Timeline



Feb 25, 2013:

11:57 PM Changeset in webkit [144014] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another fix attempt after r143991 since having \r? after a greedy match doesn't help.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.value_from_svn_info):

11:56 PM Changeset in webkit [144013] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
11:47 PM Changeset in webkit [144012] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: remove redundant update of non compositing layer.
https://bugs.webkit.org/show_bug.cgi?id=110444

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-25
Reviewed by Noam Rosenthal.

Currently, we update non compositing layer when the page scrolled. However, it
is not needed, because TiledBackingStore can scroll without tile update.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

11:42 PM Changeset in webkit [144011] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r143981): Crash in WebFrameLoaderClient::dispatchDidStartProvisionalLoad()
https://bugs.webkit.org/show_bug.cgi?id=110848

Reviewed by Ryosuke Niwa.

NULL-check the result of document->documentElement().

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

11:21 PM Changeset in webkit [144010] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784

Unreviewed.

This patch restores the code that I rolled out in
http://trac.webkit.org/changeset/143960 and
http://trac.webkit.org/changeset/143983. Rolling out those patches did
not heal the bot.

  • dom/Element.cpp:

(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore):
(WebCore::UniqueElementData::attributeItem):

  • dom/Element.h:

(ElementData):
(UniqueElementData):
(WebCore::isShadowHost):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/CSSPreloadScanner.cpp:

(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore::TokenPreloadScanner::rewindTo):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::isSafeToSendToAnotherThread):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):

11:01 PM Changeset in webkit [144009] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
10:32 PM Changeset in webkit [144008] by noel.gordon@gmail.com
  • 2 edits in trunk/Tools

GCE EWS bots failing intermittently on HTTP 502 error while updating their status
https://bugs.webkit.org/show_bug.cgi?id=110845

Unreviewed EWS bot fix.

Switch the Queue Status Server address the EWS bots use to a more direct URL that
doesn't seem to be having problems from GCE like queues.webkit.org.

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-25

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

10:24 PM TestExpectations edited by glenn@skynav.com
editorial cleanup (diff)
10:13 PM TestExpectations edited by glenn@skynav.com
editorial cleanup (diff)
10:10 PM TestExpectations edited by glenn@skynav.com
describe how to learn which expectations files apply (diff)
10:00 PM TestExpectations edited by glenn@skynav.com
editorial cleanup; add info on generic test expectations file (diff)
9:57 PM TestExpectations edited by glenn@skynav.com
editorial cleanup (diff)
9:54 PM TestExpectations edited by glenn@skynav.com
editorial cleanup (diff)
9:53 PM Changeset in webkit [144007] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

AudioDestinationChromium should pass in inputDeviceId when creating WebKit::WebAudioDevice
https://bugs.webkit.org/show_bug.cgi?id=110796

Reviewed by Kenneth Russell.

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

9:51 PM TestExpectations edited by glenn@skynav.com
clarify usage of WontFix | Skip (diff)
9:49 PM TestExpectations edited by glenn@skynav.com
ensure grammaticality (diff)
9:47 PM TestExpectations edited by glenn@skynav.com
qualify "equivalent" (diff)
9:36 PM Creating and Submitting Layout Tests and Patches edited by glenn@skynav.com
add description about using webkit-patch upload instead of svn-create-patch (diff)
9:06 PM Changeset in webkit [144006] by mark.lam@apple.com
  • 25 edits
    4 deletes in trunk/Source/WebCore

Need a more robust WebSQL disk usage computation.
https://bugs.webkit.org/show_bug.cgi?id=110805.

Reviewed by Geoffrey Garen.

  • Changed DatabaseTracker::usageForOrigin() to compute the disk usage for a specified origin by fetching database sizes from the file system instead of using cached file size values.
  • The OriginQuotaManager and OriginUsageRecord are no longer needed. Updated build files to reflect this.
  • Removed getMaxSizeForDatabase() from DatabaseManager, DatabaseServer, and AbstractDatabaseServer since it is only needed in the backend.
  • DatabaseTracker::getMaxSizeForDatabase() now calls usageForOrigin() to get the disk usage for its computation.
  • The performance difference for this changes is a 1.6% degradation per additional database whose size needs to be fetched. This is a worst case estimated based on the disk-stat-speed-test.html benchmark (attached to bugzilla). The benchmark writes an average of 16 bytes per transaction. Most real-world transactions will likely write more content than that. Since disk write IO time will dominate over memory read time for fetching the file size, the degradation ratio will only reduce with larger workloads.

No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. While the test is running, we can run a
"du -k; du -k *" on the database directory to verify that the total
disk usage does not far exceed the allowed quota (some small error
is expected). Without this change, each database from each tab may
exceed the quota by that same maginitude of error.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::maximumSize):

  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginQuotaManager.cpp: Removed.
  • Modules/webdatabase/OriginQuotaManager.h: Removed.
  • Modules/webdatabase/OriginUsageRecord.cpp: Removed.
  • Modules/webdatabase/OriginUsageRecord.h: Removed.
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):

  • Modules/webdatabase/SQLTransactionBackendSync.cpp:

(WebCore::SQLTransactionBackendSync::executeSQL):

  • Modules/webdatabase/SQLTransactionClient.cpp:
  • Modules/webdatabase/SQLTransactionClient.h:
  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
8:25 PM Changeset in webkit [144005] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r143654): some jquery test asserts on 32 bit debug build
https://bugs.webkit.org/show_bug.cgi?id=110756

Reviewed by Geoffrey Garen.

TypeOf does speculations manually, so it should mark its JSValueOperand as doing ManualOperandSpeculation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:13 PM Changeset in webkit [144004] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Upstream iOS Stack bound checking
https://bugs.webkit.org/show_bug.cgi?id=110813

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-25
Reviewed by Filip Pizlo.

On iOS, the StackBounds cannot be cached because the stack
can be in one of two threads (the web thread or the UI thread).

We simply always consider the current stack bound when testing
stack boundaries.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(BytecodeGenerator):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(JSC::Parser::canRecurse):
(Parser):

8:04 PM Changeset in webkit [144003] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[texmap] Rename TextureMapperGL::ClipStack::init to reset
https://bugs.webkit.org/show_bug.cgi?id=110783

Reviewed by Noam Rosenthal.

Functions named init() are usually called inside ctor's to initialize
member variables that were unable to be assigned on an initialization
list, which is not the case, and also because reset() better reflects
the behavior (clears the clip stack and assigns a value to the initial
clip state).

No behavior changes, thus covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::initializeDepthBuffer):

  • platform/graphics/texmap/TextureMapperGL.h:

(ClipStack):

7:18 PM Changeset in webkit [144002] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add expandedToParagraph() method to WebRange
https://bugs.webkit.org/show_bug.cgi?id=110618

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-25
Reviewed by Adam Barth.

Add a method expandedToParagraph() to WebRange to return a copy of the
range expanded to paragraph boundaries. This method is to be used to
query the spelling context around the misspelled word under cursor.

  • public/WebRange.h:

(WebRange): Added expandedToParagraph() method declaration.

  • src/WebRange.cpp:

(WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
(WebKit): Added expandedToParagraph() method definition.

7:02 PM Changeset in webkit [144001] by rniwa@webkit.org
  • 2 edits in trunk/Source/WTF

Build fix attempt after r143996.

  • wtf/FastMalloc.cpp:

(WTF):

6:36 PM Changeset in webkit [144000] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
https://bugs.webkit.org/show_bug.cgi?id=110637

Reviewed by Eric Seidel.

With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.

Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).

This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.

  • dom/DocumentParser.h:

(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

6:33 PM Changeset in webkit [143999] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Anders Carlsson.

  • English.lproj/Localizable.strings:
6:25 PM Changeset in webkit [143998] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
https://bugs.webkit.org/show_bug.cgi?id=110834

Reviewed by Adrienne Walker.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):

6:25 PM Changeset in webkit [143997] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed. Fix script to use WEBKIT_SOURCE for VS2010 property sheets instead of WEBKIT_LIBRARIES.

  • WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
6:13 PM Changeset in webkit [143996] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Add cookies to FastMalloc spans
https://bugs.webkit.org/show_bug.cgi?id=110827

Reviewed by Michael Saboff.

Add a cookie to spans, and move some of the hardening around so
that it's more useful.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF::spanInitializerCookie):
(WTF::Span::initCookie):
(WTF::Span::clearCookie):
(WTF::Span::isValid):
(Span):
(WTF::NewSpan):
(WTF::DeleteSpan):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

6:10 PM Changeset in webkit [143995] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Forgot to delete a no-longer-needed unit test after r143980.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_path_to_image_diff):

6:10 PM Changeset in webkit [143994] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

For JSVALUE32_64, maxOffsetRelativeToPatchedStorage() doesn't compute the maximum negative offset
https://bugs.webkit.org/show_bug.cgi?id=110828

Reviewed by Oliver Hunt.

  • runtime/JSObject.h:

(JSC::maxOffsetRelativeToPatchedStorage): Only add the OBJECT_OFFSETOF(tag) for positive offsets.
That way this function will return the offset farthest from 0 needed to access either the payload
or tag.

6:06 PM Changeset in webkit [143993] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Flexbox should ignore firstLetter pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=105126

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-02-25
Reviewed by Tony Chang.

Source/WebCore:

The CSS WG decided that first-line and first-letter should not
apply to flex containers.
http://dev.w3.org/csswg/css3-flexbox/issue-cr-2012#issue-13

tests:
css3/flexbox/flexbox-ignore-firstLetter.html
css3/flexbox/flexbox-ignore-container-firstLetter.html

  • rendering/RenderBlock.cpp:

(WebCore::findFirstLetterBlock):

LayoutTests:

The CSS WG decided that first-line and first-letter should not
apply to flex containers.
http://dev.w3.org/csswg/css3-flexbox/issues-cr-2012#issue-13

  • css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt: Added.
  • css3/flexbox/flexbox-ignore-container-firstLetter.html: Added.
  • css3/flexbox/flexbox-ignore-firstLetter-expected.txt: Added.
  • css3/flexbox/flexbox-ignore-firstLetter.html: Added.
  • css3/flexbox/inline-flex-crash-expected.txt:
  • css3/flexbox/inline-flex-crash2-expected.txt:
5:35 PM Changeset in webkit [143992] by zmo@google.com
  • 2 edits in branches/chromium/1410/Source/WebCore

Merge 142545

WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
https://bugs.webkit.org/show_bug.cgi?id=109508

Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.

TBR=zmo@google.com
Review URL: https://codereview.chromium.org/12334083

5:24 PM Changeset in webkit [143991] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix. run-perf-tests was reporting with revision numbers ending with \r.
Don't include \r at the end of svn info lines on Windows.

This is similar to r143839.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.value_from_svn_info):

5:22 PM Changeset in webkit [143990] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Lots of unnecessary DidLayout notifications when scrolling zoomed page with iframes
https://bugs.webkit.org/show_bug.cgi?id=110824

Reviewed by Tim Horton.

RenderWidget::setWidgetGeometry() compares the old and new frame rects to decide
if the geometry changed. However, it use implicit IntRect->LayoutRect promotion in
the comparison, and then roundedIntRect() in setting. Thus the code would think
that the geometry changed, even when the final assigned frame did not.

Fix by computing the new frame using roundedIntRect(), and using that to determine
whether the geometry changed.

No way to test DidLayout notifications in DRT/WTR.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

5:13 PM Changeset in webkit [143989] by simonjam@chromium.org
  • 10 edits
    22 moves
    3 adds in trunk

[Resource Timing] Update test suite so it can be exported to the W3C
https://bugs.webkit.org/show_bug.cgi?id=107343

Reviewed by Tony Gentilcore.

Tools:

  • Scripts/export-w3c-performance-wg-tests: Clean up output.
  • Scripts/import-w3c-performance-wg-tests:

LayoutTests:

  • http/tests/w3c/webperf/resources/webperftestharness.js: Removed unneeded functions and moved new ones to extension.
  • http/tests/w3c/webperf/resources/webperftestharnessextension.js:

(test_resource_entries):

  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html.
  • platform/chromium/TestExpectations: Moved directories...
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
5:06 PM Changeset in webkit [143988] by andersca@apple.com
  • 16 edits in trunk

Source/WebKit2: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):
Add two new API key getters.

  • UIProcess/API/C/WKPage.h:

Add a new callback and deprecate the old callback.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Make the pluginInformationDictionary a static member function of WebPageProxy so it
can be called from WebUIClient as well.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):
Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

  • UIProcess/WebPageProxy.messages.in:

Pass along more information; the frame and page URLs.

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call the new callback if it's supported.

  • UIProcess/WebUIClient.h:

(WebUIClient):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Update for API changes.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Ensure that the pluginspage attribute is a valid URL.

Tools: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):

  • WebKitTestRunner/TestController.h:

(TestController):

4:50 PM Changeset in webkit [143987] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Remove browser patching mechanism for handling javascript dialogs in chromium port
https://bugs.webkit.org/show_bug.cgi?id=110531

Patch by Ken Kania <kkania@chromium.org> on 2013-02-25
Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):

4:49 PM Changeset in webkit [143986] by jpfau@apple.com
  • 37 edits
    7 adds in trunk

Optionally partition cache to prevent using cache for tracking
https://bugs.webkit.org/show_bug.cgi?id=110269

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage

Source/WebCore:

Implement memory cache partitioning by passing the cache name through
resource requests into a new version of resourceForURL.

Test: http/tests/cache/partitioned-cache.html

  • Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
  • WebCore.exp.in: Export new functions for WKSI and test suite
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Retrofit for new resourceForRequest function

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource): Retrofit for new resourceForRequest function

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR): Retrofit for new resourceForRequest function

  • loader/DocumentLoader.h:

(DocumentLoader):
(WebCore::DocumentLoader::recordMemoryCacheLoadForFutureClientNotification): Retrofit for new resourceForRequest function
(WebCore::DocumentLoader::takeMemoryCacheLoadsForClientNotification): Retrofit for new resourceForRequest function

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache): Retrofit for new resourceForRequest function
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Retrofit for new resourceForRequest function

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Retrofit for new resourceForRequest function

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

  • loader/cache/CachedResource.h: Retrofit for new resourceForRequest function

(CachedResource):
(WebCore::CachedResource::cachePartition):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::requestResource): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::loadResource): Retrofit for new resourceForRequest function

  • loader/cache/MemoryCache.cpp:

(WebCore):
(WebCore::partitionName): Add function for determining absolute partition name
(WebCore::MemoryCache::add): Retrofit for partition mapping
(WebCore::MemoryCache::revalidationSucceeded): Retrofit for partition mapping
(WebCore::MemoryCache::resourceForURL): Call into new resourceForRequest
(WebCore::MemoryCache::resourceForRequest): Retrofit for partition mapping
(WebCore::MemoryCache::evict): Retrofit for partition mapping
(WebCore::MemoryCache::removeResourcesWithOrigin): Retrofit for partition mapping
(WebCore::MemoryCache::getOriginsWithCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeUrlFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCacheImpl): Retrofit for partition mapping
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Add function for calling removeRequestFromCacheImpl that takes a CrossThreadResourceRequestData
(WebCore::MemoryCache::getStatistics): Retrofit for partition mapping
(WebCore::MemoryCache::setDisabled): Retrofit for partition mapping

  • loader/cache/MemoryCache.h:

(MemoryCache):

  • page/SecurityOrigin.cpp:

(WebCore):
(WebCore::SecurityOrigin::cachePartition): Add function for determining the cache partition name

  • page/SecurityOrigin.h:

(SecurityOrigin):

  • platform/PublicSuffix.h: Added.

(WebCore):

  • platform/mac/PublicSuffixMac.mm: Added.

(WebCore):
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/cf/ResourceRequest.h:

(ResourceRequest):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition):
(CrossThreadResourceRequestData):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doPlatformCopyData): Pass through cache partition name
(WebCore):
(WebCore::ResourceRequest::doPlatformAdopt): Pass through cache partition name

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest): Pass through cache partition name
(WebCore::ResourceRequest::doUpdatePlatformRequest): Pass through cache partition name

Source/WebKit/mac:

Update WKSI bindings and add feature defines.

  • Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Update WKSI bindings and add feature defines.

  • Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Tools:

Add test suite for public suffix functions on Mac.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST_F):

WebKitLibraries:

Update WKSI bindings.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:

LayoutTests:

Added tests for ensuring the cache partitioning functions

  • http/tests/cache/partitioned-cache-expected.txt: Added.
  • http/tests/cache/partitioned-cache.html: Added.
  • http/tests/cache/resources/echo-cookie.cgi: Added.
  • http/tests/cache/resources/partitioned-cache-loader.html: Added.
4:44 PM Changeset in webkit [143985] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=110640

Patch by James Robinson <jamesr@chromium.org> on 2013-02-25
Reviewed by Adrienne Walker.

This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
it can be implemented by the embedder. The existing logic is left in place for now,
once the embedder side has landed WebViewImpl will be purely a pass-through.

  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::suppressCompositorScheduling):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):

4:21 PM Changeset in webkit [143984] by jer.noble@apple.com
  • 10 edits in trunk/Source

Normalize ENABLE_ENCRYPTED_MEDIA definitions across all FeatureDefines files.
https://bugs.webkit.org/show_bug.cgi?id=110806

Source/WebCore:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

  • Configurations/FeatureDefines.xcconfig:

Fix some build errors which occurred when both ENCRYPTED_MEDIA and
ENCRYPTED_MEDIA_V2 were enabled:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):

  • page/DOMWindow.idl:

Source/WebKit/mac:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

Reviewed by Alexey Proskuryakov.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

  • wtf/FeatureDefines.h:
4:12 PM Changeset in webkit [143983] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784

Reviewed by Eric Seidel.

This patch reverts http://trac.webkit.org/changeset/143014 to see if
that's the cause of the PLT regression. If it's not the cause, I'll
roll it back in.

  • dom/Element.cpp:

(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):

  • dom/Element.h:

(ElementData):
(UniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):

3:48 PM Changeset in webkit [143982] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Full screen mode should not exit when application resigns active state.
https://bugs.webkit.org/show_bug.cgi?id=106129

Reviewed by Darin Adler.

Now that full screen windows get their own full screen space, there is no reason to exit full
screen mode when the application resigns active state. Instead, the windowserver will bring the
space containing the newly active application to the foreground. The user can then swipe back
to the full screen space (or use Mission Control) to get back to the full screen window.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController windowDidLoad]): Remove the applicationDidResignActive: notification from WKFullScreenWindowController.

3:39 PM Changeset in webkit [143981] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Safari shows empty window and paints webpage in full-screen background
https://bugs.webkit.org/show_bug.cgi?id=103712

Reviewed by Darin Adler.

When canceling full screen mode due to a provisional load, exit normally instead of closing the
full screen window controller. Additionally, to ensure full screen is cancelled when the enclosing
frame around a full screen iframe is navigated, check to see if the navigating document contains
a full screen element, rather than checking whether the document itself is full screen.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

3:36 PM Changeset in webkit [143980] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: reenable multiple http shards on chromium win
https://bugs.webkit.org/show_bug.cgi?id=110814

Reviewed by Tony Chang.

The underlying bug in DumpRenderTree that was causing us to look for a
pac file and timeout under load was fixed a while ago.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.relative_test_filename):

3:32 PM Changeset in webkit [143979] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Page::m_isInWindow is uninitialized
https://bugs.webkit.org/show_bug.cgi?id=110807

Reviewed by Simon Fraser.

Ideally m_isInWindow and m_isOnscreen would default to false, and be flipped to true
when the Page is put in-window or on-screen. However, only the Mac port seems to ever
call setIsInWindow/didMoveOnscreen. So, we have to default to true and flip it to false
immediately after construction on Mac.

This is just matching the behaviour of the existing m_isOnscreen.

  • page/Page.cpp:

(WebCore::Page::Page): Initialize m_isInWindow to true.

3:02 PM Changeset in webkit [143978] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default w/ build-webkit --chromium on windows.
https://bugs.webkit.org/show_bug.cgi?id=110731

Unreviewed - TBR'ing thakis :).

  • Scripts/update-webkit-chromium:
2:58 PM Changeset in webkit [143977] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

2:38 PM Changeset in webkit [143976] by andersca@apple.com
  • 13 edits in trunk

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::pluginInformationDictionary):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didFailToInitializePlugin):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

2:27 PM Changeset in webkit [143975] by eric@webkit.org
  • 8 edits
    18 copies
    11 moves
    28 adds
    44 deletes in trunk/LayoutTests

Move html5lib/run-test* into html5lib/generated in preparation for generating these harnesses
https://bugs.webkit.org/show_bug.cgi?id=110795

Reviewed by Ojan Vafai.

  • html5lib/generated/run-template-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-template.html: Added.
  • html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/html5lib/run-test7-expected.txt.
  • html5lib/generated/run-tests1.html: Added.
  • html5lib/generated/run-tests10-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests10.html: Added.
  • html5lib/generated/run-tests11-expected.txt: Renamed from LayoutTests/html5lib/run-test11-expected.txt.
  • html5lib/generated/run-tests11.html: Added.
  • html5lib/generated/run-tests12-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests12.html: Added.
  • html5lib/generated/run-tests14-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests14.html: Added.
  • html5lib/generated/run-tests15-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests15.html: Added.
  • html5lib/generated/run-tests16-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests16.html: Added.
  • html5lib/generated/run-tests17-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests17.html: Added.
  • html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/html5lib/run-test18-expected.txt.
  • html5lib/generated/run-tests18.html: Added.
  • html5lib/generated/run-tests19-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests19.html: Added.
  • html5lib/generated/run-tests2-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests2.html: Added.
  • html5lib/generated/run-tests20-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests20.html: Added.
  • html5lib/generated/run-tests21-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests21.html: Added.
  • html5lib/generated/run-tests22-expected.txt: Renamed from LayoutTests/html5lib/run-test10-expected.txt.
  • html5lib/generated/run-tests22.html: Added.
  • html5lib/generated/run-tests23-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests23.html: Added.
  • html5lib/generated/run-tests24-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests24.html: Added.
  • html5lib/generated/run-tests25-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests25.html: Added.
  • html5lib/generated/run-tests26-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests26.html: Added.
  • html5lib/generated/run-tests3-expected.txt: Renamed from LayoutTests/html5lib/run-test14-expected.txt.
  • html5lib/generated/run-tests3.html: Added.
  • html5lib/generated/run-tests4-expected.txt: Renamed from LayoutTests/html5lib/run-test12-expected.txt.
  • html5lib/generated/run-tests4.html: Added.
  • html5lib/generated/run-tests5-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests5.html: Added.
  • html5lib/generated/run-tests6-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests6.html: Added.
  • html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/html5lib/run-test1-expected.txt.
  • html5lib/generated/run-tests7.html: Added.
  • html5lib/generated/run-tests8-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests8.html: Added.
  • html5lib/generated/run-tests9-expected.txt: Renamed from LayoutTests/html5lib/run-template-expected.txt.
  • html5lib/generated/run-tests9.html: Added.
  • html5lib/run-template.html: Removed.
  • html5lib/run-test1.html: Removed.
  • html5lib/run-test10.html: Removed.
  • html5lib/run-test11.html: Removed.
  • html5lib/run-test12.html: Removed.
  • html5lib/run-test14.html: Removed.
  • html5lib/run-test15-expected.txt: Removed.
  • html5lib/run-test15.html: Removed.
  • html5lib/run-test16-expected.txt: Removed.
  • html5lib/run-test16.html: Removed.
  • html5lib/run-test17-expected.txt: Removed.
  • html5lib/run-test17.html: Removed.
  • html5lib/run-test18.html: Removed.
  • html5lib/run-test19-expected.txt: Removed.
  • html5lib/run-test19.html: Removed.
  • html5lib/run-test2-expected.txt: Removed.
  • html5lib/run-test2.html: Removed.
  • html5lib/run-test20-expected.txt: Removed.
  • html5lib/run-test20.html: Removed.
  • html5lib/run-test21-expected.txt: Removed.
  • html5lib/run-test21.html: Removed.
  • html5lib/run-test22-expected.txt: Removed.
  • html5lib/run-test22.html: Removed.
  • html5lib/run-test23-expected.txt: Removed.
  • html5lib/run-test23.html: Removed.
  • html5lib/run-test24-expected.txt: Removed.
  • html5lib/run-test24.html: Removed.
  • html5lib/run-test25-expected.txt: Removed.
  • html5lib/run-test25.html: Removed.
  • html5lib/run-test26-expected.txt: Removed.
  • html5lib/run-test26.html: Removed.
  • html5lib/run-test3-expected.txt: Removed.
  • html5lib/run-test3.html: Removed.
  • html5lib/run-test4-expected.txt: Removed.
  • html5lib/run-test4.html: Removed.
  • html5lib/run-test5-expected.txt: Removed.
  • html5lib/run-test5.html: Removed.
  • html5lib/run-test6-expected.txt: Removed.
  • html5lib/run-test6.html: Removed.
  • html5lib/run-test7.html: Removed.
  • html5lib/run-test8-expected.txt: Removed.
  • html5lib/run-test8.html: Removed.
  • html5lib/run-test9-expected.txt: Removed.
  • html5lib/run-test9.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test7-expected.txt.
  • platform/chromium/html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test18-expected.txt.
  • platform/chromium/html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test1-expected.txt.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:21 PM Changeset in webkit [143974] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r143965.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedConstructorCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor):

2:15 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
2:12 PM Changeset in webkit [143973] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for gtk2-based library.

Reviewed by Martin Robinson.

  • platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h

include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.

2:06 PM Changeset in webkit [143972] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r143936.
http://trac.webkit.org/changeset/143936
https://bugs.webkit.org/show_bug.cgi?id=110789

Causes webkit_unit_tests failures on android dbg (Requested by
vollick on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-25

Source/WebCore:

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageDecoder.h:

(GIFImageDecoder):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::doLZW):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/GIFImageDecoderTest.cpp: Removed.
  • tests/data/broken.gif: Removed.
1:48 PM Changeset in webkit [143971] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.9/Source/WebKit2

Merged r143829. <rdar://problem/13236883>

1:47 PM Changeset in webkit [143970] by roger_fong@apple.com
  • 4 edits in trunk/Source

Unreviewed. VS2010 solution build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
1:44 PM Changeset in webkit [143969] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.9/Source

Versioning.

1:40 PM Changeset in webkit [143968] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.9

New Tag.

1:31 PM Changeset in webkit [143967] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Generate a wrapper function for method callbacks
https://bugs.webkit.org/show_bug.cgi?id=110769

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxMethod(), like this:

For non-custom methods
void xxxMethodCallback(...) {

xxxMethod(...);

}

For custom methods
void xxxMethodCallback(...) {

return xxxMethodCustom(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethodCallback):
(Float64ArrayV8Internal):
(WebCore::Float64ArrayV8Internal::setMethodCallback):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethodCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethodCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethodCallback):
(TestCustomNamedGetterV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemMethodCallback):
(TestEventTargetV8Internal):
(WebCore::TestEventTargetV8Internal::addEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod1MethodCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalMethod2MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod3MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod4MethodCallback):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodMethodCallback):
(TestMediaQueryListListenerV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::longMethodMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceMethodCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethodCallback):
(WebCore::TestObjV8Internal::serializedValueMethodCallback):
(WebCore::TestObjV8Internal::optionsObjectMethodCallback):
(WebCore::TestObjV8Internal::methodWithExceptionMethodCallback):
(WebCore::TestObjV8Internal::customMethodMethodCallback):
(WebCore::TestObjV8Internal::customMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::addEventListenerMethodCallback):
(WebCore::TestObjV8Internal::removeEventListenerMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethodCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod1MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod2MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod3MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethodCallback):
(WebCore::TestObjV8Internal::classMethod2MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1MethodCallback):
(WebCore::TestObjV8Internal::classMethodWithClampMethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2MethodCallback):
(WebCore::TestObjV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestObjV8Internal::domStringListFunctionMethodCallback):
(WebCore::TestObjV8Internal::getSVGDocumentMethodCallback):
(WebCore::TestObjV8Internal::convert1MethodCallback):
(WebCore::TestObjV8Internal::convert2MethodCallback):
(WebCore::TestObjV8Internal::convert4MethodCallback):
(WebCore::TestObjV8Internal::convert5MethodCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::orangeMethodCallback):
(WebCore::TestObjV8Internal::strictFunctionMethodCallback):
(WebCore::TestObjV8Internal::variadicStringMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethodCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethodCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethodCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::multiTransferListMethodCallback):
(WebCore::TestTypedefsV8Internal::setShadowMethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethodCallback):
(WebCore::TestTypedefsV8Internal::funcWithClampMethodCallback):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2MethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):

1:29 PM Changeset in webkit [143966] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Remove two stale entries from TestExpectations

Unreviewed patch of test expectations.

  • platform/chromium/TestExpectations:
1:28 PM Changeset in webkit [143965] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Generate a wrapper method for constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=110765

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for constructor(), like this:

For non-custom constructors
void constructorCallback(...) {

return constructor(...);

}

For custom constructors
void constructorCallback(...) {

return constructorCustom(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateConstructor):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateNamedConstructor):
(GenerateConstructorHeader):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::constructor):
(Float64ArrayV8Internal):
(WebCore::V8Float64Array::constructorCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::constructor):
(WebCore):
(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::constructor):
(TestInterfaceV8Internal):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::TestNodeV8Internal::constructor):
(TestNodeV8Internal):
(WebCore::V8TestNode::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::constructor):
(TestObjV8Internal):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor4):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore):
(WebCore::V8TestOverloadedConstructors::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::constructor):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::constructor):
(TestTypedefsV8Internal):
(WebCore::V8TestTypedefs::constructorCallback):

1:26 PM Changeset in webkit [143964] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Generate xxxAttrSetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110726

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings.
This patch introduces an indirection function for xxxAttrSetter(), like this:

For non-custom setters
void xxxAttrSetterCallback(...) {

xxxAttrSetter(...);

}

For custom setters.
void xxxAttrSetterCallback(...) {

return xxxAttrSetterCustom(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::createAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallback):
(WebCore::TestObjV8Internal::idAttrSetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore):

1:24 PM Changeset in webkit [143963] by pdr@google.com
  • 16 edits in trunk/LayoutTests

Rebaseline 3 svg/as-image/ tests

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
1:16 PM Changeset in webkit [143962] by timothy_horton@apple.com
  • 8 edits in trunk/Source/WebKit2

PDFPlugin: Tab between text annotations
https://bugs.webkit.org/show_bug.cgi?id=106539
<rdar://problem/12751789>

Reviewed by Darin Adler.

Use [PDFLayerController activateNextAnnotation:] to advance focus when the tab key is hit while inside a PDF form.

Also, a drive-by fix to make the lifetime of PDFPluginAnnotationEventListener's m_annotation pointer more explicit.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add activateNextAnnotation: SPI.
  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add focus(Next|Previous)Annotation.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::focusNextAnnotation): Ask PDFLayerController to focus the next annotation.
(WebKit::PDFPlugin::focusPreviousAnnotation): Ask PDFLayerController to focus the next annotation.

  • WebProcess/Plugins/PDF/PDFPluginAnnotation.h: Drive-by, initialize m_parent to 0.

(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::setAnnotation): Added.

  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach): Use eventNames() instead of string literals.
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation): Clear the event listener's reference to its annotation.
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent): Null-check the event listener's annotation.

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:

(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotation): Create our PDFPluginTextAnnotationEventListener.
(PDFPluginTextAnnotationEventListener): Added an event listener (for keydown events in form fields).
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::create):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::setTextAnnotation):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::PDFPluginTextAnnotationEventListener):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation): Unregister our keydown event listener.
(WebKit::PDFPluginTextAnnotation::createAnnotationElement): Register our keydown event listener.
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::handleEvent): Ask PDFPlugin to focus
the next/previous annotation when the tab key is pressed (Shift-Tab goes backwards).

1:13 PM Changeset in webkit [143961] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for Debug.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

12:58 PM Changeset in webkit [143960] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784

Reviewed by Eric Seidel.

This patch attempts to heal the regression by reverting all the changes
to the preload scanner up to (and including)
http://trac.webkit.org/changeset/143020/.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):

12:54 PM Changeset in webkit [143959] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12976385> Remove rule to silence attempts to create the ~/Library/Caches/com.apple.WebKit2.WebProcessService directory

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb.in: Remove the obsolete rule. We no longer have a "WebProcessService".
12:48 PM Changeset in webkit [143958] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::Edge should have more bits for UseKind, and DFG::Allocator should be simpler
https://bugs.webkit.org/show_bug.cgi?id=110722

Reviewed by Oliver Hunt.

This rolls out the DFG::Allocator part of http://trac.webkit.org/changeset/143654,
and changes Edge to have more room for UseKinds and possibly other things.

This is performance-neutral on both 32-bit and 64-bit. It reduces the size of
DFG::Node on 64-bit (by virtue of getting rid of the 16-byte alignment of Node)
and increases it slightly on 32-bit (by 4 bytes total - 16-byte alignment led to
80 bytes, but the base size of Node plus the 12 bytes of new m_encodedWords in
Edge gets 84 bytes). But, it will mean that we don't have to increase Node by
another 16 bytes if we ever want to add more UseKinds or other things to Edge.

  • dfg/DFGAllocator.h:

(DFG):
(Allocator):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::Edge):
(Edge):
(JSC::DFG::Edge::node):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(JSC::DFG::Edge::makeWord):

  • dfg/DFGNodeAllocator.h:

(DFG):

12:27 PM Changeset in webkit [143957] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1410

Merge 143640

Stop starting animations when leaving a page
https://bugs.webkit.org/show_bug.cgi?id=110257

Reviewed by Stephen Chenney.

Source/WebCore:

SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().

Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.

Both of these changes are functionally covered with existing tests.

Test: svg/animations/reset-animation-crash.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::resetAnimation):

LayoutTests:

  • svg/animations/reset-animation-crash-expected.html: Added.
  • svg/animations/reset-animation-crash.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12310113

12:23 PM Changeset in webkit [143956] by pdr@google.com
  • 12 edits
    6 copies in branches/chromium/1410

Merge 142765

Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159

Reviewed by Tim Horton.

Source/WebCore:

This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/

On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):

without patch: ~20FPS
with patch: ~55FPS

The bitmap SVG image cache had several shortcomings:

  • The bitmap cache prevented viewport rendering. (WK104693)
  • Bitmap memory usage was high. (WK106484)
  • Caching animating images was expensive.

This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

Tests: svg/as-image/svg-image-scaled.html

svg/as-image/svg-image-viewbox.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):

SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):

drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:

the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed

SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.

(WebCore::SVGImage::drawPatternForContainer):

For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.

(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):

  • svg/graphics/SVGImage.h:

(WebCore):
(SVGImage):

  • svg/graphics/SVGImageCache.cpp:

Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.

To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.

Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.

(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):

Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.

(WebCore::SVGImageCache::imageForRenderer):

A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

  • svg/graphics/SVGImageForContainer.cpp: Added.

(WebCore):

SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.

(WebCore::SVGImageForContainer::size):

This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h: Added.

(WebCore):
(SVGImageForContainer):

In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

LayoutTests:

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

  • platform/chromium/TestExpectations:
  • svg/as-image/svg-image-scaled-expected.html: Added.
  • svg/as-image/svg-image-scaled.html: Added.
  • svg/as-image/svg-image-viewbox-expected.html: Added.
  • svg/as-image/svg-image-viewbox.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12319101

12:23 PM Changeset in webkit [143955] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

The DFG special case checks for isCreatedThisArgument are fragile
https://bugs.webkit.org/show_bug.cgi?id=110535

Reviewed by Oliver Hunt.

There may be many situations in which we want to force a variable to never be
unboxed. Capturing is one such case, and the created this argument is another.
Previously all code that dealt with this issue had to query both scenarios.

Now DFG::VariableAccessData knows these things. You just have to ask
VariableAccessData for whether a variable should be unboxed. Anyone wishing to
force a variable to never be unboxed just tells VariableAccessData.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):

  • dfg/DFGCFGSimplificationPhase.cpp:

(CFGSimplificationPhase):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(JSC::DFG::VariableAccessData::mergeShouldNeverUnbox):
(VariableAccessData):
(JSC::DFG::VariableAccessData::shouldNeverUnbox):
(JSC::DFG::VariableAccessData::shouldUnboxIfPossible):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):

11:50 AM FeatureFlags edited by Laszlo Gombos
CSS_REGIONS - see r88148 (diff)
11:36 AM Changeset in webkit [143954] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Changed DatabaseTracker::getMaxSizeForDatabase() to return the previous
database size instead of 0 when the quota limit has been reached.
https://bugs.webkit.org/show_bug.cgi?id=110557.

Reviewed by Geoffrey Garen.

Testing of concurrent multi-process consumption of database quota shows that
returning a value of 0 when the quota is exceeded still allows some databases
to run away with unbounded growth. However, if getMaxSizeForDatabase() returns
the existing database size, the underlying sqlite3 database will successfully
reject new growth.

The value returned by DatabaseTracker::getMaxSizeForDatabase() is used to set
the SQLite3 database size using a sql command "PRAGMA max_page_count = <size>".
The SQLite3 documentation on this pragma says, "The maximum page count cannot
be reduced below the current database size."

It is undefined what setting it to a reduced size will do. So, we're changing
getMaxSizeForDatabase() to return the existing size instead.

No new tests.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

11:29 AM Changeset in webkit [143953] by thakis@chromium.org
  • 2 edits in trunk/Tools

Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
https://bugs.webkit.org/show_bug.cgi?id=110775

Unreviewed, basically a rebaseline.

  • Scripts/webkitpy/common/config/watchlist:
11:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
11:27 AM Changeset in webkit [143952] by Carlos Garcia Campos
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-2.0

Merge r143931 - [soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
  • http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
  • http/tests/cookies/set-cookie-on-redirect.html: Added.
11:23 AM Changeset in webkit [143951] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] Try to get the webkit builder to use msvs again
https://bugs.webkit.org/show_bug.cgi?id=110771

Reviewed by Eric Seidel.

The msvs gyp generator apparently doesn't write the sln file on every
run, so check the vcxproj file instead.

  • Scripts/webkitdirs.pm:

(determineIsChromiumNinja):

11:14 AM Changeset in webkit [143950] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Refactor logic for relaying out children out of RenderBlock::styleDidChange
https://bugs.webkit.org/show_bug.cgi?id=110661

Reviewed by David Hyatt.

Instead of having styleDidChange need to know which children to mark as needing layout,
use a bool to keep track of border and padding width changes so at layout time, we know
we need to set relayoutChildren=true.

We steal a bit from m_lineHeight reducing the possible line height from around 500 million pixels
to 250 million pixels.

No new tests, this should be covered by fast/block/positioning/border-change-relayout-test.html and
fast/block/dynamic-padding-border.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock): Fix indent and initialize m_hasBorderOrPaddingLogicalWidthChanged.
(WebCore::RenderBlock::styleDidChange): Remove logic for setting children as needing layout.
(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth): Return true if border or padding width changed.

  • rendering/RenderBlock.h:

(RenderBlock): Steal a bit from m_lineHeight and give it to m_hasBorderOrPaddingLogicalWidthChanged.

10:56 AM Changeset in webkit [143949] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Do one lookup per code cache insertion instead of two
https://bugs.webkit.org/show_bug.cgi?id=110674

Reviewed by Sam Weinig.

Deployed the idiomatic "add null value" trick to avoid a second hash
lookup when inserting an item.

  • runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): Factored this into a helper function
to improve clarity and get some code off the hot path.

(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Use the add() API
to avoid two hash lookups. Be sure to remove items if parsing fails,
otherwise we'll leave nulls in the table. (I'm guessing that caching parse
errors is not a win.)

  • runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(CodeCacheMap):
(JSC::CodeCacheMap::add): Combined find() and set() into add().

(JSC::CodeCacheMap::remove):
(JSC::CodeCacheMap::age):
(JSC::CodeCacheMap::prune): Refactored to support above changes.

10:56 AM Changeset in webkit [143948] by alexis@webkit.org
  • 5 edits in trunk

transition-property property doesn't accept "all, <IDENT>".
https://bugs.webkit.org/show_bug.cgi?id=110074

Reviewed by Dean Jackson.

Source/WebCore:

http://dev.w3.org/csswg/css3-transitions/#transition-property-property
allows all, <IDENT> as a value for the transition-property property. In
fact thanks to http://trac.webkit.org/changeset/143019 we correctly
implemented that behavior for transition shorthand property while
fixing bugs on the previous implementation. We did introduce a
AnimationParseContext to track whether the parsing of the
transition-property was finished or not in relation to the keyword.
This patch extend that mechanism to the longhand by renaming the
boolean and the functions to use it in the context class and set it
correctly while parsing the longhand property.

Test: LayoutTests/transitions/transitions-parsing.html

  • css/CSSParser.cpp:

(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitAnimationPropertyKeyword):
(WebCore::AnimationParseContext::animationPropertyKeywordAllowed):
(AnimationParseContext):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty): We can remove the
condition inShorthand() here, if 'none' is parsed then no more keyword
can appear, if 'all' is parsed then we can continue the parsing but
invalidate the property if another keyword is encountered. These
conditions are valid for the shorthand and the longhand.

LayoutTests:

Extend exising test to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:39 AM Changeset in webkit [143947] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Texmap] LayoutTests/compositing/animation/state-at-end-event-transform-layer.html shows a red square where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=110685

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-02-25
Reviewed by Martin Robinson.

Removed m_shouldUpdateCurrentTransformFromGraphicsLayer etc., as they don't do
what they're supposed to do. No flickers observed.

LayoutTests/compositing/animation/state-at-end-event-transform-layer.html now works correctly.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setAnimatedTransform):
(WebCore::TextureMapperLayer::setAnimatedOpacity):
(WebCore::TextureMapperLayer::setAnimatedFilters):
(WebCore::TextureMapperLayer::syncAnimations):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):

10:27 AM Changeset in webkit [143946] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
https://bugs.webkit.org/show_bug.cgi?id=110767

Reviewed by Eric Seidel.

The tester runs gyp, which generates out/Release/build.ninja. The bot
scripts use existence (and timestamp) of that file to decide if the
current build is supposed to be ninja or xcodebuild. The file exists,
so the snapshot is extracted to out/Release. The snapshot doesn't
contain build.ninja however due to
http://trac.webkit.org/changeset/140375 , so after extracting the
snapshot the scripts think that this is an xcodebuild build. So remove
the part of that revision that removed ninja files from the archive,
and the bots should be happy again.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

10:24 AM Changeset in webkit [143945] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

AVFoundation.framework and QTKit.framework are lazy-loaded on every WebProcess launch
https://bugs.webkit.org/show_bug.cgi?id=110725

Reviewed by Eric Carlson.

When settings are changed, do not re-query the media engines (which causes their respective
frameworks to load). Instead, merely clear any previously loaded media engines so that
the media engine list will be re-queried the next time installedMediaEngines() is called.

(WebCore::MediaPlayer::resetMediaEngines): Renamed from requeryMediaEngines.

  • platform/graphics/MediaPlayer.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::resetMediaEngines): Ditto.

  • html/HTMLMediaElement.h:
  • page/Settings.cpp:

(WebCore::Settings::setAVFoundationEnabled): Call renamed method.
(WebCore::Settings::setQTKitEnabled): Ditto.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Only clear out previously queried engines.

10:21 AM Changeset in webkit [143944] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows gyp build after r143937

  • WebCore.gypi: Update the filename in the source list.
10:13 AM Changeset in webkit [143943] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add isInputMode() method to WebPage class.
https://bugs.webkit.org/show_bug.cgi?id=110754

Patch by Yongxin Dai <yodai@rim.com> on 2013-02-25
Reviewed by Rob Buis.

PR #262569.

There is a case we need to know if the active node is content editable
from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
InputHandler::isInputMode().

Reviewed Internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isInputMode):
(WebKit):

  • Api/WebPage.h:
10:10 AM Changeset in webkit [143942] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Force form submission when implicit submission fails.
https://bugs.webkit.org/show_bug.cgi?id=110627

Reviewed by Rob Buis.

PR 286023.

When implicit form submission does not submit the form
do a direct submission of the form.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

10:08 AM Changeset in webkit [143941] by jchaffraix@webkit.org
  • 8 edits in trunk/Source/WebCore

[CSS Grid Layout] Refactor RenderStyle's grid position storage in preparation to supporting spanning
https://bugs.webkit.org/show_bug.cgi?id=110651

Reviewed by Ojan Vafai.

The current code stores grid-{row|column} as a single GridPosition value. While this works well currently,
we want to be able to handle 2 GridPosition as this enables row / column spanning.

That's what this refactoring achieves: it replaces the internal storage by a GridPositions that contains a
single GridPosition for now. The rest is mechanical updates.

Refactoring covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPositions):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the simple wrapper valueForGridPositions and updated the rest of the code.

  • css/StyleResolver.cpp:

(WebCore::createGridPositions):
(WebCore::StyleResolver::applyProperty):
Ditto with createGridPositions.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionsForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionsForChild):
Updated the code after adding the indirection: s/GridPosition/GridPositions/ and
use the firstPosition helper.

  • rendering/RenderGrid.h:
  • rendering/style/GridPosition.h:

(WebCore::GridPositions::GridPositions):
(WebCore::GridPositions::firstPosition):
(WebCore::GridPositions::operator==):
Added this class to add the indirection. For now, it only wraps the single GridPosition.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.h:

Updated to store / take / return a GridPositions.

10:02 AM Changeset in webkit [143940] by Dimitri Glazkov
  • 13 edits in trunk/Source/WebCore

Revert r143840 because it caused flaky crashes.
https://bugs.webkit.org/show_bug.cgi?id=110766

9:57 AM Changeset in webkit [143939] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Remove an obsolete workaround for relaxing 3rd party cookie policy
https://bugs.webkit.org/show_bug.cgi?id=110664

Reviewed by Benjamin Poulain.

Removed shouldRelaxThirdPartyCookiePolicy(). This workaround is no longer needed,
because CFNetwork performs the same check starting with 10.6.8.

Also, the workaround was not quite correct and harmful for performance, as it
was always changing main document URL to an untrue value, which caused ResourceRequest
regeneration.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

9:47 AM Changeset in webkit [143938] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

WebInspector: Do not keep track of resources unless they have a valid loader identifier.
https://bugs.webkit.org/show_bug.cgi?id=110761

Reviewed by Pavel Feldman.

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::reuseXHRReplayData):
(WebCore::NetworkResourcesData::resourceDataForRequestId):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(NetworkResourcesData):

9:30 AM Changeset in webkit [143937] by commit-queue@webkit.org
  • 4 edits
    1 move
    1 add in trunk/Source/WebCore

[EFL][GTK] Move text selection/focus notification for a11y from gtk to atk directory
https://bugs.webkit.org/show_bug.cgi?id=110221

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2013-02-25
Reviewed by Martin Robinson.

Share implementation between efl and gtk.
Update build with changes made.

  • GNUmakefile.list.am: Change WebCore/editing/gtk/FrameSelectionGtk.cpp to WebCore/editing/atk/FrameSelectionAtk.cpp to build.
  • PlatformEfl.cmake: Add WebCore/editing/atk to include directories, add Webcore/editing/atk/FrameSelectionAtk.cpp to build.
  • editing/FrameSelection.h: Omit notifyAccessibilityForSelectionChange() stub for EFL port.

(WebCore):

  • editing/atk/FrameSelectionAtk.cpp: Renamed from Source/WebCore/editing/gtk/FrameSelectionGtk.cpp.

(WebCore):
(WebCore::emitTextSelectionChange):
(WebCore::maybeEmitTextFocusChange):
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

9:27 AM Changeset in webkit [143936] by hclam@chromium.org
  • 8 edits
    2 adds in trunk/Source

GIFImageReader to read from source data directly
https://bugs.webkit.org/show_bug.cgi?id=109662

Reviewed by Stephen White.

Source/WebCore:

This is the first patch to improve GIF image decoding.

GIFImageReader has an internal 256 bytes buffer to saving incoming
bytes. This mechanism is out-dated because WebKit holds the entire
file in memory and it is not necessary to hold data in an intermediate
buffer.

This is also a blocker for later work to parse and decode GIF
incrementally.

This change removed the imtermediate 'hold' buffer and uses an index
for data position to keep track of parsing of the GIF file. Buffer for
global colormap and local colormap are also removed because they can be
referenced from the data stream.

This change is tested by:

Layout tests
All tests passed under fast/images.

Unit tests
Added GIFImageDecoderTest for Chromium.

Local testing
I tested this implementation against a set of 50k GIF images and
there's no crashes and produces bit-exact results as previous code.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::doLZW):
(GIFImageReader::decode):
(GIFImageReader::decodeInternal):
(GIFImageReader::setRemainingBytes):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::setData):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::localColormap):
(GIFImageReader::localColormapSize):
(GIFImageReader::data):
(GIFImageReader::colormap):

Source/WebKit/chromium:

Added the following unit tests to test new logic in GIFImageDecoder:

GIFImageDecoderTest.decodeTwoFrames
Test that it can decode a multi-frame GIF image correctly.

GIFImageDecoderTest.parseAndDecode
First perform a parse operation and then a decode operation. Expect
that parse and decode operates correctly.

GIFImageDecoderTest.parseByteByByte
Test that multi-frame GIF image can be parsed correctly byte by byte.

GIFImageDecoderTest.parseAndDecodeByteByByte
Run a loop to feed decoder byte by byte, perform a parse and then
decode operation and make sure frames are decoded correctly.

GIFImageDecoderTest.brokenSecondFrame
Decode a GIF image with second frame broken. Expect that the first
frame can be decoded correctly.

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/GIFImageDecoderTest.cpp: Added.

(WebKit):
(WebKit::readFile):
(WebKit::TEST):

  • tests/data/broken.gif: Added.
9:14 AM Changeset in webkit [143935] by abecsi@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Remove unneeded method didResumeContent from PageViewportController clients
https://bugs.webkit.org/show_bug.cgi?id=110751

Reviewed by Jocelyn Turcotte.

This is a clean-up in the PageViewportController clients that removes leftover
code from previous design that is partially unused and unnecessary, to simplify
the interaction between PageViewportController and clients.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::resumeContent):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:
  • UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::resumeAndUpdateContent):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

9:05 AM Changeset in webkit [143934] by peter@chromium.org
  • 20 edits
    2 copies in branches/chromium/1410

Merge 143356

Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

  • page/Settings.cpp:

(WebCore::Settings::setTextAutosizingFontScaleFactor):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):

  • rendering/TextAutosizer.h:

(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

  • fast/text-autosizing/constrained-height-body-expected.html:
  • fast/text-autosizing/constrained-height-body.html:
  • fast/text-autosizing/constrained-then-float-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-float-ancestors.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
  • fast/text-autosizing/nested-em-line-height-expected.html:
  • fast/text-autosizing/nested-em-line-height.html:
  • fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
  • fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
  • fast/text-autosizing/simple-paragraph-expected.html:
  • fast/text-autosizing/simple-paragraph.html:
  • fast/text-autosizing/span-child-expected.html:
  • fast/text-autosizing/span-child.html:
  • fast/text-autosizing/unwrappable-blocks-expected.html:
  • fast/text-autosizing/unwrappable-blocks.html:
  • fast/text-autosizing/unwrappable-inlines-expected.html:
  • fast/text-autosizing/unwrappable-inlines.html:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12310107

8:59 AM Changeset in webkit [143933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size.
https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-25
Reviewed by Rob Buis.

Fix a typo in function names.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

8:56 AM Changeset in webkit [143932] by peter@chromium.org
  • 4 edits in branches/chromium/1410

Merge 143318

[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825

Source/WebCore:

Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Updated the existing test to verify the patch.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.

(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):

Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.

  • rendering/TextAutosizer.h:

New method definitions.

LayoutTests:

Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

  • fast/text-autosizing/narrow-descendants-combined-expected.html:
  • fast/text-autosizing/narrow-descendants-combined.html:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12317102

8:56 AM Changeset in webkit [143931] by sergio@webkit.org
  • 3 edits
    3 adds in trunk

[soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
  • http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
  • http/tests/cookies/set-cookie-on-redirect.html: Added.
8:52 AM Changeset in webkit [143930] by peter@chromium.org
  • 2 edits
    2 copies in branches/chromium/1410

Merge 142866

[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573

Source/WebCore:

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.

Test: fast/text-autosizing/narrow-descendants-combined.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.

(WebCore::TextAutosizer::processCluster):

Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.

(WebCore::TextAutosizer::processCompositeCluster):

Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

Calls the multiple renderers version to avoid code duplication.

(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):

The multiple renderers version of clusterShouldBeAutosized.

  • rendering/TextAutosizer.h:

Updated method declarations.

LayoutTests:

Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

  • fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
  • fast/text-autosizing/narrow-descendants-combined.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12326104

8:51 AM Changeset in webkit [143929] by thakis@chromium.org
  • 2 edits in trunk/Tools

Fix tests after r143910
https://bugs.webkit.org/show_bug.cgi?id=110757

Reviewed by Andreas Kling.

While here, also add a test for the bug r143910 fixed.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ScriptErrorTest.test_message_with_output):
(ScriptErrorTest):
(ScriptErrorTest.test_message_with_tuple):

8:46 AM Changeset in webkit [143928] by peter@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp

Merge 142534

[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054

Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.

No behavioral changes thus no new tests or test changes.

  • rendering/TextAutosizer.cpp:

(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):

Remember narrow descendants of the parent cluster for later processing.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12315083

8:09 AM Changeset in webkit [143927] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] Apparently built-product-archive is written in Python, not Perl :-/
https://bugs.webkit.org/show_bug.cgi?id=110755

Reviewed by Jochen Eisinger.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

7:51 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
7:50 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
7:49 AM Changeset in webkit [143926] by akling@apple.com
  • 52 edits in trunk/Source

Reduce amount of code that includes StylePropertySet.h
<http://webkit.org/b/101149>

Reviewed by Antti Koivisto.

Source/WebCore:

StylePropertySet.h and dependents were getting included by the majority of WebKit
through either StyledElement.h or CSSStyleDeclaration.h. This change removes those includes
and moves inclusion to .cpp files instead. After this change, it's possible to hack most
of WebCore/css/ and rebuild <100 files instead of >1000.

The only real code change in here is changing CSSStyleDeclaration::cssPropertyMatches()
to take a CSSPropertyID/CSSValue* combo instead of a StylePropertySet::Reference.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

  • css/PropertySetCSSStyleDeclaration.h:
  • css/SelectorChecker.h:
  • css/SelectorCheckerFastPath.cpp:
  • css/SelectorFilter.cpp:
  • css/SelectorFilter.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):

  • css/StylePropertySet.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):

  • css/StyleResolver.h:

(MatchedProperties):

  • css/StyleRule.cpp:
  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::~ViewportStyleResolver):

  • css/ViewportStyleResolver.h:

(ViewportStyleResolver):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::StyleKeyframe):
(WebCore::StyleKeyframe::~StyleKeyframe):

  • css/WebKitCSSKeyframeRule.h:

(StyleKeyframe):

  • dom/Attr.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):

  • editing/FrameSelection.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):

  • editing/RemoveCSSPropertyCommand.h:

(RemoveCSSPropertyCommand):

  • editing/RemoveFormatCommand.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFontElement.cpp:
  • html/HTMLHRElement.cpp:
  • html/HTMLPreElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/canvas/CanvasStyle.cpp:
  • html/shadow/MediaControlElementTypes.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • page/PageSerializer.cpp:
  • rendering/RenderTableCell.cpp:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGElementRareData.h:
  • svg/SVGFontFaceElement.cpp:

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:
  • WebView/WebFrame.mm:
  • WebView/WebView.mm:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
7:46 AM Changeset in webkit [143925] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip asserting tests.
https://bugs.webkit.org/show_bug.cgi?id=110756

  • platform/qt/TestExpectations:
7:42 AM Changeset in webkit [143924] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r143895.
http://trac.webkit.org/changeset/143895
https://bugs.webkit.org/show_bug.cgi?id=110758

broke a bunch of tests (Requested by thakis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-25

  • Scripts/update-webkit-chromium:
7:22 AM Changeset in webkit [143923] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Web Inspector: Remove CPU profile from a group causes exception
https://bugs.webkit.org/show_bug.cgi?id=110466

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

WebInspector.ProfilesPanel._removeProfileHandle did not handle
profile removal from a group. The fix takes care of this case.

Test: inspector/profiler/cpu-profiler-profile-removal.html

Source/WebCore:

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

LayoutTests:

  • inspector/profiler/cpu-profiler-profile-removal-expected.txt: Added.
  • inspector/profiler/cpu-profiler-profile-removal.html: Added.
7:15 AM Changeset in webkit [143922] by yoli@rim.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Edit my personal info.

  • Scripts/webkitpy/common/config/committers.py:
7:10 AM Changeset in webkit [143921] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.

  • src/js/Tests.js:

(.TestSuite.prototype.testPageOverlayUpdate.step2):

6:53 AM Changeset in webkit [143920] by mkwst@chromium.org
  • 3 edits
    1 copy
    1 move
    40 adds
    13 deletes in trunk/LayoutTests

XSSAuditor tests shouldn't depend on IFrames's load order.
https://bugs.webkit.org/show_bug.cgi?id=110737

Reviewed by Jochen Eisinger.

Various tests under http/tests/security/xssAuditor actually wrap up
multiple test cases under a single HTML file by loading a variety of
IFrames. Currently, the error messages that these tests expect aren't
detailed enough to distinguish between the order in which the IFrames
load: they all generate the same error, so the ordering is irrelevant.

Before we increase the error message detail in webkit.org/b/110733, we
need to ensure that these tests don't rely on load order. One option
is to serialize the IFrame loading by chaining onload events, but that
seems like a slow way of doing things. This patch takes a different
approach, breaking the multiple-IFrame tests into many single-IFrame
tests (which should be more shardable, and actually execute more quickly
in the long run).

  • http/tests/security/xssAuditor/open-iframe-src-expected.txt: Removed.
  • http/tests/security/xssAuditor/open-iframe-src.html: Removed.
  • http/tests/security/xssAuditor/open-script-src-expected.txt: Removed.
  • http/tests/security/xssAuditor/open-script-src.html: Removed.
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt: Removed.
  • http/tests/security/xssAuditor/property-escape-comment.html: Removed.
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt: Removed.
  • http/tests/security/xssAuditor/property-escape-entity.html: Removed.
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt: Removed.
  • http/tests/security/xssAuditor/property-escape-quote.html: Removed.
  • http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-with-comma.html: Removed.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Removed.

Removed these tests, breaking them into multiple single-IFrame HTML files.

  • http/tests/security/xssAuditor/open-iframe-src-01.html: Added.
  • http/tests/security/xssAuditor/open-iframe-src-02.html: Added.
  • http/tests/security/xssAuditor/open-script-src-01-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src-01.html: Added.
  • http/tests/security/xssAuditor/open-script-src-02-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src-02.html: Added.
  • http/tests/security/xssAuditor/open-script-src-03-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src-03.html: Added.
  • http/tests/security/xssAuditor/open-script-src-04-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src-04.html: Added.
  • http/tests/security/xssAuditor/property-escape-comment-01-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-comment-01.html: Added.
  • http/tests/security/xssAuditor/property-escape-comment-02-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-comment-02.html: Added.
  • http/tests/security/xssAuditor/property-escape-comment-03-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-comment-03.html: Added.
  • http/tests/security/xssAuditor/property-escape-entity-01-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-entity-01.html: Added.
  • http/tests/security/xssAuditor/property-escape-entity-02-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-entity-02.html: Added.
  • http/tests/security/xssAuditor/property-escape-entity-03-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-entity-03.html: Added.
  • http/tests/security/xssAuditor/property-escape-quote-01.html: Added.
  • http/tests/security/xssAuditor/property-escape-quote-02.html: Added.
  • http/tests/security/xssAuditor/property-escape-quote-03.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-comma-01.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-comma-02.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html: Added.

These tests perform the same validation as the combined tests, they
simply do it without introducing load-order dependencies.

6:38 AM Changeset in webkit [143919] by tommyw@google.com
  • 6 edits in branches/chromium/1410/Source

Merge 142773

MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688

Reviewed by Adam Barth.

Source/Platform:

Added id to initialize and renamed audio/videoSources to audio/videoTracks.

  • chromium/public/WebMediaStream.h:

(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):

  • chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

Source/WebCore:

This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.

Covered by existing tests.

  • platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):

  • platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::initialize):
(WebKit):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Tools:

Switching mock to new API.

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

TBR=dharani@google.com
Review URL: https://codereview.chromium.org/12326102

6:14 AM Changeset in webkit [143918] by akling@apple.com
  • 2 edits in trunk/Tools

Unreviewed, fix simple mistake in r143903.
<http://webkit.org/b/110746>

Reviewed by Andreas Kling.

Pass git revision, not svn revision, to git shell command.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit):

6:06 AM Changeset in webkit [143917] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-25
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at http://crbug.com/156386

  • features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
  • src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
6:06 AM Changeset in webkit [143916] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
5:59 AM Changeset in webkit [143915] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] Let built-product-archive log which directory it's archiving from and extracting to
https://bugs.webkit.org/show_bug.cgi?id=110748

Reviewed by Jochen Eisinger.

One of the mac testers runs DRT from out/ but WebKitUnitTests from
xcodebuild. I'm trying to understand what's going on.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

5:50 AM Changeset in webkit [143914] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
5:37 AM Changeset in webkit [143913] by loislo@chromium.org
  • 13 edits in trunk

Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=110599

Reviewed by Yury Semikhatsky.

Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
that were given us via MemoryInstrumentation calls.
So I extended client api with registerString method that pushes the strings
down to the serializer.

Source/WebCore:

  • css/InspectorCSSOMWrappers.h:
  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::registerString):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::registerString):
(WebCore):

  • inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationClientImpl):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):

  • wtf/MemoryObjectInfo.h:

(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::classNameId):
(WTF::MemoryObjectInfo::setName):
(WTF::MemoryObjectInfo::nameId):
(MemoryObjectInfo):

Tools:

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::Helper::Helper):
(Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::TEST):

5:21 AM Changeset in webkit [143912] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
5:20 AM Changeset in webkit [143911] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add a scrollbar class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110589

Reviewed by Kent Tamura.

Adding a scrollbar to be used in the new calendar picker (Bug 109439).

No new tests. Code is not used yet.

  • Resources/pagepopups/calendarPicker.js:

(ScrubbyScrollBar):
(ScrubbyScrollBar.prototype.height):
(ScrubbyScrollBar.prototype.setHeight):
(ScrubbyScrollBar.prototype.setThumbHeight): Sets the height of the scroll bar thumb.
(ScrubbyScrollBar.prototype._setThumbPositionFromEvent): Sets the thumb position from a mouse event.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(ScrubbyScrollBar.prototype.onThumbStyleTopAnimationStep): Animates the thumb back to the center position.
(ScrubbyScrollBar.prototype.onScrollTimer): Fires repeatedly while the thumb is being dragged.

5:16 AM Changeset in webkit [143910] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ScriptError not crash when args is a tuple
https://bugs.webkit.org/show_bug.cgi?id=110747

Reviewed by Jochen Eisinger.

I'm trying to understand the error on
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
better. I'll likely have to revert the ninja switch on windows, but
having error reporting code that doesn't itself crash sounds like a
good thing to have anyways.

The problem is that '%s' % (1, 2) errors out, and args is sometimes a
tuple not a list.

  • Scripts/run-chromium-webkit-unit-tests:
  • Scripts/webkitpy/common/system/executive.py:

(ScriptError.init):

5:13 AM Changeset in webkit [143909] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

[BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=110738

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-02-25
Reviewed by Rob Buis.

Use reinterpret_cast_ptr instead of reinterpret_cast for
pointers.

  • dfg/DFGOperations.cpp:
  • heap/CopiedBlock.h:

(JSC::CopiedBlock::zeroFillWilderness):

  • heap/WeakBlock.h:

(JSC::WeakBlock::asWeakImpl):
(JSC::WeakBlock::asFreeCell):
(JSC::WeakBlock::weakImpls):

  • heap/WeakImpl.h:

(JSC::WeakImpl::asWeakImpl):

  • interpreter/JSStack.cpp:

(JSC::JSStack::disableErrorStackReserve):

  • interpreter/JSStack.h:

(JSC::JSStack::reservationEnd):

  • runtime/ArrayStorage.h:

(JSC::ArrayStorage::from):

  • runtime/Butterfly.h:

(JSC::Butterfly::indexingPayload):

  • runtime/IndexingHeader.h:

(JSC::IndexingHeader::propertyStorage):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC::JSActivation::storage):

5:10 AM Changeset in webkit [143908] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
5:02 AM Changeset in webkit [143907] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
4:56 AM Changeset in webkit [143906] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
4:47 AM FeatureFlags edited by tkent@chromium.org
CUSTOM_ELEMENTS (diff)
4:36 AM Changeset in webkit [143905] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Align feature defaults
https://bugs.webkit.org/show_bug.cgi?id=110715

Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
OptionsEfl.cmake.

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-25
Reviewed by Gyuyoung Kim.

  • Scripts/webkitperl/FeatureList.pm:
4:31 AM Changeset in webkit [143904] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix of closure type annotations.

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/utilities.js:
4:26 AM Changeset in webkit [143903] by rniwa@webkit.org
  • 7 edits in trunk/Tools

run-perf-tests reports wrong commit time
https://bugs.webkit.org/show_bug.cgi?id=110746

Reviewed by Andreas Kling.

The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
of when the subdirectory was last modified.

Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
insufficient since running "svn log -r <revision>" on a partial checkout only returns
an empty result if the revision didn't modify the subdirectory.

For git, there is no partial checkout, so we just need to pass in "-r" option to keep
the interface compatible with svn.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.timestamp_of_latest_commit):

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.timestamp_of_latest_commit):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_timestamp_of_latest_commit):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

3:45 AM Changeset in webkit [143902] by eustas@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
https://bugs.webkit.org/show_bug.cgi?id=109943

Reviewed by Pavel Feldman.

Look at network log: red bar (on load) is positioned to the right of
the last required load.

This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.

  • inspector/front-end/DataGrid.js:

Fix - hidden columns can have non-zero width.

  • inspector/front-end/NetworkPanel.js: Use correct width for calculator.
  • inspector/front-end/networkLogView.css: Removed parasite paddinds.

Extracted common absolute "paddings".

3:31 AM Changeset in webkit [143901] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add list view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110140

Reviewed by Kent Tamura.

Adding list view class to be used in the new calendar picker (Bug 109439).

No new tests. Code is not yet used.

  • Resources/pagepopups/calendarPicker.js:

(ListCell): One row inside the list view. We reuse
list cells to avoid animation hiccups caused by memory allocation.
(ListCell.prototype._recycleBin): Returns array to
store thrown away list cells so we can reuse them.
(ListCell.prototype.throwAway): Hides the cell and puts it in the recycle bin.
(ListCell.prototype.show):
(ListCell.prototype.hide): Hide the cell when we don't need the cell any more.
(ListCell.prototype.width):
(ListCell.prototype.setWidth):
(ListCell.prototype.position):
(ListCell.prototype.setPosition): Sets the CSS transform to position the cell.
(ListCell.prototype.setSelected): Adds selected CSS class.
(ListView): Shows a scrolling list.
(ListView.prototype.onAnimationFrameWillFinish): Calls updateCells if the cells need to be updated.
(ListView.prototype.setNeedsUpdateCells): Mark the cells as need to be updated.
(ListView.prototype.cellAtRow): Returns the cell at a given row. If the cell is not visible and doesn't exist, returns undefined.
(ListView.prototype.rowAtScrollOffset): The row that is displayed at the given scroll offset.
(ListView.prototype.scrollOffsetForRow): The scroll offset for the top of a given row.
(ListView.prototype.addCellIfNecessary): Adds the cell for a given row.
(ListView.prototype.prepareNewCell): Prepares a new or recycled cell for a given row.
(ListView.prototype.throwAwayCell): Throws a way a cell.
(ListView.prototype.firstVisibleRow): The first visible row at the top of the view.
(ListView.prototype.lastVisibleRow): The last visible row at the bottom of the view.
(ListView.prototype.scrollViewDidChangeContentOffset):
(ListView.prototype.scrollViewDidChangeHeight):
(ListView.prototype.scrollViewDidChangePartition):
(ListView.prototype.updateCells): Updates all the cells that are visible.
(ListView.prototype.width):
(ListView.prototype.setWidth):
(ListView.prototype.height):
(ListView.prototype.setHeight):
(ListView.prototype.onClick): Clicking on a row selects it.
(ListView.prototype.select):
(ListView.prototype.deselect):
(ListView.prototype.scrollToRow): Scrolls to a given row.

2:53 AM Changeset in webkit [143900] by commit-queue@webkit.org
  • 15 edits in trunk

Web Inspector: move profile type specific code out of ProfilesPanel (refactor)
https://bugs.webkit.org/show_bug.cgi?id=110597

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

Move profile type specific functionality out of ProfilesPanel class.
This is a first part of WebInspector.ProfilesPanel refactoring.

No new tests as the functionality isn't changed.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.addProfileHeader):
(WebInspector.CPUProfileType.prototype.removeProfile):
(WebInspector.CPUProfileType.prototype._requestProfilesFromBackend):
(WebInspector.CPUProfileType.prototype.resetProfiles):
(WebInspector.CPUProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.CPUProfileType.prototype.finishHeapSnapshot):
(WebInspector.CPUProfileType.prototype.reportHeapSnapshotProgress):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._reset):
(WebInspector.CanvasProfileType.prototype.removeProfile):
(WebInspector.CanvasProfileHeader.prototype.dispose):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.addProfileHeader):
(WebInspector.HeapSnapshotProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.HeapSnapshotProfileType.prototype.finishHeapSnapshot):
(WebInspector.HeapSnapshotProfileType.prototype.reportHeapSnapshotProgress):
(WebInspector.HeapSnapshotProfileType.prototype.resetProfiles):
(WebInspector.HeapSnapshotProfileType.prototype.removeProfile):
(WebInspector.HeapSnapshotProfileType.prototype._requestProfilesFromBackend):
(WebInspector.HeapProfileHeader.prototype._updateTransferProgress):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileType.prototype.addNativeSnapshotChunk):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType):
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfileType.prototype.getProfiles):
(WebInspector.ProfileType.prototype.getProfile):
(WebInspector.ProfileType.prototype._makeKey):
(WebInspector.ProfileType.prototype.addProfile):
(WebInspector.ProfileType.prototype.removeProfile):
(WebInspector.ProfileType.prototype.findTemporaryProfile):
(WebInspector.ProfileType.prototype._reset):
(WebInspector.ProfileType.prototype._requestProfilesFromBackend):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._populateAllProfiles):
(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._profilerWasEnabled):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onAddProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onRemoveProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onProgressUpdated):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._createTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.getProfile):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype._getAllProfiles):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportProfileProgress):

LayoutTests:

  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

  • inspector/profiler/profiler-test.js:

(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):

2:40 AM Changeset in webkit [143899] by kadam@inf.u-szeged.hu
  • 4 edits
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped failing tests.

  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/select-baseline-expected.png: Removed.
  • platform/qt-5.0/fast/forms/select-baseline-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/fast/forms/select-baseline-expected.png: Update after r143836.
  • platform/qt/fast/forms/select-baseline-expected.txt: Update after r143836.
2:33 AM Changeset in webkit [143898] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] move WebRuntimeFeatures configuration to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110712

Reviewed by Nico Weber.

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

2:04 AM Changeset in webkit [143897] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
1:56 AM Changeset in webkit [143896] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip tests after r143800.

  • platform/qt/TestExpectations:
1:48 AM Changeset in webkit [143895] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default build system for build-webkit --chromium on windows
https://bugs.webkit.org/show_bug.cgi?id=110731

Reviewed by Jochen Eisinger.

With http://crbug.com/169945 fixed, this should now work.

  • Scripts/update-webkit-chromium:
1:48 AM Changeset in webkit [143894] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fix of type annotation for this._liveLocations.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

1:42 AM Changeset in webkit [143893] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Fix style errors in WebCore/editing/{htmlediting,markup,visible_units}.*
https://bugs.webkit.org/show_bug.cgi?id=110721

Reviewed by Ryosuke Niwa.

No new tests. This should not make any bahevior changes.

  • editing/htmlediting.cpp:

(WebCore::lowestEditableAncestor):
(WebCore):
(WebCore::isSpecialElement):
(WebCore::enclosingListChild):
(WebCore::canMergeLists):
(WebCore::tabSpanNode):
(WebCore::isNodeRendered):
(WebCore::caretMaxOffset):

  • editing/htmlediting.h:

(WebCore):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):

  • editing/markup.h:

(WebCore):

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::previousBoundary):
(WebCore::endOfLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::nextSentencePositionBoundary):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

1:41 AM Changeset in webkit [143892] by zandobersek@gmail.com
  • 3 edits
    2 deletes in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Giving up on individually listing slow sputnik tests, replaced all

the expectations with a single one covering the whole directory in both release and debug builds.
Also removing duplicate expectations and adding an expectation for tests that require custom elements support.

  • platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Rebaselining.
  • platform/gtk/media/audio-controls-rendering-expected.png: Removed. Requires a new baseline.
  • platform/gtk/media/audio-controls-rendering-expected.txt: Removed. Ditto.
1:29 AM Changeset in webkit [143891] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
1:11 AM Changeset in webkit [143890] by keishi@webkit.org
  • 6 edits
    3 copies in branches/chromium/1410

Merge 142572

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

  • Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

TBR=keishi@webkit.org

1:10 AM Changeset in webkit [143889] by loislo@chromium.org
  • 7 edits in trunk

Web Inspector: Improve speed of Linkifier.reset operation.
https://bugs.webkit.org/show_bug.cgi?id=110696

Reviewed by Yury Semikhatsky.

Linkifier calls Location.dispose N times and each dispose method calls Array.remove
which scans entire array and does splice. So the complexity of Linkifier.reset
is O(N2). I replaced the arrays with Set and got O(N) complexity.

Drive by fix: The identifier generator was slightly changed.
Now it produces identifiers that couldn't be converted into a number.
So the engine will never convert Set/Map object into an array.

Source/WebCore:

  • inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.updateLocations):
(WebInspector.Script.prototype.createLiveLocation):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/linkifier.html:
12:49 AM WebKitGTK/2.0.x edited by sergio@webkit.org
(diff)
12:09 AM Changeset in webkit [143888] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ChromeClientBlackBerry: fix variable names
https://bugs.webkit.org/show_bug.cgi?id=110562

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-25
Reviewed by Rob Buis.

manager was incorrectly renamed back to tracker in r138696:
http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

Feb 24, 2013:

11:35 PM Changeset in webkit [143887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] GeolocationClientBlackBerry: add missing headers
https://bugs.webkit.org/show_bug.cgi?id=110563

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Benjamin Poulain.

Frame.h and SecurityOrigin.h are necessary since r136969.
GeolocationPosition.h since r132360.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:
11:27 PM Changeset in webkit [143886] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r143797.
http://trac.webkit.org/changeset/143797
https://bugs.webkit.org/show_bug.cgi?id=110724

Causes assertion failures in multiple tests. (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-24

  • dom/DocumentParser.h:

(DocumentParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

11:00 PM Changeset in webkit [143885] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

Rollout r143556, it regressed html5-full-render perf.
https://bugs.webkit.org/show_bug.cgi?id=110719

Unreviewed rollout.

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToLength):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:

(WebCore):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:

(CSSGradientValue):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):

  • css/CSSToStyleMap.h:

(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

  • css/StyleBuilder.h:

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
(State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::styleMap):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

7:57 PM Changeset in webkit [143884] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=110716

Reviewed by Alexey Proskuryakov.

No new tests, no functionality changed.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Take AVFInbandTrackParent*

instead of MediaPlayerPrivateAVFoundation*.

(WebCore::InbandTextTrackPrivateAVF::processCue): Pass new cues directly to the client.
(WebCore::InbandTextTrackPrivateAVF::disconnect): m_player -> m_owner.
(WebCore::InbandTextTrackPrivateAVF::setMode): m_player -> m_owner.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::addGenericCue): Delete, no longer needed.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Don't include

CachedResourceClient.h, it isn't needed.

7:38 PM Changeset in webkit [143883] by noel.gordon@gmail.com
  • 3 edits in branches/chromium/1410/Source/WebCore

Merge 143363

Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):

  • page/FeatureObserver.h:

(FeatureObserver):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12340046

6:02 PM Changeset in webkit [143882] by kihong.kwon@samsung.com
  • 6 edits in trunk

Add an ASSERT to didChangeDeviceProximity
https://bugs.webkit.org/show_bug.cgi?id=110317

Reviewed by Hajime Morrita.

Source/WebCore:

Add An ASSERT to didChangeDeviceProximity function to check range of value.

Change exist test cases.

  • Modules/proximity/DeviceProximityController.cpp:

(WebCore::DeviceProximityController::didChangeDeviceProximity):

LayoutTests:

Fix wrong test cases which are found by ASSERT insertion.

  • proximity/basic-operation-expected.txt:
  • proximity/basic-operation.html:
  • proximity/resources/event-after-navigation-new.html:
4:14 PM Changeset in webkit [143881] by ap@apple.com
  • 4 edits in trunk/Source

Clarify meaning of default default encoding localizable string
https://bugs.webkit.org/show_bug.cgi?id=110714

Reviewed by Eric Carlson.

  • English.lproj/Localizable.strings: This string is only used on Windows, and it's very confusing to everyone involved.
2:40 PM Changeset in webkit [143880] by mkwst@chromium.org
  • 9 edits
    63 adds in trunk

CSP 1.1: Experiment with 'reflected-xss' directive.
https://bugs.webkit.org/show_bug.cgi?id=104479

Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy 1.1 defines a 'reflected-xss' directive that
works in much the same way as WebKit's current 'X-XSS-Protection'
header[1]. This patch implements the new directive by parsing it
inside ContentSecurityPolicy, and exposing that state to XSSAuditor.

XSSAuditor now grabs the CSP directive's state, and mixes it with the
X-XSS-Protection header's state to determine how the page should be
handled. Moreover, both headers' states are now expressed in terms of
ContentSecurityPolicy::ReflectedXSSDisposition.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#reflected-xss--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html

http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html

  • html/parser/XSSAuditor.cpp:

(WebCore::combineXSSProtectionHeaderAndCSP):

Given both headers' states, return the state which the XSSAuditor
should use when parsing a page. Blocking overrides filtering, which
overrides disabling.

(WebCore):
(WebCore::XSSAuditor::init):

Process the 'X-XSS-Protection' header before grabbing the CSP
header's state. Both are passed into the new
combineXSSProtectionHeaderAndCSP method to generate the final
state that ought to be used.

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

Switch to ContentSecurityPolicy::ReflectedXSSDisposition internally
in XSSAuditor.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::reflectedXSSDisposition):

Enum defining the possible state of the 'reflected-xss' CSP directive.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::parseReflectedXSS):

Given a 'reflected-xss' directive's value, set the
ReflectedXSSDisposition into a new property on the CSPDirectiveList.

(WebCore):
(WebCore::CSPDirectiveList::addDirective):

Accept 'reflected-xss' as a valid directive if we're in
experimental mode.

(WebCore::ContentSecurityPolicy::reflectedXSSDisposition):

Expose the directive's state via the public API.

(WebCore::ContentSecurityPolicy::reportInvalidReflectedXSS):

Generate console errors when invalid reflected-xss directive values
are encounted during parsing.

  • page/ContentSecurityPolicy.h:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseXSSProtectionHeader):

  • platform/network/HTTPParsers.h:

(WebCore):

Start using ContentSecurityPolicy::ReflectedXSSDisposition rather
than the XSSProtectionDisposition enum.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js: Added.

(testMixedHeader):
(frameLoaded):
(frameErrored):

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:

Added the ability to send an 'X-WebKit-CSP' header to test 'reflected-xss' behavior.

1:11 PM Changeset in webkit [143879] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=110699

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-24
Reviewed by Andreas Kling.

Fix a typo. ENABLE_REGIONS is called ENABLE_CSS_REGIONS
throughout the project.

  • Source/cmake/OptionsEfl.cmake:
12:33 PM Changeset in webkit [143878] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

REGRESSION(r143837): Broke build on AppleWin http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29.
https://bugs.webkit.org/show_bug.cgi?id=110713

Unreviewed.

  • WebKit.vcproj/WebKitExports.def.in: Add the missing symbol after r143837.
12:31 PM Changeset in webkit [143877] by zandobersek@gmail.com
  • 16 edits in trunk/Source/WebCore

Updating GObject bindings baselines after r143863.

Unreviewed.

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
11:51 AM Changeset in webkit [143876] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.8/Source/WebCore

Merged r143656. 13281269

11:01 AM Changeset in webkit [143875] by zandobersek@gmail.com
  • 5 edits
    1 add
    1 delete in trunk

[GTK] Stop generating UserAgentGtk.h
https://bugs.webkit.org/show_bug.cgi?id=110582

Reviewed by Martin Robinson.

.:

  • configure.ac: Provide the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines in the autotoolsconfig.h

header, containing the user agent versions that are to be used in the user agent string. The
WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION name is avoided as the same defines are specified in the
webkitversion.h API header (but are not accessible from the WebCore layer). The UserAgentGtk.h
header is also not generated anymore from the input file.

Source/WebCore:

No new tests - no new functionality.

  • GNUmakefile.list.am: Move the UserAgentGtk.h build target from the derived sources list to

the list of the WebCore platform sources.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent): Rename WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION to
USER_AGENT_GTK_(MAJOR|MINOR)_VERSION.

  • platform/gtk/UserAgentGtk.h: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.h.in.

Same as the input file expect for removed WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION defines that
are now replaced by using the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines placed in autotoolsconfig.h.

10:19 AM Changeset in webkit [143874] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.8/Source/WebCore

Merged r143825. <rdar://problem/13258596>

10:16 AM Changeset in webkit [143873] by Lucas Forschler
  • 11 edits
    4 copies in tags/Safari-537.31.8

Merged r143821. <rdar://problem/12944761>

10:13 AM Changeset in webkit [143872] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.8/Source

Merged r143816. <rdar://problem/13096456>

10:09 AM Changeset in webkit [143871] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.8/Source

Versioning.

10:06 AM Changeset in webkit [143870] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.8

New Tag.

9:42 AM Changeset in webkit [143869] by kov@webkit.org
  • 34 edits in trunk

[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
https://bugs.webkit.org/show_bug.cgi?id=110702

Reviewed by Martin Robinson.

Source/WebCore:

No tests. Build fix, no behaviour change.

  • platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,

which contains the GTK_API_VERSION_2 define now.

Source/WebKit/gtk:

  • tests/testapplicationcache.c: include autotoolsconfig.h.
  • tests/testatk.c: ditto.
  • tests/testatkroles.c: ditto.
  • tests/testcontextmenu.c: ditto.
  • tests/testcopyandpaste.c: ditto.
  • tests/testdomdocument.c: ditto.
  • tests/testdomdomwindow.c: ditto.
  • tests/testdomnode.c: ditto.
  • tests/testdownload.c: ditto.
  • tests/testfavicondatabase.c: ditto.
  • tests/testglobals.c: ditto.
  • tests/testhittestresult.c: ditto.
  • tests/testhttpbackend.c: ditto.
  • tests/testkeyevents.c: ditto.
  • tests/testloading.c: ditto.
  • tests/testmimehandling.c: ditto.
  • tests/testnetworkrequest.c: ditto.
  • tests/testnetworkresponse.c: ditto.
  • tests/testwebbackforwardlist.c: ditto.
  • tests/testwebdatasource.c: ditto.
  • tests/testwebframe.c: ditto.
  • tests/testwebhistoryitem.c: ditto.
  • tests/testwebinspector.c: ditto.
  • tests/testwebplugindatabase.c: ditto.
  • tests/testwebresource.c: ditto.
  • tests/testwebsettings.c: ditto.
  • tests/testwebview.c: ditto.
  • tests/testwindow.c: ditto.

Tools:

  • GtkLauncher/main.c: include autotoolsconfig.h.
  • Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of

the include ordering check, since it uses autotoolsconfig.h which needs to
come first.

8:45 AM Changeset in webkit [143868] by akling@apple.com
  • 8 edits in trunk/Source

StyledElement: Don't expose a mutable direct interface to the inline style.
<http://webkit.org/b/110711>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the ability to grab at a mutable StylePropertySet* for a StyledElement's inline style
from the outside world. It's now private and returns MutableStylePropertySet* for future convenience.

Three paths to changing the inline style remain:

  • Setting the "style" attribute
  • Via CSSOM (element.style)
  • setInlineStyleProperty/removeInlineStyleProperty helpers
  • dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):

  • dom/StyledElement.h:

(StyledElement):

  • editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • html/canvas/CanvasStyle.cpp:

(WebCore::currentColor):

Source/WebKit/qt:

QWebElement::styleProperty() is a read-only method, so rewrite it to use StyledElement::inlineStyle().

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

8:42 AM Changeset in webkit [143867] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Add methods to date types for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110454

Reviewed by Kent Tamura.

Source/WebCore:

Adding some methods to date types as part of the calendar picker redesign (Bug 109439).

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html

  • Resources/pagepopups/calendarPicker.js:

(createUTCDate):
(DateType): Base class for Day, Week and Month.
(Day): Simplified constructor to only accept year, month, date.
(Day.createFromValue): Creates a new Day from a value.
(Day.createFromDate): Throw an error if the given date is invalid.
(Day.createFromDay):
(Day.prototype.equals): Accept non Day objects.
(Day.prototype.previous): Modified to take an offset value.
(Day.prototype.next): Ditto.
(Day.prototype.firstDay): Returns the first day in the range. For Day's case, returns itself.
(Day.prototype.middleDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.lastDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.valueOf):
(Day.prototype.weekDay): Returns the week day.
(Week): Simplified constructor to only accept year, month, date.
(Week.createFromValue):
(Week.createFromDate):
(Week.createFromDay):
(Week.weekOneStartDateForYear):
(Week.weekOneStartDayForYear):
(Week._numberOfWeeksSinceDate):
(Week.prototype.equals):
(Week.prototype.previous):
(Week.prototype.next):
(Week.prototype.firstDay): Returns the first day in the week.
(Week.prototype.middleDay): Returns the the day for Thursday.
(Week.prototype.lastDay): Returns the last day in the week.
(Week.prototype.valueOf):
(Month):
(Month.createFromValue):
(Month.createFromDate):
(Month.createFromDay):
(Month.prototype.containsDay):
(Month.prototype.equals):
(Month.prototype.previous):
(Month.prototype.next):
(Month.prototype.firstDay): Returns the first day in the month.
(Month.prototype.middleDay): Returns the middle day in the month.
(Month.prototype.lastDay): Returns the last day in the month.
(Month.prototype.valueOf):
(Month.prototype.toLocaleString): Moved location.
(Month.prototype.toShortLocaleString): Returns the month string in short format.
(CalendarPicker): Use createFromValue.
(YearMonthController.prototype.setMonth): Ditto.
(YearMonthController.prototype.moveRelatively): Ditto.

LayoutTests:

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html: Added. Unit tests for date types.
7:23 AM Changeset in webkit [143866] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=110570

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Allan Sandfeld Jensen.

HitTestResult is no longer a HitTestLocation:
http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::fingerRectForPoint):

5:21 AM Changeset in webkit [143865] by morrita@google.com
  • 23 edits
    3 copies
    20 adds in trunk

[Custom Elements] Implement bare-bone document.register()
https://bugs.webkit.org/show_bug.cgi?id=100229

Reviewed by Adam Barth.

Source/WebCore:

This change implements a prefixed version of document.register(), with minimal feature support.

  • The feature is guarded by ENABLE(CUSTOM_ELEMENTS) and RuntimeEnabledFeatures::customDOMElementsEnabled().
  • This bare-bone version only recognizes "name" and "prototype" parameters. It doesn't support default value of "prototype" parameter.
  • Currently only V8 is supported. JSC binding needs its own binding implementation.

Major new classes under dom/:

The dom module gets two new classes:

  • CustomElementConstructor: A return value of document.register() which holds the custom element definition.
  • CustomElementRegistry: A collection of CustomElementConstructor objects. CustomElementRegistry instance is created per Document and is owned by the Document.

CustomElementConstructor knows the definition of each custom
element, which is registered by document.register(). The name and
other options are held by this object. CustomElementRegistry owns a set
of the registered constructors. The registry guarantees invariants
like validity and uniqueness of the element names.

A change on make_names.pl

This change tweaks make_names.pl (or generated HTMLElementFactory)
to hook the creations of unknown elements. Some of element names
which come to the fallback path can be one of registered custom
element.

[V8WrapAsFunction] extended attribute:

The document.register() API returns a constructor
function. However, the V8 binding currently doesn't support it. To
make it possible, this change introduces "V8WrapAsFunction"
extended attribute for annotating CustomElementConstructor IDL
interface.

V8WrapAsFunction wraps the annotated interface with a JavaScript
function, which calls the original object as a function, or as a
constructor depends on the context.

With this wrapper function, there are two levels of indirection
between native C++ object and author-visible JS function:

[JS Adaptor Function] <-(hidden property)-> [JS Wrapper Object] -(internal field)-> [C++ Native object]

The code generator generates the binding code which deals with
this indirection. Also, there is a set of helper functions in
V8AdaptorFunction.h/cpp which takes care of this indirection.
V8DOMWrapper.cpp/h works as a facade for these APIs and is used from
the generated code.

This redundancy comes from limitations of both V8 bindings and V8
embedding API. See bug 108138 for details.

V8HTMLCustomElement

Unlike built-in HTML elements, any custom element has no
corresponding C++ class. Instead, document.register() should allow
passing a prototype object for the elements being registered.

V8HTMLCustomElement handles this lack of native class. It behaves
like a native side proxy of non-native HTMLElement subclasses. It
connects each custom element to an appropriate native element,
which is HTMLElement at this time. This restriction will be
relaxed later. See Bug 110436 for details.

Custom DOM elements and multiple worlds

In this patch, custom element registration and instantiation is not allowed
in non-main world and document.register() API just fails there.

Reviewed by Adam Barth.

Tests: fast/dom/custom/document-register-basic.html

fast/dom/custom/document-register-reentrant-null-constructor.html
fast/dom/custom/document-register-reentrant-returning-fake.html
fast/dom/custom/document-register-reentrant-throwing-constructor.html

  • DerivedSources.make:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/v8/CustomElementHelpers.cpp: Added.

(WebCore::CustomElementHelpers::initializeConstructorWrapper):
(WebCore::hasNoBuiltinsInPrototype):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::isFeatureAllowed):

  • bindings/v8/CustomElementHelpers.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(CustomElementHelpers):

  • bindings/v8/V8AdaptorFunction.cpp: Added.

(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::configureTemplate):
(WebCore::V8AdaptorFunction::invocationCallback):
(WebCore::V8AdaptorFunction::wrap):

  • bindings/v8/V8AdaptorFunction.h: Added.

(V8AdaptorFunction):
(WebCore::V8AdaptorFunction::unwrap):
(WebCore::V8AdaptorFunction::get):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::toFunction):
(WebCore::V8DOMWrapper::fromFunction):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8HTMLCustomElement.cpp: Added.

(WebCore::V8HTMLCustomElement::createWrapper):

  • bindings/v8/V8HTMLCustomElement.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(V8HTMLCustomElement):
(WebCore::V8HTMLCustomElement::toV8):
(WebCore::HTMLCustomElement::toV8):

  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8CustomElementConstructorCustom.cpp: Added.

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

  • dom/CustomElementConstructor.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::~CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):

  • dom/CustomElementConstructor.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::tagName):
(WebCore::CustomElementConstructor::name):

  • dom/CustomElementConstructor.idl: Added.
  • dom/CustomElementRegistry.cpp: Added.

(WebCore::CustomElementRegistry::CustomElementRegistry):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):
(WebCore::CustomElementRegistry::document):

  • dom/CustomElementRegistry.h: Added.

(CustomElementRegistry):

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::registerElement):
(WebCore::Document::registry):

  • dom/Document.h:

(Document):

  • dom/make_names.pl:

(printWrapperFactoryCppFile):

  • html/HTMLDocument.idl:

Source/WebKit/chromium:

Added enableCustomDOMElements flag.

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCustomDOMElements):
(WebKit):
(WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):

Tools:

Added enableCustomDOMElements flag.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • fast/dom/custom/document-register-basic-expected.txt: Added.
  • fast/dom/custom/document-register-basic.html: Added.
  • fast/dom/custom/document-register-reentrant-null-constructor-expected.txt: Added.
  • fast/dom/custom/document-register-reentrant-null-constructor.html: Added.
  • fast/dom/custom/document-register-reentrant-returning-fake-expected.txt: Added.
  • fast/dom/custom/document-register-reentrant-returning-fake.html: Added.
  • fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt: Added.
  • fast/dom/custom/document-register-reentrant-throwing-constructor.html: Added.
  • fast/dom/custom/resources/document-register-fuzz.js: Added.
  • platform/mac/TestExpectations:
5:18 AM Changeset in webkit [143864] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
https://bugs.webkit.org/show_bug.cgi?id=110561

Reviewed by Pavel Feldman.

Area that causes frame information popup is overly "shaded" by CPU bars.

  • inspector/front-end/timelinePanel.css:

(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.

5:01 AM Changeset in webkit [143863] by akling@apple.com
  • 26 edits
    3 copies in trunk/Source

Reduce include graph of JSDOMBinding.h
<http://webkit.org/b/110709>

Reviewed by Antti Koivisto.

Source/WebCore:

Move WebCore::root(Foo*) to the custom JSFooCustom.h headers.
This reduces the number of headers pulled in by JSDOMBinding.h.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp:
  • bindings/js/JSCSSRuleCustom.h: Added.

(WebCore::root):

  • bindings/js/JSCSSRuleListCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.h:

(WebCore::root):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSMediaListCustom.h: Added.

(WebCore::root):

  • bindings/js/JSMutationObserverCustom.cpp:
  • bindings/js/JSNodeCustom.h:

(WebCore::root):

  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSStyleSheetCustom.h: Added.

(WebCore::root):

  • bindings/js/JSTextTrackCustom.h:
  • bindings/js/JSTextTrackListCustom.cpp:
  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/js/SerializedScriptValue.cpp:
  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(AddIncludesForType):

  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • editing/mac/EditorMac.mm:

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • WebProcess/Storage/StorageAreaProxy.cpp:
12:39 AM Changeset in webkit [143862] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Add timeout to the Chromium expectation of state-url-sets-links-visited.html

Unreviewed.

  • platform/chromium/TestExpectations: Since Chromium's DRT does not support

computedStyleIncludingVisitedInfo, the test can also timeout as it will
raise an exception before invoking finishJSTest.

Feb 23, 2013:

11:29 PM Changeset in webkit [143861] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

ResourceRequestBase unnecessarily updates when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=110665

Reviewed by Dan Bernstein.

Don't mark platform data for update if nothing really changed. This avoids ever doing
doUpdatePlatformRequest() in NetworkProcess during normal browsing for me, which is
good for performance.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::removeCredentials):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setFirstPartyForCookies):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):

11:24 PM Changeset in webkit [143860] by benjamin@webkit.org
  • 6 edits
    2 deletes in trunk/LayoutTests

Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883

Reviewed by Antti Koivisto.

Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.

Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.

This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.

The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.

  • fast/js/resources/js-test-pre.js:

(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):

  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/wk2/TestExpectations:

state-url-sets-links-visited.html failed on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.

The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.

  • platform/chromium/TestExpectations: Make the test as failing on Chromium until proper test support is added

to DRT or Internals.

10:35 PM Changeset in webkit [143859] by pdr@google.com
  • 3 edits
    2 adds in trunk

Prevent crash in animated transform lists
https://bugs.webkit.org/show_bug.cgi?id=110704

Reviewed by Abhishek Arya.

Source/WebCore:

This change prevents accessing values off the end of toAtEndOfDuration by adding a check
for this case. Similar checks were added in r116458 but the author failed to catch this
case. WK110706 has been filed to handle this case in general.

This change also makes a trivial change that marks effectiveFrom as const.

Test: svg/animations/animateTransform-list-crash.html

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

LayoutTests:

  • svg/animations/animateTransform-list-crash-expected.txt: Added.
  • svg/animations/animateTransform-list-crash.html: Added.
10:18 PM Changeset in webkit [143858] by Dimitri Glazkov
  • 6 edits in trunk/Source/WebCore

SelectorChecker should not know about SelectorCheckerFastPath.
https://bugs.webkit.org/show_bug.cgi?id=110663

Both SelectorChecker and it's speedy cousin unfortunately include each other.
Luckily, the particular way in which SelectorQuery uses SelectorChecker yields
to a fairly simple decoupling. Now only the cousin knows of SelectorChecker.

Reviewed by Antti Koivisto.

No new functionality, covered by existing tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matches): Removed.

  • css/SelectorChecker.h:

(SelectorChecker): Updated the decls to remove fast-path flag.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches): Added a helper just for SelectorQuery.
(WebCore::SelectorDataList::matches): Changed the callsite to use new helper.
(WebCore::SelectorDataList::execute): Ditto.

  • dom/SelectorQuery.h:

(SelectorDataList): Updated decls.

9:31 PM Changeset in webkit [143857] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[Mac] user preference caption style applied incorrectly
https://bugs.webkit.org/show_bug.cgi?id=110707
<rdar://problem/13281096>

Reviewed by Maciej Stachowiak.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): New

static function so the pseudo ID is available.

(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Call textTrackContainerElementShadowPseudoId.

  • html/shadow/MediaControlElements.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Style the text track container

element for cue color, edge style, and font name.

6:54 PM Changeset in webkit [143856] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Generate xxxAttrGetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110676

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxAttrGetter(), like this:

For non-custom getters
Handle<Value> xxxAttrGetterCallback(...) {

return xxxAttrGetter(...);

}

For custom getters.
Handle<Value> xxxAttrGetterCallback(...) {

return xxxAttrGetterCustom(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateNonStandardFunction):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallback):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetterCallback):
(TestExceptionV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::createAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallback):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallback):
(WebCore::TestObjV8Internal::idAttrGetterCallback):
(WebCore::TestObjV8Internal::hashAttrGetterCallback):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore):

5:38 PM Changeset in webkit [143855] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110701

Reviewed by Abhishek Arya.

This is a follow-up fix for r143853. In WebCore.gyp, we need to
increase the shard of 'webcore_rendering' as well.

No tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp:
4:17 PM Changeset in webkit [143854] by haraken@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r143844.
http://trac.webkit.org/changeset/143844
https://bugs.webkit.org/show_bug.cgi?id=110241

It broke Chromium Mac Release Build

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/WebCoreGTK.gyp: Removed.
  • WebCore.gypi:
3:33 PM Changeset in webkit [143853] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110697

Reviewed by Eric Seidel.

Apparently we need to use more shards to work around linker limitations
on Windows again.

  • WebCore.gyp/WebCore.gyp:
3:31 PM Changeset in webkit [143852] by pilgrim@chromium.org
  • 6 edits
    2 moves in trunk/Tools

[Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110606

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(WebKitSupportTestEnvironment):

  • DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(MockPlatform::create):
(MockPlatform::MockPlatform):
(MockPlatform::~MockPlatform):
(MockPlatform::setInterfaces):
(MockPlatform::cryptographicallyRandomValues):
(MockPlatform::createMediaStreamCenter):
(MockPlatform::createRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.

(MockPlatform):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

2:37 PM Changeset in webkit [143851] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Rename constructorCallbackCustom() to constructorCustom()
https://bugs.webkit.org/show_bug.cgi?id=110671

Reviewed by Adam Barth.

his is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to indicate that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateCustomConstructorCallback):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCustom):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCustom):

2:23 PM Changeset in webkit [143850] by haraken@chromium.org
  • 50 edits in trunk/Source/WebCore

[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
https://bugs.webkit.org/show_bug.cgi?id=110669

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE()
macros into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to refer that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::Float64ArrayV8Internal::setMethod):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethod):
(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemMethod):
(WebCore::TestEventTargetV8Internal::addEventListenerMethod):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethod):
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod1Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod3Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod4Method):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodMethod):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodMethod):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethod):
(WebCore::TestObjV8Internal::methodReturningSequenceMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::serializedValueMethod):
(WebCore::TestObjV8Internal::optionsObjectMethod):
(WebCore::TestObjV8Internal::methodWithExceptionMethod):
(WebCore::TestObjV8Internal::customMethodMethod):
(WebCore::TestObjV8Internal::customMethodWithArgsMethod):
(WebCore::TestObjV8Internal::addEventListenerMethod):
(WebCore::TestObjV8Internal::removeEventListenerMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidMethod):
(WebCore::TestObjV8Internal::withScriptStateObjMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethod):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethod):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethod):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethod):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethod):
(WebCore::TestObjV8Internal::conditionalMethod1Method):
(WebCore::TestObjV8Internal::conditionalMethod2Method):
(WebCore::TestObjV8Internal::conditionalMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod4Method):
(WebCore::TestObjV8Internal::overloadedMethod5Method):
(WebCore::TestObjV8Internal::overloadedMethod6Method):
(WebCore::TestObjV8Internal::overloadedMethod7Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethod9Method):
(WebCore::TestObjV8Internal::overloadedMethod10Method):
(WebCore::TestObjV8Internal::overloadedMethod11Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::classMethodMethod):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethod):
(WebCore::TestObjV8Internal::classMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod12Method):
(WebCore::TestObjV8Internal::classMethodWithClampMethod):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Method):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Method):
(WebCore::TestObjV8Internal::stringArrayFunctionMethod):
(WebCore::TestObjV8Internal::domStringListFunctionMethod):
(WebCore::TestObjV8Internal::getSVGDocumentMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::mutablePointFunctionMethod):
(WebCore::TestObjV8Internal::immutablePointFunctionMethod):
(WebCore::TestObjV8Internal::orangeMethod):
(WebCore::TestObjV8Internal::strictFunctionMethod):
(WebCore::TestObjV8Internal::variadicStringMethodMethod):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethod):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethod):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethod):
(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::TestTypedefsV8Internal::multiTransferListMethod):
(WebCore::TestTypedefsV8Internal::setShadowMethod):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethod):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethod):
(WebCore::TestTypedefsV8Internal::funcWithClampMethod):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Method):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethod):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataMethodCustom):
(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceMethodCustom):
(WebCore::V8Console::assertMethodCustom):
(WebCore::V8Console::profileMethodCustom):
(WebCore::V8Console::profileEndMethodCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendMethodCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerMethodCustom):
(WebCore::V8DOMWindow::removeEventListenerMethodCustom):
(WebCore::V8DOMWindow::postMessageMethodCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::releaseEventsMethodCustom):
(WebCore::V8DOMWindow::captureEventsMethodCustom):
(WebCore::V8DOMWindow::showModalDialogMethodCustom):
(WebCore::V8DOMWindow::openMethodCustom):
(WebCore::V8DOMWindow::setTimeoutMethodCustom):
(WebCore::V8DOMWindow::setIntervalMethodCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8MethodCustom):
(WebCore::V8DataView::getUint8MethodCustom):
(WebCore::V8DataView::setInt8MethodCustom):
(WebCore::V8DataView::setUint8MethodCustom):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageMethodCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventMethodCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventMethodCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):
(WebCore::V8Document::createTouchListMethodCustom):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionMethodCustom):
(WebCore::V8Geolocation::watchPositionMethodCustom):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::itemMethodCustom):
(WebCore::V8HTMLAllCollection::namedItemMethodCustom):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):
(WebCore::V8HTMLCanvasElement::toDataURLMethodCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::writeMethodCustom):
(WebCore::V8HTMLDocument::writelnMethodCustom):
(WebCore::V8HTMLDocument::openMethodCustom):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::V8HTMLFormControlsCollection::namedItemMethodCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorMethodCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::setSelectionRangeMethodCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::namedItemMethodCustom):
(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::addMethodCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::removeMethodCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateMethodCustom):
(WebCore::V8History::replaceStateMethodCustom):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectMethodCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameMethodCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::functionDetailsMethodCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
(WebCore::V8InjectedScriptHost::inspectMethodCustom):
(WebCore::V8InjectedScriptHost::databaseIdMethodCustom):
(WebCore::V8InjectedScriptHost::storageIdMethodCustom):
(WebCore::V8InjectedScriptHost::evaluateMethodCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueMethodCustom):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformMethodCustom):
(WebCore::V8InspectorFrontendHost::portMethodCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuMethodCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenMethodCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownMethodCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedMethodCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateMethodCustom):
(WebCore::V8JavaScriptCallFrame::restartMethodCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueMethodCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeMethodCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
(WebCore::V8Location::reloadMethodCustom):
(WebCore::V8Location::replaceMethodCustom):
(WebCore::V8Location::assignMethodCustom):
(WebCore::V8Location::valueOfMethodCustom):
(WebCore::V8Location::toStringMethodCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventMethodCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventMethodCustom):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::V8MessagePort::postMessageMethodCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionMethodCustom):

  • bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionMethodCustom):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemMethodCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlMethodCustom):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlMethodCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsMethodCustom):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getExtensionMethodCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsMethodCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvMethodCustom):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsMethodCustom):
(WebCore::V8WorkerContext::setTimeoutMethodCustom):
(WebCore::V8WorkerContext::setIntervalMethodCustom):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::postMessageMethodCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openMethodCustom):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::setParameterMethodCustom):
(WebCore::V8XSLTProcessor::getParameterMethodCustom):
(WebCore::V8XSLTProcessor::removeParameterMethodCustom):

12:44 PM Changeset in webkit [143849] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip javascriptDialogEvents.html since its result bleed into other tests non-deterministically per bug 110186.

  • platform/mac/TestExpectations:
12:41 PM Changeset in webkit [143848] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

Scrollbar style resolution arguments should not passed via statics.
https://bugs.webkit.org/show_bug.cgi?id=110690

Use PseudoStyleRequest to pass scrollbar params for style resolve.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Changed to use context params, rather than statics.
(WebCore::SelectorChecker::checkOne): Changed to pass context to checkScrollbarPseudoClass.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Changed to use context params, rather than statics.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added scrollbar style args.
(SelectorCheckingContext): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use PseudoStyleRequest.
(WebCore::StyleResolver::State::initForStyleResolve): Ditto.
(WebCore::StyleResolver::pseudoStyleForElement): Ditto.
(WebCore::StyleResolver::ruleMatches): Ditto and added stuffing scrollbar style resolve args into SelectorCheckingContext.

  • css/StyleResolver.h:

(PseudoStyleRequest): Added.
(State): Changed to hold and use PseudoStyleRequest instead of just PseudoId

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid): Changed to use PseudoStyleRequest.

  • page/FrameView.cpp: Ditto.

(WebCore::FrameView::updateScrollCorner): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollCornerStyle): Ditto.
(WebCore::RenderLayer::updateResizerStyle): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor): Ditto.
(WebCore::RenderObject::selectionColor): Ditto.
(WebCore::firstLineStyleForCachedUncachedType): Ditto.
(WebCore::RenderObject::getCachedPseudoStyle): Ditto.
(WebCore::RenderObject::getUncachedPseudoStyle): Ditto.

  • rendering/RenderObject.h:

(RenderObject): Ditto.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Ditto.

  • rendering/RenderScrollbar.h:

(RenderScrollbar): Removed static members that are now obsolete.

12:00 PM Changeset in webkit [143847] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/efl/TestExpectations: Adding a failure expectation for the html5lib/runner.html test

that started failing with r143804.

  • platform/gtk/TestExpectations: Ditto. Also adding flaky crasher expectations for two http tests,

crashes are originating from IDB code and starter appearing with r143694.

11:57 AM Changeset in webkit [143846] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • public/WebKit.h:

(WebKit):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

10:37 AM Changeset in webkit [143845] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/parser-yield-timing.html
https://bugs.webkit.org/show_bug.cgi?id=110647

Reviewed by Eric Seidel.

Previously, the threaded HTML parser would run for an arbitrary amount
of time without yielding after speculation succeeded. This might be the
cause of the good DOMContentLoaded numbers.

Note: This patch also demonstrates that the ParseHTML_max numbers
aren't correct currently because they're measuring the interior of this
loop instead of all the time spent in the loop. We should move the
instrumentation in a followup patch.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLParserScheduler.cpp:
10:22 AM Changeset in webkit [143844] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-23
Reviewed by Dirk Pranke.

  • WebCore.gyp/WebCore.gyp: Moved shared include directories to

WebCore.gypi.

  • WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
  • WebCore.gypi: Added shared include directories.
9:57 AM Changeset in webkit [143843] by akling@apple.com
  • 64 edits in trunk/Source/WebCore

StyledElement: Tweak signature of collectStyleForPresentationAttribute().
<http://webkit.org/b/110687>

Reviewed by Antti Koivisto.

Out with the old:

collectStyleForPresentationAttribute(const Attribute&, StylePropertySet*)

In with the new:

collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*)

This is primarily about switching to using MutableStylePropertySet* in preparation for
removing mutating functions from the StylePropertySet base class.

8:55 AM Changeset in webkit [143842] by commit-queue@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/Source/WebCore

[EFL][WebGL] Refactor GLPlatformSurface.
https://bugs.webkit.org/show_bug.cgi?id=110616

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-23
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

With recent changes, there is a clear separation between
transport surface and off-screen surface. PlatformSurface
has the logic to render content to transport surface.
We currently rely on EXT_framebuffer_blit for this. This
extension is not exposed on GLES2.0. PlatformSurface was
supposed to be an abstraction layer without any knowledge
of the type of surface. This patch addresses the issues
in PlatformSurface class. We use shaders to draw texture
content to the surface. Any transport surface related
code in PlatformSurface is moved to GLTransportSurface class.

  • PlatformEfl.cmake:
  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::didResizeCanvas):

  • platform/graphics/surfaces/GLTransportSurface.cpp: Added.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):

  • platform/graphics/surfaces/GLTransportSurface.h:

(WebCore):
(GLTransportSurface):

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):

  • platform/graphics/surfaces/egl/EGLSurface.h:
  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):

  • platform/graphics/surfaces/glx/GLXSurface.h:
8:16 AM Changeset in webkit [143841] by Martin Robinson
  • 41 edits
    25 adds in trunk/LayoutTests

Remove some tests needing to be rebaselined from TestExpectations

  • platform/gtk/TestExpectations: Update the list of tests needing new baselines

and skip some that are timing out on my machine.

  • platform/gtk/accessibility/color-well-expected.txt: Added.
  • platform/gtk/accessibility/image-link-expected.txt: Added.
  • platform/gtk/accessibility/image-map1-expected.txt: Added.
  • platform/gtk/accessibility/image-map2-expected.txt: Added.
  • platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Added.
  • platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
  • platform/gtk/accessibility/notification-listeners-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt:
  • platform/gtk/editing/selection/extend-by-sentence-001-expected.png:
  • platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/gtk/fast/block/float/024-expected.png:
  • platform/gtk/fast/block/float/024-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Added.
  • platform/gtk/fast/css/resize-corner-tracking-expected.png:
  • platform/gtk/fast/css/resize-corner-tracking-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/gtk/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
  • platform/gtk/fast/inline/justify-emphasis-inline-box-expected.png: Added.
  • platform/gtk/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
  • platform/gtk/fast/repaint/caret-with-transformation-expected.png: Added.
  • platform/gtk/fast/repaint/caret-with-transformation-expected.txt: Added.
  • platform/gtk/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/gtk/fast/text/whitespace/006-expected.png:
  • platform/gtk/fast/text/whitespace/006-expected.txt:
  • platform/gtk/fast/text/whitespace/007-expected.png:
  • platform/gtk/fast/text/whitespace/007-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.png: Added.
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-strict-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
  • platform/gtk/svg/batik/text/xmlSpace-expected.png:
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt:
  • platform/gtk/svg/carto.net/combobox-expected.png:
  • platform/gtk/svg/carto.net/combobox-expected.txt:
  • platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
  • platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
  • platform/gtk/svg/filters/filter-hidden-content-expected.png: Added.
  • platform/gtk/svg/filters/filter-hidden-content-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
3:26 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
Add bug #110614 to proposed merges for 1.11.91 (diff)
2:49 AM Changeset in webkit [143840] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777

Reviewed by Dimitri Glazkov.

This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.

Detail:

  • Document::m_guardRefCount and related funcdtions are moved to TreeScope
  • Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
  • Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.

No new tests. Covered by existing tests.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()

  • dom/Document.h:

(WebCore::Node::isTreeScope):
(WebCore::Node::Node):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):

  • dom/Node.h:

(WebCore::Node::setTreeScope):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/TreeScope.cpp:

(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.

  • dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.

(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

1:03 AM Changeset in webkit [143839] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit):

12:54 AM Changeset in webkit [143838] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Don't include ResourceHandle.h in ResourceLoaderOptions.h
https://bugs.webkit.org/show_bug.cgi?id=110662

Reviewed by Tim Horton.

  • loader/ResourceLoaderOptions.h: Include ResourceHandleTypes.h instead.
12:14 AM Changeset in webkit [143837] by commit-queue@webkit.org
  • 31 edits in trunk

Source/WebCore: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::setAutofilled):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests: Moved setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

  • fast/forms/input-autofilled.html:
  • fast/forms/reset-autofilled.html:
  • platform/wk2/TestExpectations:

Feb 22, 2013:

10:16 PM Changeset in webkit [143836] by commit-queue@webkit.org
  • 43 edits
    1 copy
    5 moves
    3 deletes in trunk/LayoutTests

Rebaseline ports after bug 109994
https://bugs.webkit.org/show_bug.cgi?id=110551

Unreviewed rebaseline of test expectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-22

  • css2.1/20110323/replaced-elements-001-expected.txt: Renamed from LayoutTests/platform/mac/css2.1/20110323/replaced-elements-001-expected.txt.
  • fast/forms/button-generated-content-expected.txt:
  • fast/forms/select-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-baseline-expected.txt.
  • platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac-lion/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
  • platform/chromium-win/fast/forms/button-generated-content-expected.txt:
  • platform/chromium-win/fast/forms/select-baseline-expected.png:
  • platform/chromium-win/fast/forms/select-baseline-expected.txt:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/efl/fast/forms/button-generated-content-expected.txt:
  • platform/efl/fast/forms/select-baseline-expected.txt:
  • platform/efl/svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt.
  • platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/svg/custom/foreign-object-skew-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/fast/forms/select-baseline-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/qt/fast/forms/button-generated-content-expected.txt:
  • platform/qt/fast/forms/select-baseline-expected.txt:
  • platform/qt/svg/custom/foreign-object-skew-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/win-future/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/fast/forms/button-generated-content-expected.txt.
  • svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/chromium/svg/custom/foreign-object-skew-expected.txt.
  • tables/mozilla/bugs/bug92647-2-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug92647-2-expected.txt.
9:40 PM Changeset in webkit [143835] by Martin Robinson
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Expose all dependencies to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=110498

Reviewed by Dirk Pranke.

  • gyp/Configuration.gypi.in: Add the missing configuration cflags here.
  • gyp/Dependencies.gyp: Add targets for all missing dependencies.
8:47 PM Changeset in webkit [143834] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Attr: Simplify modification callbacks.
<http://webkit.org/b/110598>

Reviewed by Antti Koivisto.

Instead of Attr being a friend of Element and grabbing at various internal storage and callbacks,
let Attr simply call Element::setAttribute() when its value is changed, and do all that business
from Element.

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

Call Attr::recreateTextChildAfterAttributeValueChanged() after modifying an attribute value instead
of doing the modification through the Attr node.

  • dom/Attr.h:
  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::childrenChanged):

Added an m_inChildrenChanged flag so we can prevent infinite callback recursion in childrenChanged().

(WebCore::Attr::setValue):

Call Element::setAttribute() instead of modifying the attribute storage directly.

(WebCore::Attr::recreateTextChildAfterAttributeValueChanged):

Factored out the "remove all children / create a new text child with attribute value" logic into
a separate function.

8:28 PM Changeset in webkit [143833] by rniwa@webkit.org
  • 12 edits in trunk/Tools

Upload results to perf.webkit.org in addition to the one specified by --test-results-server
https://bugs.webkit.org/show_bug.cgi?id=108577

Reviewed by Dirk Pranke.

Upload results to perf.webkit.org using new JSON format as well as the host specified by
--test-results-server. The new format is needed to provide extra information perf.webkit.org
need such as the subversion commit time and test URLs. This is a temporarily measure until
we complete the transition and the old JSON format and the code to upload results to
webkit-perf.appspot.com can be deleted.

This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
so that the app can sort performance test results based on the timestamp of the last commit.

It also changes the repository names returned by port objects to be properly capitalized
human readable names such as WebKit instead of lowercased names such as webkit since these names
are displayed on perf.webkit.org for humans. Several users of this feature has been updated
to explicitly lowercase the names.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
git's timestamp granularity is seconds so we're losing some information compared to using a regular
subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
UTC so we're going to manually fiddle with timezone.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.timestamp_of_latest_commit): Added.

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.timestamp_of_latest_commit): Added.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
the timestamp which is always in UTC.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
'chromium' needs to be substituted by 'chrome' for historical reasons.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths): Return WebKit instead of webkit as noted above.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init): Store the current time in UTC as well as in local time.
(PerfTestsRunner._collect_tests):

(PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
and upload them appropriately.

(PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
in revisions_for_perf_webkit and construct an output for perf.webkit.org.

(PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.

(PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
e.g. "processor" would be renamed to "builderProcessor".

(PerfTestsRunner._generate_output_files):

(PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
webkit-perf.appspot.com which spits out a plaintext response.

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
(MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
cases to parse JSON responses.
(MainTest.test_upload_json.MockFileUploader): Refactored.
(MainTest.test_upload_json.MockFileUploader.reset): Added.
(MainTest.test_upload_json.MockFileUploader.init):
(MainTest.test_upload_json.MockFileUploader.upload_single_text_file):

8:14 PM Changeset in webkit [143832] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source

[EFL] Use EINA_LOG instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=110313

Reviewed by Laszlo Gombos.

Replace fprintf with EINA_LOG.

Source/WebCore:

  • platform/efl/NetworkInfoProviderEfl.cpp:

(WebCore::NetworkInfoProviderEfl::startUpdating):

  • platform/graphics/efl/CairoUtilitiesEfl.cpp:

(WebCore::evasObjectFromCairoImageSurface):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(_ewk_frame_debug):

7:43 PM Changeset in webkit [143831] by Lucas Forschler
  • 6 edits in tags/Safari-537.31.7/Source

Rollout r143761.

7:28 PM Changeset in webkit [143830] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Threaded HTML parser fails resources/plain-text-unsafe.dat
https://bugs.webkit.org/show_bug.cgi?id=110538

Reviewed by Eric Seidel.

With this patch, the background HTML parser passes all tests in plain-text-unsafe.dat.

No new tests because covered by existing tests.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::tokenExitsSVG):
(WebCore):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

7:18 PM Changeset in webkit [143829] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Add temporary work around for 32-bit plugins not working in production builds as XPCServices
https://bugs.webkit.org/show_bug.cgi?id=110680
<rdar://problem/13236883>

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Temporarily don't use XPC for plug-ins for Safari while we figure out why the
32-bit XPCService is being built universal.

7:14 PM Changeset in webkit [143828] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct InspectorInstrumentation for background HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110678

Reviewed by Adam Barth.

resumeParsingAfterScriptExecution potentially calls processParsedChunkFromBackgroundParser multiple times
without yielding. So it is not correct to count each of those as a separate ParseHTML event.

This patch moves the instrumentation outside of the loop.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

6:54 PM Changeset in webkit [143827] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
https://bugs.webkit.org/show_bug.cgi?id=110668

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-22
Reviewed by Adam Barth.

This fixes http://crbug.com/172764

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::destoryPage):

6:48 PM Changeset in webkit [143826] by acolwell@chromium.org
  • 15 edits
    5 adds in trunk/Source

Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
https://bugs.webkit.org/show_bug.cgi?id=109857

Reviewed by Adam Barth.

Source/WebCore:

This is a simple refactor that moves MediaSource related methods out of MediaPlayer & MediaPlayerPrivate
so that the MediaSource implementation can be updated without further polluting these interfaces.
MediaSourcePrivate is the new WebCore interface that ports must implement to support the MediaSource API.

No new tests. No user visible behavior has changed.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::duration):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::append):
(WebCore::MediaSource::abort):
(WebCore::MediaSource::setTimestampOffset):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop):

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::reportMemoryUsage):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/MediaPlayer.cpp:

(NullMediaPlayerPrivate):
(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load):
(WebCore):
(WebCore::MediaPlayer::loadWithNextMediaEngine):

  • platform/graphics/MediaPlayer.h:

(WebCore):
(MediaPlayerClient):
(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/MediaSourcePrivate.h: Added.

(WebCore):
(MediaSourcePrivate): Contains the MediaSource methods extracted from MediaPlayer.
(WebCore::MediaSourcePrivate::MediaSourcePrivate):
(WebCore::MediaSourcePrivate::~MediaSourcePrivate):

Source/WebKit/chromium:

WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
media player interfaces.

  • WebKit.gyp:
  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::load):

  • public/WebMediaPlayerClient.h:

(WebKit):

  • public/WebMediaSource.h: Added.

(WebKit):
(WebMediaSource):
(WebKit::WebMediaSource::~WebMediaSource):

  • public/WebMediaSourceClient.h: Added.

(WebKit):
(WebMediaSourceClient):
(WebKit::WebMediaSourceClient::~WebMediaSourceClient):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium

changes land.

(WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::addId):
(WebKit::WebMediaSourceClientImpl::removeId):
(WebKit::WebMediaSourceClientImpl::buffered):
(WebKit::WebMediaSourceClientImpl::append):
(WebKit::WebMediaSourceClientImpl::abort):
(WebKit::WebMediaSourceClientImpl::duration):
(WebKit::WebMediaSourceClientImpl::setDuration):
(WebKit::WebMediaSourceClientImpl::endOfStream):
(WebKit::WebMediaSourceClientImpl::setTimestampOffset):
(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebMediaSourceImpl.cpp: Added.

(WebKit):
(MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::addId):
(WebKit::MediaSourcePrivateImpl::removeId):
(WebKit::MediaSourcePrivateImpl::buffered):
(WebKit::MediaSourcePrivateImpl::append):
(WebKit::MediaSourcePrivateImpl::abort):
(WebKit::MediaSourcePrivateImpl::duration):
(WebKit::MediaSourcePrivateImpl::setDuration):
(WebKit::MediaSourcePrivateImpl::endOfStream):
(WebKit::MediaSourcePrivateImpl::setTimestampOffset):
(WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::open):

  • src/WebMediaSourceImpl.h: Added.

(WebKit):
(WebMediaSourceImpl):

6:13 PM Changeset in webkit [143825] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>

Reviewed by Sam Weinig.

FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

6:09 PM Changeset in webkit [143824] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
6:00 PM Changeset in webkit [143823] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

More rebaselines after http://trac.webkit.org/changeset/143804.

  • html5lib/run-test1-expected.txt:
  • html5lib/run-test18-expected.txt:
  • html5lib/run-test7-expected.txt:
5:59 PM Changeset in webkit [143822] by acolwell@chromium.org
  • 4 edits in trunk

Disable MediaSource on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=110494

Reviewed by Tim Horton.

Source/WebKit:

  • WebKit.vcxproj/FeatureDefines.props:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
5:54 PM Changeset in webkit [143821] by rniwa@webkit.org
  • 11 edits
    4 adds in trunk

WebKit can erroneously strip font-size CSS property from font element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=110657

Reviewed by Justin Garcia.

Source/WebCore:

The bug was caused by ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
erroneously removing style attributes even on an element such as font that implicitly adds
editing style.

Fixed the bug by removing these elements or attributes when they conflict with the inline
style of the element. This is always safe because implicit style of an element is always
overridden by that of inline style.

Note that when the font element becomes "empty" (i.e. doesn't have any attributes), then
we also want to delete this font element as it doesn't contribute anything to the style.

Test: editing/pasteboard/insert-u-with-text-decoration-none.html

editing/pasteboard/insert-font-with-size-and-css.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::isEmptyFontTag): Added ShouldStyleAttributeBeEmpty as an argument. This will
allow removeRedundantStylesAndKeepStyleSpanInline to ignore style attribute when we know
the attribute can be removed.

  • editing/ApplyStyleCommand.h: Expose isEmptyFontTag and ShouldStyleAttributeBeEmpty.
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Added.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See above.

  • editing/ReplaceSelectionCommand.h:

(InsertedNodes): Added a declaration of didReplaceNode.

LayoutTests:

Added two regression tests to ensure WebKit doesn't erroneously remove inline styles of an element
when its implicit styles differ from the inline styles. Also rebaselined some tests as their results
have progressed.

  • editing/pasteboard/insert-u-with-text-decoration-none-expected.txt: Added.
  • editing/pasteboard/insert-u-with-text-decoration-none.html: Added.
  • editing/pasteboard/insert-font-with-size-and-css-expected.txt: Added.
  • editing/pasteboard/insert-font-with-size-and-css.html: Added.
  • editing/pasteboard/4744008-expected.txt:
  • editing/pasteboard/paste-text-with-style-5-expected.txt:
  • editing/pasteboard/paste-text-with-style-5.html:
  • editing/pasteboard/style-from-rules-expected.txt:
  • editing/pasteboard/style-from-rules.html:
5:32 PM Changeset in webkit [143820] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused make variable from DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=110306

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-22
Reviewed by Alexey Proskuryakov.

r107026 removed the last piece of logic that was guarded with
ENABLE_DASHBOARD_SUPPORT, so now it can be removed from
DerivedSources.make.

Also combined the way ENABLE_ORIENTATION_EVENTS is set to 0
to make it more readable.

No new tests, no new functionality.

  • DerivedSources.make:
5:15 PM Changeset in webkit [143819] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

REGRESSION(r130089): Scrollbar thumb no longer re-rendered on hover
https://bugs.webkit.org/show_bug.cgi?id=109230

Source/WebCore:

In r130089, I accidentally removed the extra check that made scrollbar
parts styles sad. I put it back and made them happy.

Reviewed by Eric Seidel.

Test: fast/css/pseudo-element-selector-scrollbar-hover.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Added the check back.

LayoutTests:

Reviewed by Eric Seidel.

  • fast/css/pseudo-element-selector-scrollbar-hover-expected.html: Added.
  • fast/css/pseudo-element-selector-scrollbar-hover.html: Added.
5:10 PM Changeset in webkit [143818] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead of doing its own thing
https://bugs.webkit.org/show_bug.cgi?id=110659

Reviewed by Oliver Hunt and Mark Hahnenberg.

This simplifies the code, and also has the effect that if speculateNumber() is called
prior to someone actually using the number in a double context, then the number will
already be up-converted to double and ready to go.

Previously if this ever came up, the subsequent use would have to again branch to see
if the value is tagged as int or tagged as double.

On the other hand, if you ever did speculateNumber() and then used the value as a
JSValue, this will be a slow down now.

I suspect that the former (speculateNumber() and then use as number) is more likely
than the latter (speculateNumber() and then use as JSValue).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNumber):

5:03 PM Changeset in webkit [143817] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG FixupPhase should have one common hook for knowing if a node is ever being speculated a certain way
https://bugs.webkit.org/show_bug.cgi?id=110650

Reviewed by Mark Hahnenberg.

Changes almost all calls to edge.setUseKind(kind) to be
setUseKindAndUnboxIfProfitable<kind>(edge). This will allow us to use the latter
as a hook for deciding which locals to unbox (webkit.org/b/110433).

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

4:57 PM Changeset in webkit [143816] by timothy_horton@apple.com
  • 4 edits in trunk/Source

[WK2] The root and page overlay layers should be the size of the view, not the content
https://bugs.webkit.org/show_bug.cgi?id=110660
<rdar://problem/13096456>

Reviewed by Simon Fraser.

Use the view size for the size of the root and page overlay layers.
For one, we never update these layers' sizes when the content size changes, causing size mismatches.
In addition, there's no reason an overlay shouldn't be able to draw outside of the bounds of the content.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

  • WebCore.exp.in:
4:43 PM Changeset in webkit [143815] by andersca@apple.com
  • 11 edits in trunk/Source

pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

Source/WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):
(WebKit::WebPageProxy::pluginInformationBundleIdentifierKey):
(WebKit):
(WebKit::WebPageProxy::pluginInformationBundleVersionKey):
(WebKit::WebPageProxy::pluginInformationDisplayNameKey):
(WebKit::WebPageProxy::pluginInformationFrameURLKey):
(WebKit::WebPageProxy::pluginInformationMIMETypeKey):
(WebKit::WebPageProxy::pluginInformationPageURLKey):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

4:35 PM Changeset in webkit [143814] by leviw@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

Unreviewed gardening, updating test expecations after r140374.

  • platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Removed.
  • platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
  • platform/chromium-win-xp/platform/chromium/fast/events/touch: Removed.
  • platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
4:21 PM Changeset in webkit [143813] by dpranke@chromium.org
  • 4 edits in trunk

Unreviewed, rolling out r143794.
http://trac.webkit.org/changeset/143794
https://bugs.webkit.org/show_bug.cgi?id=110542

debug linux builds broken?

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

LayoutTests:

  • platform/chromium/TestExpectations:
4:00 PM Changeset in webkit [143812] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644

Reviewed by Ryosuke Niwa.

Midpoints are used to delineate ranges where we don't add line boxes for contents (collapsed spaces),
and to explicitly split a RenderText into multiple text runs so that text paragraph seperators get
their own line boxes. This patch encapsulates the different cases where midpoints are added to
lineMidpointState into 4 helper functions to make it clearer what's going on in each case.

No new tests. No change in functionality.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::deprecatedAddMidpoint): Original function simply adds a midpoint to the lineMidpointState.
Renaming to deprecated to discourage callers.
(WebCore::startIgnoringSpaces): Adds a midpoint to start collapsing subsequent spaces. Asserts that
we have an even number of midpoints.
(WebCore::stopIgnoringSpaces): Adds the corresponding midpoint from startIgnoringSpaces and asserts
that it's an odd number.
(WebCore::ensureLineBoxInsideIgnoredSpaces): When ignoring spaces and we come across a RenderInline
that needs a line box, this function adds a pair of midpoints which ensures we'll later add a line
box for it.
(WebCore::ensureCharacterGetsLineBox): Adds a pair of midpoints in a text renderer to mark that
the current character needs its own line box. This is used by svg for absolutely positioned
characters, or for text paragraph seperators.

3:37 PM Changeset in webkit [143811] by jschuh@chromium.org
  • 2 edits in trunk/Source/WebCore

RenderArena masking has low entropy
https://bugs.webkit.org/show_bug.cgi?id=110394

Reviewed by Oliver Hunt.

No new tests. This is a hardening measure.

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):

3:28 PM Changeset in webkit [143810] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Remove old SerializedScriptValue-based get() callbacks
https://bugs.webkit.org/show_bug.cgi?id=110626

Reviewed by James Robinson.

Removal now that refactoring is complete.

  • public/WebIDBCallbacks.h:

(WebKit):

3:21 PM Changeset in webkit [143809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the overlay play button position on android
https://bugs.webkit.org/show_bug.cgi?id=110638

Patch by Min Qin <qinmin@chromium.org> on 2013-02-22
Reviewed by Ojan Vafai.

Because we are using flex box, specifying the height is not necessary.
Setting height to 100% will make the enclosure go outside the control panel.
There are no media layout test expecations for android, will do that in another patch.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-overlay-enclosure):

3:20 PM Changeset in webkit [143808] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed. Make WinTools.make stop copying vsprops into nested vsprops folders.

  • win/tools/WinTools.make:
3:15 PM Changeset in webkit [143807] by schenney@chromium.org
  • 2 edits
    24 adds in trunk/LayoutTests

[Chromium] Test expectations for newish tests

Unreviewed test expectations addition.

  • platform/chromium-linux-x86/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-linux-x86/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-linux/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/chromium-linux/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-linux/fast/text/orientation-sideways-expected.png: Added.
  • platform/chromium-linux/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/chromium-mac/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-mac/fast/text/orientation-sideways-expected.png: Added.
  • platform/chromium-mac/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/orientation-sideways-expected.png: Added.
  • platform/chromium-win-xp/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium-win/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/chromium-win/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/chromium-win/fast/text/orientation-sideways-expected.png: Added.
  • platform/chromium-win/fast/text/orientation-sideways-expected.txt: Added.
  • platform/chromium/TestExpectations:
3:04 PM Changeset in webkit [143806] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix. Added missing #if PLATFORM(CHROMIUM).

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

3:00 PM Changeset in webkit [143805] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Document::styleRecalc() and FrameView::layout() should be traced
https://bugs.webkit.org/show_bug.cgi?id=110646

Reviewed by Ojan Vafai.

Document::styleRecalc() and FrameView::layout() are key factors
for web page rendering performance. We should add TRACE_EVENT()
macros to these functions.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

2:57 PM Changeset in webkit [143804] by eric@webkit.org
  • 33 edits in trunk

Teach the html5lib tests how to test the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110643

Reviewed by Adam Barth.

Source/WebCore:

This adds a way to force data: url parsing to go through
the threaded parser, to enable us to test the threaded parser
using the html5lib test harness.

  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • page/Settings.in:

LayoutTests:

(window.onload):

  • html5lib/run-template-expected.txt:
  • html5lib/run-test10-expected.txt:
  • html5lib/run-test11-expected.txt:
  • html5lib/run-test12-expected.txt:
  • html5lib/run-test14-expected.txt:
  • html5lib/run-test15-expected.txt:
  • html5lib/run-test16-expected.txt:
  • html5lib/run-test17-expected.txt:
  • html5lib/run-test19-expected.txt:
  • html5lib/run-test2-expected.txt:
  • html5lib/run-test20-expected.txt:
  • html5lib/run-test21-expected.txt:
  • html5lib/run-test22-expected.txt:
  • html5lib/run-test23-expected.txt:
  • html5lib/run-test24-expected.txt:
  • html5lib/run-test25-expected.txt:
  • html5lib/run-test26-expected.txt:
  • html5lib/run-test3-expected.txt:
  • html5lib/run-test4-expected.txt:
  • html5lib/run-test5-expected.txt:
  • html5lib/run-test6-expected.txt:
  • html5lib/run-test8-expected.txt:
  • html5lib/run-test9-expected.txt:
  • html5lib/runner-expected.txt:
  • platform/chromium/html5lib/run-test1-expected.txt:
  • platform/chromium/html5lib/run-test18-expected.txt:
  • platform/chromium/html5lib/run-test7-expected.txt:
2:42 PM Changeset in webkit [143803] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

[chromium] Register newly-created layers for animation
https://bugs.webkit.org/show_bug.cgi?id=106594

Patch by Ali Juma <ajuma@chromium.org> on 2013-02-22
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::registerForAnimations):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/GraphicsLayerFactoryChromium.cpp: Added.

(WebKit):
(WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):

  • src/GraphicsLayerFactoryChromium.h: Added.

(WebKit):
(GraphicsLayerFactoryChromium):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::registerForAnimations):

  • src/WebViewImpl.h:

(WebViewImpl):

2:39 PM Changeset in webkit [143802] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

fast/parser/parser-yield-timing.html doesn't integrate with js-test-pre correctly
https://bugs.webkit.org/show_bug.cgi?id=110645

Reviewed by Eric Seidel.

  • fast/parser/parser-yield-timing.html:
2:38 PM Changeset in webkit [143801] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

Increase the max preferred width of tables to 1000000
https://bugs.webkit.org/show_bug.cgi?id=110545

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/table/large-shrink-wrapped-width.html

The old limit of 15000 was picked arbitrarily to avoid overflow.
No need to pick such a small number.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computeInstrinsicLogicalWidths):
As best I can tell, this code is just wrong. Removing this makes the
new test pass and doesn't cause any test failure. While we have many
tests that hit this codepath, this code would only
show a difference in the cases where the available container width is
greater then 15000, and I don't think we have any tests that hit that case
other than this new one.

  • rendering/TableLayout.h:

LayoutTests:

  • fast/table/large-shrink-wrapped-width-expected.txt: Added.
  • fast/table/large-shrink-wrapped-width.html: Added.
2:38 PM Changeset in webkit [143800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r143654): some fast/js test crashes on 32 bit build
https://bugs.webkit.org/show_bug.cgi?id=110590

Reviewed by Mark Hahnenberg.

In compileValueToInt32, the refactoring in r143654 undid one of the fixes from
r143314 due to a merge goof.

In speculateNumber, we were simply forgetting to indicate that we need a
ManualOperandSpeculation on a JSValueOperand. ManualOperandSpeculation should
be passed whenever you will be performing the type checks yourself rather than
using the operand class to do it for you.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):

2:30 PM Changeset in webkit [143799] by vollick@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test expectations for XP after 143554
https://bugs.webkit.org/show_bug.cgi?id=110636

Unreviewed gardening.

  • platform/chromium/TestExpectations:
2:19 PM Changeset in webkit [143798] by dgrogan@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 143512

IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::openDB):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12326083

2:17 PM Changeset in webkit [143797] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
https://bugs.webkit.org/show_bug.cgi?id=110637

Reviewed by Eric Seidel.

With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.

Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).

This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.

  • dom/DocumentParser.h:

(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

2:16 PM Changeset in webkit [143796] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[BlackBerry] Reread cookies when retrying a request with new auth credentials
https://bugs.webkit.org/show_bug.cgi?id=110628

Patch by Joe Mason <jmason@rim.com> on 2013-02-22
Reviewed by George Staikos.

Internal PR: 298805
Internally Reviewed By: Leo Yang

The "isRedirect" parameter of initializePlatformRequest is only used to decide whether to
reread cookies. Since we must reread cookies when resending a request with new auth
credentials as well, rename this to "rereadCookies".

The only caller which sets this parameter rather than using the default value is
NetworkManager::startJob, which also has other processing on redirect. So add a new
"rereadCookies" parameter to startJob and ensure it is always set to true on a redirect, but
can also be set to true on a non-redirect. And when startJob is called due to new auth
credentials, set it to true.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest): Add rereadCookies parameter, pass it to
startJob.
(WebCore::NetworkJob::handleRedirect): Set new rereadCookies param of startNewJob to true.
(WebCore::NetworkJob::notifyChallengeResult): Set new rereadCookies param of startNewJob to
true.

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob): Add rereadCookies parameter to startNewJobWithRequest.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob): Add rereadCookies parameter, pass it instead of
redirectCount to initializePlatformRequest.

  • platform/network/blackberry/NetworkManager.h:

(NetworkManager): Add rereadCookies parameter to startJob.

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest): Rename isRedirect parameter to rereadCookies.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest): Rename isRedirect to rereadCookies.

2:15 PM Changeset in webkit [143795] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use CFNotificationCenter instead of NSNotificationCenter for SharedTimerIOS
https://bugs.webkit.org/show_bug.cgi?id=110544

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-22
Reviewed by Daniel Bates.

Previously, we were instantiating the Obj-C object WebCoreResumeNotifierIOS
with the only purpose of forwarding one notification to a C function.

This patch updates the code to use CFNotificationCenter to dispatch the notification
without the intermediary object.

  • platform/ios/SharedTimerIOS.mm:

(WebCore::applicationDidBecomeActive):
(WebCore::setSharedTimerFireInterval):

2:12 PM Changeset in webkit [143794] by dpranke@chromium.org
  • 4 edits in trunk

[chromium] enable the fixed version of freetype on linux
https://bugs.webkit.org/show_bug.cgi?id=110542

Reviewed by Tony Chang.

Tools:

Switch to building with a fixed version of FreeType for
just DumpRenderTree. This allows us to share one version
of pixel baselines for both Lucid and Precise, and run
the layout tests in a stock Precise install (instead of a Lucid
chroot). Going forward, this approach isolates us from os-level
changes to the version of FreeType. Note that Chromium itself
still uses the system FreeType and is unaffected by this change.

This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

LayoutTests:

Add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.

  • platform/chromium/TestExpectations:
2:10 PM Changeset in webkit [143793] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose shadowRoot to the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=110522

Reviewed by Dimitri Glazkov.

  • public/WebElement.h:

(WebElement):

  • src/WebElement.cpp:

(WebKit::WebElement::shadowRoot):
(WebKit):

2:10 PM Changeset in webkit [143792] by kbr@google.com
  • 6 edits
    10 adds in trunk

Uint8ClampedArray constructor is wrong in WorkerContext.idl
https://bugs.webkit.org/show_bug.cgi?id=110634

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/canvas/webgl/typed-arrays-in-workers.html

webgl/conformance/typedarrays/typed-arrays-in-workers.html

  • workers/WorkerContext.idl:

LayoutTests:

Added copy of new WebGL conformance test both in old location
(fast/canvas/webgl) and new location (webgl -- not yet being run
on any ports) to avoid losing test coverage after cutover.

  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/resources/typed-array-test-cases.js: Added.
  • fast/canvas/webgl/resources/typed-array-worker.js: Added.

(constructTypedArray):
(constructDataView):
(onmessage):

  • fast/canvas/webgl/typed-arrays-in-workers-expected.txt: Added.
  • fast/canvas/webgl/typed-arrays-in-workers.html: Added.
  • webgl/conformance/typedarrays/typed-arrays-in-workers-expected.txt: Added.
  • webgl/conformance/typedarrays/typed-arrays-in-workers.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt:
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
  • webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-test-cases.js: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-worker.js: Added.

(constructTypedArray):
(constructDataView):
(onmessage):

  • webgl/resources/webgl_test_files/conformance/typedarrays/typed-arrays-in-workers.html: Added.
2:07 PM Changeset in webkit [143791] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Add some checks to DatabaseTracker::getMaxSizeForDatabase() to ensure
that it returns a sane value.
https://bugs.webkit.org/show_bug.cgi?id=110557.

Reviewed by Geoffrey Garen.

No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. Once the test webpages are loaded, you will
need to monitor the database directory and its files to confirm that
growth is bounded. Also try reloading the test in the tabs. At no
time should any database file ever exceed the quota.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

2:06 PM Changeset in webkit [143790] by andersca@apple.com
  • 11 edits in trunk

Source/WebKit2: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

  • UIProcess/WebUIClient.cpp:

(WebKit):

  • UIProcess/WebUIClient.h:

(WebUIClient):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

2:00 PM Changeset in webkit [143789] by simonjam@chromium.org
  • 3 edits
    2 adds in trunk

Preloads should be cleared when JavaScript cancels loading prematurely.
https://bugs.webkit.org/show_bug.cgi?id=110388

Reviewed by Antti Koivisto.

Source/WebCore:

If a page preloads a resource, but JavaScript aborts parsing for any reason (for example, a
redirect or document.write()), the resource is forever marked a preload and won't be reloaded
even if it's explicitly marked no-cache and the page is reloaded.

Test: http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html

  • dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::finishedParsing):

LayoutTests:

  • http/tests/cache/preload-cleared-after-parrsing-canceled-by-js-expected.txt: Added.
  • http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html: Added.
1:50 PM Changeset in webkit [143788] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Expect editing/spelling/spelling-changed-text.html to fail on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-22
Reviewed by Ryosuke Niwa.

Qt and GTK layout tests do not mark the word "wellcome" as a misspelling in
editing/spelling/spelling-changed-text.html layout test. This patch disables
editing/spelling/spelling-changed-text.html on Qt and GTK platforms.

  • platform/gtk/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].
  • platform/qt/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].
1:45 PM Changeset in webkit [143787] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505

Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.

This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.

Reviewed by Simon Fraser.

No new tests.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore):
(WebCore::RenderLayerCompositor::logReasonsForCompositing):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

1:41 PM Changeset in webkit [143786] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate invalid clipping for content editable selections
https://bugs.webkit.org/show_bug.cgi?id=110630

Reviewed by Rob Buis.

PR 284629.

Remove selection clipping for content editable
fields as the bounds aren't valid and cause
clipping based on starting node rather than the
union of nodes.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):

1:38 PM Changeset in webkit [143785] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

ScrollingStateTree::rootStateNode() should be null-checked since it can be null
https://bugs.webkit.org/show_bug.cgi?id=110631

Reviewed by Simon Fraser.

This is a speculative fix for <rdar://problem/13233090> and
<rdar://problem/12519348>. It is totally possible for rootStateNode() to be null,
so we should null-check it.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinatorMac::syncChildPositions):

1:30 PM Changeset in webkit [143784] by reed@google.com
  • 2 edits in trunk/Source/WebCore

Check for null-device when calling createCompatibleDevice
https://bugs.webkit.org/show_bug.cgi?id=107981

Reviewed by James Robinson.

No new tests. Current tests provided coverage. Site in the wild triggered the failure
(cairo failed to allocate a huge surface).

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

1:24 PM Changeset in webkit [143783] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.

Changing HitTestRequest::IgnoreClipping does not solve the problem that
FatFinger rect detect the element out of the viewport. We have to clip
the fatfinger rect according to the current viewport size to avoid picking
the element out of the viewport.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):

  • WebKitSupport/FatFingers.h:
1:20 PM Changeset in webkit [143782] by kbr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add script to generate LayoutTests from WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=110525

Patch by Gregg Tavares <Gregg Tavares> on 2013-02-22
Reviewed by Kenneth Russell.

Adds the script generate-webgl-tests.py which given a path
to the WebGL Conformance 'sdk/tests' folder generates and
or updates LayoutTests for WebGL. Example

git clone git://github.com/KhronosGroup/WebGL.git
generate-webgl-tests.py -w WebGL/sdk/tests -e

  • webgl/generate-webgl-tests.py: Added.

(ReadFile):
(WriteFile):
(CopyTree):
(FileReader):
(GreaterThanOrEqualToVersion):
(GetTestList):
(main):

  • webgl/resources/webgl-expectation-template.txt: Added.
  • webgl/resources/webgl-wrapper-template.html: Added.
12:49 PM Changeset in webkit [143781] by crogers@google.com
  • 15 edits in trunk/Source

AudioDestination::create() needs extra device identification information for live/local input streams
https://bugs.webkit.org/show_bug.cgi?id=109494

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

AudioDestination::create() supports live/local audio input. But, since there may be multiple
audio input devices available, an identifier for the requested input device needs to be
passed in. The embedder may then use this information so that the proper audio hardware is
accessed.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • Modules/webaudio/AudioDestinationNode.h:

(AudioDestinationNode):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):

  • Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

  • Modules/webaudio/OfflineAudioDestinationNode.h:
  • platform/audio/AudioDestination.h:

(AudioDestination):

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

  • platform/audio/chromium/AudioDestinationChromium.h:

(AudioDestinationChromium):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::create):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):

  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::deviceId):
(WebKit):
(WebKit::WebMediaStreamSource::setDeviceId):

  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::deviceId):
(WebCore::MediaStreamSource::setDeviceId):
(MediaStreamSource):

12:44 PM Changeset in webkit [143780] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removed expectations for tests that now pass. Adjusted an expectation for a flaky crasher.
Marked a few more sputnik tests as slow.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
12:41 PM Changeset in webkit [143779] by rniwa@webkit.org
  • 2 edits
    1 copy in trunk/LayoutTests

Mac WebKit2 rebaselines.

Partially revert http://trac.webkit.org/changeset/143709 since the expected result for
cross-origin-local-storage-wk1-expected.txt is different on Mac WebKit on the contrary to
the change log description in the changeset.

Also skip editing/spelling/spelling-changed-text.html on Mac since the test requires
the support for asynchronous spellchecking.

  • platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Copied

from platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt.

  • platform/mac/TestExpectations:
12:37 PM Changeset in webkit [143778] by aelias@chromium.org
  • 4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 143355

[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):

  • tests/WebFrameTest.cpp:

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330082

12:35 PM Changeset in webkit [143777] by aelias@chromium.org
  • 3 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 143032

[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901

Reviewed by James Robinson.

Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.

  • src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330081

12:34 PM Changeset in webkit [143776] by aelias@chromium.org
  • 4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142927

[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.

Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.

  • public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/WebViewTest.cpp:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12340032

12:33 PM Changeset in webkit [143775] by aelias@chromium.org
  • 4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142913

[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12315056

12:31 PM Changeset in webkit [143774] by aelias@chromium.org
  • 5 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142571

[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370

Reviewed by James Robinson.

Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.

I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).

New WebInputEventConversionTest: InputEventsScaling

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):

  • tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):
(WebCore):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12319074

12:30 PM Changeset in webkit [143773] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Add a Mac baseline for the test added in r142955.

  • platform/mac/TestExpectations:
  • platform/mac/svg/filters/filter-hidden-content-expected.png: Added.
  • platform/mac/svg/filters/filter-hidden-content-expected.txt: Added.
12:28 PM Changeset in webkit [143772] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Marking a bunch of (mostly Sputnik) tests as slow.
12:22 PM Changeset in webkit [143771] by rniwa@webkit.org
  • 15 edits in trunk/Source/WebCore

Binding tests rebaseline after r143737.

  • bindings/scripts/test/V8/V8Float64Array.cpp:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp:
  • bindings/scripts/test/V8/V8TestException.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestNode.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/V8/V8TestTypedefs.cpp:
12:18 PM Changeset in webkit [143770] by commit-queue@webkit.org
  • 6 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
https://bugs.webkit.org/show_bug.cgi?id=110431

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-02-22
Reviewed by Kent Tamura.

Source/WebCore:

Fixed a bug that hour-field does not accept "24" as a valid input when hour format is 1-24.
To test <input> against different time formats, added "pattern" attribute to DateTimeEditElement.

Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Overwrites layoutParameters.dateTimeFormat by pattern attribute of DateTimeEditElement (if exists).

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Fixed a bug where AM/PM value was passed to setHour().
(WebCore::DateTimeHourFieldElement::setValueAsInteger): Clamps the given value to 0-24 when the range of the field is 1-12 or 1-24. Renamed the parameter as it may not be an hour23 value (0-23).

LayoutTests:

Added test cases for hour formats 0-11 and 1-24.

  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
12:08 PM Changeset in webkit [143769] by kbr@google.com
  • 2 edits in trunk/Tools

Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.

  • Scripts/webkitpy/common/config/committers.py:
12:05 PM Changeset in webkit [143768] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Fix the 32-bit build by using the right data type in more places.

  • runtime/CodeCache.h:

(CodeCacheMap):

11:59 AM Changeset in webkit [143767] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617

Reviewed by Rob Buis.

PR 293598.

Don't reject key events that arrive when composing region is active,
this can prevent navigation events from firing, instead end
the composition and process the key.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

11:53 AM Changeset in webkit [143766] by zoltan@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Regions] Region boxes should respect -shape-inside CSS property
https://bugs.webkit.org/show_bug.cgi?id=107880

Reviewed by David Hyatt.

The shape-inside CSS property modifies the shape of the inner inline flow content from rectangular content box
to an arbitrary geometry. The detailed documentation is located in the CSS-Exclusions specification:
http://dev.w3.org/csswg/css3-exclusions/#shape-inside-property. This change adds support for the shape-inside property
on CSS Regions.

Source/WebCore:

Test: fast/regions/shape-inside-on-regions.html

  • rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::logicalTopOffset): Shape dimension should be relative to the current region.

  • rendering/ExclusionShapeInfo.h:

(ExclusionShapeInfo):
(WebCore::::logicalTopOffset): Move the implementation to ExclusionShapeInfo.cpp.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::logicalHeightForLine): Move the function prior to layoutExclusionShapeInsideInfo, since we need to use it there.
(WebCore):
(WebCore::layoutExclusionShapeInsideInfo): Add support for cases when shape-inside is a region-block property.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the exclusion shape information for every line, since the content
could flow through several region containers which can have different shape-inside properties.

LayoutTests:

  • fast/regions/shape-inside-on-regions-expected.html: Added.
  • fast/regions/shape-inside-on-regions.html: Added.
11:51 AM Changeset in webkit [143765] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Fix the 32-bit build by using the right data type.

  • runtime/CodeCache.h:

(JSC::CodeCacheMap::find):

11:48 AM Changeset in webkit [143764] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Two video contollers appear after exiting the fullscreen video when using menubar to exit.
https://bugs.webkit.org/show_bug.cgi?id=110506

Reviewed by Eric Carlson.

When we are notified that the fullscreen window is about to exit fullscreen mode unrequested,
call requestExitFullScreen(), as that will result in Document::webkitExitFullScreen() correctly
tearing down the fullscreen state.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

11:44 AM Changeset in webkit [143763] by kbr@google.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Mac OS build broken by new ExpressionParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=110629

Unreviewed build fix. Regenerated ExpressionParser with Bison 2.3.

  • src/compiler/preprocessor/ExpressionParser.cpp:
11:40 AM Changeset in webkit [143762] by ojan@chromium.org
  • 7 edits in trunk/Source/WebCore

Add computeInstrinsicLogicalWidths functions to TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110520

Reviewed by Tony Chang.

This is just a refactor in preparation for adding RenderTable::computeIntinsicLogicalWidths.
No change in behavior.

Split the computePreferredLogicalWidths functions into a computeIntinsicLogicalWidths
and a applyPreferredLogicalWidthQuirks. Also, move the addition of bordersPaddingAndSpacing
into RenderTable since both TableLayout subclasses need this.

This has the added readability benefit of better isolating the quirks that each table layout
mode requires.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):

  • rendering/AutoTableLayout.h:

(AutoTableLayout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::computeIntrinsicLogicalWidths):
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):

  • rendering/FixedTableLayout.h:

(FixedTableLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computePreferredLogicalWidths):

  • rendering/TableLayout.h:

(TableLayout):

11:25 AM Changeset in webkit [143761] by Lucas Forschler
  • 6 edits in tags/Safari-537.31.7/Source

Merged r143650. <rdar://problem/13250271>

11:16 AM Changeset in webkit [143760] by Lucas Forschler
  • 4 edits
    3 copies in tags/Safari-537.31.7

Merged r143269. <rdar://problem/13146994>

11:16 AM Changeset in webkit [143759] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Code cache size should adapt to workload
https://bugs.webkit.org/show_bug.cgi?id=110560

Reviewed by Antti Koivisto.

(*) 5% PLT arithmetic mean speedup
(*) 10% PLT geometric mean speedup
(*) 3.4X microbenchmark speedup
(*) Reduces initial cache capacity by 16X

  • runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache): Updated for interface change.

  • runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(SourceCodeValue): Turned the cache value into a struct so it can track its age.

(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(JSC::CodeCacheMap::pruneIfNeeded):
(CodeCache): Grow and shrink in response to usage.

11:14 AM Changeset in webkit [143758] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.7/Source/JavaScriptCore

Merged r143097. <rdar://problem/13146994>

11:09 AM Changeset in webkit [143757] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

[New Multicolumn] Correctly track whether or not a layer is paginated.
https://bugs.webkit.org/show_bug.cgi?id=110625.

Taking the first step towards implementing the correct spec-compliant painting
model for the new multi-column layout. Add code to make sure the paginated
bits in RenderLayer get propagated correctly for the new layout.

The main difference in bit propagation between the old multicolumn layout and
the new multicolumn layout is that the old layout only tracked pagination "roots",
since it has a broken layer painting model. It incorrectly treats a pagination
"root" inside a multi-column block as establishing a stacking context in each
column. This is incorrect.

The new multicolumn code is going to paint each paginated layer individually,
and this means the bits can't just be about roots. Instead they have to be set
on every layer that may be split across columns, without regard for whether parent
layers are also split or not. This is actually a simpler bit propagation model
than the old code.

Reviewed by Beth Dakin.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
Add code to set the m_isPaginated bit for in-flow RenderFlowThreads. This includes
only RenderMultiColumnFlowThread for now, but eventually it will also include
RenderPageFlowThread.

(WebCore::RenderLayer::useRegionBasedColumns):
Add a helper method to check if region-based columns are turned on, since we're
not attempting to alter the old column pagination model.

(WebCore::RenderLayer::updatePagination):
Added the code to propagate bits under the new model. Whether or not you're paginated
just depends on whether or not your enclosing layer along the containing block chain
is paginated.

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
Add code that avoids the old multi-column pagination model when the new column model
is enabled. For now there is no code in the new model that does anything with the bits,
but we're avoiding calling the old code, since it is broken for the new columns.

  • rendering/RenderLayer.h:

(RenderLayer):
Added the useRegionBasedColumns method to check the Setting.

  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isInFlowRenderFlowThread):
(RenderObject):
Implement isInFlowRenderFlowThread, a virtual function for asking if a renderer is
an in-flow RenderFlowThread, which means that it is going to need paginated layers
because the flow thread has to split across "pages" that do not establish stacking
contexts.

11:01 AM Changeset in webkit [143756] by adamk@chromium.org
  • 29 edits
    2 copies in branches/chromium/1410

Merge 143386

Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/MutationObserver/added-out-of-order.html:
  • fast/dom/MutationObserver/callback-arguments.html:
  • fast/dom/MutationObserver/clear-transient-without-delivery.html:
  • fast/dom/MutationObserver/create-during-delivery.html:
  • fast/dom/MutationObserver/cross-document.html:
  • fast/dom/MutationObserver/database-callback-delivery.html:
  • fast/dom/MutationObserver/delivery-order.html:
  • fast/dom/MutationObserver/disconnect-cancel-pending.html:
  • fast/dom/MutationObserver/document-fragment-insertion.html:
  • fast/dom/MutationObserver/end-of-task-delivery.html:
  • fast/dom/MutationObserver/filesystem-callback-delivery.html:
  • fast/dom/MutationObserver/inline-event-listener.html:
  • fast/dom/MutationObserver/mutate-during-delivery.html:
  • fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
  • fast/dom/MutationObserver/mutation-observer-constructor.html:
  • fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
  • fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
  • fast/dom/MutationObserver/mutation-record-nullity.html:
  • fast/dom/MutationObserver/observe-attributes.html:
  • fast/dom/MutationObserver/observe-characterdata.html:
  • fast/dom/MutationObserver/observe-childList.html:
  • fast/dom/MutationObserver/observe-exceptions.html:
  • fast/dom/MutationObserver/observe-subtree.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff.html:
  • fast/dom/MutationObserver/parser-mutations.html:
  • fast/dom/MutationObserver/removed-out-of-order.html:
  • fast/dom/MutationObserver/shadow-dom.html:
  • fast/dom/MutationObserver/takeRecords.html:
  • fast/dom/MutationObserver/transient-gc-crash.html:

TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/12317072

11:00 AM Changeset in webkit [143755] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.7/Source

Versioning.

10:58 AM Changeset in webkit [143754] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

text-overflow:ellipsis is not applied when the block contains nested blocks
https://bugs.webkit.org/show_bug.cgi?id=101879

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-22
Reviewed by Eric Seidel.

Source/WebCore:

Since text-overflow is not an inherited property, the anonymous blocks
don't know they should ellipse. This causes the anonymous blocks
created in the nested block situation to check their parent to find
out if they should ellipse.

Test: fast/css/text-overflow-ellipsis-anonymous-blocks.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Use the test from the specification that is supplied as part of the
bug.

  • fast/css/text-overflow-ellipsis-anonymous-blocks-expected.html: Added.
  • fast/css/text-overflow-ellipsis-anonymous-blocks.html: Added.
10:50 AM Changeset in webkit [143753] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554

Reviewed by Adam Barth.

Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

10:45 AM Changeset in webkit [143752] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142659

REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html

The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.

TBR=robert@webkit.org
Review URL: https://codereview.chromium.org/12335038

10:40 AM Changeset in webkit [143751] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.7

New Tag.

10:21 AM Changeset in webkit [143750] by mrowe@apple.com
  • 4 edits in trunk/Source/WebCore

Build fix after r143637.

  • WebCore.exp.in: Unconditionally export ScriptController::javaScriptContext.
  • bindings/js/ScriptController.h: Unconditionally define javaScriptContext for Mac builds.
  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::javaScriptContext): Move the #if inside the function, and return 0 when false.

10:20 AM Changeset in webkit [143749] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TextAutosizing] Refactoring to eliminate boolean parameter.
https://bugs.webkit.org/show_bug.cgi?id=110490

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-22
Reviewed by Julien Chaffraix.

A follow-up to the recent change that introduced a boolean parameter to
processClusterInternal method of TextAutosizer. Boolean parameters are discouraged by the
WebKit style guide. See http://trac.webkit.org/changeset/142866

Refactoring so no new tests.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::clusterMultiplier):

Calculates the font size multiplier for the specified cluster.

(WebCore::TextAutosizer::processClusterInternal):

Accepts the font size multiplier instead of |shouldBeAutosized|.

(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processCompositeCluster):

Both methods above now calculate the multiplier and then pass it to
processClusterInternal.

  • rendering/TextAutosizer.h:

Updated method declarations.

10:13 AM Changeset in webkit [143748] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use KURL::protocolIsInHTTPFamily instead of KURL::protocolInHTTPFamily
https://bugs.webkit.org/show_bug.cgi?id=110581

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

KURL::protocolInHTTPFamily() was removed in r109670.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore::ResourceRequest::clearHTTPContentType):

10:07 AM Changeset in webkit [143747] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build-fix after r143744.

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

10:05 AM Changeset in webkit [143746] by kareng@chromium.org
  • 4 edits in branches/chromium/1364/Source

Merge 142755

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12320068

9:56 AM Changeset in webkit [143745] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] throttle replayTraceLog messages to backend
https://bugs.webkit.org/show_bug.cgi?id=110591

Reviewed by Pavel Feldman.

The replayTraceLog message may be quite expensive. So, while such a request is processed by the
backend, user may well generate a dozen of new ones simply by walking through the DataGrid.
We should actually send to the backend only the last event from the queue.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):

9:53 AM Changeset in webkit [143744] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609

Reviewed by Antonio Gomes.

Revert r128869. InnerNode may now again be from a child document,
and should be handled and not asserted against.

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

9:47 AM Changeset in webkit [143743] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Element: Make updateName/updateId/updateLabel private.
<http://webkit.org/b/110603>

Reviewed by Antti Koivisto.

These methods are only called from inside Element so make them private and
move them to the .cpp file.

  • dom/Element.cpp:

(WebCore::Element::updateName):
(WebCore::Element::updateId):

  • dom/Element.h:
9:42 AM Changeset in webkit [143742] by zmo@google.com
  • 46 edits
    7 adds
    2 deletes in trunk/Source

Roll ANGLE to r1833
https://bugs.webkit.org/show_bug.cgi?id=110513

Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

Upstream ANGLE r1833 includes webkit side local fixes
1) r139758 build fix for -Wshorten-64-to-32
2) r139665 build fix for uninitialized variables

After this roll, WebKit side ANGLE is the same as upstream ANGLE r1833, except:
1) include/GLSLANG/ShaderLang.h, where "KHR" is removed from include path.

With this roll, we have EXT_draw_buffers support.

  • ANGLE.xcodeproj/project.pbxproj:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp:
  • src/common/system.h: Added.
  • src/common/version.h:
  • src/compiler/ArrayBoundsClamper.cpp: Removed.
  • src/compiler/ArrayBoundsClamper.h: Removed.
  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::getArrayBoundsClamper):
(TCompiler::getArrayIndexClampingStrategy):
(TCompiler::getBuiltInFunctionEmulator):

  • src/compiler/DetectDiscontinuity.cpp:

(sh::DetectLoopDiscontinuity::traverse):
(sh::DetectLoopDiscontinuity::visitLoop):
(sh):
(sh::DetectLoopDiscontinuity::visitBranch):

  • src/compiler/DetectDiscontinuity.h:

(DetectLoopDiscontinuity):

  • src/compiler/Initialize.cpp:

(InitExtensionBehavior):

  • src/compiler/Intermediate.cpp:

(TIntermConstantUnion::fold):
(TIntermTraverser::hash):

  • src/compiler/MapLongVariableNames.cpp:

(LongNameMap::Size):
(MapLongVariableNames::mapGlobalLongName):

  • src/compiler/MapLongVariableNames.h:

(LongNameMap):

  • src/compiler/OutputESSL.cpp:

(TOutputESSL::TOutputESSL):

  • src/compiler/OutputESSL.h:

(TOutputESSL):

  • src/compiler/OutputGLSL.cpp:

(TOutputGLSL::TOutputGLSL):

  • src/compiler/OutputGLSL.h:

(TOutputGLSL):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):

  • src/compiler/OutputGLSLBase.h:

(TOutputGLSLBase):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::output):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::writeConstantUnion):

  • src/compiler/ParseHelper.cpp:

(TParseContext::constructorErrorCheck):
(PaParseStrings):

  • src/compiler/ParseHelper.h:
  • src/compiler/ShHandle.h:

(TCompiler):

  • src/compiler/ShaderLang.cpp:

(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShCompile):
(ShGetInfo):
(ShGetActiveAttrib):
(ShGetActiveUniform):
(ShGetNameHashingEntry):

  • src/compiler/SymbolTable.h:

(TFunction::getParamCount):
(TFunction::getParam):
(TSymbolTable::setDefaultPrecision):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/ValidateLimitations.cpp:

(ValidateLimitations::validateFunctionCall):

  • src/compiler/VariablePacker.cpp:

(VariablePacker::GetNumRows):

  • src/compiler/glslang.h:
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(string_input):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/preprocessor/ExpressionParser.cpp:
  • src/compiler/preprocessor/ExpressionParser.y:
  • src/compiler/preprocessor/Input.cpp:

(pp::Input::Input):
(pp::Input::read):

  • src/compiler/preprocessor/Input.h:

(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):

  • src/compiler/preprocessor/Preprocessor.cpp:

(pp::Preprocessor::init):

  • src/compiler/preprocessor/Preprocessor.h:

(Preprocessor):

  • src/compiler/preprocessor/Tokenizer.cpp:

(pp::Tokenizer::init):

  • src/compiler/preprocessor/Tokenizer.h:

(Tokenizer):

  • src/compiler/preprocessor/Tokenizer.l:
  • src/third_party: Added.
  • src/third_party/compiler: Added.
  • src/third_party/compiler/ArrayBoundsClamper.cpp: Added.

(ArrayBoundsClamper::ArrayBoundsClamper):
(ArrayBoundsClamper::SetClampingStrategy):
(ArrayBoundsClamper::MarkIndirectArrayBoundsForClamping):
(ArrayBoundsClamper::OutputClampingFunctionDefinition):

  • src/third_party/compiler/ArrayBoundsClamper.h: Added.

(ArrayBoundsClamper):
(ArrayBoundsClamper::Cleanup):
(ArrayBoundsClamper::GetArrayBoundsClampDefinitionNeeded):
(ArrayBoundsClamper::SetArrayBoundsClampDefinitionNeeded):

  • src/third_party/compiler/LICENSE: Added.
  • src/third_party/compiler/README.angle: Added.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
9:28 AM Changeset in webkit [143741] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r143734.
http://trac.webkit.org/changeset/143734
https://bugs.webkit.org/show_bug.cgi?id=110615

Causes linux build failures. (Requested by vollick on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22

  • public/WebKit.h:

(WebKit):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

9:26 AM Changeset in webkit [143740] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[BlackBerry] Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=110577

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

Iterators were renamed to key/value in r130612.

Source/WebCore:

  • platform/blackberry/AuthenticationChallengeManager.cpp:

(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):

Source/WebKit/blackberry:

  • WebKitSupport/NotificationManager.cpp:

(BlackBerry::WebKit::NotificationManager::show):
(BlackBerry::WebKit::NotificationManager::clearNotifications):
(BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):

9:23 AM Changeset in webkit [143739] by rakuco@webkit.org
  • 4 edits
    6 deletes in trunk

[WTR] Do not dump information about empty subframes.
https://bugs.webkit.org/show_bug.cgi?id=110585

Reviewed by Simon Fraser.

Tools:

Follow DumpRenderTree more closely by skipping empty frames
(frames which have no document). We are not really interested in
showing anything about them.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpDescendantFramesText): Do not print subframe names when they
have no associated Document.

LayoutTests:

Remove some platform-specific expectations now that the results match
the base expectations.

  • platform/efl/TestExpectations: Unskip tests that are now passing.
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
  • platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
  • platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
8:55 AM Changeset in webkit [143738] by commit-queue@webkit.org
  • 6 edits
    2 copies
    2 adds in trunk/LayoutTests

Unreviewed, rolling out r143678 and r143702.
http://trac.webkit.org/changeset/143678
http://trac.webkit.org/changeset/143702
https://bugs.webkit.org/show_bug.cgi?id=110613

Breaks fast/loader/stateobjects/state-url-sets-links-
visited.html in Chromium (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22

  • fast/js/resources/js-test-pre.js:
  • fast/loader/stateobjects/state-url-sets-links-visited-expected.txt:
  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
  • platform/wk2/TestExpectations:
8:54 AM Changeset in webkit [143737] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Add comments to checkTypeOrDieTrying()
https://bugs.webkit.org/show_bug.cgi?id=110553

Reviewed by Adam Barth.

It is mysterious how the check is helpful. We need comments.

No tests. Just added comments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/v8/ScriptWrappable.h:

(ScriptWrappable):

8:51 AM Changeset in webkit [143736] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=110567

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

They were removed from ChromeClient in r122810 and are now
implemented in NavigatorContentUtilsClientBlackBerry since r131056.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

8:46 AM Changeset in webkit [143735] by mnaganov@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

[Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
https://bugs.webkit.org/show_bug.cgi?id=109946

Adding a WebView method for permanently setting initial page scale.
This override has higher priority than any calculated page scale
and viewport meta tag value.

Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
previously used by Android WebView.

Reviewed by Adam Barth.

  • public/WebView.h:

(WebView):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setInitialPageScaleOverride):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):

  • src/WebViewImpl.h:
  • tests/WebFrameTest.cpp:
8:41 AM Changeset in webkit [143734] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • public/WebKit.h:

(WebKit):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

8:33 AM Changeset in webkit [143733] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

32-bit build fix after r143706

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didReceiveData):

8:24 AM Changeset in webkit [143732] by kadam@inf.u-szeged.hu
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after 143626.

  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt/TestExpectations:
8:17 AM Changeset in webkit [143731] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do no show a single frame node in data grid
https://bugs.webkit.org/show_bug.cgi?id=110473

Reviewed by Pavel Feldman.

In a single canvas frame capture mode do not show the single "Frame #1" node.
Drive-by: Fix a wrong "this" pointer.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype.appendDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._flattenSingleFrameNode):

8:12 AM Changeset in webkit [143730] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609

Reviewed by Antonio Gomes.

Point based hit tests should not append but assign HitTestResults.

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

7:54 AM Changeset in webkit [143729] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: show source location after drawer views
https://bugs.webkit.org/show_bug.cgi?id=110156

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-22
Reviewed by Pavel Feldman.

  • Add statusBarText method
  • Add #drawer-view-anchor, which determines layout position of

drawerView

  • Fix layout in #panel-status-bar to avoid floating elements.

No new tests.

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown): Add statusBarItems before
drawer-view-anchor and statusBarText after.
(WebInspector.Panel.prototype.willHide): Remove statusBarText from DOM in the
way it's done for statusBarItems

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.statusBarText): Added.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.statusBarText): Added.
(WebInspector.SourceFrame.prototype.statusBarItems):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.statusBarText):

  • inspector/front-end/inspector.css:

(#drawer-view-anchor):
(.source-frame-cursor-position):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.showViewInDrawer):

  • inspector/front-end/timelinePanel.css:

(.timeline-records-stats):
(.timeline-records-stats-container):

7:31 AM Changeset in webkit [143728] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing tests on EFL bots.

  • platform/efl/TestExpectations:
6:46 AM Changeset in webkit [143727] by allan.jensen@digia.com
  • 15 edits
    3 adds in trunk

Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

Reviewed by Julien Chaffraix.

Source/WebCore:

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

This means that area-based hit-tests can now return elements from all the child frames
they intersect instead of just the one frame containing the center point. The improved
results from area-based hit-tests will among other things also improve touch adjustment
near frame boundaries.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

Recursion into child-frames have been moved to RenderFrameBase::nodeAtPoint, so
now hitTestResultAtPoint just needs to set AllowChildFrameContent.

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::parentShadowHostOrOwner):

New function to iterate up across frame boundaries.

(WebCore::TouchAdjustment::compileSubtargetList):

We need to iterate up across frame boundaries to avoid iframes competing with their
own content for touch adjustment.

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowsChildFrameContent):
(WebCore::HitTestRequest::isChildFrameHitTest):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::append):
(WebCore::HitTestResult::dictationAlternatives):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(HitTestResult):

m_hitTestLocation is now in main frame coordinates, which make m_pointInMainFrame
unnecessary, but requires the introduction of m_pointInInnerFrame, to remember
the coordinates of inner-node in its own frame.

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

The recursion into child-frames is now handled here instead of in hitTestResultAtPoint, this
allows us to recurse into multiple frames, instead of just one.

  • rendering/RenderFrameBase.h:

(RenderFrameBase):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

RenderLayer should not lie about being hit if the request is child-frame request.

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Extended so nodesFromRect with child-frame content can be tested.

LayoutTests:

A new tests for nodesFromRect that returns result from child frames.

  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
  • fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html:
  • fast/dom/nodesFromRect/resources/child-frame.html: Added.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):
(nodesFromRectAsString):

6:39 AM Changeset in webkit [143726] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>

Reviewed by Anders Carlsson.

Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery and a default constructor for Attribute.

  • dom/Attribute.cpp:

(WebCore::Attribute::Attribute):

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/Element.cpp:

(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):

  • dom/Element.h:

(ShareableElementData):
(WebCore::ElementData::attributeItem):

5:52 AM Changeset in webkit [143725] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] add a browser test for frames on timeline
https://bugs.webkit.org/show_bug.cgi?id=110592

  • factor out timeline recording logic from testPageOverlayUpdate for reuse;
  • record timeline while running a simple DOM-based animation;
  • assure we have frames and Style Recalc/Layout/Paint events in between.

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.TestSuite.prototype.assertHasKey):
(.TestSuite.prototype.testTimelineFrames.step1):
(.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
(.TestSuite.prototype.testTimelineFrames):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
(.TestSuite.prototype.recordTimeline.addRecord):
(.TestSuite.prototype.recordTimeline.innerAddRecord):
(.TestSuite.prototype.recordTimeline.done):
(.TestSuite.prototype.recordTimeline):
(.TestSuite.prototype.stopTimeline):

5:50 AM Changeset in webkit [143724] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused declaration: Element::removeCachedHTMLCollection()

Not reviewed by Antti Koivisto.

  • dom/Element.h:

(Element):

5:44 AM Changeset in webkit [143723] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add scroll view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110137

Reviewed by Kent Tamura.

Adding a scroll view class as part of the new calendar picker (Bug 109439).

No new tests. Code not yet used.

  • Resources/pagepopups/calendarPicker.js:

(View):
(View.prototype.offsetRelativeTo): Returns the offset position of this view relative to the given ancestor element.
(View.prototype.attachTo): Attaches view to a node or view.
(View.prototype.bindCallbackMethods): Binds all methods starting with "on" to this.
(ScrollView): A custom scroll view that can contain extremely long content. CSS values have a limit. This can go beyond that.
(ScrollView.prototype.setWidth): Sets the view width.
(ScrollView.prototype.width):
(ScrollView.prototype.setHeight):Sets the view height.
(ScrollView.prototype.height):
(ScrollView.prototype.onScrollAnimatorStep): Callback for scroll animator step.
(ScrollView.prototype.scrollTo): Scrolls to a certain offset.
(ScrollView.prototype.scrollBy): Scrolls by a certain amount.
(ScrollView.prototype.contentOffset): Current content offset.
(ScrollView.prototype.onMouseWheel): Scroll with the mouse wheel.
(ScrollView.prototype.setContentOffset): Sets the content offset.
(ScrollView.prototype.contentPositionForContentOffset): Returns where the content element should be positioned.

5:43 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:42 AM Changeset in webkit [143722] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143696 - [GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459

Reviewed by Martin Robinson.

  • platform/gtk/KeyBindingTranslator.cpp:

(WebCore): The translation table for paragraph selection
commands is backwards, fix it.

5:41 AM Changeset in webkit [143721] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: InspectorPageAgent::disable() should not update view metrics regardless of the override state
https://bugs.webkit.org/show_bug.cgi?id=110593

Reviewed by Vsevolod Vlasov.

InspectorPageAgent::disable() now checks if the device metrics are overridden before
telling the client to disable the override.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::deviceMetricsChanged):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

5:35 AM Changeset in webkit [143720] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.90

Tagging the WebKitGTK+ 1.11.90 release

5:34 AM Changeset in webkit [143719] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r143695.
http://trac.webkit.org/changeset/143695
https://bugs.webkit.org/show_bug.cgi?id=110554

Crashes in DocumentLoader::checkLoadComplete on AppleMac WK1, EFL, GTK.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

5:33 AM Changeset in webkit [143718] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding crash expectations for tests that regressed with r143624.
  • platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining.
5:33 AM Changeset in webkit [143717] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Yet another unreviewed buildfix after r143714.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::paintToCairoSurface):

5:26 AM Changeset in webkit [143716] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip tests until regressions (r143470, r143654) fixed.

  • platform/qt/TestExpectations:
5:18 AM Changeset in webkit [143715] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed preventive buildfix after my last commit.

  • UIProcess/API/efl/EwkView.cpp:
  • UIProcess/efl/WebView.cpp:
4:58 AM Changeset in webkit [143714] by kbalazs@webkit.org
  • 6 edits in trunk/Source

[CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=109824

Reviewed by Andreas Kling.

Avoid ugly ifdefs by using PlatformGraphicsContext.

Source/WebCore:

No new tests, only refactoring.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):

4:22 AM Changeset in webkit [143713] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Remove declaration of non-existent functions from EwkView
https://bugs.webkit.org/show_bug.cgi?id=110572

Reviewed by Kenneth Rohde Christiansen.

Removed declarations of non-existent EwkView::paintToCurrentGLContext() and
EwkView::paintToCairoSurface(cairo_surface_t*) that were accidentally
left at r143699.

  • UIProcess/API/efl/EwkView.h:

(EwkView):

4:11 AM Changeset in webkit [143712] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 1.11.90 release.

4:07 AM Changeset in webkit [143711] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143710 - Unreviewed. Fix make distcheck.

  • GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to

EXTRA_DIST.

4:05 AM Changeset in webkit [143710] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to

EXTRA_DIST.

2:50 AM Changeset in webkit [143709] by rakuco@webkit.org
  • 1 edit
    6 deletes in trunk/LayoutTests

Unreviewed gardening.

Remove some platform expectations which are identical to the
original ones.

  • platform/efl/http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Removed.
  • platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
  • platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt: Removed.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-frames-expected.txt: Removed.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
2:33 AM Changeset in webkit [143708] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][DRT] Do not dump empty frames.
https://bugs.webkit.org/show_bug.cgi?id=110474

Reviewed by Kenneth Rohde Christiansen.

Follow the original Mac implementation more closely by skipping
empty frames (frames which have no document). We are not really
interested in showing anything about them.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):

2:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:13 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
Bring back previous versions sections (diff)
2:10 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
Subresources leaks was merged already (diff)
2:07 AM Changeset in webkit [143707] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

GlyphPage: ALWAYS_INLINE all performance-relevant getters.

REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>

Reviewed by Antti Koivisto.

Unreviewed desperate hack. Since I can't reproduce the problem and it's only showing
up on two bots, one Linux and one Snow Leopard, I'm thinking it may be GCC related.
Let's see what happens if we tell it to force inline all the GlyphPage getters.

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::indexForCharacter):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::fontDataForCharacter):

2:03 AM Changeset in webkit [143706] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Update FileReaderLoader to allow specifying a range and reading as a blob.
https://bugs.webkit.org/show_bug.cgi?id=110556

This is part of a series of patches to implement Stream support. See:
https://bugs.webkit.org/show_bug.cgi?id=110194

Patch by Zach Kuznia <zork@chromium.org> on 2013-02-22
Reviewed by Hajime Morrita.

Tests: will be added when js binding is added.

  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
1:33 AM Changeset in webkit [143705] by mikhail.pozdnyakov@intel.com
  • 5 edits in trunk/Source/WebKit2

[WK2][EFL] Clean up PageViewportControllerClientEfl class
https://bugs.webkit.org/show_bug.cgi?id=110438

Reviewed by Andreas Kling.

Cleaned up PageViewportControllerClientEfl class from unused methods
and class members, eliminated access to WK2 internals from this class.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::~PageViewportControllerClientEfl):
(PageViewportControllerClientEfl):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::updateViewportSize):

1:33 AM Changeset in webkit [143704] by commit-queue@webkit.org
  • 17 edits
    3 adds in trunk

[WebGL][EFL] Support for creating surface with alpha disabled.
https://bugs.webkit.org/show_bug.cgi?id=110067

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Covered by compositing/webgl/webgl-no-alpha.html

We currently always create a surface supporting alpha channel.
With this patch we create the surface with alpha only if
required.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::createTransportSurface):
(WebCore::GLPlatformSurface::GLPlatformSurface):
(WebCore::GLPlatformSurface::attributes):
(WebCore):

  • platform/graphics/opengl/GLPlatformSurface.h:
  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::surfaceClientConfig):
(WebCore::GLXConfigSelector::validateAttributes):
(WebCore::GLXConfigSelector::findMatchingConfig):
(WebCore::GLXConfigSelector::findMatchingConfigWithVisualId):
(GLXConfigSelector):

  • platform/graphics/surfaces/glx/GLXContext.cpp:

(WebCore::GLXOffScreenContext::initialize):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXOffScreenSurface):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):

LayoutTests:

Enabled compositing/webgl/webgl-no-alpha.html for Efl port.

  • platform/efl/TestExpectations:
  • platform/efl/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/efl/compositing/webgl/webgl-no-alpha-expected.txt: Added.
1:20 AM Changeset in webkit [143703] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/multicol/newmulticol/positioned-split.html is failing on chromium mac 10.8 since it was added
https://bugs.webkit.org/show_bug.cgi?id=110568

Unreviewed test expectation update.

  • platform/chromium/TestExpectations:
1:07 AM Changeset in webkit [143702] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/stateobjects/state-url-sets-links-visited.html is timing out in chromium
https://bugs.webkit.org/show_bug.cgi?id=110566

Unreviewed test expectation update.

  • platform/chromium/TestExpectations:
12:59 AM Changeset in webkit [143701] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: allow opting out from vertical split in the dock-to-right mode
https://bugs.webkit.org/show_bug.cgi?id=110564

Reviewed by Vsevolod Vlasov.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._splitVertically):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

12:56 AM WebKitGTK/1.10.x edited by Claudio Saavedra
(diff)
12:55 AM Changeset in webkit [143700] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL][GTK][Qt] Add context menu item tags for C API
https://bugs.webkit.org/show_bug.cgi?id=109815

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-22
Reviewed by Anders Carlsson.

This patch adds context menu item tags used by EFL, GTK and Qt ports, defined in
WebCore to WK2 C API.

  • Shared/API/c/WKContextMenuItemTypes.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

12:52 AM Changeset in webkit [143699] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk/Source/WebKit2

[WK2][EFL] Move AC code from EwkView to WebView
https://bugs.webkit.org/show_bug.cgi?id=110216

Reviewed by Anders Carlsson.

Accelerated compositing code is moved from EwkView to WebView.
Added new WKView API to be used from EwkView instead of direct accessing
to coordinated graphics scene.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewPaintToCairoSurface):

  • UIProcess/API/C/efl/WKView.h:

Added WKView API functions.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::feedTouchEvent):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEwkViewMouseWheel):
(EwkView::handleEwkViewMouseDown):
(EwkView::handleEwkViewMouseUp):
(EwkView::handleEwkViewMouseMove):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

Using new WKView API.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):

  • UIProcess/efl/WebView.h:

(WebCore):
(WebKit::WebView::setUserViewportTranslation):
(WebView):

Added WebView methods to support new WKView API.

12:46 AM Changeset in webkit [143698] by vsevik@chromium.org
  • 9 edits
    2 copies
    5 adds in trunk/LayoutTests

Unreviewed tests rebaseline.

  • platform/chromium-linux-x86/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-linux/fast/images/favicon-as-image-expected.png:
  • platform/chromium-linux/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/chromium-linux/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-lion/fast/images/favicon-as-image-expected.png:
  • platform/chromium-mac-lion/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/favicon-as-image-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac/fast/images/favicon-as-image-expected.png:
  • platform/chromium-mac/fast/images/favicon-as-image-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
  • platform/chromium/TestExpectations:
12:45 AM Changeset in webkit [143697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] DomSupport: use NodeTraversal APIs
https://bugs.webkit.org/show_bug.cgi?id=110467

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::visibleTextQuads):

12:40 AM Changeset in webkit [143696] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

[GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459

Reviewed by Martin Robinson.

  • platform/gtk/KeyBindingTranslator.cpp:

(WebCore): The translation table for paragraph selection
commands is backwards, fix it.

Feb 21, 2013:

11:51 PM Changeset in webkit [143695] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554

Reviewed by Ryosuke Niwa.

Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

11:39 PM Changeset in webkit [143694] by alecflett@chromium.org
  • 24 edits in trunk/Source

IndexedDB: Implement SharedBuffer version of put() / onSuccess()
https://bugs.webkit.org/show_bug.cgi?id=110398

Reviewed by Tony Chang.

Source/WebCore:

This avoids all unnecessary data copies within the context of
IndexedDB proper, and removes all references to
SerializedScriptValue from the IndexedDB "backend".

No new tests because this is just a refactor.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueBuffer): New version of deserializeIDBValue which takes SharedBuffer.

Source/WebKit/chromium:

Proxy new SharedBuffer calls to WebIDBCallbacks through
to the new SharedBuffer-based IDBCallbacks.

  • public/WebIDBCursor.h:
  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):

  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBRequestTest.cpp:

(WebKit::TEST_F):

11:18 PM Changeset in webkit [143693] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r143691.
http://trac.webkit.org/changeset/143691
https://bugs.webkit.org/show_bug.cgi?id=110559

Breaks compilation on mac. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore):
(WebCore::RenderLayerCompositor::reasonForCompositing):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

10:39 PM Changeset in webkit [143692] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Remove deep copy of ImageBuffer in tiled SVG backgrounds
https://bugs.webkit.org/show_bug.cgi?id=110549

Reviewed by Dirk Schulze.

SVGImage::drawPatternForContainer creates a temporary ImageBuffer for stamping out tiled
backgrounds. Previously this ImageBuffer was unnecessarily deep-copied! This patch uses a
shallow copy, taking advantage of the fact that the temporary ImageBuffer is never modified.

This patch is covered with existing tests.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

10:33 PM Changeset in webkit [143691] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505

Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.

This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.

Reviewed by Simon Fraser.

No new tests.

10:25 PM Changeset in webkit [143690] by tasak@google.com
  • 3 edits
    2 adds in trunk

RenderTable::paintBoxDecorations sometimes draws box-shadow twice.
https://bugs.webkit.org/show_bug.cgi?id=110196

Reviewed by Simon Fraser.

Source/WebCore:

When RenderTable::paintBoxDecorations draws box-shadow, paintBackground
should not draw box-shadow. So we have to provide bleedAvoidance
parameter for RenderBox::paintBackground.

Test: fast/css/table-border-radius-with-box-shadow.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):
Provide bleedAvoidance, which determineBackgroundBleedAvoidance
returns, for paintBackground.

LayoutTests:

  • fast/css/table-border-radius-with-box-shadow-expected.html: Added.
  • fast/css/table-border-radius-with-box-shadow.html: Added.
10:02 PM Changeset in webkit [143689] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add failing test expectations for bugs 110554 and 110555.

  • platform/mac/TestExpectations:
10:00 PM Changeset in webkit [143688] by g.czajkowski@samsung.com
  • 11 edits in trunk/Source

Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
https://bugs.webkit.org/show_bug.cgi?id=110208

Reviewed by Hajime Morrita.

Source/WebCore:

The WebCore changes are required to implement asynchronous spell checking in WK2.
The idea of asynchronous spell checking in WK1 is to pass the pointer to the abstract object
to the client who is able to verify the given text and notify the WebCore about results.
WK2 will extract the request data and pass it (with additional information) to the UIProcess.

No new tests, covered by editing/spelling tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):
Extract the request data as it is the member of 'TextCheckingRequest'.

  • editing/SpellChecker.cpp:

(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::setCheckerAndSequence):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::enqueueRequest):
(WebCore::SpellChecker::didCheck):
(WebCore::SpellChecker::didCheckSucceed):

  • platform/text/TextChecking.h:

(WebCore):
(TextCheckingRequestData):
Introduce a new 'TextCheckingRequestData' class to keep the request data and to
easy extract it from the 'TextCheckingRequest'.

(WebCore::TextCheckingRequestData::TextCheckingRequestData):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::didCheckSucceed):
(WebEditorClient::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

9:56 PM Changeset in webkit [143687] by beidson@apple.com
  • 4 edits in trunk/Source

Move fastlog2() to WTF/MathExtras.h so it can be used from multiple projects.

Rubberstamped by Geoff Garen.

Source/WebCore:

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::lruListFor): Remove the inline fastlog2 and use WTF::fastlog2.

Source/WTF:

  • wtf/MathExtras.h:

(WTF::fastLog2):

9:15 PM Changeset in webkit [143686] by Dimitri Glazkov
  • 12 edits
    2 adds in trunk/Source/WebCore

Split SelectorChecker's fast-checking logic into its own class.
https://bugs.webkit.org/show_bug.cgi?id=106860

Reviewed by Antti Koivisto.

No functional changes, covered by existing tests.

  • CMakeLists.txt: Added new class to existing build system.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSAllInOne.cpp: Ditto.
  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData): Changed to use SelectorCheckerFastPath.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matches): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker): Move fast path code into SelectorCheckerFastPath.

  • css/SelectorCheckerFastPath.cpp: Added.
  • css/SelectorCheckerFastPath.h: Added.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::ruleMatches): Changed to use SelectorCheckerFastPath.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::initialize): Ditto.

8:03 PM Changeset in webkit [143685] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Invalidate outstanding checkpoints for the background input stream and preload scanner
https://bugs.webkit.org/show_bug.cgi?id=110537

Reviewed by Adam Barth.

fast/tokenizer/write-before-load.html caused duplicate didFailSpeculation() calls for the same checkpoint.
One was triggered by processParsedChunkFromBackgroundParser and the other by resumeParsingAfterScriptExecution.
This change ensures that after we send a checkpoint, it is cleared so it won't be sent again until the next
processParsedChunkFromBackgroundParser().

No new tests because no new functionality.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::rewindTo):

7:19 PM Changeset in webkit [143684] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Followup commit for https://bugs.webkit.org/show_bug.cgi?id=110541
from a comment by Jon Lee.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Logic
in conditional was unnecessarily complex.

7:12 PM Changeset in webkit [143683] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Clean up computePreferredLogicalWidths functions in TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110515

Reviewed by Tony Chang.

No change in behavior. This is just a cleanup in preparation for other
refactoring to this code.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Move a FIXME here from computePreferredLogicalWidths. It makes more sense here.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
-Remove outdated or unhelpful comments.
-Isolate the fixed width codepath to make it a bit less convoluted.
(WebCore::FixedTableLayout::layout):

  • rendering/FixedTableLayout.h:

The argument to calcWidthArray is never used. Remove it.

7:01 PM Changeset in webkit [143682] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

TriState.h should be a Project header
https://bugs.webkit.org/show_bug.cgi?id=110543

Rubber-stamped by Dan Bernstein.

WTF uses a script to copy headers to the build destination, so it isn't
necessary to mark headers as Private/Public (and doing so can be problematic).

  • WTF.xcodeproj/project.pbxproj: Mark TriState.h as a Project header.
6:54 PM Changeset in webkit [143681] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995

Unreviewed speculative fix for Mac WK1.

It appears that m_frame can be null for Mac WK1.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

6:48 PM Changeset in webkit [143680] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Better sizing model for Snapshotted plugins
https://bugs.webkit.org/show_bug.cgi?id=110541

Reviewed by Simon Fraser.

Clarify the way we apply sizing rules to snapshotted plug-ins. In
testing we've found that plug-ins smaller than 40px in either
dimension should never be frozen. Also, larger plugins should
be explicitly marked, because often they are the single dominant
element on the page.

As a drive-by, I removed the flag that indicated whether or not
the label should show automatically. It wasn't being used. This is
all determined from the shadow root and its CSS now.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New values for size thresholds.
(WebCore::HTMLPlugInImageElement::createRenderer): Remove call to setShouldShowSnapshotLabelAutomatically.
(WebCore::classNameForShadowRoot): Remove logging and clearly assign sizing classes.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): We don't need the page size any more.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use new constant names.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): Remove setShouldShowSnapshotLabelAutomatically.

6:48 PM Changeset in webkit [143679] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix a typo that broke the 32 bit build.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:29 PM Changeset in webkit [143678] by benjamin@webkit.org
  • 6 edits
    2 deletes in trunk/LayoutTests

Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883

Reviewed by Antti Koivisto.

Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.

Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.

This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.

The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.

  • fast/js/resources/js-test-pre.js:

(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):

  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/wk2/TestExpectations:

state-url-sets-links-visited.html fails on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.

The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.

6:10 PM Changeset in webkit [143677] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=110539

Reviewed by Filip Pizlo.

Change the scale used to lookup pointers in JSGlobalObject::m_specialPointers to be 4 bytes for
the 32 bit version of the interpreter.

  • llint/LowLevelInterpreter32_64.asm:
5:43 PM Changeset in webkit [143676] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the build after r143664.

Unreviewed.

  • WebCore.exp.in:
5:42 PM Changeset in webkit [143675] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

QuickTime plugin doesn't load when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=110534

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-21
Reviewed by Anders Carlsson.

We shouldn't disable accelerated compositing for plugins, because
plugins such as QuickTime rely on this and will try to set other drawing
models that we don't support.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isAcceleratedCompositingEnabled):

5:40 PM Changeset in webkit [143674] by pilgrim@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove chromium/public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=110471

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • WebKit.gyp:
  • public/platform: Removed.
  • public/platform/WebKitPlatformSupport.h: Removed.
  • public/platform/android: Removed.
  • public/platform/default: Removed.
  • public/platform/linux: Removed.
  • public/platform/mac: Removed.
  • public/platform/win: Removed.
  • src/WebKit.cpp:
5:27 PM Changeset in webkit [143673] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

tables/mozilla/bugs/bug8950.html fails with threaded parser due to attribute duplication
https://bugs.webkit.org/show_bug.cgi?id=110532

Reviewed by Adam Barth.

This is a very basic failure which we should have caught earlier with the html5lib parser
tests, except those use document.write and thus avoid the threaded parser.

AtomicHTMLToken expects its attributes to be unique. We were not doing that for the
CompactHTMLToken path, and this ancient mozilla table test caught that.

Fixes tables/mozilla/bugs/bug8950.html.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

5:26 PM Changeset in webkit [143672] by dpranke@chromium.org
  • 4 edits in trunk

[chromium] support the lucid version of freetype on precise in DRT
https://bugs.webkit.org/show_bug.cgi?id=107338

Reviewed by Tony Chang.

Source/WebKit/chromium:

Add in a linux-only dependency on Freetype2 so that we can
match the version shipped in Ubuntu Lucid.

  • DEPS:

Tools:

Modify the DRT build so that we can optionally link against
a fixed version of Freetype2. This allows us to share pixel test
results across multiple versions of Ubuntu without having to
worry about differences in font rendering.

At the moment this feature is off by default. Eventually it will
be on by default on linux.

Note that this only affects DRT; the regular Chromium binary
(and, for now, content_shell) will still use the system version
of Freetype.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5:13 PM Changeset in webkit [143671] by roger_fong@apple.com
  • 4 edits in trunk/Source

Unreviewed. Add executable property to cmd file.
Required for executable files to maintain their executable permissions over svn.

  • JavaScriptCore.vcxproj/copy-files.cmd: Added property svn:executable.
  • WTF.vcxproj/copy-files.cmd: Added property svn:executable.
5:13 PM Changeset in webkit [143670] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Threaded HTML Parser fails fast/dom/Document/readystate.html
https://bugs.webkit.org/show_bug.cgi?id=110529

Reviewed by Eric Seidel.

Source/WebCore:

We need to create the tokenizer even when we finish a script-created
parser. Most of the time, the tokenizer has already been created at
this point because it is created by calls to document.write.

Test: fast/parser/body-should-exist-after-open-close.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::finish):

LayoutTests:

This test is a reduction of the original issue.

  • fast/parser/body-should-exist-after-open-close-expected.txt: Added.
  • fast/parser/body-should-exist-after-open-close.html: Added.
5:11 PM Changeset in webkit [143669] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Lots of LayoutUnit assertions when loading a Wikipedia article
https://bugs.webkit.org/show_bug.cgi?id=110270

Reviewed by Levi Weintraub.

Change RenderBlock::adjustRectForColumns to ensure that the
endColumn calculation does not overflow.

No new tests, covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):
Make the endOffset value be no less than the beforeBorderPadding
value to ensure that endColumn is not negative.

4:56 PM Changeset in webkit [143668] by commit-queue@webkit.org
  • 7 edits in trunk

Tools: [Chromium] Remove the word "cheher" from the list of misspelled words
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.

Other platforms do not mark "cheher" as a misspelled word in layout tests.
This change is to bring Chromium platform in line with the rest of the
platforms.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
(WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.

LayoutTests: Fix editing/spelling/spelling-changed-text.html on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.

After r143470 editing/spelling/spelling-changed-text.html fails on Qt and GTK,
because Qt and Gtk spelling tests do not mark "cheher" as a misspelling. This
patch changes the test to use the misspelling "wellcome" instead.

  • editing/spelling/spelling-changed-text-expected.txt: Changed "cheher" to "wellcome".
  • editing/spelling/spelling-changed-text.html: Changed "cheher" to "wellcome".
  • platform/gtk/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
  • platform/qt/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
4:55 PM Changeset in webkit [143667] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Object allocation profiling will refuse to create objects with more than JSFinalObject::maxInlineCapacity() inline slots, but JSFunction::allocationProfile() asserts that the number of inline slots is always what it asked for
https://bugs.webkit.org/show_bug.cgi?id=110519
<rdar://problem/13218566>

Reviewed by Geoffrey Garen.

  • runtime/JSFunction.h:

(JSC::JSFunction::allocationProfile):

4:55 PM Changeset in webkit [143666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r183905. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

  • DEPS:
4:48 PM Changeset in webkit [143665] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Remove copying WebIDBDatabase::put() stub
https://bugs.webkit.org/show_bug.cgi?id=109967

Reviewed by Darin Fisher.

Now that the chromium call to this method has
been removed, we can remove the stub.

  • public/WebIDBDatabase.h:
4:39 PM Changeset in webkit [143664] by eric@webkit.org
  • 6 edits in trunk

LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995

Reviewed by Adam Barth.

Source/WebCore:

In the case where during main document onload, we
load a new iframe, and then from within that iframe
we run script to remove the iframe and call testRunner.notifyDone()
the notifyDone() will not correctly dump because
the testRunner does not yet realize that the main resource
has completed loading.

In the main-thread parser, the testRunner does correctly know
that the main thread has completed, because removing the iframe
causes a didFailLoad callback to the embedder, because when
the iframe is being removed, the DocumentLoader for that iframe
is still on the stack and believe's its loading
(because it has a MainResourceLoader which is also on the stack
delivering us the bytes which contain this inline script).

In the threaded-parser case, the DocumentLoader and MainResourceLoader
are no longer on the stack, as we are parsing the iframe asynchronously
after all the bytes have been delivered, and the MainResourceLoader destroyed.
Thus when DocumentLoader::stopLoading() is called, loading() returns
false, and it returns early. One might argue that we should remove that
early return entirely, but it seemed safer to extend the idea of
when we're loading to include the time when the parser is active.

This patch solves this by teaching the DocumentLoader that it is still
"loading" so long as the parser is still active.

Also added a call to DocumentLoader::checkLoadComplete from
Document::decrementActiveParserCount which seemed to cause
http/tests/multipart/policy-ignore-crash.php to pass.

This causes http/tests/security/feed-urls-from-remote.html to timeout
on chromium (but no other platforms that I'm aware of). I believe this
is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls!

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):
(WebCore):

  • loader/DocumentLoader.h:

(DocumentLoader):

LayoutTests:

Mark http/tests/security/feed-urls-from-remote.html as timeout on chromium.
I believe this is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls.

  • platform/chromium/TestExpectations:
4:27 PM Changeset in webkit [143663] by arv@chromium.org
  • 6 edits
    2 adds in trunk

Nodes should not have attributes property
https://bugs.webkit.org/show_bug.cgi?id=110510

Reviewed by Adam Barth.

Source/WebCore:

According to http://dom.spec.whatwg.org/ attributes and hasAttributes
should be defined on Element and not on Node.

Test: fast/dom/Text/text-should-not-have-attributes.html

  • dom/Element.idl:
  • dom/Node.idl:

LayoutTests:

  • fast/dom/Node/initial-values-expected.txt:
  • fast/dom/Node/script-tests/initial-values.js:
  • fast/dom/Text/text-should-not-have-attributes-expected.txt: Added.
  • fast/dom/Text/text-should-not-have-attributes.html: Added.
4:26 PM Changeset in webkit [143662] by roger_fong@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in

Unreviewed. Tab to spaces style fix.

4:21 PM Changeset in webkit [143661] by tonyg@chromium.org
  • 7 edits in trunk/Source/WebCore

Make BackgroundHTMLParser rewind the preload scanner instead of clear it
https://bugs.webkit.org/show_bug.cgi?id=110517

Reviewed by Adam Barth.

No new tests becuase no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

  • html/parser/HTMLDocumentParser.h:

(ParsedChunk):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore):
(WebCore::TokenPreloadScanner::rewindTo):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):
(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):

4:19 PM Changeset in webkit [143660] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for VS2010 WebKit solution.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
4:07 PM Changeset in webkit [143659] by alokp@chromium.org
  • 4 edits in trunk/LayoutTests

Suppressed failing tests after r143626.
These tests need to be rebaselined.

Unreviewed gardening of TestExpectations.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
3:50 PM Changeset in webkit [143658] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r143536.
http://trac.webkit.org/changeset/143536
https://bugs.webkit.org/show_bug.cgi?id=110523

Causing a bunch of tests to fail on Windows, requires
rebaselining (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • config.h:
  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setShouldPaintNativeControls):

  • page/Settings.h:

(Settings):
(WebCore::Settings::shouldPaintNativeControls):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore):

  • rendering/RenderThemeWin.cpp:

(WebCore):

Source/WebKit/win:

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

3:36 PM Changeset in webkit [143657] by Lucas Forschler
  • 18 edits
    6 copies
    18 deletes in tags/Safari-537.31.6/Source/WebKit2

Merged r142806. <rdar://problem/13236883>

3:29 PM Changeset in webkit [143656] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Don't make an overhang shadow layer when the WKView has a transparent background
https://bugs.webkit.org/show_bug.cgi?id=110429

Reviewed by Anders Carlsson.

When in coordinated scrolling mode, RenderLayerCompositor makes a layer to show
the shadow around the content when rubber-banding. However, if the view is
transparent, we don't want to make this layer, since it darkens the entire view.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Code was moved
into viewHasTransparentBackground(), so just call that here.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't make
a shadow layer when the view is transparent.
(WebCore::RenderLayerCompositor::viewHasTransparentBackground): Return
true if the view is transparent or has a non-opaque background color,
and optionally return that color.

  • rendering/RenderLayerCompositor.h:
3:29 PM Changeset in webkit [143655] by Simon Fraser
  • 3 edits
    2 adds in trunk

[Safari] Crash with opacity + drop shadow filter + child element extending beyond filter outsets
https://bugs.webkit.org/show_bug.cgi?id=107467

Source/WebCore:

Reviewed by Dean Jackson.

The filter code plays games with the current GraphicsContext, replacing the current
context with one which will get filtered.

This doesn't play nicely with the RenderLayer code which lazily starts transparency
layers. If we don't start a transparency layer until painting a child of the filtered
layer, then the transparency layer is started using the wrong context.

Fix by eagerly starting transparency layers if we have both a filter and opacity.

Test: css3/filters/filter-with-opacity-and-children.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Reviewed by Dean Jackson.

Testcase with filtered element with opacity, and layer child.

  • css3/filters/filter-with-opacity-and-children-expected.txt: Added.
  • css3/filters/filter-with-opacity-and-children.html: Added.
2:59 PM Changeset in webkit [143654] by fpizlo@apple.com
  • 31 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should not change its mind about what type speculations a node does, by encoding the checks in the NodeType, UseKind, and ArrayMode
https://bugs.webkit.org/show_bug.cgi?id=109371

Reviewed by Oliver Hunt.

FixupPhase now locks in the speculations that each node will do. The DFG then
remembers those speculations, and doesn't change its mind about them even if the
graph is transformed - for example if a node's child is repointed to a different
node as part of CSE, CFG simplification, or folding. Each node ensures that it
executes the speculations promised by its edges. This is true even for Phantom
nodes.

This still leaves some craziness on the table for future work, like the
elimination of speculating SetLocal's due to CFG simplification
(webkit.org/b/109388) and elimination of nodes via DCE (webkit.org/b/109389).

In all, this allows for a huge simplification of the DFG. Instead of having to
execute the right speculation heuristic each time you want to decide what a node
does (for example Node::shouldSpeculateInteger(child1, child2) &&
node->canSpeculateInteger()), you just ask for the use kinds of its children
(typically node->binaryUseKind() == Int32Use). Because the use kinds are
discrete, you can often just switch over them. This makes many parts of the code
more clear than they were before.

Having UseKinds describe the speculations being performed also makes it far
easier to perform analyses that need to know what speculations are done. This is
so far only used to simplify large parts of the CFA.

To have a larger vocabulary of UseKinds, this also changes the node allocator to
be able to round up Node sizes to the nearest multiple of 16.

This appears to be neutral on benchmarks, except for some goofy speed-ups, like
8% on Octane/box2d.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::startExecuting):
(DFG):
(JSC::DFG::AbstractState::executeEdges):
(JSC::DFG::AbstractState::verifyEdge):
(JSC::DFG::AbstractState::verifyEdges):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):
(JSC::DFG::AbstractState::filterByType):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filter):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::reset):
(JSC::DFG::AdjacencyList::firstChild):
(JSC::DFG::AdjacencyList::setFirstChild):
(JSC::DFG::AdjacencyList::numChildren):
(JSC::DFG::AdjacencyList::setNumChildren):
(AdjacencyList):

  • dfg/DFGAllocator.h:

(DFG):
(Allocator):
(JSC::DFG::Allocator::cellSize):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::payloadSize):
(JSC::DFG::Allocator::Region::payloadBegin):
(JSC::DFG::Allocator::Region::payloadEnd):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::handleMinMax):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:

(DFG):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.cpp:

(JSC::DFG::Edge::dump):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::useKind):
(JSC::DFG::Edge::shift):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(FixupPhase):
(JSC::DFG::FixupPhase::truncateConstantToInt32):
(JSC::DFG::FixupPhase::truncateConstantsIfNecessary):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

  • dfg/DFGGraph.cpp:

(DFG):
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(DFG):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::willHaveCodeGenOrOSR):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::binaryUseKind):
(Node):
(JSC::DFG::Node::isBinaryUseKind):

  • dfg/DFGNodeAllocator.h:

(DFG):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::typeCheck):
(JSC::DFG::SpeculativeJIT::forwardTypeCheck):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculateBoolean):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
(JSC::DFG::SpeculativeJIT::speculateOther):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::edge):
(IntegerOperand):
(JSC::DFG::IntegerOperand::node):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSValueOperand):
(JSC::DFG::JSValueOperand::edge):
(JSC::DFG::JSValueOperand::node):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::edge):
(StorageOperand):
(JSC::DFG::StorageOperand::node):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::edge):
(JSC::DFG::SpeculateIntegerOperand::node):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(JSC::DFG::SpeculateIntegerOperand::use):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateStrictInt32Operand::edge):
(JSC::DFG::SpeculateStrictInt32Operand::node):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::edge):
(JSC::DFG::SpeculateDoubleOperand::node):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(JSC::DFG::SpeculateDoubleOperand::use):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::edge):
(JSC::DFG::SpeculateCellOperand::node):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::edge):
(SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::node):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
(DFG):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • dfg/DFGUseKind.cpp: Added.

(WTF):
(WTF::printInternal):

  • dfg/DFGUseKind.h: Added.

(DFG):
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
(WTF):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::reportValidationContext):

2:57 PM Changeset in webkit [143653] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, roll chromium deps 183552 -> 183788

  • DEPS:
2:21 PM Changeset in webkit [143652] by tony@chromium.org
  • 9 edits in trunk

Autogenerate Settings that call setNeedsRecalcStyleInAllFrames when set
https://bugs.webkit.org/show_bug.cgi?id=109989

Reviewed by Ryosuke Niwa.

.:

Add setters to export symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Start generating the code for settings that call m_page->setNeedsRecalcStyleInAllFrames()
when the value is changed. This allows us to generate 10 more settings. As a follow up, we
can remove some methods from DRT/WTR after this.

No new tests, this is a build refactor and should not impact any test results.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove member variables. Add SETTINGS_SETTER_BODIES macro that
has the generated setter bodies.

  • page/Settings.h:

(Settings): Remove code that is now generated.

  • page/Settings.in: Add new entries with setNeedsStyleRecalcWhenSetting=1
  • page/make_settings.pl:

(defaultItemFactory): Add setNeedsStyleRecalcWhenSetting flag.
(generateSettingsMacrosHeader): Print macro for setter bodies.
(printConditionalMacros): Add setter body code.
(printGettersAndSetters): Pass in setNeedsStyleRecalcWhenSetting so we know whether to inline the
setter in the header or not.
(printGetterAndSetter): Ditto.
(printSetterBodies): Print macro for setter bodies.
(printSetterBody): Print setter body for a single setting.

2:03 PM Changeset in webkit [143651] by pdr@google.com
  • 12 edits
    2 adds in trunk/LayoutTests

Rebaseline 4 SVG tests after an aspect ratio change in r143389

These 4 SVG tests needed a rebaseline after fixing WK99984.

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [143650] by dino@apple.com
  • 6 edits in trunk/Source

Plug-in snapshotting code always accepts first snapshot
https://bugs.webkit.org/show_bug.cgi?id=110495

Reviewed by Tim Horton.

When we detect a plugin that can be snapshotted we start capturing
images until we find one that we believe isn't blank, or we timeout.
I introduced a regression recently where we swap renderers as
soon as the snapshot arrives, whether or not is is blank.

The fix was to have the embedder (currently only WK2) be the one
who tells the HTMLPlugInElement to start displaying snapshots.

Source/WebCore:

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::setDisplayState): Make this a virtual function.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::setDisplayState): Override to call the

base class version, but swap renderers if we should move to the snapshot.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Don't swap renderers here any more.

  • html/HTMLPlugInImageElement.h: New virtual version of setDisplayState.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired): When we find a
snapshot that we like, tell the HTMLPlugInElement to move to
the snapshot view.

1:46 PM Changeset in webkit [143649] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Tune BackgroundHTMLParser's pendingTokenLimit based on a benchmark
https://bugs.webkit.org/show_bug.cgi?id=110408

Reviewed by Adam Barth.

This constant was tuned by running the top 25 sites in Telemetry on a Nexus 7 device.
The new value decreases the maximum time spent parsing by 40% without significantly impacting total parse time or DOMContentLoaded.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore):

1:45 PM ExportingSymbols edited by tony@chromium.org
(diff)
1:40 PM Changeset in webkit [143648] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Fix duplicate TestExpecataions entry for svg/custom/foreign-object-skew.svg

Unreviewed gardening of TestExpecations

  • platform/chromium/TestExpectations:
1:22 PM Changeset in webkit [143647] by fpizlo@apple.com
  • 7 edits in trunk/LayoutTests

Rebalance the running times of JSRegress somewhat.

Rubber stamped by Mark Hahnenberg.

  • fast/js/regress/script-tests/adapt-to-double-divide.js:

(foo):

  • fast/js/regress/script-tests/array-access-polymorphic-structure.js:
  • fast/js/regress/script-tests/int-overflow-local.js:
  • fast/js/regress/script-tests/method-on-number.js:

(foo):

  • fast/js/regress/script-tests/rare-osr-exit-on-local.js:
  • fast/js/regress/script-tests/slow-convergence.js:
1:11 PM Changeset in webkit [143646] by commit-queue@webkit.org
  • 13 edits
    5 deletes in trunk

Unreviewed, rolling out r143419.
http://trac.webkit.org/changeset/143419
https://bugs.webkit.org/show_bug.cgi?id=110507

Broke border-image on Mac (Requested by jpfau on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawTiledImage):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • fast/borders/border-image-02.html: Removed.
  • platform/chromium-linux/fast/borders/border-image-02-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/borders/border-image-02-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/fast/borders/border-image-02-expected.png: Removed.
  • platform/gtk/fast/borders/border-image-02-expected.txt: Removed.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:07 PM Changeset in webkit [143645] by fpizlo@apple.com
  • 1 edit
    9 adds in trunk/LayoutTests

Add Apache's HashMap.java translated into JavaScript as a JSRegress test

Rubber stamped by Geoffrey Garen.

  • fast/js/regress/HashMap-put-get-iterate-keys.html: Added.
  • fast/js/regress/HashMap-put-get-iterate.html: Added.
  • fast/js/regress/HashMap-string-put-get-iterate.html: Added.
  • fast/js/regress/script-tests/HashMap-put-get-iterate-keys.js: Added.

(HashMap):
(HashMap.):
(get var):

  • fast/js/regress/script-tests/HashMap-put-get-iterate.js: Added.

(HashMap):
(HashMap.):
(get var):

  • fast/js/regress/script-tests/HashMap-string-put-get-iterate.js: Added.

(HashMap):
(HashMap.):
(get var):

1:00 PM Changeset in webkit [143644] by tsepez@chromium.org
  • 38 edits
    1 copy
    5 adds in trunk

XSSAuditor should block pages by redirecting to a sandboxed data: URL.
https://bugs.webkit.org/show_bug.cgi?id=110406

Reviewed by Adam Barth.

Source/WebCore:

Patch originally by mkwst@chromium.org.
Tests: http/tests/security/xssAuditor/block-does-not-leak-location.html

http/tests/security/xssAuditor/block-does-not-leak-referrer.html
http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

When blocking entire pages via the XSSAuditor, redirect to a data:
URL to ensure that requests for properties don't leak information.

LayoutTests:

  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-location.html: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer.html: Added.
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href.html:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link.html:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick.html:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag.html:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
  • http/tests/security/xssAuditor/full-block-script-tag.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
  • http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-02.html:
  • http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-03.html:
  • http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-04.html:

Rebaselined tests. Can no longer use final location of about:blank to
indicate success.

  • http/tests/security/xssAuditor/resources/utilities.js:

(checkIfFrameLocationMatchesSrcAndCallDone):

Check final location against frame source (should only match when same
origin and not blocked).

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:

Clean up noise in httpd error log about undefined values.

12:56 PM Changeset in webkit [143643] by commit-queue@webkit.org
  • 29 edits in trunk

Convert buttons from DeprecatedFlexBox to nondeprecated FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109994

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-21
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests for <button> and <input
type="button|submit|reset">

  • css/html.css:

(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
Convert from box-align to align-items. We are using flex-start here in
conjunction with an auto margin for correct centering. See
RenderButton.cpp below for the margin & more explanation.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
Add a case for creating a non-deprecated flex box.

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::addChild):
(WebCore::RenderButton::removeChild):
Forward to new base class
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
We are now using flexbox properties.

  • min-width is needed for correct shrinking of the contents
  • margin-top and margin-bottom are used for correct centering. We

can't use align-items: center because results are incorrect when the
content overflows. See LayoutTests/fast/forms/control-clip.html

  • rendering/RenderButton.h:

Inherit from RenderFlexibleBox

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::createAnonymous):
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):
Add a createAnonymous function to RenderFlexibleBox.

LayoutTests:

  • fast/flexbox/box-orient-button.html: Change -webkit-box to

-webkit-flex, and related changes.

  • fast/flexbox/resources/box-orient-button.js:

(setFlexDirection): webkitBoxOrient -> webkitFlexDirection

  • fast/replaced/table-percent-height.html: Give a value to the

<input type="button"> so that the layout doesn't change. No need to
change expectations because this test uses dumpAsText() and just
compares one button's height to another.

  • http/tests/security/isolatedWorld/userGestureEvents.html: Add text

to the button so that sending the click event doesn't miss the
now-smaller button.

  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt:

Add that text to the expectation too.

  • fast/forms/button-generated-content-expected.txt:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.txt:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.txt:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/svg/custom/foreign-object-skew-expected.txt:

Rebaseline. Most changes come from the fact that an empty button now
consistently has a small height, when previously it would sometimes
have the height of the line. See this testcase:
https://bugs.webkit.org/attachment.cgi?id=188679
The new behavior is consistent with Firefox.

The only other difference is fast/forms/button-generated-content.html:
The empty buttons are now aligned on the baseline instead of being
vertically centered in the line. This is consistent with Firefox.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

Mark tests for rebaselining.

12:49 PM Changeset in webkit [143642] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Simplify computation of screenRect/windowRect.
https://bugs.webkit.org/show_bug.cgi?id=110456

Patch by John Mellor <johnme@chromium.org> on 2013-02-21
Reviewed by Adam Barth.

This patch removes applyDeviceScaleFactorInCompositor checks
added by http://trac.webkit.org/changeset/139356 because
Chrome for Android now sizes its screen and window in DIP
units (like other platforms), so they are no longer necessary.

Source/WebCore:

No new tests, since this is just removing an unused codepath.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

12:41 PM Changeset in webkit [143641] by Beth Dakin
  • 9 edits
    2 deletes in trunk

Out-of-view fixed position check should not be affected by page scale at all on Mac
https://bugs.webkit.org/show_bug.cgi?id=110294
-and corresponding-
<rdar://problem/13247582>

Reviewed by Simon Fraser.

Source/WebCore:

Don't scale the layerBounds. Generally, the layerBounds should be relative to the
viewBounds which are also unscaled. Chromium used to want this behavior, but it is
covered by their pageScaleFactorAppliedInCompositor implementation now.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

These layer results should be the same regardless of the scale factor.

  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
  • compositing/layer-creation/fixed-position-out-of-view-scaled.html:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:

Skip these on Chromium for now.

  • platform/chromium/TestExpectations:
12:37 PM Changeset in webkit [143640] by pdr@google.com
  • 4 edits
    2 adds in trunk

Stop starting animations when leaving a page
https://bugs.webkit.org/show_bug.cgi?id=110257

Reviewed by Stephen Chenney.

Source/WebCore:

SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().

Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.

Both of these changes are functionally covered with existing tests.

Test: svg/animations/reset-animation-crash.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::resetAnimation):

LayoutTests:

  • svg/animations/reset-animation-crash-expected.html: Added.
  • svg/animations/reset-animation-crash.html: Added.
12:33 PM Changeset in webkit [143639] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Remove deprecated WebCompositorSupport::createLayerTreeView() declaration
https://bugs.webkit.org/show_bug.cgi?id=110492

Patch by James Robinson <jamesr@chromium.org> on 2013-02-21
Reviewed by Adrienne Walker.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):

12:31 PM Changeset in webkit [143638] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] document WebTestDelegate and WebTestRunner interfaces
https://bugs.webkit.org/show_bug.cgi?id=110472

Reviewed by Adam Barth.

Also remove the default implementation of the remaining WebTestDelegate
methods now that all embedders provide this interface.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

12:00 PM Changeset in webkit [143637] by mhahnenberg@apple.com
  • 50 edits
    3 adds in trunk

Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
https://bugs.webkit.org/show_bug.cgi?id=106059

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

  • API/JSBase.h: Renamed enable flag for API.
  • API/JSBlockAdaptor.h: Using new flag.
  • API/JSBlockAdaptor.mm: Ditto.
  • API/JSContext.h: Add convenience C API conversion function for JSGlobalContextRef.
  • API/JSContext.mm:

(-[JSContext JSGlobalContextRef]): Implementation of C API convenience function.
(-[JSContext initWithVirtualMachine:]): We don't use the m_apiData field any more.
(-[JSContext initWithGlobalContextRef:]): init method for allocating new JSContexts given a JSGlobalContextRef.
(-[JSContext dealloc]): No more m_apiData.
(-[JSContext wrapperForObjCObject:]): Renamed wrapperForObject.
(-[JSContext wrapperForJSObject:]): Fetches or allocates the JSValue for the specified JSValueRef in this JSContext.
(+[JSContext contextWithGlobalContextRef:]): Helper function to grab the lightweight JSContext wrapper for a given
JSGlobalContextRef from the global wrapper cache or allocate a new one if there isn't already one.

  • API/JSContextInternal.h: New flag, new method declaration for initWithGlobalContextRef.
  • API/JSExport.h: New flag.
  • API/JSValue.h: New flag and new C API convenience method.
  • API/JSValue.mm:

(-[JSValue JSValueRef]): Implementation of the C API convenience method.
(objectToValueWithoutCopy):
(+[JSValue valueWithValue:inContext:]): We now ask the JSContext for an Objective-C JSValue wrapper, which it can cache
in its internal JSWrapperMap.

  • API/JSValueInternal.h:
  • API/JSVirtualMachine.h:
  • API/JSVirtualMachine.mm: Added global cache that maps JSContextGroupRef -> JSVirtualMachine lightweight wrappers.

(wrapperCacheLock):
(initWrapperCache):
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):
(-[JSVirtualMachine init]):
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(+[JSVirtualMachine virtualMachineWithContextGroupRef:]):
(-[JSVirtualMachine contextForGlobalContextRef:]):
(-[JSVirtualMachine addContext:forGlobalContextRef:]):

  • API/JSVirtualMachineInternal.h:
  • API/JSWrapperMap.h:
  • API/JSWrapperMap.mm:

(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We use the JSObjectSetPrototype C API call because
setting the proto property causes all sorts of bad things to happen behind the scenes, which can cause crashes based on
when it gets called.
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap jsWrapperForObject:]):
(-[JSWrapperMap objcWrapperForJSValueRef:]):

  • API/JavaScriptCore.h:
  • API/ObjCCallbackFunction.h:
  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::ObjCCallbackFunction): We never actually should have retained the target in the case that we had a
block as a callback. Blocks are initially allocated on the stack and are only moved to the heap if we call their copy method.
Retaining the block on the stack was a bad idea because if that stack frame ever went away and we called the block later,
we'd crash and burn.
(ObjCCallbackFunction::setContext): We need a new setter for when the weak reference to a JSContext inside an ObjCCallbackFunction
disappears, we can allocate a new one in its place.
(ObjCCallbackFunction):
(objCCallbackFunctionCallAsFunction): Reset the callback's context if it's ever destroyed.
(objCCallbackFunctionForInvocation): Again, don't set the proto property because it uses black magic that can cause us to crash
depending on when this is called.
(objCCallbackFunctionForBlock): Here is where we copy the block to the heap when we're first creating the callback object for it.

  • API/tests/testapi.c:

(main):

  • API/tests/testapi.mm: We're going to get rid of the automatic block conversion, since that is causing leaks. I changed it

here in this test just so that it wouldn't mask any other potential leaks. Also modified some of the tests since JSContexts are
just lightweight wrappers now, we're not guaranteed to get the same pointer back from the call to [JSValue context] as the one
that the value was created in.
(-[TestObject callback:]):

(JSC::JSGlobalData::JSGlobalData): No more m_apiData.

  • runtime/JSGlobalData.h: Ditto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject): Ditto.

  • runtime/JSGlobalObject.h:

Source/WebCore:

Reviewed by Geoffrey Garen.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow): Since we're basically abandoning a JSDOMWindow here, we call
garbageCollectSoon().

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScriptController.h: New function to get the JSContext for the global object of the current main world.
  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::javaScriptContext): Ditto.

  • bindings/objc/WebScriptObject.h: Added ifdef guards. Also new convenience conversion function for the JSC Obj-C API.
  • bindings/objc/WebScriptObject.mm: JSC::JSValue and JSValue conflict with one another, so we have to be more specific.

(-[WebScriptObject _globalContextRef]): Useful helper function for getting the JSGlobalContextRef of a particular WebScriptObject.
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject webScriptValueAtIndex:]):
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
(-[WebScriptObject JSValue]): Implementation of convenience WebScriptObject conversion function to new Objective-C API.

  • bindings/objc/WebScriptObjectPrivate.h:

Source/WebKit/mac:

Reviewed by Geoffrey Garen.

Addition of appropriate delegate callbacks and support to the WebKit API.

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebDelegateImplementationCaching.h:

(WebFrameLoadDelegateImplementationCache):

  • WebView/WebFrame.h:
  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _javaScriptContextForScriptWorld:]):
(-[WebFrame javaScriptContext]):

  • WebView/WebFrameLoadDelegate.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame _convertValueToObjcValue:JSC::]):
(-[WebScriptCallFrame exception]):
(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptWorld.h:
  • WebView/WebScriptWorld.mm:

(+[WebScriptWorld scriptWorldForJavaScriptContext:]):

  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):
(aeDescFromJSValue):
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

Source/WTF:

Reviewed by Geoffrey Garen.

  • wtf/FeatureDefines.h: Added enable flag for JSC Objective-C API so it can be used in

export files.

Tools:

Reviewed by Geoffrey Garen.

Added new tests for the WebKit API portion of the JSC Objective-C API.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
  • TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
  • TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.

(-[MyConsole log:]):
(-[MyConsole printHelloWorld]):
(-[MyConsole add:to:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

11:56 AM Changeset in webkit [143636] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
https://bugs.webkit.org/show_bug.cgi?id=110404

Reviewed by Adam Barth.

The current function name is confusing
(See discussion in bug 110396). We should rename the functions
so that it becomes clear that "Node"/"Object" refers to a type
of a wrapper in the second argument.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):

11:39 AM Changeset in webkit [143635] by schenney@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, add myself as a reviewer

  • Scripts/webkitpy/common/config/committers.py:
11:35 AM Changeset in webkit [143634] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.6/Source/WebKit2

Merged r143552. <rdar://problem/13157837>

11:30 AM Changeset in webkit [143633] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.6/Source

Versioning.

11:26 AM Changeset in webkit [143632] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.6

New Tag.

11:20 AM Changeset in webkit [143631] by vivek.vg@samsung.com
  • 2 edits in trunk/Source/WebCore

[JS Binding] ScriptObject default constructor should initialize the Script State to 0
https://bugs.webkit.org/show_bug.cgi?id=110177

Reviewed by Geoffrey Garen.

Adding the initialization of ScriptState to 0.

  • bindings/js/ScriptObject.h:

(WebCore::ScriptObject::ScriptObject):

11:19 AM Changeset in webkit [143630] by Nate Chapin
  • 3 edits
    3 adds in trunk

REGRESSION: Crash in MainResourceLoader::setDataBufferingPolicy when sharing an html5 video via email
https://bugs.webkit.org/show_bug.cgi?id=110075

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: webarchive/loading/video-in-webarchive.html

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterContentPolicy): isStopping()

isn't accurate to determine whether a SubstituteData load should
continue, as this point in the code shouldn't be reachable from any point
where isStopping() would return true. DocumentLoader might have completely
stopped and believe that MainResourceLoader is complete, though. Don't
continue in that case.

(WebCore::MainResourceLoader::setDataBufferingPolicy): m_resource can be null

in a reasonable case, handle it rather than asserting that it can't be null.

LayoutTests:

  • webarchive/loading/resources/video-in-webarchive.webarchive: Added.
  • webarchive/loading/video-in-webarchive-expected.txt: Added.
  • webarchive/loading/video-in-webarchive.html: Added.
11:09 AM Changeset in webkit [143629] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebPagePrivate::load should not check new window policy
https://bugs.webkit.org/show_bug.cgi?id=110403

Patch by Andrew Lo <anlo@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Based on my understanding of changeset 135952, we should
not check the new window policy in WebPagePrivate::load.

None of the other ports seem to do this, except for plugins.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):

10:51 AM Changeset in webkit [143628] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r143616.
http://trac.webkit.org/changeset/143616
https://bugs.webkit.org/show_bug.cgi?id=110491

Caused a test failure on Chromium Mac. (Requested by vollick
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • page/FrameView.h:

(FrameView):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Removed.
  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Removed.
10:46 AM Changeset in webkit [143627] by robert@webkit.org
  • 9 edits in trunk/Source/WebCore

Overflow can be cleared just before it is computed
https://bugs.webkit.org/show_bug.cgi?id=110361

Reviewed by David Hyatt.

Overflow can be cleared just before it is computed in a lot of places because overflow computation happens all at once
now rather than cumulatively during layout. Any object that doesn't use computeOverflow() will still need to clear it manually
though.

No new tests, refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

10:25 AM Changeset in webkit [143626] by alokp@chromium.org
  • 303 edits
    4 copies
    5 adds in trunk

Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Reviewed by Simon Fraser.

Source/WebCore:

Mark layers as opaque in a very simple case - the main renderer has an
opaque background and covers the entire composited bounds.
RenderLayer::contentsOpaqueInRect has been implemented conservatively,
i.e. it errs towards returning false negative.

Tests: compositing/contents-opaque/contents-opaque-background-clip.html

compositing/contents-opaque/contents-opaque-background-color.html
compositing/contents-opaque/contents-opaque-layer-opacity.html
compositing/contents-opaque/contents-opaque-layer-transform.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsOpaqueInRect):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::backgroundIsOpaqueInRect):
(WebCore::RenderBoxModelObject::foregroundIsOpaqueInRect):
(RenderBoxModelObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listContentsOpaqueInRect):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

LayoutTests:

  • compositing/absolute-inside-out-of-view-fixed-expected.txt:
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/clip-child-by-non-stacking-ancestor-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/contents-opaque/contents-opaque-background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • compositing/contents-opaque/contents-opaque-background-clip.html: Added.
  • compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • compositing/contents-opaque/contents-opaque-background-color.html: Added.
  • compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
  • compositing/contents-opaque/contents-opaque-layer-opacity.html: Added.
  • compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
  • compositing/contents-opaque/contents-opaque-layer-transform.html: Added.
  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/clip-inside-expected.txt:
  • compositing/geometry/fixed-position-composited-switch-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/masks/mask-layer-size-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • compositing/overflow/textarea-scroll-touch-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • compositing/tiling/rotated-tiled-clamped-expected.txt:
  • compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • compositing/tiling/tile-cache-zoomed-expected.txt:
  • compositing/tiling/tiled-layer-resize-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/iframe-no-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium/compositing/geometry/clip-expected.txt:
  • platform/chromium/compositing/geometry/clip-inside-expected.txt:
  • platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt:
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
10:21 AM Changeset in webkit [143625] by jer.noble@apple.com
  • 3 edits in trunk/Tools

Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
10:07 AM Changeset in webkit [143624] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r143619 - [GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960

Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto

  • webkit/webkitwebview.cpp:

(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.

10:04 AM Changeset in webkit [143623] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r143620 - gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386

  • DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build

by include locale.h when we use setlocale.

10:02 AM Changeset in webkit [143622] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source

Merge r143618 - A couple more 'make dist' fixes for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add a missing file to the source list.

Source/WTF:

  • GNUmakefile.list.am: Add a missing file to the source list.
9:58 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
9:57 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
9:53 AM Changeset in webkit [143621] by jchaffraix@webkit.org
  • 6 edits in trunk

[CSS Grid Layout] Implement grid growth during auto placement
https://bugs.webkit.org/show_bug.cgi?id=110418

Reviewed by Ojan Vafai.

Source/WebCore:

This change implements the last remaining piece of the auto placement algorithm:
growing the grid mid-placement. With that landed, we should handle all cases properly.

Change covered by : fast/css-grid-layout/grid-item-addition-auto-placement.html

fast/css-grid-layout/grid-item-removal-auto-placement.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::growGrid):
Added this helper function to grow the grid one item in a direction.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Updated this function to grow in the minor axis direction and insert in the
newly created grid area.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated this function to grow in the major axis direction and insert in the
newly create grid area. Unfortunately this code cannot use the iterator to find
the new position as the (auto, auto) case iterates orthogonally to the major axis
direction, which we just grew.

  • rendering/RenderGrid.h:

Added growGrid.

LayoutTests:

  • fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt:
  • fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt:
9:52 AM Changeset in webkit [143620] by Martin Robinson
  • 2 edits in trunk/Tools

gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386

  • DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build

by include locale.h when we use setlocale.

9:50 AM Changeset in webkit [143619] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960

Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto

  • webkit/webkitwebview.cpp:

(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.

9:49 AM Changeset in webkit [143618] by Martin Robinson
  • 4 edits in trunk/Source

A couple more 'make dist' fixes for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add a missing file to the source list.

Source/WTF:

  • GNUmakefile.list.am: Add a missing file to the source list.
9:42 AM Changeset in webkit [143617] by abucur@adobe.com
  • 3 edits
    2 adds in trunk

-webkit-margin-collapse: separate doesn't work correctly for before margins
https://bugs.webkit.org/show_bug.cgi?id=109956

Reviewed by David Hyatt.

Source/WebCore:

The collapsing code for "-webkit-margin-collapse: separate" assumed the margin value inside
marginInfo always contributes to the position of the child. This is valid only if the collapse
doesn't happen at the before side of the container. In that case, the child needs to be positioned
at the margin value specified in the style sheet.

Test: fast/block/margin-collapse/webkit-margin-collapse-separate-position.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):

LayoutTests:

The test verifies a child specifying "-webkit-margin-collapse: separate" is correctly positioned inside
its container, at a value equal with the top margin of the child. The container also need to be sized
accordingly.

  • fast/block/margin-collapse/webkit-margin-collapse-separate-position-expected.txt: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-separate-position.html: Added.
9:31 AM Changeset in webkit [143616] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
https://bugs.webkit.org/show_bug.cgi?id=105486

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-21
Reviewed by James Robinson.

In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.

The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.

Source/WebCore:

Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • page/FrameView.h:

(FrameView):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.
9:18 AM Changeset in webkit [143615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
https://bugs.webkit.org/show_bug.cgi?id=110460

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

This was renamed incorrectly in r142879.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

9:11 AM Changeset in webkit [143614] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=110451

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Remove the extra ResourceRequest parameter from
FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

9:09 AM Changeset in webkit [143613] by mihnea@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Regions] border-radius on a region causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=103684

Reviewed by Tony Chang.

The fix for https://bugs.webkit.org/show_bug.cgi?id=74132, making RenderRegion
inherit from RenderBlock instead of RenderReplaced, also fixed this bug.
Still, it deserves a test.

  • fast/regions/last-region-border-radius-expected.html: Added.
  • fast/regions/last-region-border-radius.html: Added.
9:02 AM Changeset in webkit [143612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerFilterRenderer: fix inclusion of Vector.h
https://bugs.webkit.org/show_bug.cgi?id=110476

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Added in r124242. The include line should be wtf/Vector.h

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:
8:54 AM Changeset in webkit [143611] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
https://bugs.webkit.org/show_bug.cgi?id=110469

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.

This changed in r134765.

  • Api/WebViewportArguments.cpp:

(BlackBerry::WebKit::WebViewportArguments::zoom):
(BlackBerry::WebKit::WebViewportArguments::setZoom):
(BlackBerry::WebKit::WebViewportArguments::minZoom):
(BlackBerry::WebKit::WebViewportArguments::setMinZoom):
(BlackBerry::WebKit::WebViewportArguments::maxZoom):
(BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
(BlackBerry::WebKit::WebViewportArguments::userZoom):
(BlackBerry::WebKit::WebViewportArguments::setUserZoom):

  • Api/WebViewportArguments.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):

8:50 AM Changeset in webkit [143610] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move posting and scrollbar updates to the page client.
https://bugs.webkit.org/show_bug.cgi?id=110256
Internal PR 297099

Reviewed by Rob Buis.

In blitVisibleContents(), we were calling the WebKit thread
functions BackingStorePrivate::isScrollingOrZooming() and
WebPage::isVisible(). This is not the right spot to do it.
Furthermore, we want to move away from direct window access
in WebKit and leave that kind of dirtywork to the client.

This patch removes invalidateWindow() as well as the two
virtual scrollbar drawing functions and replaces it with
one new virtual, WebPageClient::postToSurface().
This clears up threading issues and gets us another step
further towards pure WebPageCompositor rendering.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPageClient.h:
8:46 AM Changeset in webkit [143609] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

[New Multicolumn] Add a positioned object pagination test.
https://bugs.webkit.org/show_bug.cgi?id=110480.

Reviewed by Antti Koivisto.

  • fast/multicol/newmulticol/positioned-split-expected.html: Added.
  • fast/multicol/newmulticol/positioned-split.html: Added.
8:37 AM Changeset in webkit [143608] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; unskip test that is now passing on the bots.

  • platform/efl/TestExpectations:
8:33 AM Changeset in webkit [143607] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=110449

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::locale):

  • WebCoreSupport/ColorPickerClient.h:

(ColorPickerClient):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::locale):

  • WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::locale):

  • WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

8:33 AM Changeset in webkit [143606] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

[New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread.
https://bugs.webkit.org/show_bug.cgi?id=110477.

Reviewed by Antti Koivisto.

I forgot that both the sets and the flow thread lay out before the containing
RenderMultiColumnBlock has finished. That means it hasn't computed its overflow yet.
Therefore there is no need to force it to compute its overflow from inside
RenderMultiColumnFlowThread::layout, because the minute RenderMultiColumnFlowThread
finishes its layout, the block will compute its overflow anyway.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

8:30 AM Changeset in webkit [143605] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp

Merge 143334

Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):

TBR=podivilov@chromium.org
Review URL: https://codereview.chromium.org/12316038

8:19 AM Changeset in webkit [143604] by Martin Robinson
  • 9 edits
    2 adds
    3 deletes in trunk

[GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293

Reviewed by Gustavo Noronha Silva.

.:

Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.

All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.

  • GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking

off a build. Also include generate-feature-defines-files in the distribution.

  • Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING

from the autoconf header, as it is already provided by the feature configuration.

  • Source/autotools/SetupWebKitFeatures.m4: Added.
  • Source/autotools/webkitfeature.m4: Removed. The functionality has been moved

to SetupWebKitFeatures.m4.

  • autogen.sh: Remove the call to override-feature-defines.
  • configure.ac: Now include SetupWebKitFeatures.

Source/WebCore:

  • GNUmakefile.am: No longer include GNUmakefile.features.am. We don't

have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.

Tools:

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.

  • gtk/generate-feature-defines-files: Added. A script which takes as an argument

the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.

  • gtk/override-feature-defines: Removed.
8:04 AM Changeset in webkit [143603] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rolling out an unindented change from r143580.

  • inspector/Inspector.json:
8:02 AM Changeset in webkit [143602] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip some tests which are passing; too bad nobody cared to file
bugs for them in the first place.

  • platform/efl/TestExpectations:
7:44 AM Changeset in webkit [143601] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

GlyphPage: Bake per-glyph font data array into same allocation as GlyphPage.

A hopeful fix for REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>

Reviewed by Antti Koivisto.

Rewire GlyphPage so that we have to decide at creation time whether there will be a per-glyph
array of SimpleFontData* or not. This removes one allocation and one step of indirection for
pages with glyphs from mixed fonts.

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createForMixedFontData):
(WebCore::GlyphPage::createForSingleFontData):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::removeFontDataFromSystemFallbackPage):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::hasPerGlyphFontData):
(GlyphPage):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

7:38 AM Changeset in webkit [143600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] MediaPlayerPrivateBlackBerry: include Logging.h
https://bugs.webkit.org/show_bug.cgi?id=110455

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Eric Carlson.

LOG is used in this file, so it is needed.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
7:33 AM Changeset in webkit [143599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
https://bugs.webkit.org/show_bug.cgi?id=110437

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Yong Li.

  • Api/WebKitTextCodec.cpp:

(WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
check enum values match between WebKit and WTF.
(BlackBerry::WebKit::base64Decode): Use a static cast directly to
convert from WebKit Base64DecodePolicy to WTF.
(BlackBerry::WebKit::base64Encode): Use a static cast directly to
convert from WebKit Base64EncodePolicy to WTF.

6:57 AM Changeset in webkit [143598] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add animation class for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110132

Reviewed by Kent Tamura.

Adding animation related classes as part of the calendar picker
redesign(Bug 109439).

No new tests. Code is not used yet.

  • Resources/pagepopups/calendarPicker.js:

(AnimationTimingFunction.Linear): Parameter t should be a number between 0 and 1.
(AnimationTimingFunction.EaseInOut): Ditto.
(AnimationManager): All animators are managed by this class so we
can dispatch "animationFrameWillFinish" event after all the updates.
(AnimationManager.prototype._startAnimation):
(AnimationManager.prototype._stopAnimation):
(AnimationManager.prototype.add): Adds an animator to the list of running animators.
(AnimationManager.prototype.remove): Removes an animator.
(AnimationManager.prototype._animationFrameCallback): Callback for requestAnimationFrame.
(AnimationManager.prototype._needsAnimationFrame): Returns true if we should request the next animation frame.
(AnimationManager.prototype.on): If we add a callback, request animation frame.
(AnimationManager.prototype.removeListener):
(Animator): Animates between the from value and to value.
(Animator.prototype.setFrom): Sets the from value.
(Animator.prototype.setTo): Sets the to value.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame): Called by AnimationManager.

6:49 AM WebKitGTK/Releasing edited by Carlos Garcia Campos
(diff)
6:26 AM Changeset in webkit [143597] by aandrey@chromium.org
  • 4 edits in trunk

Web Inspector: [Canvas] UI: more intuitive control buttons
https://bugs.webkit.org/show_bug.cgi?id=110327

Reviewed by Pavel Feldman.

Source/WebCore:

Tweaks to the CanvasProfiler replay control buttons.

  • NextDrawCall forward button (StepOver) should jump up to the last expanded node, otherwise a noop is not intuitive unless the last node is selected.
  • NextDrawCall/PrevDrawCall buttons should not skip draw call nodes themselves.
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):

LayoutTests:

  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
6:19 AM Changeset in webkit [143596] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Make SpellCheckRequest's constructor private.
https://bugs.webkit.org/show_bug.cgi?id=110462

Reviewed by Antonio Gomes.

It's no need to expose SpellCheckRequest's constructor.
There is SpellCheckRequest::create() method which is
responsible for creating SpellCheckRequest object.

No new tests, no behavior change.

  • editing/SpellChecker.h:

(SpellCheckRequest):

6:15 AM Changeset in webkit [143595] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] Remove arrays of DataGrid nodes from the View
https://bugs.webkit.org/show_bug.cgi?id=110325

Reviewed by Pavel Feldman.

Remove arrays of DataGrid nodes from the CanvasProfileView and use live DataGrid instead.
This is a prerequisite to support a non-fixed layered tree in the grid (for example, to hide
a single frame group node, or to combine several draw call groups into a pattern group).
Drive-by: added an assert to injected canvas module.

  • inspector/InjectedScriptCanvasModuleSource.js:
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._requestTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._peekLastRecursively):
(WebInspector.CanvasProfileView.prototype._appendCallNodes):
(WebInspector.CanvasProfileView.prototype.):
(WebInspector.CanvasProfileView.prototype.splitDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._appendCallNodesToFrameNode):

6:13 AM Changeset in webkit [143594] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/efl/fast/js/global-constructors-expected.txt: Ditto.
  • platform/efl/TestExpectations: Added editing/spelling/spelling-changed-text.html after r143470.
6:08 AM Changeset in webkit [143593] by apavlov@chromium.org
  • 29 edits
    2 deletes in trunk

Source/WebCore: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
Re-landing r143581 with a build fix for Windows.
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

This is a complete rework of the DOMStorage domain of the Web Inspector protocol. The most notable changes:

  • Session and local DOM storages are considered to implicitly exist for each SecurityOrigin in the page (previously, only those that were lazily created by DOMWindow would exist).
  • Consequently, the addDOMStorage event is gone.
  • StorageId is now an object rather than an opaque numeric identifier.
  • DOM storage modifiers no longer return a boolean indicating if the operation was successful. Clients should rely on the returned error message instead.

Implementation changes:

  • InspectorDOMStorageResource would rely on the frame for which it was created throughout its lifetime. As such, the frame removal from the page would break the respective DOM storage inspection. Since this concept was entirely flawed, InspectorDOMStorageResource has been removed. Instead, a StorageArea is retrieved based on the security origin specified by the client.
  • DOM storages can now be dynamically removed (upon the respective SecurityOrigin removal) in the frontend.
  • CMakeLists.txt: Remove InspectorDOMStorageResource.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/WebCoreMemoryInstrumentation.cpp: Ditto.
  • dom/WebCoreMemoryInstrumentation.h: Ditto.
  • inspector/InjectedScriptSource.js: Account for the structured StorageId.
  • inspector/Inspector.json: Update structures and API methods. Do not return boolean success flag and make use of the error message instead.
  • inspector/InspectorAllInOne.cpp: Remove InspectorDOMStorageResource.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Add InspectorPageAgent into InspectorDOMStorageAgent.

  • inspector/InspectorDOMStorageAgent.cpp: Mostly remove InspectorDOMStorageResource usages.

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems): Renamed.
(WebCore::toErrorString): Stringify ExceptionCode.
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId): Make it structured rather than a plain string.
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea): Added.
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage): Remove InspectorDOMStorageResource map.

  • inspector/InspectorDOMStorageAgent.h:

(WebCore::InspectorDOMStorageAgent::create): Update signature.
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Removed.
  • inspector/InspectorDOMStorageResource.h: Removed.
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl): Do not call the removed clearResources().

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Added.

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js: Entirely reworked to use the SecurityOriginAdded/Removed events.

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):

  • inspector/front-end/DOMStorageItemsView.js: Rename Entries -> Items to avoid confusion.

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):

  • inspector/front-end/ResourcesPanel.js: Follow the updated DOMStorage model.

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp: Remove instrumentation calls.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
6:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
6:04 AM WebKitGTK/2.0.x created by Carlos Garcia Campos
Add page for stable WebKitGTK+ 2.0
5:53 AM Changeset in webkit [143592] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.0

Branch WebKitGTK+ for 2.0

5:50 AM Changeset in webkit [143591] by Carlos Garcia Campos
  • 7 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit/gtk:

  • GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection

scanner.

Source/WebKit2:

  • GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection

scanner.

  • GNUmakefile.list.am: Add missing header to compilation and

remove one that no longer exists.

5:10 AM Changeset in webkit [143590] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
https://bugs.webkit.org/show_bug.cgi?id=110439

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Antonio Gomes.

This was changed in r142827.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

4:40 AM Changeset in webkit [143589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix access to ResourceHandle::context
https://bugs.webkit.org/show_bug.cgi?id=110443

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r141981.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):

4:39 AM Changeset in webkit [143588] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Replace QWebPageAdaptor::TouchAdjuster
https://bugs.webkit.org/show_bug.cgi?id=110226

Reviewed by Antonio Gomes.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::adjustPointForClicking):

  • WebCoreSupport/QWebPageAdapter.h:
4:38 AM Changeset in webkit [143587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayerBlackBerry: rename showDebugBorder to isShowingDebugBorder
https://bugs.webkit.org/show_bug.cgi?id=110453

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r133517.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

4:37 AM Changeset in webkit [143586] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

Web Inspector: take large strings out of CodeGeneratorInspector.py
https://bugs.webkit.org/show_bug.cgi?id=110159

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-21
Reviewed by Yury Semikhatsky.

Python script is refactored.

  • inspector/CodeGeneratorInspector.py:
  • inspector/CodeGeneratorInspectorStrings.py: Added.

(InspectorFrontend_h):
(InspectorFrontendChannel):
(InspectorArray):
(InspectorObject):
(String):
(InspectorFrontend):
(InspectorBackendDispatcher_h):
(InspectorAgent):
(InspectorBackendDispatcherImpl):
(InspectorBackendDispatcher):
(CallbackBase):
(void):
(HashMap):
(OptOutput):
(ExactlyInt):
(RuntimeCastHelper):
(provides):
(typename):
(Array):
(Builder):

4:30 AM WebKit Team edited by zarvai@inf.u-szeged.hu
add myself as committer (diff)
4:29 AM Changeset in webkit [143585] by commit-queue@webkit.org
  • 29 edits
    2 adds in trunk

Unreviewed, rolling out r143581.
http://trac.webkit.org/changeset/143581
https://bugs.webkit.org/show_bug.cgi?id=110457

Breaks Windows builds (compile + link) (Requested by apavlov
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::clearResources):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.h:

(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Added.

(WebCore):
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
(WebCore::InspectorDOMStorageResource::unbind):
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.h: Added.

(WebCore):
(InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::id):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get domain):
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
4:26 AM Changeset in webkit [143584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This was changed in r142879.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::willComposite):
(BlackBerry::WebKit::WebPagePrivate::didComposite):

4:09 AM Changeset in webkit [143583] by vsevik@chromium.org
  • 15 edits in trunk

Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
https://bugs.webkit.org/show_bug.cgi?id=110335

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced UISourceCode.parsedURL with UISourceCode.displayName().

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.displayName):
(WebInspector.UISourceCode.prototype.urlChanged):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype._scriptsAreParsed):

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/dynamic-scripts.html:
  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/source-url-comment.html:
  • inspector/styles/edit-inspector-stylesheet.html:
  • inspector/styles/styles-add-new-rule.html:
3:58 AM Changeset in webkit [143582] by mikhail.pozdnyakov@intel.com
  • 5 edits in trunk/Source/WebKit2

[WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
https://bugs.webkit.org/show_bug.cgi?id=110345

Reviewed by Andreas Kling.

WebView does not need to know about both PageViewportController and
PageViewportControllerClientEfl. Considering the fact that PageViewportController
will stop being WK2 internal and will be based on WK2 C API, it
should be owned by EwkView rather than WebView.

This patch is also a preparation for WKViewClient API extension to cover all
the places where PageViewportController and PageViewportControllerClientEfl
are accessed directly from WebView at the moment.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(EwkView::pageViewportControllerClient):
(EwkView::pageViewportController):
(EwkView):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

  • UIProcess/efl/WebView.h:

(WebView):

3:57 AM Changeset in webkit [143581] by apavlov@chromium.org
  • 29 edits
    2 deletes in trunk

Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::toErrorString):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.h:

(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Removed.
  • inspector/InspectorDOMStorageResource.h: Removed.
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
3:39 AM Changeset in webkit [143580] by eustas@chromium.org
  • 18 edits in trunk

Web Inspector: [Console] Add console API message types for profile/profileEnd.
https://bugs.webkit.org/show_bug.cgi?id=109790

Reviewed by Pavel Feldman.

With profile/profileEnd message types we will gain more control over
output messages.

  • English.lproj/localizedStrings.js: Added corresponging strings.
  • inspector/ConsoleAPITypes.h: Added enum members.
  • inspector/Inspector.json: Ditto.
  • inspector/front-end/ConsoleModel.js: Ditto.
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue): Added cases.

  • inspector/InspectorProfilerAgent.cpp: Adopted changes.
  • inspector/front-end/inspector.js: Ditto.
  • inspector/front-end/ConsoleMessage.js:

Added message generators for introduced message types.

  • inspector/front-end/ProfilesPanel.js:

Turned showProfileForURL(url) to showProfile(typeId, uid).

  • inspector/front-end/ProfilesPanelDescriptor.js:

(WebInspector.ProfilesPanelDescriptor.resolveProfileTitle): Added.

  • inspector/front-end/ResourceUtils.js: Removed linkifier plugins.
2:44 AM Changeset in webkit [143579] by zarvai@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/TestExpectations: Skip failing reftests.
  • platform/qt/TestExpectations: Skip failing tests after r143541 and r110447.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r143505.
2:43 AM Changeset in webkit [143578] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

OpenCL implementation of FEMerge filter.
https://bugs.webkit.org/show_bug.cgi?id=110193

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-21
Reviewed by Zoltan Herczeg.

In case of odd number of parameters the first parameter is copied to the destination image and
the rest of the parameters are merged in pairs.

  • Target.pri:
  • platform/graphics/filters/FEMerge.h:

(FEMerge):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Added.

(WebCore):
(WebCore::FilterContextOpenCL::compileFEMerge):
(WebCore::FilterContextOpenCL::copy): This is a simple copy method.
(WebCore::FilterContextOpenCL::applyFEMerge):
(WebCore::FEMerge::platformApplyOpenCL):

2:26 AM Changeset in webkit [143577] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r143470 and r143541.
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/gtk/fast/js/global-constructors-expected.txt: Ditto.
2:16 AM Changeset in webkit [143576] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add event dispatch class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110131

Reviewed by Kent Tamura.

Adding event dispatcher class as part of the new calendar picker patch at Bug 109439.

No new tests. Code is not yet used.

  • Resources/pagepopups/calendarPicker.js:

(EventEmitter):
(EventEmitter.prototype.on): Adds a callback for an event.
(EventEmitter.prototype.hasListener): Returns true if more than one listeners exist for an event type.
(EventEmitter.prototype.removeListener): Removes an event listener.
(EventEmitter.prototype.dispatchEvent): Dispatches an event to all callbacks. Takes variable number of arguments.

2:09 AM Changeset in webkit [143575] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped failing inpector tests after r143300.
https://bugs.webkit.org/show_bug.cgi?id=110440.

  • platform/qt/TestExpectations:
1:18 AM Changeset in webkit [143574] by commit-queue@webkit.org
  • 10 edits
    5 adds in trunk

Web Inspector: Add command for selecting files for file input element
https://bugs.webkit.org/show_bug.cgi?id=109308

Patch by Ken Kania <kkania@chromium.org> on 2013-02-21
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector-protocol/dom/setFileInputFiles.html

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canSetFileInputFiles):
(InspectorClient):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFileInputFiles):
(WebCore):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canSetFileInputFiles):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

LayoutTests:

  • inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
  • inspector-protocol/dom/setFileInputFiles.html: Added.
  • platform/chromium/inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
1:04 AM Changeset in webkit [143573] by commit-queue@webkit.org
  • 37 edits
    1 move
    2 adds in trunk

Source/WebCore: [Web Inspector]Add WebSocket networking events in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This patch add four WebSocket networking events in Timeline panel. The Events
are CreateWebSocket, SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse
and DestoryWebSocket. Thanks to Kitamura san's previous work.

Test: http/tests/inspector/websocket/timeline-websocket-event.html

  • English.lproj/localizedStrings.js:
  • Modules/websockets/WebSocketChannel.cpp: Add protocol information

(WebCore::WebSocketChannel::connect):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl): Add Timeline agent instrumentation for websocket
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): Ditto
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): Ditto
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl): Ditto

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore):
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Add Timeline record for websocket create
(WebCore::InspectorTimelineAgent::addWebSocketRecord): Add general websocket record
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Add Timeline record for websocket handshake request send
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Add Timeline record for websocket handshake response receive
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Add Timeline record for websocket destroy

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):

  • inspector/front-end/TimelineModel.js: Add Timeline record type for websocket
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):
(WebInspector.TimelinePresentationModel.prototype.reset): Add slot to store WebSocket Create record
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview): Add PopupContent for websocket record, including url and protocol

LayoutTests: [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This change add the record event type to test expections. The Events are CreateWebSocket,
SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse and DestoryWebSocket.
timeline-test.js was moved to http folder, since new added websocket test need it from server side.

  • http/tests/inspector/timeline-test.js: Renamed from LayoutTests/inspector/timeline/timeline-test.js.

(initialize_Timeline.InspectorTest.startTimeline.addRecord):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
(initialize_Timeline.step1):
(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline):
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.printTimestampRecords):
(initialize_Timeline.InspectorTest.innerPrintTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest.dumpTimelineRecords):
(initialize_Timeline.InspectorTest.printTimelineRecordProperties):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):
(initialize_Timeline.InspectorTest.FakeFileReader):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.cancel):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.loadedSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileName):
(initialize_Timeline.InspectorTest):
(initialize_Timeline):

  • http/tests/inspector/websocket/timeline-websocket-event-expected.txt: Added.
  • http/tests/inspector/websocket/timeline-websocket-event.html: Added.
  • inspector/timeline/timeline-animation-frame.html: Modify address of script "timeline-test.js"
  • inspector/timeline/timeline-decode-resize.html:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch.html:
  • inspector/timeline/timeline-frames.html:
  • inspector/timeline/timeline-injected-script-eval.html:
  • inspector/timeline/timeline-layout-reason.html:
  • inspector/timeline/timeline-layout.html:
  • inspector/timeline/timeline-load-event.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-mark-timeline.html:
  • inspector/timeline/timeline-network-received-data.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-parse-html.html:
  • inspector/timeline/timeline-recalculate-styles.html:
  • inspector/timeline/timeline-receive-response-event.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-start-time.html:
  • inspector/timeline/timeline-time-stamp.html:
  • inspector/timeline/timeline-time.html:
  • inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
  • inspector/timeline/timeline-timer.html:
  • inspector/timeline/timeline-trivial.html:
1:03 AM Changeset in webkit [143572] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Remove obsolete DEPENDPATH assignment

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann

qmake now adds CONFIG+=depend_includepath by default, making manual
DEPENDPATH setup unnecessary.

  • qmake/mkspecs/features/default_post.prf:
1:01 AM Changeset in webkit [143571] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fix pkg-config dependencies of QtWebKit itself

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann.

Don't override QMAKE_PKGCONFIG_REQUIRES needlessly.

  • WebCore.pri:
1:00 AM Changeset in webkit [143570] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-21
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

  • rendering/RenderFileUploadControl.cpp:

Add borderTop() and paddingTop() when computing position.

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border.html: Added.
  • fast/forms/file/file-vertical-padding-border-expected.html: Added.
12:27 AM Changeset in webkit [143569] by ap@apple.com
  • 9 edits in trunk/Source/WebCore

Stop hardcoding knowledge about blob protocol in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=110382

Reviewed by Anders Carlsson.

  • platform/network/BlobRegistry.h:
  • platform/network/chromium/BlobRegistryProxy.h: Removed loadResourceSynchronously(). Chromium did not even implement it, and cross-platform code doesn't need it any more either.
  • platform/network/BlobRegistryImpl.cpp: (WebCore::loadResourceSynchronously): A function to load a blob synchronously, suitable for being in a ResourceHandle map. (WebCore::registerBlobResourceHandleConstructor): Register loadResourceSynchronously too. (WebCore::BlobRegistryImpl::createResourceHandle): Don't make policy decisions here, it's just a registry. Moved code for checking request method down to BlobResourceHandle.
  • platform/network/BlobRegistryImpl.h: Removed BlobRegistryImpl::loadResourceSynchronously(). A registry shouldn't load resources, and it already has enough accessors to implement this externally.
  • platform/network/BlobResourceHandle.h:
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::createAsync): Renamed from create(), to make it clear that it's not OK to call from synchronous loader. Moved method check here. (WebCore::BlobResourceHandle::loadResourceSynchronously): Moved method check here. We used to fall through to NSURLConnection based loader when method was not GET, which of course resulted in an error eventually, but was just wrong.
  • platform/network/ResourceHandle.cpp: (WebCore::builtinResourceHandleSynchronousLoaderMap): Added a map for synchronous case. (WebCore::ResourceHandle::registerBuiltinSynchronousLoader): Ditto. (WebCore::ResourceHandle::loadResourceSynchronously): We no longer need to hardcode knowledge about blobRegistry and blobs here.
  • platform/network/ResourceHandle.h: Added registerBuiltinSynchronousLoader().
  • platform/network/chromium/ResourceHandle.h: Removed loadResourceSynchronously(), which was not implemented for Chromium.
Note: See TracTimeline for information about the timeline view.