Timeline
Jun 12, 2013:
- 11:10 PM Changeset in webkit [151537] by
-
- 2 edits in trunk/LayoutTests
[ARM] Unreviewed gardening, skip one more test to paint the bot green.
- platform/qt-arm/TestExpectations:
- 10:58 PM Changeset in webkit [151536] by
-
- 3 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build correction.
- win/tools32/vsprops/WinCairo.props: Switch from using the $WebKitLibraries environment variable to the newer $WebKit_Libraries.
- win/tools32/vsprops/debug_wincairo.props: Ditto.
- 6:48 PM Changeset in webkit [151535] by
-
- 2 edits in trunk/Tools
Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
- Scripts/webkitpy/common/config/ews.json:
- 6:15 PM Changeset in webkit [151534] by
-
- 4 edits3 moves in trunk/Websites/webkit.org
Update webkit.org build instructions for Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=117563.
Reviewed by Brent Fulgham.
- building/build.html:
- building/debug.html:
- building/launch-debugger-vs2005.png: Removed.
- building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
- building/set-as-startup-project-vs2005.png: Removed.
- building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
- building/set-debugging-properties-vs2005.png: Removed.
- building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
- building/tools.html:
- 6:13 PM Changeset in webkit [151533] by
-
- 3 edits29 adds in trunk/LayoutTests
Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/editing/selection/3690703-2-expected.png: Added.
- platform/efl/editing/selection/3690703-2-expected.txt: Added.
- platform/efl/editing/selection/3690703-expected.png: Added.
- platform/efl/editing/selection/3690703-expected.txt: Added.
- platform/efl/editing/selection/3690719-expected.png: Added.
- platform/efl/editing/selection/3690719-expected.txt: Added.
- platform/efl/editing/selection/4397952-expected.png: Added.
- platform/efl/editing/selection/4397952-expected.txt: Added.
- platform/efl/editing/selection/4895428-3-expected.png: Added.
- platform/efl/editing/selection/4895428-3-expected.txt: Added.
- platform/efl/editing/selection/4975120-expected.png: Added.
- platform/efl/editing/selection/4975120-expected.txt: Added.
- platform/efl/editing/selection/5007143-2-expected.png: Added.
- platform/efl/editing/selection/5007143-2-expected.txt: Added.
- platform/efl/editing/selection/5007143-expected.png: Added.
- platform/efl/editing/selection/5007143-expected.txt: Added.
- platform/efl/editing/selection/5057506-expected.png: Added.
- platform/efl/editing/selection/5057506-expected.txt: Added.
- platform/efl/editing/selection/5195166-1-expected.txt: Added.
- platform/efl/editing/selection/7152-2-expected.png: Added.
- platform/efl/editing/selection/7152-2-expected.txt: Added.
- platform/efl/editing/selection/caret-before-select-expected.png: Added.
- platform/efl/editing/selection/caret-before-select-expected.txt: Added.
- platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
- platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
- platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.
- 6:00 PM Changeset in webkit [151532] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Remove irrelevant blog from Planet WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117572
Reviewed by Mark Rowe.
- config.ini: Remove Chromium blog from planet.webkit.org
- 5:59 PM Changeset in webkit [151531] by
-
- 2 edits in trunk/Source/WTF
[Windows] Activate supported C++11 Features for VS2010
https://bugs.webkit.org/show_bug.cgi?id=117569
Reviewed by Anders Carlsson.
- wtf/Compiler.h: Turn on rvalue references and static_assert
when compiling with VS2010 (or newer)
- 5:34 PM Changeset in webkit [151530] by
-
- 18 edits in trunk/Source
Remove the notion of inactive plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117570
<rdar://problem/13484213>
Reviewed by Tim Horton.
Source/WebCore:
Remove RenderEmbeddedObject::PluginInactive and the replacement text.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
- rendering/RenderEmbeddedObject.h:
Source/WebKit/mac:
Remove code that deals with inactive plug-ins.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Source/WebKit2:
Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.
- Shared/Plugins/PluginModuleInfo.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
- UIProcess/Plugins/PluginInfoStore.cpp:
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- 5:10 PM BuildingOnWindows edited by
- (diff)
- 5:05 PM Changeset in webkit [151529] by
-
- 18 edits7 adds in trunk
[Windows] Implement Accessibility2 APIs in Windows.
https://bugs.webkit.org/show_bug.cgi?id=117561
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
- WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.
Source/WebKit/win:
- AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue
method with get_attribute from IAccessible2 API.
- AccessibleBase.h: Ditto.
- AccessibleDocument.cpp: Revise signatures for IAccessible2.
- AccessibleDocument.h: Ditto.
- AccessibleImage.cpp: Revise signatures for IAccessible2.
- AccessibleImage.h: Ditto.
- Interfaces/Accessible2: Added.
- Interfaces/Accessible2/Accessible2.idl: Added.
- Interfaces/Accessible2/Accessible2_2.idl: Added.
- Interfaces/Accessible2/AccessibleApplication.idl: Added.
- Interfaces/Accessible2/AccessibleRelation.idl: Added.
- Interfaces/Accessible2/AccessibleStates.idl: Added.
- Interfaces/Accessible2/IA2CommonTypes.idl: Added.
- Interfaces/AccessibleComparable.idl:
- Interfaces/WebKit.idl: Reference IAccessible2 types.
- WebFrame.cpp:
(WebFrame::accessible): Pass window handle to IAccessible types.
- 4:55 PM Changeset in webkit [151528] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Change default Traditional Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117568
Reviewed by Alexey Proskuryakov.
Change default font on newer versions of OS X.
- page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
on 10.9 and above.
- 4:53 PM Changeset in webkit [151527] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
https://bugs.webkit.org/show_bug.cgi?id=117564
Reviewed by Martin Robinson.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- 4:48 PM Changeset in webkit [151526] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Change default Simplified Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117567
Reviewed by Alexey Proskuryakov.
Change default font on newer versions of OS X.
- page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
instead of 'STSong' on newer systems.
- 4:30 PM Changeset in webkit [151525] by
-
- 2 edits in trunk/Source/WebCore
Fix crashes due to failed ImageBuffer allocation
https://bugs.webkit.org/show_bug.cgi?id=117541
Reviewed by Andreas Kling.
From Blink r152268 by <pdr@chromium.org>
A crash can happen due to a failed ImageBuffer allocation in
SVGImage::drawPatternForContainer(). Added a check for that failed allocation.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- 4:28 PM BuildingOnWindows edited by
- (diff)
- 4:20 PM BuildingOnWindows edited by
- (diff)
- 4:19 PM BuildingOnWindows edited by
- (diff)
- 4:13 PM BuildingOnWindows edited by
- (diff)
- 4:08 PM BuildingOnWindows edited by
- (diff)
- 3:56 PM BuildingOnWindows edited by
- (diff)
- 3:48 PM BuildingOnWindows edited by
- (diff)
- 3:46 PM BuildingOnWindows edited by
- (diff)
- 3:44 PM BuildingOnWindows edited by
- (diff)
- 3:29 PM BuildingOnWindows edited by
- (diff)
- 2:39 PM Changeset in webkit [151524] by
-
- 6 edits in trunk
[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
Reviewed by Martin Robinson.
Source/WebCore:
Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
AtkObject, to include custom implementations for AtkDocument and AtkText objects,
taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
AccessibilityUIElementAtk::language(), respectively.
Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.
No new functionality, no new tests.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentInterfaceInit): Chains implementation of
AtkDocument::get_document_locale() to AtkObject::get_object_locale().
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
objects of type AtkDocument and AtkText.
(webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.
Tools:
Locale resolution is moved to WebKitAccessibleWrapperAtk using
AtkObject::get_object_locale() API. Now, implementation of
AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
be leveraged to get_object_locale() of AtkObject.
Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.
No new functionality, no new tests.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
- 1:46 PM Changeset in webkit [151523] by
-
- 3 edits in trunk/Tools
Remove last bits of GYP from build-webkit and update-webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=117557
Reviewed by Ryosuke Niwa.
- Scripts/build-webkit:
- Scripts/update-webkit:
- 1:18 PM Changeset in webkit [151522] by
-
- 6 edits in trunk/Source
[GTK] Move more build targets for source code that's free of layer violations into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115936
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories
that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk
CPPFLAGS.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.
These build targets represent source files that are already free of platform layer violations and are as such
ready to be pushed down from the WebCore layer into the Platform layer.
Source/WebKit2:
- GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.
- 1:07 PM Changeset in webkit [151521] by
-
- 1 edit1 delete in trunk/Tools
Remove forgotten unused Tools/Script/make-gypi script
https://bugs.webkit.org/show_bug.cgi?id=117558
Reviewed by Ryosuke Niwa.
This script isn't used since the GYP removal from WebKit.
- Scripts/make-gypi: Removed.
- 12:58 PM Changeset in webkit [151520] by
-
- 7 edits in trunk/Source
"Open Video in New Window" doesn't make sense in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=117556
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Beth Dakin.
Source/WebCore:
No new tests needed.
- WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.
Source/WebKit2:
Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 12:52 PM Changeset in webkit [151519] by
-
- 3 edits2 adds in trunk
Accessibility code assumes an area element's parent is a map element
https://bugs.webkit.org/show_bug.cgi?id=117496
Reviewed by Chris Fleizach.
Source/WebCore:
We can't make such an assumption. Scripts can insert any element between area and map elements.
Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
Test: accessibility/image-map-with-indirect-area-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
LayoutTests:
Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
- accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
- accessibility/image-map-with-indirect-area-crash.html: Added.
- 12:20 PM Changeset in webkit [151518] by
-
- 3 edits2 adds in trunk
Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=117370
Reviewed by David Hyatt.
Test: fast/text/whitespace/inline-whitespace-wrapping-8.html
A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
Likewise when we finish iterating through the objects on a line we should clear our linebreak
if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.
Removing the trailing space from this measurement means we need to watch out for potential
breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
and enter an autowrap inline then we need to mark the beginning of the autowrap inline
as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
is an example of such a case.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117370
Reviewed by David Hyatt.
- fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.
- 11:59 AM Changeset in webkit [151517] by
-
- 16 edits4 adds in trunk
[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
https://bugs.webkit.org/show_bug.cgi?id=116745
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-12
Reviewed by Dirk Schulze.
Source/WebCore:
If ry is not supplied, it now defaults to the rx value. Also, if rx
and ry are not supplied, they default to 0px. This also has the effect
that the computed style for any rectangle or inset-rectangle now
contains all six parameters.
If rx > width/2 then it is clamped to width/2, and if ry > height/2,
then it is clamped to height/2. This happens at layout time because
given mixed units and relative units, that is the only time this
determination can be made.
Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html
fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Remove checks for undefined, since rx
and ry cannot be undefined in BasicShapes anymore.
(WebCore::basicShapeForValue): If radii are undefined in CSS, set
default values in the BasicShape, per the spec.
- rendering/ExclusionShape.cpp:
(WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii
don't overlap.
(WebCore::ExclusionShape::createExclusionShape): Remove defaulting to
zero, clamp radii per the spec.
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeRectangle::path): Remove defaulting.
(WebCore::BasicShapeRectangle::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::path): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting
to undefined for radii.
(WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to
prevent undefined.
(WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to
prevent undefined.
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to
prevent undefined.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to
prevent undefined.
LayoutTests:
Update tests to check for the rx and ry conditions.
- fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
- fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
- fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update
to reflect that the computed value now always has rx and ry.
- fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
- fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
- fast/exclusions/resources/rounded-rectangle.js:
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and
right into separate methods so that they can be used in tests that
only have left floats or only right floats.
(genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
(genRightRoundedRectFloatShapeOutsideRefTest): Ditto.
- fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
- fast/exclusions/shape-inside/shape-inside-animation.html: Change to
reflect new computed style value.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
Note that the expected test here uses shape-inside, because we
really are just testing that the behavior is the same as a
shape-inside with rx and ry set to 50%, and it turned out to be
very hard to construct an expected result that didn't use
shape-inside and wasn't off by a pixel.
- css3/masking/clip-path-animation.html: Update expected value.
- css3/masking/clip-path-animation-expected.txt: New results.
- 11:57 AM Changeset in webkit [151516] by
-
- 9 edits in trunk
[Windows] Support Title UI Element Accessibility Attribute
https://bugs.webkit.org/show_bug.cgi?id=117530
Reviewed by Anders Carlsson.
Source/WebCore:
Fixes: accessibility/list-item-role.html
accessibility/hidden-legend.html
- accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
for the Title UI Element object.
- accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,
which is more in keeping with the Mac's 'id' method signature.
Source/WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::attributeValue): Extend to handle Title UI Element.
- AccessibleBase.h: Revise signature to use a variant argument.
- Interfaces/AccessibleComparable.idl: Revise interface to use variant
- 11:53 AM Changeset in webkit [151515] by
-
- 1 edit17 adds in trunk/Websites/webkit.org
Add new Web Inspector images for a blog post.
- blog-files/new-inspector/activity-viewer.png: Added.
- blog-files/new-inspector/codemirror.png: Added.
- blog-files/new-inspector/console.png: Added.
- blog-files/new-inspector/hero-labeled.png: Added.
- blog-files/new-inspector/hero.png: Added.
- blog-files/new-inspector/layer-borders.png: Added.
- blog-files/new-inspector/layers.png: Added.
- blog-files/new-inspector/navigation-bar.png: Added.
- blog-files/new-inspector/open-sign.png: Added.
- blog-files/new-inspector/reasons.png: Added.
- blog-files/new-inspector/save.png: Added.
- blog-files/new-inspector/source-map.png: Added.
- blog-files/new-inspector/styles.png: Added.
- blog-files/new-inspector/toolbar-context-menu.png: Added.
- blog-files/new-inspector/toolbar-docked.png: Added.
- blog-files/new-inspector/toolbar.png: Added.
- 11:41 AM Changeset in webkit [151514] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=117553
Reviewed by Carlos Garcia Campos.
In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.
Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
No functionalities changed no new tests.
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
(WebCore::CredentialTransformData::locateSpecificPasswords):
- WebCoreSupport/CredentialTransformData.h:
- 11:28 AM Changeset in webkit [151513] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shaders] Animations and transitions should use validated custom programs
https://bugs.webkit.org/show_bug.cgi?id=117550
Run filters used for animations and transitions through RenderLayer::computeFilterOperations
in order to validate custom filter operations.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
Reviewed by Alexandru Chiculita.
No new tests as no platform can run custom filters with accelerated animations yet.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
- 10:33 AM Changeset in webkit [151512] by
-
- 13 edits in trunk/Source
Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Dean Jackson.
Source/WebCore:
This patch adds the ability for fullscreen
context menu item on <video> elements to switch between "Enter Fullscreen"
and "Exit Fullscreen" and behave appropriately.
No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.
- English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
- html/HTMLMediaElement.h:
- page/ContextMenuController.cpp:
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
was a media element in fullscreen.
(WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
HTMLMediaElement::toggleFullscreenState.
- rendering/HitTestResult.h:
Source/WebKit2:
- Shared/API/c/WKContextMenuItemTypes.h:
- Shared/API/c/WKSharedAPICast.h:
Added variables to support the toggle-ability of the fullscreen
video context menu item.
- 10:32 AM Changeset in webkit [151511] by
-
- 2 edits3 deletes in trunk/LayoutTests
[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.
- platform/qt-arm/TestExpectations:
- platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
- platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
- platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.
- 10:23 AM Changeset in webkit [151510] by
-
- 3 edits2 adds in trunk
Skipping {}, () and [] blocks while error recovering in CSS
https://bugs.webkit.org/show_bug.cgi?id=116071
Reviewed by Darin Adler.
From Blink r150201 and r150755 by <serya@chromium.org>
Source/WebCore:
Test: fast/css/parsing-expr-error-recovery.html
The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-expr-error-recovery-expected.txt: Added.
- fast/css/parsing-expr-error-recovery.html: Added.
- 10:22 AM Changeset in webkit [151509] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSExport header documentation substitutes "semicolon" for "colon"
https://bugs.webkit.org/show_bug.cgi?id=117552
Patch by Conrad Shultz <Conrad Shultz> on 2013-06-12
Reviewed by Mark Hahnenberg.
- API/JSExport.h:
Fix a couple typos.
- 10:17 AM Changeset in webkit [151508] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117412
Reviewed by Anders Carlsson.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching just invalidate the launcher. Reset the process
identifier after killing the process.
- 10:11 AM Changeset in webkit [151507] by
-
- 9 edits in trunk
[BlackBerry] Remove dead WebDOM code
https://bugs.webkit.org/show_bug.cgi?id=113370
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-12
Reviewed by Anders Carlsson.
BlackBerry PR 347565
Internally reviewed by Charles Wei.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- Api/WebPage.cpp:
- Api/WebPage.h:
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 10:01 AM Changeset in webkit [151506] by
-
- 5 edits in trunk/LayoutTests
[css exclusions] fast/css/variables/var-inside-shape.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116059
Reviewed by Alexandru Chiculita.
Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.
Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.
- fast/css/variables/var-inside-shape-expected.html:
- fast/css/variables/var-inside-shape.html:
- platform/efl/TestExpectations: Removed var-inside-shape.html.
- platform/gtk/TestExpectations: Ditto.
- 9:46 AM Changeset in webkit [151505] by
-
- 10 edits1 copy3 adds in trunk
window.find() case-insensitive search doesn't match diacritical marks
https://bugs.webkit.org/show_bug.cgi?id=117353
<rdar://problem/8535227>
Patch by Daniel Bates <dabates@apple.com> on 2013-06-12
Reviewed by Darin Adler.
Source/WebCore:
Currently, a case-insensitive window.find() search will return true for a word w
(e.g. café) with diacritical characters when w appears on the page without
diacritical marks (e.g. cafe). This leads to bad results, especially when
searching for a non-English word (e.g. qué) where the presence of an accented
character(s) may change the meaning of the word. Instead window.find() should
return false when case-insensitively matching a word with diacritical marks to
the same word without diacritical marks.
Test: fast/text/find-diacritical-mark.html
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
LayoutTests:
Added test to use window.find() to find a search string in text, where either
the search string or text (or both) contain diacritical characters.
Additionally, updated tests LayoutTests/fast/text/find-soft-hyphen.html
and LayoutTests/editing/execCommand/findString-diacriticals.html based on the
new behavior of window.find(). Moved function testFind() from LayoutTests/fast/text/script-tests/find-backwards.js
to its own file, LayoutTests/fast/text/resources/test-find.js, so that this function can
be used by both tests LayoutTests/fast/text/find-{backwards, diacritical-mark}.html.
- LayoutTests/editing/execCommand/findString-diacriticals.html: Update test based on the new
behavior of window.find().
- fast/text/find-backwards.html: Include external JavaScript file test-find.js.
- fast/text/find-case-folding-expected.txt: Rebase result; expected failure.
- fast/text/find-case-folding.html: Add comment to see bug #117548 with regards to expected failure.
- fast/text/find-diacritical-mark-expected.txt: Added.
- fast/text/find-diacritical-mark.html: Copied from LayoutTests/fast/text/find-backwards.html.
- fast/text/find-soft-hyphen-expected.txt: Rebase result.
- fast/text/resources/test-find.js: Added.
(testFind):
- fast/text/script-tests/find-backwards.js: Moved function testFind() from here to
file fast/text/resources/test-find.js and modified it to take an additional argument to
toggle search case sensitivity.
- fast/text/script-tests/find-diacritical-mark.js: Added.
- fast/text/script-tests/find-soft-hyphen.js: Update test based on the new behavior of window.find().
- 9:30 AM Changeset in webkit [151504] by
-
- 29 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, rolled back in http://trac.webkit.org/changeset/151362.
I fixed that the llint exception process was happening in common slow paths
even when call via the baseline JIT. Also moved emitSlow_* methods to
be right after the corresponding emit_* method.
2013-06-07 Michael Saboff <msaboff@apple.com>
fourthTier: The baseline jit and LLint should use common slow paths
https://bugs.webkit.org/show_bug.cgi?id=116889
- 9:06 AM Changeset in webkit [151503] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451
JIRA115644
https://jira.bbqnx.net/browse/BRWSR-7028
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-12
Reviewed by Rob Buis.
So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.
This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.
This patch completely revamps the algorithm for
determining where the backingstore should be positioned.
The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.
The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.
In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.
The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.
As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into
account.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
(BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
(BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 8:48 AM Changeset in webkit [151502] by
-
- 2 edits in trunk/LayoutTests
[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
https://bugs.webkit.org/show_bug.cgi?id=97199
Unreviewed, Qt Gardening.
Unskip test that is now passing on the bots.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-06-12
- platform/qt/TestExpectations:
- 8:37 AM Changeset in webkit [151501] by
-
- 3 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk:
------------------------------------------------------------------------
r148746 | jberlin@webkit.org | 2013-04-19 08:21:49 -0700 (Fri, 19 Apr 2013) | 3 lines
Fix expectations added in r148720.
------------------------------------------------------------------------
- 8:03 AM Changeset in webkit [151500] by
-
- 23 edits4 deletes in branches/dfgFourthTier/Source
Unreviewed, rolled out r151456, r151420:
Source/JavaScriptCore:
It causes layout test failures.
Source/WebCore:
It causes layout test failures.
- 7:49 AM WebKitIDL edited by
- Remove [IndexedGetter] and [NumericIndexedGetter] after r151499 (diff)
- 7:41 AM Changeset in webkit [151499] by
-
- 58 edits in trunk/Source/WebCore
Support latest Web IDL indexed property getters
https://bugs.webkit.org/show_bug.cgi?id=117507
Reviewed by Kentaro Hara.
Support latest Web IDL indexed property getters:
http://www.w3.org/TR/WebIDL/#dfn-support-indexed-properties
Drop support for outdated [IndexedGetter] and [NumericIndexedGetter]
IDL extended attributes. Since the new getter format specifies the
return type, the bindings generator is now smart enough to know if
the indexed getter is numeric or not on its own.
Based on Blink r149564 by <kojih@chromium.org>.
No new tests, no behavior change.
- Modules/filesystem/EntryArray.idl:
- Modules/filesystem/EntryArraySync.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- bindings/scripts/CodeGenerator.pm:
(IsNumericType):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetIndexedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestEventTarget.idl:
- bindings/scripts/test/TestTypedArray.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSTransformValue.idl:
- dom/ClientRectList.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DataTransferItemList.idl:
- dom/NamedNodeMap.idl:
- dom/NodeList.idl:
- dom/PropertyNodeList.idl:
- dom/TouchList.idl:
- fileapi/FileList.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLPropertiesCollection.idl:
- html/HTMLSelectElement.idl:
- html/RadioNodeList.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrackList.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResultList.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- 7:37 AM Changeset in webkit [151498] by
-
- 3 edits in trunk/Source/WebKit2
[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=117539
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-12
Reviewed by Noam Rosenthal.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- 6:50 AM Changeset in webkit [151497] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Unskipping passing tests.
- platform/gtk-wk2/TestExpectations:
- 6:39 AM Changeset in webkit [151496] by
-
- 2 edits in trunk/Tools
[GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
https://bugs.webkit.org/show_bug.cgi?id=117533
Patch by Andres Gomez <Andres Gomez> on 2013-06-12
Reviewed by Carlos Garcia Campos.
MiniBrowser now starts automatically the download of the documents
that cannot be shown just by WebKit itself on link left clicking.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): handled the
WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
- 5:49 AM WebKitIDL edited by
- Rename [CallWith] to [ConstructorCallWith] for interfaces (diff)
- 5:25 AM Changeset in webkit [151495] by
-
- 22 edits in trunk/Source/WebCore
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=117531
Reviewed by Kentaro Hara.
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.
Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.
No new tests, no behavior change.
- Modules/filesystem/FileWriter.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestInterface.idl:
- dom/MessageChannel.idl:
- fileapi/FileReader.idl:
- html/MediaController.idl:
- html/track/TextTrackCue.idl:
- page/EventSource.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- xml/XMLHttpRequest.idl:
- 4:44 AM Changeset in webkit [151494] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Set windows key-code for multimedia keys
https://bugs.webkit.org/show_bug.cgi?id=117535
Reviewed by Jocelyn Turcotte.
Map Qt Key-events to their defined windows keycode values.
- platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 4:34 AM Changeset in webkit [151493] by
-
- 3 edits in trunk/Source/WebCore
[Soup] Use ResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=112902
Reviewed by Carlos Garcia Campos.
Use the ResourceLoadPriority from the ResourceRequest to set the
correnpondent priority to each SoupMessage.
No new tests required as there is no change in functionality,
we're just enabling a new feature in the underlying network stack.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
- platform/network/soup/ResourceRequest.h:
(WebCore):
(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
to SoupMessagePriority.
- 1:51 AM Changeset in webkit [151492] by
-
- 4 edits in trunk
[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
https://bugs.webkit.org/show_bug.cgi?id=116723
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.
Tools:
- TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.
- 1:45 AM Changeset in webkit [151491] by
-
- 16 edits in trunk/Source
Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
https://bugs.webkit.org/show_bug.cgi?id=117512
Reviewed by Darin Adler.
Source/WebCore:
- page/Settings.in: Remove the memoryInfoEnabled and the quantizedMemoryInfoEnabled settings. These are not used
anywhere anymore after r151199 which simplified and moved the MemoryInfo interface under window.internals.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
Source/WebKit/mac:
- WebKit.order: Remove the memoryInfoEnabled entry.
- WebView/WebPreferenceKeysPrivate.h: Remove WebKitMemoryInfoEnabledPreferenceKey.
- WebView/WebPreferences.mm: Remove memoryInfoEnabled, setMemoryInfoEnabled methods.
(+[WebPreferences initialize]): Don't set the default value for the WebKitMemoryInfoEnabledPreferenceKey, the preference is being removed.
- WebView/WebPreferencesPrivate.h: Remove memoryInfoEnabled, setMemoryInfoEnabled method declarations.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl: Remove memoryInfoEnabled, setMemoryInfoEnabled entries.
- WebPreferenceKeysPrivate.h: Remove the WebKitMemoryInfoEnabledPreferenceKey definition.
- WebPreferences.cpp: Remove the memoryInfo, setMemoryInfoEnabled methods.
(WebPreferences::initializeDefaultSettings): Remove the WebKitMemoryInfoEnabledPreferenceKey entry initialization.
- WebPreferences.h: Remove the memoryInfo, setMemoryInfoEnabled method declarations.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Remove the Settings::setMemoryInfoEnabled call, the method is being removed.
- 1:36 AM Changeset in webkit [151490] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix.
- GNUmakefile.list.am: Adding missing build targets to the plugin process after r151480.
- 1:09 AM Changeset in webkit [151489] by
-
- 4 edits in trunk/Source
[GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
https://bugs.webkit.org/show_bug.cgi?id=117332
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-12
Reviewed by Xan Lopez.
Source/WebCore:
Add parameter 'pseudoElement' to the list of parameters that are allowed to
be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetGReturnMacro):
Source/WebKit/gtk:
Add test for function 'webkit_dom_dom_window_get_computed_style'.
- tests/testdomdomwindow.c:
(dom_dom_window_fixture_setup): Test setup for function
'dom_dom_window_get_computed_style'.
(dom_dom_window_fixture_teardown): Test teardown for function
'dom_dom_window_get_computed_style'.
(loadedCallback):
(test_dom_dom_window_get_computed_style): Checks function
'dom_dom_window_get_computed_style'.
(main):
- 12:20 AM Changeset in webkit [151488] by
-
- 4 edits in trunk
Add CSS parsing recovery to functions
https://bugs.webkit.org/show_bug.cgi?id=117500
Reviewed by Andreas Kling.
From Blink r150205 by <serya@chromium.org>
Source/WebCore:
Add parsing recovery capabilities to functions. Errors were
correctly detected without this change but then the whole
declaration was invalidated. By using expr_recovery to handle them
we can recover from those errors and go on with the parsing.
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-error-recovery.html: added some test cases for
parsing recovery inside functions.
Jun 11, 2013:
- 11:38 PM WebKitIDL edited by
- Bring back [ConstructorRaisesException] (diff)
- 11:05 PM Changeset in webkit [151487] by
-
- 16 edits in trunk/Source/WebCore
Unreviewed, rolling out r151378.
http://trac.webkit.org/changeset/151378
https://bugs.webkit.org/show_bug.cgi?id=117400
Decreased IDL readability a bit.
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/mediastream/RTCIceCandidate.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCSessionDescription.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestNamedConstructor.idl:
- css/WebKitCSSMatrix.idl:
- html/HTMLOptionElement.idl:
- page/EventSource.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 10:29 PM Changeset in webkit [151486] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL Gardening. Unskip fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
for efl-wk2. Because Ubuntu 13.04 solves issues related to xvfb. However, EFL WK1 doesn't support
webgl yet. So, it needs to be moved to efl-wk1 TestExpectations.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 10:10 PM Changeset in webkit [151485] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL Gardening.
EFL WK2 supports fast/canvas/webgl/read-pixels-test.html because Ubuntu 13.04 solves issues related to xvfb.
However, EFL WK1 doesn't support webgl yet. So, it is moved to efl-wk1 TestExpectations.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 8:09 PM Changeset in webkit [151484] by
-
- 7 edits in trunk/Source/WebKit2
Add NSSupportsAppNap keys to WebProcess, PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=117528
Reviewed by Mark Rowe.
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- add NSSupportsAppNap key.
- 7:54 PM Changeset in webkit [151483] by
-
- 2 edits in trunk/Tools
[EFL] Window resize should close the popupmenu
https://bugs.webkit.org/show_bug.cgi?id=117391
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-11
Reviewed by Christophe Dumez.
Added the code to close the popup when main window is resized.
- MiniBrowser/efl/main.c:
(on_window_resize):
- 6:47 PM Changeset in webkit [151482] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Unskip passing tests for new EFL bots.
fast/parser/document-write-fighting-eof.html
fast/parser/document-write-partial-entity-before-load.html
- platform/efl/TestExpectations:
- 6:40 PM Changeset in webkit [151481] by
-
- 90 edits4 deletes in branches/dfgFourthTier
Rolled back in <http://trac.webkit.org/changeset/151363>.
Source/JavaScriptCore:
Rubber stamped by Phil Pizlo.
The ASSERTs were due to the bytecode parser performing a
StructureTransitionWatchpoint optimization in a case where the CFA
wouldn't because the CFA could prove that the watchpoint would contradict
a preceding CheckStructure.
I fixed this by removing the bytecode parser optimization: now, we fully
rely on CFA and constant folding to optimize structure checks when
possible.
I verified that there's no performance change vs doing the optimization
in the bytecode parser. (The optimization is very simple, so this is not
surprising.)
LayoutTests:
Rubber stamped by Phil Pizlo.
- 6:12 PM Changeset in webkit [151480] by
-
- 6 edits2 adds in trunk/Source/WebKit2
Make sure we aren't throttling plugin timers during initialisation and destruction
https://bugs.webkit.org/show_bug.cgi?id=117522
Reviewed by Darin Adler.
Add a new ActivityAssertion RAII class to handle allowing/disallowing
timer throttling. Then make use of it during plugin initialisation
and destruction, as well as any synchronous messages (on the basis
that if another process is waiting for the plugin we shouldn't be
throttling timers).
- CMakeLists.txt:
- GNUmakefile.list.am:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):
- Shared/ActivityAssertion.cpp: Added.
(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):
- Shared/ActivityAssertion.h: Added.
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- 4:51 PM Changeset in webkit [151479] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build correction after r151440.
- AccessibleBase.cpp:
(MSAARole): Switch back to emiting ROLE_SYSTEM_LISTITEM for
ListItemRole Web role to avoid breaking existing test.
- 4:16 PM Changeset in webkit [151478] by
-
- 1 edit1 delete in trunk/WebKitLibraries
Unreviewed. Another part of rollout of r151408.
- win/tools64: Removed.
- win/tools64/scripts: Removed.
- win/tools64/vsprops: Removed.
- 3:23 PM Changeset in webkit [151477] by
-
- 2 edits in tags/Safari-537.44.1/WebKitLibraries
Merged r151474. <rdar://problem/14120726>
- 2:59 PM Changeset in webkit [151476] by
-
- 2 edits in trunk/Source/WebCore
Have to invalidate the mute button when changing the volume
https://bugs.webkit.org/show_bug.cgi?id=117464
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08
but without a test since the test doesn't work in WebKit.
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::changedVolume):
- 2:55 PM Changeset in webkit [151475] by
-
- 3 edits2 adds in trunk
[CSS Regions] Regions don't create a stacking context for their contents
https://bugs.webkit.org/show_bug.cgi?id=114268
Reviewed by Alexandru Chiculita.
Source/WebCore:
Paint the region content (from RenderFlowThread) during the background phase instead of the
foreground phase.
Let's assume there is a region and a sibling element. The sibling partially overlaps the
region and appears after the region in DOM order.
Before this patch, we would paint in this order:
1) Region background
2) Sibling background
3) Region content
4) Sibling content
As a result, the sibling background would incorrectly paint between the region
background and the region content. Instead, the sibling background should paint over the
region background and the region content.
After this patch, we paint in this order:
1) Region background
2) Region content
3) Sibling background
4) Sibling content
Test: fast/regions/region-sibling-paint-order.html
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintObject):
LayoutTests:
- fast/regions/region-sibling-paint-order-expected.html: Added.
- fast/regions/region-sibling-paint-order.html: Added.
- 2:46 PM Changeset in webkit [151474] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed. WinTools makefile fix.
- win/tools32/WinTools.make:
- 2:43 PM Changeset in webkit [151473] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: (r149232) videos on disney.com are initially scrambled on load
https://bugs.webkit.org/show_bug.cgi?id=117517
Reviewed by Eric Carlson.
Set a background color on the AVPlayerLayer to avoid corruption when no
frames are available to display.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
- 2:23 PM Changeset in webkit [151472] by
-
- 1 edit1 delete in trunk/Tools
Removed old broken code coverage tool.
https://bugs.webkit.org/show_bug.cgi?id=117520
Reviewed by Sam Weinig.
- CodeCoverage: Removed.
- CodeCoverage/README: Removed.
- CodeCoverage/amber.png: Removed.
- CodeCoverage/cov.py: Removed.
- CodeCoverage/emerald.png: Removed.
- CodeCoverage/gcov.css: Removed.
- CodeCoverage/glass.png: Removed.
- CodeCoverage/regenerate-coverage-display: Removed.
- CodeCoverage/ruby.png: Removed.
- CodeCoverage/run-generate-coverage-data: Removed.
- CodeCoverage/snow.png: Removed.
- 2:18 PM Changeset in webkit [151471] by
-
- 3 edits2 adds in trunk
Use HTMLElementFactory to create equivalent elements in WebVTTElement
https://bugs.webkit.org/show_bug.cgi?id=117423
Reviewed by Eric Carlson.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/3d60bec8e5dabfe877c482797d9ef430bfde31
This change forces the calls through the factory so that we create appropriate sub-classes based upon the passed tag name,
rather than just creating a concrete HTMLElement class with an inappropriate tag name.
Test: media/track/getCueAsHTMLCrash.html
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):
LayoutTests:
- media/track/getCueAsHTMLCrash-expected.txt: Added.
- media/track/getCueAsHTMLCrash.html: Added.
- 2:09 PM Changeset in webkit [151470] by
-
- 2 edits in trunk/Source/WebCore
Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
https://bugs.webkit.org/show_bug.cgi?id=117486
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Ryosuke Niwa.
Since this is pretty common, split the name selector to have the constant conditions
outside the traversal.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
- 1:55 PM Changeset in webkit [151469] by
-
- 11 edits in trunk
[Mac] Update text track menu
https://bugs.webkit.org/show_bug.cgi?id=117351
Reviewed by Darin Adler.
Source/WebCore:
No new tests, existing tests updated.
- English.lproj/Localizable.strings: Update the menu title.
- page/CaptionUserPreferencesMac.mm: System language is no longer needed.
- platform/LocalizedStrings.cpp: Ditto.
- platform/LocalizedStrings.h:
LayoutTests:
- media/video-controls-captions-trackmenu-localized.html:
- media/video-controls-captions-trackmenu-sorted.html:
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- 1:53 PM Changeset in webkit [151468] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
isContravenedByStructure is backwards
https://bugs.webkit.org/show_bug.cgi?id=117366
We should be checking if arrayModeForStructure(structure) is a
subset of arrayModesThatPassFiltering(), not the other way around.
Also renamed isContravenedByStructure to better reflect what the
function is trying to determine.
Rubber stamped by Filip Pizlo.
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode):
(JSC::DFG::ArrayTypeCheck::isContravenedByValue):
- 1:43 PM Changeset in webkit [151467] by
-
- 3 edits in trunk/Source/WebCore
Fix the element type in the selector checkers
https://bugs.webkit.org/show_bug.cgi?id=117450
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Anders Carlsson.
- css/SelectorCheckerFastPath.cpp:
(WebCore::HTMLNames::checkClassValue):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
- 1:40 PM Changeset in webkit [151466] by
-
- 3 edits in trunk/Source/WebCore
Clean up the initializer mess in Document
https://bugs.webkit.org/show_bug.cgi?id=117448
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Ryosuke Niwa.
Basic cleaning from
https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
- 1:39 PM Changeset in webkit [151465] by
-
- 2 edits in trunk/Tools
Have build-webkit build the WebInspectorUI project.
- Scripts/build-webkit:
- 1:12 PM Changeset in webkit [151464] by
-
- 1 edit1 move26 deletes in trunk/WebKitLibraries
Unreviewed, rolling out r151408.
http://trac.webkit.org/changeset/151408
https://bugs.webkit.org/show_bug.cgi?id=117519
Opting for a different approach (Requested by rfong on
#webkit).
- win/WinTools.make: Removed.
- win/tools32/WinTools.make: Renamed from WebKitLibraries/win/tools64/WinTools.make.
- win/tools64/scripts/COPYRIGHT-END-YEAR: Removed.
- win/tools64/scripts/VERSION: Removed.
- win/tools64/scripts/auto-version.sh: Removed.
- win/tools64/scripts/feature-defines.sh: Removed.
- win/tools64/vsprops/FeatureDefines.props: Removed.
- win/tools64/vsprops/FeatureDefines.vsprops: Removed.
- win/tools64/vsprops/FeatureDefinesCairo.props: Removed.
- win/tools64/vsprops/FeatureDefinesCairo.vsprops: Removed.
- win/tools64/vsprops/WinCairo.props: Removed.
- win/tools64/vsprops/WinCairo.vsprops: Removed.
- win/tools64/vsprops/cURL.props: Removed.
- win/tools64/vsprops/cURL.vsprops: Removed.
- win/tools64/vsprops/common.props: Removed.
- win/tools64/vsprops/common.vsprops: Removed.
- win/tools64/vsprops/debug.props: Removed.
- win/tools64/vsprops/debug.vsprops: Removed.
- win/tools64/vsprops/debug_all.vsprops: Removed.
- win/tools64/vsprops/debug_wincairo.props: Removed.
- win/tools64/vsprops/debug_wincairo.vsprops: Removed.
- win/tools64/vsprops/debugsuffix.props: Removed.
- win/tools64/vsprops/production.props: Removed.
- win/tools64/vsprops/production.vsprops: Removed.
- win/tools64/vsprops/release.props: Removed.
- win/tools64/vsprops/release.vsprops: Removed.
- win/tools64/vsprops/releaseproduction.vsprops: Removed.
- 1:08 PM Changeset in webkit [151463] by
-
- 6 edits3 adds in trunk/LayoutTests
Rebaseline results after r151451
Unreviewed, gardening.
- platform/efl/fast/forms/button-positioned-expected.txt:
- platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- platform/gtk/fast/forms/button-positioned-expected.txt:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- platform/win/fast/forms/onselect-textfield-expected.txt: Added.
- 1:03 PM Changeset in webkit [151462] by
-
- 3 edits in trunk/Tools
Add an option to run-webkit-tests to skip java dependency check
https://bugs.webkit.org/show_bug.cgi?id=117516
Reviewed by Andreas Kling.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/port/mac.py:
(MacPort._check_port_build):
- 1:02 PM Changeset in webkit [151461] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=117514
Removed extra Xcode code coverage flags.
Reviewed by Sam Weinig.
- Scripts/webkitdirs.pm:
(XcodeCoverageSupportOptions):
- 12:58 PM Changeset in webkit [151460] by
-
- 2 edits in trunk/Source/WebCore
Set the font size for in-band captions on the display box, not the :cue.
https://bugs.webkit.org/show_bug.cgi?id=117515
Reviewed by Eric Carlson.
Make the in-band font size behavior match the out-of-band behavior.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize):
- 12:53 PM Changeset in webkit [151459] by
-
- 10 edits1 add in trunk
Source/WebCore: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513
Reviewed by Anders Carlsson.
- WebCore.vcxproj/WebCore.vcxproj: Add new implementation file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- accessibility/win/AccessibilityObjectWrapperWin.cpp: Added.
- accessibility/win/AccessibilityObjectWrapperWin.h: Add declaration
Source/WebKit/win: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513
Reviewed by Anders Carlsson.
- AccessibleBase.cpp:
(AccessibleBase::attributeValue): Added.
- AccessibleBase.h: Added method declaration.
- Interfaces/AccessibleComparable.idl: New accessor interface.
Tools: [Windows] Implement 'attributeValue' accessor to support testing
https://bugs.webkit.org/show_bug.cgi?id=117513
Reviewed by Anders Carlsson.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(comparableObject): Move earlier in file.
(findAccessibleObjectById): New implemenation.
(AccessibilityController::accessibleElementById): New implementation.
- 12:49 PM Changeset in webkit [151458] by
-
- 11 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining various tests that are at the moment failing and need the new baseline.
- platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/pasteboard/8145-2-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:
- 12:37 PM Changeset in webkit [151457] by
-
- 1 edit1 copy2 deletes in tags/Safari-537.44.1/WebKitLibraries
Rollout of r151408.
- 12:20 PM Changeset in webkit [151456] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Removed unused local variable to fix cab build.
Unreviewed.
- interpreter/StackIterator.cpp:
(JSC::StackIterator::Frame::logicalFrame):
- 12:17 PM Changeset in webkit [151455] by
-
- 2 edits in trunk
Add WebInspectorUI to the Makefile.
Reviewed by Mark Rowe.
- Source/Makefile:
- 12:16 PM Changeset in webkit [151454] by
-
- 5 edits in trunk/Source
Update the framework bundle identifier for the Web Inspector.
Reviewed by Mark Rowe.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):
- 12:16 PM Changeset in webkit [151453] by
-
- 604 adds in trunk/Source/WebInspectorUI
Open Source the Safari Web Inspector back to WebKit.
- 12:06 PM Changeset in webkit [151452] by
-
- 1 edit30 copies1 delete in tags/Safari-537.44.1/WebKitLibraries
Merged r151408. <rdar://problem/14097829>
- 12:03 PM Changeset in webkit [151451] by
-
- 16 edits6 adds in trunk
Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
https://bugs.webkit.org/show_bug.cgi?id=93735
Reviewed by Darin Adler.
Source/WebCore:
Replaced elements that aren't RenderReplaced aren't |isReplaced| and don't have an
intrinsic height or width. This causes them to go down the wrong height and width computation
path in RenderBox when they are absolute positioned.
The notion of |isReplaced| is entwined with the notion of being |isInline| so it isn't really
possible to make them isReplaced without re-wiring a lot of code. So instead use an ad-hoc definition
of isReplacedElement in RenderBox to bring all replaced elements into the height and width calculation.
To make sure we get the right height and width in there, give non-RenderReplaced replaced renderers
the helpers for returning their approximation of intrinsic height and width.
Test: fast/replaced/width-and-height-of-positioned-replaced-elements.html
- rendering/RenderBox.cpp:
(WebCore::isReplacedElement):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
- rendering/RenderButton.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
- rendering/RenderListBox.h:
- rendering/RenderMenuList.h:
- rendering/RenderReplaced.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControl.h:
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- fast/replaced/width-and-height-of-positioned-replaced-elements.html: Added.
- platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- platform/qt/fast/forms/button-positioned-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 12:02 PM Changeset in webkit [151450] by
-
- 4 edits in tags/Safari-537.44.1/Source
Versioning.
- 11:48 AM Changeset in webkit [151449] by
-
- 3 edits in trunk/Source/WebCore
There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds
https://bugs.webkit.org/show_bug.cgi?id=117475
Reviewed by Andreas Kling.
Removed.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
- 11:48 AM Changeset in webkit [151448] by
-
- 1 edit2 adds in trunk/LayoutTests
Add baselines for test added in r151444
Unreviewed.
- platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
- 11:48 AM Changeset in webkit [151447] by
-
- 2 edits in trunk/Source/WebKit2
Do not filter cookies requested through the CookieStorageShim.
https://bugs.webkit.org/show_bug.cgi?id=117511
<rdar://problem/13603433>
Reviewed by Beth Dakin.
Since the shim function is called when the underlying media engine is
creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
not filter out HTTP-only cookies) rather than CookiesForDOM (which does).
- Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
- 11:33 AM Changeset in webkit [151446] by
-
- 2 edits in trunk/Source/WebCore
Fix typo in r151445
Unreviewed build fix.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
- 11:22 AM Changeset in webkit [151445] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=117490
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/be336b14325b2938ff6a4fb6191073a6e717a57c.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
- 11:11 AM Changeset in webkit [151444] by
-
- 3 edits4 adds in trunk
Painting collapsed borders during scrolling
https://bugs.webkit.org/show_bug.cgi?id=85658
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/table-cell-collapsed-border-scroll.html
WHen painting collapsed borders we need to paint the borders of the row above
the topmost dirtied row so that we compute the correct value for the dirtied row's collapsed border.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
LayoutTests:
- fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
- fast/repaint/table-cell-collapsed-border-scroll.html: Added.
- platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
- 10:49 AM Changeset in webkit [151443] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Type check hoisting phase has a dead if statement
https://bugs.webkit.org/show_bug.cgi?id=117510
Reviewed by Geoffrey Garen.
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- 10:09 AM WebKitGTK/2.0.x edited by
- Only bug fixes are allowed in the stable branch (diff)
- 10:08 AM Changeset in webkit [151442] by
-
- 1 copy in releases/WebKitGTK/webkit-2.0.3
Tagging the WebKitGTK+ 2.0.3 release
- 9:37 AM Changeset in webkit [151441] by
-
- 2 edits in trunk/Source/WebCore
[curl] Custom HTTP method support
https://bugs.webkit.org/show_bug.cgi?id=117302
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-11
Reviewed by Kenneth Rohde Christiansen.
No new tests, already covered by existing ones like:
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/methods-async.html
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):
- 8:32 AM Changeset in webkit [151440] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Provide MSAA mappings for more WebCore roles.
https://bugs.webkit.org/show_bug.cgi?id=117389
Reviewed by Chris Fleizach.
- AccessibleBase.cpp:
(MSAARole): Add additional mappings between WebCore roles and MSAA roles.
- 8:14 AM Changeset in webkit [151439] by
-
- 4 edits in trunk
Remove leftover wxWebkit code
https://bugs.webkit.org/show_bug.cgi?id=117471
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-11
Reviewed by Andreas Kling.
.:
- Source/cmake/WebKitPackaging.cmake:
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
- 8:09 AM Changeset in webkit [151438] by
-
- 2 edits in trunk/LayoutTests
editing/undo/undo-after-event-edited.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=117461
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1
- editing/undo/undo-after-event-edited.html:
- 8:06 AM Changeset in webkit [151437] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Remove 'using namespace std'
https://bugs.webkit.org/show_bug.cgi?id=117498
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-11
Reviewed by Anders Carlsson.
No new tests, no behavior change.
- inspector/InspectorAgent.cpp: Remove unneeded 'using namespace std'.
- inspector/InspectorFrontendClientLocal.cpp: Use explicit std:: qualifiers instead.
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
- inspector/InspectorFrontendHost.cpp: Remove unneeded 'using namespace std'.
- inspector/InspectorPageAgent.cpp: Remove unneeded 'using namespace std'.
- 7:42 AM Changeset in webkit [151436] by
-
- 4 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where needed.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-11
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.txt: Added.
- platform/qt/TestExpectations:
- 6:45 AM Changeset in webkit [151435] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 2.0.3 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.0.3.
- 6:28 AM WebKitIDL edited by
- Remove [NamedGetter] after r151434 (diff)
- 6:04 AM Changeset in webkit [151434] by
-
- 18 edits in trunk/Source/WebCore
Support latest Web IDL named property getters
https://bugs.webkit.org/show_bug.cgi?id=117403
Reviewed by Kentaro Hara.
Add support for the latest Web IDL named property getters to the JSC
bindings generator:
http://www.w3.org/TR/WebIDL/#idl-named-properties
Drop support for outdated [NamedGetter] IDL extended attribute.
Support for other kinds of named properties will be added in later
patches. This patch only brings named property getters.
This patch is based on Blink r149247 by kojih@chromium.org.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetSpecialAccessorFunctionForType):
(GetNamedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/IDLParser.pm:
(applyTypedefs):
(parseSpecialOperation):
(parseSpecials):
(applyMemberList):
- bindings/scripts/test/TestEventTarget.idl:
- css/StyleSheetList.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- dom/NodeList.idl:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLPropertiesCollection.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- 5:12 AM Changeset in webkit [151433] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=117504
Patch by Changhyup Jwa <ch.jwa@samsung.com> on 2013-06-11
Reviewed by Christophe Dumez.
There're many fails on efl webkit2 unit test if opengl is not available.
So, add fallback to non-opengl evas engine.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
- 3:47 AM Changeset in webkit [151432] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Rename gobject_introspection_required variable.
As gobject_introspection_required_version for consistency with all
other required_version variables.
- Source/autotools/FindDependencies.m4:
- Source/autotools/Versions.m4:
- 2:31 AM Changeset in webkit [151431] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r150182 - [GTK] TargetFrame and innerNodeFrame confused
https://bugs.webkit.org/show_bug.cgi?id=102907
Reviewed by Martin Robinson.
- webkit/webkithittestresult.cpp:
(WebKit::kit):
- 1:48 AM Changeset in webkit [151430] by
-
- 4 edits in trunk/LayoutTests
[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
https://bugs.webkit.org/show_bug.cgi?id=117295
Reviewed by Alexandru Chiculita.
Both test specify margins auto, which means that they can be computed to floats.
I changed the tests so that the margins are computed to integer values, to avoid
possible differences on platforms that enable subpixel layout.
- fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html:
- fast/regions/overflow-size-change-with-stacking-context-rtl.html:
- platform/qt/TestExpectations: Unskip the skipped test
- 1:39 AM Changeset in webkit [151429] by
-
- 11 edits in trunk
Make WTR use its own temporary directory for application cache
https://bugs.webkit.org/show_bug.cgi?id=117143
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetApplicationCacheDirectory):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::applicationCacheDirectory):
- UIProcess/WebContext.h:
(WebKit::WebContext::setApplicationCacheDirectory):
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 1:35 AM Changeset in webkit [151428] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Fix test_ewk2_context_menu
https://bugs.webkit.org/show_bug.cgi?id=116601
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-11
Reviewed by Gyuyoung Kim.
test_ewk2_context_menu is always passing, it does not test any context menu feature
as it ends before context menu is called.
One single test was divided into two tests: testing WebKit2 created context menu and
testing menus and items created by application.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTrue): added function introducing internal loop until boolean value is changed to true
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(customItemSelected):
(showContextMenu):
(showContextMenuForRemoveAndAppend):
(showContextMenuForSubmenu):
(hideContextMenu):
(TEST_F):
- 1:10 AM Changeset in webkit [151427] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk_view_navigate API
https://bugs.webkit.org/show_bug.cgi?id=117467
Reviewed by Christophe Dumez.
The applications will use this API to navigate history more than one step.
- UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for page to navigate.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_navigate_to): Added new API.
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Added more test case for navigation.
- 12:57 AM Changeset in webkit [151426] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
https://bugs.webkit.org/show_bug.cgi?id=117235
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-11
Reviewed by Rob Buis.
PR 346414.
After r150224 ResourceHandle::start() can fail returning false so
that the ResourceHandle is destroyed and the error not
handled. Handle the errors by scheduling a InvalidURLFailure and
returning true when startJob fails to make sure the ResourceHandle
is not destroyed and the error is handled and notified to the
client.
Fixes timeout in editing/execCommand/indent-paragraphs.html.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):
- 12:34 AM Changeset in webkit [151425] by
-
- 6 edits in trunk/Source/WebCore
Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
https://bugs.webkit.org/show_bug.cgi?id=117494
Reviewed by Darin Adler.
Merge: https://chromium.googlesource.com/chromium/blink/+/9433dc00e882e2808ac1db3c1fd89090896d7b58
https://chromium.googlesource.com/chromium/blink/+/7beaa73aa099170cb2cad02c12c5e0a448b12c21
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
- platform/graphics/IntRect.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
- 12:10 AM Changeset in webkit [151424] by
-
- 3 edits4 adds in trunk
Autoclose braces and parentheses at the end of style sheet
https://bugs.webkit.org/show_bug.cgi?id=117414
Reviewed by Andreas Kling.
From Blink r150202 by <serya@chromium.org>
Source/WebCore:
Use closing_parenthesis and closing_brace instead of the literals
'}' and ')'. This allows the parser to treat expressions with
unmatched closing braces/parenthesis as if all of them were
actually closed.
Tests: animations/keyframe-autoclose-brace.html
css3/autoclose-braces-and-parentheses.html
- css/CSSGrammar.y.in:
LayoutTests:
- animations/keyframe-autoclose-brace-expected.txt: Added.
- animations/keyframe-autoclose-brace.html: Added.
- css3/autoclose-braces-and-parentheses-expected.txt: Added.
- css3/autoclose-braces-and-parentheses.html: Added.
