Context Navigation

← Previous Period
Next Period →

Timeline

Oct 15, 2018:

11:05 PM Changeset in webkit [237172] by bshafiei@apple.com

7 edits in tags/Safari-607.1.10.3/Source

Versioning.

11:00 PM Changeset in webkit [237171] by bshafiei@apple.com

1 copy in tags/Safari-607.1.10.3

New tag.

9:57 PM Changeset in webkit [237170] by Justin Fan

26 edits in trunk

Add WebGPU 2018 feature flag and experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=190509

Reviewed by Dean Jackson.

Update FeatureDefines for WebGPU -> WebMetal renaming, while preserving WebGPU
references for 2018 WebGPU Sketch implementation.

Source/cmake/OptionsMac.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

Configurations/FeatureDefines.xcconfig:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebGPUEnabled):
(WebCore::RuntimeEnabledFeatures::webGPUEnabled const):

Source/WebCore/PAL:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

Configurations/FeatureDefines.xcconfig:
Shared/WebPreferences.yaml:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webGPUEnabled]):
(-[WebPreferences setWebGPUEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
for the 2018 WebGPU prototype.

DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

DumpRenderTree/TestOptions.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

6:30 PM Changeset in webkit [237169] by guijemont@igalia.com

2 edits in trunk/JSTests

Skip stress/array-prototype-concat-of-long-spliced-arrays2.js on arm and mips/linux

Unreviewed gardening.

stress/array-prototype-concat-of-long-spliced-arrays2.js:

6:15 PM Changeset in webkit [237168] by commit-queue@webkit.org

5 edits
3 adds in trunk/Source/WebCore

Unreviewed, rolling out r237162.
https://bugs.webkit.org/show_bug.cgi?id=190612

Broke Windows build (Requested by dolmstead on #webkit).

Reverted changeset:

"Add stub implementation for accessibility objects"
https://bugs.webkit.org/show_bug.cgi?id=190608
https://trac.webkit.org/changeset/237162

6:12 PM Changeset in webkit [237167] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix API tests after r237146

Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::decode):
I accidentally changed the decoder.

6:04 PM Changeset in webkit [237166] by Ryan Haddad

2 edits in trunk/Source/WebKit

HSTS cache entries cannot be removed by origin
https://bugs.webkit.org/show_bug.cgi?id=190455
<rdar://problem/45181322>

Patch by Sihui Liu <sihui_liu@apple.com> on 2018-10-15
Reviewed by Chris Dumez.

The SPI _CFNetworkResetHSTS does not recognize url without protocol, so we need to add protocol manually.

NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):

6:02 PM Changeset in webkit [237165] by achristensen@apple.com

4 edits in trunk/Source

Source/WebKit:
Fix GTK build, even though bots are not working right now.

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):

Source/WebKitLegacy/win:
Fix Windows build.

WebView.cpp:

(WebView::loadBackForwardListFromOtherView):

5:56 PM Changeset in webkit [237164] by achristensen@apple.com

2 edits in trunk/Source/WebKitLegacy/win

Fix WinCairo build.

WebView.cpp:

(WebView::backForwardList):

5:53 PM Changeset in webkit [237163] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[CG] Adopt CG SPI for non-even cornered rounded rects
https://bugs.webkit.org/show_bug.cgi?id=190155

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-10-15
Reviewed by Simon Fraser.

Source/WebCore:

Instead of creating bezier curves for the non-even corners of the rounded
rects, we should use the optimized SPI provided by CG.

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

Source/WebCore/PAL:

pal/spi/cg/CoreGraphicsSPI.h:

5:46 PM Changeset in webkit [237162] by don.olmstead@sony.com

5 edits
1 delete in trunk/Source/WebCore

Add stub implementation for accessibility objects
https://bugs.webkit.org/show_bug.cgi?id=190608

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Add default implementation to associated cpp file. Removes the WPE
specific stubs.

SourcesWPE.txt:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment const):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

accessibility/AccessibilityObject.h:
accessibility/wpe/AXObjectCacheWPE.cpp: Removed.
accessibility/wpe/AccessibilityObjectWPE.cpp: Removed.

5:38 PM Changeset in webkit [237161] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix WinCairo build after r237146

UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):

5:34 PM Changeset in webkit [237160] by achristensen@apple.com

2 edits in trunk/Source/WebKitLegacy/mac

Fix iOS build after r237157

WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

5:32 PM Changeset in webkit [237159] by Chris Dumez

2 edits in trunk/Source/WebKit

REGRESSION (r236512): [ Mac WK2 ] Layout Test editing/undo/undo-smart-delete-word.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190375
<rdar://problem/45177807>

Reviewed by Ryosuke Niwa.

The test is doing the following:

document.execCommand("Delete"); document.execCommand("Undo");

Both operation are synchronous and rely on synchronous IPC from the WebProcess to the UIProcess.
However, for the undo operation to succeed, the first command need to have been registered with
with the UIProcess via the WebPageProxy::RegisterEditCommandForUndo IPC to the UIProcess, which
is asynchronous.

After r236512, the UIProcess no longer processes incoming sync / async IPC in order and thus,
it is possible for the WebPageProxy::ExecuteUndoRedo synchronous IPC to get processed by the
UIProcess *before* the WebPageProxy::RegisterEditCommandForUndo asynchronous IPC for the
previous "Delete" command. As a result, canUndo would return false and we would fail to undo.

To address the issue, use SendOption::DispatchMessageEvenWhenWaitingForSyncReply flag when sending
the WebPageProxy::RegisterEditCommandForUndo IPC, so that it gets processed in order with regards
to surrounding synchronous IPC.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerUndoStep):

5:30 PM Changeset in webkit [237158] by Ryan Haddad

2 edits in trunk/Tools

Update bot configuration for Sierra archive queues
https://bugs.webkit.org/show_bug.cgi?id=190605

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/config.json:

5:14 PM Changeset in webkit [237157] by achristensen@apple.com

28 edits in trunk/Source

Modernize BackForwardClient.h
https://bugs.webkit.org/show_bug.cgi?id=190610

Reviewed by Chris Dumez.

Source/WebCore:

editing/markup.cpp:

(WebCore::createPageForSanitizingWebContent):

history/BackForwardClient.h:
history/BackForwardController.h:

(WebCore::BackForwardController::client):
(WebCore::BackForwardController::client const):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/EmptyClients.cpp:

(WebCore::pageConfigurationWithEmptyClients):
(WebCore::createEmptyFrameNetworkingContext): Deleted.
(WebCore::fillWithEmptyClients): Deleted.
(WebCore::createEmptyEditorClient): Deleted.

loader/EmptyClients.h:
page/Page.cpp:

(WebCore::Page::Page):

page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

page/PageConfiguration.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:

(WebKit::InjectedBundleBackForwardList::clear):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::installServiceWorker):

WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
(WebKit::WebBackForwardListProxy::backListCount const):
(WebKit::WebBackForwardListProxy::forwardListCount const):
(WebKit::WebBackForwardListProxy::backListCount): Deleted.
(WebKit::WebBackForwardListProxy::forwardListCount): Deleted.

WebProcess/WebPage/WebBackForwardListProxy.h:

(WebKit::WebBackForwardListProxy::create):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):
(WebKit::WebPage::restoreSessionInternal):

Source/WebKitLegacy/mac:

History/BackForwardList.h:
History/BackForwardList.mm:

(BackForwardList::backListCount const):
(BackForwardList::forwardListCount const):
(BackForwardList::backListCount): Deleted.
(BackForwardList::forwardListCount): Deleted.

History/WebBackForwardList.mm:

(-[WebBackForwardList init]):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canCachePage const):

WebView/WebFrameView.mm:

(-[WebFrameView keyDown:keyDown:]):

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView initWithCoder:]):
(-[WebView encodeWithCoder:]):
(-[WebView backForwardList]):
(-[WebView setMaintainsBackForwardList:]):

Source/WebKitLegacy/win:

BackForwardList.cpp:

(BackForwardList::backListCount const):
(BackForwardList::forwardListCount const):
(BackForwardList::backListCount): Deleted.
(BackForwardList::forwardListCount): Deleted.

BackForwardList.h:
WebView.cpp:

(WebView::initWithFrame):
(WebView::backForwardList):

4:43 PM Changeset in webkit [237156] by timothy@apple.com

33 edits
7 adds in trunk

Add support for prefers-color-scheme media query
https://bugs.webkit.org/show_bug.cgi?id=190499
rdar://problem/45212025

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.

Source/WebCore:

Test: css-dark-mode/prefers-color-scheme.html

Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
css/CSSValueKeywords.in: Added light and dark.
css/MediaFeatureNames.h: Added prefers-color-scheme.
css/MediaQueryEvaluator.cpp:

(WebCore::prefersColorSchemeEvaluate): Added.

css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent): Added prefers-color-scheme.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDarkModeCSSEnabled): Added.
(WebCore::RuntimeEnabledFeatures::darkModeCSSEnabled const): Added.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::resetToConsistentState): Reset setUseDarkAppearance.
(WebCore::InternalSettings::setUseDarkAppearance): Added.

testing/InternalSettings.h: Added setUseDarkAppearance.
testing/InternalSettings.idl: Ditto.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.

Source/WebKit:

Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
Shared/WebPreferences.yaml: Added DarkModeCSSEnabled as experimental.

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.

Source/WTF:

wtf/FeatureDefines.h: Added ENABLE_DARK_MODE_CSS.

Tools:

Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.

LayoutTests:

css-dark-mode/prefers-color-scheme-expected.txt: Added.
css-dark-mode/prefers-color-scheme.html: Added.
platform/gtk/TestExpectations: Skip css-dark-mode.
platform/ios/TestExpectations: Skip css-dark-mode.
platform/mac-wk1/TestExpectations: Skip css-dark-mode.
platform/win/TestExpectations: Skip css-dark-mode.
platform/wincairo/TestExpectations: Skip css-dark-mode.
platform/wpe/TestExpectations: Skip css-dark-mode.

4:29 PM Changeset in webkit [237155] by Matt Baker

4 edits in trunk/LayoutTests

Web Inspector: Cleanup Table test utilities
https://bugs.webkit.org/show_bug.cgi?id=190538
<rdar://problem/45237730>

Reviewed by Joseph Pecoraro.

Cleanup Table test utilities by exposing removing the artificial dependency
between TableDelegate and TableDataSource, and exposing a cleaner set of
utility methods to InspectorTest. This patch changes InspectorTest.createTable
to take no parameters, and adds InspectorTest.createTableWithDelegate for
tests that need to supply a custom delegate.

inspector/table/resources/table-utilities.js:

(TestPage.registerInitializer.InspectorTest.TableDataSource):
(TestPage.registerInitializer.InspectorTest.TableDelegate):
(TestPage.registerInitializer.InspectorTest.TableDelegate.prototype.tablePopulateCell):
(TestPage.registerInitializer.createDataSource):
(TestPage.registerInitializer.createTableInternal):
(TestPage.registerInitializer.InspectorTest.createTable):
(TestPage.registerInitializer.InspectorTest.createTableWithDelegate):
(TestPage.registerInitializer):

inspector/table/table-selection-expected.txt:

Update with new test suite name.

inspector/table/table-selection.html:

4:18 PM Changeset in webkit [237154] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit

Remove StorageProcess leftover
https://bugs.webkit.org/show_bug.cgi?id=190591

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-15
Reviewed by Michael Catanzaro.

The process was deleted.

Shared/ChildProcess.h:
Shared/mac/ChildProcessMac.mm:

(WebKit::processStorageClass):
(WebKit::sandboxDirectory):

UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::getLaunchOptions):

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):

4:14 PM Changeset in webkit [237153] by commit-queue@webkit.org

2 edits in trunk/Tools

[JHBuild] Add xdg-dbus-proxy module
https://bugs.webkit.org/show_bug.cgi?id=190589

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-15
Reviewed by Michael Catanzaro.

gtk/jhbuild.modules:

4:14 PM Changeset in webkit [237152] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Add new sandboxing dependencies to install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=190588

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-15
Reviewed by Michael Catanzaro.

gtk/install-dependencies:

4:10 PM Changeset in webkit [237151] by commit-queue@webkit.org

7 edits
3 adds in trunk

Web Inspector: Expose Server Timing Response Headers in Network Tab
https://bugs.webkit.org/show_bug.cgi?id=190440

Patch by Charles Vazac <cvazac@gmail.com> on 2018-10-15
Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Localizations/en.lproj/localizedStrings.js: new key "Server Timing:"
UserInterface/Main.html: add reference to Models/ServerTimingEntry.js
UserInterface/Models/Resource.js:

(WI.Resource.prototype.get serverTiming):
(WI.Resource.prototype.updateForResponse):

UserInterface/Models/ServerTimingEntry.js: Added.

(WI.ServerTimingEntry):
(WI.ServerTimingEntry.parseHeaders): parse raw response headers into an array of ServerTimingEntry objects
(WI.ServerTimingEntry.parseHeaders.consumeDelimiter):
(WI.ServerTimingEntry.parseHeaders.consumeToken):
(WI.ServerTimingEntry.):

UserInterface/Test.html: add reference to Models/ServerTimingEntry.js
UserInterface/Views/ResourceTimingBreakdownView.js:

(WI.ResourceTimingBreakdownView.prototype._appendServerTimingRow): render a table row per ServerTimingEntry object
(WI.ResourceTimingBreakdownView.prototype.initialLayout):
(WI.ResourceTimingBreakdownView):

LayoutTests:

inspector/unit-tests/server-timing-entry-expected.txt:
inspector/unit-tests/server-timing-entry.html:

3:51 PM Changeset in webkit [237150] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: pseudo elements in DOM tree are too dark
https://bugs.webkit.org/show_bug.cgi?id=190541
<rdar://problem/45238443>

Reviewed by Matt Baker.

UserInterface/Views/DOMTreeOutline.css:

(@media (prefers-dark-interface)):
(.tree-outline.dom .html-pseudo-element):

3:35 PM Changeset in webkit [237149] by achristensen@apple.com

1 edit
1 delete in trunk/LayoutTests

Garden WK2 tests after r237104
https://bugs.webkit.org/show_bug.cgi?id=190522

platform/wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Removed.

I added this wk2 expectation in r234658 after r234640. r237104 effectively did the inverse of r234640,
so behavior is back to how it was before then. This makes the expectations reflect such.

2:45 PM Changeset in webkit [237148] by achristensen@apple.com

17 edits in trunk/Source

Remove unused WebView._globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=190601

Reviewed by Chris Dumez.

Source/WebCore:

This was a hack to give the client a more reliable current back/forward item, but it hasn't been used for years
and it's adding unnecessary complexity to the history code.

loader/EmptyFrameLoaderClient.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

loader/FrameLoaderClient.h:
loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.

WebView/WebView.mm:

(-[WebView _globalHistoryItem]): Deleted.
(-[WebView _setGlobalHistoryItem:]): Deleted.

WebView/WebViewData.h:
WebView/WebViewInternal.h:
WebView/WebViewPrivate.h:

Source/WebKitLegacy/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.

WebCoreSupport/WebFrameLoaderClient.h:
WebView.cpp:

(WebView::globalHistoryItem):
(WebView::setGlobalHistoryItem): Deleted.

WebView.h:

2:40 PM Changeset in webkit [237147] by Ryan Haddad

7 edits
2 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r237084, r237088, r237098, and
r237114.
https://bugs.webkit.org/show_bug.cgi?id=190602

Breaks internal builds. (Requested by ryanhaddad on #webkit).

Reverted changesets:

"Separate configuration extraction from offset extraction"
https://bugs.webkit.org/show_bug.cgi?id=189708
https://trac.webkit.org/changeset/237084

"Gardening: Build fix after r237084."
https://bugs.webkit.org/show_bug.cgi?id=189708
https://trac.webkit.org/changeset/237088

"Gardening: Build fix after r237084."
https://bugs.webkit.org/show_bug.cgi?id=189708
https://trac.webkit.org/changeset/237098

"REGRESSION (r237084): JavaScriptCore fails to build on Linux"
https://trac.webkit.org/changeset/237114

Patch by Commit Queue <commit-queue@webkit.org> on 2018-10-15

2:33 PM Changeset in webkit [237146] by achristensen@apple.com

9 edits in trunk/Source/WebKit

Remove unused parameters of WebPageGroupData
https://bugs.webkit.org/show_bug.cgi?id=190600

Reviewed by Chris Dumez.

visibleToInjectedBundle and visibleToHistoryClient are both always true.
This removes a mysterious check in the history code.

Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode const):
(WebKit::WebPageGroupData::decode):

Shared/WebPageGroupData.h:
UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::create):
(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):

UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::create):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create):
(WebKit::WebPage::close):

WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::create):

WebProcess/WebPage/WebPageGroupProxy.h:

(WebKit::WebPageGroupProxy::pageGroupID const):
(WebKit::WebPageGroupProxy::isVisibleToInjectedBundle const): Deleted.
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient const): Deleted.

2:21 PM Changeset in webkit [237145] by Matt Baker

3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r233824): execution highlight range missing/incorrect in pretty printed code
https://bugs.webkit.org/show_bug.cgi?id=188082
<rdar://problem/42640580>

Reviewed by Joseph Pecoraro.

UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
TextEditor expects positions returned by the delegate to be relative to
the editor's text content, not the original source code content.

UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype._updateExecutionRangeHighlight):
Convert positions to CodeMirror format here rather than in the delegate
method, which is a layer removed from CodeMirror.

2:21 PM Changeset in webkit [237144] by Chris Dumez

15 edits
3 adds in trunk

Experiment: target=_blank on anchors should imply rel=noopener
https://bugs.webkit.org/show_bug.cgi?id=190481

Reviewed by Alex Christensen.

Source/WebCore:

As an experiment, try and make it so that target=_blank on anchors implies rel=noopener for improved security.
WebContent can then request an opener relationship by using rel=opener instead.

This change was discussed at:

https://github.com/whatwg/html/issues/4078

We want to attempt this change is STP to see if it is Web-compatible. Preliminary testing seems to indicate
that OAuth workflows still work.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::effectiveTarget const):

html/HTMLAnchorElement.h:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setBlankAnchorTargetImpliesNoOpenerEnabled):
(WebCore::RuntimeEnabledFeatures::blankAnchorTargetImpliesNoOpenerEnabled const):

Source/WebKit:

Shared/WebPreferences.yaml:

Tools:

Add API test coverage to make sure we can now swap process when target=_blank
is specified on an anchor but rel=noopener is not.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

LayoutTests:

Update existing tests to reflect behavior change.

TestExpectations:
http/tests/navigation/no-referrer-reset.html:
http/tests/security/resources/referrer-policy-redirect-link.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
http/tests/security/xssAuditor/link-opens-new-window.html:

2:14 PM Changeset in webkit [237143] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: unreadable text when hovering CSS properties while holding Command
https://bugs.webkit.org/show_bug.cgi?id=190548
<rdar://problem/45242098>

Reviewed by Joseph Pecoraro.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.meta-key-pressed .spreadsheet-css-declaration:not(.locked) :matches(.name, .value):not(.editing):hover):
In the light mode the color remained the same.

2:10 PM Changeset in webkit [237142] by aestes@apple.com

10 edits in trunk

[Apple Pay] New shipping methods are ignored when updating after the shippingaddresschange event
https://bugs.webkit.org/show_bug.cgi?id=190560
<rdar://problem/44559075>

Reviewed by Youenn Fablet.

Source/WebCore:

When a PaymentDetailsUpdate with shipping options was specified to updateWith() after the
shippingaddresschange event fires, ApplePayPaymentHandler needs to convert the shipping
options to ShippingMethods and add them to the ShippingContactUpdate so that the Apple Pay
UI renders the new options.

Added test cases to http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https.html.

Modules/applepay/ApplePayShippingMethod.idl:
Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::computeShippingMethods):
(WebCore::ApplePayPaymentHandler::shippingAddressUpdated):

Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
testing/MockPaymentCoordinator.cpp:

(WebCore::convert):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):

testing/MockPaymentCoordinator.h:
testing/MockPaymentCoordinator.idl:

LayoutTests:

http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https-expected.txt:
http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https.html:

1:58 PM Changeset in webkit [237141] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

BytecodeDumper should print all switch labels
https://bugs.webkit.org/show_bug.cgi?id=190596

Reviewed by Saam Barati.

Right now the bytecode dumper only prints the default target not any of the
non-default targets.

bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

1:52 PM Changeset in webkit [237140] by youenn@apple.com

24 edits
7 adds in trunk

RTCPeerConnection.generateCertificate is not a function
https://bugs.webkit.org/show_bug.cgi?id=173541
<rdar://problem/32638029>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCCertificate-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-generateCertificate-expected.txt:
web-platform-tests/webrtc/interfaces.https-expected.txt:
web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/ThirdParty/libwebrtc:

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:

Source/WebCore:

Add support for RTCCertificate generation through libwebrtc certificate generator.
Make generation in the webrtc network thread.
Support is as per spec (ECDSA and RSASSA_PKCS).

Partially covered by WPT tests.

css/StyleBuilder.h: Fixing build.
CMakeLists.txt:
DerivedSources.make:
Modules/webauthn/PublicKeyCredential.cpp: Fixing build.
Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::generateCertificate):

Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::CertificateInformation::RSASSA_PKCS1_v1_5):
(WebCore::PeerConnectionBackend::CertificateInformation::ECDSA_P256):
(WebCore::PeerConnectionBackend::CertificateInformation::CertificateInformation):

Modules/mediastream/RTCCertificate.cpp: Added.

(WebCore::RTCCertificate::create):
(WebCore::RTCCertificate::RTCCertificate):

Modules/mediastream/RTCCertificate.h: Added.

(WebCore::RTCCertificate::expires const):
(WebCore::RTCCertificate::getFingerprints const):

Modules/mediastream/RTCCertificate.idl: Added.
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::certificateTypeFromAlgorithmIdentifier):
(WebCore::RTCPeerConnection::generateCertificate):

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp: Added.

(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::~RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):

Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h: Added.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::certificateGenerator):

platform/mediastream/libwebrtc/LibWebRTCProvider.h:

1:09 PM Changeset in webkit [237139] by Simon Fraser

3 edits in trunk/Source/WebCore

Add compact logging for the paint-order RenderLayer tree
https://bugs.webkit.org/show_bug.cgi?id=190592

Reviewed by Zalan Bujtas.

Add a way to dump the RenderLayer tree in paint order, which will be extended in future
to show more dirty bit state.

rendering/RenderLayer.cpp:

(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputIdent):
(WebCore::outputPaintOrderTreeRecursive):
(WebCore::showPaintOrderTree):

rendering/RenderLayer.h:

12:55 PM Changeset in webkit [237138] by achristensen@apple.com

14 edits in trunk/Source

Remove unused parameters from FrameLoaderClient::createFrame
https://bugs.webkit.org/show_bug.cgi?id=190587

Reviewed by Chris Dumez.

Source/WebCore:

loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::createFrame):

loader/EmptyFrameLoaderClient.h:
loader/FrameLoaderClient.h:
loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createFrame):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createFrame):

Source/WebKitLegacy/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createFrame):

WebCoreSupport/WebFrameLoaderClient.h:

12:53 PM Changeset in webkit [237137] by achristensen@apple.com

3 edits in trunk/Source/WebKitLegacy/mac

Remove unused WebFrame._loadType
https://bugs.webkit.org/show_bug.cgi?id=190583

Reviewed by Chris Dumez.

This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.

WebView/WebFrame.mm:

(toWebFrameLoadType): Deleted.
(-[WebFrame _loadType]): Deleted.

WebView/WebFramePrivate.h:

12:47 PM Changeset in webkit [237136] by sbarati@apple.com

13 edits
1 add in trunk

Emit fjcvtzs on ARM64E on Darwin
https://bugs.webkit.org/show_bug.cgi?id=184023

Reviewed by Yusuke Suzuki and Filip Pizlo.

JSTests:

stress/double-to-int32-NaN.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

ARMv8.3 introduced the fjcvtzs instruction which does double->int32
conversion using the semantics defined by JavaScript:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0801g/hko1477562192868.html
This patch teaches JSC to use that instruction when possible.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::fjcvtzs):
(JSC::ARM64Assembler::fjcvtzsInsn):

assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssemblerARM64::collectCPUFeatures):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::supportsDoubleToInt32ConversionUsingJavaScriptSemantics):
(JSC::MacroAssemblerARM64::convertDoubleToInt32UsingJavaScriptSemantics):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

disassembler/ARM64/A64DOpcode.cpp:
disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcode::appendInstructionName):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::doubleToInt32):

jit/JITRightShiftGenerator.cpp:

(JSC::JITRightShiftGenerator::generateFastPath):

runtime/MathCommon.h:

(JSC::toInt32):

Source/WTF:

wtf/Platform.h:

12:47 PM Changeset in webkit [237135] by Wenson Hsieh

12 edits
2 adds in trunk

[iOS] Can't select text after dismissing the keyboard when changing focus
https://bugs.webkit.org/show_bug.cgi?id=190563
<rdar://problem/44613559>

Reviewed by Tim Horton.

Source/WebKit:

In r230686, we switched from using UIWKSelectionAssistant to UIWKTextInteractionAssistant for handling selection
in non-editable content on iOS; as such, when an editable element loses focus, instead of switching from the
text interaction assistant to the web selection assistant as we've previously done, we now reset our text
interaction assistant by calling -[UIWKTextInteractionAssistant setGestureRecognizers], which removes all of
the current text selection gesture recognizers from WKContentView and regenerates them by building up a tree of
UITextInteractions and adding them to the assistant (see `-[UITextInteractionAssistant
addGestureRecognizersToView:]). In particular, _UITextSelectionForceGesture` is the gesture recognizer used to
trigger text selection when long pressing.

After dismissing the keyboard by tapping the "Done" button, the UITextInteractions and gesture recognizers on
the interaction assistant include:

<UITextInteraction>

…
<UITextIndirectNonEditableInteraction>

<_UIKeyboardBasedNonEditableTextSelectionInteraction>

↳ "_UIKeyboardTextSelectionGestureForcePress" → <_UITextSelectionForceGesture>

However, after the keyboard dismisses due to an editable element losing focus, the UITextInteractions on the
interaction assistant look like this:

<UITextInteraction>

…
<UITextIndirectNonEditableInteraction>

Subsequently, the lack of a _UIKeyboardBasedNonEditableTextSelectionInteraction makes text selection by long
pressing impossible, since the _UITextSelectionForceGesture is never introduced to WKContentView. In UIKit,
UITextIndirectNonEditableInteraction only adds _UIKeyboardBasedNonEditableTextSelectionInteraction as a
child if the text input view — in our case, WKContentView — is missing an input delegate (see -initWithView:).
In the case where the Done button is used to dismiss the keyboard, WKContentView loses first responder, and the
input delegate of WKContentView is cleared out early on, before we call -stopAssistingKeyboard:

-[WKContentView(WKInteraction) setInputDelegate:]
-[UIKeyboardImpl setDelegate:force:]
-[UIPeripheralHost(UIKitInternal) _reloadInputViewsForResponder:]
-[UIResponder _finishResignFirstResponder]
-[UIResponder resignFirstResponder]
-[WKContentView(WKInteraction) resignFirstResponderForWebView]
-[UIKeyboardImpl dismissKeyboard]

However, in the case where the focused element is blurred, we end up clearing out the delegate in
-_stopAssistingNode, *after* we've already called -setGestureRecognizers on the interaction assistant. This
means UIKit will skip adding _UIKeyboardBasedNonEditableTextSelectionInteraction to the text interaction
assistant.

-[WKContentView(WKInteraction) setInputDelegate:]
-[UIKeyboardImpl setDelegate:force:]
-[UIPeripheralHost(UIKitInternal) _reloadInputViewsForResponder:]
-[UIResponder(UIResponderInputViewAdditions) reloadInputViews]
-[WKContentView(WKInteraction) _stopAssistingNode]

To fix this, we simply reset our inputDelegate earlier in _stopAssistingKeyboard instead of waiting until
we reload input views. This ensures that UIKit sets up the text interaction assistant's gestures when changing
focus in the same way as we would when the keyboard is dismissed via -resignFirstResponder (e.g. when pressing
the Done button).

Test: editing/selection/ios/select-text-after-changing-focus.html

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView setUpTextSelectionAssistant]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(-[WKContentView useSelectionAssistantWithGranularity:]): Deleted.

Additionally rename this to -setUpTextSelectionAssistant and remove the selection granularity argument. This was
previously used to switch between web and text interaction assistants.

Tools:

DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isShowingKeyboard const):

Add a new UIScriptController method that returns whether the keyboard is shown. See ui-helper.js for more
details.

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::isShowingKeyboard const):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

Also rename the isShowingKeyboard Objective-C property to the more canonical showingKeyboard, with
isShowingKeyboard as the getter method.

(-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
(-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isShowingKeyboard const):

LayoutTests:

Add a new layout test to check that the user can make a selection by long pressing after the keyboard is
dismissed due to changing the focused element.

editing/selection/ios/select-text-after-changing-focus-expected.txt: Added.
editing/selection/ios/select-text-after-changing-focus.html: Added.
resources/ui-helper.js:

Also tweak the behavior of UIHelper.waitForKeyboardToHide(), so that it resolves immediately if the keyboard
is not shown. This allows us to ensure that tests which use UIHelper.waitForKeyboardToHide() are robust in the
case where they wait for another action to complete (e.g. a simulated tap) prior to registering a keyboard
hiding callback.

(window.UIHelper.waitForKeyboardToHide.return.new.Promise):
(window.UIHelper.waitForKeyboardToHide):

12:40 PM Changeset in webkit [237134] by aestes@apple.com

4 edits
2 adds in trunk

[Apple Pay] Payment authorization results with ApplePayErrors should never be considered final
https://bugs.webkit.org/show_bug.cgi?id=190559
<rdar://problem/37250908>

Reviewed by Anders Carlsson.

Source/WebCore:

When PaymentCoordinator thinks a payment authorization result is final it releases the
active ApplePaySession. The Apple Pay UI is dismissed after a receiving a final result.

However, WebCore::isFinalStateResult had the wrong idea about what was a final state,
in some cases causing PaymentCoordinator to release the active session even when the UI is
still presented. If the user authorizes payment again, the website will not receive another
paymentauthorized event, and the Apple Pay UI will eventually time out waiting for a result.

Specifically, isFinalStateResult thought that:

(1) results with STATUS_SUCCESS were always final, even if they had errors
(2) errors with code "unknown" were final

Both of these assumptions are wrong. PassKit considers any result with errors to be
non-final, even if an error has code "unknown."

Fixed WebCore::isFinalStateResult to agree with what PassKit considers to be final results.

Test: http/tests/ssl/applepay/ApplePaySessionFinalState.https.html

Modules/applepay/ApplePaySessionPaymentRequest.cpp:

(WebCore::isFinalStateResult):

testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::completePaymentSession):

LayoutTests:

http/tests/ssl/applepay/ApplePaySessionFinalState.https-expected.txt: Added.
http/tests/ssl/applepay/ApplePaySessionFinalState.https.html: Added.

12:37 PM Changeset in webkit [237133] by aestes@apple.com

4 edits in trunk/Source/WebCore

[Payment Request] PaymentResponse should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=190558

Reviewed by Alex Christensen.

Make PaymentResponse a ContextDestructionObserver so it has a ScriptExecutionContext to
return for its override of EventTarget::scriptExecutionContext(). Do this instead of
downcasting m_request to an ActiveDOMObject to ask for its context.

Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::accept):

Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::scriptExecutionContext const): Deleted.

Modules/paymentrequest/PaymentResponse.h:

12:34 PM Changeset in webkit [237132] by aestes@apple.com

3 edits in trunk/Source/WebCore

[Payment Request] Use a PendingActivity token rather than calling (un)setPendingActivity
https://bugs.webkit.org/show_bug.cgi?id=190557

Reviewed by Alex Christensen.

PaymentRequest has pending activity whenever there is an active payment handler, since
user-initiated events can occur whenever the payment UI is displayed.

Rather than manually track the pending activity with setPendingActivity() and
unsetPendingActivity(), use a PendingActivity token tied to the lifetime of the active
payment handler. Also, rewrite canSuspendForDocumentSuspension() in terms of
hasPendingActivity().

Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abortWithException):
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const):
(WebCore::PaymentRequest::paymentMethodChanged):
(WebCore::PaymentRequest::completeMerchantValidation):
(WebCore::PaymentRequest::settleDetailsPromise):
(WebCore::PaymentRequest::complete):
(WebCore::PaymentRequest::cancel):

Modules/paymentrequest/PaymentRequest.h:

12:28 PM Changeset in webkit [237131] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit

Web Inspector: RDM: Toolbar hidden in when Inspector is docked to side.
https://bugs.webkit.org/show_bug.cgi?id=190545
rdar://problem/44674500

Patch by Remy Demarest <rdemarest@apple.com> on 2018-10-15
Reviewed by Brian Burg.

When the inspector is placed next to the web view it uses its _topContentInset and _totalHeightOfBanners
to lay out the inspector so it does not underlap the window toolbar, but this technique does not work when
in responsive design mode because of the different attachment view. This patch fixes the issue by using
-[NSWindow contentLayoutRect] to figure out the height of the inspector instead of relying on the content
insets of the web view. This requires observing -contentLayoutRect and ensure we only observe its changes
when the view is actually on the screen.

UIProcess/WebInspectorProxy.h:

Declare helpers to add/remove observer on the attached inspector window.

UIProcess/mac/WKInspectorViewController.h:
UIProcess/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController inspectorWKWebView:willMoveToWindow:]):
(-[WKInspectorViewController inspectorWKWebViewDidMoveToWindow:]):

UIProcess/mac/WKInspectorWKWebView.h:
UIProcess/mac/WKInspectorWKWebView.mm:

(-[WKInspectorWKWebView viewWillMoveToWindow:]):
(-[WKInspectorWKWebView viewDidMoveToWindow]):

UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter observeValueForKeyPath:ofObject:change:context:]): Update inspector layout
whenever the contentLayoutRect changes. Except when live resizing since the attachment view also sends
notifications at the same time.
(-[WKWebInspectorProxyObjCAdapter inspectorViewController:willMoveToWindow:]):
(-[WKWebInspectorProxyObjCAdapter inspectorViewControllerDidMoveToWindow:]):
(WebKit::WebInspectorProxy::attachmentWillMoveFromWindow): Remove the observer only if we set it up before.
(WebKit::WebInspectorProxy::attachmentDidMoveToWindow): Set up the observer and immediately update the frame
of the inspector since it just moved to its final destination.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Adjust the frame of the attached inspector based
on the contentLayoutRect of the window rather than the topContentInset of the web view.

12:14 PM Changeset in webkit [237130] by Ryan Haddad

2 edits in trunk/Tools

Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.

Scripts/run-javascriptcore-tests:

(runJSCStressTests): Remove wsl-tests.yaml.

12:14 PM Changeset in webkit [237129] by sbarati@apple.com

4 edits
1 add in trunk

JSArray::shiftCountWithArrayStorage is wrong when an array has holes
https://bugs.webkit.org/show_bug.cgi?id=190262
<rdar://problem/44986241>

Reviewed by Mark Lam.

JSTests:

stress/array-prototype-concat-of-long-spliced-arrays.js:

(test):

stress/slice-array-storage-with-holes.js: Added.

(main):

Source/JavaScriptCore:

We would take the fast path for shiftCountWithArrayStorage when the array
hasHoles(). However, the code for this was wrong. It'd incorrectly update
ArrayStorage::m_numValuesInVector. Since the hasHoles() for ArrayStorage
path is never taken in JetStream 2, this patch just removes that from
the fast path. Instead, we just fallback to the slow path when hasHoles().
If we find evidence that this matters for real use cases, we can
figure out a way to make the fast path work.

runtime/JSArray.cpp:

(JSC::JSArray::shiftCountWithArrayStorage):

11:44 AM WebKitGTK/2.22.x edited by Michael Catanzaro

(diff)

11:42 AM Changeset in webkit [237128] by commit-queue@webkit.org

27 edits
2 deletes in trunk

Unreviewed, rolling out r237054.
https://bugs.webkit.org/show_bug.cgi?id=190593

"this regressed JetStream 2 by 6% on iOS" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"[JSC] JSC should have "parseFunction" to optimize Function
constructor"
https://bugs.webkit.org/show_bug.cgi?id=190340
https://trac.webkit.org/changeset/237054

10:36 AM Changeset in webkit [237127] by Wenson Hsieh

7 edits
2 adds in trunk

Changing view scale should zoom to initial scale if the page is already at initial scale
https://bugs.webkit.org/show_bug.cgi?id=190570
<rdar://problem/45261877>

Reviewed by Tim Horton.

Source/WebCore:

Add a getter for ViewportConfiguration's layout size scale factor.
See Source/WebKit/ChangeLog for more details.

page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::layoutSizeScaleFactor const):

Source/WebKit:

r237087 added support for changing the view scale on iOS, by making it possible to let the minimum layout size
be a factor of the view size; this allows internal clients to change page zoom levels on iOS. Currently,
changing the page zoom level automatically zooms to the new initial scale only if the user has not manually
scaled the page before, even if the page is already at initial scale (e.g. after the user double taps to zoom on
a small element, and double taps again to zoom back out to initial scale).

This patch makes some minor adjustments to automatically zoom to the new initial scale after changing the view
scale, as long as the page was at initial scale when changing zoom levels.

Test: fast/viewport/ios/initial-scale-after-changing-view-scale.html

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::areEssentiallyEqualAsFloat):

Move this function further up in the file, so that we can use it in setViewportConfigurationViewLayoutSize.

(WebKit::WebPage::setViewportConfigurationViewLayoutSize):

If the page is near initial scale and the zoom level changes, zoom to the new initial scale.

(WebKit::WebPage::viewportConfigurationChanged):

Make this take a new enum argument that determines whether we want to zoom to initial scale as a result of the
viewport configuration change (No by default).

LayoutTests:

fast/viewport/ios/initial-scale-after-changing-view-scale-expected.txt: Added.
fast/viewport/ios/initial-scale-after-changing-view-scale.html: Added.

Add a new layout test to verify that:

Changing view scale before the page scale factor is changed by the user zooms to the new initial scale.
Changing view scale after the user changes the page scale to something different than initial scale does not

cause the page to zoom to the new initial scale.

Changing view scale after the user changes the page scale factor back to initial scale causes the page to

zoom to the new initial scale.

resources/basic-gestures.js:

Make a small tweak in doubleTapToZoomAtPoint to ensure that both single taps as well as zooming are complete
before invoking UIScriptController completion.

(return.new.Promise):

10:33 AM Changeset in webkit [237126] by cturner@igalia.com

3 edits in trunk/Source/WebCore

Fix build error with !LOG_DISABLED in Release mode
https://bugs.webkit.org/show_bug.cgi?id=190465

Reviewed by Michael Catanzaro.

No tests due to no new functionality.

workers/service/ServiceWorkerRegistrationKey.cpp:
workers/service/ServiceWorkerRegistrationKey.h:

10:27 AM Changeset in webkit [237125] by Nikita Vasilyev

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: style editor warnings should not look like errors
https://bugs.webkit.org/show_bug.cgi?id=190569
<rdar://problem/45261689>

Reviewed by Matt Baker.

Make warnings in the style editor look the same as warnings in the content views.
Unify warning and error background color variables.

UserInterface/Views/LogContentView.css:

(@media (prefers-dark-interface)):
(.console-error-level):
(.console-warning-level):

UserInterface/Views/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .warning):
(.source-code.text-editor > .CodeMirror .error):
(.source-code.text-editor > .CodeMirror .issue-widget.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error):
(@media (prefers-dark-interface)):
(.source-code.text-editor > .CodeMirror .issue-widget):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property.has-warning):
(.spreadsheet-style-declaration-editor .property.has-warning .warning):
(@media (prefers-dark-interface)):
(.spreadsheet-style-declaration-editor :matches(.name, .value).editing):

UserInterface/Views/Variables.css:

(:root):
(@media (prefers-dark-interface)):

10:25 AM Changeset in webkit [237124] by Simon Fraser

5 edits in trunk/Source/WebCore

LayerListMutationDetector should take a reference
https://bugs.webkit.org/show_bug.cgi?id=190586

Reviewed by Zalan Bujtas.

Change LayerListMutationDetector to take a RenderLayer&.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayer.h:

(WebCore::LayerListMutationDetector::LayerListMutationDetector):
(WebCore::LayerListMutationDetector::~LayerListMutationDetector):

rendering/RenderLayerBacking.cpp:

(WebCore::traverseVisibleNonCompositedDescendantLayers):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

10:25 AM Changeset in webkit [237123] by Simon Fraser

3 edits in trunk/Source/WebCore

Share some code to dirty z-order and normal flow lists when child layers are added or removed
https://bugs.webkit.org/show_bug.cgi?id=190585

Reviewed by Zalan Bujtas.

Factor code which dirties the normal flow list and child stacking context z-order lists
when a layer is added or removed.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::dirtyPaintOrderListsOnChildChange):

rendering/RenderLayer.h:

10:25 AM Changeset in webkit [237122] by Simon Fraser

3 edits in trunk/Source/WebCore

Make a helper function to check for reflection layers
https://bugs.webkit.org/show_bug.cgi?id=190584

Reviewed by Zalan Bujtas.

Add RenderLayer::isReflectionLayer() which returns true if the passed layer
is the layer of this layer's reflection. It's used in z-order list building.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayer.h:

10:25 AM Changeset in webkit [237121] by Simon Fraser

4 edits in trunk/Source/WebCore

RenderLayer::addChild() and removeChild() should take references
https://bugs.webkit.org/show_bug.cgi?id=190582

Reviewed by Zalan Bujtas.

Pass the layer to be added or removed as a reference; it's never null.

rendering/RenderElement.cpp:

(WebCore::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::insertOnlyThisLayer):
(WebCore::RenderLayer::removeOnlyThisLayer):

rendering/RenderLayer.h:

9:59 AM Changeset in webkit [237120] by Chris Dumez

2 edits in trunk/Source/WebKitLegacy/win

Unreviewed Windows build fix after r237112.

Plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):
(WebCore::PluginView::load):

9:50 AM Changeset in webkit [237119] by yoshiaki.jitsukawa@sony.com

3 edits
4 adds in trunk

[Cairo] Incorrect rendering for 135-deg skews
https://bugs.webkit.org/show_bug.cgi?id=190513

Source/WebCore:

Compensation value to zero the the translation components
of the transformation matrix is incorrect if the matrix
has a shear factor.

Reviewed by Žan Doberšek.

Tests: fast/transforms/skew-x-135deg-with-gradient.html

fast/transforms/skew-y-135deg-with-gradient.html

platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::drawPatternToCairoContext):

LayoutTests:

Reviewed by Žan Doberšek.

fast/transforms/skew-x-135deg-with-gradient-expected.html: Added.
fast/transforms/skew-x-135deg-with-gradient.html: Added.
fast/transforms/skew-y-135deg-with-gradient-expected.html: Added.
fast/transforms/skew-y-135deg-with-gradient.html: Added.

9:33 AM Changeset in webkit [237118] by chris.reid@sony.com

10 edits
2 adds
1 delete in trunk

[Curl][WinCairo] Add Public Suffix support to WinCairo
https://bugs.webkit.org/show_bug.cgi?id=183060

Reviewed by Alex Christensen.

Source/cmake/FindLibPSL.cmake: Added.
Source/cmake/OptionsWin.cmake:
Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Add Public Suffix support to WinCairo using LibPSL.
LibPSL has been added to WinCairoRequirements in v2018.10.09.

platform/Curl.cmake:
platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::searchCookies): Search for cookies using the topPrivatelyControlledDomain
(WebCore::CookieJarDB::setCookie): Prevent cookies from being added under TLDs

platform/network/curl/PublicSuffixCurl.cpp: Added.

(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomainInternal):
(WebCore::topPrivatelyControlledDomain):

Tools:

Share mac's PublicSuffix tests with all ports.

TestWebKitAPI/PlatformWin.cmake:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.

9:12 AM Changeset in webkit [237117] by Simon Fraser

3 edits in trunk/Source/WebCore

RenderLayer tree-related cleanup
https://bugs.webkit.org/show_bug.cgi?id=190572

Reviewed by Zalan Bujtas.

Move code around so that functions related to parent/child and z-order tree structure
are near the top of RenderLayer.cpp, since this is one of the primary functions of layers.

Attempts to use inheritance or composition to separate out tree structure resulted in
unwieldy code and/or performance regressions.

The only behavior change is to store a bit for m_isStackingContext so that we don't have
to consult the old style to know if it changed.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::insertOnlyThisLayer):
(WebCore::RenderLayer::removeOnlyThisLayer):
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::shouldBeStackingContext const):
(WebCore::RenderLayer::setIsNormalFlowOnly):
(WebCore::RenderLayer::setIsStackingContext):
(WebCore::RenderLayer::setParent):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyStackingContextZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):
(WebCore::RenderLayer::updateLayerListsIfNeeded):
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::willBeDestroyed):
(WebCore::RenderLayer::isDescendantOf const):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::compareZIndex): Deleted.

rendering/RenderLayer.h:

9:02 AM Changeset in webkit [237116] by Antti Koivisto

6 edits in trunk/Source/WebCore

[PSON] Prewarm system fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=190517

Reviewed by Ryosuke Niwa.

This seems to be ~2% progression in PSON PLT4 with large (40ms+) improvements on some pages
after process swaps.

page/PrewarmInformation.h:

(WebCore::PrewarmInformation::encode const):
(WebCore::PrewarmInformation::decode):

page/ProcessWarming.cpp:

(WebCore::ProcessWarming::collectPrewarmInformation):
(WebCore::ProcessWarming::prewarmWithInformation):

platform/graphics/FontCache.cpp:

(WebCore::FontCache::collectPrewarmInformation const):
(WebCore::FontCache::prewarm):

platform/graphics/FontCache.h:

(WebCore::FontCache::PrewarmInformation::isolatedCopy const):
(WebCore::FontCache::PrewarmInformation::encode const):
(WebCore::FontCache::PrewarmInformation::decode):

Make font cache prewarm information a struct with encode/decode support and move it into FontCache scope.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::collectionForFamily):
(WebCore::FontCache::systemFallbackForCharacters):

Collect the names of fonts that end up needing character specific system fallbacks.

(WebCore::FontCache::collectPrewarmInformation const):

Include them into prewarm information.

(WebCore::FontCache::prewarm):

Invoking CTFontCreateForCharactersWithLanguage for the correct named font seems sufficient to fully
prewarm it for fallbacks (independent of size, locale or other characteristics).
Any future calls to systemFallbackForCharacters are fast.

8:54 AM Changeset in webkit [237115] by mmaxfield@apple.com

1 edit
1 delete in trunk/Tools

[WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
https://bugs.webkit.org/show_bug.cgi?id=190555

Unreviewed.

Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source

WebGPUShadingLanguageRI/AddressSpace.js: Removed.
WebGPUShadingLanguageRI/All.js: Removed.
WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
WebGPUShadingLanguageRI/ArrayType.js: Removed.
WebGPUShadingLanguageRI/Assignment.js: Removed.
WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
WebGPUShadingLanguageRI/Block.js: Removed.
WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
WebGPUShadingLanguageRI/Break.js: Removed.
WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
WebGPUShadingLanguageRI/CallExpression.js: Removed.
WebGPUShadingLanguageRI/CallFunction.js: Removed.
WebGPUShadingLanguageRI/Casts.js: Removed.
WebGPUShadingLanguageRI/Check.js: Removed.
WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
WebGPUShadingLanguageRI/CheckLoops.js: Removed.
WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
WebGPUShadingLanguageRI/CheckReturns.js: Removed.
WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
WebGPUShadingLanguageRI/Checker.js: Removed.
WebGPUShadingLanguageRI/CloneProgram.js: Removed.
WebGPUShadingLanguageRI/CommaExpression.js: Removed.
WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
WebGPUShadingLanguageRI/Continue.js: Removed.
WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
WebGPUShadingLanguageRI/DotExpression.js: Removed.
WebGPUShadingLanguageRI/EArrayRef.js: Removed.
WebGPUShadingLanguageRI/EBuffer.js: Removed.
WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
WebGPUShadingLanguageRI/EPtr.js: Removed.
WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
WebGPUShadingLanguageRI/EnumMember.js: Removed.
WebGPUShadingLanguageRI/EnumType.js: Removed.
WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
WebGPUShadingLanguageRI/Evaluator.js: Removed.
WebGPUShadingLanguageRI/Expression.js: Removed.
WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
WebGPUShadingLanguageRI/Field.js: Removed.
WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
WebGPUShadingLanguageRI/ForLoop.js: Removed.
WebGPUShadingLanguageRI/Func.js: Removed.
WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
WebGPUShadingLanguageRI/FuncDef.js: Removed.
WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
WebGPUShadingLanguageRI/FuncParameter.js: Removed.
WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
WebGPUShadingLanguageRI/IfStatement.js: Removed.
WebGPUShadingLanguageRI/IndexExpression.js: Removed.
WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
WebGPUShadingLanguageRI/Inline.js: Removed.
WebGPUShadingLanguageRI/Inliner.js: Removed.
WebGPUShadingLanguageRI/IntLiteral.js: Removed.
WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
WebGPUShadingLanguageRI/Intrinsics.js: Removed.
WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
WebGPUShadingLanguageRI/Lexer.js: Removed.
WebGPUShadingLanguageRI/LexerToken.js: Removed.
WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
WebGPUShadingLanguageRI/LogicalNot.js: Removed.
WebGPUShadingLanguageRI/LoopChecker.js: Removed.
WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
WebGPUShadingLanguageRI/MatrixType.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
WebGPUShadingLanguageRI/NameContext.js: Removed.
WebGPUShadingLanguageRI/NameFinder.js: Removed.
WebGPUShadingLanguageRI/NameResolver.js: Removed.
WebGPUShadingLanguageRI/NativeFunc.js: Removed.
WebGPUShadingLanguageRI/NativeType.js: Removed.
WebGPUShadingLanguageRI/Node.js: Removed.
WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
WebGPUShadingLanguageRI/NullLiteral.js: Removed.
WebGPUShadingLanguageRI/NullType.js: Removed.
WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
WebGPUShadingLanguageRI/OriginKind.js: Removed.
WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
WebGPUShadingLanguageRI/Parse.js: Removed.
WebGPUShadingLanguageRI/Prepare.js: Removed.
WebGPUShadingLanguageRI/Program.js: Removed.
WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
WebGPUShadingLanguageRI/PtrType.js: Removed.
WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
WebGPUShadingLanguageRI/ReferenceType.js: Removed.
WebGPUShadingLanguageRI/ResolveNames.js: Removed.
WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
WebGPUShadingLanguageRI/Return.js: Removed.
WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
WebGPUShadingLanguageRI/ReturnException.js: Removed.
WebGPUShadingLanguageRI/Rewriter.js: Removed.
WebGPUShadingLanguageRI/SPIR-V.js: Removed.
WebGPUShadingLanguageRI/SPIRV.html: Removed.
WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
WebGPUShadingLanguageRI/Sampler.js: Removed.
WebGPUShadingLanguageRI/Semantic.js: Removed.
WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
WebGPUShadingLanguageRI/StatementCloner.js: Removed.
WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
WebGPUShadingLanguageRI/StructType.js: Removed.
WebGPUShadingLanguageRI/SwitchCase.js: Removed.
WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
WebGPUShadingLanguageRI/Test.html: Removed.
WebGPUShadingLanguageRI/Test.js: Removed.
WebGPUShadingLanguageRI/Texture.js: Removed.
WebGPUShadingLanguageRI/TextureOperations.js: Removed.
WebGPUShadingLanguageRI/TrapStatement.js: Removed.
WebGPUShadingLanguageRI/Type.js: Removed.
WebGPUShadingLanguageRI/TypeDef.js: Removed.
WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
WebGPUShadingLanguageRI/TypeRef.js: Removed.
WebGPUShadingLanguageRI/TypedValue.js: Removed.
WebGPUShadingLanguageRI/UintLiteral.js: Removed.
WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
WebGPUShadingLanguageRI/UnificationContext.js: Removed.
WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
WebGPUShadingLanguageRI/Value.js: Removed.
WebGPUShadingLanguageRI/VariableDecl.js: Removed.
WebGPUShadingLanguageRI/VariableRef.js: Removed.
WebGPUShadingLanguageRI/VectorType.js: Removed.
WebGPUShadingLanguageRI/VisitingSet.js: Removed.
WebGPUShadingLanguageRI/Visitor.js: Removed.
WebGPUShadingLanguageRI/WLexicalError.js: Removed.
WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
WebGPUShadingLanguageRI/WTrapError.js: Removed.
WebGPUShadingLanguageRI/WTypeError.js: Removed.
WebGPUShadingLanguageRI/WhileLoop.js: Removed.
WebGPUShadingLanguageRI/WrapChecker.js: Removed.
WebGPUShadingLanguageRI/index.html: Removed.
WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.

8:51 AM Changeset in webkit [237114] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r237084): JavaScriptCore fails to build on Linux
<https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10949>

llint/LLIntSettingsExtractor.cpp: Attempt to fix build by

including <stdio.h>.

8:42 AM Changeset in webkit [237113] by Philippe Normand

2 edits in trunk/Tools

[GTK] Disable MSE build support on Debian and Ubuntu LTS bots
https://bugs.webkit.org/show_bug.cgi?id=190581

Reviewed by Michael Catanzaro.

These bots don't use JHBuild and their host GStreamer version is
too old for the GStreamer MSE backend. Version 1.14 is needed at least.

BuildSlaveSupport/build.webkit.org-config/config.json:

8:34 AM Changeset in webkit [237112] by Chris Dumez

20 edits
14 adds in trunk

Restrict browsing context lookup by name to frames that are related to one another
https://bugs.webkit.org/show_bug.cgi?id=190475

Reviewed by Alex Christensen.

Source/WebCore:

Update our frame lookup by name logic to take in the active / requesting frame and
only a return a frame that is related to it. By related to it, I mean:

Ancestor <-> Descendant relationship
Opener <-> Openee relationship

Being able to look up unrelated frames makes process swapping difficult so we need
to be stricter.

This change is being discussed at:

https://github.com/whatwg/html/issues/313

Tests: http/tests/dom/new-window-can-target-opener.html

http/tests/dom/noopener-window-cannot-target-opener.html
http/tests/dom/noopener-window-not-targetable.html
http/tests/dom/noopener-window-not-targetable2.html
http/tests/dom/noreferrer-window-not-targetable.html
http/tests/dom/opened-window-not-targetable-after-disowning-opener.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

page/FrameTree.cpp:

(WebCore::isFrameFamiliarWith):
(WebCore::FrameTree::find const):

page/FrameTree.h:
rendering/HitTestResult.cpp:

(WebCore::HitTestResult::targetFrame const):

Source/WebKit:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest):

Source/WebKitLegacy/mac:

WebView/WebFrame.mm:

(-[WebFrame findFrameNamed:]):

LayoutTests:

http/tests/dom/new-window-can-target-opener-expected.txt: Added.
http/tests/dom/new-window-can-target-opener.html: Added.
http/tests/dom/noopener-window-cannot-target-opener-expected.txt: Added.
http/tests/dom/noopener-window-cannot-target-opener.html: Added.
http/tests/dom/noopener-window-not-targetable-expected.txt: Added.
http/tests/dom/noopener-window-not-targetable.html: Added.
http/tests/dom/noopener-window-not-targetable2-expected.txt: Added.
http/tests/dom/noopener-window-not-targetable2.html: Added.
http/tests/dom/noreferrer-window-not-targetable-expected.txt: Added.
http/tests/dom/noreferrer-window-not-targetable.html: Added.
http/tests/dom/opened-window-not-targetable-after-disowning-opener-expected.txt: Added.
http/tests/dom/opened-window-not-targetable-after-disowning-opener.html: Added.
http/tests/dom/resources/new-window-can-target-opener-win.html: Added.
http/tests/dom/resources/noopener-window-cannot-target-opener-win.html: Added.

Add layout test coverage.

fast/dom/Window/a-rel-noopener-expected.txt:
fast/dom/Window/area-rel-noopener-expected.txt:
fast/dom/Window/resources/rel-noopener.js:
http/tests/navigation/no-referrer-target-blank-expected.txt:
http/tests/navigation/resources/no-referrer-helper.php:
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt:
platform/wk2/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt:

Update / rebaseline existing tests to reflect behavior change.

8:29 AM Changeset in webkit [237111] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix assertion after r237102
https://bugs.webkit.org/show_bug.cgi?id=190459

WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
Shipping Safari still uses shouldGoToBackForwardListItem, so only assert on
newer platforms like we do in WKPageSetPageLoaderClient.

8:23 AM Changeset in webkit [237110] by achristensen@apple.com

68 edits in trunk/Source

Shrink more enum classes
https://bugs.webkit.org/show_bug.cgi?id=190540

Reviewed by Chris Dumez.

Source/JavaScriptCore:

runtime/ConsoleTypes.h:

Source/WebCore:

Modules/notifications/NotificationDirection.h:
dom/Document.h:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/HistoryController.h:
loader/ShouldSkipSafeBrowsingCheck.h:
loader/ShouldTreatAsContinuingLoad.h:
page/AutoplayEvent.h:
page/ChromeClient.h:
page/DiagnosticLoggingClient.h:
page/Page.h:
platform/CookiesStrategy.h:
platform/audio/AudioSession.h:
platform/network/NetworkStorageSession.h:
platform/network/StoredCredentialsPolicy.h:
workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerRegistrationData.h:
workers/service/ServiceWorkerRegistrationOptions.h:
workers/service/ServiceWorkerTypes.h:
workers/service/ServiceWorkerUpdateViaCache.h:
workers/service/server/SWServer.h:
workers/service/server/SWServerRegistration.h:

Source/WebKit:

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
Shared/Authentication/AuthenticationChallengeDisposition.h:
Shared/Authentication/AuthenticationManager.h:
Shared/Authentication/AuthenticationManager.messages.in:
Shared/DragControllerAction.h:
Shared/LayerTreeContext.h:
Shared/UndoOrRedo.h:
UIProcess/Authentication/AuthenticationDecisionListener.h:
UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/Notifications/WebNotification.h:
UIProcess/Notifications/WebNotificationManagerProxy.h:
UIProcess/PageClient.h:
UIProcess/UserContent/WebUserContentControllerProxy.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/forms/WKAirPlayRoutePicker.h:
WebProcess/Automation/WebAutomationSessionProxy.messages.in:
WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
WebProcess/Storage/WebSWClientConnection.messages.in:
WebProcess/UserContent/InjectUserScriptImmediately.h:
WebProcess/UserContent/WebUserContentController.h:
WebProcess/UserContent/WebUserContentController.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

8:10 AM Changeset in webkit [237109] by Michael Catanzaro

2 edits
6 adds in trunk

Add new files missing from previous commit.

Source/cmake/FindLibseccomp.cmake: Added.

8:07 AM Changeset in webkit [237108] by yusukesuzuki@slowstart.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Disable DOMJIT on 32bit architecture
https://bugs.webkit.org/show_bug.cgi?id=190387

Reviewed by Mark Lam.

We disable DOMJIT on 32bit architecture due to exhaustion of registers.

runtime/Options.h:

8:02 AM Changeset in webkit [237107] by Michael Catanzaro

24 edits in trunk

[GTK][WPE] Implement subprocess sandboxing
https://bugs.webkit.org/show_bug.cgi?id=188568

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-15
Reviewed by Michael Catanzaro.

Add ENABLE_BUBBLEWRAP_SANDBOX option for sandboxing.

Source/cmake/FindLibseccomp.cmake: Added.
Source/cmake/OptionsGTK.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Link against libseccomp.

PlatformGTK.cmake:

Source/WebKit:

This implements sandboxing of WebKitWebProcesses.

The sandbox is opt-in at runtime as it is a behavior change.
See webkit_web_context_set_sandbox_enabled() and the
WEBKIT_FORCE_SANDBOX env var for developers.

This is Linux specific using Namespaces, Seccomp, and a DBus proxy service.
This introduces three new dependencies:

bwrap executable
libseccomp library
xdg-dbus-proxy executable

The use of xdg-dbus-proxy will ideally be replaced once upstream DBus
gains the same filtering abilities which is a work in progress.

Currently the sandbox is not completed and there are a few large holes:

Pulseaudio: The Pipewire project will solve this.
DRI device access: No immediate solutions planned.
Webcam device access: Pipewire will also solve this.
Webprocess network access: Will require GStreamer changes.
DConf access: Custom proxy planned.
X11 access: Wayland solves this.

That is not an exhaustive list but are the noteworthy ones. Filesystem access
is still an evolving list as problems are found as is specific DBus name access.

PlatformGTK.cmake:
PlatformWPE.cmake:
SourcesGTK.txt:
SourcesWPE.txt:
UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_sandbox_enabled):
(webkit_web_context_get_sandbox_enabled):

UIProcess/API/gtk/WebKitWebContext.h:
UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
UIProcess/API/wpe/WebKitWebContext.h:
UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::getLaunchOptions):

UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::platformGetLaunchOptions):

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Added.

(WebKit::memfd_create):
(WebKit::argsToFd):
(WebKit::XDGDBusProxyLauncher::setAddress):
(WebKit::XDGDBusProxyLauncher::isRunning const):
(WebKit::XDGDBusProxyLauncher::path const):
(WebKit::XDGDBusProxyLauncher::proxyPath const):
(WebKit::XDGDBusProxyLauncher::setPermissions):
(WebKit::XDGDBusProxyLauncher::launch):
(WebKit::XDGDBusProxyLauncher::childSetupFunc):
(WebKit::XDGDBusProxyLauncher::makeProxyPath):
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath):
(WebKit::bindIfExists):
(WebKit::bindDBusSession):
(WebKit::bindX11):
(WebKit::bindDconf):
(WebKit::bindWayland):
(WebKit::bindPulse):
(WebKit::bindFonts):
(WebKit::bindGtkData):
(WebKit::bindA11y):
(WebKit::bindPathVar):
(WebKit::bindGStreamerData):
(WebKit::bindOpenGL):
(WebKit::bindV4l):
(WebKit::bindSymlinksRealPath):
(WebKit::setupSeccomp):
(WebKit::bubblewrapSpawn):

UIProcess/Launcher/glib/BubblewrapLauncher.h: Added.
UIProcess/Launcher/glib/FlatpakLauncher.cpp: Added.

(WebKit::flatpakSpawn):

UIProcess/Launcher/glib/FlatpakLauncher.h: Added.
UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::isInsideFlatpak):
(WebKit::ProcessLauncher::launchProcess):

UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getLaunchOptions):

UIProcess/Plugins/PluginProcessProxy.h:
UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes):

UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

UIProcess/WebProcessProxy.h:
UIProcess/glib/WebProcessProxyGLib.cpp: Added.

(WebKit::WebProcessProxy::platformGetLaunchOptions):

7:56 AM Changeset in webkit [237106] by commit-queue@webkit.org

14 edits
3 copies
2 adds in trunk

Implement error handler of MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=190438

Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-10-15
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-record/MediaRecorder-error-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-error.html: Added.

Source/WebCore:

Test: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-error.html

Implement error event handler (onerror) for MediaRecorder and basic architecture of start() function.

CMakeLists.txt:
DerivedSources.make:
Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::stop):
(WebCore::MediaRecorder::start):
(WebCore::MediaRecorder::setNewRecordingState):
(WebCore::MediaRecorder::scheduleDeferredTask):
(WebCore::MediaRecorder::didAddOrRemoveTrack):

Modules/mediarecorder/MediaRecorder.h:
Modules/mediarecorder/MediaRecorder.idl:
Modules/mediarecorder/MediaRecorderErrorEvent.cpp: Added.

(WebCore::MediaRecorderErrorEvent::create):
(WebCore::MediaRecorderErrorEvent::MediaRecorderErrorEvent):
(WebCore::MediaRecorderErrorEvent::eventInterface const):

Modules/mediarecorder/MediaRecorderErrorEvent.h: Added.
Modules/mediarecorder/MediaRecorderErrorEvent.idl: Added.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventNames.in:
dom/EventTargetFactory.in:

LayoutTests:

Since dataavailable event has not been implemented, skip three MediaRecorder-related tests now.
We will need to reenable those tests once implementing the dataavailable event for MediaRecorder.

TestExpectations:

7:54 AM Changeset in webkit [237105] by Chris Dumez

28 edits
5 adds in trunk

Window's properties such as 'location' should not become null when it loses its browsing context
https://bugs.webkit.org/show_bug.cgi?id=190539

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT test whose output has changed.

web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:

Source/WebCore:

Window's properties such as 'location' should not become null when it loses its browsing context.
This Webkit behavior is not standard and does not match other browsers so this patch makes it so
that those properties persist.

Tests: http/tests/dom/cross-origin-detached-window-properties.html

http/tests/dom/same-origin-detached-window-properties.html

bindings/js/JSDOMBindingSecurity.cpp:

(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow):

bindings/js/JSDOMBindingSecurity.h:
bindings/js/JSDOMWindowProperties.cpp:

(WebCore::jsDOMWindowPropertiesGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindowProperties::getOwnPropertySlot):

bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::putCommon):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::deletePropertyByIndex):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocation::getPrototype):
(WebCore::JSLocation::toStringName):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateOperationBodyDefinition):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectExcitingAttrGetter):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunctionBody):

crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::SubtleCrypto):

crypto/SubtleCrypto.h:

(WebCore::SubtleCrypto::create):

dom/Document.cpp:

(WebCore::Document::~Document):

page/Crypto.cpp:

(WebCore::Crypto::Crypto):

page/Crypto.h:

(WebCore::Crypto::create):

page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console const):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance const):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::visualViewport):
(WebCore::DOMWindow::styleMedia):

page/DOMWindow.h:
page/DOMWindow.idl:
workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::crypto):

LayoutTests:

http/tests/dom/cross-origin-detached-window-properties-expected.txt: Added.
http/tests/dom/cross-origin-detached-window-properties.html: Added.
http/tests/dom/resources/post-message-to-parent-when-loaded.html: Added.
http/tests/dom/same-origin-detached-window-properties-expected.txt: Added.
http/tests/dom/same-origin-detached-window-properties.html: Added.

Add layout test coverage.

fast/frames/detached-frame-property-expected.txt:
fast/frames/detached-frame-property.html:
http/tests/security/named-window-property-from-same-origin-inactive-document-expected.txt:
http/tests/security/named-window-property-from-same-origin-inactive-document.html:
http/tests/security/xss-DENIED-named-window-property-from-cross-origin-inactive-document-expected.txt:
http/tests/security/xss-DENIED-named-window-property-from-cross-origin-inactive-document.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:

Update existing layout tests to reflect behavior change.

7:31 AM Changeset in webkit [237104] by achristensen@apple.com

5 edits in trunk/Source/WebKit

Add a temporarily off by default preference for doing safe browsing checks
https://bugs.webkit.org/show_bug.cgi?id=190522

Reviewed by Chris Dumez.

Safe browsing development has taken longer than anticipated.
To prevent the unused possible contacting the safe browsing provider for no benefit, make this off by default for now.
I'll make it on by default when it's actually used.

Shared/WebPreferences.yaml:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setSafeBrowsingEnabled:]):
(-[WKPreferences _safeBrowsingEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

7:30 AM Changeset in webkit [237103] by achristensen@apple.com

31 edits in trunk/Source

Include EnumTraits.h less
https://bugs.webkit.org/show_bug.cgi?id=190535

Reviewed by Chris Dumez.

Source/JavaScriptCore:

runtime/ConsoleTypes.h:

Source/WebCore:

Modules/applepay/ApplePaySessionPaymentRequest.h:
Modules/applepay/PaymentAuthorizationStatus.h:
Modules/applicationmanifest/ApplicationManifest.h:
Modules/fetch/FetchHeaders.h:
Modules/webauthn/AuthenticatorTransport.h:
Modules/webauthn/PublicKeyCredentialType.h:
loader/ShouldSkipSafeBrowsingCheck.h:
loader/ShouldTreatAsContinuingLoad.h:
platform/Cookie.h:
platform/audio/AudioSession.h:
platform/mediastream/CaptureDevice.h:
platform/mediastream/MediaStreamRequest.h:
platform/mediastream/RealtimeMediaSourceSettings.h:
platform/mediastream/libwebrtc/LibWebRTCProvider.h:
platform/network/NetworkLoadInformation.h:
workers/service/ServiceWorkerClientType.h:
workers/service/ServiceWorkerTypes.h:
workers/service/ServiceWorkerUpdateViaCache.h:

Source/WebKit:

NetworkProcess/NetworkSessionCreationParameters.h:
Shared/Authentication/AuthenticationChallengeDisposition.h:
Shared/CoordinateSystem.h:
Shared/LayerTreeContext.h:
Shared/UndoOrRedo.h:
Shared/WebsiteAutoplayPolicy.h:
Shared/WebsitePopUpPolicy.h:
UIProcess/API/APIWebsitePolicies.h:
WebProcess/UserContent/InjectUserScriptImmediately.h:

7:29 AM Changeset in webkit [237102] by achristensen@apple.com

27 edits in trunk/Source

Remove InjectedBundle processing of back/forward lists
https://bugs.webkit.org/show_bug.cgi?id=190459

Reviewed by Chris Dumez.

Source/WebCore:

The uses of these functions are dead code I removed in rdar://problem/45180545
Removing these functions is a step towards fixing the PSON history bugs.

loader/EmptyFrameLoaderClient.h:
loader/FrameLoaderClient.h:
loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem):

Source/WebKit:

Shared/API/c/WKDeprecated.h:
UIProcess/API/APINavigationClient.h:

(API::NavigationClient::willGoToBackForwardListItem):

UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::willGoToBackForwardListItem):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willGoToBackForwardListItem):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::shouldGoToBackForwardListItem): Deleted.

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemCopyOriginalURL):
(WKBundleBackForwardListItemCopyTitle):
(WKBundleBackForwardListItemIsTargetItem):
(WKBundleBackForwardListItemIsInPageCache):
(WKBundleBackForwardListItemHasCachedPageExpired):

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h:
WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem): Deleted.

WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem const):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::shouldGoToHistoryItem const):

Source/WebKitLegacy/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldGoToHistoryItem const):

WebCoreSupport/WebFrameLoaderClient.h:

7:28 AM Changeset in webkit [237101] by achristensen@apple.com

6 edits in trunk/Source/WebKit

WebPageProxy should always have a HistoryClient
https://bugs.webkit.org/show_bug.cgi?id=190450

Reviewed by Chris Dumez.

This will make it so we don't forget to null check it.
No change in behavior because the default HistoryClient does nothing.

UIProcess/API/APIHistoryClient.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::createHistoryClient):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setHistoryClient):
(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::didUpdateHistoryTitle):

UIProcess/WebPageProxy.h:

7:27 AM Changeset in webkit [237100] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Use std::optional<size_t> for a WebBackForwardList's current index
https://bugs.webkit.org/show_bug.cgi?id=190448

Reviewed by Chris Dumez.

Also remove m_capacity, which was immutable.

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::~WebBackForwardList):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem const):
(WebKit::WebBackForwardList::backItem const):
(WebKit::WebBackForwardList::forwardItem const):
(WebKit::WebBackForwardList::itemAtIndex const):
(WebKit::WebBackForwardList::backListCount const):
(WebKit::WebBackForwardList::forwardListCount const):
(WebKit::WebBackForwardList::backListAsAPIArrayWithLimit const):
(WebKit::WebBackForwardList::forwardListAsAPIArrayWithLimit const):
(WebKit::WebBackForwardList::removeAllItems):
(WebKit::WebBackForwardList::clear):
(WebKit::WebBackForwardList::backForwardListState const):
(WebKit::WebBackForwardList::restoreFromState):
(WebKit::WebBackForwardList::loggingString):

UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::currentIndex const): Deleted.

7:24 AM Changeset in webkit [237099] by achristensen@apple.com

325 edits in trunk

Use pragma once in WTF
https://bugs.webkit.org/show_bug.cgi?id=190527

Reviewed by Chris Dumez.

Source/WTF:

We also need to consistently include wtf headers from within wtf so we can build wtf without
symbol redefinition errors from including the copy in Source and the copy in the build directory.

wtf/ASCIICType.h:
wtf/Assertions.cpp:
wtf/Assertions.h:
wtf/Atomics.h:
wtf/AutomaticThread.cpp:
wtf/AutomaticThread.h:
wtf/BackwardsGraph.h:
wtf/Bag.h:
wtf/BagToHashMap.h:
wtf/BitVector.cpp:
wtf/BitVector.h:
wtf/Bitmap.h:
wtf/BloomFilter.h:
wtf/Box.h:
wtf/BubbleSort.h:
wtf/BumpPointerAllocator.h:
wtf/ByteOrder.h:
wtf/CPUTime.cpp:
wtf/CallbackAggregator.h:
wtf/CheckedArithmetic.h:
wtf/CheckedBoolean.h:
wtf/ClockType.cpp:
wtf/ClockType.h:
wtf/CommaPrinter.h:
wtf/CompilationThread.cpp:
wtf/CompilationThread.h:
wtf/Compiler.h:
wtf/ConcurrentPtrHashSet.cpp:
wtf/ConcurrentVector.h:
wtf/Condition.h:
wtf/CountingLock.cpp:
wtf/CrossThreadTaskHandler.cpp:
wtf/CryptographicUtilities.cpp:
wtf/CryptographicUtilities.h:
wtf/CryptographicallyRandomNumber.cpp:
wtf/CryptographicallyRandomNumber.h:
wtf/CurrentTime.cpp:
wtf/DataLog.cpp:
wtf/DataLog.h:
wtf/DateMath.cpp:
wtf/DateMath.h:
wtf/DecimalNumber.cpp:
wtf/DecimalNumber.h:
wtf/Deque.h:
wtf/DisallowCType.h:
wtf/Dominators.h:
wtf/DoublyLinkedList.h:
wtf/FastBitVector.cpp:
wtf/FastMalloc.cpp:
wtf/FastMalloc.h:
wtf/FeatureDefines.h:
wtf/FilePrintStream.cpp:
wtf/FilePrintStream.h:
wtf/FlipBytes.h:
wtf/FunctionDispatcher.cpp:
wtf/FunctionDispatcher.h:
wtf/GetPtr.h:
wtf/Gigacage.cpp:
wtf/GlobalVersion.cpp:
wtf/GraphNodeWorklist.h:
wtf/GregorianDateTime.cpp:
wtf/GregorianDateTime.h:
wtf/HashFunctions.h:
wtf/HashMap.h:
wtf/HashMethod.h:
wtf/HashSet.h:
wtf/HashTable.cpp:
wtf/HashTraits.h:
wtf/Indenter.h:
wtf/IndexSparseSet.h:
wtf/InlineASM.h:
wtf/Insertion.h:
wtf/IteratorAdaptors.h:
wtf/IteratorRange.h:
wtf/JSONValues.cpp:
wtf/JSValueMalloc.cpp:
wtf/LEBDecoder.h:
wtf/Language.cpp:
wtf/ListDump.h:
wtf/Lock.cpp:
wtf/Lock.h:
wtf/LockAlgorithm.h:
wtf/LockedPrintStream.cpp:
wtf/Locker.h:
wtf/MD5.cpp:
wtf/MD5.h:
wtf/MainThread.cpp:
wtf/MainThread.h:
wtf/MallocPtr.h:
wtf/MathExtras.h:
wtf/MediaTime.cpp:
wtf/MediaTime.h:
wtf/MemoryPressureHandler.cpp:
wtf/MessageQueue.h:
wtf/MetaAllocator.cpp:
wtf/MetaAllocator.h:
wtf/MetaAllocatorHandle.h:
wtf/MonotonicTime.cpp:
wtf/MonotonicTime.h:
wtf/NakedPtr.h:
wtf/NoLock.h:
wtf/NoTailCalls.h:
wtf/Noncopyable.h:
wtf/NumberOfCores.cpp:
wtf/NumberOfCores.h:
wtf/OSAllocator.h:
wtf/OSAllocatorPosix.cpp:
wtf/OSRandomSource.cpp:
wtf/OSRandomSource.h:
wtf/ObjcRuntimeExtras.h:
wtf/OrderMaker.h:
wtf/PackedIntVector.h:
wtf/PageAllocation.h:
wtf/PageBlock.cpp:
wtf/PageBlock.h:
wtf/PageReservation.h:
wtf/ParallelHelperPool.cpp:
wtf/ParallelHelperPool.h:
wtf/ParallelJobs.h:
wtf/ParallelJobsLibdispatch.h:
wtf/ParallelVectorIterator.h:
wtf/ParkingLot.cpp:
wtf/ParkingLot.h:
wtf/Platform.h:
wtf/PointerComparison.h:
wtf/Poisoned.cpp:
wtf/PrintStream.cpp:
wtf/PrintStream.h:
wtf/ProcessID.h:
wtf/ProcessPrivilege.cpp:
wtf/RAMSize.cpp:
wtf/RAMSize.h:
wtf/RandomDevice.cpp:
wtf/RandomNumber.cpp:
wtf/RandomNumber.h:
wtf/RandomNumberSeed.h:
wtf/RangeSet.h:
wtf/RawPointer.h:
wtf/ReadWriteLock.cpp:
wtf/RedBlackTree.h:
wtf/Ref.h:
wtf/RefCountedArray.h:
wtf/RefCountedLeakCounter.cpp:
wtf/RefCountedLeakCounter.h:
wtf/RefCounter.h:
wtf/RefPtr.h:
wtf/RetainPtr.h:
wtf/RunLoop.cpp:
wtf/RunLoop.h:
wtf/RunLoopTimer.h:
wtf/RunLoopTimerCF.cpp:
wtf/SHA1.cpp:
wtf/SHA1.h:
wtf/SaturatedArithmetic.h:

(saturatedSubtraction):

wtf/SchedulePair.h:
wtf/SchedulePairCF.cpp:
wtf/SchedulePairMac.mm:
wtf/ScopedLambda.h:
wtf/Seconds.cpp:
wtf/Seconds.h:
wtf/SegmentedVector.h:
wtf/SentinelLinkedList.h:
wtf/SharedTask.h:
wtf/SimpleStats.h:
wtf/SingleRootGraph.h:
wtf/SinglyLinkedList.h:
wtf/SixCharacterHash.cpp:
wtf/SixCharacterHash.h:
wtf/SmallPtrSet.h:
wtf/Spectrum.h:
wtf/StackBounds.cpp:
wtf/StackBounds.h:
wtf/StackStats.cpp:
wtf/StackStats.h:
wtf/StackTrace.cpp:
wtf/StdLibExtras.h:
wtf/StreamBuffer.h:
wtf/StringHashDumpContext.h:
wtf/StringPrintStream.cpp:
wtf/StringPrintStream.h:
wtf/ThreadGroup.cpp:
wtf/ThreadMessage.cpp:
wtf/ThreadSpecific.h:
wtf/Threading.cpp:
wtf/Threading.h:
wtf/ThreadingPrimitives.h:
wtf/ThreadingPthreads.cpp:
wtf/TimeWithDynamicClockType.cpp:
wtf/TimeWithDynamicClockType.h:
wtf/TimingScope.cpp:
wtf/TinyLRUCache.h:
wtf/TinyPtrSet.h:
wtf/TriState.h:
wtf/TypeCasts.h:
wtf/UUID.cpp:
wtf/UnionFind.h:
wtf/VMTags.h:
wtf/ValueCheck.h:
wtf/Vector.h:
wtf/VectorTraits.h:
wtf/WallTime.cpp:
wtf/WallTime.h:
wtf/WeakPtr.h:
wtf/WeakRandom.h:
wtf/WordLock.cpp:
wtf/WordLock.h:
wtf/WorkQueue.cpp:
wtf/WorkQueue.h:
wtf/WorkerPool.cpp:
wtf/cf/LanguageCF.cpp:
wtf/cf/RunLoopCF.cpp:
wtf/cocoa/Entitlements.mm:
wtf/cocoa/MachSendRight.cpp:
wtf/cocoa/MainThreadCocoa.mm:
wtf/cocoa/MemoryFootprintCocoa.cpp:
wtf/cocoa/WorkQueueCocoa.cpp:
wtf/dtoa.cpp:
wtf/dtoa.h:
wtf/ios/WebCoreThread.cpp:
wtf/ios/WebCoreThread.h:
wtf/mac/AppKitCompatibilityDeclarations.h:
wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
wtf/mbmalloc.cpp:
wtf/persistence/PersistentCoders.cpp:
wtf/persistence/PersistentDecoder.cpp:
wtf/persistence/PersistentEncoder.cpp:
wtf/spi/cf/CFBundleSPI.h:
wtf/spi/darwin/CommonCryptoSPI.h:
wtf/text/ASCIIFastPath.h:
wtf/text/ASCIILiteral.cpp:
wtf/text/AtomicString.cpp:
wtf/text/AtomicString.h:
wtf/text/AtomicStringHash.h:
wtf/text/AtomicStringImpl.cpp:
wtf/text/AtomicStringImpl.h:
wtf/text/AtomicStringTable.cpp:
wtf/text/AtomicStringTable.h:
wtf/text/Base64.cpp:
wtf/text/CString.cpp:
wtf/text/CString.h:
wtf/text/ConversionMode.h:
wtf/text/ExternalStringImpl.cpp:
wtf/text/IntegerToStringConversion.h:
wtf/text/LChar.h:
wtf/text/LineEnding.cpp:
wtf/text/StringBuffer.h:
wtf/text/StringBuilder.cpp:
wtf/text/StringBuilder.h:
wtf/text/StringBuilderJSON.cpp:
wtf/text/StringCommon.h:
wtf/text/StringConcatenate.h:
wtf/text/StringHash.h:
wtf/text/StringImpl.cpp:
wtf/text/StringImpl.h:
wtf/text/StringOperators.h:
wtf/text/StringView.cpp:
wtf/text/StringView.h:
wtf/text/SymbolImpl.cpp:
wtf/text/SymbolRegistry.cpp:
wtf/text/SymbolRegistry.h:
wtf/text/TextBreakIterator.cpp:
wtf/text/TextBreakIterator.h:
wtf/text/TextBreakIteratorInternalICU.h:
wtf/text/TextPosition.h:
wtf/text/TextStream.cpp:
wtf/text/UniquedStringImpl.h:
wtf/text/WTFString.cpp:
wtf/text/WTFString.h:
wtf/text/cocoa/StringCocoa.mm:
wtf/text/cocoa/StringViewCocoa.mm:
wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp:
wtf/text/icu/UTextProvider.cpp:
wtf/text/icu/UTextProvider.h:
wtf/text/icu/UTextProviderLatin1.cpp:
wtf/text/icu/UTextProviderLatin1.h:
wtf/text/icu/UTextProviderUTF16.cpp:
wtf/text/icu/UTextProviderUTF16.h:
wtf/threads/BinarySemaphore.cpp:
wtf/threads/BinarySemaphore.h:
wtf/threads/Signals.cpp:
wtf/unicode/CharacterNames.h:
wtf/unicode/Collator.h:
wtf/unicode/CollatorDefault.cpp:
wtf/unicode/UTF8.cpp:
wtf/unicode/UTF8.h:

Tools:

Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.

DumpRenderTree/TestRunner.cpp:

(TestRunner::queueLoadHTMLString):
(TestRunner::queueLoadAlternateHTMLString):
(TestRunner::queueBackNavigation):
(TestRunner::queueForwardNavigation):
(TestRunner::queueLoadingScript):
(TestRunner::queueNonLoadingScript):
(TestRunner::queueReload):

DumpRenderTree/WorkQueue.cpp:

(WorkQueue::singleton): Deleted.
(WorkQueue::WorkQueue): Deleted.
(WorkQueue::queue): Deleted.
(WorkQueue::dequeue): Deleted.
(WorkQueue::count): Deleted.
(WorkQueue::clear): Deleted.
(WorkQueue::processWork): Deleted.

DumpRenderTree/WorkQueue.h:

(WorkQueue::setFrozen): Deleted.

DumpRenderTree/WorkQueueItem.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(runTest):

DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate processWork:]):
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):

DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::notifyDone):
(TestRunner::forceImmediateCompletion):
(TestRunner::queueLoad):

DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::processWork):
(FrameLoadDelegate::locationChangeDone):

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::notifyDone):
(TestRunner::forceImmediateCompletion):
(TestRunner::queueLoad):

7:01 AM Changeset in webkit [237098] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Gardening: Build fix after r237084.
https://bugs.webkit.org/show_bug.cgi?id=189708

Unreviewd.

llint/LLIntOffsetsExtractor.cpp:

6:51 AM Changeset in webkit [237097] by yusukesuzuki@slowstart.org

18 edits in trunk

[JSC] Remove Option::useAsyncIterator
https://bugs.webkit.org/show_bug.cgi?id=190567

Reviewed by Saam Barati.

Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Async iterator is enabled by default at 2017-08-09. It is already shipped in several releases,
and we can think that it is already mature. Let's drop the option Option::useAsyncIterator.

Configurations/FeatureDefines.xcconfig:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewFunction):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseAsyncFunctionExpression):

runtime/Options.h:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

6:49 AM Changeset in webkit [237096] by yusukesuzuki@slowstart.org

4 edits in trunk/Source/JavaScriptCore

[JSC] Remove Options::useObjectRestSpread
https://bugs.webkit.org/show_bug.cgi?id=190568

Reviewed by Saam Barati.

Options::useObjectRestSpread is enabled by default at 2017-06-27. It is already shipped in several releases,
and we can think that it is mature. Let's drop Options::useObjectRestSpread() flag.

parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseProperty):

parser/Parser.h:
runtime/Options.h:

6:48 AM Changeset in webkit [237095] by yusukesuzuki@slowstart.org

3 edits
1 add in trunk

[JSC] JSON.stringify can accept call-with-no-arguments
https://bugs.webkit.org/show_bug.cgi?id=190343

Reviewed by Mark Lam.

JSTests:

stress/json-stringify-no-arguments.js: Added.

(shouldBe):

Source/JavaScriptCore:

JSON.stringify can accept JSON.stringify() call (call-with-no-arguments) according to the spec[1].
Instead of throwing an error, we should take the first argument as undefined if it is not given.

[1]: https://tc39.github.io/ecma262/#sec-json.stringify

runtime/JSONObject.cpp:

(JSC::JSONProtoFuncStringify):

5:27 AM Changeset in webkit [237094] by Claudio Saavedra

3 edits in trunk/LayoutTests

[GStreamer] MediaStream test failing since r236877

Unreviewed gardening

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

4:53 AM Changeset in webkit [237093] by Claudio Saavedra

2 edits in trunk/Tools

[WPE] Silence a unused-parameter warning

Unreviewed.

MiniBrowser/wpe/main.cpp:

(decidePermissionRequest):

4:44 AM Changeset in webkit [237092] by Philippe Normand

3 edits in trunk/Source/WebCore

[GStreamer] Fix EME build for GStreamer 1.14.x
https://bugs.webkit.org/show_bug.cgi?id=190471

Reviewed by Xabier Rodriguez-Calvar.

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptTransformCaps): The
GST_PROTECTION_UNSPECIFIED_SYSTEM_ID #define won't be shipped
until the GStreamer 1.16.0 release, so its use needs to be wrapped
between a version check.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered): Ditto.

Oct 14, 2018:

11:30 PM Last2YearsOfPlatformNetworkCurl edited by Fujii Hironori: (diff)

Oct 12, 2018:

5:29 PM October 2018 Meeting edited by Jon Davis

Added IntersectionObserver Notes (diff)

5:29 PM IntersectionObserverNotes created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

5:17 PM October 2018 Meeting edited by Jon Davis

Added Redesigned Form Controls and Dark Mode CSS notes (diff)

5:17 PM RedesignedFormControlsAndDarkModeCSS created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

5:09 PM October 2018 Meeting edited by Jon Davis

Added Fixing WebKit Development Annoyances notes (diff)

5:08 PM FixingWebKitDevelopmentAnnoyances created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:54 PM Changeset in webkit [237091] by Devin Rousso

1 edit
2 adds in trunk/Websites/webkit.org

Add a demo for WebInspector scanvas debugging.

demos/canvas-debugging/index.html: Added.

4:52 PM Changeset in webkit [237090] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: previews aren't removed when the parent view is hidden
https://bugs.webkit.org/show_bug.cgi?id=190525

Reviewed by Matt Baker.

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.attached):

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.get canvases):
(WI.CanvasManager.prototype.get shaderPrograms):
Drive-by: simplify these getters.

4:48 PM October 2018 Meeting edited by Jon Davis

(diff)

4:46 PM October 2018 Meeting edited by Jon Davis

Added Last 2 Years of Platform/Network/cURL notes (diff)

4:44 PM Last2YearsOfPlatformNetworkCurl created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:42 PM October 2018 Meeting edited by Jon Davis

(diff)

4:39 PM WPTandWebKitTests edited by Jon Davis

(diff)

4:31 PM October 2018 Meeting edited by Jon Davis

Added WPT and WebKit Tests (diff)

4:30 PM WPTandWebKitTests created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:27 PM Changeset in webkit [237089] by guijemont@igalia.com

2 edits in trunk/Tools

[Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
https://bugs.webkit.org/show_bug.cgi?id=190537

Reviewed by Alexey Proskuryakov.

In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
needs to be split before adding it to the command since it is treated
as a list of args.

Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_javascriptcore_tests_command):

4:17 PM October 2018 Meeting edited by Jon Davis

Added EWS Updates notes (diff)

4:16 PM Changeset in webkit [237088] by Tadeu Zagallo

2 edits in trunk/Source/JavaScriptCore

Gardening: Build fix after r237084.
https://bugs.webkit.org/show_bug.cgi?id=189708

Unreviewd.

JavaScriptCore.xcodeproj/project.pbxproj:

4:16 PM EWSUpdates2018 created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:14 PM October 2018 Meeting edited by Jon Davis

Added notes for WebKitGTK+ and WPE WebKit in Five Minutes (diff)

4:14 PM WebKitGTKAndWPEWebKitInFiveMinutes created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:13 PM Changeset in webkit [237087] by Wenson Hsieh

27 edits
5 adds in trunk

[iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
https://bugs.webkit.org/show_bug.cgi?id=190504
<rdar://problem/45117760>

Reviewed by Tim Horton.

Source/WebCore:

Add support in ViewportConfiguration for applying a layout size scale factor to the viewport. See below for
more details.

Tests: fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html

fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setViewLayoutSize):

The viewport's layout size may now be changed alongside the layout size scale factor. If either of these two
variables change, we recompute our minimum layout size and viewport configuration parameters.

(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints const):
(WebCore::ViewportConfiguration::nativeWebpageParameters):
(WebCore::ViewportConfiguration::testingParameters):
(WebCore::ViewportConfiguration::updateConfiguration):

Multiply the minimum scale, initial scale, and maximum scale by the layout size scale factor. This allows us to
keep the document well-proportioned within the viewport, while still laying out at a different layout size.

(WebCore::ViewportConfiguration::updateMinimumLayoutSize):

Compute the minimum layout size by scaling the default layout size derived from our view's size.

(WebCore::ViewportConfiguration::layoutWidth const):
(WebCore::ViewportConfiguration::layoutHeight const):

page/ViewportConfiguration.h:

Maintain the original initial scale, unaffected by the layout size scale factor. This is used when computing
layout width and height to prevent scaling by the layout size scale factor twice when computing layout sizes.

(WebCore::ViewportConfiguration::description const):

Include the layout size scale factor in ViewportConfiguration's description string.

(WebCore::ViewportConfiguration::Parameters::operator== const):
(WebCore::operator<<):

Source/WebKit:

Add support for _setViewScale: and _viewScale on iOS. While similar in concept to macOS, changing this property
on iOS uses viewport configurations to change the minimum layout size of the document and apply view scaling.
Setting the view scale on iOS to a value s multiplies the minimium layout size by a factor 1 / s, but also
multiplies the initial, minimum and maximum scales by a factor of s. The net effect of applying this scale
causes the page to lay out at a larger width and shrink (or a smaller width and expand) to fit the viewport.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

Send viewportConfigurationLayoutSizeScaleFactor alongside viewportConfigurationViewLayoutSize.

(-[WKWebView _dispatchSetViewLayoutSize:]):
(-[WKWebView _viewScale]):
(-[WKWebView _setViewScale:]):

Provide a different implementation of _setViewScale: on iOS, by scaling the effective minimum layout size.
(See above for more detail).

UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add missing API availability annotations for the _viewScale property.

UIProcess/API/mac/WKView.mm:

(-[WKView _setViewScale:]):

UIProcess/Cocoa/WebViewImpl.mm:

Both -[WKView _setViewScale:] and -[WKWebView _setViewScale:] throw Objective C exceptions upon receiving a bad
argument (e.g. scale <= 0). However, logic for throwing this exception is specific to iOS in WKWebView, and
handled in WebViewImpl on macOS. To make this less confusing, move the exception throwing code out of
!PLATFORM(MAC) in WKWebView, and move the path for raising this exception in WKView on macOS from WebViewImpl to
WKView.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::layoutSizeScaleFactor const):

Tie the notion of "view scale" on iOS to layoutSizeScaleFactor. As its name suggests, this is a scale factor
by which we transform the layout size.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setViewportConfigurationViewLayoutSize):

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Plumb the layout size scale factor over to the web process, along with the layout size.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setViewportConfigurationViewLayoutSize):

Tools:

Teach UIScriptController to set WKWebView's view scale via a new setViewScale method, supported in WebKit2 on
macOS and iOS.

DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::setViewScale):

DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::setViewScale):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setViewScale):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/UIScriptControllerCocoa.mm: Added.

Add a new file for UIScriptController methods on Cocoa platforms.

(WTR::UIScriptController::setViewScale):

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

Ensure that _viewScale is reset to 1 after running a layout test.

LayoutTests:

Add two new layout tests on iOS that change WKWebView's view scale, and measure the resulting window sizes and
lengths of viewport units.

fast/viewport/ios/constant-width-viewport-after-changing-view-scale-expected.txt: Added.
fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html: Added.

Add a test page with a viewport meta tag that has a constant width and an explicit initial scale of 0.5.

fast/viewport/ios/device-width-viewport-after-changing-view-scale-expected.txt: Added.
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html: Added.

Add a test page with a viewport meta tag at device-width, with initial scale 1.

resources/ui-helper.js:

(window.UIHelper.setViewScale):

Add a convenience function that wraps a UI script invocation of setViewScale in a promise.

(window.UIHelper):

4:13 PM October 2018 Meeting edited by Jon Davis

Added Igalia Contributions to WebKit (diff)

4:12 PM IgaliaContributionsToWebKit created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

4:10 PM Changeset in webkit [237086] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Perf dashboard: add a test for aggregating subtests without a matching metric in /api/report
https://bugs.webkit.org/show_bug.cgi?id=190544

Rubber-stamped by Keith Miller and unofficially reviewed by Dewei Zhu.

Added tests for reporting results to /api/report where a test with aggregated metrics has a subtest
without a matching metric type. The aggregation should simply skip such a subtest instead of returning
an error or aggregating with a mismatching metric type.

server-tests/api-report-tests.js:

(.makeReport): Extracted out of a test case.

4:05 PM October 2018 Meeting edited by Jon Davis

Added JavaScript RegExp Processing and JavaScriptCore Goals (diff)

4:03 PM JSCRegExpProcessingAndJSCGoals created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

3:59 PM Changeset in webkit [237085] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark
https://bugs.webkit.org/show_bug.cgi?id=190510

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-12
Reviewed by Devin Rousso.

UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers.showing-find-banner .search-highlight):
Use adaptive text-color.

3:54 PM October 2018 Meeting edited by Jon Davis

Added Web Inspector notes (diff)

3:52 PM WebInspectorNotes2018 created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

3:50 PM October 2018 Meeting edited by Jon Davis

Added WebDriver Notes (diff)

3:47 PM WebDriverNotes2018 created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

3:39 PM Changeset in webkit [237084] by Tadeu Zagallo

7 edits
2 adds in trunk/Source/JavaScriptCore

Separate configuration extraction from offset extraction
https://bugs.webkit.org/show_bug.cgi?id=189708

Reviewed by Keith Miller.

Instead of generating a file with all offsets for every combination of
configurations, we first generate a file with only the configuration
indices and pass that to the offset extractor. The offset extractor then
only generates the offsets for valid configurations

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy):

llint/LLIntSettingsExtractor.cpp: Added.

(main):

offlineasm/generate_offset_extractor.rb:
offlineasm/generate_settings_extractor.rb: Added.
offlineasm/offsets.rb:
offlineasm/settings.rb:

3:38 PM October 2018 Meeting edited by Jon Davis

Added WebKit Accessibility Performance notes (diff)

3:37 PM WebKitAccessibilityPerformance created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

3:28 PM October 2018 Meeting edited by Jon Davis

Added Investigating Leaks and Bloat (diff)

3:28 PM InvestigatingLeaksAndBloat created by Jon Davis

Notes from 2018 WebKit Contributors Meeting

3:24 PM October 2018 Meeting edited by Jon Davis

Added WebKit Feature Focus 2018-2019 Notes (diff)

3:23 PM WebKitFeatureFocus2018-2019 created by Jon Davis

Notes from the 2018 WebKit Contributors Meeting

3:16 PM October 2018 Meeting edited by timothy@hatcher.name

(diff)

3:06 PM Changeset in webkit [237083] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=190536

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.

3:06 PM Changeset in webkit [237082] by youenn@apple.com

5 edits in trunk/Source/WebCore

Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
https://bugs.webkit.org/show_bug.cgi?id=190533

Reviewed by Chris Dumez.

Clean-up work.
No change of behavior.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::setExistingReceiverSourceTrack):

platform/mediastream/RealtimeIncomingAudioSource.h:

(isType):

platform/mediastream/RealtimeIncomingVideoSource.h:

(isType):

platform/mediastream/RealtimeMediaSource.h:

2:43 PM Changeset in webkit [237081] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

WebAVSampleBufferErrorListener's parent should be a WeakPtr.
https://bugs.webkit.org/show_bug.cgi?id=190524
<rdar://problem/44359307>

Reviewed by Eric Carlson.

Once WebAVSampleBufferErrorListener's parent is a WeakPtr, we no longer need to pass
protectedSelf into the callOnMainThread lambdas; we can pass in the parent itself.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener initWithParent:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):

2:42 PM Changeset in webkit [237080] by Ryan Haddad

15 edits in trunk/Source

Unreviewed, rolling out r237063.

Caused layout test fast/dom/Window/window-postmessage-clone-
deep-array.html to fail on macOS and iOS Debug bots.

Reverted changeset:

"[JSC] Remove gcc warnings on mips and armv7"
https://bugs.webkit.org/show_bug.cgi?id=188598
https://trac.webkit.org/changeset/237063

2:32 PM Changeset in webkit [237079] by youenn@apple.com

1 edit in trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt

Unreviewed.
Speculative build fix for GTK/WPE after r237075.

2:30 PM Changeset in webkit [237078] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: wrong color used for "goto arrow" for selected DOM breakpoint tree element
https://bugs.webkit.org/show_bug.cgi?id=190180
<rdar://problem/44927654>

Reviewed by Matt Baker.

UserInterface/Views/Main.css:

(@media (prefers-dark-interface)):
(:focus .selected .go-to-arrow):

2:29 PM Changeset in webkit [237077] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Address the review comment which was meant to be addressed in r237025.

editing/MarkupAccumulator.cpp:

(WebCore::elementCannotHaveEndTag):

2:04 PM Changeset in webkit [237076] by Ryan Haddad

1 edit
1 delete in trunk/Source/ThirdParty/libwebrtc

Unreviewed build fix, remove executable file imported with r237075.

Source/webrtc/data/voice_engine/stereo_rtp_files/rtpplay.exe: Removed.

1:53 PM October 2018 Meeting edited by Jon Davis

Moved "How Text Works" into main schedule (diff)

1:45 PM Changeset in webkit [237075] by youenn@apple.com

1279 edits
64 copies
164 moves
313 adds
92 deletes in trunk/Source

Refresh libwebrtc up to 343f4144be
https://bugs.webkit.org/show_bug.cgi?id=190361

Reviewed by Chris Dumez.

This refresh should not change behavior but will allow us to implement better
mdns candidate support and simulcast activation surfacing through addTransceiver.
Covered by existing tests.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnection::CreateAnswer):
testing/MockLibWebRTCPeerConnection.h: (WebCore::MockRtpSender::GetParameters): Deleted. (WebCore::MockRtpSender::SetParameters): Deleted. (WebCore::MockRtpSender::GetDtmfSender const): Deleted.

ThirdParty/libwebrtc

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:
Configurations/libwebrtc.xcconfig:
Source/webrtc: Resynced.
WebKit/0001-Updating-webrtc.patch: Removed.
libwebrtc.xcodeproj/project.pbxproj:

1:20 PM Changeset in webkit [237074] by achristensen@apple.com

23 edits in trunk/Source

Allow encoding of small enum classes
https://bugs.webkit.org/show_bug.cgi?id=190531

Reviewed by Tim Horton.

Source/WebCore:

Modules/webauthn/PublicKeyCredentialCreationOptions.h:
dom/Document.h:
editing/FontAttributeChanges.h:
history/CachedFrame.h:
loader/FrameLoaderTypes.h:
platform/CookiesStrategy.h:
platform/PasteboardItemInfo.h:
platform/ReferrerPolicy.h:

Source/WebKit:

NetworkProcess/NetworkLoadClient.h:
Scripts/webkit/messages.py:
Scripts/webkit/parser.py:

(parse_parameters_string):

UIProcess/API/APINavigation.h:
UIProcess/WebFramePolicyListenerProxy.h:
UIProcess/WebNavigationState.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(-[WebFramePolicyListener dealloc]):

Source/WTF:

wtf/Forward.h:

12:58 PM October 2018 Meeting edited by Jon Davis

Added IntersectionObserver talk (diff)

12:51 PM October 2018 Meeting edited by Jon Davis

(diff)

12:47 PM October 2018 Meeting edited by Michael Catanzaro

(diff)

12:43 PM October 2018 Meeting edited by Jon Davis

Changed order of Igalia and Web Inspector talks (diff)

12:20 PM Changeset in webkit [237073] by commit-queue@webkit.org

15 edits in trunk/Source

Solve the confusion around blankURL() and isBlankURL() in URL
https://bugs.webkit.org/show_bug.cgi?id=158988

Patch by Rob Buis <rbuis@igalia.com> on 2018-10-12
Reviewed by Alex Christensen.

Source/WebCore:

The name isBlankURL is not accurate as the function tests the
protocol, not the full URL. Choose protocolIsAbout to align with
exisiting protocolIsData, protocolIsBlob etc.

No tests as no change in functionality.

WebCore.order:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadApplicationManifest):
(WebCore::DocumentLoader::startIconLoading):

loader/NavigationAction.cpp:

(WebCore::shouldTreatAsSameOriginNavigation):

loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

page/PageSerializer.cpp:

(WebCore::PageSerializer::SerializerMarkupAccumulator::appendCustomAttributes):
(WebCore::PageSerializer::serializeFrame):

page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFrame const):
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForObjectSource const):

platform/URL.cpp:

(WebCore::URL::protocolIsAbout const):
(WebCore::URL::isBlankURL const): Deleted.

platform/URL.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::loadFull):

Source/WebKit:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal):

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setLastSeen):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom):

11:03 AM Changeset in webkit [237072] by realdawei@apple.com

2 edits in trunk/LayoutTests

[Mojave Wk2] Layout Test http/tests/cache/disk-cache/disk-cache-validation-attachment.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190323

Unreviewed, mark test as Flaky.

Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-12

platform/mac-wk2/TestExpectations:

10:57 AM Changeset in webkit [237071] by youenn@apple.com

5 edits in trunk/Source/WebKit

Cache API tests are flaky due to file writing failing from time to time
https://bugs.webkit.org/show_bug.cgi?id=190321

Reviewed by Chris Dumez.

Make NetworkCache::Storage::store callback return an error in case of writing failure.
Use this to surface this error at Cache API level.

Minor clean-up to make Storage::clear take a completion handler.

Make also sure to create the folder before writing the file in CacheStorageEngine.
As can be seen from some logging, it does happen that writing the 'origin' file sometimes fail with Posix error 9,
which might mean the folder is not present.

Changes are covered by current tests, flaky tests like http/wpt/cache-storage/cache-put-keys.https.any.worker.html
will show a "failed writing data to the file system" error message.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::writeFile):

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::storeOrigin):
(WebKit::CacheStorage::Caches::writeCachesToDisk):
(WebKit::CacheStorage::Caches::writeRecord):

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::Storage::finishWriteOperation):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::clear):

NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::store):

10:14 AM Changeset in webkit [237070] by youenn@apple.com

2 edits in trunk/Source/WebCore

DOMCache should dereference itself as soon as stopped
https://bugs.webkit.org/show_bug.cgi?id=190441

Reviewed by Chris Dumez.

Dereference the DOMCache as soon as its context is stopped instead of waiting for garbage collection.
This allows freeing resources sooner in the network process.
No observable change of behavior since the DOMCache becomes no-op when its context is stopped.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::~DOMCache):
(WebCore::DOMCache::stop):

9:57 AM Changeset in webkit [237069] by ap@apple.com

2 edits in trunk/Source/WTF

Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY)
https://bugs.webkit.org/show_bug.cgi?id=190477

Reviewed by Tim Horton.

Currently, PLATFORM(IOS) and OS(IOS) are true when building for any
TARGET_OS_IPHONE target, which is quite confusing. Add a better named alternative,
as a first step towards mass replacing PLATFORM(IOS). Can't so it all at once
because of dependencies in other source repositories.

wtf/Platform.h: Changed to the new name in this file though. Kept a few

instances that actually target iOS only, having a version check.

9:24 AM October 2018 Meeting edited by mmaxfield@apple.com

(diff)

9:07 AM Changeset in webkit [237068] by pvollan@apple.com

2 edits in trunk/LayoutTests

Layout Test editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190520

Unreviewed test gardening.

platform/win/TestExpectations:

8:28 AM Changeset in webkit [237067] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

CRASH in WebCore::MediaPlayerPrivateAVFoundation::setPreload
https://bugs.webkit.org/show_bug.cgi?id=190485
<rdar://problem/34613350>

Reviewed by Eric Carlson.

Crash analytics show that a pure-virtual function is called by MediaPlayerPrivateAVFoundation::setPreload(), and
the likely cause of that pure-virtual function call is that the MediaPlayerPrivateAVFoundation object itself has
been destroyed, likely as a side effect of calling MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL().
The usual suspect for this kind of crash is due to calling into JS (e.g., from a callback passed up to
HTMLMediaElement). Code inspection hasn't yielded any good hints about why this might be occurring, so we will
add a ScriptDisallowedScope assertion inside HTMLMediaElement::prepareToPlay(), to generate a good crashlog
showing exactly what callback is resulting in a JS call. But just in case the deallocation is not due to JS,
also add an explicit strong-ref inside MediaPlayer::prepareToPlay.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareToPlay):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::prepareToPlay):

8:28 AM Changeset in webkit [237066] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Null-dereference in SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged
https://bugs.webkit.org/show_bug.cgi?id=190490
<rdar://problem/42213807>

Reviewed by Eric Carlson.

Crash analytics show a null dereference occurring, likely because m_mediaSource is null.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

6:19 AM October 2018 Meeting edited by dbates@webkit.org

Cannot attend the meeting. (diff)

Oct 11, 2018:

11:33 PM Changeset in webkit [237065] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r236956. Use array_get to avoid warnings.

public/include/report-processor.php:

11:13 PM Changeset in webkit [237064] by jonlee@apple.com

2 edits in trunk/Websites/browserbench.org

Update default hyperlink for MotionMark to MotionMark 1.1
https://bugs.webkit.org/show_bug.cgi?id=190491

Reviewed by Ryosuke Niwa.

index.html:

7:51 PM Changeset in webkit [237063] by guijemont@igalia.com

15 edits in trunk/Source

[JSC] Remove gcc warnings on mips and armv7
https://bugs.webkit.org/show_bug.cgi?id=188598

Reviewed by Mark Lam.

Source/bmalloc:

Add bitwise_cast (from WTF) and use it instead of reinterpret_cast in
a couple places where reinterpret_cast triggers a warning about
alignment even though we know that alignment is correct.

bmalloc/Algorithm.h:

(bmalloc::bitwise_cast): Copied from WTF/wtf/StdLibextras.h

bmalloc/IsoDirectoryPageInlines.h:

(bmalloc::IsoDirectoryPage<Config>::pageFor):

bmalloc/IsoPageInlines.h:

(bmalloc::IsoPage<Config>::startAllocating):

Source/JavaScriptCore:

Fix many gcc/clang warnings that are false positives, mostly alignment
issues.

assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printMemory):
Use bitwise_cast instead of reinterpret_cast.

assembler/testmasm.cpp:

(JSC::floatOperands):
marked as potentially unused as it is not used on all platforms.
(JSC::testProbeModifiesStackValues):
modifiedFlags is not used on mips, so don't declare it.

bytecode/CodeBlock.h:

Make ScriptExecutable::prepareForExecution() return an
std::optional<Exception*> instead of a JSObject*.

interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
Update calling code for the prototype change of
ScriptExecutable::prepareForExecution().

jit/JITOperations.cpp: Same as for Interpreter.cpp.
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall): Same as for Interpreter.cpp.

runtime/JSBigInt.cpp:

(JSC::JSBigInt::dataStorage):
Use bitwise_cast instead of reinterpret_cast.

runtime/ScriptExecutable.cpp:
runtime/ScriptExecutable.h:

Make ScriptExecutable::prepareForExecution() return an
std::optional<Exception*> instead of a JSObject*.

tools/JSDollarVM.cpp:

(JSC::codeBlockFromArg): Use bitwise_cast instead of reinterpret_cast.

7:45 PM Changeset in webkit [237062] by don.olmstead@sony.com

2 edits in trunk/Source/WebCore

Add Houdini specs to features.json
https://bugs.webkit.org/show_bug.cgi?id=190494
<rdar://problem/45211879>

Unreviewed fix.

Specifications should not reference other specifications. Also
move Worklet into the specifications section.

features.json:

7:30 PM Changeset in webkit [237061] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: detail view reverts to "Response" when new requests are added
https://bugs.webkit.org/show_bug.cgi?id=190443

Reviewed by Joseph Pecoraro.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._showDetailView):
Return early if we are already showing a detail view for the selected object.

6:33 PM Changeset in webkit [237060] by youenn@apple.com

13 edits in trunk

IOS 12 - Service worker cache not shared when added to homescreen
https://bugs.webkit.org/show_bug.cgi?id=190269
<rdar://problem/45009961>

Reviewed by Alex Christensen.

Source/WebCore:

Expose Cache Storage API when Service Worker API is exposed.
This is used for API tests.

dom/ScriptExecutionContext.h: Make hasServiceWorkerScheme

available outside SERVICE_WORKER compilation flag since used by DOMWindowCaches.

dom/ScriptExecutionContext.cpp: Ditto.
Modules/cache/DOMWindowCaches.idl:

Source/WebKit:

NetworkProcessProxy does not always have all its stores in its hash map.
Make sure to check for the default web process pool store when grabbing cache storage parameters from a given session ID.

Add a way to remove the default website data for testing.
This is used in the new API test.

UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::deleteDefaultDataStoreForTesting):

UIProcess/API/APIWebsiteDataStore.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _deleteDefaultDataStoreForTesting]):

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Add test to ensure that CacheStorage use the default website data store parameters.

6:32 PM Changeset in webkit [237059] by yusukesuzuki@slowstart.org

5 edits in trunk/Source

Use currentStackPointer more
https://bugs.webkit.org/show_bug.cgi?id=190503

Reviewed by Saam Barati.

Source/JavaScriptCore:

runtime/VM.cpp:

(JSC::VM::committedStackByteCount):

Source/WTF:

Use WTF::currentStackPointer more in WebKit to adopt ASAN detect_stack_use_after_return option.

wtf/StackBounds.cpp:

(WTF::testStackDirection2):
(WTF::testStackDirection):

wtf/ThreadingPthreads.cpp:

(WTF::Thread::signalHandlerSuspendResume):
(WTF::getApproximateStackPointer): Deleted.

5:23 PM Changeset in webkit [237058] by Simon Fraser

9 edits in trunk/Source

Hide RenderLayer z-order and normal flow lists behind iterators
https://bugs.webkit.org/show_bug.cgi?id=190457

Source/WebCore:

Reviewed by Zalan Bujtas.

Expose the positive z-order, negative z-order and normal flow lists
from RenderLayer as iterators rather than vectors of raw pointers.

This hides the fact that the vectors can be null, and allows for easier casting in future.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::update3DTransformedDescendantStatus):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::traverseVisibleNonCompositedDescendantLayers):

rendering/RenderLayerCompositor.cpp:

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

Source/WebKit:

Reviewed by Zalan Bujtas.

Expose the positive z-order, negative z-order and normal flow lists
from RenderLayer as iterators rather than vectors of raw pointers.

Use a lambda function to get access to the private constructor, while not having
to refer to the nested RenderLayer::LayerIterator class in the header.

Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::WebRenderLayer):
(WebKit::WebRenderLayer::createArrayFromLayerList): Deleted.

Shared/WebRenderLayer.h:

5:08 PM Changeset in webkit [237057] by don.olmstead@sony.com

2 edits in trunk/Source/WebCore

Add Houdini specs to features.json
https://bugs.webkit.org/show_bug.cgi?id=190494

Reviewed by Simon Fraser.

Add CSS Typed OM Level 1, CSS Layout API Level 1, CSS Animation
Worklet, and group them under a Houdini feature set.

features.json:

4:51 PM Changeset in webkit [237056] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

iOS: Scrolling using the arrow keys doesn't show the scroll indicator like it does on macOS
https://bugs.webkit.org/show_bug.cgi?id=190478
<rdar://problem/22194031>

Reviewed by Megan Gardner.

Platform/spi/ios/UIKitSPI.h:

Add some SPI.

UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
Do a persistent flash when scrolling continuously.

(-[WKKeyboardScrollViewAnimator scrollWithScrollToExtentAnimationTo:]):
Do a single flash when doing a scroll-to-top/bottom.

4:48 PM Changeset in webkit [237055] by timothy_horton@apple.com

4 edits in trunk

Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
https://bugs.webkit.org/show_bug.cgi?id=190476
<rdar://problem/32757191>

Reviewed by Megan Gardner.

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _saveBackForwardSnapshotForItem:]):
The WKBackForwardListItem can be nil. Then we retrieve a reference from it.
An Objective-C method that returns a reference is a great way to get
a null reference. Other code then assumes it's not null and crashes.
Add a nil check.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:

(TEST):
Add a test that we don't crash.

4:43 PM Changeset in webkit [237054] by yusukesuzuki@slowstart.org

27 edits
2 adds in trunk

[JSC] JSC should have "parseFunction" to optimize Function constructor
https://bugs.webkit.org/show_bug.cgi?id=190340

Reviewed by Mark Lam.

JSTests:

This patch fixes the line number of syntax errors raised by the Function constructor,
since we now parse the final code only once. And we no longer use block statement
for Function constructor's parsing.

ChakraCore/test/Function/FuncBodyES5.baseline-jsc:
stress/function-cache-with-parameters-end-position.js: Added.

(shouldBe):
(shouldThrow):
(i.anonymous):

stress/function-constructor-name.js: Added.

(shouldBe):
(GeneratorFunction):
(AsyncFunction.async):
(AsyncGeneratorFunction.async):
(anonymous):
(async.anonymous):

test262/expectations.yaml:

LayoutTests/imported/w3c:

web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt:
web-platform-tests/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late-expected.txt:
web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-attribute-expected.txt:
web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-body-onerror-expected.txt:

Source/JavaScriptCore:

The current Function constructor is suboptimal. We parse the piece of the same code three times to meet
the spec requirement. (1) check parameters syntax, (2) check body syntax, and (3) parse the entire function.
And to parse 1-3 correctly, we create two strings, the parameters and the entire function. This operation
is really costly and ideally we should meet the above requirement by the one time parsing.

To meet the above requirement, we add a special function for Parser, parseSingleFunction. This function
takes std::optional<int> functionConstructorParametersEndPosition and check this end position is correct in the parser.
For example, if we run the code,

Function('/*', '*/){')

According to the spec, this should produce '/*' parameter string and '*/){' body string. And parameter
string should be syntax-checked by the parser, and raise the error since it is incorrect. Instead of doing
that, in our implementation, we first create the entire string.

function anonymous(/*) {

*/){

}

And we parse it. At that time, we also pass the end position of the parameters to the parser. In the above case,
the position of the `function anonymous(/*)' <> is passed. And in the parser, we check that the last token
offset of the parameters is the given end position. This check allows us to raise the error correctly to the
above example while we parse the entire function only once. And we do not need to create two strings too.

This improves the performance of the Function constructor significantly. And web-tooling-benchmark/uglify-js is
significantly sped up (28.2%).

Before:

uglify-js: 2.94 runs/s

After:

uglify-js: 3.77 runs/s

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

bytecode/UnlinkedFunctionExecutable.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseFunctionExpression):
(JSC::Parser<LexerType>::parseAsyncFunctionExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):

parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):

parser/ParserModes.h:
parser/ParserTokens.h:

(JSC::JSTextPosition::JSTextPosition):
(JSC::JSTokenLocation::JSTokenLocation): Deleted.

parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):

runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

runtime/CodeCache.h:
runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::fromGlobalCode):

runtime/FunctionExecutable.h:

LayoutTests:

fast/dom/attribute-event-listener-errors-expected.txt:
fast/events/attribute-listener-deletion-crash-expected.txt:
fast/events/window-onerror-syntax-error-in-attr-expected.txt:
js/dom/invalid-syntax-for-function-expected.txt:
js/dom/script-start-end-locations-expected.txt:

4:41 PM Changeset in webkit [237053] by timothy_horton@apple.com

8 edits
2 adds in trunk/Source/WebKit

Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)
https://bugs.webkit.org/show_bug.cgi?id=190495
<rdar://problem/22734616>

Reviewed by Andy Estes.

Hook up WKKeyboardScrollViewAnimator to the scroll view when
WKPDFView is installed.

Platform/spi/ios/UIKitSPI.h:

Move _inputFlags to the IPI section so we can remove it
from WKContentViewInteraction.

SourcesCocoa.txt:
UIProcess/ios/WKWebEvent.h:
UIProcess/ios/WKWebEvent.mm:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView handleKeyEvent:]):
(-[WKWebEvent dealloc]): Deleted.

WebKit.xcodeproj/project.pbxproj:

Move WKWebEvent out of WKContentViewInteraction.
We tend to prefer one file per class.
Also, move the code to make a WKWebEvent from a UIEvent into
-initWithEvent:, instead of being ad-hoc in WKContentViewInteraction.
Adopt RetainPtr for the WKWebEvent's uiEvent property.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _handleKeyUIEvent:]):

UIProcess/Cocoa/WKWebViewContentProvider.h:

Plumb hardware keyboard events to custom content views, if they want them.

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView dealloc]):
(-[WKPDFView web_handleKeyEvent:]):
(-[WKPDFView web_initWithFrame:webView:mimeType:]):
Install a WKKeyboardScrollViewAnimator and plumb key events to it.

4:07 PM October 2018 Meeting edited by Jon Davis

Swapped ggaren and cfleizach talks (diff)

3:52 PM Changeset in webkit [237052] by Ross Kirsling

5 edits
1 move in trunk/Source

[WTF] Semaphore.h conflicts with POSIX header
https://bugs.webkit.org/show_bug.cgi?id=190486

Reviewed by Yusuke Suzuki.

Source/WebCore:

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

Source/WTF:

Rename Semaphore.h to WTFSemaphore.h to avoid conflict with POSIX semaphore.h on case-insensitive file systems.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/WTFSemaphore.h: Renamed from wtf/Semaphore.h.

3:06 PM Changeset in webkit [237051] by Ross Kirsling

2 edits in trunk/Source/JavaScriptCore

Fix non-existent define CPU(JSVALUE64)
https://bugs.webkit.org/show_bug.cgi?id=190479

Reviewed by Yusuke Suzuki.

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsImpl):
Correct CPU(JSVALUE64) to USE(JSVALUE64).

2:46 PM Changeset in webkit [237050] by Matt Baker

13 edits in trunk/Source/WebInspectorUI

Web Inspector: remove unused TreeOutline style .force-focus
https://bugs.webkit.org/show_bug.cgi?id=190480
<rdar://problem/45203484>

Reviewed by Joseph Pecoraro.

UserInterface/Views/CallFrameTreeElement.css:

(.tree-outline:focus .item.call-frame.selected .status > .status-image):
(.tree-outline:matches(:focus, .force-focus) .item.call-frame.selected .status > .status-image): Deleted.

UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline:focus .item.processing.selected .subtitle > progress):
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline:matches(:focus, .force-focus) .item.processing.selected .subtitle > progress): Deleted.

UserInterface/Views/DataGrid.css:

(body[dir=ltr] .data-grid:focus tr.selected td:not(:last-child)):
(body[dir=rtl] .data-grid:focus tr.selected td:not(:last-child)):
(.data-grid:focus tr.parent.selected td.disclosure::before):
(.data-grid:focus tr.parent.expanded.selected td.disclosure::before):
(.data-grid:focus tr.selected):
(.data-grid:focus tr.selected td .subtitle):
(body:not(.window-inactive, .window-docked-inactive) .data-grid:focus tr.editable.selected .cell-content > input):
(@media (prefers-dark-interface)):
(body[dir=ltr] .data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)): Deleted.
(body[dir=rtl] .data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)): Deleted.
(.data-grid:matches(:focus, .force-focus) tr.parent.selected td.disclosure::before): Deleted.
(.data-grid:matches(:focus, .force-focus) tr.parent.expanded.selected td.disclosure::before): Deleted.
(.data-grid:matches(:focus, .force-focus) tr.selected): Deleted.
(.data-grid:matches(:focus, .force-focus) tr.selected td .subtitle): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input): Deleted.

UserInterface/Views/Main.css:

(:focus .selected .go-to-arrow):
(:focus .selected .go-to-arrow:active):
(:matches(:focus, .force-focus) .selected .go-to-arrow): Deleted.
(:matches(:focus, .force-focus) .selected .go-to-arrow:active): Deleted.

UserInterface/Views/ProfileView.css:

(.profile > .data-grid:focus tr.selected td .location):
(.profile > .data-grid:matches(:focus, .force-focus) tr.selected td .location): Deleted.

UserInterface/Views/RecordingActionTreeElement.css:

(.tree-outline:focus .item.action.selected:not(.initial-state, .invalid) > .icon):
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus .item.action.selected > .titles .parameter.swizzled,):
(.tree-outline:matches(:focus, .force-focus) .item.action.selected:not(.initial-state, .invalid) > .icon): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:matches(:focus, .force-focus) .item.action.selected > .titles .parameter.swizzled,): Deleted.

UserInterface/Views/ScriptDetailsTimelineView.css:

(.tree-outline:focus .item.selected .alternate-subtitle):
(.tree-outline:matches(:focus, .force-focus) .item.selected .alternate-subtitle): Deleted.

UserInterface/Views/ShaderProgramTreeElement.css:

(.tree-outline:focus .item.shader-program.selected .status > img):
(.tree-outline:matches(:focus, .force-focus) .item.shader-program.selected .status > img): Deleted.

UserInterface/Views/ThreadTreeElement.css:

(.tree-outline:focus > .item.thread.selected .status-button.resume):
(.tree-outline:matches(:focus, .force-focus) > .item.thread.selected .status-button.resume): Deleted.

UserInterface/Views/TimelineRecordBar.css:

(:focus .selected .timeline-record-bar > .segment):
(:focus .selected .timeline-record-bar > .segment.inactive):
(body[dir=ltr] :focus .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=rtl] :focus .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(:matches(:focus, .force-focus) .selected .timeline-record-bar > .segment): Deleted.
(:matches(:focus, .force-focus) .selected .timeline-record-bar > .segment.inactive): Deleted.
(body[dir=ltr] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.
(body[dir=rtl] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.

UserInterface/Views/TreeElementStatusButton.css:

(:focus .item.selected > .status > .status-button):
(:matches(:focus, .force-focus) .item.selected > .status > .status-button): Deleted.

UserInterface/Views/TreeOutline.css:

(.tree-outline:focus .item.selected .disclosure-button):
(.tree-outline:focus .item.selected.expanded .disclosure-button):
(.tree-outline:focus .item.selected):
(.tree-outline:focus .item.selected .subtitle):
(.tree-outline:not(.large):focus .item.selected .status .indeterminate-progress-spinner):
(.tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button): Deleted.
(.tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button): Deleted.
(.tree-outline:matches(:focus, .force-focus) .item.selected): Deleted.
(.tree-outline:matches(:focus, .force-focus) .item.selected .subtitle): Deleted.
(.tree-outline:not(.large):matches(:focus, .force-focus) .item.selected .status .indeterminate-progress-spinner): Deleted.

2:43 PM Changeset in webkit [237049] by graouts@webkit.org

3 edits in trunk/Source/WebKit

[Web Animations] Allow iOS to also control toggling Web Animations CSS Integration
https://bugs.webkit.org/show_bug.cgi?id=190489

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setWebAnimationsCSSIntegrationEnabled:]):
(-[WKPreferences _webAnimationsCSSIntegrationEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

2:30 PM Changeset in webkit [237048] by commit-queue@webkit.org

10 edits in trunk

[GStreamer] Support arbitrary video resolution in getUserMedia API
https://bugs.webkit.org/show_bug.cgi?id=189734

Source/WebCore:

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-10-11
Reviewed by Xabier Rodriguez-Calvar.

Implement arbitrary video resolution for the getUserMedia API in GStreamer.

Fix the MockRealtimeMediaSource device list to make devices properties match
test expectations.

Reactivate tests that were failling because of that.

platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::standardVideoSizes):
(WebCore::standardVideoSizes): Deleted.

platform/mediastream/RealtimeVideoSource.h:
platform/mediastream/VideoPreset.h:
platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoPreset::create):
(WebCore::GStreamerVideoPreset::GStreamerVideoPreset):
(WebCore::GStreamerVideoCaptureSource::GStreamerVideoCaptureSource):
(WebCore::GStreamerVideoCaptureSource::capabilities):
(WebCore::GStreamerVideoCaptureSource::generatePresets):

platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):

LayoutTests:

Implement arbitrary video resolution for the getUserMedia API in GStreamer.

Fix the MockRealtimeMediaSource device list to make devices properties match
test expectations.

Reactivate tests that were failling because of that.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-10-11
Reviewed by Xabier Rodriguez-Calvar.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

2:22 PM Changeset in webkit [237047] by Keith Rollin

12 edits in trunk/Source

CURRENT_ARCH should not be used in Run Script phase.
https://bugs.webkit.org/show_bug.cgi?id=190407
<rdar://problem/45133556>

Reviewed by Alexey Proskuryakov.

CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
CURRENT_ARCH is not well-defined during this phase (and may even have
the value "undefined") since this phase is run just once per build
rather than once per supported architecture. Migrate away from
CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
performing an operation for each value, or by picking the first entry
in ARCHS and using that as a representative value.

Source/JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj: Store

LLIntDesiredOffsets.h into a directory with a name based on ARCHS
rather than CURRENT_ARCH.

Source/WebCore:

No new tests -- no functional changes.

DerivedSources.make: When forming TARGET_TRIPLE_FLAGS, grab the

first entry in ARCHS rather than use CURRENT_ARCH.

Source/WebKit:

DerivedSources.make: When forming TARGET_TRIPLE_FLAGS, grab the

first entry in ARCHS rather than use CURRENT_ARCH.

Source/WebKitLegacy:

WebKitLegacy.xcodeproj/project.pbxproj: When generating

WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
macosx platforms.

Source/WebKitLegacy/mac:

Configurations/WebKitLegacy.xcconfig: When generating

WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
macosx platforms.

MigrateHeaders.make:
migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,

generate one for each architecture in ARCHS.

1:30 PM Changeset in webkit [237046] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Support building WebKit for macOS Mojave using a newer SDK
https://bugs.webkit.org/show_bug.cgi?id=190431

Reviewed by Andy Estes.

platform/network/cocoa/CookieCocoa.mm:

(WebCore::coreSameSitePolicy):
(WebCore::nsSameSitePolicy):

1:29 PM Changeset in webkit [237045] by dbates@webkit.org

3 edits in trunk/Source/WebCore

[iOS] Add typedef for WebEvent keyboard flags
https://bugs.webkit.org/show_bug.cgi?id=190435

Reviewed by Wenson Hsieh.

Currently WebEvent and UIKit SPI are intertwined when it comes to keyboard flags. It seems sufficient
to have WebEvent defined its own keyboard flags so that callers do not need to be aware of UIKit SPI.

No functionality changed. So, no new tests.

platform/ios/WebEvent.h:
platform/ios/WebEvent.mm:

(-[WebEvent keyboardFlags]):

12:32 PM Changeset in webkit [237044] by timothy_horton@apple.com

2 edits in trunk/Tools

REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'

Scripts/webkitpy/tool/steps/options.py:

(Options):
Fix the name of the variable that the --cc-radar option writes into.

12:26 PM Changeset in webkit [237043] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: detail view is not re-shown after sorting the Network table
https://bugs.webkit.org/show_bug.cgi?id=190330
<rdar://problem/45089607>

Reviewed by Matt Baker.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._restoreSelectedRow):

12:19 PM Changeset in webkit [237042] by mark.lam@apple.com

14 edits
2 adds in trunk/Source

Changes towards allowing use of the ASAN detect_stack_use_after_return option.
https://bugs.webkit.org/show_bug.cgi?id=190405
<rdar://problem/45131464>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The ASAN detect_stack_use_after_return option checks for use of stack variables
after they have been freed. It does this by allocating relevant stack variables
in heap memory (instead of on the stack) if the code ever takes the address of
those stack variables. Unfortunately, this is a common idiom that we use to
compute the approximate stack pointer value. As a result, on such ASAN runs, the
computed approximate stack pointer value will point into the heap instead of the
stack. This breaks the VM's expectations and wreaks havoc.

To fix this, we use the newly introduced WTF::currentStackPointer() instead of
taking the address of stack variables.

We also need to enhance ExceptionScopes to be able to work with ASAN
detect_stack_use_after_return which will allocated the scope in the heap. We
work around this by passing the current stack pointer of the instantiating calling
frame into the scope constructor, and using that for the position check in
~ThrowScope() instead.

The above is only a start towards enabling ASAN detect_stack_use_after_return on
the VM. There are still other issues to be resolved before we can run with this
ASAN option.

runtime/CatchScope.h:
runtime/ExceptionEventLocation.h:

(JSC::ExceptionEventLocation::ExceptionEventLocation):

runtime/ExceptionScope.h:

(JSC::ExceptionScope::stackPosition const):

runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

runtime/ThrowScope.cpp:

(JSC::ThrowScope::~ThrowScope):

runtime/ThrowScope.h:
runtime/VM.h:

(JSC::VM::needExceptionCheck const):
(JSC::VM::isSafeToRecurse const):

wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse const):

Source/WTF:

Introduce WTF::currentStackPointer() which computes its caller's stack pointer value.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

wtf/StackPointer.cpp: Added.

(WTF::currentStackPointer):

wtf/StackPointer.h: Added.

11:56 AM Changeset in webkit [237041] by Kocsen Chung

2 edits in tags/Safari-607.1.10.2/Source/WebKit

Cherry-pick r236989. rdar://problem/43391014

REGRESSION(r231663) loading in hidden WKWebViews stalls because WebProcess is suspended
https://bugs.webkit.org/show_bug.cgi?id=190417
<rdar://problem/43391014>

Reviewed by Chris Dumez.

UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::didChangeIsLoading): Revert r321663, but keep the change to TestWKWebView.mm because that made the tests more reliable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:39 AM Changeset in webkit [237040] by Antti Koivisto

3 edits in trunk/Source/WebCore

Use finer grained locking in FontDatabase
https://bugs.webkit.org/show_bug.cgi?id=190467

Reviewed by Alex Christensen.

platform/graphics/FontCache.h:

Also use ListHashSet for prewarming info so we can prewarm in the same order the fonts were
seen last time.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::collectionForFamily):

Only hold the lock when accessing the hashmap. There is no need to hold it during font construction
which can take a long time.

(WebCore::FontDatabase::fontForPostScriptName):

This is currently not prewarmed from a thread so no need for locking.

(WebCore::FontDatabase::clear):

11:35 AM Changeset in webkit [237039] by Kocsen Chung

7 edits in tags/Safari-607.1.10.2/Source

Versioning.

11:32 AM Changeset in webkit [237038] by Kocsen Chung

1 copy in tags/Safari-607.1.10.2

New tag.

11:10 AM October 2018 Meeting edited by Jon Davis

Schedule changes. (diff)

10:32 AM Changeset in webkit [237037] by dino@apple.com

6 edits in trunk/Tools

Add --cc-radar option to webkit-patch bug creation
https://bugs.webkit.org/show_bug.cgi?id=190451
<rdar://problem/45176671>

Reviewed by Antoine Quint.

Add a new command line option to automatically
CC radar to new or updated bugs.

Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

Scripts/webkitpy/tool/commands/upload.py:

(CreateBug.init):
(CreateBug.execute):

Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_prepare_with_cc):
(test_prepare_with_radar):
(test_prepare_with_cc_and_radar):

Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.options):
(CreateBug.run):

Scripts/webkitpy/tool/steps/options.py:

(Options):

10:29 AM Changeset in webkit [237036] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] Fix race condition in GStreamerVideoDecoder
https://bugs.webkit.org/show_bug.cgi?id=190470

The GStreamerVideoDecoder.m_dtsPtsMap filed is accessed from
the main thread and some GStreamer streaming thread, make sure
to protect its access.

And use WTF::StdMap instead of std::map.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-10-11
Reviewed by Philippe Normand.

Manually tested and a random crash is gone.

platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::newSampleCallback):

10:25 AM Changeset in webkit [237035] by Chris Dumez

2 edits in trunk/Source/WebKit

Regression(PSON): Deal with the drawing area potentially being null under WebChromeClient::contentsSizeChanged()
https://bugs.webkit.org/show_bug.cgi?id=190474

Reviewed by Geoffrey Garen.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged const):

8:54 AM Changeset in webkit [237034] by pvollan@apple.com

2 edits in trunk/LayoutTests

Layout Test fast/forms/fieldset/fieldset-elements-htmlcollection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190472

Unreviewed test gardening.

platform/win/TestExpectations:

4:10 AM Changeset in webkit [237033] by eocanha@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer][MSE] Fix height calculation for streams with source aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=190464

Reviewed by Xabier Rodriguez-Calvar.

This patch is authored by Nikola Veljkovic <Nikola.Veljkovic@zenterio.com>

platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::getVideoResolutionFromCaps): Reverse the SAR adjustment to "undo" it
instead of applying it twice.

3:41 AM Changeset in webkit [237032] by Claudio Saavedra

2 edits in trunk/Tools

[GStreamer] Do not build gstgtk plugins
https://bugs.webkit.org/show_bug.cgi?id=190463

Reviewed by Xabier Rodriguez-Calvar.

These plugins pull a GTK+ dependency that, at least in WPE,
is unnecessary. The GTK+ port doesn't need it either, as far
as I can tell.

gstreamer/jhbuild.modules: Disable gstgtk plugins

3:26 AM Changeset in webkit [237031] by commit-queue@webkit.org

23 edits
6 adds in trunk

[GTK][WPE] Add mediaDevices.enumerateDevices support
https://bugs.webkit.org/show_bug.cgi?id=185761

Patch by Alejandro G. Castro <alex@igalia.com> on 2018-10-11
Reviewed by Youenn Fablet.

Source/WebCore:

We are adopting the same policy COCOA is using when returning the
list of media devices if the user does not have persistent
access. Namely, we just return the first media device for audio
and video capture.

Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::filterDeviceList): Add support for
other platforms when filtering devices if there is no persistent
access to the origin.

Source/WebKit:

Implemented the enumerateDevices API using a new WebKit class
(DeviceIdHashSaltStorage) that generates and stores the device ids
hash salts per origin, used to avoid fingerprinting in the
webpages.

The patch also adds a new type of data for the WebsiteDataStore.
That way the users can call the WebsiteDataStore to show what
origins have hash salt generated and remove them at some point.

For the moment just GTK+ and WPE ports are using this class to
generate the hash salts. The patch adds code to the
checkUserMediaPermissionForOrigin API implementation, it was empty
until now for these ports. In this function we create an instance
of a new class WebKitDeviceInfoPermissionRequest that implements
the WebKitPermissionRequestIface interface, that allows the ports
to use the current permission managers implemented in the
embedders to handle this new kind of request the way they like
it. The default implementation is deny.

The class WebKitDeviceInfoPermissionRequest takes care of
contacting the DeviceIdHashSaltStorage and request/regenerate the
hash salts accordingly.

Persistency is still not implemented, we will add it in a
future patch.

Shared/WebsiteData/WebsiteDataType.h: Added the new type of

webside data: DeviceIdHashSalt.

Sources.txt: Added new files to compilation.
SourcesGTK.txt: Ditto.
SourcesWPE.txt: Ditto.
UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp: Added

this class to represent a request of permission to access the
devices information. This is specific for glib ports and implements
the policies regarding the hash salts when the embedder allows or
denies the access using the DeviceIdHashSaltStorage class.
(webkitDeviceInfoPermissionRequestAllow): Get the device hash salt
when the origin is allowed and set it in the original request.
(webkitDeviceInfoPermissionRequestDeny): Regenerate the device id
hash salt when the user does not allow to access the device information.
(webkit_permission_request_interface_init):
(webkitDeviceInfoPermissionRequestDispose):
(webkit_device_info_permission_request_class_init):
(webkitDeviceInfoPermissionRequestCreate): Create the class using
the proxy request from the webprocess and a reference to the
DeviceIdHashSaltStorage.

UIProcess/API/glib/WebKitDeviceInfoPermissionRequestPrivate.h:

Ditto.

UIProcess/API/glib/WebKitUIClient.cpp: Added the implementation

for the checkUserMediaPermissionForOrigin API for the glib ports,
it creates the device info request and calls the permission
request API.

UIProcess/API/glib/WebKitWebsiteData.cpp:

(recordContainsSupportedDataTypes): Added the DeviceIdHashSalt
type.
(toWebKitWebsiteDataTypes): Added the conversion from the WebKit
types to the glib types for the WebsiteDataType::DeviceIdHashSalt.

UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(toWebsiteDataTypes): Added the conversion from the glib type
WEBKIT_WEBSITE_DATA_DEVICE_ID_HASH_SALT to the WebKit type.
(webkit_website_data_manager_remove): Make sure we remote the
DeviceIdHashSalt if the Cookies are selected.

UIProcess/API/gtk/WebKitDeviceInfoPermissionRequest.h: Added

this new class that represents a permission request for the device
information in the GTK+ port.

UIProcess/API/gtk/WebKitWebsiteData.h: Added the new type of

website that in the GTK+ port:
WEBKIT_WEBSITE_DATA_DEVICE_ID_HASH_SALT.

UIProcess/API/wpe/WebKitDeviceInfoPermissionRequest.h: Added

this new class that represents a permission request for the device
information in the WPE port.

UIProcess/API/wpe/WebKitWebsiteData.h: Added the new type of

website that in the WPE port:
WEBKIT_WEBSITE_DATA_DEVICE_ID_HASH_SALT.

UIProcess/DeviceIdHashSaltStorage.cpp: Added this new class that

handles how to generate and store the hash salts inside
WebKit. Persistency is still not implemented, we will add it in a
future patch.
(WebKit::DeviceIdHashSaltStorage::create):
(WebKit::DeviceIdHashSaltStorage::deviceIdentifierHashSaltForOrigin):
Check the map to get the hash salt for an origin, if there is none
create a new random one.
(WebKit::DeviceIdHashSaltStorage::regenerateDeviceIdentifierHashSaltForOrigin):
Delete the hash salt of an origin if it already exists and create a new one.
(WebKit::DeviceIdHashSaltStorage::getDeviceIdHashSaltOrigins):
Returns the list of origins that have a hash salt generated for
them. It is used in the WebsiteDataStore.
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins):
Deletes the hash salts in the map for an origin.
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltOriginsModifiedSince):
Delete the origins that have not been modified since a time.

UIProcess/DeviceIdHashSaltStorage.h: Ditto.
UIProcess/UserMediaPermissionCheckProxy.h: Remove uneeded class

definition.

UIProcess/WebsiteData/WebsiteDataStore.cpp: Added support to

return and remove the origins with a generate hash salt used to
generate the device ids.
(WebKit::WebsiteDataStore::WebsiteDataStore): Added the new
reference to the DeviceIdHashSaltStorage class, used to handle the
hash salts.
(WebKit::WebsiteDataStore::fetchDataAndApply): Get the list of
origins with a hash salts in the DeviceIdHashSaltStorage.
(WebKit::WebsiteDataStore::removeData): Remove the hash salts in
DeviceIdHashSaltStorage for an origin.

UIProcess/WebsiteData/WebsiteDataStore.h: Ditto.

(WebKit::WebsiteDataStore::deviceIdHashSaltStorage):

WebKit.xcodeproj/project.pbxproj: Added the

DeviceIdHashSaltStorage to the compilation.

Tools:

Added new API test for the mediaDevices.enumerateDevices:
usermedia-enumeratedevices-permission-check. And a new API test
for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.

MiniBrowser/gtk/main.c:

(gotWebsiteDataCallback): Added a new section to the about:data
webpage to include the information about the hash salt.

TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:

(testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
new test checking the enumerateDevices API when permission is
denied and when permission is allowed for the origin.
(beforeAll): Defined the new test.

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(serverCallback): Register a new URI for the enumerateDevices.
(testWebsiteDataConfiguration): Remove the hash salts from the
directories.
(testWebsiteDataDeviceIdHashSalt): New test cheking the
enumerateDevices API.
(beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
the init structure.

TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView): Make sure the media-stream is
activated in the webView.

LayoutTests:

Remove the failure expectation for the test
media-devices-enumerate-devices.html. Just for the record we have
also checked the following tests.

fast/mediastream/media-devices-enumerate-devices.html
fast/mediastream/resources/enumerate-devices-frame.html
http/tests/media/media-stream/enumerate-devices-source-id.html
http/tests/media/media-stream/enumerate-devices-source-id-persistent.html
http/tests/media/media-stream/resources/enumerate-devices-source-id-frame.html

platform/gtk/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed