Timeline

Sep 28, 2011:

11:32 PM Changeset in webkit [96305] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

Chromium test_expectations update for isindex-with-no-form.html

• platform/chromium/test_expectations.txt:

11:27 PM Changeset in webkit [96304] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=69062

Chromium test_expectations update

• platform/chromium/test_expectations.txt:

11:24 PM Changeset in webkit [96303] by rniwa@webkit.org

• 1 edit
  4 adds in trunk/LayoutTests

Chromium rebaseline after r96294.

• platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
• platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
• platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
• platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.

11:11 PM Changeset in webkit [96302] by rniwa@webkit.org

• 3 edits in trunk/LayoutTests

Yet another Chromium linux rebaseline after r96257.

• platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
• platform/chromium/test_expectations.txt:

11:07 PM Changeset in webkit [96301] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
​https://bugs.webkit.org/show_bug.cgi?id=68984

Reviewed by Darin Adler.

Just a follow-up fix for the bug 68345. For performance,
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".

Tests: fast/events/constructors/pop-state-event-constructor.html

fast/events/fire-popstate-event.html

• dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):

• dom/PopStateEvent.h:

11:03 PM Changeset in webkit [96300] by Csaba Osztrogonác

• 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r96257.

• platform/qt-4.8/editing/inserting/4278698-expected.png:
• platform/qt-4.8/editing/inserting/4278698-expected.txt:
• platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
• platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
• platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
• platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:

11:02 PM Changeset in webkit [96299] by Martin Robinson

• 6 edits
  2 adds in trunk/Source

[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=66890

Source/WebCore:

Added a GtkDragAndDropHelper class to hold all the logic that is common
between WebKit1 and WebKit2. This will allow greater code sharing between
the two ports.

Reviewed by Philippe Normand.

No new tests. This patch should not change behavior.

• GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
• platform/gtk/GtkDragAndDropHelper.cpp: Added.
• platform/gtk/GtkDragAndDropHelper.h: Added.

Source/WebKit/gtk:

Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.

Reviewed by Philippe Normand.

• WebCoreSupport/DragClientGtk.cpp:

(WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.

• webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was

maintaining drag-and-drop state itself.

• webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance

of the glue class.

11:01 PM Changeset in webkit [96298] by rniwa@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

Update Chromium test expectation and also add back the expected result erroneously removed in r96284.

• platform/chromium/test_expectations.txt:
• platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
• platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.

10:43 PM Changeset in webkit [96297] by rniwa@webkit.org

• 27 edits
  29 adds
  39 deletes in trunk/LayoutTests

Chromium rebaselines for r96257 part 2.

• editing/deleting/delete-line-011-expected.txt: Added.
• editing/deleting/delete-tab-001-expected.txt: Added.
• editing/deleting/delete-tab-002-expected.txt: Added.
• editing/deleting/delete-tab-003-expected.txt: Added.
• editing/deleting/delete-tab-004-expected.txt: Added.
• editing/deleting/smart-delete-002-expected.txt: Added.
• editing/inserting/insert-text-with-newlines-expected.txt: Added.
• editing/style/smoosh-styles-003-expected.txt: Added.
• editing/style/style-3681552-fix-001-expected.txt: Added.
• editing/style/style-boundary-002-expected.txt: Added.
• editing/style/style-boundary-003-expected.txt: Added.
• editing/style/typing-style-001-expected.txt: Added.
• editing/style/typing-style-002-expected.txt: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/paste-xml-expected.txt: Added.
• platform/chromium-cg-mac/editing/pasteboard/paste-xml-expected.txt:
• platform/chromium-linux-x86/editing: Added.
• platform/chromium-linux-x86/editing/pasteboard: Added.
• platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt: Added.
• platform/chromium-linux-x86/editing/style: Added.
• platform/chromium-linux-x86/editing/style/style-3681552-fix-002-expected.txt: Added.
• platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
• platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt: Added.
• platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
• platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
• platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
• platform/chromium-linux/editing/style/style-3681552-fix-002-expected.txt: Added.
• platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
• platform/chromium-win-vista/editing/deleting: Removed.
• platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Removed.
• platform/chromium-win-vista/editing/execCommand: Removed.
• platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Removed.
• platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Removed.
• platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Removed.
• platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Removed.
• platform/chromium-win-vista/editing/inserting: Removed.
• platform/chromium-win-vista/editing/inserting/4278698-expected.png: Removed.
• platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Removed.
• platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Removed.
• platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Removed.
• platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Removed.
• platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Removed.
• platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Added.
• platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Removed.
• platform/chromium-win-vista/editing/selection: Removed.
• platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Removed.
• platform/chromium-win-vista/editing/style: Added.
• platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Added.
• platform/chromium-win-vista/editing/undo: Removed.
• platform/chromium-win-vista/editing/undo/4063751-expected.png: Removed.
• platform/chromium-win-vista/editing/unsupported-content: Removed.
• platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Removed.
• platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Removed.
• platform/chromium-win-xp/editing/pasteboard: Added.
• platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt: Added.
• platform/chromium-win-xp/editing/style: Added.
• platform/chromium-win-xp/editing/style/style-3681552-fix-002-expected.txt: Added.
• platform/chromium-win-xp/fast/events: Removed.
• platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Added.
• platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
• platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
• platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
• platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
• platform/chromium-win/editing/spelling/spelling-expected.txt:
• platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
• platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
• platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
• platform/chromium-win/editing/style/style-boundary-002-expected.txt:
• platform/chromium-win/editing/style/style-boundary-003-expected.txt:
• platform/chromium-win/editing/style/style-boundary-005-expected.txt:
• platform/chromium-win/editing/style/typing-style-001-expected.txt:
• platform/chromium-win/editing/style/typing-style-002-expected.txt:
• platform/chromium-win/fast/events/updateLayoutForHitTest-expected.png:
• platform/chromium-win/fast/events/updateLayoutForHitTest-expected.txt:
• platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
• platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
• platform/gtk/editing/deleting/delete-tab-002-expected.txt: Removed.
• platform/gtk/editing/deleting/delete-tab-003-expected.txt: Removed.
• platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
• platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
• platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
• platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
• platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
• platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
• platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
• platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
• platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
• platform/gtk/fast/repaint/selection-clear-expected.txt: Removed.
• platform/mac/editing/deleting/delete-line-011-expected.txt: Removed.
• platform/mac/editing/deleting/delete-tab-001-expected.txt: Removed.
• platform/mac/editing/deleting/delete-tab-002-expected.txt: Removed.
• platform/mac/editing/deleting/delete-tab-003-expected.txt: Removed.
• platform/mac/editing/deleting/delete-tab-004-expected.txt: Removed.
• platform/mac/editing/deleting/smart-delete-002-expected.txt: Removed.
• platform/mac/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
• platform/mac/editing/style/smoosh-styles-003-expected.txt: Removed.
• platform/mac/editing/style/style-3681552-fix-001-expected.txt: Removed.
• platform/mac/editing/style/style-boundary-002-expected.txt: Removed.
• platform/mac/editing/style/style-boundary-003-expected.txt: Removed.
• platform/mac/editing/style/typing-style-001-expected.txt: Removed.
• platform/mac/editing/style/typing-style-002-expected.txt: Removed.

9:55 PM Changeset in webkit [96296] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Remove some of Chromium test expectations temporarily added for r96257.

• platform/chromium/test_expectations.txt:

9:48 PM Changeset in webkit [96295] by Martin Robinson

• 4 edits in trunk

.: Fix the WebKit2 WebGL build.

• configure.ac: Add -ldl to the OPENGL_LIBS.

Source/WebKit2: Fix the WebGL build on WebKit2 GTK+.

• GNUmakefile.am: Add OPENGL_LIBS to WebKit2 targets.

9:12 PM Changeset in webkit [96294] by mitz@apple.com

• 3 edits
  3 adds in trunk

<rdar://problem/10196497> first-letter after list marker not updated correctly

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/first-letter-after-list-marker.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter): Improved the logic for continuing past list markers
when trying to locate a first letter to update.

LayoutTests:

• fast/dynamic/first-letter-after-list-marker-expected.png: Added.
• fast/dynamic/first-letter-after-list-marker-expected.txt: Added.
• fast/dynamic/first-letter-after-list-marker.html: Added.

9:00 PM Changeset in webkit [96293] by barraclough@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Build fix pt 2 for r96286.

• assembler/MacroAssemblerCodeRef.h:

8:57 PM Changeset in webkit [96292] by hayato@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

Add a test for accesskey in regard to iframes.
​https://bugs.webkit.org/show_bug.cgi?id=67642

Reviewed by Hajime Morita.

To catch any improvement of accesskey behavior in regard to
iframes, it'd be nice to add a test to verify the current behavior.

• fast/dom/access-key-iframe-expected.txt: Added.
• fast/dom/access-key-iframe.html: Added.

7:52 PM Changeset in webkit [96291] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
​https://bugs.webkit.org/show_bug.cgi?id=68594

As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
isn't effective at all, this patch just removes it.

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.

• ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_zoom_set_internal):

7:49 PM Changeset in webkit [96290] by tkent@chromium.org

• 5 edits in trunk

REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 2^{31
​https://bugs.webkit.org/show_bug.cgi?id=68981}

Reviewed by Darin Adler.

Source/WebCore:

• html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().

LayoutTests:

• fast/forms/input-text-paste-maxlength-expected.txt:
• fast/forms/input-text-paste-maxlength.html:

7:37 PM Changeset in webkit [96289] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Run TestWebKitAPI on Chromium buildbots
​https://bugs.webkit.org/show_bug.cgi?id=68678

Patch by Xianzhu Wang <​wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

7:32 PM Changeset in webkit [96288] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Build fix attempt for r96286.

• assembler/MacroAssemblerCodeRef.h:

7:27 PM Changeset in webkit [96287] by ryuan.choi@samsung.com

• 2 edits in trunk

[EFL] Bump minimum requirement for eina.
​https://bugs.webkit.org/show_bug.cgi?id=68994

Reviewed by Ryosuke Niwa.

• Source/cmake/FindEFL.cmake:

6:36 PM Changeset in webkit [96286] by barraclough@apple.com

• 6 edits in trunk/Source/JavaScriptCore

DFG JIT Operations on 32_64 should use stdcall calling convention.
​https://bugs.webkit.org/show_bug.cgi?id=69046

Reviewed by Sam Weinig.

All calls out are expecting stdcall conventions, but the default on OS X are cdecl.
Leave D_DFGOperation_DD calls as the one exception, since we want to be able to link
directly to std library functions like fmod - leave these calls obeying the default
platform calling convention.

• assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

• Add implicit constructors for std calls.

• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

• Make this work non-Mac platforms.

• dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

• dfg/DFGOperations.h:
  • Mark all operations as stdcalls.

6:34 PM Changeset in webkit [96285] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

One last GTK rebaseline for r96257.

• platform/gtk/editing/inserting/insert-at-end-02-expected.txt:

6:31 PM Changeset in webkit [96284] by rniwa@webkit.org

• 53 edits
  58 adds
  2 deletes in trunk/LayoutTests

Chromium rebaseline for r96257 part 2.

• platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
• platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/undo: Added.
• platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/unsupported-content: Added.
• platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png: Added.
• platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png: Added.
• platform/chromium-cg-mac/editing/deleting/table-cells-expected.png:
• platform/chromium-cg-mac/editing/execCommand/create-list-with-hr-expected.png: Added.
• platform/chromium-cg-mac/editing/execCommand/find-after-replace-expected.png: Added.
• platform/chromium-cg-mac/editing/execCommand/paste-1-expected.png: Added.
• platform/chromium-cg-mac/editing/execCommand/paste-2-expected.png: Added.
• platform/chromium-cg-mac/editing/inserting/4278698-expected.png: Added.
• platform/chromium-cg-mac/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
• platform/chromium-cg-mac/editing/pasteboard/3976872-expected.png: Added.
• platform/chromium-cg-mac/editing/pasteboard/4076267-2-expected.png: Added.
• platform/chromium-cg-mac/editing/pasteboard/4076267-3-expected.png: Added.
• platform/chromium-cg-mac/editing/pasteboard/4076267-expected.png: Added.
• platform/chromium-cg-mac/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
• platform/chromium-cg-mac/editing/selection/select-all-iframe-expected.png: Added.
• platform/chromium-cg-mac/editing/undo: Added.
• platform/chromium-cg-mac/editing/undo/4063751-expected.png: Added.
• platform/chromium-cg-mac/editing/unsupported-content: Added.
• platform/chromium-cg-mac/editing/unsupported-content/table-type-after-expected.png: Added.
• platform/chromium-cg-mac/editing/unsupported-content/table-type-before-expected.png: Added.
• platform/chromium-linux/editing/deleting/table-cells-expected.png:
• platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-linux/editing/execCommand/paste-1-expected.png:
• platform/chromium-linux/editing/execCommand/paste-2-expected.png:
• platform/chromium-linux/editing/inserting/4278698-expected.png:
• platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-linux/editing/pasteboard/3976872-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-expected.png:
• platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
• platform/chromium-linux/editing/undo/4063751-expected.png:
• platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
• platform/chromium-mac/editing/deleting/table-cells-expected.png:
• platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-mac/editing/execCommand/paste-1-expected.png:
• platform/chromium-mac/editing/execCommand/paste-2-expected.png:
• platform/chromium-mac/editing/inserting/4278698-expected.png:
• platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-mac/editing/pasteboard/3976872-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-expected.png:
• platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png:
• platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
• platform/chromium-mac/editing/undo/4063751-expected.png:
• platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
• platform/chromium-win-vista/editing: Added.
• platform/chromium-win-vista/editing/deleting: Added.
• platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Added.
• platform/chromium-win-vista/editing/execCommand: Added.
• platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Added.
• platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Added.
• platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Added.
• platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Added.
• platform/chromium-win-vista/editing/inserting: Added.
• platform/chromium-win-vista/editing/inserting/4278698-expected.png: Added.
• platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
• platform/chromium-win-vista/editing/pasteboard: Added.
• platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Added.
• platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Added.
• platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Added.
• platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Added.
• platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
• platform/chromium-win-vista/editing/selection: Added.
• platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Added.
• platform/chromium-win-vista/editing/undo: Added.
• platform/chromium-win-vista/editing/undo/4063751-expected.png: Added.
• platform/chromium-win-vista/editing/unsupported-content: Added.
• platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Added.
• platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Added.
• platform/chromium-win/editing/deleting/table-cells-expected.png:
• platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-win/editing/execCommand/paste-1-expected.png:
• platform/chromium-win/editing/execCommand/paste-2-expected.png:
• platform/chromium-win/editing/inserting/4278698-expected.png:
• platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-win/editing/pasteboard/3976872-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-expected.png:
• platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
• platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-win/editing/selection/select-all-iframe-expected.png:
• platform/chromium-win/editing/undo/4063751-expected.png:
• platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
• platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
• platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.

6:28 PM Changeset in webkit [96283] by commit-queue@webkit.org

• 5 edits in trunk/Source

Remove unused createRootLayerPainter from CCLayerTreeHostClient
​https://bugs.webkit.org/show_bug.cgi?id=69042

Patch by Antoine Labour <​piman@chromium.org> on 2011-09-28
Reviewed by James Robinson.

No new test needed: no semantic change.

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

6:03 PM clutter edited by kov@webkit.org

(diff)

6:03 PM Changeset in webkit [96282] by Dimitri Glazkov

• 2 edits in trunk/Tools

garden-o-matic results should anticipate 0 unexpected failures.
​https://bugs.webkit.org/show_bug.cgi?id=69036

Also fixes controllers: UnexpectedFailures test.

Reviewed by Adam Barth.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.

6:01 PM Changeset in webkit [96281] by macpherson@chromium.org

• 2 edits in trunk/Source/WebCore

Only resolve direction aware properties when properties are direction aware.
​https://bugs.webkit.org/show_bug.cgi?id=68968

Reviewed by Eric Seidel.

No new tests / no functionality changed.

Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

5:47 PM Changeset in webkit [96280] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

DFG JIT falls back on numerical comparisons when it does not
recognize a prediction
​https://bugs.webkit.org/show_bug.cgi?id=68977

Reviewed by Geoffrey Garen.

This fixes both the way comparison implementations are selected. It
also fixes a bug where comparisons other than equality (like < or >)
on objects are compiled as if the comparison was equality.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):

5:45 PM Changeset in webkit [96279] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit/mac

ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
​https://bugs.webkit.org/show_bug.cgi?id=69037

Reviewed by Alexey Proskuryakov.

• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::runOpenPanel):
If no delegate is implemented, dismiss the listener
with a cancel. It expects some action.

5:45 PM Changeset in webkit [96278] by Simon Fraser

• 6 edits in trunk

fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
​https://bugs.webkit.org/show_bug.cgi?id=68815

Source/WebCore:

Reviewed by Dan Bernstein.

FrameView::scrollElementToRect() was incorrectly using Element::boundsInWindowSpace(),
which is window-relative (not web view-relative), and has flipped coordinates
in WebKit1.

Change to use Node::getRect() which is what the author intended.

• dom/Element.h:
• page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):

LayoutTests:

Reviewed by Dan Bernstein.

Fix these tests to not throw errors when window.internals is not available.

• fast/dom/scroll-element-to-rect-centered.html:
• fast/dom/scroll-element-to-rect.html:

5:32 PM Changeset in webkit [96277] by rniwa@webkit.org

• 1 edit
  1 copy in trunk/LayoutTests

Qt rebsaeline after r96257. It seems like the difference is coming from the font used in select element.

• platform/qt/editing/pasteboard/select-element-1-expected.txt: Copied from

LayoutTests/editing/pasteboard/select-element-1-expected.txt.

5:29 PM Changeset in webkit [96276] by commit-queue@webkit.org

• 5 edits
  10 adds in trunk

Don't clamp cubic-bezier timing functions between 0 and 1
​https://bugs.webkit.org/show_bug.cgi?id=45761

Source/WebCore:

Remove the limitation of clamping the cubic-bezier timing function
values between 0 and 1, following the specification change made on
April 5 of this year.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

Tests: transitions/cubic-bezier-overflow-color.html

transitions/cubic-bezier-overflow-length.html
transitions/cubic-bezier-overflow-shadow.html
transitions/cubic-bezier-overflow-svg-length.html
transitions/cubic-bezier-overflow-transform.html

• css/CSSParser.cpp:

(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):

LayoutTests:

Test overflow behavior of colors, lengths, svg lengths,
shadows and transforms (through rotations). Update the
timing function test to check for now valid values.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

• fast/css/transition-timing-function-expected.txt:
• fast/css/transition-timing-function.html:
• transitions/cubic-bezier-overflow-color-expected.txt: Added.
• transitions/cubic-bezier-overflow-color.html: Added.
• transitions/cubic-bezier-overflow-length-expected.txt: Added.
• transitions/cubic-bezier-overflow-length.html: Added.
• transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
• transitions/cubic-bezier-overflow-shadow.html: Added.
• transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
• transitions/cubic-bezier-overflow-svg-length.html: Added.
• transitions/cubic-bezier-overflow-transform-expected.txt: Added.
• transitions/cubic-bezier-overflow-transform.html: Added.

5:24 PM Changeset in webkit [96275] by rniwa@webkit.org

• 10 edits in trunk/LayoutTests

More GTK rebaselines after r96257.

• platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
• platform/gtk/editing/deleting/delete-line-005-expected.txt:
• platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
• platform/gtk/editing/deleting/regional-indicators-expected.txt:
• platform/gtk/editing/deleting/table-cells-expected.txt:
• platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
• platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-005-expected.txt:

5:21 PM Changeset in webkit [96274] by mihaip@chromium.org

• 2 edits in trunk/LayoutTests

Remove Chromium failing expectations for tests that now pass.

• platform/chromium/test_expectations.txt:

5:20 PM Changeset in webkit [96273] by rniwa@webkit.org

• 283 edits
  1 add
  4 deletes in trunk/LayoutTests

Chromium rebaseline for r96257 part 1.

• platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Removed.
• platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
• platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
• platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
• platform/chromium-linux/editing/deleting/table-cells-expected.png:
• platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
• platform/chromium-linux/editing/execCommand/paste-1-expected.png:
• platform/chromium-linux/editing/execCommand/paste-2-expected.png:
• platform/chromium-linux/editing/inserting/4278698-expected.png:
• platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-linux/editing/pasteboard/3976872-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-linux/editing/pasteboard/4076267-expected.png:
• platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-linux/editing/selection/node-removal-1-expected.png:
• platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
• platform/chromium-linux/editing/undo/4063751-expected.png:
• platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
• platform/chromium-mac/editing/deleting/table-cells-expected.png:
• platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
• platform/chromium-mac/editing/execCommand/paste-1-expected.png:
• platform/chromium-mac/editing/execCommand/paste-2-expected.png:
• platform/chromium-mac/editing/inserting/4278698-expected.png:
• platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-mac/editing/pasteboard/3976872-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-mac/editing/pasteboard/4076267-expected.png:
• platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-mac/editing/selection/node-removal-1-expected.png:
• platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
• platform/chromium-mac/editing/undo/4063751-expected.png:
• platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
• platform/chromium-win-xp/editing/pasteboard: Removed.
• platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3775172-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3857753-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3865854-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3928305-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt:
• platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
• platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-contents-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-contents-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-contents-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-023-expected.txt:
• platform/chromium-win/editing/deleting/delete-block-merge-contents-024-expected.txt:
• platform/chromium-win/editing/deleting/delete-br-008-expected.txt:
• platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
• platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-first-list-item-expected.txt:
• platform/chromium-win/editing/deleting/delete-image-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-image-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-image-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-image-004-expected.txt:
• platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-003-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-004-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-005-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-006-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-007-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-008-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-009-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-010-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-013-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-014-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-015-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-016-expected.txt:
• platform/chromium-win/editing/deleting/delete-line-017-expected.txt:
• platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-listitem-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
• platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
• platform/chromium-win/editing/deleting/forward-delete-expected.txt:
• platform/chromium-win/editing/deleting/list-item-1-expected.txt:
• platform/chromium-win/editing/deleting/merge-different-styles-expected.txt:
• platform/chromium-win/editing/deleting/merge-endOfParagraph-expected.txt:
• platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
• platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
• platform/chromium-win/editing/deleting/pruning-after-merge-2-expected.txt:
• platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
• platform/chromium-win/editing/deleting/table-cells-expected.png:
• platform/chromium-win/editing/deleting/table-cells-expected.txt:
• platform/chromium-win/editing/execCommand/4641880-1-expected.txt:
• platform/chromium-win/editing/execCommand/4641880-2-expected.txt:
• platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
• platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
• platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
• platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
• platform/chromium-win/editing/execCommand/format-block-with-trailing-br-expected.txt:
• platform/chromium-win/editing/execCommand/indent-list-item-expected.txt:
• platform/chromium-win/editing/execCommand/indent-selection-expected.txt:
• platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.txt:
• platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
• platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
• platform/chromium-win/editing/execCommand/nsresponder-indent-expected.txt:
• platform/chromium-win/editing/execCommand/nsresponder-outdent-expected.txt:
• platform/chromium-win/editing/execCommand/paste-1-expected.png:
• platform/chromium-win/editing/execCommand/paste-1-expected.txt:
• platform/chromium-win/editing/execCommand/paste-2-expected.png:
• platform/chromium-win/editing/execCommand/paste-2-expected.txt:
• platform/chromium-win/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/chromium-win/editing/execCommand/remove-list-item-1-expected.txt:
• platform/chromium-win/editing/inserting/4278698-expected.png:
• platform/chromium-win/editing/inserting/4278698-expected.txt:
• platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
• platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
• platform/chromium-win/editing/inserting/insert-3775316-fix-expected.txt:
• platform/chromium-win/editing/inserting/insert-3851164-fix-expected.txt:
• platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
• platform/chromium-win/editing/inserting/insert-at-end-01-expected.txt:
• platform/chromium-win/editing/inserting/insert-at-end-02-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-001-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-005-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
• platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-001-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-002-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-005-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-007-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-009-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-010-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-020-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-023-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-025-expected.txt:
• platform/chromium-win/editing/inserting/insert-div-026-expected.txt:
• platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
• platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
• platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
• platform/chromium-win/editing/inserting/paragraph-separator-03-expected.txt:
• platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
• platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/chromium-win/editing/inserting/redo-expected.txt:
• platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/chromium-win/editing/inserting/typing-001-expected.txt:
• platform/chromium-win/editing/inserting/typing-002-expected.txt:
• platform/chromium-win/editing/inserting/typing-003-expected.txt:
• platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
• platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
• platform/chromium-win/editing/pasteboard/3976872-expected.png:
• platform/chromium-win/editing/pasteboard/3976872-expected.txt:
• platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
• platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
• platform/chromium-win/editing/pasteboard/4076267-expected.png:
• platform/chromium-win/editing/pasteboard/4076267-expected.txt:
• platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
• platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
• platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
• platform/chromium-win/editing/pasteboard/displaced-generic-placeholder-expected.txt:
• platform/chromium-win/editing/pasteboard/displaced-placeholder-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
• platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
• platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
• platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
• platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
• platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.txt:
• platform/chromium-win/editing/selection/move-between-blocks-no-001-expected.txt:
• platform/chromium-win/editing/selection/node-removal-1-expected.png:
• platform/chromium-win/editing/selection/node-removal-1-expected.txt:
• platform/chromium-win/editing/selection/node-removal-2-expected.txt:
• platform/chromium-win/editing/selection/replace-selection-1-expected.txt:
• platform/chromium-win/editing/selection/select-all-iframe-expected.png:
• platform/chromium-win/editing/selection/select-all-iframe-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-001-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-002-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-003-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-004-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-007-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-009-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-010-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-011-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-012-expected.txt:
• platform/chromium-win/editing/style/create-block-for-style-013-expected.txt:
• platform/chromium-win/editing/style/designmode-expected.txt:
• platform/chromium-win/editing/style/relative-font-size-change-001-expected.txt:
• platform/chromium-win/editing/style/relative-font-size-change-002-expected.txt:
• platform/chromium-win/editing/style/smoosh-styles-001-expected.txt:
• platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
• platform/chromium-win/editing/style/smoosh-styles-003-expected.txt:
• platform/chromium-win/editing/style/style-3998892-fix-expected.txt:
• platform/chromium-win/editing/style/style-boundary-001-expected.txt:
• platform/chromium-win/editing/style/style-boundary-004-expected.txt:
• platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
• platform/chromium-win/editing/undo/4063751-expected.png:
• platform/chromium-win/editing/undo/4063751-expected.txt:
• platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
• platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
• platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
• platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
• platform/chromium-win/editing/undo/undo-delete-expected.txt:
• platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
• platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
• platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
• platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
• platform/chromium-win/editing/unsupported-content/list-delete-001-expected.txt:
• platform/chromium-win/editing/unsupported-content/list-delete-003-expected.txt:
• platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
• platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
• platform/chromium-win/editing/unsupported-content/table-delete-001-expected.txt:
• platform/chromium-win/editing/unsupported-content/table-delete-002-expected.txt:
• platform/chromium-win/editing/unsupported-content/table-delete-003-expected.txt:
• platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
• platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
• platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
• platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
• platform/chromium-win/fast/dynamic/move-node-with-selection-expected.txt:
• platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
• platform/gtk/editing/deleting/delete-br-010-expected.txt: Removed.
• platform/gtk/editing/inserting/insert-div-010-expected.txt: Removed.
• platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Removed.
• platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.

5:09 PM Changeset in webkit [96272] by dpranke@chromium.org

• 16 edits in trunk

Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.

​https://bugs.webkit.org/show_bug.cgi?id=67253

Reviewed by Eric Seidel.

Tools:

Nearly all of the work in this was done by Simon Fraser; I'm
just repackaging it and cleaning it up a bit. This change
modifies port.diff_image() to return a tuple of (pass/fail,
%age), adds the value to the FailureImageHashMismatch, and
writes the value into the full_results.json files to be
displayed in the results page.

• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
• Scripts/webkitpy/layout_tests/models/test_failures.py:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/chromium.py:
• Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
• Scripts/webkitpy/layout_tests/port/port_testcase.py:
• Scripts/webkitpy/layout_tests/port/test.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

LayoutTests:

• fast/harness/resources/results-test.js:

(mockExpectation):
(runDefaultSingleRowTest):
():

• fast/harness/results.html:

5:09 PM Changeset in webkit [96271] by bfulgham@webkit.org

• 2 edits in trunk/Source/WebKit2

WinCairo build fix.

• WebProcess/WebPage/WebFrame.h: Add include of <wtc/RetainPtr.h>

5:06 PM Changeset in webkit [96270] by crogers@google.com

• 4 edits
  3 adds in trunk

DelayNode must set the context on delayTime AudioParam to support automation
​https://bugs.webkit.org/show_bug.cgi?id=68828

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/delaynode-scheduling.html

• webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

LayoutTests:

• webaudio/delaynode-scheduling-expected.txt: Added.
• webaudio/delaynode-scheduling.html: Added.
• webaudio/delaynode.html:
• webaudio/resources/delay-testing.js: Added.

(createToneBuffer):
(checkDelayedResult.return.var):
(checkDelayedResult):

5:02 PM Changeset in webkit [96269] by rniwa@webkit.org

• 3 edits in trunk/LayoutTests

More Mac rebaselines for r96257.

• platform/mac/editing/execCommand/insertHorizontalRule-expected.png:
• platform/mac/editing/selection/node-removal-1-expected.png:

5:00 PM Changeset in webkit [96268] by haraken@chromium.org

• 2 edits in trunk/Tools

Add myself to committers.py

4:56 PM Changeset in webkit [96267] by mihaip@chromium.org

• 2 edits in trunk/LayoutTests

Add failing Chromium expectations after r96257.

• platform/chromium/test_expectations.txt:

4:24 PM Changeset in webkit [96266] by rniwa@webkit.org

• 245 edits in trunk/LayoutTests

GTK rebaseline for r96257.

• platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
• platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
• platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
• platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
• platform/gtk/editing/deleting/delete-and-undo-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
• platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
• platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-023-expected.txt:
• platform/gtk/editing/deleting/delete-block-merge-contents-024-expected.txt:
• platform/gtk/editing/deleting/delete-br-008-expected.txt:
• platform/gtk/editing/deleting/delete-br-010-expected.txt:
• platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
• platform/gtk/editing/deleting/delete-first-list-item-expected.txt:
• platform/gtk/editing/deleting/delete-image-001-expected.txt:
• platform/gtk/editing/deleting/delete-image-002-expected.txt:
• platform/gtk/editing/deleting/delete-image-003-expected.txt:
• platform/gtk/editing/deleting/delete-image-004-expected.txt:
• platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
• platform/gtk/editing/deleting/delete-line-001-expected.txt:
• platform/gtk/editing/deleting/delete-line-002-expected.txt:
• platform/gtk/editing/deleting/delete-line-003-expected.txt:
• platform/gtk/editing/deleting/delete-line-004-expected.txt:
• platform/gtk/editing/deleting/delete-line-005-expected.txt:
• platform/gtk/editing/deleting/delete-line-006-expected.txt:
• platform/gtk/editing/deleting/delete-line-007-expected.txt:
• platform/gtk/editing/deleting/delete-line-008-expected.txt:
• platform/gtk/editing/deleting/delete-line-009-expected.txt:
• platform/gtk/editing/deleting/delete-line-010-expected.txt:
• platform/gtk/editing/deleting/delete-line-011-expected.txt:
• platform/gtk/editing/deleting/delete-line-012-expected.txt:
• platform/gtk/editing/deleting/delete-line-013-expected.txt:
• platform/gtk/editing/deleting/delete-line-014-expected.txt:
• platform/gtk/editing/deleting/delete-line-015-expected.txt:
• platform/gtk/editing/deleting/delete-line-016-expected.txt:
• platform/gtk/editing/deleting/delete-line-017-expected.txt:
• platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
• platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
• platform/gtk/editing/deleting/delete-selection-001-expected.txt:
• platform/gtk/editing/deleting/delete-tab-001-expected.txt:
• platform/gtk/editing/deleting/delete-tab-002-expected.txt:
• platform/gtk/editing/deleting/delete-tab-003-expected.txt:
• platform/gtk/editing/deleting/delete-tab-004-expected.txt:
• platform/gtk/editing/deleting/delete-trailing-ws-001-expected.txt:
• platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
• platform/gtk/editing/deleting/forward-delete-expected.txt:
• platform/gtk/editing/deleting/list-item-1-expected.txt:
• platform/gtk/editing/deleting/merge-different-styles-expected.txt:
• platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
• platform/gtk/editing/deleting/merge-no-br-expected.txt:
• platform/gtk/editing/deleting/non-smart-delete-expected.txt:
• platform/gtk/editing/deleting/pruning-after-merge-2-expected.txt:
• platform/gtk/editing/deleting/smart-delete-001-expected.txt:
• platform/gtk/editing/deleting/smart-delete-002-expected.txt:
• platform/gtk/editing/deleting/table-cells-expected.txt:
• platform/gtk/editing/execCommand/4641880-1-expected.txt:
• platform/gtk/editing/execCommand/4641880-2-expected.txt:
• platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
• platform/gtk/editing/execCommand/find-after-replace-expected.txt:
• platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt:
• platform/gtk/editing/execCommand/indent-list-item-expected.txt:
• platform/gtk/editing/execCommand/indent-selection-expected.txt:
• platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt:
• platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
• platform/gtk/editing/execCommand/nsresponder-indent-expected.txt:
• platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt:
• platform/gtk/editing/execCommand/paste-1-expected.txt:
• platform/gtk/editing/execCommand/paste-2-expected.txt:
• platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/gtk/editing/execCommand/remove-list-item-1-expected.txt:
• platform/gtk/editing/inserting/4278698-expected.txt:
• platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
• platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
• platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
• platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
• platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
• platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
• platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
• platform/gtk/editing/inserting/insert-br-001-expected.txt:
• platform/gtk/editing/inserting/insert-br-003-expected.txt:
• platform/gtk/editing/inserting/insert-br-005-expected.txt:
• platform/gtk/editing/inserting/insert-br-006-expected.txt:
• platform/gtk/editing/inserting/insert-br-007-expected.txt:
• platform/gtk/editing/inserting/insert-br-008-expected.txt:
• platform/gtk/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/gtk/editing/inserting/insert-div-001-expected.txt:
• platform/gtk/editing/inserting/insert-div-002-expected.txt:
• platform/gtk/editing/inserting/insert-div-003-expected.txt:
• platform/gtk/editing/inserting/insert-div-005-expected.txt:
• platform/gtk/editing/inserting/insert-div-006-expected.txt:
• platform/gtk/editing/inserting/insert-div-007-expected.txt:
• platform/gtk/editing/inserting/insert-div-008-expected.txt:
• platform/gtk/editing/inserting/insert-div-009-expected.txt:
• platform/gtk/editing/inserting/insert-div-010-expected.txt:
• platform/gtk/editing/inserting/insert-div-020-expected.txt:
• platform/gtk/editing/inserting/insert-div-023-expected.txt:
• platform/gtk/editing/inserting/insert-div-024-expected.txt:
• platform/gtk/editing/inserting/insert-div-025-expected.txt:
• platform/gtk/editing/inserting/insert-div-026-expected.txt:
• platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
• platform/gtk/editing/inserting/insert-text-at-tabspan-001-expected.txt:
• platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/gtk/editing/inserting/multiple-lines-selected-expected.txt:
• platform/gtk/editing/inserting/paragraph-separator-03-expected.txt:
• platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/gtk/editing/inserting/redo-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/gtk/editing/inserting/typing-001-expected.txt:
• platform/gtk/editing/inserting/typing-002-expected.txt:
• platform/gtk/editing/inserting/typing-003-expected.txt:
• platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
• platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
• platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt:
• platform/gtk/editing/pasteboard/3976872-expected.txt:
• platform/gtk/editing/pasteboard/4076267-2-expected.txt:
• platform/gtk/editing/pasteboard/4076267-3-expected.txt:
• platform/gtk/editing/pasteboard/4076267-expected.txt:
• platform/gtk/editing/pasteboard/8145-3-expected.txt:
• platform/gtk/editing/pasteboard/bad-placeholder-expected.txt:
• platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
• platform/gtk/editing/pasteboard/displaced-generic-placeholder-expected.txt:
• platform/gtk/editing/pasteboard/displaced-placeholder-expected.txt:
• platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
• platform/gtk/editing/pasteboard/merge-after-delete-1-expected.txt:
• platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
• platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
• platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
• platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
• platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-001-expected.txt:
• platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
• platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/gtk/editing/pasteboard/paste-table-003-expected.txt:
• platform/gtk/editing/pasteboard/paste-table-cells-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-016-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-019-expected.txt:
• platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
• platform/gtk/editing/pasteboard/paste-xml-expected.txt:
• platform/gtk/editing/pasteboard/pasting-object-expected.txt:
• platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
• platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
• platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
• platform/gtk/editing/pasteboard/undoable-fragment-removes-expected.txt:
• platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
• platform/gtk/editing/selection/node-removal-1-expected.txt:
• platform/gtk/editing/selection/node-removal-2-expected.txt:
• platform/gtk/editing/selection/replace-selection-1-expected.txt:
• platform/gtk/editing/selection/select-all-iframe-expected.txt:
• platform/gtk/editing/spelling/spelling-expected.txt:
• platform/gtk/editing/style/create-block-for-style-001-expected.txt:
• platform/gtk/editing/style/create-block-for-style-002-expected.txt:
• platform/gtk/editing/style/create-block-for-style-003-expected.txt:
• platform/gtk/editing/style/create-block-for-style-004-expected.txt:
• platform/gtk/editing/style/create-block-for-style-007-expected.txt:
• platform/gtk/editing/style/create-block-for-style-009-expected.txt:
• platform/gtk/editing/style/create-block-for-style-010-expected.txt:
• platform/gtk/editing/style/create-block-for-style-011-expected.txt:
• platform/gtk/editing/style/create-block-for-style-012-expected.txt:
• platform/gtk/editing/style/create-block-for-style-013-expected.txt:
• platform/gtk/editing/style/designmode-expected.txt:
• platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
• platform/gtk/editing/style/relative-font-size-change-002-expected.txt:
• platform/gtk/editing/style/smoosh-styles-001-expected.txt:
• platform/gtk/editing/style/smoosh-styles-003-expected.txt:
• platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
• platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
• platform/gtk/editing/style/style-3998892-fix-expected.txt:
• platform/gtk/editing/style/style-boundary-001-expected.txt:
• platform/gtk/editing/style/style-boundary-002-expected.txt:
• platform/gtk/editing/style/style-boundary-003-expected.txt:
• platform/gtk/editing/style/style-boundary-004-expected.txt:
• platform/gtk/editing/style/style-boundary-005-expected.txt:
• platform/gtk/editing/style/typing-style-001-expected.txt:
• platform/gtk/editing/style/typing-style-002-expected.txt:
• platform/gtk/editing/style/unbold-in-bold-expected.txt:
• platform/gtk/editing/undo/4063751-expected.txt:
• platform/gtk/editing/undo/redo-typing-001-expected.txt:
• platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
• platform/gtk/editing/undo/undo-combined-delete-expected.txt:
• platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
• platform/gtk/editing/undo/undo-delete-expected.txt:
• platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
• platform/gtk/editing/undo/undo-forward-delete-expected.txt:
• platform/gtk/editing/undo/undo-misspellings-expected.txt:
• platform/gtk/editing/undo/undo-typing-001-expected.txt:
• platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
• platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
• platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
• platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
• platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
• platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
• platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
• platform/gtk/editing/unsupported-content/table-type-after-expected.txt:
• platform/gtk/editing/unsupported-content/table-type-before-expected.txt:
• platform/gtk/fast/dynamic/move-node-with-selection-expected.txt:
• platform/gtk/fast/events/updateLayoutForHitTest-expected.txt:
• platform/gtk/fast/repaint/selection-clear-expected.txt:
• platform/gtk/svg/custom/use-clipped-hit-expected.txt:

3:25 PM Changeset in webkit [96265] by abarth@webkit.org

• 4 edits in trunk/Tools

garden-o-matic shouldn't depend on test-results.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=69019

Reviewed by Dimitri Glazkov.

This patch moves garden-o-matic from getting full_results.json from
test-results.appspot.com to getting that information directly from the
buildbot. This patch improve the load time and accuracy of
garden-o-matic because test-results.appspot.com is slow and is dropping
a significant number of writes (see
​https://bugs.webkit.org/show_bug.cgi?id=68748).

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

3:05 PM Changeset in webkit [96264] by rniwa@webkit.org

• 263 edits in trunk/LayoutTests

Mac rebaseline for r96257.

Also fixed editing/deleting/regional-indicators.html as done in the original patch.
(The fix was included in the original patch but webkit-patch could not apply because of some exotic characters in the test.)

• editing/deleting/delete-ligature-001-expected.txt:
• editing/deleting/regional-indicators.html:
• editing/pasteboard/interchange-newline-2-expected.txt:
• editing/pasteboard/paste-4039777-fix-expected.txt:
• editing/pasteboard/select-element-1-expected.txt:
• fast/events/5056619-expected.txt:
• platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
• platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
• platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
• platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
• platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
• platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
• platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
• platform/mac/editing/deleting/delete-3865854-fix-expected.txt:
• platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
• platform/mac/editing/deleting/delete-3959464-fix-expected.txt:
• platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
• platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
• platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
• platform/mac/editing/deleting/delete-and-undo-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/mac/editing/deleting/delete-block-contents-001-expected.txt:
• platform/mac/editing/deleting/delete-block-contents-002-expected.txt:
• platform/mac/editing/deleting/delete-block-contents-003-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-005-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-008-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-023-expected.txt:
• platform/mac/editing/deleting/delete-block-merge-contents-024-expected.txt:
• platform/mac/editing/deleting/delete-br-008-expected.txt:
• platform/mac/editing/deleting/delete-br-010-expected.txt:
• platform/mac/editing/deleting/delete-br-011-expected.txt:
• platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
• platform/mac/editing/deleting/delete-first-list-item-expected.txt:
• platform/mac/editing/deleting/delete-image-001-expected.txt:
• platform/mac/editing/deleting/delete-image-002-expected.txt:
• platform/mac/editing/deleting/delete-image-003-expected.txt:
• platform/mac/editing/deleting/delete-image-004-expected.txt:
• platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
• platform/mac/editing/deleting/delete-line-001-expected.txt:
• platform/mac/editing/deleting/delete-line-002-expected.txt:
• platform/mac/editing/deleting/delete-line-003-expected.txt:
• platform/mac/editing/deleting/delete-line-004-expected.txt:
• platform/mac/editing/deleting/delete-line-005-expected.txt:
• platform/mac/editing/deleting/delete-line-006-expected.txt:
• platform/mac/editing/deleting/delete-line-007-expected.txt:
• platform/mac/editing/deleting/delete-line-008-expected.txt:
• platform/mac/editing/deleting/delete-line-009-expected.txt:
• platform/mac/editing/deleting/delete-line-010-expected.txt:
• platform/mac/editing/deleting/delete-line-011-expected.txt:
• platform/mac/editing/deleting/delete-line-012-expected.txt:
• platform/mac/editing/deleting/delete-line-013-expected.txt:
• platform/mac/editing/deleting/delete-line-014-expected.txt:
• platform/mac/editing/deleting/delete-line-015-expected.txt:
• platform/mac/editing/deleting/delete-line-016-expected.txt:
• platform/mac/editing/deleting/delete-line-017-expected.txt:
• platform/mac/editing/deleting/delete-listitem-001-expected.txt:
• platform/mac/editing/deleting/delete-listitem-002-expected.txt:
• platform/mac/editing/deleting/delete-selection-001-expected.txt:
• platform/mac/editing/deleting/delete-tab-001-expected.txt:
• platform/mac/editing/deleting/delete-tab-002-expected.txt:
• platform/mac/editing/deleting/delete-tab-003-expected.txt:
• platform/mac/editing/deleting/delete-tab-004-expected.txt:
• platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
• platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
• platform/mac/editing/deleting/forward-delete-expected.txt:
• platform/mac/editing/deleting/list-item-1-expected.txt:
• platform/mac/editing/deleting/merge-different-styles-expected.txt:
• platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
• platform/mac/editing/deleting/merge-no-br-expected.txt:
• platform/mac/editing/deleting/non-smart-delete-expected.txt:
• platform/mac/editing/deleting/pruning-after-merge-2-expected.txt:
• platform/mac/editing/deleting/smart-delete-001-expected.txt:
• platform/mac/editing/deleting/smart-delete-002-expected.txt:
• platform/mac/editing/deleting/smart-delete-003-expected.txt:
• platform/mac/editing/deleting/smart-delete-004-expected.txt:
• platform/mac/editing/deleting/table-cells-expected.txt:
• platform/mac/editing/execCommand/4641880-1-expected.txt:
• platform/mac/editing/execCommand/4641880-2-expected.txt:
• platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
• platform/mac/editing/execCommand/find-after-replace-expected.txt:
• platform/mac/editing/execCommand/format-block-with-trailing-br-expected.txt:
• platform/mac/editing/execCommand/indent-list-item-expected.txt:
• platform/mac/editing/execCommand/indent-selection-expected.txt:
• platform/mac/editing/execCommand/insert-list-and-stitch-expected.txt:
• platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
• platform/mac/editing/execCommand/nsresponder-indent-expected.txt:
• platform/mac/editing/execCommand/nsresponder-outdent-expected.txt:
• platform/mac/editing/execCommand/paste-1-expected.txt:
• platform/mac/editing/execCommand/paste-2-expected.txt:
• platform/mac/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/mac/editing/execCommand/remove-list-item-1-expected.txt:
• platform/mac/editing/input/5576619-expected.txt:
• platform/mac/editing/input/emacs-ctrl-o-expected.txt:
• platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
• platform/mac/editing/input/text-input-controller-expected.txt:
• platform/mac/editing/inserting/4278698-expected.txt:
• platform/mac/editing/inserting/editing-empty-divs-expected.txt:
• platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
• platform/mac/editing/inserting/insert-3775316-fix-expected.txt:
• platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
• platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
• platform/mac/editing/inserting/insert-at-end-01-expected.txt:
• platform/mac/editing/inserting/insert-at-end-02-expected.txt:
• platform/mac/editing/inserting/insert-br-001-expected.txt:
• platform/mac/editing/inserting/insert-br-003-expected.txt:
• platform/mac/editing/inserting/insert-br-005-expected.txt:
• platform/mac/editing/inserting/insert-br-006-expected.txt:
• platform/mac/editing/inserting/insert-br-007-expected.txt:
• platform/mac/editing/inserting/insert-br-008-expected.txt:
• platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/mac/editing/inserting/insert-div-001-expected.txt:
• platform/mac/editing/inserting/insert-div-002-expected.txt:
• platform/mac/editing/inserting/insert-div-003-expected.txt:
• platform/mac/editing/inserting/insert-div-005-expected.txt:
• platform/mac/editing/inserting/insert-div-006-expected.txt:
• platform/mac/editing/inserting/insert-div-007-expected.txt:
• platform/mac/editing/inserting/insert-div-008-expected.txt:
• platform/mac/editing/inserting/insert-div-009-expected.txt:
• platform/mac/editing/inserting/insert-div-010-expected.txt:
• platform/mac/editing/inserting/insert-div-020-expected.txt:
• platform/mac/editing/inserting/insert-div-023-expected.txt:
• platform/mac/editing/inserting/insert-div-024-expected.txt:
• platform/mac/editing/inserting/insert-div-025-expected.txt:
• platform/mac/editing/inserting/insert-div-026-expected.txt:
• platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
• platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
• platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
• platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
• platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/mac/editing/inserting/redo-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/mac/editing/inserting/typing-001-expected.txt:
• platform/mac/editing/inserting/typing-002-expected.txt:
• platform/mac/editing/inserting/typing-003-expected.txt:
• platform/mac/editing/inserting/typing-around-br-001-expected.txt:
• platform/mac/editing/inserting/typing-around-image-001-expected.txt:
• platform/mac/editing/inserting/typing-at-end-of-line-expected.txt:
• platform/mac/editing/pasteboard/3976872-expected.txt:
• platform/mac/editing/pasteboard/4076267-2-expected.txt:
• platform/mac/editing/pasteboard/4076267-3-expected.txt:
• platform/mac/editing/pasteboard/4076267-expected.txt:
• platform/mac/editing/pasteboard/8145-3-expected.txt:
• platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
• platform/mac/editing/pasteboard/cut-text-001-expected.txt:
• platform/mac/editing/pasteboard/displaced-generic-placeholder-expected.txt:
• platform/mac/editing/pasteboard/displaced-placeholder-expected.txt:
• platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
• platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
• platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
• platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
• platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
• platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
• platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
• platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
• platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt:
• platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
• platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/mac/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/mac/editing/pasteboard/paste-table-003-expected.txt:
• platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
• platform/mac/editing/pasteboard/paste-text-004-expected.txt:
• platform/mac/editing/pasteboard/paste-text-005-expected.txt:
• platform/mac/editing/pasteboard/paste-text-006-expected.txt:
• platform/mac/editing/pasteboard/paste-text-007-expected.txt:
• platform/mac/editing/pasteboard/paste-text-008-expected.txt:
• platform/mac/editing/pasteboard/paste-text-016-expected.txt:
• platform/mac/editing/pasteboard/paste-text-019-expected.txt:
• platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
• platform/mac/editing/pasteboard/paste-xml-expected.txt:
• platform/mac/editing/pasteboard/pasting-object-expected.txt:
• platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
• platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
• platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
• platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
• platform/mac/editing/pasteboard/undoable-fragment-removes-expected.txt:
• platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
• platform/mac/editing/selection/node-removal-1-expected.txt:
• platform/mac/editing/selection/node-removal-2-expected.txt:
• platform/mac/editing/selection/replace-selection-1-expected.txt:
• platform/mac/editing/selection/select-all-iframe-expected.txt:
• platform/mac/editing/spelling/spelling-expected.txt:
• platform/mac/editing/style/create-block-for-style-001-expected.txt:
• platform/mac/editing/style/create-block-for-style-002-expected.txt:
• platform/mac/editing/style/create-block-for-style-003-expected.txt:
• platform/mac/editing/style/create-block-for-style-004-expected.txt:
• platform/mac/editing/style/create-block-for-style-007-expected.txt:
• platform/mac/editing/style/create-block-for-style-009-expected.txt:
• platform/mac/editing/style/create-block-for-style-010-expected.txt:
• platform/mac/editing/style/create-block-for-style-011-expected.txt:
• platform/mac/editing/style/create-block-for-style-012-expected.txt:
• platform/mac/editing/style/create-block-for-style-013-expected.txt:
• platform/mac/editing/style/designmode-expected.txt:
• platform/mac/editing/style/relative-font-size-change-001-expected.txt:
• platform/mac/editing/style/relative-font-size-change-002-expected.txt:
• platform/mac/editing/style/smoosh-styles-001-expected.txt:
• platform/mac/editing/style/smoosh-styles-003-expected.txt:
• platform/mac/editing/style/style-3681552-fix-001-expected.txt:
• platform/mac/editing/style/style-3681552-fix-002-expected.txt:
• platform/mac/editing/style/style-3998892-fix-expected.txt:
• platform/mac/editing/style/style-boundary-001-expected.txt:
• platform/mac/editing/style/style-boundary-002-expected.txt:
• platform/mac/editing/style/style-boundary-003-expected.txt:
• platform/mac/editing/style/style-boundary-004-expected.txt:
• platform/mac/editing/style/style-boundary-005-expected.txt:
• platform/mac/editing/style/typing-style-001-expected.txt:
• platform/mac/editing/style/typing-style-002-expected.txt:
• platform/mac/editing/style/unbold-in-bold-expected.txt:
• platform/mac/editing/undo/4063751-expected.txt:
• platform/mac/editing/undo/redo-typing-001-expected.txt:
• platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
• platform/mac/editing/undo/undo-combined-delete-expected.txt:
• platform/mac/editing/undo/undo-delete-boundary-expected.txt:
• platform/mac/editing/undo/undo-delete-expected.txt:
• platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
• platform/mac/editing/undo/undo-forward-delete-expected.txt:
• platform/mac/editing/undo/undo-misspellings-expected.txt:
• platform/mac/editing/undo/undo-typing-001-expected.txt:
• platform/mac/editing/unsupported-content/list-delete-001-expected.txt:
• platform/mac/editing/unsupported-content/list-delete-003-expected.txt:
• platform/mac/editing/unsupported-content/list-type-after-expected.txt:
• platform/mac/editing/unsupported-content/list-type-before-expected.txt:
• platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
• platform/mac/editing/unsupported-content/table-delete-002-expected.txt:
• platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
• platform/mac/editing/unsupported-content/table-type-after-expected.txt:
• platform/mac/editing/unsupported-content/table-type-before-expected.txt:
• platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
• platform/mac/fast/repaint/selection-clear-expected.txt:
• platform/mac/svg/custom/use-clipped-hit-expected.txt:

2:58 PM Changeset in webkit [96263] by levin@chromium.org

• 2 edits
  4 adds in trunk/Tools

watchlist: Add a way to load the watchlist from config.
​https://bugs.webkit.org/show_bug.cgi?id=68991

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/config/watchlist: Added.
• Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.

Support for loading the watch list.

• Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.

Tests for the loading.

• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

Adjusted to use the common base class.

• Scripts/webkitpy/common/webkitunittest.py: Added.

Made a common base class for functionality used in more than one.

2:30 PM Changeset in webkit [96262] by levin@chromium.org

• 2 edits in trunk/Tools

Attempt fix for Leopard python unit test run.

• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

2:02 PM Changeset in webkit [96261] by scheib@chromium.org

• 2 edits in branches/chromium/874/Source/WebKit/chromium

Merge 95861 - occasional crash in Chromium in dispatching keyEvent
​https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <​scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.

Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/8072009

2:01 PM Changeset in webkit [96260] by commit-queue@webkit.org

• 5 edits
  3 adds in trunk

JavaScript generated documents don't inherit the cookie URL
​https://bugs.webkit.org/show_bug.cgi?id=69003

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/cookies/cookie-theft-with-javascript-doc.html

• dom/Document.h:

(WebCore::Document::setCookieURL):

• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):

• loader/DocumentWriter.h:

LayoutTests:

• http/tests/security/cookies/cookie-theft-with-javascript-doc-expected.txt: Added.
• http/tests/security/cookies/cookie-theft-with-javascript-doc.html: Added.
• http/tests/security/cookies/resources/innocent-victim-with-cookies.html: Added.

1:59 PM Changeset in webkit [96259] by barraclough@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Implement callOperation(D_DFGOperation_DD) for DFG JIT 32_64
​https://bugs.webkit.org/show_bug.cgi?id=69026

Reviewed by Sam Weinig.

• assembler/X86Assembler.h:

(JSC::X86Assembler::fstpl):

• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

1:55 PM Changeset in webkit [96258] by Dimitri Glazkov

• 6 edits
  2 adds in trunk

REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
​https://bugs.webkit.org/show_bug.cgi?id=68938

Source/WebCore:

Reviewed by David Hyatt.

Test: all svg tests in LayoutTests.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths): Added a null-check for containingBlock.

Tools:

Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.

Reviewed by David Hyatt.

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didUpdateLayout): Added width/height queries.

• DumpRenderTree/chromium/WebViewHost.h: Updated defs.

LayoutTests:

Reviewed by David Hyatt.

• fast/frames/flattening/crash-svg-document-expected.txt: Added.
• fast/frames/flattening/crash-svg-document.html: Added.

1:51 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:51 PM Changeset in webkit [96257] by rniwa@webkit.org

• 330 edits
  4 adds in trunk

Setting innerText to an empty string on editable div loses focus
​https://bugs.webkit.org/show_bug.cgi?id=62092

Patch by Una Sabovic <​una.sabovic@palm.com> on 2011-09-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

When selection start or end node is being deleted do not clear the selection.
Instead update the start/end position to an equivalent parent-anchored positions.
When text is inserted/deleted update selection per range modification spec:
​http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation

Tests: editing/selection/document-mutation.html

editing/selection/editable-div-clear-on-keydown.html

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::respondToNodeModification):
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):

• editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval):

LayoutTests:

Added test to make sure that caret is still present in a focused editable div after its text is deleted.
Updated editing tests to not expect that deleting selection start or end node will clear the selection.
Added test to exercise range modification examples from
​http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation

• editing/deleting/5546763-expected.txt:
• editing/deleting/delete-4038408-fix-expected.txt:
• editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
• editing/deleting/delete-br-011-expected.txt:
• editing/deleting/delete-by-word-001-expected.txt:
• editing/deleting/delete-by-word-002-expected.txt:
• editing/deleting/delete-cell-contents-expected.txt:
• editing/deleting/delete-ligature-002-expected.txt:
• editing/deleting/delete-ligature-003-expected.txt:
• editing/deleting/delete-select-all-002-expected.txt:
• editing/deleting/delete-select-all-003-expected.txt:
• editing/deleting/delete-to-end-of-paragraph-expected.txt:
• editing/deleting/merge-paragraph-into-blockquote-expected.txt:
• editing/deleting/paragraph-in-preserveNewline-expected.txt:
• editing/deleting/pruning-after-merge-1-expected.txt:
• editing/deleting/skip-virama-001-expected.txt:
• editing/deleting/whitespace-pre-1-expected.txt:
• editing/execCommand/4920488-expected.txt:
• editing/execCommand/crash-indenting-list-item-expected.txt:
• editing/execCommand/createLink-expected.txt:
• editing/execCommand/format-block-expected.txt:
• editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt:
• editing/execCommand/format-block-with-braces-expected.txt:
• editing/execCommand/hilitecolor-expected.txt:
• editing/execCommand/indent-nested-lists-1-expected.txt:
• editing/execCommand/indent-nested-lists-2-expected.txt:
• editing/execCommand/indent-nested-lists-3-expected.txt:
• editing/execCommand/indent-nested-lists-4-expected.txt:
• editing/execCommand/indent-nested-lists-5-expected.txt:
• editing/execCommand/indent-nested-lists-6-expected.txt:
• editing/execCommand/indent-nested-lists-7-expected.txt:
• editing/execCommand/indent-paragraphs-expected.txt:
• editing/execCommand/indent-with-style-expected.txt:
• editing/execCommand/insertHTML-expected.txt:
• editing/execCommand/outdent-nested-lists-1-expected.txt:
• editing/execCommand/outdent-nested-lists-2-expected.txt:
• editing/execCommand/outdent-nested-lists-3-expected.txt:
• editing/execCommand/outdent-nested-lists-4-expected.txt:
• editing/execCommand/queryCommandState-01-expected.txt:
• editing/execCommand/remove-formatting-2-expected.txt:
• editing/execCommand/remove-formatting-expected.txt:
• editing/execCommand/remove-list-1-expected.txt:
• editing/execCommand/remove-list-items-expected.txt:
• editing/execCommand/switch-list-type-expected.txt:
• editing/execCommand/unlink-expected.txt:
• editing/inserting/insert-3786362-fix-expected.txt:
• editing/inserting/insert-div-021-expected.txt:
• editing/inserting/insert-paragraph-at-end-of-line-expected.txt:
• editing/inserting/insert-thai-characters-001-expected.txt:
• editing/pasteboard/4242293-1-expected.txt:
• editing/pasteboard/5065605-expected.txt:
• editing/pasteboard/block-wrappers-necessary-expected.txt:
• editing/pasteboard/copy-in-password-field-expected.txt:
• editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
• editing/pasteboard/insert-div-text-into-text-expected.txt:
• editing/pasteboard/interchange-newline-1-expected.txt:
• editing/pasteboard/interchange-newline-3-expected.txt:
• editing/pasteboard/interchange-newline-4-expected.txt:
• editing/pasteboard/merge-end-2-expected.txt:
• editing/pasteboard/merge-end-3-expected.txt:
• editing/pasteboard/merge-end-4-expected.txt:
• editing/pasteboard/merge-end-5-expected.txt:
• editing/pasteboard/merge-end-list-2-expected.txt:
• editing/pasteboard/merge-end-list-expected.txt:
• editing/pasteboard/merge-end-table-2-expected.txt:
• editing/pasteboard/merge-end-table-expected.txt:
• editing/pasteboard/nested-blocks-with-text-area-expected.txt:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt:
• editing/pasteboard/paste-into-anchor-text-expected.txt:
• editing/pasteboard/paste-list-001-expected.txt:
• editing/pasteboard/paste-table-001-expected.txt:
• editing/pasteboard/paste-table-002-expected.txt:
• editing/pasteboard/paste-text-001-expected.txt:
• editing/pasteboard/paste-text-002-expected.txt:
• editing/pasteboard/paste-text-003-expected.txt:
• editing/pasteboard/paste-text-011-expected.txt:
• editing/pasteboard/paste-text-017-expected.txt:
• editing/pasteboard/paste-text-018-expected.txt:
• editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
• editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
• editing/pasteboard/paste-text-with-style-expected.txt:
• editing/pasteboard/prevent-block-nesting-01-expected.txt:
• editing/pasteboard/select-element-1-expected.txt:
• editing/pasteboard/smart-paste-003-expected.txt:
• editing/pasteboard/smart-paste-004-expected.txt:
• editing/pasteboard/smart-paste-005-expected.txt:
• editing/pasteboard/smart-paste-006-expected.txt:
• editing/selection/5497643-expected.txt:
• editing/selection/5497643.html:
• editing/selection/character-data-mutation-expected.txt:
• editing/selection/character-data-mutation.html:
• editing/selection/document-mutation-expected.txt: Added.
• editing/selection/document-mutation.html: Added.
• editing/selection/editable-div-clear-on-keydown-expected.txt: Added.
• editing/selection/editable-div-clear-on-keydown.html: Added.
• editing/selection/regional-indicators.html:
• editing/style/remove-underline-from-stylesheet-expected.txt:
• editing/style/typing-style-003-expected.txt:
• editing/undo/redo-style-expected.txt:
• editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:
• editing/undo/undo-indent-expected.txt:
• platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html:
• platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
• platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
• platform/qt/editing/deleting/delete-3608462-fix-expected.txt:
• platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
• platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
• platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
• platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
• platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
• platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
• platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
• platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
• platform/qt/editing/deleting/delete-and-undo-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
• platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
• platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
• platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
• platform/qt/editing/deleting/delete-br-008-expected.txt:
• platform/qt/editing/deleting/delete-br-010-expected.txt:
• platform/qt/editing/deleting/delete-contiguous-ws-001-expected.txt:
• platform/qt/editing/deleting/delete-first-list-item-expected.txt:
• platform/qt/editing/deleting/delete-image-001-expected.txt:
• platform/qt/editing/deleting/delete-image-002-expected.txt:
• platform/qt/editing/deleting/delete-image-003-expected.txt:
• platform/qt/editing/deleting/delete-image-004-expected.txt:
• platform/qt/editing/deleting/delete-leading-ws-001-expected.txt:
• platform/qt/editing/deleting/delete-line-001-expected.txt:
• platform/qt/editing/deleting/delete-line-002-expected.txt:
• platform/qt/editing/deleting/delete-line-003-expected.txt:
• platform/qt/editing/deleting/delete-line-004-expected.txt:
• platform/qt/editing/deleting/delete-line-005-expected.txt:
• platform/qt/editing/deleting/delete-line-006-expected.txt:
• platform/qt/editing/deleting/delete-line-007-expected.txt:
• platform/qt/editing/deleting/delete-line-008-expected.txt:
• platform/qt/editing/deleting/delete-line-009-expected.txt:
• platform/qt/editing/deleting/delete-line-010-expected.txt:
• platform/qt/editing/deleting/delete-line-012-expected.txt:
• platform/qt/editing/deleting/delete-line-013-expected.txt:
• platform/qt/editing/deleting/delete-line-014-expected.txt:
• platform/qt/editing/deleting/delete-line-015-expected.txt:
• platform/qt/editing/deleting/delete-line-016-expected.txt:
• platform/qt/editing/deleting/delete-line-017-expected.txt:
• platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
• platform/qt/editing/deleting/delete-listitem-001-expected.txt:
• platform/qt/editing/deleting/delete-listitem-002-expected.txt:
• platform/qt/editing/deleting/delete-selection-001-expected.txt:
• platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
• platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
• platform/qt/editing/deleting/delete-ws-fixup-002-expected.txt:
• platform/qt/editing/deleting/forward-delete-expected.txt:
• platform/qt/editing/deleting/list-item-1-expected.txt:
• platform/qt/editing/deleting/merge-different-styles-expected.txt:
• platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
• platform/qt/editing/deleting/merge-no-br-expected.txt:
• platform/qt/editing/deleting/non-smart-delete-expected.txt:
• platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
• platform/qt/editing/deleting/smart-delete-001-expected.txt:
• platform/qt/editing/deleting/smart-delete-003-expected.txt:
• platform/qt/editing/deleting/smart-delete-004-expected.txt:
• platform/qt/editing/deleting/table-cells-expected.txt:
• platform/qt/editing/execCommand/4641880-1-expected.txt:
• platform/qt/editing/execCommand/4641880-2-expected.txt:
• platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
• platform/qt/editing/execCommand/find-after-replace-expected.txt:
• platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
• platform/qt/editing/execCommand/indent-list-item-expected.txt:
• platform/qt/editing/execCommand/indent-selection-expected.txt:
• platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
• platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
• platform/qt/editing/execCommand/nsresponder-indent-expected.txt:
• platform/qt/editing/execCommand/nsresponder-outdent-expected.txt:
• platform/qt/editing/execCommand/paste-1-expected.txt:
• platform/qt/editing/execCommand/paste-2-expected.txt:
• platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
• platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
• platform/qt/editing/input/emacs-ctrl-o-expected.txt:
• platform/qt/editing/inserting/4278698-expected.txt:
• platform/qt/editing/inserting/editing-empty-divs-expected.txt:
• platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
• platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
• platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
• platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
• platform/qt/editing/inserting/insert-at-end-01-expected.txt:
• platform/qt/editing/inserting/insert-at-end-02-expected.txt:
• platform/qt/editing/inserting/insert-br-001-expected.txt:
• platform/qt/editing/inserting/insert-br-003-expected.txt:
• platform/qt/editing/inserting/insert-br-005-expected.txt:
• platform/qt/editing/inserting/insert-br-006-expected.txt:
• platform/qt/editing/inserting/insert-br-007-expected.txt:
• platform/qt/editing/inserting/insert-br-008-expected.txt:
• platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/qt/editing/inserting/insert-div-001-expected.txt:
• platform/qt/editing/inserting/insert-div-002-expected.txt:
• platform/qt/editing/inserting/insert-div-003-expected.txt:
• platform/qt/editing/inserting/insert-div-005-expected.txt:
• platform/qt/editing/inserting/insert-div-006-expected.txt:
• platform/qt/editing/inserting/insert-div-007-expected.txt:
• platform/qt/editing/inserting/insert-div-008-expected.txt:
• platform/qt/editing/inserting/insert-div-009-expected.txt:
• platform/qt/editing/inserting/insert-div-010-expected.txt:
• platform/qt/editing/inserting/insert-div-020-expected.txt:
• platform/qt/editing/inserting/insert-div-023-expected.txt:
• platform/qt/editing/inserting/insert-div-024-expected.txt:
• platform/qt/editing/inserting/insert-div-025-expected.txt:
• platform/qt/editing/inserting/insert-div-026-expected.txt:
• platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
• platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
• platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
• platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
• platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/qt/editing/inserting/redo-expected.txt:
• platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/qt/editing/inserting/typing-001-expected.txt:
• platform/qt/editing/inserting/typing-002-expected.txt:
• platform/qt/editing/inserting/typing-003-expected.txt:
• platform/qt/editing/inserting/typing-around-br-001-expected.txt:
• platform/qt/editing/inserting/typing-around-image-001-expected.txt:
• platform/qt/editing/pasteboard/3976872-expected.txt:
• platform/qt/editing/pasteboard/4076267-2-expected.txt:
• platform/qt/editing/pasteboard/4076267-3-expected.txt:
• platform/qt/editing/pasteboard/4076267-expected.txt:
• platform/qt/editing/pasteboard/8145-3-expected.txt:
• platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
• platform/qt/editing/pasteboard/cut-text-001-expected.txt:
• platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
• platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
• platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
• platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
• platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
• platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
• platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
• platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
• platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
• platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
• platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
• platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
• platform/qt/editing/pasteboard/paste-table-003-expected.txt:
• platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
• platform/qt/editing/pasteboard/paste-text-004-expected.txt:
• platform/qt/editing/pasteboard/paste-text-005-expected.txt:
• platform/qt/editing/pasteboard/paste-text-006-expected.txt:
• platform/qt/editing/pasteboard/paste-text-007-expected.txt:
• platform/qt/editing/pasteboard/paste-text-008-expected.txt:
• platform/qt/editing/pasteboard/paste-text-016-expected.txt:
• platform/qt/editing/pasteboard/paste-text-019-expected.txt:
• platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
• platform/qt/editing/pasteboard/pasting-object-expected.txt:
• platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
• platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
• platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
• platform/qt/editing/selection/move-between-blocks-no-001-expected.txt:
• platform/qt/editing/selection/node-removal-1-expected.txt:
• platform/qt/editing/selection/node-removal-2-expected.txt:
• platform/qt/editing/selection/replace-selection-1-expected.txt:
• platform/qt/editing/selection/select-all-iframe-expected.txt:
• platform/qt/editing/style/create-block-for-style-001-expected.txt:
• platform/qt/editing/style/create-block-for-style-002-expected.txt:
• platform/qt/editing/style/create-block-for-style-003-expected.txt:
• platform/qt/editing/style/create-block-for-style-004-expected.txt:
• platform/qt/editing/style/create-block-for-style-007-expected.txt:
• platform/qt/editing/style/create-block-for-style-009-expected.txt:
• platform/qt/editing/style/create-block-for-style-010-expected.txt:
• platform/qt/editing/style/create-block-for-style-011-expected.txt:
• platform/qt/editing/style/create-block-for-style-012-expected.txt:
• platform/qt/editing/style/create-block-for-style-013-expected.txt:
• platform/qt/editing/style/designmode-expected.txt:
• platform/qt/editing/style/relative-font-size-change-001-expected.txt:
• platform/qt/editing/style/relative-font-size-change-002-expected.txt:
• platform/qt/editing/style/smoosh-styles-001-expected.txt:
• platform/qt/editing/style/smoosh-styles-003-expected.txt:
• platform/qt/editing/style/style-3998892-fix-expected.txt:
• platform/qt/editing/style/style-boundary-001-expected.txt:
• platform/qt/editing/style/style-boundary-004-expected.txt:
• platform/qt/editing/style/unbold-in-bold-expected.txt:
• platform/qt/editing/undo/4063751-expected.txt:
• platform/qt/editing/undo/redo-typing-001-expected.txt:
• platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
• platform/qt/editing/undo/undo-combined-delete-expected.txt:
• platform/qt/editing/undo/undo-delete-boundary-expected.txt:
• platform/qt/editing/undo/undo-delete-expected.txt:
• platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
• platform/qt/editing/undo/undo-forward-delete-expected.txt:
• platform/qt/editing/undo/undo-misspellings-expected.txt:
• platform/qt/editing/undo/undo-typing-001-expected.txt:
• platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
• platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
• platform/qt/editing/unsupported-content/list-type-after-expected.txt:
• platform/qt/editing/unsupported-content/list-type-before-expected.txt:
• platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
• platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
• platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
• platform/qt/editing/unsupported-content/table-type-after-expected.txt:
• platform/qt/editing/unsupported-content/table-type-before-expected.txt:
• platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
• platform/qt/svg/custom/use-clipped-hit-expected.txt:

1:50 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:48 PM Changeset in webkit [96256] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[chromium / skia] temporarily add files test expectations pending rebaseline due to skia change
​https://bugs.webkit.org/show_bug.cgi?id=69013

Patch by Brian Salomon <​bsalomon@google.com> on 2011-09-28
Reviewed by Stephen White.

• platform/chromium/test_expectations.txt:

1:48 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:46 PM Changeset in webkit [96255] by adauria@apple.com

• 3 edits in trunk/Source/WebKit/mac

Expose +[WebStorageManager _storageDirectoryPath] as SPI
​https://bugs.webkit.org/show_bug.cgi?id=68951

Reviewed by Brady Eidson.

This patch exposes +[WebStorageManager _storageDirectoryPath], which
pulls the path from NSUserDefaults if the preference is set. Otherwise,
it falls back on the default path.

• Storage/WebStorageManager.mm:

(+[WebStorageManager _storageDirectoryPath]): Adding static variable
so that we don't reread user defaults repeatedly.
(WebKitInitializeStorageIfNecessary):

• Storage/WebStorageManagerPrivate.h:

1:41 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

1:28 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

1:21 PM Changeset in webkit [96254] by loislo@chromium.org

• 1 edit in branches/chromium/874/Source/WebCore/inspector/front-end/TimelinePanel.js

Merge 95794 - Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Yury Semikhatsky.

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

TBR=​loislo@chromium.org

1:18 PM Changeset in webkit [96253] by Joseph Pecoraro

• 2 edits in trunk/Source/WebCore

FTPDirectoryDocument Shows Garbled String for Last Modified Date
​https://bugs.webkit.org/show_bug.cgi?id=69011

Reviewed by Dan Bernstein.

Force WTF::String concatenation instead of an accidental char* pointer addition.

• html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

1:10 PM Changeset in webkit [96252] by mihaip@chromium.org

• 3 edits in trunk/Tools

Get rebaseline server running again
​https://bugs.webkit.org/show_bug.cgi?id=69020

Reviewed by Adam Barth.

Make rebaseline server run again after r90337 (missing format_date_time
import, results_json wasn't outputting anything).

• Scripts/webkitpy/tool/servers/rebaselineserver.py:
• Scripts/webkitpy/tool/servers/reflectionhandler.py:

1:07 PM Changeset in webkit [96251] by dgrogan@chromium.org

• 2 edits in trunk/Tools

Move dgrogan from contributor to committer.

1:06 PM Changeset in webkit [96250] by mihaip@chromium.org

• 3 edits in trunk/Tools

Add Mac Skia GPU bots to builders.py
​https://bugs.webkit.org/show_bug.cgi?id=69016

Reviewed by Eric Seidel.

This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
GPU tests.

• Scripts/webkitpy/layout_tests/port/builders.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

12:56 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

12:55 PM Changeset in webkit [96249] by Csaba Osztrogonác

• 3 edits in trunk/Source/WebCore

Fix a regression in r96060. ResourceLoader shouldn't get
initialized with a null DocumentLoader.
​https://bugs.webkit.org/show_bug.cgi?id=69004

Patch by Nate Chapin <Nate Chapin> on 2011-09-28
Reviewed by Csaba Osztrogonác.

This should fix a debug crash in some platforms in
plugins/js-from-destroy.html

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init): Move the activeDocumentLoader() null checks back

to SubresouceLoader::create().

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

12:55 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

12:54 PM Changeset in webkit [96248] by kov@webkit.org

• 2 edits in trunk/Source/WebKit2

One more shot at fixing GTK+, this seems to make the dependencies
work.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-09-28

• GNUmakefile.am:

12:53 PM Changeset in webkit [96247] by barraclough@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Merge bug#68580, bug#68932 for DFG JIT with JSVALUE32_64
​https://bugs.webkit.org/show_bug.cgi?id=69017

Reviewed by Oliver Hunt.

• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

• dfg/DFGOperations.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):

12:51 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

12:24 PM Changeset in webkit [96246] by barraclough@apple.com

• 4 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Reviewed by Oliver Hunt.

• fast/js/array-prototype-properties-expected.txt: Added.
• fast/js/array-prototype-properties.html: Added.
• fast/js/script-tests/array-prototype-properties.js: Added.
  • Added layout test for array prototype functions with undefined as this value.
• ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
• ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
  • These tests now pass.

12:15 PM Changeset in webkit [96245] by kov@webkit.org

• 2 edits in trunk/Source/WebKit2

GTK+ build fix 3 - the return of the marshal.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-09-28

• GNUmakefile.am:

12:14 PM Changeset in webkit [96244] by mihaip@chromium.org

• 3 edits in trunk/LayoutTests

Rebaseline fast/canvas/canvas-composite-transformclip.html and
fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.

• platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
• platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:

12:02 PM Changeset in webkit [96243] by barraclough@apple.com

• 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Reviewed by Oliver Hunt.

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

• These methods should throw if this value is undefined.

11:39 AM Changeset in webkit [96242] by kov@webkit.org

• 4 edits in trunk

Second try at fixing the GTK+ build.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-09-28

Source/WebKit2:

• GNUmakefile.am:

Tools:

• GNUmakefile.am:

11:14 AM Changeset in webkit [96241] by kov@webkit.org

• 2 edits in trunk/Source/WebKit2

Try to fix GTK+ build.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-09-28

• GNUmakefile.am:

11:09 AM Changeset in webkit [96240] by imasaki@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] remove a passing test from the test expectation file.
​https://bugs.webkit.org/show_bug.cgi?id=69008

Reviewed by David Levin.

• platform/chromium/test_expectations.txt:

11:06 AM Changeset in webkit [96239] by abarth@webkit.org

• 2 edits in trunk/Source/WebCore

CSP doesn't work for a wide variety of cases
​https://bugs.webkit.org/show_bug.cgi?id=68921

Reviewed by Darin Adler.

Patch suggested by Sam Weinig. It's unclear to me how to test this
change because all our tests run on non-default ports, which is why we
have this bug in the first place. Mozilla uses a proxy while testing
so they can test with URLs like ​http://example.com, but we don't have
such a facility.

• page/ContentSecurityPolicy.cpp:

(WebCore::CSPSource::portMatches):

11:05 AM Changeset in webkit [96238] by barraclough@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Value profiling in baseline JIT for JSVALUE32_64
​https://bugs.webkit.org/show_bug.cgi?id=68750

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Geoff Garen.

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):

• jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_call_put_result):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):

• jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

10:56 AM QtWebKitReleases edited by Ademar Reis

(diff)

10:56 AM Changeset in webkit [96237] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Fix webkit2 unit tests in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=69006

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2011-09-28
Reviewed by Martin Robinson.

We are currently using the WorQueue name as thread name which in
this moment can be com.apple.WebKit.ProcessLauncher or
com.apple.CoreIPC.ReceiveQueue. Both names are longer than 31
characters which is the limit of Visual Studio for thread
names. When log is enabled createThread() will assert instead of
truncate the name, so we need to make sure we don't use a name
longer than 31 characters.

• Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::platformInitialize):

10:54 AM Changeset in webkit [96236] by mihaip@chromium.org

• 2 edits
  3 adds in trunk/LayoutTests

Rebaseline svg/filters/animate-fill.svg for Chromium.

• platform/chromium-cg-mac/svg/filters/animate-fill-expected.png: Added.
• platform/chromium-mac/svg/filters/animate-fill-expected.png: Added.
• platform/chromium-win/svg/filters/animate-fill-expected.png: Added.
• platform/chromium/test_expectations.txt:

10:46 AM Changeset in webkit [96235] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Let TestWebKitAPI and webkit_unit_tests work for chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=68680

Patch by Xianzhu Wang <​wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.

• Scripts/run-chromium-webkit-unit-tests:
• Scripts/webkitdirs.pm:

(determineBaseProductDir):

10:44 AM QtWebKit edited by Ademar Reis

(diff)

10:40 AM Changeset in webkit [96234] by commit-queue@webkit.org

• 7 edits in trunk

[Gtk] Implement textInputController.doCommand
​https://bugs.webkit.org/show_bug.cgi?id=66496

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-09-28
Reviewed by Martin Robinson.

Source/WebKit/gtk:

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::doCommand): Function definition for doCommand
callback. Converted Incoming command to match with WebCore::Editor CommandMap.

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

• DumpRenderTree/gtk/TextInputController.cpp:

(doCommandCallback): Callback function for textInputController.doCommand

LayoutTests:

Removed skipped tests under textInputController.doCommand for Gtk Port.

• platform/gtk/Skipped:

10:36 AM Changeset in webkit [96233] by fsamuel@chromium.org

• 5 edits
  1 copy in trunk/Source

[Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
​https://bugs.webkit.org/show_bug.cgi?id=68936

Reviewed by Tony Chang.

Source/WebCore:

Chromium need to be built without Gtk for future version of ChromiumOS.

• WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

• WebKit.gyp:
• public/gtk/WebFontInfo.h:
• public/linux/WebFontInfo.h: Copied from Source/WebKit/chromium/public/gtk/WebFontInfo.h.

10:35 AM QtWebKitReleases edited by Ademar Reis

(diff)

10:28 AM Changeset in webkit [96232] by levin@chromium.org

• 3 edits in trunk/Tools

watchlist: Suggest corrections for typos and improve error message consistency.
​https://bugs.webkit.org/show_bug.cgi?id=68976

Reviewed by Adam Barth.

• Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions

for typos and improve consistency of the error messages.

• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests

and improve the regex that were already present.

10:19 AM Changeset in webkit [96231] by commit-queue@webkit.org

• 8 edits in trunk

Revert change which broke displaying end script tags in view-source, instead
deal with any trailing </script> tag included by mistake in the XSSAuditor
itself. Correct tests to detect the missing close tags.
​https://bugs.webkit.org/show_bug.cgi?id=68898

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

• html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::end):

• html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

• html/parser/XSSAuditor.cpp:

(WebCore::startsHTMLEndTagAt):
(WebCore::XSSAuditor::snippetForJavaScript):

LayoutTests:

• fast/frames/resources/viewsource-frame-2.html:
• fast/frames/viewsource-plain-text-tags-expected.txt:
• fast/frames/viewsource-plain-text-tags.html:

10:15 AM Changeset in webkit [96230] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Wrong integer checks in JSVALUE32_64 DFG JIT
​https://bugs.webkit.org/show_bug.cgi?id=68985

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-09-28
Reviewed by Geoffrey Garen.

• dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

10:06 AM Changeset in webkit [96229] by abarth@webkit.org

• 2 edits
  8 deletes in trunk/Source

Remove empty directories.

Source/JavaScriptCore:

• wtf/brew: Removed.
• wtf/unicode/brew: Removed.

Source/WebCore:

• editing/brew: Removed.
• page/brew: Removed.
• platform/brew: Removed.
• platform/graphics/brew: Removed.
• platform/network/brew: Removed.
• platform/text/brew: Removed.

10:05 AM Changeset in webkit [96228] by levin@chromium.org

• 4 edits
  2 adds in trunk/Tools

watchlist: Add support for matching added or deleted lines.
​https://bugs.webkit.org/show_bug.cgi?id=68972

Reviewed by Adam Barth.

• Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
• Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
• Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input

to the pattern match to only have the diff lines instead of the DiffFile.

• Scripts/webkitpy/common/watchlist/watchlist_unittest.py:

Add tests for the new patterns and combinations of the patterns.

• Scripts/webkitpy/common/watchlist/watchlistparser.py:

Sort imports. Add changeline support.

9:57 AM Changeset in webkit [96227] by loislo@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: optional arguments support for the frontend needs to be extended.
​https://bugs.webkit.org/show_bug.cgi?id=69005

Generator supports optional arguments but they are transferred by value.
It is not suitable if the used type doesn't have operator bool.
I'll transfer such arguments by pointer.

Reviewed by Pavel Feldman.

Build is the test.

• inspector/CodeGeneratorInspector.pm:

(generateFrontendFunction):
(paramTypeTraits):

• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFailLoading):

9:24 AM Changeset in webkit [96226] by Carlos Garcia Campos

• 4 edits
  4 adds in trunk/Source/WebKit2

[GTK] Loader client implementation for WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=68085

Reviewed by Martin Robinson.

Adds a new object, WebKitWebLoaderClient, that emits signals for
every page loader callback.

• GNUmakefile.am: Add new files to compilation.
• UIProcess/API/gtk/WebKitWebLoaderClient.cpp: Added.

(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(webkitWebLoaderClientConstructed):
(webkitWebLoaderClientSetProperty):
(webkitWebLoaderClientGetProperty):
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):

• UIProcess/API/gtk/WebKitWebLoaderClient.h: Added.
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Create the loader client for the view.
(webkit_web_view_init):
(webkit_web_view_get_loader_client): Get the current loader client.
(webkit_web_view_set_loader_client): Set a new loader client.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/tests/testloading.c: Added.

(serverCallback):
(webLoadingFixtureSetup):
(webLoadingFixtureTeardown):
(getURIForPath):
(loadStatusProvisionalLoadStarted):
(loadStatusProvisionalLoadReceivedServerRedirect):
(loadStatusProvisionalLoadFailed):
(loadStatusLoadCommitted):
(loadStatusLoadFinished):
(loadStatusLoadFailed):
(testLoadingStatus):
(loadErrorProvisionalLoadStarted):
(loadErrorProvisionalLoadFailed):
(loadErrorLoadFinished):
(testLoadingError):
(main):

• UIProcess/API/gtk/webkit2marshal.list: Added.

9:20 AM Changeset in webkit [96225] by Carlos Garcia Campos

• 6 edits
  1 copy
  1 add in trunk

[GTK] Add WebKitError to GTK+ WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=68508

Reviewed by Martin Robinson.

Source/WebKit2:

Add WebKitNetworkError enum to define network errors.

• GNUmakefile.am: Add new files to compilation.
• UIProcess/API/gtk/WebKitError.cpp: Added.

(webkit_network_error_quark):

• UIProcess/API/gtk/WebKitError.h:
• UIProcess/API/gtk/WebKitPrivate.h: Add

COMPILE_ASSERT_MATCHING_ENUM macro.

• UIProcess/API/gtk/webkit2.h: Add WebKitError.h and

WebKitEnumTypes.h

Tools:

• GNUmakefile.am: Add path to webkitgtk derived sources to the

include path.

8:52 AM Changeset in webkit [96224] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Reflected attribute input.size wraps on negative values (Chrome), or
returns them (Safari).
​https://bugs.webkit.org/show_bug.cgi?id=44886

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2011-09-28
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLInputElement/input-size-attribute.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

LayoutTests:

• fast/dom/HTMLInputElement/input-size-attribute-expected.txt: Added.
• fast/dom/HTMLInputElement/input-size-attribute.html: Added.
• fast/dom/HTMLInputElement/script-tests/size-attribute.js:
• fast/dom/HTMLInputElement/size-attribute-expected.txt:

8:01 AM Changeset in webkit [96223] by vsevik@chromium.org

• 12 edits
  2 adds in trunk

Web Inspector: Add support for search in single resource to page agent.
​https://bugs.webkit.org/show_bug.cgi?id=68998

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-resource.html

• inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):

• inspector/ContentSearchUtils.h:
• inspector/Inspector.json:
• inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForSearchMatch):
(WebCore::InspectorPageAgent::searchInResource):

• inspector/InspectorPageAgent.h:
• inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.searchInContent):

• inspector/front-end/SourceFile.js:

(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

• inspector/front-end/UISourceCode.js:

(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):

LayoutTests:

• http/tests/inspector/search/search-in-resource-expected.txt: Added.
• http/tests/inspector/search/search-in-resource.html: Added.
• http/tests/inspector/search/search-in-resources.html:
• http/tests/inspector/search/search-test.js:

(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest.InspectorTest.dumpSearchMatches):
(initialize_SearchTest):

7:30 AM Changeset in webkit [96222] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
​https://bugs.webkit.org/show_bug.cgi?id=69002

Reviewed by Yury Semikhatsky.

• inspector/CodeGeneratorInspector.pm:

7:28 AM Changeset in webkit [96221] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
​https://bugs.webkit.org/show_bug.cgi?id=63396

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-09-28
Reviewed by Csaba Osztrogonác.

• platform/wk2/Skipped: Skip svg/animations/animate-from-to-keyTimes.html.

7:02 AM Changeset in webkit [96220] by Philippe Normand

• 1 edit
  4 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

• platform/gtk/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/gtk/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
• platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
• platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.

6:53 AM Changeset in webkit [96219] by podivilov@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: live edit cursor always appears at the beginning of the file.
​https://bugs.webkit.org/show_bug.cgi?id=68900

Reviewed by Pavel Feldman.

• inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):

6:41 AM Changeset in webkit [96218] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip 2 64-bits Debug crashers on GTK.

• platform/gtk/Skipped: Skip

fast/borders/inline-mask-overlay-image-outset-vertical-rl.html and plugins/js-from-destroy.html

5:35 AM Changeset in webkit [96217] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebKit/efl

[EFL] Remove *void* parameter in internal functions
​https://bugs.webkit.org/show_bug.cgi?id=68867

Reviewed by Andreas Kling.

As a step to let ewk be compliant with webkit coding style,
we need to remove *void* parameter in internal functions.

• ewk/ewk_private.h:
• ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_get):

• ewk/ewk_util.cpp:

(ewk_util_dpi_get):

5:35 AM Changeset in webkit [96216] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected file after r95745.

• platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt:

4:56 AM Changeset in webkit [96215] by vsevik@chromium.org

• 10 edits
  10 adds in trunk

Web Inspector: Refactor searching in inspector, add test (fixed non regex search).
​https://bugs.webkit.org/show_bug.cgi?id=68930

Reviewed by Yury Semikhatsky.

Source/WebCore:

Search moved out from page agent.
Fixed search for non regex case which is not yet used.

Test: http/tests/inspector/search/search-in-resources.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• inspector/ContentSearchUtils.cpp: Added.

(WebCore::ContentSearchUtils::createSearchRegexSource):
(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

• inspector/ContentSearchUtils.h: Added.
• inspector/InspectorPageAgent.cpp:

(WebCore::hasTextContent):
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::textContentForCachedResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):

• inspector/front-end/utilities.js:

():

LayoutTests:

• http/tests/inspector/search/resources/search.css: Added.

(div.searchTestUniqueString):
(div.searchTestUniqueString:hover):

• http/tests/inspector/search/resources/search.html: Added.
• http/tests/inspector/search/resources/search.js: Added.

(searchTestUniqueString):
(doSomething):

• http/tests/inspector/search/search-in-resources-expected.txt: Added.
• http/tests/inspector/search/search-in-resources.html: Added.
• http/tests/inspector/search/search-test.js: Added.

(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest):

4:25 AM Changeset in webkit [96214] by Philippe Normand

• 2 edits in trunk/Tools

[GTK] missing WebKit2 support in run-gtk-tests
​https://bugs.webkit.org/show_bug.cgi?id=68992

Rubber-stamped by Andreas Kling.

• Scripts/run-gtk-tests: Get the WebKit2 tests to run from the

webkit2 directory.

3:56 AM Changeset in webkit [96213] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit2

[GTK] Fix Programs/unittests/webkit2/testwebview
​https://bugs.webkit.org/show_bug.cgi?id=68993

Reviewed by Philippe Normand.

• GNUmakefile.am: Add -DWEBKIT_EXEC_PATH.
• UIProcess/API/gtk/tests/testwebview.c:

(main): Get WebProcess path from WEBKIT_EXEC_PATH environment
variable.

2:54 AM Changeset in webkit [96212] by commit-queue@webkit.org

• 5 edits in trunk

Implement a PopStateEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=68896

Patch by Kentaro Hara <​haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/pop-state-event-constructor.html

• bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
• dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.

• platform/chromium/test_expectations.txt:

2:45 AM Changeset in webkit [96211] by noam.rosenthal@nokia.com

• 2 edits in trunk/Source/WebCore

[Texmap] Allow TextureMapperGL to work without a GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=68980

Reviewed by Andreas Kling.

Perform a null-check for m_context and initialize that variable.
If a graphics-context doesn't exist, we don't need to reset it.

No new functionality so no new tests.

• platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):

2:42 AM Changeset in webkit [96210] by loislo@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed fix for test.

• inspector/performance/resources/inspector-startup-time.html:

2:30 AM Changeset in webkit [96209] by loislo@chromium.org

• 2 edits
  1 add in trunk/LayoutTests

Web Inspector: UI performance test for Inspector start-up time is required.
​https://bugs.webkit.org/show_bug.cgi?id=68986

Reviewed by Yury Semikhatsky.

• inspector/performance/resources/inspector-startup-time.html: Added.
• inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

2:27 AM Changeset in webkit [96208] by commit-queue@webkit.org

• 7 edits in trunk

Implement an ErrorEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=68336

Patch by Kentaro Hara <​haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/error-event-constructor.html

• bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyValue): Returns an unsigned value corresponding to a given key.

• bindings/v8/OptionsObject.h:
• bindings/v8/custom/V8EventConstructors.cpp: Added the ErrorEvent constructor.
• dom/ErrorEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled fast/events/constructors/error-event-constructor.html,
since V8 now has the constructor for ErrorEvent.

• platform/chromium/test_expectations.txt:

2:27 AM Changeset in webkit [96207] by Philippe Normand

• 3 edits in trunk/Tools

[GTK] build-webkit --no-webkit2 still builds WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=68892

Reviewed by Martin Robinson.

Take the --no-webkit2 option in account when building WebKitGTK+.

• Scripts/build-webkit:
• Scripts/webkitdirs.pm:

(buildAutotoolsProject):
(buildGtkProject):

1:47 AM Changeset in webkit [96206] by rgabor@webkit.org

• 3 edits in trunk/LayoutTests

[Qt][GTK] Skip http/tests/multipart/stop-crash.html because it fails after r96174.
​https://bugs.webkit.org/show_bug.cgi?id=68979

Reviewed by Csaba Osztrogonác.

• platform/gtk/Skipped: Skip http/tests/multipart/stop-crash.html failing
• platform/qt/Skipped: Skip http/tests/multipart/stop-crash.html failing

1:28 AM Changeset in webkit [96205] by aestes@apple.com

• 8 edits
  1 delete in trunk/Source

WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
​https://bugs.webkit.org/show_bug.cgi?id=68863

Reviewed by Darin Adler.

The SolarWalk binary does not link against WebKit.framework directly,
so calling NSVersionOfLinkTimeLibrary() will not return the version of
WebKit against which SolarWalk was linked. Since Solar Walk has
released an update that addresses the issue for which this app-specific
hack was originally added, we should just remove the hack.

Source/WebCore:

• WebCore.exp.in: Remove applicationIsSolarWalkMac().
• platform/RuntimeApplicationChecks.cpp: Ditto.
• platform/RuntimeApplicationChecks.h: Ditto.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Remove SolarWalkQuirksUserScript.js.

Source/WebKit/mac:

• Misc/SolarWalkQuirksUserScript.js: Removed.
• WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),

leakSolarWalkQuirksUserScriptContents(), and
-[WebView _injectSolarWalkQuirksScript].
(-[WebView _commonInitializationWithFrameName:groupName:]): Do not
inject the Solar Walk quirks script.

1:21 AM Changeset in webkit [96204] by rgabor@webkit.org

• 2 edits in trunk/LayoutTests

fast/canvas/crash-set-font.html failing on all platform because
getCSSCanvasContext needs 4 parameters
​https://bugs.webkit.org/show_bug.cgi?id=66291

Reviewed by Csaba Osztrogonác.

• fast/canvas/crash-set-font.html: adding the fourth parameter

1:06 AM Changeset in webkit [96203] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Fix potential SVG performance regression (over-invalidation of caches) from 96052
​https://bugs.webkit.org/show_bug.cgi?id=68941
<rdar://problem/10196224>

Reviewed by Zoltan Herczeg.

Only invalidate the cache of a filter when target style changes, as of the different types of cached
resources, only filters make use of the style of the target element and thus need to be invalidated
when the target style changes.

No new tests, performance improvement.

• rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientUpdatedFromElement):

1:02 AM Changeset in webkit [96202] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get.
​https://bugs.webkit.org/show_bug.cgi?id=65842

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.

Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get
as an optional parameter. Developer may pass NULL to skip returning the number of elements
of the requested array.

• ewk/ewk_view.cpp:

(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):

1:00 AM Changeset in webkit [96201] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68895

Unreviewed manual rebaseline for linux gpu.

• platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:

12:54 AM Changeset in webkit [96200] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
​https://bugs.webkit.org/show_bug.cgi?id=68982

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

12:46 AM Changeset in webkit [96199] by loislo@chromium.org

• 2 edits in trunk/LayoutTests

Web Inspector: Unreviewed. Slight adjustment of the test content for better representation of the performance.

• inspector/performance/resources/show-panel.html:

12:44 AM Changeset in webkit [96198] by hamaji@chromium.org

• 3 edits
  4 adds
  1 delete in trunk/LayoutTests

Unreviewed rebaseline pservers-grad-14-b again.

• platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
• platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
• platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
• platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.

12:39 AM Changeset in webkit [96197] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=68970

Unreviewed fix for a lint error in test_expectations.txt

• platform/chromium/test_expectations.txt:

12:22 AM Changeset in webkit [96196] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Missing initialization of member in ImageFrameQt class
​https://bugs.webkit.org/show_bug.cgi?id=68943

Patch by Adenilson Cavalcanti <​adenilson.silva@openbossa.org> on 2011-09-28
Reviewed by Kenneth Rohde Christiansen.

No new tests, this fixes internal implementation detail.

• platform/image-decoders/qt/ImageFrameQt.cpp:

(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):

12:12 AM Changeset in webkit [96195] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/efl

[EFL] URL of resources are not decoded.
​https://bugs.webkit.org/show_bug.cgi?id=66540

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.

Fix ewk_frame_resources_location_get which was returning the encoded URL of resources.
As a result characters for instance, %20 occurred. For now returned strings are decoded.

• ewk/ewk_frame.cpp:

(ewk_frame_resources_location_get):

12:02 AM Changeset in webkit [96194] by rniwa@webkit.org

• 3 edits in trunk/Tools

Make Chromium Win Release (Tests) a core builder
​https://bugs.webkit.org/show_bug.cgi?id=68906

Reviewed by Adam Barth.

Add Chromium Win Release (Tests) to the list of core builders.

• Scripts/webkitpy/common/net/buildbot/buildbot.py:
• Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

Sep 27, 2011:

11:46 PM Changeset in webkit [96193] by Csaba Osztrogonác

• 1 edit
  2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected result for new test introduced in r96149.

• platform/qt/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/qt/fast/multicol/float-paginate-empty-lines-expected.txt: Added.

11:32 PM Changeset in webkit [96192] by macpherson@chromium.org

• 2 edits in trunk/Source/WebCore

Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty().
​https://bugs.webkit.org/show_bug.cgi?id=68964

Reviewed by Eric Seidel.

No new tests / no functionality changed.

Doing value->isPrimitiveValue() is relatviely expensive, so moving it after the early returns but
before the result is used saves a significant number of cycles. (Tested with Shark profiler in Safari).

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:43 PM Changeset in webkit [96191] by hamaji@chromium.org

• 8 edits
  1 copy
  2 adds in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68895

Unreviewed rebaseline for skia r2300 roll.

• platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
• platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
• platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
• platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
• platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
• platform/chromium/test_expectations.txt:

10:37 PM Changeset in webkit [96190] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=68970

Unreviewed test_expectations.txt update

• platform/chromium/test_expectations.txt:

10:33 PM Changeset in webkit [96189] by fpizlo@apple.com

• 10 edits in trunk/Source/JavaScriptCore

DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
​https://bugs.webkit.org/show_bug.cgi?id=68580

Reviewed by Oliver Hunt.

This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.

With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownArray):

10:26 PM BuildingGtk edited by nayankk@motorola.com

Changed the libgail dependency to libgail-3-dev (diff)

10:23 PM Changeset in webkit [96188] by gyuyoung.kim@samsung.com

• 2 edits in trunk

Unreviewed. Fix a build error in WebKit EFL.

When web socket is disabled, there is a build break in WebKit EFL port.
Currently, web socket is enabled by default in build-webkit script.
Thus, the web socket is also enabled in EFL script of cmake build system for now.
Because, WebKit EFL developers can't work on latest WebKit trunk.

However, IMO, we should fix build errors when web socket is disabled.

• Source/cmake/OptionsEfl.cmake:

10:04 PM Changeset in webkit [96187] by rniwa@webkit.org

• 16 edits in trunk/Source/WebCore

Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
​https://bugs.webkit.org/show_bug.cgi?id=68939

Reviewed by Darin Adler.

Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.

This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
text at ends are not removed when it has a render object. Fixed the bug by checking the length of
the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)

This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.

• dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::nodeHasVisibleRenderText): Added.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.

• editing/visible_units.cpp:

(WebCore::startOfParagraph): Calls renderedTextLength.
(WebCore::endOfParagraph): Ditto.

• rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
• rendering/InlineBox.h: Ditto.
• rendering/InlineTextBox.cpp: Ditto.
• rendering/InlineTextBox.h: Ditto.
• rendering/RenderBR.cpp: Ditto.
• rendering/RenderBR.h: Ditto.
• rendering/RenderObject.cpp: Ditto.
• rendering/RenderObject.h: Ditto.
• rendering/RenderReplaced.cpp: Ditto.
• rendering/RenderReplaced.h: Ditto.
• rendering/RenderText.cpp:

(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.

• rendering/RenderText.h:

9:56 PM Changeset in webkit [96186] by commit-queue@webkit.org

• 29 edits
  1 copy
  1 add in trunk/Source/WebCore

[chromium] LayerRenderChromium asserts about leaking textures.
​https://bugs.webkit.org/show_bug.cgi?id=68190

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.

• WebCore.gypi:
• platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

• platform/graphics/chromium/Canvas2DLayerChromium.h:
• platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

• platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

• platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):

• platform/graphics/chromium/LayerTextureUpdater.h:
• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

• platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
• platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

• platform/graphics/chromium/ManagedTexture.h:
• platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

• platform/graphics/chromium/TextureManager.h:

(WebCore::TextureAllocator::~TextureAllocator):

• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

• platform/graphics/chromium/TiledLayerChromium.h:
• platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):

• platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.

(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):

• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):

• platform/graphics/chromium/VideoLayerChromium.h:
• platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

• platform/graphics/chromium/WebGLLayerChromium.h:
• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
• platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

9:03 PM Changeset in webkit [96185] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
​https://bugs.webkit.org/show_bug.cgi?id=68967

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).

Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

8:39 PM Changeset in webkit [96184] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG JIT should speculate more aggressively on reads of array.length
​https://bugs.webkit.org/show_bug.cgi?id=68932

Reviewed by Oliver Hunt.

This is a 2% speed-up on Kraken, neutral elsewhere.

• dfg/DFGNode.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:37 PM Changeset in webkit [96183] by abarth@webkit.org

• 4 edits in trunk/Tools

garden-o-matic should load faster and inform the user what is happening
​https://bugs.webkit.org/show_bug.cgi?id=68954

Reviewed by Dimitri Glazkov.

This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.

This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

7:58 PM Changeset in webkit [96182] by crogers@google.com

• 1 edit
  2 adds in trunk/LayoutTests

Add layout test for WaveShaperNode
​https://bugs.webkit.org/show_bug.cgi?id=68925

Reviewed by Kenneth Russell.

• webaudio/waveshaper-expected.txt: Added.
• webaudio/waveshaper.html: Added.

7:48 PM Changeset in webkit [96181] by abarth@webkit.org

• 2 edits in trunk/Tools

garden-o-matic should show the first result when examining results
​https://bugs.webkit.org/show_bug.cgi?id=68960

Reviewed by Dimitri Glazkov.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:

7:30 PM Changeset in webkit [96180] by commit-queue@webkit.org

• 5 edits in trunk

Implement a PageTransitionEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=68067

Patch by Kentaro Hara <​haraken@chromium.com> on 2011-09-27
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/page-transition-event-constructor.html

• bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
• dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.

• platform/chromium/test_expectations.txt:

7:02 PM Changeset in webkit [96179] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk

Implement a MessageEvent constructor for JSC
​https://bugs.webkit.org/show_bug.cgi?id=68883

Patch by Kentaro Hara <​haraken@chromium.org> on 2011-09-27
Reviewed by Adam Barth.

Source/WebCore:

The spec for MessageEvent is here:
​http://www.whatwg.org/specs/web-apps/current-work/#messageevent

Currently, some tests in fast/events/constructors/message-event-constructor.html
are failing or crashing in DRT, as we commented in the test file.
This is because MessageEvent.data is implemented as SerializedScriptValue,
and thus it cannot keep ScriptValue passed by JavaScript.
This is the same issue as the bug (​https://bugs.webkit.org/show_bug.cgi?id=68345).
We will soon make a follow-up patch to fix these failures, after this
patch is landed.

Test: fast/events/constructors/message-event-constructor.html

• bindings/generic/EventConstructors.h: Added a definition for the MessageEvent constructor.
• bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Generates MessagePortArray from the list of message ports in the format of JSValues.

• bindings/js/JSDictionary.h:
• bindings/js/JSEventConstructors.cpp: Added #includes for MessageEvent.
• dom/MessageEvent.cpp:

(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

• dom/MessageEvent.h: Added a definition for MessageEvent. Removed an extra leading spaces.

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::origin):
(WebCore::MessageEvent::lastEventId):
(WebCore::MessageEvent::source):
(WebCore::MessageEvent::ports):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):

• dom/MessageEvent.idl: Makes MessageEvent constructible.

LayoutTests:

message-event-constructor.html checks the behavior of the MessageEvent constructor.

• fast/dom/constructed-objects-prototypes-expected.txt: Now window has MessageEvent.
• fast/events/constructors/message-event-constructor-expected.txt: Added.
• fast/events/constructors/message-event-constructor.html: Added.
• platform/chromium/test_expectations.txt: Skipped message-event-constructor.html, since V8 does not yet have the MessageEvent constructor.

6:52 PM Changeset in webkit [96178] by barraclough@apple.com

• 3 edits in trunk/Source/JavaScriptCore

DFG JIT - merge changes between 95905 - 96175
​https://bugs.webkit.org/show_bug.cgi?id=68963

Reviewed by Sam Weinig.

Merge missing changes from bug#68677, bug#68784, bug#68785.

• dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:46 PM Changeset in webkit [96177] by ericu@chromium.org

• 5 edits
  1 copy
  8 adds in trunk

[Chromium/FileWriter] race condition in FileWriter completion can lead to assert
​https://bugs.webkit.org/show_bug.cgi?id=67684

Reviewed by David Levin.

Source/WebCore:

Tests: fast/filesystem/file-writer-abort-continue.html

fast/filesystem/file-writer-abort.html

Track the state of the backend and be prepared for reentrant user
requests. Limit recursion depth to an arbitrary small constant.

• fileapi/FileWriter.cpp: Lots of event-handling changes.
• fileapi/FileWriter.h:

LayoutTests:

• fast/filesystem/file-writer-abort-continue-expected.txt: Added.
• fast/filesystem/file-writer-abort-continue.html: Added.
• fast/filesystem/file-writer-abort-expected.txt: Added.
• fast/filesystem/file-writer-abort.html: Added.
• fast/filesystem/resources/file-writer-abort-continue.js: Added.
• fast/filesystem/resources/file-writer-abort.js: Added.
• fast/filesystem/resources/file-writer-events.js: Fixed a copy-paste error.

6:12 PM Changeset in webkit [96176] by timothy_horton@apple.com

• 7 edits in trunk/LayoutTests

svg/custom/oversized-pattern-scale.svg is useless because the interesting part of the test is off the screen
​https://bugs.webkit.org/show_bug.cgi?id=68945

Reviewed by Darin Adler.

Change oversized-pattern-scale so that the interesting part of the pattern is on the screen,
and so that it doesn't draw a scrollbar (making it platform-independent).

Change transformed-pattern-clamp-svg-root so that it doesn't draw a gradient, making it platform-independent.

• svg/custom/oversized-pattern-scale-expected.png:
• svg/custom/oversized-pattern-scale-expected.txt:
• svg/custom/oversized-pattern-scale.svg:
• svg/custom/transformed-pattern-clamp-svg-root-expected.png:
• svg/custom/transformed-pattern-clamp-svg-root-expected.txt:
• svg/custom/transformed-pattern-clamp-svg-root.svg:

6:09 PM Changeset in webkit [96175] by barraclough@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Get JSVALUE32_64 DFG JIT building on OS X.
​https://bugs.webkit.org/show_bug.cgi?id=68961

Reviewed by Geoff Garen.

• Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
• Forward-declare functions in DFGOperations.cpp
• UNUSED_PARAM for unused arguments
• NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
• Fix argument types handled by OpInfo constructor.
• Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
• Add files to Xcode project.

6:01 PM Changeset in webkit [96174] by tony@chromium.org

• 3 edits in trunk/LayoutTests

http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
​https://bugs.webkit.org/show_bug.cgi?id=34222

Reviewed by Ryosuke Niwa.

Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).

• http/tests/multipart/stop-crash-expected.txt:
• http/tests/multipart/stop-crash.html:

5:25 PM Changeset in webkit [96173] by mihaip@chromium.org

• 29 edits
  3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r96141.
​http://trac.webkit.org/changeset/96141
​https://bugs.webkit.org/show_bug.cgi?id=68190

Breaks PrerenderBrowserTest.PrerenderHTML5Video in
browser_tests

• WebCore.gypi:
• platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

• platform/graphics/chromium/Canvas2DLayerChromium.h:
• platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

• platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::createLayerTexture):
(WebCore::LayerRendererChromium::deleteLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

• platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):

• platform/graphics/chromium/LayerTextureUpdater.h:
• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

• platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
• platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

• platform/graphics/chromium/ManagedTexture.h:
• platform/graphics/chromium/TextureManager.cpp:

(WebCore::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

• platform/graphics/chromium/TextureManager.h:
• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

• platform/graphics/chromium/TiledLayerChromium.h:
• platform/graphics/chromium/TrackingTextureAllocator.cpp: Removed.
• platform/graphics/chromium/TrackingTextureAllocator.h: Removed.
• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):

• platform/graphics/chromium/VideoLayerChromium.h:
• platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

• platform/graphics/chromium/WebGLLayerChromium.h:
• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp.rej: Removed.
• platform/graphics/chromium/cc/CCLayerTreeHost.h:
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
• platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

4:51 PM Changeset in webkit [96172] by jamesr@google.com

• 4 edits in trunk/Source/WebCore

[chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
​https://bugs.webkit.org/show_bug.cgi?id=68953

Reviewed by Kenneth Russell.

The accelerated drawing code is incompatible with threaded compositing. Rather than tying the two behaviors
together via USE(THREADED_COMPOSITING), this patch guards the accelerated drawing code with its own USE() guard
so the features can advance independently. Today, it's not safe to set both of these flags.

• platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
• platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

4:48 PM Changeset in webkit [96171] by barraclough@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
​https://bugs.webkit.org/show_bug.cgi?id=68755

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Gavin Barraclough.

We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.

• bytecode/StructureStubInfo.h:
• dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

• dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:42 PM Changeset in webkit [96170] by levin@chromium.org

• 4 edits
  2 copies in trunk/Tools

watchlist: Add support for cc and message rules.
​https://bugs.webkit.org/show_bug.cgi?id=68950

Reviewed by Adam Barth.

• Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get

the cc's and messages for a patch.

• Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
• Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support

for the rules.

• Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.

A generic encapsulation of either a message list or a cc list.

• Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.

4:32 PM Changeset in webkit [96169] by barraclough@apple.com

• 8 edits in trunk/Source/JavaScriptCore

Macro assembler branch8 & 16 methods vary in treatment of upper bits
​https://bugs.webkit.org/show_bug.cgi?id=68301

Reviewed by Sam Weinig.

Fix for branch16 - remove it!
No performance impact.

• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.h:
• assembler/MacroAssemblerARMv7.h:
• assembler/MacroAssemblerMIPS.h:
• assembler/MacroAssemblerSH4.h:
• assembler/MacroAssemblerX86Common.h:
• yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):

4:24 PM Changeset in webkit [96168] by macpherson@chromium.org

• 3 edits in trunk/Source/WebCore

Slightly improve performance of CSSStyleApplyProperty handler lookup.
​https://bugs.webkit.org/show_bug.cgi?id=68868

Reviewed by Eric Seidel.

No new tests as no functionality changed.

• css/CSSStyleApplyProperty.h:

(WebCore::CSSStyleApplyProperty::propertyHandler):
Make propertyHandler() public and remove redirecting functions.

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Perform property handler lookup once and reuse the result.

4:11 PM Changeset in webkit [96167] by mihaip@chromium.org

• 1 edit
  4 adds in trunk/LayoutTests

Chromium baselines for fast/multicol/float-paginate-empty-lines.html
after r96149 and 96162.

• platform/chromium-linux/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/chromium-mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.txt: Added.

4:05 PM Changeset in webkit [96166] by tkent@chromium.org

• 5 edits in trunk

[V8] element.dataset.nonExistingKey should return undefined.
​https://bugs.webkit.org/show_bug.cgi?id=68877

Reviewed by Nate Chapin.

Source/WebCore:

• bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().

LayoutTests:

• fast/dom/dataset-expected.txt: Updated.
• fast/dom/script-tests/dataset.js: Add a test case.

3:53 PM Changeset in webkit [96165] by mihaip@chromium.org

• 2 edits
  6 adds
  2 deletes in trunk/LayoutTests

Chromium rebaseline after r96155.

• platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
• platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
• platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
• platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
• platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
• platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
• platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
• platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
• platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.

3:46 PM Changeset in webkit [96164] by mhahnenberg@apple.com

• 74 edits in trunk/Source

Source/JavaScriptCore: Add static version of JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=68741

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.

• API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::getCallDataVirtual):
(JSC::JSCallbackFunction::getCallData):

• API/JSCallbackFunction.h:
• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h:

(JSC::::getCallDataVirtual):
(JSC::::getCallData):

• API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getCallDataVirtual):
(JSC::ArrayConstructor::getCallData):

• runtime/ArrayConstructor.h:
• runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getCallDataVirtual):
(JSC::BooleanConstructor::getCallData):

• runtime/BooleanConstructor.h:
• runtime/DateConstructor.cpp:

(JSC::DateConstructor::getCallDataVirtual):
(JSC::DateConstructor::getCallData):

• runtime/DateConstructor.h:
• runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):

• runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getCallDataVirtual):
(JSC::ErrorConstructor::getCallData):

• runtime/ErrorConstructor.h:
• runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getCallDataVirtual):
(JSC::FunctionConstructor::getCallData):

• runtime/FunctionConstructor.h:
• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::getCallDataVirtual):
(JSC::FunctionPrototype::getCallData):

• runtime/FunctionPrototype.h:
• runtime/InternalFunction.h:
• runtime/JSCell.cpp:

(JSC::JSCell::getCallDataVirtual):
(JSC::JSCell::getCallData):

• runtime/JSCell.h:

(JSC::getCallData):

• runtime/JSFunction.cpp:

(JSC::JSFunction::getCallDataVirtual):
(JSC::JSFunction::getCallData):

• runtime/JSFunction.h:
• runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):

• runtime/JSObject.cpp:

(JSC::JSObject::put):

• runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getCallDataVirtual):
(JSC::NativeErrorConstructor::getCallData):

• runtime/NativeErrorConstructor.h:
• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getCallDataVirtual):
(JSC::NumberConstructor::getCallData):

• runtime/NumberConstructor.h:
• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getCallDataVirtual):
(JSC::ObjectConstructor::getCallData):

• runtime/ObjectConstructor.h:
• runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):

• runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

• runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getCallDataVirtual):
(JSC::RegExpConstructor::getCallData):

• runtime/RegExpConstructor.h:
• runtime/StringConstructor.cpp:

(JSC::StringConstructor::getCallDataVirtual):
(JSC::StringConstructor::getCallData):

• runtime/StringConstructor.h:

Source/JavaScriptGlue: Add static version of JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=68741

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.

• JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCallFunction):

• UserObjectImp.cpp:

(UserObjectImp::getCallDataVirtual):
(UserObjectImp::getCallData):

• UserObjectImp.h:

Source/WebCore: Add static version of JSCell::visitChildren
​https://bugs.webkit.org/show_bug.cgi?id=68404

Reviewed by Darin Adler.

No new tests.

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

• WebCore.exp.in:
• bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):

• bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):

• bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):

• bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):

• bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):

• bindings/js/JSDOMGlobalObject.h:
• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):

• bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):

• bindings/js/JSDOMWindowShell.h:
• bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):

• bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):

• bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):

• bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):

• bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):

• bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):

• bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):

• bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):

• bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):

• bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):

• bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):

• bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):

• bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):

• bindings/scripts/test/JS/JSTestObj.h:
• bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):

• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):

• bridge/qt/qt_runtime.h:
• workers/WorkerContext.h:

Source/WebKit/mac: Add static version of JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=68741

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2: Add static version of JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=68741

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.

• WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::getCallDataVirtual):
(WebKit::JSNPMethod::getCallData):

• WebProcess/Plugins/Netscape/JSNPMethod.h:
• WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallDataVirtual):
(WebKit::JSNPObject::getCallData):

• WebProcess/Plugins/Netscape/JSNPObject.h:

3:43 PM Changeset in webkit [96163] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove duplicate FilterOperation{s}.h that were
accidentally added to the top level of the Xcode project.

• WebCore.xcodeproj/project.pbxproj:

3:11 PM Changeset in webkit [96162] by hyatt@apple.com

• 5 edits
  1 add in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68940

Narrow the float/lines pagination heuristic to only kick in if
the previous line broke cleanly and if the floats are occurring
at the start of the line.

Reviewed by Dan Bernstein.

Source/WebCore:

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

LayoutTests:

• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
• platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:

3:04 PM Changeset in webkit [96161] by commit-queue@webkit.org

• 2 edits in trunk/Tools

webkit-patch doesn't like UTF-8 characters in reviewers names
​https://bugs.webkit.org/show_bug.cgi?id=63452

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-27
Reviewed by Eric Seidel.

• Scripts/webkit-patch:

2:47 PM Changeset in webkit [96160] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Add a mechanism to test for the compositing tree mutated during painting
​https://bugs.webkit.org/show_bug.cgi?id=68738

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-27
Reviewed by Adam Barth.

Source/WebCore:

Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.

Test: compositing/video/video-with-invalid-source.html

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

LayoutTests:

Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.

• compositing/video/video-with-invalid-source-expected.txt: Added.
• compositing/video/video-with-invalid-source.html: Added.

2:45 PM Changeset in webkit [96159] by ojan@chromium.org

• 6 edits in trunk

take padding/border on flexbox into account with direction:rtl
​https://bugs.webkit.org/show_bug.cgi?id=68846

Reviewed by David Hyatt.

Source/WebCore:

Use the logicalWidth of the flexbox instead of it's availableLogicalWidth
so that we include the flexbox's border and padding.

Also, change all uses of availableLogicalWidth to contentLogicalWidth.
The former takes multi-column into account. Multi-column flexboxes don't
make any sense, so there's no point in calling availableLogicalWidth.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

• rendering/RenderFlexibleBox.h:

LayoutTests:

• css3/flexbox/writing-modes-expected.txt:
• css3/flexbox/writing-modes.html:

2:43 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:41 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:31 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:30 PM QtWebKitReleases edited by Ademar Reis

(diff)

2:29 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:25 PM Changeset in webkit [96158] by mihaip@chromium.org

• 2 edits in trunk/LayoutTests

Chromium test expectations update.

Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.

• platform/chromium/test_expectations.txt:

2:23 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:20 PM QtWebKitReleases edited by Ademar Reis

(diff)

2:19 PM Changeset in webkit [96157] by commit-queue@webkit.org

• 4 edits
  2 deletes in trunk

Unreviewed, rolling out r96139.
​http://trac.webkit.org/changeset/96139
​https://bugs.webkit.org/show_bug.cgi?id=68933

Broke table-percent-height.html on Mac bots (Requested by
mwenge2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

Source/WebCore:

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

• rendering/RenderBox.h:

LayoutTests:

• fast/replaced/table-percent-width-expected.txt: Removed.
• fast/replaced/table-percent-width.html: Removed.

2:17 PM QtWebKitReleases edited by Ademar Reis

(diff)

2:13 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:12 PM Changeset in webkit [96156] by reed@google.com

• 2 edits in trunk/LayoutTests

need to rebseline these once new aa-gdi-text code lands in skia
​https://bugs.webkit.org/show_bug.cgi?id=68920

Reviewed by Kenneth Russell.

• platform/chromium/test_expectations.txt:

2:08 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:06 PM QtWebKitSecurity edited by Ademar Reis

(diff)

2:06 PM Changeset in webkit [96155] by timothy_horton@apple.com

• 14 edits
  6 adds in trunk

REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
​https://bugs.webkit.org/show_bug.cgi?id=67700
<rdar://problem/10125102>

Reviewed by Darin Adler.

Clamp all resources to the same size, 4096x4096 (arbitrarily chosen), instead of to the size
of the <svg> element. This fixes the case where a transformed element displays part of a resource
outside of the size of the <svg> element.

When drawing an oversized pattern into its tile image, scale the content down to fit. When drawing
the tile image to the screen, scale it back up to fit the expected area. This will cause pixelation
when patterns are over the 4k limit.

Tests: svg/custom/transformed-pattern-clamp-svg-root.svg, svg/custom/oversized-pattern-scale.svg

• rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

• rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):

• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):

• rendering/svg/RenderSVGResourcePattern.h:
• rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRect):

• rendering/svg/SVGImageBufferTools.h:

pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is
still very excessive but easier to draw with.

Add a test (transformed-pattern-clamp-svg-root.svg) that ensures that patterns on transformed
elements are displayed correctly, instead of being clamped to the size of the <svg> element.

Add a test (oversized-pattern-scale.svg) that ensures that oversized patterns are correctly drawn
into the pattern tile scaled down and then are scaled back up when drawn to the screen.

• platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
• platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
• svg/custom/pattern-excessive-malloc-expected.txt:
• svg/custom/pattern-excessive-malloc.svg:
• svg/custom/oversized-pattern-scale-expected.png: Added.
• svg/custom/oversized-pattern-scale-expected.txt: Added.
• svg/custom/oversized-pattern-scale.svg: Added.
• svg/custom/transformed-pattern-clamp-svg-root.svg: Added.
• svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
• svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added.

2:04 PM Changeset in webkit [96154] by mitz@apple.com

• 3 edits
  2 adds in trunk

<rdar://problem/10098679> Assertion failure in RenderLayer::paintPaginatedChildLayer()

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/layer-no-longer-paginated.html

FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.

LayoutTests:

• fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
• fast/dynamic/layer-no-longer-paginated.html: Added.

2:02 PM Changeset in webkit [96153] by abarth@webkit.org

• 5 edits
  1 add in trunk/Tools

garden-o-matic examine buttons shows both expected and unexpected failures
​https://bugs.webkit.org/show_bug.cgi?id=68918

Reviewed by Dimitri Glazkov.

This was a copy/paste error when I refactored this classes to share
more code.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:

1:55 PM Changeset in webkit [96152] by ojan@chromium.org

• 8 edits
  2 adds in trunk

offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
​https://bugs.webkit.org/show_bug.cgi?id=68304

Reviewed by David Hyatt.

Source/WebCore:

When grabbing the x/y values of the RenderBox, we need to take writing mode
flipping into account.

Test: fast/dom/offset-position-writing-modes.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::locationIncludingFlipping):

• rendering/RenderBox.h:

(WebCore::RenderBox::yFlippedForWritingMode):
(WebCore::RenderBox::xFlippedForWritingMode):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

• css3/flexbox/writing-modes-expected.txt:
• css3/flexbox/writing-modes.html:
• fast/dom/offset-position-writing-modes-expected.txt: Added.
• fast/dom/offset-position-writing-modes.html: Added.

1:54 PM Changeset in webkit [96151] by timothy_horton@apple.com

• 6 edits
  3 adds in trunk

Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
​https://bugs.webkit.org/show_bug.cgi?id=68816
<rdar://problem/10186468>

Reviewed by Simon Fraser.

If a filter returns without writing into its result buffer, make sure to return an cleared buffer.

Test: svg/filters/feMorphology-zero-radius.svg

1:51 PM Changeset in webkit [96150] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

CompositeEditCommand::prune should remove subtree at once
​https://bugs.webkit.org/show_bug.cgi?id=68866

Reviewed by Darin Adler.

Extracted the logic to find the highest ancestor to remove as highestNodeToRemoveInPruning from prune.
This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.

• editing/CompositeEditCommand.cpp:

(WebCore::hasARenderedDescendant): Takes excludedNode in addition to node. excludedNode is used to ignore
the child node from which we climbed up the tree in highestNodeToRemoveInPruning.
(WebCore::highestNodeToRemoveInPruning): Extracted from prune.
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

1:39 PM Changeset in webkit [96149] by hyatt@apple.com

• 4 edits
  5 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68922

Source/WebCore:

Paginated floats should not grow the height of a block when they don't end
up being tied to a line. Floats encountered in skipLeadingWhitespace that
paginate can't immediately grow the height of the block, since there may not
end up being any actual line content. We only want to push the height of the
block down if we have actual line content that we want to keep with the
float.

Make positionNewFloatOnLine check if the line is empty or not, and if it is,
it just puts the desired pagination strut into LineInfo. If and when actual
line content is encountered and setEmpty becomes false, we'll grow the block
height then.

Reviewed by Dan Bernstein.

Added fast/multicol/float-paginate-empty-lines.html and
fast/regions/webkit-flow-double-pagination-float-push.html.

• rendering/RenderBlock.h:
• rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setFloatPaginationStrut):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::positionNewFloatOnLine):

LayoutTests:

Paginated floats should not grow the height of a block when they don't end
up being tied to a line.

Reviewed by Dan Bernstein.

• fast/multicol/float-paginate-empty-lines.html: Added.
• fast/regions/webkit-flow-double-pagination-float-push.html: Added.
• platform/mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.

1:35 PM QtWebKitSecurity edited by Ademar Reis

(diff)

1:34 PM QtWebKitSecurity edited by Ademar Reis

(diff)

1:29 PM Changeset in webkit [96148] by rniwa@webkit.org

• 2 edits in trunk/Tools

Add Kaustubh Atrawalkar to the list of contributors.

• Scripts/webkitpy/common/config/committers.py:

1:28 PM QtWebKitSecurity edited by Ademar Reis

(diff)

1:24 PM Changeset in webkit [96147] by mihaip@chromium.org

• 2 edits in trunk/Tools

[Chromium] Fixed layout mode tests break subsequent tests
​https://bugs.webkit.org/show_bug.cgi?id=68923

Reviewed by Adam Barth.

Reset fixed layout mode between tests, so that tests that run after
platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
regular 800x600 non-fixed layout.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

1:16 PM Changeset in webkit [96146] by commit-queue@webkit.org

• 14 edits
  3 deletes in trunk

Unreviewed, rolling out r96131.
​http://trac.webkit.org/changeset/96131
​https://bugs.webkit.org/show_bug.cgi?id=68927

It made 18+ tests crash on all platform (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

Source/JavaScriptCore:

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

• interpreter/Interpreter.h:
• jsc.cpp:

(GlobalObject::finishCreation):

• parser/Parser.h:

(JSC::Parser::parse):

• runtime/CommonIdentifiers.h:
• runtime/Error.cpp:

(JSC::addErrorInfo):

• runtime/Error.h:

LayoutTests:

• fast/js/exception-properties-expected.txt:
• fast/js/script-tests/exception-properties.js:
• fast/js/script-tests/stack-trace.js: Removed.
• fast/js/stack-trace-expected.txt: Removed.
• fast/js/stack-trace.html: Removed.
• platform/chromium/test_expectations.txt:

1:05 PM Changeset in webkit [96145] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Source/WebKit2

[Qt] QDesktopWebView load zero size view test missing
​https://bugs.webkit.org/show_bug.cgi?id=68655

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-09-27
Reviewed by Chang Shu.

Added test case to check load behavior with zero size view.

• UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Added.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:

12:55 PM Changeset in webkit [96144] by levin@chromium.org

• 4 edits
  3 copies in trunk/Tools

watchlist: Add the filename pattern for definitions.
​https://bugs.webkit.org/show_bug.cgi?id=68917

Reviewed by Adam Barth.

• Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
• Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
• Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern

for definitions.

• Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.

12:53 PM Changeset in webkit [96143] by mhahnenberg@apple.com

• 11 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::getPrimitiveNumber
​https://bugs.webkit.org/show_bug.cgi?id=68851

Reviewed by Darin Adler.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Changed JSCell::getPrimitiveNumber to manually handle the dispatch for
JSCells (JSObject and JSString in this case).

• runtime/JSCell.cpp:

(JSC::JSCell::getPrimitiveNumber):

• runtime/JSCell.h:

Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't
matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
can cover the case for JSNotAnObject.

• runtime/JSNotAnObject.cpp:
• runtime/JSNotAnObject.h:

De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber
and changed them to be const. Also made JSString::getPrimitiveNumber public
because it needs to be called from JSCell::getPrimitiveNumber and also since it's
no longer virtual, we want people who have a more specific pointer (JSString*
instead of JSCell*) to not have to pay the cost of a virtual method call.

• runtime/JSObject.cpp:

(JSC::JSObject::getPrimitiveNumber):

• runtime/JSObject.h:
• runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber):

• runtime/JSString.h:

12:49 PM Changeset in webkit [96142] by dino@apple.com

• 12 edits
  3 copies
  2 adds in trunk/Source/WebCore

Add 'filter' value to RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=68471

Reviewed by Simon Fraser.

Add a filter property to RenderStyle when ENABLE(CSS_FILTERS)
is turned on. Similar to -webkit-transform, -webkit-filter is a
list of FilterOperations, each identifying what type of operation
it is. This change simply adds the basic objects, it does not
parse the property to generate the list.

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/filters/FilterOperation.h: Added.

(WebCore::FilterOperation::~FilterOperation):
(WebCore::FilterOperation::operator!=):
(WebCore::FilterOperation::getOperationType):
(WebCore::FilterOperation::isSameType):
(WebCore::FilterOperation::FilterOperation):
(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::reference):
(WebCore::ReferenceFilterOperation::operator==):
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::BasicColorMatrixFilterOperation::create):
(WebCore::BasicColorMatrixFilterOperation::amount):
(WebCore::BasicColorMatrixFilterOperation::operator==):
(WebCore::BasicColorMatrixFilterOperation::BasicColorMatrixFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::create):
(WebCore::BasicComponentTransferFilterOperation::amount):
(WebCore::BasicComponentTransferFilterOperation::operator==):
(WebCore::BasicComponentTransferFilterOperation::BasicComponentTransferFilterOperation):
(WebCore::GammaFilterOperation::create):
(WebCore::GammaFilterOperation::amplitude):
(WebCore::GammaFilterOperation::exponent):
(WebCore::GammaFilterOperation::offset):
(WebCore::GammaFilterOperation::operator==):
(WebCore::GammaFilterOperation::GammaFilterOperation):
(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::operator==):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::amount):
(WebCore::SharpenFilterOperation::operator==):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):
(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::shadow):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):

• platform/graphics/filters/FilterOperations.cpp: Added.

(WebCore::FilterOperations::FilterOperations):
(WebCore::FilterOperations::operator==):

• platform/graphics/filters/FilterOperations.h: Added.

(WebCore::FilterOperations::operator!=):
(WebCore::FilterOperations::clear):
(WebCore::FilterOperations::operations):
(WebCore::FilterOperations::size):
(WebCore::FilterOperations::at):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

• rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::filter):
(WebCore::InheritedFlags::hasFilter):
(WebCore::InheritedFlags::setFilter):
(WebCore::InheritedFlags::initialFilter):

• rendering/style/StyleAllInOne.cpp: Added include of new StyleFilterData.
• rendering/style/StyleFilterData.cpp: Added.

(WebCore::StyleFilterData::StyleFilterData):
(WebCore::StyleFilterData::operator==):

• rendering/style/StyleFilterData.h: Added.

(WebCore::StyleFilterData::create):
(WebCore::StyleFilterData::copy):
(WebCore::StyleFilterData::operator!=):

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h: New filter DataRef.

12:41 PM Changeset in webkit [96141] by jamesr@google.com

• 29 edits
  1 copy
  2 adds in trunk/Source/WebCore

[chromium] LayerRenderChromium asserts about leaking textures.
​https://bugs.webkit.org/show_bug.cgi?id=68190

Reviewed by Kenneth Russell.

This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.

• WebCore.gypi:
• platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

• platform/graphics/chromium/Canvas2DLayerChromium.h:
• platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

• platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::updateCompositorResources):

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

• platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):

• platform/graphics/chromium/LayerTextureUpdater.h:
• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

• platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
• platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

• platform/graphics/chromium/ManagedTexture.h:
• platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

• platform/graphics/chromium/TextureManager.h:

(WebCore::TextureAllocator::~TextureAllocator):

• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

• platform/graphics/chromium/TiledLayerChromium.h:
• platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):

• platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.

(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):

• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):

• platform/graphics/chromium/VideoLayerChromium.h:
• platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

• platform/graphics/chromium/WebGLLayerChromium.h:
• platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
• platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

12:34 PM Changeset in webkit [96140] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/efl

[EFL] Make ewk_view emit the "load,document,finished" signal.
​https://bugs.webkit.org/show_bug.cgi?id=66782

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-27
Reviewed by Antonio Gomes.

Currently, only ewk_frame emits the "load,document,finished" signal
when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
ewk_frame_load_document_finished().

However, in some cases it is not even possible to connect to the
"frame,created" signal to properly monitor the
"load,document,finished" signal, as the former is not emitted.
fast/frames/frame-unload-crash.html, for example, has a page with an
iframe inside an iframe, and this innermost iframe does not seem to be
loaded via FrameLoaderClientEfl::createFrame (which calls all the
machinery which then emits the "frame,created" signal).

We now make ewk_frame_load_document_finished() call the newly-created
ewk_view_load_document_finished() function, whose job is to emit the
"load,document,signal" with the frame as its parameter. This way, one
can just connect to the view and make sure all the signals will get
delivered.

• ewk/ewk_frame.cpp:

(ewk_frame_load_document_finished):

• ewk/ewk_private.h:
• ewk/ewk_view.cpp:

(ewk_view_load_document_finished):

• ewk/ewk_view.h:

12:31 PM Changeset in webkit [96139] by robert@webkit.org

• 4 edits
  2 adds in trunk

Reviewed by David Hyatt.

Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
​https://bugs.webkit.org/show_bug.cgi?id=29447

Source/WebCore:

If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.

Test: fast/replaced/table-percent-width.html

• rendering/RenderBox.cpp:

(WebCore::avoidSqueezingWidth):
(WebCore::avoidSqueezingHeight):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

• rendering/RenderBox.h:

LayoutTests:

• fast/replaced/table-percent-width.html: Added.
• fast/replaced/table-percent-width-expected.txt: Added.

12:00 PM Changeset in webkit [96138] by Simon Fraser

• 9 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=67858

Roll r96070 back in now that the crash has been fixed in r96130.

Source/WebCore:

Reviewed by Darin Adler.

When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.

Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.

Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).

• page/FrameView.cpp:

(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().

• platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.

• platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches

invalidateScrollbar().

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().

• rendering/RenderScrollbarPart.cpp: Ditto.

(WebCore::RenderScrollbarPart::imageChanged): Ditto.

LayoutTests:

• compositing/iframes/repaint-after-losing-scrollbars-expected.png:

11:44 AM Changeset in webkit [96137] by mihaip@chromium.org

• 2 edits in trunk/Source/WebCore

Fix Chromium Mac build after r96130.

• page/FrameView.cpp:

(WebCore::FrameView::layerForOverhangAreas):

11:32 AM Changeset in webkit [96136] by Carlos Garcia Campos

• 5 edits
  3 adds in trunk/Source/WebKit2

[GTK] Use WebKitWebContext in WebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=67990

Reviewed by Martin Robinson.

Use webkit_web_context_get_default() instead of
WKContextGetSharedProcessContext() and add API to create a view
with a given web context and to return the current context
associated to the view.

• GNUmakefile.am: Add new files to compilation.
• UIProcess/API/gtk/WebKitPrivate.h: Added.
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextGetWKContext): Private API to get the WKContext
wrapped by the WebKitWebContext.

• UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Create the webpage using the web
context of the view.
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_init):
(webkit_web_view_class_init):
(webkit_web_view_new): Create a new view with the default context.
(webkit_web_view_new_with_context): Create a new view with the
given context.
(webkit_web_view_get_context): Return the context.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/tests/testwebview.c: Added.

(testWebViewDefaultContext):
(main):

11:19 AM Changeset in webkit [96135] by commit-queue@webkit.org

• 2 edits in trunk

[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.

Install the flag, which indicates whether or not the optimization
script was executed, on the global object.

​https://bugs.webkit.org/show_bug.cgi?id=68890

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

• Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

11:17 AM Changeset in webkit [96134] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Autofocus on readonly inputs does not focus the element.
​https://bugs.webkit.org/show_bug.cgi?id=24092

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-09-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Readonly input elements should be autofocusable. Removed the check.

Tests: fast/forms/autofocus-readonly-attribute.html

• html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

LayoutTests:

• fast/forms/autofocus-readonly-attribute-expected.txt: Added.
• fast/forms/autofocus-readonly-attribute.html: Added.

11:06 AM Changeset in webkit [96133] by Carlos Garcia Campos

• 3 edits
  1 copy
  3 adds in trunk/Source/WebKit2

[GTK] Add WebKitWebContext to GTK API
​https://bugs.webkit.org/show_bug.cgi?id=67931

Reviewed by Philippe Normand.

Initial implementation of WebKitWebContext for WebKit2 GTK API.

• GNUmakefile.am: Add new files to compilation.
• UIProcess/API/gtk/WebKitWebContext.cpp: Added.

(webkitWebContextFinalize):
(webkit_web_context_init):
(webkit_web_context_class_init):
(createDefaultWebContext):
(webkit_web_context_get_default):

• UIProcess/API/gtk/WebKitWebContext.h: Added.
• UIProcess/API/gtk/tests/testwebcontext.c:

(testWebContextDefault):
(main):

• UIProcess/API/gtk/webkit2.h: Add <webkit2/WebKitWebContext.h>.

11:04 AM Changeset in webkit [96132] by mihaip@chromium.org

• 1 edit
  1 delete in trunk/LayoutTests

Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
​https://bugs.webkit.org/show_bug.cgi?id=68915

Reviewed by Ryosuke Niwa.

r92496 and r92881 were only trying to move the baselines to
platform/mac-snowleopard/platform/mac/fast, but they also inadvertedly
copied the test itself.

• platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.

10:58 AM Changeset in webkit [96131] by commit-queue@webkit.org

• 14 edits
  3 adds in trunk

Implement Error.stack
​https://bugs.webkit.org/show_bug.cgi?id=66994

Patch by Juan Carlos Montemayor Elosua <​j.mont@me.com> on 2011-09-27
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• interpreter/Interpreter.cpp:

(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):

• interpreter/Interpreter.h:

(JSC::StackFrame::toString):

• jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCStack):

• parser/Parser.h:

(JSC::Parser::parse):

• runtime/CommonIdentifiers.h:
• runtime/Error.cpp:

(JSC::addErrorInfo):

• runtime/Error.h:

LayoutTests:

Unit tests that contain both normal and special cases for stack trace
generation.

• fast/js/exception-properties-expected.txt:
• fast/js/script-tests/exception-properties.js:
• fast/js/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):

• fast/js/stack-trace-expected.txt: Added.
• fast/js/stack-trace.html: Added.
• platform/chromium/test_expectations.txt:

10:55 AM Changeset in webkit [96130] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Clean up how FrameView accesses the RenderView
​https://bugs.webkit.org/show_bug.cgi?id=68914

Reviewed by Sam Weinig.

Clean up how FrameView accesses the content renderer of its
frame. Previously, this was done in several different ways,
only some of which did null-checking.

Use an inline method to avoid having to expose Frame
in the header.

Standardize the terminology to use 'root' for this RenderView.

• page/FrameView.cpp:

(WebCore::rootRenderer):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

10:53 AM Changeset in webkit [96129] by abarth@webkit.org

• 2 edits in trunk/Tools

garden-o-matic results view should sort test and builder names
​https://bugs.webkit.org/show_bug.cgi?id=68488

Reviewed by Andy Estes.

Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time. That confused one user study
participant. This patch sorts the lists so that they occur in a
predictable order.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

10:38 AM Changeset in webkit [96128] by enne@google.com

• 2 edits
  1 add in trunk/LayoutTests

[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
​https://bugs.webkit.org/show_bug.cgi?id=68882

Unreviewed rebaseline.

• platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
• platform/chromium/test_expectations.txt:

10:29 AM Changeset in webkit [96127] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

AXObjectCache cleared unnecessarily when non-top Document is detached.
​https://bugs.webkit.org/show_bug.cgi?id=68636

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2011-09-27
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/deleting-iframe-destroys-axcache.html

• dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::detach):

LayoutTests:

• accessibility/deleting-iframe-destroys-axcache.html: Added.
• platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.

10:27 AM Changeset in webkit [96126] by commit-queue@webkit.org

• 55 edits in trunk

Unreviewed, rolling out r96108, r96111, r96113, and r96116.
​http://trac.webkit.org/changeset/96108
​http://trac.webkit.org/changeset/96111
​http://trac.webkit.org/changeset/96113
​http://trac.webkit.org/changeset/96116
​https://bugs.webkit.org/show_bug.cgi?id=68913

Wait for working Qt5 (Requested by ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

.:

• Source/WebKit.pro:

Source/WebCore:

• WebCore.pri:
• platform/graphics/qt/GraphicsLayerQt.cpp:

Source/WebKit/qt:

• Api/qgraphicswebview.cpp:
• Api/qgraphicswebview.h:
• Api/qwebframe.h:
• Api/qwebhistory.h:
• Api/qwebpage.h:
• Api/qwebsettings.h:
• Api/qwebview.h:
• QtWebKit.pro:
• WebCoreSupport/PageClientQt.h:
• WebCoreSupport/QtWebComboBox.cpp:
• WebCoreSupport/QtWebComboBox.h:
• declarative/declarative.pro:
• declarative/qdeclarativewebview.cpp:
• declarative/qdeclarativewebview_p.h:
• docs/webkitsnippets/webpage/main.cpp:
• examples/platformplugin/WebNotificationPresenter.h:
• tests/tests.pri:

Source/WebKit2:

• UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::chooseFiles):

• UIProcess/API/qt/qdesktopwebview.h:
• UIProcess/API/qt/tests/tests.pri:
• UIProcess/API/qt/tests/tests.pro:
• UIProcess/qt/ViewInterface.h:
• UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):

Tools:

• DumpRenderTree/qt/DumpRenderTree.pro:
• DumpRenderTree/qt/ImageDiff.pro:
• MiniBrowser/qt/BrowserView.cpp:

(BrowserView::BrowserView):

• MiniBrowser/qt/BrowserView.h:
• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):

• MiniBrowser/qt/BrowserWindow.h:
• MiniBrowser/qt/MiniBrowser.pro:
• MiniBrowser/qt/MiniBrowserApplication.h:
• MiniBrowser/qt/main.cpp:
• QtTestBrowser/QtTestBrowser.pro:
• QtTestBrowser/launcherwindow.cpp:
• QtTestBrowser/launcherwindow.h:
• QtTestBrowser/locationedit.h:
• QtTestBrowser/main.cpp:
• QtTestBrowser/mainwindow.cpp:
• QtTestBrowser/mainwindow.h:
• QtTestBrowser/webinspector.h:
• QtTestBrowser/webpage.cpp:
• QtTestBrowser/webview.cpp:
• WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
• WebKitTestRunner/PlatformWebView.h:
• WebKitTestRunner/qt/EventSenderProxyQt.cpp:
• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WebView::wkView):
(WTR::WebView::pageRef):
(WTR::WebView::~WebView):
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):

• WebKitTestRunner/qt/WebKitTestRunner.pro:

10:26 AM Changeset in webkit [96125] by rniwa@webkit.org

• 3 edits
  6 adds
  26 deletes in trunk/LayoutTests

dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html
​https://bugs.webkit.org/show_bug.cgi?id=68857

Reviewed by Kent Tamura.

Converted the tests into dump-as-markup tests. Also split each test into two tests.

• editing/pasteboard/merge-end-list-2-expected.txt: Added.
• editing/pasteboard/merge-end-list-2.html: Added.
• editing/pasteboard/merge-end-list-expected.txt: Added.
• editing/pasteboard/merge-end-list.html:
• editing/pasteboard/merge-end-table-2-expected.txt: Added.
• editing/pasteboard/merge-end-table-2.html: Added.
• editing/pasteboard/merge-end-table-expected.txt: Added.
• editing/pasteboard/merge-end-table.html:
• platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-cg-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt: Removed.
• platform/chromium-win/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt: Removed.
• platform/gtk/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/gtk/editing/pasteboard/merge-end-list-expected.txt: Removed.
• platform/gtk/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/gtk/editing/pasteboard/merge-end-table-expected.txt: Removed.
• platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/mac/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/mac/editing/pasteboard/merge-end-list-expected.txt: Removed.
• platform/mac/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/mac/editing/pasteboard/merge-end-table-expected.txt: Removed.
• platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/qt/editing/pasteboard/merge-end-list-expected.txt: Removed.
• platform/qt/editing/pasteboard/merge-end-table-expected.png: Removed.
• platform/qt/editing/pasteboard/merge-end-table-expected.txt: Removed.

10:18 AM Changeset in webkit [96124] by jchaffraix@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Crash in WebCore::HTMLParser::createHead
​https://bugs.webkit.org/show_bug.cgi?id=32426

Reviewed by Darin Adler.

The crash was fixed some time ago but the test was not landed which kept the bug open.

• fast/parser/crash-HTMLParser-createHead.html: Added.

Tweaked the test case as we now throw an exception (DOM Exception 12).

10:06 AM Changeset in webkit [96123] by Csaba Osztrogonác

• 7 edits in trunk/Source/WebCore

Fix ENABLE(SQL_DATABASE)=0 build after r95919
​https://bugs.webkit.org/show_bug.cgi?id=68902

r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.

Reviewed by Adam Barth.

• platform/sql/SQLiteAuthorizer.cpp:
• platform/sql/SQLiteDatabase.cpp:
• platform/sql/SQLiteFileSystem.cpp:
• platform/sql/SQLiteStatement.cpp:
• platform/sql/SQLiteTransaction.cpp:
• storage/DatabaseAuthorizer.cpp:

9:55 AM Changeset in webkit [96122] by jchaffraix@webkit.org

• 3 edits
  2 adds in trunk

Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
​https://bugs.webkit.org/show_bug.cgi?id=66291

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/crash-set-font.html

This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
list as Font::update was never called.

The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
Until this happens, it is better not to crash.

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
mutated by the previous property change. Also added a comment explaining why it is safe to do it
this way.

LayoutTests:

• fast/canvas/crash-set-font-expected.txt: Added.
• fast/canvas/crash-set-font.html: Added.

9:40 AM Changeset in webkit [96121] by Carlos Garcia Campos

• 7 edits
  1 move in trunk

[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
​https://bugs.webkit.org/show_bug.cgi?id=65178

Reviewed by Martin Robinson.

Source/WebKit2:

• GNUmakefile.am: Add webkit2.h.
• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
• webkit2gtk.pc.in: Use webkitgtk-<api-version> as include dir.

Tools:

• GNUmakefile.am:
• GtkLauncher/main.c: Include <webkit2/webkit2.h>.

9:38 AM Changeset in webkit [96120] by noam.rosenthal@nokia.com

• 3 edits in trunk/Source/WebCore

[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
​https://bugs.webkit.org/show_bug.cgi?id=68897

Reviewed by Andreas Kling.

No new functionality so no new tests.

• platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::syncCompositingState):

• platform/graphics/texmap/TextureMapperNode.h:

9:28 AM Changeset in webkit [96119] by inferno@chromium.org

• 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: ​http://codereview.chromium.org/8055019

9:28 AM Changeset in webkit [96118] by noam.rosenthal@nokia.com

• 6 edits in trunk/Source/WebCore

[Texmap][Qt] Refactor texture-upload to allow direct chunk update
​https://bugs.webkit.org/show_bug.cgi?id=68808

Add a function to BitmapTexture for direct pixel updates.
Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
to RGBA swizzling is done inside that function, there's no need for the
RGBA32PremultipliedBuffer class to contain such function. Also,
RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
an old mistake.

Reviewed by Andreas Kling.

No new tests. Existing tests in LayoutTests/compositing test this.

• platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):

• platform/graphics/opengl/TextureMapperGL.h:

(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):

• platform/graphics/qt/TextureMapperQt.cpp:

(WebCore::BitmapTextureQt::updateContents):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):

• platform/graphics/qt/TextureMapperQt.h:
• platform/graphics/texmap/TextureMapper.h:

9:21 AM Changeset in webkit [96117] by inferno@chromium.org

• 1 edit
  2 copies in branches/chromium/874

Merge 95926 - <rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
BUG=97952
Review URL: ​http://codereview.chromium.org/8052011

9:12 AM Changeset in webkit [96116] by Csaba Osztrogonác

• 6 edits in trunk

[Qt][WK2] Buildfix after r96108.

Rubber-stamped by Andreas Kling.

Source/WebKit/qt:

• tests/tests.pri:

Tools:

• WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
• WebKitTestRunner/qt/EventSenderProxyQt.cpp:
• WebKitTestRunner/qt/WebKitTestRunner.pro:

8:52 AM Changeset in webkit [96115] by levin@chromium.org

• 3 edits in trunk/Tools

watchlist: Change watchlistparser.py to be class based.
​https://bugs.webkit.org/show_bug.cgi?id=68869

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/watchlist/watchlistparser.py:
• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

8:50 AM Changeset in webkit [96114] by loislo@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed followupfix for r96110.
This is a small adjustment of the heap size delta calculation.

• inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):

8:37 AM WebKitGTK/Releasing edited by plaes@plaes.org

Added link to make patch (diff)

8:36 AM Changeset in webkit [96113] by vestbo@webkit.org

• 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build of declarative plugin against Qt5

Reviewed by Andreas Kling.

• declarative/declarative.pro:

8:35 AM Changeset in webkit [96112] by levin@chromium.org

• 2 edits
  1 add in trunk/Tools

watchlist: Break out the diff boilerplate to allow for re-use.
​https://bugs.webkit.org/show_bug.cgi?id=68871

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/checkout/diff_parser_unittest.py:

Break out the diff into a new file.

• Scripts/webkitpy/common/checkout/diff_test_data.py: Added.

8:29 AM Changeset in webkit [96111] by vestbo@webkit.org

• 2 edits in trunk/Source/WebKit2

[Qt] Fix build of WebKit2 unit-tests after r96108

Reviewed by Andreas Kling.

• UIProcess/API/qt/tests/tests.pri:

8:26 AM Changeset in webkit [96110] by loislo@chromium.org

• 5 edits in trunk

Web Inspector: UI performance: introduce heap size tracking stats.
​https://bugs.webkit.org/show_bug.cgi?id=68901

It is interesting how much the heap memory is used by Inspector in order of running the test.

Reviewed by Yury Semikhatsky.

Tools:

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::showDevTools):
(TestShell::closeDevTools):

LayoutTests:

• inspector/performance/resources/network-append-30-requests.html:
• inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):

8:17 AM Changeset in webkit [96109] by wjmaclean@chromium.org

• 5 edits in trunk/LayoutTests

Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=68852

Rebaseline GPU tests for Mac, Win.

Reviewed by Shinichiro Hamaji.

• platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
• platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
• platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
• platform/chromium/test_expectations.txt:

8:11 AM Changeset in webkit [96108] by vestbo@webkit.org

• 49 edits in trunk

[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi

QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.

Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.

​https://bugs.webkit.org/show_bug.cgi?id=68687

Reviewed by Andreas Kling.

7:49 AM Changeset in webkit [96107] by commit-queue@webkit.org

• 8 edits in trunk/LayoutTests

Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=68577

Patch by Ben Wagner <​bungeman@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

• platform/chromium-linux-x86/fast/box-shadow: Removed.
• platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
• platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
• platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
• platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
• platform/chromium/test_expectations.txt:

7:13 AM Changeset in webkit [96106] by pfeldman@chromium.org

• 16 edits in trunk

Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
Send attribute name and value within the event.
​https://bugs.webkit.org/show_bug.cgi?id=68613

Reviewed by Yury Semikhatsky.

• dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):

• inspector/Inspector.draft-01.json:
• inspector/Inspector.json:
• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):

• inspector/InspectorDOMAgent.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):

• inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype._setAttribute):
(WebInspector.DOMNode.prototype._removeAttribute):
(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._attributeRemoved):
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMDispatcher.prototype.attributeModified):
(WebInspector.DOMDispatcher.prototype.attributeRemoved):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):

• inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype):

• inspector/validate-protocol-compatibility:

LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
​https://bugs.webkit.org/show_bug.cgi?id=68613

Reviewed by Yury Semikhatsky.

• inspector/elements/mutate-unknown-node.html-disabled:
• inspector/elements/set-attribute.html:

7:09 AM Changeset in webkit [96105] by caio.oliveira@openbossa.org

• 14 edits
  1 add in trunk

[Qt][WK2] Add support for hover API in Qt WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=68369

Reviewed by Andreas Kling.

Source/WebKit2:

Based on the patch from Igor Oliveira in the same bug.

Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
QString corresponding to the link title. I left textContent out because was
unsure of its use case.

In QDesktopWebView we store the last URL and title emitted to make sure we send
the signal only if either value changes. Tests were added to the QML element to
check: if values are correctly emitted and if we don't emit more signals than
necessary.

• UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didMouseMoveOverElement):

• UIProcess/API/qt/qdesktopwebview.h:
• UIProcess/API/qt/qdesktopwebview_p.h:
• UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
• UIProcess/API/qt/tests/qmltests/common/test2.html:
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/ClientImpl.cpp:

(qt_wk_mouseDidMoveOverElement):

• UIProcess/qt/ClientImpl.h:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

• UIProcess/qt/TouchViewInterface.h:

(WebKit::TouchViewInterface::didMouseMoveOverElement):

• UIProcess/qt/ViewInterface.h:

Tools:

Change the statusbar to show the link URL when hovering links in
MiniBrowser using QDesktopWebView.

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onLinkHovered):

• MiniBrowser/qt/BrowserWindow.h:

6:23 AM Changeset in webkit [96104] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

• DEPS:

6:12 AM Changeset in webkit [96103] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68895

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

6:00 AM Changeset in webkit [96102] by commit-queue@webkit.org

• 10 edits in trunk

Unreviewed, rolling out r96070 and r96075.
​http://trac.webkit.org/changeset/96070
​http://trac.webkit.org/changeset/96075
​https://bugs.webkit.org/show_bug.cgi?id=68893

WK2 tests started crashing after r96070 for SL and Qt
(Requested by torarne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

Source/WebCore:

• page/FrameView.cpp:

(WebCore::FrameView::updateScrollCorner):

• platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollCorner):

• platform/ScrollableArea.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::destroyRootLayer):

• rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::imageChanged):

LayoutTests:

• compositing/iframes/repaint-after-losing-scrollbars-expected.png:
• platform/qt/Skipped:

5:58 AM Changeset in webkit [96101] by alexis.menard@openbossa.org

• 3 edits in trunk/Source/WebKit2

[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
​https://bugs.webkit.org/show_bug.cgi?id=68889

Reviewed by Andreas Kling.

Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.

• UIProcess/API/qt/qdesktopwebview.h:
• UIProcess/API/qt/qtouchwebpage.h:

5:39 AM Changeset in webkit [96100] by yurys@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
​https://bugs.webkit.org/show_bug.cgi?id=67732

Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.

Reviewed by Pavel Feldman.

• src/js/Tests.js:

(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):

5:34 AM Changeset in webkit [96099] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed typo fix.

• platform/chromium/test_expectations.txt:

5:21 AM Changeset in webkit [96098] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: JS exception upon clicking on "Word Wrap" checkbox in Settings screen
​https://bugs.webkit.org/show_bug.cgi?id=68888

Reviewed by Pavel Feldman.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):

5:06 AM Changeset in webkit [96097] by podivilov@chromium.org

• 7 edits in trunk

Web Inspector: migrate RawSourceCode clients to SourceMapping class.
​https://bugs.webkit.org/show_bug.cgi?id=68524

Source/WebCore:

Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.

Reviewed by Yury Semikhatsky.

• inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):

• inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get sourceMapping):

LayoutTests:

Reviewed by Yury Semikhatsky.

• inspector/debugger/breakpoint-manager.html:
• inspector/debugger/raw-source-code.html:

4:20 AM Changeset in webkit [96096] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

wrap attribute of textarea element cannot be accessed by JavaScript.
​https://bugs.webkit.org/show_bug.cgi?id=68592

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.

Source/WebCore:

Added JS interface for wrap attribute to HTMLTextAreaElement.idl.

Test: fast/forms/textarea-wrap-attribute.html

• html/HTMLTextAreaElement.idl:

LayoutTests:

Added test cases to check accessibility to wrap attribute by JS.

• fast/forms/textarea-wrap-attribute-expected.txt: Added.
• fast/forms/textarea-wrap-attribute.html: Added.

3:43 AM Changeset in webkit [96095] by alex

• 2 edits in releases/WebKitGTK/webkit-1.6

Bump the release number to 1.6.1 and add the NEWS information

3:33 AM Changeset in webkit [96094] by alex

• 3 edits in releases/WebKitGTK/webkit-1.6/Source/WebCore

Merging ​http://trac.webkit.org/changeset/96093

3:28 AM Changeset in webkit [96093] by xan@webkit.org

• 3 edits in trunk/Source/WebCore

[GTK] Add compatibility methods for DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=68884

Reviewed by Philippe Normand.

Add compatibility methods for our DOM bindings.

• bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_blob_slice): alias to the new method name.
(webkit_dom_html_form_element_dispatch_form_change): this was
removed from WebCore, so just print a warning about it.
(webkit_dom_html_form_element_dispatch_form_input): ditto.

• bindings/gobject/WebKitDOMCustom.h:

3:22 AM Changeset in webkit [96092] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-27

• DEPS:

3:15 AM Changeset in webkit [96091] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast compositing/geometry/limit-layer-bounds-transformed-overflow.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68886

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

3:06 AM Changeset in webkit [96090] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

2:56 AM Changeset in webkit [96089] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68852

Unreviewed test_expectations.txt update. We may need GPU-CG, too.

• platform/chromium/test_expectations.txt:

2:51 AM Changeset in webkit [96088] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
​https://bugs.webkit.org/show_bug.cgi?id=68882

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

2:35 AM Changeset in webkit [96087] by Carlos Garcia Campos

• 8 edits in trunk

[GTK] Reorganize header files
​https://bugs.webkit.org/show_bug.cgi?id=65616

Reviewed by Martin Robinson.

.:

• GNUmakefile.am: Initialize $libwebkitgtkincludedir to

$(prefix)/include/webkitgtk-<api-version>

Source/JavaScriptCore:

Install header files under $libwebkitgtkincludedir/JavaScriptCore.

• GNUmakefile.am: Use $libwebkitgtkincludedir.
• javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.

Source/WebKit/gtk:

Install header files under $libwebkitgtkincludedir/webkit.

• GNUmakefile.am: Use $libwebkitgtkincludedir.
• webkit.pc.in: Use webkitgtk-<api-version> as include dir.

2:31 AM Changeset in webkit [96086] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
​https://bugs.webkit.org/show_bug.cgi?id=68881

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

2:24 AM Changeset in webkit [96085] by Philippe Normand

• 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening

• platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing

in 32-Bits Release.

• platform/gtk/test_expectations.txt: Mark

media/video-timeupdate-reverse-play.html as flaky because of bug 67407.

2:00 AM Changeset in webkit [96084] by rniwa@webkit.org

• 6 edits in trunk/Source/WebCore

Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
​https://bugs.webkit.org/show_bug.cgi?id=68875

Reviewed by Kent Tamura.

Added InsertedNode class inside ReplaceSelection to encapsulate m_firstNodeInserted and m_lastLeafInserted.
Deployed it in removeRedundantStylesAndKeepStyleSpanInline, doApply, and insertAsListItems of ReplaceSelectionCommand.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):

• editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::InsertedNodes::respondToNodeInsertion):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::InsertedNodes::firstNodeInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::lastLeafInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):

• editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval): Moved from DeleteSelectionCommand.cpp.

• editing/htmlediting.h:

1:56 AM Changeset in webkit [96083] by hamaji@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=68879

Unreviewed test_expectations.txt update.

• platform/chromium/test_expectations.txt:

1:33 AM Changeset in webkit [96082] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.
​https://bugs.webkit.org/show_bug.cgi?id=60972

Patch by Arun Patole <​bmf834@motorola.com> on 2011-09-27
Reviewed by Philippe Normand.

Source/WebCore:

The paused attribute should be set to true and the media element should emit a 'paused' at the end of playback.
WHATWG revision r6562: ​http://html5.org/tools/web-apps-tracker?from=6561&to=6562

Test: media/media-element-play-after-eos.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): set m_paused to true and schedule 'pause' event when playback ended.

LayoutTests:

Update media tests as the 'pause' event should be fired
and 'paused' should be set to true at the end of playback.

• media/event-attributes-expected.txt:
• media/event-attributes.html:
• media/media-element-play-after-eos-expected.txt: Added.
• media/media-element-play-after-eos.html: Added.
• media/video-loop-expected.txt:

1:21 AM Changeset in webkit [96081] by Philippe Normand

• 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

• platform/gtk/Skipped:

Skip outdated canvas/philip/tests/2d.drawImage.outsidesource.html.

• platform/gtk/test_expectations.txt:

media/video-playing-and-pause.html is flaky.

1:08 AM Changeset in webkit [96080] by Philippe Normand

• 5 edits
  1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95845, r95897 and r95857.

• platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
• platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
• platform/gtk/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
• platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
• platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:

12:55 AM Changeset in webkit [96079] by alexis.menard@openbossa.org

• 5 edits in trunk/Source/WebKit2

[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
​https://bugs.webkit.org/show_bug.cgi?id=68848

Reviewed by Andreas Kling.

The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.

• UIProcess/API/qt/qdesktopwebview.h:
• UIProcess/API/qt/qtouchwebpage.h:
• UIProcess/API/qt/qtouchwebview.h:
• UIProcess/API/qt/qwebnavigationcontroller.h:

12:34 AM Changeset in webkit [96078] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

<input> with autofocus doesn't lose focus when it has a certain onblur listener
​https://bugs.webkit.org/show_bug.cgi?id=68513

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/autofocus-focus-only-once.html

These changes make sure that an element is focused only once when autofocus attribute is used.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::attach):

• html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::hasAutofocused):
(WebCore::HTMLFormControlElement::setAutofocused):

LayoutTests:

These changes make sure that an element is focused only once when autofocus attribute is used.

• fast/forms/autofocus-focus-only-once-expected.txt: Added.
• fast/forms/autofocus-focus-only-once.html: Added.

12:05 AM Changeset in webkit [96077] by reni@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

[Qt] Add missing test expecteds after r95924.

Unreviewed gardening.

• platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
• platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.