⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 22, 2011:

10:03 PM Changeset in webkit [98198] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

HTTPBodyStream in NSURLRequest gets lost when using CFNetwork loader
​https://bugs.webkit.org/show_bug.cgi?id=70583
<rdar://problem/10281227>

Reviewed by Darin Adler.

Call WebCore::setHTTPBody() only if we actually have a FormData. Unconditionally calling it
results in us passing 0 to wkCFURLRequestSetHTTPRequestBodyParts() which resets any input
stream specified by the user on the NSURLRequest. This code matches the behavior in the
Foundation version of doUpdatePlatformRequest().

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

5:40 PM Changeset in webkit [98197] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Make relayout-nested-positioned-elements-crash.html more reliable
​https://bugs.webkit.org/show_bug.cgi?id=70672

Reviewed by Kenneth Rohde Christiansen.

The test relayout-nested-positioned-elements-crash relies on implementation
details of the test runner. If the function runTest() is run
during the test, the result will be different than the expected results.

Change the test to use the Javascript test framework.
Ensure the element has the correct style in the final state.

  • fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt:
  • fast/block/positioning/relayout-nested-positioned-elements-crash.html:
4:46 PM Changeset in webkit [98196] by commit-queue@webkit.org
  • 19 edits
    30 moves
    1 add
    1 delete in trunk/Source/WebCore

Move all MediaStream and PeerConnection related non-platform files to WebCore/mediastream
​https://bugs.webkit.org/show_bug.cgi?id=70233

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-10-22
Reviewed by Adam Barth.

Removed affected files from build systems that don't have a MEDIA_STREAM build flag.

No new tests since we're just moving files.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • dom/DOMAllInOne.cpp:
  • dom/DispatchTask.h: Removed unused file.
  • dom/ScriptExecutionContext.cpp:
  • mediastream/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/LocalMediaStream.cpp.

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
(WebCore::LocalMediaStream::stop):
(WebCore::LocalMediaStream::stopTimerFired):
(WebCore::LocalMediaStream::~LocalMediaStream):
(WebCore::LocalMediaStream::toLocalMediaStream):

  • mediastream/LocalMediaStream.h: Renamed from Source/WebCore/dom/LocalMediaStream.h.
  • mediastream/LocalMediaStream.idl: Renamed from Source/WebCore/dom/LocalMediaStream.idl.
  • mediastream/MediaStream.cpp: Renamed from Source/WebCore/dom/MediaStream.cpp.

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore::MediaStream::toMediaStream):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::scriptExecutionContext):
(WebCore::MediaStream::eventTargetData):
(WebCore::MediaStream::ensureEventTargetData):

  • mediastream/MediaStream.h: Renamed from Source/WebCore/dom/MediaStream.h.

(WebCore::MediaStream::label):
(WebCore::MediaStream::tracks):
(WebCore::MediaStream::descriptor):
(WebCore::MediaStream::refEventTarget):
(WebCore::MediaStream::derefEventTarget):

  • mediastream/MediaStream.idl: Renamed from Source/WebCore/dom/MediaStream.idl.
  • mediastream/MediaStreamClient.h: Renamed from Source/WebCore/page/MediaStreamClient.h.

(WebCore::MediaStreamClient::~MediaStreamClient):

  • mediastream/MediaStreamController.cpp: Renamed from Source/WebCore/page/MediaStreamController.cpp.

(WebCore::MediaStreamController::Request::Request):
(WebCore::MediaStreamController::Request::localId):
(WebCore::MediaStreamController::Request::frameController):
(WebCore::MediaStreamController::MediaStreamController):
(WebCore::MediaStreamController::~MediaStreamController):
(WebCore::MediaStreamController::isClientAvailable):
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::registerRequest):
(WebCore::MediaStreamController::generateStream):
(WebCore::MediaStreamController::streamGenerated):
(WebCore::MediaStreamController::streamGenerationFailed):

  • mediastream/MediaStreamController.h: Renamed from Source/WebCore/page/MediaStreamController.h.
  • mediastream/MediaStreamEvent.cpp: Renamed from Source/WebCore/p2p/MediaStreamEvent.cpp.

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
(WebCore::MediaStreamEvent::~MediaStreamEvent):
(WebCore::MediaStreamEvent::initMediaStreamEvent):
(WebCore::MediaStreamEvent::stream):

  • mediastream/MediaStreamEvent.h: Renamed from Source/WebCore/p2p/MediaStreamEvent.h.

(WebCore::MediaStreamEvent::isMediaStreamEvent):

  • mediastream/MediaStreamEvent.idl: Renamed from Source/WebCore/p2p/MediaStreamEvent.idl.
  • mediastream/MediaStreamFrameController.cpp: Renamed from Source/WebCore/page/MediaStreamFrameController.cpp.

(WebCore::MediaStreamFrameController::Request::~Request):
(WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
(WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
(WebCore::MediaStreamFrameController::Request::Request):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::create):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback):
(WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
(WebCore::MediaStreamFrameController::RequestMap::abort):
(WebCore::MediaStreamFrameController::RequestMap::abortAll):
(WebCore::MediaStreamFrameController::MediaStreamFrameController):
(WebCore::MediaStreamFrameController::~MediaStreamFrameController):
(WebCore::MediaStreamFrameController::securityOrigin):
(WebCore::MediaStreamFrameController::scriptExecutionContext):
(WebCore::MediaStreamFrameController::pageController):
(WebCore::MediaStreamFrameController::enterDetachedState):
(WebCore::MediaStreamFrameController::isClientAvailable):
(WebCore::MediaStreamFrameController::disconnectPage):
(WebCore::MediaStreamFrameController::disconnectFrame):
(WebCore::MediaStreamFrameController::transferToNewPage):
(WebCore::MediaStreamFrameController::parseGenerateStreamOptions):
(WebCore::MediaStreamFrameController::generateStream):
(WebCore::MediaStreamFrameController::streamGenerated):
(WebCore::MediaStreamFrameController::streamGenerationFailed):

  • mediastream/MediaStreamFrameController.h: Renamed from Source/WebCore/page/MediaStreamFrameController.h.

(WebCore::MediaStreamFrameController::IdGenerator::IdGenerator):
(WebCore::MediaStreamFrameController::IdGenerator::getNextId):

  • mediastream/MediaStreamList.cpp: Renamed from Source/WebCore/dom/MediaStreamList.cpp.

(WebCore::MediaStreamList::create):
(WebCore::MediaStreamList::MediaStreamList):
(WebCore::MediaStreamList::~MediaStreamList):
(WebCore::MediaStreamList::length):
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::append):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):

  • mediastream/MediaStreamList.h: Renamed from Source/WebCore/dom/MediaStreamList.h.
  • mediastream/MediaStreamList.idl: Renamed from Source/WebCore/dom/MediaStreamList.idl.
  • mediastream/MediaStreamRegistry.cpp: Renamed from Source/WebCore/platform/MediaStreamRegistry.cpp.

(WebCore::MediaStreamRegistry::registry):
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::mediaStream):

  • mediastream/MediaStreamRegistry.h: Renamed from Source/WebCore/platform/MediaStreamRegistry.h.
  • mediastream/MediaStreamTrack.cpp: Renamed from Source/WebCore/dom/MediaStreamTrack.cpp.

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):

  • mediastream/MediaStreamTrack.h: Renamed from Source/WebCore/dom/MediaStreamTrack.h.
  • mediastream/MediaStreamTrack.idl: Renamed from Source/WebCore/dom/MediaStreamTrack.idl.
  • mediastream/MediaStreamTrackList.cpp: Renamed from Source/WebCore/dom/MediaStreamTrackList.cpp.

(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::~MediaStreamTrackList):
(WebCore::MediaStreamTrackList::length):
(WebCore::MediaStreamTrackList::item):

  • mediastream/MediaStreamTrackList.h: Renamed from Source/WebCore/dom/MediaStreamTrackList.h.
  • mediastream/MediaStreamTrackList.idl: Renamed from Source/WebCore/dom/MediaStreamTrackList.idl.
  • mediastream/PeerConnection.cpp: Renamed from Source/WebCore/p2p/PeerConnection.cpp.

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::~PeerConnection):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::iceProcessingCompleted):
(WebCore::PeerConnection::sdpGenerated):
(WebCore::PeerConnection::dataStreamMessageReceived):
(WebCore::PeerConnection::remoteStreamAdded):
(WebCore::PeerConnection::remoteStreamRemoved):
(WebCore::PeerConnection::toPeerConnection):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::stop):
(WebCore::PeerConnection::eventTargetData):
(WebCore::PeerConnection::ensureEventTargetData):
(WebCore::PeerConnection::scheduleInitialNegotiation):
(WebCore::PeerConnection::initialNegotiationTimerFired):
(WebCore::PeerConnection::ensureStreamChangeScheduled):
(WebCore::PeerConnection::streamChangeTimerFired):
(WebCore::PeerConnection::scheduleReadyStateChange):
(WebCore::PeerConnection::readyStateChangeTimerFired):
(WebCore::PeerConnection::changeReadyState):

  • mediastream/PeerConnection.h: Renamed from Source/WebCore/p2p/PeerConnection.h.

(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

  • mediastream/PeerConnection.idl: Renamed from Source/WebCore/p2p/PeerConnection.idl.
  • mediastream/SignalingCallback.h: Renamed from Source/WebCore/p2p/SignalingCallback.h.

(WebCore::SignalingCallback::~SignalingCallback):

  • mediastream/SignalingCallback.idl: Renamed from Source/WebCore/p2p/SignalingCallback.idl.
  • page/Frame.cpp:
  • page/Navigator.cpp:
  • page/Page.cpp:
3:38 PM Changeset in webkit [98195] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] run-launcher script fails after testing WK2 tests
​https://bugs.webkit.org/show_bug.cgi?id=70676

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-10-22
Reviewed by Andreas Kling.

Pass the '-2' flag instead of '--webkit-test-runner' when executing
run-launcher script after testing with WebKitTestRunner.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:31 PM Changeset in webkit [98194] by pfeldman@chromium.org
  • 40 edits in trunk

Source/WebCore: Web Inspector: get rid of View::hide, View::set visible, View::attach,
View::set visible.
​https://bugs.webkit.org/show_bug.cgi?id=70523

This change also introduces assetions that forces view attach / detach operations
to be performed explicitly.

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-10-20
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype.willHide):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype.wasShown):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.wasShown):
(WebInspector.ConsolePanel.prototype.willHide):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.wasShown):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype.wasShown):
(WebInspector.CookieItemsView.prototype.willHide):
(WebInspector.CookieItemsView.prototype._updateWithCookies):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype.willHide):

  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype.wasShown):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):
(WebInspector.DetailedHeapshotView.prototype._changeView):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.willHide):

  • inspector/front-end/EmptyView.js:

(WebInspector.EmptyView.prototype.wasShown):

  • inspector/front-end/FontView.js:

(WebInspector.FontView.prototype.wasShown):

  • inspector/front-end/IFrameView.js:

(WebInspector.IFrameView):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype.wasShown):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype.wasShown):
(WebInspector.ResourceContentView.prototype.wasShown):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.wasShown):
(WebInspector.NetworkLogView.prototype.willHide):
(WebInspector.NetworkPanel.prototype.wasShown):

  • inspector/front-end/Panel.js:

(WebInspector.Panel):
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/PanelEnablerView.js:
  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype.willHide):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype.wasShown):

  • inspector/front-end/ResourceHTMLView.js:

(WebInspector.ResourceHTMLView.prototype.wasShown):
(WebInspector.ResourceHTMLView.prototype.willHide):

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.wasShown):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.prototype.wasShown):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.wasShown):
(WebInspector.TimelinePanel.prototype.willHide):

  • inspector/front-end/View.js:

(WebInspector.View):
(WebInspector.View.prototype.get visible):
(WebInspector.View.prototype.setHideOnDetach):
(WebInspector.View.prototype._wasShown):
(WebInspector.View.prototype._willHide):
(WebInspector.View.prototype._onResize):
(WebInspector.View.prototype.wasShown):
(WebInspector.View.prototype.willHide):
(WebInspector.View.prototype.onResize):
(WebInspector.View.prototype.show):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.doResize):
(WebInspector.View.prototype.dispatchToSelfAndChildren):
(WebInspector.View.prototype.dispatchToChildren):
(WebInspector.View.prototype._handleInsertedIntoDocument):

LayoutTests: Web Inspector: get rid of View::hide, View::set visible, View::attach.
​https://bugs.webkit.org/show_bug.cgi?id=70523

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-10-20
Reviewed by Yury Semikhatsky.

  • inspector/debugger/scripts-panel.html:
  • inspector/view-events-expected.txt:
  • inspector/view-events.html:
9:38 AM Changeset in webkit [98193] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][GTK] Missing env variables cause WKTR to crash
​https://bugs.webkit.org/show_bug.cgi?id=70674

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-10-22
Reviewed by Martin Robinson.

Set two environment variables that the Gtk's port of WebKitTestRunner
depends on and crashes if they're not explicitly set by the user.
Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
properly uses the _build_path method.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Set

TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
environment variables.

3:53 AM Changeset in webkit [98192] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
​https://bugs.webkit.org/show_bug.cgi?id=70582

Reviewed by Darin Adler.

No new tests. It's very hard to make a reliable test.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality):
Clear *strongDirectionalityTextNode even if hasStrongDirectionality is false.

Oct 21, 2011:

10:52 PM Changeset in webkit [98191] by mitz@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

Caret is drawn in the wrong place in multi-column blocks
​https://bugs.webkit.org/show_bug.cgi?id=70662

Reviewed by Gavin Barraclough.

  • manual-tests/caret-in-columns.html: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret): Removed the call to offsetForContents(). That function takes
a point in local coordinates, whereas this function was applying it to a point in painting root
coordinates. The desired effect was only to undo the scroll adjustment done by the caller,
paintObject().
(WebCore::RenderBlock::paintObject): Pass the original, rather than scroll-adjusted, paint offset
to paintCaret().

10:32 PM Changeset in webkit [98190] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Change efl style local variables with WebKit coding Style.
​https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

Change *sd* variable name with *smartData*. Some variables were changed by Bug 69988.

  • ewk/ewk_frame.cpp:

(ewk_frame_view_get):
(ewk_frame_uri_set):
(ewk_frame_uri_get):
(ewk_frame_contents_size_get):
(ewk_frame_load_document_finished):
(ewk_frame_load_error):
(ewk_frame_title_set):
(ewk_frame_uri_changed):
(ewk_frame_editor_client_selection_changed):
(ewk_frame_editor_client_contents_changed):
(EWKPrivate::coreFrame):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(EWKPrivate::corePage):

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_add):
(_ewk_view_single_smart_resize):

9:57 PM Changeset in webkit [98189] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Clicking a print button in a PDF doesn't do anything
​https://bugs.webkit.org/show_bug.cgi?id=70663
<rdar://problem/9795014>

Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printMainFrame): Added a public method

that PDFViewController could call.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView PDFViewPerformPrint:]):
(WebKit::PDFViewController::print):
Connect PDFView delegate method for printing.

8:58 PM Changeset in webkit [98188] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG inlining sometimes fails to reset constant references
​https://bugs.webkit.org/show_bug.cgi?id=70668

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Reset constant references when we need to (new block created) and not
when we don't (change of inlining depth).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

Reviewed by Anders Carlsson.

Added a new test that covers this specific bug as well as the general
ability to perform inlining, and the ability to OSR out of an inline
stack.

  • fast/js/dfg-inline-constant-expected.txt: Added.
  • fast/js/dfg-inline-constant.html: Added.
  • fast/js/script-tests/dfg-inline-constant.js: Added.

(foo):
(bar):

8:56 PM Changeset in webkit [98187] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Lookup does not work on text using web fonts in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=70669
<rdar://problem/10147441>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
If the font for the range is web font (and therefore no NSFont is
available), use the system font of the same size. While not great,
it approximates what WebKit1 does.

8:25 PM Changeset in webkit [98186] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash below CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy::DidPerformDictionaryLookup>
​https://bugs.webkit.org/show_bug.cgi?id=70667
<rdar://problem/9622186>

Reviewed by Anders Carlsson.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
Account for the fact that the options dictionary can be null. This is due to Lookup passing
back a null, rather than empty, dictionary when it could not find any interesting characteristics.

8:15 PM Changeset in webkit [98185] by nduca@chromium.org
  • 13 edits in trunk/Source

[chromium] Make setVisibility extension- and thread-correct
​https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

7:51 PM Changeset in webkit [98184] by weinig@apple.com
  • 5 edits
    3 adds in trunk/Source/WebKit2

Add WKBrowsingContextGroup which wraps WKPageGroupRef
​https://bugs.webkit.org/show_bug.cgi?id=70665

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextGroup.h: Added.
  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Added.

(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup pageGroupRef]):

  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):

  • WebKit2.xcodeproj/project.pbxproj:
7:24 PM Changeset in webkit [98183] by ojan@chromium.org
  • 4 edits
    15 adds
    2 deletes in trunk/LayoutTests

Fixup test expectations now that ​http://trac.webkit.org/changeset/98173 has landed.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
  • platform/chromium-cg-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/fallback-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:42 PM Changeset in webkit [98182] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Removed the test since it has been passing on

the bots for at least a week.

6:32 PM Changeset in webkit [98181] by jchaffraix@webkit.org
  • 1 edit
    1 add
    4 deletes in trunk/LayoutTests

Unreviewed rebaseline.

This test started failing on the bot. As this is a progression, updating the baseline.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
  • platform/chromium/fast/multicol/flipped-blocks-border-after-expected.png: Added.
6:26 PM Changeset in webkit [98180] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=68879

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt: Those changes have been consistently passing on

the bots for at least 10 days.

6:22 PM Changeset in webkit [98179] by fpizlo@apple.com
  • 31 edits in trunk/Source/JavaScriptCore

DFG should have inlining
​https://bugs.webkit.org/show_bug.cgi?id=69996

Reviewed by Oliver Hunt.

Implements inlining that's hooked into the bytecode parser. Only
works for calls, for now, though nothing fundamentally prevents us
from inlining constructor calls. 2% overall speed-up on all
benchmarks. 7% speed-up on V8 (around 34% and 27% on deltablue and
richards respectively), neutral on Kraken and SunSpider.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::setInstructionCount):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::inlineDepth):
(JSC::CodeOrigin::operator==):
(JSC::CodeOrigin::inlineStack):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::handleSuccessor):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::canInlineOpcodes):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForConstruct):

  • dfg/DFGGraph.cpp:

(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::decodedCodeMapFor):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::baselineCodeBlockFor):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::shouldGenerate):

  • dfg/DFGOperands.h:

(JSC::DFG::Operands::ensureLocals):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::getLocal):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallSlowCase):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::profiledCodeBlockFor):
(JSC::FunctionExecutable::parameterCount):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
  • runtime/JSFunction.h:
6:15 PM Changeset in webkit [98178] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=70647
Common but unreproducible crash under [ScrollbarPartAnimation setCurrentProgress:]
-and corresponding-
<rdar://problem/9542018>

Reviewed by Sam Weinig.

This patch implements two speculative fixes for this crash.

First, block exceptions around all of the code responsible for calling
stopAnimation. If that code throws any exceptions, we want to make sure the other
animations are still stopped.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

Only send AppKit these notifications for active pages. I originally made these
assertions, and I found that they were hit a surprising number of times. If we
only send notifications for active pages, then we should greatly reduce and
possibly eliminate our chances of hitting this crash.
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):

5:48 PM Changeset in webkit [98177] by mhahnenberg@apple.com
  • 10 edits in trunk/Source

Add put to the MethodTable
​https://bugs.webkit.org/show_bug.cgi?id=70439

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ClassInfo.h: Added put and putByIndex to the MethodTable.
  • runtime/JSFunction.h: Changed access modifier for put to protected since some

subclasses of JSFunction need to reference it in their MethodTables.

Source/WebCore:

No new tests.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp: Added static put since it was overlooked in

previous patches.
(WebCore::JSDOMWindow::putVirtual):
(WebCore::JSDOMWindow::put):

  • bindings/js/JSDOMWindowShell.cpp: Ditto.

(WebCore::JSDOMWindowShell::putVirtual):
(WebCore::JSDOMWindowShell::put):

  • bindings/js/JSDOMWindowShell.h:
5:39 PM Changeset in webkit [98176] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r98112.

5:38 PM Changeset in webkit [98175] by dslomov@google.com
  • 9 edits in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.

Reviewed by David Levin.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeTransferredMessagePort):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::tryGetTransferredMessagePort):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.
Results for JSC include some FAILs - this will be addressed when JSC
implements message port transfers as well (​https://bugs.webkit.org/show_bug.cgi?id=70658)

Reviewed by David Levin.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js:

(testTransfers.channel0.port2.onmessage):
(testTransfers):
(channel.port2.onmessage):

  • platform/chromium-win/fast/events/message-port-multi-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
5:16 PM Changeset in webkit [98174] by eae@chromium.org
  • 18 adds in branches/subpixellayout/Source/WebCore/platform

Add missing files for fixed-point implementation

5:10 PM Changeset in webkit [98173] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

r97693 caused 42 failures on the chromium mac bots
​https://bugs.webkit.org/show_bug.cgi?id=70300

Can't test this until ​https://bugs.webkit.org/show_bug.cgi?id=70660
is fixed. The fix for that bug will test this codepath as well though.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

5:04 PM Changeset in webkit [98172] by commit-queue@webkit.org
  • 6 edits in trunk

Setting form.enctype reflected attribute behaves strangely.
​https://bugs.webkit.org/show_bug.cgi?id=44879

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-10-21
Reviewed by Darin Adler.

Source/WebCore:

The spec says form.enctype should be application/x-www-form-urlencoded,
So as "text", "plain", "multipart" or "form-data" these are not a valid value so must be ignored.

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):

LayoutTests:

Leading/trailing white-spaces should not be allowed while specifying attribute value.
Added more test coverage for form.enctype attribute.

  • fast/forms/encoding-test.html:
  • fast/forms/enctype-attribute-expected.txt:
  • fast/forms/enctype-attribute.html: Corrected test case as per new behavior.
5:01 PM Changeset in webkit [98171] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

Ensure periodic flushing of canvas drawing context
​https://bugs.webkit.org/show_bug.cgi?id=70646

Reviewed by Simon Fraser.

No new tests. No current way to track tests that cause hangs or
non-deterministic drops in performance.

  • platform/graphics/cg/ImageBufferDataCG.h: Adds a timestamp of last tracked flush.
  • platform/graphics/cg/ImageBufferCG.cpp: Ensures periodic flushes on the drawing context.

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context): Flushes context if we're beyond flush interval.
(WebCore::ImageBuffer::copyNativeImage): Updates last flush timestamp.
(WebCore::ImageBuffer::getUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::getPremultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putPremultipliedImageData): Updates last flush timestamp.

4:54 PM Changeset in webkit [98170] by Lucas Forschler
  • 13 edits in branches/safari-534.52-branch/Source

Merged r98027.

4:53 PM Changeset in webkit [98169] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Gardening update.

  • platform/chromium/test_expectations.txt: We are randomly hitting

a known ASSERT on this test case.

4:52 PM Changeset in webkit [98168] by Lucas Forschler
  • 11 edits in branches/safari-534.52-branch/Source

Merge 97810 & 97813.

4:20 PM Changeset in webkit [98167] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Bencher script doesn't measure GC times accurately
​https://bugs.webkit.org/show_bug.cgi?id=70588

Reviewed by Geoff Garen.

Added two new options which allow different ways of measuring GC times:

--measure-gc, which omits calls to gc() between benchmark invocations.
This option takes an optional argument, which is the name of the
VM in which to enable this feature. This allows comparing a single VM
against itself, with and without GC.

--rerun <N>, which causes each sample measurement to include N invocations
which do not have gc() calls between them. The default is N = 1, which
results in the same behavior as before.

You can use either --measure-gc or --rerun <N> for N > 1 (preferably
N >= 3) to get more of a contribution from GC to the measured times.
--rerun results in tighter confidence intervals than --measure-gc, since
it amortizes GC effects in each sample, while with --measure-gc some
samples will see GC and some won't leading to a higher standard devation
and thus requiring more samples to reduce confidence intervals to
managable levels.

  • Scripts/bencher:
4:18 PM Changeset in webkit [98166] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Style guide should mention the preference of index over iterator
​https://bugs.webkit.org/show_bug.cgi?id=70285

Reviewed by Darin Adler.

Per discussion on ​https://lists.webkit.org/pipermail/webkit-dev/2011-October/018274.html,
we prefer index over iterators.

  • coding/coding-style.html:
4:12 PM Changeset in webkit [98165] by eae@chromium.org
  • 286 edits in branches/subpixellayout/Source

Merging subpixel patch into branch. Currently builds on the qt and mac ports.

3:56 PM Changeset in webkit [98164] by abarth@webkit.org
  • 16 edits in trunk/Source

Introduce Event::hasInterface to make uses of interfaceName more readable
​https://bugs.webkit.org/show_bug.cgi?id=70652

Reviewed by Eric Seidel.

Source/WebCore:

Eric felt that this approach would be more readable because it requires
less syntax at each callsite.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • dom/Event.cpp:

(WebCore::Event::hasInterface):

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::handleEvent):

Source/WebKit/chromium:

Update call sites to the new interface.

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isPopStateEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isXMLHttpRequestProgressEvent):
(WebKit::WebDOMEvent::isWebKitAnimationEvent):
(WebKit::WebDOMEvent::isWebKitTransitionEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

3:52 PM Changeset in webkit [98163] by adamk@chromium.org
  • 4 edits
    2 adds in trunk

[MutationObservers] Implement basic subtree observation
​https://bugs.webkit.org/show_bug.cgi?id=70436

Reviewed by Ryosuke Niwa.

Source/WebCore:

Note that this patch only implements "basic" subtree semantics,
not the fully robust semantics described in
​http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html.
Most importantly, this change does not handle the case where mutations
occur in a temporarily detached subtree.

The plan is to implement those semantics in a followup to avoid
blocking other parts of the MutationObserver spec that rely on
the existence of subtree observation but not its specific
implementation.

Test: fast/mutation/observe-subtree.html

  • dom/Node.cpp:

(WebCore::addMatchingObservers): Static helper method for registeredMutationObserversOfType().
(WebCore::Node::registeredMutationObserversOfType): Walk up the tree looking for observers.

  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::hasAllOptions): A stricter, renamed from matches().

LayoutTests:

  • fast/mutation/observe-subtree-expected.txt: Added.
  • fast/mutation/observe-subtree.html: Added.
3:33 PM Changeset in webkit [98162] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/qt

[Qt] Remote debugging needs QWebInspector to work
​https://bugs.webkit.org/show_bug.cgi?id=70651

Patch by Luiz Agostini <​luiz.agostini@palm.com> on 2011-10-21
Reviewed by Kenneth Rohde Christiansen.

Removing QWebInspector dependency from remote inspector.

  • Api/qwebinspector.cpp:
  • Api/qwebinspector_p.h:

(QWebInspectorPrivate::QWebInspectorPrivate):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
(WebCore::InspectorClientQt::detachRemoteFrontend):
(WebCore::InspectorClientQt::sendMessageToFrontend):

  • WebCoreSupport/InspectorClientQt.h:
  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

  • WebCoreSupport/InspectorServerQt.h:
3:30 PM Changeset in webkit [98161] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Mark member variables of WebKit2 API @private
​https://bugs.webkit.org/show_bug.cgi?id=70655

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKView.h:
3:26 PM Changeset in webkit [98160] by weinig@apple.com
  • 4 edits
    3 moves in trunk/Source/WebKit2

Rename WKProcessCluster to WKProcessGroup
​https://bugs.webkit.org/show_bug.cgi?id=70654

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKProcessCluster.h: Removed.
  • UIProcess/API/mac/WKProcessCluster.mm: Removed.
  • UIProcess/API/mac/WKProcessClusterInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.h.
  • UIProcess/API/mac/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.mm.

(-[WKProcessGroup initWithInjectedBundleURL:]):

  • UIProcess/API/mac/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessClusterInternal.h.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processCluster:]):

  • WebKit2.xcodeproj/project.pbxproj:
3:09 PM Changeset in webkit [98159] by weinig@apple.com
  • 9 edits in trunk

Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
​https://bugs.webkit.org/show_bug.cgi?id=70653

Reviewed by Simon Fraser.

Source/WebKit2:

Requiring a context and pagegroup removes the concept of global contexts,
which is something that is both confusing, and makes Objective-C wrapping
harder.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processCluster:]):

  • UIProcess/API/mac/WKViewPrivate.h:

Remove init methods that didn't take both a context and a pagegroup.

Tools:

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithContext:pageGroup:]):
(-[BrowserWindowController windowWillClose:]):
(createNewPage):
(-[BrowserWindowController awakeFromNib]):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
Update testing code to pass a PageGroup as necessary.

3:01 PM Changeset in webkit [98158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Wrong type conversion in InspectorServerQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=70639

Patch by Luiz Agostini <​luiz.agostini@palm.com> on 2011-10-21
Reviewed by Noam Rosenthal.

Wrong type conversion causes WebSocket handshake failures for the remote inspector.

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::parseWebSocketChallengeNumber):

2:59 PM Changeset in webkit [98157] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

webkitpy: Teach NRWT about the EFL port
​https://bugs.webkit.org/show_bug.cgi?id=70637

Allows using efl as a platform when executing NRWT.

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-10-21
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/efl.py: Added.
  • Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects

when using PortFactory.get(port_name='efl').

2:43 PM Changeset in webkit [98156] by eae@chromium.org
  • 2728 edits
    1452 copies
    52 deletes in branches/subpixellayout

Merging trunk changes up until 98153 into subpixel branch.

2:34 PM Changeset in webkit [98155] by Lucas Forschler
  • 38 edits
    3 adds in branches/safari-534.52-branch/Source

Merge rdar://problem/10310999

2:30 PM Changeset in webkit [98154] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

IndexedDB: objectStore.transaction property should be readonly
​https://bugs.webkit.org/show_bug.cgi?id=62395

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-21
Reviewed by Tony Chang.

Source/WebCore:

Implement the IDBObjectStore.transaction property defined by the spec.

Test: storage/indexeddb/readonly-properties.html

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::transaction):

  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/readonly-properties-expected.txt: Added.
  • storage/indexeddb/readonly-properties.html: Added.
2:26 PM Changeset in webkit [98153] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash after printing a view with accelerated compositing content
​https://bugs.webkit.org/show_bug.cgi?id=70643
<rdar://problem/9479083>

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): We cannot rely on -[WKView drawRect:] calling endPrinting() for us. That call to endPrinting() is still necessary to paint e.g. when resizing a window while a print dialog is present.
2:22 PM Changeset in webkit [98152] by Lucas Forschler
  • 5 edits
    3 copies in branches/safari-534.52-branch

Merged r98060.

2:16 PM Changeset in webkit [98151] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98013.

2:13 PM Changeset in webkit [98150] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.52-branch

Merged r97821.

2:10 PM Changeset in webkit [98149] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97808.

2:09 PM Changeset in webkit [98148] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97807.

2:08 PM Changeset in webkit [98147] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r97681.

2:07 PM Changeset in webkit [98146] by abarth@webkit.org
  • 35 edits in trunk/Source

Event.h has too many virtual isMumbleEvent() functions
​https://bugs.webkit.org/show_bug.cgi?id=70636

Reviewed by Dimitri Glazkov.

Source/WebCore:

We should use the new interfaceName() way of doing run-time type inference.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventCustom.cpp:

(WebCore::JSEvent::clipboardData):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::clipboardDataAccessorGetter):

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::interfaceName):

  • dom/BeforeTextInsertedEvent.h:
  • dom/ClipboardEvent.cpp:
  • dom/ClipboardEvent.h:
  • dom/CompositionEvent.cpp:
  • dom/CompositionEvent.h:
  • dom/ErrorEvent.cpp:
  • dom/ErrorEvent.h:
  • dom/Event.cpp:

(WebCore::Event::storesResultAsString):
(WebCore::Event::storeResult):
(WebCore::Event::clipboardData):

  • dom/Event.h:
  • dom/Event.idl:
    • Remove this interface from the CPP bindings because this function no longer exists. It's unclear to me how strong our API commitments are in the CPP bindings.
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:
  • dom/MutationEvent.cpp:
  • dom/MutationEvent.h:
  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

  • dom/OverflowEvent.cpp:
  • dom/OverflowEvent.h:
  • dom/PageTransitionEvent.h:
  • dom/ProgressEvent.h:
  • dom/TextEvent.cpp:
  • dom/TextEvent.h:
  • dom/WheelEvent.cpp:
  • dom/WheelEvent.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::defaultEventHandler):

  • svg/SVGZoomEvent.cpp:
  • svg/SVGZoomEvent.h:

Source/WebKit/chromium:

Update these callsites to the new API.

  • src/WebDOMEvent.cpp:

(WebKit::WebDOMEvent::isKeyboardEvent):
(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isClipboardEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isBeforeTextInsertedEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):

2:06 PM Changeset in webkit [98145] by Lucas Forschler
  • 4 edits in branches/safari-534.52-branch/Source/WebCore

Merged r97433.

2:04 PM Changeset in webkit [98144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Flush denormals in Biquad, ZeroPole, and DynamicsCompressor.

We only flush when saving the state variables instead of in the
loops so that we don't impact performance too much when there are
no denormals. This will at least not propagate the denormals any
further within the class.

​https://bugs.webkit.org/show_bug.cgi?id=70626

Patch by Raymond Toy <Raymond Toy> on 2011-10-21
Reviewed by Kenneth Russell.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):
Flush denormals when storing the filter state back in to class
filter state.

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):
Ditto.

  • platform/audio/ZeroPole.cpp:

(WebCore::ZeroPole::process):
Ditto.

2:01 PM Changeset in webkit [98143] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r96874.

1:57 PM Changeset in webkit [98142] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96864.

1:56 PM Changeset in webkit [98141] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96855.

1:54 PM Changeset in webkit [98140] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94472.

1:52 PM Changeset in webkit [98139] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96765.

1:52 PM Changeset in webkit [98138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebFrameLoaderClient::shouldFallback() should use a port-specific implementation
​https://bugs.webkit.org/show_bug.cgi?id=70055

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-10-21
Reviewed by Luiz Agostini.

In QtWebKit 1, our FrameLoaderClient::shouldFallback was checking for InterruptedForPolicyChange
error. In WebKit2, we are relying on the common implementation for WebFrameLoaderClient::shouldFallback
which doesn't check for the same error. Here we add this check only for Qt.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldFallBack):

1:51 PM Changeset in webkit [98137] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, yet another flaky crashing test.

  • platform/chromium/test_expectations.txt:
1:50 PM Changeset in webkit [98136] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r96555.

1:48 PM Changeset in webkit [98135] by Lucas Forschler
  • 6 edits
    3 copies in branches/safari-534.52-branch

Merged r95226.

1:37 PM Changeset in webkit [98134] by jchaffraix@webkit.org
  • 2 edits
    7 adds
    4 deletes in trunk/LayoutTests

Gardening rebaselines.

  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
  • platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
  • platform/chromium-win/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium/fast/multicol: Added.
  • platform/chromium/fast/multicol/vertical-lr: Added.
  • platform/chromium/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium/fast/multicol/vertical-rl: Added.
  • platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium/test_expectations.txt:

The dumps are weird on SL so we don't land them but mark the test as PASS TEXT.

1:02 PM Changeset in webkit [98133] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: This test is flaky and crashing

sometimes on snow-leopard.

1:00 PM Changeset in webkit [98132] by Lucas Forschler
  • 8 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94454.

12:58 PM Changeset in webkit [98131] by Lucas Forschler
  • 4 edits in branches/safari-534.52-branch/Source

Merged r94371.

12:56 PM Changeset in webkit [98130] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Fix r98125 by having duplicate entries for Win Debug.

  • platform/chromium/test_expectations.txt:
12:56 PM Changeset in webkit [98129] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r94340.

12:54 PM Changeset in webkit [98128] by Lucas Forschler
  • 7 edits in branches/safari-534.52-branch/Source

Merged r94298.

12:53 PM Changeset in webkit [98127] by kerz@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/html/HTMLKeygenElement.cpp

Hand merge of patch for bug 70617 from Gaurav Shah

12:51 PM Changeset in webkit [98126] by Lucas Forschler
  • 14 edits
    2 copies in branches/safari-534.52-branch/Source/WebKit2

Merged 94115.

12:43 PM Changeset in webkit [98125] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: The test is now also failing on debug on XP.
12:38 PM Changeset in webkit [98124] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Advanced search results should be cleared on navigation.
​https://bugs.webkit.org/show_bug.cgi?id=70627

Reviewed by Pavel Feldman.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController):
(WebInspector.AdvancedSearchController.prototype._frameNavigated):

12:36 PM Changeset in webkit [98123] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add finalizer to JSObject
​https://bugs.webkit.org/show_bug.cgi?id=70336

Reviewed by Darin Adler.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor): Skip the call to the destructor
if we're a JSFinalObject, since the finalizer takes care of things.

  • runtime/JSCell.h:

(JSC::JSCell::~JSCell): Remove the GC validation due to a conflict with
future changes and the fact that we no longer always call the destructor, making
the information provided less useful.

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize): Add finalizer for JSObject.
(JSC::JSObject::allocatePropertyStorage): The first time we need to allocate out-of-line
property storage, we add a finalizer to ourself.

  • runtime/JSObject.h:
12:33 PM Changeset in webkit [98122] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark call-base-resolution.html as crashing on snow-leopard.
12:19 PM Changeset in webkit [98121] by adamk@chromium.org
  • 15 edits
    4 adds in trunk

[MutationObservers] Implement WebKitMutationObserver.observe for childList changes
​https://bugs.webkit.org/show_bug.cgi?id=68955

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-10-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a ChildListMutationScope object which manages the coalescing of
multiple child removals and additions within DOM operations into single childList
mutation records.

Note that this patch doesn't cover all the cases which can be coalesced (it only
covers ContainerNode.*, and Node.innerHTML/innerText). A separate bug,
​https://bugs.webkit.org/show_bug.cgi?id=70385, has been opened to track the
remaining cases.

Test: fast/mutation/observe-childList.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ChildListMutationScope.cpp: Added.

(WebCore::ChildListAccumulation::ChildListAccumulation::ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::~ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulation::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulation::dispatch):
(WebCore::ChildListAccumulation::ChildListAccumulation::clear):
(WebCore::ChildListAccumulation::ChildListAccumulation::isEmpty):
(WebCore::ChildListAccumulation::ChildListAccumulator::ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::~ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::initialize):
(WebCore::ChildListAccumulation::ChildListAccumulator::instance):
(WebCore::ChildListAccumulation::ChildListAccumulator::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulator::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulator::incrementScopingLevel):
(WebCore::ChildListAccumulation::ChildListAccumulator::decrementScopingLevel):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):

  • dom/ChildListMutationScope.h: Added.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChildren):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::setTextContent):
(WebCore::Node::registeredMutationObserversOfType):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::disconnect):

  • html/HTMLElement.cpp:

(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
  • fast/mutation/observe-childList-expected.txt: Added.
  • fast/mutation/observe-childList.html: Added.
11:43 AM Changeset in webkit [98120] by jchaffraix@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed gardening: rebaseline 2 tests (small color difference).

  • platform/chromium-linux-x86/fast/multicol: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
11:31 AM Changeset in webkit [98119] by caryclark@google.com
  • 24 edits
    689 adds in trunk/LayoutTests

Unreviewed gardening: second chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 706 of 712 files for brevity.]

  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.

...

  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-rtl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.
11:20 AM Changeset in webkit [98118] by jeffm@apple.com
  • 3 edits in trunk/WebKitLibraries

Focus rings are too thin in HiDPI in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=70396

Rename wkSetPatternBaseCTM() to wkSetBaseCTM().

Reviewed by Beth Dakin.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:13 AM Changeset in webkit [98117] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r98079.
​http://trac.webkit.org/changeset/98079
​https://bugs.webkit.org/show_bug.cgi?id=70624

The extensions tests enabled are failing on the Chromium Win
Dbg bot (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-21

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:12 AM Changeset in webkit [98116] by vsevik@chromium.org
  • 24 edits in branches/chromium/912

Merge 97851 - Web Inspector: Enable caseSensitive search / Regex support in advanced search.
​https://bugs.webkit.org/show_bug.cgi?id=70335

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get searchConfig):
(WebInspector.FileBasedSearchResultsPane.prototype._createSearchRegex):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.SearchResult):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.searchInContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.searchInContent):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.searchInContent):
(WebInspector.ContentProvider.prototype.searchInContent):

  • inspector/front-end/inspector.css:

(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel label.search-config-label):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-resource-expected.txt:
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt:
  • http/tests/inspector/search/search-in-script.html:

BUG=101007
TBR=​vsevik@chromium.org
Review URL: ​http://codereview.chromium.org/8371003

11:03 AM Changeset in webkit [98115] by mitz@apple.com
  • 3 edits
    6 adds in trunk

Column rules positioned incorrectly in vertical-rl block with horizontal border or padding
​https://bugs.webkit.org/show_bug.cgi?id=70622

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/multicol/vertical-lr/rules-with-border-before.html

fast/multicol/vertical-rl/rules-with-border-before.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Changed to use the physical left border and padding for the
left edge of the horizontal column rule.

LayoutTests:

  • fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • fast/multicol/vertical-lr/rules-with-border-before.html: Added.
  • fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • fast/multicol/vertical-rl/rules-with-border-before.html: Added.
10:55 AM Changeset in webkit [98114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] WebKit build does not respect QMAKE_MAC_SDK variable.
​https://bugs.webkit.org/show_bug.cgi?id=70596

Instead of only relying on DARWIN_MAJOR_VERSION we also
check QMAKE_MAC_SDK. In case QMAKE_MAC_SDK is not defined
we are still falling back to DARWIN_MAJOR_VERSION.

Patch by Andy Shaw <​andy.shaw@digia.com>

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-21
Reviewed by Noam Rosenthal.

10:46 AM Changeset in webkit [98113] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Flash of white when loading a page after a web process crash
​https://bugs.webkit.org/show_bug.cgi?id=70615
<rdar://problem/10306906>

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _processDidCrash]):
(-[WKView _didRelaunchProcess]):
Remove calls to setNeedsDisplay here.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):
Call setNeedsDisplay, but only if calling out to the loader client didn't relaunch the web process.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setPaintingEnabled):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::setPaintingEnabled):

  • WebProcess/WebPage/DrawingAreaImpl.h:

Add a way to disable painting completely for a drawing area.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Disable painting while setting up the web page, otherwise we'll get paint requests when we set the
active state of the web page.

10:41 AM Changeset in webkit [98112] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

10:39 AM Changeset in webkit [98111] by commit-queue@webkit.org
  • 3 edits
    3 adds
    3 deletes in trunk/LayoutTests

re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
​https://bugs.webkit.org/show_bug.cgi?id=70612

Patch by Elliot Poger <​epoger@google.com> on 2011-10-21
Reviewed by Adam Barth.

  • platform/chromium-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Added.
  • platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/chromium-mac/fast/repaint/continuation-after-outline-expected.png:
  • platform/chromium/test_expectations.txt:
10:39 AM Changeset in webkit [98110] by vsevik@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/inspector/front-end/ScriptsPanel.js

Merge 97777 - Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
​https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

BUG=101006
TBR=​vsevik@chromium.org
Review URL: ​http://codereview.chromium.org/8373002

10:32 AM Changeset in webkit [98109] by gyuyoung.kim@samsung.com
  • 13 edits in trunk/Source/WebKit/efl

[EFL] Change efl style local variables with WebKit coding Style.
​https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

In common with Bug 69073, this is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter local variable according to efl style. However, it's
more difficult for other reviewers to review EFL patches. So, this patch changes efl style
local variable with meaningful one.

  • Use *menu* instead of *o* in comment of ewk_contextmenu.cpp.
  • Use *list* instead of *l* local variable
  • Use *ewkPolicy* instead of *ewk_policy* in ewk_cookies.cpp
  • Use *smartData* instead of *sd* local variable for Ewk_XXXX_Smart_Data struct.
  • Use *width*, *height* instead of *w*, *h* local variables.
  • Use *scrollX*, *scrollY*, *scrollWidth*, *scrollHeight*, *centerX*, *centerY*, *deltaX*, *deltaY*,

*baseX*, *baseY* instead of *sx*, *sy*, *sw*, *sh*, *cx*, *cy*, *dx*, *dy*, *bx*, *by*.

  • Use *red*, *green*, *blue*, *alpha*, *contentRed*, *contentGreen*, *contentBlue* and *contentAlpha*

instead of *r*,*g*,*b*,*a*,*cr*,*cg*,*cb*,*ca*.

  • Use *tilePositionX*, *tilePositionY* instead of *ox*,*oy* in tiled backingstore files.
  • Use *object* instead of *obj*
  • Use *length* instead of *len*
  • Use *coreFrame* instead of *cf*
  • Use *buffer* instead of *buf*
  • Use *item* instead of *i*
  • Use *currentColumn*, *currentRow* instead of *m_col*, *m_row*
  • Remove "_" in local variable.
  • And so on.
  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_model.cpp:
  • ewk/ewk_view.cpp:
10:28 AM Changeset in webkit [98108] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Gtk] mousemove event always has metaKey == true
​https://bugs.webkit.org/show_bug.cgi?id=35299

Patch by Devdatta Deshpande <​pwjd73@motorola.com> on 2011-10-21
Reviewed by Martin Robinson.

Source/WebCore:

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state. Use GDK_META_MASK instead.

Test: platform/gtk/fast/events/event-sender-metakey.html

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

Tools:

  • DumpRenderTree/gtk/EventSender.cpp:

(gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
keyboard events. So making it in sync with WebCore files.
(mouseMoveToCallback): Sending modifier keys state for mouse move event.

LayoutTests:

For testing state of metaKey for mouse and keyboard events generated
using evnetSender object.

  • platform/gtk/fast/events/event-sender-metakey-expected.txt: Added.
  • platform/gtk/fast/events/event-sender-metakey.html: Added.
10:06 AM Changeset in webkit [98107] by vsevik@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 97702 - Web Inspector: Search in resource crashes when there is no resource with given url.
​https://bugs.webkit.org/show_bug.cgi?id=69767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/search-in-non-existing-resource.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResource):

LayoutTests:

  • http/tests/inspector/search/search-in-non-existing-resource-expected.txt: Added.
  • http/tests/inspector/search/search-in-non-existing-resource.html: Added.

BUG=101005
TBR=​vsevik@chromium.org
Review URL: ​http://codereview.chromium.org/8370003

10:04 AM Changeset in webkit [98106] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Style and Link elements' sheet() should return CSSStyleSheet.
​https://bugs.webkit.org/show_bug.cgi?id=70608

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-21
Reviewed by Antti Koivisto.

Return a CSSStyleSheet* instead of a StyleSheet* in these functions
since we know they are always CSSStyleSheets.
Also remove some now-unnecessary isCSSStyleSheet() checks.

  • dom/StyleElement.h:

(WebCore::StyleElement::sheet):

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:

(WebCore::HTMLLinkElement::sheet):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

9:58 AM Changeset in webkit [98105] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Advanced search is working very slowly and does not show searching progress.
​https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/inspector.css:

(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):

  • inspector/front-end/utilities.js:

():

9:42 AM Changeset in webkit [98104] by zmo@google.com
  • 8 edits in trunk/Source

Implement mechanism to enable privileged webgl extensions
​https://bugs.webkit.org/show_bug.cgi?id=70538

Reviewed by Darin Fisher.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::allowPrivilegedExtensions): check page/Settings flag.

  • page/Settings.cpp: Add the flag.

(WebCore::Settings::Settings):
(WebCore::Settings::setPrivilegedWebGLExtensionsEnabled):

  • page/Settings.h: Ditto.

(WebCore::Settings::privilegedWebGLExtensionsEnabled):

Source/WebKit/chromium:

  • public/WebSettings.h: Add the flag.
  • src/WebSettingsImpl.cpp: Ditto.

(WebKit::WebSettingsImpl::setPrivilegedWebGLExtensionsEnabled):

  • src/WebSettingsImpl.h: Ditto.
8:56 AM Changeset in webkit [98103] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: first line in file is not highlighted.
​https://bugs.webkit.org/show_bug.cgi?id=70504

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._initializeTextViewer):

8:43 AM Changeset in webkit [98102] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Simplify CSSStyleRule::setSelectorText().
​https://bugs.webkit.org/show_bug.cgi?id=70607

Reviewed by Antti Koivisto.

Remove unnecessary isCSSStyleSheet() check and redundant Document finding
logic (CSSStyleSheet::document() will return the owner node's Document just
like this code would.)

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

8:15 AM Changeset in webkit [98101] by caryclark@google.com
  • 1 edit
    712 adds in trunk/LayoutTests

Unreviewed gardening: first chunk of rebaselines for Chromium-Skia
on Leopard.

[Omitting 707 of 713 files for brevity.]

  • platform/chromium-mac-leopard/css1: Added.
  • platform/chromium-mac-leopard/css1/basic: Added.
  • platform/chromium-mac-leopard/css1/basic/class_as_selector-expected.png: Added.

...

  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
7:33 AM Changeset in webkit [98100] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing a11y test in GTK.

  • platform/gtk/Skipped: Skip accessibility/menu-list-sends-change-notification.html
7:16 AM Changeset in webkit [98099] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 3 new tests.

  • platform/gtk/fast/css/clip-text-in-scaled-div-expected.txt: Added.
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Added.
  • platform/gtk/fast/selectors/visited-descendant-expected.txt: Added.
6:47 AM Changeset in webkit [98098] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

watchlist: Add a new entry for WebKit2 GTK+ public API
​https://bugs.webkit.org/show_bug.cgi?id=70601

Reviewed by Philippe Normand.

Subscribe myself to WebKit2 GTK+ API patches. Also add a message
for patches that might include new API that points to the WebKit2
GTK+ API guidelines.

  • Scripts/webkitpy/common/config/watchlist:
6:36 AM Changeset in webkit [98097] by caryclark@google.com
  • 492 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening: rebaselining to account for focus ring changes in
​http://trac.webkit.org/changeset/97971

  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Added.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png: Added.
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png:
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
  • platform/chromium-mac/fast/css/outline-auto-location-expected.png:
  • platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-mac/fast/inline/25277-2-expected.png:
  • platform/chromium-mac/fast/inline/25277-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac/fast/repaint/focus-ring-expected.png:
  • platform/chromium-mac/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium/test_expectations.txt:
5:43 AM Changeset in webkit [98096] by alex
  • 2 edits in trunk/Source/WebCore

2011-10-21 Alejandro G. Castro <​alex@igalia.com>

[cairo] Forward declaration of GraphicsContextState uses class instead of struct
​https://bugs.webkit.org/show_bug.cgi?id=70522

The type is a struct not a class, replace the definition in the
forward declaration.

Reviewed by Martin Robinson.

  • platform/graphics/cairo/PlatformContextCairo.h:
5:39 AM Changeset in webkit [98095] by yurys@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: remove debugger support for out-of-process dedicated workers
​https://bugs.webkit.org/show_bug.cgi?id=70602

Now that Chromium uses in-process dedicated workers, remove support for out-of-process
dedicated workers debugger.

Reviewed by Pavel Feldman.

  • public/WebWorker.h:
  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):

  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp:
  • src/WebWorkerImpl.h:
5:02 AM Changeset in webkit [98094] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/events/touch/page-scaled-touch-gesture-click.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=70593

It was introduced in r97988. Skip it.

  • platform/qt/Skipped:
4:02 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Add comments about new public headers (diff)
3:56 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Add comment about includes (diff)
3:46 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Add point about C API (diff)
3:37 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
3:28 AM HackingGtk edited by Carlos Garcia Campos
Add link to WebKit2 new API guidelines (diff)
3:26 AM Changeset in webkit [98093] by Simon Hausmann
  • 7 edits
    47 deletes in trunk

Remove QtScript source code from WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=64088

Reviewed by Tor Arne Vestbø.

Removed dead code that isn't developed anymore.

.:

  • Source/WebKit.pro:

Source/JavaScriptCore:

  • JavaScriptCore.gypi:
  • JavaScriptCore.pri:
  • qt/api/QtScript.pro: Removed.
  • qt/api/qscriptconverter_p.h: Removed.
  • qt/api/qscriptengine.cpp: Removed.
  • qt/api/qscriptengine.h: Removed.
  • qt/api/qscriptengine_p.cpp: Removed.
  • qt/api/qscriptengine_p.h: Removed.
  • qt/api/qscriptfunction.cpp: Removed.
  • qt/api/qscriptfunction_p.h: Removed.
  • qt/api/qscriptoriginalglobalobject_p.h: Removed.
  • qt/api/qscriptprogram.cpp: Removed.
  • qt/api/qscriptprogram.h: Removed.
  • qt/api/qscriptprogram_p.h: Removed.
  • qt/api/qscriptstring.cpp: Removed.
  • qt/api/qscriptstring.h: Removed.
  • qt/api/qscriptstring_p.h: Removed.
  • qt/api/qscriptsyntaxcheckresult.cpp: Removed.
  • qt/api/qscriptsyntaxcheckresult.h: Removed.
  • qt/api/qscriptsyntaxcheckresult_p.h: Removed.
  • qt/api/qscriptvalue.cpp: Removed.
  • qt/api/qscriptvalue.h: Removed.
  • qt/api/qscriptvalue_p.h: Removed.
  • qt/api/qscriptvalueiterator.cpp: Removed.
  • qt/api/qscriptvalueiterator.h: Removed.
  • qt/api/qscriptvalueiterator_p.h: Removed.
  • qt/api/qtscriptglobal.h: Removed.
  • qt/benchmarks/benchmarks.pri: Removed.
  • qt/benchmarks/benchmarks.pro: Removed.
  • qt/benchmarks/qscriptengine/qscriptengine.pro: Removed.
  • qt/benchmarks/qscriptengine/tst_qscriptengine.cpp: Removed.
  • qt/benchmarks/qscriptvalue/qscriptvalue.pro: Removed.
  • qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp: Removed.
  • qt/tests/qscriptengine/qscriptengine.pro: Removed.
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: Removed.
  • qt/tests/qscriptstring/qscriptstring.pro: Removed.
  • qt/tests/qscriptstring/tst_qscriptstring.cpp: Removed.
  • qt/tests/qscriptvalue/qscriptvalue.pro: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue.h: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Removed.
  • qt/tests/qscriptvalueiterator/qscriptvalueiterator.pro: Removed.
  • qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp: Removed.
  • qt/tests/tests.pri: Removed.
  • qt/tests/tests.pro: Removed.

Tools:

  • Scripts/webkitpy/style/checker_unittest.py:
3:05 AM WebKitGTK/AddingNewWebKit2API created by Carlos Garcia Campos
Initial guidelines for adding new API to WebKit2 GTK+
2:15 AM Changeset in webkit [98092] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt][WK2] Typo fix.

  • tests/util.h:
2:11 AM Changeset in webkit [98091] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk

bytecompiler sometimes generates incorrect bytecode for put_by_id
​https://bugs.webkit.org/show_bug.cgi?id=70403

Patch by Zheng Liu <​zheng.z.liu@intel.com> on 2011-10-21
Reviewed by Filip Pizlo.

  • bytecompiler/NodesCodegen.cpp:

(JSC::AssignDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):

2:08 AM Changeset in webkit [98090] by Csaba Osztrogonác
  • 4 edits in trunk/Source

[Qt][WK2] Buildfix for newer Qt5. Remove duplicated defines.

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
2:00 AM Changeset in webkit [98089] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-10-21 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK+ build after r98081.

  • UIProcess/API/gtk/WebKitWebView.h:
1:55 AM Changeset in webkit [98088] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r98085.
​http://trac.webkit.org/changeset/98085
​https://bugs.webkit.org/show_bug.cgi?id=70589

It broke the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-21

Source/WebKit/qt:

  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
1:49 AM Changeset in webkit [98087] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] 2 inspector/extensions tests times out on Mac and linux after r97850
​https://bugs.webkit.org/show_bug.cgi?id=70414

Unreviewed. Skipped inspector/extensions/extensions-{events,network}.html

  • platform/qt/Skipped:
1:44 AM Changeset in webkit [98086] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix API documentation comment for webkit_web_view_get_estimated_load_progress()
​https://bugs.webkit.org/show_bug.cgi?id=70587

Reviewed by Philippe Normand.

It's should start with / to be recognized as API documentation.

  • UIProcess/API/gtk/WebKitWebView.cpp:
1:44 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the WK2 bot (diff)
1:40 AM Changeset in webkit [98085] by Csaba Osztrogonác
  • 4 edits in trunk/Source

[Qt][WK2] Unreviewed buildfix for newer Qt5. Remove duplicated defines.

Source/WebKit/qt:

  • tests/util.h:

(waitForSignal):

Source/WebKit2:

  • UIProcess/API/qt/tests/util.h:
1:32 AM Changeset in webkit [98084] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
​https://bugs.webkit.org/show_bug.cgi?id=65680

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-10-21
Reviewed by Ryosuke Niwa.

Generally API methods using macros NULL checking in WebKit-EFL.
The macros ensure that code is smaller, version of view object
is checked and error message is displayed if NULL is passed.

  • ewk/ewk_view.cpp:

(ewk_view_mode_get):

1:24 AM Changeset in webkit [98083] by tkent@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Add tests to check behavior of border attribute with a large number or an invalid value.
​https://bugs.webkit.org/show_bug.cgi?id=69055

Reviewed by Daniel Bates.

r96290 changed the behavior of integer parsing so that large
number strings which can not be represented in 32 bit integers
makes an error. However, border attribute behavior wasn't changed
by r96290 because its default value is 0 and
parseHTMLNonNegativeInteger() had set 0 in a case of overflow.

  • fast/dom/HTMLImageElement/image-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLImageElement/image-with-invalid-border.html: Added.
  • fast/dom/HTMLInputElement/input-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLInputElement/input-with-invalid-border.html: Added.
  • fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html: Added.
  • fast/dom/HTMLObjectElement/object-with-invalid-border.html: Added.
1:19 AM Changeset in webkit [98082] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should not try to predict argument types by looking at the values of
argument registers at the time of compilation
​https://bugs.webkit.org/show_bug.cgi?id=70578

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:
  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):

1:17 AM Changeset in webkit [98081] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=69823

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):

  • UIProcess/API/gtk/WebKitWebView.h:
1:09 AM Changeset in webkit [98080] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=69610

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_stop_loading):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(provisionalLoadFailedCallback):
(loadFailedCallback):

  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(LoadStopTrackingTest::loadCommitted):
(LoadStopTrackingTest::loadFailed):
(LoadStopTrackingTest::loadFinished):
(testLoadCancelled):
(serverCallback):
(beforeAll):

12:51 AM Changeset in webkit [98079] by caseq@chromium.org
  • 9 edits
    2 adds in trunk

Web Inspector: make extension tests pass on chromium
​https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

LayoutTests:

  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/resources/extension-main.js:

():

  • inspector/extensions/extensions-audits.html:
  • inspector/extensions/extensions-console.html:
  • inspector/extensions/extensions-resources.html:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:19 AM Changeset in webkit [98078] by Csaba Osztrogonác
  • 919 edits in trunk/LayoutTests

[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
even if the family does not match.
​https://bugs.webkit.org/show_bug.cgi?id=55036

Unreviewed. Update tests after r97990, and unskip them. (part 6)

  • platform/qt/tables/: [...]
  • platform/qt/transforms/: [...]
  • platform/qt/transitions/: [...]
  • platform/qt/Skipped:
12:07 AM Changeset in webkit [98077] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Test expectation change: fast/canvas/webgl/WebGLContextEvent.html now passes.

Unreviewed. The test passes since ​http://trac.webkit.org/changeset/98044/

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.