Timeline
Apr 16, 2012:
- 11:51 PM April 2012 Meeting edited by
- (diff)
- 11:45 PM Changeset in webkit [114352] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files.
Source/WebCore:
- GNUmakefile.list.am: Add missing files.
- 11:40 PM Changeset in webkit [114351] by
-
- 106 edits1 add in trunk/Source/WebCore
insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701
Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.
This change makes following change to merge these functions.
- pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
- letting new Node::insertInto() do the job for its own, but not for its children and
- Pass the parent of each insertion root as a parameter of insertedInto(). This root node can tell inserted node where it is inserted, specifically whetehr the insertion is to the document or not.
Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.
Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.
Caveat:
There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that. It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.
No new tests. Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):
- dom/ContainerNode.h:
(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):
- dom/ContainerNodeAlgorithms.cpp: Added.
(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
- dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):
- dom/DOMAllInOne.cpp:
- dom/DocumentType.cpp:
(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):
- dom/DocumentType.h:
(DocumentType):
- dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- dom/Element.h:
(Element):
- dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):
- dom/Node.h:
(Node):
(WebCore::Node::didNotifyDescendantInseretions):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
- dom/ProcessingInstruction.h:
(ProcessingInstruction):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::insertedInto):
- dom/ScriptElement.h:
(WebCore):
(ScriptElement):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
- dom/ShadowTree.h:
(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
- html/FormAssociatedElement.h:
(FormAssociatedElement):
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):
- html/HTMLBaseElement.h:
(HTMLBaseElement):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):
- html/HTMLFormElement.h:
(HTMLFormElement):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):
- html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):
- html/HTMLInputElement.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
- html/HTMLLinkElement.h:
(HTMLLinkElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
- html/HTMLMapElement.h:
(HTMLMapElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::insertedInto):
- html/HTMLMetaElement.h:
(HTMLMetaElement):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):
- html/HTMLObjectElement.h:
(HTMLObjectElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto):
- html/HTMLOptionElement.h:
(HTMLOptionElement):
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
- html/HTMLQuoteElement.h:
(HTMLQuoteElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
- html/HTMLScriptElement.h:
(HTMLScriptElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto):
- html/HTMLSelectElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
- html/HTMLSourceElement.h:
(HTMLSourceElement):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
- html/HTMLStyleElement.h:
(HTMLStyleElement):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
- html/HTMLTextFormControlElement.h:
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):
- html/HTMLTitleElement.h:
(HTMLTitleElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto):
- html/HTMLTrackElement.h:
(HTMLTrackElement):
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
- mathml/MathMLMathElement.h:
(MathMLMathElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):
- svg/SVGFEImageElement.h:
(SVGFEImageElement):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):
- svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::insertedInto):
- svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):
- svg/SVGGlyphElement.h:
(SVGGlyphElement):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGHKernElement.h:
(SVGHKernElement):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::insertedInto):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
- svg/SVGSVGElement.h:
(SVGSVGElement):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
- svg/SVGScriptElement.h:
(SVGScriptElement):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):
- svg/SVGStyleElement.h:
(SVGStyleElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
- svg/SVGStyledElement.h:
(SVGStyledElement):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):
- svg/SVGTRefElement.h:
(SVGTRefElement):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
- svg/SVGTitleElement.h:
(SVGTitleElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
- svg/SVGUseElement.h:
(SVGUseElement):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- svg/SVGVKernElement.h:
(SVGVKernElement):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
- 11:26 PM Changeset in webkit [114350] by
-
- 3 edits3 adds in trunk
Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
- http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
- http/tests/css/css-imports-redirect-cycle.css: Added.
- http/tests/css/css-imports-redirect-cycle.html: Added.
- 11:22 PM Changeset in webkit [114349] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 11:11 PM Changeset in webkit [114348] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054
- chromium/public/WebFilterOperations.h:
(WebKit): WebFilterOperation is a struct, not a class.
- 10:57 PM Changeset in webkit [114347] by
-
- 5 edits1 move in trunk/Source
Rename LocalizedNumberICU.h to ICULocale.h
https://bugs.webkit.org/show_bug.cgi?id=84119
Reviewed by Kentaro Hara.
Source/WebCore:
LocalizedNumberICU.h contains only ICULocale class. It should be
named as ICULocale.h. We're going to move some functions in
LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale,
and add unit tests for them.
- WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h
- platform/text/ICULocale.h:
Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h.
- platform/text/LocalizedNumberICU.cpp:
Rename LocalizedNumberICU.h to ICULocale.h
Source/WebKit/chromium:
- tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h
- 10:49 PM Changeset in webkit [114346] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip one more worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125
- platform/chromium/test_expectations.txt:
- 10:46 PM Changeset in webkit [114345] by
-
- 1 edit2 adds in trunk/Source/WebKit2
[EFL][WK2] Add missing files to build webkit2/Efl.
https://bugs.webkit.org/show_bug.cgi?id=76139
Reviewed by Ryosuke Niwa.
Add missing files needed to build webkit2/Efl.
- Shared/efl/PlatformCertificateInfo.h: Added.
(WebKit):
(PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
- UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Added.
(WebKit):
(WebKit::ThreadLauncher::createWebThread):
- 10:36 PM Changeset in webkit [114344] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066
Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.
WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
- platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
- 10:28 PM Changeset in webkit [114343] by
-
- 8 edits4 adds in trunk/Source
[chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebFilterOperation.h: Added.
(WebKit):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBlurFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebDropShadowFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):
- chromium/public/WebFilterOperations.h: Added.
(WebKit):
(WebFilterOperations):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
Source/WebCore:
Adds WebFilterOperation that wraps WebCore::FilterOperation and
WebFilterOperations that wraps WebCore::FilterOperations.
We add support for most of the FilterOperation subclasses, and
allow the user to set the WebFilterOperations for both layer
content filters and background filters.
- WebCore.gypi:
- platform/chromium/support/WebFilterOperation.cpp: Added.
(WebKit):
(WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation):
(WebKit::WebBlurFilterOperation::toFilterOperation):
(WebKit::WebDropShadowFilterOperation::toFilterOperation):
- platform/chromium/support/WebFilterOperations.cpp: Added.
(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::toFilterOperations):
Source/WebKit/chromium:
- WebKit.gyp:
- src/WebLayer.cpp:
(WebKit::WebLayer::setFilters):
(WebKit):
(WebKit::WebLayer::setBackgroundFilters):
- 10:08 PM Changeset in webkit [114342] by
-
- 2 edits in trunk/Source/WebCore
Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.
No new tests. The repro steps require using Chrome notifications on Win.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 10:08 PM Changeset in webkit [114341] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove invalid text expectation for Snow Leopard.
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
- 10:07 PM Changeset in webkit [114340] by
-
- 1 copy in tags/Safari-534.57.1
New tag.
- 9:32 PM Changeset in webkit [114339] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove useless text expectation for WinXP
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
- 9:09 PM Changeset in webkit [114338] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125
- platform/chromium/test_expectations.txt:
- 8:58 PM Changeset in webkit [114337] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
- DEPS:
- 8:42 PM Changeset in webkit [114336] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116
Reviewed by Kentaro Hara.
This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().
- src/WebPagePopupImpl.h:
(WebPagePopupImpl): Rename an argument name.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().
- 8:38 PM April 2012 Meeting edited by
- (diff)
- 8:04 PM Changeset in webkit [114335] by
-
- 16 edits2 copies1 move in trunk/Source
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
https://bugs.webkit.org/show_bug.cgi?id=83963
Reviewed by Adrienne Walker.
Source/Platform:
Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface.
- Platform.gypi:
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebLayer.h:
(WebLayer):
(WebKit::WebLayer::unwrap):
- chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h.
(WebKit):
(WebVideoFrameProvider):
(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider):
(Client):
- chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::~WebVideoLayer):
Source/WebCore:
Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a
WebCore VideoFrameProvider.
- WebCore.gypi:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
- platform/graphics/chromium/VideoLayerChromium.h:
(WebKit):
(WebCore):
(VideoLayerChromium):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):
(CCVideoLayerImpl):
Source/WebKit/chromium:
Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it.
WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer()
interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer.
- WebKit.gyp:
- src/WebContentLayer.cpp:
- src/WebLayer.cpp:
(WebKit::WebLayer::invalidate):
(WebKit):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
- 7:55 PM Changeset in webkit [114334] by
-
- 6 edits in trunk
[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010
Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-16
Reviewed by Hajime Morita.
This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point
Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.
- html/shadow/InsertionPoint.h:
(InsertionPoint):
Added isActive public method.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.
- 7:33 PM April 2012 Meeting edited by
- (diff)
- 7:15 PM Changeset in webkit [114333] by
-
- 3 edits in trunk/Source/WebCore
Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299
Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.
Reviewed by Antti Koivisto.
No new tests. No bahavior change.
- dom/Node.cpp:
(WebCore):
- dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):
- 7:02 PM Changeset in webkit [114332] by
-
- 2 edits in trunk/Tools
[GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball
- 6:06 PM Changeset in webkit [114331] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110150
- 5:55 PM Changeset in webkit [114330] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107
broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
- fast/media/media-query-list-08-expected.txt: Removed.
- fast/media/media-query-list-08.html: Removed.
- platform/qt/Skipped:
- 5:48 PM Changeset in webkit [114329] by
-
- 5 edits1 add in trunk/Source/WebKit/chromium
Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebMediaPlayer.h:
(WebKit):
- public/WebMediaPlayerClient.h:
- public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.
(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):
- src/AssertMatchingEnums.cpp:
- 5:47 PM WebKitGTK/1.8.x edited by
- (diff)
- 5:47 PM Changeset in webkit [114328] by
-
- 3 edits in trunk/Source/WebCore
Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100
Reviewed by Alexey Proskuryakov.
No new tests, removing dead code.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):
- 5:35 PM Changeset in webkit [114327] by
-
- 2 edits in trunk/Source/WebKit2
Followup to http://trac.webkit.org/changeset/114323
For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.
Reviewed by Mark Rowe.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- 5:35 PM Changeset in webkit [114326] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r114322.
http://trac.webkit.org/changeset/114322
https://bugs.webkit.org/show_bug.cgi?id=84096
Didn't make the debug bot happy, so back out
- gtk/jhbuild.modules:
- 5:28 PM Changeset in webkit [114325] by
-
- 6 edits in trunk/Source/WebCore
Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
<http://webkit.org/b/83988>
Reviewed by Antti Koivisto.
Remove the 'context style sheet' argument to <font face> value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.
- css/CSSParser.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
- css/CSSValuePool.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
- 5:21 PM Changeset in webkit [114324] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543
Reviewed by Adrienne Walker.
It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.
One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.
Covered by existing tests.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- 5:21 PM Changeset in webkit [114323] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit
Reviewed by Jessie Berlin.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one.
- 5:18 PM Changeset in webkit [114322] by
-
- 2 edits in trunk/Tools
[GTK] Try to fix debug bot by adding gobject-introspection to the build
https://bugs.webkit.org/show_bug.cgi?id=84096
Unreviewed speculative build fix.
- gtk/jhbuild.modules: Added gobject-introspection, since modules need
an up-to-date introspection m4 for running autogen.
- 5:17 PM Changeset in webkit [114321] by
-
- 2 edits in trunk/LayoutTests
Add two flaky tests in fast/profiler.
- platform/mac/Skipped:
- 4:53 PM Changeset in webkit [114320] by
-
- 3 edits2 adds in trunk
[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831
Reviewed by Nate Chapin.
Source/WebCore:
Test: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
LayoutTests:
- http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
- http/tests/security/isolatedWorld/context-destroy.html: Added.
- 4:50 PM Changeset in webkit [114319] by
-
- 12 edits in trunk/Source/WebCore
Add V8 code generation support for MessagePortArray attributes.
https://bugs.webkit.org/show_bug.cgi?id=83943
Patch by Greg Billock <gbillock@google.com> on 2012-04-16
Reviewed by Kentaro Hara.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::ports):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_get_ports):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface ports]):
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
- 4:45 PM Changeset in webkit [114318] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:37 PM Changeset in webkit [114317] by
-
- 17 edits in trunk
Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097
it broke everything (Requested by olliej on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- bytecode/CodeBlock.h:
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1):
- fast/js/stack-trace-expected.txt:
- 4:32 PM Changeset in webkit [114316] by
-
- 2 edits in trunk/Source/WebCore
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521
Reviewed by David Levin.
No functionality change, so no new tests.
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
- 4:24 PM Changeset in webkit [114315] by
-
- 9 edits in trunk/Source/WebCore
Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063
Reviewed by Eric Seidel.
In an effort to prevent misuse, we previously decided to have borderBoxRect return a
pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned
at (0,0), and therefore won't snap to the same size as the element it's covering.
There are a couple uses of borderBoxRect that don't pixel snap the values and require
sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping
explicit, and moves uses that would otherwise pixel snap the rect to this version to
avoid producing a rect of the incorrect size. For details about pixel snapping with
LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit
No new tests. No change in behavior.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addVisualOverflowFromTheme):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
(WebCore::RenderBox::pixelSnappedBorderBoxRect):
(WebCore::RenderBox::borderBoundingBox):
(WebCore::RenderBox::hasVisualOverflow):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromChildren):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
- 4:19 PM Changeset in webkit [114314] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaseline continued from xji's rebase after r114267.
Unreviewed.
- platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added.
- 4:10 PM Changeset in webkit [114313] by
-
- 6 edits11 adds11 deletes in trunk/LayoutTests
Unreviewed gardening for ietestcenter/grid. Adding reference tests
and removing gtk expected.txt
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-16
- ietestcenter/css3/grid/display-grid-001-expected.htm: Added.
- ietestcenter/css3/grid/display-grid-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-003-expected.htm: Added.
- ietestcenter/css3/grid/grid-columns-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-003-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-004-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-005-expected.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Removed.
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 3:54 PM Changeset in webkit [114312] by
-
- 2 edits in trunk/Tools
[GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086
Unreviewed build fix.
- gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.
- 3:50 PM Changeset in webkit [114311] by
-
- 2 edits in trunk/Source/WebCore
Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091
Reviewed by Andreas Kling.
Null check triggeringEvent.
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
- 3:27 PM Changeset in webkit [114310] by
-
- 15 edits in branches/subpixellayout
Reverting unnecessary changes to RenderRubyRun, and applying the patch from webkit.org/b/84063.
- 3:26 PM Changeset in webkit [114309] by
-
- 17 edits in trunk
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOriginIndexForReturn):
(CodeBlock):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
Update tests to include new exception property ordering, and new functions
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1): Modified slightly so that we produce consistent traces
- fast/js/stack-trace-expected.txt:
- 3:25 PM Changeset in webkit [114308] by
-
- 2 edits in trunk/Tools
[GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
includes a phony clean target that should make warnings and errors go
away.
- 3:19 PM Changeset in webkit [114307] by
-
- 5 edits in trunk/Source/WebKit/mac
Use a MIG call when creating a plug-in property list file
https://bugs.webkit.org/show_bug.cgi?id=84084
<rdar://problem/11197341>
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::createPropertyListFile):
Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.
- Plugins/Hosted/WebKitPluginHost.defs:
Add PHCreatePluginMIMETypesPreferences.
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage createPropertyListFile]):
NetscapePluginHostManager::createPropertyListFile is no longer a static member function.
- 3:14 PM Changeset in webkit [114306] by
-
- 2 edits in trunk/LayoutTests
Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=83965
Patch by David Alcala <dalcala@adobe.com> on 2012-04-16
Reviewed by Dirk Schulze.
- platform/chromium/test_expectations.txt:
- 3:09 PM Changeset in webkit [114305] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.
Unreviewed.
- platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
- platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
- 3:05 PM Changeset in webkit [114304] by
-
- 2 edits in trunk
Re-add GPU DEPS builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=84056
Patch by Dave Tu <dtu@chromium.org> on 2012-04-16
Reviewed by Ojan Vafai.
- Tools/TestResultServer/static-dashboards/builders.js:
- 3:05 PM Changeset in webkit [114303] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Supressing test errors introduced by http://trac.webkit.org/changeset/114283.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:02 PM Changeset in webkit [114302] by
-
- 3 edits in trunk/Source/WebCore
Rename to updateZOrderListsSlowCase to rebuildZOrderLists
https://bugs.webkit.org/show_bug.cgi?id=84071
Reviewed by Antti Koivisto.
Use a better name for updateZOrderListsSlowCase().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::rebuildZOrderLists):
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::updateZOrderLists):
- 2:50 PM Changeset in webkit [114301] by
-
- 6 edits in trunk/Source
[chromium] Allow WebGestureEvent to store four floating point values
https://bugs.webkit.org/show_bug.cgi?id=84053
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
See bug description for an explanation of the changes made.
Source/WebCore:
- platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
(WebCore::PlatformGestureEvent::gammaX):
(WebCore::PlatformGestureEvent::gammaY):
Source/WebKit/chromium:
- public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 2:44 PM Changeset in webkit [114300] by
-
- 4 edits1 add1 delete in trunk/LayoutTests
[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
https://bugs.webkit.org/show_bug.cgi?id=84082
Unreviewed Chromium test expectations update.
Results look right but the test maybe flaky.
- platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
- platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png:
- platform/chromium-mac/svg/hixie/error/012-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 2:33 PM Changeset in webkit [114299] by
-
- 12 edits3 deletes in trunk/LayoutTests
[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
https://bugs.webkit.org/show_bug.cgi?id=84075
Unreviewed Chromium expectations update.
- platform/chromium-linux-x86/svg/as-image: Removed.
- platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
- platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium/test_expectations.txt:
- svg/hixie/perf/001-expected.txt: Removed.
- svg/hixie/perf/002-expected.txt: Removed.
- 2:19 PM Changeset in webkit [114298] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring][V8] Remove $indent from NativeToJSValue()
https://bugs.webkit.org/show_bug.cgi?id=84077
Reviewed by Nate Chapin.
$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used.
This patch removes it.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- 2:19 PM Changeset in webkit [114297] by
-
- 4 edits1 delete in trunk
[GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060
Rubber-stamped by Martin Robinson.
.:
- configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we
already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.
Tools:
- gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
to their GNOME 3.4 versions.
- gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
is applied upstream.
- 2:02 PM Changeset in webkit [114296] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking failing test platform/chromium/compositing/filters/background-filter-blur-outsets.html.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 2:02 PM Changeset in webkit [114295] by
-
- 8 edits in trunk/Source/WebKit2
Nightly Back/Forward no longer calls plug-in's NPP_NewStream
https://bugs.webkit.org/show_bug.cgi?id=83805
<rdar://problem/11238748>
Reviewed by Simon Fraser.
When a page with a full-frame plug-in is restored from the page cache, it needs to re-fetch the plug-in stream.
Fix this by breaking the assumption that a plug-in will always get its data from WebCore if it's a full-frame plug-in;
instead it only get its data from WebCore if it's a full-frame plug-in that's not being restored from the page cache.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Rename m_loadManually to m_shouldUseManualLoader.
(WebKit::NetscapePlugin::initialize):
Get the mode from parameters.isFullFramePlugin instead.
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
Rename m_loadManually to m_shouldUseManualLoader.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Rename m_loadManually to m_shouldUseManualLoader.
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h:
(Parameters):
Add an extra isFullFramePlugin parameter, and rename loadManually to shouldUseManualLoader.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameCameFromPageCache.
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Set m_frameCameFromPageCache to true.
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Set m_frameCameFromPageCache to false.
(WebKit::WebFrameLoaderClient::createPlugin):
Initialize isFullFramePlugin and shouldUseManualLoader.
- 1:57 PM Changeset in webkit [114294] by
-
- 3 edits2 adds in trunk/LayoutTests
[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=84069
Unreviewed Chromium test expectations update.
Finally closing out an expectations update from 2009.
- platform/chromium-mac-leopard/svg/filters/sourceAlpha-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png:
- platform/chromium-mac/svg/filters/sourceAlpha-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:32 PM Changeset in webkit [114293] by
-
- 3 edits10 adds10 deletes in trunk/LayoutTests
[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
https://bugs.webkit.org/show_bug.cgi?id=84064
Unreviewed Chromium expectations update.
One of these results, for svg/filters/filter-source-position.svg, is
incorrect, but it should be updated regardless.
- platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/filter-clip-expected.png: Added.
- platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win/svg/filters/filter-clip-expected.png: Added.
- platform/chromium-win/svg/filters/filter-source-position-expected.png: Added.
- platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/svg/filters/filter-source-position-expected.png: Removed.
- platform/efl/svg/filters/filter-source-position-expected.txt: Removed.
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/gtk/svg/filters/filter-source-position-expected.png: Removed.
- platform/gtk/svg/filters/filter-source-position-expected.txt: Removed.
- platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/mac/svg/filters/filter-source-position-expected.txt: Removed.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/qt/svg/filters/filter-source-position-expected.txt: Removed.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- svg/filters/filter-source-position-expected.png: Added.
- svg/filters/filter-source-position-expected.txt: Added.
- svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- 1:26 PM Changeset in webkit [114292] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position-composited-page-scale-down.
Unreviewed.
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- 1:14 PM Changeset in webkit [114291] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove BlobRegistryProxy::createResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=84047
Reviewed by Nate Chapin.
- src/BlobRegistryProxy.h: (BlobRegistryProxy::createResourceHandle): This function
is no longer used.
- 1:08 PM Changeset in webkit [114290] by
-
- 1 edit3 adds in trunk/LayoutTests
RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431
Add a test case for Bug 80431. It renders a 1x1 svg as an image with percent
width/height specified.
Patch by Yong Li <yoli@rim.com> on 2012-04-16
Reviewed by Nikolas Zimmermann.
- svg/as-image/resources/rect-1x1.svg: Added.
- svg/as-image/svg-as-image-with-relative-size-expected.html: Added.
- svg/as-image/svg-as-image-with-relative-size.html: Added.
- 1:05 PM Changeset in webkit [114289] by
-
- 3 edits in trunk/LayoutTests
Reverting shader-precision-format.html reftest fix - it only fixed some DBG builders. Marking test failing for those.
Unreviewed.
- fast/canvas/webgl/shader-precision-format-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:00 PM Changeset in webkit [114288] by
-
- 2 edits in trunk/Source/WebKit/blackberry
2012-04-16 Antonio Gomes <agomes@rim.com>
Screen shift down when VKB shows by clicking in a input box MKS_3601371
PR #149846
Reviewed by Rob Buis.
After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
we had a less restricted code path allowing/disallowing overscrolling. That caused
some webpages like google.com to get on overscroll when adjusting the scroll
position to ensure the focused input field is visible.
Patch restricts the way we allow overscrolling to the bottom, where the virtual
keyboard pops up from, clamping it to 0, 0 if it tries to
overscroll upwards, and to maximum scroll position if it overscrolls
downwards.
Internally reviewed by Mike Fenton.
PR #149846
- WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 12:34 PM Changeset in webkit [114287] by
-
- 3 edits7 adds in trunk/LayoutTests
Rebaseline after r114267.
- platform/chromium-linux/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-mac/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png:
- platform/chromium/test_expectations.txt:
- 11:52 AM Changeset in webkit [114286] by
-
- 2 edits in trunk/Source/WebKit2
EndPrinting message should be sent synchronously when printing was initiated from DOM.
https://bugs.webkit.org/show_bug.cgi?id=84049
<rdar://problem/11096575>
Reviewed by Oliver Hunt.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): When printing is initiated by WebProcess, all messages from UI process are sent synchronously to avoid being queued, and so should EndPrinting.
- 11:45 AM Changeset in webkit [114285] by
-
- 6 edits2 adds in trunk
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903
Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-16
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/media-query-list-08.html
Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.
The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.
- dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
Testing MediaQueryLists listeners related to viewport changes.
- fast/media/media-query-list-08-expected.txt: Added.
- fast/media/media-query-list-08.html: Added.
Skipping the new test in Qt due to an issue in its DumpRenderTree.
- platform/qt/Skipped:
- 11:41 AM Changeset in webkit [114284] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Delete uncalled unreserveContentsTextures function
https://bugs.webkit.org/show_bug.cgi?id=84005
Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.
This is vestigal dead code.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- 11:32 AM Changeset in webkit [114283] by
-
- 14 edits7 adds in trunk
Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547
Source/WebCore:
Reviewed by Dean Jackson.
If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.
This saves backing store memory on some pages.
Tests: compositing/backing/no-backing-for-clip-overlap.html
compositing/backing/no-backing-for-clip.html
compositing/backing/no-backing-for-perspective.html
- rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):
- rendering/RenderLayerCompositor.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
LayoutTests:
Reviewed by Dean Jackson.
New tests for backing store elimination with clip or perspective.
New results for some tests that no longer have backing store on some
layers.
- compositing/backing/no-backing-for-clip-expected.txt: Added.
- compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- compositing/backing/no-backing-for-clip-overlap.html: Added.
- compositing/backing/no-backing-for-clip.html: Added.
- compositing/backing/no-backing-for-perspective-expected.txt: Added.
- compositing/backing/no-backing-for-perspective.html: Added.
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/visibility/layer-visible-content-expected.png:
- compositing/visibility/layer-visible-content-expected.txt:
- 11:28 AM April 2012 Meeting edited by
- (diff)
- 11:27 AM Changeset in webkit [114282] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903
Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.
PR 125888
Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.
Reviewed internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 11:27 AM Changeset in webkit [114281] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 11:12 AM Changeset in webkit [114280] by
-
- 2 edits in trunk/Tools
Adding Contributors Brian Salomon and Tom Hudson to committers.py.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 11:06 AM Changeset in webkit [114279] by
-
- 3 edits in trunk/LayoutTests
Try to fix a flaky JS test.
Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).
- fast/js/custom-constructors-expected.txt:
- fast/js/script-tests/custom-constructors.js:
- 11:01 AM Changeset in webkit [114278] by
-
- 5 edits in trunk/Source
<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed
Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.
Source/WebCore:
- WebCore.exp.in: Export PageCache::remove()
Source/WebKit2:
Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.
- WebProcess/WebPage/WebBackForwardListProxy.h:
- 10:55 AM Changeset in webkit [114277] by
-
- 925 edits198 copies37 deletes in branches/subpixellayout
Merge trunk changes up until 114126 into subpixel branch.
- 10:55 AM April 2012 Meeting edited by
- Added proposed IDB discussion (diff)
- 10:51 AM Changeset in webkit [114276] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, GTK build fix after r114269.
- GNUmakefile.list.am:
- 10:43 AM Changeset in webkit [114275] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606
Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
- 10:41 AM Changeset in webkit [114274] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix COMMANDLINE_TYPEDARRAYS build
https://bugs.webkit.org/show_bug.cgi?id=84051
Reviewed by Gavin Barraclough.
Update for new putByIndex API and wtf changes.
- JSCTypedArrayStubs.h:
(JSC):
- 10:30 AM Changeset in webkit [114273] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Turns out those frame
flattening tests are still flaky.
- 10:25 AM Changeset in webkit [114272] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870
Reviewed by Pavel Feldman.
- only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
- 10:23 AM Changeset in webkit [114271] by
-
- 13 edits63 moves1 delete in trunk
Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
https://bugs.webkit.org/show_bug.cgi?id=84038
A bunch of renames "detailed heapshot" -> "heap snapshot".
Reviewed by Pavel Feldman.
PerformanceTests:
- inspector/detailed-heapshots-smoke-test.html:
Source/WebCore:
Tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-show-all.html
inspector/profiler/heap-snapshot-comparison-show-next.html
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-sorting.html
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-show-all.html
inspector/profiler/heap-snapshot-containment-show-next.html
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-sorting.html
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-show-all.html
inspector/profiler/heap-snapshot-dominators-show-next.html
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-sorting.html
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-show-all.html
inspector/profiler/heap-snapshot-summary-show-next.html
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-sorting.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/HeapSnapshotGridNodes.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js.
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotGridNode.prototype.createCell):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._emptyData):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffNode.prototype._signForDelta):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
(MixInSnapshotNodeFunctions):
- inspector/front-end/HeapSnapshotView.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotView.js.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback2):
(WebInspector.HeapSnapshotView.prototype.wasShown):
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype.onResize):
(WebInspector.HeapSnapshotView.prototype.searchCanceled):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesById):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesQuery):
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToLastSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToNextSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToPreviousSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingLastSearchResult):
(WebInspector.HeapSnapshotView.prototype._jumpToSearchResult):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapSnapshotView.prototype._changeFilter):
(WebInspector.HeapSnapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.HeapSnapshotView.prototype._changeNameFilter):
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype._loadProfile):
(WebInspector.HeapSnapshotView.prototype._loadProfileByIndex):
(WebInspector.HeapSnapshotView.prototype.isDetailedSnapshot):
(WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
(WebInspector.HeapSnapshotView.prototype._selectionChanged):
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.HeapSnapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.HeapSnapshotView.prototype.changeView.sortingComplete):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
(WebInspector.HeapSnapshotView.prototype._resolveObjectForPopover):
(WebInspector.HeapSnapshotView.prototype._helpClicked.appendHelp):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._retainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
(WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.HeapSnapshotProfileType.prototype.get description):
(WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/heapProfiler.css:
(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .view):
(.heap-snapshot-view .view.visible):
(.heap-snapshot-view .data-grid tr:empty):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid td.addedCount-column):
(.heap-snapshot-view .data-grid td.removedCount-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid td.addedSize-column):
(.heap-snapshot-view .data-grid td.removedSize-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(.heap-snapshot-view .data-grid td.shallowSize-column):
(.heap-snapshot-view .data-grid td.retainedSize-column):
(.heap-snapshot-view .data-grid td.distanceToWindow-column):
(.heap-snapshot-view .data-grid span.percent-column):
(.heap-snapshot-view .console-formatted-object, .console-formatted-node):
(.heap-snapshot-view .console-formatted-string):
(.heap-snapshot-view .console-formatted-id):
(.heap-snapshot-view .data-grid tr.selected *):
(.heap-snapshot-view .data-grid:focus tr.selected *):
(.heap-snapshot-view .delimiter):
(.heap-snapshot-view .views-container):
(.heap-snapshot-view .views-container .view):
(.heap-snapshot-view .retaining-paths-view):
(.heap-snapshot-view .class-view-grid):
(.heap-snapshot-view .class-view-toolbar):
(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):
(.heap-snapshot-view .retainers-view-header .title > span):
(.heap-snapshot-view tr:not(.selected) td.object-column span.highlight):
(.heap-snapshot-view td.object-column span.grayed):
(.heap-snapshot-help-status-bar-item .glyph):
(table.heap-snapshot-help):
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/profiler/detailed-heapshots-test.js: Removed.
- inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
- inspector/profiler/heap-snapshot-comparison-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html.
- inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
- inspector/profiler/heap-snapshot-comparison-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next.html.
- inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting.html.
- inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
- inspector/profiler/heap-snapshot-containment-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all.html.
- inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
- inspector/profiler/heap-snapshot-containment-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next.html.
- inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting.html.
- inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
- inspector/profiler/heap-snapshot-dominators-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all.html.
- inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt.
- inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
- inspector/profiler/heap-snapshot-dominators-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next.html.
- inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting.html.
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
- inspector/profiler/heap-snapshot-summary-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all.html.
- inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
- inspector/profiler/heap-snapshot-summary-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next.html.
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting.html.
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
(initialize_HeapSnapshotTest.InspectorTest.completeProfilerTest):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite.runner):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
- platform/chromium/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
- 10:18 AM Changeset in webkit [114270] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
https://bugs.webkit.org/show_bug.cgi?id=83946
Reviewed by Pavel Feldman.
Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
support for moving overview window with horizontal swype over lower timeline pane, thus removing
an irritating situation when we try to both change overview window and scroll lower timeline pane
upon a single touchpad gesture. Those willing to move timeline window now would need to position
mouse over overview.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
- 10:14 AM Changeset in webkit [114269] by
-
- 10 edits2 adds in trunk/Source/WebCore
[GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095
Reviewed by Martin Robinson.
Moved the GStreamer initialization logic to a new
GStreamerUtilities module, used by the MediaPlayer and the
AudioContext. I also removed the static variables as
gst_init_check already handles cases where it's called multiple
times.
- GNUmakefile.list.am:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstElementFactory):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF):
- platform/graphics/gstreamer/GStreamerUtilities.cpp: Added.
(WebCore):
(WebCore::initializeGStreamer):
- platform/graphics/gstreamer/GStreamerUtilities.h: Added.
(WebCore):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::doGstInit):
- 10:06 AM Changeset in webkit [114268] by
-
- 5 edits in trunk/Source/WebCore
Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
https://bugs.webkit.org/show_bug.cgi?id=83982
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-16
Reviewed by Martin Robinson.
GL_BGRA is not defined in GLESv2, so it causes build-break at readRenderingResults.
To resolve this, a helper function readPixelsAndConvertToBGRAIfNecessary is added
in GC3DOpenGL.cpp & GC3DOpenGLES.cpp and it's used in GC3DOpenGLCommon.cpp.
And some other issues to build with GLES are gone with this patch.
No new tests, since no new feature.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::readRenderingResults):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
- 10:03 AM Changeset in webkit [114267] by
-
- 4 edits8 adds in trunk
[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
Disable kashida justification if using Skia to draw.
Test: fast/text/international/arabic-justify.html
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
- fast/text/international/arabic-justify.html: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
- 9:59 AM Changeset in webkit [114266] by
-
- 4 edits in trunk/Source/WebCore
Build fix.
Change set 114220 broke OS X internal build. Change set 114231 attempted to fix it, but isn't entirely
correct. This patch amends change set 114231.
- WebCore.exp.in:
- editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h:
(DictationAlternative):
- 9:37 AM Changeset in webkit [114265] by
-
- 6 edits2 adds in trunk
REGRESSION (r104445): Style is not recomputed on serenaandlily.com
https://bugs.webkit.org/show_bug.cgi?id=83663
Source/WebCore:
Reviewed by Andreas Kling.
CSS class and id selectors are case insensitive in non-strict modes. The code
that invalidated the scope elements used getElementByID() which is case
sensitive in all modes. As a result we would fail to invalidate elements
that would match a style rule but used different case in id.
The new code invalidates by crawling the DOM tree. This often (when there are classes)
actually faster than the existing code as we can now handle everything in a single pass.
Each class scope required a crawl with the old code.
The code uses the same functions as the selector matching code to get the same behavior.
The maximum class limit is lifted as number of classes does not affect complexity anymore.
Test: fast/css/id-or-class-before-stylesheet-strict.html
- css/SelectorChecker.h:
(WebCore::SelectorChecker::elementMatchesSelectorScopes):
(WebCore):
- dom/Document.cpp:
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore):
LayoutTests:
Reviewed by Andreas Kling.
Update the existing test with case insensitive comparisons and add a strict mode test.
- fast/css/id-or-class-before-stylesheet-expected.txt:
- fast/css/id-or-class-before-stylesheet-strict-expected.txt: Added.
- fast/css/id-or-class-before-stylesheet-strict.html: Added.
- fast/css/id-or-class-before-stylesheet.html:
- 9:28 AM April 2012 Meeting edited by
- (diff)
- 8:56 AM Changeset in webkit [114264] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Unflag frame flattening
tests fixed in r114262.
- 8:53 AM Changeset in webkit [114263] by
-
- 6 edits in trunk
[BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
https://bugs.webkit.org/show_bug.cgi?id=84031
Patch by Jonathan Dong <Jonathan Dong> on 2012-04-16
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.
Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
- Api/DumpRenderTreeClient.h:
(WebCore):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
Tools:
Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
(DumpRenderTree):
- 8:51 AM Changeset in webkit [114262] by
-
- 16 edits in trunk/LayoutTests
[Qt] LayoutTest: Replace setTimeout with synchronous layout for frame flattening where possible.
https://bugs.webkit.org/show_bug.cgi?id=84028
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
It's safer (and faster) to force synchronous layout, than expecting a layout before setTimout(0) hits.
- fast/frames/flattening/crash-svg-document.html: Remove extra line so that non-svg builds don't report failure.
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- 8:36 AM Changeset in webkit [114261] by
-
- 3 edits2 adds in trunk
CSS3 Selectors failures on css3test.com
https://bugs.webkit.org/show_bug.cgi?id=83885
Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16
Reviewed by Zoltan Herczeg.
Source/WebCore:
Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type()
with values -n-b and n-b as they are of valid form an+b where a and b are integers.
http://www.w3.org/TR/selectors/#structural-pseudos
Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers.
However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor.
The original code only checked this if the string was n- or -n- but this is not enough.
We need to check everything which starts with an n- or -n- prefix.
Test: css3/parsing-css3-nthchild.html
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
LayoutTests:
- css3/parsing-css3-nthchild-expected.txt: Added.
- css3/parsing-css3-nthchild.html: Added.
- 8:35 AM Changeset in webkit [114260] by
-
- 2 edits in trunk
[GTK] GStreamer 1.0 support in configure.ac
https://bugs.webkit.org/show_bug.cgi?id=84029
Reviewed by Martin Robinson.
The GStreamer version was recently changed to 1.0 in the git
repositories of the project so we need to reflect this change in
configure.ac.
- configure.ac:
- 8:33 AM Changeset in webkit [114259] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt:
- 8:18 AM Changeset in webkit [114258] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in notifyChildInserted when HTMLMediaElement is removed from tree
https://bugs.webkit.org/show_bug.cgi?id=83949
Reviewed by Antti Koivisto.
No new tests. I was not able to create a reproducible test case, but I have been unable
to reproduce the ASSERT that occassionally fired in existing tests since I have been
living on these changes.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedIntoDocument): Call configureMediaControls.
(WebCore::HTMLMediaElement::removedFromDocument): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Don't show controls when the
media element is not in a Document.
- 8:15 AM Changeset in webkit [114257] by
-
- 2 edits in trunk/Tools
build-webkit --gtk --no-webkit2 builds WK2
https://bugs.webkit.org/show_bug.cgi?id=83977
Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-16
Reviewed by Martin Robinson.
- Scripts/build-webkit: Fixup ./configure option to disable
WebKit2 build.
- 8:13 AM Changeset in webkit [114256] by
-
- 5 edits in trunk
Layout Test media/track/track-delete-during-setup.html is hitting an ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=82269
Reviewed by Antti Koivisto.
Source/WebCore:
No new tests, already tested by media/track/track-delete-during-setup.html.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoDocument): Don't notify the media element until/unless
the track element is inserted into the document.
- html/HTMLTrackElement.h:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 8:10 AM Changeset in webkit [114255] by
-
- 7 edits in trunk/Source/JavaScriptCore
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by Geoffrey Garen.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
- runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
- runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):
- 7:49 AM Changeset in webkit [114254] by
-
- 2 edits16 adds in trunk/LayoutTests
[EFL][DRT] Create baselines for CSS cases related to Ahem font
https://bugs.webkit.org/show_bug.cgi?id=83265
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/fast/css/caption-width-absolute-position-expected.png: Added.
- platform/efl/fast/css/caption-width-absolute-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/caption-width-fixed-position-expected.png: Added.
- platform/efl/fast/css/caption-width-fixed-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/caption-width-relative-position-expected.png: Added.
- platform/efl/fast/css/caption-width-relative-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-expected.png: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-expected.txt: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
- platform/efl/test_expectations.txt:
- 7:43 AM Changeset in webkit [114253] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build break in PageClientImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?=id=84034
Reviewed by Kenneth Rohde Christiansen.
Fixes typo in didChangeViewportProperites definition.
- UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::didChangeViewportProperties):
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-16
- 7:33 AM Changeset in webkit [114252] by
-
- 53 edits56 adds in trunk/LayoutTests
[EFL][DRT] SVG rebaseline for tests affected by SVGEllipse and SVG shadow root changes
https://bugs.webkit.org/show_bug.cgi?id=84027
Unreviewed, EFL gardening.
Updating txt baselines for tests affected by r109097 and r112806,
creating pixel test results.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
- platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/efl/svg/batik/paints/patternRegionA-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegionA-expected.txt:
- platform/efl/svg/batik/paints/patternRegions-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegions-expected.txt:
- platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/efl/svg/carto.net/button-expected.png: Added.
- platform/efl/svg/carto.net/button-expected.txt:
- platform/efl/svg/carto.net/colourpicker-expected.png: Added.
- platform/efl/svg/carto.net/colourpicker-expected.txt:
- platform/efl/svg/carto.net/slider-expected.png: Added.
- platform/efl/svg/carto.net/slider-expected.txt:
- platform/efl/svg/carto.net/window-expected.png: Added.
- platform/efl/svg/carto.net/window-expected.txt:
- platform/efl/svg/clip-path/clip-in-mask-expected.png: Added.
- platform/efl/svg/clip-path/clip-in-mask-expected.txt:
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt:
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt:
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt:
- platform/efl/svg/clip-path/clip-path-evenodd-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-expected.txt:
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/efl/svg/clip-path/clip-path-nonzero-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-expected.txt:
- platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
- platform/efl/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt:
- platform/efl/svg/clip-path/clip-path-transform-1-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-transform-1-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-container-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-container-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt:
- platform/efl/svg/clip-path/clipper-placement-issue-expected.png: Added.
- platform/efl/svg/clip-path/clipper-placement-issue-expected.txt:
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
- platform/efl/svg/css/clippath-with-shadow-expected.png: Added.
- platform/efl/svg/css/clippath-with-shadow-expected.txt:
- platform/efl/svg/css/mask-with-shadow-expected.png: Added.
- platform/efl/svg/css/mask-with-shadow-expected.txt:
- platform/efl/svg/css/shadow-changes-expected.png: Added.
- platform/efl/svg/css/shadow-changes-expected.txt:
- platform/efl/svg/hixie/cascade/001-broken-expected.png: Added.
- platform/efl/svg/hixie/cascade/001-broken-expected.txt:
- platform/efl/svg/hixie/cascade/002-expected.png: Added.
- platform/efl/svg/hixie/cascade/002-expected.txt:
- platform/efl/svg/hixie/error/001-expected.png: Added.
- platform/efl/svg/hixie/error/001-expected.txt:
- platform/efl/svg/hixie/error/003-expected.png: Added.
- platform/efl/svg/hixie/error/003-expected.txt:
- platform/efl/svg/hixie/error/017-expected.png: Added.
- platform/efl/svg/hixie/error/017-expected.txt:
- platform/efl/svg/hixie/perf/001-expected.png: Added.
- platform/efl/svg/hixie/perf/001-expected.txt: Added.
- platform/efl/svg/hixie/perf/002-expected.png: Added.
- platform/efl/svg/hixie/perf/002-expected.txt: Added.
- platform/efl/svg/hixie/rendering-model/001-expected.png: Added.
- platform/efl/svg/hixie/rendering-model/001-expected.txt:
- platform/efl/svg/hixie/rendering-model/002-expected.png: Added.
- platform/efl/svg/hixie/rendering-model/002-expected.txt:
- platform/efl/svg/hixie/transform/001-expected.png: Added.
- platform/efl/svg/hixie/transform/001-expected.txt:
- platform/efl/svg/hixie/use/001-expected.png: Added.
- platform/efl/svg/hixie/use/001-expected.txt:
- platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
- platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
- platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- 7:30 AM WebKit Team edited by
- Adding myself to the committers list. (diff)
- 7:20 AM Changeset in webkit [114251] by
-
- 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore
Merged r112966.
- 7:17 AM Changeset in webkit [114250] by
-
- 4 edits in trunk
[EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797
Tools:
Keep the keyName valid within scope of KeyEventInfo to avoid
feeding key events with invalid keyName.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
- DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
LayoutTests:
Unskip fast/frames/iframe-window-focus.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
- platform/efl/Skipped:
- 7:05 AM Changeset in webkit [114249] by
-
- 8 edits1 add in trunk
[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981
Reviewed by Kenneth Rohde Christiansen.
.:
- ManualTests/remove-add-fixed-position.html: Added.
Source/WebCore:
When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.
- page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
- rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):
- rendering/RenderView.h:
(RenderView):
Source/WebKit2:
Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
- 6:59 AM Changeset in webkit [114248] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip crash test in chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=84024
- platform/chromium/test_expectations.txt:
- 6:38 AM Changeset in webkit [114247] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Clean up how the interaction engine is making use of ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=83895
Reviewed by Simon Hausmann.
Refactor how the interaction engine is using the ViewportAttributes
and get rid of the Contraints subclass.
Push the ViewportAttributes through to the QQuickWebViewPrivate class
and add some default values in the case the Legacy view is used.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::setCSSScaleBounds):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::hadUserInteraction):
(WebKit::QtViewportInteractionEngine::setAllowsUserScaling):
(WebKit::QtViewportInteractionEngine::setContentToDevicePixelRatio):
- 6:19 AM Changeset in webkit [114246] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after QRawFont change.
Missed this one earlier. We now use primaryFontHasGlyphForCharacter from
FontFastPath.cpp, resulting in a different DRT output.
- platform/qt-5.0/Skipped: unskip
- platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- 6:16 AM SelectiveTestEWS edited by
- (diff)
- 6:09 AM SelectiveTestBuildBot edited by
- (diff)
- 5:58 AM Changeset in webkit [114245] by
-
- 2 edits in trunk/LayoutTests
[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820
Unreviewed gardening. Skip new failing tests after r114240 until fix.
- platform/qt-5.0/Skipped:
- 5:53 AM Changeset in webkit [114244] by
-
- 3 edits in trunk/LayoutTests
[EFL][DRT] Gardening CSS Regions & Exclusions
https://bugs.webkit.org/show_bug.cgi?id=84011
Skipping CSS regions and exclusions tests for now,
waiting for feature to complete.
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 5:41 AM Changeset in webkit [114243] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Flag two failing media tests.
- 4:58 AM Top100Invariant edited by
- (diff)
- 4:57 AM RegressionTestResearch edited by
- (diff)
- 4:51 AM SelectiveTestBuildBot edited by
- (diff)
- 4:50 AM Changeset in webkit [114242] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
https://bugs.webkit.org/show_bug.cgi?id=83933
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-16
Reviewed by Adam Treat.
RIM PR: 149609
This was because I accidentally dropped an exclamation mark when
upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
the exclamation mark.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- 4:49 AM Improving Regression Tests edited by
- (diff)
- 4:46 AM Changeset in webkit [114241] by
-
- 26 edits1 add in trunk
Web Inspector: extract ContentProvider into its own file, make NetworkRequest, Resoruce and others implement it.
https://bugs.webkit.org/show_bug.cgi?id=83922
Reviewed by Yury Semikhatsky.
Source/WebCore:
We have two different types of requestContent methods: one on the source mapping level and one on the resource level.
There are also adapters between the two. I'm aligning it all to a single requestContent method declared in ContentProvider.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
- inspector/front-end/ContentProvider.js: Added.
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.contentURL):
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
(WebInspector.ContentProvider.SearchMatch):
- inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.contentURL):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentURL):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.requestContent):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._getResourceContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
- inspector/front-end/NetworkItemView.js:
(WebInspector.RequestContentView.prototype._ensureInnerViewShown.callback):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.contentURL):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.searchInContent):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.contentURL):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.contentURL):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):
- inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
- inspector/front-end/ScriptFormatter.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/content-providers-expected.txt:
- inspector/debugger/content-providers.html:
- inspector/debugger/raw-source-code.html:
- inspector/debugger/ui-source-code.html:
- 4:44 AM Changeset in webkit [114240] by
-
- 3 edits6 adds in trunk/Tools
[Qt] Replace QtXmlPatterns usage with libxslt dependency
<https://bugs.webkit.org/show_bug.cgi?id=76820>
Patch by Andras Piroska <pandras@inf.u-szeged.hu> on 2012-04-16
Reviewed by Simon Hausmann.
The features.prf file was modified, in order to use libxml and libxslt by default.
This modification only work at Qt5.
- qmake/config.tests/libxml2/libxml2.cpp: Added.
(main):
- qmake/config.tests/libxml2/libxml2.pro: Added.
- qmake/config.tests/libxslt/libxslt.cpp: Added.
(main):
- qmake/config.tests/libxslt/libxslt.pro: Added.
- qmake/mkspecs/features/features.prf:
- qmake/sync.profile:
- 4:32 AM Changeset in webkit [114239] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix a wrong expected.txt
https://bugs.webkit.org/show_bug.cgi?id=84014
- fast/canvas/webgl/shader-precision-format-expected.txt:
- 4:20 AM Changeset in webkit [114238] by
-
- 2 edits in trunk/Tools
[EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
https://bugs.webkit.org/show_bug.cgi?id=83862
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
It doesn't work properly because of wrong parameter order in function call.
- EWebLauncher/main.c:
- 3:13 AM Changeset in webkit [114237] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip failing tests, because less tests means less problems.
- platform/qt-5.0/Skipped:
- platform/qt/Skipped:
- 2:24 AM Changeset in webkit [114236] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r114200.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 2:04 AM Changeset in webkit [114235] by
-
- 3 edits2 adds in trunk
[BlackBerry] Missing readyState 2 when a XMLHttpRequest calls xmlhttp.open("HEAD","notExist.html",true).
https://bugs.webkit.org/show_bug.cgi?id=83866
Source/WebCore:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
We receive 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case shouldn't be treated as a failure.
Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyClose):
LayoutTests:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
- http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html: Added.
- 1:56 AM Changeset in webkit [114234] by
-
- 7 edits2 deletes in trunk/LayoutTests
[Chromium] Rebaseline for date-appearance.html.
- platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Removed.
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
- platform/chromium-win/fast/forms/date/date-appearance-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
- 1:42 AM Changeset in webkit [114233] by
-
- 2 edits in trunk/LayoutTests
[Qt]REGRESSION(r114217): It broke fast/repaint/line-flow-with-floats-in-regions.html
https://bugs.webkit.org/show_bug.cgi?id=84013
Unreviewed gardening, skip a failing test to paint the bot green. (Less tests, less problem.)
- platform/qt/Skipped:
- 1:32 AM Changeset in webkit [114232] by
-
- 1 edit12 adds in trunk/LayoutTests
Unreviewed, GTK baselines for tests added in r114162.
- platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
- 1:16 AM Changeset in webkit [114231] by
-
- 4 edits in trunk/Source/WebCore
Build fix.
- WebCore.exp.in:
- editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h:
(DictationAlternative):
- 1:11 AM Changeset in webkit [114230] by
-
- 2 edits in trunk/Source/WebCore
Fix signed/unsigned mismatch warning for BlackBerry debug builds.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::removeCookieAtIndex):
- 12:42 AM Changeset in webkit [114229] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Skip svg failures, unskip
ietestcenter for rebaseline and unflag a flaky media/track test.
- 12:26 AM Changeset in webkit [114228] by
-
- 2 edits in trunk/Tools
Unreviewed, GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skip /webkit/atk/textChangedNotifications.
- 12:14 AM Changeset in webkit [114227] by
-
- 2 edits in trunk/Source/WTF
Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999
Reviewed by Sam Weinig.
Before this patch, NullPtr.h assumed that a working |nullptr| implied
a working |std::nullptr_t| as well. With clang and libstdc++4.2, this
is not true.
I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03)
with clang.
- wtf/NullPtr.h:
(std):
Apr 15, 2012:
- 11:37 PM Changeset in webkit [114226] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- 11:23 PM Changeset in webkit [114225] by
-
- 8 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
- platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
- platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.
- 11:12 PM Changeset in webkit [114224] by
-
- 2 edits in trunk/Source/WebCore
WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991
Reviewed by Hajime Morita.
We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.
No new tests because this behavior depends on locale setting.
- platform/text/LocalizedCalendarICU.cpp:
(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().
- 10:32 PM PrefixedAPIs edited by
- (diff)
- 10:21 PM Changeset in webkit [114223] by
-
- 7 edits in trunk/Source/WebKit/chromium
Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777
Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.
Reviewed by Kent Tamura.
- public/WebAutofillClient.h:
(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
- public/WebView.h:
(WebView):
- src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
- src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.
Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions):
- src/WebViewImpl.h:
(WebViewImpl):
- 9:13 PM Changeset in webkit [114222] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to chromium-win build fix.
- editing/DictationAlternative.h:
- 8:54 PM Changeset in webkit [114221] by
-
- 2 edits in trunk/Source/WebCore
Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003
Reviewed by Eric Seidel.
Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.
No new tests. Covered by existing cnavas toDataURL tests.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::toDataURL):
- 8:05 PM Changeset in webkit [114220] by
-
- 31 edits3 copies3 adds in trunk/Source/WebCore
Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549
Reviewed by Hajime Morita.
No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.
On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:
- Added DictationMarkDetails to store non-string type maker detail.
- Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with attached markers.
- Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
- Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.
Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.
This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used
by AlternativeTextController.
(WebCore):
- dom/Document.h:
(WebCore):
- dom/DocumentMarker.cpp:
(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):
- dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore):
- dom/DocumentMarkerController.h:
(DocumentMarkerController):
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: Added member variable for dictation alternatives.
(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):
- dom/TextEventInputType.h:
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):
- editing/AlternativeTextController.h:
(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):
- editing/CompositeEditCommand.h:
(WebCore::CompositeEditCommand::isDictationCommand):
- editing/DictationAlternative.cpp: Added.
(WebCore):
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.
(DictationAlternative):
(WebCore):
- editing/DictationCommand.cpp: Added.
(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):
- editing/DictationCommand.h: Added.
(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):
- editing/EditingAllInOne.cpp:
- editing/Editor.cpp:
(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
- editing/Editor.h:
(Editor):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):
- editing/InsertTextCommand.h:
(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):
- editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.
(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
- editing/TextInsertionBaseCommand.h: Added.
(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):
- editing/TypingCommand.cpp:
(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):
- editing/TypingCommand.h:
- page/EventHandler.cpp:
- rendering/InlineTextBox.cpp:
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/InlineTextBox.h:
(InlineTextBox):
- testing/Internals.cpp:
(WebCore::markerTypesFrom):
- 7:49 PM Changeset in webkit [114219] by
-
- 33 edits2 copies4 adds6 deletes in trunk/LayoutTests
[chromium] Unreviewed rebaselines for various compositing tests.
- platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
- platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
- platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
- platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
- platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
- platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
- 7:44 PM Changeset in webkit [114218] by
-
- 16 edits in trunk/Source
[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415
Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.
Source/WebCore:
This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):
- platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):
- 7:40 PM Changeset in webkit [114217] by
-
- 27 edits in trunk
Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998
Source/WebCore:
Reviewed by Andreas Kling.
Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.
The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.
If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.
- css/CSSGrammar.y:
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
- css/CSSParser.cpp:
(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):
- css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):
- css/CSSParserMode.h:
(WebCore):
(CSSParserContext):
- css/CSSRule.h:
(WebCore::CSSRule::parserContext):
(CSSRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):
- css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):
- css/CSSValuePool.cpp:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::parseDeclaration):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
- dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
- dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector):
- dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
LayoutTests:
Reviewed by Andreas Kling.
Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.
- css3/filters/script-tests/custom-filter-property-parsing.js:
- fast/regions/script-tests/css-regions-disabled.js:
- 7:14 PM Changeset in webkit [114216] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975
Reviewed by Martin Robinson.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests. Covered by existing canvas toDataURL tests.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().
- 6:43 PM Changeset in webkit [114215] by
-
- 7 edits in trunk/Source
Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749
Reviewed by David Levin.
Source/WebCore:
Second attempt to remove leaks around WorkerThreadableWebSocketChannel.
No new tests, as this patch does not impose any functional change.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).
Source/WebKit/chromium:
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().
- 4:15 PM Changeset in webkit [114214] by
-
- 2 edits in trunk/Tools
Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641
Reviewed by Eric Seidel.
Don't build on perf bots to improve the cycle time.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 8:23 AM Changeset in webkit [114213] by
-
- 1 delete in trunk/LayoutTests/platform/efl/fast/regions
Remove empty directory.
- 8:21 AM Changeset in webkit [114212] by
-
- 2 edits50 deletes in trunk/LayoutTests
[EFL] Gardening. Skip fast/regions tests.
SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.
- platform/efl/Skipped:
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
- platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
- platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
- platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
