Timeline
Apr 18, 2012:
- 11:59 PM Changeset in webkit [114617] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp
Fix failed merge
- 11:56 PM Changeset in webkit [114616] by
-
- 2 edits in trunk/Source/WebCore
[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319
Reviewed by Eric Seidel.
No change in behavior. Covered by existing canvas 2d and 3d tests:
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).
- 11:54 PM Changeset in webkit [114615] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110374
- 11:42 PM Changeset in webkit [114614] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r111601
- 11:38 PM Changeset in webkit [114613] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111899
- 11:35 PM Changeset in webkit [114612] by
-
- 2 edits in trunk/LayoutTests
Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html
- platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- 11:35 PM Changeset in webkit [114611] by
-
- 10 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110323
- 11:33 PM Changeset in webkit [114610] by
-
- 6 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Fix a failed merge.
- 11:24 PM April 2012 Meeting edited by
- (diff)
- 10:40 PM Changeset in webkit [114609] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288
Reviewed by Eric Seidel.
No new tests, no change in functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.
- 10:21 PM Changeset in webkit [114608] by
-
- 6 edits3 adds in trunk
[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.
Source/WebCore:
RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain Defaults to the effective request-host. (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)
The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.
In sum, we shouldn't use m_hasDefaultDomain.
Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::shouldRejectForSecurityReason):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::ParsedCookie):
- platform/blackberry/ParsedCookie.h:
(ParsedCookie):
LayoutTests:
- http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
- http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
- http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.
- 9:51 PM Changeset in webkit [114607] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840
Reviewed by James Robinson.
The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::setupPaintForFont):
- 9:45 PM Changeset in webkit [114606] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314
Unreviewed, build fix after http://trac.webkit.org/changeset/114604
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
- 9:33 PM April 2012 Meeting edited by
- (diff)
- 9:07 PM April 2012 Meeting edited by
- (diff)
- 9:02 PM April 2012 Meeting edited by
- (diff)
- 8:51 PM Changeset in webkit [114605] by
-
- 13 edits2 adds in trunk
Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748
Reviewed by Ryosuke Niwa.
Source/WebCore:
The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)
Test: platform/chromium/editing/spelling/delete-misspelled-word.html
- WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.
- editing/SpellChecker.h:
(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.
Source/WebKit/chromium:
This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.
- public/WebTextCheckingCompletion.h:
(WebKit::WebTextCheckingCompletion::didCancelCheckingText):
- src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
- src/WebTextCheckingCompletionImpl.h:
(WebTextCheckingCompletionImpl):
Source/WebKit/mac:
This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().
- WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.
Tools:
This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
LayoutTests:
The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)
- platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
- platform/chromium/editing/spelling/delete-misspelled-word.html: Added.
- 8:29 PM April 2012 Meeting edited by
- (diff)
- 8:29 PM April 2012 Meeting edited by
- (diff)
- 8:26 PM April 2012 Meeting edited by
- (diff)
- 7:48 PM Changeset in webkit [114604] by
-
- 15 edits2 moves3 deletes in trunk/Source
[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120
Reviewed by Adrienne Walker.
Source/Platform:
This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):
Source/WebCore:
This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.
- WebCore.gypi:
- platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):
Source/WebKit/chromium:
This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward. In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.
- WebKit.gyp:
- WebKit.gypi:
- src/WebContentLayer.cpp:
- src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
- src/WebExternalTextureLayerImpl.cpp: Removed.
- src/WebExternalTextureLayerImpl.h: Removed.
- src/WebLayer.cpp:
(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
- src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
- tests/WebExternalTextureLayerImplTest.cpp: Removed.
- tests/WebLayerTest.cpp:
- 7:44 PM April 2012 Meeting edited by
- (diff)
- 7:32 PM Changeset in webkit [114603] by
-
- 9 edits in trunk
Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221
Patch by Raymond Toy <Raymond Toy> on 2012-04-18
Reviewed by Chris Rogers.
Source/WebCore:
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
- Modules/webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::releaseTime):
(DynamicsCompressorNode):
- Modules/webaudio/DynamicsCompressorNode.idl: Add attack and
release attributes.
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute): Skip release()
(GenerateHeader): Call SkipAttribute for getters/setters.
- platform/audio/DynamicsCompressor.h:
(DynamicsCompressor):
LayoutTests:
- webaudio/dynamicscompressor-basic-expected.txt:
- webaudio/dynamicscompressor-basic.html:
- 7:02 PM Changeset in webkit [114602] by
-
- 2 edits in trunk/Tools
Fix failure in test-webkitpy after r114583.
Unreviewed, build fix.
Updating the call site in r114583 w/o updating the test caused
the test to fail. Somehow I forgot to run the unit tests :(.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
- 7:01 PM Changeset in webkit [114601] by
-
- 10 edits in trunk/Source
[chromium] Simplify occlusion tracker API by passing layer iterator data
https://bugs.webkit.org/show_bug.cgi?id=84088
Reviewed by Adrienne Walker.
Source/WebCore:
Previously three methods lived in the API and you needed to call the
appropriate method (with different amounts of data) depending on what
the current layer iterator was representing.
This makes usage of the occlusion tracker simpler to read and harder
to mess up, by just passing in the layer iterator at each step of the
iteration process.
Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore):
(CCLayerIteratorPosition):
(CCLayerIterator):
(WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterLayer):
(WebCore):
(WebCore::::leaveLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestMainThreadTypes):
(CCOcclusionTrackerTestImplThreadTypes):
(WebKitTests::CCOcclusionTrackerTest::CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::enterLayer):
(WebKitTests::CCOcclusionTrackerTest::leaveLayer):
(WebKitTests::CCOcclusionTrackerTest::visitLayer):
(WebKitTests::CCOcclusionTrackerTest::enterContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::leaveContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::visitContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::resetLayerIterator):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
- tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore::TEST):
- 6:47 PM Changeset in webkit [114600] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Mark new fast/table test as failing.
- 6:30 PM Changeset in webkit [114599] by
-
- 9 edits in trunk/Source
[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301
Reviewed by Adrienne Walker.
Source/WebCore:
If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.
Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):
Source/WebKit/chromium:
Update unit tests for new canBeginFrame bit.
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- 6:22 PM Changeset in webkit [114598] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112935
- 6:22 PM Changeset in webkit [114597] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r112596
- 6:20 PM Changeset in webkit [114596] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r112596
- 6:20 PM Changeset in webkit [114595] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112200
- 6:10 PM Changeset in webkit [114594] by
-
- 21 edits in trunk/LayoutTests
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Rubber stamped by Geoff Garen.
Changed calls to shouldBe("...", "...") to be more informative, per Geoff's
suggestion.
- fast/js/dfg-float32array-expected.txt:
- fast/js/dfg-int16array-expected.txt:
- fast/js/dfg-int32array-expected.txt:
- fast/js/dfg-int32array-overflow-values-expected.txt:
- fast/js/dfg-int8array-expected.txt:
- fast/js/dfg-uint16array-expected.txt:
- fast/js/dfg-uint32array-expected.txt:
- fast/js/dfg-uint32array-overflow-values-expected.txt:
- fast/js/dfg-uint8array-expected.txt:
- fast/js/dfg-uint8clampedarray-expected.txt:
- fast/js/script-tests/dfg-float32array.js:
- fast/js/script-tests/dfg-int16array.js:
- fast/js/script-tests/dfg-int32array-overflow-values.js:
- fast/js/script-tests/dfg-int32array.js:
- fast/js/script-tests/dfg-int8array.js:
- fast/js/script-tests/dfg-uint16array.js:
- fast/js/script-tests/dfg-uint32array-overflow-values.js:
- fast/js/script-tests/dfg-uint32array.js:
- fast/js/script-tests/dfg-uint8array.js:
- fast/js/script-tests/dfg-uint8clampedarray.js:
- 6:05 PM Changeset in webkit [114593] by
-
- 22 edits4 adds in releases/WebKitGTK/webkit-1.8
Merging r112184
- 6:03 PM Changeset in webkit [114592] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112119
- 6:02 PM Changeset in webkit [114591] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112012
- 5:55 PM Changeset in webkit [114590] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111912
- 5:52 PM Changeset in webkit [114589] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111895
- 5:32 PM Changeset in webkit [114588] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110139
- 5:15 PM Changeset in webkit [114587] by
-
- 11 edits9 adds in trunk
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Source/JavaScriptCore:
Reviewed by Geoff Garen.
Added Uint8ClampedArray to the set of typed arrays that are supported by jsc
command-line.
- JSCTypedArrayStubs.h:
(JSC):
- jsc.cpp:
(GlobalObject::finishCreation):
Tools:
Reviewed by Geoff Garen.
Made run-fast-jsc print something and a newline if jsc threw an exception or
otherwise returned with an error code, but did not crash.
- Scripts/run-fast-jsc:
LayoutTests:
Reviewed by Geoff Garen.
Added tests for uint8 and uint16 arrays. Added a test for uint32 arrays that
does not focus entirely on overflow values.
Also added the typed array tests to the repertoire that can be run by
run-fast-jsc.
- fast/js/dfg-int16array-expected.txt:
- fast/js/dfg-int8array-expected.txt:
- fast/js/dfg-uint16array-expected.txt: Added.
- fast/js/dfg-uint16array.html: Added.
- fast/js/dfg-uint32array-expected.txt: Added.
- fast/js/dfg-uint32array.html: Added.
- fast/js/dfg-uint8array-expected.txt: Added.
- fast/js/dfg-uint8array.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-int16array.js:
- fast/js/script-tests/dfg-int8array.js:
- fast/js/script-tests/dfg-uint16array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- fast/js/script-tests/dfg-uint32array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- fast/js/script-tests/dfg-uint8array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- 5:11 PM Changeset in webkit [114586] by
-
- 4 edits in trunk/LayoutTests
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874
Reviewed by Eric Carlson.
Fix-up use of setMediaPlaybackRequiresUserGesture() in two media
tests.
- media/video-load-require-user-gesture.html:
- media/video-play-require-user-gesture.html:
- platform/gtk/test_expectations.txt:
- 5:05 PM Changeset in webkit [114585] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Unflag some tests now passing.
- 5:04 PM Changeset in webkit [114584] by
-
- 2 edits in trunk/Source/WTF
Somehow, there's an errant backslash in my last WTF patch
https://bugs.webkit.org/show_bug.cgi?id=84290
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Andreas Kling.
- wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):
- 4:56 PM Changeset in webkit [114583] by
-
- 2 edits in trunk/Tools
Fix crash in chromium.py after r114877.
Unreviewed, build fix.
Missed updating one call site for get_crash_log() :(.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
- 4:38 PM Changeset in webkit [114582] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r111775
- 4:34 PM Changeset in webkit [114581] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111714
- 4:32 PM Changeset in webkit [114580] by
-
- 4 edits in trunk/Source
[Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197
Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.
Source/WebCore:
Fold opacity into shader color for solid color layers.
Test: CCSolidColorLayerImplTest.verifyCorrectOpacityInQuad
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawSolidColorQuad):
Source/WebKit/chromium:
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon):
- 4:29 PM Changeset in webkit [114579] by
-
- 2 edits in trunk/Tools
[GTK] NRWT bails out if more than one X server runs on the machine
https://bugs.webkit.org/show_bug.cgi?id=84276
Reviewed by Dirk Pranke.
Set up GTK driver's Xvfb display number based on Xorg servers
currently running.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
(GtkDriver._start.x_filter):
- 4:23 PM Changeset in webkit [114578] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-1.8
Merging r111556
- 4:17 PM Changeset in webkit [114577] by
-
- 10 edits in trunk/Tools
run-webkit-tests picked up an old crash log
https://bugs.webkit.org/show_bug.cgi?id=84196
Reviewed by Ryosuke Niwa.
Modify the crash log-finding code so that we can
limit our search to logs newer than X - this prevents
us from finding old crash logs for a given process/pid
combination even when the PIDs might've wrapped.
Also fix a bug in filesystem_mock where files_under() would
return paths that didn't exist.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):
(CrashLogsTest.test_find_log_darwin.bad_read):
(CrashLogsTest):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.files_under):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.run_test):
- 4:11 PM April 2012 Meeting edited by
- (diff)
- 4:10 PM Changeset in webkit [114576] by
-
- 5 edits in trunk/Source
[Chromium] Call prefetchDNS directly
https://bugs.webkit.org/show_bug.cgi?id=84262
Reviewed by Kentaro Hara.
Part of a series, see tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 4:08 PM Changeset in webkit [114575] by
-
- 3 edits in trunk/Source/JavaScriptCore
jsc command line should support typed arrays by default
https://bugs.webkit.org/show_bug.cgi?id=84298
Rubber stamped by Gavin Barraclough.
- JSCTypedArrayStubs.h:
(JSC):
- jsc.cpp:
(GlobalObject::finishCreation):
- 4:07 PM Changeset in webkit [114574] by
-
- 3 edits2 adds in trunk
REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan
https://bugs.webkit.org/show_bug.cgi?id=84260
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/table/td-width-fifty-percent-regression-expected.html
fast/table/td-width-fifty-percent-regression.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
As we are spreading the cell's min / max logical width, we should be updating them.
This prevents the following logic getting confused and allocating more than needed.
LayoutTests:
- fast/table/td-width-fifty-percent-regression-expected.html: Added.
- fast/table/td-width-fifty-percent-regression.html: Added.
- 3:59 PM Changeset in webkit [114573] by
-
- 2 edits in branches/chromium/1084/Source/WebCore
Merge 114342 - Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.
No new tests. The repro steps require using Chrome notifications on Win.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035046
- 3:57 PM Changeset in webkit [114572] by
-
- 4 edits in branches/chromium/1084/Source/WebCore
Merge 113287 - Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.
No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10116046
- 3:49 PM Changeset in webkit [114571] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Mark some tests as crashing
in debug builds due to bug 63611.
- 3:31 PM Changeset in webkit [114570] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 should be able to perform division on ARM without crashing, and variables
forced double should not be scrambled when performing OSR entry
https://bugs.webkit.org/show_bug.cgi?id=84272
Reviewed by Geoff Garen.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- 3:29 PM Changeset in webkit [114569] by
-
- 2 edits in trunk/Source/WebCore
Win8 builds usually fail due to cygwin rebasing
https://bugs.webkit.org/show_bug.cgi?id=84274
Reviewed by Dirk Pranke.
Cygwin can fail to spawn children if the DLL is rebased. This happens
frequently enough on Windows 8 that we should retry on failure.
No new tests. No behavior changed.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 3:03 PM Changeset in webkit [114568] by
-
- 2 edits in trunk/Source/WebCore
Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=84264
Reviewed by Eric Seidel.
Explicitly instantiating integer max and min templates to fix compilation in Chromium. We
intentionally truncated these values in platform code, which matches earlier behavior.
See https://trac.webkit.org/wiki/LayoutUnit for details.
No new tests. No change in behavior.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::layout):
- 2:53 PM Changeset in webkit [114567] by
-
- 4 edits in trunk/Source
Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931
Reviewed by Eric Carlson.
When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
of the view's backing CALayers.
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):
- 2:51 PM Changeset in webkit [114566] by
-
- 2 edits in trunk/Source/WebCore
Prevent potential null pointer dereference in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=84267
Reviewed by Kentaro Hara.
No new tests / code cleanup found via static analysis.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:45 PM Changeset in webkit [114565] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore.gypi not current
https://bugs.webkit.org/show_bug.cgi?id=84224
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-18
Reviewed by Eric Seidel.
Updated JavaScriptCore.gypi to contain the latest sources. Removed os-win32 as it wasn't used. Also removed references to ICU files in the gypi file as ICU is most likely specified by the port itself.
Private and public header files were determined by looking at copy-files.cmd within Apple's Visual Studio directory.
- JavaScriptCore.gypi:
- 2:34 PM Changeset in webkit [114564] by
-
- 12 edits1 copy1 add in releases/WebKitGTK/webkit-1.8
[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630
Reviewed by Martin Robinson.
.:
Bump libsoup and glib dependencies.
- Source/cmake/OptionsEfl.cmake:
- configure.ac:
Source/WebCore:
Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.
No new tests required as we're just refactoring existing code to
be used by two different ports.
- CMakeLists.txt: added new file.
- GNUmakefile.list.am: ditto.
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- platform/network/DNSResolveQueue.cpp: Added.
(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.
- platform/network/DNSResolveQueue.h: Added.
(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
- platform/network/soup/DNSSoup.cpp:
(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):
Tools:
Bump libsoup and glib dependencies.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
Conflicts:
Tools/efl/jhbuild.modules
- 2:34 PM Changeset in webkit [114563] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.
Fix build error introduced by r110669.
- platform/network/soup/DNSSoup.cpp:
- 2:34 PM Changeset in webkit [114562] by
-
- 11 edits1 copy in releases/WebKitGTK/webkit-1.8/Source/WebCore
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997
Reviewed by Martin Robinson.
This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.
No need for new tests as this just moves code around.
- GNUmakefile.list.am:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLLinkElement.cpp:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
- platform/network/DNS.h:
(WebCore):
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/chromium/DNSChromium.cpp:
- platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
- platform/network/soup/ResourceHandleSoup.cpp:
- 2:33 PM WebKitGTK/1.8.x edited by
- (diff)
- 2:27 PM April 2012 Meeting edited by
- (diff)
- 2:26 PM Changeset in webkit [114561] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium compile of WebDatabase.cpp fails without SQL_DATABASE
https://bugs.webkit.org/show_bug.cgi?id=84212
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Kentaro Hara.
- src/WebDatabase.cpp:
(WebCore::AbstractDatabase::isSyncDatabase):
- 2:21 PM Changeset in webkit [114560] by
-
- 2 edits in trunk/Source/WebCore
Prevent switch case fallthrough in StylePropertySet::getPropertyValue().
https://bugs.webkit.org/show_bug.cgi?id=84266
Reviewed by Kentaro Hara.
No new tests / code cleanup found by static analysis.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
- 2:04 PM Changeset in webkit [114559] by
-
- 5 edits in trunk/Tools
nrwt: support additional test expectations files
https://bugs.webkit.org/show_bug.cgi?id=84222
Reviewed by Ojan Vafai.
This patch adds an --additional-expectations flag that can be
used to point to more files that will override the default set
of expectations. This will allow us to remove the
'google_chrome' ports and eventually help to clean up override
handling in the chromium ports and unify expectations files and
Skipped files; this can also be used to specify overrides for
tests that run differently on a given machine.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_expectations_overrides):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_additional_expectations):
- 2:01 PM Changeset in webkit [114558] by
-
- 3 edits in trunk/Source/WebCore
CSSValuePool: Make numeric value caches fixed-size arrays.
<http://webkit.org/b/84268>
Reviewed by Antti Koivisto.
Change the numeric CSSPrimitiveValue caches in CSSValuePool from HashMaps to
fixed-size arrays of RefPtr<CSSPrimitiveValue>s.
This is more space efficient and doesn't incur the cost of a hash lookup every
time a numeric CSSPrimitiveValue is needed. We retain the limit of caching
only values between 0-255 for now.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createValue):
- css/CSSValuePool.h:
(CSSValuePool):
- 1:53 PM Changeset in webkit [114557] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
https://bugs.webkit.org/show_bug.cgi?id=83500
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
- 1:52 PM Changeset in webkit [114556] by
-
- 528 edits14 copies1 delete in branches/subpixellayout
Merge trunk changes up until 114550 into subpixel branch.
- 1:47 PM Changeset in webkit [114555] by
-
- 2 edits in trunk/Tools
Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" https://bugs.webkit.org/show_bug.cgi?id=84177
Reviewed by Dirk Pranke.
Try to delete the pid file left by Apache in the case it was killed forcefully.
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd._stop_running_server):
- 1:46 PM Changeset in webkit [114554] by
-
- 17 edits2 adds in branches/dfgopt/Source/JavaScriptCore
DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004
Reviewed by Gavin Barraclough.
Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).
Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp: Added.
(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):
- dfg/DFGConstantFoldingPhase.h: Added.
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGInsertionSet.h:
(JSC::DFG::InsertionSet::execute):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToConstant):
(Node):
- runtime/JSValue.cpp:
(JSC::JSValue::description):
- runtime/JSValue.h:
(JSValue):
- 1:37 PM Changeset in webkit [114553] by
-
- 1 edit2 adds in branches/dfgopt/Source/JavaScriptCore
Unreviewed, adding files that I forgot to add in http://trac.webkit.org/changeset/114472
- dfg/DFGSilentRegisterSavePlan.h: Added.
(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):
- dfg/DFGSlowPathGenerator.h: Added.
(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):
- 1:34 PM Changeset in webkit [114552] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Solid color shader should use premultiplied alpha.
https://bugs.webkit.org/show_bug.cgi?id=84215
Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.
For efficiency and consistency, expect premultiplied alpha in
solid color shader.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderColor::getShaderString):
- 1:23 PM Changeset in webkit [114551] by
-
- 9 edits in trunk/Source
[WK2] Sandbox violations prevent attaching files to gmail messages
https://bugs.webkit.org/show_bug.cgi?id=84263
<rdar://problem/11248260>
Reviewed by Oliver Hunt.
- page/DragActions.h: Removed the newly added upload action. We cannot know if or when an upload is going to happen - a drop even listener can always get a reference to a File object, and upload it with XMLHttpRequest.
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Removed a separate willPerformDragDestinationAction call for upload action - ther is nothing we'd want to only do when dropping on a file upload button.
- 1:13 PM LayoutUnit edited by
- (diff)
- 1:12 PM Changeset in webkit [114550] by
-
- 2 edits in branches/subpixellayout/Source
WebKit/win cleanup on branch.
- 1:08 PM Changeset in webkit [114549] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/platform/graphics
Merging in r114548.
- 1:05 PM Changeset in webkit [114548] by
-
- 4 edits in trunk/Source/WebCore
GraphicsContextCG's roundToDevicePixels should round even when there's no transform
https://bugs.webkit.org/show_bug.cgi?id=84191
Reviewed by Eric Seidel.
When painting with the identify transform, the roundToDevicePixels function in GraphicsContextCG
does an early return that simply returns the FloatRect that was passed in. This proved to be a
problem in sub-pixel layout, as we wouldn't adjust the paint rect for text underline, and it could
end up being more than one pixel wide. Adding a roundedIntRect method on FloatRect for the simple
short-circuit case.
No new tests. No change in behavior before switching to sub-pixel layout.
- platform/graphics/FloatRect.cpp:
(WebCore::roundedIntRect):
- platform/graphics/FloatRect.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
- 12:53 PM Changeset in webkit [114547] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 12:48 PM Changeset in webkit [114546] by
-
- 9 edits in trunk
Clean-up WheelEvent Conversion.
https://bugs.webkit.org/show_bug.cgi?id=84243
Source/WebKit/qt:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::applyDelta):
Source/WebKit2:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
Tools:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
Calculate proper wheel-delta from pixel-delta given.
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):
LayoutTests:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
- 12:32 PM Changeset in webkit [114545] by
-
- 10 edits in trunk
[chromium] Turn on ENABLE_DATALIST for chromium
https://bugs.webkit.org/show_bug.cgi?id=84118
Reviewed by Kent Tamura.
Source/WebCore:
- html/HTMLDataListElement.cpp: Touched to avoid build issues. No code change.
- html/HTMLDataListElement.h: Ditto.
- html/HTMLInputElement.cpp: Ditto.
- html/HTMLInputElement.h: Ditto.
Source/WebKit/chromium:
- features.gypi: Turn on ENABLE_DATALIST.
- src/WebInputElement.cpp: Touched to avoid build issues. No code change.
LayoutTests:
- platform/chromium/fast/forms/label/labelable-elements-expected.txt: Update expectated result.
- 12:25 PM SelectiveTestEWS edited by
- (diff)
- 12:19 PM Changeset in webkit [114544] by
-
- 1 edit1 delete in trunk/Source/WebCore
[Qt] WheelEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84237
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- platform/qt/WheelEventQt.cpp: Removed.
- 12:14 PM SelectiveTestBuildBot edited by
- (diff)
- 11:58 AM Changeset in webkit [114543] by
-
- 22 edits4 adds in trunk/LayoutTests
[EFL][DRT] Update baselines after font-face support was fixed
https://bugs.webkit.org/show_bug.cgi?id=84234
Unreviewed, EFL gardening.
Fixing baselines for css/font-face* tests and tests affected
by working @font-face. A bunch of table/* rebaselines will
follow in a separate batch.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
- platform/efl/fast/css/beforeSelectorOnCodeElement-expected.png:
- platform/efl/fast/css/font-face-default-font-expected.png:
- platform/efl/fast/css/font-face-in-media-rule-expected.png:
- platform/efl/fast/css/font-face-multiple-faces-expected.png:
- platform/efl/fast/css/font-face-multiple-faces-expected.txt:
- platform/efl/fast/css/font-face-opentype-expected.png:
- platform/efl/fast/css/font-face-opentype-expected.txt:
- platform/efl/fast/css/font-face-remote-expected.png:
- platform/efl/fast/css/font-face-remote-expected.txt:
- platform/efl/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
- platform/efl/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
- platform/efl/fast/css/font-face-unicode-range-expected.png:
- platform/efl/fast/css/font-face-unicode-range-expected.txt:
- platform/efl/fast/css/font-face-weight-matching-expected.png: Added.
- platform/efl/fast/css/font-face-weight-matching-expected.txt: Added.
- platform/efl/fast/css/font-face-woff-expected.png:
- platform/efl/fast/css/font-face-woff-expected.txt:
- platform/efl/fast/css/rtl-ordering-expected.txt:
- platform/efl/fast/css/text-security-expected.txt:
- platform/efl/fast/events/updateLayoutForHitTest-expected.png:
- platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.png:
- platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/efl/fast/writing-mode/broken-ideographic-font-expected.png:
- platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/efl/test_expectations.txt:
- 11:54 AM Changeset in webkit [114542] by
-
- 1109 edits236 copies123 deletes in branches/subpixellayout
Merge trunk changes up until 114521 into subpixel branch.
- 11:46 AM Changeset in webkit [114541] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.
- platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
- 11:40 AM Changeset in webkit [114540] by
-
- 2 edits5 adds in trunk/LayoutTests
IDB: Pending setVersion call in worker prevents document from opening the db, even after worker termination
https://bugs.webkit.org/show_bug.cgi?id=83952
These two tests fail in DRT most proximately because DRT provides
different instances of IDBFactoryBackend to a document and worker:
https://bugs.webkit.org/show_bug.cgi?id=82776.
One fails in chromium because of a logic error tracked by
http://crbug.com/123418. The plan is to run them both as browser tests
when the logic is fixed, but just one in the meantime.
Also added SKIP for storage/indexeddb/dont-commit-on-blocked.html
since it also can't pass in DRT and just turns the flakiness dashboard
all red.
Reviewed by Ojan Vafai.
- platform/chromium/test_expectations.txt:
- storage/indexeddb/pending-version-change-stuck-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate.html: Added.
- storage/indexeddb/pending-version-change-stuck.html: Added.
- storage/indexeddb/resources/pending-version-change-stuck.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):
- 11:36 AM Changeset in webkit [114539] by
-
- 7 edits in trunk/Source
Remove m_subclassData from JSArray, move the attribute to subclass as needed
https://bugs.webkit.org/show_bug.cgi?id=84249
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
case.
This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
of CopiedSpace.
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray):
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- runtime/JSArray.h:
Source/WebCore:
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
- bridge/runtime_array.h:
(JSC::RuntimeArray::getLength):
(JSC::RuntimeArray::getConcreteArray):
(RuntimeArray):
- 11:34 AM Changeset in webkit [114538] by
-
- 7 edits in trunk
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903
Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/media-query-list-08.html
Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.
The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.
- dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
Testing MediaQueryLists listeners related to viewport changes.
- fast/media/media-query-list-08-expected.txt: Added.
- fast/media/media-query-list-08.html: Added.
Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.
- platform/qt/Skipped:
- platform/mac/Skipped:
- 11:31 AM Changeset in webkit [114537] by
-
- 4 edits in trunk/Source/WebCore
Use explicit casts for size_t to unsigned conversion
https://bugs.webkit.org/show_bug.cgi?id=83602
Reviewed by Eric Seidel.
No new tests, no change in functinality.
Not all platforms have implicit casts from size_t to unsigned and we
can't add size_t versions of the operators to FractionalLayoutUnit for
all platforms as it would conflict with the unsigned versions of same.
Change support methods to take unsigned instead of size_t and use
explicit casts when multiplying or dividing a FractionalLayoutUnit with
a size_t and the other way around.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::packFlexLines):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
- 11:31 AM Changeset in webkit [114536] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Skip some failing tests and
mark 3 more frame flattening tests flaky.
- 11:14 AM Changeset in webkit [114535] by
-
- 5 edits in trunk
Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166
Re-applying r114497.
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
LayoutTests: Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254
Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
- platform/gtk/test_expectations.txt:
- 11:06 AM Changeset in webkit [114534] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, trying to fix QT build.
It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 11:03 AM Changeset in webkit [114533] by
-
- 7 edits5 adds in trunk/LayoutTests
[chromium] Unreviewed, rebaseline compositing tests after r114283.
https://bugs.webkit.org/show_bug.cgi?id=84083
- platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium/test_expectations.txt:
- 11:01 AM Changeset in webkit [114532] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
https://bugs.webkit.org/show_bug.cgi?id=84244
Reviewed by Vsevolod Vlasov.
Overlay logic is well separable from the scripts panel and does not belong there.
Extracting it into a separate class.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype.wasShown):
(WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
(WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
(WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
- 11:01 AM Changeset in webkit [114531] by
-
- 8 edits in trunk
Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254
Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
Source/WebKit/gtk:
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
- platform/gtk/test_expectations.txt:
- 10:44 AM Changeset in webkit [114530] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114497.
http://trac.webkit.org/changeset/114497
https://bugs.webkit.org/show_bug.cgi?id=84253
Broke compile on Win, including stdio did not help (Requested
by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 10:37 AM Changeset in webkit [114529] by
-
- 4 edits in trunk/Source/WebCore
[CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263
Reviewed by Dean Jackson.
Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
rectangle that needs to be drawn in order to update the shadow correctly.
No new tests, this change doesn't have visible results and the functionality should
already be covered by previous filter tests.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
(WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
the filter is computed.
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::repaintRect):
(FilterEffectRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
- 10:23 AM Changeset in webkit [114528] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149
Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.
Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.
Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.
- webkit/webkitwebview.cpp:
(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)
- 10:23 AM Changeset in webkit [114527] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.
.:
- configure.ac: Bumped the libsoup dependency to 2.37.90.
Source/WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html
When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
- 10:22 AM Changeset in webkit [114526] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-1.8
[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Test: platform/gtk/fast/forms/large-toggle-elements.html
Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle): Draw default-sized toggles.
LayoutTests:
Add a test for this issue.
- platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
- platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
- platform/gtk/fast/forms/large-toggle-elements.html: Added.
- 10:22 AM Changeset in webkit [114525] by
-
- 5 edits5 adds in releases/WebKitGTK/webkit-1.8
[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html
The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.
- platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.
Source/WebKit/gtk:
Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.
LayoutTests:
Added a pixel test for this issue.
- platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.
- 10:22 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:17 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:17 AM Changeset in webkit [114524] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496
Reviewed by Gavin Barraclough.
Don't attempt to use the DFG when SSE2 is not available.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::canCompileOpcodes):
- 10:16 AM Changeset in webkit [114523] by
-
- 2 edits in trunk/Source/WebCore
[EFL][DRT] @font-face support fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=83264
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
Reviewed by Dimitri Glazkov.
STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
Fixing that by removing a long standing FIXME with the intention
to turn the whitelist for this switch into a blacklist.
- loader/cache/CachedFont.cpp:
- 10:16 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:15 AM Changeset in webkit [114522] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8
[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447
Reviewed by Philippe Normand.
Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt
- autogen.sh: respect the NOCONFIGURE environment flag, per the
new GNOME build-api.
- 10:07 AM Changeset in webkit [114521] by
-
- 2 edits in trunk/Source/JavaScriptCore
replaceUsingStringSearch: delay the creation of the replace string until needed
https://bugs.webkit.org/show_bug.cgi?id=83841
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.
We do not need to obtain the replaceValue until we have a match. By moving the intialization
of replaceValue when needed, we save a few instructions when there is no match.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
- 10:05 AM Changeset in webkit [114520] by
-
- 13 edits in trunk/Source/WebCore
Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098
Reviewed by Eric Seidel.
Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
couldn't have been attained before that conversion. With that in mind, this patch reverts
drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
to be an IntPoint.
No new tests. No change in behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
- page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::shadowForBlending):
- platform/animation/AnimationUtilities.h:
(WebCore::blend): New blend function that operates on IntPoints.
(WebCore):
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebDropShadowFilterOperation):
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::DropShadowFilterOperation::blend):
- platform/graphics/filters/FilterOperation.h:
(WebCore::DropShadowFilterOperation::clone):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
(DropShadowFilterOperation):
- rendering/RenderBoxModelObject.cpp:
(WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
a RoundedRect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
RoundedRect that we use for painting.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::location):
(ShadowData):
- 9:53 AM Changeset in webkit [114519] by
-
- 18 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
- bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):
- bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- 9:34 AM Changeset in webkit [114518] by
-
- 3 edits in trunk/Source/WebCore
[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
https://bugs.webkit.org/show_bug.cgi?id=83960
Reviewed by Simon Fraser.
The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
be inside it.
No new tests added in this patch, but this patch fixes two existing tests that fail.
LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
LayoutTests/css3/filters/filter-repaint-shadow-rotated.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- 9:33 AM Changeset in webkit [114517] by
-
- 1 copy in tags/Safari-534.57.2
New tag.
- 9:29 AM Changeset in webkit [114516] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111263
- 9:29 AM Changeset in webkit [114515] by
-
- 11 edits3 adds in trunk/Source/WebCore
Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109
Reviewed by Kentaro Hara.
Now that incrementStatsCounter has been moved from
PlatformSupport.h to Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
means we need a new StatsCounter class in WebCore/platform/ and an
implementation in
WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
are welcome to implement their own stats counters if they
wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
(WebCore::V8WorkerContext::setTimeoutCallback):
(WebCore::V8WorkerContext::setIntervalCallback):
- platform/StatsCounter.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):
- platform/StatsCounter.h: Added.
(WebCore):
(StatsCounter):
- platform/chromium/StatsCounterChromium.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):
- 9:28 AM Changeset in webkit [114514] by
-
- 4 edits in branches/subpixellayout/Source/WebCore
Replace uses of size_t with unsigned in rendering code on branch.
- 9:25 AM Changeset in webkit [114513] by
-
- 5 edits in trunk/Source
[Chromium] REGRESSION: Popup shrinks because of autocomplete
https://bugs.webkit.org/show_bug.cgi?id=84139
http://code.google.com/p/chromium/issues/detail?id=123432
Source/WebCore:
Do not update the window rect on the wrong client but instead return the popup widget's
new screen coordinates from the refresh() method.
Reviewed by Kent Tamura.
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::refresh):
- platform/chromium/PopupContainer.h:
(PopupContainer):
Source/WebKit/chromium:
Do not use the PopupContainer's frameRect() to update the popup client's window rect,
since PopupContainer is always positioned at (0, 0) inside the client's window rect,
and the latter one is positioned relative to the screen origin.
Reviewed by Kent Tamura.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::refreshAutofillPopup):
- 9:20 AM Changeset in webkit [114512] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110487
- 9:18 AM Changeset in webkit [114511] by
-
- 9 edits in trunk/Source/JavaScriptCore
GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919
Reviewed by Geoffrey Garen.
- API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've
released a global object, we're abandoning a potentially large number of objects that JSC might want
to collect.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
that we've hit a slow path and are allocating now, so schedule the timer.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
amounts of compiled code).
(JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
collection to see if we should throw away our compiled code. Currently this is set to happen about once
every minute.
- heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
in CopiedSpace.
- runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
- runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing
the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
objects and that JSC might want to clean them up.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::willAllocate):
(JSC::GCActivityCallback::didCollect):
(JSC::GCActivityCallback::didAbandonObjectGraph):
(JSC::GCActivityCallback::synchronize):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.
We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
turned out to be quite expensive (although Instruments couldn't tell us this).
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
- 9:18 AM Changeset in webkit [114510] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110307
- 9:17 AM Changeset in webkit [114509] by
-
- 3 edits2 adds in trunk
ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
https://bugs.webkit.org/show_bug.cgi?id=84221
Source/WebCore:
Reviewed by Dean Jackson.
When a RenderLayerBacking doesn't require its own backing store, and is
in "paintIntoCompositingAncestor" mode, we would assert when trying to
paint its m_foregroundLayer if it had one (because of a negative z-index child).
The fix is to set the 'drawsContent' state on the m_foregroundLayer
as well as m_graphicsLayer.
Test: compositing/backing/no-backing-foreground-layer.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
LayoutTests:
Reviewed by Dean Jackson.
New testcase.
- compositing/backing/no-backing-foreground-layer-expected.txt: Added.
- compositing/backing/no-backing-foreground-layer.html: Added.
- 9:14 AM Changeset in webkit [114508] by
-
- 4 edits in trunk
[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
https://bugs.webkit.org/show_bug.cgi?id=84229
CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.
Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.
.:
- CMakeLists.txt:
Tools:
- Scripts/build-jsc:
- 8:45 AM Changeset in webkit [114507] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225
Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.
Tested with manual tests.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035027
- 8:44 AM Changeset in webkit [114506] by
-
- 8 edits in trunk
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874
Patch by Simon Pena <Simon Pena> on 2012-04-18
Reviewed by Philippe Normand.
Source/WebKit/gtk:
When the MediaPlaybackRequiresUserGesture setting was added, no gtk
API was implemented to access it.
This adds a property to gtk WebKit WebSettings, and connects it to
WebKit WebView, thus allowing clients to programmatically modify it.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Tools:
Now that there is gtk API to update the
MediaPlaybackRequiresUserGesture property, set it to false from the
DumpRenderTree tool when resetting defaults to consistent values.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html where enabling
MediaPlaybackRequiresUserGesture when run, so tests running
concurrently would fail -they would pass when run independently.
Since new API is added to ensure DumpRenderTree is able to reset
that setting, having media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html no longer causes
flakiness.
- platform/gtk/test_expectations.txt: Unskip
media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html
- 8:09 AM Changeset in webkit [114505] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/TextPrompt.js
Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148
Reviewed by Pavel Feldman.
TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
TBR=vsevik@chromium.org
BUG=123826
Review URL: https://chromiumcodereview.appspot.com/10116026
- 7:59 AM Changeset in webkit [114504] by
-
- 18 edits in trunk
Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240
DataGrid now has an explicit root node. All children are added/removed
to that node.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
- inspector/front-end/CookieItemsView.js:
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):
- inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._rebuildTable):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype.rootNode):
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype._enumerateChildren):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.get revealed):
(WebInspector.DataGridNode.prototype.get depth):
(WebInspector.DataGridNode.prototype.appendChild):
(WebInspector.DataGridNode.prototype.insertChild):
(WebInspector.DataGridNode.prototype.removeChild):
(WebInspector.DataGridNode.prototype.removeChildren):
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.reveal):
(WebInspector.DataGridNode.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.traverseNextNode):
(WebInspector.DataGridNode.prototype.traversePreviousNode):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.clear):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
- inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.prototype.refresh):
- inspector/front-end/treeoutline.js:
LayoutTests:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
- inspector/storage-panel-dom-storage.html:
- 7:55 AM Changeset in webkit [114503] by
-
- 2 edits2 deletes in trunk/LayoutTests
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Unreviewed test expectation fix.
The svg/transforms/transform-origin-css-property.xhtml test has a
ref-test for it, so there should not be any image expectations. If the
test if failing, we need to look at why the ref test is not valid, or
why we differ.
The expectations file update here is just some cleanup for
https://bugs.webkit.org/show_bug.cgi?id=84230.
- platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
- platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 6:55 AM Changeset in webkit [114502] by
-
- 15 edits in trunk/Source/WebCore
Add PassThis=* to support the callbacks which requires to pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232
Patch by Vineet Chaudhary <Vineet> on 2012-04-18
Reviewed by Kentaro Hara.
Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
This will help to identify the type(XXX) of "this" value in codegenerator.
Tests: bindings/scripts/test/TestCallback.idl
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation): Ditto.
- bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.
(WebDOMTestCallback::callbackWithBoolean):
(WebDOMTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.
(WebDOMTestCallback):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
- bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/JS/JSTestCallback.h: Ditto.
(JSTestCallback):
- bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.
(-[DOMTestCallback callbackWithBoolean:]):
(-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):
- bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
- bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/V8/V8TestCallback.h: Ditto.
(V8TestCallback):
- 6:52 AM Changeset in webkit [114501] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: fixing Chromium win compilation.
- bindings/v8/V8IsolatedContext.cpp:
- 6:02 AM Changeset in webkit [114500] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary variable reassignment in CSSParser::parseImageSet().
https://bugs.webkit.org/show_bug.cgi?id=84204
Reviewed by Kentaro Hara.
Code calls next and then current instead of reusing the result of next.
No new tests / no functionality changed.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseImageSet):
- 5:26 AM Changeset in webkit [114499] by
-
- 10 edits in trunk
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
- WebInspector.cpp:
- WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
- WebNodeHighlight.h:
(WebNodeHighlight):
- WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
- WebView.h:
(WebView):
Tools:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 3:56 AM Changeset in webkit [114498] by
-
- 3 edits2 adds in trunk
[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.
.:
- ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
- ManualTests/blackberry/clear-cookie-refresh.php: Added.
Source/WebCore:
Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.
We must click "clear button" to test, so have to write a manual test case.
Test: ManualTests/blackberry/clear-cookie-refresh.php
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- 3:09 AM Changeset in webkit [114497] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166
Reviewed by Yury Semikhatsky.
V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 3:04 AM Changeset in webkit [114496] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.
After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
- 2:29 AM SelectiveTestEWS edited by
- (diff)
- 1:53 AM Changeset in webkit [114495] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230
- platform/chromium/test_expectations.txt:
- 1:49 AM Changeset in webkit [114494] by
-
- 5 edits2 adds in trunk
Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179
Reviewed by Yury Semikhatsky.
Source/WebCore:
Perform total update upon modifications of the document node.
Test: inspector/elements/delete-from-document.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/front-end/ElementsTreeOutline.js:
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):
- inspector/elements/delete-from-document-expected.txt: Added.
- inspector/elements/delete-from-document.html: Added.
- 1:40 AM Changeset in webkit [114493] by
-
- 8 edits2 adds in trunk
Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
Test: media/audio-concurrent-supported.html
- platform/blackberry/PageClientBlackBerry.h:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isVisible):
LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
- media/audio-concurrent-supported-expected.txt: Added.
- media/audio-concurrent-supported.html: Added.
- 1:17 AM Changeset in webkit [114492] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18
- platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
- 1:05 AM Changeset in webkit [114491] by
-
- 2 edits in trunk/Source/WebCore
[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022
Reviewed by Eric Seidel.
ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.
No new tests. Covered by existing toDataURL tests, in particular:
canvas/philip/tests/toDataURL.jpeg.alpha.html
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.
- 12:37 AM Changeset in webkit [114490] by
-
- 2 edits in trunk/Tools
[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010
Unreviewed, unskipping test after bug being fixed by r114311.
- Scripts/run-gtk-tests:
(TestRunner): Unskip now passing test.
- 12:35 AM Changeset in webkit [114489] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225
Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.
Tested with manual tests.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10083037
Apr 17, 2012:
- 11:39 PM Changeset in webkit [114488] by
-
- 5 edits in trunk
[BlackBerry] Viewport metatag doesn't disable double-tap zoom
https://bugs.webkit.org/show_bug.cgi?id=84199
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
Reviewed by George Staikos.
Source/WebKit/blackberry:
PR: 148279
When we set "user-scalable=no" in viewport meta-tag and change any
other WebSettings, the WebPage can turn to be scalable.
This is a regression of the change master_32/SHA:fa0f8ee9. In that
change, we used setUserScalable(webSettings->isUserScalable())
in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
case, as webSettings->isUserScalable() would always return true by
default.
Create a new API WebPage::setUserScalable which will be used in
DumpRenderTree.cpp.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserScalable):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebPage.h:
Tools:
Revert a part of the change master_32/SHA:fa0f8ee9 and use
WebPage::setUserScalable instead.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 11:36 PM Changeset in webkit [114487] by
-
- 2 edits in trunk/Source/WebCore
Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225
Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.
Tested with manual tests.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):
- 10:54 PM Changeset in webkit [114486] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- 10:47 PM Changeset in webkit [114485] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs textInputController
https://bugs.webkit.org/show_bug.cgi?id=42337
Update wk2 Skipped list to skip new failing test.
- platform/wk2/Skipped:
- 10:34 PM Changeset in webkit [114484] by
-
- 2 edits in trunk/LayoutTests
[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
https://bugs.webkit.org/show_bug.cgi?id=84227
Update wk2 Skipped list to skip new failing test.
- platform/wk2/Skipped:
- 10:27 PM Changeset in webkit [114483] by
-
- 1 edit1 move2 adds in trunk/LayoutTests
Unreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .
- platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png: Added.
- platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Added.
- svg/as-background-image/svg-as-background-6-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-6-expected.txt.
- 10:18 PM Changeset in webkit [114482] by
-
- 3 edits in branches/safari-534.57-branch/WebKitLibraries
Merge r97323.
- 9:52 PM Changeset in webkit [114481] by
-
- 3 edits2 adds in trunk
ShadowRoot shouldn't be adopted by any Document.
https://bugs.webkit.org/show_bug.cgi?id=84127
Reviewed by Dimitri Glazkov.
Source/WebCore:
ShadowRoot cannot cannot be removed from its host, which means
ShadowRoot cannot be adopted by any Document directly because the
adoptNode() tries to remove it from its parent but it doesn't make
sense for ShadowRoot.
This change adds a guard to check such a case.
Test: fast/dom/shadow/adopt-node-with-shadow-root.html
- dom/Document.cpp:
(WebCore::Document::adoptNode):
LayoutTests:
- fast/dom/shadow/adopt-node-with-shadow-root-expected.txt: Added.
- fast/dom/shadow/adopt-node-with-shadow-root.html: Added.
- 9:40 PM Changeset in webkit [114480] by
-
- 1 edit1 delete in trunk/LayoutTests
REGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84226
Remove expected failing results ſtor media/video-playing-and-pause.html.
- platform/mac-wk2/media/video-playing-and-pause-expected.txt: Removed.
- 9:04 PM Changeset in webkit [114479] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, revert temporal expectation changeset (114248)
https://bugs.webkit.org/show_bug.cgi?id=84024
- platform/chromium/test_expectations.txt:
- 8:54 PM Changeset in webkit [114478] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should not attempt to get rare case counts for op_mod on ARM
https://bugs.webkit.org/show_bug.cgi?id=84218
Reviewed by Geoff Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- dfg/DFGCommon.h:
(JSC::DFG::isX86):
(DFG):
- 8:42 PM Changeset in webkit [114477] by
-
- 2 edits in trunk/Source
BumpPointerAllocator assumes page size is less than MINIMUM_BUMP_POOL_SIZE
https://bugs.webkit.org/show_bug.cgi?id=80912
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-17
Reviewed by Hajime Morita.
- wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::create):
- 8:34 PM Changeset in webkit [114476] by
-
- 9 edits1 move2 adds in trunk/Source/WebKit2
[Mac] USPS Shipping label prints without barcode
https://bugs.webkit.org/show_bug.cgi?id=84099
<rdar://problem/11133877>
Reviewed by Sam Weinig.
Use PDFDocuemnt instead of CGPDFDocument when printing PDFs, because PDFKit knows
how to draw PDF buttons, and CG does not.
- Shared/mac/PDFKitImports.h: Added.
- Shared/mac/PDFKitImports.mm: Added.
- UIProcess/API/mac/WKPrintingView.mm:
Moved code for dealing with dynamically loaded PDFKit from WKPrintingView, as we
now also need it elsewhere.
- WebKit2.xcodeproj/project.pbxproj: Added
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Rebamed to .mm.
- WebProcess/Plugins/PDF/BuiltInPDFView.h: Changed m_pdfDocument to PDFDocument.
- WebProcess/Plugins/PDF/BuiltInPDFView.mm: Copied from Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp.
(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::calculateSizes):
(WebKit::BuiltInPDFView::paintContent):
Changed m_pdfDocument to PDFDocument, and updated for the changes. We still use
CGPDF when drawing to screen though, because that doesn't affect USPS.
- WebProcess/Plugins/Plugin.h: (WebKit::Plugin::pdfDocumentForPrinting): Updated
the type, and changed ifsed from CG to MAC, as we're now fully dependent on Cocoa.
- WebProcess/Plugins/PluginView.h: (WebKit::PluginView::pdfDocumentForPrinting):
Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pdfDocumentForPrintingFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
- WebProcess/WebPage/WebPage.h:
Moved PDF document printing code to WebPageMac.mm, as it's now Objective C.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::computePagesForPrintingPDFDocument):
(WebKit::roundCGFloat):
(WebKit::drawPDFPage): While moving, also fixed a logic error in calculating the box
(it used to intersect with an empty box).
(WebKit::WebPage::drawRectToPDFFromPDFDocument):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):
- 7:57 PM Changeset in webkit [114475] by
-
- 12 edits in trunk/Source/WebCore
[chromium] Ensure RateLimiter waits for Swapbuffers completion
https://bugs.webkit.org/show_bug.cgi?id=83649
Patch by John Bauman <jbauman@chromium.org> on 2012-04-17
Reviewed by James Robinson.
We were waiting only on the canvas context, which with the new GPU
scheduling was causing the RateLimiter not to ratelimit enough. We
need to insert no-op commands in the compositor context, so that we'll
wait for the canvas context and SwapBuffers as well.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::doNoOp):
(WebCore):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/RateLimiter.cpp:
(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::rateLimitContext):
- platform/graphics/chromium/RateLimiter.h:
(RateLimiterClient):
(WebCore):
(RateLimiter):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::forceNoOpCommand):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::forceNoOpCommand):
(WebCore):
(WebCore::CCThreadProxy::forceNoOpCommandOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
- 7:49 PM Changeset in webkit [114474] by
-
- 3 edits in trunk/Source/WebCore
CSSValuePool: Made identifier value cache a fixed-size array.
<http://webkit.org/b/84219>
Reviewed by Antti Koivisto.
Change the identifier CSSPrimitiveValue cache in CSSValuePool from a HashMap to a
fixed-size array of RefPtr<CSSPrimitiveValue>s.
We have ~700 values total, so this is quite space efficient now that the CSSValuePool
is globally shared. More importantly it avoids a hash lookup every time we need an
identifier value.
- css/CSSValuePool.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):
- 7:48 PM April 2012 Meeting edited by
- For logistical reasons, test importing session needs to take place … (diff)
- 6:13 PM April 2012 Meeting edited by
- (diff)
- 6:10 PM April 2012 Meeting edited by
- (diff)
- 6:08 PM April 2012 Meeting edited by
- (diff)
- 5:52 PM Changeset in webkit [114473] by
-
- 7 edits in trunk/Source
[Chromium] Clean up texture ids on the impl side when losing the context
https://bugs.webkit.org/show_bug.cgi?id=84122
Reviewed by James Robinson.
Tested by CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext.
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::didLoseContext):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::didLoseContext):
(WebCore):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::didLoseContext):
(WebCore):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
- 5:33 PM Changeset in webkit [114472] by
-
- 12 edits in branches/dfgopt/Source/JavaScriptCore
DFG should have out-of-line slow paths
https://bugs.webkit.org/show_bug.cgi?id=83992
Reviewed by Oliver Hunt.
Introduces the notion of slow path code generation closures in the DFG.
These are defined in DFGSlowPathGenerator.h, though they are fairly
extensible so DFGSpeculativeJIT64.cpp and DFGSpeculativeJIT32_64.cpp
define a couple special-purpose ones. A slow path generation closure
(DFG::SlowPathGenerator) is executed after the main speculative path is
generated. This makes them great for scheduling slow path code out of
the way of the hot paths.
This patch also converts most - but not all - of the DFG to use slow
path generators instead of inline slow paths.
The result is a sub-1% improvement on SunSpider and V8, and a miniscule
regression on Kraken.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(TrustedImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):
- bytecode/StructureStubInfo.h:
- dfg/DFGCommon.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(DFG):
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
(JITCompiler):
- dfg/DFGSilentRegisterSavePlan.h: Added.
(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):
- dfg/DFGSlowPathGenerator.h: Added.
(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
- dfg/DFGSpeculativeJIT.h:
(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- 5:31 PM Changeset in webkit [114471] by
-
- 3 edits in trunk/Source/WebCore
Change RenderThemeChromiumSkia paint methods to use pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=84175
Reviewed by Eric Seidel.
No new tests, no change in functionality.
Change RenderThemeChromiumSkia to use subpixel types and pixel snap
values just before painting.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumSkia.h:
2012-04-17 Levi Weintraub <leviw@chromium.org>
Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209
Reviewed by Eric Seidel.
Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit
No new tests. No change in behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.
- platform/graphics/FractionalLayoutPoint.h:
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.
- rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.
- rendering/RenderText.h:
(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.
- 5:30 PM Changeset in webkit [114470] by
-
- 8 edits in trunk/Source/WebCore
2012-04-17 Levi Weintraub <leviw@chromium.org>
Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209
Reviewed by Eric Seidel.
Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit
No new tests. No change in behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.
- platform/graphics/FractionalLayoutPoint.h:
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.
- rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.
- rendering/RenderText.h:
(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.
- 5:29 PM Changeset in webkit [114469] by
-
- 2 edits in trunk/Tools
build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213
Reviewed by Eric Seidel.
Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.
- Scripts/webkitdirs.pm:
(determineIsChromiumNinja):
- 5:24 PM Changeset in webkit [114468] by
-
- 2 edits in trunk/Source/WebCore
Ensure CSSParser member variables are initialized.
https://bugs.webkit.org/show_bug.cgi?id=84205
Reviewed by Andreas Kling.
No new tests / code cleanup only.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
- 5:19 PM Changeset in webkit [114467] by
-
- 2 edits in trunk/Source/WebCore
Regression(114172): Use after free in CustomFilterProgram::notifyClients
https://bugs.webkit.org/show_bug.cgi?id=84000
Reviewed by Dean Jackson.
The function returned early and the shaders didn't have a chance to be saved. Moving
those two lines before the return false just to make sure that FilterEffectRenderer never adds
itself as a client for a shader without keeping track of that.
No new tests. The problem reproduces with existing tests.
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/effect-custom-combined-missing.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
- 4:44 PM Changeset in webkit [114466] by
-
- 2 edits in trunk/LayoutTests
Re-enable W3C canPlayType() tests on Chromium
https://bugs.webkit.org/show_bug.cgi?id=84164
They use the new expectations override from changeset 112937 and pass after http://crrev.com/132463.
Unreviewed, layout test expectations update.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-17
- platform/chromium/test_expectations.txt:
- 4:26 PM Changeset in webkit [114465] by
-
- 1 edit1 delete in trunk/LayoutTests
REGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84206
Remove expected failing test results for fast/harness/use-page-cache.html.
- platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Removed.
- 4:26 PM Changeset in webkit [114464] by
-
- 3 edits5 adds in trunk
IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Ojan Vafai.
Source/WebCore:
When iterating backwards with PREV_NO_DUPLICATE, keep walking past
the 'prev' key until it changes, then walk forward one time. This
covers the object store and index cases.
Test: storage/indexeddb/mozilla/index-prev-no-duplicate.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
LayoutTests:
Test for PREV_NO_DUPLICATE.
- storage/indexeddb/cursor-prev-no-duplicate.html: Added.
- storage/indexeddb/cursor-prev-no-duplicate.txt: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate.html: Added.
- storage/indexeddb/resources/cursor-prev-no-duplicate.js: Added.
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(runAllTests):
(waitFor):
(complete.fireCallback):
(complete):
(testFarRangeCursor):
(makeOpenKeyCursor):
(runTest.trans.oncomplete):
(runTest.testFunction):
(runTest):
- 4:20 PM Changeset in webkit [114463] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskip some WebSocket worker tests that should not be skipped.
- platform/chromium/test_expectations.txt:
- 4:17 PM Changeset in webkit [114462] by
-
- 2 edits in trunk/LayoutTests
need to rebaseline after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84184
Unreviewed. expectations change only.
- platform/chromium/test_expectations.txt:
- 4:12 PM April 2012 Meeting edited by
- (diff)
- 4:10 PM Changeset in webkit [114461] by
-
- 3 edits2 adds in trunk
Caret is not rendered properly inside an input element with text-indent
https://bugs.webkit.org/show_bug.cgi?id=82688
Reviewed by Ryosuke Niwa.
For an empty input element, there is no RenderText. Instead, RenderBlock::localCaretRect provides
the caret position for rendering the caret in the empty input element. To get correct caret rect,
textIndentOffset() should be used to adjust the caret's position.
Source/WebCore:
Test: editing/style/text-indent.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
LayoutTests:
- editing/style/text-indent-expected.txt: Added.
- editing/style/text-indent.html: Added.
- 4:08 PM Changeset in webkit [114460] by
-
- 2 edits in trunk/Tools
Add caching to the flakiness dashboard json files
https://bugs.webkit.org/show_bug.cgi?id=84198
Reviewed by Dirk Pranke.
- TestResultServer/handlers/testfilehandler.py:
(GetFile._get_file_list):
(GetFile._get_file_content):
(GetFile._get_file_content_from_key):
(GetFile._get_test_list_json):
(GetFile._serve_json):
Add a Last-Modified header and handle If-Modified-Since headers.
(GetFile.get):
- 4:03 PM Changeset in webkit [114459] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempt to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:02 PM Changeset in webkit [114458] by
-
- 2 edits in trunk/Source/WebKit/chromium
[MutationObservers] enable V8RecursionScope debug ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=84094
Reviewed by Ojan Vafai.
This patch enables the ASSERT() which enforces usage of
V8RecursionScope.
- src/WebKit.cpp:
(WebKit::assertV8RecursionScope):
- 4:01 PM Changeset in webkit [114457] by
-
- 7 edits in trunk/Source
It should be possible to create an inheritorID for the global this object without crashing
https://bugs.webkit.org/show_bug.cgi?id=84200
<rdar://problem/11251082>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
- runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::unwrappedObject):
(JSGlobalThis):
- runtime/JSObject.cpp:
(JSC::JSObject::createInheritorID):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):
Source/WebCore:
No new tests, because the circumstances necessary to make this happen are rather hairy.
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
- 3:57 PM Changeset in webkit [114456] by
-
- 5 edits4 copies in branches/safari-534.57-branch
Merge 109480.
- 3:56 PM Changeset in webkit [114455] by
-
- 2 edits in trunk/Source/WebCore
Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
https://bugs.webkit.org/show_bug.cgi?id=83544
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
The code as it stands appears to be correct, but static analysis was concerned that value could become null.
This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 3:54 PM Changeset in webkit [114454] by
-
- 1 copy in branches/dfgopt
New branch for JSC DFG work
- 3:51 PM Changeset in webkit [114453] by
-
- 4 edits in branches/safari-534.57-branch/Source/WebCore
Fix for 11238384.
- 3:48 PM Changeset in webkit [114452] by
-
- 4 edits in trunk/Source
[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
https://bugs.webkit.org/show_bug.cgi?id=84182
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
Source/WebKit/chromium:
- WebKit.gyp:
- 3:43 PM Changeset in webkit [114451] by
-
- 13 edits in trunk
Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>
Reviewed by Andreas Kling.
Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
fires while it's already unresponsive.
- UIProcess/API/C/WKPage.h:
- UIProcess/ResponsivenessTimer.cpp:
(WebKit):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
- UIProcess/ResponsivenessTimer.h:
(Client):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
Tools: Need a client callback for when the user tries to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>
Reviewed by Andreas Kling.
Add new client functions.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 3:42 PM Changeset in webkit [114450] by
-
- 12 edits2 adds in trunk/Source
[Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=83972
Patch by David Reveman <reveman@chromium.org> on 2012-04-17
Reviewed by James Robinson.
Source/WebCore:
Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::textureUploader):
(LayerRendererChromium):
- platform/graphics/chromium/TextureUploader.cpp: Added.
(WebCore):
(WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::uploadTexture):
- platform/graphics/chromium/TextureUploader.h: Added.
(WebCore):
(TextureUploader):
(WebCore::TextureUploader::~TextureUploader):
(AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::create):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(WebCore):
(CCTextureUpdater):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
Source/WebKit/chromium:
- tests/CCTiledLayerTestCommon.h:
(FakeTextureUploader):
(WebKitTests::FakeTextureUploader::uploadTexture):
(WebKitTests):
- tests/Canvas2DLayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 3:37 PM Changeset in webkit [114449] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:32 PM Changeset in webkit [114448] by
-
- 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore
Merged r107647.
- 3:29 PM Changeset in webkit [114447] by
-
- 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore
Merged r112966.
- 3:23 PM Changeset in webkit [114446] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r111977.
- 3:17 PM Changeset in webkit [114445] by
-
- 4 edits in branches/safari-534.57-branch/WebKitLibraries
Merged r113649.
- 3:16 PM Changeset in webkit [114444] by
-
- 2 edits in trunk/Source/WebCore
Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547
Reviewed by Kentaro Hara.
Removed multiple unnecessary calls to m_valueList->current().
Restructured logic for parsing second value to make it clearer.
No new tests / code cleanup only.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillRepeat):
- 3:15 PM Changeset in webkit [114443] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r113528.
- 3:09 PM Changeset in webkit [114442] by
-
- 2 edits in trunk/Tools
nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84190
Reviewed by Ojan Vafai.
LayoutTestHelper would exit when the user typed ctrl-c, but we
would attempt to write to it to shut it down, generating an
IOError.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.stop_helper):
- 3:04 PM Changeset in webkit [114441] by
-
- 3 edits in trunk/Tools
rename --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=84188
Reviewed by Ojan Vafai.
I thought this was done long ago; rename
--experimental-fully-parallel to just --fully-parallel and
remove the --no- switch that AFAIK no one uses.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 3:03 PM Changeset in webkit [114440] by
-
- 3 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 3:03 PM Changeset in webkit [114439] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r111108.
- 2:59 PM Changeset in webkit [114438] by
-
- 7 edits in branches/safari-534.57-branch
Merge 112023.
- 2:51 PM Changeset in webkit [114437] by
-
- 16 edits in trunk/Source/WebCore
Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83816
Reviewed by James Robinson.
No change in behavior expected.
This code adds several functions on RenderBoxModelObject to forward
to the associated layer. This removes the RenderLayer dependencies
at the call sites.
Currently only RenderBoxModelObject can be hardware accelerated as
we need a RenderLayer, this looks like the best place to put those
new functions.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::contentChanged):
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
(WebCore::RenderBoxModelObject::startTransition):
(WebCore::RenderBoxModelObject::transitionPaused):
(WebCore::RenderBoxModelObject::transitionFinished):
(WebCore::RenderBoxModelObject::startAnimation):
(WebCore::RenderBoxModelObject::animationPaused):
(WebCore::RenderBoxModelObject::animationFinished):
(WebCore::RenderBoxModelObject::suspendAnimations):
- rendering/RenderBoxModelObject.h:
Added the previous functions to hide the layer need.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasAcceleratedCompositing):
- rendering/RenderLayer.h:
Removed the previous method as it was superseeded by the
one on RenderBoxModelObject. Also moved the ContentChangeType
enumaration.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
Updated after the ContentChangeType enumaration move.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::freezeAtTime):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
Updated all those call sites to use the new functions. Also
removed unneeded RenderLayer.h include as we went.
- 2:49 PM Changeset in webkit [114436] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r110150.
- 2:43 PM Changeset in webkit [114435] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r110139.
- 2:41 PM Changeset in webkit [114434] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG and LLInt should not clobber the frame pointer on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84185
<rdar://problem/10767252>
Reviewed by Gavin Barraclough.
Changed LLInt to use a different register. Changed DFG to use one fewer
registers. We should revisit this and switch the DFG to use a different
register instead of r7, but we can do that in a subsequent step since
the performance effect is tiny.
- dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
- offlineasm/armv7.rb:
- 2:32 PM Changeset in webkit [114433] by
-
- 3 edits in trunk/Source/WebCore
-webkit-mask-box-image does not draw when layer tree flattening is enabled
https://bugs.webkit.org/show_bug.cgi?id=84111
Reviewed by Simon Fraser.
No new tests since taking pixel test results with
PaintBehaviorFlattenCompositingLayers set is not currently supported.
<https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.
When painting mask images, we should take the non-composited path if
layers are being flattened.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintMask):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages):
- 2:28 PM Changeset in webkit [114432] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merge 114142.
- 1:56 PM Changeset in webkit [114431] by
-
- 2 edits in trunk/Source/WebCore
Rollout r114404 as it broke a couple of chromium builds.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
- 1:48 PM Changeset in webkit [114430] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 1:45 PM Changeset in webkit [114429] by
-
- 1 copy in branches/safari-534.57-branch
New Branch.
- 1:44 PM Changeset in webkit [114428] by
-
- 1 delete in branches/safari-534.57-branch
Remove branch.
- 1:32 PM Changeset in webkit [114427] by
-
- 4 edits3 adds in trunk
localStorage.setItemcan overwritelocalStoragemethods
https://bugs.webkit.org/show_bug.cgi?id=30996
Source/WebCore:
Update the JSC and V8 bindings such that if the name of the DOM
Storage property being retrieved is a match for a property in the
prototype, always return the prototype version. If there is a DOM
Storage key of the same name, it can still be retrieved via the
getItem method. This prevents storage methods from being
accidentally hidden. This brings WebKit behavior in line with the
de facto standard implemented by FireFox and IE.
Reviewed by Kentaro Hara.
Test: storage/domstorage/storage-functions-not-overwritten.html
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyGetter):
LayoutTests:
Add a test to verify that setting a DOM Storage key with the same name
as a function on the Storage object does not prevent that function
being called, but also that it can still be retrieved via the getItem
function.
Reviewed by Kentaro Hara.
- storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.
(doWedgeThySelf):
(testStorage):
(runTest):
- storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
- storage/domstorage/storage-functions-not-overwritten.html: Added.
- 1:25 PM Changeset in webkit [114426] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.
Unreviewed.
- platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.
- 1:21 PM Changeset in webkit [114425] by
-
- 2 edits in trunk/Source/WebCore
Fix Chromium/Windows build broken by r114404.
- platform/FractionalLayoutUnit.h:
- 1:17 PM Changeset in webkit [114424] by
-
- 12 edits in branches/subpixellayout/Source/WebCore
Reverting ShadowData to integers, and applying the refactoring from Bug 84098. Also fixing a bug that only showed up in Mac WebKit2 related to the GraphicsContext function roundToDevicePixels, which doesn't when there's no transform (whoops).
- 1:08 PM Changeset in webkit [114423] by
-
- 2 edits in trunk/LayoutTests
Reorganise Chromium test_expectations to group SVG expectations.
Unreviewed Chromium expectations change.
This is done to make future maintenance easier.
- platform/chromium/test_expectations.txt:
- 1:05 PM Changeset in webkit [114422] by
-
- 7 edits in trunk
EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Martin Robinson.
Source/WebKit/efl:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::callShouldCloseOnWebView):
LayoutTests:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.
- platform/efl/Skipped:
- 1:05 PM Changeset in webkit [114421] by
-
- 7 edits in trunk/Source/WebCore
[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103
Reviewed by Nate Chapin.
This patch improves the performance of a lot of DOM attribute
getters that return a string.
- Improves the performance of Dromaeo/dom-attr.html(element.property) by 27.7%.
- Improves the performance of Dromaeo/dom-attr.html(getAttribute) by 10.6%.
- Improves the performance of div.id, div.className, div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.
The followings are the test results in my Linux desktop.
Performance test: Dromaeo/dom-attr.html
Total: 674.64runs/s -> 707.03runs/s (+ 4.8%)
getAttribute: 1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property: 1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute: 538.88runs/s -> 548.87runs/s (+ 1.9%)
element.property = value: 644.07runs/s -> 656.67runs/s (+ 2.0%)
element.expando = value: 219.76runs/s -> 207.14runs/s (- 6.8%)
element.expando: 578.77runs/s -> 554.67runs/s (- 4.2%)
Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id: 30.70ns -> 26.70ns (+15%)
div.className: 31.10ns -> 26.40ns (+18%)
div.nodeName: 37.70ns -> 33.00ns (+14%)
text.nodeValue: 31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)
Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
- bindings/v8/V8Binding.h:
(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.
- bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
- 1:01 PM Changeset in webkit [114420] by
-
- 4 edits in trunk
[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
postProgressFinishedNotification() in order to send notifications all frames,
not just the main one.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
LayoutTests:
Unskip EFL test cases which rely on the DumpRenderTree support for
LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
frame than the main one.
- platform/efl/Skipped:
- 12:56 PM Changeset in webkit [114419] by
-
- 13 edits in trunk
[EFL] Add setting API to enable/disable XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=83281
Source/WebKit/efl:
Add setting API to enable or disable WebKit's XSSAuditor to protect
from reflective cross-site scripting attacks. Also, emit the signal
'xss,detected' and provide addition information received from
XSSAuditor when reflected XSS is encountered in the page.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didDetectXSS):
- ewk/ewk_frame.cpp:
(ewk_frame_xss_detected):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_xss_auditor_get):
(ewk_view_setting_enable_xss_auditor_set):
- ewk/ewk_view.h:
Tools:
Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
'xss,detected' in DRT to enable a test, which is expecting a line containing
'didDetectXSS' in the output when reflected XSS is encountered in the page.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onDidDetectXSS):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setXSSAuditorEnabled):
LayoutTests:
Unskip tests in http/tests/security/xssAuditor
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.
- platform/efl/Skipped:
- 12:48 PM Changeset in webkit [114418] by
-
- 3 edits2 adds in trunk
Crash in invalid index for _textMarkerForIndex
https://bugs.webkit.org/show_bug.cgi?id=84104
Reviewed by Beth Dakin.
Source/WebCore:
Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
LayoutTests:
- platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
- platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.
- 12:44 PM Changeset in webkit [114417] by
-
- 15 edits in trunk
HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101
Reviewed by Dan Bernstein.
Source/WebCore:
No new tests; updated platform results which were previously rebaselined.
Use the correct CSS keyword for the -webkit-appearance of the full screen button.
- css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
LayoutTests:
- platform/mac/media/controls-after-reload-expected.png:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.png:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-no-audio-expected.png:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-playing-and-pause-expected.png:
- platform/mac/media/video-playing-and-pause-expected.txt:
- 12:33 PM Changeset in webkit [114416] by
-
- 2 edits2 adds in trunk/LayoutTests
SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068
Unreviewed Chromium expectations update.
- platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
- platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:30 PM Changeset in webkit [114415] by
-
- 7 edits1 add in trunk/LayoutTests
Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613
Unreviewed Chromium expectations update.
- platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
- platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
- platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
- platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
- platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:24 PM Changeset in webkit [114414] by
-
- 2 edits in trunk/Source/WebKit2
Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=84180
<rdar://problem/11265113>
Reviewed by Andreas Kling.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
- 12:23 PM Changeset in webkit [114413] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714
Unreviewed Chromium expectations update.
- platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
- platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:22 PM Changeset in webkit [114412] by
-
- 2 edits in trunk/Source/JavaScriptCore
use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
https://bugs.webkit.org/show_bug.cgi?id=83942
<rdar://problem/11247370>
Reviewed by Gavin Barraclough.
Don't use references to the graph after resizing the graph.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgument):
- 12:19 PM Changeset in webkit [114411] by
-
- 3 edits4 adds in trunk/LayoutTests
getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631
Unreviewed Chromium expectations update.
- platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
- platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:15 PM Changeset in webkit [114410] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253
Unreviewed Chromium expectations update.
- platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
- platform/chromium/test_expectations.txt:
- 12:11 PM Changeset in webkit [114409] by
-
- 4 edits in trunk/Source/WebKit/chromium
IndexedDB: stub getKey/getObject interfaces for IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=84089
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Dimitri Glazkov.
Added stub methods on WebIDBIndex.h to cleanly land
https://bugs.webkit.org/show_bug.cgi?id=83638
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::getKey):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit):
(WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- 12:10 PM Changeset in webkit [114408] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Fix pixel snapping in RenderThemeChromiumSkia on branch.
- 12:09 PM Changeset in webkit [114407] by
-
- 4 edits3 adds2 deletes in trunk/LayoutTests
[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=53378
Unreviewed expectations update after the fix went in.
- platform/chromium-linux-x86/svg/zoom: Removed.
- platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-win-xp/svg/zoom: Removed.
- platform/chromium/test_expectations.txt:
- 12:03 PM Changeset in webkit [114406] by
-
- 19 edits4 adds in trunk
Framesniffing defense is too aggressive.
https://bugs.webkit.org/show_bug.cgi?id=83721
Reviewed by James Robinson.
Source/WebCore:
The RenderLayer code currently propagates scroll position to parent frames
without any cross-origin checks. This gives it a quick origin boundary check
that is set by FrameLoader only when performing a fragment navigation. This
allows us to safely relax the restriction on not scrolling at load time in
FrameLoader since the safe thing will happen later on at scroll time.
Test: http/tests/navigation/anchor-frames-same-origin.html
- dom/Document.cpp:
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
- dom/Document.h:
(Document):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
- loader/FrameLoader.h:
(FrameLoader):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
- page/FrameView.h:
(WebCore::FrameView::safeToPropagateScrollToParent):
(WebCore::FrameView::setSafeToPropagateScrollToParent):
(FrameView):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
LayoutTests:
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/navigation/anchor-frames-cross-origin-expected.txt:
- http/tests/navigation/anchor-frames-cross-origin.html:
- http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
- http/tests/navigation/anchor-frames-same-origin.html: Added.
- http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
- http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
- http/tests/navigation/resources/grandchild-with-anchor.html: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
- 11:59 AM April 2012 Meeting edited by
- (diff)
- 11:58 AM Changeset in webkit [114405] by
-
- 8 edits in trunk
Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- check for join function, use fast case if base object is array & join is present & default.
- runtime/CommonIdentifiers.h:
- added 'join'.
LayoutTests:
- fast/js/array-functions-non-arrays-expected.txt:
- check in new results
- fast/js/array-prototype-properties-expected.txt:
- new more detailed error message.
- fast/js/script-tests/array-functions-non-arrays.js:
- added new test cases, fix incorrect one.
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
- check in failing result (test is wrong)
- 11:51 AM Changeset in webkit [114404] by
-
- 2 edits in trunk/Source/WebCore
Add size_t versions of multiplication and division operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848
Reviewed by Julien Chaffraix.
Add size_t versions of operator* and operator/ for platforms where there
is no ambiguity between unsigned int and size_t.
No new tests, no new functionality.
- platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
(WebCore::operator*):
(WebCore::operator/):
- 11:45 AM Changeset in webkit [114403] by
-
- 7 edits in trunk/LayoutTests
Update long-failing Chromium expectations.
Unreviewed Chromium expectation update.
There is some chance that the background test is flaky, as many others are.
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:35 AM Changeset in webkit [114402] by
-
- 4 edits in trunk/Source
Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936
Reviewed by Adele Peterson.
Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 11:21 AM Changeset in webkit [114401] by
-
- 51 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
Modified as described above.
(GenerateHeader):
(NativeToJSValue):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
- bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- 11:20 AM Changeset in webkit [114400] by
-
- 3 edits4 adds2 deletes in trunk/LayoutTests
Update Chromium test expectations for long failing tests.
Unreviewed Chromium test expectations update.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/chromium-linux/svg/carto.net/combobox-expected.png: Added.
- platform/chromium-linux/svg/carto.net/combobox-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:19 AM Changeset in webkit [114399] by
-
- 2 edits7 adds in trunk/LayoutTests
[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277
Unreviewed, EFL baselines for tests related to cursor
positioning behaviour.
Adding baselines and unskipping tests related to cursor
positioning behaviour after r114250.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
- platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
- platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
- platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
- platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/efl/test_expectations.txt:
- 11:11 AM Changeset in webkit [114398] by
-
- 3 edits1 add2 deletes in trunk/LayoutTests
fill-opacity does not render properly on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=78624
Unreviewed expectations update after this change.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Removed.
- platform/chromium-mac/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-win/svg/text/text-fill-opacity-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:01 AM Changeset in webkit [114397] by
-
- 3 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
https://bugs.webkit.org/show_bug.cgi?id=84142
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-17
Reviewed by Martin Robinson.
Create a cpp file needed to build EFL port with FULLSCREEN_API.
- PlatformEfl.cmake: Added WebFullScreenManagerProxyEfl.cpp to build list.
- UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
- UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Added.
(WebKit):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
- 10:59 AM Changeset in webkit [114396] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
because it was fixed in r113808.
- platform/chromium/test_expectations.txt: Removed flaky expectations.
- 10:57 AM Changeset in webkit [114395] by
-
- 23 edits6 adds1 delete in trunk/LayoutTests
[Chromium] Rebaseline after Skia changes (CR105305)
https://bugs.webkit.org/show_bug.cgi?id=84165
Unreviewed Chromium expectations update.
- platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
- platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
- platform/chromium-linux/svg/text/selection-background-color-expected.png:
- platform/chromium-linux/svg/text/selection-styles-expected.png:
- platform/chromium-linux/svg/text/text-gradient-positioning-expected.png:
- platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
- platform/chromium-mac-leopard/svg/css/composite-shadow-text-expected.png:
- platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-leopard/svg/text/selection-styles-expected.png:
- platform/chromium-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
- platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Added.
- platform/chromium-mac/svg/css/text-gradient-shadow-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/text/selection-styles-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/text/text-gradient-positioning-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Added.
- platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png: Added.
- platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Added.
- platform/chromium-win/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
- platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
- platform/chromium/test_expectations.txt:
- 10:51 AM April 2012 Meeting edited by
- (diff)
- 10:41 AM Changeset in webkit [114394] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp
Correct where we do our flooring for tables to be in setting the logical width, instead of at paint time. This avoids a bug where a 1 pixel gap would exist following a table that nothing could be placed in.
- 10:24 AM Changeset in webkit [114393] by
-
- 6 edits2 adds8 deletes in trunk/LayoutTests
new baselines for crbug 104128
https://bugs.webkit.org/show_bug.cgi?id=72746
Unreviewed Chromium expectations update, just for SVG files.
- platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png: Modified property svn:mime-type.
- platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
- platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/mac/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/qt/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- svg/css/shadow-with-large-radius-expected.txt: Added.
- svg/css/shadow-with-negative-offset-expected.txt: Added.
- 10:17 AM Changeset in webkit [114392] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: move heap snapshot data grids into their own file
https://bugs.webkit.org/show_bug.cgi?id=84160
Moved heap snapshot data grids into a separate file.
Reviewed by Pavel Feldman.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/DataGrid.js:
- inspector/front-end/HeapSnapshotDataGrids.js: Added.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
- inspector/front-end/HeapSnapshotView.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 10:12 AM Changeset in webkit [114391] by
-
- 2 edits in trunk/Source/WebCore
Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-17
Reviewed by Kentaro Hara.
Added a newline character and removed ';' after the DEFINE_GLOBAL
No test cases required for this change.
- dom/make_names.pl:
(printNamesCppFile):
- 10:09 AM Changeset in webkit [114390] by
-
- 14 edits2 adds in trunk
Source/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
and propagate calls to the MediaPlayerPrivate interface.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.
Test: http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::setSourceState):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceAddId):
(WebCore::NullMediaPlayerPrivate::sourceRemoveId):
(WebCore):
(WebCore::MediaPlayer::sourceAddId):
(WebCore::MediaPlayer::sourceRemoveId):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceAddId):
(WebCore::MediaPlayerPrivateInterface::sourceRemoveId):
Source/WebKit/chromium: Add sourceAddId() & sourceRemoveId() stubs for Chromium.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.
- public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceAddId):
(WebKit::WebMediaPlayer::sourceRemoveId):
- src/AssertMatchingEnums.cpp:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::sourceAddId):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceRemoveId):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests: Add LayoutTests for new webkitSourceAddId() & webkitSourceRemoveId() methods.
https://bugs.webkit.org/show_bug.cgi?id=83616
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.
- http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
- http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added.
- platform/chromium/test_expectations.txt:
- 10:04 AM April 2012 Meeting edited by
- (diff)
- 10:03 AM April 2012 Meeting edited by
- i would attend several of these talks :) (diff)
- 10:02 AM April 2012 Meeting edited by
- (diff)
- 10:02 AM April 2012 Meeting edited by
- (diff)
- 9:41 AM Changeset in webkit [114389] by
-
- 10 edits in trunk/Source/WebKit2
[Qt][WK2] Refactor the gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=83044
Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.
This patch implements a simple decision tree in the web page event handler
on the basis of how many active touch points the current touch event has.
Active touch points are pressed, moved or stationary and the number of these
fully determine which gesture recognizer should be updated, cancelled or
finished.
This new structure makes the internal states of the pinch and pan gesture
recognizers independent from the event type, thus makes it possible to handle
the transitions between these gestures in one centralized place which reduces
code duplication and complexity and fixes some issues regarding incorrectly
handled transitions.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit):
(WebKit::QtPanGestureRecognizer::cancel):
- UIProcess/qt/QtPanGestureRecognizer.h:
(QtPanGestureRecognizer):
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit):
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
- UIProcess/qt/QtPinchGestureRecognizer.h:
(QtPinchGestureRecognizer):
- UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
- UIProcess/qt/QtTapGestureRecognizer.h:
(QtTapGestureRecognizer):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):
- 9:31 AM Changeset in webkit [114388] by
-
- 3 edits2 adds in trunk
Web Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with open Inspector
https://bugs.webkit.org/show_bug.cgi?id=84154
Source/WebCore:
Check that a node inserted actually has a parent.
Reviewed by Yury Semikhatsky.
Test: inspector/elements/elements-panel-reload-assert.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didInsertDOMNode):
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/elements/elements-panel-reload-assert-expected.txt: Added.
- inspector/elements/elements-panel-reload-assert.html: Added.
- 9:26 AM Changeset in webkit [114387] by
-
- 2 edits in trunk/Tools
[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
Reviewed by Simon Hausmann.
Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
the corresponding parameter to the buildQMakeProjects function.
- Scripts/build-jsc:
- 9:13 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:13 AM Changeset in webkit [114386] by
-
- 12 edits in trunk
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit "load,started" and "onload,event" signals needed to support
LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
- ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
(ewk_frame_load_started):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_load_started):
(ewk_view_onload_event):
- ewk/ewk_view.h:
Tools:
Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. Make use of the new frame argument passed to
the "load,started" and "load,finished" signals.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.
- platform/efl/Skipped:
- 9:12 AM Changeset in webkit [114385] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149
Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.
Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.
Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.
- webkit/webkitwebview.cpp:
(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)
- 9:10 AM Changeset in webkit [114384] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r113172) Wheel events are scrolling inversed.
https://bugs.webkit.org/show_bug.cgi?id=84156
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
- 8:50 AM Changeset in webkit [114383] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543
Reviewed by Adrienne Walker.
It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.
One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.
Covered by existing tests.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- 8:38 AM Changeset in webkit [114382] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148
Reviewed by Pavel Feldman.
TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
- 8:37 AM Changeset in webkit [114381] by
-
- 13 edits in trunk
Unreviewed, rolling out r114376.
http://trac.webkit.org/changeset/114376
https://bugs.webkit.org/show_bug.cgi?id=84155
Wrong patch version committed, asked by the patch author.
(Requested by rakuco on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
- WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
- ewk/ewk_frame.cpp:
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
- ewk/ewk_view.h:
Tools:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onWillSendRequest):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
- platform/efl/Skipped:
- 8:20 AM Changeset in webkit [114380] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Pattern matching should be applied to numbers
https://bugs.webkit.org/show_bug.cgi?id=84152
Reviewed by Antonio Gomes.
PR 148906.
Add pattern matching for number based on [0-9] to trigger
input help matching number fields.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
- 8:20 AM Changeset in webkit [114379] by
-
- 3 edits2 adds in trunk
REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958
Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.
.:
Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.
- ManualTests/resources/iframe-reloaded-on-touch.html: Added.
- ManualTests/touch-stale-iframe-crash.html: Added.
Source/WebCore:
Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.
ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- 8:18 AM Changeset in webkit [114378] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
[Chromium] Rebaseline svg/carto.net/colourpicker.svg
Unreviewed Chromium test expectations update.
This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.
- platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
- platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 8:06 AM Changeset in webkit [114377] by
-
- 36 edits12 adds5 deletes in trunk/LayoutTests
[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150
Unreviewed Chromium test expectations update.
- fast/repaint/background-misaligned-expected.txt: Added.
- platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
- platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
- platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
- platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-win-vista/fast/repaint: Added.
- platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-win-xp/svg/as-border-image: Removed.
- platform/chromium-win/fast/repaint/background-misaligned-expected.png:
- platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
- platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
- platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
- platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
- platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
- platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.
- 8:02 AM Changeset in webkit [114376] by
-
- 13 edits in trunk
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
from postProgressFinishedNotification() since it is already emitted
from dispatchDidFinishLoad(). This avoids unwanted extra signals we
prevent some tests from passing (e.g.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
- WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
- ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_onload_event):
- ewk/ewk_view.h:
Tools:
Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.
- platform/efl/Skipped:
- 7:15 AM Changeset in webkit [114375] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Unreviewed ARM build fix
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain): Export this function.
- 7:02 AM Changeset in webkit [114374] by
-
- 5 edits3 adds in trunk
Asserts in XMLHttpRequestProgressEventThrottle
https://bugs.webkit.org/show_bug.cgi?id=81506
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Julien Chaffraix.
Source/WebCore:
The asserts were incorrectly triggered because suspending active DOM objects
(which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
from running or suspend any running loader we may have. The previous code would
assume those 2 cases were impossible.
When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
is suspended the object may attempt to dispatch events. This patch defers these events
until the object is resumed.
Progress events are coalesced similar to normal throttling, and readystate-change events
are coalesced to avoid identical events emitted right after eachother.
On resume the events are dispatched after a timer to avoid interfering with
ScriptExecutionContext which is iterating over suspended objects.
Test: fast/events/pagehide-xhr-open.html
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):
- xml/XMLHttpRequestProgressEventThrottle.h:
(XMLHttpRequestProgressEventThrottle):
LayoutTests:
Tests that xmlhttprequest.open does not assert in when called from onpagehide.
- fast/events/pagehide-xhr-open-expected.txt: Added.
- fast/events/pagehide-xhr-open.html: Added.
- fast/events/resources/subframe-xmlhttprequest.html: Added.
- platform/chromium/test_expectations.txt:
- 6:44 AM Changeset in webkit [114373] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035
Reviewed by Pavel Feldman.
Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
- 6:35 AM Changeset in webkit [114372] by
-
- 1 edit1 move in trunk/PerformanceTests
Web Inspector: the fix for test after massive rename in r114271.
https://bugs.webkit.org/show_bug.cgi?id=84147
Drive by fix. The test was renamed to heap-snapshot.html
Reviewed by Yury Semikhatsky.
- inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.
- 6:30 AM WebKit Team edited by
- (diff)
- 6:29 AM Changeset in webkit [114371] by
-
- 2 edits in trunk/Tools
[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
https://bugs.webkit.org/show_bug.cgi?id=83035
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.
The force_static_libs_as_shared feature for the Qt port will remove
hide_symbols from Qt's CONFIG in order to make them visible to other
libraries again.
Due to an evaluation order problem in qmake, the flags for the C++ compiler
that are set by adding hide_symbols to the CONFIG variables get applied
to qmake's C++ compiler flags directly and hence trying to remove these
later will not work and cause build failures when using the force_static_libs_as_shared
feature of the Qt port.
This is fixed by removing the flags that hide the exports from the compiler flags directly.
- qmake/mkspecs/features/force_static_libs_as_shared.prf:
- 6:14 AM Changeset in webkit [114370] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Zoom out on second double-tap.
https://bugs.webkit.org/show_bug.cgi?id=84145
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 6:10 AM Changeset in webkit [114369] by
-
- 2 edits in trunk/LayoutTests
Need to rebaseline these images after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84144
Unreviewed. Expectations change only
- platform/chromium/test_expectations.txt:
- 6:03 AM Changeset in webkit [114368] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [regression r112413]content scripts tree outline is not added to the tab.
https://bugs.webkit.org/show_bug.cgi?id=84146
Reviewed by Vsevolod Vlasov.
Adding the tree to the container.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
- 4:56 AM Changeset in webkit [114367] by
-
- 31 edits in trunk/Source
[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=83285
Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
- platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.
(WebCore):
- platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.
Source/WebKit/efl:
Remove WebCore namespace from PageClientEfl.
- WebCoreSupport/PageClientEfl.cpp:
(WebCore):
- WebCoreSupport/PageClientEfl.h:
- ewk/ewk_private.h:
(EWKPrivate):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(EWKPrivate::corePageClient):
Source/WebKit2:
Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
Add dummy functions for public API implementation related to context menu.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
- Shared/WebContextMenuItem.cpp:
- Shared/WebContextMenuItem.h:
- Shared/WebContextMenuItemData.cpp:
- Shared/WebContextMenuItemData.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/WebPageContextMenuClient.cpp:
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
- WebProcess/WebPage/WebContextMenu.cpp:
- WebProcess/WebPage/WebContextMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 4:53 AM Changeset in webkit [114366] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, fix wrong paths to JS resources in GTK tests.
- platform/gtk/accessibility/aria-list-and-listitem.html:
- platform/gtk/accessibility/aria-option-role.html:
- platform/gtk/accessibility/aria-option-role-expected.txt: Fixed
typo in the expected output.
- 4:36 AM Changeset in webkit [114365] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.
Patch by János Badics <János Badics> on 2012-04-17
- platform/qt-5.0/Skipped:
- 4:35 AM Changeset in webkit [114364] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Rebaseline and add platform specific expectations, after r114283.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-17
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:
- 4:05 AM Changeset in webkit [114363] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectations for worker WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=84125
Add BUGWK84125 and mark as CRASH.
- platform/chromium/test_expectations.txt:
- 3:58 AM Changeset in webkit [114362] by
-
- 2 edits2 moves5 adds in trunk/LayoutTests
Unreviewed, GTK rebaseline after r113981.
- accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
- accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
- platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
- platform/gtk/accessibility/aria-list-and-listitem.html: Added.
- platform/gtk/accessibility/aria-option-role-expected.txt: Added.
- platform/gtk/accessibility/aria-option-role.html: Added.
- platform/gtk/accessibility/lists-expected.txt: Added.
- platform/gtk/test_expectations.txt:
- 2:48 AM Changeset in webkit [114361] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Export the initialization function so it can be called earlier.
https://bugs.webkit.org/show_bug.cgi?id=84134
Reviewed by Nikolas Zimmermann.
- Api/BlackBerryGlobal.h: export globalInitialize()
(WebKit):
- 1:37 AM April 2012 Meeting edited by
- (diff)
- 1:36 AM Changeset in webkit [114360] by
-
- 7 edits in trunk/Source/WebCore
Introduce an internal feature for a fixed placeholder
https://bugs.webkit.org/show_bug.cgi?id=84009
Reviewed by Hajime Morita.
This change adds a framework to support fixed placeholder string for
textfield-like <input> without the palceholder attribute support. This
doesn't change any behavior of input types which support the
'placeholder' attribute.
According to the standard, <input type=date> doesn't support the
'placeholder' attribute. However it is a kind of text field in WebKit
platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
information as the default placeholder.
No new tests because of no behavior changes.
- html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.
- html/HTMLInputElement.h:
(HTMLInputElement): Overrides isPlaceholderEmpty().
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPlaceholderEmpty):
Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().
- html/InputType.cpp:
(WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
(WebCore::InputType::fixedPlaceholder): Added. Returns a null string.
- html/InputType.h:
(InputType): Add usesFixedPlaceholder() and fixedPlaceholder().
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().
- 1:20 AM Changeset in webkit [114359] by
-
- 4 edits1 copy in trunk/Source/WebCore
Move some code of LocalizedNumberICU.cpp to ICULocale.cpp
https://bugs.webkit.org/show_bug.cgi?id=84128
Reviewed by Hajime Morita.
No new tests. No behavior change.
- WebCore.gypi: Add ICULocale.cpp
- platform/text/ICULocale.cpp:
Added. Move some code from LocalizedNumberICU.cpp
- platform/text/ICULocale.h:
(ICULocale): Add currentLocale().
- platform/text/LocalizedNumberICU.cpp:
(WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
(WebCore::convertFromLocalizedNumber): ditto.
- 12:47 AM Changeset in webkit [114358] by
-
- 2 edits in trunk/Source/WebCore
[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004
Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.
m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.
- plugins/PluginView.cpp:
(WebCore::PluginView::stop):
- 12:40 AM Changeset in webkit [114357] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Calendar Picker: Popup position is wrong when there are
no enough space below the target date field
https://bugs.webkit.org/show_bug.cgi?id=84007
Reviewed by Hajime Morita.
The popup was detached from the origin element because
calendarPicker.js resizes its window. To fix this bug, we move the
window position vertically when it is resized.
No new tests. This is not testable in WebKit.
- src/WebPagePopupImpl.cpp:
(WebKit::PagePopupChromeClient::setWindowRect):
If this request is just a resize and m_isPutAboveOrigin is true,
update the vertical position so that the popup attaches to the
origin rectangle.
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_isPutAboveOrigin with false.
(WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.
- src/WebPagePopupImpl.h:
(WebPagePopupImpl): Add m_isPutAboveOrigin.
- 12:30 AM Changeset in webkit [114356] by
-
- 5 edits in trunk
Calendar Picker: Support RTL layout
https://bugs.webkit.org/show_bug.cgi?id=83668
Reviewed by Hajime Morita.
.:
- ManualTests/forms/calendar-picker.html:
Add Arabic parameters.
Add <select> to select a locale.
Source/WebCore:
Manual test: ManualTests/forms/calendar-picker.html
- Resources/calendarPicker.js:
(layout): If params.isRTL, add dir=rtl to the body.
(DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::addProperty): Add addProperty() with a bool value.
(WebCore::CalendarPickerElement::writeDocument):
Check the direction of the first character of localized January label,
and pass it as isRTL property.
- 12:21 AM Changeset in webkit [114355] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.
- platform/qt/Skipped:
- 12:18 AM Changeset in webkit [114354] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium expectations.
- platform/chromium/test_expectations.txt:
- 12:18 AM Changeset in webkit [114353] by
-
- 2 edits in trunk/Tools
Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068
Reviewed by Eric Seidel.
Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
automatically creates the build directory if needed.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):
