⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 2, 2013:

11:47 PM Changeset in webkit [149519] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fine tune dependencies for glslang generated files
​https://bugs.webkit.org/show_bug.cgi?id=115537

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-05-02
Reviewed by Martin Robinson.

Make glslang.* explictly depend on glslang_tab.*, since the
dependency does exist. Otherwise Make might decide to compile
things ahead of time and fail.

  • GNUmakefile.am:
11:46 PM Changeset in webkit [149518] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Profiler should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115445

Reviewed by Geoffrey Garen.

Change the Profiler::Database API for Compilation creation so that we don't add
it to the Database until it's completely constructed. This prevents the Database
from seeing Compilations that are being concurrently constructed.

Change the Profiler::Database itself to do locking for creation of Bytecodes and
for modifying the map. This map may be consulted by both the main thread and the
concurrent thread.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • profiler/ProfilerBytecodes.h:
  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::addCompilation):

  • profiler/ProfilerDatabase.h:

(Database):

10:20 PM May 2013 Meeting - Unifying Build Systems - Notes edited by mark.salisbury@hp.com
minor edits; fixed referenced bug # (diff)
10:01 PM Changeset in webkit [149517] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warnings on ResourceHandleClient.h
​https://bugs.webkit.org/show_bug.cgi?id=115540

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-05-02
Reviewed by Alexey Proskuryakov.

Comment out the parameter names for 'getOrCreateReadBuffer' to fix -Wunused-parameter build warnings.

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::getOrCreateReadBuffer):

8:29 PM May 2013 Meeting - Unifying Build Systems - Notes created by jmason@blackberry.com
8:17 PM May 2013 Meeting edited by jmason@blackberry.com
link to Unifying Build Systems notes (diff)
7:57 PM Changeset in webkit [149516] by fpizlo@apple.com
  • 41 edits
    3 adds in branches/dfgFourthTier/Source

fourthTier: DFG tries to ref/deref StringImpls in a ton of places
​https://bugs.webkit.org/show_bug.cgi?id=115300

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Change any code transitively called from DFG compilation to use StringImpl*
directly instead of String, Identifier, or PropertyName. I use the convention
of passing "StringImpl* uid" instead of an Identifier or PropertyName.

Switch over any code transitively called from DFG compilation to use CStrings
whenever possible for all of its debug dumping.

This makes it possible to compile things without hitting the ref/deref
assertion in StringImpl.

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
(JSC::pointerToSourceString):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dumpBytecode):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::inferredName):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC):
(GetByIdStatus):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(JSC):
(PutByIdStatus):

  • bytecode/ReduceWhitespace.cpp:

(JSC::reduceWhitespace):

  • bytecode/ReduceWhitespace.h:

(JSC):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDesiredIdentifiers.cpp: Added.

(DFG):
(JSC::DFG::DesiredIdentifiers::DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::~DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredIdentifiers.h: Added.

(DFG):
(DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::numberOfIdentifiers):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::operator[]):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • parser/SourceCode.cpp: Added.

(JSC):
(JSC::SourceCode::toUTF8):

  • parser/SourceCode.h:

(SourceCode):

  • profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h:

(JSC::Profiler::Bytecodes::inferredName):
(JSC::Profiler::Bytecodes::sourceCode):
(Bytecodes):

  • runtime/Identifier.h:

(JSC::Identifier::utf8):
(JSC):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

Source/WTF:

Reviewed by Geoffrey Garen.

Make it possible to do more things directly to StringImpl*'s, including being
able to directly do utf8 conversion on a substring without creating the
substring first.

Add assertions to StringImpl that it isn't being ref/deref'd from the
compilation thread.

  • wtf/PrintStream.cpp:

(WTF::printInternal):
(WTF):

  • wtf/PrintStream.h:

(WTF):
(WTF::printInternal):

  • wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8ForRange):
(WTF::StringImpl::utf8):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::hasAtLeastOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):

6:06 PM Changeset in webkit [149515] by roger_fong@apple.com
  • 4 edits in trunk/Source

Following r149463, set Path for WebCore and WebKit makefile as well.

  • WebKit.vcxproj/WebKit.make:
6:02 PM May 2013 Meeting edited by kov@webkit.org
(diff)
5:38 PM Changeset in webkit [149514] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip html5lib test cases that were skipped due to failure after r143804.

  • platform/efl/TestExpectations:
5:25 PM Changeset in webkit [149513] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk/Source/WTF

[WinCairo] Unreviewed build fix.

  • WTF.vcxproj/WTF.vcxproj: Use WinCairo FeatureDefines
  • WTF.vcxproj/WTF.vcxproj.filters: Use WinCairo FeatureDefines
  • WTF.vcxproj/WTFDebugWinCairo.props: Added.
  • WTF.vcxproj/WTFReleaseWinCairo.props: Added.
5:09 PM Changeset in webkit [149512] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure transition table keys don't have to ref their StringImpl's
​https://bugs.webkit.org/show_bug.cgi?id=115525

Reviewed by Geoffrey Garen.

The structure transition table basically maps string to structure. The string is
always also stored, and ref'd, in the structure in Structure::m_nameInPrevious.
m_nameInPrevious is never mutated, and never cleared. The string cannot die unless
the structure dies. If the structure dies, then that entry in the transition map
becomes a zombie anyway and we will detect this separately.

So, we don't need to use RefPtr<StringImpl>. We can just use StringImpl*.

This also fixes a goof where we were getting the StringImpl's hash rather than
using a pointer hash. Not only is the latter faster, but it prevents my change
from leading to crashes: with my change we can have zombie keys, not just zombie
values. They will exist only until the next map mutation, which will clear them.
Lookups will work fine because the lookup routine will reject zombies. But it
does mean that the HashMap will have to deal with dangling StringImpl*'s; all it
takes to make this work is to ensure that the HashMap itself never dereferences
them. Using a pointer hash rather than StringImpl::existingHash() accomplishes
this.

This also ensures that we don't accidentally call ref() or deref() from the
compilation thread, if the compilation thread inspects the transition table.

And no, we wouldn't have been able to use the HashMap<RefPtr<...>, ...>
specialization, because the transition table is actually
HashMap<pair<RefPtr<StringImpl>, unsigned>, ...>: hence that specialization
doesn't kick in. We could have written a new specialization or something, but
that seemed like a lot of work given that we don't need the table to be ref'ing
the strings anyways.

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::add):

  • runtime/StructureTransitionTable.h:

(StructureTransitionTable):
(Hash):
(JSC::StructureTransitionTable::Hash::hash):

5:04 PM Changeset in webkit [149511] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed Windows build fix.

  • win/lib/WebKitSystemInterface.lib:
5:04 PM Changeset in webkit [149510] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed fix for Mac Lion build after r149503.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
5:01 PM Changeset in webkit [149509] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WTF

[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=115130

Reviewed by Tim Horton.

Windows is suffering from mismatched allocation/deallocation
between the system allocator and fastMalloc/fastFree. By turning
off the global switch to fastMalloc, only classes specified to
honor fastMalloc/fastFree are affected, and other memory allocation
and freeing is done with consistent library calls.

  • wtf/Platform.h: Deactivate ENABLE_GLOBAL_FASTMALLOC_NEW for

the Windows build.

5:00 PM Changeset in webkit [149508] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Move Mac-only symbols into the shared symbol list

  • WebCore.exp.in: Move symbols.
4:56 PM Changeset in webkit [149507] by Antti Koivisto
  • 10 edits
    2 deletes in trunk/Source/WebCore

Shadow DOM removal: Get rid of ContentSelectorQuery
​https://bugs.webkit.org/show_bug.cgi?id=115533

Reviewed by Anders Carlsson.

This is only used for Shadow DOM distribution. <details> element works fine without it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distributeSelectionsTo):

  • html/shadow/ContentSelectorQuery.cpp: Removed.
  • html/shadow/ContentSelectorQuery.h: Removed.
  • html/shadow/HTMLContentElement.cpp:
4:49 PM May 2013 Meeting edited by Bem Jones-Bey
(diff)
4:39 PM Changeset in webkit [149506] by ryuan.choi@samsung.com
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Moved XFrameOptions results from efl-wk2 to efl and rebased source-list-parsing-nonascii.html

  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
  • platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.
4:34 PM Changeset in webkit [149505] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip WebAudio test cases on EFL WK2.

  • platform/efl-wk2/TestExpectations:
4:33 PM Changeset in webkit [149504] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

border-radius clipping a canvas does not always clip
​https://bugs.webkit.org/show_bug.cgi?id=113343

Source/WebCore:

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

clipToRect method clip context to clipRect, and then clip to rounded
rect if clipRect has a radius. But currently, clipToRect exit early if
clipToRect is equal to paintDirtyRect.

This patch allows clipping to rounded corner ever if clipToRect is
equal to paintDirtyRect.

Test: fast/overflow/border-radius-clipping-2.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

LayoutTests:

Create a test that draws a canvas into a clipped overflown div with
radius corner. Then redraw that same thing a moment later. The canvas
should stay correctly clipped the second time.

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

  • fast/overflow/border-radius-clipping-2-expected.html: Added.
  • fast/overflow/border-radius-clipping-2.html: Added.
4:07 PM May 2013 Meeting edited by betravis@adobe.com
(diff)
4:06 PM Changeset in webkit [149503] by eric.carlson@apple.com
  • 18 edits
    2 copies in trunk

Caption menu does not include in-band captions
​https://bugs.webkit.org/show_bug.cgi?id=111934

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, upated existing tests for these changes.

  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal): Clear the LoadMediaResource from m_pendingActionFlags

in case there is a pending async load.

(WebCore::HTMLMediaElement::configureTextTrackGroup): Always log the track score.
(WebCore::HTMLMediaElement::configureTextTracks): Call configureTextTrackDisplay so

m_legacyWebKitClosedCaptionsVisible is always updated immediately.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Use m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Ditto.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::CaptionUserPreferences): Initialize m_displayMode to ForcedOnly

because it is no longer used for testing only.

(WebCore::CaptionUserPreferences::notify): Post notifications when not in testing-only mode.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate a track score when

webkitClosedCaptionsVisible has been set.

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Don't filter track list when we

don't have the media accessibility framework. Make logging more informative.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:

(WebCore::InbandTextTrackPrivateAVFObjC::create): Take a AVFInbandTrackParent instead of a

MediaPlayerPrivateAVFoundationObjC.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm: Added.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): We only have legible output when

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT is defined.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create a legacy CC track if

there are no media selection options and there is a CC AVAssetTrack.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyCCTracks): New, process CC tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processNewAndRemovedTextTracks): New, refactored

common setup/cleanup code from processMediaSelectionOptions.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Renamed from

processTextTracks. Move common setup/cleanup code to processNewAndRemovedTextTracks.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Deal with legacy CC tracks.

Source/WTF:

  • wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT on 10.8 and higher. Added

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT.

LayoutTests:

  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
3:57 PM Changeset in webkit [149502] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] caption track menu includes "easy to read" in-band tracks twice
​https://bugs.webkit.org/show_bug.cgi?id=115529

Reviewed by Dean Jackson.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Check to see if a track is

easy-to-read after checking if it is forced only.

3:41 PM Changeset in webkit [149501] by Antti Koivisto
  • 7 edits
    1 delete in trunk/Source/WebCore

Remove SiblingTraversalStrategies.h
​https://bugs.webkit.org/show_bug.cgi?id=115532

Reviewed by Andreas Kling.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/SiblingTraversalStrategies.h: Removed.
3:39 PM Changeset in webkit [149500] by Lucas Forschler
  • 4 edits in tags/Safari-537.40/Source/WebKit2

Merged r149499. <rdar://problem/13795795>

3:23 PM Changeset in webkit [149499] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (149389) Main resources converted to downloads are immediately cancelled.
<rdar://problem/13795795> and ​https://bugs.webkit.org/show_bug.cgi?id=115530

Reviewed by Alexey Proskuryakov.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Call didConvertHandleToDownload

on the NetworkResourceLoader.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload): Set m_handleConvertedToDownload to true.
(WebKit::NetworkResourceLoader::abort): Only cancel the handle if m_handleConvertedToDownload is false.

  • NetworkProcess/NetworkResourceLoader.h:
3:13 PM Changeset in webkit [149498] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Shadow DOM removal: Make SelectorChecker non-generic
​https://bugs.webkit.org/show_bug.cgi?id=115526

Reviewed by Andreas Kling.

Without Shadow DOM distribution we don't need SiblingTraversalStrategies anymore.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • css/SelectorChecker.cpp:

(WebCore):
(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::countElementsAfter):
(WebCore::countElementsOfTypeAfter):
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/SiblingTraversalStrategies.h:
  • css/StyleResolver.h:

(WebCore::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorDataList::checkContentSelector):

3:10 PM May 2013 Meeting edited by msaboff@apple.com
(diff)
3:09 PM May 2013 Meeting edited by msaboff@apple.com
(diff)
2:33 PM Changeset in webkit [149497] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl-wk2/TestExpectations:
1:59 PM Changeset in webkit [149496] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix potential bug in lookup logic
​https://bugs.webkit.org/show_bug.cgi?id=115522

Reviewed by Mark Hahnenberg.

Though not a problem in practise, it is technically possible
to inject an un-proxied global object into the scope chain
via the C API. This change makes sure that the scope walk
in BytecodeGenerator actually limits itself to scopes that
are statically bindable.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

  • runtime/JSObject.h:

(JSObject):
(JSC):
(JSC::JSObject::isStaticScopeObject):

1:56 PM Changeset in webkit [149495] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify WebCoreObjCExtras by using WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=115524

Reviewed by Andreas Kling.

  • platform/mac/WebCoreObjCExtras.mm:

(deallocCallback):
(WebCoreObjCScheduleDeallocateOnMainThread):

1:49 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
1:43 PM Changeset in webkit [149494] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated WebKitGTK+ Translation for Odia [or] language.
​https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

  • or.po: updated translation.
1:42 PM Changeset in webkit [149493] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WTF

Make BloomFilter fast allocated.
​https://bugs.webkit.org/show_bug.cgi?id=115519

Reviewed by Benjamin Poulain.

  • wtf/BloomFilter.h:

(BloomFilter): Make BloomFilter Fast-allocated.

1:17 PM May 2013 Meeting edited by timothy_horton@apple.com
Make the schedule words bigger! (diff)
1:00 PM Changeset in webkit [149492] by thakis@chromium.org
  • 1 edit
    1 delete in trunk/Tools

Remove a stale script file.
​https://bugs.webkit.org/show_bug.cgi?id=115521

Reviewed by Anders Carlsson.

This script was added in
​https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
Bakefile system that was removed in
​https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
script just asserts when it's run and is useless.

  • Scripts/update-sources-list.py: Removed.
12:27 PM May 2013 Meeting edited by cavalcantii@gmail.com
(diff)
12:26 PM Changeset in webkit [149491] by ap@apple.com
  • 6 edits in trunk/Source

<rdar://problem/13740375> Non-ASCII downloaded file names are garbled when using NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=115520

Reviewed by Darin Adler.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::::encodePlatformData): (CoreIPC::::decodePlatformData): Send the encoding fallback array over IPC, so that it's present when NetworkProcess does its loading.
12:17 PM May 2013 Meeting edited by cavalcantii@gmail.com
(diff)
11:33 AM May 2013 Meeting edited by rniwa@webkit.org
Remove "proposed" from both sections since they have been voted on (diff)
11:33 AM Changeset in webkit [149490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cannot touch scroll readonly text input.
​https://bugs.webkit.org/show_bug.cgi?id=115378

Patch by Genevieve Mak <​gmak@rim.com> on 2013-05-02
Reviewed by Rob Buis.

PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

11:32 AM May 2013 Meeting edited by rniwa@webkit.org
More prune & merge (diff)
11:30 AM May 2013 Meeting edited by rniwa@webkit.org
Prune & merge (diff)
11:28 AM May 2013 Meeting edited by rniwa@webkit.org
Add back the location info. (diff)
11:25 AM May 2013 Meeting edited by Beth Dakin
(diff)
10:45 AM Changeset in webkit [149489] by Lucas Forschler
  • 2 edits in tags/Safari-537.40/Source/WebKit2

Merged r149488. <rdar://problem/13787297>

9:56 AM Changeset in webkit [149488] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]
broken when second argument is nil
​https://bugs.webkit.org/show_bug.cgi?id=115505
<rdar://problem/13787297>

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile): Pass a URL string to assumeReadAccessToBaseURL, as this is what it takes.
8:52 AM Changeset in webkit [149487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
​https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-05-02
Reviewed by Rob Buis.

PR 308796
Debug build fix.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):

7:22 AM Changeset in webkit [149486] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit/gtk

Segmentation Fault with Romanian locale. Evolution not starting.
​https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

  • webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

7:06 AM WebKit Team edited by Alexandru Chiculita
(diff)
5:49 AM Changeset in webkit [149485] by zarvai@inf.u-szeged.hu
  • 14 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed. Some more gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.png:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.png:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0-wk2/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
5:13 AM Changeset in webkit [149484] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r149457 and r149388.

  • platform/qt/TestExpectations:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
12:06 AM May 2013 Meeting edited by rniwa@webkit.org
Add myself to various talks (diff)

May 1, 2013:

11:30 PM Changeset in webkit [149483] by ryuan.choi@samsung.com
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
8:45 PM Changeset in webkit [149482] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

7:38 PM Changeset in webkit [149481] by Stephanie Lewis
  • 1 edit
    1 add in trunk/LayoutTests

Update Lion results after ​http://trac.webkit.org/projects/webkit/changeset/149474

Unreviewed.

  • platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.
7:10 PM Changeset in webkit [149480] by glenn@skynav.com
  • 2 edits in trunk/Tools

[webkitpy] Need abstract base class for commands that analyze commit logs
​https://bugs.webkit.org/show_bug.cgi?id=115391

Reviewed by Benjamin Poulain.

Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
in preparation for adding two new commands that will reuse this functionality along with
suggest-nominations. See ​https://bugs.webkit.org/show_bug.cgi?id=115387 and
​https://bugs.webkit.org/show_bug.cgi?id=115388.

No new tests as this patch does not change existing functionality or behavior.

  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
(AbstractCommitLogCommand.init):
(AbstractCommitLogCommand._init_options):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
(SuggestNominations.init):
(SuggestNominations._init_options):

7:01 PM Changeset in webkit [149479] by Lucas Forschler
  • 5 edits in tags/Safari-537.39.4/Source

Merge fix for <rdar://problem/13784241>

7:01 PM Changeset in webkit [149478] by Lucas Forschler
  • 4 edits in tags/Safari-537.39.4/Source

Versioning.

6:59 PM Changeset in webkit [149477] by Lucas Forschler
  • 1 copy in tags/Safari-537.39.4

New Tag.

6:54 PM Changeset in webkit [149476] by rniwa@webkit.org
  • 7 edits in trunk/Source

[Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed
​https://bugs.webkit.org/show_bug.cgi?id=115463

Reviewed by Darin Adler.

Source/WebKit/mac:

Observe the default notification center for changes to autocorrection preferences.
Note system preferences may also update WebAutomatic* defaults.

  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _shouldAutomaticTextReplacementBeEnabled]):
(+[WebView _didChangeAutomaticTextReplacementEnabled:]):
(+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]):
(+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]):
(+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
(+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
(+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]):
(+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):

Source/WebKit2:

Observe the default notification center and propagate the changes to TextCheckerState and
to all WebProcesses when system preferences are updated.

  • UIProcess/TextChecker.h:
  • UIProcess/WebContext.h:
  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::shouldAutomaticTextReplacementBeEnabled):
(WebKit::shouldAutomaticSpellingCorrectionBeEnabled):
(WebKit::shouldAutomaticQuoteSubstitutionBeEnabled):
(WebKit::shouldAutomaticDashSubstitutionBeEnabled):
(WebKit::initializeState):
(WebKit::TextChecker::didChangeAutomaticTextReplacementEnabled):
(WebKit::TextChecker::didChangeAutomaticSpellingCorrectionEnabled):
(WebKit::TextChecker::didChangeAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::didChangeAutomaticDashSubstitutionEnabled):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::registerNotificationObservers):
(WebKit::WebContext::unregisterNotificationObservers):

6:53 PM Changeset in webkit [149475] by Lucas Forschler
  • 1 copy in tags/Safari-537.40

New Tag.

6:48 PM Changeset in webkit [149474] by enrica@apple.com
  • 3 edits
    3 adds in trunk

text-combine: horizontal does not work properly for some fonts.
​https://bugs.webkit.org/show_bug.cgi?id=115503.

Reviewed by Dave Hyatt.

Source/WebCore:

For some fonts that don't have width variants, we fail to combine glyphs
because we believe they don't fit. That decision is made comparing the run width
with the font computed size multiplied by a margin factor.
I've increased the margin from 10% to 15%.

Test: fast/text/text-combine-different-fonts.html

  • rendering/RenderCombineText.cpp:

LayoutTests:

  • fast/text/text-combine-different-fonts.html: Added.
  • platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
  • platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.
6:30 PM Changeset in webkit [149473] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix build break after r149449
​https://bugs.webkit.org/show_bug.cgi?id=115500

Reviewed by Gustavo Noronha Silva.

Unreviewed GTK build fix

  • GNUmakefile.list.am: Added LocalStorageDatabase.[cpp|h] to the list of

sources.

6:22 PM Changeset in webkit [149472] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

FastMalloc.cpp should use system defined page size instead of literal constant
​https://bugs.webkit.org/show_bug.cgi?id=115502

Reviewed by Geoffrey Garen.

Updated kPageShift to be PAGE_SHIFT for Mac. Changed kMaxSize to be fixed at 32K.
Updated kNumClasses for 4K and 16K page sizes.

  • wtf/FastMalloc.cpp:

kPageShift: Changed this to be PAGE_SHIFT on mac.

6:09 PM Changeset in webkit [149471] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream smart selection
​https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-05-01
Reviewed by Rob Buis.

Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
caused crash.
But viewport from webkitThreadViewportAccessor uses unadjusted size which is
wrong for email.
The solution here is to get actual viewport size on UI thread and then pass it
to WebKit::SelectionHandler.

PR 333763
Reviewed Internally By Jakob Petsovits.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
(WebKit):

  • Api/WebPage.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):

  • WebKitSupport/SelectionHandler.h:

(BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
(BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
(SelectionHandler):

6:07 PM Changeset in webkit [149470] by Stephanie Lewis
  • 1 edit
    3 adds in trunk/LayoutTests

Update Lion results after ​http://trac.webkit.org/projects/webkit/changeset/149450

Unreviewed.

  • platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.png: Added.
  • platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
5:40 PM Changeset in webkit [149469] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Null check plugInClient earlier in snapshotting path
​https://bugs.webkit.org/show_bug.cgi?id=115498

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-01
Reviewed by Darin Adler.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

5:39 PM Changeset in webkit [149468] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: Fix check-inspector-strings script and fix localized strings
​https://bugs.webkit.org/show_bug.cgi?id=115495

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, because there is no change in behavior.

  • English.lproj/localizedStrings.js:

Tools:

  • Scripts/check-inspector-strings:
5:38 PM Changeset in webkit [149467] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate what happens when JavaScript is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115492

Reviewed by Xan Lopez.

  • UIProcess/API/gtk/WebKitWebView.cpp: Clarify the documentation.
5:15 PM Changeset in webkit [149466] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

<object data="<some data URL>"> MIME types aren't case-insensitive
​https://bugs.webkit.org/show_bug.cgi?id=115494

Reviewed by Darin Adler.

Test: fast/images/object-data-url-case-insensitivity.html

MIME types are defined to be case-insensitive, but many places in WebCore
only compare them against lower-case strings. Most entry points for MIME
types lower-case them, but mimeTypeFromDataURL doesn't, causing, for example,
data:image/png;... to work, but data:iMaGe/PNG;... to fail.

To fix this, lower-case the string returned from mimeTypeFromDataURL.

  • platform/KURL.cpp:

(WebCore::mimeTypeFromDataURL):

Add a testcase that ensures that iMaGe/PNG == image/png when it comes to
the MIME type specified in a data URL provided to <object> via its
'data' attribute.

  • fast/images/object-data-url-case-insensitivity-expected.html: Added.
  • fast/images/object-data-url-case-insensitivity.html: Added.
5:02 PM Changeset in webkit [149465] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

[Mac] Text replacement should use correction indicator
​https://bugs.webkit.org/show_bug.cgi?id=115471

Reviewed by Darin Adler.

Support autocorrection panel for text replacements by making AlternativeTextTypeCorrection
handle text replacements as well as automatic spelling correction.

No new tests. Unfortunately this feature is not testable as is. We need to provide some
internals or testRunner methods to make this feature testable in the long term.

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired): Trigger both TextCheckingTypeReplacement
and TextCheckingTypeShowCorrectionPanel.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor): Autocorrection panel maybe used for both
TextCheckingTypeReplacement and TextCheckingTypeShowCorrectionPanel.

4:46 PM Changeset in webkit [149464] by timothy_horton@apple.com
  • 14 edits in trunk/Source

Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=115487

Reviewed by Darin Adler.

No new tests, just a refactoring.

  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:

Remove pdfAndPostScriptMIMETypes.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType): Move PDF bits to WebPageProxy.
(WebKit::WebFrameProxy::isDisplayingPDFDocument):
Make use of WebCore's newfound knowledge of PDF and PostScript MIME types,
so we don't have to duplicate it unnecessarily in WebKit2.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):
Add code which used to be in WebFrameProxy::canShowMIMEType, and adapt it
to use WebCore's knowledge of PDF and PostScript MIME types.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(WebKit::SimplePDFPlugin::pluginInfo):
We previously supported the "text/pdf" MIME type for PDFViewController,
so SimplePDFPlugin and PDFPlugin should support it as well.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType.

  • WebProcess/WebPage/WebPage.h:

(WebPage):
Remove pdfAndPostScriptMIMETypes.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange):
Adopt getPDFAndPostScriptMIMETypes instead of duplicating the list in WebKit2.

  • WebCore.exp.in:

Export newly-added isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType instead of duplicating
the list of MIME types. The previous list did not include PostScript, but
it seems reasonable to put plugins ahead of built-in support for it in addition to PDF.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializePDFAndPostScriptMIMETypes): Added.
(WebCore::initializeMIMETypeRegistry): Call initializePDFAndPostScriptMIMETypes.
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):
Consult our new HashSet to see if the given MIME type is one of those used for PDF or PS.

(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Added.

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry): Add isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

4:28 PM Changeset in webkit [149463] by roger_fong@apple.com
  • 4 edits in trunk/Source

Set Path in makefile for AppleWin.

4:20 PM Changeset in webkit [149462] by Lucas Forschler
  • 4 edits in tags/Safari-537.39.3/Source

Versioning.

4:17 PM Changeset in webkit [149461] by Lucas Forschler
  • 1 copy in tags/Safari-537.39.3

New Tag.

4:17 PM Changeset in webkit [149460] by andersca@apple.com
  • 4 edits in trunk/Source

Implement LocalStorageDatabase::importItems
​https://bugs.webkit.org/show_bug.cgi?id=115493

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Fetch items and insert them in the storage map.

  • UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::importItems):

4:01 PM Changeset in webkit [149459] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115468

Reviewed by Geoffrey Garen.

This makes the main thread modify the transition table while holding a lock. Note
that the GC might modify its weak pointers without locking, but the GC will lock out
the compilation thread anyway. The map will then only reshape in response to add()
and set(), which happen while holding a lock.

This allows the compilation thread to now query transition tables safely, provided it
holds a lock when doing so.

Also changed LLVM asm printer initialization to just initialize the X86 one. It makes
sense for us to just initialize the asm printer(s) that we actually use; you could
imagine us being linked to a system LLVM that has cross-compilation support; there is
no point in the WebKit or JSC process doing work to initialize all of those targets.
That part was rubber stamped by Mark Hahnenberg.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):

  • runtime/Structure.h:

(Structure):

3:38 PM Changeset in webkit [149458] by andersca@apple.com
  • 7 edits in trunk/Source

Begin work on loading items from the local storage database
​https://bugs.webkit.org/show_bug.cgi?id=115489

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols and SQLite headers needed.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Some of the LocalStorageDatabase code is originally from WebCore,
but has been simplified due to the fact that we don't need to load
database data asynchronously since we're already running on a non-main thread.

  • UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
(WebKit::LocalStorageDatabase::openDatabase):
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
(WebKit::LocalStorageDatabase::migrateItemTableIfNeeded):
(WebKit::LocalStorageDatabase::importItems):

  • UIProcess/Storage/LocalStorageDatabase.h:

(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::items):
Call importItemsFromDatabase().

(WebKit::StorageManager::StorageArea::importItemsFromDatabase):
Ask the database to import the items.

3:01 PM Changeset in webkit [149457] by hmuller@adobe.com
  • 19 edits in trunk

[CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115455

Source/WebCore:

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off.

Reviewed by Dirk Schulze.

  • rendering/ExclusionPolygon.cpp:

(WebCore::appendArc): Ensure that the 3rd of 5 added vertices is in the center of the arc.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Use ceiledLayoutUnit() for downwards-snapping first fit location.

  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): Ditto.

LayoutTests:

Reviewed by Dirk Schulze.

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off. This set of changes just restores four tests. It also revises
the subpixel-utils code to bring it into line with the most recent LayoutUnit et al changes
and to simplify its use a little.

  • fast/exclusions/resources/rounded-rectangle.js:

(simulateShape): Revised dependencies on subpixel-utils.

  • fast/exclusions/resources/simple-polygon.js:

(polygonXIntercepts): Ditto.

  • fast/exclusions/resources/subpixel-utils.js:

(SubPixelLayout.): Substantially revised, see description.

  • fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt:
  • fast/exclusions/shape-inside/shape-inside-polygon-layout.html:
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.txt:
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html:
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
  • platform/mac/TestExpectations:
2:50 PM Changeset in webkit [149456] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed buildfix after r149449.

  • CMakeLists.txt:
2:36 PM Changeset in webkit [149455] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure::getConcurrently() may be called from for uncacheable dictionaries, and this is safe
​https://bugs.webkit.org/show_bug.cgi?id=115464

Reviewed by Oliver Hunt and Geoffrey Garen.

This can happen for example transitively from JSObject::put(). getCurrently() does
work for uncacheable dictionaries; it just has the obvious race that right after it
returns, the result it returned may no longer be right. This isn't an issue if it was
called on the main thread, and may not be an issue in some other situations.

So, we should just remove the assertion, since the only thing it buys us is crashes.

  • runtime/Structure.cpp:

(JSC::Structure::getConcurrently):

2:22 PM Changeset in webkit [149454] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Fix the function names of r149453

Unreviewed.

I forgot to follow one of Darin's review comment. This patch
fixes the function names to follow CF naming conventions.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-01

  • WebView/WebHTMLRepresentation.mm:

(newArrayWithStrings):
(newArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

2:02 PM Changeset in webkit [149453] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Simplify WebHTMLRepresentation supportedMIMETypes methods
​https://bugs.webkit.org/show_bug.cgi?id=115314

Reviewed by Darin Adler.

The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL.
First, a new pointer was allocated on the heap with fast malloc (for RetainPtr<NSArray>).
Then a new NSMutableArray was allocated but immediately put on the autorelease pool.
Finally, that array was retained by the RetainPtr.

This patch changes the code to only leak the NSMutableArray memory. There
is no fastMalloc, nor any use of the autorelease pool.

  • WebView/WebHTMLRepresentation.mm:

(createArrayWithStrings):
(createArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

1:58 PM Changeset in webkit [149452] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149449.

  • Target.pri:
1:52 PM Changeset in webkit [149451] by benjamin@webkit.org
  • 2 edits
    2 deletes in trunk

Remove the remaining wscript
​https://bugs.webkit.org/show_bug.cgi?id=115459

Reviewed by Andreas Kling.

.:

  • wscript: Removed.

Source/JavaScriptCore:

  • wscript: Removed.
1:37 PM Changeset in webkit [149450] by enrica@apple.com
  • 3 edits
    3 adds in trunk

Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box.
​https://bugs.webkit.org/show_bug.cgi?id=115478.

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/block/lineboxcontain/block-with-ideographs.xhtml

When computing ascent and descent we need to take into account
the baseline type. RootInlineBox::ascentAndDescentForBox failed
to do that in few cases.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

LayoutTests:

  • fast/block/lineboxcontain/block-with-ideographs.xhtml: Added.
  • platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png : Added.
1:28 PM Changeset in webkit [149449] by andersca@apple.com
  • 5 edits
    2 adds in trunk/Source

Add LocalStorageDatabase class
​https://bugs.webkit.org/show_bug.cgi?id=115486

Reviewed by Sam Weinig.

Source/WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

The LocalStorageDatabase class will persist local storage data to disk.

  • UIProcess/Storage/LocalStorageDatabase.cpp:
  • UIProcess/Storage/LocalStorageDatabase.h: Added.
  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::LocalStorageNamespace::storageManager):
Add getter.

(StorageManager::LocalStorageNamespace):
(WebKit::StorageManager::StorageArea::StorageArea):
If this is a local storage area, create a LocalStorageDatabase.

(WebKit::StorageManager::LocalStorageNamespace::databaseFilename):
Helper function for getting the name of the database for the given origin.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

12:57 PM Changeset in webkit [149448] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
​https://bugs.webkit.org/show_bug.cgi?id=115289

Reviewed by Jer Noble.

No new tests, this is a speculative fix for an infrequent assertion.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackRemoveCue): Mark the cue as inactive when it is removed

from the active set.

12:55 PM Changeset in webkit [149447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

TextTrackMenu crashes in ports where MediaElement players are lazily created
​https://bugs.webkit.org/show_bug.cgi?id=115485

Null check the player for ports, like iOS, that lazily create the player.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-01
Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::platformTextTrackMenu):
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):

12:10 PM Changeset in webkit [149446] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
​https://bugs.webkit.org/show_bug.cgi?id=115470

Reviewed by Martin Robinson.

In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
not building either of the IOS, Windows or GTK-WK1 platforms.

Up until now the header was included for everything but the IOS and Windows platforms due to
an incorrectly stated condition regarding the GTK platform.

  • TestWebKitAPI/config.h:
12:09 PM Changeset in webkit [149445] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=115469

Reviewed by Martin Robinson.

Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
for the WebKit2 tests and the injected bundle required by them.

This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
under the WebKit2 code).

The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.

  • TestWebKitAPI/GNUmakefile.am:
11:59 AM Changeset in webkit [149444] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source

Add FunctionDispatcher class and make RunLoop derive from it
​https://bugs.webkit.org/show_bug.cgi?id=115480

Reviewed by Sam Weinig.

Source/WebCore:

Change RunLoop to be a subclass of FunctionDispatcher.

  • platform/RunLoop.h:

(RunLoop):

Source/WTF:

Add FunctionDispatcher files.

  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/FunctionDispatcher.cpp: Added.

(WTF::FunctionDispatcher::FunctionDispatcher):
(WTF::FunctionDispatcher::~FunctionDispatcher):

  • wtf/FunctionDispatcher.h: Added.
11:55 AM Changeset in webkit [149443] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
​https://bugs.webkit.org/show_bug.cgi?id=81856

Reviewed by Jer Noble.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there

is obviously no work to be done.

11:32 AM Writing Layout Tests for DumpRenderTree edited by achristensen@apple.com
made example test pass (diff)
11:26 AM Changeset in webkit [149442] by ap@apple.com
  • 4 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
11:14 AM Changeset in webkit [149441] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13781156> Launching NetworkProcess broken on some OS versions.

Reviewed by Anders Carlsson.

Adapt to LaunchServices changes.

  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::setApplicationIsDaemon):
11:10 AM Changeset in webkit [149440] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
​https://bugs.webkit.org/show_bug.cgi?id=114394

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-05-01
Reviewed by Anders Carlsson.

Add a setting to control accelerated 2D canvas, which determines whether
or not to consider rendering HTML canvas with hardware acceleration.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added support for enable-accelerated-2d-canvas property.
(webKitSettingsGetProperty): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_class_init): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_get_enable_accelerated_2d_canvas): Added.
(webkit_settings_set_enable_accelerated_2d_canvas): Added.

  • UIProcess/API/gtk/WebKitSettings.h: New methods.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to the documentation.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Added a simple test for the setting.

10:45 AM Changeset in webkit [149439] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Entering full screen mode shows desktop linen instead of WKView the first time.
​https://bugs.webkit.org/show_bug.cgi?id=115433
<rdar://problem/13774540>

Reviewed by Eric Carlson.

For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.

  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

10:38 AM Changeset in webkit [149438] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Closed caption lines overlap
​https://bugs.webkit.org/show_bug.cgi?id=115438
<rdar://problem/13351747>

Reviewed by Eric Carlson.

Take the line-box padding into account when determining line hight by setting
the -webkit-line-box-contain property to include 'inline-box'.

  • css/mediaControls.css:

(video::-webkit-media-text-track-container):

10:29 AM Changeset in webkit [149437] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr<CFRunLoopRef>

Fixes the following build failure:

WebCore/platform/cf/RunLoopCF.cpp:82:5: error: no matching function for call to 'CFRunLoopStop'

CFRunLoopStop(m_runLoop);

  • platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::stop): Call RetainPtr::get().

10:15 AM Changeset in webkit [149436] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

EventSource: Loss of reconnect time precision due to integer division
​https://bugs.webkit.org/show_bug.cgi?id=115358

Source/WebCore:

Make sure precision is not lost when converting the reconnect time from milliseconds to seconds.

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-retry-precision.html

  • page/EventSource.cpp:

(WebCore::EventSource::scheduleReconnect):

LayoutTests:

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

  • http/tests/eventsource/eventsource-retry-precision-expected.txt: Added.
  • http/tests/eventsource/eventsource-retry-precision.html: Added.
  • http/tests/eventsource/resources/precise-retry.asis: Added.
9:55 AM Changeset in webkit [149435] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
<​http://webkit.org/b/115386>
<rdar://problem/13769995>

Reviewed by Antti Koivisto.

Only send synchronous resize events for the main frame. Subframes change size during layout,
so it never really makes sense for them to use synchronous dispatch anyway.

  • page/FrameView.cpp:

(WebCore::FrameView::dispatchResizeEvent):

8:47 AM Changeset in webkit [149434] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial buildfix after r149432.

  • testing/Internals.cpp:

(WebCore):

7:25 AM Changeset in webkit [149433] by zarvai@inf.u-szeged.hu
  • 6 edits in trunk/Source

[Qt][Win] Fix build after r149416.
​https://bugs.webkit.org/show_bug.cgi?id=115474

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::dispatchSentMessagesUntil):

Source/WTF:

  • WTF.pro:
  • wtf/threads/BinarySemaphore.h:

(BinarySemaphore):

7:17 AM Changeset in webkit [149432] by sergio@webkit.org
  • 17 edits
    2 adds in trunk

Show a block cursor in overtype mode
​https://bugs.webkit.org/show_bug.cgi?id=114819

Reviewed by Ryosuke Niwa.

.:

  • Source/autotools/symbols.filter: export some extra symbols for

testing purposes.

Source/WebCore:

Test: editing/selection/block-cursor-overtype-mode.html

Overtype mode will use block cursor instead of a caret to
highlight the next character to be replaced. It will fully cover
the next character to be replaced (except at the end of a line
where the usual blinking caret will be shown).

This new block cursor is internally implemented as a selection
(not exposed to JavaScript) because the selection code knows how
to deal with bidi text.

  • WebCore.exp.in: Export symbols for testing purposes.
  • WebCore.order: Ditto.
  • editing/Editor.cpp:

(WebCore::Editor::toggleOverwriteModeEnabled): Added a call to
FrameLoader::setShouldShowBlockCursor.
(WebCore):

  • editing/Editor.h:

(Editor):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::updateAppearance): Use a 1-character
long selection to paint the cursor in overtype mode.
(WebCore::FrameSelection::setShouldShowBlockCursor):
(WebCore):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::shouldShowBlockCursor):
(FrameSelection):

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::selectionBounds): Added a new method which
returns the IntRect issued by FrameSelection::bounds().

  • testing/Internals.h: Ditto.
  • testing/Internals.idl: Ditto.

Source/WebKit:

Export three more WebCore symbols.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Export three more WebCore symbols.

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

New test case for the new block cursor to be used in overtype
mode. The test verifies that the 1-pixel long caret is replaced by
a selection like 1-character long block cursor when in overtype
mode. This test covers LTR and RTL text in LTR and RTL blocks and
bidi text.

  • editing/selection/block-cursor-overtype-mode-expected.txt: Added.
  • editing/selection/block-cursor-overtype-mode.html: Added.
4:22 AM Changeset in webkit [149431] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r149417.

  • GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of

sources.

3:14 AM Changeset in webkit [149430] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed buildfix after r149416 and r149417.

Unreviewed build fix.

  • CMakeLists.txt:
1:43 AM Changeset in webkit [149429] by zarvai@inf.u-szeged.hu
  • 4 edits in trunk/Source

Source/WebKit2: [Qt] Unreviewed buildfix after r149416 and r149417.

  • Target.pri:

Source/WTF: [Qt] Unreviewed buildfix after r149416.

  • WTF.pro:
Note: See TracTimeline for information about the timeline view.