Timeline
Apr 25, 2011:
- 11:59 PM Changeset in webkit [84888] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=59427
Reviewed by Adam Barth.
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask8::create):
- 11:54 PM Changeset in webkit [84887] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
Reviewed by Dan Bernstein.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
- css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
- 11:46 PM Changeset in webkit [84886] by
-
- 8 edits in trunk/Source
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
Fix include ordering.
- WebView/WebDeviceOrientationProviderMock.mm:
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage):
- Lack of OwnPtr in HashMap is sad face. This code becomes very pretty if we could use OwnPtr in HashMap...
- Platform/RunLoop.cpp: (RunLoop::performWork): (RunLoop::scheduleWork):
- Platform/RunLoop.h:
- Platform/mac/WorkQueueMac.cpp: (WorkQueue::executeWorkItem):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverData):
- 11:31 PM Changeset in webkit [84885] by
-
- 3 edits2 adds in trunk
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
Test: editing/pasteboard/paste-before-tab-span.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after positionAvoidingPrecedingNodes, since that function could once again put our position inside a tab span.
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
- editing/pasteboard/paste-before-tab-span-expected.txt: Added.
- editing/pasteboard/paste-before-tab-span.html: Added.
- 11:26 PM Changeset in webkit [84884] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict error in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=59422
Reviewed by Adam Barth.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
- 11:24 PM Changeset in webkit [84883] by
-
- 7 edits in trunk/Source/WebKit/mac
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit1 should build cleanly with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59424
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/WebNetscapePluginEventHandler.h:
- Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
- WebView/WebDeviceOrientationProviderMock.mm:
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]):
- 11:23 PM Changeset in webkit [84882] by
-
- 5 edits2 adds in trunk
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
SunSpider reports no change.
The hasCustomProperties() check didn't check for a custom prototype.
- runtime/JSObject.h: (JSC::JSObject::hasCustomProperties): Changed to delegate to Structure because it is the "truth" about an object's pedigree.
- runtime/Structure.cpp: (JSC::Structure::Structure):
- runtime/Structure.h: (JSC::Structure::didTransition): Track whether a Structure has ever transitioned for any reason. If so, we have to assume that the object holding it is custom in some way.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
- fast/dom/gc-custom-prototype-expected.txt: Added.
- fast/dom/gc-custom-prototype.html: Added.
- fast/dom/script-tests/dataset-gc.js:
- 11:22 PM Changeset in webkit [84881] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr violations and whitelist known-tricky files
https://bugs.webkit.org/show_bug.cgi?id=59421
With this patch, WebCore builds cleanly with strict OwnPtrs.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort):
- dom/XMLDocumentParserLibxml2.cpp:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu):
- page/PluginHalter.cpp:
- platform/graphics/MediaPlayer.cpp:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
- svg/SVGDocumentExtensions.cpp:
- 11:07 PM April 2011 Meeting edited by
- (diff)
- 10:57 PM April 2011 Meeting edited by
- (diff)
- 10:56 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM Changeset in webkit [84880] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in DatasetDOMStringMap.h.
https://bugs.webkit.org/show_bug.cgi?id=59419
Reviewed by Adam Barth.
- dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::create):
- 10:40 PM Changeset in webkit [84879] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Eric Seidel.
KeyboardEvent.cpp should work with strict OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=59403
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent):
- 10:25 PM April 2011 Meeting edited by
- (diff)
- 10:24 PM April 2011 Meeting edited by
- (diff)
- 10:22 PM April 2011 Meeting edited by
- Adding the Oslo webkittens (diff)
- 10:10 PM Changeset in webkit [84878] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Update some call sites that referenced the old location for
the scripts {animation, transition}-test-helpers.js. These
scripts were moved in <http://trac.webkit.org/changeset/84872>,
and <http://trac.webkit.org/changeset/84874>, respectively.
- compositing/animation/computed-style-during-delay.html:
- compositing/reflections/animation-inside-reflection.html:
- compositing/reflections/nested-reflection-animated.html:
- compositing/reflections/nested-reflection-transition.html:
- compositing/transitions/scale-transition-no-start.html:
- compositing/transitions/singular-scale-transition.html:
- 10:05 PM Changeset in webkit [84877] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- 10:05 PM April 2011 Meeting edited by
- (diff)
- 9:57 PM April 2011 Meeting edited by
- (diff)
- 9:53 PM Changeset in webkit [84876] by
-
- 2 edits in trunk/Tools
Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 9:47 PM April 2011 Meeting edited by
- (diff)
- 9:34 PM April 2011 Meeting edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:01 PM April 2011 Meeting edited by
- (diff)
- 8:44 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:40 PM April 2011 Meeting edited by
- (diff)
- 8:37 PM April 2011 Meeting edited by
- Fix tony's nick (diff)
- 8:32 PM April 2011 Meeting edited by
- (diff)
- 8:31 PM April 2011 Meeting edited by
- (diff)
- 8:25 PM Changeset in webkit [84875] by
-
- 70 edits in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Clean up transition tests
https://bugs.webkit.org/show_bug.cgi?id=59410
General test cleanup: use the named variables as
arguments to runTransitionTest() for readability,
remove unnecessary titles and meta tags, remove
style and script tag attributes etc. No substantive
changes.
- 8:25 PM April 2011 Meeting edited by
- Fix the attendee list (diff)
- 8:24 PM April 2011 Meeting edited by
- Added some attendees (diff)
- 8:17 PM Changeset in webkit [84874] by
-
- 30 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move transition-test-helpers.js to resources/
https://bugs.webkit.org/show_bug.cgi?id=59397
Move transition-test-helpers.js and fix tests.
- transitions/background-transitions.html:
- transitions/border-radius-transition.html:
- transitions/clip-transition.html:
- transitions/color-transition-all.html:
- transitions/color-transition-premultiplied.html:
- transitions/default-timing-function.html:
- transitions/font-family-during-transition.html:
- transitions/mask-transitions.html:
- transitions/min-max-width-height-transitions.html:
- transitions/mismatched-shadow-styles.html:
- transitions/move-after-transition.html:
- transitions/multiple-background-size-transitions.html:
- transitions/multiple-background-transitions.html:
- transitions/multiple-mask-transitions.html:
- transitions/multiple-shadow-transitions.html:
- transitions/negative-delay.html:
- transitions/resources/interrupted-accelerated-transition-final.html:
- transitions/resources/transition-test-helpers.js: (roundNumber): (isCloseEnough): (isShadow): (): (expected): (callback.delay):
- transitions/shorthand-border-transitions.html:
- transitions/shorthand-transitions.html:
- transitions/steps-timing-function.html:
- transitions/svg-text-shadow-transition.html:
- transitions/text-indent-transition.html:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match.html:
- transitions/transition-drt-api-delay.html:
- transitions/transition-end-event-rendering.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-shorthand-delay.html:
- transitions/zero-duration-in-list.html:
- 8:16 PM Changeset in webkit [84873] by
-
- 4 edits2 adds4 deletes in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Make a couple of animation tests into text tests
https://bugs.webkit.org/show_bug.cgi?id=59389
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html: No need for these two to be text tests.
- animations/state-at-end-event.html: General cleanup.
- animations/animation-drt-api-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/state-at-end-event.html:
- platform/mac/animations/animation-drt-api-expected.png: Removed.
- platform/mac/animations/animation-drt-api-expected.txt: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
- 8:16 PM Changeset in webkit [84872] by
-
- 48 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move animation-test-helpers.js into resources directory
https://bugs.webkit.org/show_bug.cgi?id=59365
Move animation-test-helpers.js and fix the tests accordingly.
- animations/3d/matrix-transform-type-animation.html:
- animations/3d/transform-perspective.html:
- animations/animation-direction.html:
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/big-rotation.html:
- animations/change-keyframes-name.html:
- animations/change-keyframes.html:
- animations/change-one-anim.html:
- animations/combo-transform-rotate+scale.html:
- animations/dynamic-stylesheet-loading.html:
- animations/generic-from-to.html:
- animations/import.html:
- animations/keyframe-timing-functions-transform.html:
- animations/keyframe-timing-functions.html:
- animations/keyframe-timing-functions2.html:
- animations/keyframes-comma-separated.html:
- animations/keyframes-out-of-order.html:
- animations/keyframes.html:
- animations/lineheight-animation.html:
- animations/longhand-timing-function.html:
- animations/matrix-anim.html:
- animations/missing-from-to-transforms.html:
- animations/missing-from-to.html:
- animations/missing-keyframe-properties-repeating.html:
- animations/missing-keyframe-properties-timing-function.html:
- animations/missing-keyframe-properties.html:
- animations/missing-values-first-keyframe.html:
- animations/missing-values-last-keyframe.html:
- animations/multiple-animations.html:
- animations/multiple-keyframes.html:
- animations/negative-delay.html:
- animations/opacity-transform-animation.html:
- animations/play-state-suspend.html:
- animations/play-state.html:
- animations/resources/animation-test-helpers.js: (isCloseEnough): (matrixStringToArray): (checkExpectedValue): (endTest): (startTest): (runAnimationTest.else): (runAnimationTest): (waitForAnimationToStart):
- animations/simultaneous-start-left.html:
- animations/simultaneous-start-transform.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation.html:
- animations/timing-functions.html:
- animations/transition-and-animation-1.html:
- animations/transition-and-animation-2.html:
- animations/transition-and-animation-3.html:
- animations/unanimated-style.html:
- animations/width-using-ems.html:
- 8:14 PM Changeset in webkit [84871] by
-
- 3 edits2 deletes in trunk
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- svg/custom/use-crash-in-non-wellformed-document.svg: Removed.
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument):
- 8:00 PM Changeset in webkit [84870] by
-
- 2 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84753.
- 8:00 PM Changeset in webkit [84869] by
-
- 5 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84752.
- 7:59 PM Changeset in webkit [84868] by
-
- 5 edits in tags/Safari-534.31.1/Source
Versioning.
- 7:56 PM Changeset in webkit [84867] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing, add missing baselines for Chromium Mac SL.
- platform/chromium/test_expectations.txt:
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- 7:48 PM Changeset in webkit [84866] by
-
- 1 copy in tags/Safari-534.31.1
New tag.
- 7:26 PM Changeset in webkit [84865] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/focusingUnloadedFrame.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59371
- fast/events/focusingUnloadedFrame-expected.txt: Added.
- fast/events/focusingUnloadedFrame.html:
- platform/chromium-linux/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/mac-leopard/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- 7:07 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM Changeset in webkit [84864] by
-
- 3 edits2 adds in trunk
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
- svg/SVGUseElement.cpp: (WebCore::isWellFormedDocument): (WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
Test case to verify webkit doesn't crash when a <use> element
is pending on resource and the document is not well-formed.
Test passes if no crash occurs in debug mode.
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
- svg/custom/use-crash-in-non-wellformed-document.svg: Added.
- 7:02 PM TextInputTestSuite created by
- 7:02 PM Changeset in webkit [84863] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Convert fast/loader/start-load-in-unload.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59384
- fast/loader/start-load-in-unload-expected.txt: Added.
- fast/loader/start-load-in-unload.html:
- platform/chromium-linux/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/mac-leopard/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/qt/fast/loader/start-load-in-unload-expected.txt: Removed.
- 7:01 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM Changeset in webkit [84862] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Tony Chang <tony@chromium.org>
Reviewed by Antonio Gomes.
replace a setTimeout with a onload event to save 2 seconds in a test
https://bugs.webkit.org/show_bug.cgi?id=59350
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:
- 6:44 PM Changeset in webkit [84861] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/event-sender-mouse-moved.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59366
- fast/events/event-sender-mouse-moved-expected.txt: Added.
- fast/events/event-sender-mouse-moved.html:
- platform/chromium-linux/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/gtk/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/mac-leopard/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/qt/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- 6:40 PM Changeset in webkit [84860] by
-
- 11 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.
Reviewed by Geoff Garen.
If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.
Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
- dfg/DFGSpeculativeJIT.h:
- runtime/Executable.cpp:
(JSC::tryDFGCompile):
- 6:28 PM Changeset in webkit [84859] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the news file for the 1.4.0 release.
- NEWS: Update news.
- 6:23 PM Changeset in webkit [84858] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing.
- platform/chromium/test_expectations.txt:
- 5:31 PM Changeset in webkit [84857] by
-
- 15 edits1 copy in trunk/Source/WebCore
2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Tony Chang.
Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028
The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
Moving the code for base class we can reduce the efforts to support DataTransferItems
element in different platforms.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem): (WebCore::DataTransferItem::owner): (WebCore::DataTransferItem::kind): (WebCore::DataTransferItem::type):
- dom/DataTransferItem.h:
- dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp. (WebCore::DataTransferItems::DataTransferItems): (WebCore::DataTransferItems::length): (WebCore::DataTransferItems::item): (WebCore::DataTransferItems::deleteItem): (WebCore::DataTransferItems::clear): (WebCore::DataTransferItems::add):
- dom/DataTransferItems.h:
- platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItem::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
- platform/chromium/DataTransferItemChromium.h:
- platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
- platform/chromium/DataTransferItemsChromium.h:
- 5:24 PM Changeset in webkit [84856] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION(75137): directly composited images are double-drawn sometimes
https://bugs.webkit.org/show_bug.cgi?id=58632
Depending on the order of operations (layout, creating compositing
layers and creating simple image layers) a layer can have both image
content and have m_drawsContent=true. In this case 2 copies of the image
are drawn in the layer. If the image has alpha, it looks wrong.
I added an updateDrawsContent() call after setting the image contents
to make sure it's correct.
I couldn't create a test case that shows the problem because layerTreeAsText()
doesn't emit enough info to show this level of detail. I've opened
https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
- 5:18 PM Changeset in webkit [84855] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400
Reviewed by James Robinson.
- wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
- 5:13 PM Changeset in webkit [84854] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in InlineFlowBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=59392
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::setLayoutOverflow): (WebCore::InlineFlowBox::setVisualOverflow):
- 5:11 PM Changeset in webkit [84853] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in TransformState.cpp
https://bugs.webkit.org/show_bug.cgi?id=59380
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- 5:07 PM Changeset in webkit [84852] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
DOMWindow.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59356
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessageTimerFired):
- page/DOMWindow.h:
- 5:06 PM Changeset in webkit [84851] by
-
- 6 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 5:04 PM Changeset in webkit [84850] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Re-land changes to ValidationMessage.
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 5:00 PM Changeset in webkit [84849] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Change FAILS_ to DISABLED_ in r84813.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 4:56 PM Changeset in webkit [84848] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Ojan Vafai <ojan@chromium.org>
Reviewed by James Robinson.
fix OwnPtr strict error in FrameView.cpp
https://bugs.webkit.org/show_bug.cgi?id=59402
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::addWidgetToUpdate):
- 4:55 PM Changeset in webkit [84847] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r84844.
http://trac.webkit.org/changeset/84844
https://bugs.webkit.org/show_bug.cgi?id=59395
Checked in too much.
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:54 PM Changeset in webkit [84846] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
JavaScriptCore should play nice strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59401
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
- heap/Heap.cpp: (JSC::TypeCounter::TypeCounter):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope):
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
- 4:52 PM Changeset in webkit [84845] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
Make ActiveDOMCallback play nice with OwnPtr strict mode
https://bugs.webkit.org/show_bug.cgi?id=59398
- bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMCallback::ActiveDOMCallback):
- 4:51 PM Changeset in webkit [84844] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:45 PM Changeset in webkit [84843] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r84835.
http://trac.webkit.org/changeset/84835
https://bugs.webkit.org/show_bug.cgi?id=59394
Breaks compile because Deque<OwnPtr> doesn't work
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:43 PM Changeset in webkit [84842] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Sam Weinig.
Fix OwnPtr strict mode violation in ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=59396
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
- 4:43 PM Changeset in webkit [84841] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378
Reviewed by Adam Roben.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.
- 4:41 PM Changeset in webkit [84840] by
-
- 5 edits1 copy in trunk/Tools
2011-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
https://bugs.webkit.org/show_bug.cgi?id=56090
Make LeaksViewer work with versions of browsers that don't support message
passing of cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: (LeaksParser.this._worker.onmessage): (LeaksParser): (LeaksParser.prototype.addLeaksFile): Use LeaksParserImpl directly if we don't support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js. (LeaksParserImpl): (LeaksParserImpl.prototype.addLeaksFile): (LeaksParserImpl.prototype._incorporateLeaks):
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: (onmessage): Factor out LeaksParser implementation into LeaksParserImpl.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: (workersSupportCyclicStructures): Add function to detect if workers support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Add LeaksParserImpl.js include.
- 4:41 PM Changeset in webkit [84839] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Convert a test to dump as text.
Reviewed by Sam Weinig.
- fast/dom/jsDevicePixelRatio-expected.txt: Added.
- fast/dom/jsDevicePixelRatio.html:
- platform/chromium-linux/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/mac-leopard/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- 4:39 PM Changeset in webkit [84838] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Huang Dongsung <luxtella@company100.net>
Reviewed by Dirk Schulze.
[Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
https://bugs.webkit.org/show_bug.cgi?id=59308
An unused local variable is created and even allocates heap memory.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- 4:37 PM Changeset in webkit [84837] by
-
- 3 edits in trunk/Source/WebCore
Qt build fix: Updated files not used by other ports for rename.
- bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):
- 4:36 PM Changeset in webkit [84836] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
WebCore/css/CSS* files should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59382
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::parseValue):
- 4:35 PM Changeset in webkit [84835] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:35 PM Changeset in webkit [84834] by
-
- 3 edits in trunk/LayoutTests
2011-04-25 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline and skip a couple of failing tests.
- platform/gtk/Skipped: skip http/tests/security/mixedContent/insecure-css-in-main-frame.html and editing/text-iterator/findString.html
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- 4:30 PM Changeset in webkit [84833] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strictness issues in WebCore/inspector/
https://bugs.webkit.org/show_bug.cgi?id=59387
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::ensureSourceData):
- 4:25 PM Changeset in webkit [84832] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381
Reviewed by Beth Dakin.
This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
- dom/Node.h: Hello fast code!
- xml/XPathNamespace.cpp: Removed.
- xml/XPathNamespace.h: Removed.
- 4:25 PM Changeset in webkit [84831] by
-
- 1 edit1 add8 deletes in trunk/LayoutTests
Move text-only results of a test that was switched to dump as text in r72166
alongside the test, and remove old expected pixel results.
- fast/dom/setPrimitiveValue-expected.txt: Added.
- platform/chromium-linux/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/chromium-win/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/gtk/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/mac-leopard/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.txt: Removed.
- 4:24 PM Changeset in webkit [84830] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HistoryItemMac should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59388
- history/mac/HistoryItemMac.mm: (WebCore::HistoryItem::setTransientProperty):
- 4:20 PM Changeset in webkit [84829] by
-
- 2 edits in trunk/Source/WebCore
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375
Reviewed by Kenneth Russell.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):
- 4:19 PM Changeset in webkit [84828] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
CheckedRadioButton should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59386
- dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::addButton):
- 4:17 PM Changeset in webkit [84827] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Resource*.cpp should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59383
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- 4:15 PM Changeset in webkit [84826] by
-
- 2 edits in trunk/Tools
2011-04-25 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
https://bugs.webkit.org/show_bug.cgi?id=59373
- Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
- 4:14 PM Changeset in webkit [84825] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- wtf/ListHashSet.h:
- 4:09 PM Changeset in webkit [84824] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>
Reviewed by Timothy Hatcher.
When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
and height.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.
- 4:09 PM Changeset in webkit [84823] by
-
- 2 edits1 move8 deletes in trunk/LayoutTests
Convert fast/events/label-focus.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=59364
Reviewed by Adam Roben.
- fast/events/label-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/events/label-focus-expected.txt.
- fast/events/label-focus.html:
- platform/chromium-linux/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.txt: Removed.
- platform/gtk/fast/events/label-focus-expected.png: Removed.
- platform/gtk/fast/events/label-focus-expected.txt: Removed.
- platform/mac-leopard/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.txt: Removed.
- platform/qt/fast/events/label-focus-expected.txt: Removed.
- 4:08 PM Changeset in webkit [84822] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59374
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::initGroup):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserScriptToWorld): (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/mac/PageMac.cpp: (WebCore::Page::addSchedulePair):
- 4:06 PM Changeset in webkit [84821] by
-
- 2 edits in trunk/Source/JavaScriptCore
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 4:02 PM Changeset in webkit [84820] by
-
- 2 edits in trunk/Source/WebCore
Build fix: This time for sure!
- dom/make_names.pl:
- 3:58 PM Changeset in webkit [84819] by
-
- 2 edits in trunk/Source/WebCore
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.
- dom/make_names.pl:
- 3:57 PM Changeset in webkit [84818] by
-
- 2 edits1 add6 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Sam Weinig.
- fast/css/affected-by-hover-after-style-change.html:
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84817] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362
- fast/events/onloadFrameCrash-expected.txt: Added.
- fast/events/onloadFrameCrash.html: Modified to dump as text.
- platform/gtk/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/gtk/fast/events/onloadFrameCrash-expected.txt: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84816] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=59368
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
- 3:54 PM Changeset in webkit [84815] by
-
- 10 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix strict OwnPtr violations in Render*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59361
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
- rendering/RenderBox.cpp: (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
- rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::ensureBacking):
- rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
- rendering/RenderView.cpp: (WebCore::RenderView::compositor):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::addCachedPseudoStyle): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/SVGResources.cpp: (WebCore::SVGResources::SVGResources):
- 3:48 PM Changeset in webkit [84814] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Attempt to fix the compile.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::loadWithNextMediaEngine):
- 3:47 PM Changeset in webkit [84813] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by James Robinson.
Suppress test failure in Chromium webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=59358
Looks like this started failing after
http://trac.webkit.org/changeset/84631.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 3:47 PM Changeset in webkit [84812] by
-
- 18 edits in trunk/Source/WebCore
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.
Rubber-stamped by Beth Dakin.
- bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
- 3:45 PM Changeset in webkit [84811] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
HTMLDocumentParser should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59363
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
- 3:41 PM Changeset in webkit [84810] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Frame.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59360
- page/Frame.cpp: (WebCore::createRegExpForLabels):
- 3:39 PM Changeset in webkit [84809] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Adam Roben.
- fast/css/zoom-property-parsing-expected.txt: Added.
- fast/css/zoom-property-parsing.html:
- platform/chromium-linux/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/mac-leopard/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.txt: Removed.
- 3:38 PM Changeset in webkit [84808] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr in Element.cpp
https://bugs.webkit.org/show_bug.cgi?id=59357
- dom/NodeRareData.h: (WebCore::NodeRareData::ensureEventTargetData):
- 3:32 PM Changeset in webkit [84807] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Missed the Chromium Mac baseline in the previous change.
- platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 3:28 PM Changeset in webkit [84806] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr issues in Media*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59354
There's still a tricky case in MediaPlayer.cpp, but we'll worry about
that later.
- css/MediaQueryMatcher.cpp: (WebCore::MediaQueryMatcher::addListener):
- dom/Document.cpp:
- platform/graphics/MediaPlayer.cpp: (WebCore::createNullMediaPlayer):
- 3:22 PM Changeset in webkit [84805] by
-
- 4 edits in trunk/Source
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- wtf/ListHashSet.h: (WTF::::ListHashSet):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor):
- 2:48 PM Changeset in webkit [84804] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347
Reviewed by Adam Barth.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 2:48 PM Changeset in webkit [84803] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 2:48 PM Changeset in webkit [84802] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Worker*.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59346
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::createResourceRequest):
- 2:31 PM April 2011 Meeting/WebKit2 created by
- 2:30 PM April 2011 Meeting edited by
- (diff)
- 2:21 PM Changeset in webkit [84801] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Remove bad use of OwnPtr::set() in IconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=59344
Needed for strict OwnPtr compliance.
- loader/icon/IconDatabase.cpp: (WebCore::readySQLiteStatement):
- 2:21 PM Changeset in webkit [84800] by
-
- 11 edits in trunk/Source/JavaScriptCore
2011-04-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make ClassInfo required when creating a Structure
https://bugs.webkit.org/show_bug.cgi?id=59340
Add ClassInfo to all those types which currently don't
have it, and add an assertion to Structure::create to
ensure that the provided classInfo is not null.
- runtime/Executable.h: (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
- runtime/GetterSetter.cpp:
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSString.cpp:
- runtime/JSString.h: (JSC::RopeBuilder::createStructure):
- runtime/Structure.h: (JSC::Structure::create): (JSC::JSCell::createDummyStructure):
- 2:16 PM Changeset in webkit [84799] by
-
- 2 edits in trunk/Source/JavaScriptCore
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342
Reviewed by Adam Barth.
This patch is to prepare for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):
- 1:57 PM Changeset in webkit [84798] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
ImageBuffer.h should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59341
This patch is to prepare for the strict OwnPtr hack-a-thon.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):
- 1:50 PM Changeset in webkit [84797] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
WebCore build on Windows should include windows.h in its precompiled header to speed builds
https://bugs.webkit.org/show_bug.cgi?id=59339
windows.h is included by several of the underlying wtf headers, including Atomics.h and
ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
(a 12% speedup).
- WebCorePrefix.h: Include windows.h
- 1:19 PM Changeset in webkit [84796] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950
split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
and apply related changes (only for SH4 platforms).
- assembler/MacroAssemblerSH4.cpp:
- assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::compare32): (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerSH4::branchDouble): (JSC::MacroAssemblerSH4::branch32): (JSC::MacroAssemblerSH4::branchTest8): (JSC::MacroAssemblerSH4::branch8): (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32): (JSC::MacroAssemblerSH4::test8): (JSC::MacroAssemblerSH4::branch16): (JSC::MacroAssemblerSH4::branchTest32): (JSC::MacroAssemblerSH4::branchAdd32): (JSC::MacroAssemblerSH4::branchMul32): (JSC::MacroAssemblerSH4::branchSub32): (JSC::MacroAssemblerSH4::branchOr32): (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32): (JSC::MacroAssemblerSH4::branchPtrWithPatch): (JSC::MacroAssemblerSH4::SH4Condition):
- assembler/SH4Assembler.h: (JSC::SH4Assembler::cmpEqImmR0):
- 1:16 PM Changeset in webkit [84795] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PropertyMapHashTable should work with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59337
This patch is in preparation for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::addDeletedOffset):
- 1:04 PM Changeset in webkit [84794] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebCore
Merging r84793
- 1:00 PM Changeset in webkit [84793] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
https://bugs.webkit.org/show_bug.cgi?id=59311
- platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar disconnect any lingering signal handlers. This prevents an adjustment from controlling the active ScrollView and some zombie ScrollView.
- 12:34 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:23 PM Changeset in webkit [84792] by
-
- 2 edits in trunk/Source/JavaScriptCore
Nixed MarkStack::deprecatedAppend, since it has no clients left.
Reviewed by Sam Weinig.
- heap/MarkStack.h:
- 12:23 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:21 PM Changeset in webkit [84791] by
-
- 3 edits in trunk/Source/WebCore
Another shot at fixing the EFL build.
- UseJSC.cmake:
- bindings/js/JSDOMBinding.cpp:
- 12:14 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:13 PM Changeset in webkit [84790] by
-
- 2 edits in trunk/Source/WebCore
Try to fix EFL build.
- UseJSC.cmake: Added a missing file.
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:02 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:01 PM QtWebKitFeatures21 edited by
- (diff)
- 11:56 AM Changeset in webkit [84789] by
-
- 27 edits in trunk/Source/WebCore
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=59333
- WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
- bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject lifetime management.
- dom/Document.idl: No need for a custom mark function anymore, since ActiveDOMObjets now manage their own lifetimes.
- dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity): Correctly report that we have pending activity when we're remotely entangled, instead of relying on our clients to know this about us and do the check for us.
- dom/MessagePort.h: FIXME!
- dom/MessagePort.idl:
- fileapi/DOMFileSystem.idl:
- fileapi/FileReader.idl:
- fileapi/FileWriter.idl:
- notifications/Notification.idl:
- notifications/NotificationCenter.idl:
- page/EventSource.idl:
- storage/IDBDatabase.idl:
- storage/IDBRequest.idl:
- storage/IDBTransaction.idl:
- webaudio/AudioContext.idl:
- websockets/WebSocket.idl:
- workers/AbstractWorker.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): No need to make up for MessagePort::hasPendingActivity being wrong anymore, since it's now right.
- xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
- 11:55 AM detect a RenderObject is destroyed unsafely created by
- 11:48 AM April 2011 Meeting edited by
- (diff)
- 11:47 AM April 2011 Meeting edited by
- (diff)
- 11:33 AM April 2011 Meeting Hardware Acceleration Track created by
- 11:32 AM April 2011 Meeting/Getting compile time under control created by
- 11:31 AM April 2011 Meeting edited by
- (diff)
- 11:24 AM QtWebKitFeatures21 edited by
- (diff)
- 11:15 AM Changeset in webkit [84788] by
-
- 2 edits2 copies in branches/chromium/742
Merge 84755 - 2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 * fast/table/auto-100-percent-width.html: Added. * platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 Test: fast/table/auto-100-percent-width.html * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
TBR=commit-queue@webkit.org
- 11:02 AM Changeset in webkit [84787] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2]fast/dom/shadow/gc-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=59335
- platform/qt-wk2/Skipped: Add fast/dom/shadow/gc-shadow.html.
- 10:47 AM Changeset in webkit [84786] by
-
- 2 edits in trunk/LayoutTests
[Qt] New tests introduced in r84742 fail
https://bugs.webkit.org/show_bug.cgi?id=59334
- platform/qt/Skipped:
- 10:41 AM Changeset in webkit [84785] by
-
- 15 edits in trunk/Source/WebKit2
Windows part of - WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>
Reviewed by Adam Roben.
Implement attaching and detaching of the Web Inspector on Windows,
and also support setAttachedWindowHeight when the user changes the height
of the docked inspector.
This patch doesn't remember whether the user prefers attached or detached, and
doesn't remember the user's preferred docked height, but that will be a separate
bug.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code.
(WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose
calls detach if the inspector was docked, and detach needs to know whether or not the window is
visible.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Add new messages.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageClient): Add a getter for the page client.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected
web view to the WebInspectorProxy.
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well
with the docked inspector.
(WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying.
(WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent
window, so the inspected web view and the inspector are siblings.
(WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach.
(WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend
from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the
inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is
something WebCore should handle.
(WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty.
This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message
from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attach): Send a message to the UIProcess.
(WebKit::WebInspector::detach): Ditto.
(WebKit::WebInspector::setAttachedWindowHeight): Ditto.
- WebProcess/WebPage/WebInspector.h: Remove some dead code.
- 10:37 AM April 2011 Meeting edited by
- (diff)
- 10:24 AM Changeset in webkit [84784] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; add failing test to mac-wk2/Skipped list.
- platform/mac-wk2/Skipped:
- 10:19 AM Changeset in webkit [84783] by
-
- 1 edit5 adds in trunk/LayoutTests
[Snow Leopard Intel WebKit2 Release Tests] editing/undo/undo-iframe-location-change.html and
compositing/iframes/invisible-nested-iframe-show.html failing since r84037.
https://bugs.webkit.org/show_bug.cgi?id=58990
Add failing expected results for SL WK2 to get the bots green.
These tests are already Skipped on Windows or have their own expected results.
- platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/mac-wk2/editing/undo/undo-iframe-location-change-expected.txt: Added.
- 10:18 AM Changeset in webkit [84782] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 10:10 AM Changeset in webkit [84781] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector: Support highlighting page elements
https://bugs.webkit.org/show_bug.cgi?id=59263
<rdar://problem/8767659>
Reviewed by Alice Liu.
Support highlighting of page elements for the inspector in WebKit2 by
having the WebInspectorClient be a PageOverlay Client and be responsible
for calling InspectorController::drawNodeHighlight.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created,
or call setNeedsDisplay if it has.
(WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists.
(WebKit::WebInspectorClient::pageOverlayDestroyed):
(WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null
WebPage), clear the member variable.
(WebKit::WebInspectorClient::didMoveToWebPage):
(WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight.
(WebKit::WebInspectorClient::mouseEvent):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable.
- 10:04 AM April 2011 Meeting edited by
- (diff)
- 10:00 AM April 2011 Meeting edited by
- (diff)
- 9:57 AM April 2011 Meeting edited by
- (diff)
- 9:47 AM Changeset in webkit [84780] by
-
- 6 edits1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: worker messages should be routed to corresponding worker front-end
https://bugs.webkit.org/show_bug.cgi?id=59323
Added WorkerManager which is responsible for routing messages between
Page inspector front-end and Worker inspector front-ends.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkerManager.js: Added. (WebInspector.WorkerManager): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded): (WebInspector.WorkerManager.loaded): (WebInspector.WorkerFrontendStub): (WebInspector.WorkerFrontendStub.prototype._receiveMessage): (WebInspector.WorkerDispatcher): (WebInspector.WorkerDispatcher.prototype._receiveMessage): (WebInspector.WorkerDispatcher.prototype.workerCreated): (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 9:45 AM April 2011 Meeting edited by
- Moar (diff)
- 9:45 AM Changeset in webkit [84779] by
-
- 2 edits in trunk/Tools
2011-04-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a few Chromium contributors to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 9:39 AM Changeset in webkit [84778] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] Should be easy to copy data.
https://bugs.webkit.org/show_bug.cgi?id=45662
Adds context menu items to copy resource location, resource request headers, and resource response headers.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
- 9:32 AM April 2011 Meeting edited by
- (diff)
- 9:24 AM April 2011 Meeting edited by
- (diff)
- 9:22 AM April 2011 Meeting edited by
- (diff)
- 9:20 AM April 2011 Meeting edited by
- (diff)
- 9:19 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:14 AM April 2011 Meeting edited by
- (diff)
- 9:06 AM April 2011 Meeting edited by
- (diff)
- 8:51 AM Changeset in webkit [84777] by
-
- 3 edits4 adds in trunk
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
- inspector/styles/parse-utf8-bom-expected.txt: Added.
- inspector/styles/parse-utf8-bom.html: Added.
- inspector/styles/resources/parse-utf8-bom-main.css: Added. (h1): (h2):
- inspector/styles/resources/parse-utf8-bom-reset.css: Added.
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
Use TextResourceDecoder to determine external stylesheet charsets correctly.
Test: inspector/styles/parse-utf8-bom.html
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::originalStyleSheetText):
- 8:13 AM Changeset in webkit [84776] by
-
- 2 edits in trunk/LayoutTests
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 7:38 AM April 2011 Meeting edited by
- (diff)
- 7:27 AM April 2011 Meeting edited by
- (diff)
- 7:18 AM Changeset in webkit [84775] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: Inspector.json cleanup.
- inspector/Inspector.json:
- 7:12 AM Changeset in webkit [84774] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: move Frame and Resource Tree management into the Page agent.
https://bugs.webkit.org/show_bug.cgi?id=59321
- inspector/report-protocol-errors.html:
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 7:01 AM April 2011 Meeting edited by
- (diff)
- 6:27 AM Changeset in webkit [84773] by
-
- 19 edits2 copies1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 4:25 AM Changeset in webkit [84772] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- Page domain is documented
- setUserAgentOverride is moved to the Network agent
- setSearchingForNode -> setInspectModeEnabled
- highlightDOMNode -> highlightNode
- reloadPage -> reload
- openInNewWindow -> open with optional parameter
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setInspectModeEnabled): (WebCore::InspectorDOMAgent::highlightNode):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideNodeHighlight):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::clearFrontend): (WebCore::InspectorPageAgent::reload): (WebCore::InspectorPageAgent::open):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
- inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.openResource): (WebInspector.documentKeyDown):
- 4:18 AM Changeset in webkit [84771] by
-
- 11 edits1 delete in trunk/Source/WebKit/efl
2011-04-25 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Remove ewk_eapi.h
https://bugs.webkit.org/show_bug.cgi?id=59091
- ewk/EWebKit.h:
- ewk/ewk_contextmenu.h:
- ewk/ewk_cookies.h:
- ewk/ewk_eapi.h: Removed.
- ewk/ewk_frame.h:
- ewk/ewk_history.h:
- ewk/ewk_main.h:
- ewk/ewk_settings.h:
- ewk/ewk_tiled_matrix.h:
- ewk/ewk_tiled_model.h:
- ewk/ewk_window_features.h:
- 2:59 AM Changeset in webkit [84770] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Fix tests after URL parsing fix
https://bugs.webkit.org/show_bug.cgi?id=59317
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Update expectations.
- fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Update expectations.
- fast/loader/url-parse-1-expected.txt: Update expectations.
- http/tests/loading/cross-origin-XHR-willLoadRequest.html: Replace single slash in an http: URL with a double slash - the single slash seemed to be erroneous.
- 1:26 AM Changeset in webkit [84769] by
-
- 16 edits in trunk/Source
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
Switch the scrollbar's overlay style depending on its frame's background color.
This refactors the getDocumentBackgroundColor method needed for gestures. The style
is determined and set on every paint() call to the Mac scrollbar theme.
- WebCore.exp.in: adding method to allow changing style
- page/Frame.cpp: (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
- page/Frame.h:
- page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
- page/FrameView.h:
- platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
- platform/ScrollableArea.h: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color
- 12:29 AM April 2011 Meeting edited by
- (diff)
- 12:28 AM Changeset in webkit [84768] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Added Radar link
- 12:26 AM Changeset in webkit [84767] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315
Reviewed by Maciej Stachowiak.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize new member variables.
(WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
is scrolled a distance equal to the change in the mouse position.
(WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
the document rather than the thumb, and pass the result to moveThumb.
(WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
- platform/Scrollbar.h:
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
returns false.
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
Option key is down.
Apr 24, 2011:
- 11:47 PM April 2011 Meeting edited by
- (diff)
- 11:45 PM April 2011 Meeting edited by
- (diff)
- 11:22 PM Changeset in webkit [84766] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-04-24 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Add Chromium baselines for fast/table/auto-100-percent-width.html.
Mark fast/dom/HTMLMeterElement/meter-element.html and
http/tests/misc/will-send-request-returns-null-on-redirect.html
as failing - need triage.
- platform/chromium-mac/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium-win/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:02 PM April 2011 Meeting edited by
- (diff)
- 10:36 PM Changeset in webkit [84765] by
-
- 4 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html (again).
- platform/chromium-linux/fast/url/standard-url-expected.txt:
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 10:12 PM April 2011 Meeting edited by
- adding /me to interesting talkings (diff)
- 9:56 PM April 2011 Meeting edited by
- (diff)
- 9:55 PM April 2011 Meeting edited by
- (diff)
- 9:22 PM ThreadCommunication edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:06 PM April 2011 Meeting edited by
- (diff)
- 8:49 PM April 2011 Meeting edited by
- (diff)
- 8:43 PM April 2011 Meeting edited by
- (diff)
- 7:43 PM April 2011 Meeting edited by
- (diff)
- 5:47 PM Changeset in webkit [84764] by
-
- 80 edits in trunk/Source/WebCore
2011-04-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
https://bugs.webkit.org/show_bug.cgi?id=59307
- WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSDOMBinding.h: (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because they're reasonably generic.
- bindings/js/JSDOMImplementationCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSDOMTokenListCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper. This is one of the few cases where a DOM object is considered a stand-alone root. It's not as efficient as the shared root case, but workers and message ports are very rare objects, so it's no big deal.
- bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
- bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
- bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, a stand-alone root.
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots system for marking WebGL contexts and their associated satellite objects.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, stand-alone roots.
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner XHR because it is not reachable from us.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/MediaList.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/MessagePort.idl:
- dom/NamedNodeMap.idl:
- fileapi/Blob.idl:
- html/DOMTokenList.idl: Opt in to autogeneration.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
- html/HTMLCollection.idl:
- html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::ref): (WebCore::CanvasRenderingContext::deref):
- html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::create): (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
Inlined some functions to match our standard idiom and to make the code
in the header document itself.
- html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
- html/canvas/OESStandardDerivatives.cpp: (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::create):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.cpp: (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::create):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESVertexArrayObject.cpp: (WebCore::OESVertexArrayObject::OESVertexArrayObject): (WebCore::OESVertexArrayObject::create):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLExtension.cpp: (WebCore::WebGLExtension::WebGLExtension):
- html/canvas/WebGLExtension.h: (WebCore::WebGLExtension::ref): (WebCore::WebGLExtension::deref): (WebCore::WebGLExtension::context):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::~WebGLRenderingContext): (WebCore::WebGLRenderingContext::getExtension):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
- html/canvas/WebKitLoseContext.h:
- html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL canavs rendering contexts to match the model for 2D canvas rendering contexts. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable. (Previously, satellite objects would magically stop working when the last reference to their owner object was dropped. Now, satellite objects keep their owner alive through reference counting.)
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- page/WorkerNavigator.idl:
- plugins/DOMMimeTypeArray.h: (WebCore::DOMMimeTypeArray::frame):
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPluginArray.h: (WebCore::DOMPluginArray::frame):
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- workers/WorkerLocation.idl: Opt in to autogeneration.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
- xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::ref): (WebCore::XMLHttpRequestUpload::deref): (WebCore::XMLHttpRequestUpload::xmlHttpRequest): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
- xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and its associated upload object to match the model for canvas. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable.
- 5:38 PM April 2011 Meeting edited by
- Make the title of RenderObject guard more descriptive (diff)
- 4:39 PM April 2011 Meeting edited by
- (diff)
- 4:13 PM April 2011 Meeting edited by
- (diff)
- 4:09 PM Changeset in webkit [84763] by
-
- 3 edits2 deletes in trunk
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- fast/dom/shadow/append-child-text-expected.txt: Removed.
- fast/dom/shadow/append-child-text.html: Removed.
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- dom/Node.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer):
- 3:53 PM Changeset in webkit [84762] by
-
- 9 edits in trunk
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
URLs like http:/example.com/ or http:example.com/ are now correctly
canonicalized as http://example.com/
The code still doesn't quite match other browsers - at least some
other browsers seem to base parsing behavior on whether they
recongize a scheme from a fixed list, and ignore whether is
present in the URL or not.
- platform/KURL.cpp: (WebCore::isNonFileHierarchicalScheme): New helper function. (WebCore::KURL::parse): For a particular list of whitelisted schemes, assume they are hierarchical and need an authority even if there is no after the :/
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
Added some new test cases. Also updated results for the
change. The changes are progressions.
- fast/url/relative-expected.txt:
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/standard-url-expected.txt:
- 2:48 PM Changeset in webkit [84761] by
-
- 3 edits1 add in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html
- platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 2:37 PM Changeset in webkit [84760] by
-
- 2 edits in trunk/Source/WebCore
LLVM Compiler build fix.
- page/ContentSecurityPolicy.cpp: Removed an unused function.
- 2:20 PM Changeset in webkit [84759] by
-
- 3 edits2 adds in trunk
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
- fast/dom/shadow/append-child-text-expected.txt: Added.
- fast/dom/shadow/append-child-text.html: Added.
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
Text nodes need to consult their host element for style.
Test: fast/dom/shadow/append-child-text.html
- dom/Node.cpp: (WebCore::NodeRendererFactory::styleForRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
- 11:38 AM Component Model edited by
- (diff)
- 11:38 AM Component Model edited by
- (diff)
- 11:37 AM Component Model edited by
- (diff)
- 11:36 AM Changeset in webkit [84758] by
-
- 15 edits in trunk
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Update tests to use the new syntax.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html:
- http/tests/security/contentSecurityPolicy/image-allowed.html:
- http/tests/security/contentSecurityPolicy/image-blocked.html:
- http/tests/security/contentSecurityPolicy/inline-script-allowed.html:
- http/tests/security/contentSecurityPolicy/style-allowed.html:
- http/tests/security/contentSecurityPolicy/style-blocked.html:
- http/tests/security/contentSecurityPolicy/xsl-allowed.php:
- http/tests/security/contentSecurityPolicy/xsl-blocked.php:
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Brandon removed disable-xss-protection in favor of unsafe-inline and
allow-eval in favor of unsafe-eval. This change in syntax also means
the options directive no longer exists.
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSourceList::allowInline): (WebCore::CSPSourceList::allowEval): (WebCore::CSPSourceList::CSPSourceList): (WebCore::CSPSourceList::parseSource): (WebCore::CSPSourceList::addSourceUnsafeInline): (WebCore::CSPSourceList::addSourceUnsafeEval): (WebCore::CSPDirective::allowInline): (WebCore::CSPDirective::allowEval): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 11:29 AM Changeset in webkit [84757] by
-
- 3 edits1 add in trunk/Source
../WebCore: Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- manual-tests/back-from-document-with-scrollbar.html: Added.
../WebKit2: <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndWindow): Null-check the document.
(WebKit::WebChromeClient::invalidateContentsForSlowScroll): Ditto.
- 10:50 AM April 2011 Meeting edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:23 AM Component Model edited by
- (diff)
- 9:02 AM Component Model created by
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:40 AM April 2011 Meeting edited by
- (diff)
- 2:23 AM April 2011 Meeting edited by
- (diff)
- 2:14 AM Changeset in webkit [84756] by
-
- 5 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Test canonicalization of scheme:/host
https://bugs.webkit.org/show_bug.cgi?id=59296
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/standard-url-expected.txt:
- 1:17 AM Changeset in webkit [84755] by
-
- 3 edits2 adds in trunk
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
- fast/table/auto-100-percent-width.html: Added.
- platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
Test: fast/table/auto-100-percent-width.html
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
Apr 23, 2011:
- 11:22 PM Changeset in webkit [84754] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build change.
Activate Geolocation API, as it will work with WinCairo assuming
an appropriate Geolocation Provider is registered.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: Activate the Geolocation features.
- 11:01 PM Changeset in webkit [84753] by
-
- 2 edits in trunk/Source/WebCore
2011-04-23 Simon Fraser <Simon Fraser>
Fix Windows build, which complains about unreachable code.
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner):
- 10:53 PM Changeset in webkit [84752] by
-
- 5 edits in trunk/Source/WebCore
2011-04-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Area under composited scrollbars not repainted in WebKit2 on scrolling
https://bugs.webkit.org/show_bug.cgi?id=59294
<rdar://problem/9299062>
When computing the rect that can be copied on scrolling, we normally
exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
the assumption is that other code will repaint these areas. However, when
scrollbars are in their own compositing layers, we can, and should
copy the entire area.
Not testable in DRT because it does not allow tests to use overlay scrollbars.
- platform/ScrollView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::rectToCopyOnScroll): New method, with code moved from scrollContents and fixed to look for scrollbars in layers. (WebCore::ScrollView::scrollContents): Call rectToCopyOnScroll().
- platform/ScrollableArea.h:
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner): Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
- 8:59 PM Changeset in webkit [84751] by
-
- 13 edits in trunk/Source
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebCore.exp.in:
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollTypes.h:
- platform/ScrollableArea.h:
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
- 8:56 PM Changeset in webkit [84750] by
-
- 5 edits in trunk
<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
https://bugs.webkit.org/show_bug.cgi?id=59288
Reviewed by Simon Fraser.
Source/WebCore:
- platform/text/mac/TextBoundaries.mm:
(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.
LayoutTests:
- editing/text-iterator/findString-expected.txt:
- editing/text-iterator/findString.html:
- 7:24 PM April 2011 Meeting edited by
- (diff)
- 7:12 PM April 2011 Meeting edited by
- (diff)
- 7:10 PM April 2011 Meeting edited by
- (diff)
- 7:08 PM April 2011 Meeting edited by
- (diff)
- 7:07 PM April 2011 Meeting edited by
- (diff)
- 6:31 PM Changeset in webkit [84749] by
-
- 5 edits2 adds in trunk
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
- fast/dom/shadow/gc-shadow-expected.txt: Added.
- fast/dom/shadow/gc-shadow.html: Added.
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
Test: fast/dom/shadow/gc-shadow.html
- bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): group shadow nodes with their hosts
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
Chromium DRT over-refcounted the NPObject wrappers it used to
marshal shadowRoot nodes back to tests (WebBindings::makeNode
births NPObjects with referenceCount == 1). This masked the GC bug
59284 in tests by making shadowRoot nodes live forever.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::shadowRoot): (LayoutTestController::ensureShadowRoot):
- 6:05 PM Changeset in webkit [84748] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:
Reviewed by Oliver Hunt.
SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
- 5:51 PM Changeset in webkit [84747] by
-
- 4 edits in trunk/Source/WebCore
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] NodeRenderParentDetector should be NodeRenderFactory
https://bugs.webkit.org/show_bug.cgi?id=59280
- Rename NodeRenderParentDetector to NodeRendererFactory
- move createRendererAndStyle() and createRendererIfNeeded to NodeRendererFactory
No new test, no behavioral change.
- dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::document): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::findVisualParent): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::NodeRendererFactory::createRendererIfNeeded): (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::createRendererIfNeeded):
- dom/Node.h:
- html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()
- 5:17 PM Changeset in webkit [84746] by
-
- 2 edits in trunk/LayoutTests
2011-04-23 MORITA Hajime <morrita@google.com>
Unreviewed test_expectations.txt update.
r84745 didn't fix meter-element.html break on chromium.
- platform/chromium/test_expectations.txt:
- 4:16 PM Changeset in webkit [84745] by
-
- 4 edits6 adds in trunk
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
https://bugs.webkit.org/show_bug.cgi?id=59281
- fast/dom/HTMLMeterElement/meter-writing-mode.html: Added.
- fast/dom/HTMLProgressElement/progress-writing-mode.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
https://bugs.webkit.org/show_bug.cgi?id=59281
Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
for vertical writing modes. This fix added a width property for each of them.
Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
- css/html.css: (meter::-webkit-meter-bar): (progress::-webkit-progress-bar):
- 1:16 PM Changeset in webkit [84744] by
-
- 8 edits in trunk/Source/JavaScriptCore
Bug 59266 - DFG JIT - Add SSA style DCE
Reviewed by Sam Weinig & Geoff Garen.
This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
- dfg/DFGNode.h:
(JSC::DFG::Node::ref):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:05 PM Changeset in webkit [84743] by
-
- 7 edits in trunk
[wx] Unreviewed build fixes for recent trunk changes.
- 12:14 PM Changeset in webkit [84742] by
-
- 10 edits in trunk
2011-04-23 Alexey Proskuryakov <ap@apple.com>
Unreviewed.
REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>
- http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Resource load delegates for cancelled loads are now correctly sent before frame load delegate's didFinishLoading, so cancellation errors get logged by DumpRenderTree.
2011-04-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>
Covered by manual-tests/print-after-window-close.html.
Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
regression.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be doing complicated work while the loader is half-canceled.
- manual-tests/print-after-window-close.html: Extended to actually print a non-empty page, thus being more practical.
- page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer. It's too scary for me to try now.
- page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::finishedLoading):
- page/DOMWindow.h: Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.
- 12:11 AM Changeset in webkit [84741] by
-
- 6 edits in trunk/Source/WebCore
2011-04-19 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Use implicit references for V8 listeners on DOM nodes.
https://bugs.webkit.org/show_bug.cgi?id=58953
Instead of allocating an auxiliary V8 array referencing V8
listener objects associated with a DOM node and using an extra
pointer in every DOM node wrapper, we can register implicit
references between nodes and their listeners during GC. This also
makes V8 bindings more aligned with JSC bindings.
No new tests because this is a refactoring.
- bindings/scripts/CodeGeneratorV8.pm: Stopped generating the listener cache internal field for DOM nodes.
- bindings/v8/V8AbstractEventListener.h: Exposed the lister handle to the GC. (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
- bindings/v8/V8GCController.cpp: Started using implicit references. (WebCore::GrouperVisitor::visitDOMWrapper):
- dom/EventTarget.h: Implemented an iterator over all listeners. (WebCore::EventListenerIterator):
Apr 22, 2011:
- 11:38 PM April 2011 Meeting edited by
- (diff)
- 11:22 PM Changeset in webkit [84740] by
-
- 13 edits in trunk/Source
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCore.exp.in: adding method to allow changing style
- page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
- page/FrameView.h:
- platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
- platform/ScrollableArea.h:
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
- 10:55 PM Changeset in webkit [84739] by
-
- 8 edits in trunk
2011-04-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
https://bugs.webkit.org/show_bug.cgi?id=59056
- http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-iframe.html: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-main-frame.html: Update expectation.
- http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Fix typo.
2011-04-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
https://bugs.webkit.org/show_bug.cgi?id=59056
Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
- 10:09 PM Changeset in webkit [84738] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect bug.
- platform/qt-wk2/Skipped:
- 9:44 PM Changeset in webkit [84737] by
-
- 2 edits in trunk/Source/WebCore
Fixed an upside-down conditional in my last check-in.
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::isObservable):
- 9:41 PM Changeset in webkit [84736] by
-
- 19 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
- bindings/js/JSNavigatorCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
- css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl: Updated to use the opaque roots system.
- 9:37 PM Changeset in webkit [84735] by
-
- 604 edits565 adds in trunk/LayoutTests
[Qt] Unskip a bunch of passing tests and update their expected files.
This patch based on work of Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
- platform/qt/Skipped:
- platform/qt/fast/[...]: Added, updated.
- platform/qt/scrollbars/[...]: Added, updated.
- 9:01 PM April 2011 Meeting edited by
- (diff)
- 8:41 PM Changeset in webkit [84734] by
-
- 7 edits4 deletes in trunk
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- Source/WebKit.pro:
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- QtWebKit.pro:
- symbian/platformplugin/WebPlugin.cpp: Removed.
- symbian/platformplugin/WebPlugin.h: Removed.
- symbian/platformplugin/platformplugin.pro: Removed.
- symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 8:23 PM April 2011 Meeting edited by
- (diff)
- 8:22 PM Changeset in webkit [84733] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - clean up some flakiness.
- platform/chromium/test_expectations.txt:
- 8:20 PM Changeset in webkit [84732] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113
- xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- 8:19 PM April 2011 Meeting edited by
- (diff)
- 8:17 PM Changeset in webkit [84731] by
-
- 18 edits in trunk/Source/WebCore
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84725 and r84728.
http://trac.webkit.org/changeset/84725
http://trac.webkit.org/changeset/84728
https://bugs.webkit.org/show_bug.cgi?id=59270
It broke http/tests/appcache tests (Requested by Ossy on
#webkit).
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
- css/StyleMedia.h:
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): (WebCore::DOMWindow::optionalSelection): (WebCore::DOMWindow::optionalHistory): (WebCore::DOMWindow::optionalCrypto): (WebCore::DOMWindow::optionalLocationbar): (WebCore::DOMWindow::optionalMenubar): (WebCore::DOMWindow::optionalPersonalbar): (WebCore::DOMWindow::optionalScrollbars): (WebCore::DOMWindow::optionalStatusbar): (WebCore::DOMWindow::optionalToolbar): (WebCore::DOMWindow::optionalConsole): (WebCore::DOMWindow::optionalNavigator): (WebCore::DOMWindow::optionalLocation): (WebCore::DOMWindow::optionalMedia): (WebCore::DOMWindow::optionalSessionStorage): (WebCore::DOMWindow::optionalLocalStorage): (WebCore::DOMWindow::optionalPerformance):
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.h: (WebCore::Navigator::optionalGeolocation):
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl:
- 8:17 PM Changeset in webkit [84730] by
-
- 6 edits in trunk/Tools
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
rebaseline-chromium-webkit-tests: clean up output
https://bugs.webkit.org/show_bug.cgi?id=59240
This change dramatically changes the output the tool provides
by default. The previous output (more or less) is still there
in -v / verbose / debug mode, but the default output is
way terser and more readable. It mostly says which files are
updated, which are duplicates, and which are not found in an
archive. Feedback desired :).
This change also adds a scm.exists() method to the SCM object
so that we can cleanly figure out what we're doing while
rebaselining.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/common/system/filesystem_mock.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 8:09 PM Changeset in webkit [84729] by
-
- 4 edits in trunk/Source/WebCore
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Change SVG-related shadow root checks to use isSVGShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59237
Covered by existing tests, no behavior change.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
- svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
- 7:50 PM April 2011 Meeting edited by
- Proposing a hw acceleration talk (diff)
- 7:48 PM April 2011 Meeting edited by
- (diff)
- 7:22 PM Changeset in webkit [84728] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix.
- page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.
- 7:19 PM Changeset in webkit [84727] by
-
- 2 edits in trunk/Tools
2011-04-22 Ilya Sherman <isherman@chromium.org>
Reviewed by Alexey Proskuryakov.
Add Ilya Sherman (isherman@chromium.org) to the list of contributors
https://bugs.webkit.org/show_bug.cgi?id=59231
- Scripts/webkitpy/common/config/committers.py:
- 7:16 PM Changeset in webkit [84726] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
don't white-space:nowrap the results iframes
https://bugs.webkit.org/show_bug.cgi?id=59259
- fast/harness/results.html:
- 7:09 PM Changeset in webkit [84725] by
-
- 18 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
- bindings/js/JSNavigatorCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
- css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl: Updated to use the opaque roots system.
- 7:05 PM Changeset in webkit [84724] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Roll in deps bots failures.
- platform/chromium/test_expectations.txt:
- 7:03 PM April 2011 Meeting edited by
- Adding myself to enrica's talk (diff)
- 7:03 PM Changeset in webkit [84723] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Stop responsiveness timer before calling runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,
because runOpenPanel can spin a nested run loop.
- 6:48 PM Changeset in webkit [84722] by
-
- 2 edits in trunk/Tools
2011-04-22 Yuta Kitamura <yutak@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: Exception raised when stderr contains binary data
https://bugs.webkit.org/show_bug.cgi?id=59083
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Use write_binary_file() instead of write_text_file().
- 6:35 PM April 2011 Meeting edited by
- (diff)
- 6:14 PM Changeset in webkit [84721] by
-
- 12 edits in trunk
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
Unskip passed tests.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetFrameFlatteningEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setFrameFlatteningEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setFrameFlatteningEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 6:09 PM Changeset in webkit [84720] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
[QT] move-by-word-visually.html failed in QT.
https://bugs.webkit.org/show_bug.cgi?id=59265
Temporarily skip the test in QT while investigating.
- platform/qt/Skipped:
- 6:03 PM Changeset in webkit [84719] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Alejandro G. Castro <alex@igalia.com>
Undo rebaseline done in r84677 for this test, it was a flaky
execution.
- platform/gtk/media/video-controls-rendering-expected.txt:
- 5:59 PM Changeset in webkit [84718] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-22 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Add missing default constructors for HashMap iterator specializations.
https://bugs.webkit.org/show_bug.cgi?id=59250
- wtf/HashIterators.h:
- wtf/HashTable.h: (WTF::HashTableConstIterator::HashTableConstIterator): Added cast to help compiler find the function template.
- 5:54 PM Changeset in webkit [84717] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 59262 - DFG JIT - reduce size of VariableRecord
Reviewed by Sam Weinig.
We never need both the get & set node, only the most recent
(which is always a set, if both exist).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
- 5:39 PM Changeset in webkit [84716] by
-
- 5 edits in trunk/Source
Versioning.
- 5:38 PM April 2011 Meeting edited by
- (diff)
- 5:37 PM Changeset in webkit [84715] by
-
- 3 edits in trunk/LayoutTests
Unreviewed: Updated bug ID for geolocation skipped cases
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- 5:37 PM April 2011 Meeting edited by
- (diff)
- 5:36 PM April 2011 Meeting edited by
- (diff)
- 5:34 PM Changeset in webkit [84714] by
-
- 6 edits in trunk
roll out incorrect versioning info (included extra file).
- 5:30 PM Changeset in webkit [84713] by
-
- 4 edits in trunk
2011-04-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=58976
- platform/gtk/Skipped: Unskip a test which is no longer crashing.
2011-04-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=58976
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement method of the document returns null.
- 5:25 PM Changeset in webkit [84712] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Alejandro G. Castro <alex@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the libWebCore.a convenience library when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59258
- GNUmakefile.am: Remove the libWebKit2 convenience library and use the libWebCore convenience library when compiling WebKit2. Not only does this maintain the CPPFLAGS isolation, it prevents double-compilation of WebCore in some cases.
- 5:23 PM Changeset in webkit [84711] by
-
- 6 edits in trunk
Versioning.
- 5:12 PM Changeset in webkit [84710] by
-
- 5 edits in trunk
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move caret by word in visual order returns wrong result when caret itself is at word boundary.
https://bugs.webkit.org/show_bug.cgi?id=58504.
Add test case to test moving left/right by word visually on every character position.
Remove a specific test added before for testing a specific code path since the test case
is covered now.
- editing/selection/move-by-word-visually-expected.txt:
- editing/selection/move-by-word-visually.html:
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move caret by word in visual order returns wrong result when caret itself is at word boundary.
https://bugs.webkit.org/show_bug.cgi?id=58504.
positionBeforeNextWord should take care that the current position is after current word.
positionAfterPreviousWord should take care that the current positin is before current word.
- editing/visible_units.cpp: (WebCore::positionBeforeNextWord): (WebCore::positionAfterPreviousWord):
- 5:08 PM Changeset in webkit [84709] by
-
- 1 edit10 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebaseline after r84655.
- platform/chromium-linux/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- 4:59 PM Changeset in webkit [84708] by
-
- 7 edits4 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebase after r84659.
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png:
- platform/chromium-mac-leopard/editing/deleting/table-cells-expected.png:
- platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
- platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
- 4:54 PM Changeset in webkit [84707] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
Flaky Test: media/invalid-media-url-crash.html
https://bugs.webkit.org/show_bug.cgi?id=51138
Add one more test to the list of known crashers from rdar://9054715.
- platform/mac-snowleopard/Skipped:
- 4:52 PM Changeset in webkit [84706] by
-
- 18 edits5 adds in trunk
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
- fullscreen/full-screen-frameset-expected.txt: Added.
- fullscreen/full-screen-frameset.html: Added.
- fullscreen/content/inner.html: Added.
- fullscreen/full-screen-iframe-allowed-expected.txt: Updated.
- fullscreen/full-screen-iframe-allowed.html: Add a button with which to trigger
full screen mode in Safari.
- fullscreen/full-screen-iframe-not-allowed-expected.txt: Updated.
- fullscreen/full-screen-iframe-not-allowed.html: Ditto.
- fullscreen/resources/allowed.html: Added.
- fullscreen/resources/inner.html: Added.
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
-webkit-full-screen pseudo class to frame elements which contain
full screen elements.
- css/fullscreen.css: (iframe:-webkit-full-screen): Add iframe-specific styling rules.
- dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each
successive document owner element, calling setContainsFullScreenElement() if
owner is a frame element.
(WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
call instead of checking the element's tag name.
(WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
iframes as containing a full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
- dom/Element.h: (WebCore::Element::isFrameElementBase): Added.
- html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
HTMLFrameElements.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
- html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added. (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset-allowed.html
fullscreen/full-screen-frameset-not-allowed.html
Return the _element's document instead of the WKView's document, which
will be different in the case of elements within <iframe>s.
- WebView/WebFullScreenController.mm: (-[WebFullScreenController _document]):
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset-allowed.html
fullscreen/full-screen-frameset-not-allowed.html
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation
if the full screen animation finishes first.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.
- 4:38 PM Changeset in webkit [84705] by
-
- 7 edits in trunk/Source/JavaScriptCore
Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE. Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.
Reviewed by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
- 4:35 PM Changeset in webkit [84704] by
-
- 4 edits in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CommitQueue should remember the expected failures from patch to patch
https://bugs.webkit.org/show_bug.cgi?id=59253
Previously, we stored the set of expected failures on the task object,
which meant the commit-queue forgot about them after each patch. This
patch moves them to the CommitQueue object so they will have a longer
lifetime.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 4:34 PM Changeset in webkit [84703] by
-
- 1 copy in tags/Safari-534.31
New tag.
- 4:29 PM Changeset in webkit [84702] by
-
- 13 edits in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
WebKit2: Implement JavaScript unresponsiveness timer/callbacks
https://bugs.webkit.org/show_bug.cgi?id=59248
Stub out shouldInterruptJavaScript callbacks.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize):
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
WebKit2: Implement JavaScript unresponsiveness callback
https://bugs.webkit.org/show_bug.cgi?id=59248
Add support for suspending JavaScript in response to a callback.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::shouldInterruptJavaScript):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInterruptJavaScript):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldInterruptJavaScript):
- 4:11 PM Changeset in webkit [84701] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
Creating copy of ContainerNode's when inserting or removing is inefficient
https://bugs.webkit.org/show_bug.cgi?id=58695
Eliminated node copying in willRemove() and insertedIntoDocument().
No new tests as this is a more efficient implementation of
existing code that is covered by existing tests.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove): Changed method to use RefPtr<> to protect against modification during removal. (WebCore::ContainerNode::insertedIntoDocument): Changed method to use RefPtr<> and two other deletion checks to protect against modification during insertion.
- 4:09 PM Changeset in webkit [84700] by
-
- 2 edits in trunk/Source/JavaScriptCore
Errk, build fix.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:04 PM Changeset in webkit [84699] by
-
- 32 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
We have an autogenerator, so use it
https://bugs.webkit.org/show_bug.cgi?id=59247
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSRuleListCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCSSValueCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMImplementationCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp:
- bindings/js/JSNodeCustom.h:
- bindings/js/JSNodeListCustom.cpp:
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
- bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- html/DOMTokenList.idl:
- html/HTMLCollection.idl:
- html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into the autogenerator.
- 4:01 PM Changeset in webkit [84698] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to achieve this actually works.
- 3:59 PM April 2011 Meeting edited by
- (diff)
- 3:47 PM Changeset in webkit [84697] by
-
- 3 edits in trunk/Tools
2011-04-22 Daniel Bates <dbates@webkit.org>
Reviewed by Csaba Osztrogonác.
webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500
Make has_authorization_for_realm() return True only if there exists a credentials file
that contains either the word "password" or "passtype". We assume that these words don't
coincide with the actual credential data (e.g. a person's username is "password").
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Added test cases: test_has_authorization_for_realm_using_credentials_with_passtype(), test_has_authorization_for_realm_using_credentials_with_password(), test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
- Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file() to better describe what it's testing.
- Repurposed test_has_authorization_for_realm() to take realm and credential data to use and return the result of calling has_authorization_for_realm() so that the caller can assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to better reflect its new purpose.
- 3:45 PM Changeset in webkit [84696] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebaseline after r84659.
- platform/mac-wk2/fast/forms: Added.
- platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- 3:44 PM Changeset in webkit [84695] by
-
- 13 edits in trunk/Source/WebCore
2011-04-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kent Tamura.
Let the RenderTheme decide if an input type should have a spinner
https://bugs.webkit.org/show_bug.cgi?id=59246
Whether an input should have a spinner or not should
be a UI decision made by the RenderTheme. Remove
WebCore's default hasSpinButton values and defer
to the RenderTheme.
No change in functionality, covered by existing tests.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl for possible RenderTheme queries.
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): For both of these ask the render theme if the input should have a spinner.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement): Steppable inputs (number, date, and range) but not range should have spinners. This does not change existing behavior.
- rendering/RenderTheme.h:
- dom/InputElement.h:
- html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
- html/BaseDateAndTimeInputType.h: remove hasSpinButton.
- html/InputType.cpp: remove hasSpinButton.
- html/InputType.h: remove hasSpinButton.
- html/NumberInputType.cpp: remove hasSpinButton.
- html/NumberInputType.h: remove hasSpinButton.
- 3:42 PM Changeset in webkit [84694] by
-
- 1 edit3 adds in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
Reviewed by Maciej Stachowiak.
Manual test added.
- manual-tests/frame-layout-on-back.html: Added.
- manual-tests/resources/empty-document-goes-back.html: Added.
- manual-tests/resources/simple-iframe.html: Added.
- 3:36 PM Changeset in webkit [84693] by
-
- 6 edits2 adds in trunk
2011-04-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Sam Weinig.
HTMLFormControlElement::labels should allow custom attributes.
https://bugs.webkit.org/show_bug.cgi?id=59128
- fast/forms/labels-custom-property-expected.txt: Added.
- fast/forms/labels-custom-property.html: Added.
2011-04-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Sam Weinig.
HTMLFormControlElement::labels should allow custom attributes.
https://bugs.webkit.org/show_bug.cgi?id=59128
Cache the labels list when it is created and keep using it for future
labels calls.
Test: fast/forms/labels-custom-property.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
- 3:34 PM Changeset in webkit [84692] by
-
- 2 edits in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Remove double-negative. (Sorry this was bugging me.)
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- 3:27 PM Changeset in webkit [84691] by
-
- 4 edits in trunk/Source/JavaScriptCore
Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().
Reviewed by Sam Weinig.
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- 3:21 PM Changeset in webkit [84690] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Remove minimum texture size for compositor tiling
https://bugs.webkit.org/show_bug.cgi?id=59236
This was mistakenly committed in r83915 and causes bad filtering
on very small textures.
Tests: compositing/images/content-image-change.html
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize):
- 3:20 PM April 2011 Meeting edited by
- (diff)
- 3:19 PM April 2011 Meeting edited by
- (diff)
- 3:18 PM April 2011 Meeting edited by
- (diff)
- 3:17 PM Changeset in webkit [84689] by
-
- 3 edits2 adds in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor LayoutTestResultsReader out of CommitQueue
https://bugs.webkit.org/show_bug.cgi?id=59244
This code will be shared with the EWS when they start running tests.
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:14 PM April 2011 Meeting edited by
- Add back changes that I inadvertently stepped on. (diff)
- 3:13 PM April 2011 Meeting edited by
- (diff)
- 3:10 PM Changeset in webkit [84688] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>
Reviewed by Maciej Stachowiak.
Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
- page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
- 3:09 PM April 2011 Meeting edited by
- Adding myself to line-layout talk. (diff)
- 3:07 PM April 2011 Meeting edited by
- (diff)
- 3:01 PM Changeset in webkit [84687] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Provide default constructors for HashMap iterators.
https://bugs.webkit.org/show_bug.cgi?id=59151
These will be used to implement an iterator over EventTarget's
listeners.
- wtf/HashTable.h: (WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter): (WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):
- 2:56 PM Changeset in webkit [84686] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=58977
r84604 fixed the bug, so we can unskip it.
- platform/qt/Skipped: Unskip platform/qt/fast/history/back-to-unreachable-url-then-forward.html.
- 2:37 PM Changeset in webkit [84685] by
-
- 3 edits4 deletes in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Updated Chromium expectations after WK r84606
- platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-mac/fast/url/host-expected.txt: Removed.
- platform/chromium-mac/fast/url/path-expected.txt: Removed.
- platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-win/fast/url/host-expected.txt: Removed.
- platform/chromium-win/fast/url/path-expected.txt: Removed.
- 2:33 PM Changeset in webkit [84684] by
-
- 4 edits in trunk/Source/JavaScriptCore
Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks
Reviewed by Geoff Garen.
These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::blockForBytecodeOffset):
- dfg/DFGNode.h:
(JSC::DFG::Node::isTerminal):
- 2:32 PM Changeset in webkit [84683] by
-
- 11 edits in trunk/Source/WebCore
2011-04-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kent Tamura.
Don't rely on hasSpinButton to check if an input type can be stepped
https://bugs.webkit.org/show_bug.cgi?id=59224
Add isSteppable to know for certain if an input type can
be stepped or not. Previously we were checking if the input
has a spin control or is the range input type. These are UI
details, but the step functionality does not require there
to be a UI.
No change in behavior, covered by existing tests.
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::isSteppable):
- html/BaseDateAndTimeInputType.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSteppable): (WebCore::HTMLInputElement::stepUpFromRenderer): remove the check for a spinner and range control and instead ASSERT that the type is steppable.
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::InputType::isSteppable):
- html/InputType.h:
- html/NumberInputType.cpp: (WebCore::NumberInputType::isSteppable):
- html/NumberInputType.h:
- html/RangeInputType.cpp: (WebCore::RangeInputType::isSteppable):
- html/RangeInputType.h:
- 2:24 PM Changeset in webkit [84682] by
-
- 2 edits in trunk/Source/WebKit2
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.
Reviewed by Sam Weinig.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.
- 2:20 PM Changeset in webkit [84681] by
-
- 7 edits in trunk
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
Update expected result to show that this test is passing now.
- http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
In this patch, I've audited all the callers to
SecurityOrigin::canDisplay to make sure they all the appropriate
Content-Security-Policy method as well. I'm not sure how to test all
these cases, but making this changes fixed the frame-src test.
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
- While I was understanding this code, I fixed the FIXME here.
- loader/cache/CachedResourceLoader.h:
- 2:17 PM Changeset in webkit [84680] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Clear shared graphics context when destroying CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=59212
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
- 2:17 PM Changeset in webkit [84679] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Object.create creates uncachable objects
https://bugs.webkit.org/show_bug.cgi?id=59164
Use the prototype object's inheritorID, as we
should always have done
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::nullPrototypeObjectStructure):
- runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
- 2:05 PM Changeset in webkit [84678] by
-
- 3 edits3 adds in trunk
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
End/Home keys do not work in a contentEditable element
https://bugs.webkit.org/show_bug.cgi?id=50564
Fixing modifying selection by lineboundary (home/end) for editable contexts that are
inline and share a line with non-editable content.
- editing/selection/modify-by-lineboundary-in-inline-editable-contexts-expected.txt: Added.
- editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html: Added.
- editing/selection/script-tests/modify-by-lineboundary-in-inline-editable-contexts.js: Added. (testModifyByLine):
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
End/Home keys do not work in a contentEditable element
https://bugs.webkit.org/show_bug.cgi?id=50564
Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
inline and share a line with non-editable content.
Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html
- editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
- 1:54 PM Changeset in webkit [84677] by
-
- 47 edits in trunk/LayoutTests
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
[Gtk] Update expectations after r84511.
- platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-1-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-expected.txt:
- platform/gtk/fast/html/details-no-summary1-expected.txt:
- platform/gtk/fast/html/details-no-summary2-expected.txt:
- platform/gtk/fast/html/details-no-summary3-expected.txt:
- platform/gtk/fast/html/details-no-summary4-expected.txt:
- platform/gtk/fast/html/details-open-javascript-expected.txt:
- platform/gtk/fast/html/details-open1-expected.txt:
- platform/gtk/fast/html/details-open2-expected.txt:
- platform/gtk/fast/html/details-open3-expected.txt:
- platform/gtk/fast/html/details-open4-expected.txt:
- platform/gtk/fast/html/details-open5-expected.txt:
- platform/gtk/fast/html/details-open6-expected.txt:
- platform/gtk/fast/html/details-position-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-expected.txt:
- platform/gtk/fast/html/details-writing-mode-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- 1:44 PM Changeset in webkit [84676] by
-
- 2 edits in trunk/Tools
2011-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=59207
My recent changes to how LayoutTestResults.results_from_string
uncovered a bug in our use of urllib2.
We now are treating the return value from _fetch_results_html()
(which returns urllib2.openurl()) as a string. That's incorrect,
the return value is a file-like object (which auto-converts to a
string in most cases).
I've updated our urllib2-using code to correctly call .read() on the
resulting object before treating it like a string.
Unfortunately there is no easy way to test this mis-understanding
of the openurl() semantics.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- 1:38 PM Changeset in webkit [84675] by
-
- 12 edits in trunk/Source/JavaScriptCore
Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result
Reviewed by Sam Weinig.
We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.
Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- 1:30 PM Changeset in webkit [84674] by
-
- 4 edits in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Landing new baselines for plugins/embedded-attributes-style.html after
border changes (r84273).
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium-win/plugins/embed-attributes-style-expected.png:
- platform/chromium/test_expectations.txt:
- 1:28 PM Changeset in webkit [84673] by
-
- 46 edits in trunk/LayoutTests
[Qt] Update expected files after r84632.
- platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-1-expected.txt:
- platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-10-expected.txt:
- platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-2-expected.txt:
- platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-3-expected.txt:
- platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-4-expected.txt:
- platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-5-expected.txt:
- platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-6-expected.txt:
- platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-7-expected.txt:
- platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-8-expected.txt:
- platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-9-expected.txt:
- platform/qt/fast/html/details-no-summary1-expected.txt:
- platform/qt/fast/html/details-no-summary2-expected.txt:
- platform/qt/fast/html/details-no-summary3-expected.txt:
- platform/qt/fast/html/details-no-summary4-expected.txt:
- platform/qt/fast/html/details-open-javascript-expected.txt:
- platform/qt/fast/html/details-open1-expected.txt:
- platform/qt/fast/html/details-open2-expected.txt:
- platform/qt/fast/html/details-open3-expected.txt:
- platform/qt/fast/html/details-open4-expected.txt:
- platform/qt/fast/html/details-open5-expected.txt:
- platform/qt/fast/html/details-open6-expected.txt:
- platform/qt/fast/html/details-position-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-expected.txt:
- platform/qt/fast/html/details-writing-mode-expected.txt:
- 1:27 PM Changeset in webkit [84672] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Make showTree/showTreeForThis aware of the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=52965
No new tests, because this code is only compiled in DEBUG.
- dom/Node.cpp: (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
recursive sub-traversal of the shadow tree.
(WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.
- 1:11 PM Changeset in webkit [84671] by
-
- 15 edits in branches/chromium/742/Source/WebCore
Merge 84582 - 2011-04-21 Vangelis Kokkevis <vangelis@chromium.org> Reviewed by James Robinson. [chromium] Only update the contents of layers that are going to be drawn. Remove individual texture unreserves that happen after the layer draw calls with a single unreserve for all the textures in the texture manager. https://bugs.webkit.org/show_bug.cgi?id=59129 Tests: No new functionality. Covered by existing layout tests. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::paintLayerContents): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTexture.cpp: * platform/graphics/chromium/LayerTexture.h: * platform/graphics/chromium/LayerTilerChromium.cpp: * platform/graphics/chromium/LayerTilerChromium.h: * platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface): * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectAllTextures): * platform/graphics/chromium/TextureManager.h: * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::owner):
TBR=vangelis@chromium.org
- 1:11 PM Changeset in webkit [84670] by
-
- 12 edits1 delete in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
- Update results of prototype-inheritance-2 for new array behavior.
- Remove checks for primitives, since they were incorrect.
- Force function check to check a function not on a primitive (this wasn't happening by itself, since functions normally aren't enumerable in the DOM).
- Add exception to the test to not try and test HTMLProgressElement, since it is not available on all platforms. This allows us to remove the windows specific results.
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow): (crawl):
- platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
- runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray): Add variants of constructArray that take a global object.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
Change callers of constructArray to use the new variant that takes
a global object.
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain):
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::ports):
- bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getAttachedShaders): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
- 1:05 PM Changeset in webkit [84669] by
-
- 3 edits in branches/chromium/742/Source/WebKit/chromium
Merge 84427 - 2011-04-20 Yuzhu Shen <yzshen@chromium.org> Reviewed by Tony Chang. [chromium] linux chromium doesn't set click count for mouse up events. https://bugs.webkit.org/show_bug.cgi?id=58921 The reason why we need such a fix is that the Pepper API passes this information to plugins, and some consumers (e.g., Flash) need it to detect double-clicks. * src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.
TBR=commit-queue@webkit.org
- 1:03 PM Changeset in webkit [84668] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed typo fix after r84522.
- WebCore.pro:
- 1:01 PM Changeset in webkit [84667] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Daniel Bates <dbates@rim.com>
Fix misspelled word in comment; tagets => targets.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- 1:01 PM Changeset in webkit [84666] by
-
- 3 edits2 copies in branches/chromium/742
Merge 84604 - https://bugs.webkit.org/show_bug.cgi?id=57898REGRESSION (r82185): Scroll position not restored on navigation back to a page in the page cache-and corresponding-<rdar://problem/9226652>Reviewed by Dan Bernstein.Source/WebCore: The original fix for this change broke scroll-position restore for pages that are *not* in the page cache. This patch fixes both cached and non-cached pages by using the cachedScrollPosition() only for cached pages.* loader/HistoryController.cpp:(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):LayoutTests: * fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.* fast/loader/scroll-position-restored-on-back-non-cached.html: Added.
TBR=Beth Dakin
- 12:57 PM Changeset in webkit [84665] by
-
- 27 edits1 add in trunk
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: Element and Document
https://bugs.webkit.org/show_bug.cgi?id=59178
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp: Build!
- bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMImplementationOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also, DOMImplementation does not need to keep its document wrapper alive, since there's no DOM API for getting a DOMImplementation's document.
- bindings/js/JSDOMStringMapCustom.cpp: (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMStringMapOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMStringMap.
- bindings/js/JSDOMTokenListCustom.cpp: Added. (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMTokenListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMTokenList.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
- bindings/js/JSElementCustom.cpp: No more need for explicit marking.
- bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
- dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::ref): (WebCore::DOMImplementation::deref): (WebCore::DOMImplementation::document): Fixed the DOMImplementation ownership model to match other satellite objects in the DOM. This was necessary to fix some crashes due to incorrect reference counting.
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- dom/Element.idl:
- html/DOMTokenList.idl: Updated to match changes above.
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: Element and Document
https://bugs.webkit.org/show_bug.cgi?id=59178
- fast/dom/dataset-gc-expected.txt:
- fast/dom/script-tests/dataset-gc.js: Changed this test not to be specific to proto. We have a general bug in the DOM that assignment to proto does not persist after garbage collection. While we should fix that bug, we don't want existing tests to tickle it, because it makes them flaky.
- 12:54 PM Changeset in webkit [84664] by
-
- 3 edits3 adds in trunk
2011-04-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Rounded corners don't looks smooth when background-image is a gradient
https://bugs.webkit.org/show_bug.cgi?id=59213
Add the "shrink background" behavior to the slow background
drawing code path.
Test: fast/backgrounds/gradient-background-leakage.html
- rendering/RenderBoxModelObject.cpp: (WebCore::backgroundRectAdjustedForBleedAvoidance): Utility function that returns a shrunk border rect based on the context scale. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use backgroundRectAdjustedForBleedAvoidance() in both the fast and slow paths.
- 12:49 PM Changeset in webkit [84663] by
-
- 6 edits13 adds in trunk/LayoutTests
2011-04-22 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
Update expected images with new shadow code
[chromium, win] Multiple failures of shadow rendering layout tests
https://bugs.webkit.org/show_bug.cgi?id=58772
- platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
- platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Added.
- platform/chromium-win-xp/fast/transforms: Added.
- platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
- platform/chromium-win-xp/transitions: Added.
- platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-win/svg/css/composite-shadow-text-expected.png:
- platform/chromium/test_expectations.txt:
- 12:46 PM Changeset in webkit [84662] by
-
- 3 edits2 copies in branches/chromium/742
Merge 84440 - 2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. https://bugs.webkit.org/show_bug.cgi?id=59037 * fast/events/simulated-click-disabled-expected.txt: Added. * fast/events/simulated-click-disabled.html: Added.2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. https://bugs.webkit.org/show_bug.cgi?id=59037 Test: fast/events/simulated-click-disabled.html * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
TBR=Dimitri Glazkov
- 12:31 PM Changeset in webkit [84661] by
-
- 4 edits8 copies in branches/chromium/696
Merge 84655 - 2011-04-22 Levi Weintraub <leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents https://bugs.webkit.org/show_bug.cgi?id=59204 http://code.google.com/p/chromium/issues/detail?id=80216 Test: fast/block/positioning/rtl-fixed-positioning.html fast/block/positioning/vertical-rl/fixed-positioning.html Returning the proper scroll offsets for fixed position content in RTL documents. We regressed to X and Y offsets not updating while scrolling when we clamped to zero, but RTL documents scroll in negative space. * page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above. * platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.2011-04-22 Levi Weintraub <leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents https://bugs.webkit.org/show_bug.cgi?id=59204 http://code.google.com/p/chromium/issues/detail?id=80216 Test to ensure position:fixed works properly in RTL documents. * fast/block/positioning/rtl-fixed-positioning.html: Added. * fast/block/positioning/vertical-rl/fixed-positioning.html: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
TBR=leviw@chromium.org
- 12:26 PM Changeset in webkit [84660] by
-
- 16 edits in trunk/Source/JavaScriptCore
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84650 and r84654.
http://trac.webkit.org/changeset/84650
http://trac.webkit.org/changeset/84654
https://bugs.webkit.org/show_bug.cgi?id=59218
Broke Windows build (Requested by bweinstein on #webkit).
- API/JSCallbackObjectFunctions.h: (JSC::::init):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
- heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
- heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
- heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
- heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
- heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
- heap/Local.h: (JSC::::set):
- heap/Strong.h: (JSC::Strong::set):
- heap/Weak.h: (JSC::Weak::set):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
- runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
- runtime/WriteBarrier.h:
- 12:25 PM Changeset in webkit [84659] by
-
- 3 edits3 adds in trunk
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
- fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- fast/forms/cursor-at-editable-content-boundary.html: Added.
- platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.
Test: fast/forms/cursor-at-editable-content-boundary.html
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
- 12:25 PM Changeset in webkit [84658] by
-
- 3 edits1 add in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor PatchAnalysis task out of CommitQueueTask
https://bugs.webkit.org/show_bug.cgi?id=59220
This is a first step towards teaching the EWS to run tests.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
- 12:18 PM April 2011 Meeting edited by
- (diff)
- 12:17 PM April 2011 Meeting edited by
- (diff)
- 12:08 PM Changeset in webkit [84657] by
-
- 1 edit13 adds in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: update Chromium baselines.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png: Added.
- 11:59 AM Changeset in webkit [84656] by
-
- 1 edit4910 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting remaining .checksum files.
More will probably creep in over the next few days-- I'll do
another pass in a week or so.
- 11:56 AM April 2011 Meeting edited by
- (diff)
- 11:53 AM Changeset in webkit [84655] by
-
- 4 edits8 adds in trunk
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: left property broken with position:fixed elements in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=59204
http://code.google.com/p/chromium/issues/detail?id=80216
Test: fast/block/positioning/rtl-fixed-positioning.html
fast/block/positioning/vertical-rl/fixed-positioning.html
Returning the proper scroll offsets for fixed position content in RTL documents.
We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
but RTL documents scroll in negative space.
- page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above.
- platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: left property broken with position:fixed elements in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=59204
http://code.google.com/p/chromium/issues/detail?id=80216
Test to ensure position:fixed works properly in RTL documents.
- fast/block/positioning/rtl-fixed-positioning.html: Added.
- fast/block/positioning/vertical-rl/fixed-positioning.html: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- 11:52 AM Changeset in webkit [84654] by
-
- 2 edits in trunk/Source/JavaScriptCore
Part of Windows build fix from r84650.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:51 AM Changeset in webkit [84653] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
Should assert on invalid type in FEComponentTransfer::apply
https://bugs.webkit.org/show_bug.cgi?id=57959
No functional change. No new tests needed.
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- 11:43 AM Changeset in webkit [84652] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 MORITA Hajime <morrita@google.com>
Unreviewed crash fix.
- html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::shouldInclude):
- 11:36 AM Changeset in webkit [84651] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [84650] by
-
- 15 edits in trunk/Source/JavaScriptCore
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make it harder to use HandleSlot incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59205
Just add a little type fudging to make it harder to
incorrectly assign through a HandleSlot.
- API/JSCallbackObjectFunctions.h: (JSC::::init):
- JavaScriptCore.exp:
- heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
- heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
- heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
- heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
- heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
- heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
- heap/Local.h: (JSC::::set):
- heap/Strong.h: (JSC::Strong::set):
- heap/Weak.h: (JSC::Weak::set):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
- runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
- runtime/WriteBarrier.h: (JSC::OpaqueJSValue::toJSValue): (JSC::OpaqueJSValue::toJSValueRef): (JSC::OpaqueJSValue::fromJSValue):
- 11:13 AM Changeset in webkit [84649] by
-
- 2 edits in trunk/Source/WebCore
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206
Reviewed by Sam Weinig.
No test added because functionality is unchanged.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().
- 11:03 AM Changeset in webkit [84648] by
-
- 5 edits in trunk/Source/WebKit2
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
https://bugs.webkit.org/show_bug.cgi?id=59179
Add API to allow the WebCore Settings preference to be called from the UIProcess.
- Shared/WebPreferencesStore.h: Added new preference definition macro.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAVFoundationEnabled): Added. (WKPreferencesGetAVFoundationEnabled): Added.
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Pass new preference along to WebCore
Settings.
- 11:00 AM Changeset in webkit [84647] by
-
- 1 edit6435 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting .checksum files in platform/mac.
- 10:51 AM Changeset in webkit [84646] by
-
- 10 edits in trunk/Source
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=59147
Add a new isAVFoundationEnabled setting and check it before adding
MediaPlayerPrivateAVFoundationObjC to the media engine registry.
- WebCore.exp.in:
- page/Settings.cpp:
- page/Settings.h: (WebCore::Settings::setAVFoundationEnabled): Added. (WebCore::Settings::isAVFoundationEnabled): Added.
- platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Check the settings added above.
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=59147
Add a new user default preference, and plumb that preference down to WebCore
Settings. Allow the fullScreenEnabled preference to override the new
isAVFoundationEnabled preference, so that clients of the legacy full screen
mode will continue to use that mode normally.
- WebView/WebPreferenceKeysPrivate.h: Add new preference key.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set the default value of new
preference.
(-[WebPreferences setAVFoundationEnabled:]): Added.
(-[WebPreferences isAVFoundationEnabled]): Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the WebCore settings with the
new values from WebPreferences.
- 10:49 AM Changeset in webkit [84645] by
-
- 3 edits in trunk
Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.
Bugzilla autocomplete should support frequent contributors who are not committers
https://bugs.webkit.org/show_bug.cgi?id=59209
- 10:49 AM Changeset in webkit [84644] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix qt build.
- Api/qwebelement.cpp:
(setupScriptContext):
- 10:47 AM Changeset in webkit [84643] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.
- 10:40 AM Changeset in webkit [84642] by
-
- 2 edits in trunk/LayoutTests
Fix windows test result.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 10:37 AM Changeset in webkit [84641] by
-
- 25 edits in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- fast/dom/prototype-inheritance-2-expected.txt: Add new passing results since we now use the correct global object. The remaining failures are pure JS objects (Array, Boolean, String, Number, Function).
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot): (DumpRenderTreeSupportGtk::ensureShadowRoot): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- DOM/WebDOMOperations.mm: (-[DOMElement _shadowRoot:]): (-[DOMElement _ensureShadowRoot:]): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::createPattern):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSSQLStatementErrorCallback::handleEvent):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMMimeTypeArrayCustom.cpp: (WebCore::JSDOMMimeTypeArray::nameGetter):
- bindings/js/JSDOMPluginArrayCustom.cpp: (WebCore::JSDOMPluginArray::nameGetter):
- bindings/js/JSDOMPluginCustom.cpp: (WebCore::JSDOMPlugin::nameGetter):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::namedItemGetter): (WebCore::JSDOMWindow::event):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/js/JSInjectedScriptHostCustom.cpp: Propagate stored global object down access chain.
(WebCore::InjectedScriptHost::nodeAsScriptValue):
Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
(WebCore::JSInjectedScriptHost::currentCallFrame):
(WebCore::JSInjectedScriptHost::inspectedNode):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
- bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument):
- bindings/scripts/CodeGeneratorJS.pm: Propagate stored global object down access chain.
- css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype, we will want refactor this to match other callbacks so we can remove this.
- 10:25 AM Changeset in webkit [84640] by
-
- 3 edits in trunk/Source/WebCore
2011-04-22 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Mac UI polish to add left/right padding space for autofill popup window.
https://bugs.webkit.org/show_bug.cgi?id=58960
http://code.google.com/p/chromium/issues/detail?id=51077
No new test because Chromium Autofill popup window doesn't have any test framework.
This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
Only if Autofill popup window has right/left padding.
The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
- rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified. (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
- 9:51 AM Changeset in webkit [84639] by
-
- 1 edit8383 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting .checksum files in platform/gtk and platform/qt*.
- 9:48 AM Changeset in webkit [84638] by
-
- 6 edits in trunk/Source/WebKit2
Give windowless plugins' context menus an owner window in the same thread as the plugin
In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.
I couldn't figure out how to write a test for this. :-(
Fixes <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin
Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.
- Platform/Module.h: Added installIATHook on Windows.
- Platform/win/ModuleWin.cpp:
(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.
- Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit::NetscapePluginModule::module): Added this simple getter.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.
(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.
(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).
- 9:45 AM Changeset in webkit [84637] by
-
- 8 edits3 adds in trunk
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
- DumpRenderTree/gtk/EventSender.cpp: (scalePageByCallback): scalePageBy() support.
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Unskipped tests that should pass now that
eventSender.scalePageBy() is supported in GTK.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Added support in DRT for webview scaling.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::scale):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- 9:45 AM Changeset in webkit [84636] by
-
- 2 edits9 adds in trunk/Source/WebCore
Add code to enumerate all the functions imported by a particular Windows binary
PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.
I couldn't figure out how to write a test for this. :-(
Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin
Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.
- WebCore.vcproj/WebCore.vcproj: Added the new files.
- platform/win/PEImage.cpp: Added.
(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.
- platform/win/PEImage.h: Added.
(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.
- platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)
- platform/win/ImportedFunctionsEnumerator.h: Added.
- platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.
- platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.
- platform/win/ImportedModulesEnumerator.h: Added.
- platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.
- platform/win/DelayLoadedModulesEnumerator.h: Added.
- 9:44 AM Changeset in webkit [84635] by
-
- 5 edits2 adds in trunk/Source
Add a shared do-nothing window class that anyone can use
Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
platform/win and into platform. Let VS reorder other files.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.
- platform/win/DefWndProcWindowClass.cpp: Added.
(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!
- platform/win/DefWndProcWindowClass.h: Added.
Source/WebKit2:
Use WebCore's do-nothing window class instead of creating our own
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::createDummyWindow): Less code!
- 9:39 AM Changeset in webkit [84634] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Cannot play flash with NSPluginWrapper
https://bugs.webkit.org/show_bug.cgi?id=59125
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle the case when we have been called with a null plugin instance.
- 9:25 AM Changeset in webkit [84633] by
-
- 5 edits2 adds in trunk/Tools
2011-04-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
LayoutTestResults should know how to handle NRWT json files
https://bugs.webkit.org/show_bug.cgi?id=59168
LayoutTestResults was originally created to be a parallel
to existing NRWT architecture for dealing with results files.
But then it turns out that NRWT has no such architecture. :(
So this patch writes the necessary code to handle reading
full_results.json and unexpected_results.json files from
NRWT layout-test-results directories.
LayoutTestResults has thus morphed from being ORWT-only to
supporting both ORWT and NRWT. It's possible at some future
point that other pieces of the NRWT architecture will learn
how to read JSON files in which case this can go away.
This is all done for making it possible for the commit-queue
to run the tests using NWRT and be able to understand the results
(for flaky test reporting, etc.)
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
- 9:13 AM Changeset in webkit [84632] by
-
- 62 edits16 adds in trunk
2011-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <details> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59055
- fast/html/details-add-child-1.html: Added.
- fast/html/details-add-child-2.html: Added.
- fast/html/details-remove-child-1.html: Added.
- fast/html/details-remove-child-2.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/html/details-add-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-add-child-1-expected.png: Added.
- platform/mac/fast/html/details-add-child-1-expected.txt: Added.
- platform/mac/fast/html/details-add-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-add-child-2-expected.png: Added.
- platform/mac/fast/html/details-add-child-2-expected.txt: Added.
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.txt:
- platform/mac/fast/html/details-add-summary-child-2-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-remove-child-1-expected.png: Added.
- platform/mac/fast/html/details-remove-child-1-expected.txt: Added.
- platform/mac/fast/html/details-remove-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-remove-child-2-expected.png: Added.
- platform/mac/fast/html/details-remove-child-2-expected.txt: Added.
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <details> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59055
- Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
- Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as subclasses of ShadowContentElement.
- Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that handles non-summary contents of <details>. Another is SummaryContentElement, that handles the main summary element.
- Removed most of RenderDetails custom layout mechanism, which is replaced by ShadowContentElement subclasses.
Tests: fast/html/details-add-child-1.html
fast/html/details-add-child-2.html
fast/html/details-remove-child-1.html
fast/html/details-remove-child-2.html
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::contentContainerFor): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::hasContentElement):
- dom/ShadowRoot.h:
- html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsContentElement::create): (WebCore::DetailsContentElement::shouldInclude): (WebCore::DetailsSummaryElement::DetailsSummaryElement): (WebCore::DetailsSummaryElement::create): (WebCore::DetailsSummaryElement::shouldInclude): (WebCore::HTMLDetailsElement::create): (WebCore::HTMLDetailsElement::HTMLDetailsElement): (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf): (WebCore::findSummaryFor): (WebCore::HTMLDetailsElement::ensureMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLDetailsElement.h:
- html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement): (WebCore::SummaryContentElement::shouldInclude): (WebCore::SummaryContentElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree):
- html/shadow/ShadowContentElement.h:
- rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::addChild):
- rendering/RenderDetails.h:
- rendering/RenderSummary.cpp:
- rendering/RenderSummary.h:
- 8:51 AM Changeset in webkit [84631] by
-
- 7 edits2 adds in trunk
2011-04-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
https://bugs.webkit.org/show_bug.cgi?id=59109
Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().
Add an assertion that fires when a GraphicsContext() is destroyed with a non-
empty state stack. Fix canvas to avoid this assertion, since bad content might
trigger it.
Also add an assertion that fires for mismatched begin/endTransparencyLayers.
Test: fast/text/multiple-text-shadow-alpha.html
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Make sure that the CanvasRenderingContext goes away before the ImageBuffer, so that CanvasRenderingContext2D has a chance to unwind the state stack in the ImageBuffer's GraphicsContext.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D): Balance unmatched state saves in the canvas context.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::~GraphicsContext): Assert that the stack is empty.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): Changes to allow for asserting for unmatched transparency layer begin/ends.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Remove an unbalanced save().
- 8:39 AM Changeset in webkit [84630] by
-
- 2 edits in trunk/LayoutTests
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081
Add media/audio-controls-do-not-fade-out.html, which uses layoutTestController.shadowRoot
to the win Skipped list to get the bots green.
- platform/win/Skipped:
- 8:34 AM Changeset in webkit [84629] by
-
- 6 edits in trunk/Source/WebCore
2011-04-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add Save As context menu item to the TextViewer.
https://bugs.webkit.org/show_bug.cgi?id=59196
- inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.requestContent): (WebInspector.ResourceSourceFrame.prototype.suggestedFileName): (WebInspector.RevisionSourceFrame.prototype.requestContent): (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._initializeTextViewer): (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu): (WebInspector.SourceFrame.prototype.suggestedFileName): (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu): (WebInspector.TextViewerDelegate.prototype.cancelEditing): (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu): (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu): (WebInspector.TextViewerDelegate.prototype.suggestedFileName):
- 8:21 AM Changeset in webkit [84628] by
-
- 2 edits in trunk/LayoutTests
Update the Windows-specific results after r84558.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 7:43 AM Changeset in webkit [84627] by
-
- 7 edits5 adds in trunk
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- Source/WebKit.pro: Add platformplugin path to the SUBDIRS.
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
- symbian/platformplugin: Added.
- symbian/platformplugin/WebPlugin.cpp: Added. (ItemListDelegate::ItemListDelegate): (ItemListDelegate::paint): (Popup::Popup): (Popup::resizeEvent): (Popup::populateList): (Popup::onItemSelected): (Popup::updateSelectionsBeforeDialogClosing): (Popup::updateAndClose): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleSelectionPopup::MultipleSelectionPopup): (WebNotificationPresenter::showNotification): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
- symbian/platformplugin/WebPlugin.h: Added. (Popup::preSelectedIndices): (Popup::listWidget): (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter):
- symbian/platformplugin/platformplugin.pro: Added.
- symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebTouchModifier::~QWebTouchModifier): (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Exempting directory WebKit/qt/symbian/platformplugin from style guide.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 6:52 AM Changeset in webkit [84626] by
-
- 13 edits2 adds in trunk/Source
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=59094
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- gyp/streamline-inspector-source.sh:
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.dispose): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider): (MixInSnapshotNodeFunctions):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose): (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose): (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths): (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype.dispose): (WebInspector.DetailedHeapshotView.prototype.get profileWrapper): (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotLoader): (WebInspector.HeapSnapshotLoader.prototype.finishLoading): (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk): (WebInspector.HeapSnapshot.prototype.pushBaseIds): (WebInspector.HeapSnapshot.prototype.createDiff): (WebInspector.HeapSnapshot.prototype._parseFilter): (WebInspector.HeapSnapshot.prototype.createEdgesProvider): (WebInspector.HeapSnapshot.prototype.createNodesProvider): (WebInspector.HeapSnapshot.prototype.createPathFinder): (WebInspector.HeapSnapshot.prototype.updateStaticData): (WebInspector.HeapSnapshotPathFinder): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._reset):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotRealWorker): (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived): (WebInspector.HeapSnapshotRealWorker.prototype.postMessage): (WebInspector.HeapSnapshotRealWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker): (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage): (WebInspector.HeapSnapshotFakeWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker): (WebInspector.HeapSnapshotWorker): (WebInspector.HeapSnapshotWorker.prototype.createObject): (WebInspector.HeapSnapshotWorker.prototype.dispose): (WebInspector.HeapSnapshotWorker.prototype.disposeObject): (WebInspector.HeapSnapshotWorker.prototype.callGetter): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod): (WebInspector.HeapSnapshotWorker.prototype.callMethod): (WebInspector.HeapSnapshotWorker.prototype._findFunction): (WebInspector.HeapSnapshotWorker.prototype._messageReceived): (WebInspector.HeapSnapshotWorker.prototype._postMessage): (WebInspector.HeapSnapshotProxyObject): (WebInspector.HeapSnapshotProxyObject.prototype._callWorker): (WebInspector.HeapSnapshotProxyObject.prototype.dispose): (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker): (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod): (WebInspector.HeapSnapshotProxyObject.prototype.callGetter): (WebInspector.HeapSnapshotProxyObject.prototype.callMethod): (WebInspector.HeapSnapshotLoaderProxy): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded): (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk): (WebInspector.HeapSnapshotProxy): (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createDiff): (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.createPathFinder): (WebInspector.HeapSnapshotProxy.prototype.dispose): (WebInspector.HeapSnapshotProxy.prototype.finishLoading): (WebInspector.HeapSnapshotProxy.prototype.get loaded): (WebInspector.HeapSnapshotProxy.prototype.get nodeCount): (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex): (WebInspector.HeapSnapshotProxy.prototype.updateStaticData): (WebInspector.HeapSnapshotProxy.prototype.startLoading): (WebInspector.HeapSnapshotProxy.prototype.get totalSize): (WebInspector.HeapSnapshotProxy.prototype.get uid): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotPathFinderProxy): (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext): (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots): (WebInspector.HeapSnapshotsDiffProxy): (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
- inspector/front-end/HeapSnapshotWorker.js: Added. (WebInspector.UIString): (postMessageWrapper):
- inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added. (WebInspector.HeapSnapshotWorkerDispatcher): (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction): (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=59094
- WebKit.gyp:
- 6:49 AM Changeset in webkit [84625] by
-
- 12 edits2 moves in trunk
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix de-obfuscation of scripts inlined in html.
https://bugs.webkit.org/show_bug.cgi?id=58538
- inspector/debugger/resources/obfuscated.js:
- inspector/debugger/script-formatter-expected.txt:
- inspector/debugger/script-formatter.html: Renamed from LayoutTests/inspector/debugger/script-formatter.html-disabled.
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix de-obfuscation of scripts inlined in html.
https://bugs.webkit.org/show_bug.cgi?id=58538
Use html tokenizer to find script boundaries instead of relying on scriptParsed events.
Test: inspector/debugger/script-formatter.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._didFormatContent):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage): (formatScript): (HTMLScriptFormatter): (HTMLScriptFormatter.prototype.format): (HTMLScriptFormatter.prototype.scriptStarted): (HTMLScriptFormatter.prototype.scriptEnded): (HTMLScriptFormatter.prototype.styleSheetStarted): (HTMLScriptFormatter.prototype.styleSheetEnded):
- inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent):
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/WebKit.qrc:
- 6:36 AM Changeset in webkit [84624] by
-
- 5 edits in trunk/Source
2011-04-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194
- inspector/front-end/ExtensionAPISchema.json:
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):
2011-04-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194
- src/js/DevTools.js: (WebInspector.platformExtensionAPI):
- 6:18 AM Changeset in webkit [84623] by
-
- 3 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group content scripts in the scripts panel drop down.
https://bugs.webkit.org/show_bug.cgi?id=59108
- English.lproj/localizedStrings.js:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
- 5:38 AM Changeset in webkit [84622] by
-
- 4 edits in trunk/Source/WebCore
2011-04-22 Mike West <mkwst@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
https://bugs.webkit.org/show_bug.cgi?id=59100
Improve web inspector UI around adding XHR breakpoints by adding
a textual label to the input-likespanused to specify which
XHR requests the breakpoint ought to target.
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
- inspector/front-end/inspector.css: (#breakpoint-condition-input):
- 5:35 AM Changeset in webkit [84621] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-22 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- 5:34 AM Changeset in webkit [84620] by
-
- 7 edits1 add1 delete in trunk/Source/WebCore
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
https://bugs.webkit.org/show_bug.cgi?id=59191
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage):
- inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
- inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added. (FormattedContentBuilder): Helper class for building formatted script content. (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype.addSpace): (FormattedContentBuilder.prototype.addNewLine): (FormattedContentBuilder.prototype.increaseNestingLevel): (FormattedContentBuilder.prototype.decreaseNestingLevel): (FormattedContentBuilder.prototype.content): (FormattedContentBuilder.prototype.mapping): (Tokenizer): Wrapper class for UglifyJS tokenizer. (Tokenizer.prototype.content): (Tokenizer.prototype.next): (Tokenizer.prototype._convertUglifyToken): (JavaScriptFormatter): New formatter based on UglifyJS tokenizer. (JavaScriptFormatter.prototype.format):
- inspector/front-end/UglifyJS/process.js: Removed.
- inspector/front-end/WebKit.qrc:
- 5:32 AM Changeset in webkit [84619] by
-
- 16 edits1 add in trunk
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
https://bugs.webkit.org/show_bug.cgi?id=59189
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BinarySearch.js: Added.
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData): (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived): (WebInspector.HeapSnapshotDiffNode.prototype.get data):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave): (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource): (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDominatorsDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind): (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize): (WebInspector.HeapSnapshotNodesProvider.prototype._serialize): (WebInspector.HeapSnapshotsDiff.prototype.calculate): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
- inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor): (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
https://bugs.webkit.org/show_bug.cgi?id=59189
- inspector/profiler/detailed-heapshots-comparison-sorting.html:
- inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest): (initialize_DetailedHeapshotTest.):
- inspector/profiler/heap-snapshot-expected.txt:
- inspector/profiler/heap-snapshot.html:
- 5:18 AM Changeset in webkit [84618] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.handleShortcut):
- 5:10 AM Changeset in webkit [84617] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Csaba Osztrogonác <Csaba Osztrogonác>
[WK2] CSP reporting doesn't work
https://bugs.webkit.org/show_bug.cgi?id=59192
- platform/mac-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html.
- 4:24 AM Changeset in webkit [84616] by
-
- 3 edits in trunk/LayoutTests
[Qt]fast/url/idna tests fail
https://bugs.webkit.org/show_bug.cgi?id=59187
- platform/qt/Skipped: Add fast/url/idna2003.html and fast/url/idna2008.html.
- platform/qt/fast/url/path-expected.txt: Update after r84606.
- 3:39 AM Changeset in webkit [84615] by
-
- 2 edits in trunk/Tools
2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Qt should use the mac-wk2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=58536
- Scripts/old-run-webkit-tests:
- 3:04 AM Changeset in webkit [84614] by
-
- 3 edits in trunk/Source/WebCore
2011-04-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline is too narrow
https://bugs.webkit.org/show_bug.cgi?id=58399
Changed Network Panel widths so that Timeline is 50%.
Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): Changed column widths. (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths. (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
- inspector/front-end/utilities.js: (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.
- 2:34 AM Changeset in webkit [84613] by
-
- 12 edits2 adds in trunk/Source/WebKit2
2011-04-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Sam Weinig.
[Qt][WK2] Implement DrawingAreaImpl for Qt.
https://bugs.webkit.org/show_bug.cgi?id=59171
- WebKit2.pro: Build files necessary for DrawingAreaImpl.
- DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.
- Shared/qt/LayerTreeContextQt.cpp: (WebKit::LayerTreeContext::LayerTreeContext): Stub. (WebKit::LayerTreeContext::~LayerTreeContext): Stub. (WebKit::LayerTreeContext::encode): Stub. (WebKit::LayerTreeContext::decode): Stub. (WebKit::LayerTreeContext::isEmpty): Stub. (WebKit::operator==): Stub.
- Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the source rect. The rect is already adjusted at the call site.
- UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested. (QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl, since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.
- UIProcess/BackingStore.h: Add Qt-specific types and backing store.
- UIProcess/qt/BackingStoreQt.cpp: (WebKit::BackingStore::paint): Implemented. (WebKit::BackingStore::incorporateUpdate): Implemented. (WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().
- UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Ditto.
- WebProcess/WebPage/DrawingArea.h: Ditto.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Ditto.
- 2:10 AM Changeset in webkit [84612] by
-
- 2 edits in trunk/Source/WebKit2
WinCairo build fix. Unreviewed.
- WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.
- 1:31 AM Changeset in webkit [84611] by
-
- 3 edits2 adds in trunk
<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: media/audio-controls-do-not-fade-out.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.
LayoutTests:
- media/audio-controls-do-not-fade-out-expected.txt: Added.
- media/audio-controls-do-not-fade-out.html: Added.
- 12:40 AM Changeset in webkit [84610] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Need to support authentication for downloads in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>
Reviewed by Maciej Stachowiak.
- WebProcess/Downloads/Download.cpp:
Include DownloadAuthenticationClient.h.
- WebProcess/Downloads/Download.h:
Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.
- WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.
(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.
- WebProcess/Downloads/DownloadAuthenticationClient.h: Added.
(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):
- WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.
- win/WebKit2.vcproj:
Add new files to project.
- 12:40 AM Changeset in webkit [84609] by
-
- 5 edits in trunk/Source/WebCore
2011-04-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
https://bugs.webkit.org/show_bug.cgi?id=59080
No new tests as no new functionality added.
- css/CSSPrimitiveValueMappings.h: Add casts to/from FontItalics and FontSmallCaps
- css/CSSStyleSelector.cpp: Use new casts defined in PrimitiveValueMappings.h
- platform/graphics/Font.h: Use FontItalics enum.
- platform/graphics/FontDescription.h: Define and use FontItalics and FontSmallCaps enums.
- 12:23 AM Changeset in webkit [84608] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
address maciej's styling feedback for results.html page
https://bugs.webkit.org/show_bug.cgi?id=59165
- fast/harness/results.html:
- 12:09 AM Changeset in webkit [84607] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
https://bugs.webkit.org/show_bug.cgi?id=59123
- inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show): (WebInspector.ResourceCookiesView.prototype.get _gotCookies): (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
