Context Navigation

All back/forward list and page cache related items used to be in WebKit.
When they were pushed into WebCore, some sloppy compromises were made to keep the Back/Forward cache working on Mac.
Namely, a WebCore::HistoryItem had to know how to keep a WebDocumentView alive. We accomplished this via some #ifdefs
in CachedPage and having the Mac-only CachedPageMac.mm

To get rid of that nastiness and pave the way for adding Back/Forward cache on other platforms, this patch adds the
concept of "CachedPagePlatformData" which can contain anything the platform API wants.

I also took the opportunity to do other cleanup and renaming client methods to better fit their new purposes.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

history/CachedPage.cpp: (WebCore::CachedPage::~CachedPage): Combined "close()" and "clear()" to just "clear()" - call it from here. (WebCore::CachedPage::clear): Call clear() on the CachedPagePlatformData if it exists. Also delete the CachedPagePlatformData. (WebCore::CachedPage::setCachedPagePlatformData): (WebCore::CachedPage::cachedPagePlatformData):
history/CachedPage.h:

history/CachedPagePlatformData.h: Added. (WebCore::CachedPagePlatformData::~CachedPagePlatformData): Virtual d'tor. (WebCore::CachedPagePlatformData::clear): Virtual method for platforms that need to do cleanup at the same time as CachedPage::clear().

history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Call "clear()" instead of "close()"

history/mac/CachedPageMac.mm: Removed. Functionality replaced with CachedPagePlatformData.

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call the new client methods. Make some work previously done by WebKitMac cross platform (setting the cached DocumentLoader to the Frame). (WebCore::FrameLoader::cachePageForHistoryItem): Renamed the client methods

loader/FrameLoaderClient.h: The very Mac-centric "makeDocumentView", "setDocumentViewFromCachedPage", and "saveDocumentViewToCachedPage" become "transitionToCommittedForNewPage", "transitionToCommittedFromCachedPage", and "savePlatformDataToCachedPage" accordingly

svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::savePlatformDataToCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedForNewPage):

WebKit:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

WebKit.xcodeproj/project.pbxproj: Added a new file

WebKit/gtk:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep GTK building

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

WebCoreSupport/WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDocumentView):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here, because that is now done in WebCore. (WebFrameLoaderClient::transitionToCommittedForNewPage):

WebKit/qt:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep Qt building

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

Even though this new code isn't exercised yet because the page cache is still turned off for Windows, local testing
has indicated it works well.

WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes an IWebDataSource and the object retains it (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDataSource):

WebFrame.cpp: (WebFrame::savePlatformDataToCachedPage): (WebFrame::transitionToCommittedFromCachedPage): (WebFrame::transitionToCommittedForNewPage):
WebFrame.h:

WebKit.vcproj/WebKit.vcproj:

WebKit/wx:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep Wx building

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):
WebKitSupport/FrameLoaderClientWx.h:

11:04 PM Changeset in webkit [28671] by mitz@apple.com

5 edits
2 moves in trunk

WebCore:

Reviewed by Oliver Hunt.

fix <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): When the font property is set to 'initial', set the font size to its initial value, 'medium', and the font family to the standard family.

LayoutTests:

Reviewed by Oliver Hunt.

updated results and skipped tests file for <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

platform/mac-leopard/fast/text/font-initial-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.checksum.
platform/mac-leopard/fast/text/font-initial-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.png.
platform/mac/fast/text/font-initial-expected.checksum: Removed.
platform/mac/fast/text/font-initial-expected.png: Removed.
platform/mac/fast/text/font-initial-expected.txt:
platform/win/Skipped:

10:56 PM Changeset in webkit [28670] by justin.garcia@apple.com

3 edits
6 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows): Don't remove the table row that contained the end of the selection if it is where we are about to place the ending selection. Don't remove all empty rows after the row that contained the start of the selection, they might come after the row that contained the end of the selection.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

editing/deleting/5433862-1-expected.txt: Added.
editing/deleting/5433862-1.html: Added.
editing/deleting/5433862-2.html: Added.
platform/mac/editing/deleting/5433862-2-expected.checksum: Added.
platform/mac/editing/deleting/5433862-2-expected.txt: Added.

9:33 PM Changeset in webkit [28669] by mjs@apple.com

2 edits in trunk/SunSpider

Reviewed by Sam.

Change sunspider-compare-results output from showing "% faster" values to "x as fast" values.

A sample of what new-style results would look like:

TEST COMPARISON FROM TO DETAILS
...
TOTAL : 1.41x as fast 6613.6ms +/- 0.1% 4703.0ms +/- 0.1% significant
...

3bit-bits-in-byte: *1.36x as slow* 88.8ms +/- 0.6% 121.1ms +/- 0.6% significant

resources/sunspider-compare-results.js:

5:47 PM Changeset in webkit [28668] by weinig@apple.com

4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Add button to clear the Web Inspector's console.

English.lproj/InspectorLocalizedStrings.js:
page/inspector/ConsolePanel.js:
page/inspector/inspector.css:

4:44 PM Changeset in webkit [28667] by andersca@apple.com

4 edits in trunk/WebCore

Reviewed by Adam and Jon.

<rdar://problem/5349282>
popup blocking is not applied to plugins on Windows.

Implement popup blocking. If the plug-in supports the new
NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState API we just use that
to determine if a plug-in request can open new windows.

If a plug-in does not support the new API, we assume that a plug-in can open new windows
in response to either mouse click or key press events.

plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::shouldAllowPopups): Add new shouldAllowPopups member.

(WebCore::PluginViewWin::popPopupsStateTimerFired):
Reset the popup state.

(WebCore::isWindowsMessageUserGesture):
New function that given a windows message id returns whether it's a user gesture or not.

(WebCore::PluginViewWin::wndProc):
Allow popups if the window message is a user gesture.

(WebCore::PluginViewWin::dispatchNPEvent):
New method that dispatches an NPEvent, turning on popups if necessary.

(WebCore::PluginViewWin::paint):
(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
Call dispatchNPEvent().

(WebCore::PluginViewWin::performRequest):
(WebCore::PluginViewWin::load):
Add calls to shouldAllowPopups().

(WebCore::PluginViewWin::pushPopupsEnabledState):
(WebCore::PluginViewWin::popPopupsEnabledState):
New methods that maintain the popup state stack.

(WebCore::PluginViewWin::arePopupsAllowed):
New method that returns whether popups are allowed.

(WebCore::PluginViewWin::PluginViewWin):

plugins/win/PluginViewWin.h: Add new instance variables.

plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Implement these.

4:23 PM Changeset in webkit [28666] by mitz@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by John Sullivan.

fix a bug in debug builds only where selecting an earlier item in a popup selects the first item

Test: fast/forms/menulist-selection-reset.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Added an argument that tells that function whether it should update the selected state of option elements. (WebCore::HTMLSelectElement::checkListItems): Changed to pass false as the above argument.
html/HTMLSelectElement.h:

LayoutTests:

Reviewed by John Sullivan.

test for a bug in debug builds only where selecting an earlier item in a popup selects the first item

fast/forms/menulist-selection-reset-expected.txt: Added.
fast/forms/menulist-selection-reset.html: Added.

4:02 PM Changeset in webkit [28665] by Beth Dakin

1 edit in trunk/LayoutTests/ChangeLog

OOPS!

3:56 PM Changeset in webkit [28664] by adele@apple.com

10 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5643054> Remove cue point implementation for media elements

When the specification for cue ranges is more final, we will implement those.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::load):
html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
platform/graphics/MediaPlayer.cpp:
platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

3:35 PM Changeset in webkit [28663] by Beth Dakin

1 edit
2 adds in trunk/LayoutTests

Reviewed by Nico.

Updated pixel results from my recent SVG change.

svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
svg/custom/inline-svg-in-xhtml-expected.png: Added.

2:37 PM Changeset in webkit [28662] by oliver@apple.com

2 edits in trunk/WebCore

2007-12-12 MorganL <morganl.webkit@yahoo.com> -- http://bugs.webkit.org/show_bug.cgi?id=16408

Reviewed by Maciej.

Fixes:
http://bugs.webkit.org/show_bug.cgi?id=16408

When navigating back/forward to a http:// link, we should prefer to
load from cache if possible.

loader/FrameLoader.cpp:

2:15 PM Changeset in webkit [28661] by andersca@apple.com

8 edits
2 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::unpackPlatformError): Handle kCFErrorDomainWinSock.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Ignore willSendRequest calls where the redirect response is null, like we do in the Mac version.

WebKitTools:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

DumpRenderTree/win/DumpRenderTree.cpp: (main): Set the resource load delegate.

DumpRenderTree/win/DumpRenderTree.vcproj:

DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
DumpRenderTree/win/ResourceLoadDelegate.h: Added.

LayoutTests:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

Remove now passing tests.

platform/win/Skipped:

2:14 PM Changeset in webkit [28660] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5643785> Fix iBench regression caused by mis-placed nested timer check.

Reviewed by Anders.

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Don't set high-resolution timer flag inside non-high-resolution timer proc.

1:46 PM Changeset in webkit [28659] by sfalken@apple.com

2 edits in trunk/WebKit/win

Build fix.

WebKit.vcproj/WebKit.make: Copy only what we need out of obj/bin.

1:24 PM Changeset in webkit [28658] by Beth Dakin

4 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://problem/5643770> REGRESSION: Free-standing SVGs
with width and height 100% clip to 300 x 150

Though it was correct in an earlier iteration of my patch, it is
not sufficient in the final, committed version to ask if the
relativeWidthValue() or relativeHeightValue() is greater than 0
just to determine if one has been set, for, they are now
initialized to 300 and 150 respectively! This patch instead adds a
bool to keep track of whether a container size has been set, and
only used the relative value if it has.

rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
svg/SVGSVGElement.h: (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::hasSetContainerSize):

11:26 AM Changeset in webkit [28657] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Steve Falkenburg

<rdar://problem/5012636> - WebURLProtectionSpace::realm returns the hostname rather than the authentication realm

platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::ProtectionSpace): Assign the realm to m_realm, instead of the host

9:57 AM Changeset in webkit [28656] by ap@webkit.org

4 edits in trunk

Reviewed by Adam Roben.

Fix conversion from double to LPARAM in dispatchMessage().

DumpRenderTree/win/EventSender.cpp: (dispatchMessageCallback):

9:34 AM Changeset in webkit [28655] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16388
[GTK] Widget::setCursor() gets called frequently

Cache the current cursor to avoid calling gdk_window_set_cursor() when
there's no change in cursor.

platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::cursor): (WebCore::Widget::setCursor):

9:27 AM Changeset in webkit [28654] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-12 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16342
Build Warning and Error fixes in WebCore GTK+

Use C-style casts for casting function pointers to gpointer
Use static_cast<int> to cast a float to int to fix a warning

platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::gtkValueChanged):
platform/gtk/ThreadingGtk.cpp: (callFunctionOnMainThread): (callOnMainThread):

8:59 AM Changeset in webkit [28653] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin Adler.

better fix for a crash when pressing a key that is not associated with a command

editing/EditorCommand.cpp: (WebCore::Editor::command): Return the empty command if the command name is empty.

WebKit/win:

Reviewed by Darin Adler.

revert my earlier crash fix after making WebCore return the empty editor command for the empty command name.

WebView.cpp: (WebView::handleEditingKeyboardEvent):

8:57 AM Changeset in webkit [28652] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16410
Implement isKeypadEvent() on Windows

Test: platform/win/fast/events/keyLocation-numpad.html

platform/win/KeyEventWin.cpp: (WebCore::isKeypadEvent): Added. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Also fixed a mistake with autorepeat.

8:27 AM Changeset in webkit [28651] by alp@webkit.org

2 edits in trunk

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16302
[GTK] Compiler flags for optimization

Use the compiler flags -fno-exceptions -fno-rtti.

This patch does not add all the flags discussed in the bug report,
only these two.

WebKit.pri:

8:25 AM Changeset in webkit [28650] by ap@webkit.org

1 edit in trunk/LayoutTests/platform/win/fast/events/alt-numpad.html

Remove an incorrect svn:executable property.

8:24 AM Changeset in webkit [28649] by mrowe@apple.com

4 edits in trunk/WebKit

Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.

Reviewed by Dave Kilzer.

8:14 AM Changeset in webkit [28648] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=15576
[GTK] Printing support

Add printing support.

The API will be kept internal for the time being, but printing can now
be triggered by Web pages or the JSC API using JavaScript.

The print spooler and pagination code is fairly abstract and could be
shared by other ports including Win and Qt once complete. It doesn't
have header/footer support yet.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
WebView/webkitprivate.h:
WebView/webkitwebframe.cpp: (PrintContext::begin_print): (PrintContext::draw_page): (PrintContext::end_print): (PrintContext::webkit_web_frame_print):

3:33 AM Changeset in webkit [28647] by ap@webkit.org

1 edit
2 adds in trunk/LayoutTests

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=15248
Can not enter accented characters using alt-numeric keypad

platform/win/fast/events/alt-numpad-expected.txt: Added.
platform/win/fast/events/alt-numpad.html: Added.

2:57 AM Changeset in webkit [28646] by oliver@apple.com

6 edits
2 adds in trunk

<rdar://problem/5071781> window.mouseout events are not sent to window when mouse moves out of window

Reviewed by Maciej.

Hook up the windows mouse tracking logic to allow us to detect the mouse leaving the window.

12:41 AM Changeset in webkit [28645] by weinig@apple.com

4 edits in trunk/WebKit

WebKit/gtk:

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didChangeTitle):

WebKit/qt:

Build fix.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent):

12:40 AM Changeset in webkit [28644] by weinig@apple.com

2 edits in trunk/WebCore

Fix Mac release build.

WebCore.base.exp:

12:13 AM Changeset in webkit [28643] by weinig@apple.com

17 edits in trunk

WebCore:

Build fix for Qt, Gtk, and Wx.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::urlSelected):
platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): (WebCore::ResourceHandleManager::startJob):
platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeURL):

WebKit/gtk:

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/qt:

Build fix.

Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init):
Api/qwebpage.cpp: (QWebPage::url): (QWebPageContext::QWebPageContext):
Api/qwebpagehistory.cpp: (QWebHistoryItem::originalUrl): (QWebHistoryItem::currentUrl):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::cannotShowURLError): (WebCore::FrameLoaderClientQt::interruptForPolicyChangeError): (WebCore::FrameLoaderClientQt::cannotShowMIMETypeError): (WebCore::FrameLoaderClientQt::fileDoesNotExistError): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::createPlugin):

WebKit/wx:

Build fix.

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::createWindow):
WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWx::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientWx::postProgressFinishedNotification): (WebCore::FrameLoaderClientWx::didChangeTitle): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

12:07 AM Changeset in webkit [28642] by mitz@apple.com

2 edits in trunk/WebKit/win

Reviewed by Alexey Proskuryakov.

fix a crash when pressing a key that is not associated with a command

WebView.cpp: (WebView::handleEditingKeyboardEvent): Check if the result of interpretKeyEvent() is empty.

12:00 AM Changeset in webkit [28641] by mitz@apple.com

6 edits in trunk

WebCore:

Reviewed by Maciej Stachowiak.

allow non-integer font sizes on Windows for small caps

platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::smallCapsFontData):
platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize):
platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

Reviewed by Maciej Stachowiak.

removed now-passing tests

platform/win/Skipped:

Dec 11, 2007:

11:44 PM Changeset in webkit [28640] by weinig@apple.com

5 edits in trunk/WebCore

Build fix for Qt, Gtk, and Wx.

platform/gtk/CookieJarGtk.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeURL):

11:26 PM Changeset in webkit [28639] by weinig@apple.com

86 edits in trunk

WebCore:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

Renames Document::URL() -> Document::url()
Renames DocumentLoader::URL() -> DocumentLoader::url()
Renames KURL::url() to KURL::string() and KURL::deprecatedString()
Remove FrameLoader::URL()
Various variable renames.

The change from Document::URL() to Document::url() required changes
to the bindings scripts as well, because URL() is the name of a DOM
method. The code generation scripts now have code to special case URL()
to url().

WebCore.base.exp:
bindings/js/kjs_events.cpp: (WebCore::JSLazyEventListener::parseCode):
bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorCOM.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createImportRule):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL):
dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::getImageMap): (WebCore::Document::completeURL):
dom/Document.h: (WebCore::Document::url): (WebCore::Document::baseURL):
dom/Element.cpp: (WebCore::Element::baseURI):
dom/ProcessingInstruction.h:
dom/StyledElement.cpp: (WebCore::StyledElement::addCSSImageProperty):
dom/StyledElement.h:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::end): (WebCore::):
dom/XMLTokenizer.h:
editing/Editor.cpp: (WebCore::Editor::copy):
editing/markup.cpp: (WebCore::completeURLs):
history/CachedPage.h: (WebCore::CachedPage::url):
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::isCurrentDocument):
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::evaluateScript):
html/HTMLScriptElement.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
loader/CachedResource.h: (WebCore::CachedResource::):
loader/CachedScript.h:
loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestResource):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::url): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::startLoadingMainResource):
loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::shouldHideReferrer): (WebCore::FrameLoader::shouldAllowNavigation): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
loader/FrameLoader.h: (WebCore::FrameLoader::url):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
loader/MainResourceLoader.cpp: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::didFinishLoading):
loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction):
loader/NavigationAction.h: (WebCore::NavigationAction::url):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
loader/mac/LoaderNSURLExtras.m: (urlOriginalData):
page/Chrome.cpp: (WebCore::Chrome::setToolTip):
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
page/Frame.cpp: (WebCore::Frame::setUserStyleSheetLocation):
page/InspectorController.cpp: (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::didCommitLoad):
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]):
platform/KURL.h: (WebCore::KURL::string): (WebCore::KURL::deprecatedString):
platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::plainText):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed):
platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::isNull):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start):
platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::urlToMarkup):
platform/win/ClipboardWin.cpp: (WebCore::writeURL): (WebCore::writeImageToDataObject): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL):
plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::findPlugin):
plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream):
plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): (WebCore::PluginViewWin::performRequest):
svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode):

WebKit/mac:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
WebView/WebDataSource.mm: (-[WebDataSource _URL]):
WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

WebKit/win:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

WebFrame.cpp: (WebFrame::url): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::setTitle): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::cancelledError): (WebFrame::blockedError): (WebFrame::interruptForPolicyChangeError): (WebFrame::createPlugin):
WebView.cpp: (WebView::notifyDidAddIcon):

9:04 PM Changeset in webkit [28638] by mitz@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Mark Rowe and Sam Weinig too!

added Helvetica Oblique and Helvetica Bold Oblique to the list of fonts DumpRenderTree registers.

DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

LayoutTests:

Reviewed by Mark Rowe and Sam Weinig too!

removed tests that pass when Helvetica Oblique and Helvetica Bold Oblique are available.

platform/win/Skipped:

7:23 PM Changeset in webkit [28637] by Beth Dakin

13 edits
30 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

CachedImage now has a setImageContainerSize function. It is only
needed for SVG right now.

loader/CachedImage.cpp: (WebCore::CachedImage::setImageContainerSize):
loader/CachedImage.h:

Relatively sized SVGs have no intrinsic size. Because this call is
low-level enough that we cannot pass in the container size and get
the real size of the SVG, we need to know if it has relative
dimensions, and if so, we need to get the size from scaledTileSize.

platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
platform/graphics/Image.h: (WebCore::Image::setContainerSize): (WebCore::Image::hasRelativeWidth): (WebCore::Image::hasRelativeHeight):

Re-factored calculateBackgroundSize a bit so that it returns an
IntSize. Made it a member function so that it can send m_width and
m_height along to setImageContainerSize.

rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::calculateBackgroundImageGeometry):
rendering/RenderBox.h:

Need to account for relatively sized SVGs in calcViewport()

rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):

Added new member variables to store the size of the SVG container.
relativeWidthValue() and relativeHeightValue() use the stored SVG
container size to correctly calculate the width and height of a
relatively sized SVG.

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::relativeWidthValue): (WebCore::SVGSVGElement::relativeHeightValue):
svg/SVGSVGElement.h: (WebCore::SVGSVGElement::containerSize):

Re-factored size calculations to use the size of the container.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight):
svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

fast/backgrounds/resources/balloon.svg: Added.
fast/backgrounds/resources/eyes.svg: Added.
fast/backgrounds/resources/hearts.svg: Added.
fast/backgrounds/resources/linguistics.svg: Added.
fast/backgrounds/resources/map.svg: Added.
fast/backgrounds/resources/mouse-repel.svg: Added.
fast/backgrounds/svg-as-background-1.html: Added.
fast/backgrounds/svg-as-background-2.html: Added.
fast/backgrounds/svg-as-background-3.html: Added.
fast/backgrounds/svg-as-background-4.html: Added.
fast/backgrounds/svg-as-background-5.html: Added.
fast/backgrounds/svg-as-background-6.html: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.

5:32 PM Changeset in webkit [28636] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Build fix: Note some variables that are used only for ASSERTs.

API/testapi.c: (Base_finalize): (globalObject_initialize): (testInitializeFinalize):

4:30 PM Changeset in webkit [28635] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed: All JS tests crash on Windows.

NDEBUG wasn't defined when compiling testkjs in release builds, so the
HashTable definition in HashTable.h included an extra data member.

The solution was to add NDEBUG to the release testkjs configuration on
Windows and Mac.

For giggles, I also added other missing #defines to testkjs on Windows.

Configurations/Base.xcconfig:
Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/testkjs.cpp: (main):

4:05 PM Changeset in webkit [28634] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-11 George Wright <george.wright@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14120
[GDK] Support input methods

This patch adds infrastructure for input method support.

It also adds Hildon features for the Maemo mobile platform sufficient
to support the virtual keyboard.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing):
WebCoreSupport/EditorClientGtk.h:
WebView/webkitprivate.h:
WebView/webkitwebview.cpp:

3:05 PM Changeset in webkit [28633] by andersca@apple.com

4 edits in trunk/WebKit/win

Reviewed by Darin.

<rdar://problem/5636865>
WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)

Interfaces/IWebView.idl:
WebView.cpp: (WebView::registerURLSchemeAsLocal):
WebView.h:

2:39 PM Changeset in webkit [28632] by adachan@apple.com

3 edits in trunk/WebKit/win

Updated the database SPI to take in IWebFrame.

Reviewed by Adam.

Interfaces/IWebUIDelegatePrivate.idl:
WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

2:33 PM Changeset in webkit [28631] by Darin Adler

2 edits in trunk/WebCore

editing/Editor.cpp: (WebCore::Editor::yankFromKillRing): Try to fix non-Mac builds by adding a missing return statement.

1:35 PM Changeset in webkit [28630] by ap@webkit.org

2 edits in trunk/WebKit/win

Windows build fix.

WebView.cpp: (WebView::interpretKeyEvent):

1:16 PM Changeset in webkit [28629] by Nikolas Zimmermann

1 edit
3 adds in trunk/LayoutTests

Rubberstamped by Mark.
Add missing tests - their results have already been checked in over a month ago - I forgot to commit the tests itself.

1:14 PM Changeset in webkit [28628] by Nikolas Zimmermann

53 edits in trunk/LayoutTests

Rubberstamped by Mark.
Update pixel test results now that filters are disabled.

1:02 PM Changeset in webkit [28627] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed bogus ASSERT.

ASSERT should only be used when we know that a code path will not be
taken. This code path is taken often during the jsFunFuzz test.

pcre/pcre_exec.cpp: (jsRegExpExecute):

12:26 PM Changeset in webkit [28626] by Darin Adler

32 edits
1 copy
2 deletes in trunk

WebCore:

Reviewed by Geoff.

exposed many new commands to the DOM Document executeCommand function by merging the JSEditor and Editor executeCommand implementations
replaced the execCommand function with a EditorCommand class
replaced the WTF::StrHash<> class template with the WebCore::StringHash class
replaced the WTF::CaseInsensitiveHash<> class template with the WebCore::CaseFoldingHash class

WebCore.base.exp: Updated.
WebCore.pro: Added EditorCommand.cpp, removed JSEditor.cpp.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.

dom/Document.cpp: (WebCore::Document::Document): Removed code to set up m_jsEditor. (WebCore::Document::~Document): Removed code to delete m_jsEditor. (WebCore::command): Added. Helper function that gets an Editor::Command. (WebCore::Document::executeCommand): Changed to use Editor::Command instead of JSEditor. (WebCore::Document::queryCommandEnabled): Ditto. (WebCore::Document::queryCommandIndeterm): (WebCore::Document::queryCommandState): Ditto. (WebCore::Document::queryCommandSupported): Ditto. (WebCore::Document::queryCommandValue): Ditto.

dom/Document.h: Removed JSEditor, jsEditor, m_jsEditor. Changed to use CaseFoldingHash.

editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Renamed from selectionForEvent and made into a member function so it is accessible from the new EditorCommand.cpp file. Also changed to get the selection from the passed-in frame instead of from the page, because this should work on the targeted frame unless the event overrides it. (WebCore::Editor::handleKeypress): Updated for selectionForCommand change. (WebCore::Editor::handleInputMethodKeypress): Ditto. (WebCore::imageElementFromImageDocument): Renamed and changed to return a HTMLImageElement instead of a Node*. (WebCore::Editor::canCopy): Updated for name change. (WebCore::Editor::selectionUnorderedListState): Updated for TriState change. (WebCore::Editor::selectionOrderedListState): Ditto. (WebCore::Editor::selectionStartHasStyle): Make type of local more specific. (WebCore::updateState): Moved here from Frame. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::Editor): Initialize m_shouldStartNewKillRingSequence. (WebCore::Editor::insertTextWithoutSendingTextEvent): Updated for selectionForCommand change. (WebCore::Editor::copy): Updated for imageElementFromImageDocument change. (WebCore::Editor::toggleBold): Call the ToggleBold command via the command machinery since it's no longer in this file as a local function. (WebCore::Editor::toggleUnderline): Call the ToggleUnderline command. (WebCore::Editor::setBaseWritingDirection): Change type of argument and of local variable. (WebCore::Editor::addToKillRing): Moved here from EditorMac. Not useful without a kill ring, but it's relatively straightforward to implement one. (WebCore::Editor::appendToKillRing): Put default implementation here for platforms other than Mac. We should probably put a simple kill ring implementation here -- doesn't need to be shared with the OS oh platforms other than Mac. (WebCore::Editor::prependToKillRing): Ditto. (WebCore::Editor::yankFromKillRing): Ditto. (WebCore::Editor::startNewKillRingSequence): Ditto. (WebCore::Editor::setKillRingToYankedState): Ditto.

editing/Editor.h: Moved the TriState enum here instead of inside the Frame class. Added EditorCommandSource enum. Moved selectionHasStyle here from the Frame class. Added Editor::Command class with five functions for the various things you can do with a command (execute it, check if it can be used, and its state and value). Changed hte parameter of setBaseWritingDirection to be a const String& rather than a String. Got rid of the kill-ring-related operations, but added the kill ring functions themselves. Made selectedRange() public. Made the m_startNewKillRingSequence not Mac-specific and added "should" to its name.

editing/EditorCommand.cpp: Copied from WebCore/editing/Editor.cpp. Retained only the editing commands. (WebCore::targetFrame): Moved to the top of the file. (WebCore::executeApplyStyle): Added. Helper function for commands that need to apply styles. (WebCore::executeToggleStyle): Added. Helper function for commands that need to toggle styles based on the style of the start of selection. (WebCore::executeApplyParagraphStyle): Added. Like executeApplyStyle, but for paragraph styles. (WebCore::executeInsertFragment): Added. Helper function for commands that need to insert a DOM fragment. (WebCore::executeInsertNode): Added. Helper function for commands that need to insert a tree rooted in a single DOM node. (WebCore::stateStyle): Added. Helper function for the state of commands that represent style. (WebCore::valueStyle): Added. Helper function for the value of commands that represent style. (WebCore::canScroll): Added. Helper functions for some move and scroll commands that need to determine if the renderer they are in can scroll. (WebCore::unionDOMRanges): Moved here from EditorMac. (WebCore::executeBackColor): (WebCore::executeBackwardDelete): (WebCore::executeCopy): (WebCore::executeCreateLink): (WebCore::executeCut): (WebCore::executeDelete): (WebCore::executeDeleteToMark): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeFindString): (WebCore::executeFontName): (WebCore::executeFontSize): (WebCore::executeFontSizeDelta): (WebCore::executeForeColor): (WebCore::executeFormatBlock): (WebCore::executeForwardDelete): (WebCore::executeIndent): (WebCore::executeInsertBacktab): (WebCore::executeInsertHorizontalRule): (WebCore::executeInsertHTML): (WebCore::executeInsertImage): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertNewlineInQuotedContent): (WebCore::executeInsertOrderedList): (WebCore::executeInsertParagraph): (WebCore::executeInsertTab): (WebCore::executeInsertText): (WebCore::executeInsertUnorderedList): (WebCore::executeJustifyCenter): (WebCore::executeJustifyFull): (WebCore::executeJustifyLeft): (WebCore::executeJustifyRight): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveDownByPageAndModifyCaret): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveUpByPageAndModifyCaret): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeOutdent): (WebCore::executePaste): (WebCore::executePasteAndMatchStyle): (WebCore::executePrint): (WebCore::executeRedo): (WebCore::executeRemoveFormat): (WebCore::executeSelectAll): (WebCore::executeSelectToMark): (WebCore::executeSetMark): (WebCore::executeStrikethrough): (WebCore::executeSubscript): (WebCore::executeSuperscript): (WebCore::executeSwapWithMark): (WebCore::executeToggleBold): (WebCore::executeToggleItalic): (WebCore::executeTranspose): (WebCore::executeUnderline): (WebCore::executeUndo): (WebCore::executeUnlink): (WebCore::executeUnscript): (WebCore::executeUnselect): (WebCore::executeYank): (WebCore::executeYankAndSelect): (WebCore::supported): (WebCore::supportedPaste): (WebCore::enabled): (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut): (WebCore::enabledInEditableText): (WebCore::enabledInRichlyEditableText): (WebCore::enabledPaste): (WebCore::enabledRangeInEditableText): (WebCore::enabledRangeInRichlyEditableText): (WebCore::enabledRedo): (WebCore::enabledUndo): (WebCore::stateNone): (WebCore::stateBold): (WebCore::stateItalic): (WebCore::stateOrderedList): (WebCore::stateStrikethrough): (WebCore::stateSubscript): (WebCore::stateSuperscript): (WebCore::stateUnderline): (WebCore::stateUnorderedList): (WebCore::valueNull): (WebCore::valueBackColor): (WebCore::valueFontName): (WebCore::valueFontSize): (WebCore::valueFontSizeDelta): (WebCore::valueForeColor): (WebCore::createCommandMap): Added lots of commands, including all the commands from JSEditor. A few commands needed different behavior based on whether they are invoked from the DOM or a keyboard binding. (WebCore::Editor::command): Added. Gets a command object given a name. (WebCore::Editor::Command::Command): Added. (WebCore::Editor::Command::execute): Added. (WebCore::Editor::Command::isSupported): Added. (WebCore::Editor::Command::isEnabled): Added. (WebCore::Editor::Command::state): Added. (WebCore::Editor::Command::value): Added. (WebCore::Editor::execCommand): Changed to call command().execute().

editing/JSEditor.cpp: Removed.
editing/JSEditor.h: Removed.

editing/mac/EditorMac.mm: Changed to provide kill ring primitives intead of kill ring commands, so the kill ring commands can be cross-platform. (WebCore::Editor::appendToKillRing): Added. (WebCore::Editor::prependToKillRing): Added. (WebCore::Editor::yankFromKillRing): Added. (WebCore::Editor::startNewKillRingSequence): Added. (WebCore::Editor::setKillRingToYankedState): Added.

page/Frame.cpp: Removed selectionHasStyle, TriState, and updateState.
page/Frame.h: Ditto.

page/mac/WebCoreFrameBridge.mm: Removed selectionHasStyle.
page/mac/WebCoreFrameBridge.h: Ditto.

platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for TriState change.

platform/text/StringHash.h: (WebCore::StringHash::hash): Merged the StrHash<> template classes into this. (WebCore::StringHash::equal): Ditto. (WebCore::CaseFoldingHash::hash): Merged the CaseInsensitiveHash<> template classes into this. (WebCore::CaseFoldingHash::equal): Ditto.

platform/text/StringImpl.cpp: (WebCore::equal): Changed to invoke StringHash. (WebCore::equalIgnoringCase): Changed to invoke CaseFoldingHash.

dom/DOMImplementation.cpp: (WebCore::addString): Updated to use StringHash and CaseFoldingHash. (WebCore::isSVG10Feature): Ditto. (WebCore::isSVG11Feature): Ditto.
loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto.
platform/graphics/FontCache.cpp: (WebCore::computeHash): Ditto.
platform/network/HTTPHeaderMap.h: Ditto.
platform/text/PlatformString.h: Ditto.
platform/text/StringImpl.h: Ditto.
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Ditto.

rendering/RenderTreeAsText.cpp: Removed stray include of JSEditor.h.

WebKit/mac:

Reviewed by Geoff.

change more editing commands to use WebCore::Editor
change to use the new WebCore::Editor::command() function

WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft, alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor, insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark, subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect to use the "forward to WebCore" macro instead of having hand-written implementations. (kit): Added function to change a TriState to an AppKit-style tri-state value. (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the first character or copies the selector name, since the Editor commands are not case sensitive any more. Returns a command object. (-[WebHTMLView coreCommandByName:]): Added. (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:, and changed to use the new coreCommandBySelector: method. (-[WebHTMLView executeCoreCommandByName:]): Added. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the methods that call through to WebCore to also use the state() and isEnabled() functions on the commands for the menu item state and user interface item enabling. (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by name rather than having local methods for them; no need for methods with a single call site. (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather than the deprecated execCommand(). (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather than the deprecated execCommand().
WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.

WebKit/win:

WebView.cpp: (WebView::handleEditingKeyboardEvent): Update for change to Editor API.

12:24 PM Changeset in webkit [28625] by Darin Adler

2 edits in trunk/WebCore

platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Another try at fixing the WX build. Changes the code around a little bit.

12:00 PM Changeset in webkit [28624] by beidson@apple.com

2 edits in trunk/WebKitTools

Reviewed by Anders

Make DumpRenderTree on mac use its own path for Databases testing

DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree for future DRT-only use, then use it to construct the Databases path and set that default

11:57 AM Changeset in webkit [28623] by Darin Adler

2 edits in trunk/WebCore

platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Quick try at fixing build.

11:54 AM Changeset in webkit [28622] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/unicode/qt4/UnicodeQt4.h: Try to fix Qt build by adding U16_IS_SINGLE.

11:36 AM Changeset in webkit [28621] by mitz@apple.com

6 edits
9 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

Test: fast/text/international/complex-character-based-fallback.html

platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter): Added a forceSmallCaps argument that forces this function to use the small caps font. It is used for combining marks that need to combine with a small cap.
platform/graphics/Font.h:
platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): Changed to split the string into runs of characters that will be rendered using the same FontData. This is done by calling glyphDataForCharacter() for each cahracter to find the FontData it should be rendered with. (WebCore::UniscribeController::itemizeShapeAndPlace): Added a fontData argument that is passed on to shapeAndPlaceItem() instead of the smallCaps argument. (WebCore::UniscribeController::shapeAndPlaceItem): Added a fontData argument and removed the font fallback logic from this function, as it is now expected to be called with an item all of whose characters can be rendered with the given fontData.
platform/win/UniscribeController.h:

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

fast/text/international/complex-character-based-fallback.html: Added.
platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/mac/fast/text/international/complex-character-based-fallback-expected.txt: Added.
platform/win/fast/text: Added.
platform/win/fast/text/international: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Added.

11:11 AM Changeset in webkit [28620] by ap@webkit.org

75 edits
7 adds in trunk

Reviewed by Darin.

<rdar://problem/5535636>
Have to press 4 times instead of 2 times to get the expected result of with german keyboard.

http://bugs.webkit.org/show_bug.cgi?id=13916
JavaScript detects Tab as a character input on a textfield validation

11:08 AM Changeset in webkit [28619] by sfalken@apple.com

1 copy in tags/Safari-523.13b

New tag.

11:08 AM Changeset in webkit [28618] by sfalken@apple.com

2 edits in branches/Safari-3-branch/WebKit/win

Bump versions for submit

11:06 AM Changeset in webkit [28617] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/PRODUCTVERSION

Versioning.

11:06 AM Changeset in webkit [28616] by sullivan@apple.com

2 edits in trunk/WebCore

Reviewed by Adele

Tiger build fix -- don't call QTMovieView setDelegate: directly because it's not public

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::detachQTMovieView):

10:46 AM Changeset in webkit [28615] by kmccullough@apple.com

3 edits in trunk/WebKitTools

Reviewed by Oliver.

<rdar://5599845> Drosera: Does not show loal files in the file list on the left side.

Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings so the open source community can build.

9:30 AM Changeset in webkit [28614] by ap@webkit.org

2 edits
1 delete in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work

Fix this on Windows, too!

Test: http/tests/misc/empty-cookie.html

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Same fix as on Mac, translated into CF.

platform/win/CookieJarWin.cpp: Removed - the real one is in platform/network/win.

5:22 AM Changeset in webkit [28613] by alp@webkit.org

2 edits
1 add in trunk/WebCore

2007-12-11 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16371
Implement additional mouse cursors for Gtk

Added cursor bitmaps from Mozilla:
http://lxr.mozilla.org/mozilla1.8/source/widget/src/gtk2/nsGtkCursors.h

platform/gtk/CursorGtk.cpp: (WebCore::customCursorNew): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
platform/gtk/CursorGtk.h: Added.

2:21 AM QtWebKitTodo edited by lars@webkit.org

(diff)

12:43 AM Changeset in webkit [28612] by oliver@apple.com

3 edits
3 adds in trunk

Fix character set used for dynamically loaded scripts.

Reviewed by Weinig, Dan and Alexey.

Fix for:

<rdar://problem/5333163> Safari can not display the mouse over pop menu on ChinaTimes News site correctly.
<rdar://problem/5530048> [Safari]? :Leopard9A576: The typed CH characters displays as garbage in Sina website after reloading the webpage.
<rdar://problem/5416588> All menus for chinese IBM site have wrong encoding

Use the same logic to determine the charset for a script loaded dynamically
as we do for a statically loaded script.

Dec 10, 2007:

11:43 PM Changeset in webkit [28611] by justin.garcia@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5482023> GoogleDocs: After FormatBlock in an empty document, certain functions are disabled

We were trying to insert a block of the requested type before the body element.

editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Removed unnecessary ()s in the if condition.

Removed "

!upstreamStart.node()->isDescendantOf(root)" from the if condition, since

a) upstreamStart will never be outside the root editable element, since in that case
there would be no block inside the editable root to Format, and b) if upstreamStart.node()
*is* the root, then refNode is the root, and we shouldn't insert before the root, we should insert
at [root, 0].
Added comments to explain the use of upstream() in the second if-clause.
Added an early return for case where there is nothing selected, in that case, there is nothing
to move.

LayoutTests:

Reviewed by Oliver Hunt.

<rdar://problem/5482023> GoogleDocs: After performing FormatBlock in an empty document, certain functions are disabled

editing/execCommand/5482023.html: Added.
platform/mac/editing/execCommand/5482023-expected.checksum: Added.
platform/mac/editing/execCommand/5482023-expected.png: Added.
platform/mac/editing/execCommand/5482023-expected.txt: Added.

11:24 PM Changeset in webkit [28610] by adele@apple.com

7 edits in trunk/WebCore

Reviewed and partially fixed by Tim Hatcher.

Remaining part of fix for <rdar://problem/5633400>
Transformed <video> is not clipped correctly until a repaint is forced

Replace the implementation of a QTKit method to avoid repaints from the NSView system associated with the QTMovie
from clobbering the WebCore repaints.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRepaint): Added.
html/HTMLMediaElement.h:
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::repaint): Added.
platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): Added.

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (method_setImplementation): Added for Tiger.

(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call detachQTMovieView, which now does more cleanup.
(WebCore::MediaPlayerPrivate::cancelLoad): ditto.
(WebCore::MediaPlayerPrivate::setVisible): ditto.
(WebCore::MediaPlayerPrivate::detachQTMovieView): Clear the delegate as well as m_qtMovieView pointer.

(WebCore::MediaPlayerPrivate::repaint): Added. Triggers a repaint on the video renderer.
(-[WebCoreMovieObserver repaint]): ditto.

(WebCore::mainThreadSetNeedsDisplay): Added.

Does a WebCore repaint instead of going through the view repaint system for QTMovieView.

(WebCore::MediaPlayerPrivate::createQTMovieView): Replace the implementation of _mainThreadSetNeedsDisplay.

10:08 PM Changeset in webkit [28609] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar

Test: fast/js/regexp-find-first-asserted.html

pcre/pcre_compile.cpp: (compileBracket): Take out unnecessary initialization of out parameters. (branchFindFirstAssertedCharacter): Added. Broke out the half of the function that handles a branch. (bracketFindFirstAssertedCharacter): Renamed from find_firstassertedchar. Also removed the options parameter -- the caller can handle the options. (jsRegExpCompile): Changed call site to call the appropriate bracket or branch version of the find_firstassertedchar function. Also put the REQ_IGNORE_CASE code here instead of passing in the options.

LayoutTests:

Reviewed by Sam Weinig.

test for http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar

fast/js/regexp-find-first-asserted-expected.txt: Added.
fast/js/regexp-find-first-asserted.html: Added.
fast/js/resources/regexp-find-first-asserted.js: Added.

9:47 PM Changeset in webkit [28608] by ggaren@apple.com

13 edits in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Split this:

FunctionBodyNode

^|

ProgramNode

into this:

ScopeNode

^{| | |}

FunctionBodyNode ProgramNode EvalNode

in preparation for specializing each class more while optimizing global
variable access.

Also removed some cruft from the FunctionBodyNode interface to simplify
things.

SunSpider says this patch is a .8% speedup, which seems reasonable,
since it eliminates a few branches and adds KJS_FAST_CALL in a few
places.

Layout tests and JS tests pass. Also, this baby builds on Windows! (Qt
mileage may vary...)

WebCore:

Reviewed by Sam Weinig.

Updated for rename in JavaScriptCore.

bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

WebKit/win:

Reviewed by Sam Weinig.

Updated for rename in JavaScriptCore.

WebScriptCallFrame.cpp: (WebScriptCallFrame::functionName): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

8:55 PM Changeset in webkit [28607] by ddkilzer@apple.com

1 edit in trunk/WebCore/ChangeLog

Add bug reference.

8:50 PM Changeset in webkit [28606] by ddkilzer@apple.com

2 edits in trunk/WebCore

Use KJS::Window not the ambiguous Window

Reviewed by ddkilzer.

bindings/js/kjs_dom.cpp (checkNodeSecurity):

7:09 PM Changeset in webkit [28605] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

RS by Mark Rowe.

Mac build fix: added some exported symbols, now that Parser::parse is
defined in the header.

JavaScriptCore.exp:

6:37 PM Changeset in webkit [28604] by weinig@apple.com

4 edits in trunk/JavaScriptCore

Build fix.

Template methods need to be in the header.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/Parser.cpp:
kjs/Parser.h: (KJS::Parser::parse):

6:26 PM Changeset in webkit [28603] by beidson@apple.com

2 edits in trunk/WebKitTools

Rubberstamped by Sam Weinig

Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]): (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):

5:54 PM Changeset in webkit [28602] by mrowe@apple.com

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/WebKit

Tag for WebKit for Mac OS X Update 10.4.11 (WebKit-4523.12)

5:54 PM Changeset in webkit [28601] by mrowe@apple.com

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/WebCore

Tag for WebCore for Mac OS X Update 10.4.11 (WebCore-4523.12)

5:54 PM Changeset in webkit [28600] by mrowe@apple.com

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/JavaScriptGlue

Tag for JavaScriptGlue for Mac OS X Update 10.4.11 (JavaScriptGlue-4523.12)

5:53 PM Changeset in webkit [28599] by mrowe@apple.com

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/JavaScriptCore

Tag for JavaScriptCore for Mac OS X Update 10.4.11 (JavaScriptCore-4523.12)

5:49 PM Changeset in webkit [28598] by mrowe@apple.com

1 add in releases/Apple/Tiger/Mac OS X Update 10.4.11

New release tag.

5:22 PM Changeset in webkit [28597] by beidson@apple.com

5 edits in trunk/WebKit/mac

Reviewed by John Sullivan

Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame

This is because a common UI case is to want to know the originating URL of a Database

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

WebView/WebUIDelegatePrivate.h:

WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): (CallUIDelegateReturningUnsignedLongLong):
WebView/WebViewInternal.h:

5:09 PM Changeset in webkit [28596] by Antti Koivisto

8 edits in trunk/LayoutTests

Reviewed by Adele.

The load events could fire before the event listener was registered making these tests fail occasionally.

No changes to test results.

media/video-source-media.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-remove.html:
media/video-src-source.html:
media/video-src.html:
media/video-test.js:

4:35 PM Changeset in webkit [28595] by ggaren@apple.com

8 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Merged different implementations of Parser::parse into a single,
templatized implementation, in preparation for adding yet another
implementation for "eval" code.

JS and layout tests pass.

4:03 PM Changeset in webkit [28594] by weinig@apple.com

2 edits in trunk/WebCore

Fix non-mac builds.

page/WindowFeatures.cpp: #include <wtf/MathExtras.h> for isnan.

3:51 PM Changeset in webkit [28593] by andrew@webkit.org

2 edits in trunk/WebCore

2007-09-05 Marvin Decker <marv.decker@gmail.com>

Reviewed by Darin.

Fix a divide by 0 in the progress tracker.
http://bugs.webkit.org/show_bug.cgi?id=15055

loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):

3:32 PM Changeset in webkit [28592] by weinig@apple.com

6 edits
1 move
1 add in trunk/WebCore

Reviewed by Darin.

More cleanup of kjs_window.

Move WindowFeatures from bridge/ to page/
Move functions related to WindowFeatures (boolFeature, floatFeature, setWindowFeature, parseWindowFeatures) into the class.
Fix up whitespace.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::~DOMWindowTimer): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::getOwnPropertySlot): (KJS::Window::allowsAccessFrom): (KJS::Window::shouldInterruptScript): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::Window::setReturnValueSlot): (KJS::ScheduledAction::execute): (KJS::Window::timerFired): (KJS::Location::Location): (KJS::Location::getValueProperty): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): Use better variable names. (KJS::LocationProtoFuncAssign::callAsFunction): Ditto. (KJS::LocationProtoFuncToString::callAsFunction): Remove extraneous calls to allowsAccessFrom, cleanup the function a little. (KJS::PausedTimeouts::~PausedTimeouts):
bridge/WindowFeatures.h: Removed.
page/WindowFeatures.cpp: Added. (WebCore::isSeparator): (WebCore::WindowFeatures::WindowFeatures): (WebCore::WindowFeatures::setWindowFeature): (WebCore::WindowFeatures::boolFeature): (WebCore::WindowFeatures::floatFeature):
page/WindowFeatures.h: Copied from WebCore/bridge/WindowFeatures.h. (WebCore::WindowFeatures::WindowFeatures):

3:06 PM Changeset in webkit [28591] by timothy@apple.com

8 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

JavaScriptGlue:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

WebCore:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

WebKit/mac:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

3:02 PM Changeset in webkit [28590] by Stephanie Lewis

2 edits in trunk/LayoutTests

Check in correct results

svg/custom/resource-client-removal-expected.txt:

12:39 PM Changeset in webkit [28589] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-10 Alp Toker <alp@atoker.com>

Reviewed by Niko.

Cairo implementation of GraphicsContext::setUseAntialiasing().

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setUseAntialiasing):

12:14 PM Changeset in webkit [28588] by rwlbuis@webkit.org

8 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16182
SVG should disable antialiasing for shape-rendering="crispEdges"

Turn off anti-aliasing of shapes when shape-rendering="crispEdges".

12:03 PM Changeset in webkit [28587] by rwlbuis@webkit.org

3 edits
4 adds in trunk

Reviewed by Niko.

http://bugs.webkit.org/show_bug.cgi?id=16163
SVG crash in Node::setChanged() on Debug builds only (trashed parent)

Fix the crash by properly unregistering as client from SVGResource
when deleting a styled svg node.

11:38 AM Changeset in webkit [28586] by beidson@apple.com

2 edits in trunk/WebCore

Rubberstamped by John

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): If the UI Delegate returns *exactly* the estimated size for the new quota, we should allow the database to be created

10:47 AM Changeset in webkit [28585] by kdecker@apple.com

2 edits
2 adds in trunk

Reviewed by Darin.

Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler

WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.

9:51 AM Changeset in webkit [28584] by ddkilzer@apple.com

6 edits
5 adds in trunk

Bug 9683: Implement select.options.remove() method

WebCore:

Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>

Reviewed by Maciej.

Implement select.options.remove() by calling select.remove()
with the same arguments. This is what MSIE 7 does, although its
select.remove() method differs from WebKit's by throwing an
exception when called with no arguments or with a negative
integer argument. Note that the DOM Level 1 documentation
specifies that select.remove() does not throw an exception.

Tests: fast/js/select-options-remove-gc.html

fast/js/select-options-remove.html

bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): Added.
html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::remove): Added.
html/HTMLOptionsCollection.h:
html/HTMLOptionsCollection.idl:

LayoutTests:

Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>

Reviewed by Maciej.

fast/js/resources/select-options-remove.js: Added.
fast/js/select-options-remove-expected.txt: Added.
fast/js/select-options-remove-gc-expected.txt: Added.
fast/js/select-options-remove-gc.html: Added.
fast/js/select-options-remove.html: Added.

9:16 AM Changeset in webkit [28583] by Adam Roben

2 edits in trunk/WebKit/win

Fix <rdar://5624866> CFStringRef UI_STRING should use a cache and follow the CF "Get" model (current uses leak)

Added a new class, LocalizedString, that wraps a CFStringRef and a
WebCore::String. We store one LocalizedString for each key string.

Reviewed by Steve.

WebLocalizableStrings.cpp: Changed our two HashMaps to map from WebCore::String to LocalizedString*. (LocalizedString::LocalizedString): (LocalizedString::operator CFStringRef): (LocalizedString::operator LPCTSTR): Code moved here from localizedLPCTSTR. (findCachedString): Changed to return a LocalizedString*. (cacheString): Changed to take a LocalizedString*. (localizedString): Changed to return a const LocalizedString&. We first try to find a cached LocalizedString. If there isn't one, we create a new one and cache it. (WebLocalizedLPCTSTRUTF8): Changed to call localizedString. (WebLocalizedLPCTSTR): Ditto.

9:15 AM Changeset in webkit [28582] by Adam Roben

4 edits in trunk/WebKit/win

Make WebLocalizableStrings work a little more like the Mac version

Reviewed by Steve.

WebKit.vcproj/WebKit.def: Deprecated SetWebLocalizedStringMainBundle.
WebKit.vcproj/WebKit_debug.def: Ditto.
WebLocalizableStrings.cpp: (createWebKitBundle): Changed to only create the bundle once. (cfBundleForStringsBundle): Added. Code was factored out of copyLocalizedStringFromBundle. We now use the CFBundleGetMainBundle to get the main bundle and WebLocalizableStringsBundle's identifier to fetch the framework's bundle. (copyLocalizedStringFromBundle): Changed to call cfBundleForStringsBundle. (cacheString): Cleaned up logic a bit with an early return. (SetWebLocalizedStringMainBundle): Moved down with the other deprecated functions and made into a no-op.

5:38 AM Changeset in webkit [28581] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Tiger build fix.

5:15 AM Changeset in webkit [28580] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-12-10 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

fix http://bugs.webkit.org/show_bug.cgi?id=16375 REGRESSION: Safari crashes on quit

Probably a debug-only issue.

kjs/Parser.cpp: (KJS::parser): Create the parser and never destroy it by using a pointer instead of a global object.

4:58 AM QtWebKitTodo edited by Simon Hausmann

(diff)

4:40 AM QtWebKitContrib edited by Simon Hausmann

(diff)

2:46 AM QtWebKitTodo edited by Simon Hausmann

(diff)

2:46 AM QtWebKitTodo edited by Simon Hausmann

(diff)

2:43 AM QtWebKitTodo edited by Simon Hausmann

(diff)

12:55 AM Changeset in webkit [28579] by ap@webkit.org

2 edits in trunk/LayoutTests

Removed fast/events/objc-keyboard-event-creation.html from skipped list, as this test has
been moved to platform/mac long ago.

platform/win/Skipped:

Dec 9, 2007:

10:22 PM Changeset in webkit [28578] by Darin Adler

4 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16369 REGRESSION (r28525): regular expression tests failing due to bad firstByte optimization

pcre/pcre_compile.cpp: Changed some names to use interCaps intead of under_scores. (branchIsAnchored): Broke is_anchored into two separate functions; this one works on a branch and the other on an anchor. The old function would only work on a bracket. Also removed unneeded parameters; the anchored check does not require the bracket map or the options any more because we have a reduced set of features. (bracketIsAnchored): Ditto. (branchNeedsLineStart): Broke canApplyFirstCharOptimization into two functions and gave both a better name. This is the function that was returning the wrong value. The failure was beacuse the old function would only work on a bracket. (bracketNeedsLineStart): Ditto. (jsRegExpCompile): Changed to call the appropriate branch or bracket flavor of the functions based on whether we compiled an outer bracket. Also removed inaccurate comments and unneeded parameters.

other small changes

pcre/pcre.h: Renumbered error codes, in a logical order. First, normal failure, then the recursion limit, then running out of memory, and finally an unexpected internal error.

pcre/pcre_exec.cpp: Fixed indentation. (jsRegExpExecute): Corrected an inaccurate comment.

8:05 PM Changeset in webkit [28577] by Darin Adler

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=16370 REGRESSION (r28540): source URL and line number no longer set for outer function/programs

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/exception-linenums.html

By the time the ProgramNode was constructed, the source URL was empty.

kjs/Parser.cpp: (KJS::Parser::parseProgram): Added code to set and clear m_sourceURL, which is now handled here instead of in the lexer; it needs to still be set when we create the program node. Call setLoc to set the first and last line number. (KJS::Parser::parseFunctionBody): Ditto, but for the body. (KJS::Parser::parse): Removed the sourceURL argument.

kjs/Parser.h: Added sourceURL(), m_sourceURL, and m_lastLine. Added a lastLine parameter to didFinishParsing, since the bison grammar knows the last line number and we otherwise do not know it. Removed the sourceURL parameter from parse, since that's now handled at a higher level.

kjs/grammar.y: Pass the last line number to didFinishParsing.

kjs/lexer.cpp: (KJS::Lexer::setCode): Removed the sourceURL argument and the code to set m_sourceURL. (KJS::Lexer::clear): Ditto.
kjs/lexer.h: More of the same.

kjs/nodes.cpp: (KJS::FunctionBodyNode::FunctionBodyNode): Get the source URL from the parser rather than from the lexer. Removed unneeded call to setLoc, since the line numbers already both default to -1.

7:33 PM Changeset in webkit [28576] by weinig@apple.com

2 edits in trunk/WebCore

Rubber stamped by Mark Rowe.

WebCore.xcodeproj/project.pbxproj: Add missing DerivedSources files.

5:12 PM Changeset in webkit [28575] by oliver@apple.com

4 edits in trunk

Need to read the spec properly.

Reviewed by Niko

Correction, 'z' and 'Z' are the only commands that cannot have an extended
list of arguments.

4:44 PM Changeset in webkit [28574] by oliver@apple.com

5 edits in trunk

Prevent unlimited iteration in the case of invalid path data.

Reviewed by Niko.

The only path commands that can leave numbers trailing the command processing
are 'm' and 'M', in which trailing numbers are parsed as arguments to an
implicit lineto command. In any case we should just terminate as an invalid
path.

1:52 PM Changeset in webkit [28573] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-09 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15825
[GTK] curl - slow dns causing hangs.

Create a vector of jobs, to satisfy requests in the right order.
Set a limit to the number of simultaneous connections.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::maxRunningJobs): added (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::startScheduledJobs):

platform/network/curl/ResourceHandleManager.h: (WebCore::ResourceHandleList): removed (WebCore::ResourceHandleManager::m_runningJobs): added (WebCore::ResourceHandleManager::m_resourceHandleListHead): removed (WebCore::ResourceHandleManager::m_resourceHandleList): added

10:49 AM UsingGitWithWebKit edited by waameukee@schitterendedingen.com

(diff)

Dec 8, 2007:

11:56 PM Changeset in webkit [28572] by weinig@apple.com

3 edits in trunk/WebCore

Reviewed by Oliver.

Cleanup kjs_window.h/cpp.

bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::Window::Window): (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::mark): (KJS::allowPopUp): (KJS::parseModalDialogFeatures): (KJS::floatFeature): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getOwnPropertySlot): (KJS::Window::globalExec): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::findOrCreateJSEventListener): (KJS::Window::findOrCreateJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::setCurrentEvent): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction):
bindings/js/kjs_window.h: (KJS::PausedTimeouts::PausedTimeouts): (KJS::PausedTimeouts::takeTimeouts): (KJS::ScheduledAction::ScheduledAction):

11:48 PM Changeset in webkit [28571] by weinig@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

fast/dom/Window/window-resize-and-move-arguments.html: Make the window small enough that this test won't fail on systems with lower resolutions.

4:47 PM Changeset in webkit [28570] by weinig@apple.com

10 edits
4 adds in trunk

WebCore:

Reviewed by Mitz.

Move window scrolling, moving and resizing methods from KJS::Window
to WebCore::DOMWindow so that there bindings can be autogenerated.

Tests: fast/dom/Window/window-resize-and-move-arguments.html

fast/dom/Window/window-scroll-arguments.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Remove extraneous allowsAccessFrom check. (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): Remove extraneous allowsAccessFrom check.
bindings/js/kjs_window.h:
bindings/scripts/CodeGeneratorJS.pm: Add new extended attribute to ensure that the no less than the declared number of attributes is allowed.
page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Moved from kjs_window. (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo): (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
page/DOMWindow.h: (WebCore::DOMWindow::scroll):
page/DOMWindow.idl:

LayoutTests:

Reviewed by Sam W.

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

These layout test changes are caused by some of the experimental
features no longer being enabled by default.

fast/dom/Window/window-properties-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/mac/svg/custom/empty-merge-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
platform/mac/svg/custom/filter-source-alpha-expected.txt:
platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
platform/mac/svg/custom/invalid-css-expected.txt:
platform/mac/svg/custom/non-opaque-filters-expected.txt:
platform/mac/svg/custom/text-filter-expected.txt:
platform/mac/svg/custom/visibility-override-filter-expected.txt:
svg/batik/filters/filterRegions-expected.txt:
svg/batik/text/textEffect-expected.txt:
svg/batik/text/textEffect3-expected.txt:
svg/batik/text/textFeatures-expected.txt:
svg/batik/text/textProperties-expected.txt:
svg/custom/js-svg-constructors-expected.txt:
svg/dom/font-face-elements-expected.txt:
svg/webarchive/svg-feimage-subresources-expected.txt:

4:32 PM Changeset in webkit [28569] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14651
[CURL] didReceiveResponse() only called for HTTP loads

http://bugs.webkit.org/show_bug.cgi?id=14583
[GDK] file:// relative CSS include URLs handled incorrectly

Make sure CURL sets the ResourceResponse URL and calls
didReceiveResponse for local files too.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback):

4:27 PM Changeset in webkit [28568] by oliver@apple.com

241 edits
2 adds in trunk

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Reviewed by Sam W.

Fixes <rdar://problem/5620249> Must disable SVG animation

<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

In order to allow finer grained control over the set of SVG features
this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
distinct flags:

ENABLE_SVG_ANIMATION
ENABLE_SVG_FILTERS
ENABLE_SVG_FONTS
ENABLE_SVG_AS_IMAGE
ENABLE_SVG_USE

by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.

4:19 PM BuildingGtk edited by andi5.py@gmx.net

apt-get typo (diff)

3:45 PM Changeset in webkit [28567] by mitz@apple.com

4 edits
6 adds in trunk

WebCore:

Reviewed by Adele Peterson.

fix two bugs in parsing of stylesheets in <style> elements created by the parser:
1. each such stylesheet is parsed twice, once when the text node is added and again when the </style> tag is reached
2. re-inserting such a <style> element into the document fails to re-parse and apply its stylesheet.

Test for bug #2: fast/dom/HTMLStyleElement/insert-parser-generated.html

html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishedParsing):
svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishedParsing):

LayoutTests:

Reviewed by Adele Peterson.

test that re-inserting a parser-generated <style> element applies its sylesheet.

fast/dom/HTMLStyleElement: Added.
fast/dom/HTMLStyleElement/insert-parser-generated.html: Added.
platform/mac/fast/dom/HTMLStyleElement: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Added.

1:02 PM Changeset in webkit [28566] by weinig@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

10:03 AM Changeset in webkit [28565] by weinig@apple.com

10 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Rename isSafeScript to allowsAccess.

bindings/NP_jsobject.cpp: (_isSafeScript):
kjs/JSGlobalObject.h: (KJS::JSGlobalObject::allowsAccessFrom): Reverse caller/argument of allowsAccessFrom to match the new call.

WebCore:

Reviewed by Darin.

Removes the faulty isSafeScript implementation that was only used for plugins.
Renames isSafeScript to allowsAccessFrom.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
bindings/js/kjs_window.h: (KJS::Window::allowsAccessFrom):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject _isSafeScript]): Reverse caller/argument of allowsAccessFrom to match the new call.
bindings/scripts/CodeGeneratorJS.pm:

6:39 AM Changeset in webkit [28564] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-08 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16346
[GTK] Some webview parts must use the focused frame.

Also update some old code.

WebView/webkitprivate.cpp: (getFrameFromView): removed

WebView/webkitprivate.h: (getFrameFromView): removed

WebView/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_key_press_event): use focused frame (webkit_web_view_key_release_event): use focused frame (webkit_web_view_button_press_event): (webkit_web_view_button_release_event): (webkit_web_view_motion_event): (webkit_web_view_scroll_event): (webkit_web_view_size_allocate): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_execute_script): (webkit_web_view_stop_loading): (webkit_web_view_load_string): (webkit_web_view_reload): (webkit_web_view_open): (webkit_web_view_can_go_forward): (webkit_web_view_can_go_backward): (webkit_web_view_go_forward): (webkit_web_view_go_backward):

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents

4:27 AM Changeset in webkit [28563] by rwlbuis@webkit.org

4 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15464
SVGLengthList allows bad values

Be more strict with svg lengths without a unit identifier.

Test: svg/custom/invalid-lengthlist.svg

4:11 AM Changeset in webkit [28562] by rwlbuis@webkit.org

2 edits in trunk/WebCore

Mac Tiger build fix.

Use the wtf prefix when including MathExtras.h.

3:35 AM Changeset in webkit [28561] by alp@webkit.org

1 edit in trunk/WebCore/ChangeLog

Remove 'Reviewed by' from build fix ChangeLog entry

3:32 AM Changeset in webkit [28560] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-08 Alp Toker <alp@atoker.com>

Reviewed by Alp Toker.

GTK+ build fix (for ENABLE_VIDEO builds):

Include MathExtras.h to get isfinite().

rendering/RenderMedia.cpp:

12:53 AM Changeset in webkit [28559] by rwlbuis@webkit.org

12 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15528
svg_dynamic_cast should be removed

Replace svg_dynamic_cast with a combination of
isSVGElement and static_cast.

Dec 7, 2007:

10:49 PM Changeset in webkit [28558] by Antti Koivisto

3 edits
5 adds in trunk

WebCore:

Reviewed by Adele.

Partial fix for <rdar://problem/5633400>
Transformed <video>, <img>, <embed> are not clipped correctly until a repaint is forced

Fix video painting when transform is applied.

Test: media/video-transformed.html

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):

LayoutTests:

Reviewed by Adele.

Test video painting when transform is applied.

media/video-paint-test.js: Added.
media/video-transformed.html: Added.
platform/mac/media/video-transformed-expected.checksum: Added.
platform/mac/media/video-transformed-expected.png: Added.
platform/mac/media/video-transformed-expected.txt: Added.

9:44 PM Changeset in webkit [28557] by sfalken@apple.com

4 edits in trunk

WebKit/win:

Fix version parsing.

Rubber-stamped by Oliver.

WebKit.vcproj/auto-version.sh:

WebKitTools:

Fix version parsing.

Rubber-stamped by Oliver.

Drosera/win/Drosera.vcproj/auto-version.sh:

8:26 PM Changeset in webkit [28556] by sfalken@apple.com

3 edits
4 adds in trunk/WebKitTools

Build modifications for Drosera.

Reviewed by Adam.

Drosera/DroseraWin.make: Added.
Drosera/win/Drosera.vcproj/Drosera.rc:
Drosera/win/Drosera.vcproj/Drosera.vcproj:
Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
Drosera/win/Drosera.vcproj/VERSION: Added.
Drosera/win/Drosera.vcproj/auto-version.sh: Added.

5:48 PM Changeset in webkit [28555] by mitz@apple.com

3 edits
5 adds in trunk

WebCore:

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16348 @font-face does not affect the default style

Test: fast/css/font-face-default-font.html

dom/Document.cpp: (WebCore::Document::recalcStyle): Pass our font selector to Font::update() if we already have one.

LayoutTests:

Reviewed by Sam Weinig.

test for http://bugs.webkit.org/show_bug.cgi?id=16348 @font-face does not affect the default style

fast/css/font-face-default-font.html: Added.
platform/mac-leopard/fast/css: Added.
platform/mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
platform/mac-leopard/fast/css/font-face-default-font-expected.png: Added.
platform/mac/fast/css/font-face-default-font-expected.txt: Added.

5:37 PM Changeset in webkit [28554] by Darin Adler

2 edits in trunk/WebKit/mac

Reviewed by Kevin Decker and Tim Hatcher.

speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389

WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling. (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire window goes away, and the view is never removed from the window. (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.

5:06 PM Changeset in webkit [28553] by sfalken@apple.com

3 edits in trunk/WebKit/win

Fix build.

WebKit.vcproj/WebKit.vcproj:
WebScriptCallFrame.cpp:

5:00 PM Changeset in webkit [28552] by sfalken@apple.com

2 edits in trunk/WebKit/win

Fix build.

WebHistory.cpp: (_WebCoreHistoryProvider::containsURL):

4:59 PM Changeset in webkit [28551] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Refactored variable access optimization: Removed the assumption that
the FunctionBodyNode holds the symbol table.

4:56 PM Changeset in webkit [28550] by Darin Adler

2 edits in trunk/WebKit/qt

try to fix build

Api/qwebhistoryinterface.cpp: (WebCore::historyContains): There's a WebCore function here in WebKit! Needs to be updated, since WebCore changed, but this should not be here.

4:39 PM Changeset in webkit [28549] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/nodes.cpp:

4:35 PM Changeset in webkit [28548] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/interpreter.cpp:

4:30 PM Changeset in webkit [28547] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/grammar.y:

4:24 PM Changeset in webkit [28546] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/function_object.cpp:

4:23 PM Changeset in webkit [28545] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Fixed crash seen running layout tests.

Reverted a change I made earlier today. Added a comment to try to
discourage myself from making this mistake a third time.

kjs/function.cpp: (KJS::ActivationImp::mark):
kjs/function.h: (KJS::ActivationImp::ActivationImpData::ActivationImpData):

4:22 PM Changeset in webkit [28544] by Darin Adler

2 edits in trunk/WebCore

fix Windows build

bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Missed a rename.

4:05 PM Changeset in webkit [28543] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Anders and Darin

When a statement bumps up against the quota and the UI Delegate grants more space, we need to
actually set the new maximum size on the SQLiteDatabase (in addition to storing the new max quota
in the DatabaseTracker, which was already done)

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runStatements): If a statement is being retried, set the maximum size on the SQLiteDatabase to the new maximum size

4:02 PM Changeset in webkit [28542] by Darin Adler

2 edits in trunk/WebCore

fix Tiger build

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Tiger didn't even have QTKIT_VERSION_MAX_ALLOWED, so add logic to work without that.

4:02 PM Changeset in webkit [28541] by beidson@apple.com

1 edit
1 add in trunk/WebKitSite

Reviewed by Darin's rubberstamp

When developing the Database feature and dealing with UI Delegate issues, it is important to have
live examples on the web to help reproduce certain situations.

This file is a dumping ground for such examples, and starts out with one function - the ability to add
arbitrary amounts of data to a database to test the quota-related mechanisms of the UI

misc/DatabaseTester.html: Added.

4:01 PM Changeset in webkit [28540] by ggaren@apple.com

7 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Refactored parsing of global code: Removed the assumption that
ProgramNode inherits from FunctionBodyNode from the parser.

kjs/Parser.cpp: (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse):
kjs/Parser.h: (KJS::Parser::didFinishParsing):
kjs/function.cpp:
kjs/grammar.y:
kjs/nodes.h:

3:53 PM Changeset in webkit [28539] by Darin Adler

2 edits in trunk/WebCore

fix 64-bit build, hopefully without breaking Tiger build

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't use Movies.h constants that are nonexistent in 64-bit. Define the new QTMovie.h constants, though, when using an older QTKit.

3:22 PM Changeset in webkit [28538] by ggaren@apple.com

2 edits in trunk/WebKit/win

Tried to fix build by suppressing warning.

WebScriptCallFrame.cpp:

3:00 PM Changeset in webkit [28537] by beidson@apple.com

3 edits in trunk/WebCore

Reviewed by Anders

Fix <rdar://problem/5636115> - Prompted for quota increase to create database when it already existed

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Check hasEntryForDatabase before doing any prompting (WebCore::DatabaseTracker::hasEntryForDatabase): Check and see if this database already exists
storage/DatabaseTracker.h:

2:58 PM Changeset in webkit [28536] by Darin Adler

15 edits in trunk

WebCore:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit

bridge/GlobalHistory.h: Change historyContains to take a character pointer plus length instead of requiring a DeprecatedString.

bridge/mac/GlobalHistoryMac.mm: (WebCore::historyContains): Updated for above change. Also removes pointless "fast Latin-1" case that was never used.
bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Ditto.
platform/gtk/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
platform/wx/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.

css/CSSStyleSelector.cpp: (WebCore::findHash): Added. Helper for cleanpath. (WebCore::findSlashDotDotSlash): Ditto. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::cleanpath): Changed to use fast helper functions instead of slower general-purpose DeprecatedString find function. (WebCore::containsColonSlashSlash): Added. Helper for checkPseudoState. (WebCore::checkPseudoState): Got rid of reference count churn by using an AtomicString* instead of an AtomicString for the attribute value. Changed to use fast helper function instead of slower DeprecatedString::contains function, and also made the fast case not bother allocating a DeprecatedConstString.

unrelated tiny cleanup

platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::releaseCachedStops): Use static_cast instead of reinterpret_cast. (WebCore::cgGradientCallback): Ditto.

WebKit/mac:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit

History/WebHistory.mm: Removed unused Latin-1 code path. (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.

WebKit/win:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit

WebHistory.cpp: Removed unused Latin-1 code path. (_WebCoreHistoryProvider::containsItem): Updated for function name change.

2:45 PM Changeset in webkit [28535] by Darin Adler

2 edits in trunk/WebCore

Fix build on Tiger (Mark Rowe told me how).

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Include <objc/objc-runtime.h>, which existed back on Tiger, rather than <objc/runtime.h>, which did not.

2:45 PM Changeset in webkit [28534] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added JSVariableObject.cpp to the .pri file.

JavaScriptCore.pri:

2:37 PM Changeset in webkit [28533] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/function.cpp:

2:33 PM Changeset in webkit [28532] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: rolling out last build fix to change #include path.

WARNING: NO TEST CASES ADDED OR CHANGED

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

2:30 PM Changeset in webkit [28531] by sfalken@apple.com

15 edits in trunk

JavaScriptCore:

Re-named our B&I flag from BUILDBOT to PRODUCTION.

Reviewed by Sam Weinig.

JavaScriptCore.vcproj/JavaScriptCore.make:
JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

WebCore:

Re-named our B&I flag from BUILDBOT to PRODUCTION.

Reviewed by Sam Weinig.

WebCore.vcproj/WebCore.make:

WebKit/win:

Re-named our B&I flag from BUILDBOT to PRODUCTION.
Fix our tiny versioning.
Bump our product version.
Use just the major version in the fallback VERSION files.
Pick up the version numbers from the production builder.

Reviewed by Sam Weinig.

Interfaces/WebKit.idl:
WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/PRODUCTVERSION:
WebKit.vcproj/VERSION:
WebKit.vcproj/WebKit.make:
WebKit.vcproj/WebKit.rc:
WebKit.vcproj/WebKit.vcproj:
WebKit.vcproj/auto-version.sh:
WebKitDLL.cpp: (DllUnregisterServer):

2:26 PM Changeset in webkit [28530] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: corrected #include path.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

2:23 PM Changeset in webkit [28529] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: removed stray name qualification.

kjs/function.h: (KJS::ActivationImp::ActivationImp):

2:14 PM Changeset in webkit [28528] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: moved functions with qualified names outside of class
declaration.

kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): (KJS::JSVariableObject::symbolTablePut):

2:05 PM Changeset in webkit [28527] by ggaren@apple.com

17 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Next step in refactoring JSGlobalObject: Added JSVariableObject class,
and factored symbol-table-related code into it. (JSGlobalObject doesn't
use the symbol table code yet, though.)

Layout and JS tests, and testapi, pass. SunSpider reports no regression.

WebCore:

Reviewed by Sam Weinig.

Added some namespace qualifications and a forwarding header, now that
KJS::Node is sometimes #included in WebCore by JavaScriptCore headers.

ForwardingHeaders/wtf/ListRefPtr.h: Added.
bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessorPrototypeFunctionTransformToFragment::callAsFunction):
bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):

WebKit/mac:

Reviewed by Sam Weinig.

Added a forwarding header, since we now #include nodes.h through some
JavaScriptCore headers.

ForwardingHeaders/wtf/ListRefPtr.h: Added.

12:21 PM Changeset in webkit [28526] by Adam Roben

7 edits
1 add in trunk

Add SoftLinking.h for Windows and use it in a few places

WebCore:

Add SoftLinking.h for Windows and use it in a few places

Reviewed by Oliver.

WebCore.vcproj/WebCore.vcproj: Added new file to project.
platform/win/PlatformScrollBarSafari.cpp: Use SoftLinking.h. (WebCore::PlatformScrollbar::PlatformScrollbar): Removed manual soft-linking calls. (WebCore::PlatformScrollbar::paintButton): Check for the presence of the SafariTheme library now that we can't check for the presence of paintThemePart directly. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
platform/win/SoftLinking.h: Copied from WebCore/platform/mac/SoftLinking.h.
rendering/RenderThemeSafari.cpp: Same basic changes as to PlatformScrollBarSafari.cpp. (WebCore::RenderThemeSafari::RenderThemeSafari): (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCapsLockIndicator):
rendering/RenderThemeSafari.h: Removed m_themeDLL member.

WebKit/win:

Use SoftLinking.h in WebKitClassFactory.

Reviewed by Oliver.

WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): We don't have to worry about not finding STInitialize anymore now that a version of SafariTheme containing this function has shipped.

11:59 AM Changeset in webkit [28525] by Darin Adler

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=16185 jsRegExpCompile should not add implicit non-capturing bracket

While this does not make SunSpider faster, it will make many regular
expressions a bit faster.

pcre/pcre_compile.cpp: Moved CompileData struct in here from the header since it's private to this file. (compile_branch): Updated for function name change. (compile_bracket): Renamed from compile_regex, since, for one thing, this does not compile an entire regular expression. (calculateCompiledPatternLengthAndFlags): Removed unused item_count local variable. Renamed CompileData to cd instead of compile_block to be consistent with other functions. Added code to set the needOuterBracket flag if there's at least one "|" at the outer level. (jsRegExpCompile): Renamed CompileData to cd instead of compile_block to be consistent with other functions. Removed unneeded "size" field from the compiled regular expression. If no outer bracket is needed, then use compile_branch to compile the regular expression.

pcre/pcre_internal.h: Removed the CompileData struct, which is now private to pcre_compile.cpp. Removed the size member from JSRegExp.

11:44 AM Changeset in webkit [28524] by Darin Adler

8 edits
2 adds in trunk

WebCore:

Reviewed by Adele.

fix <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152

Test: fast/forms/select-set-inner.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Added a return value, as with other calls that change children, so we can optimize for the case where it does nothing. (WebCore::ContainerNode::cloneChildNodes): Changed parameter type to ContainerNode.
dom/ContainerNode.h: See above.

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLOptGroupElement::childrenChanged): Override childrenChanged instead of addChild, for consistency with HTMLSelectElement; no need to override both. (WebCore::HTMLOptGroupElement::groupLabelText): Made const.
html/HTMLOptGroupElement.h: See above.

html/HTMLSelectElement.cpp: Don't override addChild any more, because we already override childrenChanged, and addChild calls that. (WebCore::HTMLSelectElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLSelectElement::recalcListItems): Tightened up the code a little bit by using a for loop and traverseNextSibling. Also added some new comments and removed some obsolete ones. (WebCore::HTMLSelectElement::checkListItems): Added. Debug-only check to make sure we don't have a stale list items vector.
html/HTMLSelectElement.h: Changed listItems() to invoke checkListItems(). This will help us catch cases where we have too few calls to setRecalcListItems.

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152

fast/forms/select-set-inner-expected.txt: Added.
fast/forms/select-set-inner.html: Added.

11:24 AM Changeset in webkit [28523] by mitz@apple.com

17 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

WebCore part of fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

Test: fast/repaint/focus-ring.html

editing/SelectionController.cpp: (WebCore::SelectionController::caretRepaintRect): Changed to return just the caret rect without any padding. (WebCore::SelectionController::recomputeCaretRect): Changed to repaint just the caret rect without any padding.
platform/graphics/GraphicsContext.h: Removed setFocusRingClip() and clearFocusRingClip().
platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
platform/graphics/cg/GraphicsContextCG.cpp: Ditto.
platform/graphics/cg/GraphicsContextPlatformPrivate.h: Removed m_focusRingClip member.
platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing): Changed to call wkDrawFocusRing() once without setting up additional clip. On Leopard, wkDrawFocusRing() respects the context clip now. On Tiger, a transparency layer is used to apply clipping to the focus ring.
platform/graphics/qt/GraphicsContextQt.cpp: Removed focus ring clip methods and member.
platform/graphics/wx/GraphicsContextWx.cpp: Ditto.
platform/mac/WebCoreSystemInterface.h: Removed the clipRect argument to wkDrawFocusRing().
platform/mac/WebCoreSystemInterface.mm: Ditto.
rendering/RenderLayer.cpp: (WebCore::setClip): Removed call to set the focus ring clip. (WebCore::restoreClip): Removed call to reset the focus ring clip.

WebKitLibraries:

Reviewed by Darin Adler.

updated system interface for fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceTiger.a:

LayoutTests:

Reviewed by Darin Adler.

repaint test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

fast/repaint/focus-ring.html: Added.
platform/mac/fast/repaint/focus-ring-expected.checksum: Added.
platform/mac/fast/repaint/focus-ring-expected.png: Added.
platform/mac/fast/repaint/focus-ring-expected.txt: Added.

11:09 AM Changeset in webkit [28522] by beidson@apple.com

2 edits in trunk/WebKitSite

Reviewed by Adam Roben

misc/DatabaseExample.html: Changed to differentiate failure between running with an unsupported browser or some other error that prevented the database from opening. In the future we can use ExceptionCodes returned from openDatabase(), but a good list of those don't exist yet

10:44 AM Changeset in webkit [28521] by Darin Adler

11 edits in trunk/WebCore

Reviewed by Antti Koivisto and Kevin Decker.

fix <rdar://problem/5601586> QtKit should be dynamically loaded upon need, not linked at startup

Also did a lot of small tweaks to MediaPlayerPrivateQTKit.

WebCore.xcodeproj/project.pbxproj: Don't link to QTKit.

platform/graphics/mac/MediaPlayerPrivateQTKit.h: Omit unneeded includes and declarations. Made a lot more functions const. Made a few more members private and a couple inline.
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Added soft linking machinery for all the things we currently use in QTKit. It's a little more awkward for classes and other data objects than it is for functions, but still relatively straightforward, with no changes needed to the client code. Added using namespace directives. Made a cuePointTimerInterval constant and put it at the top of the file. Use 0 consistently instead of sometimes 0 and sometimes 0.0f. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Removed unneeded initialization of RetainPtr members to nil. (WebCore::MediaPlayerPrivate::createQTMovie): Use adoptNS instead of autorelease. (WebCore::MediaPlayerPrivate::createQTMovieView): Ditto. Also use -[NSColor clearColor]. (WebCore::MediaPlayerPrivate::createQTTime): Remove an unneeded type cast that had no effect. Changed to use long instead of int because that's the type for a QTTime time scale anyway. (WebCore::MediaPlayerPrivate::duration): Use a static_cast instead of a C-style cast. (WebCore::MediaPlayerPrivate::currentTime): Ditto. Also merged into a single expression. (WebCore::MediaPlayerPrivate::cuePointTimerFired): Added code to make a copy of the cue points set to avoid a potential problem with a set being modified as we iterate it. (WebCore::MediaPlayerPrivate::bytesLoaded): Removed unneeded null check of m_qtMovie. (WebCore::MediaPlayerPrivate::updateStates): Instead of comments explaining the numeric values, used the constants from the headers directly. (WebCore::MediaPlayerPrivate::getSupportedTypes): Instead of (QTMovieFileTypeOptions)0, pass the named constant with value 0, QTIncludeCommonTypes. Skipped the intermediate type of NSString to remove one cast. Replaced C-style cast with reinterpret_cast (arguably no better). Used RetainPtr instead of explicit CFRelease calls.

platform/mac/SoftLinking.h: Added macros to do soft linking for classes and for pointers. It's not quite as automatic as the soft linking we can do for functions, since these define functions to get the values, so you need to define macros to make what look like variable accesses turn into function calls. See MediaPlayerPrivateQTKit for the details.

html/HTMLMediaElement.h:
html/TimeRanges.h:
html/VoidCallback.h:
platform/graphics/MediaPlayer.h: Use angle brackets for wtf includes. Omit unneeded includes.

10:43 AM Changeset in webkit [28520] by adachan@apple.com

3 edits in trunk/WebKit/win

<rdar://problem/5556378> Implemented database related UI delegate methods (prompts for new/enlarged databases)

Reviewed by Darin.

Interfaces/IWebUIDelegatePrivate.idl:
WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

10:26 AM Changeset in webkit [28519] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix http://bugs.webkit.org/show_bug.cgi?id=16334 <rdar://problem/5634923> REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load completely

Test: fast/dynamic/subtree-no-common-root-static-y.html

rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Changed the call to setChildNeedsLayout() to not mark containing blocks and added a separate call to markContainingBlocksForLayout() that will not schedule a layout if we are already in the middle of scheduleRelayoutOfSubtree().

LayoutTests:

Reviewed by Darin Adler.

test for http://bugs.webkit.org/show_bug.cgi?id=16334 <rdar://problem/5634923> REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load completely

fast/dynamic/subtree-no-common-root-static-y.html: Added.
platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.checksum: Added.
platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.png: Added.
platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.

9:24 AM Changeset in webkit [28518] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Fix wxWebKit page leaks.

Reviewed by Darin Adler.

9:18 AM Changeset in webkit [28517] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

MSVC7 build fix due to a compiler bug with placement new and/or templates and casting.

Reviewed by Darin Adler.

4:26 AM HackingGtk edited by alp@atoker.com

Movie -> MediaPlayer in SVN link (diff)

3:47 AM Changeset in webkit [28516] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-12-07 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16333
[GTK] Key bindings must work with focused frames.

There are still more cases where getFrameFromView() is mis-used that
need to be fixed, but this is a good start.

WebView/webkitwebview.cpp: (webkit_web_view_real_select_all): (webkit_web_view_real_cut_clipboard): (webkit_web_view_real_copy_clipboard): (webkit_web_view_real_paste_clipboard):

2:17 AM Changeset in webkit [28515] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work

Test: http/tests/misc/empty-cookie.html

platform/mac/CookieJar.mm: (WebCore::setCookies): Don't store empty cookies. (WebCore::cookies): Filter out empty cookies if we have them, as they could have been set with an earlier version of Leopard!

Dec 6, 2007:

11:27 PM Changeset in webkit [28514] by adachan@apple.com

2 edits in trunk/WebCore

Fixed the if statement (ERROR_SUCCESS is 0 and we were actually
returning true when there's an error).

Reviewed by Steve.

platform/win/FileSystemWin.cpp: (WebCore::makeAllDirectories):

11:02 PM Changeset in webkit [28513] by ap@webkit.org

1 edit
10 adds in trunk/LayoutTests

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16091
JSCRE needs to import the PCRE test suite

We can use two files from PCRE test suite, as others either test for features not supported
in JS, or use internal debugging facilities of PCRE.

The files are checked in almost unmodified, I have only converted them to UTF-8 and removed two
huge test cases that were completely incompatible with JSC, and were polluting the output.

Many of the failures in results are just legitimate differences in behavior or possibly
problems with the test runner, but some may be genuine bugs and even regressions in JSC.

fast/regex: Added.
fast/regex/pcre-test-runner.js: Added.
fast/regex/test1-expected.txt: Added.
fast/regex/test1.html: Added.
fast/regex/test4-expected.txt: Added.
fast/regex/test4.html: Added.
fast/regex/testinput1: Added.
fast/regex/testinput4: Added.
fast/regex/testoutput1: Added.
fast/regex/testoutput4: Added.

10:17 PM Changeset in webkit [28512] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Oliver's rubber stamp

Let's go ahead and call the correct UI Delegate method, shall we?

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate

9:33 PM Changeset in webkit [28511] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Linux build fix - ensure that webcore is linked before jscore so that the linker will know which symbols it needs to link in. Also fix MSVC project file name typo for sample app.

7:59 PM Changeset in webkit [28510] by Darin Adler

2 edits in trunk/WebCore

fix broken regression test

bindings/js/kjs_binding.cpp: (KJS::setDOMException): Oops, this was just supposed to be PERMISSION_DENIED.

7:18 PM Changeset in webkit [28509] by Darin Adler

9 edits
1 copy in trunk/WebCore

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16332 ObjC DOM exception object descriptions should include the exception name

WebCore.pro: Added ExceptionCode.cpp.
WebCore.vcproj/WebCore.vcproj: Added ExceptionCode.cpp.
WebCore.xcodeproj/project.pbxproj: Added ExceptionCode.cpp.
WebCoreSources.bkl: Added ExceptionCode.cpp.

bindings/js/kjs_binding.cpp: (KJS::setDOMException): Moved the code to decompose an ExceptionCode into ExceptionCode.h/cpp -- getExceptionCodeDescription. Also removed the many unneeded includes that were here. Had to keep one special case here, for SECURITY_ERR.

bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException): Changed to use the new getExceptionCodeDescription function so that this shares the exception name information that was previously only available to JavaScript.

dom/ExceptionCode.cpp: Copied from bindings/js/kjs_binding.cpp. (WebCore::getExceptionCodeDescription): Added some assertions, and made the function handle exception names in a slightly more robust way that is not subject to integer overflow. (Not a real world issue since we should never receive a bad exception code.)

dom/ExceptionCode.h: Added the ExceptionCodeDescription struct and the getExceptionCodeDescription function.

svg/SVGException.h: Added a missing #include and got rid of some comments. Some of the comments were mildly helpful, but others were incorrect. This now matches the other exception-related headers such as RangeException.h.

6:49 PM Changeset in webkit [28508] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Darin

Fixed a glaring bug that would prevent a statement from getting run a second time

storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Clear failure due to quota *before* we check the error and return early (WebCore::SQLStatement::clearFailureDueToQuota): Only clear the error if it was a quota error

6:10 PM Changeset in webkit [28507] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Use keydown instead of keypress so keyIdentifier can be used.

page/inspector/ConsolePanel.js: Use keydown instead of keypress.
page/inspector/DatabasePanel.js: Ditto.
page/inspector/inspector.js: Ditto. Plus call removeEventListener before deleting windowLoaded.

6:05 PM Changeset in webkit [28506] by Adam Roben

2 edits in trunk/WebCore

Rename FontsTable.plist to FontsList.plist

Rubberstamped by Hyatt.

platform/graphics/win/FontDatabase.cpp:

6:00 PM Changeset in webkit [28505] by alice.liu@apple.com

4 edits in trunk/WebKit/win

Fixed <rdar://5540000> onbeforeunload doesn't fire when closing window/tab

Reviewed by Darin.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::shouldClose):
WebView.h:

5:51 PM Changeset in webkit [28504] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Darin

Tweaked a comment and a few assertions from my last checkin

storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): (WebCore::SQLStatement::clearFailureDueToQuota): (WebCore::SQLStatement::lastExecutionFailedDueToQuota):

5:04 PM Changeset in webkit [28503] by Adam Roben

4 edits in trunk/WebKit

Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision

WebKit/mac:

Remove some assertions we know can fire and replace them with a FIXME

Reviewed by Anders.

WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/win:

Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision

It's possible for a second policy listener to be created while we're
waiting for a decision on the first policy listener. In this case we
would crash when the first policy listener had a decision made. Mac
WebKit already handles this by invalidating any existing policy
listener when creating a new one.

A test case is coming in a future commit.

Reviewed by Anders.

WebFrame.cpp: (WebFrame::setUpPolicyListener): Copy the Mac behavior of invalidating any existing policy listener, and remove some assertions that we know can fire.

4:50 PM Changeset in webkit [28502] by beidson@apple.com

9 edits in trunk/WebCore

Reviewed by Darin

Finished hooking up UI Delegate for databases - Database operations will now enforce a size quota and
will ask the UI Delegate for more space when that quota is met

platform/sql/SQLiteDatabase.cpp: Add the new SQLResultFull constant
platform/sql/SQLiteDatabase.h: Ditto

storage/Database.cpp: (WebCore::Database::securityOriginData): Added this accessor, copying for thread safety (WebCore::Database::stringIdentifier): Ditto
storage/Database.h:

storage/SQLStatement.cpp: (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::execute): Change to return an enum that represents 3 states - success, error, and quota. If the result is quota, this statement expects that it might be run again, presumably after the user increases the quota (WebCore::SQLStatement::setFailureDueToQuota): Setup a quota failure, including a flag and the error (WebCore::SQLStatement::clearFailureDueToQuota): Clear a quota failure, for when the statement is rerun (WebCore::SQLStatement::lastExecutionFailedDueToQuota):
storage/SQLStatement.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::performPendingCallback): Added an acceptable callback pointer (WebCore::SQLTransaction::openTransactionAndPreflight): Setup the quota in the database that will remain for this transaction. Note that in this patch, the quota being set is wrong - it makes sense to fix that in a follow up patch (WebCore::SQLTransaction::runStatements): Modified to add the ability to re-run a statement based on the UI delegate decision and whether the current statement was already run (WebCore::SQLTransaction::runCurrentStatement): Added another result condition - the Quota result - and handle it (WebCore::SQLTransaction::handleCurrentStatementError): Statements can now error-out from two places, so the code that handles a statement error was moved here (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Added - Consult the UI delegate for more quota, then reschedule the current statement on the database thread
storage/SQLTransaction.h:

3:32 PM Changeset in webkit [28501] by timothy@apple.com

2 edits in trunk/WebKit/mac

Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
Only assert if the major version is zero, since zero is handled in the other cases.

WebView/WebView.mm: (callGestalt): Remove the ASSERT. (createMacOSXVersionString): ASSERT that major is not zero.

3:31 PM Changeset in webkit [28500] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5614257> Crash in timer / hashtable code due to uncaught exception

Don't use callback-based timers, since these cause Windows to eat Windows crashes
in code the timers call.

Windows appears to be defending against "shatter" attacks partially by setting
up a structured exception block while dispatching callback-based WM_TIMERs.

I verified this by adding a divide by zero into some timer callback code.
In the case where the timer was dispatched via a callback, the divide by zero
exception was silently handled and ignored, with execution continuing after
our call to DispatchMessage. When processed via the WNDPROC, no SEH
block was established by Windows, and our divide by zero generated a real
crash (which is what we wanted).

Windows handling our crashes for us led us to leave the timer data structures
in an invalid state so the next time a timer was set, we'd crash accessing an
invalid HashMap of timer data.

Reviewed by Hyatt.

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):

2:36 PM Changeset in webkit [28499] by Darin Adler

2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string

WebView/WebView.mm: (callGestalt): Added. (createMacOSXVersionString): Added. (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string, right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4). (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.

2:11 PM Changeset in webkit [28498] by Adam Roben

9 edits in trunk

Fix <rdar://5108390> Feed title is too low in blue banner

WebCore:

Fix <rdar://5108390> Feed title is too low in blue banner

Way back in r23069 we started applying the same font ascent hack that
Mac WebKit applies to Helvetica, Times, and Courier. We did this so
that those fonts would match the Mac metrics when we run the
regression tests. However, this hack was applying to Arial on Windows
when a site would specify the Helvetica font face because Windows will
alias the font names. Instead of removing the hack entirely, we
turn it off by default but provide some SPI so that DumpRenderTree can
turn it on.

Reviewed by Hyatt.

All tests pass.

platform/graphics/FontData.h: Add a new static method to turn on the hack on Windows only.
platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::setShouldApplyMacAscentHack): Added. (WebCore::FontData::platformInit): Only perform the hack if shouldApplyMacAscentHack is true.

WebKit/win:

Add SPI so that DumpRenderTree can turn on the Mac font ascent hack

Reviewed by Hyatt.

Interfaces/IWebViewPrivate.idl: Added new method declaration.
WebView.cpp: (WebView::setShouldApplyMacFontAscentHack): Added. Just calls down to FontData.
WebView.h:

WebKitTools:

Explicitly turn on the Mac font ascent hack on Windows

This keeps our font metrics matching those from Mac.

Reviewed by Hyatt.

DumpRenderTree/win/DumpRenderTree.cpp: (main):

1:25 PM Changeset in webkit [28497] by mitz@apple.com

3 edits in trunk/LayoutTests

updated render tree results for r28483

svg/batik/text/textEffect2-expected.txt:
svg/batik/text/textProperties-expected.txt:

1:19 PM Changeset in webkit [28496] by ggaren@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Fixed http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation

page/Frame.cpp: (WebCore::Frame::scriptProxy): Only return 0 if JS seems disabled *and* we haven't created the proxy yet. If we've created the proxy already, a script may be in the midst of execution, even though we've lost our settings object. During execution, scripts assume they have free access to the proxy.

LayoutTests:

Reviewed by Sam Weinig.

Test for http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation

fast/frames/location-put-after-removal.html: Added.
fast/frames/resources/location-put-after-removal-frame.html: Added.
fast/frames/resources/location-put-after-removal-frame-expected.txt: Updated.

1:17 PM Changeset in webkit [28495] by andersca@apple.com

1 edit
1 copy in trunk/WebKitTools

Rename main.c to main.cpp here too.

DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.

1:10 PM Changeset in webkit [28494] by weinig@apple.com

2 edits in trunk/WebKitTools

Rubber stamped by Geoff.

Scripts/do-webcore-rename: Don't rename kjs_css twice.

1:00 PM Changeset in webkit [28493] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Some more renaming plans.

12:37 PM Changeset in webkit [28492] by andersca@apple.com

2 edits in trunk/WebKitTools

Remove implementation of testGetIntIdentifier that was accidentally
removed somehow (possibly when I made PluginObject be a cpp file).

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

12:24 PM Changeset in webkit [28491] by Darin Adler

5 edits in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>

Test: fast/js/regexp-oveflow.html

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): In the case where a single character character class is optimized to not use a character class at all, the preflight code was not setting the lastitemlength variable.

LayoutTests:

Reviewed by Eric Seidel.

fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>

fast/js/regexp-overflow-expected.txt: Updated.
fast/js/resources/regexp-overflow.js: Added test.

12:11 PM Changeset in webkit [28490] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-06 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16329
[GTK] Two small cleanups

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::addMessageToConsole): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::runJavaScriptPrompt): (WebKit::ChromeClient::setStatusbarText): (WebKit::ChromeClient::mouseDidMoveOverElement): (WebKit::ChromeClient::setToolTip):
WebCoreSupport/ChromeClientGtk.h:
WebView/webkitprivate.cpp: (WebKit::kit): s/m_webPage/m_webView/
WebView/webkitwebview.cpp: Chain up to the parent class to activate bindings instead of doing it explicitely.

12:02 PM Changeset in webkit [28489] by adele@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5631356> Toggling display property on video causes controls to get lost

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attach): Call updateFromElement.
html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Oliver.

Fix <rdar://problem/5631356> Toggling display property on video causes controls to get lost

media/video-display-toggle.html: Added.
platform/mac/media/video-display-toggle-expected.checksum: Added.
platform/mac/media/video-display-toggle-expected.png: Added.
platform/mac/media/video-display-toggle-expected.txt: Added.

11:33 AM Changeset in webkit [28488] by adachan@apple.com

2 edits in trunk/WebKit/win

Build fix.

Reviewed by Geoff.

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

10:46 AM Changeset in webkit [28487] by Antti Koivisto

12 edits
6 moves in trunk/WebCore

Reviewed by Oliver.

Rename

Movie -> MediaPlayer
MoviePrivate -> MediaPlayerPrivate

Movie is QuickTime terminology and clashes with its C API.

WebCore.xcodeproj/project.pbxproj:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::mediaPlayerCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::willSaveToCache):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::player):
html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMediaMIMETypes): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
platform/MIMETypeRegistry.h:
platform/graphics/MediaPlayer.cpp: Copied from WebCore/platform/graphics/Movie.cpp. (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::~MediaPlayer): (WebCore::MediaPlayer::load): (WebCore::MediaPlayer::cancelLoad): (WebCore::MediaPlayer::play): (WebCore::MediaPlayer::pause): (WebCore::MediaPlayer::duration): (WebCore::MediaPlayer::currentTime): (WebCore::MediaPlayer::seek): (WebCore::MediaPlayer::paused): (WebCore::MediaPlayer::seeking): (WebCore::MediaPlayer::naturalSize): (WebCore::MediaPlayer::hasVideo): (WebCore::MediaPlayer::networkState): (WebCore::MediaPlayer::readyState): (WebCore::MediaPlayer::volume): (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::rate): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::dataRate): (WebCore::MediaPlayer::setEndTime): (WebCore::MediaPlayer::addCuePoint): (WebCore::MediaPlayer::removeCuePoint): (WebCore::MediaPlayer::clearCuePoints): (WebCore::MediaPlayer::maxTimeBuffered): (WebCore::MediaPlayer::maxTimeSeekable): (WebCore::MediaPlayer::bytesLoaded): (WebCore::MediaPlayer::totalBytesKnown): (WebCore::MediaPlayer::totalBytes): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::visible): (WebCore::MediaPlayer::setVisible): (WebCore::MediaPlayer::paint): (WebCore::MediaPlayer::getSupportedTypes): (WebCore::MediaPlayer::networkStateChanged): (WebCore::MediaPlayer::readyStateChanged): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::timeChanged): (WebCore::MediaPlayer::cuePointReached):
platform/graphics/MediaPlayer.h: Copied from WebCore/platform/graphics/Movie.h. (WebCore::MediaPlayerClient::~MediaPlayerClient): (WebCore::MediaPlayerClient::mediaPlayerNetworkStateChanged): (WebCore::MediaPlayerClient::mediaPlayerReadyStateChanged): (WebCore::MediaPlayerClient::mediaPlayerVolumeChanged): (WebCore::MediaPlayerClient::mediaPlayerTimeChanged): (WebCore::MediaPlayerClient::mediaPlayerCuePointReached):
platform/graphics/Movie.cpp: Removed.
platform/graphics/Movie.h: Removed.
platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.cpp. (WebCore::mediaPlayerPrivateErrorCallback): (WebCore::mediaPlayerPrivateEOSCallback): (WebCore::mediaPlayerPrivateStateCallback): (WebCore::mediaPlayerPrivateBufferingCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.h.
platform/graphics/gtk/MoviePrivateGStreamer.cpp: Removed.
platform/graphics/gtk/MoviePrivateGStreamer.h: Removed.
platform/graphics/mac/MediaPlayerPrivateQTKit.h: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.h.
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.mm. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::createQTTime): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::seekTimerFired): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (-[WebCoreMovieObserver initWithCallback:WebCore::]):
platform/graphics/mac/MoviePrivateQTKit.h: Removed.
platform/graphics/mac/MoviePrivateQTKit.mm: Removed.
rendering/RenderMedia.cpp: (WebCore::RenderMedia::player):
rendering/RenderMedia.h:
rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paintReplaced): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updatePlayer):
rendering/RenderVideo.h:

10:26 AM HackingGtk edited by alp@atoker.com

Add a link to the GStreamer video backend code (diff)

10:01 AM Changeset in webkit [28486] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: access global object directly.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):

4:20 AM Changeset in webkit [28485] by mrowe@apple.com

2 edits in trunk/WebCore

Fix bug spotted by GCC 4.2. Remove extraneous semicolon that completely changed the meaning of allowPopUp.

Reviewed by Eric.

1:26 AM Changeset in webkit [28484] by alp@webkit.org

16 edits in trunk

2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change

Change license from BSD to LGPL.

Dec 5, 2007:

11:40 PM Changeset in webkit [28483] by rwlbuis@webkit.org

10 edits
4 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15289
WebKit does not respect clip paths of a 0x0 rect

Make empty clip paths clip the whole referencing graphic.

10:25 PM Changeset in webkit [28482] by Darin Adler

4 edits in trunk/WebCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=16266 <rdar://problem/5625279> REGRESSION: crash loading CNN.com at Interpreter::createObjectsForGlobalObjectProperties()

I don't know how to reproduce this in a test.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call JSEventTargetNode::mark instead of DOMObject::mark. There's no difference right now, but it's best to call your base class, not your base's base.

bindings/js/kjs_events.h: Removed unneeded virtual from the JSUnprotectedEventListener::mark() function; it neither derives from or is derived from anyone else with a mark() function so there's no need for virtual.

bindings/js/kjs_window.cpp: (KJS::Window::mark): Call JSGlobalObject::mark, not JSObject::mark. This is the actual bug fix.

9:42 PM Changeset in webkit [28481] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-05 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend

Reviewed by Alp Toker.

Remove old comments, fix variable names, match WebKit coding style.

platform/graphics/gtk/MoviePrivateGStreamer.cpp: (WebCore::moviePrivateEOSCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::createGSTPlayBin):
platform/graphics/gtk/MoviePrivateGStreamer.h:

9:37 PM Changeset in webkit [28480] by mrowe@apple.com

2 edits in trunk/WebCore

Speculative wx build fix. Add PlugInInfoStore::pluginNameForMIMEType to the temporary link stubs.

9:25 PM Changeset in webkit [28479] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Qt Windows build fix. Include the time-related headers in the correct place.

9:22 PM Changeset in webkit [28478] by Darin Adler

2 edits in trunk/JavaScriptCore

Not reviewed; just undoing a previous commit.

remove earlier incorrect fix for http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)

The real bug was the backwards ?: in the compile function, which Geoff just
fixed. Rolling out the incorrect earlier fix.

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Take out the unneeded preflight change. The regression test proves this is still working fine, so the bug remains fixed.

9:13 PM Changeset in webkit [28477] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-05 Alp Toker <alp@atoker.com>

Rubber stamped by Mark Rowe.

Remove DEPENDPATH on the generated sources directory. This causes
trouble and is no longer necessary following the glib-genmarshal
generator split.

WebCore.pro:

8:14 PM Changeset in webkit [28476] by mrowe@apple.com

7 edits in trunk/JavaScriptCore

Build fix. Include headers before trying to use the things that they declare.

7:11 PM Changeset in webkit [28475] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added some #includes.

kjs/JSImmediate.cpp:

7:07 PM Changeset in webkit [28474] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Build fix: added some #includes.

kjs/JSGlobalObject.cpp:
kjs/JSImmediate.cpp:

7:02 PM Changeset in webkit [28473] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: Fixed #include spelling.

kjs/debugger.cpp:

6:57 PM Changeset in webkit [28472] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/debugger.cpp:

6:51 PM Changeset in webkit [28471] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added a forward declaration.

kjs/debugger.h:

6:47 PM Changeset in webkit [28470] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/error_object.cpp:

6:41 PM Changeset in webkit [28469] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/bool_object.cpp:

6:31 PM Changeset in webkit [28468] by ggaren@apple.com

109 edits
5 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.

This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.

This is a big change, but it's mostly code motion and renaming.

Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.

JavaScriptGlue:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.

JSRun.cpp: (JSRun::JSRun): (JSRun::Evaluate): (JSRun::CheckSyntax):
JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
JSUtils.cpp: (KJSValueToCFTypeInternal):
JSValueWrapper.cpp: (getThreadGlobalExecState):

WebCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.

This is a big change, but it's mostly code motion and renaming.

WebKit/mac:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.

WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):

WebKit/win:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.

WebFrame.cpp: (WebFrame::globalContext): (WebFrame::attachScriptDebugger): (WebFrame::windowObjectCleared):
WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):

5:37 PM Changeset in webkit [28467] by alice.liu@apple.com

3 edits in trunk/LayoutTests

Reviewed by Antti.

Addressed <rdar://problem/5137284> fast/events/mouseout-dead-node.html fails on boomer

fast/events/mouseout-dead-node.html: Changed the questionable calls to mouseUp() to mouseMoveTo() to better simulate mouseovers
platform/win/Skipped: removed this test from skipped file

5:36 PM Changeset in webkit [28466] by sfalken@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/5625327> Crash toggling check grammar w/ spelling when no spell checker exists.

Reviewed by Adam.

WebView.cpp: (WebView::setGrammarCheckingEnabled): Add null check

4:56 PM Changeset in webkit [28465] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Add a crashing test.

4:33 PM Changeset in webkit [28464] by Darin Adler

2 edits in trunk/WebCore

"Reviewed" by Geoff.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed assertion. (WebCore::FrameLoader::dispatchDidCommitLoad): This one too. The assertions are firing like crazy. Not sure why yet.

4:03 PM Changeset in webkit [28463] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. (Or vice versa.)

Fixed ASSERT during run-javascriptcore-tests. (Darin just added the
ASSERT, but the bug wasn't new.)

pcre/pcre_compile.cpp: (compile_branch): The ?: operator here was backwards, causing us to execute the loop too many times, adding stray KET opcodes to the compiled regular expression.

3:56 PM BuildBot edited by Adam Roben

Add a note about the just-in-time debugger registry key on Windows (diff)

3:34 PM Changeset in webkit [28462] by andersca@apple.com

2 edits in trunk/WebKitTools

Make the entry points extern "C".

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

2:58 PM Changeset in webkit [28461] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=16306 Assertion failed in WebCore/loader/FrameLoader.cpp:4642

loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidCommitLoad): Check m_creatingInitialEmptyDocument and don't deliver the client call in that case.

2:57 PM Changeset in webkit [28460] by andersca@apple.com

2 edits in trunk/WebKitTools

C++ warning fixes.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue):

2:54 PM Changeset in webkit [28459] by andersca@apple.com

2 edits in trunk/WebKitTools

Add the .cpp files to the TestNetscapePlugIn target.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

2:48 PM Changeset in webkit [28458] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Wait until local variable data is fully constructed before notifying the debugger of entering or leaving a call frame.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction):
kjs/nodes.cpp: (KJS::FunctionBodyNode::execute):

2:42 PM Changeset in webkit [28457] by andersca@apple.com

3 edits
3 moves in trunk/WebKitTools

Reviewed by Geoff.

Rename the TestNetscapePlugIn .c files to be .cpp.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

2:30 PM Changeset in webkit [28456] by mrowe@apple.com

2 edits in trunk/WebCore

Fix 64-bit debug build.

Reviewed by Kevin Decker.

platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode): OSStatus is a long for 32-bit but int on 64-bit,
so we need to cast it to be able to use a single format specifier on both.

2:29 PM Changeset in webkit [28455] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Build fix for GCC 4.2. Cast via a union to avoid strict-aliasing issues.

Reviewed by Oliver.

2:27 PM Changeset in webkit [28454] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Add another test failing due to fonts.

2:24 PM Changeset in webkit [28453] by Adam Roben

2 edits in trunk/WebKitTools

Fix case of keypresses from the Windows implementation of eventSender.keyDown

This fixes several regression tests.

Reviewed by Alice.

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Virtual keycodes for ASCII characters are always uppercase, so we need to check the case of the original character passed in to eventSender.keyDown.

2:08 PM Changeset in webkit [28452] by kdecker@apple.com

1 edit in trunk/WebCore/ChangeLog

Corrected a Radar number in my previous ChangeLog entry.

1:51 PM Changeset in webkit [28451] by kdecker@apple.com

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5602071> Safari displays each pixel of 300 dpi US Patent TIFF Images, making them extremely large

loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Allow plug-ins (with the exception of QuickTime) to takeover TIFF once again.

1:48 PM Changeset in webkit [28450] by timothy@apple.com

1 edit
1 add in trunk/WebKitSite

Add another Inspector screenshot for an upcoming blog post.

blog-files/InspectorDatabaseBrowser.png: Added.

1:16 PM Changeset in webkit [28449] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Fix testkjs in 64-bit.

When built for 64-bit the TCMalloc spin lock uses pthread mutexes rather than a custom spin lock
implemented in assembly. If we fail to initialize the pthread mutex, attempts to lock or unlock
it will fail and trigger a call to abort.

Reviewed by Darin.

wtf/FastMalloc.cpp: Initialize the spin lock so that we can later lock and unlock it.
wtf/TCSpinLock.h: Add an Init method to the optimised spin lock.

1:12 PM HackingGtk edited by alp@atoker.com

Mention bundled code (diff)

12:26 PM Changeset in webkit [28448] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-05 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16290
[GTK] Pasting clipboard in rich text.

platform/gtk/PasteboardGtk.cpp: (Pasteboard::documentFragment): Implement rich text paste support.

12:10 PM Changeset in webkit [28447] by adele@apple.com

2 edits in trunk/WebCore

Reviewed by Hyatt.

Reverting fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

We need to just fix the underlying focus ring repaint problem.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):

12:01 PM Changeset in webkit [28446] by kmccullough@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://5621435>
Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards compatibility reasons.

loader/FrameLoader.cpp:

WebKit/mac:

Reviewed by Darin.

<rdar://5621435>
Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards coimpatibility reasons.

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

11:38 AM Changeset in webkit [28445] by Adam Roben

5 edits in trunk/WebKit/win

Expose WebView::setProhibitsMainFrameScrolling through IWebViewPrivate

Reviewed by Steve.

Interfaces/IWebViewPrivate.idl: Added declaration.
WebInspectorClient.cpp: (WebInspectorClient::createPage): Updated for change to setProhibitsMainFrameScrolling signature.
WebView.cpp: (WebView::setProhibitsMainFrameScrolling): Updated and robustified.
WebView.h:

11:36 AM Changeset in webkit [28444] by Adam Roben

2 edits in trunk/WebCore

Set the menu item identifier for all menu items

This allows WebKit clients to distinguish between submenus in the
context menu.

Reviewed by Darin.

No test possible.

platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem):

10:51 AM Changeset in webkit [28443] by Adam Roben

2 edits in trunk/WebKitTools

Learn from Tim's mistakes

DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Reset the authorAndUserStylesEnabled preference for each test.

10:46 AM Changeset in webkit [28442] by mitz@apple.com

9 edits
3 adds in trunk

WebCore:

Reviewed by Darin Adler.

WebCore part of fixing <rdar://problem/5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/

manual-tests/nested-plug-ins.html: Added.
manual-tests/resources/nested-plug-ins-inner-frame.html: Added.
manual-tests/resources/nested-plug-ins-outer-frame.html: Added.
platform/ScrollView.h:
platform/Widget.h: (WebCore::Widget::attachToWindow): Added. Tells the widget that it is connected via visible ScrollViews to the root ScrollView of the WebView. (WebCore::Widget::detachFromWindow): Added. Tells the widget that it is no longer connected via visible ScrollViews to the root ScrollView of the WebView.
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added m_visible and m_attachedToWindow members. (WebCore::ScrollView::attachToWindow): Added. Attaches all children if this view is visible. (WebCore::ScrollView::detachFromWindow): Added. Detaches all children if this view is visible (otherwise they would be detached already). (WebCore::ScrollView::show): Added. Attaches all children if this view is attached. (WebCore::ScrollView::hide): Added. Detaches all children if this view is attached (otherwise they would be detached already). (WebCore::ScrollView::isAttachedToWindow): Added.
platform/win/WidgetWin.cpp: (WebCore::Widget::setParent): Added calls to attachToWindow() and detachFromWindow() depending on whether the parent is set and attached or not.
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFocus): (WebCore::PluginViewWin::show): Changed to show the plug-in only if this view is attached. (WebCore::PluginViewWin::hide): Changed to hide the plug-in only if this view is attached (otherwise it would be hidden already). (WebCore::PluginViewWin::attachToWindow): Added. Shows the plug-in if this view is visible. (WebCore::PluginViewWin::detachFromWindow): Added. Hides the plug-in if this view is visible (otherwise it would be hidden already). (WebCore::PluginViewWin::PluginViewWin):
plugins/win/PluginViewWin.h: Added m_attachedToWindow member.

WebKit/win:

Reviewed by Darin Adler.

WebKit/win part of fixing <rdar://problem/5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/

WebView.cpp: (WebView::initWithFrame): Attach the main frame's view.

10:15 AM Changeset in webkit [28441] by beidson@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Kevin Deckers rubberstamp

Disclose and export the Databases Directory defaults key

Storage/WebDatabaseManager.mm:
Storage/WebDatabaseManagerPrivate.h:
WebKit.exp:

9:07 AM HackingGtk edited by alp@atoker.com

Update link to the Cairo SVG backend in SVN, add link to the Cairo canvas (diff)

8:42 AM Changeset in webkit [28440] by alp@webkit.org

2 edits in trunk/WebKitTools

2007-12-05 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Initialize GTK+ and WebKit so the tests can run.

Reorganize the headers a little.

7:53 AM Changeset in webkit [28439] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-12-05 Michael Natterer <mitch@imendio.com>

Reviewed by Alp Toker.

WebView/webkitwebview.cpp: split key and button event handlers into separate press and release functions.

7:16 AM Changeset in webkit [28438] by alp@webkit.org

3 edits in trunk/WebKit/gtk

2007-12-05 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

Handle events for Home and End keys.

WebView/webkitwebview.cpp: (webkit_web_view_key_event):
WebCoreSupport/EditorClientGtk.cpp: (EditorClient::handleKeypress):

4:35 AM Changeset in webkit [28437] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-05 Michael Natterer <mitch@imendio.com>

Reviewed by Alp Toker.

WebView/webkitwebview.cpp
WebCoreSupport/ChromeClientGtk.cpp
WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.

1:32 AM QtWebKitTodo edited by Simon Hausmann

(diff)

12:26 AM Changeset in webkit [28436] by mitz@apple.com

1 edit
2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

adding a test for http://bugs.webkit.org/show_bug.cgi?id=16097

fast/dom/ImageDocument-image-deletion-expected.txt: Added.
fast/dom/ImageDocument-image-deletion.html: Added.

Dec 4, 2007:

8:47 PM Changeset in webkit [28435] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Fix gtk build

7:58 PM Changeset in webkit [28434] by oliver@apple.com

7 edits
1 add in trunk/JavaScriptCore

Merge TCMalloc r38

Reviewed by Mark Rowe and Geoff Garen.

It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.

6:48 PM Changeset in webkit [28433] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-04 Alp Toker <alp@atoker.com>

Potential GTK+ build fix for the glib-genmarshal issue.

Split the glib-genmarshal qmake generator in two; one for the source
file, another for the header.

WebCore.pro:

6:34 PM Changeset in webkit [28432] by andersca@apple.com

2 edits in trunk/WebKitTools

Remove IWebScriptScope include.

Drosera/win/DebuggerDocumentPlatform.cpp:

6:08 PM Changeset in webkit [28431] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-04 Alp Toker <alp@atoker.com>

GTK+ build fix.

platform/PlugInInfoStore.h:

5:58 PM Changeset in webkit [28430] by sfalken@apple.com

1 delete in tags/Safari-523.12.11b/Safari-3-branch

Remove bad tag.

5:56 PM Changeset in webkit [28429] by sfalken@apple.com

1 copy in tags/Safari-523.12.11b/Safari-3-branch

New tag.

5:49 PM Changeset in webkit [28428] by sfalken@apple.com

1 copy in tags/Safari-523.12.11b

New tag.

5:48 PM Changeset in webkit [28427] by sfalken@apple.com

1 delete in tags/Safari-523.12.11b

Remove unnecessary tag.

5:46 PM Changeset in webkit [28426] by kdecker@apple.com

9 edits in trunk

Reviewed by Anders.

<rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type

page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
platform/PlugInInfoStore.h:
platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType. (PlugInInfoStore::pluginNameForMIMEType):
platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
platform/qt/PlugInInfoStoreQt.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory pluginNameForMIMEType:]): Added.

5:44 PM Changeset in webkit [28425] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

5:40 PM Changeset in webkit [28424] by sfalken@apple.com

1 copy in tags/Safari-523.12.11b

New tag.

5:08 PM Changeset in webkit [28423] by adele@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Adjust outline-offset so it doesn't extend beyond the border to interfere with typing

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

fast/forms/textfield-outline.html: Added.
platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
platform/mac/fast/forms/textfield-outline-expected.png: Added.
platform/mac/fast/forms/textfield-outline-expected.txt: Added.

5:05 PM Changeset in webkit [28422] by adachan@apple.com

6 edits in trunk/WebKit/win

Provide API for setting the default storage quota per database origin

Reviewed by Jon.

Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): default database quota is 5MB (WebPreferences::longlongValueForKey): (WebPreferences::setLongLongValue): (WebPreferences::defaultDatabaseQuota): (WebPreferences::setDefaultDatabaseQuota):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.

4:46 PM Changeset in webkit [28421] by andersca@apple.com

3 edits in trunk/WebCore

Reviewed by Jon.

Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
result streams, even if the JavaScript expression threw an exception or returned undefined.
This matches what Firefox does.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream): Handle the result string being null, and set the correct NPReason if it is.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Always send the JavaScript stream, regardless of the result could be converted to a string or not.

4:30 PM Changeset in webkit [28420] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe

Tweaked the way we typedef and cast these objc_msgSend calls

WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong):

4:23 PM Changeset in webkit [28419] by weinig@apple.com

3 edits in trunk/WebKitTools

Rubber stamped by Mark Rowe.

Define CF as platform for mac and revert r28409

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/mac/DumpRenderTreeMac.h:

4:14 PM Changeset in webkit [28418] by weinig@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
as it is no longer crashing. <rdar://problem/5507278>

platform/win/Skipped:

4:08 PM Changeset in webkit [28417] by adele@apple.com

7 edits
4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5622464> controls should show up for audio element

css/html4.css: Added styles for audio controls. This will need to be refined, since we may want a different look for audio controls.
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary. (WebCore::HTMLMediaElement::rendererIsNeeded): Added. (WebCore::HTMLMediaElement::createRenderer): Added. Uses RenderMedia.
html/HTMLMediaElement.h:
rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
rendering/RenderMedia.h:

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5622464> controls should show up for audio element

media/audio-controls-rendering.html: Added.
platform/mac/media/audio-controls-rendering-expected.checksum: Added.
platform/mac/media/audio-controls-rendering-expected.png: Added.
platform/mac/media/audio-controls-rendering-expected.txt: Added.

4:01 PM Changeset in webkit [28416] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Brady Eidson (with help from Mark Rowe)

Fixed return values for unsigned-long-long delegate methods

WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): redid the change that Brady did at home over the weekend but forgot to check in

3:53 PM Changeset in webkit [28415] by andersca@apple.com

5 edits in trunk

JavaScriptCore:

Reviewed by Sam.

Make isSafeScript const.

kjs/JSGlobalObject.h: (KJS::JSGlobalObject::isSafeScript):

WebCore:

Reviewed by Sam.

Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
implementation, which always returns true(!).

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Make the static isSafeScript method take two JSGlobalObjects.

bindings/js/kjs_window.h: (KJS::Window::isSafeScript): Implement isSafeScript and have it call the static method.

3:40 PM Changeset in webkit [28414] by weinig@apple.com

2 edits in trunk/WebKitTools

Define CF as platform for windows.

Reviewed by Adam Roben.

DumpRenderTree/win/DumpRenderTreeWin.h:

3:19 PM Changeset in webkit [28413] by kmccullough@apple.com

5 edits in trunk

WebKit/win:

Reviewed by Adam and Darin.

Fixed a crasher where the top of the stack was not updated correctly. And set the eol style on IWebScriptCallFrame.idl file.

Interfaces/IWebScriptCallFrame.idl:
WebScriptDebugger.cpp: (WebScriptDebugger::atStatement): (WebScriptDebugger::leaveFrame):

WebKitTools:

Reviewed by Adam and Darin.

Removed a needless BSTR cleanup.

Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformCurrentFunctionStack):

2:54 PM Changeset in webkit [28412] by Adam Roben

10 edits in trunk

Hook up the authorAndUserStylesEnabled preference on Windows

WebKit/win:

Hook up the authorAndUserStylesEnabled preference

This is the Windows counterpart of r28071.

Reviewed by Maciej.

Interfaces/IWebPreferencesPrivate.idl: Added new method declarations.
WebPreferenceKeysPrivate.h: Added a new preference key.
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Set the default for the new preference. (WebPreferences::setAuthorAndUserStylesEnabled): Added. (WebPreferences::authorAndUserStylesEnabled): Added.
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): Communicate the new preference down to WebCore::Settings.

WebKitTools:

Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT

Reviewed by Maciej.

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.

LayoutTests:

Remove a now-passing test from the Windows Skipped file

Reviewed by Maciej.

platform/win/Skipped:

2:52 PM Changeset in webkit [28411] by Adam Roben

15 edits in trunk

Make the implementation of Frame::setNeedsReapplyStyles cross-platform

WebCore:

Make the implementation of Frame::setNeedsReapplyStyles cross-platform

Reviewed by Hyatt.

No change in functionality.

page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the FrameView so that FrameView::layout will be called, which ends up calling reapplyStyles. (WebCore::Frame::needsReapplyStyles): Added. (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration. (WebCore::FramePrivate::FramePrivate):
page/Frame.h:
page/FramePrivate.h: Added new boolean member.
page/FrameView.cpp: (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed. (WebCore::FrameView::needsLayout): Say that we need layout if the Frame needs styles reapplied.
page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for rename.

bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
page/gtk/FrameGtk.cpp: Ditto.
page/mac/FrameMac.mm: Ditto.
page/qt/FrameQt.cpp: Ditto.
platform/wx/TemporaryLinkStubs.cpp: Ditto.

WebKit/mac:

Remove -[WebFrameBridge setNeedsReapplyStyles]

This functionality is now WebCore's responsibility.

Reviewed by Hyatt.

WebCoreSupport/WebFrameBridge.mm:
WebKit.order:

2:40 PM Changeset in webkit [28410] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

2:28 PM Changeset in webkit [28409] by alp@webkit.org

2 edits in trunk/WebKitTools

2007-12-04 Alp Toker <alp@atoker.com>

Prospective Win DRT build fix.

DumpRenderTree/DumpRenderTree.h:

1:46 PM Changeset in webkit [28408] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Adele.

Pass intrinsic size to the base class.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):

1:38 PM Changeset in webkit [28407] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/Interfaces.vcproj

Build fix.

1:15 PM Changeset in webkit [28406] by Adam Roben

2 edits in tags/Safari-525.2.3b/WebKit/win

Merge r28391

2007-12-04 Adam Roben <Adam Roben>

Windows build fix

WebScriptCallFrame.cpp:

1:12 PM Changeset in webkit [28405] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2007-12-04 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

Don't crash if our JavaPlugin DLL can't be found

WebFrame.cpp: (WebFrame::createJavaAppletWidget): Added null check

1:11 PM Changeset in webkit [28404] by sullivan@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Darin

Added deleteOrigin: SPI, which isn't fully implemented

Storage/WebDatabaseManagerPrivate.h:
Storage/WebDatabaseManager.mm: (-[WebDatabaseManager deleteOrigin:]): just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too

1:11 PM Changeset in webkit [28403] by adele@apple.com

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey

loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload.

1:04 PM Changeset in webkit [28402] by Adam Roben

1 copy in tags/Safari-525.2.3b

New tag.

12:26 PM Changeset in webkit [28401] by timothy@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Remove a check for early versions of Leopard CFNetwork now that
Leopard has shipped.

Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
WebView/WebView.mm: (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.

11:56 AM Changeset in webkit [28400] by kdecker@apple.com

2 edits in trunk/WebKit/mac

2007-12-04 Kevin Decker <kdecker@apple.com>

Reviewed by Darin.

Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

This fix is exactly the same as chageset 28359 with the exception of an added early return in
updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.

The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
regardless of whether or not it actually needs to draw.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function. Also tweaked a comment and added an early return if the plug-in can't draw.

11:47 AM Changeset in webkit [28399] by Darin Adler

22 edits in trunk

WebCore:

Reviewed by Kevin Decker.

added an assertion for a situation that leads to a Safari assertion: a commit that is not followed by a load completion

removed some unneeded FrameLoader stuff -- maybe some day we'll get this class cut down to size

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Added boolean for assertion. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert that we already sent a commit before sending a complete. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::loadItem): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing state from Settings instead of FrameLoaderClient. Also call client directly instead of indirecting through a function. (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert that we did not yet send a commit and set the flag that will be used to check that we don't do this twice in a row without an intervening completion call.

loader/FrameLoader.h: Added a boolean for the assertion. Removed six now-unneeded functions.

loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get the private browsing state from Settings instead of FrameLoaderClient.

svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.

WebKit/gtk:

Reviewed by Kevin Decker.

WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
WebCoreSupport/FrameLoaderClientGtk.h: Ditto.

WebKit/mac:

Reviewed by Kevin Decker.

WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
WebKit.order: Ditto.

WebKit/qt:

Reviewed by Kevin Decker.

WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
WebCoreSupport/FrameLoaderClientQt.h: Ditto.

WebKit/win:

Reviewed by Kevin Decker.

WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
WebFrame.h: Ditto.

WebKit/wx:

Reviewed by Kevin Decker.

WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
WebKitSupport/FrameLoaderClientWx.h: Ditto.

11:46 AM Changeset in webkit [28398] by timothy@apple.com

1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update StringsNotToBeLocalized.txt.

11:21 AM Changeset in webkit [28397] by Antti Koivisto

13 edits
4 adds in trunk

WebCore:

Reviewed by Adele.

Fix <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified

Explicitly adjust size of the controls tree root.
Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree by hand. This also allows better code sharing with other replaced element classes.
Move duplicated layout and painting code from subclasses up to RenderReplaced.

Test: media/video-controls-rendering.html

rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
rendering/RenderHTMLCanvas.h:

Share code.

rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::minimumReplacedHeight):
rendering/RenderImage.h:

Share code.

rendering/RenderMedia.cpp: (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):

Add a subclass just to get through encapsulation to use setParent().

(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):

Move initialization to the constructor.

(WebCore::RenderMedia::RenderMedia):
(WebCore::RenderMedia::~RenderMedia):
(WebCore::RenderMedia::layout):

Resize and layout the controller root by hand.

(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
(WebCore::RenderMedia::removeChild):

Support one child renderer for controls.

(WebCore::RenderMedia::createControlsShadowRoot):

rendering/RenderMedia.h: (WebCore::RenderMedia::isMedia):

Switch base class to RenderReplaced, delete the now unnecessary stuff.

rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint):
rendering/RenderReplaced.h: (WebCore::RenderReplaced::minimumReplacedHeight): (WebCore::RenderReplaced::paintReplaced):

Share code.

rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoSizeChanged):

Simplify, just request relayout.

(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):

rendering/RenderVideo.h:

Share code.

LayoutTests:

Reviewed by Adele.

Test for <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified

media/remove-from-document.html: Improve coverage by doing relayout before finishing.
media/video-controls-rendering.html: Added.
platform/mac/media/video-controls-rendering-expected.checksum: Added.
platform/mac/media/video-controls-rendering-expected.png: Added.
platform/mac/media/video-controls-rendering-expected.txt: Added.

11:10 AM Changeset in webkit [28396] by alp@webkit.org

4 edits in trunk

2007-12-04 Michael Natterer <mitch@imendio.com>

Reviewed by Alp Toker.

WebCore.pro: fix build of webkit-marshal by building the functions into a separate .cpp file instead of including them in the header. This way we can use the marshallers from more than one file without using bad hacks.

Add the generated sources directory to DEPENDPATH.

11:08 AM Changeset in webkit [28395] by Darin Adler

5 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

fix first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)

Test: fast/js/regexp-overflow.html

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that was generated in the compile code but not taken into account here.

LayoutTests:

Reviewed by Geoff.

test for first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)

fast/js/regexp-overflow-expected.txt: Updated.
fast/js/resources/regexp-overflow.js: Added test cases.

10:52 AM Changeset in webkit [28394] by Adam Roben

1 edit in tags/Safari-525.2.2b/WebKit/win/WebKit.vcproj/WebKit.make

Merge r28392

10:36 AM Changeset in webkit [28393] by sfalken@apple.com

1 copy in tags/Safari-525.2.2b

New tag.

10:28 AM Changeset in webkit [28392] by sfalken@apple.com

1 edit in trunk/WebKit/win/WebKit.vcproj/WebKit.make

Build fix.

10:27 AM Changeset in webkit [28391] by Adam Roben

2 edits in trunk/WebKit/win

Windows build fix

WebScriptCallFrame.cpp:

9:58 AM Changeset in webkit [28390] by alp@webkit.org

2 edits in trunk/WebKitSite

2007-12-04 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Link to Planet WebKit.

nav.inc:

8:50 AM Changeset in webkit [28389] by alp@webkit.org

5 edits
2 adds in trunk/WebCore

2007-12-04 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend

This implements the media tags of HTML5 on the GTK+ port based on the
Mac port. Media tests pass although some tests required a small modifications:
As per the HTML5 spec, the loading of the clip should start only after
all script are done. But in the case of the tests, the loading starts
before some callbacks get registered. This has been discussed with
Antti Koivisto, and the tests should be updated.

There is only one known issue: one time in 10 tries, loading a buffered
clip will never end buffering. The buffering will stall at 97% for no
apparent reasons. Reloading the page usually works around the problem.
On the GStreamer side, some codecs don't return correct values, therefore
they make the tests fail. For instance H.264 will make the video-end
test fail. This should be fixed in GStreamer 0.10.15.

This version displays video in a pop up window. A place holder is drawn
on the page where the video should appear.

By default, it is turned off in WebCore.pro until GStreamer/X
detection issues are sorted out.

WebCore.pro: Disable video for now
platform/Logging.cpp: (WebCore::):
platform/Logging.h: Added a logging level for Media stuff
platform/graphics/Movie.cpp:
platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added. (WebCore::moviePrivateErrorCallback): (WebCore::moviePrivateEOSCallback): (WebCore::moviePrivateStateCallback): (WebCore::moviePrivateBufferingCallback): (WebCore::moviePrivateWindowIDCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::loadingFailed): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (WebCore::MoviePrivate::createGSTPlayBin):
platform/graphics/gtk/MoviePrivateGStreamer.h: Added.

6:12 AM Changeset in webkit [28388] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-12-04 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

Fix a regression in key press propagation in r28386.

Fix indentation (was off by two spaces).

WebView/webkitwebview.cpp:

5:48 AM QtWebKitTodo edited by zecke2@selfish.org

(diff)

5:43 AM QtWebKitTodo edited by zecke2@selfish.org

(diff)

5:27 AM QtWebKitTodo edited by zecke2@selfish.org

CallOnMainThread is done, IconDataBase is outstanding (diff)

5:19 AM Changeset in webkit [28387] by zecke@webkit.org

2 edits in trunk

Add the missing ChangeLog entries for r28349.

WebCore/ChangeLog:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Simon.

Implement the InspectorClient for the Qt port
It does not support highlighting of nodes yet
Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
To make the InspectorClient work we will have to mark qrc as secure.

WebCore.pro:
loader/FrameLoader.cpp: (WebCore::localSchemes):
page/inspector/WebKit.qrc: Added.

WebKit/qt:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Simon.

Implement the InspectorClient for the Qt port
It does not support highlighting of nodes yet
Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
To make the InspectorClient work we will have to mark qrc as secure.

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
Api/qwebpage.h:
WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::hideEvent): (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::localizedStringsURL): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow):
WebCoreSupport/InspectorClientQt.h:

5:14 AM Changeset in webkit [28386] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-12-04 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15911
[GTK] Use GtkBindingSet to make key bindings user-configurable

This patch doesn't cover the full range of bindings, only the ones
that seem obviously correct and have clear public API.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
WebView/webkitwebview.h:

4:34 AM Changeset in webkit [28385] by alp@webkit.org

2 edits in trunk/WebKitTools

2007-12-04 Alp Toker <alp@atoker.com>

Fix a clobbered copyright header.

DumpRenderTree/gtk/DumpRenderTree.cpp:

4:16 AM Changeset in webkit [28384] by alp@webkit.org

7 edits
7 adds in trunk

2007-12-04 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15561
GTK port needs DumpRenderTree implementation

Start work on the GTK+ DRT.

This does not work yet, and there are a few lingering style issues
(nothing major) but this patch has been stuck in the bug tracker for
too long already.

12:40 AM Changeset in webkit [28383] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>).

12:31 AM Changeset in webkit [28382] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-04 Alp Toker <alp@atoker.com>

Rubber stamped by Mark Rowe.

Remove two unused variables to silence warnings.

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke):

Dec 3, 2007:

11:35 PM Changeset in webkit [28381] by pewtermoose@webkit.org

2 edits in trunk/PlanetWebKit

Rubberstamped by Tim.

Make the bullets lickable.

wwwroot/planetwebkit.css:

11:19 PM Changeset in webkit [28380] by pewtermoose@webkit.org

2 edits
4 adds in trunk/PlanetWebKit

Reviewed by Adam.

Make it sexy with awesome icon and tweaks from Tim.

templates/index.html.tmpl:
wwwroot/ie.css: Added.
wwwroot/images/ie-nav-blue.png: Added.
wwwroot/planetwebkit.css: Added.

10:59 PM Changeset in webkit [28379] by ddkilzer@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Added bug reference.

9:35 PM Changeset in webkit [28378] by Adam Roben

1 copy in tags/Safari-525.2.1b

New tag.

9:17 PM Changeset in webkit [28377] by weinig@apple.com

2 edits
2 moves
4 adds in trunk/WebKitTools

Move JavaScriptCore thread testing code to pthread specific directory
and remove the dependance on CoreFoundation by using WTF::HashSet.

Reviewed by Geoff and Oliver.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
DumpRenderTree/mac/JavaScriptThreading.h: Removed.
DumpRenderTree/pthreads: Added.
DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads):

8:59 PM Changeset in webkit [28376] by Adam Roben

1 copy in tags/Safari-525.2b

New tag.

8:57 PM Changeset in webkit [28375] by Adam Roben

2 edits in trunk/WebKit/win

Versioning.

5:08 PM Changeset in webkit [28374] by mitz@apple.com

2 edits in trunk/WebKitTools

2007-12-03 Andrew Bonventre <andybons@google.com>

Reviewed by Darin Adler.

Drosera/debugger.js: Fixed javascript error where document property should have been used instead of contentDocument in switchFunction that was breaking the select symbol dropdown menu. This is because window.frames will return a Window object and not a frame object like the author was originally expecting.

4:44 PM Changeset in webkit [28373] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/Interfaces.vcproj

Build fix.

4:28 PM Changeset in webkit [28372] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleWidth): Do not return negative values. (WebCore::ScrollView::visibleHeight): Ditto.

LayoutTests:

Reviewed by Darin Adler.

remove passing test

platform/win/Skipped:

4:25 PM Changeset in webkit [28371] by mitz@apple.com

13 edits
2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

Test: fast/events/resize-subframe.html

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when deferring tasks that need to be done after layout. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Moved the updating of widget positions, loading plug-ins and sending events queued up during layout into performPostLayoutTasks(). performPostLayoutTasks() is called after layout unless the layout was triggered by a previous layout's post- layout tasks. In the latter case, performPostLayoutTasks() is scheduled to run later. (WebCore::FrameView::performPostLayoutTasks): Performs work that needs to be done after layout but which can result in arbitrary code execution and therefore may re-invalidate the layout. This includes updating widget positions, loading plug-ins, and dispatching layout- related DOM events (scroll, overflow and resize). (WebCore::FrameView::postLayoutTimerFired): (WebCore::FrameView::dispatchScheduledEvents):
page/FrameView.h:
page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this is handled by FrameView now.

WebKit/gtk:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since FrameView sends it now.

WebKit/mac:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code that checked if the view had resized and sent the resize event, since FrameView sends resize events now.
WebView/WebHTMLViewInternal.h:

WebKit/win:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView.cpp: (WebViewWndProc): Removed call to sendResizeEvent() since FrameView sends them now.

LayoutTests:

Reviewed by Dave Hyatt.

test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

fast/events/resize-subframe-expected.txt: Added.
fast/events/resize-subframe.html: Added.

2:56 PM Changeset in webkit [28370] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

Test: fast/js/recursion-limit-equal.html

kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive.

LayoutTests:

Reviewed by Geoff.

test for http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

fast/js/recursion-limit-equal-expected.txt: Added.
fast/js/recursion-limit-equal.html: Added.
fast/js/resources/recursion-limit-equal.js: Added.

2:15 PM Changeset in webkit [28369] by kmccullough@apple.com

12 edits
2 deletes in trunk

WebKit/win:

Reviewed by Adam.

<rdar://5618942> Drosera: Console window does not process everything correctly.
<rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.

Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup functions from WebScriptScope to here.
Interfaces/WebKit.idl: Removed WebScriptScope.
WebKit.vcproj/Interfaces.vcproj: Ditto.
WebKit.vcproj/WebKit.vcproj: Ditto.
WebKit.vcproj/WebKitGUID.vcproj: Ditto.
WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now returns a string value for things that are not strings. (WebScriptCallFrame::variableNames): Moved from WebScriptScope. (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope. (WebScriptCallFrame::jsValueToString): Helper functions that converts any JSValue to a String.
WebScriptCallFrame.h: Moved WebScriptScope functionality into here.
WebScriptDebugger.cpp: Added nested guards so that Drosera does not receive notifications about JavaScript that Drosera is running just the JavaScript WebKit is running. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception):
WebScriptDebugger.h: Ditto.
WebScriptScope.cpp: Removed.
WebScriptScope.h: Removed.

WebKitTools:

Reviewed by Adam.

<rdar://5618942> Drosera: Console window does not process everything correctly.
<rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.

Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):

2:14 PM Changeset in webkit [28368] by mitz@apple.com

2 edits in trunk/JavaScriptCore

fix a copy-and-paste-o

bindings/npruntime.cpp: (_NPN_GetIntIdentifier):

2:12 PM Changeset in webkit [28367] by Stephanie Lewis

2 edits in trunk/WebKitTools

Check to see if we are building a debug root

Scripts/check-for-global-initializers:

2:07 PM Changeset in webkit [28366] by mitz@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

fix an ASSERT when getIntIdentifier is called with 0 or -1

bindings/npruntime.cpp: (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since they are the empty value and the deleted value. Instead, keep the identifiers for those two integers in a static array.

WebKitTools:

Reviewed by Darin Adler.

added a testGetIntIdentifier() method to TestNetscapePlugIn

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):

LayoutTests:

Reviewed by Darin Adler.

added a test of the behavior of getIntIdentifier with the integers 0 and -1

plugins/getintidentifier-special-values-expected.txt: Added.
plugins/getintidentifier-special-values.html: Added.

1:43 PM Changeset in webkit [28365] by timothy@apple.com

6 edits in trunk/WebKit/mac

Reviewed by Darin.

Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
to return a pointer to the implementation struct instead of a copy of the struct. This changes
all of the callers to dereference the pointer to access the struct fields.

Plugins/WebNullPluginView.mm: (-[WebNullPluginView reportFailure]):
WebCoreSupport/WebFrameBridge.mm:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout):
WebView/WebView.mm: (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
WebView/WebViewInternal.h:

1:37 PM Changeset in webkit [28364] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix the build, move JSDOMWindow.h to the Copy Generated Headers phase.

1:25 PM Changeset in webkit [28363] by rwlbuis@webkit.org

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15767
Text decorations do not respect "visibility" property

Only paint decorations if visibility is "visible".

12:35 PM Changeset in webkit [28362] by timothy@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Brady Eidson.

<rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
<rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
<rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
WebViewGetResourceLoadDelegateImplementations + 28

WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the implementation cache. This just prevents us from calling getMethod() multiple times just to zero. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto. (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct if the WebView is nil. This fixes the crashes. (WebViewGetFrameLoadDelegateImplementations): Ditto.

12:24 PM Changeset in webkit [28361] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing passing tests

platform/win/Skipped:

11:55 AM Changeset in webkit [28360] by sfalken@apple.com

2 edits in trunk/WebCore

Fix build.

WebCore.vcproj/WebCore.vcproj:

11:47 AM Changeset in webkit [28359] by kdecker@apple.com

2 edits in trunk/WebKit/mac

i Reviewed by Darin.

Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
and provide a valid graphics context regardless of whether or not it actually needs to draw.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.

11:19 AM Changeset in webkit [28358] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/PRODUCTVERSION

Bump version.

10:57 AM Changeset in webkit [28357] by Nikolas Zimmermann

3 edits
4 adds in trunk

Reviewed by David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15645
Don't allow selectors to interfere with the SVG shadow tree (<use> internal non-exposed tree).

10:44 AM Changeset in webkit [28356] by Nikolas Zimmermann

12 edits in trunk/LayoutTests

Rubber stamped by Mark.
Commit missing layout test results from my last commit (fix for bug 15403)

10:09 AM Changeset in webkit [28355] by zecke@webkit.org

2 edits in trunk/WebKit/qt

2007-12-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Mark.

Always include config.h at the beginning of the file.

Api/qwebsettings.cpp:

10:09 AM Changeset in webkit [28354] by mitz@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed by Adam Roben.

fix <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

Test: fast/dom/Document/replaceChild-null-oldChild.html

dom/Document.cpp: (WebCore::Document::canReplaceChild):

LayoutTests:

Reviewed by Adam Roben.

test for <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

fast/dom/Document/replaceChild-null-oldChild-expected.txt: Added.
fast/dom/Document/replaceChild-null-oldChild.html: Added.
fast/dom/Document/resources/replaceChild-null-oldChild.js: Added.

10:05 AM Changeset in webkit [28353] by zecke@webkit.org

8 edits in trunk

Avoid crashes by making sure everything is layouted before we start painting. This avoids a crash in Widget::invalidateRect because QPainter::begin would fail
The QWebFrame::layout() methods and calls are left untouched because this would be an API decision.

Signed-off-by: Simon

10:02 AM Changeset in webkit [28352] by zecke@webkit.org

2 edits in trunk/WebCore

Implement GraphicsContext::fillRoundedRect similiar to the CoreGraphics implementation only addPath is not called this seems to be only needed for CoreGraphics.

Signed-off-by: Simon

10:01 AM Changeset in webkit [28351] by zecke@webkit.org

2 edits in trunk/WebKit/qt

SubClass QWebPage to handle hide and close events.
Forward these events to the InspectorController
The other options would have been using an eventFilter on the webpage and making InspectorClient a QObject or creating a QObject Observer.
Provide a simple QWebPage* createWindow implementation. This is needed to make FrameLoaderClientQt::dispatchCreatePage stop crashing in the case of the inspector client.

Signed-off-by: Simon

10:01 AM Changeset in webkit [28350] by zecke@webkit.org

2 edits in trunk/WebCore

Coding Style fixes

Signed-off-by: Simon

10:00 AM Changeset in webkit [28349] by zecke@webkit.org

6 edits
1 add in trunk

Implement the InspectorClient for the Qt port
It does not support highlighting of nodes yet
Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
To make the InspectorClient work we will have to mark qrc as secure.

Signed-off-by: Simon

9:58 AM Changeset in webkit [28348] by zecke@webkit.org

4 edits in trunk/WebKit/qt

Allow adding the Inspect ContextMenuItem to our Menu
Open the Inspector when Inspect was activated. This requires that we keep the innerNonSharedNode from the HitTest around. This forces us to include <wtf/RefPtr.h> in the private header. It is the first non Qt header but should be okay.

Signed-off-by: Simon

9:57 AM Changeset in webkit [28347] by zecke@webkit.org

4 edits in trunk/WebKit/qt

Add the Developer Extras to the WebAttribute and propagate it to WebCore::Settings. This will enable the Inspect Element menu item
CodingStyle fixes in QWebSettings
Enable the Developer Extras in the QtLauncher

Signed-off-by: Simon

7:46 AM Changeset in webkit [28346] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

Test: fast/js/sparse-array.html

kjs/array_instance.cpp: (KJS::ArrayInstance::inlineGetOwnPropertySlot): Check sparse array cutoff before looking in hash map. Can't avoid the branch because we can't look for 0 in the hash. (KJS::ArrayInstance::deleteProperty): Ditto.

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

fast/js/resources/sparse-array.js: Added.
fast/js/sparse-array-expected.txt: Added.
fast/js/sparse-array.html: Added.

4:57 AM Changeset in webkit [28345] by alp@webkit.org

4 edits in trunk/WebCore

2007-12-03 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Don't delete the decoder if it's already been created. The one we have
is fine.

Cairo image cleanups. Nothing substantial.

Notify ImageObservers where appropriate.

platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
platform/graphics/gtk/ImageGtk.cpp:

4:04 AM Changeset in webkit [28344] by Simon Hausmann

2 edits in trunk/WebCore

Fixed crash when rendering form elements with Qt 4.4

QPainter::device() is not guaranteed to return a QWidget, so do the safe "cast" with the
help of QPaintDevice::devType().
Also fall back to the QApplication::style() if we don't have a widget.

2:36 AM Changeset in webkit [28343] by zecke@webkit.org

4 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Sam Weinig.

Add FrameLoader::shouldTreatSchemeAsLocal which is similar to shouldTreatURLAsLocal.
Make use of FrameLoader::shouldTreatSchemeAsLocal in SecurityOrigin and do not hardcode "file". This is needed for the WebKit/qt port to make the Web Inspector work as it using the qrc protocol instead of file.

loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldTreatSchemeAsLocal):
loader/FrameLoader.h:
platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isSecureTransitionTo):

2:34 AM Changeset in webkit [28342] by zecke@webkit.org

2 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Sam Weinig.

Only add applewebdata to the localSchemes when building for the
mac. This is in preparation of adding qrc for the Qt port there
as well and http://bugs.webkit.org/show_bug.cgi?id=15938.

According to Anders applewebdata is not used on the win port.

loader/FrameLoader.cpp: (WebCore::localSchemes):

2:33 AM Changeset in webkit [28341] by zecke@webkit.org

2 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Sam Weinig.

Fix a typo. It is contains and not containts

loader/FrameLoader.cpp:

1:25 AM Changeset in webkit [28340] by mrowe@apple.com

2 edits in trunk/WebKit/win

2007-12-03 Mark Rowe <mrowe@apple.com>

Speculative Windows build fix.

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

1:19 AM Changeset in webkit [28339] by mrowe@apple.com

2 edits in trunk/WebKit/wx

2007-12-03 Mark Rowe <mrowe@apple.com>

wx build fix.

WebView.cpp: (wxWebView::RunScript):

1:10 AM Changeset in webkit [28338] by ap@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Oliver.

Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
in a more fine-grained manner than eventSender.keyDown().

DumpRenderTree/win/EventSender.cpp: (getConstantCallback): (dispatchMessageCallback):

1:05 AM Changeset in webkit [28337] by Adam Roben

2 edits in trunk/WebKit/win

Another speculative Windows build fix

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

12:58 AM Changeset in webkit [28336] by alp@webkit.org

4 edits in trunk

2007-12-03 Alp Toker <alp@atoker.com>

Add another missing DEPENDPATH.

Noticed when fixing the build.

WebCore.pro:

12:52 AM Changeset in webkit [28335] by Adam Roben

2 edits in trunk/WebCore

Speculative Windows build fix

plugins/win/PluginViewWin.cpp: (WebCore::getString):

12:43 AM Changeset in webkit [28334] by Adam Roben

3 edits in trunk/WebKit/win

Speculative Windows build fix

WebFrame.cpp: (WebFrame::globalContext): (WebFrame::windowObjectCleared):
WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):

12:13 AM Changeset in webkit [28333] by ggaren@apple.com

2 edits in trunk/WebKit/qt

Removed unnecessary and possibly incorrect #include from my last
check-in.

Api/qwebframe.cpp:

12:10 AM Changeset in webkit [28332] by ggaren@apple.com

2 edits in trunk/WebKit/gtk

GTK Build fix: get globalExec from the right place.

WebView/webkitwebframe.cpp:

12:06 AM Changeset in webkit [28331] by ggaren@apple.com

2 edits in trunk/WebKit/qt

Qt build fix: Get globalExec() from the right place.

12:02 AM Changeset in webkit [28330] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: added symbols to the right .exp file.

WebCore.base.exp:

Dec 2, 2007:

11:53 PM Changeset in webkit [28329] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/collector.cpp:

11:43 PM Changeset in webkit [28328] by ggaren@apple.com

47 edits
1 add in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

Second step in refactoring JSGlobalObject: moved virtual functions from
Interpreter to JSGlobalObject.

Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
believe his lies.

JavaScriptGlue:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

JSRun.cpp:
JSRun.h:
JSValueWrapper.cpp: (getThreadGlobalExecState):
JavaScriptGlue.cpp: (JSRunCopyGlobalObject): (JSRunEvaluate):

WebCore:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

Moved virtual ScriptInterpreter functions to Window.

WebKit/mac:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

WebView/WebFrame.mm: (-[WebFrame globalContext]): Use the toRef function instead of manually casting.

9:52 PM QtWebKitContrib edited by Simon Hausmann

(diff)

8:57 PM Changeset in webkit [28327] by Darin Adler

17 edits
22 adds in trunk

WebCore:

Reviewed by Mitz.

fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

There were two problems here:

1) Incorrect HTMLCollection behavior led to us trying to insert a

new row inside an existing row instead of next to it. The fix for
this is to make HTMLCollection work better for table-related
collections.

2) HTMLTableRowElement::insertCell would return a bad pointer if

the insertion failed. The code should have failed, but not crashed,
so it's worth fixing that too.

While fixing the HTMLCollection issues, I did some clean-up of that
class and its derived classes.

Test: fast/dom/HTMLTableElement/rows.html
Test: fast/dom/HTMLTableElement/tBodies.html
Test: fast/dom/HTMLTableRowElement/cells.html
Test: fast/dom/HTMLTableRowElement/insertCell.html
Test: fast/dom/HTMLTableSectionElement/rows.html

bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated because collectionType() was renamed to type().

html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Updated for data member name changes. Also added a protected constructor for use by derived classes that pass in a CollectionInfo. (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of the header. (WebCore::isTableSection): Added. (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem, because the old name was grammatically incorrect and thus a bit confusing. Changed to operate on Element* instead of Node*, and use 0 to start rather than passing in the base node (required since the base node can be a document, which is not an element). Generalized the code that made NodeChildren not descend into deeper descendants so it can be used for TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the switch statement and got rid of the "found" boolean since we can just return when we find something. Got rid of the default case, and instead listed all the enum values. Also changed to use a for loop for clarity. (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes. (WebCore::HTMLCollection::item): Ditto. (WebCore::HTMLCollection::nextItem): Ditto. (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element instead of a Node pointer. (WebCore::HTMLCollection::namedItem): More of the same. (WebCore::HTMLCollection::updateNameCache): Ditto. (WebCore::HTMLCollection::namedItems): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto. (WebCore::HTMLCollection::tags): Ditto.

html/HTMLCollection.h: Added a type FormElements, so that the HTMLFormCollection would not have a type of DocImages, which is what it previously did. Changed the base parameter to be a PassRefPtr to make it clear we take ownership of it. Added a comment explaining why we should change the name CollectionInfo. Made a lot more members private instead of protected. Renamed traverseNextItem to itemAfter. Changed most functions to take Element* instead of Node*.

html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Added. (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass collection info into the base class. (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we don't need to get at m_base directly. (WebCore::HTMLFormCollection::item): Same, but for info(). (WebCore::HTMLFormCollection::getNamedItem): Removed unused first argument. (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded checks that the base is still an element and still a form, since that's guaranteed. (WebCore::HTMLFormCollection::nextItem): Use info(). (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of Element, some name changes. (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere. (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop to be much simpler. (WebCore::HTMLFormCollection::updateNameCache): More of the same.

html/HTMLFormCollection.h: Changed constructor to take an HTMLFormElement, using a PassRefPtr to communicate transfer of ownership. Made everything private instead of protected. Removed unneeded override of firstItem. Made getNamedItem and nextNamedItemInternal non-virtual. Removed unused first argument of getNamedItem. Added declaration of formCollectionInfo.

html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass collection info into the base class. (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and changed into a for loop.

html/HTMLNameCollection.h: Updated for name changes. Made function private instead of public. Used PassRefPtr in constructor.

html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to pass collection info into the base class. (WebCore::HTMLOptionsCollection::add): Updated for public/private changes in the base class. (WebCore::HTMLOptionsCollection::selectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setLength): Ditto.

html/HTMLOptionsCollection.h: Changed constructor parameter to be a PassRefPtr.

html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr and PassRefPtr since this creates a new object. This alone fixed the crash. Also cleaned up logic a bit to be more readable.

html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr. Also reordered functions a bit to make things a little more logical and removed the unused ncols data member.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not TableRows. This mistake was harmless before because TableRows and TSectionRows were handled identically inside HTMLCollection, but that is no longer the case with this fix.

bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the fact that HTMLOptionsCollection no longer includes HTMLOptionElement. I don't think this really should be a special case -- might be worth returning later to see if this can be optimized.

LayoutTests:

Reviewed by Mitz.

tests for table-related HTMLCollection classes for misnested tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

fast/dom/HTMLTableElement/resources: Added.
fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableElement/resources/rows.js: Added.
fast/dom/HTMLTableElement/resources/tBodies.js: Added.
fast/dom/HTMLTableElement/rows-expected.txt: Added.
fast/dom/HTMLTableElement/rows.html: Added.
fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
fast/dom/HTMLTableElement/tBodies.html: Added.
fast/dom/HTMLTableRowElement: Added.
fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
fast/dom/HTMLTableRowElement/cells.html: Added.
fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
fast/dom/HTMLTableRowElement/insertCell.html: Added.
fast/dom/HTMLTableRowElement/resources: Added.
fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableRowElement/resources/cells.js: Added.
fast/dom/HTMLTableSectionElement: Added.
fast/dom/HTMLTableSectionElement/resources: Added.
fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
fast/dom/HTMLTableSectionElement/rows.html: Added.

8:41 PM Changeset in webkit [28326] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More planned renaming.

5:05 PM Changeset in webkit [28325] by Nikolas Zimmermann

4 edits in trunk/WebCore

Reviewed by Adam.

RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.

Fixes:

svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
svg/custom/deep-dynamic-updates.svg
svg/custom/use-clipped-hit.svg
svg/custom/image-clipped-hit.svg

3:40 PM Changeset in webkit [28324] by weinig@apple.com

2 edits in trunk/WebKitTools

Rubber stamped by Anders.

Use [NSURL absoluteString] instead of [NSURL description] in order to get
more uniform results cross platform.

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):

3:32 PM Changeset in webkit [28323] by weinig@apple.com

3 edits
2 moves in trunk/WebKitTools

Rubber stamped by Niko.

Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.

DumpRenderTree/win/DumpRenderTree.cpp:
DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
DumpRenderTree/win/FrameLoaderDelegate.h: Removed.

12:20 PM Changeset in webkit [28322] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Darin

databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
like all other notifications we send out!

platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
platform/SecurityOriginData.h:

storage/DatabaseTracker.cpp: (WebCore::notificationMutex): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications on the main thread (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
storage/DatabaseTracker.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!" (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto

12:18 PM WebKit Team edited by rwlbuis@webkit.org

(diff)

11:32 AM Changeset in webkit [28321] by rwlbuis@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16002
Load SVG (and other) UA StyleSheets dynamically when needed

Load svg sheet when needed.

6:13 AM QtWebKitTodo edited by Simon Hausmann

(diff)

4:59 AM Changeset in webkit [28320] by mrowe@apple.com

2 edits in trunk/WebCore

Speculative Windows build fix.

4:02 AM Changeset in webkit [28319] by Nikolas Zimmermann

4 edits
31 copies
1 move in trunk/WebCore

Rubber stamped by Eric.

Move platform/graphics/svg to graphics/svg as discussed on webkit-dev.
Updated all project files.

3:22 AM Changeset in webkit [28318] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Maciej.
Fix IDL lookup in subdirectories. Missing 'my' prefix for the 'thisDir' variable.

3:08 AM BuildingGtk edited by alp@atoker.com

Mention the Debian WebKit packaging team and its mailing lists (diff)

12:32 AM Changeset in webkit [28317] by Adam Roben

1 edit
1 add in trunk/WebKitSite

Add another screenshot

blog-files/InspectElementMenu.png: Added.

12:16 AM Changeset in webkit [28316] by alp@webkit.org

7 edits
1 add in trunk

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
takes care of extern "C".

Introduce a webkit.h convenience header.

Remove another left-over from the old API.

12:07 AM Changeset in webkit [28315] by Adam Roben

2 edits
2 adds in trunk/WebKitSite

Add some Inspector screenshots for an upcoming blog post

Rubberstamped by Mark Rowe.

blog-files/InspectorCSSEditing.png: Added.
blog-files/InspectorFonts.png: Added.

Dec 1, 2007:

11:56 PM Changeset in webkit [28314] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Tim

Added a default database quota of 5mb to the default WebPreferences

WebView/WebPreferences.m: (+[WebPreferences initialize]):

10:43 PM Changeset in webkit [28313] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=15687
[Gtk] Allow API clients to interact with JavaScript in web pages

Include the necessary JavaScriptCore headers directly in the public
API headers.

This is the last of a series of changes needed to allow GTK+
applications to access the JS API.

Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
developers will still have to include the individual JS API headers
individually if they want to use it in their applications.

Patch also removes some old legacy use of GDK that was in
WebKitWebFrame. No ABI change.

WebView/webkitdefines.h:
WebView/webkitwebframe.h:
WebView/webkitwebview.h:

10:14 PM Changeset in webkit [28312] by Antti Koivisto

3 edits
4 adds in trunk

WebCore:

Reviewed by Adam.

Fix a crash when removing a loading media element from the tree.
Follow the spec by invoking pause() when element is removed from the tree instead of unloading.

Tests: http/tests/media/remove-while-loading.html

media/remove-from-document.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

Reviewed by Adam.

Test that removing a media element when it is loading does not crash.
Test that media is paused when it is removed from the tree.

http/tests/media/remove-while-loading-expected.txt: Added.
http/tests/media/remove-while-loading.html: Added.
media/remove-from-document-expected.txt: Added.
media/remove-from-document.html: Added.

9:24 PM Changeset in webkit [28311] by alp@webkit.org

3 edits in trunk/JavaScriptCore

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT

Add JS_EXPORT to kJSClassDefinitionEmpty.

Make the gcc compiler check take precedence over the WIN32

_WIN32

check to ensure that symbols are exported on Windows when using gcc.

Add a TODO referencing the bug about JS_EXPORT in the Win build
(http://bugs.webkit.org/show_bug.cgi?id=16227)

Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:

extern extern const JSClassDefinition kJSClassDefinitionEmpty;

(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)

API/JSBase.h:
API/JSObjectRef.h:

3:59 PM Changeset in webkit [28310] by ggaren@apple.com

2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Restored the test string in this test.

manual-tests/window-open-features-parsing.html:

3:56 PM Changeset in webkit [28309] by ggaren@apple.com

25 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.

Reversed the ownership relationship between Interpreter and JSGlobalObject.
Now, the JSGlobalObject owns the Interpreter, and top-level objects
that need the two to persist just protect the JSGlobalObject from GC.

Global object bootstrapping looks a little odd right now, but it will
make much more sense soon, after further rounds of refactoring.

bindings/runtime_root.h: Made this class inherit from RefCounted, to avoid code duplication.

kjs/collector.cpp: (KJS::Collector::collect): No need to give special GC treatment to Interpreters, since we mark their global objects, which mark them.

kjs/interpreter.cpp: (KJS::Interpreter::mark): No need to mark our global object, since it marks us.
kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject owns us directly.

kjs/testkjs.cpp: Modified to follow the new rules. (createGlobalObject): (runWithScripts):

JavaScriptGlue:

Reviewed by Beth Dakin.

Modified to follow new JSGlobalObject/Interpreter ownership rules
in JavaScriptCore.

JSRun.cpp: (JSRun::JSRun): (JSRun::GetInterpreter): (JSRun::Evaluate): (JSRun::CheckSyntax):
JSRun.h:
JSValueWrapper.cpp: (unprotectGlobalObject): (initializeGlobalObjectKey): (getThreadGlobalExecState):

WebCore:

Reviewed by Beth Dakin.

Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
rules in JavaScriptCore.

bindings/js/kjs_binding.cpp:
bindings/js/kjs_binding.h: Removed stale, unused interpreterForGlobalObject().

bindings/js/kjs_proxy.cpp: Changed to store a global object, rather than an interpreter. (WebCore::KJSProxy::finishedWithEvent): Need to NULL check m_globalObject here because we no longer unnecessarily instantiate it.

bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
bindings/js/kjs_window.h: Removed redundant and less efficient interpreter() function -- global objects have direct access to their interpreters now.

Changed these functions to pass around JSGlobalObjects instead of
Interpreters:

page/Frame.cpp: (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject):
page/Frame.h:
page/mac/WebCoreFrameBridge.mm: (createRootObject):

3:35 PM Changeset in webkit [28308] by treat@webkit.org

2 edits in trunk/WebKitTools

Check to see if the directory exists and exit if not.

2:32 PM BuildingGtk edited by alp@atoker.com

Add links to distribution packages (diff)

2:29 PM Changeset in webkit [28307] by weinig@apple.com

4 edits in trunk/WebKit/win

Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.

Rubber stamped by Adam Roben.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::selectionRect):
WebView.h:

2:15 PM Changeset in webkit [28306] by mitz@apple.com

2 edits in trunk/PlanetWebKit

Reviewed by Mark Rowe.

config.ini: Correct blog name.

1:08 PM Changeset in webkit [28305] by timothy@apple.com

1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update StringsNotToBeLocalized.txt.

11:43 AM UsingGitWithWebKit edited by Adam Roben

(diff)

11:04 AM Changeset in webkit [28304] by Darin Adler

3 edits in trunk/WebCore

Reviewed by Mitz.

fix problem tracked by these bugs: http://bugs.webkit.org/show_bug.cgi?id=16097 <rdar://problem/5619305> Safari crashes during load of LexisNexis search results <rdar://problem/5510779> CrashTracer: [USER] 25 crashes in Safari at WebCore::DocumentLoader::isLoadingMultipartContent const

loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement instead of an HTMLImageElement. (WebCore::ImageDocument::scale): Added a null check for m_imageElement. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto. (WebCore::ImageDocument::windowSizeChanged): Ditto. (WebCore::ImageDocumentElement::~ImageDocumentElement): Call disconnectImageElement so m_imageElement will be set to 0 if we're still connected to the document. (WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.

loader/ImageDocument.h: Changed image element type to be ImageDocumentElement instead of HTMLImageElement. Also added a disconnectImageElement function that sets m_imageElement to 0.

10:44 AM Changeset in webkit [28303] by Darin Adler

1 edit
1 delete in trunk/WebCore

remove the empty directories

ksvg2: Removed.
ksvg2/css: Removed.
ksvg2/events: Removed.
ksvg2/misc: Removed.
ksvg2/scripts: Removed.

10:09 AM Changeset in webkit [28302] by Darin Adler

1 edit in trunk/SunSpider/hosted

Ignore another file that's now part of hosted SunSpider.

8:51 AM Changeset in webkit [28301] by mrowe@apple.com

5 edits in trunk

2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader):

Test: http/tests/xmlhttprequest/set-dangerous-headers.html

2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers

8:41 AM Changeset in webkit [28300] by mrowe@apple.com

3 edits in trunk/WebCore

2007-12-01 Rahul Abrol <ra5ul@comcast.net>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().

bindings/js/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures):
manual-tests/window-open-features-parsing.html:

8:33 AM Changeset in webkit [28299] by mitz@apple.com

7 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

Test: fast/dynamic/subtree-common-root.html

page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added a parameter to let this method return the layout root for a pending layout as well. (WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root to markContainingBlocksForLayout(). Otherwise, markContainingBlocksForLayout() could mark past the new root, if it had previously been marked as having a normal child needing layout and then was reached via a positioned child.
page/FrameView.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth):
rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that it would really catch deletion of the layout root. (WebCore::RenderObject::markContainingBlocksForLayout): Added the newRoot parameter, which tells this method where to stop marking.
rendering/RenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

fast/dynamic/subtree-common-root-expected.txt: Added.
fast/dynamic/subtree-common-root.html: Added.

8:28 AM Changeset in webkit [28298] by mitz@apple.com

29 edits
1 delete in trunk/WebCore

Reviewed by Darin Adler.

fold FontStyle into TextRun

WebCore.xcodeproj/project.pbxproj:
platform/graphics/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
platform/graphics/Font.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setText): (WebCore::TextRun::allowTabs): (WebCore::TextRun::xPos): (WebCore::TextRun::padding): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::directionalOverride): (WebCore::TextRun::applyRunRounding): (WebCore::TextRun::applyWordRounding): (WebCore::TextRun::spacingDisabled): (WebCore::TextRun::disableSpacing): (WebCore::TextRun::disableRoundingHacks): (WebCore::TextRun::setRTL): (WebCore::TextRun::setDirectionalOverride):
platform/graphics/FontStyle.h: Removed.
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
platform/graphics/GraphicsContext.h:
platform/graphics/StringTruncator.cpp: (WebCore::stringWidth):
platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/graphics/qt/FontQt.cpp: (WebCore::generateComponents): (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::offsetForPosition): (WebCore::cursorToX): (WebCore::Font::selectionRectForText):
platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
platform/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): (WebCore::UniscribeController::offsetForPosition): (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::resetControlAndState): (WebCore::UniscribeController::shapeAndPlaceItem):
platform/win/UniscribeController.h:
platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint):
rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcPrefWidths):
rendering/RenderImage.cpp:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
rendering/RenderText.h: (WebCore::RenderText::allowTabs):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox):
rendering/SVGRootInlineBox.h:

4:58 AM Changeset in webkit [28297] by mrowe@apple.com

3 edits in branches/Safari-3-branch/WebCore

Merge r26782 to Safari-3-branch.

4:34 AM Changeset in webkit [28296] by mrowe@apple.com

2 edits in tags/Safari-5523.10.5

Versioning.

4:33 AM Changeset in webkit [28295] by mrowe@apple.com

5 edits in tags/Safari-5523.10.5/WebCore

Merge r28225.

4:31 AM Changeset in webkit [28294] by mrowe@apple.com

7 edits
9 adds in tags/Safari-5523.10.5

Merge r28056.

4:29 AM Changeset in webkit [28293] by mrowe@apple.com

4 edits in tags/Safari-5523.10.5/WebCore

Merge r27433.

4:27 AM Changeset in webkit [28292] by mrowe@apple.com

21 edits
2 adds in tags/Safari-5523.10.5

Merge r26780.

4:22 AM Changeset in webkit [28291] by mrowe@apple.com

2 edits in tags/Safari-4523.12.1

Versioning.

4:21 AM Changeset in webkit [28290] by mrowe@apple.com

5 edits in tags/Safari-4523.12.1/WebCore

Merge r28225.

4:19 AM Changeset in webkit [28289] by mrowe@apple.com

7 edits
9 adds in tags/Safari-4523.12.1

Merge r28056.

4:17 AM Changeset in webkit [28288] by mrowe@apple.com

4 edits in tags/Safari-4523.12.1/WebCore

Merge r27433.

4:15 AM Changeset in webkit [28287] by mrowe@apple.com

21 edits
2 adds in tags/Safari-4523.12.1

Merge r26780.

4:07 AM Changeset in webkit [28286] by mrowe@apple.com

5 edits in branches/Safari-3-branch/WebCore

Merge r28225 to Safari-3-branch.

4:04 AM Changeset in webkit [28285] by mrowe@apple.com

7 edits
9 adds in branches/Safari-3-branch

Merge r28056 to Safari-3-branch.

4:01 AM Changeset in webkit [28284] by mrowe@apple.com

4 edits in branches/Safari-3-branch/WebCore

Merge r27433 to Safari-3-branch.

3:59 AM Changeset in webkit [28283] by mrowe@apple.com

21 edits
2 adds in branches/Safari-3-branch

Merge r26780 to Safari-3-branch.

3:08 AM Changeset in webkit [28282] by mrowe@apple.com

1 copy in tags/Safari-5523.10.5

New tag.

3:07 AM Changeset in webkit [28281] by mrowe@apple.com

1 delete in tags/Safari-5523.10.4

Remove bogus tag.

3:05 AM Changeset in webkit [28280] by mrowe@apple.com

1 copy in tags/Safari-5523.10.4

New tag.

3:04 AM Changeset in webkit [28279] by mrowe@apple.com

1 copy in tags/Safari-4523.12.1

New tag.

Nov 30, 2007:

10:56 PM Changeset in webkit [28278] by Adam Roben

2 edits in trunk/PlanetWebKit

Add another feed

config.ini:

10:48 PM Changeset in webkit [28277] by Adam Roben

1 edit
1 add in trunk/PlanetWebKit

Add a simple script to update the site

update.pl: Added.

10:41 PM HackingGtk edited by alp@atoker.com

More fixes to track the latest WebKit/GTK+ API change (diff)

10:34 PM Changeset in webkit [28276] by Adam Roben

2 edits in trunk/PlanetWebKit

Include all WebKit posts from Trolltech Labs

config.ini:

9:46 PM Changeset in webkit [28275] by Simon Hausmann

4 edits in trunk

Don't hide symbols when in Debug mode
On Linux (glibc) provide a backtrace in the test output for debugging purposes

Signed-off-by: Simon

9:29 PM Changeset in webkit [28274] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Fix for GTK+ Debug build breakage introduced in r28273.

WebView/webkitprivate.cpp: (WebKit::kit):

9:04 PM HackingGtk edited by alp@atoker.com

Update to track API changes (diff)

8:24 PM Changeset in webkit [28273] by alp@webkit.org

13 edits
16 adds
1 delete in trunk

2007-11-30 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Refactor the WebKit/GTK+ public API. Changes:

WebKitPage -> WebKitWebView
WebKitFrame -> WebKitWebFrame

Public API source and header names have been updated to mirror the API
changes.

The API is now kept in WebKit/gtk/WebView to match other ports in the
same class such as Mac and Win.

API/ABI-breaking change.

8:10 PM BuildingOnWindows edited by bfulgham@macports.org

(diff)

6:25 PM Changeset in webkit [28272] by Adam Roben

2 edits in trunk/JavaScriptCore

Reviewed by Eric.

ChangeLog:
pcre/pcre_compile.cpp: (compile_branch):

5:57 PM Changeset in webkit [28271] by pewtermoose@webkit.org

3 edits in trunk/WebKitSite

Reviewed by Adam.

Link to the commit and review policy.

coding/contributing.html:
nav.inc:

5:47 PM Changeset in webkit [28270] by Darin Adler

2 edits in trunk/WebKitSite

coding/commit-review-policy.html: A couple more typos and very minor grammatical stuff. No substantive change.

5:42 PM Changeset in webkit [28269] by Darin Adler

2 edits in trunk/WebKitSite

coding/commit-review-policy.html: Fixed a typo, added a footer.

5:37 PM Changeset in webkit [28268] by Adam Roben

74 adds in trunk/PlanetWebKit

Initial checkin of Planet WebKit

Rubberstamped by Sam.

README: Added.
config.ini: Added.
planet/AUTHORS: Added.
planet/INSTALL: Added.
planet/LICENCE: Added.
planet/NEWS: Added.
planet/PKG-INFO: Added.
planet/README: Added.
planet/THANKS: Added.
planet/TODO: Added.
planet/examples/atom.xml.tmpl: Added.
planet/examples/basic/config.ini: Added.
planet/examples/basic/index.html.tmpl: Added.
planet/examples/fancy/config.ini: Added.
planet/examples/fancy/index.html.tmpl: Added.
planet/examples/foafroll.xml.tmpl: Added.
planet/examples/opml.xml.tmpl: Added.
planet/examples/output/images/edd.png: Added.
planet/examples/output/images/evolution.png: Added.
planet/examples/output/images/feed-icon-10x10.png: Added.
planet/examples/output/images/jdub.png: Added.
planet/examples/output/images/keybuk.png: Added.
planet/examples/output/images/logo.png: Added.
planet/examples/output/images/opml.png: Added.
planet/examples/output/images/planet.png: Added.
planet/examples/output/images/thom.png: Added.
planet/examples/output/planet.css: Added.
planet/examples/rss10.xml.tmpl: Added.
planet/examples/rss20.xml.tmpl: Added.
planet/planet-cache.py: Added.
planet/planet.py: Added.
planet/planet/init.py: Added.
planet/planet/atomstyler.py: Added.
planet/planet/cache.py: Added.
planet/planet/compat_logging/init.py: Added.
planet/planet/compat_logging/config.py: Added.
planet/planet/compat_logging/handlers.py: Added.
planet/planet/feedparser.py: Added.
planet/planet/htmltmpl.py: Added.
planet/planet/sanitize.py: Added.
planet/planet/tests/init.py: Added.
planet/planet/tests/data/simple.tmpl: Added.
planet/planet/tests/data/simple2.tmpl: Added.
planet/planet/tests/test_channel.py: Added.
planet/planet/tests/test_main.py: Added.
planet/planet/tests/test_sanitize.py: Added.
planet/planet/tests/test_sub.py: Added.
planet/planet/timeoutsocket.py: Added.
planet/runtests.py: Added.
planet/setup.py: Added.
templates/atom.xml.tmpl: Added.
templates/foafroll.xml.tmpl: Added.
templates/index.html.tmpl: Added.
templates/opml.xml.tmpl: Added.
templates/rss10.xml.tmpl: Added.
templates/rss20.xml.tmpl: Added.
wwwroot/images/feed-icon-10x10.png: Added.
wwwroot/images/planet.png: Added.
wwwroot/planet.css: Added.

4:48 PM Changeset in webkit [28267] by pewtermoose@webkit.org

2 edits in trunk/WebKitSite

Reviewed by Maciej.

Clean up a couple of typos from Maciej's last patch.

coding/commit-review-policy.html:

4:47 PM Changeset in webkit [28266] by adachan@apple.com

4 edits in trunk/WebKit/win

<rdar://problem/5621373> Added a way for the client to clear undo/redo
operations from a WebView.

Reviewed by Steve.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::clearUndoRedoOperations):
WebView.h:

4:27 PM Changeset in webkit [28265] by mjs@apple.com

1 edit
1 add in trunk/WebKitSite

Reviewed by Bertrand.

New commit and review policy.

coding/commit-review-policy.html: Added.

4:18 PM Changeset in webkit [28264] by andersca@apple.com

2 edits in trunk/WebCore

Add platform/text project group.

WebCore.vcproj/WebCore.vcproj:

4:05 PM Changeset in webkit [28263] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-30 Eric Seidel <eric@webkit.org>

No review, build fix only.

Fix uninitialized var warnings in release build.

JavaScriptCore.xcodeproj/project.pbxproj:
pcre/pcre_compile.cpp: (compile_regex):

3:57 PM Changeset in webkit [28262] by andersca@apple.com

2 edits in trunk/WebCore

Remove extra </Filter> tag which prevented the vcproj from being parsed correctly.

WebCore.vcproj/WebCore.vcproj:

3:47 PM Changeset in webkit [28261] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Geoff Garen

Added another symbol for WebDatabaseManager clients

WebKit.exp: added .objc_class_name_WebSecurityOrigin

3:43 PM Changeset in webkit [28260] by eric@webkit.org

4 edits
3 adds in trunk

2007-11-30 Eric Seidel <eric@webkit.org>

Reviewed by darin.

PCRE crashes under GuardMalloc
http://bugs.webkit.org/show_bug.cgi?id=16127
check against patternEnd to make sure we don't walk off the end of the string

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):

3:25 PM Changeset in webkit [28259] by Nikolas Zimmermann

2 edits in trunk/WebCore

Not reviewed. Try to fix qt/gtk build.

3:19 PM Changeset in webkit [28258] by Nikolas Zimmermann

5 edits
27 moves in trunk/WebCore

Rubber stamped by Eric.

Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.

Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.

2:22 PM Changeset in webkit [28257] by kevino@webkit.org

4 edits in trunk

wx build fix. Add WebCore/platform/graphics/wx to includes.

2:08 PM Changeset in webkit [28256] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Geoff

Further hookup of Database API
With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
result in a didModifyDatabase notification when the transaction is successfully committed

storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase" (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate):
storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::lastActionChangedDatabase):

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::notifyDatabaseChanged): Added. Allow external entities (SQLTransaction) to be able to request a didModifyDatabase notification to the delegate
storage/DatabaseTracker.h:

storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of a transaction resulted in a change to the database. (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation statement occurred (WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
storage/SQLTransaction.h:

2:04 PM Changeset in webkit [28255] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Geoff

Add isEqual operator to WebSecurityOrigin

Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin isEqual:]):

1:55 PM Changeset in webkit [28254] by Adam Roben

2 edits in trunk/WebKitTools

Hopefully the final build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to pull in WTF's assertion/logging functions.

1:44 PM Changeset in webkit [28253] by Adam Roben

2 edits in trunk/WebKitTools

Another build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for WebKit.lib.

1:27 PM Changeset in webkit [28252] by Adam Roben

4 edits
1 copy in trunk/WebKitTools

Debug build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal configuration.
Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other projects.
Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from WebKitTools/DumpRenderTree/win/debug_internal.vsprops.

12:35 PM Changeset in webkit [28251] by Nikolas Zimmermann

6 edits
60 moves
6 adds in trunk/WebCore

Rubber stamped by David.

Next round of moves - platform reorganization.
Move text/font/glyph related files from the individual port directories
into platform/text/<port> or platform/graphics/<port>.

12:15 PM Changeset in webkit [28250] by kevino@webkit.org

4 edits in trunk

Other wx port fixes needed to restore the build bot.

12:11 PM Changeset in webkit [28249] by weinig@apple.com

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Fix drawSelectionRect to actually draw the selection rect.

DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect):

11:33 AM Changeset in webkit [28248] by Simon Hausmann

2 edits in trunk/WebCore

Fix the build with DATABASE=0.

11:32 AM Changeset in webkit [28247] by Adam Roben

1 edit
2 adds in trunk/LayoutTests

Copy some cross-platform results into platform/win to avoid picking up the platform/mac versions

platform/win/fast/dom/Window/window-resize-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-expected.txt.
platform/win/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/fast/dom/wrapper-classes-expected.txt.

11:21 AM Changeset in webkit [28246] by Nikolas Zimmermann

2 edits
1 move in trunk/WebCore

Rubber stamped by Darin.

Fix misplaced file. The name "FontStyle" is not correct though - it probably
needs yet another move - but this time inside platform/graphics - as soon
as we agree on a better name.

11:04 AM Changeset in webkit [28245] by sullivan@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Darin

Tweaks to newly-declared NSString * constants to make them usable from clients

Storage/WebDatabaseManagerPrivate.h:
Storage/WebDatabaseManager.mm: removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used

WebKit.exp: export new NSNotification names and userInfo keys so clients can use them

11:02 AM QtWebKitTodo edited by Simon Hausmann

(diff)

10:56 AM Changeset in webkit [28244] by Adam Roben

2 edits in branches/Safari-3-branch/WebKitTools

Merge r26734

10:54 AM Changeset in webkit [28243] by Darin Adler

5 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters

SunSpider says this is 5.5% faster on the regexp test, 0.4% faste overall.

Test: fast/js/regexp-non-bmp.html

Renamed ANY_CHAR to NOT_NEWLINE to more-accurately reflect its meaning.

pcre/pcre_compile.cpp: (compile_branch): Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. (calculateCompiledPatternLengthAndFlags): Ditto.

pcre/pcre_exec.cpp: (match): Fixed indentation of some case labels (including all the BEGIN_OPCODE). Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. Also removed some explicit UTF-16 support code in a few cases. Removed the unneeded "UTF-8" code path in the ANY_CHAR repeat code, and in another case, eliminated the code to check against end_subject in because it is already done outside the loop. (jsRegExpExecute):

pcre/pcre_internal.h: Removed all the UTF-16 helper functions.

LayoutTests:

Reviewed by Adam Roben.

test for http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters

fast/js/regexp-non-bmp-expected.txt: Added.
fast/js/regexp-non-bmp.html: Added.
fast/js/resources/regexp-non-bmp.js: Added.

10:47 AM Changeset in webkit [28242] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.

10:44 AM Changeset in webkit [28241] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Build fix after platform/text changes.

10:43 AM Changeset in webkit [28240] by Nikolas Zimmermann

8 edits in trunk/WebCore

Reviewed by Sam.

Rename "FontStyle FontStyle(...)" to "FontStyle fontStyle(...)".
I scripted a bit too much while doing the TextStyle -> FontStyle change.

10:38 AM Changeset in webkit [28239] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-30 Alp Toker <alp@atoker.com>

GTK+ build fix following the recent text reorganization.

WebCore.pro:

10:30 AM QtWebKitContrib edited by Simon Hausmann

(diff)

10:08 AM Changeset in webkit [28238] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-29 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Adam.

Part of <rdar://problem/5506522> Seed: cannot type into text box in
Facebook, don't see plugin content (Adobe Flash)

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Focus the plugin's parent frame

10:06 AM Changeset in webkit [28237] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Get ready for some future renaming.

10:03 AM Changeset in webkit [28236] by kmccullough@apple.com

4 edits in trunk/WebKitTools

Reviewed by Adam.

Removed some unnecessary functions and changed an unused return type.

Drosera/win/DebuggerClient.cpp: (registerConsoleClass):
Drosera/win/DebuggerClient.h:
Drosera/win/Drosera.cpp: (registerDroseraClass):

9:54 AM Changeset in webkit [28235] by Nikolas Zimmermann

3 edits in trunk/WebCore

Not reviewed. Trying to fix gtk/qt/wx build. (I expected problems because of the moves)

9:41 AM Changeset in webkit [28234] by Nikolas Zimmermann

32 edits
67 moves
2 adds in trunk/WebCore

Rubber stamped by Brady.

Started platform reorganization (platform/text addition).
Moving string/text/font related classes into new places - as discussed on webkit-dev.

In a follow-up commit I'll move classes out of platform/{mac,win,...} into
platform/text/{mac,win,...}, and also do the ksvg2/ -> svg/ move.

9:02 AM Changeset in webkit [28233] by adele@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)

Test: fast/events/mousemove-after-drag-over-scrollbar.html

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse. We should only need to show the hover effect when the mouse isn't pressed.

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button

fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
fast/events/mousemove-after-drag-over-scrollbar.html: Added.

6:12 AM Changeset in webkit [28232] by ap@webkit.org

2 edits in trunk/LayoutTests

platform/win/Skipped: Added editing/selection/5241148.html, which crashes for me.

4:40 AM Changeset in webkit [28231] by alp@webkit.org

10 edits in trunk

2007-11-28 Alp Toker <alp@atoker.com>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=16174
[GTK] Use "URI" not "URL" in public API

Replace use of the term "URL" with "URI" in public headers,
documentation and some internal code to match GLib/GTK+ convention.

This is now mentioned in the API guidelines:

http://trac.webkit.org/projects/webkit/wiki/HackingGtk

API/ABI-breaking change.

1:34 AM Changeset in webkit [28230] by zecke@webkit.org

6 edits in trunk/WebKit/qt

Self destruct the clients like the ohter ports do

Signed-off-by: Simon

12:49 AM Changeset in webkit [28229] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-30 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Fix layout test regressions caused by r28186
http://bugs.webkit.org/show_bug.cgi?id=16195
change first_byte and req_byte back to shorts instead of chars
(I think PCRE stuffs information in the high bits)

pcre/pcre_internal.h:

12:44 AM QtWebKit edited by Simon Hausmann

(diff)

Nov 29, 2007:

11:01 PM Changeset in webkit [28228] by beidson@apple.com

3 edits in trunk/WebCore

Reviewed by Tim

Part of <rdar://problem/5556377> - Need to accurately track and enforce database quota

SQLite has the ability to enforce the page usage for databases. This gives us bulletproof
enforcement of the database size limit with reasonable granularity (within 1023 bytes by
default on OS X with SQLite 3.4.0)

This also involved enhancing the ability to install/remove the authorizer to run the PRAGMA
statements involved

Note this patch does not actually use the new maximumSize() functionality of the
SQLiteDatabase class - that can be reviewed/landed seperately

platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::maximumSize): Return the current maximum size in bytes (WebCore::SQLiteDatabase::setMaximumSize): Based on m_pageSize, set the maximum page count to enforce the maximum size in bytes (WebCore::SQLiteDatabase::pageSize): Fetch m_pageSize if it hasn't been fetched, or return the cached value (WebCore::SQLiteDatabase::setAuthorizer): Use enableAuthorizer for the sqlite_* level authorizer setup (WebCore::SQLiteDatabase::enableAuthorizer): Install or remove the sqlite authorizer handler
platform/sql/SQLiteDatabase.h: Add the m_pageSize member so we only have to fetch it once

9:50 PM Changeset in webkit [28227] by zecke@webkit.org

4 edits in trunk

Fix fast/events/mousedown_in_scrollbar.html
This test used to crash in PlatformScrollbarQt::mouse*Event due parent() returning 0.
Extend the current check that the scrollbar in the mev can be go away. This happens if we destroy a RenderLayer as the result of a click. In the case of Qt we can have this scrollbar in m_lastScrollbarUnderMouse. The RenderLayer is the ScrollbarClient, m_lastScrollbarUnderMouse is a RefPtr and keeps the last reference. When calling into this scrollbar the m_client pointer is a dangling pointer. We extend the check to set m_lastScrollbarUnderMouse back to zero when it was the scrollbar in the old mev and is gone in the new one.
This happens only on the Qt port because we send more/different move events.

9:25 PM Changeset in webkit [28226] by Antti Koivisto

5 edits
5 adds in trunk

WebCore:

Reviewed by Mitz.

Fix aspect ratio calculation of video.

Video should always be treated as a replaced element in size calculation.

Test: media/video-aspect-ratio.html

rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
rendering/RenderBox.h: (WebCore::RenderBox::shouldCalculateSizeAsReplaced):
rendering/RenderMedia.h: (WebCore::RenderMedia::shouldCalculateSizeAsReplaced):

LayoutTests:

Reviewed by Mitz.

Test for video aspect ratio calculation.

media/video-aspect-ratio.html: Added.
platform/mac/media: Added.
platform/mac/media/video-aspect-ratio-expected.checksum: Added.
platform/mac/media/video-aspect-ratio-expected.png: Added.
platform/mac/media/video-aspect-ratio-expected.txt: Added.

9:20 PM Changeset in webkit [28225] by weinig@apple.com

5 edits in trunk/WebCore

Reviewed by Oliver.

Additional fix for <rdar://problem/5592988> / http://bugs.webkit.org/show_bug.cgi?id=15936

More closely match IE's policy for frame navigation.

bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncOpen::callAsFunction):
loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldAllowNavigation):
page/FrameTree.cpp: (WebCore::FrameTree::top):
page/FrameTree.h:

8:34 PM Changeset in webkit [28224] by mitz@apple.com

7 edits in trunk/WebCore

Reviewed by Adam Roben and John Sullivan.

make the recent searches popup extend only along the straight part of the search field (unless it needs to be wider).

platform/PopupMenuClient.h: Added clientInsetLeft() and clientInsetRight() for clients to specify desired horizontal insets for the menu.
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::paint):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientInsetLeft): Added. Returns 0. (WebCore::RenderMenuList::clientInsetRight): Ditto.
rendering/RenderMenuList.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::clientInsetLeft): Added. Returns half the control's height, which is the radius of the cap on the left. (WebCore::RenderTextControl::clientInsetRight): Added.
rendering/RenderTextControl.h:

7:02 PM Changeset in webkit [28223] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Make the JS collector work with multiple threads

Reviewed by Maciej and Darin.

Under heavy contention it was possible the GC to suspend other
threads inside the pthread spinlock, which could lead to the GC
thread blocking on the pthread spinlock itself.

We now determine and store each thread's stack base when it is
registered, thus removing the need for any calls to pthread_get_stackaddr_np
that needed the pthread spinlock.

6:42 PM Changeset in webkit [28222] by andersca@apple.com

6 edits in trunk

WebKitTools:

Reviewed by Sam.

<rdar://problem/5230478>
FrameLoadDelegate callbacks are not dumped in DRT.

DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): (runTest): (main):
DumpRenderTree/win/FrameLoaderDelegate.cpp: (BSTRtoString): (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didStartProvisionalLoadForFrame): (FrameLoadDelegate::didFailProvisionalLoadWithError): (FrameLoadDelegate::didCommitLoadForFrame): (FrameLoadDelegate::didFinishLoadForFrame): (FrameLoadDelegate::willCloseFrame): (FrameLoadDelegate::didClearWindowObject): (FrameLoadDelegate::didFinishDocumentLoadForFrame): (FrameLoadDelegate::didHandleOnloadEventsForFrame):
DumpRenderTree/win/FrameLoaderDelegate.h: (FrameLoadDelegate::windowScriptObjectAvailable): (FrameLoadDelegate::didFirstLayoutInFrame):

LayoutTests:

Reviewed by Sam.

<rdar://problem/5230478>
FrameLoadDelegate callbacks are not dumped in DRT.

Remove now passing tests.

platform/win/Skipped:

6:38 PM Changeset in webkit [28221] by andersca@apple.com

3 edits in trunk/WebKit/win

Reviewed by Sam.

Add an IWebFrameLoadDelegate2 interface with a didClearWindowObject method
that passes in the frame whose window has been cleared. This matches a newly
added delegate method on the Mac.

Interfaces/IWebFrameLoadDelegate.idl:
WebFrame.cpp: (WebFrame::windowObjectCleared):

6:26 PM Changeset in webkit [28220] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed two Mac-specific tests.

6:21 PM Changeset in webkit [28219] by alice.liu@apple.com

2 edits
1 copy
1 add in trunk/LayoutTests

Move incorrect, Mac-specific results of fast/dom/Window/window-resize.html into platform/mac and replace them with non-Mac results

The incorrect results are tracked by <rdar://5563578>.

Reviewed by Adam.

fast/dom/Window/window-resize-expected.txt: Replaced.
platform/mac/fast/dom/Window/window-resize-expected.txt: Copied from fast/dom/Window/window-resize-expected.txt.
platform/win/Skipped: Removed window-resize tests.

6:19 PM Changeset in webkit [28218] by weinig@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Anders.

Add database quota UIDelegates methods to DRT UIDelegate.

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]): (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):

LayoutTests:

Reviewed by Anders.

Revert r28213 which added an error callback that was not needed and changed
the results.

storage/transaction_callback_exception_crash.html:

6:07 PM Changeset in webkit [28217] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed a passing test.

6:01 PM Changeset in webkit [28216] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group failures related to dumpResourceLoadCallbacks being unimplemented

Reviewed by Adam.

platform/win/Skipped:

6:00 PM Changeset in webkit [28215] by alp@webkit.org

16 edits in trunk/WebCore

2007-11-30 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change

Change license from BSD to LGPL.

This is being done to encourage vendors to contribute their fixes back
upstream.

5:44 PM Changeset in webkit [28214] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group failures related to using Cygwin paths

Reviewed by Adam.

platform/win/Skipped:

5:02 PM Changeset in webkit [28213] by beidson@apple.com

2 edits in trunk/LayoutTests

Not reviewed.

Fixed a hang in the layout tests.
My checkin earlier today broke things such that the transaction call errors out instead of succeeds.
Therefore LayoutTestController is never notified that the test is done.

This changes modifies the test such that the controller is notified of completion even if
there's a transaction error.

The net effect of this fix is to transform the hang to a single layout test failure, so people
and the bots don't have their run-webkit-tests hang while I try to fix the real regression.

storage/transaction_callback_exception_crash.html:

4:53 PM Changeset in webkit [28212] by Darin Adler

4 edits
2 adds in trunk

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=16191 REGRESSION: cannot tab to radio input after setting checked to false

Test: fast/forms/input-radio-checked-tab.html

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::CheckedRadioButtons::addButton): Fix this code so that it doesn't call setChecked(false) until after the map has been updated. Otherwise, we can end up deallocating the map before manipulating it. As long as I was changing the function, I decided to make it do only a single hash table lookup.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Remove the button from the radio buttons set before changing the checked state. This matches the idiom used elsewhere and fixes the problem where setting checked to false would not remove it from the set.

LayoutTests:

Reviewed by Adele.

test for http://bugs.webkit.org/show_bug.cgi?id=16191 REGRESSION: cannot tab to radio input after setting checked to false

fast/forms/input-radio-checked-tab-expected.txt: Added.
fast/forms/input-radio-checked-tab.html: Added.

4:50 PM Changeset in webkit [28211] by alice.liu@apple.com

1 edit
1 copy
1 add in trunk/LayoutTests

Move Mac-specific results of fast/dom/wrapper-classes.html into platform/mac and replace them with non-Mac results

Reviewed by Adam.

fast/dom/wrapper-classes-expected.txt: Replaced.
platform/mac/fast/dom/wrapper-classes-expected.txt: Copied from fast/dom/wrapper-classes-expected.txt.

4:43 PM Changeset in webkit [28210] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group drag-n-drop related failures under one bug

We don't know the specific causes of these failures, but we believe
they're due to bugs in DRT's drag-n-drop implementation.

Reviewed by Adam.

platform/win/Skipped:

4:36 PM Changeset in webkit [28209] by kmccullough@apple.com

11 edits in trunk

WebKit/win:

Reviewed by Sam.

<rdar://5618976> Drosera: should listen for the WebScriptDebugServer dying and vice versa.

Interfaces/IWebScriptDebugListener.idl: Added the new function to the interface.
WebKit.vcproj/WebKit.def: Added the new function to the def file so Safari can tell WebKit when the server is dying.
WebKit.vcproj/WebKit_debug.def: Ditto.
WebKitDLL.cpp: Added the new function for Safari to call. (RunAsLocalServer): (LocalServerDidDie):
WebScriptDebugServer.cpp: (WebScriptDebugServer::WebScriptDebugServer): Removed unused member. (WebScriptDebugServer::sharedWebScriptDebugServer): Ditto, and added new member to prevent adding or removing listeners when the server is dying. (WebScriptDebugServer::addListener): Don't let new listeners be added when the server is dying. (WebScriptDebugServer::removeListener): Don't let listeners remove themselves when the server is dying. The server will remove them all anyways. (WebScriptDebugServer::serverDidDie): Notify all listeners that the server is dying and remove all listeners.
WebScriptDebugServer.h: Added the new method and removed an unused member.

WebKitTools:

Reviewed by Sam.

<rdar://5618976> Drosera: should listen for the WebScriptDebugServer dying and vice versa.
This fix will allow Drosera and Safari to reconnect if either of them closes correctly, but does not fix the case where one of them dies silently.

Drosera/win/ServerConnection.cpp: (ServerConnection::attemptToCreateServerConnection): Added a safety check, because it's possilbe to try to connect to a server that's dying. (ServerConnection::serverDidDie): Implemented. This resets Drosera when the server has died.
Drosera/win/ServerConnection.h: Added the new function and removed an unnecessary member.

4:29 PM Changeset in webkit [28208] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed another passing test.

4:26 PM Changeset in webkit [28207] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Recategorized one failing test and removed a passing test.

4:26 PM Changeset in webkit [28206] by justin.garcia@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5620093> Brief hang when Safari caches page text of XML document

editing/TextIterator.cpp: (WebCore::TextIterator::representNodeOffsetZero): When we haven't been emitting any characters, shouldRepresentNodeOffsetZero() can create VisiblePositions, which is expensive. So, we perform the inexpensive checks on m_node to see if it necessitates emitting a character first and will early return before encountering shouldRepresentNodeOffsetZero()s worse case behavior.

4:23 PM Changeset in webkit [28205] by andersca@apple.com

2 edits in trunk/WebKitTools

DumpRenderTree/win/DumpRenderTree.vcproj: Add shlwapi.lib to all configurations.

3:30 PM Changeset in webkit [28204] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing <rdar://5507350> from skipped list because it's not failing.

platform/win/Skipped:

2:15 PM Changeset in webkit [28203] by andersca@apple.com

1 edit
4 moves in trunk/LayoutTests

Reviewed by Alexey.

Move Mac-specific tests to platform/mac.

fast/events/objc-event-api-expected.txt: Removed.
fast/events/objc-event-api.html: Removed.
fast/events/objc-keyboard-event-creation-expected.txt: Removed.
fast/events/objc-keyboard-event-creation.html: Removed.
platform/mac/fast/events/objc-event-api-expected.txt: Copied from fast/events/objc-event-api-expected.txt.
platform/mac/fast/events/objc-event-api.html: Copied from fast/events/objc-event-api.html.
platform/mac/fast/events/objc-keyboard-event-creation-expected.txt: Copied from fast/events/objc-keyboard-event-creation-expected.txt.
platform/mac/fast/events/objc-keyboard-event-creation.html: Copied from fast/events/objc-keyboard-event-creation.html.

2:10 PM Changeset in webkit [28202] by andersca@apple.com

3 edits in trunk/WebKit/mac

Reviewed by John.

Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.

This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
is using the setter and not messing around with NSUserDefaults.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences shrinksStandaloneImagesToFit]): (-[WebPreferences setShrinksStandaloneImagesToFit:]):

1:57 PM Changeset in webkit [28201] by Adam Roben

3 edits in trunk/JavaScriptCore

Windows build fix

Removed some unreachable code (ironically, the code was some
ASSERT_NOT_REACHED()s).

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):

1:53 PM Changeset in webkit [28200] by andersca@apple.com

2 edits in trunk/WebCore

Reviewed by Sam.

Don't install event handlers or set the zoom cursor if auto-shrink has been disabled.

loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): (WebCore::ImageDocument::imageChanged):

1:51 PM Changeset in webkit [28199] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing some fixed tests

platform/win/Skipped:

1:49 PM Changeset in webkit [28198] by beidson@apple.com

2 edits in trunk/WebKit/win

Build fix that works...?

WebChromeClient.h:

1:26 PM Changeset in webkit [28197] by kmccullough@apple.com

2 edits in trunk/WebKitTools

Build fix. Added additional includes for VS Express to the Release project.

Drosera/win/Drosera.vcproj/Drosera.vcproj:

1:13 PM Changeset in webkit [28196] by beidson@apple.com

2 edits in trunk/WebKit/gtk

Better build fix for Gtk

WebCoreSupport/ChromeClientGtk.h:

1:09 PM Changeset in webkit [28195] by beidson@apple.com

2 edits in trunk/WebKit/win

Build fix

WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

11:53 AM Changeset in webkit [28194] by andersca@apple.com

5 edits in trunk

WebKitTools:

Reviewed by Adam.

<rdar://problem/5132005>
setUserStyleSheetEnabled is not fully implemented in Windows DRT.

DumpRenderTree/win/DumpRenderTree.vcproj: Add shlwapi.lib

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setUserStyleSheetEnabled): Implement this.

(appendComponentToPath):
New method which wraps the Win32 API PathAppend.

(followShortcuts):
New method which checks if a file points to a shortcut and
follows the shortcut.

(resolveCygwinPath):
New method that takes a cygwin unix-style path and returns the Win32 path.

(cfStringRefToWString):

(LayoutTestController::setUserStyleSheetLocation):
Implement this.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5132005>
setUserStyleSheetEnabled is not fully implemented in Windows DRT.

platform/win/Skipped:

11:38 AM Changeset in webkit [28193] by Beth Dakin

2 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5620151> Disable JavaScript for SVG as
image for <img> and CSS images

platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): When we create the empty clients, explicitly disable JavaScript in the settings.

11:29 AM Changeset in webkit [28192] by beidson@apple.com

31 edits in trunk

WebCore:

Reviewed by Anders

Support for <rdar://problem/5556381> and <rdar://problem/5556379>

The Database feature in the engine needs to support delegate calls for policy decisions and
also provide notifications when origins and databases change their state.

This patch also polishes off the missing features of the management API

page/Chrome.cpp: Implement the two UIDelegate methods (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): Ask for more space to create a new database if it won't fit (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation): Ask for more space to complete an in-progress operation
page/Chrome.h:
page/ChromeClient.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):

storage/Database.cpp: (WebCore::Database::openDatabase): Check to see if this database can be opened - the quota must be high enough and if it isn't, the UIDelegate should have a change to bump the quota. Also update the UI-relevant details (display name and estimated size) upon successful opening of the database

storage/DatabaseDetails.h: Remove the version parameter as it is a programatic detail of a site database and is not important to API clients (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::isValid): (WebCore::DatabaseDetails::name):

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::openTrackerDatabase): Tweaked the schema here - there was a horrible bug with the old schema that would prevent you from having two databases of the same name from two different origins. Also simplify the origin-management schema (WebCore::DatabaseTracker::canEstablishDatabase): Added. Does some estimated size vs quota checks, and asks the UI delegate for more space if necessary (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::establishEntryForOrigin): Establishes a tracker entry for the given origin with the current default quota Also notifies the client of the new origin (WebCore::DatabaseTracker::setDatabaseDetails): Update the display name and estimated size for the given database (WebCore::DatabaseTracker::fullPathForDatabase): Tweak to add the ability to get the path without creating it - for management purposes (WebCore::DatabaseTracker::populateOrigins): Populate origins from the Origins table instead of the Databases table (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::detailsForNameAndOrigin): For API management (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): Notify the client (WebCore::DatabaseTracker::addDatabase): Notify the client (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
storage/DatabaseTracker.h:

WebKit/gtk:

Keep it building with new client method

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

Reviewed by Anders

Support for <rdar://problem/5556381> and <rdar://problem/5556379>

Hook up UI Delegate calls for the database engine feature and other small tweaks

Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
Storage/WebDatabaseManagerPrivate.h:

Storage/WebDatabaseTrackerClient.h:
Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto

WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods

WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): (CallUIDelegateReturningUnsignedLongLong):
WebView/WebViewInternal.h:

WebKit/qt:

Keep it building with new client method

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Keep it building with new client method

WebChromeClient.cpp: (ChromeClient::requestQuotaIncreaseForNewDatabase): (ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebChromeClient.h:

WebKit/wx:

Keep it building with new client method

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKitSupport/ChromeClientWx.h:

11:21 AM Changeset in webkit [28191] by alice.liu@apple.com

2 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): uppercase letters were being sent as lowercase letters without the shift key down.

10:56 AM Drosera edited by kmccullough@apple.com

Added new information about the design of Drosera, specifically to add … (diff)

10:48 AM Changeset in webkit [28190] by mitz@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Fix typo

10:46 AM Changeset in webkit [28189] by kmccullough@apple.com

2 edits in trunk/WebKitTools

Windows build fix. VS express needs some love.

Drosera/win/Drosera.vcproj/Drosera.vcproj:

10:45 AM Changeset in webkit [28188] by mitz@apple.com

3 edits
1 add in trunk

WebCore:

Reviewed by Beth Dakin and Darin Adler.

manual test for <rdar://problem/5346394> Contextmenu event doesn't fire on body element inside frame

manual-tests/context-click-unfocused-frame.html: Added.

WebKit/win:

Reviewed by Beth Dakin and Darin Adler.

fix <rdar://problem/5346394> Contextmenu event doesn't fire on body element inside frame

WebView.cpp: (WebView::handleContextMenuEvent): Send the context menu event to the frame containing the node that was hit.

10:36 AM Changeset in webkit [28187] by kmccullough@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Sam.

Added recursive runloop guards.

DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer suspendProcessIfPaused]):

6:48 AM BuildingGtk edited by hendry@iki.fi

let people know about ccache (diff)

6:38 AM UsingGitWithWebKit edited by hendry@iki.fi

initial setup (diff)

4:49 AM Changeset in webkit [28186] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Fix for --guard crash of fast/js/regexp-charclass-crash introduced by r28151.

pcre/pcre_compile.cpp: (is_anchored):

3:57 AM Changeset in webkit [28185] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Gtk build fix.

3:44 AM Changeset in webkit [28184] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Attempt to fix non-mac builds after PCRE cleanup.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:
pcre/pcre.pri:

3:39 AM Changeset in webkit [28183] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give consistent naming to the RegExp options/compile flags

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:38 AM Changeset in webkit [28182] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give consistent naming to the RegExp options/compile flags

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:37 AM Changeset in webkit [28181] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Pull first_byte and req_byte optimizations out into separate static funtions, SunSpider reported this as a win.

pcre/pcre_exec.cpp: (tryFirstByteOptimization): (tryRequiredByteOptimization): (jsRegExpExecute):
pcre/pcre_internal.h:

3:37 AM Changeset in webkit [28180] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

give PCRE_MULTILINE a better name: OptionMatchAcrossMultipleLines

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:35 AM Changeset in webkit [28179] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Deprecate jsRegExpExecute's offset-vector fallback code

pcre/pcre_exec.cpp: (jsRegExpExecute):

3:34 AM Changeset in webkit [28178] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Centralize code for subjectPtr adjustments using inlines, only ever check for a single trailing surrogate (as UTF16

only allows one), possibly fix PCRE bugs involving char classes and garbled UTF16 strings.

pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h: (getPreviousChar): (movePtrToPreviousChar): (movePtrToNextChar): (movePtrToStartOfCurrentChar):

3:33 AM Changeset in webkit [28177] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Make cur_is_word and prev_is_word locals, and change OP_ANY to OP_ANY_CHAR for clarity

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (canApplyFirstCharOptimization):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:32 AM Changeset in webkit [28176] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Mitz & Maciej.

Change _NC operators to use _IGNORING_CASE for clarity

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (find_firstassertedchar):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:32 AM Changeset in webkit [28175] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Mitz.

Remove branch from return

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):

3:31 AM Changeset in webkit [28174] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Add repeatInformationFromInstructionOffset inline

pcre/pcre_exec.cpp: (repeatInformationFromInstructionOffset): (match):

3:30 AM Changeset in webkit [28173] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove no longer used error code JSRegExpErrorMatchLimit

kjs/regexp.cpp: (KJS::RegExp::match):
pcre/pcre.h:
pcre/pcre_internal.h:

3:30 AM Changeset in webkit [28172] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

change getChar* functions to return result and push 'c' into local scopes for clarity

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (getChar): (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):

3:29 AM Changeset in webkit [28171] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Make i locally scoped for better code clarity

pcre/pcre_exec.cpp: (match):

3:29 AM Changeset in webkit [28170] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Comment cleanup

pcre/pcre_exec.cpp: (match):

3:28 AM Changeset in webkit [28169] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Give subjectPtr and instructionPtr sane names, reduce size of MatchFrame for a 0.2% speedup.

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match_ref): (MatchStack::pushNewFrame): (getUTF8CharAndIncrementLength): (match):
pcre/pcre_internal.h: (getChar): (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):
pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer):

3:27 AM Changeset in webkit [28168] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Small speedup (0.7%) by simplifying canUseStackBufferForNextFrame() check

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::popCurrentFrame):

3:27 AM Changeset in webkit [28167] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Lower MATCH_LIMIT_RECURSION to more sane levels to prevent hangs on run-javascriptcore-tests

pcre/pcre_internal.h:

3:26 AM Changeset in webkit [28166] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove match_is_group variable for another 5% speedup

pcre/pcre_compile.cpp:
pcre/pcre_exec.cpp: (startNewGroup): (match):

3:25 AM Changeset in webkit [28165] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Remove redundant eptrblock struct

pcre/pcre_exec.cpp: (MatchStack::pushNewFrame): (match):

3:25 AM Changeset in webkit [28164] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove redundant match_call_count and move recursion check out of super-hot code path
SunSpider says this is at least an 8% speedup for regexp.

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::pushNewFrame): (MatchStack::popCurrentFrame): (MatchStack::popAllFrames): (match): (jsRegExpExecute):
pcre/pcre_internal.h:

3:24 AM Changeset in webkit [28163] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Get rid of GETCHAR* macros, replacing them with better named inlines

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):

3:24 AM Changeset in webkit [28162] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Further cleanup GET/PUT inlines

pcre/pcre_internal.h: (putOpcodeValueAtOffset): (getOpcodeValueAtOffset): (putOpcodeValueAtOffsetAndAdvance): (put2ByteOpcodeValueAtOffset): (get2ByteOpcodeValueAtOffset): (put2ByteOpcodeValueAtOffsetAndAdvance):

3:23 AM Changeset in webkit [28161] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give GET, PUT better names, and add (poor) moveOpcodePtrPastAnyAlternateBranches

pcre/pcre_compile.cpp: (firstSignificantOpCodeSkippingAssertions): (find_fixedlength): (complete_callout): (compile_branch): (compile_regex): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (putOpcodeValueAtOffset): (getOpcodeValueAtOffset): (putOpcodeValueAtOffsetAndAdvance): (put2ByteOpcodeValueAtOffset): (get2ByteOpcodeValueAtOffset): (moveOpcodePtrPastAnyAlternateBranches):
pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):

3:22 AM Changeset in webkit [28160] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Add inlines for toLowerCase, isWordChar, isSpaceChar for further regexp speedup

pcre/pcre_compile.cpp: (compile_branch): (jsRegExpCompile):
pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h: (toLowerCase): (flipCase): (classBitmapForChar): (charTypeForChar): (isWordChar): (isSpaceChar): (CompileData::CompileData):
pcre/pcre_xclass.cpp: (_pcre_xclass):

3:21 AM Changeset in webkit [28159] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

cleanup _pcre_ucp_othercase

pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):

3:21 AM Changeset in webkit [28158] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Abstract frame variables into locals and args

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:20 AM Changeset in webkit [28157] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Section off MatchData arguments into args struct

pcre/pcre_exec.cpp: (MatchStack::pushNewFrame): (match):

3:19 AM Changeset in webkit [28156] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

split first_significant_code into two simpler functions

pcre/pcre_compile.cpp: (firstSignificantOpCode): (firstSignificantOpCodeSkippingAssertions): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):

3:18 AM Changeset in webkit [28155] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

split first_significant_code into two simpler functions

pcre/pcre_compile.cpp: (firstSignificantOpCode): (firstSignificantOpCodeSkippingAssertions): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):

3:18 AM Changeset in webkit [28154] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

clean up is_counted_repeat

pcre/pcre_compile.cpp: (is_counted_repeat):

3:17 AM Changeset in webkit [28153] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

clean up check_escape

pcre/pcre_compile.cpp: (check_escape):

3:16 AM Changeset in webkit [28152] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Reformat find_fixedlength

pcre/pcre_compile.cpp: (find_fixedlength):

3:16 AM Changeset in webkit [28151] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

reformat is_anchored

pcre/pcre_compile.cpp: (is_anchored):

3:15 AM Changeset in webkit [28150] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove unused function could_be_empty_branch

pcre/pcre_compile.cpp: (first_significant_code): (find_fixedlength): (compile_branch): (canApplyFirstCharOptimization):

3:14 AM Changeset in webkit [28149] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Pass around MatchData objects by reference

pcre/pcre_exec.cpp: (pchars): (match_ref): (match): (jsRegExpExecute):

3:13 AM Changeset in webkit [28148] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

give PCRE_STARTLINE a better name and rename match_data to MatchData

pcre/pcre_compile.cpp: (compile_branch): (canApplyFirstCharOptimization): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (pchars): (jsRegExpExecute):
pcre/pcre_internal.h:

3:12 AM Changeset in webkit [28147] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up find_firstassertedchar

pcre/pcre_compile.cpp: (get_othercase_range): (find_firstassertedchar): (calculateCompiledPatternLengthAndFlags):

3:11 AM Changeset in webkit [28146] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Tim Hatcher.

Pass around CompileData& instead of CompileData*

pcre/pcre_compile.cpp: (compile_branch): (jsRegExpCompile):

3:10 AM Changeset in webkit [28145] by eric@webkit.org

4 edits
1 delete in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up compile_branch, move _pcre_ord2utf8, and rename CompileData

JavaScriptCore.xcodeproj/project.pbxproj:
pcre/pcre_compile.cpp: (_pcre_ord2utf8): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_internal.h:
pcre/pcre_ord2utf8.cpp: Removed.

3:09 AM Changeset in webkit [28144] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

removing more macros

pcre/pcre_compile.cpp: (could_be_empty_branch): (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h:
pcre/pcre_xclass.cpp:

3:08 AM Changeset in webkit [28143] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

clean up formating in compile_branch

pcre/pcre_compile.cpp: (compile_branch):

3:07 AM Changeset in webkit [28142] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Fix spacing for read_repeat_counts

pcre/pcre_compile.cpp: (read_repeat_counts):

3:06 AM Changeset in webkit [28141] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Get rid of PCRE custom char types

pcre/pcre_compile.cpp: (check_escape): (complete_callout): (compile_branch): (compile_regex): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_exec.cpp: (match_ref): (match): (jsRegExpExecute):
pcre/pcre_internal.h:

3:06 AM Changeset in webkit [28140] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

reformat get_othercase_range

pcre/pcre_compile.cpp: (get_othercase_range):

3:05 AM Changeset in webkit [28139] by eric@webkit.org

6 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove register keyword and more cleanup

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (is_anchored): (is_startline): (find_firstassertedchar): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_exec.cpp: (MatchStack::canUseStackBufferForNextFrame): (MatchStack::allocateNextFrame): (MatchStack::pushNewFrame): (MatchStack::frameIsStackAllocated): (MatchStack::popCurrentFrame): (MatchStack::unrollAnyHeapAllocatedFrames): (getUTF8CharAndIncrementLength): (match): (jsRegExpExecute):
pcre/pcre_internal.h: (PUT2INC): (isLeadingSurrogate): (isTrailingSurrogate): (decodeSurrogatePair): (getChar):
pcre/pcre_ord2utf8.cpp: (_pcre_ord2utf8):
pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): (_pcre_xclass):

3:04 AM Changeset in webkit [28138] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Clean up jsRegExpExecute

pcre/pcre_compile.cpp: (returnError): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

2:16 AM Changeset in webkit [28137] by mrowe@apple.com

2 edits in trunk/JavaScriptGlue

Fix REGRESSION(r27885): Installer hits assertion failure in JavaScriptGlue.

Reviewed by Maciej.

JSValueWrapper.cpp:

(getThreadGlobalExecState): Set the global object on the Interpreter before using it.

1:05 AM Changeset in webkit [28136] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix an assertion failure seen on the layout tests, and when closing the window after visiting <http://www.coudal.com/losalamos/>.

Reviewed by Oliver Hunt.

Plugins/WebBaseNetscapePluginStream.mm:

(-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
descriptor even when the stream is being destroyed without the load completing. This
avoids leaking the path and file descriptor, and leaving the temporary file on disk.

12:46 AM Changeset in webkit [28135] by oliver@apple.com

5 edits in trunk/JavaScriptCore

Merging updated system alloc and spinlock code from r38 of TCMalloc.

Reviewed by Geoff

This is needed as a precursor to the merge of TCMalloc proper.

12:44 AM template.svg attached to IconContestIdeas by Adam Roben

Preliminary entry template

Nov 28, 2007:

11:57 PM IconContestIdeas edited by Adam Roben

(diff)

11:40 PM IconContestIdeas edited by Adam Roben

(diff)

11:39 PM IconContestIdeas edited by Adam Roben

Stole a judging criterion from the SVG logo contest (diff)

11:32 PM IconContestIdeas edited by Adam Roben

Change start of submissions to be the same as the announcement (diff)

10:20 PM Changeset in webkit [28134] by mrowe@apple.com

1 edit
4 moves in trunk/LayoutTests

Unreviewed layout test fix. Fix typos in the name of four files used by HTTP layout tests.

10:07 PM Changeset in webkit [28133] by Antti Koivisto

3 edits
2 adds in trunk

WebCore:

Reviewed by Geoff.

Fallback content inside media elements should not be rendered.

Test: media/fallback.html

rendering/RenderMedia.h: (WebCore::RenderMedia::canHaveChildren):

LayoutTests:

Reviewed by Geoff.

Test that fallback content inside media elements is not be rendered.

media/fallback-expected.txt: Added.
media/fallback.html: Added.

10:04 PM Changeset in webkit [28132] by beidson@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Geoff

Add copyKeysToVector utility, mirroring copyValuesToVector
Also change the copyValuesToVector implementation to be a little more attractive

wtf/HashMap.h: (WTF::copyKeysToVector): (WTF::copyValuesToVector):

9:33 PM Changeset in webkit [28131] by mrowe@apple.com

2 edits in trunk/WebCore

Windows build fix.

9:29 PM Changeset in webkit [28130] by mrowe@apple.com

2 edits in trunk/WebCore

Gtk build fix.

8:50 PM Changeset in webkit [28129] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Oliver.

Make QTMovieView fill color transparent. This behavior matches the specification
(and allows nice alpha blended video).

platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):

6:54 PM IconContestIdeas edited by Adam Roben

(diff)

6:48 PM IconContestIdeas edited by Adam Roben

(diff)

6:48 PM IconContestIdeas edited by Adam Roben

(diff)

6:25 PM Changeset in webkit [28128] by alice.liu@apple.com

17 edits in trunk/LayoutTests

just some more typo fixes

http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-expected.txt:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:

6:02 PM Changeset in webkit [28127] by Antti Koivisto

54 edits
4 adds in trunk

WebCore:

Reviewed by Darin.

Test: media/video-controls.html

<rdar://problem/5605668>
Implement controls attribute for video element

Add RenderMedia and make RenderVideo its subclass. Controls code goes to RenderMedia while video specific (painting etc) code stays in RenderVideo. For example audio controls can be implemented later by just instantiating RenderMedia as renderer.
Make media renderer hierarchy inherit from RenderBlock instead of RenderReplaced so it can have child nodes (for controls).
Controls are implemented as a shadow DOM.
Current look is a placeholder. It is defined purely in CSS.
Some things like volume controls are not yet implemented.
Fade-in/out is done manually, CSS animations don't work well in shadow trees.

WebCore.xcodeproj/project.pbxproj:
css/html4.css:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): (WebCore::HTMLMediaElement::updateMovie): (WebCore::HTMLMediaElement::defaultEventHandler):
html/HTMLMediaElement.h:
rendering/RenderMedia.cpp: Added. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlShadowRootElement::isShadowNode): (WebCore::MediaControlShadowRootElement::shadowParentNode): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::attachToParent): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlPlayButtonElement::inPausedState): (WebCore::MediaControlPlayButtonElement::defaultEventHandler): (WebCore::MediaControlPlayButtonElement::update): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlTimelineElement::update): (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::~RenderMedia): (WebCore::RenderMedia::mediaElement): (WebCore::RenderMedia::movie): (WebCore::RenderMedia::setStyle): (WebCore::RenderMedia::createControlsShadowRoot): (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createPlayButton): (WebCore::RenderMedia::createTimeline): (WebCore::RenderMedia::createTimeDisplay): (WebCore::RenderMedia::updateFromElement): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::timeUpdateTimerFired): (WebCore::RenderMedia::updateTimeDisplay): (WebCore::RenderMedia::updateControlVisibility): (WebCore::RenderMedia::changeOpacity): (WebCore::RenderMedia::opacityAnimationTimerFired): (WebCore::RenderMedia::forwardEvent):
rendering/RenderMedia.h: Added. (WebCore::RenderMedia::renderName): (WebCore::RenderMedia::isMedia): (WebCore::RenderMedia::intrinsicSize):
rendering/RenderObject.h: (WebCore::RenderObject::isMedia):
rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paintObject): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::calcAspectRatioWidth): (WebCore::RenderVideo::calcAspectRatioHeight):
rendering/RenderVideo.h:

LayoutTests:

Reviewed by Darin.

<rdar://problem/5605668>
Implement controls attribute for video element

A new test for the controls attribute.
Add the controls attibute to all existing video tests. This will give the code some additional exercise without affecting test results.

media/progress-event.html:
media/video-append-source.html:
media/video-autoplay.html:
media/video-buffered.html:
media/video-controls-expected.txt: Added.
media/video-controls.html: Added.
media/video-currentTime-set.html:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-autoplay.html:
media/video-dom-end.html:
media/video-dom-loopcount.html:
media/video-dom-loopend.html:
media/video-dom-loopstart.html:
media/video-dom-src.html:
media/video-dom-start.html:
media/video-end.html:
media/video-error-abort.html:
media/video-error-does-not-exist.html:
media/video-load-networkState.html:
media/video-load-readyState.html:
media/video-loopcount.html:
media/video-loopend.html:
media/video-loopstart.html:
media/video-muted.html:
media/video-no-autoplay.html:
media/video-pause-empty-events.html:
media/video-play-empty-events.html:
media/video-play-pause-events.html:
media/video-play-pause-exception.html:
media/video-poster.html:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing.html:
media/video-seekable.html:
media/video-seeking.html:
media/video-size.html:
media/video-source-media.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change.html:
media/video-src-remove.html:
media/video-src-set.html:
media/video-src-source.html:
media/video-src.html:
media/video-start.html:
media/video-volume.html:
media/video-width-height.html:

5:33 PM Changeset in webkit [28126] by justin.garcia@apple.com

15 edits
6 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating

In the new beta, Google has added some custom code on top of our RemoveFormat
to work around a bug where fully selected lists aren't removed. This code corrupts
the undo stack and causes crashes. This change fixes two problems with RemoveFormat
so that Google doesn't have to have any custom code. After checking this in I'll
work on bulletproofing the undo stack

WebCore.xcodeproj/project.pbxproj:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertLineBreak): Added this convenience method. (WebCore::CompositeEditCommand::inputText): Added code to select all inserted text, not just the last paragraph. Added code to support an input string with '\n's.
editing/CompositeEditCommand.h:
editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved code to its own EditCommand.
editing/RemoveFormatCommand.cpp: Added. Moved code from removeFormattingAndStyle here. (WebCore::RemoveFormatCommand::RemoveFormatCommand): (WebCore::RemoveFormatCommand::doApply): Added code to remove fully selected lists.
editing/RemoveFormatCommand.h: Added. (WebCore::RemoveFormatCommand::editingAction):

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating

Added to demonstrate fixes:

editing/execCommand/5573879.html: Added.
platform/mac/editing/execCommand/5573879-expected.checksum: Added.
platform/mac/editing/execCommand/5573879-expected.png: Added.
platform/mac/editing/execCommand/5573879-expected.txt: Added.

Fixes (RemoveFormat now preserves the selection correctly):

platform/mac/editing/execCommand/4920742-1-expected.checksum:
platform/mac/editing/execCommand/4920742-1-expected.png:
platform/mac/editing/execCommand/4920742-1-expected.txt:
platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
platform/mac/editing/execCommand/remove-formatting-2-expected.png:
platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
platform/mac/editing/execCommand/remove-formatting-expected.checksum:
platform/mac/editing/execCommand/remove-formatting-expected.png:
platform/mac/editing/execCommand/remove-formatting-expected.txt:

5:17 PM IconContestIdeas edited by Adam Roben

Little re-organziation (diff)

5:16 PM IconContestIdeas edited by Adam Roben

Added a submissions section (diff)

5:13 PM WebKit Team edited by Adam Roben

(diff)

5:06 PM IconContestIdeas edited by Adam Roben

(diff)

5:05 PM Changeset in webkit [28125] by timothy@apple.com

3 edits in trunk/LayoutTests

Make this test not depend on the screen size.

fast/dom/Window/window-resize-expected.txt:
fast/dom/Window/window-resize.html:

5:04 PM IconContestIdeas edited by Adam Roben

(diff)

5:02 PM IconContestIdeas edited by Adam Roben

Added a disclaimer (diff)

4:59 PM IconContestIdeas edited by Adam Roben

Added a preliminary schedule (diff)

4:44 PM IconContestIdeas edited by Adam Roben

Added voting section (diff)

4:43 PM Changeset in webkit [28124] by Darin Adler

3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): Send capital letters through as lowercase letters with the shift key down rather than sending them as if they were highly unusual "capital letter keys".

Scripts/update-javascriptcore-test-results: Add a "--force" option for cases where you need to update results and more tests are failing than before.

4:33 PM Changeset in webkit [28123] by andersca@apple.com

6 edits in trunk

WebKitTools:

Reviewed by Darin.

<rdar://problem/5132001>
contextClick is not implemented in DRT on Windows.

DumpRenderTree/win/EventSender.cpp: (contextClickCallback): Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed by a WM_RBUTTONUP message.

DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::hasCustomMenuImplementation): (UIDelegate::trackCustomPopupMenu):
DumpRenderTree/win/UIDelegate.h: Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup menu from being shown (and causing the DRT to hang).

LayoutTests:

Reviewed by Darin.

<rdar://problem/5132001>
contextClick is not implemented in DRT on Windows.

Remove tests that pass now that we have contextClick.

platform/win/Skipped:

3:05 PM Changeset in webkit [28122] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing some tests tracked by <rdar://5130762> because they don't fail.

platform/win/Skipped:

3:01 PM IconContestIdeas edited by timothy@apple.com

Rename resolution to size. (diff)

2:54 PM HackingGtk edited by alp@atoker.com

Add an API rationale (diff)

2:51 PM IconContestIdeas edited by Adam Roben

(diff)

2:45 PM Changeset in webkit [28121] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing fixed tests tracked by <rdar://5128229>

platform/win/Skipped:

2:41 PM IconContestIdeas edited by Adam Roben

(diff)

2:29 PM IconContestIdeas edited by Adam Roben

(diff)

2:29 PM IconContestIdeas edited by Adam Roben

(diff)

2:27 PM Changeset in webkit [28120] by alice.liu@apple.com

2 edits
8 moves in trunk/LayoutTests

Rubberstamped by Sam.

Fixing a typo in some filenames

http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Removed.
http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Removed.
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt.
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html.
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt.
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html.
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Removed.
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Removed.
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt.
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html.
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt.
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html.
platform/win/Skipped:

2:25 PM IconContestIdeas created by Adam Roben

Initial ideas for a WebKit icon contest

2:24 PM Changeset in webkit [28119] by kmccullough@apple.com

2 edits in trunk/WebKit/win

Reviewed by Tim.

Added guards to the wait loop so execution would not hang and now the console window can process JavaScript.

WebScriptDebugServer.cpp: (WebScriptDebugServer::suspendProcessIfPaused):

2:04 PM Changeset in webkit [28118] by mitz@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

Test: fast/table/empty-auto-column-zero-divide.html

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): When distributing the remaining width among columns, skip those whose effective (rather than specified) width is auto and contain only empty cells.

LayoutTests:

Reviewed by Dave Hyatt.

test for <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

fast/table/empty-auto-column-zero-divide-expected.txt: Added.
fast/table/empty-auto-column-zero-divide.html: Added.

2:03 PM Changeset in webkit [28117] by adele@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin.

Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6

The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
WebHTMLView to prevent future problems in other methods as well.

WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView flagsChanged:]): (-[WebHTMLView _selectionStartFontAttributesAsRTF]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): (-[WebHTMLView checkSpelling:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView indent:]): (-[WebHTMLView outdent:]): (-[WebHTMLView paste:]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView insertText:]): (-[WebHTMLView selectionTextRects]):

1:17 PM Changeset in webkit [28116] by andersca@apple.com

4 edits in trunk/WebKit/win

Reviewed by Adam.

Implement the last bits of the WebDatabaseManager API.

Interfaces/IWebDatabaseManager.idl:
WebDatabaseManager.cpp: (isEqual): (WebDatabaseManager::sharedWebDatabaseManager): (WebDatabaseManager::dispatchDidModifyOrigin): (WebDatabaseManager::dispatchDidModifyDatabase):
WebDatabaseManager.h:

12:55 PM WebKit Team edited by zimmermann@kde.org

(diff)

12:12 PM Changeset in webkit [28115] by andersca@apple.com

2 edits in trunk/WebKit/win

Get Drosera working again for real.

COMEnumVariant.h: (::Next):

11:57 AM Changeset in webkit [28114] by alp@webkit.org

3 edits in trunk/WebCore

2007-11-28 Peter Kasting <zerodpx@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16169
GIF decoder needs to set hasAlpha() correctly on subsequent frames.

This also removes the workaround for this problem in
ImageSourceCairo.cpp.

platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex):
platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer):

11:37 AM Changeset in webkit [28113] by jhoneycutt@apple.com

2 edits in trunk/LayoutTests

2007-11-28 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Dan.

<rdar://problem/5507360> plugins/return-error-from-new-stream-callback-
in-full-frame-plugin.html is crashing

Alice fixed this in r28046

platform/win/Skipped:

10:08 AM HackingGtk edited by alp@atoker.com

Codify URL vs. URI public API policy (diff)

9:46 AM Changeset in webkit [28112] by kmccullough@apple.com

2 edits in trunk/WebKit/win

Reviewed by Maciej and Adam.

Added Drosera to the WebKit project.

WebKit.vcproj/WebKit.sln:

8:47 AM Changeset in webkit [28111] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler and Adam Roben.

<rdar://problem/5057218> Reenable "recent searches" search field menu when menu is fully implemented

platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::enabled): Changed to return true. (WebCore::autosaveKey): Added. Returns a preferences key for the autosave name by prefixing it with "com.apple.WebKit.searchField:". (WebCore::SearchPopupMenu::saveRecentSearches): Implemented. (WebCore::SearchPopupMenu::loadRecentSearches): Implemented.

5:12 AM Changeset in webkit [28110] by mrowe@apple.com

59 edits
10 deletes in trunk

Roll out r28106 and r28108. These introduced a frequent assertion failure on page load and broke all non-Mac builds.

4:47 AM Changeset in webkit [28109] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-28 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=15689
[GTK] Background of loading images is always black

frameHasAlphaAtIndex() exists only to allow optimization for cases we
are certain the image can be blitted rather than composited.

Thus we need to be conservative, returning false only when we are
absolutely certain there is no need for composited copying, and true
otherwise.

CG doesn't even bother with this optimization at all and always
returns true.

Patch includes a workaround for

http://bugs.webkit.org/show_bug.cgi?id=16169
GIF ImageDecoder hasAlpha() return value incorrect

platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex):

3:03 AM Changeset in webkit [28108] by mjs@apple.com

2 edits
10 adds in trunk

JavaScriptCore:

Add files missing from previous commit.

kjs/MarkStack.h: Added.

LayoutTests:

add files missing from previous commit.

fast/js/gc-breadth-2-expected.txt: Added.
fast/js/gc-breadth-2.html: Added.
fast/js/gc-breadth-expected.txt: Added.
fast/js/gc-breadth.html: Added.
fast/js/gc-depth-expected.txt: Added.
fast/js/gc-depth.html: Added.
fast/js/resources/gc-breadth-2.js: Added.
fast/js/resources/gc-breadth.js: Added.
fast/js/resources/gc-depth.js: Added.

2:42 AM Changeset in webkit [28107] by mrowe@apple.com

2 edits in trunk

2007-11-26 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Mark Rowe.

Set CONFIG option for the window system GTK+ is using

WebKit.pri:

2:08 AM Changeset in webkit [28106] by mjs@apple.com

59 edits in trunk

JavaScriptCore:

Reviewed by Darin and Geoff.

Fixed "Stack overflow crash in JavaScript garbage collector mark pass" http://bugs.webkit.org/show_bug.cgi?id=12216

Implement mark stack. This version is not suitable for prime time because it makes a
huge allocation on every collect, and potentially makes marking of detached subtrees
slow. But it is an 0.4% SunSpider speedup even without much tweaking.

The basic approach is to replace mark() methods with
markChildren(MarkStack&) methods. Reachable references are pushed
onto a mark stack (which encapsulates ignoring already-marked
references).

Objects are no longer responsible for actually setting their own
mark bits, the collector does that. This means that for objects on
the number heap we don't have to call markChildren() at all since
we know there aren't any.

The mark phase of collect pushes roots onto the mark stack
and drains it as often as possible.

To make this approach viable requires a constant-size mark stack
and a slow fallback approach for when the stack size is exceeded,
plus optimizations to make the required stack small in common
cases. This should be doable.

JavaScriptCore.exp: Export new symbols.
JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::drainMarkStack): Helper for all of the below. (KJS::Collector::markStackObjectsConservatively): Use mark stack. (KJS::Collector::markCurrentThreadConservatively): ditto (KJS::Collector::markOtherThreadConservatively): ditto (KJS::Collector::markProtectedObjects): ditto (KJS::Collector::markMainThreadOnlyObjects): ditto (KJS::Collector::collect): ditto
kjs/collector.h: (KJS::Collector::cellMayHaveRefs): Helper for MarkStack.

kjs/MarkStack.h: Added. The actual mark stack implementation. (KJS::MarkStack::push): (KJS::MarkStack::pushAtom): (KJS::MarkStack::pop): (KJS::MarkStack::isEmpty): (KJS::MarkStack::reserveCapacity):

Changed mark() methods to markChildren() methods:

kjs/ExecState.cpp: (KJS::ExecState::markChildren):
kjs/ExecState.h:
kjs/JSWrapperObject.cpp: (KJS::JSWrapperObject::markChildren):
kjs/JSWrapperObject.h:
kjs/array_instance.cpp: (KJS::ArrayInstance::markChildren):
kjs/array_instance.h:
kjs/bool_object.cpp: (BooleanInstance::markChildren):
kjs/bool_object.h:
kjs/error_object.cpp:
kjs/error_object.h:
kjs/function.cpp: (KJS::FunctionImp::markChildren): (KJS::Arguments::Arguments): (KJS::Arguments::markChildren): (KJS::ActivationImp::markChildren):
kjs/function.h:
kjs/internal.cpp: (KJS::GetterSetterImp::markChildren):
kjs/interpreter.cpp: (KJS::Interpreter::markRoots):
kjs/interpreter.h:
kjs/list.cpp: (KJS::List::markProtectedListsSlowCase):
kjs/list.h: (KJS::List::markProtectedLists):
kjs/object.cpp: (KJS::JSObject::markChildren):
kjs/object.h: (KJS::ScopeChain::markChildren):
kjs/property_map.cpp: (KJS::PropertyMap::markChildren):
kjs/property_map.h:
kjs/scope_chain.h:
kjs/string_object.cpp: (KJS::StringInstance::markChildren):
kjs/string_object.h:

JavaScriptGlue:

Reviewed by Darin and Geoff.

Fixups for JavaScriptCore mark stack.

JSObject.cpp: (JSUserObject::Mark):
JSObject.h:
JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
JSValueWrapper.h:
UserObjectImp.cpp:
UserObjectImp.h:

WebCore:

Reviewed by Darin and Geoff.

Implement mark stack. This version is not suitable for prime time because it makes a
huge allocation on every collect, and potentially makes marking of detached subtrees
slow. But it is a .2% - .4% speedup even without much tweaking.

I replaced mark() methods with markChildren() as usual. One
optimization that is lost is avoiding walking detached DOM
subtrees more than once to mark them; since marking is not
recursive there's no obvious way to bracket operation on the tree
any more.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren):
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren):
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/JSNodeFilterCondition.h:
bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::markChildren):
bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::markChildren):
bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::markChildren):
bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::markChildren):
bindings/js/JSXMLHttpRequest.h:
bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument):
bindings/js/kjs_binding.h:
bindings/js/kjs_events.cpp: (WebCore::JSUnprotectedEventListener::markChildren):
bindings/js/kjs_events.h:
bindings/js/kjs_window.cpp: (KJS::Window::markChildren):
bindings/js/kjs_window.h:
bindings/scripts/CodeGeneratorJS.pm:
dom/Node.cpp: (WebCore::Node::Node):
dom/Node.h:
dom/NodeFilter.h:
dom/NodeFilterCondition.h:

LayoutTests:

Not reviewed.

Test cases for "Stack overflow crash in JavaScript garbage collector mark pass" http://bugs.webkit.org/show_bug.cgi?id=12216

I have fixed this with the mark stack work.

fast/js/gc-breadth-2-expected.txt: Added.
fast/js/gc-breadth-2.html: Added.
fast/js/gc-breadth-expected.txt: Added.
fast/js/gc-breadth.html: Added.
fast/js/gc-depth-expected.txt: Added.
fast/js/gc-depth.html: Added.
fast/js/resources/gc-breadth-2.js: Added.
fast/js/resources/gc-breadth.js: Added.
fast/js/resources/gc-depth.js: Added.

1:24 AM Changeset in webkit [28105] by mjs@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Not reviewer for this patch.

1:04 AM Changeset in webkit [28104] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Maciej Stachowiak.

fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)

WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver because addMouseMovedObserver returns early if the dataSource is not nil. But if the dataSource is already set (which happens when a WebHTMLView is being reused) then addMouseMovedObserver must not be called again.

12:27 AM Changeset in webkit [28103] by alp@webkit.org

3 edits
1 add in trunk

2007-11-27 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Install the JavaScriptCore headers as part of the GTK+ port.

Nov 27, 2007:

10:31 PM Changeset in webkit [28102] by Beth Dakin

3 edits
5 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)

platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): Use valueAsPercentage() for percents instead of valueInSpecifiedUnits(). valueInSpecifiedUnits() returns, for example, 50 for 50%, so multiplying percentages by the default size of 300 x 150 led to ridiculously huge dimensions for SVG images, and the subsequent hang.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)

fast/images/resources/width-100-percent.svg: Added.
fast/images/svg-width-100p-as-background.html: Added.
platform/mac/fast/images/svg-width-100p-as-background-expected.checksum: Added.
platform/mac/fast/images/svg-width-100p-as-background-expected.png: Added.
platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Added.

9:54 PM Changeset in webkit [28101] by mjs@apple.com

2 edits in trunk/WebKitTools

Not reviewed.

Fix DumpRenderTree ObjC bug comparing strings.

DumpRenderTree/mac/ObjCController.m: (-[ObjCController identityIsEqual::]): Compare strings with string equality instead of identiy equality.

9:48 PM Changeset in webkit [28100] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-27 Alp Toker <alp@atoker.com>

Prospective MSVC build fix.

Roll back dllexport/dllimport support for now.

API/JSBase.h:

8:50 PM Changeset in webkit [28099] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Adam.

Return bool from registerWebViewWindowClass, as nothing uses the ATOM.
Set haveRegisteredWindowClass to true

WebView.cpp: (registerWebViewWindowClass):

8:47 PM Changeset in webkit [28098] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Adam.

Set haveRegisteredWindowClass when we register the window class.

plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView):

8:31 PM Changeset in webkit [28097] by alp@webkit.org

8 edits in trunk/JavaScriptCore

2007-11-27 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15569
[gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF

Introduce JS_EXPORT to mark symbols to be exported as public API.

Export all public symbols in the JavaScriptCore C API.

This matches conventions for exporting symbols set by the CF and CG
frameworks.

API/JSBase.h:
API/JSContextRef.h:
API/JSObjectRef.h:
API/JSStringRef.h:
API/JSStringRefBSTR.h:
API/JSStringRefCF.h:
API/JSValueRef.h:

6:47 PM Changeset in webkit [28096] by andersca@apple.com

2 edits in trunk/WebKit/win

Speculative fix to get Drosera working.

COMEnumVariant.h: (::Next): Update the number of elements fetched correctly.

5:34 PM Changeset in webkit [28095] by andersca@apple.com

6 edits in trunk/WebKit/mac

Reviewed by Brady.

Storage/WebDatabaseManager.mm:
Storage/WebDatabaseManagerPrivate.h:
Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
Storage/WebSecurityOriginInternal.h:

5:22 PM Changeset in webkit [28094] by timothy@apple.com

2 edits in trunk/WebKitTools

Reviewed by Sam.

Reset the authorAndUserStylesEnabled preference
back to YES for each test. Fixes the broken tests.

DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):

5:12 PM Changeset in webkit [28093] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Sam Weinig.

Bug 16165: Dragging the inspector toolbar should move the window
http://bugs.webkit.org/show_bug.cgi?id=16165

page/inspector/DocumentPanel.js: Call the new drag functions, and cleanup code.
page/inspector/inspector.css: Only make the toolbar transparent in detached mode.
page/inspector/inspector.js: Call the new drag functions, and cleanup code. Add toolbar drag functions that move the window.

5:12 PM Changeset in webkit [28092] by andersca@apple.com

13 edits in trunk/WebKit/win

Reviewed by Adam.

Some COM cleanup.

CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::QueryInterface):
CFDictionaryPropertyBag.h:
WebBackForwardList.cpp: (WebBackForwardList::addItem): (WebBackForwardList::removeItem):
WebDownload.cpp: (WebDownload::initWithRequest):
WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::initWithWebFrameView): (WebFrame::webHistory): (WebFrame::dispatchWillSendRequest):
WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::QueryInterface): (WebURLAuthenticationChallenge::initWithProtectionSpace):
WebURLAuthenticationChallenge.h:
WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::QueryInterface):
WebURLAuthenticationChallengeSender.h:
WebURLResponse.cpp: (WebURLResponse::QueryInterface):
WebURLResponse.h:
WebView.cpp: (WebView::notifyDidAddIcon): (WebView::goToBackForwardItem): (WebView::canHandleRequest): (WebView::loadBackForwardListFromOtherView): (core):

4:35 PM Changeset in webkit [28091] by kmccullough@apple.com

4 edits in trunk/WebKitTools

Reviewed by Adam.

Drosera now displays the console window, although it cannot currently process JavaScript.

Drosera/win/DebuggerClient.cpp: Shows the console window. (registerConsoleClass): Implemented. (consoleWndProc): Implemented. (DebuggerClient::onSize): Implemented. (DebuggerClient::createWebViewWithRequest): Implemented, now creates a new window.
Drosera/win/DebuggerClient.h: Added needed method and members for creating and maintaining a new window.
Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of lines of code to more appropriate places. (Drosera::handleCommand): (Drosera::initUI): (Drosera::onSize): (Drosera::attach):

4:12 PM Changeset in webkit [28090] by andersca@apple.com

2 edits in trunk/WebKit/win

Add COMEnumVariant.h to the project.

WebKit.vcproj/WebKit.vcproj:

4:11 PM Changeset in webkit [28089] by andersca@apple.com

2 edits in trunk/WebKit/win

Reviewed by Adam.

Return E_INVALIDARG if the databaseName BSTR is null;

WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):

3:57 PM Changeset in webkit [28088] by andersca@apple.com

5 edits in trunk/WebKit/win

Reviewed by Adam.

Implement the rest of the WebDatabaseManager API.

COMEnumVariant.h:
Interfaces/IWebDatabaseManager.idl:
WebDatabaseManager.cpp: (isEqual): (DatabaseDetailsPropertyBag::DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::~DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::createInstance): (DatabaseDetailsPropertyBag::AddRef): (DatabaseDetailsPropertyBag::Release): (DatabaseDetailsPropertyBag::QueryInterface): (DatabaseDetailsPropertyBag::Read): (DatabaseDetailsPropertyBag::Write): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
WebDatabaseManager.h:

3:34 PM Changeset in webkit [28087] by timothy@apple.com

2 edits in trunk/LayoutTests

Land results for my last test change,

3:32 PM Changeset in webkit [28086] by adachan@apple.com

3 edits in trunk/WebKit/win

<rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
was not allocated correctly.

Reviewed by Anders.

WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle):
WebHistoryItem.h:

3:30 PM Changeset in webkit [28085] by Antti Koivisto

4 edits in trunk/WebCore

Reviewed by Mitz.

Small changes to make RenderSlider a bit more generic so it can be used in video controls.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fix coordinates with forwarded events.
rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Fix coordinates with forwarded events. (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): Copy thumb left and top from the orginal style so position does not reset. (WebCore::RenderSlider::mouseEventIsInThumb): Make this work with forwarded events.
rendering/RenderSlider.h:

3:27 PM Changeset in webkit [28084] by Antti Koivisto

7 edits in trunk/WebCore

Reviewed by Darin.

Don't use hasPseudoId() optimization for pseudo styles used in shadow trees. These styles generally exist when asked for so the optimization does not do much. This reverses the continuing growth of the _pseudoBits bitfield in RenderStyle.
Add some pseudo elements for media controls

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkOneSelector):
rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
rendering/RenderStyle.cpp: (WebCore::pseudoBit): (WebCore::RenderStyle::hasPseudoStyle): (WebCore::RenderStyle::setHasPseudoStyle):
rendering/RenderStyle.h: (WebCore::RenderStyle::):

3:05 PM Changeset in webkit [28083] by timothy@apple.com

4 edits in trunk

WebCore:

Reviewed by Kevin McCullough.

Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
http://bugs.webkit.org/show_bug.cgi?id=16161

Removed the "Adjust the window rect to be in the coordinate space of
the screen rect" step which was always adding (0,22) to the window
position (on the main screen). Instead, account for screen X and Y
in the bottom and right constrain step.

Added more test cases to: fast/dom/Window/window-resize.html

bindings/js/kjs_window.cpp: (KJS::adjustWindowRect):

LayoutTests:

Reviewed by Kevin McCullough.

Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
http://bugs.webkit.org/show_bug.cgi?id=16161

Added test cases for moveBy(0, 0), moveBy(0, 1) and moveBy(1, 0).

fast/dom/Window/window-resize.html:

3:00 PM Changeset in webkit [28082] by andersca@apple.com

3 edits in trunk/JavaScriptGlue

Build fix.

JSUtils.cpp: (KJSValueToCFTypeInternal):
JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):

2:30 PM Changeset in webkit [28081] by andersca@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Darin, landed by Anders.

Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131

The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
database will compare bundle versions and always load the latest version.

Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes, but we think for now it's good enough for us.
Plugins/WebPluginDatabase.m: (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number. If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate. (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.

2:27 PM Changeset in webkit [28080] by andersca@apple.com

3 edits in trunk/WebKit/win

Reviewed by Adam.

Use COMEnumVariant in WebScriptCallFrame and WebScriptScope.

WebScriptCallFrame.cpp: (WebScriptCallFrame::scopeChain):
WebScriptScope.cpp: (WebScriptScope::variableNames):

2:21 PM Changeset in webkit [28079] by andersca@apple.com

6 edits in trunk/JavaScriptCore

Reviewed by Adam.

Make PropertyNameArray and ScopeChain COMEnumVariant friendly.

kjs/PropertyNameArray.cpp: (KJS::PropertyNameArray::swap): Implement PropertyNameArray::swap.

kjs/PropertyNameArray.h: Add ValueType typedef. Replace PropertyNameArrayIterator with PropertyNameArray::const_iterator.

kjs/nodes.cpp: (KJS::ForInNode::execute):
kjs/scope_chain.cpp: (KJS::ScopeChain::print): Update for changes to PropertyNameArray.

kjs/scope_chain.h: Add const_iterator and ValueType typedef.

1:48 PM Changeset in webkit [28078] by andersca@apple.com

2 edits in trunk/WebKit/win

Reviewed by Adam.

Use the correct include paths.

COMEnumVariant.h:

1:43 PM Changeset in webkit [28077] by andersca@apple.com

4 edits
1 add in trunk/WebKit/win

Reviewed by Darin.

Add COMEnumVariant, a templatized class with implements IEnumVARIANT and lets
you enumerate over a C++ container, be it WTF or STL.

COMEnumVariant.h: Added.

WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): Implement these using COMEnumVariant.

WebSecurityOrigin.cpp: (WebSecurityOrigin::QueryInterface):
WebSecurityOrigin.h: Add a UUID for the implementation so that other parts of WebKit can access the WebCore::SecurityOriginData object.

1:27 PM Changeset in webkit [28076] by andersca@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add a ValueType typedef.

wtf/Vector.h:

1:23 PM Changeset in webkit [28075] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

page/inspector/inspector.css: Make the text in the Network panel legend more readable.

12:51 PM Changeset in webkit [28074] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Don't call setNeedsReapplyStylesInAllFrames if the
authorAndUserStylesEnabled setting didn't change.

page/Settings.cpp: (WebCore::Settings::setAuthorAndUserStylesEnabled):

10:53 AM Changeset in webkit [28073] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-27 Alp Toker <alp@atoker.com>

Fix potential broken build due to a missing DEPENDPATH.

WebCore.pro:

10:48 AM Changeset in webkit [28072] by sullivan@apple.com

3 edits in trunk/WebKitLibraries

Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
that affects Safari.

reviewed by Kevin Decker

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceTiger.a:

9:15 AM Changeset in webkit [28071] by timothy@apple.com

22 edits
2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles

WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter. (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before matching user and author rules. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
dom/Document.cpp: (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector. (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true. (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames when the setting changes.
page/Settings.h: Add m_authorAndUserStylesEnabled. (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.

WebKit/mac:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles

WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
WebView/WebPreferences.m: (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES. (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value. (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.

WebKitTools:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles

Add support for disabling author and user styles for testing.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/LayoutTestController.cpp: (setAuthorAndUserStylesEnabledCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAuthorAndUserStylesEnabled):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled):

LayoutTests:

Reviewed by Dave Hyatt.

Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles

fast/css/disabled-author-styles.html: Added.
platform/mac/fast/css/disabled-author-styles-expected.txt: Added.

7:06 AM QtWebKitGitInstructions edited by Simon Hausmann

(diff)

1:48 AM HackingGtk edited by alp@atoker.com

Link to OptimizingGtk (diff)

12:15 AM Changeset in webkit [28070] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-27 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Based on changes by Mike Emmel.

CURL HTTP backend local file fixes:

Set a MIME type for local files based on the file extension.

Remove any HTTP query part sent to a local file.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):

Nov 26, 2007:

7:28 PM Changeset in webkit [28069] by beidson@apple.com

13 edits in trunk

WebCore:

Reviewed by Mark Rowe

Allow setting the default storage quota per database origin

WebCore.base.exp:

page/Settings.cpp: (WebCore::Settings::setDefaultDatabaseOriginQuota): (WebCore::Settings::defaultDatabaseOriginQuota):
page/Settings.h:

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDefaultOriginQuota): (WebCore::DatabaseTracker::defaultOriginQuota):
storage/DatabaseTracker.h:

WebKit/mac:

Reviewed by Mark Rowe

Provide API for setting the default storage quota per database origin

Misc/WebNSDictionaryExtras.h:
Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto (-[WebPreferences defaultDatabaseQuota]): (-[WebPreferences setDefaultDatabaseQuota:]):
WebView/WebPreferencesPrivate.h:

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref

7:01 PM Changeset in webkit [28068] by alp@webkit.org

6 edits in trunk/WebCore

2007-11-26 Peter Kasting <zerodpx@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):

6:20 PM Changeset in webkit [28067] by Adam Roben

5 edits in trunk

Make WebKitGraphics able to handle grayscale colors

WebCore:

Add a Color(CGColorRef) constructor

Reviewed by Darin.

platform/graphics/Color.h:
platform/graphics/cg/ColorCG.cpp: (WebCore::Color::Color): Added.

WebKit/win:

Take advantage of the new Color constructor that takes a CGColorRef

This lets us handle grayscale colors (which only have 2 components).

Reviewed by Darin.

WebKitGraphics.cpp: (DrawTextAtPoint):

6:15 PM Changeset in webkit [28066] by adele@apple.com

2 edits in trunk/WebCore

Reviewed by Darin.

Update to last change. Moved addPendingSheet call to within nil check for m_cachedSheet.

page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):

6:08 PM Changeset in webkit [28065] by alp@webkit.org

7 edits in trunk/WebKit/gtk

2007-11-26 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16149
Implement the window-object-cleared signal

This implementation provides the JSGlobalContextRef and JSObjectRef
directly rather than using an intermediate JS wrapper object, similar
to the approach taken by the Win port.

Api/webkitgtk-marshal.list:
Api/webkitgtkframe.h:
Api/webkitgtkpage.cpp:
Api/webkitgtkpage.h:
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):

6:07 PM Changeset in webkit [28064] by adele@apple.com

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5591583> CrashTracer: [USER] 157 in Mail crashes at -[WebCoreFrameBridge reapplyStylesForDeviceType:]

page/Frame.cpp: Add nil checks since every other caller of requestCSSStyleSheet checks for nil. (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):

6:05 PM Changeset in webkit [28063] by mrowe@apple.com

2 edits in trunk/WebCore

GCC 4.2 build fix.

xml/XSLTUnicodeSort.cpp: Add another WTF_ATTRIBUTE_PRINTF.

5:52 PM Changeset in webkit [28062] by weinig@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed and touched up by Sam Weinig.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16073

Test: http/tests/security/xss-DENIED-invalid-domain-change.html

dom/Document.cpp: (WebCore::Document::setDomain): Don't set the securityOrigin policy unless the set succeeds. Adds some early returns as well.

LayoutTests:

Reviewed by Sam Weinig.

Tests for http://bugs.webkit.org/show_bug.cgi?id=16073

http/tests/security/resources/iframe-invalid-domain-change.html: Added.
http/tests/security/xss-DENIED-invalid-domain-change-expected.txt: Added.
http/tests/security/xss-DENIED-invalid-domain-change.html: Added.

5:35 PM Changeset in webkit [28061] by Darin Adler

3 edits in trunk/WebKit/mac

Reviewed by Adele.

some middle-mouse-button-related fixes

These don't affect Safari since it maps the middle mouse button to the command key,
but that might not always be the case for future versions.

WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore. (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events. (-[WebHTMLView otherMouseUp:]): Ditto, for up events.

WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.

5:25 PM Changeset in webkit [28060] by sfalken@apple.com

2 edits in trunk/WebKit/win

Build fix.

WebKit.vcproj/WebKit.make:

5:08 PM Changeset in webkit [28059] by sfalken@apple.com

5 edits in trunk

WebCore:

Build fix.

WebCore.vcproj/WebCore.make:
WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

WebKit.vcproj/build-generated-files.sh:

4:50 PM Changeset in webkit [28058] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=16096 REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

Test: fast/js/regexp-overflow.html

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Removed a stray "ptr++" that I added by accident when merging the changes between PCRE 6.4 and 6.5.

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=16096 REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

fast/js/regexp-overflow-expected.txt: Added.
fast/js/regexp-overflow.html: Added.
fast/js/resources/regexp-overflow.js: Added.

4:28 PM Changeset in webkit [28057] by weinig@apple.com

2 edits in trunk/WebCore

Fix potential null-dereference.

Reviewed by Adam Roben.

page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf):

4:15 PM Changeset in webkit [28056] by weinig@apple.com

7 edits
9 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5592988>

Enforce tighter restrictions on what frames in other domains can be navigated.

Tests: http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html

http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html

bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldAllowNavigation): Move and update logic from canTarget().
loader/FrameLoader.h:
page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): Make this O(1) in the case when both frames are not in the same page.

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5592988>

Update and add tests for new tighter restrictions on what frames in other domains can be navigated.

http/tests/security/cross-frame-access-location-expected.txt:
http/tests/security/frameNavigation: Added.
http/tests/security/frameNavigation/resources: Added.
http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Added.
http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Added.
http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Added.
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Added.
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Added.
http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Added.
http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Added.

3:53 PM Changeset in webkit [28055] by sfalken@apple.com

4 edits in trunk

WebCore:

Build fix.

WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

WebKit.vcproj/build-generated-files.sh:

3:50 PM Changeset in webkit [28054] by ggaren@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Fixed typo

3:48 PM Changeset in webkit [28053] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

Fixed <rdar://problem/5597937> REGRESSION (r27126): Drosera does not
show variables (can't enumerate ActivationImp properties)

Implemented a custome ActivationImp::getPropertyNames, since
ActivationImp now uses a custom property storage mechanism for local
variables.

kjs/function.cpp: (KJS::ActivationImp::getPropertyNames):
kjs/function.h:

3:45 PM Changeset in webkit [28052] by andersca@apple.com

8 edits
2 adds in trunk/WebKit/win

Reviewed by Adam.

Add an implementation of IWebSecurityOrigin and a partially stubbed out
implementation of IWebDatabaseManager.

ForEachCoClass.h:
Interfaces/IWebDatabaseManager.idl:
Interfaces/WebKit.idl:
WebDatabaseManager.cpp: (WebDatabaseManager::createInstance): (WebDatabaseManager::WebDatabaseManager): (WebDatabaseManager::~WebDatabaseManager): (WebDatabaseManager::QueryInterface): (WebDatabaseManager::AddRef): (WebDatabaseManager::Release): (WebDatabaseManager::sharedWebDatabaseManager): (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
WebDatabaseManager.h:
WebKit.vcproj/WebKit.vcproj:
WebKitClassFactory.cpp:
WebSecurityOrigin.cpp: Added. (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::~WebSecurityOrigin): (WebSecurityOrigin::QueryInterface): (WebSecurityOrigin::AddRef): (WebSecurityOrigin::Release): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
WebSecurityOrigin.h: Added.

3:34 PM Changeset in webkit [28051] by mitz@apple.com

2 edits in trunk/WebKitTools

Tiger build fix.

DumpRenderTree/mac/Configurations/Base.xcconfig:

3:03 PM Changeset in webkit [28050] by kmccullough@apple.com

11 edits in trunk

WebKit/win:

Reviewed by Maciej.

Implemented displaying variables for Drosera on Win.

Interfaces/IWebScriptCallFrame.idl: Added a local function to be able to access the WebScriptCallFrame.
Interfaces/IWebScriptScope.idl: Implemented.
Interfaces/WebKit.idl: Added WebScriptScope to the tlb.
WebKit.vcproj/Interfaces.vcproj:
WebScriptCallFrame.cpp: Implemented the helper and accessor methods. (EnumScopes::Next): Fixed a bug where we did not release correctly and would accidentally destroy scopes. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Implemented. (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Implemented
WebScriptCallFrame.h: Implemented the helper and accessor methods. (WebScriptCallFrame::impl): (WebScriptCallFrame::state):
WebScriptScope.cpp: Implmented. (EnumVariables::EnumVariables): Created an IEnumVariant over the variables to be able to pass a DCOM acceptable structure back to Drosera. (EnumVariables::createInstance): (EnumVariables::QueryInterface): (EnumVariables::AddRef): (EnumVariables::Release): (EnumVariables::Next): (EnumVariables::Skip): (EnumVariables::Reset): (EnumVariables::Clone): (WebScriptScope::WebScriptScope): (WebScriptScope::createInstance): Implemented. (WebScriptScope::variableNames): Implemented. (WebScriptScope::valueForVariable):
WebScriptScope.h: Implmeneted.

WebKitTools:

Reviewed by Maciej.

Implemented displaying variables for Drosera on Win.

Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions that retrieve variables to not hold onto the return value since it's not returned. Also changed to use the new signatures of the retrieval functions. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
Drosera/win/Drosera.cpp: Removed a needless TODO. (droseraWndProc):

2:15 PM Changeset in webkit [28049] by andersca@apple.com

3 edits
2 adds in trunk/WebKit/win

Reviewed by Brady.

Add IWebDatabaseManager and IWebSecurityOrigin interfaces.

Interfaces/IWebDatabaseManager.idl: Added.
Interfaces/IWebSecurityOrigin.idl: Added.
WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/WebKitGUID.vcproj:

1:19 PM Changeset in webkit [28048] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

Test: fast/dynamic/float-withdrawal-2.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): When a float may have been withdrawn from a child, mark all descendants if necessary and not just the child.

LayoutTests:

Reviewed by Dave Hyatt.

test for <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

fast/dynamic/float-withdrawal-2.html: Added.
platform/mac/fast/dynamic/float-withdrawal-2-expected.checksum: Added.
platform/mac/fast/dynamic/float-withdrawal-2-expected.png: Added.
platform/mac/fast/dynamic/float-withdrawal-2-expected.txt: Added.

1:16 PM Changeset in webkit [28047] by weinig@apple.com

4 edits in trunk/WebKitTools

Cleanup names of painting and repainting functions.

Reviewed by Adam Roben.

DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect): was drawSelectionRectIntoContext. (dumpWebViewAsPixelsAndCompareWithExpected):
DumpRenderTree/cg/PixelDumpSupportCG.h:
DumpRenderTree/mac/PixelDumpSupportMac.mm: (paintWebView): was drawWebViewIntoContext. (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.

11:51 AM Changeset in webkit [28046] by alice.liu@apple.com

2 edits in trunk/WebKit/win

Reviewed by Jon Honeycutt.

Fall back to the default Policy Delegate in these functions,
as is already done in dispatchDecidePolicyForNavigationAction

WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchUnableToImplementPolicy):

11:47 AM Changeset in webkit [28045] by mitz@apple.com

2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

Leopard build fix

DumpRenderTree/mac/Configurations/Base.xcconfig:

11:35 AM Changeset in webkit [28044] by andersca@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Brady.

Get rid of the WebSecurityOriginPrivate object and store
the WebCore::SecurityOriginData pointer in the _private field of
the WebSecurityOrigin object instead.

Storage/WebDatabaseManager.mm: (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]): (-[WebSecurityOrigin _core]):
Storage/WebSecurityOriginInternal.h:

11:34 AM Changeset in webkit [28043] by sfalken@apple.com

2 edits
1 move in trunk/WebCore

Build fix.

WebCore.vcproj/MigrateIDLAndScripts: Copied from WebCore.vcproj/MigrateIDLAndScripts.make.
WebCore.vcproj/MigrateIDLAndScripts.make: Removed.
WebCore.vcproj/migrate-idls.sh:

11:19 AM Changeset in webkit [28042] by weinig@apple.com

7 edits
2 moves
2 deletes in trunk/WebKitTools

Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
Use shared PixelDumpSupport for Mac DRT

Reviewed by Adam Roben.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
DumpRenderTree/cg/ImageDiffCG.cpp:
DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRectIntoContext): (dumpWebViewAsPixelsAndCompareWithExpected):
DumpRenderTree/cg/PixelDumpSupportCG.h:
DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/DumpRenderTree.mm: (dump):
DumpRenderTree/mac/ImageDiff.m: Removed.
DumpRenderTree/mac/PixelDumpSupport.h: Removed.
DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm. (setDefaultColorProfileToRGB): (getBitmapContextFromWebView): (drawWebViewIntoContext): (repaintWithVerticalSweep): (repaintWithHorizontalSweep): (getSelectionRect):
DumpRenderTree/win/PixelDumpSupport.h: Removed.

11:17 AM Changeset in webkit [28041] by beidson@apple.com

3 edits in trunk/WebCore

Reviewed by Anders (and typo lovingly found by Adam)

Change Databases to be stored in a per-origin directory hierarchy - this will make
storage quotas much easier to enforce

platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::SecurityOriginData): Parse string based on '_' instead of ':' (WebCore::SecurityOriginData::stringIdentifier): Change to use '_' as a separator instead of ':'. '_' still works due to not being allowed in domain names, but also is a valid filename character ' on all filesystems we care about

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Create a per-origin directory hierarchy to categorize databases by origin

10:40 AM Changeset in webkit [28040] by alp@webkit.org

1 edit
1 add in trunk/JavaScriptCore

2007-11-26 Alp Toker <alp@atoker.com>

GTK+/Qt/Wx build fix for breakage introduced in r28039.

ForwardingHeaders/JavaScriptCore/JSRetainPtr.h: Added.

9:17 AM Changeset in webkit [28039] by timothy@apple.com

12 edits in trunk

WebCore:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
http://bugs.webkit.org/show_bug.cgi?id=16137

On Leopard the toolbar background will be transparent, to allow the
window background to show through the transparent WebView. The
search results divs needed to move inside the "main" div, so they
would be clipped and not show where the toolbar is.

page/InspectorController.cpp: (WebCore::platform): Return a string for which platform we are. (WebCore::InspectorController::windowScriptObjectAvailable): Define the platform function on the JavaScript class.
page/inspector/Panel.js: Add panels to the panels div.
page/inspector/inspector.css: On the Leopard platform make the toolbar background transparent so the window background shows.
page/inspector/inspector.html: Add a panels div and move search result divs inside the main div.
page/inspector/inspector.js: Tweak the resize code to acount for the search results divs moving inside the main div.

WebKit/mac:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
http://bugs.webkit.org/show_bug.cgi?id=16137

Create the Web Inspector window with the textured style. Set the content border
thickness for the top of the window or the height of the toolbar. Also make the
window's bottom corners square, since a normal textured window normally has
rounded bottom corners.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):

WebKitLibraries:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
http://bugs.webkit.org/show_bug.cgi?id=16137

Add a new function to make bottom window corners square for textured windows.

WebKitSystemInterface.h:
libWebKitSystemInterfaceTiger.a:
libWebKitSystemInterfaceLeopard.a:

Nov 25, 2007:

11:29 PM Changeset in webkit [28038] by Adam Roben

2 edits in trunk/WebKit/win

Fix a leak pointed out by Alexey

WebView.cpp: (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't know to call delete[].

11:06 PM Changeset in webkit [28037] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 16052: prepare-ChangeLog doesn't report deleted files
<http://bugs.webkit.org/show_bug.cgi?id=16052>

Reviewed by Sam.

Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.

11:02 PM Changeset in webkit [28036] by Adam Roben

3 edits in trunk/WebKit/win

Fix Bug 16138: Reduce code duplication in WebView.cpp

http://bugs.webkit.org/show_bug.cgi?id=16138

Reviewed by Sam.

WebView.cpp: (getUpdateRects): Factored code out of updateBackingStore and paint into this new helper function. (WebView::updateBackingStore): Use getUpdateRects. (WebView::paint): Ditto. (WebView::paintIntoBackingStore): Changed to take a const IntRect&. (WebView::paintIntoWindow): Ditto.
WebView.h:

10:00 PM Changeset in webkit [28035] by ddkilzer@apple.com

2 edits
1 delete in trunk/WebKitTools

Bug 15864: Replace merge-changelog with resolve-ChangeLogs
<http://bugs.webkit.org/show_bug.cgi?id=15864>

Reviewed by Adam.

Roll functionality of merge-changelog into resolve-ChangeLogs
script. The script now checks for ChangeLog.rej and
ChangeLog.orig files first. If it finds them, it uses the
ChangeLog.rej file as a patch (in old contextual diff format) to
apply with --fuzz=3.

Scripts/merge-changelog: Removed.
Scripts/resolve-ChangeLogs: Handle traditional rejected patches.

9:26 PM Changeset in webkit [28034] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Add a known failure.

9:25 PM Changeset in webkit [28033] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Remove an unnecessary entry.

8:16 PM Changeset in webkit [28032] by weinig@apple.com

4 edits
2 adds in trunk/WebKitTools

Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

Reviewed by Mark Rowe.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.

7:52 PM Changeset in webkit [28031] by weinig@apple.com

2 edits
4 adds in trunk/WebKitTools

Convert DumpRenderTree to ues .xcconfig files.

Reviewed by Mark Rowe.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/Configurations: Added.
DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.

6:54 PM Changeset in webkit [28030] by weinig@apple.com

12 edits
8 adds in trunk/WebKitTools

Add ForwardingHeaders to wtf for DumpRenderTree.

Reviewed by Mark Rowe.

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/ForwardingHeaders: Added.
DumpRenderTree/ForwardingHeaders/wtf: Added.
DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
DumpRenderTree/LayoutTestController.cpp:
DumpRenderTree/WorkQueue.cpp:
DumpRenderTree/mac/DumpRenderTree.mm:
DumpRenderTree/mac/FrameLoadDelegate.mm:
DumpRenderTree/mac/JavaScriptThreading.cpp:
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/mac/ObjCController.m:
DumpRenderTree/mac/UIDelegate.mm:
DumpRenderTree/mac/WorkQueueItemMac.mm:

6:37 PM Changeset in webkit [28029] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-25 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Remove the unneeded CFNETWORK #ifdefs.

loader/NetscapePlugInStreamLoader.h:

6:12 PM Changeset in webkit [28028] by mrowe@apple.com

5 edits in trunk/WebCore

2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>

Reviewed by Sam Weinig.

Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

dom/XMLTokenizer.cpp:
dom/XMLTokenizer.h:
platform/DeprecatedString.h:
platform/PlatformString.h:

6:12 PM Changeset in webkit [28027] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>

Reviewed by Maciej Stachowiak.

Fix minor compiler warning (GCC 4.1.3)

pcre/pcre_internal.h:
pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):

5:53 PM Changeset in webkit [28026] by Adam Roben

2 edits in trunk/WebKitTools

Fix some test failures caused by r28019

Now that stdout is in binary mode, we need to always use printf
instead of wprintf. Otherwise we'll end up with UTF-16 characters in
the output.

Reviewed by Sam.

DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with printf. (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):

5:06 PM Changeset in webkit [28025] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix off-center error images

Covered by many pixel tests with missing images

rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Account for the 1 pixel outline when positioning the error image.

4:13 PM Changeset in webkit [28024] by Adam Roben

2 edits in trunk/WebKitTools

Set the font smoothing preference in DRT

This makes the pixel results on Windows closer to the Mac results.

Reviewed by Mitz.

DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):

4:03 PM Changeset in webkit [28023] by Adam Roben

4 edits
2 adds in trunk

Fix Bug 16133: Implement pixel test support on Windows

WebKit/win:

Add ImageDiff.vcproj to WebKit.sln

Reviewed by Sam.

WebKit.vcproj/WebKit.sln:

WebKitTools:

Port ImageDiff to CG and C++

Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
DumpRenderTree/cg/ImageDiffCG.cpp: Added. (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap): (computePercentageDifferent):
DumpRenderTree/win/ImageDiff.vcproj: Added.

4:03 PM Changeset in webkit [28022] by Adam Roben

2 edits in trunk/WebKitTools

Fix image diff link generation on Windows

Reviewed by Sam.

Scripts/run-webkit-tests: Removed unnecessary and incorrect calls to toURL.

4:02 PM Changeset in webkit [28021] by Adam Roben

3 edits
7 adds in trunk/WebKitTools

Implement pixel dumping in Windows DRT

Part of http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added. (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a Content-Length header. (getMD5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):
DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
DumpRenderTree/win/DumpRenderTree.cpp: (dump): Do a pixel dump if requested. (main): Parse pixel test options.
DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added the cg/ subdirectory to the include path.
DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't available in a header or import library, so we have to go through this LoadLibrary/GetProcAddress dance to use them. (cryptDLL): (init): (update): (final): (MD5_Init): (MD5_Update): (MD5_Final):
DumpRenderTree/win/MD5.h: Added.
DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be moved up to the top level to share it with Mac eventually.
DumpRenderTree/win/PixelDumpSupportWin.cpp: Added. (getBitmapContextFromWebView): Forces the WebView to paint using a WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.

4:02 PM Changeset in webkit [28020] by Adam Roben

2 edits in trunk/WebKitTools

Clean up Windows DRT's option parsing a little bit

Reviewed by Sam.

DumpRenderTree/win/DumpRenderTree.cpp: (main): Put non-option arguments into a Vector.

4:01 PM Changeset in webkit [28019] by Adam Roben

3 edits in trunk/WebKitTools

Make Windows DRT stop changing LF into CRLF

Reviewed by Sam.

DumpRenderTree/win/DumpRenderTree.cpp: (main): Put stdout in binary mode.
Scripts/run-webkit-tests: Remove the CRLF hack.

2:14 PM Changeset in webkit [28018] by mrowe@apple.com

3 edits
3 adds in trunk

Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting http://mysit.es (crashes release build)

pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated

to our caller like they expect.

Reviewed by Dan Bernstein.

1:16 PM Changeset in webkit [28017] by kevino@webkit.org

4 edits in trunk

wx build fixes for Linux/GTK+ port.

5:06 AM Changeset in webkit [28016] by Nikolas Zimmermann

1 edit in trunk/WebCore/ChangeLog

Fix wrong bug number in ChangeLog. Not reviewed.

5:04 AM Changeset in webkit [28015] by Nikolas Zimmermann

14 edits
4 adds in trunk

Reviewed by Adam Roben.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15393

Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:
svg/text/textPathBoundsBug.svg

Fixed testcase: (all showed text selection problems on text paths)
svg/batik/text/textGlyphOrientationHorizontal.svg
svg/batik/text/textOnPath.svg
svg/batik/text/textOnPath3.svg
svg/batik/text/verticalTextOnPath.svg
svg/text/text-align-04-b.svg
svg/W3C-SVG-1.1/text-align-04-b.svg

1:45 AM Changeset in webkit [28014] by ap@webkit.org

9 edits
2 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15919
XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

Test: fast/xsl/extra-lf-at-end.html

xml/XSLTProcessor.cpp: (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend(). (WebCore::saveResultToString): Remove trailing line feed if present.

12:48 AM Changeset in webkit [28013] by alp@webkit.org

7 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Public API enhancements:

Implement webkit_page_get_editable() and webkit_page_set_editable().

Implement webkit_frame_get_name().

Remove definitions for functions that are unusable or not implemented.
This has caused much confusion for application developers.

Improve documentation.

Correct/constify some return types.

Add parameter checks.

Make the default fixed font "Courier New" to match the other Web
font names.

Api/webkitgtkframe.cpp:
Api/webkitgtkframe.h:
Api/webkitgtkpage.cpp:
Api/webkitgtkpage.h:
Api/webkitgtkprivate.h:
WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isEditable):

Nov 24, 2007:

11:15 PM Changeset in webkit [28012] by ddkilzer@apple.com

3 edits in trunk/LayoutTests

Added tests for select.options.remove(boolean).

Reviewed by Maciej.

fast/js/resources/select-options-add.js: Added two tests.
fast/js/select-options-add-expected.txt: Updated results.

7:39 PM Changeset in webkit [28011] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16125
[GTK] Up key doesn't work properly when content is editable

Add a missing 'break' to avoid falling through to the next case when
handling VK_UP keystrokes. This was noticed when working on editing
support in the GTK+ port.

I've checked the other cases for similar typos and they seem fine.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):

7:13 PM Changeset in webkit [28010] by ddkilzer@apple.com

1 edit
1 delete in trunk/WebKitTools

2007-11-24 David Kilzer <ddkilzer@webkit.org>

Removed empty directory.

Scripts/resources: Removed.

6:53 PM Changeset in webkit [28009] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-24 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15745
[GTK] Arrow keys do not Scroll

Api/webkitgtkpage.cpp:

Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for
details.

5:23 PM Changeset in webkit [28008] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Fix call to gtk_message_dialog_new() which expects a format string.

Api/webkitgtkpage.cpp:

4:23 PM HackingGtk edited by alp@atoker.com

Mention the build bots (diff)

3:56 PM Changeset in webkit [28007] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Tiger build fix.

Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.

3:48 PM Changeset in webkit [28006] by mrowe@apple.com

7 edits in trunk

Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
http://bugs.webkit.org/show_bug.cgi?id=13705

Reviewed by Tim Hatcher.

Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading. On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.

The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.

3:43 PM Changeset in webkit [28005] by Adam Roben

8 edits
2 deletes in trunk

Get rid of WebCoreSystemInterface on Windows

WebCore:

Get rid of WebCoreSystemInterface on Windows

The one function defined in that file is now in WebKitSystemInterface.

Reviewed by Tim.

WebCore.vcproj/WebCore.vcproj: Removed WebCoreSystemInterface.{cpp,h}.
platform/graphics/cg/ImageCG.cpp: Made #include of WebCoreSystemInterface.h Mac-only.
platform/win/GraphicsContextWin.cpp: Ditto.
platform/win/WebCoreSystemInterface.cpp: Removed.
platform/win/WebCoreSystemInterface.h: Removed.

WebKitLibraries:

Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows

Reviewed by Tim.

win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added declaration.
win/lib/WebKitSystemInterface.lib: Updated.
win/lib/WebKitSystemInterface_debug.lib: Updated.

3:33 PM Changeset in webkit [28004] by Adam Roben

6 edits in trunk/WebCore

Replace uses of %@ with %s in the inspector

Rubberstamped by Tim.

English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
page/inspector/DatabasePanel.js: Ditto.
page/inspector/StylesSidebarPane.js: Ditto.
page/inspector/inspector.js: Ditto.
page/inspector/utilities.js: (String.vsprintf): Removed @ as a format specifier.

3:32 PM Changeset in webkit [28003] by Adam Roben

3 edits in trunk/WebCore

Windows build fix

Turn off the change made in r27984 on Windows for now.

xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString):
xml/XSLTUnicodeSort.cpp:

2:35 PM Changeset in webkit [28002] by timothy@apple.com

12 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
addEventListener and setTimeout
http://bugs.webkit.org/show_bug.cgi?id=16121

Add Function.prototype.bind. This helper will return a wrapper function
that will call the original function with the supplied arguments
and using the supplied 'this' object.

page/inspector/Database.js: Remove a use of setTimeout by inheriting some common functions from Resource.
page/inspector/DatabasePanel.js: Use the new bind function.
page/inspector/ConsolePanel.js: Ditto.
page/inspector/DocumentPanel.js: Ditto.
page/inspector/NetworkPanel.js: Ditto.
page/inspector/PropertiesSection.js: Ditto.
page/inspector/Resource.js: Ditto.
page/inspector/SidebarPane.js: Ditto.
page/inspector/inspector.html: Moved Database.js after Resource.js, now that Database.js uses it.
page/inspector/inspector.js: Use the new bind function. Also removed a setTimeout used for the localized strings code. There is now a load event listener added to the localized strings script element that will call WebInspector.loaded.
page/inspector/utilities.js: Add Function.prototype.bind.

2:20 PM Changeset in webkit [28001] by timothy@apple.com

1 edit in trunk/WebCore/English.lproj/InspectorLocalizedStrings.js

Add missing strings.

1:52 PM Changeset in webkit [28000] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] Webkit doesn't show title attribute tooltip when hovering over an image

Implement tooltip support using the new Tooltip API.

Support for older versions of GTK+ is still lacking.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip):

11:18 AM Changeset in webkit [27999] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads
http://bugs.webkit.org/show_bug.cgi?id=16112

In the places where we use offsetWidth and offsetHeight before
the stylesheet loads there is now a check. If the body's
offsetWidth is not greater than zero, then set a timeout
to do the updates requiring the stylesheet later.

The three places this happened:

DOM tree selection highlight would show up at the wrong height when using Inspect Element to open the inspector.
DOM tree breadcrumbs would not collapse when using Inspect Element to open the inspector.
Network Timeline divider lines would not show when opening directly into the timeline.

page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
page/inspector/NetworkPanel.js: Ditto.
page/inspector/inspector.html: Include the stylesheet before any scripts, this will help get it loaded sooner.

10:18 AM Changeset in webkit [27998] by kevino@webkit.org

2 edits in trunk/WebCore

Add wx implementation for pathGetFilename

Reviewed by David D. Kilzer.

Nov 23, 2007:

10:09 PM Changeset in webkit [27997] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Fix bisect-builds to work with recent WebKit nightly builds.

Reviewed by Dan.

Scripts/bisect-builds: Check for the WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use it for the DYLD_FRAMEWORK_PATH environment variable, else fallback to WebKit.app/Contents/Resources.

8:48 PM Changeset in webkit [27996] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16110: Clicking inside the resource headers in the network timeline collapses them
http://bugs.webkit.org/show_bug.cgi?id=16110

Toggle the resource headers only if the click happens on the
resource row, not within the headers area.

WebCore.xcodeproj/project.pbxproj:
page/inspector/NetworkPanel.js:

8:11 PM HackingGtk edited by alp@atoker.com

Add WebCore and WebKit specific hacking guides (diff)

7:14 PM Changeset in webkit [27995] by oliver@apple.com

2 edits in trunk/WebKit/mac

Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves

Reviewed by Mark Rowe.

4:52 PM Changeset in webkit [27994] by kevino@webkit.org

7 edits in trunk

Windows build fixes for USE(CURL) and MSVC compilation for ports.

Reviewed by Adam Roben.

4:11 PM BuildingGtk edited by alp@atoker.com

Fix the link, split out the hacking guide (diff)

4:11 PM HackingGtk created by alp@atoker.com

Add GTK+ hacking information verbatim

4:05 PM BuildingGtk edited by alp@atoker.com

Add link to HackingGtk (diff)

3:22 PM Changeset in webkit [27993] by kevino@webkit.org

2 edits in trunk

Forgot to add JSCore and WebCore ChangeLog during previous commit.

3:17 PM Changeset in webkit [27992] by kevino@webkit.org

11 edits in trunk

Fix the wx buildbot after removal of move-js-headers.sh..

2:03 PM Changeset in webkit [27991] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Implement and document several WebKitFrame functions, some of which
are necessary to support DRT.

Correct NULL handling and improve run-time checks.

Api/webkitgtkframe.cpp:
Api/webkitgtkframe.h:
Api/webkitgtkprivate.cpp:

12:07 PM Changeset in webkit [27990] by Antti Koivisto

17 edits in trunk/LayoutTests

Set video src from script, not from the element attribute. This
guarantees load events do not fire before event listeners are registered.
This change does not affect test results.

media/progress-event.html:
media/video-autoplay.html:
media/video-buffered.html:
media/video-currentTime-set.html:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-autoplay.html:
media/video-error-abort.html:
media/video-error-does-not-exist.html:
media/video-load-networkState.html:
media/video-load-readyState.html:
media/video-no-autoplay.html:
media/video-seekable.html:
media/video-seeking.html:
media/video-size.html:
media/video-src.html:
media/video-start.html:

7:56 AM Changeset in webkit [27989] by Simon Hausmann

2 edits in trunk/WebCore

Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).

Signed-off-by: George Staikos <staikos@kde.org>

7:44 AM Changeset in webkit [27988] by Simon Hausmann

3 edits in trunk/JavaScriptCore

Fix make (dist)clean on Windows.

OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.

Signed-off-by: George Staikos <staikos@kde.org>

6:37 AM QtWebKitGitInstructions edited by Simon Hausmann

(diff)

5:56 AM QtWebKitGitInstructions edited by Simon Hausmann

(diff)

5:30 AM UsingGitWithWebKit edited by Simon Hausmann

(diff)

5:30 AM QtWebKitGitInstructions created by Simon Hausmann

5:29 AM QtWebKitContrib edited by Simon Hausmann

(diff)

5:29 AM QtWebKitContrib edited by Simon Hausmann

(diff)

5:21 AM UsingGitWithWebKit edited by Simon Hausmann

(diff)

5:19 AM UsingGitWithWebKit edited by Simon Hausmann

(diff)

4:27 AM Changeset in webkit [27987] by ap@webkit.org

2 edits in trunk/WebCore

Not reviewed, trivial leak fix.

Fix xsltUnicodeSortFunction() memory leaks.

xml/XSLTUnicodeSort.cpp: (WebCore::xsltUnicodeSortFunction):

2:52 AM ProjectVision created by lars@webkit.org

2:19 AM Changeset in webkit [27986] by ap@webkit.org

6 edits
8 adds in trunk

Reviewed by Maciej.

<rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
not closed (affects digg.com)

Tests: fast/loader/meta-refresh-vs-open.html

fast/loader/redirect-with-open-subframe-2.html
fast/loader/redirect-with-open-subframe.html
http/tests/loading/onload-vs-immediate-refresh.pl

loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for HTTP redirects - JavaScript-initiated ones are effective immediately.

WebKitTools:

DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank one after finishing with a test to avoid having its delayed onload handler fired when starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog), but it helps somewhat.

1:39 AM WebKit Team edited by Simon Hausmann

(diff)

1:24 AM QtWebKit edited by lars@webkit.org

(diff)

1:21 AM WebKit Team edited by staikos@webkit.org

Remove irc handle (diff)

1:20 AM Changeset in webkit [27985] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

apply matrix transforms on the correct side of the transformation matrix (not on the side where the vector is multiplied).

Test: fast/transforms/matrix-02.html

rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Alexey Proskuryakov.

test the matrix transforms are applied on the correct side

fast/transforms/matrix-02.html: Added.
platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
platform/mac/fast/transforms/matrix-02-expected.png: Added.
platform/mac/fast/transforms/matrix-02-expected.txt: Added.

12:29 AM Changeset in webkit [27984] by ap@webkit.org

7 edits
7 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16077
<rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
browser implementations

Test: fast/xsl/sort-unicode.xml

xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Set a custom sort function.

xml/XSLTUnicodeSort.cpp: Added. (init_xsltTransformError): (xsltTransformError): (WebCore::xsltUnicodeSortFunction):
xml/XSLTUnicodeSort.h: Added. ICU-based implementation of xsl:sort, using an example from libxslt distribution. Only minimal coding style fixes to ease synchronization with upstream in the future.

icu/unicode/ucol.h: Added.
icu/unicode/uset.h: Added. Taken from ICU 3.2

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added XSLTUnicodeSort.cpp.

Nov 22, 2007:

10:43 PM Changeset in webkit [27983] by ap@webkit.org

3 edits in trunk/WebCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14977
Hixie's DOM Core performance test shows insert >10x slower than append

Each invocation of Element.childNodes[n] was creating and registering a new ChildNodeList,
which persisted and listened to notifications until GC.

A fix is to avoid registering child node lists for notifications - they don't need them, as
they share a common cache in Node.

dom/Node.cpp: (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged):
dom/NodeList.h: (WebCore::NodeList::needsNotifications):

10:04 PM Changeset in webkit [27982] by mitz@apple.com

14 edits in trunk

WebCore:

Reviewed by Antti Koivisto.

fix http://bugs.webkit.org/show_bug.cgi?id=15811 WebKit plug-ins can re-enter WebKit under attach() <rdar://problem/5577978>

Defer plug-in loading until after attach and recalcStyle using the
post-attach callback mechanism. Netscape plug-ins are still loaded only
after layout.

dom/ContainerNode.cpp: Made NodeCallbackQueue elements retain the Node because callbacks might delete nodes that are in the callback queue. (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to prevent post-attach callbacks from being dispatched under recalcStyle(). (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto. (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from attach(). (WebCore::ContainerNode::attach):
dom/ContainerNode.h:
dom/Document.cpp: (WebCore::Document::recalcStyle): Added calls to suspendPostAttachCallbacks() and resumePostAttachCallbacks().
html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the post-attach callback.
html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to prevent a double update if another plug-in's post-attach updateWidget() triggers a layout which updates the widget before this plug-in's post-attach callback is invoked. (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLObjectElement::updateWidget): Added. Called by the post-attach callback.
html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::updateWidget):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Added calls to setNeedWidgetUpdate(false) so that if this method is called from FrameView::layout() during post-attach dispatch of another plug-in, it will not be called again when this plug-in's post-attach callback is dispatched.
rendering/RenderPartObject.h: (WebCore::RenderPartObject::updateWidget) Renamed argument to match the method definition.

WebKit/mac:

Reviewed by Antti Koivisto.

http://bugs.webkit.org/show_bug.cgi?id=15811 WebKit plug-ins can re-enter WebKit under attach() <rdar://problem/5577978>

Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the above bug that added as part of fixing <http://bugs.webkit.org/show_bug.cgi?id=15804>.

8:45 PM Changeset in webkit [27981] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

Fix the Element.hasStyleClass and Element.removeStyleClass helpers
to not find and replace substrings, but whole class names at the
beginning or end of the string or surrounded by whitespace.

page/inspector/utilities.js:

8:23 PM Changeset in webkit [27980] by timothy@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix typo.

8:20 PM Changeset in webkit [27979] by timothy@apple.com

3 edits in trunk/WebCore

Revert part of my r27935 change that made the Tip balloons
animate with CSS transitions. The balloon was only opacity 0,
so it would cause it's row to highlight when hovering over
another row.

page/inspector/NetworkPanel.js:
page/inspector/inspector.css:

8:11 PM Changeset in webkit [27978] by mitz@apple.com

6 edits
4 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

fix http://bugs.webkit.org/show_bug.cgi?id=15943 -webkit-transform matrix does not work

Test: fast/transforms/matrix-01.html

Parse all six matrix entries as numbers.

css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/RenderStyle.cpp: (WebCore::MatrixTransformOperation::blend):
rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Maciej Stachowiak.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=15943 -webkit-transform matrix does not work

fast/transforms/matrix-01.html: Added.
platform/mac/fast/transforms/matrix-01-expected.checksum: Added.
platform/mac/fast/transforms/matrix-01-expected.png: Added.
platform/mac/fast/transforms/matrix-01-expected.txt: Added.

6:53 PM Changeset in webkit [27977] by alp@webkit.org

12 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <alp@atoker.com>

Whitespace fixes only.

Api/webkitgtkframe.cpp:
Api/webkitgtkpage.cpp:
Api/webkitgtkpage.h:
Api/webkitgtkprivate.h:
WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/ContextMenuClientGtk.cpp:
WebCoreSupport/ContextMenuClientGtk.h:
WebCoreSupport/DragClientGtk.h:
WebCoreSupport/EditorClientGtk.h:
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::createJavaAppletWidget): (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::setMainFrameDocumentReady): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::frameLoadCompleted): (WebKit::FrameLoaderClient::saveViewStateToItem): (WebKit::FrameLoaderClient::restoreViewState): (WebKit::FrameLoaderClient::shouldGoToHistoryItem): (WebKit::FrameLoaderClient::setTitle):
WebCoreSupport/FrameLoaderClientGtk.h:

5:52 PM Changeset in webkit [27976] by alp@webkit.org

9 edits in trunk/WebKit/gtk

2007-11-22 Michael Natterer <mitch@imendio.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15984
Implement "navigation-requested" signal for WebKit Gtk

Api/webkitgtknetworkrequest.h: fix parent class member.

Api/webkitgtknetworkrequest.cpp
Api/webkitgtkprivate.h: basic implementation featuring an "url" member and API.

Api/webkitgtkdefines.h: added network request typedefs.

Api/webkitgtkpage.h: fix enum name: s/WEBKIT_NAVIGATION_REQUEST_RESPONSE/WebKitNavigationRequestResponse/ and sanitized enum values.

Api/webkitgtkpage.cpp: made "navigation-requested" a signal.

Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT

WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in dispatchDecidePolicyForNavigationAction().

5:48 PM Changeset in webkit [27975] by mrowe@apple.com

2 edits in trunk/WebKitTools

2007-11-22 Mark Rowe <mrowe@apple.com>

Reviewed by Alp Toker.

Fix build-webkit to propagate make's exit status if it fails.

Scripts/webkitdirs.pm:

5:03 PM Changeset in webkit [27974] by alp@webkit.org

2 edits in trunk

2007-11-22 Alp Toker <alp@atoker.com>

GTK+ build fix. Pass a correct LIBDIR value.

WebKit.pri:

4:04 PM Changeset in webkit [27973] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-22 Laszlo Gombos <laszlo.gombos@gmail.com>

Reviewed by Alp Toker.

Fix some compilation warnings. Do not reference undefined (platform) specific type (WebCore::CachedFont::m_fontData)

loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::allReferencesRemoved):

1:02 PM Changeset in webkit [27972] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-22 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fix.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkEventExpose. This was noticed when adding
printing support but might be triggered in other situations too.

platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):

9:36 AM Changeset in webkit [27971] by mitz@apple.com

2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

fix crash when running pixel tests

DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Parse the command line options before setting up the environment so that we know if we need to set up the pixel dump machinery.

9:02 AM QtWebKitContrib edited by treat@kde.org

(diff)

5:04 AM QtWebKitTodo edited by treat@kde.org

(diff)

5:03 AM QtWebKit edited by treat@kde.org

(diff)

3:35 AM WikiStart edited by treat@kde.org

Reorganize a bit and add page for Git (diff)

3:30 AM UsingGitWithWebKit edited by treat@kde.org

Tips and tricks (diff)

3:03 AM Changeset in webkit [27970] by ap@webkit.org

3 edits
2 adds in trunk

2007-11-22 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Alexey.

Bug 15530: XMLHttpRequest should not support certain methods

Test: http/tests/xmlhttprequest/xmlhttprequest-forbidden-methods-exception.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):

2:55 AM Changeset in webkit [27969] by mrowe@apple.com

1 edit in trunk/WebCore/ChangeLog

Remove WARNING notes from change logs that committers neglected to remove when landing.

2:42 AM WebKit Team edited by mjs@apple.com

(diff)

2:37 AM WebKit Team edited by mjs@apple.com

(diff)

2:24 AM WebKit Team edited by mjs@apple.com

(diff)

2:20 AM WebKit Team edited by mrowe@apple.com

(diff)

2:18 AM WebKit Team edited by alp@atoker.com

Update (diff)

2:16 AM Changeset in webkit [27968] by Simon Hausmann

1 edit in trunk/WebKit/qt/ChangeLog

Fix changelog

2:13 AM Changeset in webkit [27967] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fix compilation (don't define notImplemented twice)

2:12 AM Changeset in webkit [27966] by Simon Hausmann

4 edits in trunk

Use Q_SIGNALS/Q_SLOTS in the public API

2:12 AM Changeset in webkit [27965] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fixed the signature of the QWebPage constructor to follow Qt guidelines.

2:12 AM Changeset in webkit [27964] by Simon Hausmann

11 edits in trunk/WebKit/qt

Use <QtModule/headerfile.h> instead of <Classname> in public HEADER files, to not require the include paths for the other modules to be present

2:11 AM Changeset in webkit [27963] by Simon Hausmann

2 edits in trunk/WebKit/qt

Removed inline copy of QExplicitlySharedDataPointer. This is not needed anymore since we require Qt >= 4.3.0.

2:11 AM Changeset in webkit [27962] by Simon Hausmann

2 edits in trunk/WebCore

For the build inside Qt include qbase.pri and don't duplicate what qbase.pri otherwise does (install targets, etc.)

2:11 AM Changeset in webkit [27961] by Simon Hausmann

2 edits in trunk/WebCore

Don't set OBJECTS_DIR when building inside Qt

2:10 AM Changeset in webkit [27960] by Simon Hausmann

2 edits in trunk/WebCore

Use ../generated as path for the generated sources for builds inside Qt

2:10 AM Changeset in webkit [27959] by Simon Hausmann

5 edits in trunk

Make the directory of where to put the generated sources configurable through the GENERATED_SOURCE_DIR variable

2:10 AM Changeset in webkit [27958] by Simon Hausmann

5 edits in trunk

Centralize the setup for all the extra compilers in a addExtraCompiler function.

This allows adding a "generated_files" target that builds all generated files
using "make generated_files". For the build inside Qt we do not generate
actual rules for the extra compilers but instead do the variable substitution
of compiler.output manually and add the generated sources to SOURCES.

2:06 AM UsingGitWithWebKit created by treat@kde.org

Start new page for collecting info for using git with webkit

2:03 AM QtWebKitContrib edited by treat@kde.org

Add a link for new page describing tips and tricks for using git with … (diff)

1:58 AM WikiStart edited by treat@kde.org

(diff)

1:40 AM WebKit Team edited by alp@atoker.com

Fix own entry (diff)

1:21 AM QtWebKit edited by treat@kde.org

(diff)

1:19 AM QtWebKitContrib edited by treat@kde.org

More information for new contributors (diff)

1:12 AM Open Source Contributors edited by treat@kde.org

(diff)

1:11 AM WikiStart edited by treat@kde.org

Don't need this anymore as we can add people to the Team page. (diff)

1:10 AM WebKit Team edited by treat@kde.org

Add lots more contributors and add review/commit info. (diff)

1:08 AM Changeset in webkit [27957] by Simon Hausmann

5 edits in trunk/WebKit/qt

Fix license headers

Signed-off-by: Simon Hausmann <hausmann@kde.org>

12:50 AM Changeset in webkit [27956] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fix shadowing of "page" variable that is passed as argument as well as a member variable.

This also fixes compilation with gcc 4.3.

Signed-off-by: George Staikos <staikos@kde.org>

Nov 21, 2007:

11:06 PM Changeset in webkit [27955] by eric@webkit.org

2 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <eric@webkit.org>

Speculative build fix for Tiger.

DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h

10:48 PM Changeset in webkit [27954] by mrowe@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Update changelog entry to match reality.

9:54 PM Changeset in webkit [27953] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Eric Seidel.

Show Fonts as Yellow in the network timeline.

page/inspector/NetworkPanel.js:
page/inspector/inspector.css:

9:23 PM Changeset in webkit [27952] by mitz@apple.com

6 edits
4 adds in trunk

WebCore:

Reviewed by Eric Seidel.

fix <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)

Test: fast/repaint/subtree-root-skipped.html

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Initialize the layout root to 0. (WebCore::FrameView::layoutRoot): Changed to return a RenderObject instead of a Node. (WebCore::FrameView::layout): Changed for layout root being a renderer rather than a DOM node. Also replaced clearing the repaint rects set with asserting that it is empty if this is the top-level call to layout(). If it is not, the set may contain rects from enclosing layout() and those should not be removed. (WebCore::FrameView::scheduleRelayout): Changed for layout root being a renderer rather than a DOM node. (WebCore::isObjectAncestorContainerOf): Added this helper function that tests whether one object will be marked by calling markContainingBlocksForLayout() on the other. (WebCore::FrameView::scheduleRelayoutOfSubtree): Changed for layout root being a renderer rather than a DOM node. Changed the check if new and current layout roots are on the same path from the root to use the subgraph of the render tree defined by container()hood instead of the DOM tree and parenthood.
page/FrameView.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Changed for layout root being a renderer rather than a DOM node.
rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Added an assertion that the object being deleted is not currently the layout root. (WebCore::RenderObject::scheduleRelayout): Changed for layout root being a renderer rather than a DOM node.

LayoutTests:

Reviewed by Eric Seidel.

repaint test for <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)

fast/repaint/subtree-root-skipped.html: Added.
platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.checksum: Added.
platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
platform/mac/fast/repaint/subtree-root-skipped-expected.txt: Added.

8:32 PM Changeset in webkit [27951] by mrowe@apple.com

15 edits in trunk

Fix JavaScriptGlue, WebCore and WebKit to build without warnings using GCC 4.2.

Reviewed by Eric.

8:13 PM Changeset in webkit [27950] by mrowe@apple.com

2 edits in trunk/WebKitSite

2007-11-21 Mark Rowe <mrowe@apple.com>

Reviewed by Eric.

Update coding style to cover control statements with no body.

coding/coding-style.html:

8:03 PM Changeset in webkit [27949] by eric@webkit.org

8 edits
4 copies
2 adds in trunk/WebKitTools

2007-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Tim Hatcher.

Break out more of DumpRenderTree.mm into individual files

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/CheckedMalloc.cpp: Added. (checkedMalloc): (checkedRealloc): (makeLargeMallocFailSilently):
DumpRenderTree/mac/CheckedMalloc.h: Added.
DumpRenderTree/mac/DumpRenderTree.mm: (crashHandler): (dump):
DumpRenderTree/mac/DumpRenderTreeMac.h:
DumpRenderTree/mac/DumpRenderTreePasteboard.h:
DumpRenderTree/mac/DumpRenderTreePasteboard.m:
DumpRenderTree/mac/DumpRenderTreeWindow.h:
DumpRenderTree/mac/DumpRenderTreeWindow.mm:
DumpRenderTree/mac/JavaScriptThreading.cpp: Added. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads):
DumpRenderTree/mac/JavaScriptThreading.h: Added.
DumpRenderTree/mac/PixelDumpSupport.h: Added.
DumpRenderTree/mac/PixelDumpSupport.mm: Added. (restoreColorSpace): (setDefaultColorProfileToRGB): (initializeColorSpaceAndScreeBufferForPixelTests): (md5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):

7:28 PM Changeset in webkit [27948] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-21 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16071
Curl backend handles EINTR incorrectly

Defer timers during select() to avoid interruption by timer signals.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback):

7:08 PM Changeset in webkit [27947] by mrowe@apple.com

13 edits in trunk

Fix <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings.

Reviewed by Tim Hatcher.

Fix all warnings emitted by GCC 4.2 when building JavaScriptCore. This allows builds with
-Werror to succeed. At present they will crash when executed due to code that is not safe
under strict aliasing (<rdar://problem/5536806>).

This required some format strings to be modified in WebCore and WebKit as their format
specifiers did not match the argument type.

7:01 PM Changeset in webkit [27946] by kevino@webkit.org

2 edits
1 move in trunk/WebKitTools

Restore the wx buildbot for Mac by automatically installing dependencies not provided by the OS into WebKitLibraries.

Reviewed by Mark Rowe

6:19 PM Changeset in webkit [27945] by eric@webkit.org

4 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam.

More refactoring for greater code readability

DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (initializeColorSpaceAndScreeBufferForPixelTests): (addTestPluginsToPluginSearchPath): (useLongRunningServerMode): (runTestingServerLoop): (prepareConsistentTestingEnvironment): (dumpRenderTree): (main): (dumpFramesAsText): (dumpBackForwardListForWebView): (sizeWebViewForCurrentTest): (methodNameStringForFailedTest): (dumpBackForwardListForAllWindows): (dumpWebViewAsPixelsAndCompareWithExpected): (invalidateAnyPreviousWaitToDumpWatchdog): (dump):
DumpRenderTree/mac/DumpRenderTreeMac.h:
DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:createWebViewWithRequest:]):

4:24 PM Changeset in webkit [27944] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-21 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

Clarify scroll event processing with a comment.

platform/gtk/PlatformScrollBarGtk.cpp: (gtkScrollEventCallback):

3:40 PM Changeset in webkit [27943] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16085: Web Inspector's Network Timeline graph code clean up and misc. fixes
http://bugs.webkit.org/show_bug.cgi?id=16085

Changes include:

Refactor the drawing code as nested functions instead of global functions.
Compute the segment percentages only once per call to drawSummaryGraph.
Account for percentages that rounded down to total less-than 100%.
Draw the pill shadow better using the canvas shadow drawing properties.
Removes a couple canvas context saves and restores.

page/inspector/NetworkPanel.js:

11:29 AM Changeset in webkit [27942] by eric@webkit.org

2 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Tim Hatcher.

Abstract more of DRT into static methods

DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (setupSignalHandlers): (allocateGlobalControllers): (releaseAndZero): (releaseGlobalControllers): (dumpRenderTree): (shouldLogFrameLoadDelegates): (createCFURLFromPathOrURL): (resetWebViewToConsistentStateBeforeTesting): (runTest):

11:28 AM Changeset in webkit [27941] by eric@webkit.org

4 edits
2 copies
2 adds in trunk/WebKitTools

2007-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Tim Hatcher.

Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): (dump): (runTest):
DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added. (+[DumpRenderTreePasteboard _pasteboardWithName:]): (+[DumpRenderTreePasteboard releaseLocalPasteboards]): (-[DumpRenderTreePasteboard declareType:owner:]): (+[LocalPasteboard alloc]): (-[LocalPasteboard init]): (-[LocalPasteboard dealloc]): (-[LocalPasteboard name]): (-[LocalPasteboard releaseGlobally]): (-[LocalPasteboard declareTypes:owner:]): (-[LocalPasteboard addTypes:owner:]): (-[LocalPasteboard changeCount]): (-[LocalPasteboard types]): (-[LocalPasteboard availableTypeFromArray:]): (-[LocalPasteboard setData:forType:]): (-[LocalPasteboard dataForType:]): (-[LocalPasteboard setPropertyList:forType:]): (-[LocalPasteboard setString:forType:]):
DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added. (+[DumpRenderTreeWindow allWindows]): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]): (-[DumpRenderTreeWindow isKeyWindow]): (-[DumpRenderTreeWindow keyDown:]):

10:48 AM BuildingGtk edited by alp@atoker.com

Add public API and GtkLauncher to the list of code modules (diff)

8:18 AM QtWebKitContrib edited by treat@kde.org

(diff)

8:15 AM BuildingQtOnWindows edited by treat@kde.org

(diff)

8:14 AM QtWebKitContrib edited by treat@kde.org

(diff)

8:13 AM BuildingQtOnLinux edited by treat@kde.org

(diff)

8:11 AM BuildingQtOnLinux edited by treat@kde.org

(diff)

8:08 AM QtWebKitContrib edited by treat@kde.org

(diff)

8:07 AM QtWebKitTodo edited by treat@kde.org

(diff)

8:07 AM QtWebKit edited by treat@kde.org

(diff)

8:06 AM QtWebKitContrib edited by treat@kde.org

(diff)

8:01 AM QtWebKitContrib created by treat@kde.org

7:16 AM QtWebKit edited by treat@kde.org

(diff)

5:02 AM Changeset in webkit [27940] by treat@webkit.org

3 edits in trunk/WebKit/qt

Connect up the signal for all subframes too.

4:20 AM Changeset in webkit [27939] by ap@webkit.org

2 edits in trunk/LayoutTests

Reviewed by Maciej.

<rdar://problem/5230233> dom/xhtml/level2/html/frame.xhtml is failing on Windows

This isn't actually a test, but an unused resource - we should re-work the W3C test rig to
support subresource loading from (X)HTML.
Anyway, it doesn't fail for me, I suppose this problem was fixed since the bug was filed.

platform/win/Skipped:

4:07 AM QtWebKitTodo edited by Simon Hausmann

(diff)

3:54 AM Changeset in webkit [27938] by ap@webkit.org

3 edits in trunk/LayoutTests

Reviewed by Maciej.

Fix a copy/paste error in the test (introduced in bug 12194).

http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
http/tests/xmlhttprequest/zero-length-response-sync.html:

2:01 AM WikiStart edited by Adam Roben

(diff)

12:10 AM Changeset in webkit [27937] by ap@webkit.org

11 edits in trunk/WebCore

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16056
Unicode not being interpreted correctly in Web Inspector source view

Cannot be tested automatically.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::encoding):
loader/CachedCSSStyleSheet.h:
loader/CachedResource.h: (WebCore::CachedResource::encoding):
loader/CachedScript.cpp: (WebCore::CachedScript::encoding):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::encoding):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::encoding):
loader/CachedXSLStyleSheet.h: Teach textual CachedResources to report their encodings.

page/InspectorController.cpp: (WebCore::addSourceToFrame): (WebCore::updateResourceResponse): Use the actual encoding - the network layer has little idea about it.

Nov 20, 2007:

11:29 PM Changeset in webkit [27936] by mrowe@apple.com

3 edits in trunk/WebCore

Fix <rdar://problem/5609579> (DOMParser().parseFromString() freezes Safari when parsing large nodes with XML entities)
http://bugs.webkit.org/show_bug.cgi?id=16076

Reviewed by Maciej Stachowiak.

XMLTokenizer was calling CharacterData::appendData twice per entity in the fragment of XML being
parsed (once for text before the entity, once for the entity itself). This triggered O(n^{2) copying

of the CharacterData's string due to resizing. We now prevent this happening by buffering all the

content for a given Text node in the XMLTokenizer before sending it out to the node in a single go.}

10:55 PM Changeset in webkit [27935] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Mark Rowe.

Animate the status area and tip balloons in the Web Inspector
with CSS animations.

page/inspector/NetworkPanel.js:
page/inspector/inspector.css:
page/inspector/inspector.js:

5:14 PM Changeset in webkit [27934] by kevino@webkit.org

6 edits in trunk

wx build fix for Windows. Don't use WebCore/move-js-headers.sh as it indiscriminately copies any headers inside JavaScriptCore, which includes Tiger ICU headers.

2:11 PM Changeset in webkit [27933] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-20 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Avoid pointlessly mallocing and freeing this transform matrix.

platform/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):

1:46 PM Changeset in webkit [27932] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-20 Naiem Shaik <naiem.shaik@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15763
[GTK] Enter key does not take to the link highlighted.

Add missing keycode cases.

platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

1:36 PM Changeset in webkit [27931] by mrowe@apple.com

5 edits in trunk

Fix http://bugs.webkit.org/show_bug.cgi?id=16074
Bug 16074: execCommand("InsertHorizontalRule", false, "") results in id="" being inserted

For consistency with InsertOrderedList and InsertUnorderedList a value parameter of "" should
not result in an id being set.

Reviewed by Sam Weinig.

10:01 AM Changeset in webkit [27930] by treat@webkit.org

3 edits in trunk/WebKitTools

Prepend git branch name to $baseProductDir

9:38 AM Changeset in webkit [27929] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Adam Roben.

fix <rdar://problem/5090708> Textareas render broken-looking scrollbars when too short to show full scrollbar

platform/win/PlatformScrollBar.h:
platform/win/PlatformScrollBarSafari.cpp: Added the "hit inset" constants (representing how far the track eats into the button). (WebCore::PlatformScrollbar::paint): Changed to paint the buttons and the thumb only if they should be showing. (WebCore::PlatformScrollbar::hasButtons): Added. Returns whether the arrows should be drawn. (WebCore::PlatformScrollbar::hasThumb): Added. Returns whether the thumb should be drawn. (WebCore::PlatformScrollbar::forwardButtonRect): (WebCore::PlatformScrollbar::trackRect): Changed to return the entire bounds of the scrollbar if the scrollbar has no buttons. (WebCore::PlatformScrollbar::paintTrack): Changed to paint a disabled track along the entire scrollbar if it has not buttons. (WebCore::PlatformScrollbar::hitTest): Changed to hit test only the parts that the scrollbar has in its current dimensions.

8:06 AM Changeset in webkit [27928] by mrowe@apple.com

4 edits in trunk

2007-11-20 Mark Rowe <mrowe@apple.com>

Reviewed by Alp Toker.

WebKit.pri: Add in -Wno-unused-parameter to silence warnings in WebCore.

2007-11-20 Mark Rowe <mrowe@apple.com>

Reviewed by Alp Toker.

config.h: Change #if to #ifdef to silence warnings on non-Apple platforms.

7:53 AM Changeset in webkit [27927] by mrowe@apple.com

3 edits in trunk/WebKitTools

2007-11-20 Mark Rowe <mrowe@apple.com>

Reviewed by Simon Hausmann.

Scripts/build-webkit: Pass "clean" flag down into buildQMakeProject.
Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit. Have it trigger a "make distclean" rather than "make clean" to ensure that the built product and generated Makefile's are removed.

7:35 AM Changeset in webkit [27926] by alp@webkit.org

2 edits in trunk

2007-11-20 Alp Toker <alp@atoker.com>

Reviewed by Simon Hausmann.

Clean up GTK+ port configuration.

Use similar compiler warning flags to the Mac build.

Add the qmake changes needed for DirectFB support.

WebKit.pri:

7:27 AM Changeset in webkit [27925] by Simon Hausmann

5 edits in trunk

Remove static linkage of QtWebKit against the ICO image format plugin.

Instead build the support for the ICO image format as a proper standalone qt image format plugin and install it.

Signed-off-by: Adam Treat <treat@kde.org>

6:52 AM Changeset in webkit [27924] by ddkilzer@apple.com

1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Fix typo.

6:48 AM Changeset in webkit [27923] by ddkilzer@apple.com

2 edits in trunk/WebCore

no-svg build broken after r27278
<http://bugs.webkit.org/show_bug.cgi?id=16061>

Reviewed by Eric.

bindings/scripts/CodeGeneratorObjC.pm: Always generate DOMHTMLEmbedElementPrivate.h and DOMHTMLObjectElementPrivate.h for no-svg build.

6:23 AM Changeset in webkit [27922] by Simon Hausmann

2 edits in trunk/WebKit/qt

Added a default argument to textContent for the hoveringOverLink signal to keep existing two-argument connections working

Signed-off-by: George Staikos <staikos@kde.org>

5:26 AM Changeset in webkit [27921] by treat@webkit.org

4 edits in trunk/WebCore

Don't use so much heap memory.

4:37 AM Changeset in webkit [27920] by treat@webkit.org

3 edits in trunk/WebCore

Make gif animations work for instance.

1:06 AM Changeset in webkit [27919] by Simon Hausmann

4 edits in trunk/WebKit/qt

Add an argument to pass the link text in the hovering signal

Signed-off-by: Simon Hausmann <hausmann@kde.org>

1:03 AM Changeset in webkit [27918] by Simon Hausmann

6 edits in trunk/LayoutTests

Adjust some test result after fixing a bug related to computation
of QFont::xHeight() in Qt.

1:02 AM Changeset in webkit [27917] by Simon Hausmann

5 edits in trunk

Fix text break interators.

The break iterators where trying to be smart about the input
string and caching their results. Unfortunately a pointer/string length
comparison is not good enough in all cases (since some input is stack based
temp strings). Removed the caching but at the same time started to use a more
efficient constructor of QTextBoundaryFinder that doesn't need to malloc for
most strings.

Fixes two test cases that test "text-transform: capitalize".

12:50 AM Changeset in webkit [27916] by treat@webkit.org

2 edits in trunk/WebCore

Build in release mode

12:29 AM Changeset in webkit [27915] by treat@webkit.org

4 edits in trunk

Be quiet and allow suppression of NotImplemented calls at runtime.

Nov 19, 2007:

6:39 PM Changeset in webkit [27914] by alp@webkit.org

3 edits in trunk/WebCore

2007-11-19 Doug Turner <dougt@meer.net>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16054
Crash when GlyphPage::fill is called with more than 256 bytes of data

http://bugs.webkit.org/show_bug.cgi?id=14446
[GDK] Crash on http://www.wikipedia.org/

setGlyphDataForIndex() uses a fixed array of size 256 which we can't
exceed. We need to return failure if the buffer has Unicode
supplementary characters for now.

This strategy matches the Win port, which also doesn't support this
case yet.

Add an assertion so nobody makes this mistake again.

platform/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForIndex):
platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):

4:24 PM Changeset in webkit [27913] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

wx port build fix (wx headers include ctype functions).

2:53 PM Changeset in webkit [27912] by Antti Koivisto

5 edits in trunk/LayoutTests

Rubber-stamped by bdash.

Improve coverage of these tests.

media/video-muted-expected.txt:
media/video-muted.html:
media/video-volume-expected.txt:
media/video-volume.html:

11:39 AM BuildingGtk edited by alp@atoker.com

Note the targets supported by the GTK+ port (diff)

11:00 AM Changeset in webkit [27911] by kevino@webkit.org

1 edit
2 deletes in trunk/JavaScriptCore

Remove outdated and unused Windows port files.

Reviewed by Adam Roben.

10:01 AM Changeset in webkit [27910] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-19 Doug Turner <dougt@meer.net>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=16050
sqlite3_prepare16_v2 build bustage.

Using the correct SQLITE_VERSION_NUMBER around sqlite_prepare16_v2
to fix build bustage.

platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):

9:56 AM Changeset in webkit [27909] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix. Don't over-qualify the constructor name.

storage/DatabaseDetails.h:

9:51 AM Changeset in webkit [27908] by beidson@apple.com

11 edits
1 add in trunk

WebCore:

Reviewed by Maciej

Stub out the WebCore parts of the WebKit API

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

storage/DatabaseDetails.h: Added. Simple container for vitals on a specific database (WebCore::DatabaseDetails::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::isValid): (WebCore::DatabaseDetails::name): (WebCore::DatabaseDetails::version): (WebCore::DatabaseDetails::displayName): (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):

storage/DatabaseTracker.cpp: Added various methods for API usage (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota):
storage/DatabaseTracker.h:

WebKit:

Reviewed by Maciej

WebKit.xcodeproj/project.pbxproj: Sorted!

WebKit/mac:

Reviewed by Maciej

Finished hooking up the WebKit API for database management.
Most of the API is actually implemented in WebCore and some of those methods might
only be stubs for now.

Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result (-[WebDatabaseManager databasesWithOrigin:]): Ditto (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto

Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): Call through to WebCore (-[WebSecurityOrigin quota]): Ditto (-[WebSecurityOrigin setQuota:]): Ditto (-[WebSecurityOrigin _core]): Get WebCore version of this object
Storage/WebSecurityOriginInternal.h:

9:28 AM Changeset in webkit [27907] by kevino@webkit.org

2 edits in trunk/WebCore

wx port build fix for !USE(WXGC).

7:59 AM Changeset in webkit [27906] by alp@webkit.org

2 edits
1 add
1 delete in trunk/WebKitTools

2007-11-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16040
[GTK] GtkLauncher should be written in C

Port GtkLauncher to plain C.

Use a more conventional GTK+ coding style.

Use a toolbar instead of menus.

Various signature fixes and cleanups.

Add a license header. Assume all previous modifications were copyright
assigned to Apple Inc. by default.

GtkLauncher/GtkLauncher.pro:
GtkLauncher/main.c: Added. (activate_url_entry_cb): (update_title): (link_hover_cb): (title_change_cb): (progress_change_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
GtkLauncher/main.cpp: Removed.

7:53 AM Changeset in webkit [27905] by alp@webkit.org

3 edits in trunk/WebCore

2007-11-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fixes.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkDrawable. This was noticed when adding printing
support but might be triggered in other situations too.

Do not render themes when painting is disabled. This is an
optimisation for cases where GraphicsContext is used to calculate page
dimensions etc. without actually rendering.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::gdkDrawable):
platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):

7:33 AM Changeset in webkit [27904] by treat@webkit.org

2 edits in trunk/WebKit/qt

Don't segfault when event pos is outside of the widget.

5:43 AM Changeset in webkit [27903] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-13 Rahul Abrol <ra5ul@comcast.net>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=15977
Resizing images preference now toggles default image state.

loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument): (WebCore::ImageDocument::createDocumentStructure): (WebCore::ImageDocument::imageChanged):

5:02 AM Changeset in webkit [27902] by mrowe@apple.com

6 edits in trunk/WebCore

Roll out r27896 as it caused lots of build breakages.

4:51 AM Changeset in webkit [27901] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix.

platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer):

4:47 AM Changeset in webkit [27900] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix.

platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove reference to SkBitmap type that doesn't belong.

4:37 AM Changeset in webkit [27899] by mrowe@apple.com

14 edits in trunk

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Build script fixes to ensure they do the right thing for the
wx port, and update build-wxwebkit to reflect the way the
build scripts now work.

Reviewed by Adam.

Scripts/build-testkjs:
Scripts/build-webkit:
Scripts/run-javascriptcore-tests:
Scripts/webkitdirs.pm:
wx/build-wxwebkit:

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Add pcre directory to JSCore includes, and update the wx port
to reflect the Shared -> RefCounted name change. Also, fix
WebFrame.cpp to re-enable code that should never have been
committed disabled.

Reviewed by Adam.

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Update wx port build sources with recent changes, update
wx FontPlatformData to be a class (MSVC7 gets confused
otherwise...) and implement its hash() method.

Reviewed by Adam.

WebCoreSources.bkl:
platform/wx/FontPlatformData.h: (WebCore::FontPlatformData::hash):

4:30 AM Changeset in webkit [27898] by mrowe@apple.com

8 edits
4 adds in trunk

2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they
are not available should raise an exception

Tests: http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html

http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html

bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):
xml/XMLHttpRequest.h:

2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they are not
available should raise an exception

http/tests/xmlhttprequest/xmlhttprequest-responseText-exception-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html: Added.
http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html: Added.
http/tests/xmlhttprequest/zero-length-response-expected.txt: Updated result
http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated result
http/tests/xmlhttprequest/zero-length-response-sync.html: Corrected URL & added exception handling to test case

4:22 AM Changeset in webkit [27897] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-19 Peter Kasting <zerodpx@gmail.com>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=15971
The GIF decoder should not fail decoding if the caller asks it to
decode again when no new data has arrived since the last call.

platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):

4:22 AM Changeset in webkit [27896] by mrowe@apple.com

6 edits in trunk/WebCore

2007-11-19 Peter Kasting <zerodpx@gmail.com>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):

Nov 18, 2007:

11:14 PM Changeset in webkit [27895] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Eric

Fix a crash hashing a default SecurityOriginData object

storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL StringImpls - don't try to hash those!

4:40 PM Changeset in webkit [27894] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run

3:04 PM Changeset in webkit [27893] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Sam Weinig.

Bug 16043: Remove InspectorController.log now that console.log works
http://bugs.webkit.org/show_bug.cgi?id=16043

Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.

page/InspectorController.cpp: Remove the log function. (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from InspectorController script class.
page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
page/inspector/Panel.js: Change InspectorController.log to console.log and early return.

3:01 PM Changeset in webkit [27892] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Brady.

Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors
http://bugs.webkit.org/show_bug.cgi?id=16041

page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql() and transaction(). Refactored some code for the success and error callbacks to use.

2:18 PM Changeset in webkit [27891] by eric@webkit.org

2 edits in trunk/WebKitTools

2007-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Anders.

Make run-javascriptcore-tests report failures on exit (to support git bisect)

Scripts/run-javascriptcore-tests:

9:54 AM Changeset in webkit [27890] by ap@webkit.org

3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Make run-webkit-tests work with Windows debug build.

DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT, as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically, and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).

9:15 AM Changeset in webkit [27889] by kevino@webkit.org

3 edits
5 adds in trunk/WebKitTools

Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.

Reviewed by Darin Adler.

7:44 AM QtWebKitTodo edited by treat@kde.org

Updates (diff)

3:31 AM Changeset in webkit [27888] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Correct script-prompt to return NULL when cancelled.

Small changes to avoid compiler warnings.

Api/webkitgtkpage.cpp:

1:49 AM Changeset in webkit [27887] by ap@webkit.org

1 edit in trunk/LayoutTests/fast/parser/html-whitespace.html

Restoring a binary svn:mime-type on the test.

1:46 AM Changeset in webkit [27886] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Maciej.

<rdar://problem/5546393> Whitespace handling doesn't match HTML5.

HTML5 definition is the same as MSIE's, with the exception that the latter strips null
characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.

Test: fast/parser/html-whitespace.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseTag): Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to check for whitespace almost everywhere.

1:09 AM Changeset in webkit [27885] by mrowe@apple.com

20 edits in trunk

Fix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)

Split Interpreter's initialization into two distinct steps: the creation of the global prototypes
and constructors, and storing them on the global object. This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.

Reviewed by Darin Adler.

Nov 17, 2007:

10:58 PM Changeset in webkit [27884] by timothy@apple.com

3 edits in trunk/WebKit

Attempt to fix port builds.
'

10:40 PM Changeset in webkit [27883] by timothy@apple.com

41 edits
2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Add support for localization to the Web Inspector. Clients need to
implement localizedStringsURL() to return the URL of the
InspectorLocalizedStrings.js that best matches the user's language.

English.lproj: Added.
English.lproj/InspectorLocalizedStrings.js: Added.
WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
page/InspectorClient.h: Add localizedStringsURL.
page/InspectorController.cpp: Add localizedStringsURL that calls the client. Also added a version exposed to JavaScript.
page/InspectorController.h: Add localizedStringsURL.
page/inspector/ConsolePanel.js: Call WebInspector.UIString for user visible strings.
page/inspector/DatabasePanel.js: Ditto.
page/inspector/DocumentPanel.js: Ditto.
page/inspector/ImagePanel.js: Ditto.
page/inspector/MetricsSidebarPane.js: Ditto.
page/inspector/NetworkPanel.js: Ditto.
page/inspector/Panel.js: Ditto.
page/inspector/PropertiesSidebarPane.js: Ditto.
page/inspector/Resource.js: Ditto.
page/inspector/ResourceCategory.js: Ditto.
page/inspector/SourcePanel.js: Ditto.
page/inspector/StylesSidebarPane.js: Ditto.
page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
page/inspector/inspector.html: Remove some user visible strings.
page/inspector/inspector.js: Added WebInspector.UIString and call WebInspector.UIString for user visible strings. Some code needed to be moved to WebInspector.loaded to use UIString after the localized strings get loaded.
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::createPage): Ditto. (WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub. (WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.

WebKit:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Update the localized strings and the file encoding of WebInspectorClient.mm.

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:
WebKit.xcodeproj/project.pbxproj:

WebKit/gtk:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::localizedStringsURL): Empty stub.
WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.

WebKit/mac:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.

WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL): Added. (WebInspectorClient::updateWindowTitle): Localized the window title. (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore. (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.

WebKit/qt:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.

WebKit/win:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

English.lproj/Localizable.strings: Updated.
WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL): Empty stub.
WebInspectorClient.h: Added localizedStringsURL.

WebKit/wx:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.

9:36 PM Changeset in webkit [27882] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Prevent testapi from reporting false leaks.

Clear out local variables pointing at JSObjectRefs to allow their values to be collected.

Reviewed by Sam Weinig.

9:36 PM Changeset in webkit [27881] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.

Reviewed by Sam Weinig.

5:14 PM Changeset in webkit [27880] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove IDL files from the WebCore.framework Resources.

3:14 PM Changeset in webkit [27879] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-17 Alp Toker <alp@atoker.com>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable

Use a plain UTF-8 string instead of a CFString.

Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.

API/minidom.c: (main):

12:49 PM Changeset in webkit [27878] by Adam Roben

7 edits
1 copy in trunk

Make it easy to run Safari in the debugger on Windows

WebKitSite:

Update Windows debugging instructions

Reviewed by Mark Rowe.

building/debug.html:

WebKitTools:

Make it easy to run Safari in the debugger on Windows

I've added a new script, debug-safari, which launches Safari in the
debugger. On OS X it just calls gdb-safari.

Reviewed by Mark Rowe.

FindSafari/FindSafari.cpp: (_tmain): Added a /debugger flag, which in combination with /printSafariLauncher will print a script that launches Safari in the debugger.
Scripts/debug-safari: Added.
Scripts/run-safari: Changed to call runSafari().
Scripts/run-webkit-nightly.cmd: Prepends the launcher script with vsvars32.bat, which will let us find VS/VC++ Express, and passes the first argument along to FindSafari.
Scripts/webkitdirs.pm: (sub runSafari): Added.

12:02 PM Changeset in webkit [27877] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam.

Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
String.vsprintf so it can be used later for the localization function.

This version only supports argument reordering, precision for floats, and these
format characters: d, f, s and @. Any unsupported format characters are logged
and substituted like strings.

page/inspector/utilities.js:

9:06 AM Changeset in webkit [27876] by sfalken@apple.com

1 copy in tags/Safari-525.1.1b

New tag.

8:53 AM Changeset in webkit [27875] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:39 AM Changeset in webkit [27874] by ap@webkit.org

4 edits in trunk

Windows build fix

WebKit:

WebView.cpp: (WebView::deleteSelection): Use canSmartCopyOrDelete() directly.

WebCore:

editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.

12:58 AM Changeset in webkit [27873] by ap@webkit.org

10 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()

No change in functionality.

WebCore:

editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().

editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::cut): (WebCore::Editor::performDelete):
editing/Editor.h: Moved relevant Editor::deleteRange() functionality to its callers. Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful in my opinion.

editing/mac/EditorMac.mm: (WebCore::initializeKillRingIfNeeded): (WebCore::Editor::addToKillRing): (WebCore::Editor::yank): (WebCore::Editor::yankAndSelect): (WebCore::Editor::setMark): (WebCore::unionDOMRanges): (WebCore::Editor::deleteToMark): (WebCore::Editor::selectToMark): (WebCore::Editor::swapWithMark): Pushed kill ring handling down from WebCore.

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm: Removed setMarkDOMRange (the corresponding getter is still needed).

WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent(). Export the new kill ring functions.

WebKit:

WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): (-[WebHTMLView setMark:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]): Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!

12:28 AM Changeset in webkit [27872] by ap@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.

Nov 16, 2007:

10:47 PM Changeset in webkit [27871] by ddkilzer@apple.com

2 edits in trunk/WebCore

2007-11-16 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Kilzer.

Build fix: the needed headers for POSIX file functions were not
included.

platform/posix/FileSystemPOSIX.cpp:

10:42 PM Changeset in webkit [27870] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

2007-11-16 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Kilzer.

The git config command was renamed to repo-config at some point. This
change tries git config and then git repo-config if the first fails.

Scripts/prepare-ChangeLog: (gitConfig):

9:10 PM Changeset in webkit [27869] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix the common case of <http://bugs.webkit.org/show_bug.cgi?id=15994> REGRESSION: Incomplete repaint of CSS image substitution

Test: fast/repaint/clip-with-layout-delta.html

rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Account for layout delta when pushing additional clip.

LayoutTests:

Reviewed by Darin Adler.

repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15994> REGRESSION: Incomplete repaint of CSS image substitution

fast/repaint/clip-with-layout-delta.html: Added.
platform/mac/fast/repaint/clip-with-layout-delta-expected.checksum: Added.
platform/mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
platform/mac/fast/repaint/clip-with-layout-delta-expected.txt: Added.

8:05 PM Changeset in webkit [27868] by andersca@apple.com

4 edits in trunk/WebKitLibraries

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

Add wkSetCFURLRequestShouldContentSniff.

win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

6:13 PM Changeset in webkit [27867] by Antti Koivisto

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

6:10 PM Changeset in webkit [27866] by Antti Koivisto

29 edits
8 adds in trunk

WebCore:

Reviewed by Adele.

Seeking related fixes, updates match to the latest specification

rename loopCount of HTMLMediaElement to playCount
add explicit seeking attribute to HTMLMediaElement to get semantics right
implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement instead of MoviePrivateQTKit
fix broken behavior when seeking past end of the media, add tests
replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make HTMLMediaElement not depend on synchronous callbacks
do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables

Tests: http/tests/media/video-seekable-stall.html

media/video-seeking.html
media/video-seek-past-end-paused.html
media/video-seek-past-end-playing.html

html/HTMLAttributeNames.in:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::playCount): (WebCore::HTMLMediaElement::setPlayCount): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updateMovie):
html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
platform/graphics/Movie.cpp: (WebCore::Movie::timeChanged):
platform/graphics/Movie.h: (WebCore::MovieClient::movieTimeChanged):
platform/graphics/mac/MoviePrivateQTKit.h:
platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::doSeek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::didEnd):

LayoutTests:

Reviewed by Adele.

Seeking related test updates

update to match specificiation
- rename loopCount to playCount everywhere
- timeupdate events during seek
fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
add text about what is being tested

Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.

http/tests/media/video-seekable-stall-expected.txt: Added.
http/tests/media/video-seekable-stall.html: Added.
media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/video-dom-loopcount-expected.txt:
media/video-dom-loopcount.html:
media/video-dom-loopend-expected.txt:
media/video-dom-loopend.html:
media/video-dom-loopstart-expected.txt:
media/video-dom-loopstart.html:
media/video-dom-start-expected.txt:
media/video-dom-start.html:
media/video-loopcount-expected.txt:
media/video-loopcount.html:
media/video-loopend-expected.txt:
media/video-loopend.html:
media/video-loopstart-expected.txt:
media/video-loopstart.html:
media/video-seek-past-end-paused-expected.txt: Added.
media/video-seek-past-end-paused.html: Added.
media/video-seek-past-end-playing-expected.txt: Added.
media/video-seek-past-end-playing.html: Added.
media/video-seeking-expected.txt: Added.
media/video-seeking.html: Added.
media/video-test.js:

5:32 PM Changeset in webkit [27865] by andersca@apple.com

5 edits in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Add new parameter which controls whether content sniffing should be turned off.

(WebCore::ResourceHandle::loadResourceSynchronously):
Always content sniff sync loads.

platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves any properties set on the CFURLRequest.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.

platform/win/Skipped:

5:25 PM Changeset in webkit [27864] by mitz@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog

5:24 PM Changeset in webkit [27863] by mitz@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Darin Adler and Sam Weinig.

fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): For characters that cannot be entered on the active keyboard layout, send a WM_CHAR message with the character along with a WM_KEYDOWN message with a virtual key code of 255.

LayoutTests:

Reviewed by Darin Adler and Sam Weinig.

remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/5134075>

platform/win/Skipped:

5:16 PM Changeset in webkit [27862] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

<rdar://problem/5605175> Crash closing or leaving window with ViewPoint
Media player plugin

ViewPoint plugin requires that we pass a valid NPSavedData* to
NPP_Destroy.

plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to NPP_Destroy. If the plugin allocates data, discard it

4:52 PM Changeset in webkit [27861] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

3:50 PM Changeset in webkit [27860] by mrowe@apple.com

10 edits in trunk

Build WebCore as a sub-framework of WebKit in all configurations.

2:43 PM Changeset in webkit [27859] by mrowe@apple.com

5 edits in trunk/JavaScriptCore

2007-11-16 Mark Rowe <mrowe@apple.com>

Reviewed by Eric.

Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
SunSpider claims this is a 0.7% speedup.

kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::lex): (KJS::Lexer::record8): (KJS::Lexer::record16): (KJS::Lexer::scanRegExp): (KJS::Lexer::clear): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
kjs/lexer.h:
kjs/ustring.cpp: (KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
kjs/ustring.h:

2:27 PM Changeset in webkit [27858] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-16 Doug Turner <dougt@meer.net>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0

Fix build bustage on GTK+ with older versions of Pango.

Don't cache the return value since the docs say it can change.

platform/gtk/Language.cpp: (WebCore::defaultLanguage):

2:26 PM BuildingGtk edited by dougt@meer.net

Note about using qmake-qt4 (diff)

1:55 PM Changeset in webkit [27857] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix

JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path and ignore the int -> bool conversion warning.

11:21 AM Changeset in webkit [27856] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Brady

WebKit.exp: Exported some new database-related symbols

11:06 AM Changeset in webkit [27855] by beidson@apple.com

2 edits in trunk/WebKit

WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!

10:59 AM Changeset in webkit [27854] by beidson@apple.com

2 edits in trunk/WebKit

WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so it is exported

9:34 AM Changeset in webkit [27853] by beidson@apple.com

5 edits
3 moves in trunk/WebKit

WebKit/mac:

Reviewed by John

Database management API tweaks

Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself

Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?

Misc/WebSecurityOrigin.mm: Removed.
Misc/WebSecurityOriginInternal.h: Removed.
Misc/WebSecurityOriginPrivate.h: Removed.

Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
Storage/WebDatabaseManagerPrivate.h:

Storage/WebSecurityOrigin.mm: Added. (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]): (-[WebSecurityOriginPrivate finalize]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
Storage/WebSecurityOriginInternal.h: Added.
Storage/WebSecurityOriginPrivate.h: Added.

WebKit:

Reviewed by John

Database management API tweaks

WebKit.xcodeproj/project.pbxproj:

9:25 AM Changeset in webkit [27852] by beidson@apple.com

2 edits in trunk/WebCore

Build fix

platform/SecurityOriginData.h: (WebCore::operator!=): Whoops!

9:13 AM Changeset in webkit [27851] by beidson@apple.com

8 edits
1 copy in trunk/WebCore

Reviewed by Sam

Further purify DatabaseTracker to use SecurityOriginData instead of "a String"

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
WebCore.vcproj/WebCore.vcproj
WebCore.pro

platform/SecurityOriginData.cpp: Added. (WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string, since that form is what will be stored in the Databases.db on disk (WebCore::SecurityOriginData::stringIdentifier):
platform/SecurityOriginData.h: (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port):

storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for a SecurityOriginData object (WebCore::SecurityOriginDataHash::equal): (WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation (WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::addDatabase):
storage/DatabaseTracker.h:

8:30 AM BuildingGtk edited by zecke2@selfish.org

(diff)

4:22 AM Changeset in webkit [27850] by Nikolas Zimmermann

980 edits in trunk/LayoutTests

Rubberstamped by Eric.

Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.

4:20 AM Changeset in webkit [27849] by ap@webkit.org

2 edits in trunk/WebCore

Windows build fix.

WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.

3:20 AM Changeset in webkit [27848] by Nikolas Zimmermann

11 edits
4 adds in trunk

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290

Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.

Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)

2:49 AM Changeset in webkit [27847] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Fix Windows debug build.
Rubber-stamped by Eric

pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC complain about unreachable code.

Nov 15, 2007:

11:47 PM Changeset in webkit [27846] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

kjs/Parser.cpp:

11:44 PM Changeset in webkit [27845] by mrowe@apple.com

4 edits in trunk/JavaScriptCore

Mac build and header search path sanity fix.

Reviewed by Sam Weinig and Tim Hatcher.

Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.

Configurations/Base.xcconfig:
Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:

11:08 PM Changeset in webkit [27844] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Qt build fix.

kjs/Parser.h:

11:00 PM Changeset in webkit [27843] by adele@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

Test: fast/forms/menulist-no-renderer-onmousedown.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
fast/forms/menulist-no-renderer-onmousedown.html: Added.

10:54 PM Changeset in webkit [27842] by ggaren@apple.com

16 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Another round of grammar / parsing cleanup.

Created distinct parser calls for parsing function bodies vs programs. This will help later with optimizing global variable access.

Turned Parser into a singleton. Cleaned up Lexer's singleton interface.

Modified Lexer to free a little more memory when done lexing. (Added FIXMEs for similar issues that I didn't fix.)

Changed Lexer::makeIdentifier and Lexer::makeUString to start respecting the arguments passed to them. (No behavior change, but this problem could have caused serious problems for an unsuspecting user of these functions.)

Removed KJS_DEBUG_MEM because it was bit-rotted.

Removed Parser::prettyPrint because the same work was simpler to do at the call site.

Some renames:

"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"

JavaScriptCore.exp:
kjs/Parser.cpp: (KJS::Parser::Parser): (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse): (KJS::Parser::didFinishParsing): (KJS::parser):
kjs/Parser.h: (KJS::Parser::sourceId):
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
kjs/interpreter.h:
kjs/lexer.cpp: (kjsyylex): (KJS::lexer): (KJS::Lexer::Lexer): (KJS::Lexer::~Lexer): (KJS::Lexer::scanRegExp): (KJS::Lexer::doneParsing): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
kjs/lexer.h: (KJS::Lexer::pattern): (KJS::Lexer::flags): (KJS::Lexer::sawError):
kjs/nodes.cpp: (KJS::Node::Node): (KJS::FunctionBodyNode::FunctionBodyNode):
kjs/nodes.h:
kjs/testkjs.cpp: (prettyPrintScript): (kjsmain):
kjs/ustring.cpp:
kjs/ustring.h:

10:25 PM Changeset in webkit [27841] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Adele.

Fix <rdar://problem/5601598>
The movie tag should do initialization on need and not during startup.

Initialize Movie MIME type hash on demand

platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):

10:18 PM Changeset in webkit [27840] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Build fix for Qt on Windows.

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis):

10:15 PM Changeset in webkit [27839] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761

page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): Change the tear down order so that inspectorDestroyed() is called before InspectorController private data is set to Zero. The inspectorDestroyed() call ends up closing the WebView and triggering InspectorController::close() which unprotects m_scriptObject. This didn't happen when the private data was cleared before calling inspectorDestroyed().

10:10 PM Changeset in webkit [27838] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

WebCore.pro:

10:04 PM Changeset in webkit [27837] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions

Test: fast/xpath/union-context-node.xhtml

xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.

10:02 PM Changeset in webkit [27836] by ap@webkit.org

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org

Test by Hitoshi Amano <seijro@gmail.com>.

fast/xpath/xpath-functional-test-expected.txt: Added.
fast/xpath/xpath-functional-test.html: Added.

10:00 PM Changeset in webkit [27835] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements

Test: fast/xpath/preceding-axis.xhtml

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.

5:21 PM Changeset in webkit [27834] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Mark Rowe and Sam.

This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.

page/inspector/inspector.css:

5:04 PM Changeset in webkit [27833] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Sam.

Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
http://bugs.webkit.org/show_bug.cgi?id=16007

Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.

page/inspector/ResourceCategory.js:
page/inspector/treeoutline.js:

4:42 PM Changeset in webkit [27832] by andersca@apple.com

5 edits in trunk/WebCore

Reviewed by Brady.

Pass a VoidCallback to Database::transaction and Database::changeVersion.
This is not yet hooked up to the database machinery.

WebCore.vcproj/WebCore.vcproj:
bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
storage/Database.cpp: (WebCore::Database::changeVersion): (WebCore::Database::transaction):
storage/Database.h:

4:40 PM Changeset in webkit [27831] by oliver@apple.com

3 edits in trunk/JavaScriptCore

<rdar://problem/5601548> REGRESSION: All SourceElements and their children leak after a syntax error

Reviewed by Darin.

Add a stub node to maintain the Vector of SourceElements until assignment.

4:17 PM Changeset in webkit [27830] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Abstract most of RMATCH into MatchStack functions.

SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.

pcre/pcre_exec.cpp: (MatchStack::canUseStackBufferForNextFrame): (MatchStack::allocateNextFrame): (MatchStack::pushNewFrame): (MatchStack::frameIsStackAllocated): (MatchStack::popCurrentFrame): (MatchStack::unrollAnyHeapAllocatedFrames): (match):

4:16 PM Changeset in webkit [27829] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Remove RETURN_ERROR, add MatchStack

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::unrollAnyHeapAllocatedFrames): (matchError): (match):

4:14 PM Changeset in webkit [27828] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up match function to match WebKit style

JavaScriptCore.xcodeproj/project.pbxproj:
pcre/pcre_exec.cpp: (match):

4:07 PM Changeset in webkit [27827] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam.

Bug 16005: Hovering in the breadcrumbs causes jumpy behavior
http://bugs.webkit.org/show_bug.cgi?id=16005

Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
crumb will expose as many hidden crumbs as possible to the user. Also crumbs
that have ID attributes will compact to the ID over the tag name.

page/inspector/DocumentPanel.js:

3:53 PM Changeset in webkit [27826] by andersca@apple.com

5 edits
2 adds
1 delete in trunk/WebCore

Reviewed by Sam.

Make the VoidCallback DOM interface behave more like our other DOM interfaces.

bindings/js/JSCustomVoidCallback.h: Added.
bindings/js/JSCustomVoidCallback.cpp: Added. (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::handleEvent): VoidCallback implementation that wraps a JS object.

(WebCore::toVoidCallback):
New method that creates a VoidCallback implementation given a JS object.

bindings/scripts/CodeGeneratorJS.pm: Specify that VoidCallback can fail conversion and add a custom conversion function.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieCuePointReached): Call handleEvent on the callback.

(WebCore::HTMLMediaElement::removeCuePoint):
Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
on overriding VoidCallback equality.

html/VoidCallback.cpp: Removed.

html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback): (WebCore::VoidCallback::~VoidCallback): Make this an abstract class with a pure virtual handleEvent method.

3:42 PM Changeset in webkit [27825] by Adam Roben

2 edits in trunk/WebCore

Fix <rdar://5485108> Type-select while a <select> menu is open doesn't work

There were two things broken here:

WebView now requires a WM_CHAR message to be sent before it will create a keyboard event with a charCode, but we were only sending a WM_KEYDOWN event.
The popup menu was not updating its focused index when the <select> element's selectedIndex changed.

Reviewed by Adele.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::updateFromElement): Update the focused index from the client's selected index. (WebCore::PopupWndProc): When we receive a WM_CHAR message for a printable character, manufacture a WM_KEYDOWN message for it and post both that and the current WM_CHAR message to the WebView.

3:23 PM Changeset in webkit [27824] by beidson@apple.com

2 edits in trunk/WebCore

Build fix

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin):

2:54 PM Changeset in webkit [27823] by justin.garcia@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/events/5056619-expected.txt

Forgot this new expected result in my previous check-in.

2:29 PM Changeset in webkit [27822] by beidson@apple.com

1 edit in trunk/WebCore/ChangeLog

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

platform/SecurityOrigin.cpp:
platform/SecurityOrigin.h:
platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated

storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
storage/DatabaseTracker.h:

storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>

2:27 PM Changeset in webkit [27821] by beidson@apple.com

12 edits
5 copies
3 moves
3 adds in trunk

WebCore:

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

platform/SecurityOrigin.cpp:
platform/SecurityOrigin.h:
platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated

storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
storage/DatabaseTracker.h:

storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):

WebKit:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

These interfaces seem to provide everything we need for UI and management at the browser level

Misc/WebDatabaseManager.h: Removed.
Misc/WebDatabaseManager.mm: Removed.
Misc/WebDatabaseManagerPrivate.h: Removed.

Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple" (protocol, domain, and port) (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
Misc/WebSecurityOriginInternal.h: Added.
Misc/WebSecurityOriginPrivate.h: Added.

Storage/WebDatabaseManager.mm: Added. (+[WebDatabaseManager sharedWebDatabaseManager]): (-[WebDatabaseManager origins]): Get a list of all origins currently tracked (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota (-[WebDatabaseManager deleteAllDatabases]): (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
Storage/WebDatabaseManagerPrivate.h: Added.
Storage/WebDatabaseManagerInternal.h: Added. (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things

Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
Storage/WebDatabaseTrackerClient.mm: Added. (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient): (WebDatabaseTrackerClient::WebDatabaseTrackerClient): (WebDatabaseTrackerClient::~WebDatabaseTrackerClient): (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of Database-related things here

2:23 PM Changeset in webkit [27820] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

NP_ASFILEONLY streams should not buffer data in m_deliveryData.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):

2:02 PM Changeset in webkit [27819] by andersca@apple.com

1 edit in trunk/LayoutTests/fast/dom/Window/window-onFocus.html

Revert accidental change. andersca--

1:52 PM Changeset in webkit [27818] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

A textarea that contained the selection was removed but the selection wasn't cleared,
and we'd crash in code that assumed a valid, in-document selection.

editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the shadowAncestorNode of the node that contains the position, not just if the node being removed contains that shadowAncestorNode.

LayoutTests:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

editing/selection/5497643-expected.txt: Added.
editing/selection/5497643.html: Added.

1:35 PM Changeset in webkit [27817] by Adam Roben

2 edits in trunk/WebKitTools

Make run-safari actually work on Windows

Scripts/run-safari: Fixed the order of arguments to cp, and added a chdir call.

1:22 PM Changeset in webkit [27816] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.

12:27 PM Changeset in webkit [27815] by andersca@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

If the string is empty, pass a real empty string to sqlite3_bind_text16.

platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindText):

LayoutTests:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

storage/open-database-empty-version-expected.txt: Added.
storage/open-database-empty-version.html: Added.

12:00 PM Changeset in webkit [27814] by sfalken@apple.com

1 copy in tags/Safari-525.1b

New tag.

11:49 AM Changeset in webkit [27813] by andersca@apple.com

6 edits in trunk/WebCore

Reviewed by Brady.

Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase): (WebCore::IconDatabase::removePageURLFromSQLDatabase): (WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase): (WebCore::IconDatabase::addIconURLToSQLDatabase): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase): (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
platform/sql/SQLiteStatement.h:
storage/Database.cpp: (WebCore::setTextValueInDatabase):
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase):

10:39 AM Changeset in webkit [27812] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore.make:

12:01 AM Changeset in webkit [27811] by beidson@apple.com

2 edits in trunk/WebCore

WebCore:

Rubberstamped by Sam

platform/SecurityOrigin.h: Lets make this an unsigned short and *not* rule out half the possible ports?

Nov 14, 2007:

9:59 PM Changeset in webkit [27810] by ap@webkit.org

7 edits in trunk/JavaScriptCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15982
Improve JSString UTF-8 decoding

API/JSStringRef.cpp: (JSStringCreateWithUTF8CString): Use strict decoding, return 0 on error.

wtf/unicode/UTF8.cpp: (WTF::Unicode::convertUTF16ToUTF8): (WTF::Unicode::convertUTF8ToUTF16):
wtf/unicode/UTF8.h: Made these function names start with a lower case letter.

kjs/ustring.cpp: (KJS::UString::UTF8String): Updated for the above renaming.

bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): Renamed to highlight the difference from convertUTF8ToUTF16 in wtf/unicode. (KJS::Bindings::convertNPStringToUTF16): Updated for the above renaming. (KJS::Bindings::identifierFromNPIdentifier): Ditto.
bindings/c/c_utility.h: Made convertUTF8ToUTF16WithLatin1Fallback() a file static.

9:49 PM Changeset in webkit [27809] by ap@webkit.org

4 edits
4 adds in trunk

Reviewed by Justin Garcia.

http://bugs.webkit.org/show_bug.cgi?id=15781
REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle
a marked range that covers half of a composed character sequence)

Test: platform/mac/editing/input/devanagari-ligature.html

This fix is somewhat of a hack, as it asks editing commands to work with invalid selections.
However, this is not entirely new for them, as Roman accents are typed in a similar manner.

In the future, we probably want to make commands work with ranges (or Positions explicitly).

editing/Editor.cpp: (WebCore::Editor::selectComposition): Force selection to composition range.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Force ending selection to inserted text range.

9:17 PM Changeset in webkit [27808] by weinig@apple.com

2 edits in trunk/JavaScriptCore

Rubber-stamped by Anders.

Fix the Xcode project file after it was messed up in r27402.

JavaScriptCore.xcodeproj/project.pbxproj:

7:52 PM Applications using WebKit edited by info@erikjohansson.com

Added Coda to "Web Development Applications" (diff)

6:40 PM Changeset in webkit [27807] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

More PCRE style cleanup.

pcre/pcre_compile.cpp: (compile_regex):

6:02 PM Changeset in webkit [27806] by Adam Roben

2 edits in trunk/JavaScriptCore

Clean up the bison conflict checking script

Reviewed by Geoff.

DerivedSources.make:

6:00 PM Changeset in webkit [27805] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <eric@webkit.org>

Reviewed by Geoff.

Another round of PCRE cleanups: inlines

SunSpider claims that this, combined with my previous PCRE cleanup were a 0.7% speedup, go figure.

pcre/pcre_compile.cpp: (jsRegExpCompile):
pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h: (PUT): (GET): (PUT2): (GET2): (isNewline):

5:55 PM Changeset in webkit [27804] by beidson@apple.com

1 edit
1 add in trunk/WebKitSite

For future use

images/DroseraPic.png: Added.

5:34 PM Changeset in webkit [27803] by Adam Roben

3 edits in trunk/WebKitTools

Updates to Safari launching now that 3.0.4 is released

Reviewed by Sam.

FindSafari/FindSafari.cpp: (getWebViewCLSID): Use version-independent ProgID.
Scripts/run-safari: Use run-webkit-nightly.cmd.

5:17 PM Changeset in webkit [27802] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give PCRE a (small) bath.
Fix some formating and break things off into separate functions
http://bugs.webkit.org/show_bug.cgi?id=15993

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): (printCompiledRegExp): (returnError): (jsRegExpCompile):
pcre/pcre_internal.h: (compile_data::compile_data):

5:04 PM Changeset in webkit [27801] by Antti Koivisto

2 edits in trunk/LayoutTests

Try to make this test less timing dependent.

http/tests/media/video-play-stall.html:

3:48 PM Changeset in webkit [27800] by Beth Dakin

7 edits
5 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5540855> REGRESSION: Combination of client-
side image map and <a> tag is not working properly (15522)

html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Allow <map> to have both block and inline children rather than just block children. This matches Firefox.

LayoutTests:

Reviewed by Hyatt.

Tests for <rdar://problem/5540855> REGRESSION: Combination of
client-side image map and <a> tag is not working properly (15522)

New test:

fast/images/image-map-anchor-children.html: Added.
fast/images/resources/boston.gif: Added.
platform/mac/fast/images/image-map-anchor-children- expected.checksum: Added.
platform/mac/fast/images/image-map-anchor-children-expected.png: Added.
platform/mac/fast/images/image-map-anchor-children-expected.txt: Added.

This test was broken and is fixed now! I had to edit the test
itself because it was written in the html that the two <map>
examples were failing, but now they succeed.

fast/invalid/residual-style.html:
platform/mac/fast/invalid/residual-style-expected.checksum:
platform/mac/fast/invalid/residual-style-expected.png:
platform/mac/fast/invalid/residual-style-expected.txt:

2:59 PM Changeset in webkit [27799] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Cleaned up the JavaScript grammar a bit.

Changed BlockNode to always hold a child vector (which may be empty), eliminating a few NULL-check branches in the common execution case.

Changed the Block production to correctly report its starting and ending line numbers to the debugger. (It used to report its ending line as its starting line.) Also, removed duplicate line-reporting code inside the BlockNode constructor.

Moved curly braces up from FunctionBody production into parent productions. (I had to move the line number reporting code, too, since it depends on the location of the curly braces.) This matches the ECMA spec more closely, and makes some future changes I plan easier.

Fixed statementList* convenience functions to deal appropriately with empty Vectors.

SunSpider reports a small and statistically insignificant speedup.

kjs/grammar.y:
kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStack): (KJS::statementListInitializeVariableAccessStack): (KJS::BlockNode::BlockNode): (KJS::BlockNode::optimizeVariableAccess): (KJS::BlockNode::getDeclarations): (KJS::BlockNode::execute): (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::optimizeVariableAccess):

2:57 PM Changeset in webkit [27798] by Adam Roben

2 edits in trunk/WebKit/win

Change Interfaces to be a "Static Library" project

Being a Utility project meant that Interfaces was rebuilding every
time (Utility projects are supposed to handle their own dependencies).
Interfaces isn't really a static library, but it means that VS will
handle dependencies for us (and not complain about missing manifests
like it did when the project was an Application).

WebKit.vcproj/Interfaces.vcproj:

2:56 PM Changeset in webkit [27797] by Adam Roben

2 edits in trunk/WebKit/win

Shut up FixMIDLHeaders.pl

WebKit.vcproj/FixMIDLHeaders.pl:

2:33 PM Changeset in webkit [27796] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

<rdar://problem/5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Removed an irrelevant FIXME. (WebCore::DeleteSelectionCommand::mergeParagraphs): If the block that contained the end of the selection hasn't been removed but has been emptied by deletion, we would to try and fail to create a VisiblePosition inside that block, which could lead to a crash. If that happens, there's no content in the block to move, so just remove the block and return. Preserve m_needPlaceholder during the call to moveParagraphs, since it may change it and since it does its own placeholder insertion when necessary. (WebCore::DeleteSelectionCommand::doApply): No need to check m_needPlaceholder before calling mergeParagraphs, because it handles preserving m_needPlaceholder when it calls moveParagraphs.

LayoutTests:

Reviewed by Alexey Proskuryakov.

<rdar://problem/5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs

editing/deleting/5546763-expected.txt: Added.
editing/deleting/5546763.html: Added.

2:30 PM Changeset in webkit [27795] by andersca@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Adam.

<rdar://problem/5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.

DumpRenderTree/win/TestNetscapePlugin/main.c: (NPP_Destroy):

LayoutTests:

Reviewed by Adam.

<rdar://problem/5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.

Remove now succeeding test from the skipped list.

platform/win/Skipped:

2:09 PM Changeset in webkit [27794] by timothy@apple.com

2 edits in trunk/WebKitLibraries

Remove the WebKit dependancy from WebKitSystemInterface.

2:08 PM Changeset in webkit [27793] by Adam Roben

1 edit in trunk/WebKit/win/ChangeLog

Fix ChangeLog order

2:07 PM Changeset in webkit [27792] by Adam Roben

2 edits in trunk/WebKit/win

Change Interfaces to use a Utility configuration

It had previously been marked as an "Application (.exe)", which is
wrong but worked with most versions of Visual Studio.

Rubberstamped by Steve.

WebKit.vcproj/Interfaces.vcproj:

1:44 PM Changeset in webkit [27791] by Antti Koivisto

3 edits in trunk/LayoutTests

Try to make this test less timing dependent.

media/video-currentTime-set-expected.txt:
media/video-currentTime-set.html:

12:36 PM Changeset in webkit [27790] by eric@webkit.org

4 edits in trunk

2007-11-14 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

sunspider: add --shark-cache for L2 Cache Miss profiling

11:19 AM Changeset in webkit [27789] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Adam.

Bug 14380: Long DOM ancestry breadcrumb lists get cut off
http://bugs.webkit.org/show_bug.cgi?id=14380

The breadcumbs will now be compacted and collapsed if there isn't enough room
to show everything. The collapsing algorithm always affects the crumbs that
are farthest away from the selected or hovered crumb first.

page/inspector/DocumentPanel.js:
page/inspector/inspector.css:

11:10 AM Changeset in webkit [27788] by andersca@apple.com

6 edits in trunk

WebKit/win:

Reviewed by Adam.

Get the new focus window from the wParam instead of calling GetFocus().
Also, send blur even if there is no focused frame.

WebView.cpp: (WebViewWndProc):

WebKitTools:

Reviewed by Adam.

<rdar://problem/5141186>
window.layoutTestController.setWindowIsKey is not implemented in DRT.

Implement setWindowIsKey.

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setWindowIsKey):

LayoutTests:

Reviewed by Adam.

platform/win/Skipped: Remove fast/dom/Window/window-onFocus.html since it succeeds now.

10:53 AM Changeset in webkit [27787] by Adam Roben

2 edits in trunk/WebKit/win

Another build fix for systems without Cygwin in their PATH

WebKit.vcproj/Interfaces.vcproj: Add Cygwin to the PATH in the Post-Build Event.

10:36 AM Changeset in webkit [27786] by andersca@apple.com

4 edits in trunk/WebCore

Use the correct include path.

platform/Cursor.h:
plugins/win/PluginPackageWin.h:
plugins/win/PluginStreamWin.h:

10:11 AM Applications using WebKit edited by tristan@apple.com

(diff)

10:10 AM Applications using WebKit edited by tristan@apple.com

(diff)

8:33 AM BuildingGtk edited by zecke2@selfish.org

(diff)

8:32 AM BuildingGtk edited by zecke2@selfish.org

(diff)

Nov 13, 2007:

10:59 PM Changeset in webkit [27785] by mrowe@apple.com

2 edits in trunk/WebKit/gtk

2007-11-13 Mark Rowe <mrowe@apple.com>

Gtk build fix. Replace incorrect use of the LOG macro with g_print.

Api/webkitgtkpage.cpp:

10:46 PM Changeset in webkit [27784] by beidson@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed by Adam

http://bugs.webkit.org/show_bug.cgi?id=15976 - ASSERT/crash when SQLTransactionCallback throws an exception

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::deliverTransactionCallback): Make a transaction error for the case where the SQLTransactionCallback fails (WebCore::SQLTransaction::deliverTransactionErrorCallback): Don't assert on the error callback, but null check it and make the commit/rollback decision accordingly

LayoutTests:

Reviewed by Adam

Fix for http://bugs.webkit.org/show_bug.cgi?id=15976

storage: Added - There will soon be an entire suite in here!
storage/transaction_callback_exception_crash-expected.txt: Added.
storage/transaction_callback_exception_crash.html: Added.

10:25 PM Changeset in webkit [27783] by Adam Roben

2 edits in trunk/LayoutTests

Add the http/tests/media directory to the Windows Skipped file

platform/win/Skipped:

9:40 PM Changeset in webkit [27782] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-11-13 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Implement signals for script dialogs and console messages.

Api/webkitgtk-marshal.list:
Api/webkitgtkpage.cpp:
Api/webkitgtkpage.h:
WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::runJavaScriptPrompt):

7:48 PM Changeset in webkit [27781] by oliver@apple.com

4 edits in trunk/WebCore

Fix <rdar://problem/5365030> calling dataWithPDFInsideRect on an SVG with a gradient crashes (14780)

Reviewed by Anders.

When drawing directly to PDF CG may delay the use of the gradient function until outside our
standard drawing path, which in turn could let us invalidate the caches before they were used.

To work around this we now store the cached stops in a RefCounted object, so that we can ensure
that cache exists as long as required.

7:04 PM Changeset in webkit [27780] by ggaren@apple.com

6 edits in trunk/WebKit/qt

Build fix: changed Shared to RefCounted.

WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/ContextMenuClientQt.cpp:
WebCoreSupport/ContextMenuClientQt.h:
WebCoreSupport/EditorClientQt.h:
WebCoreSupport/FrameLoaderClientQt.h:

6:33 PM Changeset in webkit [27779] by andersca@apple.com

4 edits in trunk/WebCore

Fix Windows build.

platform/Cursor.h:
plugins/win/PluginPackageWin.h:
plugins/win/PluginStreamWin.h:

6:20 PM Changeset in webkit [27778] by andersca@apple.com

2 edits in trunk/JavaScriptCore

Add RefCounted.h (And remove Shared.h)

JavaScriptCore.vcproj/WTF/WTF.vcproj:

6:19 PM Changeset in webkit [27777] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix.

kjs/regexp.h:

6:05 PM Changeset in webkit [27776] by ggaren@apple.com

108 edits
4 moves in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

API/JSClassRef.h:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/interpreter.h:
kjs/regexp.h:
wtf/RefCounted.h: Copied from JavaScriptCore/wtf/Shared.h. (WTF::RefCounted::RefCounted):
wtf/Shared.h: Removed.

JavaScriptGlue:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/Shared.h.
ForwardingHeaders/wtf/Shared.h: Removed.

WebCore:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

ForwardingHeaders/wtf/RefCounted.h: Copied from WebCore/ForwardingHeaders/wtf/Shared.h.
ForwardingHeaders/wtf/Shared.h: Removed.
bindings/js/JSSVGPODTypeWrapper.h:
css/CSSFontFace.h:
css/CSSRuleList.h:
css/Counter.h:
css/Pair.h:
css/Rect.h:
css/StyleBase.h:
css/StyleSheetList.h:
dom/Attribute.h:
dom/Clipboard.h:
dom/DOMImplementation.h:
dom/Event.h:
dom/EventListener.h:
dom/NamedNodeMap.h:
dom/NodeFilter.h:
dom/NodeFilterCondition.h:
dom/NodeList.h:
dom/QualifiedName.h:
dom/Range.h:
dom/RangeException.h:
dom/RegisteredEventListener.h:
dom/Traversal.h:
editing/EditCommand.h:
history/BackForwardList.h:
history/CachedPage.h:
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
history/HistoryItem.h:
html/CanvasGradient.h:
html/CanvasPattern.h:
html/CanvasRenderingContext2D.h:
html/CanvasStyle.h:
html/HTMLCollection.h:
html/MediaError.h:
html/TimeRanges.h:
html/VoidCallback.h:
ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
ksvg2/css/SVGRenderStyle.h:
ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimatedTemplate.h:
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGException.h:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGPathSeg.h:
ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
ksvg2/svg/SVGPreserveAspectRatio.h:
ksvg2/svg/SVGRenderingIntent.h:
ksvg2/svg/SVGTransform.h:
ksvg2/svg/SVGUnitTypes.h:
loader/DocumentLoader.h:
loader/FormState.h:
loader/ResourceLoader.h:
loader/TextResourceDecoder.h:
loader/icon/IconRecord.h:
page/BarInfo.h:
page/Console.h:
page/DOMSelection.h:
page/DOMWindow.h:
page/Frame.h:
page/History.h:
page/InspectorController.cpp:
page/Plugin.h:
page/Screen.h:
platform/ArrayImpl.h:
platform/CString.h:
platform/Cursor.h:
platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private):
platform/FileChooser.h:
platform/FontFallbackList.h:
platform/FontFamily.cpp: (WebCore::FontFamily::FontFamily):
platform/FontFamily.h:
platform/FontSelector.h:
platform/GlyphPageTreeNode.h:
platform/PopupMenu.h:
platform/RegularExpression.cpp:
platform/ScrollBar.h:
platform/SharedBuffer.h:
platform/StringImpl.h:
platform/graphics/Icon.h:
platform/graphics/svg/SVGResource.h:
platform/network/FormData.cpp: (WebCore::FormData::FormData):
platform/network/FormData.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h:
rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
rendering/RenderStyle.h:
rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::SVGCharOnPath):
storage/SQLResultSetRowList.h:
xml/DOMParser.h:
xml/XMLHttpRequest.h:
xml/XMLSerializer.h:
xml/XPathEvaluator.h:
xml/XPathExpression.h:
xml/XPathNSResolver.h:
xml/XPathResult.h:
xml/XPathValue.h:
xml/XSLTProcessor.h:

WebKit/mac:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
ForwardingHeaders/wtf/Shared.h: Removed.
WebCoreSupport/WebContextMenuClient.h:

5:54 PM Changeset in webkit [27775] by beidson@apple.com

2 edits
4 deletes in trunk/WebCore

Reviewed by Mark Rowe

Remove errantly added files, and fix the idl (for reference's sake)

storage/JSCustomSQLStatementCallback.h: Removed.
storage/JSCustomSQLStatementErrorCallback.h: Removed.
storage/JSCustomSQLTransactionCallback.h: Removed.
storage/JSCustomSQLTransactionErrorCallback.h: Removed.
storage/SQLStatementCallback.idl:

5:41 PM Changeset in webkit [27774] by Adam Roben

3 edits in trunk/WebCore

Fix a bug and improve upon Brady's fix

Reviewed by Anders.

bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql): Made the code a little clearer and more correct.
loader/icon/IconDatabase.cpp: Put parentheses around the expansion of IS_ICON_SYNC_THREAD() so that ASSERT_NOT_SYNC_THREAD() does the comparison it meant to.

5:39 PM Changeset in webkit [27773] by weinig@apple.com

2 edits in trunk/WebCore

Fix Qt and Gtk builds.

WebCore.pro: Remove non-generated idl files.

5:36 PM Changeset in webkit [27772] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-13 Mark Rowe <mrowe@apple.com>

Remove removed file from the project.

WebCore.pro:

5:30 PM Changeset in webkit [27771] by weinig@apple.com

5 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

Fix for <rdar://problem/5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")

DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Initialize the RECT. (UIDelegate::setFrame): copy the contents of the rect, not the pointer. (UIDelegate::webViewFrame): ditto.
DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*

LayoutTests:

Reviewed by Adam Roben.

Fix for <rdar://problem/5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")

platform/win/Skipped: remove http/tests/security/cross-frame-access-put.html

5:29 PM Changeset in webkit [27770] by beidson@apple.com

2 edits in trunk/WebCore

Release build fix

bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):

5:05 PM Changeset in webkit [27769] by kmccullough@apple.com

17 edits in trunk

WebKit/win:

Reviewed by Adam.

Make Drosera show source, source URLs, and function stack on Windows and some minor fixes.

WebScriptCallFrame.cpp: Fixed a bug where the callFrame was not reffed properly before being returned, and changed functionName() to check for Null or if the name is empty. (EnumScopes::Clone): (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::caller): (WebScriptCallFrame::functionName):
WebScriptCallFrame.h: Ditto
WebScriptDebugServer.cpp: Made the listenerSet static since we were already treating it as if it were. Removed the EnumViews stuff. This was added by Steve to demonstrate DCOM and he thought it would be needed by Drosera, but I don't believe it will be. Implemented suspendProcessIfPaused() also added calls to it at the end of several functions to ensure we pause if Drosera has told WebKit to. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::sharedWebScriptDebugServer): (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::suspendProcessIfPaused): (WebScriptDebugServer::didLoadMainResourceForDataSource): (WebScriptDebugServer::didParseSource): (WebScriptDebugServer::failedToParseSource): (WebScriptDebugServer::didEnterCallFrame): (WebScriptDebugServer::willExecuteStatement): (WebScriptDebugServer::willLeaveCallFrame): (WebScriptDebugServer::exceptionWasRaised):
WebScriptDebugServer.h: Ditto.
WebScriptDebugger.cpp: The important change here is that leaveFrame() is called before willLeaveCallFrame(). I think there is some EOL stuff going on too.
It was the implementing of these functions that allows source, the source URLs and function stack to be displayed. (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::enterFrame): (WebScriptDebugger::leaveFrame):
WebView.cpp: Removed the EnumView functions. (WebView::WebView): (WebView::~WebView):

WebKitTools:

Reviewed by Adam.

Make Drosera show source, source URLs, and function stack on Windows, and some minor fixes.

Drosera/DebuggerDocument.cpp: Force source to always update display. (DebuggerDocument::updateFileSource):
Drosera/debugger.js: Force source to always update display.
Drosera/win/DebuggerClient.cpp: Create the needed functions for the menu controls. (DebuggerClient::resume): (DebuggerClient::pause): (DebuggerClient::stepInto): (DebuggerClient::stepOver): (DebuggerClient::stepOut): (DebuggerClient::showConsole): (DebuggerClient::closeCurrentFile):
Drosera/win/DebuggerClient.h: Ditto.
Drosera/win/DebuggerDocumentPlatform.cpp: Changed getPlatformCurrentFunctionStack to not use an unecessary HRESULT and removed two bugs. 1) caller could be in a bad state when asked to assign into it. 2) BSTRs were not created correctly. (DebuggerDocument::getPlatformCurrentFunctionStack):
Drosera/win/Drosera.cpp: Hook up the menu controls. (droseraWndProc): (handleCommand): (Drosera::resume): (Drosera::pause): (Drosera::stepInto): (Drosera::stepOver): (Drosera::stepOut): (Drosera::showConsole): (Drosera::closeCurrentFile):
Drosera/win/Drosera.h: Hook up the menu controls.
Drosera/win/ServerConnection.cpp: Removed unncessary server connection functions, added a null check, and fixed another bug where caller could be in a bad state when asked to assign into it. (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::getCallerFrame):
Drosera/win/ServerConnection.h: Safety first.

4:58 PM Changeset in webkit [27768] by Adam Roben

2 edits in trunk/JavaScriptCore

Build fix

Reviewed by Geoff.

kjs/regexp.h: Added a missing #include.

4:51 PM Changeset in webkit [27767] by andersca@apple.com

2 edits
1 add
3 deletes in trunk/LayoutTests

Reviewed by Adam.

Make this a text-only test.

fast/dom/Window/window-onFocus-expected.txt: Added.
fast/dom/Window/window-onFocus.html:
platform/mac/fast/dom/Window/window-onFocus-expected.checksum: Removed.
platform/mac/fast/dom/Window/window-onFocus-expected.png: Removed.
platform/mac/fast/dom/Window/window-onFocus-expected.txt: Removed.

4:49 PM Changeset in webkit [27766] by mitz@apple.com

3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

fix <http://bugs.webkit.org/show_bug.cgi?id=13371> DumpRenderTree --pixel-tests renders each test twice

DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed the --paint option because the painting code is always exercised as a result of -[FrameLoadDelegate webView:didFinishLoadFromFrame:] calling -displayIfNeeded. (dump): Changed to always grab the image from the window since the view is always displayed. (runTest): (displayWebView):
Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree because it always paints.

4:44 PM Changeset in webkit [27765] by Adam Roben

5 edits
2 copies
1 add in trunk

Fix <rdar://5346832> Infinite recursion when opening Web Inspector on more than one tab

WebCore:

Add WindowMessageBroadcaster

This class is used to listen in on messages sent to HWNDs. Multiple
WindowMessageListeners can be notified about messages sent to a single
HWND, and one WindowMessageListener can listen to messages from
multiple HWNDs.

Reviewed by Ada.

WebCore.vcproj/WebCore.vcproj: Added new files to project.
platform/win/WindowMessageBroadcaster.cpp: Added. (WebCore::instancesMap): Static helper. (WebCore::WindowMessageBroadcaster::addListener): Registers a listener for a particular HWND. (WebCore::WindowMessageBroadcaster::removeListener): Removes a listener for a particular HWND. (WebCore::WindowMessageBroadcaster::WindowMessageBroadcaster): (WebCore::WindowMessageBroadcaster::~WindowMessageBroadcaster): (WebCore::WindowMessageBroadcaster::destroy): Removes this broadcaster from the instancesMap, removes all of its listeners, unsubclasses the window, and deletes the broadcaster. (WebCore::WindowMessageBroadcaster::unsubclassWindow): Unsubclasses the window (which means that SubclassedWndProc won't be called again for this window). (WebCore::WindowMessageBroadcaster::SubclassedWndProc): Notifies all the listeners about every message sent to the HWND
platform/win/WindowMessageBroadcaster.h: Added. (WebCore::WindowMessageBroadcaster::listeners): (WebCore::WindowMessageBroadcaster::originalWndProc):
platform/win/WindowMessageListener.h: Added.

WebKit/win:

Fix <rdar://5346832> Infinite recursion when opening Web Inspector on more than one tab

The bug was that multiple WebNodeHighlights would subclass the same
browser window, leading to infinite recursion within
SubclassedWndProc.

WebNodeHighlight is now a WindowMessageListener, and lets
WindowMessageBroadcaster handle subclassing the window.

Reviewed by Ada.

WebNodeHighlight.cpp: (WebNodeHighlight::WebNodeHighlight): Initialize m_observedWindow member. (WebNodeHighlight::~WebNodeHighlight): Unregister as a listener for m_observedWindow. (WebNodeHighlight::highlight): Register as a listener. (WebNodeHighlight::windowReceivedMessage): Do the work that used to be done in SubclassedWndProc.
WebNodeHighlight.h: Made WebNodeHighlight a WindowMessageListener, and renamed m_subclassedWindow to m_observedWindow.

4:44 PM Changeset in webkit [27764] by Adam Roben

2 edits in trunk/WebKit/win

Build fix for systems that don't have Cygwin in their PATH

WebKit.vcproj/Interfaces.vcproj: Put Cygwin in the PATH before trying to run bash.

4:30 PM Changeset in webkit [27763] by ggaren@apple.com

92 edits
1 copy
1 move
3 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places. Deployed
Shared in places where JSCore previously had hand-rolled ref-counting
classes.

API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass):
API/JSClassRef.h:
API/JSObjectRef.cpp: (JSClassRetain): (JSClassRelease):
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/interpreter.cpp: (KJS::Interpreter::init):
kjs/interpreter.h:
kjs/regexp.cpp: (KJS::RegExp::RegExp):
kjs/regexp.h:
wtf/Shared.h: Copied from WebCore/platform/Shared.h.

JavaScriptGlue:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places.

ForwardingHeaders/wtf/Shared.h: Added.

WebCore:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places. Retained
TreeShared, but moved it to its own file, TreeShared.h.

ForwardingHeaders/wtf/Shared.h: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSSVGPODTypeWrapper.h:
css/CSSFontFace.h:
css/CSSRuleList.h:
css/Counter.h:
css/Pair.h:
css/Rect.h:
css/StyleBase.h:
css/StyleSheetList.h:
dom/Clipboard.h:
dom/DOMImplementation.h:
dom/Event.h:
dom/EventListener.h:
dom/NamedNodeMap.h:
dom/NodeFilterCondition.h:
dom/NodeList.h:
dom/Range.h:
dom/RangeException.h:
dom/RegisteredEventListener.h:
dom/Traversal.h:
history/BackForwardList.h:
history/CachedPage.h:
history/HistoryItem.h:
html/CanvasGradient.h:
html/CanvasPattern.h:
html/HTMLCollection.h:
html/MediaError.h:
html/TimeRanges.h:
html/VoidCallback.h:
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/svg/SVGAnimatedTemplate.h:
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGPathSeg.h:
ksvg2/svg/SVGPreserveAspectRatio.h:
ksvg2/svg/SVGRenderingIntent.h:
ksvg2/svg/SVGTransform.h:
ksvg2/svg/SVGUnitTypes.h:
loader/DocumentLoader.h:
loader/FormState.h:
loader/ResourceLoader.h:
loader/TextResourceDecoder.h:
loader/icon/IconRecord.h:
page/BarInfo.h:
page/Console.h:
page/DOMSelection.h:
page/DOMWindow.h:
page/History.h:
page/InspectorController.cpp:
page/Plugin.h:
page/Screen.h:
platform/ArrayImpl.h:
platform/CString.h:
platform/DeprecatedValueListImpl.cpp:
platform/FontFallbackList.h:
platform/FontFamily.h:
platform/FontSelector.h:
platform/GlyphPageTreeNode.h:
platform/PopupMenu.h:
platform/RegularExpression.cpp:
platform/ScrollBar.h:
platform/Shared.h: Removed.
platform/SharedBuffer.h:
platform/StringImpl.h:
platform/graphics/Icon.h:
platform/graphics/svg/SVGResource.h:
platform/network/FormData.h:
platform/network/ResourceHandleClient.h:
rendering/RenderStyle.h:
rendering/SVGCharacterLayoutInfo.h:
storage/SQLResultSetRowList.h:
xml/DOMParser.h:
xml/XMLSerializer.h:
xml/XPathEvaluator.h:
xml/XPathExpression.h:
xml/XPathNSResolver.h:
xml/XPathResult.h:

WebKit/mac:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places.

ChangeLog:
WebCoreSupport/WebContextMenuClient.h:

4:26 PM Changeset in webkit [27762] by beidson@apple.com

24 edits
2 copies
2 moves
2 adds
8 deletes in trunk

Squashed commit of the following:

commit 3e6cb737b3b823b4bf177b9e0c2fcfcc38baf46d
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 16:22:36 2007 -0800

Changelog for commit

commit 4be13a5ef17685368e68a76292b785c99da1d7f2
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 16:19:34 2007 -0800

Make inspector work with new API

commit c500ed90c32b31fbc37a183c8ae5427f36b9ccc2
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 14:37:16 2007 -0800

Woops!

commit c61b147f35a2801c340f82054d177914da6ccde5
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 11:45:40 2007 -0800

Ander's review comments

commit f3dc2683acc5730cbab8758226adae3e35f7263b
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 18:05:21 2007 -0800

Initial vcproj changes after the rebase

commit c8cf9be275479ff1fb39b911e5165f07fcd5ae34
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 18:02:30 2007 -0800

Fixed Changelog a bit

commit c9790cde9b79e25690f1c0b34b9c1e77d2f4449f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 16:53:48 2007 -0800

Finish the rebase/trunk merge

commit 663ad85619ec677eb5c52bed3c59b8b3f50de624
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 6 11:54:26 2007 -0800

VCProj changes for new SQL api + blind attempt at keeping qt/gtk going

commit 2aceeb3bdfa6894bb4e93c0b129867059e9cdad7
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 15:27:55 2007 -0800

Changelog edit cleanup

commit a05f11fa4fa0ba935eb28df6d9628f29a4074d7a
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 15:25:27 2007 -0800

Changelog entries and small style cleanup

commit a2d34a78d06f446f4bdb6ea1797dfb91cfc336fe
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:37:10 2007 -0800

Minor edit

commit eaf0aa9c07cfeb54df312c130677ecbc60728c5f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:32:20 2007 -0800

Do version check at time of executeSql

commit 3bac84615badcc810f44ebf14d1679bffd4cc8fb
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:04:14 2007 -0800

Newline = t3h gone

commit de7cfcf737b1a6143b74f1cc60955c317877ca27
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:02:11 2007 -0800

Example + inspector fixes

commit 536b119c219de72c97fe6756e226a36bef5e6880
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 11:47:30 2007 -0800

DatabaseExample works

commit fff79aa99dbf47955bc37ca325928460fc41a59e
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 10:36:59 2007 -0800

Remove the old, now unused DatabaseCallback

commit 06bc8e16ad346b755f767ce8e7849da819ccf96f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 09:57:36 2007 -0800

Sort project file

commit 741084d108ec994ff513e18c3d7a3153f6dd6bb5
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 09:30:37 2007 -0800

Sort the project file

commit 2e77cec4337db174f56269b7fb406d81ebb1de7d
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 16:01:03 2007 -0700

Yay! Change version even works!

commit 05c2ed1f22e3b689dd453ea300154492937f46db
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 15:19:56 2007 -0700

Nuke some DRT changes

commit 9b5b9b25c45d7d4720e4ddf4a31f163fb4f7faf2
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 15:05:59 2007 -0700

Nuke some printfs

commit 8503eecdefa95278a15246bb4eed2dccb69af12a
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 13:44:32 2007 -0700

Added "current transaction" to Database and reworked how scheduling goes

commit f70354c9a84d654d28894ab3c6b13679ce494fc3
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 11:49:26 2007 -0700

Things are largely working. Still need to clean up loose ends in the sticky notes demo and do further testing

commit 417665cd15f020c22af5691577e5c8a072630839
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 00:00:47 2007 -0700

Transaction steps are almost locked up completely. Still need the SQLError for the transaction error callback and actually implementing ::execute() on the SQLStatement

commit 752d572acd4d1d9832976b4869284e554845205a
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 18:52:55 2007 -0700

Forgot this.

commit 2c8f2689d212296961a841c579a2f93609858862
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 18:31:05 2007 -0700

Merge.

commit 7540d4fa7ef858400d9f834cba976a439394412d
Author: Brady Eidson <beidson@apple.com>
Date: Wed Oct 31 17:14:30 2007 -0700

Even closer!

commit 143a70a5d026ab9fab1b5de91f826effcd481527
Author: Brady Eidson <beidson@apple.com>
Date: Wed Oct 31 16:43:31 2007 -0700

Merge project file correctly

commit 11207e7b6e391a4052fc41f6db42ce30449c7e3e
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 11:04:35 2007 -0700

Remove more unused methods.

commit 9a0d306d467eb9aa8c19825da03b7abe318c609c
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 11:01:35 2007 -0700

Add SQLTransactionCallback.idl

commit 12e2fa2858145e3895320293462ec441c35a7e3d
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 10:47:17 2007 -0700

Fix build.

commit 02f4631705b0f6e0bd3c715c64f4938ea53f4670
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 23:36:24 2007 -0700

All steps now take place in the right order, following the right rules - only thing missing is the actual SQL executing!

commit 6a8c0d7d2beb745c070c55b14beac9a47d373fc4
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 18:20:35 2007 -0700

Closer and closer we roll

commit f945446453ae48a28d6e2f3dcce4660feae0da79
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 17:59:25 2007 -0700

Things are really rolling - transaction steps 1-5 are called as expected. Downhill from here

commit 138b49b62bc8f3d05b1171e280d403e8b15ef9c4
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 14:50:14 2007 -0700

Use pointer-to-member functions for the transaction steps... !!!

commit 3eb4f794861827f5c88cd8c36efb144cdc537bd5
Author: Anders Carlsson <andersca@apple.com>
Date: Tue Oct 30 14:45:59 2007 -0700

Remove more old cruft.

commit f18835f0709b4aff00903738974dbebb11a224f0
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 13:55:05 2007 -0700

Restore that comment

commit 35b2eac5ac3ec338cc2a8a4fe611f85e62c72dd6
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 12:08:29 2007 -0700

Closer, still, to the new model working. Lotsa little tweaks

commit a8476702a7d9bb38b8e15966e837ceca5858e9b2
Author: Anders Carlsson <andersca@apple.com>
Date: Tue Oct 30 11:23:02 2007 -0700

Wrap changeVersion.

commit aa0d8cc6aaaf674de341996555306eb9f122de3c
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 22:35:16 2007 -0700

Dummy callback as part of transaction steps acheived! And other architectural changes

commit 01c0a92daf764375be79753bc7bc417aa0205168
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 18:23:00 2007 -0700

Have a the first chunk of transaction steps occuring asynchronously with stubs and printf()s - should be downhill from here. Also updated the DatabaseExample.html for the portion of the new API that works so far.

commit 6b6e9e7a064424cd6b70489de80c79e7ae950b38
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 17:32:30 2007 -0700

Made DatabaseTasks create mutex/conditions on demand, and renamed the internal sqlitedatabase

commit 99d06513090c2b4e04edda82d82108cf97da245a
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 16:30:52 2007 -0700

Fix bug.

commit 83def2ce73fa001f5bda3e152ca60e58c563dbed
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 15:17:45 2007 -0700

Remove some cruft.

commit 9f2c8c21d06d6b379426449357f1ee00a25faeee
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 14:45:54 2007 -0700

More bindings.

commit 9eae9135ed17179b7bcd225648272d24b76de8b9
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 14:19:34 2007 -0700

Adapt to new openDatabase() method

commit 2e1dad857b190634f4394475e925d2dc518ae1fe
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 12:05:53 2007 -0700

More infrastructure changes for the new spec, getting really close now!

commit b0d8ca9dc7ffe1a424070d5f8587346eca56b76b
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 17:25:41 2007 -0700

More stubbing of infrastructure

commit bb8c6528208a24f129af9a8c09763989e5723157
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 15:38:16 2007 -0700

Remove SQLVersionChangeCallback.h

commit c77ec8b1d2a7c8cb7a6a0bc42b089c34541cdf83
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 15:28:08 2007 -0700

Make it build (removed the old changeVersion)

commit e205fd2d6cb0cd4e6dd47cf4b6609196d0d8e87d
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 14:53:15 2007 -0700

Even more progress in the architecture change

commit 322f576e2ed8c584244335f918302169c81ea39f
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 14:52:22 2007 -0700

Add JSSQLTransactionCustom.cpp.

commit 22d0b184e1d5d92574b5caf2b73eb6c7faae84be
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 13:21:55 2007 -0700

Add new API to Database.

commit 910660c7668f2728850990f8984045de9e41423f
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 11:48:33 2007 -0700

Add more .IDL files

commit 4d0cbb5b3e8c57076ce0cb743f8a52a5e31c0219
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 11:20:54 2007 -0700

Further groundwork for new API (does not build)

commit d6420aacd1bf610ca53eced12e61ecd074f31bd7
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 18:02:23 2007 -0700

Further stubs and adaptations to the new API

commit ea80b0c14037cfbdccf322146b26b62df2aa8211
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 15:51:43 2007 -0700

Remove closeTransaction()

commit 4e701837674e07111da80a476135f5b73e25210f
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 14:05:40 2007 -0700

Further stubbing and API-matching cleanup

commit f667cf3c7847069a6720296710876394954611bd
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 16:32:58 2007 -0700

Add extra arguments to Window.openDatabase.

commit efbbe3016a31a9c4a717de25d831406288f8126d
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 14:21:22 2007 -0700

cleanup.

commit b70a8252a588eee36d06835bad5793361ced35c5
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 12:31:06 2007 -0700

Stub out a couple of new classes.

2:14 PM Changeset in webkit [27761] by mitz@apple.com

2 edits
1 add in trunk/WebCore

Reviewed by Beth Dakin.

fix <rdar://problem/5551163> REGRESSION: Cursor does not change to arrow on "X" button in google maps, making it hard to click

css/html4.css: Added a 'cursor: auto' rule for links.
manual-tests/link-cursor-auto.html: Added.

1:59 PM Changeset in webkit [27760] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Beth Dakin.

fix <rdar://problem/5516272> Reproducible crash in RenderObject::setStyle involving going Back from a non-HTML document (Bookmarks view, PDF view)

The root cause for the crash is that when a non-HTML view enters the
frame, the frame's document pointer keeps pointing at the last HTML-type
document it contained. This patch does not address the root cause, but
makes changes to account for that condition.

loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedMainResourceError): Do not change the frame's current document's page cache state here. (WebCore::FrameLoader::invalidateCurrentItemCachedPage): If the frame's current document is in fact the history item being invalidated, then set its page cache state here.

12:37 PM Changeset in webkit [27759] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-13 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Add an ASSERT to getTruncatedInt32 to enforce proper usage.
Best part about this patch? It doesn't break the web!

kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::getUInt32):

12:08 PM Changeset in webkit [27758] by Antti Koivisto

10 edits
4 adds in trunk

WebCore:

Reviewed by Adele.

Fix that 'timeupdate' and 'waiting' events were never dispatched.

Add explicit m_paused attribute instead of trying to derive paused state from
underlying media. Call updatePlayState() to start/stop media playback
when any attribute that affects active playback state changes. This matches
specification text.

Test: http/tests/media/video-play-stall.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::paused): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieDidEnd): (WebCore::HTMLMediaElement::updatePlayState):
html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Adele.

add HTTP media test for stalling load
update tests that don't specifically test autoplay feature to not use autoplay attribute since playback may start before event listeners are registered

http/tests/media: Added.
http/tests/media/video-load-and-stall.cgi: Added.
http/tests/media/video-play-stall-expected.txt: Added.
http/tests/media/video-play-stall.html: Added.
media/video-autoplay.html:
media/video-dom-loopstart.html:
media/video-end.html:
media/video-loopcount.html:
media/video-loopend.html:
media/video-loopstart.html:

12:05 PM Changeset in webkit [27757] by Antti Koivisto

2 edits in trunk/WebKitTools

Reviewed by Adele.

Add support for http media tests

Scripts/run-webkit-tests:

11:54 AM Changeset in webkit [27756] by ap@webkit.org

4 edits in trunk/JavaScriptCore

Windows build fix.

bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
kjs/ustring.cpp: (KJS::UString::UTF8String):
wtf/unicode/UTF8.cpp: (WTF::Unicode::ConvertUTF8ToUTF16):

11:29 AM Changeset in webkit [27755] by sfalken@apple.com

4 edits in trunk/WebKit/win

Add IDOMElementPrivate::font() to get an element's font
as a WebFontDescription.

Reviewed by Darin.

DOMCoreClasses.cpp: (DOMElement::font):
DOMCoreClasses.h:
Interfaces/DOMPrivate.idl:

10:15 AM Changeset in webkit [27754] by sullivan@apple.com

5 edits in trunk

WebCore:

Reviewed by Darin.

removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing

bridge/WindowFeatures.h: (WebCore::WindowFeatures::WindowFeatures): removed definition of PreferredType

page/ContextMenuController.cpp: (WebCore::openNewWindow): removed use of PreferredType

WebKit/mac:

Reviewed by Darin.

removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): removed use of PreferredType

9:35 AM Changeset in webkit [27753] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Dan Bernstein.

fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in form fields other than the one you're typing into

WebCoreSupport/WebEditorClient.mm: (selectorForKeyEvent): correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445 but didn't get updated here.

9:25 AM Changeset in webkit [27752] by Darin Adler

5 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=11231 RegExp bug when handling newline characters and a number of other differences between PCRE behvior and JavaScript regular expressions:

+ single-digit sequences like \4 should be treated as octal

character constants, unless there is a sufficient number
of brackets for them to be treated as backreferences

+ \8 turns into the character "8", not a binary zero character

followed by "8" (same for 9)

+ only the first 3 digits should be considered part of an

octal character constant (the old behavior was to decode
an arbitrarily long sequence and then mask with 0xFF)

+ if \x is followed by anything other than two valid hex digits,

then it should simply be treated a the letter "x"; that includes
not supporting the \x{41} syntax

+ if \u is followed by anything less than four valid hex digits,

then it should simply be treated a the letter "u"

+ an extra "+" should be a syntax error, rather than being treated

as the "possessive quantifier"

+ if a "]" character appears immediately after a "[" character that

starts a character class, then that's an empty character class,
rather than being the start of a character class that includes a
"]" character

+ a "$" should not match a terminating newline; we could have gotten

PCRE to handle this the way we wanted by passing an appropriate option

Test: fast/js/regexp-no-extensions.html

pcre/pcre_compile.cpp: (check_escape): Check backreferences against bracount to catch both overflows and things that should be treated as octal. Rewrite octal loop to not go on indefinitely. Rewrite both hex loops to match and remove \x{} support. (compile_branch): Restructure loops so that we don't special-case a "]" at the beginning of a character class. Remove code that treated "+" as the possessive quantifier. (jsRegExpCompile): Change the "]" handling here too.

pcre/pcre_exec.cpp: (match): Changed CIRC to match the DOLL implementation. Changed DOLL to remove handling of "terminating newline", a Perl concept which we don't need.

tests/mozilla/expected.html: Two tests are fixed now: ecma_3/RegExp/regress-100199.js and ecma_3/RegExp/regress-188206.js. One test fails now: ecma_3/RegExp/perlstress-002.js -- our success before was due to a bug (we treated all 1-character numeric escapes as backreferences). The date tests also now both expect success -- whatever was making them fail before was probably due to the time being close to a DST shift; maybe we need to get rid of those tests.

LayoutTests:

Reviewed by Geoff.

test for http://bugs.webkit.org/show_bug.cgi?id=11231 RegExp bug when handling newline characters and other regular expression behavior that is different for JavaScript and PCRE

fast/js/regexp-no-extensions-expected.txt: Added.
fast/js/regexp-no-extensions.html: Added.
fast/js/resources/regexp-no-extensions.js: Added.

9:22 AM Changeset in webkit [27751] by Darin Adler

2 edits in trunk/JavaScriptCore

kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Remove too-strong assert that was firing constantly and preventing even basic web browsing from working in a debug build. This function is used in many cases where the immediate value is not a number; the assertion could perhaps be added back later with a bit of reorganization.

1:49 AM Changeset in webkit [27750] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-13 Alp Toker <alp@atoker.com>

Build fix for breakage to non-Mac builds introduced in r27746.

kjs/ustring.cpp:

12:34 AM Changeset in webkit [27749] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-13 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Clean up evaluateToBoolean functions to use inlines instead of copy/paste code

kjs/JSImmediate.h:
kjs/nodes.cpp: (KJS::GreaterNode::inlineEvaluateToBoolean): (KJS::GreaterNode::evaluate): (KJS::LessEqNode::inlineEvaluateToBoolean): (KJS::LessEqNode::evaluate): (KJS::GreaterEqNode::inlineEvaluateToBoolean): (KJS::GreaterEqNode::evaluate): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::inlineEvaluateToBoolean): (KJS::EqualNode::evaluate): (KJS::NotEqualNode::inlineEvaluateToBoolean): (KJS::NotEqualNode::evaluate): (KJS::StrictEqualNode::inlineEvaluateToBoolean): (KJS::StrictEqualNode::evaluate): (KJS::NotStrictEqualNode::inlineEvaluateToBoolean): (KJS::NotStrictEqualNode::evaluate):
kjs/nodes.h:

12:05 AM Changeset in webkit [27748] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15958
base64 spends 1.1% of total time checking for special Infinity case

Use a fast character test instead of calling strncmp.

1.1% speedup on string-base64. SunSpider reports a .4% speedup overall;
Sharks reports only .1%. Who are you going to believe? Huh?

kjs/ustring.cpp: (KJS::UString::toDouble):

12:02 AM Changeset in webkit [27747] by eric@webkit.org

6 edits in trunk/JavaScriptCore

2007-11-12 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Add evaluateToInt32 and evaluateUInt32 methods and deploy them.
Fix a few missing evaluateToBoolean methods
Deploy all evaluateTo* functions to more nodes to avoid slowdowns
http://bugs.webkit.org/show_bug.cgi?id=15950

SunSpider claims this is at least a 1.4% speedup.

kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::getUInt32):
kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToNumber): (KJS::ExpressionNode::evaluateToInt32): (KJS::ExpressionNode::evaluateToUInt32): (KJS::NumberNode::evaluateToInt32): (KJS::NumberNode::evaluateToUInt32): (KJS::ImmediateNumberNode::evaluateToInt32): (KJS::ImmediateNumberNode::evaluateToUInt32): (KJS::ResolveNode::evaluate): (KJS::ResolveNode::evaluateToNumber): (KJS::ResolveNode::evaluateToBoolean): (KJS::ResolveNode::evaluateToInt32): (KJS::ResolveNode::evaluateToUInt32): (KJS::LocalVarAccessNode::evaluateToInt32): (KJS::LocalVarAccessNode::evaluateToUInt32): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::BracketAccessorNode::evaluateToBoolean): (KJS::BracketAccessorNode::evaluateToInt32): (KJS::BracketAccessorNode::evaluateToUInt32): (KJS::DotAccessorNode::inlineEvaluate): (KJS::DotAccessorNode::evaluate): (KJS::DotAccessorNode::evaluateToNumber): (KJS::DotAccessorNode::evaluateToBoolean): (KJS::DotAccessorNode::evaluateToInt32): (KJS::DotAccessorNode::evaluateToUInt32): (KJS::NewExprNode::inlineEvaluate): (KJS::NewExprNode::evaluate): (KJS::NewExprNode::evaluateToNumber): (KJS::NewExprNode::evaluateToBoolean): (KJS::NewExprNode::evaluateToInt32): (KJS::NewExprNode::evaluateToUInt32): (KJS::FunctionCallResolveNode::inlineEvaluate): (KJS::FunctionCallResolveNode::evaluate): (KJS::FunctionCallResolveNode::evaluateToNumber): (KJS::FunctionCallResolveNode::evaluateToBoolean): (KJS::FunctionCallResolveNode::evaluateToInt32): (KJS::FunctionCallResolveNode::evaluateToUInt32): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluateToNumber): (KJS::LocalVarFunctionCallNode::evaluateToBoolean): (KJS::LocalVarFunctionCallNode::evaluateToInt32): (KJS::LocalVarFunctionCallNode::evaluateToUInt32): (KJS::FunctionCallDotNode::evaluate): (KJS::FunctionCallDotNode::evaluateToNumber): (KJS::FunctionCallDotNode::evaluateToBoolean): (KJS::FunctionCallDotNode::evaluateToInt32): (KJS::FunctionCallDotNode::evaluateToUInt32): (KJS::PostDecLocalVarNode::inlineEvaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToBoolean): (KJS::PostDecLocalVarNode::evaluateToInt32): (KJS::PostDecLocalVarNode::evaluateToUInt32): (KJS::typeStringForValue): (KJS::UnaryPlusNode::evaluate): (KJS::UnaryPlusNode::evaluateToBoolean): (KJS::UnaryPlusNode::evaluateToNumber): (KJS::UnaryPlusNode::evaluateToInt32): (KJS::BitwiseNotNode::inlineEvaluateToInt32): (KJS::BitwiseNotNode::evaluate): (KJS::BitwiseNotNode::evaluateToNumber): (KJS::BitwiseNotNode::evaluateToBoolean): (KJS::BitwiseNotNode::evaluateToInt32): (KJS::MultNode::evaluateToBoolean): (KJS::MultNode::evaluateToInt32): (KJS::MultNode::evaluateToUInt32): (KJS::DivNode::evaluateToInt32): (KJS::DivNode::evaluateToUInt32): (KJS::ModNode::evaluateToBoolean): (KJS::ModNode::evaluateToInt32): (KJS::ModNode::evaluateToUInt32): (KJS::AddNode::evaluateToNumber): (KJS::AddNode::evaluateToInt32): (KJS::AddNode::evaluateToUInt32): (KJS::AddNumbersNode::evaluateToInt32): (KJS::AddNumbersNode::evaluateToUInt32): (KJS::SubNode::evaluateToInt32): (KJS::SubNode::evaluateToUInt32): (KJS::LeftShiftNode::inlineEvaluateToInt32): (KJS::LeftShiftNode::evaluate): (KJS::LeftShiftNode::evaluateToNumber): (KJS::LeftShiftNode::evaluateToInt32): (KJS::RightShiftNode::inlineEvaluateToInt32): (KJS::RightShiftNode::evaluate): (KJS::RightShiftNode::evaluateToNumber): (KJS::RightShiftNode::evaluateToInt32): (KJS::UnsignedRightShiftNode::inlineEvaluateToUInt32): (KJS::UnsignedRightShiftNode::evaluate): (KJS::UnsignedRightShiftNode::evaluateToNumber): (KJS::UnsignedRightShiftNode::evaluateToInt32): (KJS::LessNode::inlineEvaluateToBoolean): (KJS::LessNode::evaluate): (KJS::LessNode::evaluateToBoolean): (KJS::LessNumbersNode::inlineEvaluateToBoolean): (KJS::LessNumbersNode::evaluate): (KJS::LessNumbersNode::evaluateToBoolean): (KJS::LessStringsNode::inlineEvaluateToBoolean): (KJS::LessStringsNode::evaluate): (KJS::BitAndNode::evaluate): (KJS::BitAndNode::inlineEvaluateToInt32): (KJS::BitAndNode::evaluateToNumber): (KJS::BitAndNode::evaluateToBoolean): (KJS::BitAndNode::evaluateToInt32): (KJS::BitXOrNode::inlineEvaluateToInt32): (KJS::BitXOrNode::evaluate): (KJS::BitXOrNode::evaluateToNumber): (KJS::BitXOrNode::evaluateToBoolean): (KJS::BitXOrNode::evaluateToInt32): (KJS::BitOrNode::inlineEvaluateToInt32): (KJS::BitOrNode::evaluate): (KJS::BitOrNode::evaluateToNumber): (KJS::BitOrNode::evaluateToBoolean): (KJS::BitOrNode::evaluateToInt32): (KJS::ConditionalNode::evaluateToNumber): (KJS::ConditionalNode::evaluateToInt32): (KJS::ConditionalNode::evaluateToUInt32): (KJS::valueForReadModifyAssignment): (KJS::AssignExprNode::evaluate): (KJS::AssignExprNode::evaluateToBoolean): (KJS::AssignExprNode::evaluateToNumber): (KJS::AssignExprNode::evaluateToInt32): (KJS::VarDeclNode::handleSlowCase):
kjs/nodes.h: (KJS::FunctionCallResolveNode::precedence): (KJS::AddNode::precedence): (KJS::AddNode::): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
kjs/value.cpp: (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):
kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::toInt32): (KJS::JSValue::toUInt32):

Nov 12, 2007:

11:12 PM Changeset in webkit [27746] by ap@webkit.org

11 edits
2 adds in trunk/JavaScriptCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15953
Add UTF-8 encoding/decoding to WTF

kjs/ustring.h: Moved UTF8SequenceLength() and decodeUTF8Sequence() to wtf/unicode.
kjs/ustring.cpp: (KJS::UString::UTF8String): Changed this function to take a strict/lenient parameter. Callers are not interested in getting decoding results in strict mode, so this allows for bailing out as soon as an error is seen.

kjs/function.cpp: (KJS::encode): Updated for new UString::UTF8String() signature.

API/JSStringRef.cpp: (JSStringCreateWithCharacters): Disambiguate UChar. (JSStringCreateWithUTF8CString): Actually use UTF-8 when creating the string!
bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use ConvertUTF8ToUTF16().

wtf/unicode/UTF8.cpp: Added. (WTF::Unicode::inlineUTF8SequenceLengthNonASCII): (WTF::Unicode::inlineUTF8SequenceLength): (WTF::Unicode::UTF8SequenceLength): (WTF::Unicode::decodeUTF8Sequence): (WTF::Unicode::): (WTF::Unicode::ConvertUTF16ToUTF8): (WTF::Unicode::isLegalUTF8): (WTF::Unicode::ConvertUTF8ToUTF16):
wtf/unicode/UTF8.h: Added. (WTF::Unicode::): Some code moved from ustring.h, some adapted from unicode.org sources.

JavaScriptCore.exp:
JavaScriptCore.pri:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl: Added UTF8.{h,cpp}

10:48 PM Changeset in webkit [27745] by weinig@apple.com

4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15946 add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)

bindings/npapi.h:

WebKit/mac:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15946 add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setVariable:value:]):

10:21 PM Changeset in webkit [27744] by ap@webkit.org

11 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15954
Move DOM Selection operations out of SelectionController

No change in functionality.

WebCore:

editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange):
editing/SelectionController.h:
page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::selectAllChildren): (WebCore::DOMSelection::toString):
page/DOMSelection.h: Moved all DOM API methods to DOMSelection; changed SelectionController::setSelectedRange() to return its result directly instead of via an ExceptionCode that no caller wanted.

editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::selectComposition): (WebCore::Editor::setComposition):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Adapted for SelectionController::setSelectedRange() now returning a bool. SelectionController::toString() is no longer avasilable, use plainText() explicitly.

WebCore.base.exp: Changed SelectionController::setSelectedRange() signature.

WebKit:

WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]):
WebView/WebView.mm: (-[WebView setSelectedDOMRange:affinity:]): Adapted for SelectionController::setSelectedRange() now returning a bool.

8:53 PM Changeset in webkit [27743] by mitz@apple.com

5 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

<http://bugs.webkit.org/show_bug.cgi?id=15890> Most of www.aol.com still redraws unnecessarily when headline/photo section changes

Test: fast/repaint/invisible-objects.html

Avoid repainting invisible blocks if they are enclosed in a layer that
contains no visible objects.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect):

LayoutTests:

Reviewed by Darin Adler.

no-repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15890> Most of www.aol.com still redraws unnecessarily when headline/photo section changes

fast/repaint/invisible-objects.html: Added.
platform/mac/fast/repaint/invisible-objects-expected.checksum: Added.
platform/mac/fast/repaint/invisible-objects-expected.png: Added.
platform/mac/fast/repaint/invisible-objects-expected.txt: Added.

7:57 PM Changeset in webkit [27742] by oliver@apple.com

3 edits in trunk/WebCore

<rdar://problem/5537289> REGRESSION: Dragging a link or an image from an IFrame causes the page to not respond to clicks afterwards (15460)

Reviewed by John S.

EventHandler needs to reset these fields when a drag terminates, otherwise
EventHandler is left in an inconsistent state when a drag is initiated on a
page with multiple frames.

6:33 PM Changeset in webkit [27741] by wsiegrist@apple.com

1 edit in trunk/WebKitSite/test.txt

6:23 PM Changeset in webkit [27740] by wsiegrist@apple.com

1 edit in trunk/WebKitSite/test.txt

test 4

6:10 PM Changeset in webkit [27739] by wsiegrist@apple.com

1 edit in trunk/WebKitSite/test.txt

6:04 PM Changeset in webkit [27738] by wsiegrist@apple.com

1 edit in trunk/WebKitSite/test.txt

2++

5:58 PM Changeset in webkit [27737] by wsiegrist@apple.com

1 edit in trunk/WebKitSite/test.txt

take 2

5:53 PM Changeset in webkit [27736] by wsiegrist@apple.com

1 add in trunk/WebKitSite/test.txt

testing post-commit.

5:39 PM Changeset in webkit [27735] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Prevent selecting a word in the breadcrumb or the styles section when double
clicking on a DOM node in the outline tree.

page/inspector/DocumentPanel.js: Call preventDefault() when a mousedown event with a detail of 2 or higher comes in. This prevents the selection.
page/inspector/inspector.css: Mark the breadcrumb as user-select: none.

5:33 PM Changeset in webkit [27734] by weinig@apple.com

5 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.

DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPrivateBrowsingEnabled):

LayoutTests:

Reviewed by Adam Roben.

platform/win/Skipped: Remove http/tests/security/cross-frame-acdcess-private-browsing.html from the windows skipped list now that LayoutTestController.setPrivateBrowsingEnabled has been implmented.

4:22 PM Changeset in webkit [27733] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=15951 REGRESSION: assertion failure in regexp match() when running JS tests

Test: fast/js/regexp-many-brackets.html

pcre/pcre_exec.cpp: (match): Added back accidentally-removed case for the BRANUMBER opcode.

LayoutTests:

Reviewed by Sam.

test for http://bugs.webkit.org/show_bug.cgi?id=15951 REGRESSION: assertion failure in regexp match() when running JS tests

fast/js/regexp-many-brackets-expected.txt: Added.
fast/js/regexp-many-brackets.html: Added.
fast/js/resources/regexp-many-brackets.js: Added.

3:53 PM Changeset in webkit [27732] by oliver@apple.com

2 edits in trunk/WebCore

Return behaviour for 0 sized pattern back to what it was prior to r27704

Reviewed by Darin and Antti.

This change in behaviour broke two layout tests in DRT, so correcting it
corrects existing tests.

3:27 PM Changeset in webkit [27731] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/5268311> REGRESSION (Safari 2-3): Exception thrown when calling -[WebDataSource subresources]

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): If the SharedBuffer is null insert an empty NSData instead of nil.

3:04 PM Changeset in webkit [27730] by Darin Adler

17 edits
1 delete in trunk/JavaScriptCore

Reviewed by Geoff.

fix use of prefix and config.h, got rid of a few unneeded things in the PCRE code; no behavior changes

API/JSBase.cpp: Added include of config.h.
API/JSCallbackConstructor.cpp: Ditto.
API/JSCallbackFunction.cpp: Ditto.
API/JSCallbackObject.cpp: Ditto.
API/JSClassRef.cpp: Ditto.
API/JSContextRef.cpp: Ditto.
API/JSObjectRef.cpp: Ditto.
API/JSStringRef.cpp: Ditto.
API/JSValueRef.cpp: Ditto.

JavaScriptCorePrefix.h: Removed obsolete <ctype.h> workaround. Moved new/delete macros after includes, as they are in WebCore's prefix. Removed "config.h".

pcre/dftables.cpp: (main): Changed back to not use a separate maketables function. This is needed for PCRE, but not helpful for our use. Also changed the tables to all be 128 entries long instead of 256, since only the first 128 are ever used.

pcre/pcre_compile.cpp: Added include of config.h. Eliminated digitab, which was only being used to check hex digits. Changed all uses of TRUE and FALSE to use the C++ true and false instead. (check_escape): Just the TRUE/FALSE thing. (is_counted_repeat): Ditto. (could_be_empty_branch): Ditto. (get_othercase_range): Ditto. (compile_branch): Ditto. (compile_regex): Ditto. (is_anchored): Ditto. (is_startline): Ditto. (find_firstassertedchar): Ditto. (jsRegExpCompile): Ditto.

pcre/pcre_exec.cpp: Added include of config.h. Changed all uses of TRUE and FALSE to use the C++ true and false instead. (match_ref): Just the TRUE/FALSE thing. (match): Ditto. Removed some unneeded braces. (jsRegExpExecute): Just the TRUE/FALSE thing.

pcre/pcre_internal.h: Moved the constants needed by dftables.cpp to the top of the file instead of the bottom, so they can be used. Also changed the table sizes to 128 instead of 256. Removed macro definitions of FALSE and TRUE. Set array sizes for all the const arrays. Changed _pcre_utf8_table1_size to be a macro instead of a extern int.

pcre/pcre_maketables.cpp: Removed. It's all in dftables.cpp now.

pcre/pcre_tables.cpp: Made table sizes explicit.

pcre/pcre_xclass.cpp: Just the TRUE/FALSE thing.

2:28 PM Changeset in webkit [27729] by Darin Adler

3 edits in trunk/WebCore

Reviewed by Tim.

http://bugs.webkit.org/show_bug.cgi?id=15947 speed up page loading a bit by inlining

loader/FrameLoader.cpp: (WebCore::FrameLoader::isLocationChange): Factored out the slow case of isScheduledLocationChangePending into this.

loader/FrameLoader.h: (WebCore::FrameLoader::isScheduledLocationChangePending): Added an inline check of the far and away most common case, where m_scheduledRedirection is 0; the rest is in the isLocationChange function.

2:11 PM Changeset in webkit [27728] by oliver@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Appease geoff :D

2:06 PM Changeset in webkit [27727] by ggaren@apple.com

3 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

fast/js/kde/completion-expected.txt:
fast/js/kde/resources/completion.js:

2:04 PM Changeset in webkit [27726] by oliver@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/5522011> The content of the password field of Safari is displayed by reconversion.

Reviewed by Darin.

Some input methods (notably Kotoeri) can incorrectly provide
access to the raw text of a password field. To work around
this we forcefully override the inputContext whenever a password
field is active.

1:59 PM Changeset in webkit [27725] by ggaren@apple.com

3 edits
3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

fast/js/kde/lval-exceptions-expected.txt: Added.
fast/js/kde/lval-exceptions.html: Added.
fast/js/kde/operators-expected.txt:
fast/js/kde/resources/lval-exceptions.js: Added.
fast/js/kde/resources/operators.js:

1:57 PM Changeset in webkit [27724] by ggaren@apple.com

1 edit
3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

fast/js/kde/func-decl-expected.txt: Added.
fast/js/kde/func-decl.html: Added.
fast/js/kde/resources/func-decl.js: Added.

1:55 PM Changeset in webkit [27723] by ggaren@apple.com

1 edit
6 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

fast/js/rehash-assign-expected.txt: Added.
fast/js/rehash-assign.html: Added.
fast/js/resize-array-assign-expected.txt: Added.
fast/js/resize-array-assign.html: Added.
fast/js/resources/rehash-assign.js: Added.
fast/js/resources/resize-array-assign.js: Added.

1:48 PM Changeset in webkit [27722] by ggaren@apple.com

3 edits
3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

fast/js/kde/arguments-scope-expected.txt: Added.
fast/js/kde/arguments-scope.html: Added.
fast/js/kde/resources/arguments-scope.js: Added.
fast/js/kde/resources/scope.js:
fast/js/kde/scope-expected.txt:

12:11 PM Changeset in webkit [27721] by staikos@webkit.org

4 edits in trunk/WebCore

2007-11-12 George Staikos <staikos@kde.org>

Reviewed by Tim.

Extract the text match marker highlight color into RenderTheme instead
of the hardcoded yellow.

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformTextSearchHighlightColor):
rendering/RenderTheme.h:

11:49 AM Changeset in webkit [27720] by mrowe@apple.com

2 edits in trunk/WebKitSite

2007-11-12 Mark Rowe <mrowe@apple.com>

building/tools.html: Remove extra >.

11:45 AM Changeset in webkit [27719] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-12 Mark Rowe <mrowe@apple.com>

Fix deadlock on launch on the Mac.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Restore unlock that was mistakenly removed in r27717.

10:51 AM Changeset in webkit [27718] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher

speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit: -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56

The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
by this class, but should be. (It is retained by WebHTMLView, e.g.).

WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release dataSource ivar (-[WebPDFView setDataSource:]): retain dataSource ivar

10:34 AM Changeset in webkit [27717] by mrowe@apple.com

5 edits in trunk/WebCore

2007-11-12 Justin Haygood <jhaygood@reaktix.com>

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=15955
Reimplement threading functions in IconDatabase and SQLiteDatabase in terms of the threading abstractions

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::close):
loader/icon/IconDatabase.h:
platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::open): (WebCore::SQLiteDatabase::close):
platform/sql/SQLiteDatabase.h:

8:31 AM TracStandalone edited by trac

(diff)

8:31 AM TracModPython edited by trac

(diff)

8:31 AM InterTrac created by trac

8:31 AM TracSearch edited by trac

(diff)

8:31 AM TracSupport edited by trac

(diff)

8:31 AM TracPlugins edited by trac

(diff)

8:31 AM TracChangeset edited by trac

(diff)

8:31 AM TracRevisionLog created by trac

8:31 AM TracUnicode edited by trac

(diff)

8:31 AM TracUpgrade edited by trac

(diff)

8:31 AM TracTimeline edited by trac

(diff)

8:31 AM TracRoadmap edited by trac

(diff)

8:31 AM TracReports edited by trac

(diff)

8:31 AM TracQuery edited by trac

(diff)

8:31 AM WikiRestructuredTextLinks edited by trac

(diff)

8:31 AM TracAccessibility edited by trac

(diff)

8:31 AM TracEnvironment edited by trac

(diff)

8:31 AM CamelCase edited by trac

(diff)

8:31 AM InterMapTxt created by trac

8:31 AM TracSyntaxColoring edited by trac

(diff)

8:31 AM WikiFormatting edited by trac

(diff)

8:31 AM TracTicketsCustomFields edited by trac

(diff)

8:31 AM TracNotification edited by trac

(diff)

8:31 AM WikiDeletePage edited by trac

(diff)

8:31 AM InterWiki created by trac

8:31 AM WikiHtml edited by trac

(diff)

8:31 AM TracWiki edited by trac

(diff)

8:31 AM TracIni edited by trac

(diff)

8:31 AM TracCgi edited by trac

(diff)

8:31 AM TracRss edited by trac

(diff)

8:31 AM WikiProcessors edited by trac

(diff)

8:31 AM TracPermissions edited by trac

(diff)

8:31 AM TracLinks edited by trac

(diff)

8:31 AM TracInterfaceCustomization edited by trac

(diff)

8:31 AM TracBrowser edited by trac

(diff)

8:31 AM WikiMacros edited by trac

(diff)

8:31 AM TracImport edited by trac

(diff)

8:31 AM TracInstall edited by trac

(diff)

8:31 AM TracFastCgi edited by trac

(diff)

8:31 AM TracGuide edited by trac

(diff)

8:31 AM TracBackup edited by trac

(diff)

8:31 AM WikiRestructuredText edited by trac

(diff)

8:31 AM TracAdmin edited by trac

(diff)

8:31 AM WikiPageNames edited by trac

(diff)

8:31 AM TracTickets edited by trac

(diff)

3:02 AM Changeset in webkit [27716] by Adam Roben

3 edits in trunk/WebCore

Windows build fix

config.h: Touch because VS apparently can't figure out which files depend on ResourceResponse.h.
WebCore.vcproj/WebCore.vcproj: Add ResourceResponseBase files to project and remove old ResourceResponse files.

2:39 AM Changeset in webkit [27715] by Adam Roben

4 edits in trunk

Change update-webkit-localizable-strings to only scan mac and win directories

WebKit:

StringsNotToBeLocalized.txt: Updated.

WebKitTools:

Scripts/update-webkit-localizable-strings: Changed to only scan the mac and win subdirectories.

2:33 AM Changeset in webkit [27714] by mrowe@apple.com

4 edits
2 moves
4 adds in trunk/WebCore

2007-11-12 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15334
Split ResourceResponse into platform specific files

WebCore.base.exp:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/network/ResourceResponse.cpp: Removed.
platform/network/ResourceResponse.h: Removed.
platform/network/ResourceResponseBase.cpp: Copied from platform/network/ResourceResponse.cpp. (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::updateResourceResponse):
platform/network/ResourceResponseBase.h: Copied from platform/network/ResourceResponse.h. (WebCore::ResourceResponseBase::ResourceResponseBase):
platform/network/cf/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse):
platform/network/curl/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
platform/network/mac/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse):
platform/network/qt/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):

2:27 AM Changeset in webkit [27713] by Adam Roben

3 edits in trunk/WebKit/win

Windows build fix

WebKit.vcproj/WebKit.def: Export fastZeroedMalloc.
WebKit.vcproj/WebKit_debug.def: Ditto.

1:59 AM Changeset in webkit [27712] by Adam Roben

2 edits in trunk/JavaScriptCore

Build fix

wtf/FastMalloc.h: Add missing using statement.

12:00 AM Changeset in webkit [27711] by oliver

7 edits in trunk/JavaScriptCore

Add special fastZeroedMalloc function to replace a
number of fastCalloc calls where one argument was 1.

Reviewed by Darin.

This results in a 0.4% progression in SunSpider, more
than making up for the earlier regression caused by
additional overflow checks.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed