Timeline
Dec 25, 2009:
- 9:26 PM Changeset in webkit [52564] by
-
- 7 edits5 adds in trunk
2009-12-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936
<section> should behave the same as <nav>.
Test: fast/html/section-element.html
- css/html.css: Add section as a block element.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add sectionTag.
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag. (WebCore::blockTagList): Add sectionTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add sectionTag.
- html/HTMLTagNames.in: Add section.
2009-12-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936
The new test file tests:
- <p> closing,
- Residual style, and
- FormatBlock.
- fast/html/script-tests/TEMPLATE.html: Added.
- fast/html/script-tests/section-element.js: Added.
- fast/html/section-element-expected.txt: Added.
- fast/html/section-element.html: Added.
- 8:34 PM Changeset in webkit [52563] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 3:58 PM Changeset in webkit [52562] by
-
- 2 edits in trunk/WebKitTools
2009-12-25 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Fixes an issue where checkFrameworks always dies with an error under Windows
since the clause "unless (-x $path)" is always satisfied because files under
Windows do not have an explict executable bit.
- Scripts/webkitdirs.pm:
- 3:32 PM Changeset in webkit [52561] by
-
- 3 edits in trunk/WebCore
2009-12-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up XSSAuditor.
Currently, we pass various parameters through to XSSAuditor::findInRequest
that are used to determine how to decode the HTTP input parameters so that
we can perform a match against the script source. Instead, we have defined
a structure XSSAuditor::FindTask that can hold all of these parameters.
No functionality was changed. So, no new tests.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): Modified to use struct XSSAuditor::FindTask. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto. (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto. (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
- page/XSSAuditor.h: (WebCore::XSSAuditor::FindTask::FindTask): Added.
- 3:11 PM Changeset in webkit [52560] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.
https://bugs.webkit.org/show_bug.cgi?id=32941
- platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
- platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
- platform/qt/fast/js/global-constructors-expected.txt: updated.
- 3:08 PM BuildingGtk edited by
- (diff)
- 1:03 PM Changeset in webkit [52559] by
-
- 11 edits3 adds in trunk
2009-12-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
DOMWindow is missing lots of SVG* constructor objects
https://bugs.webkit.org/show_bug.cgi?id=20430
Expose all implemented SVG 1.1 constructors.
Test: svg/custom/global-constructors.js
- bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
- bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
- page/DOMWindow.idl: Add a bunch of new SVG object ctors.
- svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
- svg/SVGAnimatedPoints.idl: Ditto.
- 6:58 AM Changeset in webkit [52558] by
-
- 7 edits4 adds in trunk/WebCore
2009-12-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
AuditsPanel for Web Inspector (hidden, no preset audits).
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditLauncherView.js: Added. (WebInspector.AuditLauncherView.categorySortFunction): (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._setAuditRunning): (WebInspector.AuditLauncherView.prototype._launchButtonClicked.profilingFinishedCallback): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype._updateButton): (WebInspector.AuditLauncherView.prototype.resize):
- inspector/front-end/AuditResultView.js: Added. (WebInspector.AuditResultView.entrySortFunction): (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane): (WebInspector.AuditRuleResultPane): (WebInspector.AuditRuleResultPane.prototype._decorateRuleResult): (WebInspector.AuditRuleResultChildSection): (WebInspector.AuditRuleResultChildSection.prototype.set title): (WebInspector.AuditRuleResultChildSection.prototype.expand):
- inspector/front-end/AuditsPanel.js: Added. (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.AuditsPanel.prototype.get statusBarItems): (WebInspector.AuditsPanel.prototype.get mainResourceLoadTime): (WebInspector.AuditsPanel.prototype.set mainResourceLoadTime): (WebInspector.AuditsPanel.prototype.get mainResourceDOMContentTime): (WebInspector.AuditsPanel.prototype.set mainResourceDOMContentTime): (WebInspector.AuditsPanel.prototype.get categoriesById): (WebInspector.AuditsPanel.prototype.get visibleView): (WebInspector.AuditsPanel.prototype._constructCategories): (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditsPanel.prototype._auditFinishedCallback): (WebInspector.AuditsPanel.prototype.initiateAudit.initiateAuditCallback): (WebInspector.AuditsPanel.prototype.initiateAudit): (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype._didMainResourceLoad): (WebInspector.AuditsPanel.prototype.showResults): (WebInspector.AuditsPanel.prototype.showLauncherView): (WebInspector.AuditsPanel.prototype.showView): (WebInspector.AuditsPanel.prototype.show): (WebInspector.AuditsPanel.prototype.attach): (WebInspector.AuditsPanel.prototype.resize): (WebInspector.AuditsPanel.prototype.updateMainViewWidth): (WebInspector.AuditsPanel.prototype._updateLauncherViewControls): (WebInspector.AuditsPanel.prototype._clearButtonClicked): (WebInspector.AuditsPanel.prototype._closeVisibleView): (WebInspector.AuditCategory): (WebInspector.AuditCategory.prototype.get id): (WebInspector.AuditCategory.prototype.get displayName): (WebInspector.AuditCategory.prototype.get ruleCount): (WebInspector.AuditCategory.prototype.addRule): (WebInspector.AuditCategory.prototype.runRules): (WebInspector.AuditRule): (WebInspector.AuditRule.prototype.get id): (WebInspector.AuditRule.prototype.get displayName): (WebInspector.AuditRule.prototype.run): (WebInspector.AuditRule.prototype.doRun): (WebInspector.AuditRule.prototype.getValue): (WebInspector.AuditCategoryResult): (WebInspector.AuditCategoryResult.prototype.addEntry): (WebInspector.AuditRuleResult): (WebInspector.AuditRuleResult.prototype.appendChild): (WebInspector.AuditRuleResult.prototype.set type): (WebInspector.AuditRuleResult.prototype.get type): (WebInspector.AuditsSidebarTreeElement): (WebInspector.AuditsSidebarTreeElement.prototype.onattach): (WebInspector.AuditsSidebarTreeElement.prototype.onselect): (WebInspector.AuditsSidebarTreeElement.prototype.get selectable): (WebInspector.AuditsSidebarTreeElement.prototype.refresh): (WebInspector.AuditResultSidebarTreeElement): (WebInspector.AuditResultSidebarTreeElement.prototype.onselect): (WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/audits.css: Added.
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
- 6:37 AM Changeset in webkit [52557] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.
- platform/qt/Skipped: inspector/settings-set-get.html removed.
- 6:24 AM Changeset in webkit [52556] by
-
- 15 edits in trunk/WebCore
2009-12-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement Edit Inner HTML action.
- English.lproj/localizedStrings.js:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorDOMAgent.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): ():
- inspector/front-end/InjectedScript.js: (InjectedScript.getNodePropertyValue): (InjectedScript.setOuterHTML): (InjectedScript.performSearch.addNodesToResults): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript.pushNodeToFrontend):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
Dec 24, 2009:
- 11:23 PM BuildingGtk edited by
- Added notice about required libsoup >= 2.28.2 due to change-set 52208 (diff)
- 10:07 PM Changeset in webkit [52555] by
-
- 2 edits in trunk/WebCore
Web Inspector: Console should force long URLs to wrap
https://bugs.webkit.org/show_bug.cgi?id=32927
Reviewed by Timothy Hatcher.
- inspector/front-end/inspector.css: Added "word-wrap: break-word;" to
the #console-messages rule.
- 7:25 PM Changeset in webkit [52554] by
-
- 2 edits in trunk/WebCore
2009-12-24 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium test fix by reverting r52536.
Do not a new Database pointer to any structure until its version has been verified
https://bugs.webkit.org/show_bug.cgi?id=32913
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- 5:15 PM Changeset in webkit [52553] by
-
- 2 edits in trunk/LayoutTests
2009-12-24 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Remove LayoutTests/storage/change-version.html from Qt Skipped list
LayoutTests/storage/change-version.html now passes.
Probably related to the fix in https://bugs.webkit.org/show_bug.cgi?id=32437.
- platform/qt/Skipped:
- 11:41 AM Changeset in webkit [52552] by
-
- 2 edits in trunk/WebKit/qt
Reviewed by Gustavo Noronha.
Doc : QGraphicsWebView::zoomFactor was introduced in 4.6.
- 9:34 AM Changeset in webkit [52551] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-24 Laszlo Gombos <Laszlo Gombos>
Unreviewed; revert of r52550.
The change regressed the following LayoutTests for QtWebKit.
fast/workers/worker-call.html -> crashed
fast/workers/worker-close.html -> crashed
- wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
- 9:03 AM Changeset in webkit [52550] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-24 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix memory leak by deleting instance of ThreadPrivate
in function waitForThreadCompletion(), synchronously, or in
detachThread(), asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=32614
- wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
- 6:12 AM Changeset in webkit [52549] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-24
[Qt] Skip failing test until a solution for layoutTestController.notifyDone() is found.
https://bugs.webkit.org/show_bug.cgi?id=31626
- platform/qt/Skipped: inspector/console-clear.html skipped
- 5:46 AM Changeset in webkit [52548] by
-
- 7 edits7 adds in trunk
Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
should not show cut off text
https://bugs.webkit.org/show_bug.cgi?id=29968
Reviewed by Dan Bernstein.
Also fixes the issue on both Mac OS X and Windows where the highlight
would extend only partway into the ellipsis based on the size of the
characters being truncated.
Test: editing/selection/select-text-overflow-ellipsis.html
WebCore:
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): When the ellipsis have been selected, paints them with the color for selected text. (WebCore::EllipsisBox::selectionRect): Returns the selection rect for the ellipsis text. (WebCore::EllipsisBox::paintSelection): Paints the selection highlight around the ellipsis text.
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): Default the selection state of the EllipsisBox to SelectionNone. (WebCore::EllipsisBox::setSelectionState): Allow the selection state to be explicitly set by the InlineTextBox that it is associated with, since the selection state depends on the position of the selection within the truncated text. (WebCore::EllipsisBox::selectionState): Return the cached selection state.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): If the text is truncated and the selection extends into the truncation where there are ellipsis, set the selection state on the EllipsisBox. (WebCore::paintTextWithShadows): Allow for an upper bound to be specified on the maximum length of the text to be painted. (WebCore::InlineTextBox::paint): Make sure the text that is drawn gets appropriately truncated. This was not an issue before on Mac OS X because it wasn't necessary to draw the selected text separately (the selected text had the same color as the non-selected text). (WebCore::InlineTextBox::paintSelection): If the text is being truncated, let whatever is being painted in the space after the truncated text paint its own highlight.
- rendering/InlineTextBox.h: (WebCore::InlineTextBox::truncation): Allow RenderText to access the truncation status.
- rendering/RenderText.cpp: (WebCore::RenderText::selectionRectForRepaint): Make sure that any ellipsis box that falls within the selection also gets repainted.
Places the expected results under the mac and win platforms separately
because they are pixel test results and also the size of the
RenderBlocks are showing up as slightly different between mac and win.
LayoutTests:
- editing/selection/select-text-overflow-ellipsis.html: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
- 4:33 AM Changeset in webkit [52547] by
-
- 24 edits1 add2 deletes in trunk
2009-12-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add Settings.js class that would manage
frontend settings.
This change:
- Splits preferences and settings
- Pushes settings to the frontend on load
- Stores settings on each change
- Stores showInheritedStyles as setting.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveFrontendSettings):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateFrontendSettings):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.saveFrontendSettings): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._setLargerResources):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/Settings.js: Added. (WebInspector.populateFrontendSettings): (WebInspector.Settings): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._installSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 3:12 AM Changeset in webkit [52546] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r52545, adding missing tests.
- inspector/console-clear-expected.txt: Added.
- inspector/console-clear.html: Added.
- 3:05 AM Changeset in webkit [52545] by
-
- 15 edits in trunk
2009-12-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] console's clear command does not work.
Test: inspector/console-clear.html
WebCore:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::clearConsoleMessages):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.requestClearConsoleMessages): (WebInspector.ConsoleView.prototype.clearConsoleMessages): (WebInspector.ConsoleView.prototype._clearButtonClicked):
- inspector/front-end/InjectedScript.js: (InjectedScript.clearConsoleMessages): (InjectedScript._ensureCommandLineAPIInstalled):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/inspector.js: (WebInspector.clearConsoleMessages): (WebInspector.reset):
LayoutTests:
- inspector/console-clear-expected.txt: Added.
- inspector/console-clear.html: Added.
- inspector/console-tests.js: (dumpConsoleMessages.callback): (dumpConsoleMessages):
- 2:38 AM Changeset in webkit [52544] by
-
- 10 edits in trunk
2009-12-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Console dumps strings in escaped form.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatIndividualValue):
- inspector/console-format-expected.txt:
Dec 23, 2009:
- 11:18 PM Changeset in webkit [52543] by
-
- 4 edits in trunk/WebKitTools
2009-12-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should accept global options anywhere
https://bugs.webkit.org/show_bug.cgi?id=26912
- Scripts/bugzilla-tool:
- Use the new global_options class property.
- Add a handle_global_options callback to avoid needing callbacks for each global option.
- Scripts/modules/multicommandtool.py:
- Make the code use one combined option parser. This allows us to accept global options anywhere and individual command options before commands.
- Add a handle_global_options callback to avoid needing callbacks for each global option.
- Make the Command hold the option parser, but allow the tool to override it.
- The default option parser is used for help printing and when Commands are run stand alone, but are otherwise not used.
- Add Command.main to codify the idea that Commands should support being run stand-alone.
- Change _split_args to _split_command_name_from_args now that args are unified.
- Scripts/modules/multicommandtool_unittest.py:
- Test that "tool" and "tool help" show the same help.
- Test that args are accepted before commands
- 9:49 PM Changeset in webkit [52542] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32905
With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion
Test: platform/mac/editing/input/selection-change-closes-typing.html
- editing/Editor.cpp: (WebCore::Editor::confirmComposition): If this function wasn't allowed to change selection, it needs to close the current typing command - otherwise, its idea of selection would be used for future typing.
- 9:31 PM Changeset in webkit [52541] by
-
- 6 edits in trunk/WebKitTools
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Moved some sections of code in preparation to refactor
check-webkit-style's argument parser to avoid setting
global variables.
- Scripts/check-webkit-style:
- Moved _USAGE string to style.py.
- Addressed FIXME by eliminating dependencies on cpp_style.py.
- Scripts/modules/cpp_style.py:
- Moved default arguments and style categories to style.py.
- Moved exit_with_usage(), exit_with_categories(), and parse_arguments() to style.py.
- Removed references in _CppStyleState to the global variables now in style.py.
- Scripts/modules/cpp_style_unittest.py:
- Moved parse_arguments() unit tests to style_unittest.py.
- Scripts/modules/style.py:
- Added _USAGE string from check-webkit-style.
- Added default arguments and style categories from cpp_style.py.
- Added exit_with_usage(), exit_with_categories(), and parse_arguments() from cpp_sstyle.py.
- Scripts/modules/style_unittest.py: Added.
- Added parse_arguments() unit tests from cpp_style_unittest.py.
- Scripts/run-webkit-unittests:
- Added unit tests from style_unittest.py.
- 6:31 PM Changeset in webkit [52540] by
-
- 3 edits in trunk/WebKitTools
2009-12-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should mention bug 30084 when rejecting patches until it can be fixed
https://bugs.webkit.org/show_bug.cgi?id=32911
- Scripts/modules/bugzilla.py: Make the message even more fancy.
- Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
- 6:23 PM Changeset in webkit [52539] by
-
- 2 edits in trunk/WebCore
2009-12-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.
This method should limit the current painting window to the bounds of the given
image, but it did not. Due to this bug, unnecessary contents were rendered in
some (limited) situations.
[Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
https://bugs.webkit.org/show_bug.cgi?id=32817
No new tests, because this is a fix of an existing test which is currently failing in
Chromium.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.
- 6:15 PM Changeset in webkit [52538] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
Include stddef.h for ptrdiff_t
https://bugs.webkit.org/show_bug.cgi?id=32891
ptrdiff_t is typedef-ed in stddef.h.
Include stddef.h in jit/ExecutableAllocator.h.
- jit/ExecutableAllocator.h:
- 5:45 PM Changeset in webkit [52537] by
-
- 198 edits in trunk/WebCore
2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Eric Seidel.
Remove all references to "GenerateConstructor", as this is the default behaviour now.
- 5:38 PM Changeset in webkit [52536] by
-
- 2 edits in trunk/WebCore
A new database should be registered with the Document,
DatabaseTracker and DatabaseThread only after it was successfully
opened and its version was successfully verified.
Reviewed by Eric Seidel.
Fixes a regression introduced by
http://trac.webkit.org/changeset/52530.
LayoutTests/storage/open-database-while-transaction-in-progress.html
should pass again (or rather, it should pass again when run after
open-database-set-empty-version.html).
https://bugs.webkit.org/show_bug.cgi?id=32913
- storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
- 5:15 PM Changeset in webkit [52535] by
-
- 7 edits2 deletes in trunk
2009-12-23 David Levin <levin@chromium.org>
REGRESSION (r52494): Assertion failure in Frame::caretBlinkTimerFired() (selection()->isCaret())
https://bugs.webkit.org/show_bug.cgi?id=32903
No review but ok'ed by Darin Adler. Rolling out r52494 due to above regression.
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
- fast/forms/selection-layout-reentry-strange-case.html: Removed.
- platform/mac/accessibility/frame-with-title-expected.txt:
WebCore:
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection):
- editing/SelectionController.h:
- page/Frame.cpp: (WebCore::Frame::setCaretVisible): (WebCore::Frame::selectionLayoutChanged):
- page/FrameView.cpp: (WebCore::FrameView::needsLayout):
- 4:55 PM Changeset in webkit [52534] by
-
- 75 edits in trunk
2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Reverse JS GenerateConstructor logic
https://bugs.webkit.org/show_bug.cgi?id=32910
Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
old default behaviour: do not generate JSFoobarConstructor class.
No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
classes have to be exposed, most of them are missing JS constructors so far.
As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html
- 4:34 PM Changeset in webkit [52533] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Eric Seidel.
Added Windows specific results for a test that was committed in r52505.
- platform/win/fast/forms/basic-textareas-quirks-expected.txt: Added.
- 3:22 PM Changeset in webkit [52532] by
-
- 4 edits in trunk
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
https://bugs.webkit.org/show_bug.cgi?id=32908
Update expected results to show that we don't raise an alarm in this case.
- http/tests/security/xssAuditor/object-src-inject-expected.txt:
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
https://bugs.webkit.org/show_bug.cgi?id=32908
Don't block direct injections into the object src attribute unless
there's an illegal character (like < or ") in the URL. This change
lets some very unusual vulnerabilities through the filter but removes a
false positive that we've seen several times.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
- 2:34 PM Changeset in webkit [52531] by
-
- 2 edits in trunk/WebKitTools
2009-12-23 Laszlo Gombos <Laszlo Gombos>
Not reviewed, adding myself to the reviewers list.
- Scripts/modules/committers.py:
- 2:33 PM Changeset in webkit [52530] by
-
- 2 edits in trunk/WebCore
Remove pointers to a database that failed to open from the
DatabaseTracker and Document.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=32885
- storage/Database.cpp:
(WebCore::Database::openDatabase):
- 1:03 PM Changeset in webkit [52529] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix after r47092.
- wtf/wince/MemoryManager.cpp: (WTF::tryFastMalloc): (WTF::tryFastZeroedMalloc): (WTF::tryFastCalloc): (WTF::tryFastRealloc):
- 12:40 PM Changeset in webkit [52528] by
-
- 7 edits in trunk/WebKitTools
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Create a prepare-diff command that creates a bug and a ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=32895
The workflow Maciej and I discussed is as follows:
1) Write code.
2) bugzilla-tool prepare-diff
3) Edit ChangeLogs
4) bugzilla-tool post-diff
We might want to experimenting with combining 2-4 into a single
command, but that might be stressful to edit the ChangeLogs modally.
Removed submit-patch since it has the modal ChangeLog editing but none
oof the bug creating fun.
- Scripts/modules/bugzilla.py:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 11:49 AM Changeset in webkit [52527] by
-
- 3 edits2 adds in trunk
<rdar://problem/7487164> First line of text cannot be selected
https://bugs.webkit.org/show_bug.cgi?id=32749
Reviewed by Darin Adler.
WebCore:
Test: fast/text/remove-zero-length-run.html
- rendering/RenderText.cpp:
(WebCore::RenderText::positionLineBox): Changed code that assumed that if a box was being
removed, it was the only box in the RenderText. Instead, correctly preserve the list of
text boxes.
(WebCore::RenderText::checkConsistency): Updated for earlier rename.
LayoutTests:
- fast/text/remove-zero-length-run-expected.txt: Added.
- fast/text/remove-zero-length-run.html: Added.
- 5:35 AM WebKit Team edited by
- (diff)
- 5:32 AM Changeset in webkit [52526] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to the committers list.
- Scripts/modules/committers.py:
- 5:19 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:52 AM Changeset in webkit [52525] by
-
- 8 edits3 adds in trunk
Fix for newlines turning into missing-gyphs when using SVG fonts
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32710
Font::drawText() has three code paths:
- drawTextUsingSVGFont()
- drawSimpleText()
- drawComplexText()
The latter two both have logic to replace newlines and tabs, as well
as a few other control characters that are considered spaces, with
spaces, before actually drawing the text. Previously the SVG font
path did not have this kind of logic.
This change introduces two helper functions in Font to do this space
replacement, which are then used for the simple path, the SVG path,
and the Qt implementation of the complex path.
Test: svg/custom/svg-fonts-in-html-linebreaks.html
WebCore:
- platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces): Helper function
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): Use helper
- platform/graphics/qt/FontQt.cpp:
(WebCore::fromRawDataWithoutRef): Rename from "qstring"
(WebCore::Font::drawComplexText): Use helper
(WebCore::Font::floatWidthForComplexText): Use helper
(WebCore::Font::offsetForPositionForComplexText): Use helper
(WebCore::Font::selectionRectForComplexText): Use helper
- platform/text/CharacterNames.h: Add enum for 0x0020
- svg/SVGFont.cpp: Use helper to fix bug
(WebCore::SVGTextRunWalker::walk):
LayoutTests:
- svg/custom/resources/ABCFont.svg: Added. Font for test case
- svg/custom/svg-fonts-in-html-linebreaks-expected.txt: Added.
- svg/custom/svg-fonts-in-html-linebreaks.html: New test case
- 3:05 AM Changeset in webkit [52524] by
-
- 10 edits18 adds in trunk
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
To implement the valueAsDate getter,
- Add a method to calculate milliseconds from 1970-01-01 to ISODateTime.
- Introduce m_type field to ISODateTime.
Tests: fast/forms/input-valueasdate-date.html
fast/forms/input-valueasdate-datetime.html
fast/forms/input-valueasdate-datetimelocal.html
fast/forms/input-valueasdate-month.html
fast/forms/input-valueasdate-time.html
fast/forms/input-valueasdate-week.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Implement it with ISODateTime::millisecondsSinceEpoch(). (WebCore::HTMLInputElement::formStringToISODateTime): Early exit for a null String. This avoids assertion failures in ISODateTime::parse*().
- html/ISODateTime.cpp: (WebCore::ISODateTime::parseMonth): Sets m_type. (WebCore::ISODateTime::parseDate): ditto. (WebCore::ISODateTime::parseWeek): ditto. (WebCore::ISODateTime::parseTime): ditto. (WebCore::ISODateTime::parseDateTimeLocal): ditto. (WebCore::ISODateTime::parseDateTime): ditto. (WebCore::ISODateTime::millisecondsSinceEpochForTime): Added. (WebCore::ISODateTime::millisecondsSinceEpoch): Added.
- html/ISODateTime.h: (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::invalidMilliseconds):
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
Tests for the valueAsDate getter with various types.
- fast/forms/input-valueasdate-date-expected.txt: Added.
- fast/forms/input-valueasdate-date.html: Added.
- fast/forms/input-valueasdate-datetime-expected.txt: Added.
- fast/forms/input-valueasdate-datetime.html: Added.
- fast/forms/input-valueasdate-datetimelocal-expected.txt: Added.
- fast/forms/input-valueasdate-datetimelocal.html: Added.
- fast/forms/input-valueasdate-month-expected.txt: Added.
- fast/forms/input-valueasdate-month.html: Added.
- fast/forms/input-valueasdate-time-expected.txt: Added.
- fast/forms/input-valueasdate-time.html: Added.
- fast/forms/input-valueasdate-week-expected.txt: Added.
- fast/forms/input-valueasdate-week.html: Added.
- fast/forms/script-tests/input-valueasdate-date.js: Added.
- fast/forms/script-tests/input-valueasdate-datetime.js: Added.
- fast/forms/script-tests/input-valueasdate-datetimelocal.js: Added.
- fast/forms/script-tests/input-valueasdate-month.js: Added.
- fast/forms/script-tests/input-valueasdate-time.js: Added.
- fast/forms/script-tests/input-valueasdate-week.js: Added.
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
Expose dateToDaysFrom1970().
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/DateMath.cpp: (WTF::dateToDaysFrom1970):
- wtf/DateMath.h:
- 12:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:00 AM Changeset in webkit [52523] by
-
- 3 edits in trunk/WebKitTools
2009-12-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[bzt] Don't call create-patch twice during post-diff
https://bugs.webkit.org/show_bug.cgi?id=32893
If we call create-patch to get the bug number, cache the diff in the
state so we don't need to call it again.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/upload.py:
Dec 22, 2009:
- 11:54 PM Changeset in webkit [52522] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Fixes an issue in builtDylibPathForName so that it returns the correct
path to the built QtWebKit library on the Qt Windows port. Currently,
it returns the path to the file named QtWebKit.dll but this file does
not exist on the Qt Windows build. Instead, the file is named
QtWebKit4.dll.
- Scripts/webkitdirs.pm:
- 11:28 PM Changeset in webkit [52521] by
-
- 6 edits in trunk/WebCore
2009-12-22 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Renames enums in RenderStyleConstants::EListStyleType to conform to
the WebKit Code Style Guidelines.
No functionality was changed. So, no new tests.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EListStyleType):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
- rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialListStyleType):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 10:08 PM Changeset in webkit [52520] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Adam Roben.
Remove the only dependency on perl-libwin32 in cygwin
- Scripts/num-cpus:
- 7:59 PM Changeset in webkit [52519] by
-
- 2 edits in trunk/WebCore
2009-12-22 James Su <suzhe@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Keyboard shortcut in dropdown not working.
https://bugs.webkit.org/show_bug.cgi?id=32008
Consider PlatformKeyboardEvent::Char type event as character type
event on all platforms. It fixes the "type ahead find" feature
of the popup listbox on Linux and Mac platforms.
Merge the case-sensitive type ahead find fix from
WebCore/dom/SelectElement.cpp. See
https://bugs.webkit.org/show_bug.cgi?id=29103
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent):
- 7:52 PM QtWebKitBackportingFixes edited by
- (diff)
- 6:26 PM Changeset in webkit [52518] by
-
- 2 edits in trunk/WebCore
2009-12-22 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Eric Seidel.
[Qt] The "Search" input type is not rendered correctly when styled.
https://bugs.webkit.org/show_bug.cgi?id=32417
There are no new tests because only pixel tests may be affected by
this change and those changes can only be done on the build bot.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSearchField): Since currently we paint the Search control as a QLineEdit, I have deferred painting to WebCore, as in the case of the text input so that the painting is consistent.
- 6:19 PM Changeset in webkit [52517] by
-
- 3 edits3 adds in trunk
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888
- fast/canvas/webgl/bug-32888-expected.txt: Added.
- fast/canvas/webgl/bug-32888.html: Added.
- fast/canvas/webgl/resources/bug-32888-texture.png: Added.
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888
Test: fast/canvas/webgl/bug-32888.html (works in Safari / DumpRenderTree)
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D):
- 6:11 PM Changeset in webkit [52516] by
-
- 3 edits in trunk/WebCore
2009-12-22 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=32121
[Qt] implement ImageDecoderQt::clearFrameBufferCache().
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::initializeDecoder): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::clearFrameBufferCache):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:04 PM Changeset in webkit [52515] by
-
- 2 edits in trunk/WebCore
2009-12-22 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Eric Seidel.
Fix assert failure with WML pages having 'Refresh' task in
'onenterforward' event.
Writing Layout test is not possible. Please refer to the discussion
in bug id #30989. A sample test case is attached in BugZilla.
- wml/WMLCardElement.cpp: (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- 5:34 PM Changeset in webkit [52514] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-22 Adam Langley <agl@google.com>
Build fix: not reviewed.
r52504 (https://bugs.webkit.org/show_bug.cgi?id=32845) broke the
Chromium build on Windows and Mac due to a misplaced #endif. The
buildbot didn't find the problem because it runs on Linux.
Have verified this patch with the author of the above.
- src/GraphicsContext3D.cpp:
- 5:20 PM Changeset in webkit [52513] by
-
- 5 edits in trunk/LayoutTests
Removed DataGrid from results.
- fast/dom/Window/window-properties-expected.txt: Removed DataGrid classes.
- fast/dom/prototype-inheritance-2-expected.txt: Ditto.
- fast/dom/prototype-inheritance-expected.txt: Ditto.
- fast/js/global-constructors-expected.txt: Ditto.
- 5:18 PM Changeset in webkit [52512] by
-
- 1 edit4 moves in trunk/LayoutTests
Disabled DataGrid tests.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-basic.html.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom.html.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html.
- 4:49 PM Changeset in webkit [52511] by
-
- 3 edits4 adds in trunk
ASSERTION FAILED: m_numNodeListCaches
https://bugs.webkit.org/show_bug.cgi?id=19526
<rdar://problem/7431572>
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/NodeList/adoptNode-node-list-cache.html
- dom/Node.cpp:
(WebCore::Node::setDocument): Call removeNodeListCache on the old
document and addNodeListCache on the new one if moving a node that
has node lists.
LayoutTests:
- fast/dom/NodeList/adoptNode-node-list-cache-expected.txt: Added.
- fast/dom/NodeList/adoptNode-node-list-cache.html: Added.
- fast/dom/NodeList/resources: Added.
- fast/dom/NodeList/resources/adoptNode-node-list-cache-subframe.html: Added.
- 4:48 PM Changeset in webkit [52510] by
-
- 2 edits in trunk/WebKit/win
Another try at fixing Windows build.
- WebKitPrefix.cpp: Touch it.
- 4:36 PM EFLWebKit edited by
- (diff)
- 4:26 PM Changeset in webkit [52509] by
-
- 2 edits in trunk/WebCore
First cut at fixing Windows build.
- WebCorePrefix.cpp: Touch it.
- 3:59 PM Changeset in webkit [52508] by
-
- 2 edits in trunk/WebKitTools
- pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
generated ".pyc" files.
- 3:53 PM Changeset in webkit [52507] by
-
- 13 edits in trunk
Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
WebCore:
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
- WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
- WebCore.vcproj/build-generated-files.sh: Ditto.
- page/DOMWindow.idl: Sorted things here to touch the file to give
the Windows build a slightly better chance of success.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
WebKit/win:
- WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
WebKitTools:
- Scripts/build-webkit: Turn off datagrid by default.
- 3:50 PM Changeset in webkit [52506] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream platform-specific variant of
plugins/get-url-with-blank-target.html . There is some uncertainty
over which behavior is correct - Chromium's and Safari/Win in this
test, or Safari/Mac in the generic test. See
https://bugs.webkit.org/show_bug.cgi?id=32886 for the bug to converge
the two.
This patch is bug https://bugs.webkit.org/show_bug.cgi?32762 .
- platform/chromium/plugins/get-url-with-blank-target-expected.txt: Added.
- platform/chromium/plugins/get-url-with-blank-target.html: Added.
- 3:35 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:31 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:19 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:12 PM Changeset in webkit [52505] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream a bunch of forms tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32755
- fast/forms/basic-selects.html: Added.
- fast/forms/basic-textareas-quirks.html: Added.
- fast/forms/document-write-empty-expected.txt: Added.
- fast/forms/document-write-empty.html: Added.
- fast/forms/form-action-expected.txt: Added.
- fast/forms/form-action.html: Added.
- fast/forms/lazy-event-listener-scope-chain-expected.txt: Added.
- fast/forms/lazy-event-listener-scope-chain.html: Added.
- fast/forms/resources/logo.gif: Added.
- fast/forms/selected-index-value-expected.txt: Added.
- fast/forms/selected-index-value.html: Added.
- fast/forms/style-display-none-expected.txt: Added.
- fast/forms/style-display-none.html: Added.
- platform/mac/fast/forms/basic-selects-expected.checksum: Added.
- platform/mac/fast/forms/basic-selects-expected.png: Added.
- platform/mac/fast/forms/basic-selects-expected.txt: Added.
- platform/mac/fast/forms/basic-textareas-quirks-expected.checksum:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- 3:00 PM Changeset in webkit [52504] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] WebGL crashes intermittently on Linux
https://bugs.webkit.org/show_bug.cgi?id=32845
The dlclose'ing of libGL.so.1 and dlopen'ing of it each time a
GraphicsContext3D was created was occasionally causing it to be
re-mapped at a different base address. Since GLEW is not
re-initialized every time, primarily for performance reasons, its
cached function pointers were pointing to garbage. Stopped closing
and re-opening libGL.so.1 each time; now it is loaded lazily, when
the first 3D context is created. Also reused the X display
connection since the GLX routines' correctness might hinge upon it
not resulting in a change of GL implementation.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::tryLoad): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
- 2:33 PM Changeset in webkit [52503] by
-
- 3 edits1 copy in trunk/JavaScriptCore
2009-12-22 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Updates Android's scheduleDispatchFunctionsOnMainThread() to use new
AndroidThreading class, rather than using JavaSharedClient directly.
This fixes the current layering violation.
https://bugs.webkit.org/show_bug.cgi?id=32651
The pattern is copied from Chromium, which uses the ChromiumThreading
class. This patch also fixes the style in ChromiumThreading.h.
- wtf/android/AndroidThreading.h: Added. Declares AndroidThreading.
- wtf/android/MainThreadAndroid.cpp: Modified (WTF::scheduleDispatchFunctionsOnMainThread): Uses AndroidThreading.
- wtf/chromium/ChromiumThreading.h: Modified. Fixes style.
- 2:26 PM Changeset in webkit [52502] by
-
- 4 edits16 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741
- platform/chromium/fast/dom/interval-expected.txt: Added.
- platform/chromium/fast/dom/interval.html: Added.
- 2:18 PM Changeset in webkit [52501] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
validate-committer-lists fails when run from an SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=31974
- Scripts/validate-committer-lists:
- Make it print a warning message instead of throwing an exception when running from an SVN checkout.
- 2:05 PM Changeset in webkit [52500] by
-
- 3 edits in trunk/JavaScriptCore
Fix a couple of problems with UntypedPtrAndBitfield.
Reviewed by Sam Weinig.
Add a m_leaksPtr to reduce false positives from leaks in debug builds
(this isn't perfect because we'd like a solution for release builds,
but this is now at least as good as a PtrAndFlags would be).
Switch SmallStringsto use a regular string for the base, rather than
a static one. UntypedPtrAndBitfield assumes all strings are at least
8 byte aligned; this migt not be true of static strings. Shared buffers
are heap allocated, as are all UStringImpls other than static strings.
Static strings cannot end up being the owner string of substrings,
since the only static strings are length 0.
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UStringImpl::UStringImpl):
- 1:59 PM Changeset in webkit [52499] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Dan Bernstein.
- page/FrameView.h: Removed incorrect comment.
- 1:47 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:44 PM Changeset in webkit [52498] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741
- platform/chromium/fast/dom/interval-expected.txt: Added.
- platform/chromium/fast/dom/interval.html: Added.
- 1:42 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:40 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:36 PM Changeset in webkit [52497] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Attempting to upstream xss-inactive-closure test from the Chromium
test suite. https://bugs.webkit.org/show_bug.cgi?id=32691 .
- http/tests/security/listener/resources/xss-inactive-closure-child-2.html: Added.
- http/tests/security/listener/resources/xss-inactive-closure-child.html: Added.
- http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
- http/tests/security/listener/xss-inactive-closure.html: Added.
- 1:18 PM Changeset in webkit [52496] by
-
- 3 edits in trunk/WebKitTools
2009-12-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Adam Barth.
check-webkit-style should not warn about NULL usage in g_object_{get,set}
https://bugs.webkit.org/show_bug.cgi?id=32858
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 12:09 PM Changeset in webkit [52495] by
-
- 9 edits in trunk
2009-12-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simplify highlighter definition.
WebCore:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: (WebInspector.CSSSourceSyntaxHighlighter):
- inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: (WebInspector.JavaScriptSourceSyntaxHighlighter.): (WebInspector.JavaScriptSourceSyntaxHighlighter):
- inspector/front-end/SourceSyntaxHighlighter.js: (WebInspector.SourceSyntaxHighlighter.prototype.lex):
- inspector/front-end/utilities.js: ():
LayoutTests:
- inspector/syntax-highlight-css-expected.txt:
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
- 11:26 AM Changeset in webkit [52494] by
-
- 7 edits2 adds in trunk
Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974
Reviewed by Sam Weinig.
WebCore:
Test: fast/forms/selection-layout-reentry-strange-case.html
Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.
- editing/SelectionController.h: Added setNeedsDisplayUpdate,
needsDisplayUpdate, and m_needsDisplayUpdate.
- page/Frame.cpp:
(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function.
- page/FrameView.cpp:
(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
- fast/forms/selection-layout-reentry-strange-case.html: Added.
- platform/mac/accessibility/frame-with-title-expected.txt: Updated since
the number of layouts is now different.
- 11:17 AM QtWebKitPerformanceWork edited by
- Added WebKit and Git prerequisite (diff)
- 11:17 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:58 AM Changeset in webkit [52493] by
-
- 2 edits1 add in trunk/JavaScriptCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
RVCT (ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp
https://bugs.webkit.org/show_bug.cgi?id=32857
Add implementation of strcasecmp and strncasecmp for RVCT < 4.0
because earlier versions of RVCT 4.0 does not provide these functions.
- wtf/StringExtras.cpp: Added. (strcasecmp): (strncasecmp):
- wtf/StringExtras.h:
- 10:51 AM Changeset in webkit [52492] by
-
- 2 edits in trunk/WebCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Allocate RemoteFontStream on the heap
https://bugs.webkit.org/show_bug.cgi?id=32850
RemoteFontStream is allocated on the stack, so its memory is freed
immediately when FontCustomPlatformData::createFontCustomPlatformData
returns.
SkTypeface::CreateFromStream increments the reference count, but it keeps
the pointer to the memory allocated on the stack which is not valid
anymore.
RemoteFontStream is a descendant of SkRefCount and SkRefCount::unref
invokes SkDELETE(this) internally once the reference count reaches zero.
This means that SkRefCount-ed instances must be allocated on the heap.
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
- 10:43 AM Changeset in webkit [52491] by
-
- 2 edits in trunk/WebCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
when condition COMPILER(RVCT) is fulfilled, we are trying to free a pointer to array allocated on the stack
https://bugs.webkit.org/show_bug.cgi?id=32861
Don't free the pointer for COMPILER(RVCT).
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 10:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:36 AM Changeset in webkit [52490] by
-
- 3 edits in trunk/JavaScriptCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to forceinline for RVCT
https://bugs.webkit.org/show_bug.cgi?id=32853
Use forceinline forces RVCT to compile a C or C++ function
inline. The compiler attempts to inline the function, regardless of
the characteristics of the function.
- wtf/AlwaysInline.h:
- wtf/FastMalloc.h:
- 10:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:28 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:05 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:40 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:39 AM Changeset in webkit [52489] by
-
- 8 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Remove no longer necessary experimental single view #ifdefs from Widget and
ScrollView.
- page/Chrome.h:
- page/mac/ChromeMac.mm:
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/Widget.cpp:
- platform/Widget.h:
- platform/mac/ScrollViewMac.mm:
- platform/mac/WidgetMac.mm:
- 9:33 AM Changeset in webkit [52488] by
-
- 5 edits in trunk/WebKit/chromium
2009-12-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
autoComplete and getElementById methods for WebKit API
- public/WebDocument.h:
- public/WebInputElement.h:
- src/WebDocument.cpp: (WebKit::WebDocument::getElementById):
- src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete):
- 9:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:21 AM Changeset in webkit [52487] by
-
- 4 edits in trunk/WebCore
2009-12-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not lose original request for non-main resource redirects.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::appendRedirect):
- inspector/front-end/Resource.js: (WebInspector.Resource):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 5:13 AM Changeset in webkit [52486] by
-
- 5 edits1 move in trunk
Rubber-stamped by Holger Freyther.
.:
Adjusted path to QtLauncher.
- WebKit.pro:
WebKit/qt:
Moved QtLauncher to WebKitTools/
- QtLauncher: Removed.
- QtLauncher/QtLauncher.pro: Removed.
- QtLauncher/main.cpp: Removed.
WebKitTools:
Moved QtLauncher from WebKit/qt.
- QtLauncher: Copied from WebKit/qt/QtLauncher.
- QtLauncher/QtLauncher.pro:
Dec 21, 2009:
- 11:46 PM Changeset in webkit [52485] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip layoutTestController.notifyDone() related test until fix.
https://bugs.webkit.org/show_bug.cgi?id=31626
- platform/qt/Skipped: http/tests/misc/set-window-opener-to-null.html added.
- 11:04 PM Changeset in webkit [52484] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream chrome/fast/events/iframe-onload-remove-self-no-crash.html .
https://bugs.webkit.org/show_bug.cgi?id=32742 .
- fast/frames/iframe-onload-remove-self-no-crash-expected.txt: Added.
- fast/frames/iframe-onload-remove-self-no-crash.html: Added.
- fast/frames/resources/iframe-onload-remove-self-no-crash-child.html: Added.
- fast/frames/resources/iframe-onload-remove-self-no-crash.js: Added. (onWindowLoad):
- 10:57 PM Changeset in webkit [52483] by
-
- 3 edits in trunk/WebCore
2009-12-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use ASSERT instead of assert in image-decoders
https://bugs.webkit.org/show_bug.cgi?id=32852
Other decoders use WTF's ASSERT macro.
Follow this convention.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
- 10:54 PM Changeset in webkit [52482] by
-
- 2 edits in trunk/JavaScriptCore
Prospective GTK build fix: Add UStringImpl.cpp/h to the build.
- GNUmakefile.am:
- 10:53 PM Changeset in webkit [52481] by
-
- 2 edits in trunk/JavaScriptCore
Fix the Qt build, add UStringImpl.cpp to the build.
- JavaScriptCore.pri:
- 10:46 PM Changeset in webkit [52480] by
-
- 7 edits1 copy in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Automate the process of calling prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=32816
This patch automates the process of creating a bug and patch and
uploading it to bugzilla. The first cut just calls
prepare-ChangeLog.
This patch required some refactoring of upload.py to the Step
model, but that's worth doing anyway.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:44 PM Changeset in webkit [52479] by
-
- 2 edits in trunk/WebCore
2009-12-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use vsnprintf instead of vasprintf for RVCT.
https://bugs.webkit.org/show_bug.cgi?id=32851
RVCT does not support vasprint, so use vsnprintf instead.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 8:47 PM Changeset in webkit [52478] by
-
- 6 edits in trunk
2009-12-21 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
- websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
- websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80
- websocket/tests/url-parsing-expected.txt:
2009-12-21 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.
- websockets/WebSocket.cpp: (WebCore::encodeProtocolString): (WebCore::WebSocket::connect):
- 8:31 PM Changeset in webkit [52477] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstream a test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32761
- http/tests/misc/resources/content-iframe.html: Added.
- http/tests/misc/set-window-opener-to-null-expected.txt: Added.
- http/tests/misc/set-window-opener-to-null.html: Added.
- 7:36 PM Changeset in webkit [52476] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix for Windows Debug, if this breaks Release I will roll it out.
- 7:01 PM Changeset in webkit [52475] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Should be final part of the Windows build fix.
- 7:00 PM Changeset in webkit [52474] by
-
- 2 edits in trunk/WebKit/mac
Don't allocate a WebGeolocationControllerClient unless that compile-time setting is enabled.
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
- 6:49 PM Changeset in webkit [52473] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Reviewed by Samuel Weinig.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 6:41 PM Changeset in webkit [52472] by
-
- 3 edits in trunk
Hopefully closer to a build fix. JavaScriptCore will build now.
- 6:25 PM Changeset in webkit [52471] by
-
- 2 edits in trunk/JavaScriptCore
Windows Build fix part 5.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 6:04 PM Changeset in webkit [52470] by
-
- 2 edits in trunk/JavaScriptCore
Fix breakage of world introduced in build fix to r52463.
Reviewed by NOBODY (build fix).
- runtime/UStringImpl.h:
- 6:03 PM Changeset in webkit [52469] by
-
- 2 edits in trunk/WebCore
Make sure that we check for the right thread.
Reviewed by Sam Weinig.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- 5:35 PM QtWebKitPerformanceWork edited by
- Change formatting to outline mode (diff)
- 5:31 PM QtWebKitPerformanceWork edited by
- Add section Common Windows Errors and describe port 80 already in use error (diff)
- 5:28 PM Changeset in webkit [52468] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #4
- 5:21 PM Changeset in webkit [52467] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #3
- 5:08 PM Changeset in webkit [52466] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #2
- 4:57 PM Changeset in webkit [52465] by
-
- 5 edits in trunk
WebCore: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843
Reviewed by Maciej Stachowiak.
The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843
Reviewed by Maciej Stachowiak.
The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.
- editing/execCommand/indent-with-style2-expected.txt:
- editing/execCommand/indent-with-style2.html:
- 4:53 PM Changeset in webkit [52464] by
-
- 1 edit in trunk/JavaScriptCore/runtime/UStringImpl.h
unreviewed windows build fix #1
- 4:47 PM QtWebKitPerformanceWork edited by
- Rewrote the sentence that starts "When starting the 'http_server'...", … (diff)
- 4:41 PM QtWebKitPerformanceWork edited by
- Added section Prerequisites to mention (diff)
- 4:38 PM Changeset in webkit [52463] by
-
- 10 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=32831
Replace UString::Rep implementation, following introduction of ropes to JSC.
Reviewed by Darin Adler.
- Remove redundant overcapacity mechanisms.
- Reduce memory cost of Rep's.
- Add an inline storage mechanism akin to that in WebCore's StringImpl.
~1% Sunspider progression.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::createRep):
(JSC::UString::createFromUTF8):
(JSC::UString::createUninitialized):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::ascii):
(JSC::UString::operator=):
(JSC::UString::toStrictUInt32):
(JSC::equal):
- runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::cost):
(JSC::makeString):
- runtime/UStringImpl.cpp: Added.
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::destroy):
(JSC::UStringImpl::computeHash):
- runtime/UStringImpl.h: Added.
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createCopying):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::size):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::computedHash):
(JSC::UStringImpl::setHash):
(JSC::UStringImpl::identifierTable):
(JSC::UStringImpl::setIdentifierTable):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::allocChars):
(JSC::UStringImpl::copyChars):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::null):
(JSC::UStringImpl::empty):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::operator new):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
JavaScriptGlue:
- ForwardingHeaders/wtf/PossiblyNull.h: Added.
- add forwarding header.
WebCore:
- ForwardingHeaders/runtime/UStringImpl.h: Added.
- add forwarding header.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::ustring):
- order of arguments to UString::Rep constructor for shared strings changed.
- 3:50 PM Changeset in webkit [52462] by
-
- 1 edit16 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstream a bunch of platform-specific Chromium plugin tests.
https://bugs.webkit.org/show_bug.cgi?id=32751
- platform/chromium/plugins/call-as-function-expected.txt: Added.
- platform/chromium/plugins/call-as-function.html: Added.
- platform/chromium/plugins/get-url-with-iframe-target-no-crash-expected.txt: Added.
- platform/chromium/plugins/get-url-with-iframe-target-no-crash.html: Added.
- platform/chromium/plugins/multiple-plugins-expected.txt: Added.
- platform/chromium/plugins/multiple-plugins.html: Added.
- platform/chromium/plugins/nested-plugin-objects-expected.txt: Added.
- platform/chromium/plugins/nested-plugin-objects.html: Added.
- platform/chromium/plugins/refcount-leaks-expected.txt: Added.
- platform/chromium/plugins/refcount-leaks.html: Added.
- platform/chromium/plugins/return-npobject-expected.txt: Added.
- platform/chromium/plugins/return-npobject.html: Added.
- platform/chromium/plugins/script-object-invoke-expected.txt: Added.
- platform/chromium/plugins/script-object-invoke.html: Added.
- 3:42 PM Changeset in webkit [52461] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test to ensure we handle variations on "javascript:" URL
correctly.
- fast/dom/xss-DENIED-javascript-variations-expected.txt: Added.
- fast/dom/xss-DENIED-javascript-variations.html: Added.
- 3:39 PM Changeset in webkit [52460] by
-
- 5 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Reviewed by Samuel Weinig.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:15 PM Changeset in webkit [52459] by
-
- 66 edits1 add in trunk/WebCore
2009-12-18 Nate Chapin <Nate Chapin>
Reviewed by Adam barth.
Generate V8 bindings non-constructor callback declarations
in CodeGeneratorV8.pm instead of manually declaring them in
V8CustomBinding.h.
- 3:00 PM Changeset in webkit [52458] by
-
- 1 edit5 deletes in trunk/LayoutTests
2009-12-21 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Cleared instead of deleted some layout test files, making them fail. Delete them for real.
- http/tests/navigation/image-load-in-beforeunload-handler-expected.txt: Removed.
- http/tests/navigation/image-load-in-beforeunload-handler.html: Removed.
- http/tests/navigation/image-load-in-unload-handler-expected.txt: Removed.
- http/tests/navigation/image-load-in-unload-handler.html: Removed.
- http/tests/navigation/resources/wait-then-notify-done.html: Removed.
- 2:52 PM Changeset in webkit [52457] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Did a rename, so checking in the
version of the script I used.
- 2:39 PM Changeset in webkit [52456] by
-
- 15 edits in trunk
2009-12-21 Nate Chapin <Nate Chapin>
Rubber-stamped by Darin Adler.
Revert r52446 due to crashiness.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::pageHidden):
- loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame):
- loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
- loader/Request.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
- 2:12 PM Changeset in webkit [52455] by
-
- 3 edits in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update status-bubble to show all the queues
https://bugs.webkit.org/show_bug.cgi?id=32838
Also, move statusbubble over to use memcache.
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/templates/statusbubble.html:
- 1:26 PM Changeset in webkit [52454] by
-
- 5 edits in trunk/WebCore
Add support for V8 Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32699
Patch by Kent Tamura <tkent@chromium.org> on 2009-12-19
Reviewed by Adam Barth.
This implements the same behavior as the recent change of
CodeGeneratorJS.pm and JSDOMBinding.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Produce toWebCoreDate() or v8DateOrNull() for Date type.
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreDate):
Converts a JavaScript object to a double representing Date.
(WebCore::v8DateOrNull):
Converts a double representing Date to a JavaScript Date object or null.
- bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
- html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.
- 12:19 PM Changeset in webkit [52453] by
-
- 3 edits1 copy1 add in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete the boring "Empty queue" status messages in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=32818
- QueueStatusServer/app.yaml:
- QueueStatusServer/cron.yaml:
- QueueStatusServer/handlers/gc.py:
- QueueStatusServer/main.py:
- 12:18 PM Changeset in webkit [52452] by
-
- 2 edits in trunk/WebKit/qt
Doc: Minor fixes to language.
Patch by David Boddie <dboddie@trolltech.com> on 2009-12-21
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
- 12:15 PM Changeset in webkit [52451] by
-
- 5 edits in trunk/WebCore
Renamed m_sel to m_selection. Used do-webcore-rename.
Reviewed by Mark Rowe.
- editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::willBeModified):
(WebCore::SelectionController::directionOfEnclosingBlock):
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingLeft):
(WebCore::SelectionController::modifyMovingBackward):
(WebCore::SelectionController::modify):
(WebCore::SelectionController::expandUsingGranularity):
(WebCore::SelectionController::xPosForVerticalArrowNavigation):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
(WebCore::SelectionController::layout):
(WebCore::SelectionController::caretRenderer):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
(WebCore::SelectionController::debugRenderer):
(WebCore::SelectionController::contains):
(WebCore::SelectionController::selectAll):
(WebCore::SelectionController::formatForDebugger):
(WebCore::SelectionController::showTreeForThis):
- editing/SelectionController.h:
- editing/gtk/SelectionControllerGtk.cpp:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Let the script do its thing. Made sure no tests broke.
- 12:11 PM Changeset in webkit [52450] by
-
- 4 edits in trunk/WebCore
2009-12-21 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type.
https://bugs.webkit.org/show_bug.cgi?id=31814
No new tests because there are no functional changes in this patch.
- rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::computeCountInParent): (WebCore::showTreeAndMark):
- rendering/RenderCounter.cpp: (WebCore::planCounter): (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText): Changed to use identifier instead of counterName and actsAsReset or hasResetType, as appropriate instead of isReset.
- rendering/CounterNode.h: (WebCore::CounterNode::actsAsReset): (WebCore::CounterNode::hasResetType):
- 12:00 PM Changeset in webkit [52449] by
-
- 8 edits in trunk
2009-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler and Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This patch makes SVG Masking faster. The luminance calculaton of the ImageBuffer,
that is created by pixel manipulation, got optimized. The ImageBuffer and it's
luminance is created once now, not on every call of applyMask.
The size of the intermediate ImageBuffer depends on the visible area now and is
clipped by the mask rect.
The patch doesn't change functionality so no new tests needed.
The new ImageBuffer handling in Mask causes two updates of test results. The pixel
tests and LayoutTests pass, but the checksum doesn't match.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
2009-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler and Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
Update pixel test results for two SVG masking operations. They don't fail
and there is no noticable difference between the old and new results. But
Masking uses smaller ImageBuffers now and that changed the checksum.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- 10:58 AM Changeset in webkit [52448] by
-
- 5 edits2 adds in trunk
2009-12-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Test that dragging an SVG as <img> doesn't crash the browser.
Note that this only works in debug mode as it's a failing assert.
- fast/images/drag-svg-as-image.html: Added.
- platform/qt/Skipped: fast/images/drag-svg-as-image.html added.
2009-12-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Fix assertion failure when dragging an SVG image.
https://bugs.webkit.org/show_bug.cgi?id=32511
Test: fast/images/drag-svg-as-image.html
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::filenameExtension): Return "svg"
- svg/graphics/SVGImage.h:
- 9:58 AM Changeset in webkit [52447] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661
Removed useless calls to the G_OBJECT() macro and replaced NULL
occurences with a SENTINEL macro.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- 9:51 AM UsingGitWithWebKit edited by
- Explain why one might want to "track the Subversion repository" (diff)
- 8:55 AM Changeset in webkit [52446] by
-
- 10 edits5 adds in trunk
2009-12-21 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
If an image load is started during an unload or beforeunload event, run it
asynchronously (and allow it to outlive its page) so navigation can continue
while the load completes.
Tests: http/tests/navigation/image-load-in-beforeunload-handler.html
http/tests/navigation/image-load-in-unload-handler.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp: Rename m_unloadEventBeingDispatched to m_isDispatchingUnloadEvent. (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Set m_isDispatchingBeforeUnloadEvent. (WebCore::FrameLoader::pageHidden):
- loader/FrameLoader.h: (WebCore::FrameLoader::isDispatchingUnloadFamilyEvent): Added.
- loader/Request.cpp: (WebCore::Request::Request): Add OutlivePagePolicy to constructor parameters
- loader/Request.h: (WebCore::): Add OutlivePagePolicy enum. (WebCore::Request::shouldOutlivePage): Added. (WebCore::Request::frame): Added.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Change one of the security checks to an outlive page check.
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): Add OutlivePagePolicy to Request constructor call,
ensure requests that should outlive page are done asynchronously.
(WebCore::Loader::cancelRequests): Remove ending ASSERT since it will now be hard to predict how
many requests might possibly outlive a cancel in every case.
(WebCore::Loader::Host::servePendingRequests): Use the correct frame in the case of a request outliving its page.
(WebCore::Loader::Host::cancelPendingRequests): Ensure we don't cancel request that should outlive their page.
(WebCore::Loader::Host::cancelRequests): Ensure we don't cancel request that should outlive their page.
- 8:34 AM Changeset in webkit [52445] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Xan Lopez.
- platform/gtk/Skipped: Unskip test fixed by patch from Bug 24001.
- 7:06 AM Changeset in webkit [52444] by
-
- 18 edits13 copies10 moves9 adds7 deletes in trunk/WebKit/qt
[Qt] Clean up the WebKit layer unit-tests
Reviewed by Simon Hausmann.
- Use tests.pri for common options
- Standardize file naming
- Move all resources to 'resources' subdir
- Standardize how TESTS_SOURCE_DIR is used
- Get rid of UID3 for symbian (autogenerated)
- Don't build app bundles on Mac OS X
- tests/benchmarks/loading/loading.pro: Added.
- tests/benchmarks/loading/tst_loading.pro: Removed.
- tests/benchmarks/painting/painting.pro: Added.
- tests/benchmarks/painting/tst_painting.pro: Removed.
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebelement/qwebelement.qrc: Removed.
- tests/qwebelement/resources/image.png: Renamed from WebKit/qt/tests/qwebelement/image.png.
- tests/qwebelement/resources/style.css: Renamed from WebKit/qt/tests/qwebelement/style.css.
- tests/qwebelement/resources/style2.css: Renamed from WebKit/qt/tests/qwebelement/style2.css.
- tests/qwebelement/tst_qwebelement.qrc: Added.
- tests/qwebframe/qwebframe.pro:
- tests/qwebframe/qwebframe.qrc: Removed.
- tests/qwebframe/resources/image.png: Renamed from WebKit/qt/tests/qwebframe/image.png.
- tests/qwebframe/resources/style.css: Renamed from WebKit/qt/tests/qwebframe/style.css.
- tests/qwebframe/resources/test1.html: Renamed from WebKit/qt/tests/qwebframe/test1.html.
- tests/qwebframe/resources/test2.html: Renamed from WebKit/qt/tests/qwebframe/test2.html.
- tests/qwebframe/resources/testiframe.html: Renamed from WebKit/qt/tests/qwebframe/testiframe.html.
- tests/qwebframe/resources/testiframe2.html: Renamed from WebKit/qt/tests/qwebframe/testiframe2.html.
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebframe/tst_qwebframe.qrc: Added.
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistory/resources/page1.html: Renamed from WebKit/qt/tests/qwebhistory/data/page1.html.
- tests/qwebhistory/resources/page2.html: Renamed from WebKit/qt/tests/qwebhistory/data/page2.html.
- tests/qwebhistory/resources/page3.html: Renamed from WebKit/qt/tests/qwebhistory/data/page3.html.
- tests/qwebhistory/resources/page4.html: Renamed from WebKit/qt/tests/qwebhistory/data/page4.html.
- tests/qwebhistory/resources/page5.html: Renamed from WebKit/qt/tests/qwebhistory/data/page5.html.
- tests/qwebhistory/resources/page6.html: Renamed from WebKit/qt/tests/qwebhistory/data/page6.html.
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::):
- tests/qwebhistory/tst_qwebhistory.qrc:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebpage/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebpage/frametest/frame_a.html.
- tests/qwebpage/resources/iframe.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe.html.
- tests/qwebpage/resources/iframe2.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe2.html.
- tests/qwebpage/resources/iframe3.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe3.html.
- tests/qwebpage/resources/index.html: Renamed from WebKit/qt/tests/qwebpage/frametest/index.html.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::backActionUpdate):
(tst_QWebPage::frameAt):
(tst_QWebPage::errorPageExtensionInFrameset):
(tst_QWebPage::screenshot):
- tests/qwebpage/tst_qwebpage.qrc:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
- tests/qwebview/qwebview.pro:
- tests/qwebview/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebview/data/frame_a.html.
- tests/qwebview/resources/index.html: Renamed from WebKit/qt/tests/qwebview/data/index.html.
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::reusePage):
(tst_QWebView::crashTests):
- tests/qwebview/tst_qwebview.qrc:
- tests/resources/image2.png: Renamed from WebKit/qt/tests/qwebframe/resources/image2.png.
- tests/tests.pri: Added.
- tests/tests.pro:
- 6:44 AM Changeset in webkit [52443] by
-
- 2 edits in trunk/WebKit/win
Fix non-ACCELERATED_COMPOSITING builds
- WebPreferences.cpp:
(WebPreferences::acceleratedCompositingEnabled): Guard use of
WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
- 6:36 AM Changeset in webkit [52442] by
-
- 7 edits in trunk/WebKit/win
Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
Fixes <http://webkit.org/b/32745>.
Reviewed by Ada Chan.
- Interfaces/IWebPreferencesPrivate.idl: Added
[set]AcceleratedCompositingEnabled.
- Interfaces/WebKit.idl: Touched to force a build.
- WebPreferenceKeysPrivate.h: Added
WebKitAcceleratedCompositingEnabledPreferenceKey.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Make accelerated
compositing be on by default.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.
- WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.
- 6:36 AM Changeset in webkit [52441] by
-
- 2 edits in trunk/WebCore
Fix Windows build warnings
- WebCore.vcproj/WebCore.vcproj: Exclude SVG files from the build that
are compiled via SVGAllInOne.cpp.
- 3:10 AM Changeset in webkit [52440] by
-
- 4 edits in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Can’t copy outer html of selected node.
Also adds "Copy as HTML" context menu item.
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/inspector.js: (WebInspector.documentCanCopy):
- 3:00 AM Changeset in webkit [52439] by
-
- 6 edits3 adds in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Eric Seidel.
Web Inspector: extract syntax highlighters into separate files.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: Added. (WebInspector.CSSSourceSyntaxHighlighter):
- inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Added. (WebInspector.JavaScriptSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter.):
- inspector/front-end/SourceFrame.js:
- inspector/front-end/SourceSyntaxHighlighter.js: Added. (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.createSpan): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:48 AM Changeset in webkit [52438] by
-
- 3 edits in trunk/WebCore
defersLoading is disabled in current libcURL.
https://bugs.webkit.org/show_bug.cgi?id=32707
Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2009-12-18
Reviewed by Darin Adler.
Basically this change reverts r49577 that was totally wrong.
According to curlver.h, LIBCURL_VERSION_NUM is a
"6-digit (24 bits) hexadecimal number".
The check should be against 0x071200 (7.18) as it was originally the case.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle): Use the right check.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setDefersLoading): Ditto. Also removed a print
to use a LOG_ERROR instead.
- 1:07 AM Changeset in webkit [52437] by
-
- 4 edits in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Exception on queue status server
https://bugs.webkit.org/show_bug.cgi?id=32812
Turns out we need to pass the id to the filter.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/templates/patch.html:
- QueueStatusServer/templates/recentstatus.html:
Dec 20, 2009:
- 11:29 PM Changeset in webkit [52436] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Created "style" folder for code supporting check-webkit-style.
- Scripts/modules/style: Added.
- 11:24 PM Changeset in webkit [52435] by
-
- 3 edits in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: error when running commit-queue
https://bugs.webkit.org/show_bug.cgi?id=32806
Fix typo and add test!
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- 10:20 PM Changeset in webkit [52434] by
-
- 8 edits3 adds in trunk
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
A test for Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
- fast/forms/input-valueasdate-expected.txt: Added.
- fast/forms/input-valueasdate.html: Added.
- fast/forms/script-tests/input-valueasdate.js: Added.
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for JavaScriptCore Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
This is needed for HTMLInputElement::valueAsDate and
HTMLTimeElement::valueAsDate.
A Date instance is mapped to a double value in C++.
- If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
- If a getter C++ function returns NaN or infinity, a JavaScript property returns null.
Test: fast/forms/input-valueasdate.html
- bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
- bindings/js/JSDOMBinding.h: Declare them.
- bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Declare valueAsDate.
- 10:16 PM Changeset in webkit [52433] by
-
- 2 edits in trunk/WebKitSite
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Removed outdated contact information from bug life cycle page.
- quality/lifecycle.html:
- 8:57 PM Changeset in webkit [52432] by
-
- 11 edits in trunk/WebCore
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Introduce the followings:
- ::-webkit-inner-spin-button pseudo CSS selector
- ::-webkit-outer-spin-button pseudo CSS selector
- new appearance type: inner-spin-button
- new appearance type: outer-spin-button
They're going to be used for <input type=number> UI.
https://bugs.webkit.org/show_bug.cgi?id=31821
Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.
The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.
This change has no tests. The following changes with tests will cover.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSValueKeywords.in:
- css/html.css:
- platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
- rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.
- 7:17 PM Changeset in webkit [52431] by
-
- 4 edits in trunk/WebCore
2009-12-20 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML module, due to the changeset #52314.
https://bugs.webkit.org/show_bug.cgi?id=32786
No new tests, this is compilation error fix.
- wml/WMLDocument.cpp:
- wml/WMLPageState.cpp:
- wml/WMLPageState.h:
- 6:57 PM Changeset in webkit [52430] by
-
- 8 edits1 copy1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Optimize status updates for new dashboard
https://bugs.webkit.org/show_bug.cgi?id=32797
This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/early_warning_system_unittest.py: Added.
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py:
- Scripts/modules/commands/queuestest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/patchcollection.py:
- Scripts/modules/queueengine.py:
- Scripts/run-webkit-unittests:
- 6:42 PM Changeset in webkit [52429] by
-
- 3 edits2 adds1 delete in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Prepare QueueStatusServer for new status messages
https://bugs.webkit.org/show_bug.cgi?id=32805
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/index.html: Removed.
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py: Added.
- QueueStatusServer/templates/recentstatus.html: Added.
- 3:51 PM Changeset in webkit [52428] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):
- 2:00 PM QtWebKitAPI edited by
- (diff)
- 12:50 PM Changeset in webkit [52427] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=32775
Reviewed by Mark Rowe.
- inspector/front-end/inspector.css: Use the default monospace family
and size.
- 12:07 PM Changeset in webkit [52426] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Remove emission of signal that does not exist.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):
- 11:31 AM Changeset in webkit [52425] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Provides a new API to copy WebKitWebHistoryItem objects.
- webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_copy):
- webkit/webkitwebhistoryitem.h:
- 10:46 AM Changeset in webkit [52424] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Disable the page cache by default since:
- It was previously off by default.
- There are still some issues when enabling it.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 10:22 AM Changeset in webkit [52423] by
-
- 3 edits in trunk/WebKitTools
2009-12-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 10:07 AM Changeset in webkit [52422] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
- tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):
- 9:39 AM Changeset in webkit [52421] by
-
- 9 edits in trunk/WebCore
2009-12-20 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] Remove more GTK+ and GLib headers from WebCore
https://bugs.webkit.org/show_bug.cgi?id=32795
Remove most GTK+ and GLib includes from WebCore headers.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/gtk/PasteboardHelper.h:
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/ScrollbarGtk.cpp:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/gtk/gtk2drawing.c:
- platform/gtk/gtkdrawing.h:
- 9:06 AM Changeset in webkit [52420] by
-
- 8 edits in trunk
[wx] build fixes after recent changes.
- 8:26 AM Changeset in webkit [52419] by
-
- 5 edits in trunk
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Avoid using fixed values when moving mouse.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Do not increase the click count if we are using a different button.
- DumpRenderTree/gtk/EventSender.cpp:
- 7:53 AM Changeset in webkit [52418] by
-
- 4 edits in trunk/WebKit/gtk
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001
Original patch by Bobby Powers <bobby@laptop.org>
Added new API to specify cache models for GTK port.
- webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.
- 7:45 AM Changeset in webkit [52417] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.
fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html
- platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
- 4:58 AM Changeset in webkit [52416] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Revert the previous patch, it introduces some failures in the
bots.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 4:41 AM Changeset in webkit [52415] by
-
- 7 edits in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Adler.
Web Inspector: Constrain the number of messages the inspector shows.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):
- 4:27 AM Changeset in webkit [52414] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] crash when loading new page
https://bugs.webkit.org/show_bug.cgi?id=32752
Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 4:18 AM Changeset in webkit [52413] by
-
- 3 edits in trunk/LayoutTests
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
- 4:02 AM Changeset in webkit [52412] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.
- WebCoreSupport/DocumentLoaderGtk.cpp:
(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):
- 2:46 AM Changeset in webkit [52411] by
-
- 2 edits in trunk/WebKit/gtk
Rubber-stamped by Xan Lopez.
Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.
- webkit/webkitprivate.cpp:
(webkit_init):
- 2:27 AM Changeset in webkit [52410] by
-
- 1 edit5 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstreaming two plugin tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32750
- plugins/get-file-url-expected.txt: Added.
- plugins/get-file-url.html: Added.
- plugins/get-url-with-iframe-target-expected.txt: Added.
- plugins/get-url-with-iframe-target.html: Added.
- plugins/resources/get-file-url-subframe.html: Added.
- 2:18 AM Changeset in webkit [52409] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
https://bugs.webkit.org/show_bug.cgi?id=32743
- fast/dom/document-clear-expected.txt: Added.
- fast/dom/document-clear.html: Added.
- fast/dom/resources/document-clear.js: Added.
- 2:10 AM Changeset in webkit [52408] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.
- svg/custom/new-image-is-html-element-expected.txt: Added.
- svg/custom/new-image-is-html-element.svg: Added.
- 2:01 AM Changeset in webkit [52407] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@fila-macpro.mtv.corp.google.com>
Reviewed by Darin Adler.
upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.
- fast/text/fake-italic.html: Added.
- platform/mac/fast/text/fake-italic-expected.checksum: Added.
- platform/mac/fast/text/fake-italic-expected.png: Added.
- platform/mac/fast/text/fake-italic-expected.txt: Added.
- 1:52 AM Changeset in webkit [52406] by
-
- 3 edits2 copies in trunk/WebCore
2009-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
https://bugs.webkit.org/show_bug.cgi?id=32559
Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().
No new tests, this is platform code.
- platform/android/PlatformBridge.h:
- platform/network/android/AuthenticationChallenge.h: Added.
- platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
- 1:47 AM Changeset in webkit [52405] by
-
- 7 edits1 copy1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[QueueStatusServer] Add a per-patch details page
https://bugs.webkit.org/show_bug.cgi?id=32784
This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/patch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/patch.html: Added.
- 12:27 AM Changeset in webkit [52404] by
-
- 4 edits1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/model/attachment.py: Added.
Dec 19, 2009:
- 11:48 PM Changeset in webkit [52403] by
-
- 5 edits in trunk/WebCore
2009-12-19 Eric Seidel <eric@webkit.org>
No review, rolling out r52395.
http://trac.webkit.org/changeset/52395
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 11:36 PM Changeset in webkit [52402] by
-
- 6 edits in trunk
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websocket/tests/bad-sub-protocol-expected.txt:
- websocket/tests/script-tests/url-parsing.js:
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 11:22 PM Changeset in webkit [52401] by
-
- 3 edits2 adds in trunk
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a test for window.open and JavaScript URLs.
- http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url.html: Added.
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Added a missing "not".
Test: http/tests/security/xss-DENIED-window-open-javascript-url.html
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- 10:55 PM Changeset in webkit [52400] by
-
- 6 edits2 adds in trunk/WebKitTools
Provide an example implementation for printing under Windows.
http://bugs.webkit.org/show_bug.cgi?id=32504.`
Reviewed by Adam Roben.
- WinLauncher/PrintWebUIDelegate.cpp: Added.
(PrintWebUIDelegate::QueryInterface):
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):
(PrintWebUIDelegate::webViewPrintingMarginRect):
- WinLauncher/PrintWebUIDelegate.h: Added.
(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):
- WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.
- WinLauncher/WinLauncher.h:
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
- WinLauncher/WinLauncher.rc: Add menu entry for printing.
- WinLauncher/WinLauncher.vcproj: Add new files.
- WinLauncher/resource.h: Add menu entry for printing.
- 7:30 PM Changeset in webkit [52399] by
-
- 6 edits in trunk
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700
- websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
- websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 6:40 PM Changeset in webkit [52398] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed. Tweak the CSS to make the dashboard prettier.
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- 6:32 PM Changeset in webkit [52397] by
-
- 2 edits in trunk/WebCore
REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776
Reviewed by Darin Adler.
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.
- 5:37 PM Changeset in webkit [52396] by
-
- 8 edits3 moves6 adds in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769
Here is a first cut at the dashboard. There's a lot left to do.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/dashboard.py: Added.
- QueueStatusServer/handlers/patchstatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/showresults.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
- QueueStatusServer/stylesheets/dashboard.css: Added.
- QueueStatusServer/templates/dashboard.html: Added.
- QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
- QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
- 5:30 PM BuildingOnWindows edited by
- Add notice of change made in changeset 51399 that requires Safari … (diff)
- 1:58 PM Changeset in webkit [52395] by
-
- 5 edits in trunk/WebCore
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.
No change in functionality. So no new test.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 1:35 PM Changeset in webkit [52394] by
-
- 3 edits4 adds in trunk
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
Tests the right order of filter and clipper/masker aplied to a SVG
object.
- platform/mac/svg/filters/filter-clip-expected.checksum: Added.
- platform/mac/svg/filters/filter-clip-expected.png: Added.
- platform/mac/svg/filters/filter-clip-expected.txt: Added.
- svg/filters/filter-clip.svg: Added.
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements
Test: svg/filters/filter-clip.svg
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- 12:53 PM Changeset in webkit [52393] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Daniel Bates <dbates@webkit.org>
Reviewed by Timothy Hatcher.
Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 10:55 AM Changeset in webkit [52392] by
-
- 2 edits in trunk/WebCore
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)
- GNUmakefile.am:
- 10:52 AM Changeset in webkit [52391] by
-
- 2 adds in trunk/LayoutTests/platform/gtk/svg/css
add forgotten file
- 10:45 AM Changeset in webkit [52390] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Rebaselined test after revision 52335.
- 10:37 AM Changeset in webkit [52389] by
-
- 4 edits2 adds in trunk
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153
- WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
- WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
- 10:30 AM Changeset in webkit [52388] by
-
- 3 edits3 adds in trunk
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
- fast/dom/Range/31684-expected.txt: Added.
- fast/dom/Range/31684.html: Added.
- fast/dom/Range/script-tests/31684.js: Added.
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
Test: fast/dom/Range/31684.html
- dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.
- 10:24 AM Changeset in webkit [52387] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.
- webkit/webkitdownload.cpp:
(webkit_download_error):
- 10:08 AM Changeset in webkit [52386] by
-
- 2 edits in trunk/WebCore
2009-12-19 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Don't use an icon for all spelling guess menu items.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- 9:23 AM Changeset in webkit [52385] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed fixes for me being terrible at python.
- Scripts/modules/bugzilla.py:
- Scripts/run-webkit-unittests:
- 8:24 AM Changeset in webkit [52384] by
-
- 2 edits in trunk/WebCore
2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Missing \.
- GNUmakefile.am:
- 7:16 AM Changeset in webkit [52383] by
-
- 2 edits in trunk
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Add a couple of WebKitGtk files to .gitignore.
- .gitignore:
- 3:52 AM Changeset in webkit [52382] by
-
- 2 edits in trunk/WebCore
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Make --disable-geolocation and --disable-svg work, by conditionally
building the relevant files.
- GNUmakefile.am:
Dec 18, 2009:
- 11:14 PM Changeset in webkit [52381] by
-
- 2 edits9 adds1 delete in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Split QueueStatus server into modules
https://bugs.webkit.org/show_bug.cgi?id=32768
One monolithic file is no good.
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/handlers/patchstatus.py: Added.
- QueueStatusServer/handlers/recentstatus.py: Added.
- QueueStatusServer/handlers/showresults.py: Added.
- QueueStatusServer/handlers/statusbubble.py: Added.
- QueueStatusServer/handlers/updatestatus.py: Added.
- QueueStatusServer/main.py: Added.
- QueueStatusServer/model.py: Added.
- QueueStatusServer/queue_status.py: Removed.
- 11:12 PM Changeset in webkit [52380] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
[Chromium] Eliminate redundant data copy in GraphicsContext3D readback
https://bugs.webkit.org/show_bug.cgi?id=32763
Eliminated useless creation of a CGBitmapContext and from there a
CGImage. Now create CGImage directly from data. Also changed
readPixels parameters and CGImage alpha info to try to avoid byte
swapping, and disabled interpolation when drawing the GL content.
Some test cases run twice as fast with these changes, though more
work is needed to achieve desired performance.
No test case; performance optimization only. Ran WebGL demos from
Khronos site to verify changes.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint):
- 10:40 PM Changeset in webkit [52379] by
-
- 2 edits in trunk/WebCore
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Simon Fraser.
Add a comment about some confusing code that otherwise would look like
it might be a bug.
https://bugs.webkit.org/show_bug.cgi?id=32534
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 10:33 PM Changeset in webkit [52378] by
-
- 3 edits2 moves in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Renamed WorkQueue to QueueEngine. WorkQueue is not a queue.
- Scripts/modules/commands/queues.py:
- Scripts/modules/queueengine.py: Added.
- Scripts/modules/queueengine_unittest.py: Added.
- Scripts/modules/stepsequence.py:
- Scripts/modules/workqueue.py: Removed.
- Scripts/modules/workqueue_unittest.py: Removed.
- 10:05 PM Changeset in webkit [52377] by
-
- 4 edits in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767
dglazkov wanted to be added.
- Scripts/modules/bugzilla.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- 10:02 PM Changeset in webkit [52376] by
-
- 2 edits in trunk/WebKit
Updated localizable strings after r52368
- English.lproj/Localizable.strings:
- 9:14 PM Changeset in webkit [52375] by
-
- 2 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Messed up the XCode file, trying to fix.
- WebCore.xcodeproj/project.pbxproj:
- 8:44 PM Changeset in webkit [52374] by
-
- 2 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, fix typos in WebCore.xcodeproj.
- WebCore.xcodeproj/project.pbxproj:
- 8:34 PM Changeset in webkit [52373] by
-
- 26 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
SVGAngle / SVGPreserveAspectRatio should be POD types
https://bugs.webkit.org/show_bug.cgi?id=32758
Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
like it has been done for SVGMatrix / SVGLength before.
This patch prepares removing the special DOMObjectWithSVGContext hack.
No change in functionality, thus no new tests.
- 6:34 PM Changeset in webkit [52372] by
-
- 2 edits in trunk/WebCore
Chromium build fix, no review.
- storage/chromium/DatabaseTrackerChromium.cpp:
- 6:04 PM Changeset in webkit [52371] by
-
- 2 edits in trunk/WebCore
Build fix, no review.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Correct my typo
on the CG build.
- 6:03 PM Changeset in webkit [52370] by
-
- 2 edits in trunk/WebCore
Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32627
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):
- 5:59 PM Changeset in webkit [52369] by
-
- 3 edits in trunk/WebCore
Build fix, no review.
- page/win/FrameCairoWin.cpp: Add missing include.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Conditionalize
Safari-only call.
- 5:56 PM Changeset in webkit [52368] by
-
- 8 edits5 adds in trunk/WebKit
Add Mac WebKit side of the client based geolocation provider.
Reviewed by Dan Bernstein.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- Misc/WebKitErrors.m:
(registerErrors): Add Geolocation errors.
- Misc/WebKitErrorsPrivate.h:
- WebCoreSupport/WebGeolocationControllerClient.h: Added.
(WebGeolocationControllerClient::webView):
- WebCoreSupport/WebGeolocationControllerClient.mm: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.
- WebView/WebGeolocationPosition.h: Added.
- WebView/WebGeolocationPosition.mm: Added.
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
- WebView/WebGeolocationPositionInternal.h: Added.
Add an Objective-C wrapper for GeolocationPosition.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
- 5:27 PM Changeset in webkit [52367] by
-
- 2 edits in trunk/WebCore
Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=32626
- storage/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::close):
- 4:47 PM Changeset in webkit [52366] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=32756
- public/WebAccessibilityRole.h: (WebKit::):
- src/AssertMatchingEnums.cpp:
- 4:40 PM Changeset in webkit [52365] by
-
- 2 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52344.
- 4:40 PM Changeset in webkit [52364] by
-
- 2 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52342.
- 4:40 PM Changeset in webkit [52363] by
-
- 4 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52338.
- 4:40 PM Changeset in webkit [52362] by
-
- 7 edits in tags/Safari-532.7.1/WebKit
Merge r52336.
- 4:40 PM Changeset in webkit [52361] by
-
- 4 edits in tags/Safari-532.7.1/WebCore
Merge r52331.
- 4:40 PM Changeset in webkit [52360] by
-
- 2 edits in tags/Safari-532.7.1/WebCore
Merge r52330.
- 4:40 PM Changeset in webkit [52359] by
-
- 10 edits in tags/Safari-532.7.1
Merge r52325.
- 4:39 PM Changeset in webkit [52358] by
-
- 4 edits in tags/Safari-532.7.1
Merge r52298.
- 4:39 PM Changeset in webkit [52357] by
-
- 4 edits in tags/Safari-532.7.1
Versioning.
- 4:33 PM Changeset in webkit [52356] by
-
- 2 edits in trunk/WebKit/mac
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(52325) Chromium build broken due to link failure
https://bugs.webkit.org/show_bug.cgi?id=32753
- WebCoreSupport/WebSystemInterface.m:
- Chromium Mac builds use this file, but do not enable Pre-compiled Header (PCH) files so that Chromium build bots can take advantage of the faster distcc 3. Eventually all mac builds will likely use distcc, but for now we'll add Platform.h here and document its usage so it's not removed by accident.
- 4:29 PM Changeset in webkit [52355] by
-
- 10 edits in trunk/JavaScriptCore
2009-12-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956
- JavaScriptCore.pri: Compile files unconditionally
- jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
- runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
- runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
- wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
- wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
- wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)
- 4:22 PM Changeset in webkit [52354] by
-
- 3 edits2 adds in trunk
2009-12-18 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
https://bugs.webkit.org/show_bug.cgi?id=31559
Fix an array bounds error when accessing the CSS value for a shorthand property that takes
a comma-separated list, after the list for one of the component properties has been set to a different length.
Test: fast/css/shorthand-mismatched-list-crash.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
- 4:09 PM Changeset in webkit [52353] by
-
- 1 copy in tags/Safari-532.7.1
New tag.
- 4:05 PM Changeset in webkit [52352] by
-
- 4 edits2 adds in trunk
REGRESSION(r52233): MSAA: Accessibility role of lists is wrong
https://bugs.webkit.org/show_bug.cgi?id=32736
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-role.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.
LayoutTests:
- platform/win/accessibility/list-role-expected.txt: Added.
- platform/win/accessibility/list-role.html: Added.
Verify that lists return the "list" role.
- 4:05 PM Changeset in webkit [52351] by
-
- 6 edits2 adds in trunk
MSAA: Accessibility role of list items is wrong
https://bugs.webkit.org/show_bug.cgi?id=32688
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-item-role.html
- accessibility/AccessibilityObject.h:
(WebCore::):
Add a ListItemRole to the enum.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list item role map to the MSAA list item role.
LayoutTests:
- platform/win/accessibility/list-item-role-expected.txt: Added.
- platform/win/accessibility/list-item-role.html: Added.
Verify that the list item role is "list item".
- 4:05 PM Changeset in webkit [52350] by
-
- 3 edits2 adds in trunk
MSAA: Accessibility role of list markers is wrong
https://bugs.webkit.org/show_bug.cgi?id=32687
Reviewed by Adam Roben.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.
LayoutTests:
- platform/win/accessibility/list-marker-role-expected.txt: Added.
- platform/win/accessibility/list-marker-role.html: Added.
Verify that the list marker role is "text".
- 4:00 PM Changeset in webkit [52349] by
-
- 2 edits in trunk/WebCore
2009-12-18 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.
- WebCore.xcodeproj/project.pbxproj:
- 3:57 PM Changeset in webkit [52348] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix part II, this time it's personal.x
- 3:46 PM Changeset in webkit [52347] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.
- 2:59 PM Changeset in webkit [52346] by
-
- 13 edits in trunk/JavaScriptCore
Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.
Reviewed by Sam Weinig.
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
- API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
- JavaScriptCore.exp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):
- runtime/UString.h:
(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):
- 2:51 PM Changeset in webkit [52345] by
-
- 6 edits1 add in trunk/WebCore
Fix mac Geolocation build.
- DerivedSources.make:
- WebCore.ClientBasedGeolocation.exp: Added.
- WebCore.xcodeproj/project.pbxproj:
- page/Geolocation.h:
- page/GeolocationError.h:
(WebCore::GeolocationError::GeolocationError):
- page/GeolocationPosition.h:
- 2:44 PM Changeset in webkit [52344] by
-
- 2 edits in trunk/WebKit/mac
Fix preference key name.
Reviewed by Anders Carlsson.
- WebView/WebPreferenceKeysPrivate.h:
- 2:18 PM Changeset in webkit [52343] by
-
- 3 edits in trunk/JavaScriptCore
Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)
Reviewed by Cameron Zwarich and Gavin Barraclough.
In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.
- interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.
- interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.
- 2:05 PM Changeset in webkit [52342] by
-
- 2 edits in trunk/WebKit/mac
Pass preference to plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
- 1:57 PM Changeset in webkit [52341] by
-
- 5 edits6 adds in trunk
Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.
Reviewed by Adam Roben.
WebCore:
The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.
Tests: platform/win/fast/events/panScroll-image-no-scroll.html
platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html
- dom/Node.cpp:
(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):
- dom/Node.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
LayoutTests:
Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.
- platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-image-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.
- 1:55 PM Changeset in webkit [52340] by
-
- 2 edits in trunk/WebKit/qt
2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>
Build fix, not reviewed.
- QtLauncher/main.cpp: (MainWindow::setTouchMocking): Leave setTouchMocking as an empty function for Qt < 4.6 so that moc still creates a slot for that. Otherwise, it would have generated a linker error.
- 1:45 PM Changeset in webkit [52339] by
-
- 2 edits in trunk/WebKitTools
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
move bugzilla.py off of urllib2
https://bugs.webkit.org/show_bug.cgi?id=32729
- Scripts/modules/bugzilla.py: use mechanize for all url fetching.
- 1:43 PM Changeset in webkit [52338] by
-
- 4 edits in trunk/WebKit/mac
Add WKPCRunSyncOpenPanel implementation.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 1:18 PM Changeset in webkit [52337] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.
Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.
- wtf/Assertions.h:
- 1:17 PM Changeset in webkit [52336] by
-
- 7 edits in trunk/WebKit
Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):
- WebView/WebPreferencesPrivate.h:
- 12:50 PM Changeset in webkit [52335] by
-
- 4 edits in trunk
[GTK] RemoveDashboard support. It's useless.
- configure.ac:
- 12:46 PM Changeset in webkit [52334] by
-
- 5 edits1 add in trunk/JavaScriptCore
Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.
Reviewed by Adam Roben.
Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):
- API/JSClassRef.h: Use WeakGCPtr.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/WeakGCPtr.h: Added.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.
- 12:45 PM Changeset in webkit [52333] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Add a needed export to fix the Windows build.
- 12:42 PM Changeset in webkit [52332] by
-
- 2 edits in trunk/WebCore
2009-12-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546
Omit SearchWeb from the context menu in the GTK+ port.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- 12:41 PM Changeset in webkit [52331] by
-
- 4 edits in trunk/WebCore
Add export the new symbol in WebCoreSystemInterface.
Reviewed by Anders Carlsson.
- WebCore.base.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:26 PM Changeset in webkit [52330] by
-
- 2 edits in trunk/WebCore
Forward declare NSMutableArray when not compiling for Objective-C.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- 12:02 PM Changeset in webkit [52329] by
-
- 7 edits1 add in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- Remove exports for UString::append
- JavaScriptCore.xcodeproj/project.pbxproj:
- Make StringBuilder a private header (was project).
WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/StringBuilder.h: Added.
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
- 11:55 AM Changeset in webkit [52328] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709
Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.
- wtf/gtk/GRefPtr.h: (WTF::GRefPtr::operator=):
- 11:43 AM Changeset in webkit [52327] by
-
- 3 edits2 adds in trunk
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
- fast/canvas/webgl/bug-32692-expected.txt: Added.
- fast/canvas/webgl/bug-32692.html: Added.
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
Test: fast/canvas/webgl/bug-32692.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
- 11:36 AM Changeset in webkit [52326] by
-
- 5 edits in trunk
2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Disable page cache for tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey): (LayoutTestController::overridePreference):
- 11:22 AM Changeset in webkit [52325] by
-
- 10 edits in trunk
WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 11:16 AM Changeset in webkit [52324] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.
- platform/win/fast/dom/Element: Added.
- platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- 10:48 AM Changeset in webkit [52323] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix gtk-doc of webkit_web_resource_new.
- webkit/webkitwebresource.cpp:
- 10:35 AM Changeset in webkit [52322] by
-
- 2 edits in trunk/WebCore
GTK build fix
- plugins/gtk/PluginViewGtk.cpp: Added #include.
- 10:00 AM Changeset in webkit [52321] by
-
- 8 edits in trunk
Build fixes
WebCore: Chromium build fix
- platform/chromium/PopupMenuChromium.cpp: Added #include.
WebKit/chromium: Chromium build fix
- src/ChromiumBridge.cpp:
- src/WebPluginContainerImpl.cpp:
- src/WebViewImpl.cpp:
Added #includes.
WebKit/qt: Qt build fix
- Api/qwebpage.cpp: Added #include.
- 9:54 AM Changeset in webkit [52320] by
-
- 2 edits in trunk/WebCore
Chromium build fix
- html/HTMLLinkElement.cpp: Added #include.
- 9:52 AM Changeset in webkit [52319] by
-
- 6 edits in trunk
Qt build fix
WebCore:
- platform/qt/RenderThemeQt.cpp:
- plugins/qt/PluginDataQt.cpp:
- plugins/qt/PluginViewQt.cpp:
Added #includes.
WebKit/qt:
- Api/qwebpage.cpp:
Added #includes.
- 9:47 AM Changeset in webkit [52318] by
-
- 3 edits in trunk/WebKitTools
2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Check one space before end of line comments.
https://bugs.webkit.org/show_bug.cgi?id=32597
Fix to check one space before end of line comments in whitespace and build/header_guard.
Also fix build/header_guard to use WebKit header guard defines.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 9:47 AM Changeset in webkit [52317] by
-
- 2 edits in trunk/WebCore
V8 build fix
- bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.
- 9:45 AM Changeset in webkit [52316] by
-
- 2 edits in trunk/WebKit/gtk
GTK build fix
- webkit/webkitprivate.cpp: Added #include.
- 9:42 AM Changeset in webkit [52315] by
-
- 2 edits in trunk/WebCore
GTK (and others?) build fix
- platform/text/StringImpl.h: Added #include.
- 9:38 AM Changeset in webkit [52314] by
-
- 68 edits in trunk
Reduce #includes in a few high-use headers
Removed unnecessary #includes in these headers:
- Frame.h
- FrameWin.h
- Node.h
- Page.h
- StringImpl.h
The rest of the patch is all adding #includes to source files that now
require them.
Fixes <http://webkit.org/b/32718>.
Rubber-stamped by Anders Carlsson.
WebCore:
- dom/Node.h:
- page/Frame.h:
- page/Page.h:
- page/win/FrameWin.h:
- platform/text/StringImpl.h:
Removed unnecessary #includes.
- accessibility/win/AXObjectCacheWin.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- dom/Document.cpp:
- dom/InputElement.cpp:
- dom/Node.cpp:
- dom/SelectElement.cpp:
- editing/EditorCommand.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLParser.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLVideoElement.cpp:
- inspector/InspectorController.cpp:
- loader/FrameLoader.cpp:
- loader/HistoryController.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- page/Console.cpp:
- page/EventHandler.cpp:
- page/Frame.cpp:
- page/FrameView.cpp:
- page/Navigator.cpp:
- page/PageGroup.cpp:
- page/Settings.cpp:
- page/mac/EventHandlerMac.mm:
- platform/KURL.h:
- platform/ScrollbarThemeComposite.cpp:
- platform/cf/BinaryPropertyList.cpp:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WidgetMac.mm:
- platform/network/cf/DNSCFNet.cpp:
- platform/text/StringImpl.cpp:
- platform/win/FileSystemWin.cpp:
- platform/win/PlatformScreenWin.cpp:
- platform/win/PopupMenuWin.cpp:
- platform/win/WidgetWin.cpp:
- plugins/PluginView.cpp:
- plugins/win/PluginViewWin.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderObject.cpp:
- rendering/RootInlineBox.cpp:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp:
- svg/graphics/SVGImage.cpp:
Added now-needed #includes.
WebKit/mac:
Add #includes needed after WebCore clean-up
- WebView/WebFrame.mm:
- WebView/WebFrameView.mm:
- WebView/WebView.mm:
WebKit/win:
Add #includes needed after WebCore clean-up
- WebCoreSupport/WebContextMenuClient.cpp:
- WebDataSource.cpp:
- WebHTMLRepresentation.cpp:
- WebView.cpp:
- WebView.h:
- 9:06 AM Changeset in webkit [52313] by
-
- 6 edits in trunk
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=32716
.:
- WebKit.pri: Use standalone_package instead of QTDIR_build
- pcre/pcre.pri: Use standalone_package instead of QTDIR_build
WebCore:
Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.
Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.
- WebCore.pro:
- 8:56 AM QtWebKitPerformanceWork edited by
- Minor spelling correction (diff)
- 8:40 AM Changeset in webkit [52312] by
-
- 36 edits20 adds in trunk
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
New test cases for isId support.
https://bugs.webkit.org/show_bug.cgi?id=5578
- dom/xhtml/level3/core/attrisid04-expected.txt:
- dom/xhtml/level3/core/attrisid04.js: (setUpPage):
- dom/xhtml/level3/core/attrisid05-expected.txt:
- dom/xhtml/level3/core/attrisid05.js: (setUpPage):
- fast/dom/Element/attrisid-extra01-expected.txt: Added.
- fast/dom/Element/attrisid-extra01.html: Added.
- fast/dom/Element/id-in-applet-expected.txt: Added.
- fast/dom/Element/id-in-applet.html: Added.
- fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- fast/dom/Element/id-in-deletebutton.html: Added.
- fast/dom/Element/id-in-formcollection-expected.txt: Added.
- fast/dom/Element/id-in-formcollection.html: Added.
- fast/dom/Element/id-in-frame-expected.txt: Added.
- fast/dom/Element/id-in-frame.html: Added.
- fast/dom/Element/id-in-frameset-expected.txt: Added.
- fast/dom/Element/id-in-frameset.html: Added.
- fast/dom/Element/id-in-getelement01-expected.txt: Added.
- fast/dom/Element/id-in-getelement01.html: Added.
- fast/dom/Element/id-in-insert-hr-expected.txt: Added.
- fast/dom/Element/id-in-insert-hr.html: Added.
- fast/dom/Element/id-in-map-expected.txt: Added.
- fast/dom/Element/id-in-map.html: Added.
- fast/dom/Element/id-in-param-expected.txt: Added.
- fast/dom/Element/id-in-param.html: Added.
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
Implemented isId as specified by DOM Level 3. See detailed description below.
https://bugs.webkit.org/show_bug.cgi?id=5578
Added isId property and implementation:
Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
fast/dom/Element/attrisid-extra01.html
- dom/Attr.cpp: (WebCore::Attr::isId):
- dom/Attr.h:
- dom/Attr.idl:
Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
for the reason that id attribute name could be customized to a different
string other than "id". A test case is associated to each code change.
- dom/Document.cpp: (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
- dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::formatForDebugger): (WebCore::Element::rareIDAttributeName):
- dom/Element.h: Added function idAttributeName(). (WebCore::Element::idAttributeName):
- dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData. (WebCore::ElementRareData::ElementRareData):
- dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::NamedNodeMap::setNamedItem): (WebCore::NamedNodeMap::removeNamedItem): (WebCore::NamedNodeMap::setAttributes):
- dom/Node.cpp: Removed ASSERT as it may not hold any more. (WebCore::Node::querySelector):
- dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more. (WebCore::createSelectorNodeList):
- dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::StyledElement::parseMappedAttribute):
- editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::DeleteButtonController::createDeletionUI):
- editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html (WebCore::executeInsertHorizontalRule):
- html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::nextNamedItem): (WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html (WebCore::HTMLFrameElementBase::parseMappedAttribute): (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html (WebCore::HTMLMapElement::parseMappedAttribute):
- html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html (WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html (WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html (WebCore::HTMLParamElement::parseMappedAttribute):
- loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html (WebCore::CachedFont::getSVGFontById):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
- rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg (WebCore::writeRenderResources):
- svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html (WebCore::SVGElement::insertedIntoDocument):
- svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg (WebCore::SVGStyledElement::isKnownAttribute):
- wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute):
- 7:04 AM Changeset in webkit [52311] by
-
- 6 edits2 adds in trunk/WebKit/qt
2009-12-18 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
then checking current frame and then ancestors
https://bugs.webkit.org/show_bug.cgi?id=32668
- Api/qwebframe.cpp: (QWebFramePrivate::scrollOverflow): (QWebFrame::scrollRecursively):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/testiframe.html: Added.
- tests/qwebframe/testiframe2.html: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:03 AM Changeset in webkit [52310] by
-
- 2 edits in trunk/WebCore
[Qt] Fix the build on Symbian.
Reviewed by Tor Arne Vestbø.
Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.
Functionally they should be equivalent, according to the source.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 6:01 AM Changeset in webkit [52309] by
-
- 2 edits in trunk/WebCore
2009-12-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] segfault during controls initialization if not GTK theme is present.
https://bugs.webkit.org/show_bug.cgi?id=32705
Create empty images for the controls if no GTK theme is set.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getThemeIconFileName): (WebCore::loadImageFromFile):
- 5:38 AM Changeset in webkit [52308] by
-
- 3 edits in trunk/WebCore
Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.
- 5:32 AM Changeset in webkit [52307] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix infinite recursion in touch mocking.
Reviewed by Tor Arne Vestbø.
Don't send the fake touch events to the view, as that'll trigger the
event filter again.
- QtLauncher/main.cpp:
(MainWindow::sendTouchEvent):
- 4:00 AM Changeset in webkit [52306] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
- 2:51 AM Changeset in webkit [52305] by
-
- 3 edits in trunk/WebCore
Remove the fragment identifier from url before passing it to libsoup.
In newer releases libsoup emits a warning when it gets handed a
fragment.
- 2:37 AM Changeset in webkit [52304] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703
Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.
- wtf/gtk/GRefPtr.cpp: (WTF::refGPtr):
- 1:50 AM Changeset in webkit [52303] by
-
- 3 edits2 adds in trunk
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Added test showing the problem described in the bug.
- editing/selection/wrapped-line-caret-3.html:
- editing/selection/wrapped-line-caret-3-expected.txt:
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Moving up from a position after the end of the previous lines
should use UPSTREAM affinity to render the caret in the previous
line.
Test: editing/selection/wrapped-line-caret-3.html
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
Dec 17, 2009:
- 11:17 PM Changeset in webkit [52302] by
-
- 2 edits in trunk/WebCore
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
https://bugs.webkit.org/show_bug.cgi?id=32675
Use the double constant 2.0 instead of static_cast<double>(2).
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch):
- 10:39 PM Changeset in webkit [52301] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstreaming an XSS test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32685
- http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
- http/tests/security/xss-DENIED-assign-location-href-javascript.html: Added.
- 10:12 PM Changeset in webkit [52300] by
-
- 3 edits2 adds in trunk
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/text/text-font-uri-invalid-expected.txt: Added.
- svg/text/text-font-uri-invalid.svg: Added.
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
- 9:42 PM Changeset in webkit [52299] by
-
- 5 edits2 adds in trunk
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
- fast/inline/inline-marquee-crash-expected.txt: Added.
- fast/inline/inline-marquee-crash.html: Added.
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
Test: fast/inline/inline-marquee-crash.html
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume): (WebCore::HTMLMarqueeElement::renderMarquee):
- html/HTMLMarqueeElement.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- 8:14 PM Changeset in webkit [52298] by
-
- 4 edits in trunk
JavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
Reviewed by Mark Rowe.
- wtf/Platform.h:
WebKitTools: Add BUILDING_ON_SNOW_LEOPARD #define.
Reviewed by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- 8:12 PM Changeset in webkit [52297] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Unskip websocket tests
New pywebsocket (0.4.5) landed at WebKit r52296, so
sub-protocol-with-space.html should pass.
- platform/mac/Skipped: delete websocket/tests/sub-protocol-with-space.html
- platform/win/Skipped: delete websocket/tests/sub-protocol-with-space.html
- 6:38 PM Changeset in webkit [52296] by
-
- 6 edits2 copies in trunk/WebKitTools
2009-12-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.5 and make handshake checking stricter
https://bugs.webkit.org/show_bug.cgi?id=32249
- Scripts/run-webkit-tests:
- pywebsocket/mod_pywebsocket/handshake.py:
- pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_handshake.py:
- pywebsocket/test/test_memorizingfile.py: Added.
- 5:28 PM Changeset in webkit [52295] by
-
- 6 edits in trunk/WebKitTools
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Command.show_in_main_help should default to False
https://bugs.webkit.org/show_bug.cgi?id=32686
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/multicommandtool.py:
- 4:51 PM Changeset in webkit [52294] by
-
- 4 edits in trunk/WebCore
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for inspector's classes
https://bugs.webkit.org/show_bug.cgi?id=32660
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
class ConsoleMessage - inspector/InspectorController.cpp:329
class InspectorController - page/Page.cpp:119
- inspector/ConsoleMessage.h:
- inspector/InspectorController.h:
- inspector/JavaScriptDebugServer.h:
- 3:22 PM Changeset in webkit [52293] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Eric Seidel <eric@webkit.org>
No review, rolling out r52291.
http://trac.webkit.org/changeset/52291
https://bugs.webkit.org/show_bug.cgi?id=32618
Darin Fisher points out that this will likely break
the SSL security indicator in Chromium. Rolling out for now.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 2:37 PM Changeset in webkit [52292] by
-
- 2 edits in trunk/WebCore
2009-12-17 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
https://bugs.webkit.org/show_bug.cgi?id=32675
Build fix only, no new tests.
- html/HTMLInputElement.cpp: Modified. (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'
- 2:14 PM Changeset in webkit [52291] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Eric Seidel.
Disable memory cache client calls so that a new identifier isn't created
for the same resource on reload.
With the calls enabled, duplicate entries for cached resources are created
in the Web Inspector. Safari for Windows disables the calls near the point of the
Frame instance creation, and we just follow this for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=32618
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 2:10 PM Changeset in webkit [52290] by
-
- 4 edits in trunk
Versioning.
- 2:09 PM Changeset in webkit [52289] by
-
- 1 copy in tags/Safari-532.7
New tag.
- 1:52 PM Changeset in webkit [52288] by
-
- 9 edits in trunk/WebCore
2009-12-17 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Eric Seidel.
Fix link failure on LTCG builds on Windows for chromium port.
Reenable SVGAllInOne.cpp. This required some fixups.
Namely, there was conflicts in constants between HTMLNames and
SVGNames, and conflicts between static functions names.
No new tests as functionality has not changed.
- WebCore.gyp/WebCore.gyp:
- svg/SVGAllInOne.cpp:
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): (WebCore::SVGStyleElement::setType): (WebCore::SVGStyleElement::media): (WebCore::SVGStyleElement::setMedia): (WebCore::SVGStyleElement::title): (WebCore::SVGStyleElement::setTitle): (WebCore::SVGStyleElement::parseMappedAttribute):
- svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
- svg/SVGStyledElement.h:
- 1:38 PM Changeset in webkit [52287] by
-
- 2 edits in trunk/WebCore
Chromium build fix VI
- svg/animation/SMILTimeContainer.h: Added now-needed #include.
- 1:37 PM Changeset in webkit [52286] by
-
- 2 edits in trunk/WebCore
Chromium build fix V
- platform/KURLGoogle.cpp: Added now-needed #include.
- 1:29 PM Changeset in webkit [52285] by
-
- 2 edits in trunk/WebCore
Chromium build fix IV
- loader/CrossOriginPreflightResultCache.h: Added now-needed
- 1:26 PM Changeset in webkit [52284] by
-
- 3 edits in trunk/WebKitTools
2009-12-17 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
Added the key WebKitEnableCaretBrowsing to the
layoutTestController.overridePreference in order to activate caret
browsing.
https://bugs.webkit.org/show_bug.cgi?id=32612
- DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of the setting.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new key in the keytable.
- 1:19 PM Changeset in webkit [52283] by
-
- 2 edits in trunk/WebCore
Chromium build fix III
- platform/graphics/Font.h: Added now-needed #include.
- 1:10 PM Changeset in webkit [52282] by
-
- 2 edits in trunk/WebCore
Chromium build fix II
- dom/EventTarget.h: Added now-needed #include.
- 1:09 PM Changeset in webkit [52281] by
-
- 4 edits in trunk/WebCore
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for js bindings
https://bugs.webkit.org/show_bug.cgi?id=32655
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class ScriptCachedFrameData - history/CachedFrame.cpp:117
class WebCoreJSClientData - bindings/js/JSDOMWindowBase.cpp:162
class ScheduledAction - bindings/js/ScheduledAction.cpp:58
- bindings/js/JSDOMBinding.h:
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCachedFrameData.h:
- 12:56 PM Changeset in webkit [52280] by
-
- 2 edits in trunk/WebCore
Chromium build fix
- dom/QualifiedName.h: Added now-needed #include of HashTraits.h
(which itself #includes HashFunctions.h).
- 12:53 PM Changeset in webkit [52279] by
-
- 6 edits in trunk
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- 12:38 PM Changeset in webkit [52278] by
-
- 2 edits in trunk/WebCore
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
Reduces code size of Gtk build by another 5%.
- platform/text/PlatformString.h:
- 12:32 PM Changeset in webkit [52277] by
-
- 2 edits in trunk/WebKit/mac
Mac build fix
- WebView/WebVideoFullscreenController.mm: Added now-needed #import.
- 12:22 PM Changeset in webkit [52276] by
-
- 4 edits in trunk/WebCore
Mac/Qt build fixes
- platform/graphics/mac/Canvas3DLayer.mm:
- platform/graphics/mac/GraphicsContext3DMac.cpp:
- platform/qt/Localizations.cpp:
Added missing #includes.
- 12:00 PM Changeset in webkit [52275] by
-
- 6 edits in trunk
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
WebCore:
PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.
No new tests as it's just a build improvement.
- platform/gtk/LocalizedStringsGtk.cpp:
include math.h here (it used to be pulled by JSC)
- platform/text/PlatformString.h:
- platform/text/String.cpp:
WebKit/win:
- WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.
- 11:59 AM Changeset in webkit [52274] by
-
- 2 edits in trunk/WebCore
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Always use all WebCore include paths in GtkWebKit.
With this patch, I can disable all optional features and still build.
- GNUmakefile.am:
- 11:58 AM Changeset in webkit [52273] by
-
- 2 edits in trunk/LayoutTests
Unreviewed layout test fix.
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
The test for this patch shouldn't be run on Tiger.
- platform/mac-tiger/Skipped:
- 11:48 AM Changeset in webkit [52272] by
-
- 6 edits in trunk/WebKitTools
AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666
Reviewed by David Kilzer.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getURLCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::url):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::url):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::url):
- 11:36 AM Changeset in webkit [52271] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- Scripts/modules/committers.py:
- 11:23 AM Changeset in webkit [52270] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
More make distcheck fixes. Use a more robust solution to making
sure we are in the correct directory for running these tests.
- tests/testmimehandling.c: (main):
- tests/testwebview.c: (main):
- 11:21 AM Changeset in webkit [52269] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- 11:18 AM Changeset in webkit [52268] by
-
- 17 edits13 adds in trunk
2009-12-17 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Added WebPageSerializer to WebKit API and enriched the WebNode hierarchy to support
downstream unit-testing of serialization.
WebPageSerializer was adapted from Chromium's dom_serializer, originally authored by Johnny Ding.
- WebKit.gyp:
- public/WebDocument.h: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::assign):
- public/WebElement.h:
- public/WebFormElement.h: (WebKit::WebFormElement::operator=):
- public/WebFrame.h:
- public/WebNode.h: (WebKit::WebNode::): (WebKit::WebNode::toConstElement):
- public/WebNodeCollection.h: Added. (WebKit::WebNodeCollection::~WebNodeCollection): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::operator=):
- public/WebNodeList.h: Added. (WebKit::WebNodeList::~WebNodeList): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::operator=):
- public/WebPageSerializer.h: Added.
- public/WebPageSerializerClient.h: Added. (WebKit::WebPageSerializerClient::): (WebKit::WebPageSerializerClient::WebPageSerializerClient): (WebKit::WebPageSerializerClient::~WebPageSerializerClient):
- public/WebString.h:
- public/WebView.h:
- src/AssertMatchingEnums.cpp:
- src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute):
- src/DOMUtilitiesPrivate.h:
- src/WebDocument.cpp: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator WTF::PassRefPtr<Document>): (WebKit::WebDocument::frame): (WebKit::WebDocument::isHTMLDocument): (WebKit::WebDocument::baseURL): (WebKit::WebDocument::body): (WebKit::WebDocument::head): (WebKit::WebDocument::all): (WebKit::WebDocument::completeURL):
- src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::hasAttribute): (WebKit::WebElement::getAttribute):
- src/WebEntities.cpp: Added. (WebKit::populateMap): (WebKit::): (WebKit::WebEntities::WebEntities): (WebKit::WebEntities::entityNameByCode): (WebKit::WebEntities::convertEntitiesInString):
- src/WebEntities.h: Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrame::fromFrameOwnerElement): (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::document): (WebKit::WebFrameImpl::fromFrameOwnerElement):
- src/WebFrameImpl.h:
- src/WebNode.cpp: (WebKit::WebNode::nodeType): (WebKit::WebNode::nodeValue): (WebKit::WebNode::document): (WebKit::WebNode::firstChild): (WebKit::WebNode::lastChild): (WebKit::WebNode::previousSibling): (WebKit::WebNode::nextSibling): (WebKit::WebNode::hasChildNodes): (WebKit::WebNode::childNodes): (WebKit::WebNode::createMarkup): (WebKit::WebNode::isTextNode): (WebKit::WebNode::isElementNode):
- src/WebNodeCollection.cpp: Added. (WebKit::WebNodeCollection::reset): (WebKit::WebNodeCollection::assign): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::length): (WebKit::WebNodeCollection::nextItem): (WebKit::WebNodeCollection::firstItem):
- src/WebNodeList.cpp: Added. (WebKit::WebNodeList::reset): (WebKit::WebNodeList::assign): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::length): (WebKit::WebNodeList::item):
- src/WebPageSerializer.cpp: Added. (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateMarkOfTheWebDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
- src/WebPageSerializerImpl.cpp: Added. (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeEndTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag): (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer): (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): (WebKit::WebPageSerializerImpl::buildContentForNode): (WebKit::WebPageSerializerImpl::WebPageSerializerImpl): (WebKit::WebPageSerializerImpl::collectTargetFrames): (WebKit::WebPageSerializerImpl::serialize):
- src/WebPageSerializerImpl.h: Added.
- src/WebString.cpp: (WebKit::WebString::WebString): (WebKit::WebString::operator=):
- src/WebViewImpl.cpp:
- 11:14 AM Changeset in webkit [52267] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] Don't assume downloads are always synchronous
http://bugs.webkit.org/show_bug.cgi?id=32359
- tests/testdownload.c: (download_requested_cb): (set_filename): (test_webkit_download_perform): (test_webkit_download_synch): (test_webkit_download_asynch): (main): Test downloads synchronously and asynchronously.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_request_download): Only try to start a requested download if the destination URI is set and clarify the documentation.
- 11:13 AM Changeset in webkit [52266] by
-
- 8 edits8 adds in trunk
Merge branch 'bug/26304' into staging
- 11:12 AM Changeset in webkit [52265] by
-
- 2 edits in trunk/JavaScriptCore
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree
Fixes <http://webkit.org/b/32665>.
Reviewed by Ada Chan.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.
- 11:12 AM Changeset in webkit [52264] by
-
- 7 edits4 deletes in trunk/JavaScriptCore
Remove HeavyProfile and TreeProfile completely
These were mostly removed in r42808, but the empty files were left in
place.
Fixes <http://webkit.org/b/32664>.
Reviewed by John Sullivan.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.
- profiler/HeavyProfile.cpp: Removed.
- profiler/HeavyProfile.h: Removed.
- profiler/TreeProfile.cpp: Removed.
- profiler/TreeProfile.h: Removed.
- 11:12 AM Changeset in webkit [52263] by
-
- 2 edits in trunk/WebKit/win
Remove WebKit.sln's Debug_All and Debug_Internal configurations
These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.
Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.
Rubber-stamped by Dan Bernstein.
- WebKit.vcproj/WebKit.sln:
- 11:09 AM Changeset in webkit [52262] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
Deprecate the title-changed signal of WebKitWebFrame.
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- 10:39 AM Changeset in webkit [52261] by
-
- 3 edits2 adds in trunk/WebCore
2009-12-17 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support navigator.onLine and ononline/onoffline events.
https://bugs.webkit.org/show_bug.cgi?id=32555
Hooked up Bearer Management to NetworkStateNotifier. This solution is available
only if QtMobility's Bearer Management is installed.
- WebCore.pro:
- platform/network/NetworkStateNotifier.h:
- platform/network/qt/NetworkStateNotifierPrivate.h: Added.
- platform/network/qt/NetworkStateNotifierQt.cpp: Added. (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifier::updateState): (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 10:25 AM Changeset in webkit [52260] by
-
- 3 edits in trunk/WebCore
2009-12-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Switch to 11px as default for source-code in WebKit.
- inspector/front-end/inspector.css:
- 9:57 AM Changeset in webkit [52259] by
-
- 2 edits in trunk/WebCore
[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
make sure we pick up the header file from QtCore. That is where the implementation
is compiled.
Reviewed by Tor Arne Vestbø.
- dom/XMLTokenizer.h:
- 9:44 AM Changeset in webkit [52258] by
-
- 9 edits2 copies2 adds in trunk
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 9:21 AM Changeset in webkit [52257] by
-
- 2 edits in trunk/WebKit/qt
2009-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with Q(GV)Launcher
https://bugs.webkit.org/show_bug.cgi?id=32434
The event delivery should go through QCoreApplication::sendEvent()
- QtLauncher/main.cpp: (MainWindow::sendTouchEvent):
- 9:09 AM Changeset in webkit [52256] by
-
- 3 edits in trunk/WebKit/qt
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for touch events in QWebView and QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=32432
- Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::sceneEvent):
- Api/qwebview.cpp: (QWebView::QWebView): (QWebView::event):
- 9:06 AM Changeset in webkit [52255] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by David Levin.
Provide explicit implementation of 'non-template' WebVector<T>::operator=
- public/WebVector.h:
- 7:56 AM Changeset in webkit [52254] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 7:34 AM Changeset in webkit [52253] by
-
- 6 edits in trunk/WebCore
2009-12-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Advice links to source code in CPU profiler to open in debugger,
not in resources tab.
Also work around the case when resources are disabled, but scripts are present.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.updateMainViewWidth): (WebInspector.Panel.prototype.canShowSourceLineForURL): (WebInspector.Panel.prototype.showSourceLineForURL):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL): (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.scriptForURL): (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL): (WebInspector.ScriptsPanel.prototype.showSourceLineForURL): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLineForURL): (WebInspector.canShowSourceLineForURL): (WebInspector.showSourceLineForURL):
- 6:42 AM Changeset in webkit [52252] by
-
- 2 edits in trunk/LayoutTests
Skipping one test that needs overriding of standard preferences,
and a new one.
- platform/gtk/Skipped:
- 6:27 AM Changeset in webkit [52251] by
-
- 3 edits in trunk/WebCore
Reviewed by Xan Lopez.
[GTK] display FPS stats for video element
https://bugs.webkit.org/show_bug.cgi?id=32560
Display FPS statistics if WEBKIT_DEBUG environment variable
contains the Media log category. This feature requires a very
recent (>= 0.10.18) version of gst-plugins-bad.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 6:01 AM Changeset in webkit [52250] by
-
- 2 edits in trunk/WebKit/qt
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=32434
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::sendTouchEvent): (MainWindow::eventFilter): (MainWindow::setTouchMocking): (MainWindow::setupUI):
- 5:05 AM Changeset in webkit [52249] by
-
- 9 edits3 deletes in trunk
Reverting 52246 and 52248 because they crash tests.
- 4:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:43 AM QtWebKitContrib edited by
- (diff)
- 4:43 AM QtWebKitReleases edited by
- (diff)
- 4:41 AM QtWebKitReleases created by
- 4:31 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:30 AM Changeset in webkit [52248] by
-
- 2 edits3 adds in trunk
Build fix. Landing files I forgot to commit.
- 4:13 AM Changeset in webkit [52247] by
-
- 3 edits in trunk/WebCore
2009-12-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] segfault during volume notification
https://bugs.webkit.org/show_bug.cgi?id=32603
Emit volumeChanged and durationChanged upon notification from
GStreamer. Also don't reset the volume property on playbin, it is
not needed as it is 1.0 by default both on playbin and in the
MediaPlayer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2009-11-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
https://bugs.webkit.org/show_bug.cgi?id=30377
Emit volumeChanged and durationChanged upon notification from
GStreamer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeCallback): (WebCore::notify_volume_idle_cb): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 4:02 AM Changeset in webkit [52246] by
-
- 9 edits in trunk
WebCore
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
WebKit/gtk
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 3:48 AM Changeset in webkit [52245] by
-
- 2 edits in trunk/WebCore
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
gtk: always use standard include paths, regardless of settings.
WebKit style is to wrap the body of a header in #if ENABLE(FOO),
so they're always safe to include whether the features are enabled or
not.
This fixes building with --disable-database and other flags.
- GNUmakefile.am:
- 3:33 AM Changeset in webkit [52244] by
-
- 6 edits in trunk
Unreviewed. Build fixes for make distcheck.
- 3:14 AM Changeset in webkit [52243] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Gustavo Noronha Silva.
Trivial WebKit coding style fix.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
- 12:27 AM Changeset in webkit [52242] by
-
- 4 edits in trunk/WebKitTools
2009-12-17 Adam Barth <abarth@webkit.org>
Rubber stamp by Seidel.
Clean up exception handling in WorkQueue. Basically, a bunch of the
delegate messages can throw exceptions because of network errors. We
want the queues to keep on ticking instead of erroring out. That means
we want to catch generic exceptions and continue looping.
Also, cleaned up the exception handling in the EWS to properly log
failures.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/workqueue.py:
Dec 16, 2009:
- 11:52 PM Changeset in webkit [52241] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make UpdateStep quiet
https://bugs.webkit.org/show_bug.cgi?id=32599
- Scripts/modules/buildsteps.py:
- Scripts/modules/buildsteps_unittest.py:
- 11:41 PM Changeset in webkit [52240] by
-
- 4 edits in trunk/WebKitTools
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Add Gtk to the early warning system WebKit port list.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 11:40 PM Changeset in webkit [52239] by
-
- 9 edits1 copy in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
post-diff is failing with exception under guess_reviewer_from_bug
https://bugs.webkit.org/show_bug.cgi?id=32642
Also refactor output capturing code into
OutputCapture.assert_outputs to share more code between tests.
- Scripts/modules/buildsteps.py:
- Add the missing include.
- Give guess_reviewer_from_bug a private underscore.
- Scripts/modules/buildsteps_unittest.py: Added.
- Test to make sure _guess_reviewer_from_bug works as expected.
- Scripts/modules/commands/commandtest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/commands/queues_unittest.py:
- ditto
- Scripts/modules/credentials_unittest.py:
- ditto
- Scripts/modules/mock_bugzillatool.py:
- fetch_reviewed_patches_from_bug can never return None
- Scripts/modules/multicommandtool_unittest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/outputcapture.py:
- Add assert_outputs to share more code between tests.
- Scripts/run-webkit-unittests:
- Add buildsteps_unittest.py
- 11:37 PM Changeset in webkit [52238] by
-
- 2 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Unreviewed. Added a default argument to _update_status so that callers
don't have to explictly pass None when they don't have a patch object.
- Scripts/modules/commands/queues.py:
- 11:17 PM Changeset in webkit [52237] by
-
- 3 edits in trunk/WebKit/chromium
Unreviewed, build fix.
[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233
- public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 11:05 PM Changeset in webkit [52236] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().
- platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.
- 10:30 PM Changeset in webkit [52235] by
-
- 3 edits2 adds in trunk
2009-12-15 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
Test: editing/selection/doubleclick-beside-cr-span.html
- editing/TextIterator.cpp: (WebCore::collapsedSpaceLength): (WebCore::maxOffsetIncludingCollapsedSpaces): (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
- editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
- editing/selection/doubleclick-beside-cr-span.html: Added.
- 10:19 PM Changeset in webkit [52234] by
-
- 3 edits in trunk/WebCore
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix flakiness in WebSocket handshake console message.
https://bugs.webkit.org/show_bug.cgi?id=32598
In chromium, LayoutTests/websocket/tests/handshake-error.html is
flaky, because it outputs the following console message several times:
CONSOLE MESSAGE: line 0: Unexpected response code:101
Update m_mode in WebSocketHandshake correctly: Once it finds
error in handshake message, set m_mode to Failed and don't try
reading handshake message again. If handshake message is not yet
fully received, set m_mode to Incomplete, so next didReceiveData()
will try to check handshake message again.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
- 9:58 PM Changeset in webkit [52233] by
-
- 7 edits2 adds in trunk
2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of text nodes is wrong
https://bugs.webkit.org/show_bug.cgi?id=32631
<rdar://problem/7369084>
Reviewed by Alice Liu.
Test: platform/win/accessibility/text-role.html
WebCore/:
- accessibility/AccessibilityObject.h: (WebCore::): Add a new role to the enum. (WebCore::AccessibilityObject::roleValueForMSAA): Declare a function to return the accessibility role for MSAA; the base implementation returns the old role value.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): Initialize m_roleForMSAA. (WebCore::AccessibilityRenderObject::roleValueForMSAA): If m_roleForMSAA has been set, return it. If the renderer is a RenderText, set the role to EditableTextRole to match IE and Firefox. Otherwise, set the role for MSAA to the old role value.
- accessibility/AccessibilityRenderObject.h: Add a member to hold the role for MSAA, and declare an override of roleValueForMSAA().
WebKit/win/:
- AccessibleBase.cpp: (MSAARole): If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT. (AccessibleBase::role): Call roleValueForMSAA().
LayoutTests/:
- platform/win/accessibility/text-role-expected.txt: Added.
- platform/win/accessibility/text-role.html: Added. Check that the role of the text node that is the first child of the <a> tag has the "editable text" role.
- 9:30 PM Changeset in webkit [52232] by
-
- 5 edits3 adds in trunk/WebKitTools
2009-12-16 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
check-webkit-style supports for TAB check against text files.
https://bugs.webkit.org/show_bug.cgi?id=32538
- Scripts/check-webkit-style: Move process_patch() to style.py.
- Scripts/modules/cpp_style.py: Add can_handle().
- Scripts/modules/cpp_style_unittest.py: Add tests for can_handle().
- Scripts/modules/style.py: Added. This is a front-end of cpp_style and text_style. It dispatches files to an appropriate linter.
- Scripts/modules/text_style.py: Added. This is a linter module for generic text files. It supports only for TAB checking at this moment.
- Scripts/modules/text_style_unittest.py: Added. Tests for text_style.py.
- Scripts/run-webkit-unittests: Add text_style_unittest.
- 7:50 PM Changeset in webkit [52231] by
-
- 4 edits in trunk/JavaScriptCore
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code
Reviewed by Oliver Hunt.
This patch cuts Interpreter stack use by about a third.
- bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.
(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.
- 4:44 PM Changeset in webkit [52230] by
-
- 3 edits in trunk/LayoutTests
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
https://bugs.webkit.org/show_bug.cgi?id=32606
It should test with /websocket/tests/no-query
- websocket/tests/script-tests/url-with-query-for-no-query.js:
- websocket/tests/url-with-query-for-no-query-expected.txt:
- 4:41 PM Changeset in webkit [52229] by
-
- 14 edits in trunk/WebCore
2009-12-16 Eric Seidel <eric@webkit.org>
No review, rolling out r52206.
http://trac.webkit.org/changeset/52206
https://bugs.webkit.org/show_bug.cgi?id=31187
This broke pixel tests on Mac. Presumably the code in
ImageCG is wrong here.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 4:40 PM Changeset in webkit [52228] by
-
- 3 edits1 add in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635
Centralize our import logic.
- Scripts/modules/bugzilla.py: use webkit_mechanize
- Scripts/modules/statusbot.py: use webkit_mechanize
- Scripts/modules/webkit_mechanize.py: Added.
- 4:31 PM Changeset in webkit [52227] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
Test was refactored by r52226, and now it passes.
- platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.
- 4:15 PM Changeset in webkit [52226] by
-
- 3 edits in trunk/LayoutTests
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Adele Peterson.
- editing/selection/empty-cell-right-click-expected.txt:
- editing/selection/empty-cell-right-click.html:
- 4:07 PM Changeset in webkit [52225] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
- platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.
- 4:03 PM Changeset in webkit [52224] by
-
- 3 edits in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32637
[V8] Generate most named property getters.
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.
- 3:52 PM Changeset in webkit [52223] by
-
- 5 edits in trunk/WebCore
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Abstract popup menu factory.
A static method from QtAbstractPopupMenu is used to create its instances. If a factory
has been suplied to class QtAbstractPopupMenu the factory will be used to create the
objects. If not an instance of QtFallbackPopupMenu will be created.
The objective is to make it easy to replace the combobox popup at WebCore layer providing
support to the combobox popup delegation API. Future patches will make it possible to
replace the combobox popup at WebKit layer.
No behavior changes.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::setFactory): (WebCore::QtAbstractWebPopup::create):
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/QtFallbackWebPopup.cpp:
- 3:39 PM Changeset in webkit [52222] by
-
- 8 edits in trunk
Build fix. Disable debug variants of WebKit frameworks.
- 2:19 PM Changeset in webkit [52221] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Generalize commit-queue recent status page for all queues
https://bugs.webkit.org/show_bug.cgi?id=32633
- QueueStatusServer/index.html:
- Generalize to support other queues.
- QueueStatusServer/queue_status.py:
- Generalize MainPage to support other queues.
- 2:02 PM Changeset in webkit [52220] by
-
- 6 edits2 adds in trunk
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
Avoid extending the selection to the next cell if we start from an empty cell.
Test: editing/selection/empty-cell-right-click.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
- editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
- editing/htmlediting.h: Added isEmptyTableCell declaration.
LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
- editing/selection/empty-cell-right-click-expected.txt: Added.
- editing/selection/empty-cell-right-click.html: Added.
- 1:56 PM Changeset in webkit [52219] by
-
- 10 edits in trunk
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
The previous test only checked if feMerge works on empty node
without a last effect. In this case we get a source image and
everything works fine. This test also covers the case if there
is a last effect.
- platform/mac/svg/custom/empty-merge-expected.checksum:
- platform/mac/svg/custom/empty-merge-expected.png:
- platform/mac/svg/custom/empty-merge-expected.txt:
- svg/custom/empty-merge.svg:
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
SVGFEMergeElement only stored pointers to all effects of it's nodes
in a list. But it should store the RefPtr otherwise the effects get
dereferenced and WebKit crashes.
I also made a short clean-up in SVGFilterBuilder. No change in
functionality.
Test: I updated svg/custom/empty-merge.svg to cover this problem.
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::mergeInputs): (WebCore::FEMerge::setMergeInputs):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::add):
- 1:24 PM Changeset in webkit [52218] by
-
- 2 edits in trunk/WebKitTools
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Early warning system server should display output as UTF-8.
- QueueStatusServer/queue_status.py:
- 1:17 PM Changeset in webkit [52217] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/32568>.
Web Inspector: Context Menus should be used in more places.
Reviewed by Timothy Hatcher.
Add a context menu entry in the console to clear the console. This
is only shown when there is no user selection of text, because if
there is selection of the text, then we want to give the user the Copy +
Spell Check context menu that they are used to.
- English.lproj/localizedStrings.js: Added "Clear Console".
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
- 1:17 PM Changeset in webkit [52216] by
-
- 4 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add error handling to the early warning system
https://bugs.webkit.org/show_bug.cgi?id=32594
This should be the last step in making the EWS operational. When we
have a build error, we post the log to QueueStatusServer and add a link
to the bug.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/executive.py:
- 1:15 PM Changeset in webkit [52215] by
-
- 8 edits in trunk/WebKit/gtk
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Deprecate the old loading signals load-started, load-committed,
load-finished, load-progress-changed and change unit tests to use
load-status instead.
- tests/testmimehandling.c: (idle_quit_loop_cb): (test_mime_type): use notify::load-status
- tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source): (test_webkit_web_data_source_unreachable_uri): Remove uses of g_main_loop_is_running. It's an error if the loop is wrongly terminated.
- tests/testwebresource.c: (notify_load_status_cb): (test_web_resource_loading): (notify_load_status_sub_cb): (test_web_resource_sub_resource_loading): use notify::load-status
- tests/testwebview.c: (idle_quit_loop_cb): (test_webkit_web_view_icon_uri):
- tests/testwindow.c: (notify_load_status_cb): (test_webkit_window_scrollbar_policy): use notify::load-status
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): Deprecate old load signals.
- 12:59 PM Changeset in webkit [52214] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching
from / to resources panel.
Reviewed by Pavel Feldman.
Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
to cover the scope bar.
- inspector/front-end/inspector.css:
- 12:14 PM Changeset in webkit [52213] by
-
- 5 edits2 deletes in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Switch all indexers to be generated.
https://bugs.webkit.org/show_bug.cgi?id=32569
Covered by existing tests.
- WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
as they are now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
FileList, and DataGridColumnList templates.
- bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
- bindings/v8/custom/V8FileListCustom.cpp: Removed.
- 11:34 AM Changeset in webkit [52212] by
-
- 2 edits in trunk/WebCore
2009-12-16 anton muhin <antonm@chromium.org>
Reviewed by Darin Adler.
[dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
https://bugs.webkit.org/show_bug.cgi?id=32617
- dom/Node.cpp: (WebCore::Node::dumpStatistics):
- 11:25 AM Changeset in webkit [52211] by
-
- 6 edits1 delete in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] There is no such thing as HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=32616
Refactoring, covered by existing tests.
- WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
- bindings/v8/V8Collection.h: Removed one-off template.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
to HTMLSelectElement.
- bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
V8HTMLSelectElementCollectionCustom.cpp
- 11:20 AM Changeset in webkit [52210] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing bug number in ChangeLog
- 11:15 AM Changeset in webkit [52209] by
-
- 2 edits in trunk/WebKit
Brought this file up to date, sans review.
- StringsNotToBeLocalized.txt:
- 11:14 AM Changeset in webkit [52208] by
-
- 6 edits in trunk
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- configure.ac: require libsoup 2.28.2 for SoupContentDecoder
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): Don't force "Accept-Encoding: identity" any more
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
Content-Encoding support
- webkit/webkitprivate.cpp: (webkit_init): add a SoupContentDecoder feature to the session
- 11:03 AM Changeset in webkit [52207] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Take into account favicon.ico in the webresource test.
- tests/testwebresource.c: (test_web_resource_sub_resource_loading):
- 11:00 AM Changeset in webkit [52206] by
-
- 14 edits in trunk/WebCore
2009-12-16 Benjamin Otte <otte@gnome.org>
Reviewed by Darin Adler.
Get rid of the phase argument to Image::drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=31187
The argument can be expressed equally well as part of the
patternTransform. All backends but the Qt one did exactly that
manually anyway.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 10:50 AM Changeset in webkit [52205] by
-
- 5 edits in trunk/WebCore
2009-12-16 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Performance problems with index validation code for drawElements
https://bugs.webkit.org/show_bug.cgi?id=32466
Added a cache of the maximum index for each element type to
WebGLBuffer, querying it before iterating through the indices in
the client-side copy of the buffer's data. Hoisted checks of the
size of the element array itself into validateElementArraySize to
avoid duplicating code.
The performance improvement has been measured with manual tests.
Existing layout tests cover the index validation functionality
and continue to pass as before.
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData): (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex): (WebCore::WebGLBuffer::clearCachedMaxIndices):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawElements):
- html/canvas/WebGLRenderingContext.h:
- 10:43 AM Changeset in webkit [52204] by
-
- 7 edits in trunk/WebCore
2009-12-16 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32261
Added ability to separate the autocomplete suggestion previewing from
the actual accepting of the suggested value in HTMLInputElement.
This element (it's single line text incarnation) can now
be put in suggestion mode where renderer might display the suggested
value without making it automatically exposed to JavaScript.
No new tests. This new methods are not exposed yet. It's use will be
platform specific. PopupMenu and Chromium specific changes will be
separated based on Darin Adler's comments.
- dom/InputElement.h: (WebCore::InputElementData::suggestedValue): (WebCore::InputElementData::setSuggestedValue):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::suggestedValue):
- wml/WMLInputElement.h:
- 10:24 AM Changeset in webkit [52203] by
-
- 6 edits in trunk/WebCore
2009-12-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make Elements tree, properties section and resources
view monospace.
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.css:
- 10:12 AM Changeset in webkit [52202] by
-
- 3 edits4 adds in trunk
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
Check if the GraphicsContex get adjusted, if the source rect is clipped
to the filter rect.
- platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
- platform/mac/svg/filters/filter-source-position-expected.png: Added.
- platform/mac/svg/filters/filter-source-position-expected.txt: Added.
- svg/filters/filter-source-position.svg: Added.
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
On SVG Filters, the rest of the source graphic gets clipped to the filter
rest. This helps us to minimize the size of intermediate ImageBuffers. If
the position moves to the right or to the bottom, we have to adjust the
GraphicContext of this intermediate ImageBuffer.
This patch fixes the adjustment of the context, according to the clipping.
Test: svg/filters/filter-source-position.svg
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter):
- 9:59 AM Changeset in webkit [52201] by
-
- 3 edits2 adds in trunk
CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
<rdar://problem/7467108>
https://bugs.webkit.org/show_bug.cgi?id=32590
Reviewed by Adele Peterson.
WebCore:
If the element is a button there is no need to look at the children to calculate the caret position.
Test: editing/selection/button-right-click.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
when starting from a button element.
LayoutTests:
- editing/selection/button-right-click-expected.txt: Added.
- editing/selection/button-right-click.html: Added.
- 9:37 AM Changeset in webkit [52200] by
-
- 2 edits in trunk/WebKit/gtk
Rubber-stamped by Xan Lopez.
Add tab_key_cycles_through_elements to copies of
WebKitWebSettings.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_copy):
- 9:27 AM Changeset in webkit [52199] by
-
- 4 edits2 copies2 moves in trunk/WebCore
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Refactoring of class QWebPopup.
Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
Both new classes are now in corresponding files and files QWebPopup.* have been removed.
Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
public QtWebKit combobox popup delegation API.
Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
It needs to be improved to provide standard features that are missing like style or indentation.
No behavior changes.
- WebCore.pro:
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QWebPopup.cpp: Removed.
- platform/qt/QWebPopup.h: Removed.
- platform/qt/QtAbstractWebPopup.cpp: Added. (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::client):
- platform/qt/QtAbstractWebPopup.h: Added.
- platform/qt/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged):
- platform/qt/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
- 9:04 AM Changeset in webkit [52198] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] webkit_web_navigation_action_get_button() documentation
https://bugs.webkit.org/show_bug.cgi?id=25555
Small documentation improvement for webkit_web_navigation_action_get_button.
- webkit/webkitwebnavigationaction.cpp:
- 6:21 AM Changeset in webkit [52197] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=31332
[Qt] After http://trac.webkit.org/changeset/52192
there are a failing and a timeouter test.
- platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
- platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.
- 6:02 AM QtWebKit/CodeCamp200912 edited by
- Update day2 and day3 (diff)
- 5:57 AM QtWebKit/CodeCamp200912 edited by
- link to the presentation to freya and mozAfterPaint (diff)
- 5:54 AM QtWebKit/CodeCamp200912 edited by
- Update performance day 1 summary (diff)
- 2:42 AM Changeset in webkit [52196] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
of DumpRenderTree. The previously wrong expected file updated.
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.
- 2:25 AM Changeset in webkit [52195] by
-
- 2 edits in trunk/LayoutTests
Skipping a new test, and a test that fails only on the release bot,
apparently because of rouding errors.
- platform/gtk/Skipped:
- 2:06 AM Changeset in webkit [52194] by
-
- 4 edits in trunk
WebKitTools: Fix crash with tests that use custom font faces.
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=32600
In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
that custom font faces between tests don't influence each other. Calling this
function in Qt however also invalidates all existing handles with QFontDatabase.
In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
which implies a call to WebCore::FontCache::fontCache()->invalidate().
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.
Reviewed by Holger Freyther.
- platform/qt/Skipped:
- 2:05 AM Changeset in webkit [52193] by
-
- 4 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: beautify HTTP info section.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshHTTPInformation):
- inspector/front-end/inspector.css:
- 1:54 AM Changeset in webkit [52192] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Maintain button state between mouse events.
This allows eventSender to generate drag events.
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo):
- DumpRenderTree/qt/EventSenderQt.h:
- 1:52 AM Changeset in webkit [52191] by
-
- 3 edits in trunk/WebCore
Revert r52085, because it causes crashes on media tests in the release
bot.
- 1:41 AM QtWebKit edited by
- (diff)
- 1:09 AM QtWebKitContrib edited by
- (diff)
- 1:08 AM QtWebKit edited by
- (diff)
- 12:56 AM Changeset in webkit [52190] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/css/font-face-unused-source-loaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=32600
Reviewed by Simon Hausmann.
The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.
- platform/qt/Skipped: fast/css/font-face-multiple-families.html added.
- 12:53 AM QtWebKitTodo edited by
- (diff)
Dec 15, 2009:
- 11:54 PM Changeset in webkit [52189] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Code clean-up in check-webkit-style as described below.
The only functional changes are minor improvements to the
script's help output.
- Scripts/check-webkit-style:
- Added the module docstring from cpp_style.py.
- Improved wording of the --help output and added some of the default values as substitution strings.
- Called cpp_style.exit_with_usage instead of sys.stderr.write in main function.
- Made changes caused by changes to cpp_style.py.
- Scripts/modules/cpp_style.py:
- Removed module docstring, as well as redundant _USAGE string and main() function obsoleted by check-webkit-style.
- Moved specification of default script values from within a function definition to global variables.
- Moved the default webkit filter rules to be near the other global variables.
- Renamed "FILTER" global variables to "FILTER_RULES" to establish unambiguous terminology.
- Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
- Changed _STYLE_CATEGORIES from a string to a list.
- Added default webkit filter rules to --filter= output.
- Renamed "print_" methods to "exit_with_" since they exist and added a temporary display_help parameter.
- Added a temporary display_help parameter to parse_arguments.
- Scripts/modules/cpp_style_unittest.py:
- Made changes caused by changes to cpp_style.py.
- Lower-cased ErrorCollector's ERROR_CATEGORIES instance variables since they are not global.
- 11:21 PM Changeset in webkit [52188] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue.
Typo: _updates_status -> _update_status
We need to improve our testing infrastructure for the queues.
- Scripts/modules/commands/queues.py:
- 11:05 PM Changeset in webkit [52187] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue. I suspect this is a recent
regression from Eric's change below.
- Scripts/modules/commands/queues.py:
- 7:12 PM Changeset in webkit [52186] by
-
- 5 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adele Peterson.
Make SunSpider version more prominent in the title
https://bugs.webkit.org/show_bug.cgi?id=32574
- hosted/sunspider.html:
- hosted/versions.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:26 PM Changeset in webkit [52185] by
-
- 3 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Make SunSpider refuse to compare results across content versions
https://bugs.webkit.org/show_bug.cgi?id=32573
The results URL now includes a version indicator, and compare mode
will refuse to compare between versions.
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:02 PM Changeset in webkit [52184] by
-
- 4 edits2 adds in trunk
Fix crash when encountering illegal HTML within a continuation inside <ruby>.
(https://bugs.webkit.org/show_bug.cgi?id=32316)
Reviewed by Adam Barth.
Avoid having the anonymous blocks utilized in the ruby renderers being
re-used as continuation blocks.
Avoid having ruby runs collected as "leftover blocks".
Test: fast/ruby/ruby-illegal.html
WebCore:
- rendering/RenderRuby.h:
(WebCore::RenderRubyAsInline::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsInline::isRuby): made private
(WebCore::RenderRubyAsInline::renderName): made private
(WebCore::RenderRubyAsInline::createsAnonymousWrapper): return true
(WebCore::RenderRubyAsBlock::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsBlock::isRuby): made private
(WebCore::RenderRubyAsBlock::renderName): made private
(WebCore::RenderRubyAsBlock::createsAnonymousWrapper): return true
- rendering/RenderRubyRun.h:
(WebCore::RenderRubyRun::removeLeftoverAnonymousBlock): avoid
(WebCore::RenderRubyRun::isRubyRun): made private
(WebCore::RenderRubyRun::renderName): made private
(WebCore::RenderRubyRun::createsAnonymousWrapper): return true
LayoutTests:
- fast/ruby/ruby-illegal-expected.txt: Added.
- fast/ruby/ruby-illegal.html: Added.
- 4:51 PM Changeset in webkit [52183] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
update-webkit-chromium to auto-install gclient
- Scripts/update-webkit-chromium:
- 4:04 PM Changeset in webkit [52182] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32498
<rdar://problem/7471495>
REGRESSION(r51978-r52039): AJAX "Mark This Forum Read" function no longer
works
Reviewed by Sam "r=me" Weinig.
Fixed a tyop.
- runtime/Operations.h:
(JSC::jsAdd): Use the '&&' operator, not the ',' operator.
- 3:53 PM Changeset in webkit [52181] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/WebKit.vcproj
Add delay load of QuartzCore.dll and QuartzCoreInterface.dll to fix Windows build
- 3:47 PM Changeset in webkit [52180] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
https://bugs.webkit.org/show_bug.cgi?id=32546
You can see an example of this working in:
https://bugs.webkit.org/show_bug.cgi?id=32585#c3
- QueueStatusServer/queue_status.py:
- Output the id of the newly created status.
- Scripts/modules/commands/queues.py:
- Tweak the commit-queue logging to include a full status link.
- Scripts/modules/statusbot.py:
- update_status should return the newly created status id.
- 3:44 PM Changeset in webkit [52179] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix the windows build: don't export this inlined function.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:33 PM Changeset in webkit [52178] by
-
- 4 edits in trunk/JavaScriptCore
Inlined JSCell's operator new.
Reviewed by Beth Dakin.
3.7% speedup on bench-allocate-nonretained.js.
- JavaScriptCore.exp:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
(JSC::JSCell::operator new):
- 3:02 PM BuildingQtOnWindows edited by
- Replaced outdated Trolltech website link to Qt download with Nokia link (diff)
- 3:02 PM Changeset in webkit [52177] by
-
- 14 edits in trunk/WebCore
2009-12-15 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Rename skipCanLoadCheck to skipSecurityCheck in a bunch of places in WebCore/loader.
- loader/Cache.cpp: (WebCore::Cache::requestUserCSSStyleSheet):
- loader/CachedImage.cpp: (WebCore::CachedImage::load):
- loader/CachedResource.cpp: (WebCore::CachedResource::load):
- loader/CachedResource.h: (WebCore::CachedResource::load):
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- loader/Request.cpp: (WebCore::Request::Request):
- loader/Request.h: (WebCore::Request::shouldDoSecurityCheck):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 2:40 PM Changeset in webkit [52176] by
-
- 7 edits in trunk/JavaScriptCore
Removed the number heap, replacing it with a one-item free list for
numbers, taking advantage of the fact that two number cells fit inside
the space for one regular cell, and number cells don't require destruction.
Reviewed by Oliver Hunt.
SunSpider says 1.6% faster in JSVALUE32 mode (the only mode that
heap-allocates numbers).
SunSpider says 1.1% faster in JSVALUE32_64 mode. v8 says 0.8% faster
in JSVALUE32_64 mode. 10% speedup on bench-alloc-nonretained.js. 6%
speedup on bench-alloc-retained.js.
There's a lot of formulaic change in this patch, but not much substance.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlockPtr):
(JSC::Heap::freeBlocks):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
(JSC::Heap::sweep):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics):
(JSC::Heap::isBusy):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
- runtime/Collector.h:
(JSC::): Removed all code pertaining to the number heap, and changed all
heap template functions and classes to non-template functions and classes.
(JSC::Heap::allocateNumber): A new optimization to replace the number
heap: allocate half-sized number cells in pairs, returning the first
cell and caching the second cell for the next allocation.
- runtime/CollectorHeapIterator.h:
(JSC::LiveObjectIterator::LiveObjectIterator):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::DeadObjectIterator):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::ObjectIterator):
(JSC::ObjectIterator::operator++):
- runtime/JSCell.h:
(JSC::JSCell::isNumber): Removed all code pertaining to the number heap,
and changed all heap template functions and classes to non-template functions
and classes.
- 2:18 PM Changeset in webkit [52175] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/utils3d.js
updated WebGL demos to latest spec
- 2:12 PM Changeset in webkit [52174] by
-
- 4 edits2 adds in trunk
<rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
https://bugs.webkit.org/show_bug.cgi?id=32257
Reviewed by Darin Adler.
WebCore:
Test: fast/css/font-face-unused-source-loaded.html
The loading of a font resource caused a CSSFontFace that had the resource in one of its
sources, but wasn’t using it (due to using an earlier source) to invalidate its
CSSSegmentedFontFaces. This caused FontData for the active source (the one that did not just
finish loading) to be deleted, but that went unnoticed by Font::operator==(), since the
corresponding FontFallbackLists were not in the loading state. The fix is for CSSFontFace to
ignore loads from unused sources.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Bail out if the loaded source is not the active source.
(WebCore::CSSFontFace::getFontData): Set m_activeSource to the source that supplied the
FontData.
- css/CSSFontFace.h:
(WebCore::CSSFontFace::CSSFontFace): Initialize m_activeSource.
LayoutTests:
- fast/css/font-face-unused-source-loaded-expected.txt: Added.
- fast/css/font-face-unused-source-loaded.html: Added.
- 2:12 PM Changeset in webkit [52173] by
-
- 1 delete in trunk/WebCore/manual-tests/webgl
Getting rid of out of date WebGL tests
- 2:07 PM Changeset in webkit [52172] by
-
- 4 edits in trunk/WebCore
2009-12-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cannot load flash files from a local file.
https://bugs.webkit.org/show_bug.cgi?id=32572
When loading the main resource and its mime type is application/octet-stream,
use the file extenstion to check if it is a supported plugin.
No new tests were added since any existing swf file can be used as a manual test.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- loader/MainResourceLoader.h:
- plugins/PluginDatabase.h:
- 1:55 PM Changeset in webkit [52171] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WeakGCMap class
https://bugs.webkit.org/show_bug.cgi?id=32547
Inherits WeakGCMap from FastAllocBase because it is instantiated by
'new' at: WebCore/dom/Document.cpp:512.
- runtime/WeakGCMap.h:
- 1:52 PM Changeset in webkit [52170] by
-
- 5 edits4 deletes in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
REGRESSION: Tips are not shown for resources anymore.
Reviewed by Timothy Hatcher.
As discussed in the bug, Tips are not coming back, and the feature
will be moved to the audits panel. This patch is to remove the Tips
code and the resources that it needed.
- WebCore.gypi: Removed tips files.
- inspector/front-end/Images/tipBalloon.png: Removed.
- inspector/front-end/Images/tipBalloonBottom.png: Removed.
- inspector/front-end/Images/tipIcon.png: Removed.
- inspector/front-end/Images/tipIconPressed.png: Removed.
- inspector/front-end/Resource.js: Removed tips code.
(WebInspector.Resource.prototype.set finished):
- inspector/front-end/WebKit.qrc: Removed tips files.
- inspector/front-end/inspector.css: Removes tips style rules.
- 1:44 PM Changeset in webkit [52169] by
-
- 4 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Display request headers for main resource
having redirects.
- inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::createCached): (WebCore::InspectorResource::updateRequest):
- inspector/InspectorResource.h: (WebCore::InspectorResource::create):
- 1:35 PM Changeset in webkit [52168] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
Web Inspector: No Need for ?="" now that we have context menus.
Reviewed by Timothy Hatcher.
Remove the toggleNewAttributeButton function and callers to it, as
we don't need this behavior anymore, now that we have context menus.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.set hovered):
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
(WebInspector.ElementsTreeElement.prototype._startEditing):
- 12:15 PM Changeset in webkit [52167] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Fixed typos
- 11:55 AM Changeset in webkit [52166] by
-
- 4 edits in trunk/WebCore
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate trivial named property getters.
https://bugs.webkit.org/show_bug.cgi?id=32562
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationNamedPropertyGetter.
- bindings/v8/V8Collection.h: (WebCore::getNamedPropertyOfCollection): Fixed a booboo by using AtomicString like we're supposed to.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed code that's now generated.
- 11:51 AM Changeset in webkit [52165] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/32568>.
New Web Inspector: The Context Menu should be used in more places.
Reviewed by Timothy Hatcher.
Add support for context menu entries for editing and deleting elements
in the datagrid. This gives support to deleting cookies, and editing and
deleting session storage and local storage.
- English.lproj/localizedStrings.js: Added "Edit" and "Add New" entries (delete was already there)
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid): Added context menu listener.
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- 11:08 AM Changeset in webkit [52164] by
-
- 10 edits in trunk
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- fast/canvas/webgl/error-reporting-expected.txt:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/script-tests/error-reporting.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bindFramebuffer):
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::bindFramebuffer):
- 10:50 AM Changeset in webkit [52163] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for FontPlatformDataCacheKey class
https://bugs.webkit.org/show_bug.cgi?id=32552
Inherits the following struct from FastAllocBase because it is instantiated by 'new':
struct name - instantiated at: WebCore/'location'
struct FontPlatformDataCacheKey - platform/graphics/FontCache.cpp:118
- platform/graphics/FontCache.cpp:
- 10:43 AM Changeset in webkit [52162] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for dtoa's P5Node struct
https://bugs.webkit.org/show_bug.cgi?id=32544
Inherits P5Node struct from Noncopyable because it is instantiated by
'new' at wtf/dtoa.cpp:588 and don't need to be copyable.
- wtf/dtoa.cpp:
- 10:14 AM Changeset in webkit [52161] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Add TreeGridRole to catch up with
http://trac.webkit.org/changeset/52159.
- public/WebAccessibilityRole.h: (WebKit::): Added WebAccessibilityRoleTreeGrid.
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 10:13 AM Changeset in webkit [52160] by
-
- 7 edits in trunk
Bug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
https://bugs.webkit.org/show_bug.cgi?id=31090
Reviewed by Dmitry Titov.
The proposal to whatwg can be found here:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022118.html
WebCore:
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::setData):
WebKit/chromium:
- public/WebDragData.h:
- src/WebDragData.cpp:
(WebKit::WebDragData::downloadURL):
(WebKit::WebDragData::setDownloadURL):
- 10:13 AM BuildBot edited by
- (diff)
- 10:07 AM Changeset in webkit [52159] by
-
- 13 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 9:09 AM Changeset in webkit [52158] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for EmptyEditorClient and EmptyInspectorClient
https://bugs.webkit.org/show_bug.cgi?id=32557
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class EmptyEditorClient - svg/graphics/SVGImage.cpp:230
class EmptyInspectorClient - svg/graphics/SVGImage.cpp:241
- loader/EmptyClients.h:
- 9:02 AM Changeset in webkit [52157] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/inspector directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32556
Inherits the following class from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class InspectorFrontend - inspector/InspectorController.cpp:538
class InspectorTimelineAgent - inspector/InspectorController.cpp:1097
- inspector/InspectorFrontend.h:
- inspector/InspectorTimelineAgent.h:
- 8:54 AM Changeset in webkit [52156] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/platform/network directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32553
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
struct CrossThreadResourceResponseData - platform/network/ResourceResponseBase.cpp:109
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class ResourceResponseBase - (its child class) platform/network/ResourceResponseBase.cpp:90
class ResourceRequestBase - (its child class) loader/DocumentThreadableLoader.cpp:88
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- 8:44 AM Changeset in webkit [52155] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
https://bugs.webkit.org/show_bug.cgi?id=32549
Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
AnimationControllerPrivate - page/animation/AnimationController.cpp:439
FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464
- page/animation/AnimationBase.cpp:
- page/animation/AnimationControllerPrivate.h:
- 8:36 AM Changeset in webkit [52154] by
-
- 7 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not lose HTTP redirect information, display it
in the Resources Panel.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject): (WebCore::InspectorResource::type):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::Changes::setAll):
- inspector/front-end/inspector.js: (WebInspector._addResource): (WebInspector.updateResource):
- 8:17 AM Changeset in webkit [52153] by
-
- 2 edits in trunk/WebCore
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=32113
For Qt versions prior to 4.6.1 we will need to use QueuedConnection
for the signal and slot connection to avoid running into a bug in.
Add a comment that we want to remove one signal to forward
queued items when moving our minimum requirements.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
- 8:17 AM Changeset in webkit [52152] by
-
- 4 edits1 add in trunk
[Qt] Fix JavaScript prompt behavior for empty/null strings.
https://bugs.webkit.org/show_bug.cgi?id=30914
The patch is based on the work done by Gupta Manish.
In the default implementation of the JavaScript prompt
we are using a QInputDialog to get the text and this has
one quirk with regard to not entering any text.
In other WebKit ports and in Firefox an empty string is
returned but in the Qt case it is a null string.
Change the API documentation in QWebPage to mention we want to
have a non null string but do the fixup in the ChromeClientQt
to support existing code.
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::javaScriptPrompt): Change API documentation
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fixup null QString
WebCore:
- manual-tests/qt/java-script-prompt.html: Added.
- 8:13 AM Changeset in webkit [52151] by
-
- 5 edits in trunk/WebCore
2009-12-15 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Moving list populate methods from PopupMenuQt to QWebPopup.
In preparation to future implementation of a delegation API for the combobox.
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
- platform/qt/QWebPopup.cpp: (WebCore::QWebPopup::show): (WebCore::QWebPopup::populate):
- platform/qt/QWebPopup.h: (WebCore::QWebPopup::hide):
- 6:18 AM Changeset in webkit [52150] by
-
- 5 edits5 moves in trunk/WebKitTools
[Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-15
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTree.h: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Updated.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
- DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
(GCController::GCController):
- DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/WorkQueueItem.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
- DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
- DumpRenderTree/qt/jsobjects.cpp: Removed.
- DumpRenderTree/qt/jsobjects.h: Removed.
- DumpRenderTree/qt/main.cpp: Updated includes.
- 4:20 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 4:14 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 4:08 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 3:29 AM Changeset in webkit [52149] by
-
- 6 edits1 copy in trunk/WebCore
2009-12-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Extract WebInspector.Section from WebInspector.PropertiesSection.
https://bugs.webkit.org/show_bug.cgi?id=32523
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/Section.js: Added. (WebInspector.Section): (WebInspector.Section.prototype.get title): (WebInspector.Section.prototype.set title): (WebInspector.Section.prototype.get subtitle): (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get expanded): (WebInspector.Section.prototype.set expanded): (WebInspector.Section.prototype.get populated): (WebInspector.Section.prototype.set populated): (WebInspector.Section.prototype.expand): (WebInspector.Section.prototype.collapse): (WebInspector.Section.prototype.toggleExpanded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:12 AM Changeset in webkit [52148] by
-
- 3 edits1 delete in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
We have two mark-fixed commands
https://bugs.webkit.org/show_bug.cgi?id=32073
- Scripts/mark-bug-fixed: Removed.
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 2:39 AM Changeset in webkit [52147] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
https://bugs.webkit.org/show_bug.cgi?id=28286
- QueueStatusServer/index.html:
- Show [results] links if a results log was uploaded.
- QueueStatusServer/queue_status.py:
- Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
- Scripts/modules/commands/queues.py:
- Post to the status bot when a patch fails and include the failure log as a results file.
- 2:32 AM QtWebKit/CodeCamp200912Teams created by
- 2:18 AM Changeset in webkit [52146] by
-
- 12 edits2 deletes in trunk
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- platform/mac/accessibility/aria-treegrid-expected.txt: Removed.
- platform/mac/accessibility/aria-treegrid.html: Removed.
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridRow.cpp:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isMultiSelect): (WebCore::AccessibilityRenderObject::setIsExpanded): (WebCore::AccessibilityRenderObject::setSelectedRows): (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows): (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren): (WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- 2:07 AM Changeset in webkit [52145] by
-
- 8 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queue sub-commands need --status-host so they can report status
https://bugs.webkit.org/show_bug.cgi?id=32313
Make --status-bot a global option and make
run_bugzilla_tool pass --status-bot to sub-commands.
- Scripts/bugzilla-tool:
- Rename _status to status_bot and make it non-lazy.
- Scripts/modules/commands/queues.py:
- Move status updates out of WorkQueue and into individual queues.
- Scripts/modules/commands/queues_unittest.py:
- Test that --status-host is passed to bugzilla-tool when run as subcommand.
- Scripts/modules/mock_bugzillatool.py:
- Add a MockStatusBot
- Scripts/modules/workqueue.py:
- Remove status_host and work_work_logs_directory callbacks.
- Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
- Scripts/modules/workqueue_unittest.py:
- Update unit tests to reflect new callbacks.
- 1:29 AM Changeset in webkit [52144] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Do not disable the inspector on show and hide
https://bugs.webkit.org/show_bug.cgi?id=31851
On Qt/X11 with some window managers the window will be
hidden when switching windows. In this case all the results
are gone when coming back to the window.
Attempt to use the CloseEvent to figure out if the window
was closed and withdrawn as this is more friendly to the
user of the inspector client.
- Api/qwebinspector.cpp:
(QWebInspector::hideEvent):
(QWebInspector::closeEvent):
- Api/qwebinspector.h:
- 1:29 AM Changeset in webkit [52143] by
-
- 2 edits in trunk/WebCore
[Qt] Remove dead code from FontPlatformDataQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=32540
In r51758 the code that used familyNames was removed
and we should remove the creation of the familyNames
as well.
- platform/graphics/qt/FontPlatformDataQt.cpp:
- 12:57 AM Changeset in webkit [52142] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm_unittest.py is too slow
https://bugs.webkit.org/show_bug.cgi?id=31818
Now we don't run the SCM unit tests unless we get the --all flag on the
command line. Eric and I were commenting out this test because it was
too painful to run.
- Scripts/run-webkit-unittests:
- 12:17 AM Changeset in webkit [52141] by
-
- 10 edits in trunk
Reviewed by Adam Roben.
WebCore:
WebCore part of <rdar://problem/7173515> Use LOGFONT support in Core
Graphics when available
When using a version of Core Graphics with LOGFONT support, this fixes
<rdar://problem/5764844> First-time launch is painfully slow due to font
plist creation
and <rdar://problem/6576281> 12px synthetic-italics Tahoma text is less
readable in Safari than in Firefox/IE due to poorly-spaced letters
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): No longer call drawGDIGlyphs for stroked text.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added a synthesizeItalic parameter. When set to true, if italics are desired but the best match lacks italics, creates and returns a synthetic italics font. (WebCore::FontCache::createFontPlatformData): Ask to synthesize italics if needed.
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Updated an assertion, and changed to create the CGFont from the LOGFONT. (WebCore::createFontCustomPlatformData): Changed cgFont to be a RetainPtr. Do not create a CGFont from the font data if it can be created from the LOGFONT in fontPlatformData().
- platform/graphics/win/FontDatabase.cpp: (WebCore::populateFontDatabase): Avoid font database work if fonts are not going to be looked up by name.
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit): Create the CGFont from a LOGFONT based on the HFONT.
WebKitLibraries:
WebKitSystemInterface part of <rdar://problem/7173515> Use LOGFONT support in
Core Graphics when available
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Declared
wkCanCreateCGFontWithLOGFONT().
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
Dec 14, 2009:
- 11:31 PM Changeset in webkit [52140] by
-
- 12 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 10:44 PM Changeset in webkit [52139] by
-
- 6 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Some Browser-hosted SunSpider files are not valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=32536
Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
close tags and adding a meta charset declaration).
- hosted/sunspider.html:
- hosted/versions.html:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 10:25 PM Changeset in webkit [52138] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Fix failing unittest.
- Scripts/modules/bugzilla_unittest.py:
- 10:24 PM Changeset in webkit [52137] by
-
- 4 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Make sunspider-0.9.1 the default content set (both command-line and hosted)
https://bugs.webkit.org/show_bug.cgi?id=32537
- hosted/sunspider.html: Change default suite link.
- sunspider: Change default suite.
- sunspider-compare-results: Likewise.
- 10:16 PM Changeset in webkit [52136] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Kill _create_step_sequence
https://bugs.webkit.org/show_bug.cgi?id=32539
It's cleaner to represent not having these sequences as an empty
sequence instead of None.
- Scripts/modules/commands/download.py:
- Scripts/modules/stepsequence.py:
- 10:00 PM Changeset in webkit [52135] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-12-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move Credential handling out into a separate module
https://bugs.webkit.org/show_bug.cgi?id=32531
- Scripts/modules/bugzilla.py:
- Scripts/modules/credentials.py: Added.
- Scripts/modules/credentials_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 9:53 PM Changeset in webkit [52134] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Address reviewer comments from an earlier patch. I didn't
do this earlier because I was worried about conflicts in dependent
patches.
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52133] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make download commands declarative
https://bugs.webkit.org/show_bug.cgi?id=32469
This patch "properly" factors most of the download commands. These
commands are now largely declarative, which is the final step of this
grand refactoring.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52132] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add AbstractPatchSequencingCommand to remove redundant code
https://bugs.webkit.org/show_bug.cgi?id=32468
Redundant code is bad. This patch moves us towards more declarative
commands.
- Scripts/modules/commands/download.py:
- 9:32 PM Changeset in webkit [52131] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitApplyingScripts
https://bugs.webkit.org/show_bug.cgi?id=32467
Ah! I've been wanting to do this for a long time. This patch brings
the applying commands into the patch processing fold.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:31 PM Changeset in webkit [52130] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert rollout to StepSequence
https://bugs.webkit.org/show_bug.cgi?id=32406
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:21 PM Changeset in webkit [52129] by
-
- 5 edits1 delete in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=32464
Removes LandingSequence in favor of StepSequence. This required
changing the Step API slightly to carry a general notion of state
instead of carrying patches specifically.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py: Removed.
- Scripts/modules/stepsequence.py:
- 7:27 PM Changeset in webkit [52128] by
-
- 4 edits1 delete in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
in-browser SunSpider suffers excessive penalty under power management
https://bugs.webkit.org/show_bug.cgi?id=32505
I have made a few changes to address this:
1) Change how browser-hosted SunSpider loads tests - preload the content and write it in with
document.write to reduce triggering of progress UI.
2) Reduce time between tests to 10ms from 500ms, so that power management doesn't keep the CPU
stepped all the way down the whole time.
3) Run the test cycle an extra time for warmup before the runs that count.
- hosted/sunspider-record-result.js: Removed.
- make-hosted:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- 7:05 PM Changeset in webkit [52127] by
-
- 3 edits4 adds in trunk
<rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
https://bugs.webkit.org/show_bug.cgi?id=32382
Reviewed by Darin Adler.
WebCore:
Test: fast/block/float/in-margin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
they are in the margin) do not need to be cleared.
LayoutTests:
- fast/block/float/in-margin.html: Added.
- platform/mac/fast/block/float/in-margin-expected.checksum: Added.
- platform/mac/fast/block/float/in-margin-expected.png: Added.
- platform/mac/fast/block/float/in-margin-expected.txt: Added.
- 5:14 PM Changeset in webkit [52126] by
-
- 3 edits2 adds in trunk
Pressing backspace inside a table cell erases all empty rows below it.
<rdar://problem/5565461>
https://bugs.webkit.org/show_bug.cgi?id=32526
Reviewed by John Sullivan.
WebCore:
No deletion is performed when the caret selection is on an empty table cell.
Test: editing/deleting/delete-empty-table.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
case of caret selection.
LayoutTests:
- editing/deleting/delete-empty-table-expected.txt: Added.
- editing/deleting/delete-empty-table.html: Added.
- 4:19 PM Changeset in webkit [52125] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Brady Eidson.
Add two http iFrame dynamic form tests to the Windows Skipped
list.
- platform/win/Skipped:
- 2:45 PM Changeset in webkit [52124] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-14 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32347
Chromium: Context menu launched by menu key has funky behavior
Make the context menu's position depend on the selection only when an
editable field has focus. Also, don't send multiple context menu events
for a single keypress.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent):
- 2:38 PM Changeset in webkit [52123] by
-
- 1 edit2 adds in trunk/WebCore
2009-12-14 Andrei Popescu <andreip@google.com>
Reviewed by Darin Adler.
[Android] Android needs ResourceHandle implementation
https://bugs.webkit.org/show_bug.cgi?id=32515
Adds implementation of ResourceHandle on Android.
No new tests needed, this is platform-specific code, so existing
tests are sufficient.
- platform/network/android/ResourceHandleAndroid.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked): (WebCore::SyncLoader::SyncLoader): (WebCore::SyncLoader::~SyncLoader): (WebCore::SyncLoader::didReceiveResponse): (WebCore::SyncLoader::didReceiveData): (WebCore::SyncLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/android/ResourceLoaderAndroid.h: Added. (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid): (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
- 2:30 PM Changeset in webkit [52122] by
-
- 2 edits in trunk/WebCore
2009-12-14 Marco Martin <notmart@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
In the Scrollbar painting of the Qt theme integration,
intersects any previous clip rects with the one needed to paint the scrollbar.
This fixes the painting in QGraphicsview, when the parent of the widget that
paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
a piece of the scrollbar should be cipped away
https://bugs.webkit.org/show_bug.cgi?id=30366
No new tests.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
- 2:23 PM Changeset in webkit [52121] by
-
- 2 edits in trunk/WebKit/win
Provide working printing support for WinCairo port.
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Conditionalize initialization of
PlatformGraphicsContext handling for CG vs. Cairo.
(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.
- 2:17 PM Changeset in webkit [52120] by
-
- 4 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate bindings for trivial indexers.
https://bugs.webkit.org/show_bug.cgi?id=32455
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
Added detecting indexers and generating code for them.
- bindings/v8/V8Collection.h: Removed code that's now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Ditto.
- 2:16 PM Changeset in webkit [52119] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Darin Fisher.
Make changing-frame-hierarchy-in-onload.html less flaky and
platform-independent.
https://bugs.webkit.org/show_bug.cgi?id=32319
- http/tests/navigation/changing-frame-hierarchy-in-onload.html:
- 2:09 PM Changeset in webkit [52118] by
-
- 6 edits in trunk
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- platform/qt/Skipped:
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::notifyDone): (LayoutTestController::provisionalLoad):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::resetLoadFinished):
- 1:57 PM Changeset in webkit [52117] by
-
- 4 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Bug 32519 - mouseEvent fires mutiple times in
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml
Add test to Qt skipped list (was passing due to bug in DRT, see
https://bugs.webkit.org/show_bug.cgi?id=32437). Updated detail on bug
in gtk and win skipped lists.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:47 PM Changeset in webkit [52116] by
-
- 7 edits2 adds in trunk
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=31660
REGRESSION (r49394): Image load event fires before the document fragment is attached.
Test: fast/images/image-load-event-in-fragment.html
We cannot fire load events immediately after parsing a fragment - an element inserted via
innerHTML or equivalent should be reachable via getElementById() by the time its load event
fires.
- dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents() and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just preserving existing behavior.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Load events for elements that have just been parsed cannot be dispatched yet, we should give the elements a chance to be inserted into a document first. There is no compatibility baggage for beforeload, so it seems OK to dispatch it right away.
- loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): (WebCore::ImageLoader::dispatchPendingLoadEvents):
- loader/ImageLoader.h: Separated dispatchPendingEvents() into individual functions for each event kind.
- 1:27 PM Changeset in webkit [52115] by
-
- 3 edits in trunk/WebCore
2009-12-14 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Simon Fraser.
Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=30442
This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.
- platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
- platform/graphics/FloatQuad.h:
- 1:08 PM Changeset in webkit [52114] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add two XSS tests that intermittently time out to the Windows
Skipped list.
- platform/win/Skipped:
- 12:57 PM Changeset in webkit [52113] by
-
- 13 edits in trunk
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Extend basic touch event test with a simple keyboard modifier test.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to TouchEvent
Similar to other ui events with keyboard state, get the alt, shift,
meta and ctrl modifiers straight from the platform event.
- dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: (WebCore::TouchEvent::create):
- dom/TouchEvent.idl:
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::shiftKey): (WebCore::PlatformTouchEvent::ctrlKey): (WebCore::PlatformTouchEvent::altKey): (WebCore::PlatformTouchEvent::metaKey):
- platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::setTouchModifier): (EventSender::clearTouchPoints): (EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:49 PM Changeset in webkit [52112] by
-
- 2 edits in trunk/WebCore
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] crash when clicking "Sign out" in GMail
https://bugs.webkit.org/show_bug.cgi?id=32300
When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
This complete r29515
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 12:42 PM Changeset in webkit [52111] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor tst_qwebelement to remove the qWait()
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 12:35 PM Changeset in webkit [52110] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
Fix the QWebPage inputMethods() autotest after r51758
to compare the Qt::ImFont property's family against an explicitly
previously configured family.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:28 PM Changeset in webkit [52109] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
access-control-basic-denied-preflight-cache.html fails manual testing.
LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
fails manual testing. It passes the automatic layout tests in Qt due to a bug with
notifyDone (see https://bugs.webkit.org/show_bug.cgi?id=32437).
Performing the test manually in QtLauncher shows that an exception is received.
Add access-control-basic-denied-preflight-cache.html to the Qt skipped list.
- platform/qt/Skipped:
- 12:21 PM Changeset in webkit [52108] by
-
- 3 edits in trunk/WebCore
2009-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
https://bugs.webkit.org/show_bug.cgi?id=32517
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluateOnSelf):
- inspector/front-end/InjectedScriptAccess.js:
- 12:13 PM Changeset in webkit [52107] by
-
- 3 edits in trunk/WebCore
2009-12-14 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML enabled builds.
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser):
- wml/WMLInputElement.h:
- 12:06 PM Changeset in webkit [52106] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Add missing newline at end of test result.
- platform/mac-tiger/media/video-no-audio-expected.txt:
- 12:01 PM Changeset in webkit [52105] by
-
- 1 edit3 adds in trunk/WebCore
[Android] Android needs ResourceError, ResourceResponse and
ResourceRequest implementation.
https://bugs.webkit.org/show_bug.cgi?id=32522
Patch by Andrei Popescu <andreip@google.com> on 2009-12-14
Reviewed by Darin Adler.
Add implementation of ResourceError, ResourceResponse and ResourceRequest.
No new tests needed, the existing tests should be sufficient.
- platform/network/android/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
- platform/network/android/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setUserGesture):
(WebCore::ResourceRequest::getUserGesture):
- platform/network/android/ResourceResponse.h: Added.
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::doUpdateResourceResponse):
- 11:38 AM Changeset in webkit [52104] by
-
- 3 edits in trunk/WebCore
Fix the build.
- page/Geolocation.cpp:
- page/Geolocation.h:
- 11:26 AM Changeset in webkit [52103] by
-
- 24 edits5 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider
Reviewed by Dan Bernstein.
Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.
WebCore:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/Geolocation.cpp:
(WebCore::createGeopositionFromGeolocationPosition):
(WebCore::createPositionErrorFromGeolocationError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::fatalErrorOccurred):
(WebCore::Geolocation::requestTimedOut):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::makeSuccessCallbacks):
(WebCore::Geolocation::errorOccurred):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- page/Geolocation.h:
- page/GeolocationController.cpp: Added.
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::lastPosition):
- page/GeolocationController.h: Added.
- page/GeolocationControllerClient.h: Added.
(WebCore::GeolocationControllerClient::~GeolocationControllerClient):
- page/GeolocationError.h: Added.
(WebCore::GeolocationError::):
(WebCore::GeolocationError::create):
(WebCore::GeolocationError::code):
(WebCore::GeolocationError::message):
- page/GeolocationPosition.h: Added.
(WebCore::GeolocationPosition::create):
(WebCore::GeolocationPosition::timestamp):
(WebCore::GeolocationPosition::latitude):
(WebCore::GeolocationPosition::longitude):
(WebCore::GeolocationPosition::accuracy):
(WebCore::GeolocationPosition::altitude):
(WebCore::GeolocationPosition::altitudeAccuracy):
(WebCore::GeolocationPosition::heading):
(WebCore::GeolocationPosition::speed):
(WebCore::GeolocationPosition::canProvideAltitude):
(WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
(WebCore::GeolocationPosition::canProvideHeading):
(WebCore::GeolocationPosition::canProvideSpeed):
(WebCore::GeolocationPosition::GeolocationPosition):
- page/Geoposition.h:
(WebCore::Geoposition::create):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::geolocationController):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
- 11:10 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 10:45 AM Changeset in webkit [52102] by
-
- 3 edits3 adds in trunk
2009-12-14 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Test that an image's size is valid before reading it.
Previously, an image that failed to load (m_failed == true) would
trigger an assertion failure when WebKit tried to get its size.
https://bugs.webkit.org/show_bug.cgi?id=32176
http://code.google.com/p/chromium/issues/detail?id=28566
Test: fast/images/size-failure.html
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 10:40 AM Changeset in webkit [52101] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests
Reviewed by Simon Fraser.
- wtf/StdLibExtras.h:
(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.
- 10:04 AM Changeset in webkit [52100] by
-
- 3 edits2 adds in trunk
<rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
RenderWidget::setWidgetGeometry()
Reviewed by Darin Adler.
WebCore:
Test: fast/forms/defer-updateFromElement.html
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback): Added this post-attach callback
that invokes updateFromElement().
(WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
updateFromElement(), enqueue a post-attach (in this case, post-style
recalc) callback to do it. updateFromElement() can cause the selection
to change, and in turn trigger synchronous layout, so it must not be
called during style recalc.
LayoutTests:
- fast/forms/defer-updateFromElement-expected.txt: Added.
- fast/forms/defer-updateFromElement.html: Added.
- 10:01 AM Changeset in webkit [52099] by
-
- 18 edits in trunk/WebCore
2009-12-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [regression] inspector deletes nodes when editing css.
Now all the treeoutlines are focusable, sections and their titles
are also focusable. Change contains couple of drive-by fixes such as
canceling of the attribute edit nuking attr info and maintaining proper
selection while deleting nodes.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.get defaultFocusedElement): (WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.get defaultFocusedElement):
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype.handleShortcut):
- inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane): (WebInspector.SidebarPane.prototype.toggleExpanded): (WebInspector.SidebarPane.prototype._onTitleKeyDown):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentCanCopy): (WebInspector.documentCopy): (WebInspector._searchFieldManualFocus): (WebInspector._searchKeyDown): (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
- inspector/front-end/treeoutline.js: (TreeOutline): (TreeOutline._removeChildAtIndex): (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.deselect):
- inspector/front-end/utilities.js: ():
- 9:46 AM Changeset in webkit [52098] by
-
- 2 edits in trunk/WebKit/win
Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
Reviewed by Steve Falkenburg.
Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly
- Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
of the interface so the vtable that Safari 4.0.4 sees is unchanged.
- 9:43 AM Changeset in webkit [52097] by
-
- 1 edit11 adds in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Update Tiger media test results after r52094.
- platform/mac-tiger/accessibility: Added.
- platform/mac-tiger/accessibility/media-element-expected.txt: Added.
- platform/mac-tiger/media/audio-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/controls-after-reload-expected.txt: Added.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Added.
- platform/mac-tiger/media/controls-strict-expected.txt: Added.
- platform/mac-tiger/media/controls-styling-expected.txt: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/video-display-toggle-expected.txt: Added.
- platform/mac-tiger/media/video-no-audio-expected.txt: Added.
- platform/mac-tiger/media/video-zoom-controls-expected.txt: Added.
- 9:20 AM Changeset in webkit [52096] by
-
- 3 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Guard all of JSC's wrapper cache-related members on Document.
- dom/Document.cpp: (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
- dom/Document.h: Added JSC guards to wrapper cache-related members.
- 8:25 AM Changeset in webkit [52095] by
-
- 5 edits2 adds in trunk
AX: there's an infinite loop going on for some webpages - facebook.com
https://bugs.webkit.org/show_bug.cgi?id=32501
Reviewed by Adele Peterson.
WebCore:
The problem is that parentObjectUnignored() cannot be called
while in accessibilityIsIgnored, because it leads to
recursiveness. Specifically, there were checks to determine
if an object was within a ARIA tree. That check should
1) be moved to all platforms, and 2) not call parentObjectUnignored().
Test: accessibility/hang-in-isignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
- accessibility/hang-in-isignored-expected.txt: Added.
- accessibility/hang-in-isignored.html: Added.
- 8:16 AM Changeset in webkit [52094] by
-
- 18 edits9 adds in trunk
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/accessibility/media-element-expected.txt:
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac-leopard/media/controls-after-reload-expected.checksum: Added.
- platform/mac-leopard/media/controls-after-reload-expected.png: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.checksum: Added.
- platform/mac-leopard/media/controls-strict-expected.png: Added.
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-strict-mode-expected.txt: Added.
- platform/mac-leopard/media/controls-styling-expected.checksum: Added.
- platform/mac-leopard/media/controls-styling-expected.png: Added.
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.checksum: Added.
- platform/mac-leopard/media/video-no-audio-expected.png: Added.
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- 7:44 AM Changeset in webkit [52093] by
-
- 2 edits in trunk/WebKit/win
Build fix
- WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
libpath for all non-Cairo configurations (it was missing from most of
them).
- 7:38 AM Changeset in webkit [52092] by
-
- 2 edits1 add in trunk/WebCore
Move QuartzCore-related build settings into a vsprops file
Fixes <http://webkit.org/b/32518>
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added
WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
other QuartzCore-related build settings from here...
- WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
- 7:21 AM Changeset in webkit [52091] by
-
- 3 edits in trunk/WebCore
2009-12-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
handling scripts can block UI
https://bugs.webkit.org/show_bug.cgi?id=27612
Break execution of external scrips to smaller chunks.
No new tests since no new functionality was introduced.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired): (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
- html/HTMLTokenizer.h:
- 6:13 AM Changeset in webkit [52090] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed trivial buildfix.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-12-14
Fix crosses initialization of usedPrimaryBlocks for JSValue32
- runtime/Collector.cpp:
(JSC::Heap::markConservatively):
- 3:09 AM Changeset in webkit [52089] by
-
- 2 edits in trunk/WebCore
[Qt] Connect QNetworkReply via direct connections.
https://bugs.webkit.org/show_bug.cgi?id=32113
In the past we have switched from auto connections to queued
connections to get some more stability. The problem with the
Queued connections is latency. Even when running simple loading
tests the time it takes to runs highly varies and by using
direct connections these tests produce a stable result.
We will have to look out for crashes coming from within the
QNetworkAccessManager due this patch and address them then.
- 3:03 AM Changeset in webkit [52088] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
media/video-played-collapse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=31434
- platform/gtk/Skipped: Give this test another chance, we believe the bug above has been fixed in a previous commit.
- 2:51 AM Changeset in webkit [52087] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
New setting to allow applications to completely supress the
default context menu that is generated by WebKit. This allows them
to still pass the vent to the default handler without needing to
use ugly hacks such as handling populate-popup, and removing all
the items from the default context menu.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 2:48 AM Changeset in webkit [52086] by
-
- 2 edits in trunk/WebCore
[Qt] QtWebKit should use QImageReader::setQuality(49)
https://bugs.webkit.org/show_bug.cgi?id=30740
Using QImageReader::setQuality(49) will influence the JPEG
decoder of Qt to use the JDCT_IFAST routines for decompressing. This
is showing a 5% improvement in a reduction that decodes all images
used during the page loading test. The libjpeg documentation mentions
that the IFAST routine is not as accurate as other routines but in
our tests we couldn't see a difference.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- 2:01 AM Changeset in webkit [52085] by
-
- 3 edits in trunk/WebCore
emit volumeChanged and durationChanged upon notification from GStreamer.
- 1:56 AM Changeset in webkit [52084] by
-
- 2 edits in trunk/JavaScriptCore
GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &
Reviewed by Simon Hausmann.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 12:39 AM Changeset in webkit [52083] by
-
- 1 edit2 adds in trunk/LayoutTests
RS by Maciej Stachowiak.
Adding platform specific results for these test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/win/fast/css/large-number-round-trip-expected.txt: Added.
- platform/win/fast/css/opacity-float-expected.txt: Added.
- 12:13 AM Changeset in webkit [52082] by
-
- 33 edits2 adds in trunk
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
Dec 13, 2009:
- 11:01 PM Changeset in webkit [52081] by
-
- 1 edit1 add in trunk/LayoutTests
RS by Maciej Stachowiak.
Readding platform specific results for this test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/mac/fast/css/opacity-float-expected.txt: Added.
- 9:01 PM Changeset in webkit [52080] by
-
- 13 edits6 adds in trunk
2009-12-13 Charles Reis <creis@chromium.org>
Reviewed by Adam Barth.
Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326
No new tests. There should be no functionality changes in this patch,
since it is only refactoring code.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/BindingSecurity.h: Added. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
- bindings/BindingSecurityBase.cpp: Added. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccessWindow):
- bindings/BindingSecurityBase.h: Added.
- bindings/GenericBinding.h: Added. (WebCore::):
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isSafeScript):
- bindings/v8/V8Binding.h:
- bindings/v8/V8BindingState.cpp: Added. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
- bindings/v8/V8BindingState.h: Added. (WebCore::):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::reportUnsafeJavaScriptAccess):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::):
- bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
2009-12-13 Charles Reis <creis@chromium.org>
Reviewed by Adam Barth.
Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326
- src/WebBindings.cpp: (WebKit::getDragDataImpl):
- 7:10 PM Changeset in webkit [52079] by
-
- 3 edits in trunk/WebCore
[Qt] Implement initializeMaximumHTTPConnectionCountPerHost.
Qt allows to have three connections per host on Symbian, for
every other platform the limit is set to six connections per
host but the default implementation will only schedule four
connections per host.
In a manual test we seem to get the best loading speed by
going with Qt's limit and schedule two more jobs to allow Qt
to prepare them.
- platform/network/ResourceRequestBase.cpp:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 6:38 PM Changeset in webkit [52078] by
-
- 3 edits in trunk
2009-12-13 Eric Seidel <eric@webkit.org>
Reviewed by Gavin Barraclough.
string-base64 test does not compute a valid base64 string
http://bugs.webkit.org/show_bug.cgi?id=16806
- tests/string-base64.js: change str[i] to str.charCodeAt(i)
2009-12-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
SunSpider/tests/string-base64.js does not compute a valid base64 encoded string
https://bugs.webkit.org/show_bug.cgi?id=16806
Based on a patch by Eric Seidel.
Fix the base64 computation to actually compute correct results. The impact on runtime of
the test is pretty small, but noticeable for some browsers. But at least it's not
doing a wrong and meaningless computation any more.
- tests/sunspider-0.9.1/string-base64.js: (): (base64ToString):
- 6:26 PM Changeset in webkit [52077] by
-
- 2 edits in trunk/WebKitTools
Fix minor problem in sunspider-compare-results which left it broken.
Reviewed by Gavin Barraclaugh.
- Scripts/sunspider-compare-results: Declare $parseonly
- 5:32 PM Changeset in webkit [52076] by
-
- 2 edits in trunk/JavaScriptCore
- runtime/JSGlobalObjectFunctions.cpp:
Reviewed by NOBODY (speculative Windows build fix).
- 4:27 PM Changeset in webkit [52075] by
-
- 12 edits1 add in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32496
Switch remaining cases of string construction to use StringBuilder.
Builds strings using a vector rather than using string append / addition.
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
(JSC::Stringifier::indent):
- runtime/JSString.h:
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
- runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
- runtime/Operations.h:
(JSC::jsString):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncConcat):
- 4:14 PM Changeset in webkit [52074] by
-
- 2 edits in trunk/WebKitSite
Add a style guideline concerning floating point literals
https://bugs.webkit.org/show_bug.cgi?id=32497
Reviewed by Sam Weinig.
- coding/coding-style.html:
- 4:12 PM Changeset in webkit [52073] by
-
- 3 edits2 adds in trunk
<rdar://problem/7341364> Crash at HTMLParser::popOneBlockCommon() after
handling misnested residual style tags
Reviewed by Simon Fraser.
WebCore:
Test: fast/parser/residual-style-close-ref-clone.html
- html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Gave the
block stack a strong reference to the cloned residual style element.
LayoutTests:
- fast/parser/residual-style-close-ref-clone-expected.txt: Added.
- fast/parser/residual-style-close-ref-clone.html: Added.
- 3:53 PM Changeset in webkit [52072] by
-
- 2 edits in trunk/SunSpider
Fixing commit error...
I accidentally committed my last patch in a form that broke Web-hosted SunSpider. Fixing.
- resources/driver-TEMPLATE.html:
- 3:00 PM Changeset in webkit [52071] by
-
- 9 edits in trunk
Reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
Reviewed by Sam Weinig.
WebCore:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
LayoutTests:
- fast/css/large-number-round-trip-expected.txt:
- fast/css/large-number-round-trip.html: Updated to run in Firefox.
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
- 2:48 PM Changeset in webkit [52070] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Also give the right click event to the frame's event handler, if
there WebCore decides to not generate the default context
menu. This fixes some pages that handle right-button clicks for
things other than context menu creation.
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 2:34 PM Changeset in webkit [52069] by
-
- 2 edits in trunk/WebKit/qt
2009-12-13 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005
https://bugs.webkit.org/show_bug.cgi?id=29008
- tests/qwebframe/tst_qwebframe.cpp:
- 12:31 PM Changeset in webkit [52068] by
-
- 3 edits1 add in trunk/SunSpider
2009-12-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Use JSON.parse instead of eval for Web-hosted SunSpider results processing
https://bugs.webkit.org/show_bug.cgi?id=32490
- hosted/json2.js: Added. Incorporated from json.org
- resources/driver-TEMPLATE.html: Fix an HTML validation bug I noticed.
- resources/results-TEMPLATE.html: Use JSON.parse instead of eval to process results.
- 5:33 AM Changeset in webkit [52067] by
-
- 8 edits in trunk
Reviewed by Eric Seidel.
Add code to allow toggling ATSUI/Core Text rendering at runtime in ComplexTextController.
https://bugs.webkit.org/show_bug.cgi?id=31802
The goal here is to allow for a zero runtime hit for ports that decide to select
the API at compile time.
When both USE(ATSUI) and USE(CORE_TEXT) are true, the API is toggled
at runtime. Core Text is used for OS Versions >= 10.6.
No test since this is already covered by existing pixel tests.
- platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::shouldUseATSUIAPI): Cache decision about which API to use.
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Stub function to call through
to ATSUI/Core text variants.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): The actual work for object construction
is delegate to createTextRunFromFontDataATSUI/createTextRunFromFontDataCoreText.
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Small style fix.
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataATSUI):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- 3:32 AM Changeset in webkit [52066] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-13 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=31014
[Gtk] Build fails with gtk+-2.10 (no tested with older releases)
Guard GTK+ 2.12 specific tooltip code with #ifdef.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- 1:31 AM Changeset in webkit [52065] by
-
- 2 edits in trunk/WebKit/qt
2009-12-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Re-enable QWebView::renderHints property for Qt for Symbian
The bug in Qt's moc that triggered a linking error when declaring this
property has been fixed and we can remove the workaround.
- Api/qwebview.h:
- 12:44 AM Changeset in webkit [52064] by
-
- 17 edits in trunk
2009-12-13 Eric Carlson <eric.carlson@apple.com>
No review, rolling out r52059 until I can generate new Tiger
test results.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-13 Eric Carlson <eric.carlson@apple.com>
No review, rolling out r52059 until I can generate new Tiger test
results.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/video-zoom-expected.checksum:
Dec 12, 2009:
- 8:45 PM Changeset in webkit [52063] by
-
- 13 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Fix the EXPERIMENTAL_SINGLE_VIEW_MODE build.
- Configurations/WebCore.xcconfig:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):
- page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventActivatedView):
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/mac/PlatformMouseEventMac.mm:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
- platform/mac/WidgetMac.mm:
- 8:26 PM Changeset in webkit [52062] by
-
- 5 edits2 moves1 add in trunk/SunSpider
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Enable Web-hosted version of SunSpider to handle multiple versions
https://bugs.webkit.org/show_bug.cgi?id=32478
- make-hosted: Now generate the hosted version to be able to run both the 0.9 and the 0.9.1 test suites.
- hosted: Modified property svn:ignore.
- hosted/sunspider-driver.html: Removed.
- hosted/sunspider-results.html: Removed.
- hosted/sunspider.html:
- hosted/versions.html: Added.
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html: Copied from hosted/sunspider-driver.html.
- resources/driver-TEMPLATE.html: Copied from hosted/sunspider-results.html.
- 7:59 PM Changeset in webkit [52061] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Fix the !ENABLE(VIDEO) build.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- 7:56 PM Changeset in webkit [52060] by
-
- 6 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Fix the !ENABLE(DATABASE) build.
- storage/SQLTransactionClient.cpp:
- storage/SQLTransactionClient.h:
- storage/SQLTransactionCoordinator.cpp:
- storage/SQLTransactionCoordinator.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- 7:28 PM Changeset in webkit [52059] by
-
- 22 edits in trunk
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.png:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.png:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.png:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 7:02 PM Changeset in webkit [52058] by
-
- 12 edits2 adds in trunk
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Errors in WebGL[T]Array set() and get() methods
https://bugs.webkit.org/show_bug.cgi?id=32456
Test: fast/canvas/webgl/bug-32456.html
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/bug-32456-expected.txt: Added.
- fast/canvas/webgl/bug-32456.html: Added.
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Errors in WebGL[T]Array set() and get() methods
https://bugs.webkit.org/show_bug.cgi?id=32456
Test: fast/canvas/webgl/bug-32456.html
- bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
- bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
- bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
- bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
- bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
- bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArray):
- html/canvas/WebGLFloatArray.idl:
- html/canvas/WebGLUnsignedIntArray.idl:
- 6:18 PM Changeset in webkit [52057] by
-
- 10 edits27 copies37 moves3 adds in trunk
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Give command-line sunspider the ability to handle multiple suites and versions
https://bugs.webkit.org/show_bug.cgi?id=32477
- Scripts/run-sunspider: Updated for changes to command-line parameters.
- Scripts/sunspider-compare-results: ditto
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Give command-line sunspider the ability to handle multiple suites and versions
https://bugs.webkit.org/show_bug.cgi?id=32477
Each suite/version's set of tests are now in a separate subdirectory of tests/, with a file named LIST
enumerating the tests. Current suites are:
sunspider-0.9 - riginal SunSpider content
sunspider-0.9.1 - SunSpider suite with a few tests fixed (and a few more to come)
ubench - "ubench" microbenchmark suite
v8-v4 - version 4 of the v8 benchmark
parse-only - some parser tests
Sunspider can now be run with the --suite= parameter to select a
suite. The default is --suite=sunspider-0.9.
- .: Modified property svn:ignore to ignore new results directories.
- make-hosted: Generate based on sunspider-0.9 suite.
- resources/TEMPLATE.html: Fix an HTML compliance problem.
- resources/sunspider-standalone-driver.js: Become aware of suite names.
- sunspider: Modified to handle multiple suites as described above.
- sunspider-compare-results: ditto
- tests/LIST: Moved to tests/sunspider-0.9/ and tests/sunspider-0.9.1/
- tests/LIST-PARSE-ONLY: Moved to parse-only/LIST
- tests/LIST-UBENCH: Removed.
- tests/LIST-V8: Removed.
- tests/3d-cube.js: Moved to tests/sunspider-0.9 and tests/sunspider-0.9.1
- tests/3d-morph.js: ditto
- tests/3d-raytrace.js: ditto
- tests/access-binary-trees.js: ditto
- tests/access-fannkuch.js: ditto
- tests/access-nbody.js: ditto
- tests/access-nsieve.js: ditto
- tests/bitops-3bit-bits-in-byte.js: ditto
- tests/bitops-bits-in-byte.js: ditto
- tests/bitops-bitwise-and.js: ditto
- tests/bitops-nsieve-bits.js: ditto
- tests/controlflow-recursive.js: ditto
- tests/crypto-aes.js: ditto
- tests/crypto-md5.js: ditto
- tests/crypto-sha1.js: ditto
- tests/date-format-tofte.js: ditto
- tests/date-format-xparb.js: ditto
- tests/math-cordic.js: ditto
- tests/math-partial-sums.js: ditto
- tests/math-spectral-norm.js: ditto
- tests/regexp-dna.js: ditto
- tests/string-base64.js: ditto
- tests/string-fasta.js: ditto
- tests/string-tagcloud.js: ditto
- tests/string-unpack-code.js: ditto
- tests/string-validate-input.js: ditto
- tests/sunspider-0.9/: Added
- tests/sunspider-0.9/*.js: Moved from one level up
- tests/sunspider-0.9.1: Added.
- tests/sunspider-0.9.1/*.js: Moved from one level up.
- tests/v8-crypto.js: Moved to v8-v4/ directory.
- tests/v8-deltablue.js: ditto
- tests/v8-earley-boyer.js: ditto
- tests/v8-raytrace.js: ditto
- tests/v8-regexp.js: ditto
- tests/v8-richards.js: ditto
- tests/v8-splay.js: ditto
- tests/v8-v4: Added.
- 3:12 PM Changeset in webkit [52056] by
-
- 10 edits in trunk
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Update WebGL tests to released versions
https://bugs.webkit.org/show_bug.cgi?id=32457
- fast/canvas/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Update WebGL tests to released versions
https://bugs.webkit.org/show_bug.cgi?id=32457
- manual-tests/webgl/Earth.html:
- manual-tests/webgl/ManyPlanetsDeep.html:
- manual-tests/webgl/SpinningBox.html:
- manual-tests/webgl/TeapotPerPixel.html:
- manual-tests/webgl/TeapotPerVertex.html:
- manual-tests/webgl/resources/CanvasMatrix.js: (CanvasMatrix4.prototype.getAsWebGLFloatArray):
- manual-tests/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):
- 1:29 PM Changeset in webkit [52055] by
-
- 11 edits in trunk
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7453726> Pull shared UI code into WebKit
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7453726> Pull shared UI code into WebKit
Update media tests for small change in timeline slider thumb position
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- 11:10 AM Changeset in webkit [52054] by
-
- 2 edits in trunk/WebCore
2009-12-12 Christian Dywan <christian@twotoasts.de>
Reviewed by Dirk Schulze.
Remove the include to SVGFEDisplacementMap.h, it's not needed at all.
- platform/graphics/filters/FEComponentTransfer.h:
- 10:32 AM Changeset in webkit [52053] by
-
- 2 edits in trunk/WebKitTools
Not reviewed, fixing previous comment.
Remove accidental change to sunspider-compare-results
- Scripts/sunspider-compare-results:
- 10:24 AM Changeset in webkit [52052] by
-
- 2 edits in trunk/WebCore
2009-12-12 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Maciej Stachowiak.
Only include SVGFEDisplacementMap.h if SVG is enabled.
- platform/graphics/filters/FEComponentTransfer.h:
- 9:52 AM Changeset in webkit [52051] by
-
- 4 edits in trunk
2009-12-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Unify codegen for forward and backward variants of branches
https://bugs.webkit.org/show_bug.cgi?id=32463
- jit/JIT.h: (JSC::JIT::emit_op_loop): Implemented in terms of forward variant. (JSC::JIT::emit_op_loop_if_true): ditto (JSC::JIT::emitSlow_op_loop_if_true): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto (JSC::JIT::emit_op_loop_if_less): ditto (JSC::JIT::emitSlow_op_loop_if_less): ditto
- jit/JITOpcodes.cpp:
- 9:14 AM Changeset in webkit [52050] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-11 Christian Dywan <christian@twotoasts.de>
Reviewed by Eric Seidel.
[GTK] Build with --disable-svg is broken
http://bugs.webkit.org/show_bug.cgi?id=32361
- webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards.
- 2:20 AM Changeset in webkit [52049] by
-
- 3 edits in trunk/WebCore
2009-12-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
[Cairo][Qt] Alpha blending in SVG filters is wrong
https://bugs.webkit.org/show_bug.cgi?id=32427
This patch is a follow-up to:
http://trac.webkit.org/changeset/51950
It fixes the alpha blending for Cairo and Qt on SVG Filters.
Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg
- LayoutTests/svg/filters/feComposite.svg and others.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- 2:13 AM Changeset in webkit [52048] by
-
- 2 edits in trunk/LayoutTests
[Qt] Missing forward entries when dumping back/forward list
https://bugs.webkit.org/show_bug.cgi?id=32470
Failing tests added to skiplist until bug fixed.
- platform/qt/Skipped:
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html added
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html added
Dec 11, 2009:
- 11:20 PM Changeset in webkit [52047] by
-
- 33 edits2 deletes in trunk
Rolled out my last patch because the bots were crashing
- 10:30 PM Changeset in webkit [52046] by
-
- 3 edits in trunk/JavaScriptCore
Allow WTFs concept of the main thread to differ from pthreads when necessary.
Reviewed by Anders Carlsson.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::isMainThread):
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- 10:22 PM Changeset in webkit [52045] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Export some new symbols.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 10:08 PM QtWebKit/CodeCamp200912 edited by
- Add another talk. I don't remember the name of this guy though. (diff)
- 10:02 PM Changeset in webkit [52044] by
-
- 2 edits in trunk/WebCore
Windows build fix: Removed an incorrect #ifdef.
- bindings/js/GCController.cpp:
- 9:50 PM Changeset in webkit [52043] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
[V8] Add a method on ScriptController to get it compiling after http://trac.webkit.org/changeset/52033.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::anyPageIsProcessingUserGesture):
- bindings/v8/ScriptController.h:
- 9:49 PM Changeset in webkit [52042] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Removed some old exports.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 9:39 PM Changeset in webkit [52041] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Use unsigned instead of uint32_t to avoid dependencies.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 9:29 PM Changeset in webkit [52040] by
-
- 32 edits4 adds in trunk
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
- 8:56 PM Changeset in webkit [52039] by
-
- 2 edits in trunk/WebCore
2009-12-11 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Change bindings to catch up with http://trac.webkit.org/changeset/52033.
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added retrieval of calling frame and passing to the submit method.
- 6:43 PM Changeset in webkit [52038] by
-
- 2 edits in trunk/WebCore
Put -umbrella linker flag into a variable so that it can be overridden.
Reviewed by Mark Rowe.
- Configurations/WebCore.xcconfig:
- 6:31 PM Changeset in webkit [52037] by
-
- 6 edits in trunk
WebKit/qt: Unreviewed build fix for Qt versions < 4.6.
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebview/tst_qwebview.cpp:
WebKitTools: Unreviewed build fix for Qt versions < 4.6.
Guard every slot individually with #ifdef.
- DumpRenderTree/qt/EventSenderQt.cpp:
- DumpRenderTree/qt/EventSenderQt.h:
- 5:50 PM Changeset in webkit [52036] by
-
- 3 edits4 adds in trunk
2009-12-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
body with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32371
- fast/inline/inline-body-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
- fast/inline/inline-body-crash.html: Added.
- fast/inline/inline-body-with-scrollbar-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
- fast/inline/inline-body-with-scrollbar-crash.html: Added.
2009-12-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
body with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32371
Tests: fast/inline/inline-body-crash.html
fast/inline/inline-body-with-scrollbar-crash.html
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout):
- 5:40 PM Changeset in webkit [52035] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Sam Weinig.
https://webkit.org/b/22851 - Remove defunct FIXME.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): This flag was removed completely
from the HTMLFrameOwnerElement chain of classes.
- 5:38 PM Changeset in webkit [52034] by
-
- 5 edits in trunk/WebCore
Small refactoring to get rid of some extra unneeded selection-related work
in RenderLayer::scrollToOffset and separate caret and range selection
logic in FrameView::layout. This may be useful later when changing how
the range selection logic works to fix layout reentrancy problems.
Reviewed by Dan Bernstein.
- page/Frame.cpp: Removed invalidateSelection.
- page/Frame.h: Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::layout): Call SelectionController::setNeedsLayout
and Frame::selectionLayoutChanged instead of calling
Frame::invalidateSelection, which was just a function that called
both of those others.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset): Call
SelectionController::setNeedsLayout instead of calling
Frame::invalidateSelection. This call site only needs the caret-related
work in that first function, not the other work formerly done by
Frame::invalidateSelection. The caret works outside the normal
painting and rendering system, and the range selection highlight is
more or less inside it and doesn't need special handling when scrolling.
- 5:34 PM Changeset in webkit [52033] by
-
- 9 edits5 adds in trunk
<rdar://problem/7342725> and https://webkit.org/b/32383
Selecting article text at sfgate.com results in spurious back/forward entries
Reviewed by Darin Adler.
WebCore:
If an iframe had a form and that form is submitted by javascript, IE and Opera don't add back/forward entries.
In the case where the frame was added dynamically via createElement(), Firefox would like to add a back entry
but has a bug that prevents this.
Therefore by a bizarre coincidence, WebKit is the loner and the only engine affected by sfgate.com's technique.
This patch changes us to willfully match IE and Opera and fixes sfgate.com in the process.
Tests: http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html
Capture whether the form was submitted by javascript:
- loader/FormState.cpp:
(WebCore::FormState::FormState):
(WebCore::FormState::create):
- loader/FormState.h:
(WebCore::FormState::formSubmissionTrigger):
When deciding the value of the lockBackForwardList variable, take formSubmissionTrigger() into account:
- loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleFormSubmission):
Rearrange the public HTMLFormElement::submit() method to be called only from DOM or JS bindings,
and figure out the rest of the parameters for an internal submit() call including the formSubmissionTrigger:
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::submit):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
LayoutTests:
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry-expected.txt: Added.
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html: Added.
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry-expected.txt: Added.
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html: Added.
- http/tests/navigation/resources/notify-done.html: Added.
- http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Updated.
- 5:10 PM Changeset in webkit [52032] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32445
REGRESSION: http://www.mcafee.com/japan/ displays unstyled
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Add a quirk for mcafee.com/japan (http or https, with or without www).
- 5:09 PM Changeset in webkit [52031] by
-
- 2 edits in trunk/WebCore
Make PlatformWheelEvent.h private instead of project.
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
- 4:39 PM Changeset in webkit [52030] by
-
- 4 edits5 adds in trunk/WebKit/win
Added icons for full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=31318
- 3:49 PM Changeset in webkit [52029] by
-
- 3 edits in trunk/WebCore
2009-12-11 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Support reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=31885
First part of supporting composited reflections on compositing layers.
Rename the m_transformLayer member variable to m_structuralLayer, since it
will get used both for transform layers (for preserve-3d) and to hold a flattening
layer related to reflections, both of which have similar requirements, and are
mutually exclusive.
- platform/graphics/mac/GraphicsLayerCA.h: primaryLayer(), hostLayerForSublayers() and layerForSuperlayer() all now return a CALayer, since m_structuralLayer isn't always a WebLayer.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChanges): updateLayerPreserves3D() renamed to updateStructuralLayer()
(WebCore::GraphicsLayerCA::updateLayerNames):
New "update" method for updating layer names.
(WebCore::GraphicsLayerCA::updateSublayerList):
m_transformLayer -> m_structuralLayer. Also minor refactor to only
allocate newSublayers in one place.
(WebCore::GraphicsLayerCA::updateLayerSize):
(WebCore::GraphicsLayerCA::removeAnimationFromLayer):
(WebCore::GraphicsLayerCA::hostLayerForSublayers):
(WebCore::GraphicsLayerCA::layerForSuperlayer):
m_transformLayer -> m_structuralLayer
(WebCore::GraphicsLayerCA::updateStructuralLayer):
Call ensureStructuralLayer() which handles any deltas to the
structural layer type.
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
Handle changes to the structural layer requirements
(WebCore::GraphicsLayerCA::structuralLayerPurpose):
Return an enum describing the purpose of the structural layer; for now
this only returns NoStructuralLayer or StructuralLayerForPreserves3D, but
will in future also have a value related to reflections.
- 3:34 PM Changeset in webkit [52028] by
-
- 17 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32454
Refactor construction of simple strings to avoid string concatenation.
Reviewed by Oliver Hunt.
Building strings through concatenation has a memory and performance cost -
a memory cost since we must over-allocate the buffer to leave space to append
into, and performance in that the string may still require reallocation (and
thus copying during construction). Instead move the full construction to
within a single function call (makeString), so that the arguments' lengths
can be calculated and an appropriate sized buffer allocated before copying
any characters.
~No performance change (~2% progression on date tests).
- bytecode/CodeBlock.cpp:
(JSC::escapeQuotes):
(JSC::valueToSourceString):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
- bytecompiler/NodesCodegen.cpp:
(JSC::substitute):
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
- runtime/DateConstructor.cpp:
(JSC::callDate):
- runtime/DateConversion.cpp:
(JSC::formatDate):
(JSC::formatDateUTCVariant):
(JSC::formatTime):
(JSC::formatTimeUTC):
- runtime/DateConversion.h:
(JSC::):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createErrorMessage):
(JSC::createInvalidParamError):
- runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
- runtime/UString.h:
(JSC::):
(JSC::makeString):
- 3:03 PM Changeset in webkit [52027] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-11 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Expose shouldHideReferrer() in WebSecurityPolicy.
- public/WebSecurityPolicy.h: Add shouldHideReferrer().
- src/WebSecurityPolicy.cpp:
- (WebKit
- WebSecurityPolicy::shouldHideReferrer): Added.
- 2:57 PM Changeset in webkit [52026] by
-
- 6 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Reviewed by Oliver Hunt.
Re-landing r51975 - added toPrimitiveString method,
performs toPrimitive then subsequent toString operations.
~1% progression on Sunspidey.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
- 2:39 PM Changeset in webkit [52025] by
-
- 4 edits in trunk/WebKitTools
2009-12-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
CommandsTest.assert_execute_outputs doesn't check stderr
https://bugs.webkit.org/show_bug.cgi?id=32352
Fix assert_execute_outputs to check stderr
and then fix all the unit tests which needed to
pass stderr output.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/commands/upload_unittest.py:
- 2:29 PM Changeset in webkit [52024] by
-
- 4 edits in trunk
Versioning.
- 2:28 PM Changeset in webkit [52023] by
-
- 1 copy in tags/Safari-532.6
New tag.
- 1:50 PM Changeset in webkit [52022] by
-
- 2 edits in trunk/WebCore
2009-12-11 Simon Fraser <Simon Fraser>
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::pauseAnimation):
- 1:35 PM Changeset in webkit [52021] by
-
- 2 edits in trunk/WebCore
2009-12-11 Simon Fraser <Simon Fraser>
Build fix, no review.
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::startAnimation):
- 1:31 PM Changeset in webkit [52020] by
-
- 4 edits in trunk
Windows build fix
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added
$(WebKitOutputDir)/include/private to the include path.
WebCore:
- platform/graphics/win/WKCACFLayerRenderer.cpp: Removed #include of
non-existent header.
- 1:24 PM Changeset in webkit [52019] by
-
- 2 edits in trunk/WebCore
2009-12-11 Simon Fraser <Simon Fraser>
Build fix, no review.
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::startAnimation):
- 1:02 PM Changeset in webkit [52018] by
-
- 3 edits4 adds in trunk
2009-12-11 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Negative values for animation-delay are ignored (treated as zero)
https://bugs.webkit.org/show_bug.cgi?id=26150
When we get the m_startTime for an animation or transition, subtract any negative
delay so the animation/transition behaves like it started in the past, per spec.
Tests: animations/negative-delay.html
transitions/negative-delay.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- 12:57 PM Changeset in webkit [52017] by
-
- 12 edits1 add in trunk/WebCore
2009-12-11 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Accelerated transitions broken when mixed with paused animations
https://bugs.webkit.org/show_bug.cgi?id=32387
Synchronization of a mixture of accelerated and software animations occurs via
a callback from GraphicsLayerCA, which ends up in
AnimationControllerPrivate::receivedStartTimeResponse(). The time passed in is
the exact time at which the accelerated animations started, so is used as the
start time for all animations and transitions which are marked as waiting.
The bug was that the callback called when re-starting animations that were
paused sent back an old time value, but this was used to start normal
transitions. Therefore the transition would start with a stale start time, and
thus end prematurely.
The fix is to change the way that GraphicsLayerCA handles paused animations.
Rather than setting the beginTime of the animation, it uses a beginTime of 0
and a timeOffset that gets passed down. Thus the callbacks always come with
beginTime for 'now'.
Also clarify the role of AnimationBase::endAnimation() by splitting it into
pauseAnimation() and endAnimation(), and pass down timeOffsets, rather than
beginTimes when starting and pausing.
Manual test only, because the bug requires a non-trivial combination of
animation pausing and transitions which take time, and the bug only shows in
pixel results.
- manual-tests/animation/transitions-and-paused-animations.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h: (WebCore::AnimationBase::startAnimation): (WebCore::AnimationBase::pauseAnimation): (WebCore::AnimationBase::endAnimation):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::startAnimation): (WebCore::ImplicitAnimation::endAnimation): (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::pauseAnimation):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation): (WebCore::KeyframeAnimation::startAnimation): (WebCore::KeyframeAnimation::pauseAnimation): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.h:
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::addAnimation): (WebCore::GraphicsLayer::pauseAnimation):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::LayerAnimation::LayerAnimation): (WebCore::GraphicsLayerCA::AnimationProcessingAction::AnimationProcessingAction):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::addAnimation): (WebCore::GraphicsLayerCA::removeAnimationsForKeyframes): (WebCore::GraphicsLayerCA::pauseAnimation): (WebCore::GraphicsLayerCA::updateLayerAnimations): (WebCore::GraphicsLayerCA::setAnimationOnLayer): (WebCore::GraphicsLayerCA::pauseAnimationOnLayer): (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): (WebCore::RenderLayerBacking::animationPaused):
- rendering/RenderLayerBacking.h:
- 12:50 PM Changeset in webkit [52016] by
-
- 3 edits in trunk/WebKitTools
2009-12-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[check-webkit-style] False positive for tst_QWebFrame
https://bugs.webkit.org/show_bug.cgi?id=32436
Add an exception for function names that start with "tst_". These are
used by the Qt unit testing framework.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 12:46 PM Changeset in webkit [52015] by
-
- 5 edits in trunk/JavaScriptCore
Move QuartzCorePresent.h to include/private
This fixes other projects that use wtf/Platform.h
Rubber-stamped by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS do its thang.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Write
QuartzCorePresent.h to $(WebKitOutputDir)/include/private.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
Added $(WebKitOutputDir)/include/private to the include path.
- 12:38 PM Changeset in webkit [52014] by
-
- 2 edits in trunk/LayoutTests
2009-12-11 Drew Wilson <atwilson@chromium.org>
Reviewed by Darin Adler.
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344
dedicated-worker-lifecycle.html relies on a Worker object getting GC'd, which is never guaranteed (due to conservative GC)
but is especially unreliable on Leopard, so disabling on that platform.
- platform/mac-leopard/Skipped: disabled dedicated-worker-lifecycle.html.
- 12:30 PM Changeset in webkit [52013] by
-
- 2 edits in trunk/JavaScriptCore
Fix clean builds and everything rebuilding on every build
Reviewed by Sam Weinig.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Don't
write out QuartzCorePresent.h if it exists but is older than
QuartzCore.h. Also, create the directory we write QuartzCorePresent.h
into first.
- 11:59 AM Changeset in webkit [52012] by
-
- 3 edits2 adds in trunk
Fixes <http://webkit.org/b/32399>.
Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled.
Reviewed by Darin Adler.
WebCore:
When we initially figure out the layer that we should begin scrolling, don't try to jump out
of frames/iFrames to look at the owner document. We don't want to jump out of frames, so we
don't need that logic anymore.
Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.
Test: platform/win/fast/events/panScroll-no-iframe-jump.html
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
LayoutTests:
Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.
- platform/win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
- platform/win/fast/events/panScroll-no-iframe-jump.html: Added.
- 11:45 AM Changeset in webkit [52011] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix for systems with spaces in their paths
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Quote some paths.
- 11:33 AM Changeset in webkit [52010] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh
Copy QuartzCore header file into Include/JavaScriptCore so Platform.h can find it.
- 11:10 AM Changeset in webkit [52009] by
-
- 2 edits in trunk/LayoutTests
Skip test that is failing because script is not executed after the
view it is on is destroyed.
See https://bugs.webkit.org/show_bug.cgi?id=32441
- platform/gtk/Skipped:
- 10:46 AM Changeset in webkit [52008] by
-
- 5 edits4 adds in trunk
Fixes <http://webkit.org/b/32303>.
Middle-mouse button not firing mousedown DOM event when autoscroll happens.
Reviewed by Adam Roben.
WebCore:
This fix moves the pan scrolling code into Node.cpp, as part of the default event handler.
We get two wins out of this:
1) Mousedown DOM events are now fired before pan scrolling.
2) Calling event.preventDefault() on a middle mouse button will now prevent pan scrolling.
Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.
Tests: platform/win/fast/events/panScroll-event-fired.html
platform/win/fast/events/panScroll-preventDefault.html
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler): Moved pan scrolling starting code to here.
- page/EventHandler.cpp:
(WebCore::EventHandler::startPanScrolling): Function to initialize scrolling variables and start timer.
(WebCore::EventHandler::handleMousePressEvent): From here.
- page/EventHandler.h:
LayoutTests:
Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.
- platform/win/fast/events/panScroll-event-fired-expected.txt: Added.
- platform/win/fast/events/panScroll-event-fired.html: Added.
- platform/win/fast/events/panScroll-preventDefault-expected.txt: Added.
- platform/win/fast/events/panScroll-preventDefault.html: Added.
- 10:31 AM Changeset in webkit [52007] by
-
- 1 edit in trunk/WebCore/ChangeLog
forgot to save Changelog
- 10:29 AM Changeset in webkit [52006] by
-
- 11 edits5 adds in trunk
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
- 10:24 AM Changeset in webkit [52005] by
-
- 2 edits2 adds in trunk/WebCore
2009-12-11 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Adds an Android-specific implementation of initializeMaximumHTTPConnectionCountPerHost.
https://bugs.webkit.org/show_bug.cgi?id=31810
- platform/network/ResourceRequestBase.cpp: Modified. Disable default implementation
of initializeMaximumHTTPConnectionCountPerHost for Android.
- platform/network/android: Added.
- platform/network/android/ResourceRequestAndroid.cpp: Added. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Android-specific implementation.
- 10:16 AM Changeset in webkit [52004] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-11 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Tickmarks in the scrollbar are not cleared for non-main frames
https://bugs.webkit.org/show_bug.cgi?id=32385
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::stopFinding):
- 10:13 AM Changeset in webkit [52003] by
-
- 4 edits in trunk/WebCore
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Add acceptTypes() method to FileChooser.
https://bugs.webkit.org/show_bug.cgi?id=32429
This method returns an 'accept' attribute value of the
corresponding INPUT element. A ChromeClient::runOpenPanel()
implementation can refer it through a FileChooser instance to
support type-restricted file selecting.
This makes no user-visible changes for now.
- platform/FileChooser.h: (WebCore::FileChooser::acceptTypes):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::acceptTypes):
- rendering/RenderFileUploadControl.h:
- 10:06 AM Changeset in webkit [52002] by
-
- 2 edits in trunk/LayoutTests
[Qt][LayoutTestController] Output of document.write() is vanished by waitUntilDone()/notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=32437
- platform/qt/Skipped: http/tests/misc/percent-sign-in-form-field-name.html added until bug fixed.
- 10:03 AM Changeset in webkit [52001] by
-
- 2 edits1 add in trunk/WebCore
2009-12-11 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
Changed PopupMenuChromium to keep the value selected from
keyboard when popup is closed.
The problem is Chromium does not fire the onchange event
when the popup is closed if an item is selected via
keyboard by typing the first char of the item. This makes
chromium popup not having consistent behaviours and also
behaves differently from other major browsers.
Calling popup->hide() instead of popup->hidePopup() in
PopupMenu fixes the issues as it does extra step to check
whethere there is a keyboard selection changed when closing
the popup.
TEST: add a manual test as the current layout test shell
does not support sending keyboard events to popup list.
- manual-tests/chromium/select-close-popup-value-change.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::hide):
- 9:31 AM Changeset in webkit [52000] by
-
- 2 edits in trunk/LayoutTests
Skip two tests that require infrastructure our DRT doesn't have,
or functionality our port does not implement.
- platform/gtk/Skipped:
- 9:30 AM Changeset in webkit [51999] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Skip a timeouter flakey test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-storage.html added.
- 9:21 AM Changeset in webkit [51998] by
-
- 6 edits in trunk/WebCore
2009-12-11 anton muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] refactor WeakReferenceMap.
Move common bits of functionality to reduce duplication.
Should be covered by buildbots.
- bindings/v8/DOMData.h: (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
- bindings/v8/DOMDataStore.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent): (WebCore::WeakReferenceMap::clear): (WebCore::WeakReferenceMap::visit):
- 9:19 AM Changeset in webkit [51997] by
-
- 4 edits1 delete in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] TouchEvent related tests have platform dependent results until all platform implement it.
- platform/qt/fast/dom/Window/window-properties-expected.txt: TouchEvent related output added.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: TouchEvent related output added.
- platform/qt/fast/dom/prototype-inheritance.html: Removed. (added by mistake previously)
- platform/qt/fast/js/global-constructors-expected.txt: TouchEvent related output added.
- 9:15 AM Changeset in webkit [51996] by
-
- 2 edits in trunk/LayoutTests
Fixed typo in test result.
- platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
- 9:14 AM Changeset in webkit [51995] by
-
- 2 edits in trunk/WebCore
2009-12-11 anton muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] in Debug builds create an additional handle scope
when doing debug build checks.
https://bugs.webkit.org/show_bug.cgi?id=32335
Should be covered by buildbots.
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
- 9:07 AM Changeset in webkit [51994] by
-
- 1 edit4 copies in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] TouchEvent related tests have platform dependent results until all platform implement it.
Original expected files copied.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/fast/dom/prototype-inheritance-expected.txt.
- platform/qt/fast/dom/prototype-inheritance.html: Copied from LayoutTests/fast/dom/prototype-inheritance.html.
- platform/qt/fast/js/global-constructors-expected.txt: Copied from LayoutTests/fast/js/global-constructors-expected.txt.
- 8:52 AM Changeset in webkit [51993] by
-
- 11 edits1 move in trunk/WebCore
2009-12-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not use ContextMenuItem as value type in custom
context menu implementation.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuCleared):
- inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuProvider::create): (WebCore::InspectorFrontendHost::MenuProvider::~MenuProvider): (WebCore::InspectorFrontendHost::MenuProvider::disconnect): (WebCore::InspectorFrontendHost::MenuProvider::populateContextMenu): (WebCore::InspectorFrontendHost::MenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuProvider::MenuProvider):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
- page/ContextMenuController.h:
- page/ContextMenuProvider.h: Added. (WebCore::ContextMenuProvider::~ContextMenuProvider):
- page/ContextMenuSelectionHandler.h: Removed.
- 8:22 AM Changeset in webkit [51992] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Updated QWebElement documentation
Reviewed by Tor Arne Vestbø.
findAll() returns a QWebElementCollection, not QList<QWebElement>.
- 8:20 AM Changeset in webkit [51991] by
-
- 6 edits in trunk
WebCore: Basic cross-platform implementation of mapping platform touch events
to JavaScript touch events.
Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
Test: fast/events/basic-touch-events.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
WebKit/qt: Forward Qt touch events to the event handler as platform touch events.
Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
- Api/qwebpage.cpp:
(QWebPagePrivate::touchEvent):
(QWebPage::event):
- Api/qwebpage_p.h:
- 8:19 AM Changeset in webkit [51990] by
-
- 2 edits in trunk/WebCore
2009-12-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's EmptyFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=32110
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class EmptyFrameLoaderClient - svg/graphics/SVGImage.cpp:229
- loader/FrameLoaderClient.h:
- 8:17 AM Changeset in webkit [51989] by
-
- 3 edits in trunk/WebCore
2009-12-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for 3 classes in WebCore's svg and loader directory
https://bugs.webkit.org/show_bug.cgi?id=32106
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class EmptyContextMenuClient - instantiated at: svg/graphics/SVGImage.cpp:232
class EmptyDragClient - instantiated at: svg/graphics/SVGImage.cpp:237
class SVGImageChromeClient - instantiated at: svg/graphics/SVGImage.cpp:243
- svg/graphics/SVGImage.cpp:
- loader/EmptyClients.h:
- 7:51 AM Changeset in webkit [51988] by
-
- 2 edits in trunk/LayoutTests
Skip the touch tests on Windows (somehow that hunk got lost).
- platform/win/Skipped:
- 7:46 AM Changeset in webkit [51987] by
-
- 3 edits in trunk/WebKitTools
Added support for creating synthetic touch events with EventSender
in Qt's DumpRenderTree.
Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::touchStart):
(EventSender::touchMove):
(EventSender::touchEnd):
(EventSender::clearTouchPoints):
(EventSender::releaseTouchPoint):
(EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 7:39 AM Changeset in webkit [51986] by
-
- 3 edits3 adds in trunk
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
https://bugs.webkit.org/show_bug.cgi?id=32304
- wtf/DateMath.cpp: (WTF::dateToDaysFrom1970): Renamed from dateToDayInYear, and changed the return type to double. (WTF::calculateDSTOffset): Follow the dateToDaysFrom1970() change. (WTF::timeClip): Use maxECMAScriptTime. (JSC::gregorianDateTimeToMS): Follow the dateToDaysFrom1970() change.
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
https://bugs.webkit.org/show_bug.cgi?id=32304
- fast/js/date-daysfrom1970-overflow-expected.txt: Added.
- fast/js/date-daysfrom1970-overflow.html: Added.
- fast/js/script-tests/date-daysfrom1970-overflow.js: Added.
- 7:35 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 7:21 AM Changeset in webkit [51985] by
-
- 8 edits in trunk
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
- bridge/runtime_array.h:
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
- DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):
- 7:07 AM Changeset in webkit [51984] by
-
- 5 edits in trunk/WebKit/chromium
2009-12-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove obsolete message handling methods from WebDevTools* interfaces
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- public/WebDevToolsFrontend.h:
- public/WebDevToolsFrontendClient.h:
- 6:38 AM Changeset in webkit [51983] by
-
- 2 edits in trunk/WebCore
2009-12-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] ImageDecoderQt: Fix retrieval of image file extensions
QImageReader only allows retrieving the format() before actually reading the image.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalDecodeSize):
- 6:15 AM Changeset in webkit [51982] by
-
- 3 edits3 adds in trunk/LayoutTests
2009-12-11 Simon Hausmann <Simon Hausmann>
Reviewed by Antti Koivisto.
Added basic layout test for DOM touch events.
- fast/events/basic-touch-events-expected.txt: Added.
- fast/events/basic-touch-events.html: Added.
- fast/events/script-tests/basic-touch-events.js: Added. (appendEventLog): (verifyTouchEvent): (verifyTouchPoint): (singleTouchSequence): (multiTouchSequence): (touchTargets):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 6:07 AM Changeset in webkit [51981] by
-
- 15 edits13 adds in trunk/WebCore
2009-12-11 Simon Hausmann <Simon Hausmann>, Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Added interfaces for touch event support in JavaScript.
The Touch, TouchEvent and TouchList interfaces come straight from
Android's copy of WebKit (eclaire branch).
The PlatformTouchEvent and PlatformTouchPoint code was written by
us.
No new tests added, we are just adding interfaces
with this patch.
- WebCore.pro:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Document.cpp: (WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h: (WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp: (WebCore::Event::isTouchEvent):
- dom/Event.h:
- dom/EventNames.h:
- dom/Touch.cpp: Added. (WebCore::contentsX): (WebCore::contentsY): (WebCore::Touch::Touch): (WebCore::Touch::updateLocation):
- dom/Touch.h: Added. (WebCore::Touch::create): (WebCore::Touch::frame): (WebCore::Touch::target): (WebCore::Touch::identifier): (WebCore::Touch::clientX): (WebCore::Touch::clientY): (WebCore::Touch::screenX): (WebCore::Touch::screenY): (WebCore::Touch::pageX): (WebCore::Touch::pageY):
- dom/Touch.idl: Added.
- dom/TouchEvent.cpp: Added. (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: Added. (WebCore::TouchEvent::create): (WebCore::TouchEvent::touches): (WebCore::TouchEvent::targetTouches): (WebCore::TouchEvent::changedTouches): (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::isTouchEvent):
- dom/TouchEvent.idl: Added.
- dom/TouchList.cpp: Added. (WebCore::TouchList::item):
- dom/TouchList.h: Added. (WebCore::TouchList::create): (WebCore::TouchList::length): (WebCore::TouchList::append): (WebCore::TouchList::TouchList):
- dom/TouchList.idl: Added.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- platform/PlatformTouchEvent.h: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::touchPoints):
- platform/PlatformTouchPoint.h: Added. (WebCore::PlatformTouchPoint::): (WebCore::PlatformTouchPoint::id): (WebCore::PlatformTouchPoint::state): (WebCore::PlatformTouchPoint::screenPos): (WebCore::PlatformTouchPoint::pos):
- platform/qt/PlatformTouchEventQt.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/qt/PlatformTouchPointQt.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):
- 4:46 AM WebKit Team edited by
- Add Haiku and myself. (diff)
- 4:20 AM Changeset in webkit [51980] by
-
- 3 edits in trunk/WebCore
[Android] Add detachHistoryItem() to AndroidWebHistoryBridge. And the constructor takes
HistoryItem* now. As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and
HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared
when HistoryItem is deleted to avoid potential crash.
https://bugs.webkit.org/show_bug.cgi?id=32251
Patch by Grace Kloba <klobag@gmail.com> on 2009-12-11
Reviewed by Darin Adler.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
- history/android/AndroidWebHistoryBridge.h:
(WebCore::AndroidWebHistoryBridge::AndroidWebHistoryBridge):
(WebCore::AndroidWebHistoryBridge::detachHistoryItem):
- 3:04 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 2:44 AM Changeset in webkit [51979] by
-
- 7 edits in trunk
2009-12-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Pavel Feldman.
Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=32165
- websocket/tests/handshake-error-expected.txt:
- websocket/tests/handshake-fail-by-cross-origin-expected.txt:
- websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt:
2009-12-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Pavel Feldman.
Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=32165
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
- 2:09 AM QtWebKitFeatures46 edited by
- (diff)
- 12:31 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 12:06 AM QtWebKit/CodeCamp200912 edited by
- add bug links (diff)
Dec 10, 2009:
- 11:54 PM QtWebKit/CodeCamp200912 edited by
- Start documenting day 3 (diff)
- 11:51 PM QtWebKit/CodeCamp200912 edited by
- (diff)
- 7:42 PM Changeset in webkit [51978] by
-
- 5 edits in trunk/JavaScriptCore
2009-12-10 Adam Barth <abarth@webkit.org>
No review, rolling out r51975.
http://trac.webkit.org/changeset/51975
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h: (JSC::JSString::JSString): (JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp: (JSC::jsAddSlowCase):
- runtime/Operations.h: (JSC::jsString): (JSC::jsAdd):
- 7:12 PM Changeset in webkit [51977] by
-
- 3 edits3 adds in trunk
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
- http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt: Added.
- http/tests/security/mixedContent/empty-url-plugin-in-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-empty-url-plugin.html: Added.
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
These plug-ins cannot be controlled by active network attackers, so
there's no reason to trigger a mixed content warning.
Test: http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
- 6:22 PM Changeset in webkit [51976] by
-
- 5 edits in trunk
Incorrect caching of prototype lookup with dictionary base
https://bugs.webkit.org/show_bug.cgi?id=32402
Reviewed by Gavin Barraclough
Make sure we don't add cached prototype lookup to the proto_list
lookup chain if the top level object is a dictionary.
- 6:07 PM Changeset in webkit [51975] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Reviewed by Oliver Hunt.
~1% progression on Sunspidey.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
- 4:58 PM Changeset in webkit [51974] by
-
- 2 edits in trunk/WebKit/chromium
Unreviewed, build fix for chromium.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 4:41 PM Changeset in webkit [51973] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32140
REGRESSION(r50072): Mailman administrative functionality is broken
Test: http/tests/misc/percent-sign-in-form-field-name.html
- platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent sign, we never had a good reason to do that.
- 4:20 PM Changeset in webkit [51972] by
-
- 3 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
No review, just updating unit tests to match recent checkins.
- Scripts/modules/mock_bugzillatool.py:
- Add missing red_core_builders_names method causing exception.
- Scripts/modules/workqueue_unittest.py:
- processutils is dead, use executive.py instead.
- 4:06 PM Changeset in webkit [51971] by
-
- 17 edits in trunk
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove JSObject::getPropertyAttributes() and all usage of it.
https://bugs.webkit.org/show_bug.cgi?id=31933
getOwnPropertyDescriptor() should be used instead.
- JavaScriptCore.exp:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyDescriptor):
- debugger/DebuggerActivation.h:
- runtime/JSObject.cpp: (JSC::JSObject::propertyIsEnumerable):
- runtime/JSObject.h:
- runtime/JSVariableObject.cpp:
- runtime/JSVariableObject.h:
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove getPropertyAttributes() from JavaScript bindings.
https://bugs.webkit.org/show_bug.cgi?id=31933
The functionality is provided by getOwnPropertyDescriptor().
- WebCore.order:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.idl:
- 3:55 PM Changeset in webkit [51970] by
-
- 23 edits3 adds in trunk
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt:
- fast/canvas/webgl/drawArraysOutOfBounds.html:
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt:
- fast/canvas/webgl/drawElementssOutOfBounds.html:
- fast/canvas/webgl/error-reporting-expected.txt: Added.
- fast/canvas/webgl/error-reporting.html: Added.
- fast/canvas/webgl/getActiveTest-expected.txt:
- fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt:
- fast/canvas/webgl/invalidPassedParams-expected.txt:
- fast/canvas/webgl/invalidPassedParams.html:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/resources/webgl-test.js: (create3DDebugContext.wrap.getError): (create3DDebugContext):
- fast/canvas/webgl/script-tests/error-reporting.js: Added.
- fast/canvas/webgl/script-tests/getActiveTest.js:
- fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
- fast/canvas/webgl/script-tests/uniform-location.js:
- fast/canvas/webgl/uniform-location-expected.txt:
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
- 3:47 PM Changeset in webkit [51969] by
-
- 4 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move run_command onto Executive to make code which uses run_command testable
https://bugs.webkit.org/show_bug.cgi?id=32396
- Scripts/modules/executive.py:
- Move run_command and error handlers onto Executive.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 3:40 PM Changeset in webkit [51968] by
-
- 2 edits in trunk/WebCore
2009-12-10 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fix for assert on Chrome/skia with SVG Filters enabled.
https://bugs.webkit.org/show_bug.cgi?id=32394
Covered by LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- 3:33 PM Changeset in webkit [51967] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-10 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
Fix FrameLoader to use the new ResourceTypes properly.
- public/WebURLRequest.h: (WebKit::WebURLRequest::):
- src/FrameLoaderClientImpl.cpp: (WebKit::setTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 3:28 PM Changeset in webkit [51966] by
-
- 1 edit5 adds in trunk/LayoutTests
Layout test for video element on HTTP
https://bugs.webkit.org/show_bug.cgi?id=32333
Reviewed by Eric Carlson.
Added a new layout test that tests video element on HTTP protocol.
This test load the same video file twice. The first load will cache
the video file if caching is supported. The second load ensure
the cache works correctly.
- http/tests/media/resources/test.mp4: Copied from LayoutTests/media/content/test.mp4.
- http/tests/media/resources/test.ogv: Copied from LayoutTests/media/content/test.ogv.
The above two files are copied from LayoutTests/media/content because the HTTP
server is rooted at LayoutTests/http/tests. And we don't want to serve these
files with cgi because that will ruin the HTTP headers.
- http/tests/media/video-load-twice-expected.txt: Added.
- http/tests/media/video-load-twice.html: Added.
- 2:59 PM Changeset in webkit [51965] by
-
- 7 edits2 adds in trunk
REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
<rdar://problem/7442065>
https://bugs.webkit.org/show_bug.cgi?id=32285
Reviewed by Darin Adler.
WebCore:
When examining the styles of the nodes after the first in a range selection, we take into
cosideration differences in style of txt nodes only.
Test: editing/execCommand/queryCommandState-02.html
- editing/Editor.cpp:
(WebCore::Editor::selectionHasStyle):
LayoutTests:
- editing/execCommand/queryCommandState-02-expected.txt: Added.
- editing/execCommand/queryCommandState-02.html: Added.
- editing/execCommand/script-tests/toggle-compound-styles.js: Fixed typo in text.
- platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- 2:13 PM Changeset in webkit [51964] by
-
- 7 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32367
Add support for short Ropes (up to 3 entries) inline within JSString.
(rather than externally allocating an object to hold the rope).
Switch jsAdd of (JSString* + JSString*) to now make use of Ropes.
Reviewed by Oliver Hunt & Mark Rowe.
~1% progression on Sunspidey.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::deref):
(JSC::JSString::Rope::Fiber::ref):
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
(JSC::JSString::JSString):
(JSC::JSString::~JSString):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::length):
(JSC::JSString::canGetIndex):
(JSC::JSString::appendStringInConstruct):
(JSC::JSString::appendValueInConstructAndIncrementLength):
(JSC::JSString::isRope):
(JSC::JSString::string):
(JSC::JSString::ropeLength):
(JSC::JSString::getStringPropertySlot):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
(JSC::resolveBase):
- 2:10 PM Changeset in webkit [51963] by
-
- 2 edits in trunk/LayoutTests
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, fixing layout test mishap.
Add a newline to the layout test.
- http/tests/security/isolatedWorld/events-expected.txt: Added a newline at the end of the file.
- 2:06 PM Changeset in webkit [51962] by
-
- 5 edits3 adds in trunk
Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing
https://bugs.webkit.org/show_bug.cgi?id=31576
Reviewed by Alexey Proskuryakov.
Add a RefCounted wrapper object around xmlParserCtxtPtr so we can
maintain it's lifetime more effectively.
Test: fast/parser/xhtml-close-while-parsing.xhtml
- 1:59 PM BuildingQtOnOSX edited by
- Require qt4-mac-dev (v4.6) instead of qt4-mac (v4.5.3). See … (diff)
- 1:54 PM Changeset in webkit [51961] by
-
- 4 edits in trunk/WebCore
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: debugger shortcuts don't work when
Search field or Console drawer has focus.
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentKeyUp): (WebInspector.searchKeyDown):
- 1:42 PM Changeset in webkit [51960] by
-
- 17 edits2 copies2 adds in trunk
WebCore:
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
Test: http/tests/security/isolatedWorld/events.html
- WebCore.gypi: Added WorldContextHandle.
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Added WorldContextHandle params.
- bindings/v8/SharedPersistent.h: Fixed a few style/include issues.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Added WorldContextHandle params. (WebCore::V8AbstractEventListener::handleEvent): Adjusted context retrieval to use WorldContextHandle. (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::worldContext): Added WorldContextHandle params.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Ditto.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Ditto. (WebCore::V8LazyEventListener::prepareListenerObject): Adjusted context retrieval to use WorldContextHandle.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Added WorldContextHandle params.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): Refactored to use mainWorldContext(); (WebCore::V8Proxy::mainWorldContext): Added. (WebCore::toV8Context): Changed to use WorldContextHandle.
- bindings/v8/V8Proxy.h: Added mainWorldContext decl.
- bindings/v8/V8Utilities.cpp: (WebCore::reportException): Added an extra check to avoid crashes during frame teardown.
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Added WorldContextHandle params.
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Added WorldContextHandle params.
- bindings/v8/WorldContextHandle.cpp: Added.
- bindings/v8/WorldContextHandle.h: Added.
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Added WorldContextHandle params.
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Added WorldContextHandle params.
LayoutTests:
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
This test is relevant to both JSC and V8 isolated world implementation,
ensuring that events are fired in the right worlds.
- http/tests/security/isolatedWorld/events.html: Added.
- http/tests/security/isolatedWorld/events-expected.txt: Added.
- 1:17 PM Changeset in webkit [51959] by
-
- 6 edits in trunk/WebKitTools
2009-12-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs a command to list patches needing cq+
https://bugs.webkit.org/show_bug.cgi?id=32351
- Scripts/modules/bugzilla.py:
- Parse attacher_email from attachment xml.
- Scripts/modules/bugzilla_unittest.py:
- Test new attacher_email parsing.
- Scripts/modules/commands/queries.py:
- Add PatchesToCommitQueue
- Scripts/modules/commands/queries_unittest.py:
- Tests for PatchesToCommitQueue
- Scripts/modules/mock_bugzillatool.py:
- Add necessary mock methods for running PatchesToCommitQueue
- 1:04 PM Changeset in webkit [51958] by
-
- 4 edits in trunk/WebKit/mac
Mac build fix. Unreviewed.
Re-adds code that was mistakenly removed from my last patch.
- WebCoreSupport/WebPluginHalterClient.mm:
Add necessary #import.
- WebView/WebDelegateImplementationCaching.h:
Declare a new overload of CallUIDelegateReturningBoolean.
- WebView/WebDelegateImplementationCaching.mm:
(CallDelegateReturningBoolean):
Add a new overload with different arguments.
(CallUIDelegateReturningBoolean):
Ditto.
- 12:24 PM Changeset in webkit [51957] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Add a missing null-check, that is causing some crash reports.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):
- 11:57 AM Changeset in webkit [51956] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Adam Barth <abarth@webkit.org>
Unreviewed. Turns out every StepSequence command needs a --quiet
option.
- Scripts/modules/stepsequence.py:
- 11:51 AM Changeset in webkit [51955] by
-
- 4 edits in trunk/JavaScriptCore
Fix three more things found by compiling with clang++.
Reviewed by Geoffrey Garen.
- runtime/Structure.h:
(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.
- wtf/DateMath.cpp:
(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.
- 11:33 AM Changeset in webkit [51954] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to try and fix the Windows build.
- 11:23 AM Changeset in webkit [51953] by
-
- 16 edits in trunk
Pass more information about a plug-in to the PluginHalterDelegate
Reviewed by Adam Roben.
WebCore:
- loader/EmptyClients.h:
Remove this unused class.
- page/HaltablePlugin.h:
Add new functions to return the plug-in's name and whether it is
windowed.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::timerFired):
Pass new arguments to the client.
- page/PluginHalterClient.h:
Add new parameters.
- plugins/PluginView.cpp:
(WebCore::PluginView::pluginName):
Return the name from the PluginPackage.
- plugins/PluginView.h:
(WebCore::PluginView::isWindowed):
WebKit/mac:
- Plugins/WebBaseNetscapePluginView.mm:
(WebHaltablePlugin::isWindowed):
Return false - the Mac doesn't really have windowed plug-ins.
(WebHaltablePlugin::pluginName):
Return the name from the plug-in package.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::shouldHaltPlugin):
Ditto; pass them when making the delegate call.
- WebView/WebUIDelegatePrivate.h:
Update for new parameters.
WebKit/win:
- Interfaces/IWebPluginHalterDelegate.idl:
Add new parameters.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::shouldHaltPlugin):
Update for new parameters. Pass them when making the delegate call.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- 10:58 AM Changeset in webkit [51952] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/31738>.
Web Inspector: Console Scope Bar should be on top of console when Console is a Panel.
Reviewed by Pavel Feldman.
When the console is set to be shown as a full panel, move the scope bar to the top
where it looks best. When it is only shown as a drawer, move it to the bottom, where
it originally was. This takes up less space as a drawer, and makes it more discoverable
and usable when it is the full panel.
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.show): Move filter bar to top.
(WebInspector.ConsolePanel.prototype.hide): Move filter bar back to bottom.
- inspector/front-end/inspector.css:
- 9:54 AM Changeset in webkit [51951] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-10 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Adam Barth.
Test case to verify that sandboxing 'about:blank' does not make
the containing frame sandboxed.
- fast/frames/resources/sandboxed-iframe-about-blank.html: Added.
- fast/frames/sandboxed-iframe-about-blank-expected.txt: Added.
- fast/frames/sandboxed-iframe-about-blank.html: Added.
- 9:13 AM Changeset in webkit [51950] by
-
- 2 edits in trunk/WebCore
Fix for alpha blending in SVG Filters on Chromium/skia.
https://bugs.webkit.org/show_bug.cgi?id=32378
Reviewed by Dirk Schulze.
Covered by LayoutTests/svg/filters/feGaussianBlur.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
- 8:44 AM Changeset in webkit [51949] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-10 Ilya Tikhonovsky <loislo@google.com>
Reviewed by Pavel Feldman.
Chromium: Expose devtools agent API for inspector layout tests.
- public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::evaluateInWebInspector):
- 6:29 AM Changeset in webkit [51948] by
-
- 8 edits2 adds in trunk
Reviewed by Xan Lopez.
[GTK] Should provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32334
First step towards a full IconDatabase API. This provides
notification for pages with favicons, and lets clients handle
them.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
- tests/resources/blank.ico: Added.
- tests/testwebview.c: Added. (server_callback): (idle_quit_loop_cb): (icon_uri_changed_cb): (icon_loaded_cb): (test_webkit_web_view_icon_uri): (main):
- webkit/webkitprivate.cpp: (closeIconDatabaseOnExit): (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (webkit_web_view_finalize): (webkit_web_view_class_init): (webkit_web_view_get_icon_uri):
- webkit/webkitwebview.h:
- 5:55 AM Changeset in webkit [51947] by
-
- 4 edits in trunk
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
DumpRenderTree has been patched so that the timeline-paint.html
unit test now runs under GTK+.
- platform/gtk/Skipped:
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Implements displayWebView() to force an invalidation and repaint.
This fixes a problem running the timeline-paint.html unit test.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (displayWebView):
- 4:53 AM Changeset in webkit [51946] by
-
- 10 edits in trunk/WebCore
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add context menu actions for DOM tree.
- English.lproj/localizedStrings.js:
- inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu): (WebInspector.ContextMenu.prototype.show): (WebInspector.ContextMenu.prototype.appendItem): (WebInspector.ContextMenu.prototype.appendSeparator): (WebInspector.ContextMenu.prototype._itemSelected): (WebInspector.contextMenuItemSelected): (WebInspector.contextMenuCleared):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._toggleURLdecoding):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.js: (WebInspector.contextMenuEventFired):
- inspector/front-end/treeoutline.js: (TreeElement.treeElementDoubleClicked):
- 4:05 AM Changeset in webkit [51945] by
-
- 20 edits in trunk/WebCore
2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
Filters contain some leaks in untested code
https://bugs.webkit.org/show_bug.cgi?id=32325
Fix obvious leak in SVGFE*Lighting classes. Implement the create() idiom for
all classes in svg/graphics, that were missing it. The lighting filters aren't
implemented so far, but the associated FilterEffect objects are build, which created
these leaks.
This removes the SVG related failures in the leaks bot.
- 4:04 AM Changeset in webkit [51944] by
-
- 3 edits in trunk/LayoutTests
2009-12-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip two tests on gtk/qt that generate new results.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 2:13 AM QtBackLog edited by
- (diff)
- 2:13 AM QtBackLog edited by
- (diff)
- 1:21 AM Changeset in webkit [51943] by
-
- 3 edits2 adds in trunk
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- fast/canvas/webgl/bug-32364-expected.txt: Added.
- fast/canvas/webgl/bug-32364.html: Added.
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi):
- 12:33 AM Changeset in webkit [51942] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert more commands to StepSequences
https://bugs.webkit.org/show_bug.cgi?id=32362
We should eventually convert all the commands, but I'm starting with
the easy ones.
- Scripts/modules/commands/download.py:
- 12:21 AM Changeset in webkit [51941] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
https://bugs.webkit.org/show_bug.cgi?id=31103
Give focus to the webviews when we create them, since some tests expect this.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
- 12:18 AM Changeset in webkit [51940] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool "builders are red" error should tell you which builders
https://bugs.webkit.org/show_bug.cgi?id=32211
- Scripts/modules/buildsteps.py:
Dec 9, 2009:
- 11:47 PM Changeset in webkit [51939] by
-
- 4 edits3 adds in trunk
2009-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Google reader gets stuck in the "Loading..." state and does not complete
https://bugs.webkit.org/show_bug.cgi?id=32256
<rdar://problem/7456388>
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jless): Fix some backward branches.
2009-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Test for: Google reader gets stuck in the "Loading..." state and does not complete
https://bugs.webkit.org/show_bug.cgi?id=32256
- fast/js/codegen-jless-expected.txt: Added.
- fast/js/codegen-jless.html: Added.
- fast/js/script-tests/codegen-jless.js: Added.
- 11:29 PM Changeset in webkit [51938] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Skip a timeouter flakey test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-scripting.html added.
- 11:22 PM Changeset in webkit [51937] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, build fix.
Change forward declaration of WebContextMenuData from class to
struct to match its definition. The bug was introduced by
http://trac.webkit.org/changeset/51874
- src/ContextMenuClientImpl.h:
- 10:07 PM Changeset in webkit [51936] by
-
- 5 edits8 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG property
-webkit-shadow should apply shadow on the result after compositing
-and corresponding-
<rdar://problem/7389404>
Reviewed by Oliver Hunt.
Set a transparency layer when setting a shadow to apply the shadow
to the composite.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG
property -webkit-shadow should apply shadow on the result after
compositing
-and corresponding-
<rdar://problem/7389404>
Reviewed by Oliver Hunt.
New tests:
- platform/mac/svg/css/composite-shadow-example-expected.checksum: Added.
- platform/mac/svg/css/composite-shadow-example-expected.png: Added.
- platform/mac/svg/css/composite-shadow-example-expected.txt: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- svg/css/composite-shadow-example.html: Added.
- svg/css/composite-shadow-with-opacity.html: Added.
New and improved results:
- platform/mac/svg/css/group-with-shadow-expected.checksum:
- platform/mac/svg/css/group-with-shadow-expected.png:
- 7:32 PM Changeset in webkit [51935] by
-
- 5 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32332
WebSocket events should be dispatched synchronously
Updated websocket/tests/simple to test for the new behavior.
When Web Sockets API says that events should be queued for async dispatch, it means something
different. We should keep this in mind when dealing with other HTML5-related specs.
The model for HTML5 is that code running in response to network events (e.g. WebSocket or
XMLHttpRequest algorithms) runs in a separate thread of execution, and thus needs to post
async events as its only way to communicate with client code. As long as network events are
queued themselves (as they are in WebKit), there is no need to queue JS events for async
dispatch.
- websockets/WebSocket.cpp: (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
- 7:30 PM Changeset in webkit [51934] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32355
Assertion failure when opening a WebSocket connection
I couldn't make a reliable test for this. Once the test from bug 32299 is landed, it
will provide partial coverage, as I was frequently seeing the assertion failure with it.
- platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): It's not an error if zero if returned from platformSend() - it just means that nothing could be pushed down to the network layer, and all data was queued for later.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): This will no longer happen with SocketStream, but a client can potentially destroy the handle from any callback, so we need to check that this didn't happen. (WebCore::SocketStreamHandle::writeStreamCallback): Ditto.
- 5:44 PM Changeset in webkit [51933] by
-
- 6 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).
Reviewed by Oliver Hunt.
- runtime/JSString.cpp:
(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):
- runtime/JSString.h:
(JSC::JSString::Rope::initializeFiber):
- runtime/Operations.h:
(JSC::concatenateStrings):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=32228
Reenabling tests.
Reviewed by Oliver Hunt.
- platform/win/Skipped:
- 4:58 PM Changeset in webkit [51932] by
-
- 5 edits in trunk
2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>
Reviewed by Adam Roben.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.
- building/build.html:
- removed the reference to forgetting to set environment variables as a common source of errors on Windows. This is because this patch would make it unnecessary for the user to set these variables manually.
2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>
Reviewed by Adam Roben.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.
- Scripts/update-webkit:
- Run setupAppleWinEnv() on Apple's Windows port.
- Scripts/webkitdirs.pm:
- Added functions that return the source directory, libraries directory and default build directory on Windows.
- Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
- Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir and Cygwin to their desired values.
- 4:23 PM Changeset in webkit [51931] by
-
- 3 edits in trunk/WebCore
Roll out 51919 and 51920. They were incorrect and unnecessary right now.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 3:32 PM Changeset in webkit [51930] by
-
- 2 edits in trunk/WebCore
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Adds wtf/StdLibExtras.h include for DEFINE_STATIC_LOCAL in V8 ScriptState.
https://bugs.webkit.org/show_bug.cgi?id=32330
Build fix only, no new tests.
- bindings/v8/ScriptState.cpp: Modified. Adds wtf/StdLibExtras.h include.
- 3:08 PM Changeset in webkit [51929] by
-
- 2 edits in trunk/WebKitSite
2009-12-09 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added the "using std::foo" rule to the coding style guidelines.
Added to the coding style guidelines the "using std::foo" rule
checked by the check-webkit-style script. Also clarified the
"using" statement guidelines that apply to implementation files.
- coding/coding-style.html:
- 3:01 PM Changeset in webkit [51928] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.
- runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):
- 2:54 PM Changeset in webkit [51927] by
-
- 3 edits in trunk/WebCore
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Adds ENABLE(INSPECTOR) guards around script binding methods that use types
defined only when INSPECTOR is enabled.
https://bugs.webkit.org/show_bug.cgi?id=32328
Build fix only, no new tests.
- bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
- bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
- 2:47 PM Changeset in webkit [51926] by
-
- 10 edits2 adds in trunk
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds Android Makefiles for building with V8.
https://bugs.webkit.org/show_bug.cgi?id=32278
- Android.mk: Modified. Includes Makefiles for V8.
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Updates Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278
- Android.mk: Modified.
- Android.v8.wtf.mk: Modified.
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds Android Makefiles for building with V8.
Also updates existing Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278
Build fix only, no new tests.
- Android.derived.jscbindings.mk: Modified.
- Android.derived.mk: Modified.
- Android.derived.v8bindings.mk: Added.
- Android.jscbindings.mk: Modified.
- Android.mk: Modified.
- Android.v8bindings.mk: Added.
- 2:35 PM Changeset in webkit [51925] by
-
- 2 edits in trunk/WebCore
Bug 32338 - [Chromium] Fix Chromium builder by including missing GeolocationServiceChromium
https://bugs.webkit.org/show_bug.cgi?id=32338
Patch by Jonathan Dixon <joth@chromium.org> on 2009-12-09
Reviewed by Dimitri Glazkov.
Fix build break: re-include file dropped out by merge in http://trac.webkit.org/changeset/51681/trunk/WebCore/WebCore.gypi
- WebCore.gypi: Add missing GeolocationServiceChromium.cpp
- 2:32 PM Changeset in webkit [51924] by
-
- 2 edits in trunk/WebCore
2009-12-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Brady Eidson.
Fixed a typo in http://trac.webkit.org/changeset/51644 that broke
the QWebPage autotest.
No new test required.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateToDifferentDocument):
- 2:25 PM Changeset in webkit [51923] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
exception thrown when running apply-patches
https://bugs.webkit.org/show_bug.cgi?id=32344
The update step now takes a port option. Once we finish the Steps
refactoring, we won't have to worry about this kind of bug again.
- Scripts/modules/commands/download.py:
- 2:18 PM Changeset in webkit [51922] by
-
- 2 edits in trunk/WebCore
2009-12-09 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Exclude JSSVG*.cpp generated files from --minimal and --no-svg builds.
- WebCore.pro:
- 2:11 PM Changeset in webkit [51921] by
-
- 2 edits in trunk/WebCore
2009-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
Ogg mimetypes are incorrect
https://bugs.webkit.org/show_bug.cgi?id=27113
The ogg extension is handled by audio/ogg instead of
application/ogg. See
http://wiki.xiph.org/MIME_Types_and_File_Extensions
- platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::):
- 1:57 PM Changeset in webkit [51920] by
-
- 2 edits in trunk/WebCore
Use the current run loop instead of the main runloop for the NetworkStateNotifier.
Reviewed by Anders Carlsson.
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 1:55 PM Changeset in webkit [51919] by
-
- 2 edits in trunk/WebCore
Use isMainThread() helper instead of pthread_main_np() != 0.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- 1:37 PM Changeset in webkit [51918] by
-
- 2 edits in trunk/LayoutTests
Skip a failing test that needs DRT support to override standard
preferences.
- platform/gtk/Skipped:
- 1:36 PM Changeset in webkit [51917] by
-
- 5 edits in trunk/WebKit/chromium
2009-12-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32324
[Chromium] Suppress WebFrameClient callbacks from a detached frame.
This change means that we no longer need the ClientHandle class.
FrameLoaderClient::detachedFromParent3() is called on each frame
in the frame tree from within frameDetached().
Test: http/tests/loading/gmail-assert-on-load.html
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::createChildFrame):
- src/WebFrameImpl.h: (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::close):
- 1:31 PM Changeset in webkit [51916] by
-
- 11 edits in trunk/WebCore
Add some #ifdefs to allow us to experiment with a single NSView mac WebKit.
Reviewed by Anders Carlsson.
- page/Chrome.h:
- page/EventHandler.h:
- page/mac/ChromeMac.mm:
- page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventLoopHandleMouseDragged):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::createDraggingClipboard):
(WebCore::isKeyboardOptionTab):
(WebCore::EventHandler::invertSenseOfTabsToLinks):
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
(WebCore::EventHandler::accessKeyModifiers):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/Widget.cpp:
- platform/Widget.h:
- platform/mac/ScrollViewMac.mm:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setCursor):
(WebCore::Widget::paint):
(WebCore::Widget::setFocus):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
- 12:36 PM Changeset in webkit [51915] by
-
- 4 edits in trunk/WebCore
2009-12-09 Michael Nordman <Michael Nordman>
Reviewed by Dimitri Glazkov.
Chromium build fix.
No new tests.
- bindings/v8/DOMData.cpp
- bindings/v8/V8DOMWrapper.cpp
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- 12:31 PM Changeset in webkit [51914] by
-
- 2 edits in trunk/JavaScriptCore
Fix a bug found while trying to compile JavaScriptCore with clang++.
Reviewed by Gavin Barraclough.
- yarr/RegexPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm): Don't self assign here. Use false instead.
- 12:26 PM Changeset in webkit [51913] by
-
- 2 edits in trunk/WebKit/win
Revert incorrect commit-box update r51911.
It mistakenly set the selectAll implementation in the
deslectAll method.
- WebFrame.cpp:
(WebFrame::deselectAll):
- 12:14 PM Changeset in webkit [51912] by
-
- 2 edits in trunk/WebCore
2009-12-09 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Pavel Feldman.
[V8] Isolated world reuse failure
https://bugs.webkit.org/show_bug.cgi?id=32306
Fixed bug introduced in r51407: (http://trac.webkit.org/changeset/51407) which caused layout test
LayoutTests/http/tests/security/isolatedWorld/world-reuse.html to fail.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::contextDebugId):
- 12:06 PM Changeset in webkit [51911] by
-
- 2 edits in trunk/WebKit/win
2009-12-09 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
- WebFrame.cpp: (WebFrame::selectAll): Implement "SelectAll" command.
- 11:59 AM Changeset in webkit [51910] by
-
- 2 edits in trunk/WebCore
2009-12-09 Patrick Scott <phanna@email.unc.edu>
Fix the build with ENABLE_ORIENTATION_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=32321
- page/Frame.cpp: (WebCore::Frame::sendOrientationChangeEvent):
- 11:52 AM Changeset in webkit [51909] by
-
- 2 edits in trunk/WebCore
2009-12-09 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Chromium tickmarks in scrollbar now UX approved.
https://bugs.webkit.org/show_bug.cgi?id=32069
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
- 11:00 AM Changeset in webkit [51908] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the Windows build.
Reviewed by Sam Weinig.
- wtf/FastMalloc.h:
- 10:53 AM Changeset in webkit [51907] by
-
- 2 edits in trunk/WebKit/win
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
Reviewed by Darin Adler.
- WebFrame.cpp:
(WebFrame::selectAll): Implement "SelectAll" command.
- 10:44 AM Changeset in webkit [51906] by
-
- 9 edits in trunk
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
Add logic to turn off accelerated compositing if d3d9 or QuartzCore
DLLs are not present.
- 10:40 AM Changeset in webkit [51905] by
-
- 4 edits in trunk/JavaScriptCore
Fix some things found while trying to compile JavaScriptCore with clang++.
Reviewed by Sam Weinig.
- wtf/FastMalloc.h:
Add correct exception specifications for the allocation/deallocation operators.
- wtf/Vector.h:
- wtf/VectorTraits.h:
Fix a bunch of struct/class mismatches.
- 10:22 AM Changeset in webkit [51904] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Include clickCount when doing MouseEvent -> WebMouseEvent conversion
in Chromium API.
- src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
- 10:11 AM Changeset in webkit [51903] by
-
- 4 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed. Fix ScriptError includes. I don't understand why these
didn't throw during unit testing...
- Scripts/modules/commands/download.py:
- Scripts/modules/logging_unittest.py:
- Scripts/modules/workqueue.py:
- 9:43 AM Changeset in webkit [51902] by
-
- 13 edits2 moves in trunk/WebCore
2009-12-09 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Rename dom/ClassNames to SpaceSplitString and update build files.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules):
- dom/ClassNames.cpp: Removed.
- dom/ClassNames.h: Removed.
- dom/ClassNodeList.h:
- dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::classNames):
- dom/SpaceSplitString.cpp: Copied from WebCore/dom/ClassNames.cpp. (WebCore::SpaceSplitStringData::createVector): (WebCore::SpaceSplitStringData::containsAll):
- dom/SpaceSplitString.h: Copied from WebCore/dom/ClassNames.h. (WebCore::SpaceSplitStringData::SpaceSplitStringData): (WebCore::SpaceSplitString::SpaceSplitString): (WebCore::SpaceSplitString::set): (WebCore::SpaceSplitString::containsAll):
- dom/StyledElement.h: (WebCore::StyledElement::classNames):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setRel):
- 9:28 AM Changeset in webkit [51901] by
-
- 8 edits in trunk/WebCore
Enable SVG filters in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=32323
Reviewed by Darin Fisher.
Covered by SVG filter layout tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:59 AM QtWebKit/CodeCamp200912 edited by
- mention the performance talks (diff)
- 7:26 AM Changeset in webkit [51900] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, build fix.
Add return statement to default implementation of hostIdentifier method
introduced in http://trac.webkit.org/changeset/51897
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::hostIdentifier):
- 7:05 AM Changeset in webkit [51899] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add declaration of static methods that allow to dispatch
DevTools messages on the IO thread and accept WebDevToolsMessageData
argument.
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- 5:27 AM Changeset in webkit [51898] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip a failing test introduced in r51877.
- platform/qt/Skipped: fast/loader/input-element-page-cache-crash.html added.
- 5:19 AM Changeset in webkit [51897] by
-
- 6 edits1 copy in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce a class for devtools message data
- WebKit.gyp:
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToFrontend): (WebKit::WebDevToolsAgentClient::forceRepaint): (WebKit::WebDevToolsAgentClient::hostIdentifier): (WebKit::WebDevToolsAgentClient::runtimeFeatureStateChanged):
- public/WebDevToolsFrontend.h:
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
- public/WebDevToolsMessageData.h: Added.
- 5:04 AM Changeset in webkit [51896] by
-
- 2 edits in trunk/LayoutTests
2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo in the Skipped list s/.htm/.html/ in the last test I added.
- platform/mac-snowleopard/Skipped:
- 3:34 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 2:09 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 1:54 AM WebKit Team edited by
- (diff)
- 1:39 AM Changeset in webkit [51895] by
-
- 4 edits1 delete in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Remove unused PatchCollection class
https://bugs.webkit.org/show_bug.cgi?id=32312
It's dead code.
- Scripts/modules/patchcollection.py:
- Scripts/modules/patchcollection_unittest.py: Removed.
- 1:29 AM Changeset in webkit [51894] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. CheckStyle needs a --no-upate option.
- Scripts/modules/commands/download.py:
- 1:24 AM Changeset in webkit [51893] by
-
- 4 edits1 add in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert Build to use Sequence
https://bugs.webkit.org/show_bug.cgi?id=32310
So much prettier.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/stepsequence.py: Added.
- 1:17 AM Changeset in webkit [51892] by
-
- 3 edits in trunk/WebCore
Build fix
- 12:26 AM Changeset in webkit [51891] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Add missing file.
- Scripts/modules/executive.py: Added.
- 12:24 AM Changeset in webkit [51890] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix.
- Scripts/modules/landingsequence.py:
- 12:20 AM Changeset in webkit [51889] by
-
- 12 edits1 delete in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement abstract Steps
https://bugs.webkit.org/show_bug.cgi?id=32212
This is a fairly disruptive change that refactors how we build
commands. Instead of using a landing sequence, we can now assemble a
sequence of steps directly. We still use the landing sequence in the
interim, but this will be removed soon.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/processutils.py: Removed.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- Scripts/modules/webkitport.py:
Dec 8, 2009:
- 11:51 PM Changeset in webkit [51888] by
-
- 11 edits in trunk/WebKitTools
2009-12-08 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run_command and ScriptError should move into processutils.py
https://bugs.webkit.org/show_bug.cgi?id=32305
Turns out there are a zillion callers to run_command.
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/logging_unittest.py:
- Scripts/modules/processutils.py:
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- Scripts/modules/workqueue.py:
- Scripts/modules/workqueue_unittest.py:
- 7:43 PM Changeset in webkit [51887] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Remove stray conflict marker.
- 7:39 PM Changeset in webkit [51886] by
-
- 7 edits3 adds in trunk
2009-12-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266
Skipped sub-protocol-with-space.html for now until new pywebsocket is
landed.
- websocket/tests/bad-sub-protocol-expected.txt:
- websocket/tests/script-tests/bad-sub-protocol.js:
- websocket/tests/script-tests/sub-protocol-with-space.js: Added.
- websocket/tests/sub-protocol-with-space-expected.txt: Added.
- websocket/tests/sub-protocol-with-space.html: Added.
2009-12-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266
Test: websocket/tests/sub-protocol-with-space.html
- websockets/WebSocket.cpp: (WebCore::isValidProtocolString):
- 7:20 PM Changeset in webkit [51885] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Add tests that WebSocket-Protocol: is ignored if protocol was not specified.
https://bugs.webkit.org/show_bug.cgi?id=32267
- websocket/tests/script-tests/websocket-protocol-ignored.js: Added.
- websocket/tests/websocket-protocol-ignored-expected.txt: Added.
- websocket/tests/websocket-protocol-ignored.html: Added.
- 6:38 PM Changeset in webkit [51884] by
-
- 14 edits7 adds in trunk
2009-12-08 Peterson Trethewey <petersont@google.com>
Reviewed by Oliver Hunt.
Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173
- fast/canvas/webgl/resources/structUniformShader.vert: Added.
- fast/canvas/webgl/script-tests/uniform-location.js: Added.
- fast/canvas/webgl/uniform-location-expected.txt: Added.
- fast/canvas/webgl/uniform-location.html: Added.
2009-12-08 Peterson Trethewey <petersont@google.com>
Reviewed by Oliver Hunt.
Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173
Test: fast/canvas/webgl/uniform-location.html
- DerivedSources.make:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getProgramParameter): (WebCore::JSWebGLRenderingContext::getUniform): (WebCore::functionForUniform): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toWebGLUniformLocation): (WebCore::): (WebCore::CALLBACK_FUNC_DECL): (WebCore::isFunctionToCallForAttribute): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- html/canvas/WebGLUniformLocation.cpp: Added. (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation):
- html/canvas/WebGLUniformLocation.h: Added. (WebCore::WebGLUniformLocation::~WebGLUniformLocation): (WebCore::WebGLUniformLocation::program): (WebCore::WebGLUniformLocation::location):
- html/canvas/WebGLUniformLocation.idl: Added.
- 5:43 PM Changeset in webkit [51883] by
-
- 3 edits2 adds in trunk
2009-12-08 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo
startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).
Thanks to Robert Swiecki for the test case.
https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880
Test: fast/css/recursive-delay-update-scroll.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
2009-12-08 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo
startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).
Thanks to Robert Swiecki for the test case.
https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880
- fast/css/recursive-delay-update-scroll.html: Added.
- fast/css/recursive-delay-update-scroll-expected.txt: Added.
- 5:29 PM Changeset in webkit [51882] by
-
- 9 edits1 copy in trunk/JavaScriptCore
move code generation portions of Nodes.cpp to bytecompiler directory
https://bugs.webkit.org/show_bug.cgi?id=32284
Reviewed by Darin Adler.
- bytecompiler/NodesCodegen.cpp: Copied from parser/Nodes.cpp. Removed parts that
are not about codegen.
- parser/Nodes.cpp: Removed everything that is about codegen.
Update build systems:
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- 4:59 PM Changeset in webkit [51881] by
-
- 2 edits in trunk/WebCore
WebCore source level debugging on Windows not reliable in some cases
https://bugs.webkit.org/show_bug.cgi?id=32297
Reviewed by Adam Roben.
Customized pdb file name/location for WebCore static library.
- WebCore.vcproj/WebCoreCommon.vsprops: Add ProgramDataBaseFileName.
- 4:52 PM Changeset in webkit [51880] by
-
- 14 edits1 add in trunk
Reviewed by Kevin Ollivier.
[wx] Mac plugins support.
https://bugs.webkit.org/show_bug.cgi?id=32236
- 4:40 PM Changeset in webkit [51879] by
-
- 2 edits in trunk/WebKit/mac
2009-12-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7295070> WebKit video fullscreen keeps playing after closing the window
Fix a leak of the QTMovieView when exiting fullscreen video, and remove the
old workaround.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): Set the movie view as the contentView directly. (-[WebVideoFullscreenController setMediaElement:WebCore::]): Cast the contentView to a movie view. (-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the old workaround.
- 4:14 PM Changeset in webkit [51878] by
-
- 2 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip another failing media test, that I already mentioned in the bug report.
- platform/mac-snowleopard/Skipped:
- 4:08 PM Changeset in webkit [51877] by
-
- 3 edits2 adds in trunk
Navigating to a cached page can result in accessing a destroyed HTMLInputElement.
<rdar://problem/6856662> and https://webkit.org/b/32293
Reviewed by Darin Adler.
WebCore:
Test: fast/loader/input-element-page-cache-crash.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Make sure to unregister for the activation
callback after the new m_autocomplete setting has been stored so the unregistration actually
takes place.
LayoutTests:
- fast/loader/input-element-page-cache-crash-expected.txt: Added.
- fast/loader/input-element-page-cache-crash.html: Added.
- 3:54 PM Changeset in webkit [51876] by
-
- 3 edits in trunk/WebKitTools
[check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
https://bugs.webkit.org/show_bug.cgi?id=32193
Reviewed by Adam Barth.
- Scripts/modules/cpp_style.py: For the function { rule, if there is space at the beginning of line, ignore lines which then have a macro.
- Scripts/modules/cpp_style_unittest.py: Add tests to verify the new behavior.
- 3:27 PM Changeset in webkit [51875] by
-
- 14 edits5 deletes in trunk
Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
It may have caused massive increase of reported leaks on the bots.
https://bugs.webkit.org/show_bug.cgi?id=31639
Rubber-stamped by David Levin.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
- wtf/ThreadVerifier.h: Removed.
JavaScriptGlue:
- ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
WebCore:
- ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
- loader/icon/IconRecord.cpp:
(WebCore::IconRecord::IconRecord):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
WebKit/mac:
- ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
WebKitTools:
- DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
- 2:45 PM WebInspector edited by
- (diff)
- 2:43 PM Changeset in webkit [51874] by
-
- 14 edits1 copy in trunk
2009-12-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Fisher.
Chromium: support custom WebCore context menu items in Chromium port.
WebCore:
- platform/ContextMenu.h:
- platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
- platform/chromium/ContextMenuChromium.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::platformDescription):
- platform/chromium/ContextMenuItemChromium.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):
WebKit/chromium:
- public/WebContextMenuData.h:
- public/WebPopupMenuInfo.h: (WebKit::WebPopupMenuInfo::Item::):
- public/WebView.h:
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::executeCustomContextMenuAction):
- src/WebViewImpl.h:
- 2:42 PM Changeset in webkit [51873] by
-
- 3 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip fast/repaint/block-selection-gap-in-table-cell.html (generates new result) to turn Qt/Gtk builds green again.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 1:58 PM Changeset in webkit [51872] by
-
- 2 edits in trunk/WebCore
2009-12-08 Adam Langley <agl@google.com>
Reviewed by Dimitri Glazkov.
Chromium Linux: set default scrollbar colours.
This is so that layout tests have sane defaults for the scrollbar
colours, even if the API user doesn't set any.
This is a fix due to r51827.
This is very well covered by existing layout tests.
- rendering/RenderThemeChromiumLinux.cpp:
- 1:35 PM Changeset in webkit [51871] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Make WebKit build correctly on FreeBSD, IA64, and Alpha.
Based on work by Petr Salinger <Petr.Salinger@seznam.cz>,
and Colin Watson <cjwatson@ubuntu.com>.
- wtf/Platform.h:
- 1:14 PM Changeset in webkit [51870] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/7397808> Crash occurs at
RenderObject::containingBlock() as I type in the Google Search
field (during page load)
Reviewed by Sam Weinig.
- editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): ownerRenderer() needs to be
null checked.
- 12:25 PM Changeset in webkit [51869] by
-
- 14 edits5 adds in trunk
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
Reviewed by Darin Adler.
- runtime/Structure.cpp:
(JSC::Structure::Structure): Disable thread verification on this class since it uses addressOfCount().
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Add ASSERT.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::derefBase): Ditto.
(WTF::RefCountedBase::disableThreadVerification): delegate to ThreadVerifier method.
- wtf/ThreadVerifier.h: Added.
(WTF::ThreadVerifier::ThreadVerifier): New Debug-only class to verify that ref/deref of RefCounted is done on the same thread.
(WTF::ThreadVerifier::activate): Activates checks. Called when ref count becomes above 2.
(WTF::ThreadVerifier::deactivate): Deactivates checks. Called when ref count drops below 2.
(WTF::ThreadVerifier::disableThreadVerification): used on objects that should not be checked (StringImpl etc)
(WTF::ThreadVerifier::verifyThread):
- GNUmakefile.am: Add ThreadVerifier.h to the build file.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
JavaScriptGlue:
- ForwardingHeaders/wtf/ThreadVerifier.h: Added.
WebCore:
- loader/icon/IconRecord.cpp:
(WebCore::IconRecord::IconRecord): Disable thread verification for this class because of its cross-thread use in IconDatabase.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer): Ditto.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Disable thread verification for this class, add FIXME to enforce proper usage via crossThreadString.
- ForwardingHeaders/wtf/ThreadVerifier.h: Added.
WebKit/mac:
- ForwardingHeaders/wtf/ThreadVerifier.h: Added.
WebKitTools:
- DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
- 11:16 AM Changeset in webkit [51868] by
-
- 2 edits in trunk/WebKit/chromium
Not reviewed: Chromium build fix.
r51859 changed the case for some of the ResourceRequest::TargetType
enums.
- src/FrameLoaderClientImpl.cpp:
(WebKit::determineTargetTypeFromLoader):
- 10:59 AM Changeset in webkit [51867] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
- 10:55 AM Changeset in webkit [51866] by
-
- 3 edits in trunk/WebKitTools
[check-webkit-style] False positive for camel case of JSC op codes
https://bugs.webkit.org/show_bug.cgi?id=32192
Reviewed by Adam Barth.
- Scripts/modules/cpp_style.py: Added an exception for the JSC op code functions and const_iterator as well since I noticed a false positive there when testing the fix.
- Scripts/modules/cpp_style_unittest.py: Added tests for these changes.
- 10:44 AM Changeset in webkit [51865] by
-
- 7 edits2 adds in trunk
2009-12-08 John Gregg <johnnyg@google.com>
Reviewed by Adam Barth.
Test for accessing the notificationCenter of a window after it's closed.
- fast/notifications/notification-after-close-expected.txt: Added.
- fast/notifications/notification-after-close.html: Added.
2009-12-08 John Gregg <johnnyg@google.com>
Reviewed by Adam Barth.
Inform the NotificationCenter when its window goes away in the same
manner as other DOMWindow fields, and prevent invalid operations on
it after that happens.
As part of this, change the V8 bindings for notifications to call
through the NotificationCenter rather than doing those operations
itself.
Test: fast/notifications/notification-after-close.html
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission):
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification): (WebCore::NotificationCenter::disconnectFrame):
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear):
- 10:44 AM CommitQueue edited by
- (diff)
- 9:37 AM Changeset in webkit [51864] by
-
- 4 edits4 adds in trunk
WebCore: Fixed block selection gap repainting in table cells
Reviewed by John Sullivan.
Test: fast/repaint/block-selection-gap-in-table-cell.html
This recently-introduced regression exposed the fact that
RenderTableCell did not override offsetFromContainer() to adjust for
the fact that table cells’ coordinates are relative to the table
section, not the table row. With this fixed, RenderTableCell no longer
needs to override mapLocalToContainer() and mapAbsoluteToLocalPoint(),
since the base class implementations of those use offsetFromContainer().
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::offsetFromContainer):
- rendering/RenderTableCell.h:
LayoutTests: Added a test of block selection gap repainting in table cells
Reviewed by John Sullivan.
- fast/repaint/block-selection-gap-in-table-cell.html: Added.
- platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Added.
- platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
- platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.
- 9:35 AM Changeset in webkit [51863] by
-
- 2 edits in trunk/WebCore
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Sane way to force a rebuild on all win slaves, according to Adam Roben.
- WebCorePrefix.h:
- 9:32 AM Changeset in webkit [51862] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct Bugzilla link
- 9:31 AM Changeset in webkit [51861] by
-
- 2 edits in trunk/WebCore
Build fix
- loader/loader.cpp:
(WebCore::cachedResourceTypeToTargetType):
- 9:08 AM Changeset in webkit [51860] by
-
- 2 edits in trunk/WebCore
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Touch svgtags.in to eventually fix the win debug build.
- svg/svgtags.in:
- 9:04 AM Changeset in webkit [51859] by
-
- 4 edits in trunk/WebCore
2009-12-08 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32152
Update the ResourceRequest::RequestType. This previously
was specific to Chromium. Moved into ResourceRequestBase, enabling
more specificity about the type (which is otherwise only known to the
loader), and also making this information available to all platforms.
Any platform with a network layer which can utilize this information
may want to use it for prioritization.
Note to Chromium glue: TargetIsSubResource renamed to TargetIsSubresource.
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::CachedResourceTypeToTargetType): (WebCore::Loader::Host::servePendingRequests):
- platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::): (WebCore::ResourceRequestBase::targetType): (WebCore::ResourceRequestBase::setTargetType): (WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
- 8:55 AM Changeset in webkit [51858] by
-
- 4 edits7 adds in trunk
2009-12-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325
- Android.mk: Added.
2009-12-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325
- Android.mk: Added.
- Android.v8.wtf.mk: Added.
2009-12-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325
Build system change only. No tests possible.
- Android.derived.jscbindings.mk: Added.
- Android.derived.mk: Added.
- Android.jscbindings.mk: Added.
- Android.mk: Added.
- WebCorePrefix.h: Modified. Sets up some flags and adds a header required for building on Android.
- 8:55 AM Changeset in webkit [51857] by
-
- 2 edits in trunk/WebKit/win
Split two-clause assertions into two separate assertions.
Reviewed by Dan Bernstein
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isTextField):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::rectOnScreen):
Added the two assertions here that all other functions in this group shared.
(DOMHTMLInputElement::selectedRange):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::setAutofilled):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::isAutofilled):
Split a two-clause assertion into two separate assertions.
- 8:36 AM Changeset in webkit [51856] by
-
- 4 edits in trunk
2009-12-08 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
- configure.ac: Require only libSoup 2.27.91 but check for 2.29.3 and define HAVE_LIBSOUP_2_29_3 in that case.
- 8:28 AM Changeset in webkit [51855] by
-
- 10 edits in trunk
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Maciej Stachowiak.
Turn on (SVG) Filters for Win.
https://bugs.webkit.org/show_bug.cgi?id=32224
- 8:17 AM Changeset in webkit [51854] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-08 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Point out the meaning of "Content-Disposition" when implementing the
mime-type-policy-decision-requested signal.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 7:58 AM Changeset in webkit [51853] by
-
- 2 edits in trunk
Rubber-stamped by Xan Lopez.
Late post-release version bump.
- configure.ac:
- 7:33 AM Changeset in webkit [51852] by
-
- 5 edits in trunk/LayoutTests
2009-12-08 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
These test results should not have platform-dependent pixel values.
https://bugs.webkit.org/show_bug.cgi?id=32265
Change is75PercentOf() so that it doesn't show pixel values when
the check is passed.
- fast/replaced/table-percent-height-expected.txt:
- fast/replaced/table-percent-height-text-controls-expected.txt:
- fast/replaced/table-percent-height-text-controls.html:
- fast/replaced/table-percent-height.html:
- 7:20 AM Changeset in webkit [51851] by
-
- 3 edits2 adds in trunk
2009-12-08 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723
- fast/css/counters/nesting-expected.txt: Added.
- fast/css/counters/nesting.html: Added. This test tests compliance with the CSS2.1 counter scoping and nesting rules.
2009-12-08 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723
Test: fast/css/counters/nesting.html
- rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Replaced the faulty counter insertion algorithm with one that works.
- 7:08 AM Changeset in webkit [51850] by
-
- 7 edits in trunk
Add isAutofilled getter to match existing setter.
Reviewed by Ada Chan.
WebCore:
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isAutofilled]):
Implemented new cover function.
- bindings/objc/DOMPrivate.h:
Declared new cover function.
WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isAutofilled):
Implemented new cover function.
- DOMHTMLClasses.h:
Declared new cover function.
- Interfaces/DOMPrivate.idl:
Declared new interface.
- 7:02 AM Changeset in webkit [51849] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().
- platform/qt/Skipped: inspector/cookie-resource-match.html added.
- 6:58 AM Changeset in webkit [51848] by
-
- 4 edits1 add in trunk
2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469
Removing hybrid configuration for --with-unicode-backend=glib
ICU not required anymore.
- autotools/webkit.m4:
2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469
Added a TextBreakIterator implementation based on GLib and pango,
which allows compiling WebCore without ICU.
- GNUmakefile.am:
- platform/text/gtk/TextBreakIteratorGtk.cpp: Added. (WebCore::): (WebCore::setUpIterator): (WebCore::characterBreakIterator): (WebCore::cursorMovementIterator): (WebCore::wordBreakIterator): (WebCore::lineBreakIterator): (WebCore::sentenceBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
- 6:35 AM Changeset in webkit [51847] by
-
- 2 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update Gtk's custom prototype-inheritance-2-expected.txt, after enabling filters
(As gtk builds with geolocation, unlike the other platforms, it needs its own results)
This turns the Gtk slave to green again.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 6:09 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 6:02 AM QtWebKit edited by
- (diff)
- 5:56 AM QtWebKit/CodeCamp200912 created by
- 5:21 AM Changeset in webkit [51846] by
-
- 11 edits2 adds in trunk
2009-12-08 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Change the way cookies are retrieved in the WebInspector frontend.
Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160
- inspector/cookie-resource-match-expected.txt: Added.
- inspector/cookie-resource-match.html: Added.
2009-12-08 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Change the way cookies are retrieved in the WebInspector frontend.
Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160
Test: inspector/cookie-resource-match.html
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
- inspector/InspectorController.h:
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._cookiesForDomain):
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get documentURL): (WebInspector.Resource.prototype.set documentURL):
- inspector/front-end/inspector.js: (WebInspector.addResource):
- 4:55 AM Changeset in webkit [51845] by
-
- 2 edits in trunk/WebCore
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)
- svg/svgtags.in:
- 4:30 AM Changeset in webkit [51844] by
-
- 2 edits in trunk/WebCore
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.
- bindings/scripts/CodeGeneratorJS.pm:
- 3:51 AM Changeset in webkit [51843] by
-
- 6 edits in trunk
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Maciej Stachowiak.
Turn on (SVG) Filters for Gtk.
https://bugs.webkit.org/show_bug.cgi?id=32224
- 3:21 AM Changeset in webkit [51842] by
-
- 2 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip some tests that fail for a longer period on the SnowLeopard bot. Filed two bugs, notifying the authors.
- platform/mac-snowleopard/Skipped:
- 2:58 AM Changeset in webkit [51841] by
-
- 4 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Oops forgot to update three results -> Qt slave green again.
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- 2:47 AM Changeset in webkit [51840] by
-
- 11 edits in trunk/LayoutTests
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Now that the Qt slave has been rebuilt, reenable all tests that failed
because of the build problems (Qt slave didn't rebuild all files with ENABLE_FILTERS set).
Update some Qt specfic filter test results.
- platform/qt/Skipped:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 2:19 AM Changeset in webkit [51839] by
-
- 22 edits2 copies in trunk/WebCore
2009-12-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: provide custom context menu in the front-end window.
- English.lproj/localizedStrings.js:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::contextMenuCleared):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuItemSelected): (WebCore::InspectorFrontendHost::contextMenuCleared):
- inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuSelectionHandler::create): (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler): (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/ContextMenu.js: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentContextMenu):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::createContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
- page/ContextMenuController.h:
- page/ContextMenuSelectionHandler.h: Added. (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler): (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
- platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- 2:04 AM Changeset in webkit [51838] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Kenneth Rohde Christiansen.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-08
[Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.
No new tests needed.
- WebCore.pro:
- 12:32 AM Changeset in webkit [51837] by
-
- 1 edit10 adds in trunk/LayoutTests
2009-12-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Add tests that WebSocket protocol argument works.
https://bugs.webkit.org/show_bug.cgi?id=3178
- websocket/tests/bad-sub-protocol-expected.txt: Added.
- websocket/tests/bad-sub-protocol.html: Added.
- websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
- websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Added.
- websocket/tests/protocol-test_wsh.py: Added.
- websocket/tests/script-tests/bad-sub-protocol.js: Added.
- websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Added.
- websocket/tests/script-tests/sub-protocol.js: Added.
- websocket/tests/sub-protocol-expected.txt: Added.
- websocket/tests/sub-protocol.html: Added.
Dec 7, 2009:
- 10:00 PM Changeset in webkit [51836] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed fix to make QtBuildBot green.
Skip failing tests caused by r51828 (Turn on (SVG) Filters for Qt.)
https://bugs.webkit.org/show_bug.cgi?id=32224
http://build.webkit.org/results/Qt%20Linux%20Release/r51828%20(4620)/results.html
- platform/qt/Skipped:
- 9:58 PM Changeset in webkit [51835] by
-
- 3 edits in trunk/WebKitTools
2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
[check-webkit-style] S_OK is a fine identifier
https://bugs.webkit.org/show_bug.cgi?id=32225
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 9:48 PM Changeset in webkit [51834] by
-
- 5 edits in trunk/LayoutTests
2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
editing/selection/last-empty-inline is failing in Windows
https://bugs.webkit.org/show_bug.cgi?id=31985
- editing/selection/last-empty-inline-expected.txt:
- editing/selection/last-empty-inline.html:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:29 PM Changeset in webkit [51833] by
-
- 3 edits in trunk/WebCore
2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Add a function to show render tree for debugging
https://bugs.webkit.org/show_bug.cgi?id=31288
No new tests because this just adds a function for debugging.
- rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderObject): (WebCore::RenderObject::showRenderTreeAndMark): (showRenderTree):
- rendering/RenderObject.h:
- 8:55 PM Changeset in webkit [51832] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-07 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Fisher.
[Chromium] accesskey is not supported on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=32213
This change fixes (partially) the accesskey issue by decoupling the
code for handling accesskeys and system keys. Because on Mac,
the modifiers of accesskeys are ctrl+alt, which are not marked as
system keys.
In order to fully fix this issue, some changes in Chromium code is
also required.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
- 8:33 PM Changeset in webkit [51831] by
-
- 2 edits in trunk/WebCore
2009-12-07 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
V8 NPObject. This should make the object enumerable and fix the
enumeration issue in layout test plugins/netscape-enumerate.html.
Also fix some existing style issues per webkit style guidelines.
Test: plugins/netscape-enumerate.html
- bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectInvokeDefaultHandler): (npObjectGetProperty): (npObjectPropertyEnumerator): (npObjectNamedPropertyEnumerator): (npObjectIndexedPropertyEnumerator): (createV8ObjectForNPObject):
- 8:19 PM Changeset in webkit [51830] by
-
- 5 edits3 deletes in trunk
2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fragments now make WebSocket URL parsing fail.
https://bugs.webkit.org/show_bug.cgi?id=32144
- websocket/tests/script-tests/url-parsing.js:
- websocket/tests/script-tests/url-with-fragment.js: Removed.
- websocket/tests/url-parsing-expected.txt:
- websocket/tests/url-with-fragment-expected.txt: Removed.
- websocket/tests/url-with-fragment.html: Removed.
2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fragments now make WebSocket URL parsing fail.
https://bugs.webkit.org/show_bug.cgi?id=32144
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 8:03 PM Changeset in webkit [51829] by
-
- 5 edits in trunk
2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Fix wrong length parsing in WebSocket.
https://bugs.webkit.org/show_bug.cgi?id=32203
These two tests assumed wrong length encoding in frame: it parsed
length from bytes with 8th bit on. But spec says length is encoded
as a series of 7-bit bytes stored in octests with the 8th bit on
*but the last byte*.
These tests encodes a frame that has 129 length, so it must be
\x81\0x01 instead of \x81\0x81.
- websocket/tests/frame-length-longer-than-buffer_wsh.py:
- websocket/tests/frame-length-skip_wsh.py:
2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Fix wrong length parsing in WebSocket.
https://bugs.webkit.org/show_bug.cgi?id=32203
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- 7:44 PM Changeset in webkit [51828] by
-
- 6 edits in trunk
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Maciej Stachowiak.
Turn on (SVG) Filters for Qt.
https://bugs.webkit.org/show_bug.cgi?id=32224
- 6:54 PM Changeset in webkit [51827] by
-
- 8 edits in trunk
2009-12-07 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Chromium: theme scrollbars to match GTK theme.
Add functions to RenderThemeChromiumLinux to change the scrollbar
color.
Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
http://bugs.webkit.org/show_bug.cgi?id=32048
Patch from Markus Gutschke <markus@chromium.org>.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::saturateAndBrighten): (WebCore::outlineColor): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
- rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::thumbInactiveColor): (WebCore::RenderThemeChromiumLinux::thumbActiveColor): (WebCore::RenderThemeChromiumLinux::trackColor):
2009-12-07 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Chromium: theme scrollbars to match GTK theme.
Add API to set the colors.
Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
http://bugs.webkit.org/show_bug.cgi?id=32048
Patch from Markus Gutschke <markus@chromium.org>.
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setScrollbarColors):
- src/WebViewImpl.h:
- 6:50 PM Changeset in webkit [51826] by
-
- 2 edits in trunk/BugsSite
2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395
Attempt to go r51748 again using --directory option of git-apply.
- PrettyPatch/PrettyPatch.rb:
- 6:44 PM Changeset in webkit [51825] by
-
- 10 edits in trunk
WebCore
Reviewed by Xan Lopez.
[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
https://bugs.webkit.org/show_bug.cgi?id=32247
Allow creating a ResourceResponse from a SoupMessage.
Covered by API test.
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
Reviewed by Xan Lopez.
[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
https://bugs.webkit.org/show_bug.cgi?id=32247
Provide a way for applications to respect Content-Disposition, by
fetching the WebKitNetworkResponse from the frame during
mime-type-policy-decision-requested.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download content when Content-Disposition is attachment.
- tests/testmimehandling.c: (server_callback): (mime_type_policy_decision_requested_cb):
- tests/testwebframe.c: (test_webkit_web_frame_response): (main):
- webkit/webkitprivate.cpp: (WebKit::core):
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_network_response):
- webkit/webkitwebframe.h:
- 6:40 PM Changeset in webkit [51824] by
-
- 2 edits in trunk/WebKitTools
2009-12-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Make run-webkit-websocketserver log to stderr rather than to a file.
https://bugs.webkit.org/show_bug.cgi?id=32234
- Scripts/run-webkit-websocketserver:
- 6:29 PM Changeset in webkit [51823] by
-
- 3 edits3 deletes in trunk
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Reverting problematic patch, causing errors.
Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
Reopen bug https://bugs.webkit.org/show_bug.cgi?id=29912.
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- 6:26 PM Changeset in webkit [51822] by
-
- 6 edits9 adds in trunk
2009-12-07 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for HTMLInputElement::stepUp() and stepDown().
https://bugs.webkit.org/show_bug.cgi?id=27451
- fast/forms/input-step-number-expected.txt: Added.
- fast/forms/input-step-number.html: Added.
- fast/forms/input-step-range-expected.txt: Added.
- fast/forms/input-step-range.html: Added.
- fast/forms/input-step-unsupported-expected.txt: Added.
- fast/forms/input-step-unsupported.html: Added.
- fast/forms/script-tests/input-step-number.js: Added.
- fast/forms/script-tests/input-step-range.js: Added.
- fast/forms/script-tests/input-step-unsupported.js: Added.
2009-12-07 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for HTMLInputElement::stepUp() and stepDown() for
type=number and type=range.
https://bugs.webkit.org/show_bug.cgi?id=27451
Our implementation of stepUp() and stepDown() rounds the resultant
value to conform to the step value.
Change the number-string conversion method for RenderSlider to be
consistent with type=number.
Tests: fast/forms/input-step-number.html
fast/forms/input-step-range.html
fast/forms/input-step-unsupported.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER. (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER. (WebCore::HTMLInputElement::stepBase): (WebCore::HTMLInputElement::stepMismatch): Use stepBase(). (WebCore::HTMLInputElement::applyStepForNumberOrRange): (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown): (WebCore::HTMLInputElement::formStringFromDouble):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown):
- html/HTMLInputElement.idl: Add stepUp() and stepDown().
- rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming. (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble(). (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().
- 6:21 PM Changeset in webkit [51821] by
-
- 2 edits in trunk/WebCore
Not reviewed: Chromium build fix try 2 (dumb error).
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::getString):
- 5:55 PM Changeset in webkit [51820] by
-
- 3 edits in trunk/WebCore
Not reviewed: Chromium build fix.
Fix Chromium build break caused by an added dependency from
ScriptControllerBase to JSDOMWindowShell, and an API change in
ScriptValue.
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::getString):
- 5:31 PM Changeset in webkit [51819] by
-
- 3 edits2 adds in trunk
WebCore: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233
Reviewed by Darin Adler.
Fixes problem in re-creating the correct hierarchy under the new block.
Added extensive testing to cover all the cases.
Test: editing/execCommand/indent-with-style2.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233
Reviewed by Darin Adler.
- editing/execCommand/indent-with-style2-expected.txt: Added.
- editing/execCommand/indent-with-style2.html: Added.
- 5:22 PM Changeset in webkit [51818] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-07 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Darin Fisher.
A patch for Chromium to restrict the scope of the Gmail focus fix,
where we set the Selection to 0,0 for content-editable fields and
also make sure we set the selection end-state for find to select the
text found (when not focusing a link we found).
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=32248
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus):
- 5:15 PM Changeset in webkit [51817] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Add some missing files that depend on SVG Filters support, only mac supports it for now.
Still one more crash affecting the win slaves, unrelated to the filters patch though.
- 5:03 PM Changeset in webkit [51816] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix for checkouts with a space in the path
- win/tools/scripts/auto-version.sh: Quote the output file's directory
before passing it to mkdir.
- 4:59 PM Changeset in webkit [51815] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Skip a timeouter flakey test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-plugins.html added.
- 4:51 PM Changeset in webkit [51814] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Skip yet another test, what a journey...
- 4:50 PM Changeset in webkit [51813] by
-
- 15 edits in trunk
Remove ENABLE_SHARED_SCRIPT flags
https://bugs.webkit.org/show_bug.cgi?id=32245
This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
Rubber-stamped by Darin Adler.
- configure.ac:
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pro:
WebKit/chromium:
- features.gypi:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitTools:
- Scripts/build-webkit:
- 4:40 PM Changeset in webkit [51812] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Adjust one layout test to the results of the Leopard Intel slave.
- 4:37 PM Changeset in webkit [51811] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Turn Qt slave green again, after landing filters.
- 4:10 PM Changeset in webkit [51810] by
-
- 2 edits in trunk/WebCore
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.
- bindings/scripts/CodeGeneratorJS.pm:
- 4:04 PM Changeset in webkit [51809] by
-
- 5 edits in trunk/LayoutTests
Corrected expected results
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png:
- 4:02 PM Changeset in webkit [51808] by
-
- 1 edit1 move in trunk/LayoutTests
Rubber-stamped by Simon Fraser.
Re-enabled this test now that <rdar://problem/7450481> is fixed.
- fast/repaint/block-selection-gap-in-composited-layer.html: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.disabled.
- fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Removed.
- 4:00 PM Changeset in webkit [51807] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Add new exported symbols to finally fix the build.
- 3:53 PM Changeset in webkit [51806] by
-
- 2 edits in trunk/WebKit/win
- WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
Reviewed by NOBODY (Windows build fix part III).
- 3:47 PM Changeset in webkit [51805] by
-
- 2 edits in trunk/WebKit/win
- WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
Reviewed by NOBODY (Windows build fix part II).
- 3:30 PM Changeset in webkit [51804] by
-
- 11 edits in trunk
2009-12-07 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
This caused one compositing test make DumpRenderTree think that all subsequent tests
were compositing too.
Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
notification informs the client that a WebHTMLView entered compositing mode (or an already-
compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
compositing subviews were removed, since this is tricky to get right.
Change -[WebView _isUsingAcceleratedCompositing] to manually walk the frames, and
return YES if any document view is composited.
- WebKit.exp:
- WebView/WebHTMLView.mm: (-[WebHTMLView close]): (-[WebHTMLView viewDidMoveToSuperview]): (-[WebHTMLView attachRootLayer:]): (-[WebHTMLView detachRootLayer]):
- WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _postsAcceleratedCompositingNotifications]): (-[WebView _setPostsAcceleratedCompositingNotifications:]): (-[WebView _isUsingAcceleratedCompositing]):
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 3:26 PM Changeset in webkit [51803] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (Windows build fixage part I).
- 3:15 PM Changeset in webkit [51802] by
-
- 2 edits in trunk/WebCore
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.
- svg/svgtags.in:
- 3:14 PM Changeset in webkit [51801] by
-
- 42 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=32184
Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.
Reviewed by Oliver Hunt.
- API/JSCallbackObjectFunctions.h:
(JSC::::toString):
- API/JSValueRef.cpp:
(JSValueIsStrictEqual):
- JavaScriptCore.exp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEqualityOp):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
- profiler/Profiler.cpp:
(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
- profiler/Profiler.h:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
(JSC::InternalFunction::calculatedDisplayName):
- runtime/InternalFunction.h:
- runtime/JSCell.cpp:
(JSC::JSCell::getString):
- runtime/JSCell.h:
(JSC::JSValue::getString):
- runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::defineOwnProperty):
- runtime/JSObject.h:
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::get):
- runtime/JSString.cpp:
(JSC::JSString::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::Rope::createOrNull):
(JSC::JSString::Rope::operator new):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
(JSC::JSValue::toString):
- runtime/JSValue.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
- runtime/Operations.cpp:
(JSC::JSValue::strictEqualSlowCase):
- runtime/Operations.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
(JSC::concatenateStrings):
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::equalTo):
- runtime/PropertyDescriptor.h:
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
WebCore:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::setShadow):
- bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::getString):
- bindings/js/ScriptValue.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializingTreeWalker::convertIfTerminal):
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- page/Console.cpp:
(WebCore::Console::addMessage):
WebKit/mac:
- WebView/WebView.mm:
(aeDescFromJSValue):
- 3:03 PM Changeset in webkit [51800] by
-
- 249 edits2 adds in trunk
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Holger Hans Peter Freyther.
Turn on (SVG) Filters support, by default.
https://bugs.webkit.org/show_bug.cgi?id=32224
Only enable filters on mac for now, skipped all affected tests on the other platforms.
Will enable them one after another, to minimize breakage.
- Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
- 2:50 PM Changeset in webkit [51799] by
-
- 5 edits in trunk
2009-12-07 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Some changes to ValidityState-typeMismatch-url.html.
https://bugs.webkit.org/show_bug.cgi?id=29913
- Add more test cases Username, IPv6 address, mailto:, file:, tel:, fragment, and IDN.
- Handle difference between KURL and KURLGoogle
- fast/forms/ValidityState-typeMismatch-url-expected.txt:
- fast/forms/script-tests/ValidityState-typeMismatch-url.js:
2009-12-07 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that KURL rejects a host name which has an IPv4 address
inside an IPv6 form like [::127.0.0.1].
https://bugs.webkit.org/show_bug.cgi?id=29913
- platform/KURL.cpp: (WebCore::characterClassTable): Add IPv6Char to '.'.
- 2:43 PM Changeset in webkit [51798] by
-
- 5 edits in trunk/LayoutTests
2009-12-07 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
http/tests/cache/subresource-failover-to-network.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=32038
Rewrite test to avoid dumpResourceLoadCallbacks, which do not
interleave predictably with the output of dumpFrameLoadCallbacks.
Other things besides resource loading can delay onload.
The newly written test uses a cookie to determine if the test has
passed.
Unskip this test for platform/win.
- http/tests/cache/resources/subresource-failover-to-network.cgi:
- http/tests/cache/subresource-failover-to-network-expected.txt:
- http/tests/cache/subresource-failover-to-network.html:
- platform/win/Skipped:
- 2:35 PM Changeset in webkit [51797] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32244
Test sending and receiving small WebSocket messages of different lengths
- websocket/tests/frame-lengths-expected.txt: Added.
- websocket/tests/frame-lengths.html: Added.
- 2:27 PM Changeset in webkit [51796] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem
Reviewed by Sam Weinig.
The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
BackForwardList. That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot
outlive its Document and Documents will always clear the back-pointer in their ::detach() method.
(WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion
about the original items m_cachedPage object (which is irrelevant to the copy).
- 1:54 PM Changeset in webkit [51795] by
-
- 1 edit in trunk/WebCore/ChangeLog
Not reviewed - fix typo in ChangeLog.
- 1:52 PM Changeset in webkit [51794] by
-
- 2 edits in trunk/WebKitTools
2009-12-07 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Chromium buildbots are not red when they fail
https://bugs.webkit.org/show_bug.cgi?id=32235
- Scripts/build-webkit:
- 1:51 PM Changeset in webkit [51793] by
-
- 8 edits9 deletes in trunk/WebCore
Remove partial SharedScript implementation.
https://bugs.webkit.org/show_bug.cgi?id=32237
The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.
Reviewed by Daring Adler.
- DerivedSources.make:
- SharedScript/SharedScriptContext.cpp: Removed.
- SharedScript/SharedScriptContext.h: Removed.
- SharedScript/SharedScriptContext.idl: Removed.
- SharedScript/SharedScriptController.h: Removed.
- SharedScript/WebKitSharedScript.cpp: Removed.
- SharedScript/WebKitSharedScript.h: Removed.
- SharedScript/WebKitSharedScript.idl: Removed.
- SharedScript/WebKitSharedScriptRepository.cpp: Removed.
- SharedScript/WebKitSharedScriptRepository.h: Removed.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::detach):
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- dom/ScriptExecutionContext.h:
- 1:25 PM Changeset in webkit [51792] by
-
- 2 edits in trunk/WebKitTools
2009-12-07 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Typo in chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=32238
- Scripts/webkitdirs.pm:
- 1:06 PM Changeset in webkit [51791] by
-
- 2 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add two tests generating new results to gtks collection of tests doing so.
- platform/gtk/Skipped:
- 1:05 PM Changeset in webkit [51790] by
-
- 2 edits in trunk/WebCore
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=32226
Random crashes in WebSocket tests on Leopard Debug builbot
- platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close): Make sure the object still exists when setting m_state.
- 12:32 PM Changeset in webkit [51789] by
-
- 3 edits3 adds in trunk
2009-12-07 Shiki Okasaka <shiki@google.com>
Reviewed by Dirk Schulze.
Avoid zero division during SVGPaintServerPattern::setup()
https://bugs.webkit.org/show_bug.cgi?id=29912
Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
if the tile of a pattern was bigger than the pattern and the pattern
size was < 0.5, and if the attribute overflow was set to visible.
Test: svg/custom/small-pattern.html
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
2009-12-07 Dirk Schulze <krit@webkit.org>
Reviewed by Adam Barth.
If the tile of a pattern is bigger than the pattern and the
pattern size is < 0.5, the SVGPaintServer produced a division
by zero. This also only happens, if the attribute overflow is
set to visible.
This is a test with a pattern size of 0.1 and a tile size of 1.
- svg/custom/script-tests/small-pattern.js: Added.
- svg/custom/small-pattern-expected.txt: Added.
- svg/custom/small-pattern.html: Added.
- 12:17 PM Changeset in webkit [51788] by
-
- 6 edits in trunk
2009-12-07 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
fixes to build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=32179
- DEPS:
- WebKit.gyp:
- gyp_webkit:
2009-12-07 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
fixes to build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=32179
- Scripts/webkitdirs.pm:
- 11:46 AM Changeset in webkit [51787] by
-
- 2 edits in trunk/WebKitTools
2009-12-07 Eric Seidel <eric@webkit.org>
No review, just adding two recently approved committers.
- Scripts/modules/committers.py:
- 11:36 AM Changeset in webkit [51786] by
-
- 2 edits in trunk/WebKitTools
- Scripts/run-webkit-websocketserver: Added property svn:executable.
- 11:36 AM Changeset in webkit [51785] by
-
- 3 edits2 adds in trunk
2009-12-07 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31889
Fixed bug in handling of zero-argument constructor call.
Test: fast/canvas/webgl/bug-31889.html
- fast/canvas/webgl/bug-31889-expected.txt: Added.
- fast/canvas/webgl/bug-31889.html: Added.
2009-12-07 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31889
Fixed bug in handling of zero-argument constructor call.
Test: fast/canvas/webgl/bug-31889.html
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 11:26 AM Changeset in webkit [51784] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Landing files I forgot to add to my working copy before
committing r51734.
- 11:22 AM Changeset in webkit [51783] by
-
- 4 edits in trunk
2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
Fix build errors when javascript-debugger is disabled on GTK
- GNUmakefile.am:
2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
Fix build errors when javascript-debugger is disabled on GTK
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):
- 11:09 AM Changeset in webkit [51782] by
-
- 2 edits in trunk/LayoutTests
Don't skip websocket/tests/url-with-credential.html, it's one of earlier tests that is
to blame.
- platform/mac/Skipped:
- 11:06 AM Changeset in webkit [51781] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Steve Falkenburg.
Add one more fast/js test to the Skipped list - also due to:
https://bugs.webkit.org/show_bug.cgi?id=32228.
- platform/win/Skipped:
- 10:51 AM Changeset in webkit [51780] by
-
- 3 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Cleaning up Skipped files in order to make more bots green, as I plan to land changes, that affect all bots (svg filters support).
Remove non-existant animations/3d directory in qt&win Skipped lists.
Skip one more test on windows (see bug #32228, already in radar, just guessing - not yet sure if it's a random crash issue though)
Skip 19 (!) tests on the Qt slave, failing since a longer time. Qt developers: Please investigate.
- platform/qt/Skipped: Also remove some duplicates I spotted.
- platform/win/Skipped:
- 10:34 AM Changeset in webkit [51779] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Add run-webkit-websocketserver
- Scripts/run-webkit-websocketserver: Added.
- 10:23 AM Changeset in webkit [51778] by
-
- 2 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Disable two flaky SnowLeopard tests, filed bug and notified author.
Tests "plugins/document-open.html" and "plugins/mouse-events.html" are flaky on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=32229
- platform/mac-snowleopard/Skipped:
- 10:23 AM Changeset in webkit [51777] by
-
- 4 edits in tags/Safari-532.5.1
Merge r51773.
- 10:22 AM Changeset in webkit [51776] by
-
- 7 edits8 adds in trunk
WebCore: Fixed <rdar://problem/7437820> Weird selection artifacts
Reviewed by Darin Adler.
Tests: fast/repaint/block-selection-gap-stale-cache-2.html
fast/repaint/block-selection-gap-stale-cache.html
Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
time, cache them in each RenderLayer at paint time. This prevents the cache from getting
stale due to layout changes and overflow scrolling.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
(WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
bounds to include the given rect.
(WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
selection gaps bounds.
(WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
selection gaps bounds.
- rendering/RenderLayer.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
of the view-level cache.
(WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().
- rendering/RenderView.h:
LayoutTests: Tests for <rdar://problem/7437820> Weird selection artifacts
Reviewed by Darin Adler.
- fast/repaint/block-selection-gap-stale-cache-2.html: Added.
- fast/repaint/block-selection-gap-stale-cache.html: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png: Added.
- platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt: Added.
- 10:09 AM Changeset in webkit [51775] by
-
- 2 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
REGRESSION: fast/js/excessive-comma-usage.html and fast/js/math-transforms.html fail on win
https://bugs.webkit.org/show_bug.cgi?id=32228
Adding above two tests to the Skipped list on win, attempting to turn the win slave green again.
- platform/win/Skipped:
- 10:06 AM Changeset in webkit [51774] by
-
- 1 copy in tags/Safari-532.5.1
New tag.
- 10:03 AM Changeset in webkit [51773] by
-
- 4 edits in trunk
Build fix. Be flexible about which version of ICU is used on Windows.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Add optional xcopy commands to copy ICU 4.2.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
- 9:43 AM Changeset in webkit [51772] by
-
- 2 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Remove non-existant files in gtk/Skipped list, and exclude a printing test, without results. Should turn the gtk slave green again.
- platform/gtk/Skipped:
- 9:21 AM Changeset in webkit [51771] by
-
- 2 edits in trunk/LayoutTests
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to get all mac build slaves to green again. Disable crashing test, and notify the author of it to fix it.
New test "websocket/tests/url-with-credential.html" crashes in debug builds
https://bugs.webkit.org/show_bug.cgi?id=32226
- platform/mac/Skipped:
- 9:10 AM Changeset in webkit [51770] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed. Add missing layout test result.
- 9:07 AM Changeset in webkit [51769] by
-
- 2 edits in trunk/WebCore
2009-12-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
Fixed whitelist comment and removed useless (tags, sdp) mimetypes
from it. Also, GStreamer doesn't handle directly SMIL.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
- 7:38 AM Changeset in webkit [51768] by
-
- 4 edits in trunk
2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):
2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.
- tests/testatk.c (test_webkit_atk_get_text_at_offset_textarea): (test_webkit_atk_get_text_at_offset_text_input): (main):
- 7:31 AM Changeset in webkit [51767] by
-
- 2 edits in trunk/WebKit/qt
2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Remove the calls to qWait() of the autotest of QWebView
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
- 7:02 AM Changeset in webkit [51766] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-07 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Add declarations for DevTools message dispatching on IO thread
(see http://codereview.chromium.org/460018)
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- 6:52 AM Changeset in webkit [51765] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
op_loop_if_less JIT codegen is broken for 64-bit
https://bugs.webkit.org/show_bug.cgi?id=32221
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_false): Fix codegen in this version - test was backwards.
- 6:35 AM Changeset in webkit [51764] by
-
- 5 edits6 adds in trunk
Reviewed by Xan Lopez.
Build the new API test.
[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183
- GNUmakefile.am:
WebCore
Reviewed by Xan Lopez.
Turn the MediaPlayer supported types blacklist into a whitelist
[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183
Covered by API test.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
WebKit/gtk
Reviewed by Xan Lopez.
New test to make sure we do not regress this feature anymore. All
test files were created by me.
[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183
- tests/resources/test.html: Added.
- tests/resources/test.ogg: Added.
- tests/resources/test.pdf: Added.
- tests/resources/test.txt: Added.
- tests/testmimehandling.c: Added. (server_callback): (idle_quit_loop_cb): (mime_type_policy_decision_requested_cb): (test_mime_type): (test_mime_pdf): (test_mime_html): (test_mime_text): (test_mime_ogg): (main):
- 6:34 AM Changeset in webkit [51763] by
-
- 2 edits in trunk/WebKit/qt
2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor tst_qwebframe to remove qWait() and use
the function waitForSignal() from util.h
- tests/qwebframe/tst_qwebframe.cpp:
- 6:27 AM Changeset in webkit [51762] by
-
- 3 edits3 adds in trunk
2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies
- platform/gtk/accessibility/title-and-alt.html: Added.
- platform/gtk/accessibility/title-and-alt-expected.txt: Added.
2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies
Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.
This is a modified version of the original fix submitted by Mario Sanchez Prada,
adjusted so that it doesn't impact other platforms.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
- 6:13 AM Changeset in webkit [51761] by
-
- 3 edits in trunk/WebKit/qt
2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor the test of QGraphicsWebView:
-make waitForSignal() available to all the tests.
-remove QTest::qWait()
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnViewlessWebPages):
- tests/util.h: (waitForSignal):
- 5:50 AM Changeset in webkit [51760] by
-
- 5 edits in trunk
Object.create fails if properties on the descriptor are getters
https://bugs.webkit.org/show_bug.cgi?id=32219
Reviewed by Maciej Stachowiak.
Correctly initialise the PropertySlots with the descriptor object.
- 5:44 AM Changeset in webkit [51759] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Plugins: Force windowless mode when there is no native window handle
Reviewed by Simon Hausmann.
Inject wmode=opaque while instantiating the plugin for the case when the
webpage is not backed by a native window handle.
- 5:29 AM Changeset in webkit [51758] by
-
- 4 edits in trunk/WebCore
[Qt] Fix support for generic font families
Reviewed by Simon Hausmann.
By not propagating the resolved font family in FontCacheQt and
only concidering the font description we ended up passing the
generic font families to Qt directly. Since most systems don't
have a mapping for these font families we ended up using the
default font in most cases.
- platform/graphics/qt/FontCacheQt.cpp:
- platform/graphics/qt/FontPlatformData.h:
- platform/graphics/qt/FontPlatformDataQt.cpp:
- 5:06 AM Changeset in webkit [51757] by
-
- 9 edits1 add in trunk
Object.getOwnPropertyDescriptor() allows cross-frame access
https://bugs.webkit.org/show_bug.cgi?id=32119
Reviewed by Maciej Stachowiak.
Make all implementations of getOwnPropertyDescriptor that have
cross domain restrictions simply fail immediately on cross domain
access, rather than trying to mimic the behaviour of normal
property access.
Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
- 4:36 AM Changeset in webkit [51756] by
-
- 9 edits3 adds in trunk/WebCore
Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
https://bugs.webkit.org/show_bug.cgi?id=32157
Reviewed by Adam Barth.
Build fix only, no new tests.
- WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
- bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
- bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
- bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
- bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
- bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
- bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
- bridge/jni/jsc: Added.
- bridge/jni/jsc/jni_utility_private.cpp: Added.
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
- bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
- platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
- 4:04 AM Changeset in webkit [51755] by
-
- 2 edits in trunk/WebKitTools
2009-12-07 Dirk Schulze <krit@webkit.org>
Not reviewed, adding myself to the reviewers list.
- Scripts/modules/committers.py:
- 12:51 AM QtWebKitMediaElementSupport edited by
- (diff)
- 12:50 AM QtWebKitMediaElementSupport edited by
- (diff)
- 12:46 AM QtWebKitMediaElementSupport created by
- 12:46 AM QtWebKit edited by
- (diff)
Dec 6, 2009:
- 11:53 PM Changeset in webkit [51754] by
-
- 2 edits in trunk/WebKitTools
2009-12-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add an API for uploading results files to StatusBot
https://bugs.webkit.org/show_bug.cgi?id=32210
Add Content-Type: plain/text which was forgotten
from the previous commit when I landed with land-patches
instead of land-diff.
- QueueStatusServer/queue_status.py:
- 11:45 PM Changeset in webkit [51753] by
-
- 2 edits in trunk/WebKitTools
2009-12-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add an API for uploading results files to StatusBot
https://bugs.webkit.org/show_bug.cgi?id=32210
- Scripts/modules/statusbot.py:
- 11:42 PM Changeset in webkit [51752] by
-
- 3 edits in trunk/WebKitTools
2009-12-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Status Server needs a way to handle uploaded results
https://bugs.webkit.org/show_bug.cgi?id=32209
- QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
- QueueStatusServer/update_status.html: Add file upload.
- 11:06 PM Changeset in webkit [51751] by
-
- 2 edits in trunk/BugsSite
2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Revert r51748.
Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395
- PrettyPatch/PrettyPatch.rb:
- 10:42 PM Changeset in webkit [51750] by
-
- 2 edits in trunk/WebKitTools
2009-12-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] BuildAttachment should not check the builders
https://bugs.webkit.org/show_bug.cgi?id=32207
This is code that got copied here by accident when the class was created.
- Scripts/modules/commands/download.py:
- 10:42 PM Changeset in webkit [51749] by
-
- 2 edits in trunk/WebKitTools
2009-12-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make LandingSequence.update aware of ports
https://bugs.webkit.org/show_bug.cgi?id=32208
This is required to make build work on the Chromium port because
Chromium has a custom update-webkit.
- Scripts/modules/landingsequence.py:
- 10:42 PM Changeset in webkit [51748] by
-
- 2 edits in trunk/BugsSite
2009-12-06 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
Reviewed by David Kilzer.
Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395
Show images in git patches using git-apply.
- PrettyPatch/PrettyPatch.rb:
- 9:20 PM Changeset in webkit [51747] by
-
- 4 edits in trunk/WebKitTools
2009-12-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add early warning system commands to bugzilla-tool.
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitport.py:
- 9:11 PM Changeset in webkit [51746] by
-
- 2 edits1 add in trunk/WebKitTools
2009-12-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
https://bugs.webkit.org/show_bug.cgi?id=32205
- Scripts/modules/commands/early_warning_system.py: Added.
- Scripts/modules/commands/queues.py:
- 7:27 PM Changeset in webkit [51745] by
-
- 2 edits in trunk/WebKitTools
REGRESSION (r51728): update-webkit fails when the current directory is
not inside a Subversion working copy
https://bugs.webkit.org/show_bug.cgi?id=32204
Reviewed by Adele Peterson.
- Scripts/update-webkit: Invoke isSVN() in the correct working
directory.
- 6:45 PM Changeset in webkit [51744] by
-
- 5 edits in trunk/LayoutTests
2009-12-06 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Improve portability and readability of table-percent-height* tests.
https://bugs.webkit.org/show_bug.cgi?id=31858
The purpose of these tests is to confirm that an element with
height:N% inside a table cell has non-zero height. We don't need
to check concrete pixel sizes of form controls.
This updates the tests so that they check heights are non-zero and
75% heights are same as corresponding 100% heights or actually 75%.
- fast/replaced/table-percent-height-expected.txt:
- fast/replaced/table-percent-height-text-controls-expected.txt:
- fast/replaced/table-percent-height-text-controls.html:
- fast/replaced/table-percent-height.html:
- 6:19 PM Changeset in webkit [51743] by
-
- 6 edits8 adds in trunk/LayoutTests
2009-12-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Add tests for cross-origin WebSocket usage
https://bugs.webkit.org/show_bug.cgi?id=32055
- websocket/tests/cross-origin-expected.txt: Added.
- websocket/tests/cross-origin.html: Added.
- websocket/tests/fixed-origin_wsh.py: Added.
- websocket/tests/handshake-fail-by-cross-origin-expected.txt: Added.
- websocket/tests/handshake-fail-by-cross-origin.html: Added.
- websocket/tests/origin-test_wsh.py: Added.
- websocket/tests/script-tests/cross-origin.js: Added.
- websocket/tests/script-tests/frame-length-longer-than-buffer.js:
- websocket/tests/script-tests/frame-length-skip.js:
- websocket/tests/script-tests/handshake-error.js:
- websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Added.
- websocket/tests/script-tests/simple.js:
- websocket/tests/simple-expected.txt:
- 5:09 PM Changeset in webkit [51742] by
-
- 2 edits in trunk/WebKitTools
2009-12-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Rename AbstractTryQueue to AbstractReviewQueue
https://bugs.webkit.org/show_bug.cgi?id=32202
- Scripts/modules/commands/queues.py:
- 9:40 AM Changeset in webkit [51741] by
-
- 3 edits in trunk/WebKit/haiku
2009-12-06 Maxime Simon <Maxime Simon>
Reviewed by Adam Barth.
Build fix. Add in FrameLoaderClientHaiku the declaration of three functions introduced in r51644.
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidPushStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidReplaceStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidPopStateWithinPage):
- WebCoreSupport/FrameLoaderClientHaiku.h:
- 3:37 AM Changeset in webkit [51740] by
-
- 2 edits in trunk/WebCore
texImage2D pixel junk for transparency
https://bugs.webkit.org/show_bug.cgi?id=32188
Reviewed by Maciej Stachowiak
Use kCGBlendModeCopy when drawing an image to the intermediate context
used to create a GL texture.
No test as we don't currently have any mechanism to retrieve pixel data
from the webgl context.
- 2:30 AM Changeset in webkit [51739] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
Actually tested 64-bit *and* 32-bit build this time.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_false):
- 2:09 AM Changeset in webkit [51738] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
Really really fix 64-bit build for prior patch (actually tested this time).
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_false):
(JSC::JIT::emitSlow_op_loop_if_false):
- 1:57 AM Changeset in webkit [51737] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
Really fix 64-bit build for prior patch.
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jless):
- 1:51 AM Changeset in webkit [51736] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
Fix 64-bit build for prior patch.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_if_less):
- 1:42 AM Changeset in webkit [51735] by
-
- 17 edits in trunk
2009-12-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
conway benchmark spends half it's time in op_less (jump fusion fails)
https://bugs.webkit.org/show_bug.cgi?id=32190
<1% speedup on SunSpider and V8
2x speedup on "conway" benchmark
Two optimizations:
1) Improve codegen for logical operators &&, and ! in a condition context
When generating code for combinations of &&, and !, in a condition context (i.e. in an if statement or loop condition), we
used to produce a value, and then separately jump based on its
truthiness. Now we pass the false and true targets in, and let the
logical operators generate jumps directly. This helps in four
ways:
a) Individual clauses of a short-circuit logical operator can now
jump directly to the then or else clause of an if statement (or to
the top or exit of a loop) instead of jumping to a jump.
b) It used to be that jump fusion with the condition of the first
clause of a logical operator was inhibited, because the register
was ref'd to be used later, in the actual condition jump; this no
longer happens since a jump straight to the final target is
generated directly.
c) It used to be that jump fusion with the condition of the second
clause of a logical operator was inhibited, because there was a
jump target right after the second clause and before the actual
condition jump. But now it's no longer necessary for the first
clause to jump there so jump fusion is not blocked.
d) We avoid generating excess mov statements in some cases.
As a concrete example this source:
if (!((x < q && y < q) (t < q && z < q))) { ...
}
Used to generate this bytecode:
[ 34] less r1, r-15, r-19
[ 38] jfalse r1, 7(->45)
[ 41] less r1, r-16, r-19
[ 45] jtrue r1, 14(->59)
[ 48] less r1, r-17, r-19
[ 52] jfalse r1, 7(->59)
[ 55] less r1, r-18, r-19
[ 59] jtrue r1, 17(->76)
And now generates this bytecode (also taking advantage of the second optimization below):
[ 34] jnless r-15, r-19, 8(->42)
[ 38] jless r-16, r-19, 26(->64)
[ 42] jnless r-17, r-19, 8(->50)
[ 46] jless r-18, r-19, 18(->64)
Note the jump fusion and the fact that there's less jump
indirection - three of the four jumps go straight to the target
clause instead of indirecting through another jump.
2) Implement jless opcode to take advantage of the above, since we'll now often generate
a less followed by a jtrue where fusion is not forbidden.
- parser/Nodes.h: (JSC::ExpressionNode::hasConditionContextCodegen): Helper function to determine whether a node supports special conditional codegen. Return false as this is the default. (JSC::ExpressionNode::emitBytecodeInConditionContext): Assert not reached - only really defined for nodes that do have conditional codegen. (JSC::UnaryOpNode::expr): Add const version. (JSC::LogicalNotNode::hasConditionContextCodegen): Returne true only if subexpression supports it. (JSC::LogicalOpNode::hasConditionContextCodegen): Return true.
- parser/Nodes.cpp: (JSC::LogicalNotNode::emitBytecodeInConditionContext): Implemented - just swap the true and false targets for the child node. (JSC::LogicalOpNode::emitBytecodeInConditionContext): Implemented - handle jumps directly, improving codegen quality. Also handles further nested conditional codegen. (JSC::ConditionalNode::emitBytecode): Use condition context codegen when available. (JSC::IfNode::emitBytecode): ditto (JSC::IfElseNode::emitBytecode): ditto (JSC::DoWhileNode::emitBytecode): ditto (JSC::WhileNode::emitBytecode): ditto (JSC::ForNode::emitBytecode): ditto
- bytecode/Opcode.h:
- Added loop_if_false opcode - needed now that falsey jumps can be backwards.
- Added jless opcode to take advantage of new fusion opportunities.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Handle above.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue): Add peephole for less + jtrue ==> jless. (JSC::BytecodeGenerator::emitJumpIfFalse): Add handling of backwrds falsey jumps.
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeInConditionContext): Wrapper to handle tracking of overly deep expressions etc.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Implement the two new opcodes (loop_if_false, jless).
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Implement JIT support for the two new opcodes. (JSC::JIT::privateCompileSlowCases): ditto
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): ditto (JSC::JIT::emitBinaryDoubleOp): ditto
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_loop_if_less): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto
- jit/JITStubs.cpp:
- jit/JITStubs.h: (JSC::):
2009-12-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
conway benchmark spends half it's time in op_less (jump fusion fails)
https://bugs.webkit.org/show_bug.cgi?id=32190
- fast/js/codegen-loops-logical-nodes-expected.txt:
- fast/js/script-tests/codegen-loops-logical-nodes.js: Update to test some newly sensitive cases of codegen that were not already covered.
Dec 5, 2009:
- 5:50 PM Changeset in webkit [51734] by
-
- 11 edits in trunk
WebCore
2009-12-03 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
Advertize audio/ogg correctly and refactored mime-type cache
building.
[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990
Test: media/media-can-play-ogg.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
LayoutTests
2009-12-05 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
New test for video.canPlayType and ogg containers.
[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990
- media/media-can-play-ogg-expected.txt: Added.
- media/media-can-play-ogg.html: Added.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-win/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 4:30 PM Changeset in webkit [51733] by
-
- 7 edits1 add in trunk/WebKitSite
2009-12-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Refactored web site documentation so that advice to add
WebKitTools/Scripts to your shell path does not appear
on multiple pages.
- building/build.html:
- building/checkout.html:
- building/run.html:
- coding/coding-style.html:
- coding/contributing.html:
- coding/scripts.html: Added.
- quality/testing.html:
- 3:59 PM Changeset in webkit [51732] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32175
REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed. (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
- 3:44 PM Changeset in webkit [51731] by
-
- 1 edit1 move in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
Disabled a test because it puts the WebView into compositing mode,
which remains in effect for all subsequent repaint tests, causing them
to fail because DumpRenderTree always forces a full repaint when
generating the image of a WebView that is in compositing mode.
- fast/repaint/block-selection-gap-in-composited-layer.html: Removed.
- fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.
- 1:55 PM Changeset in webkit [51730] by
-
- 3 edits in trunk/WebKitTools
2009-12-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement ChromiumPort
https://bugs.webkit.org/show_bug.cgi?id=32182
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 1:54 PM Changeset in webkit [51729] by
-
- 6 edits in trunk/WebKitTools
2009-12-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move update-webkit into BuildSteps
https://bugs.webkit.org/show_bug.cgi?id=32181
We need to move update-webkit out of SCM.py because SCM isn't supposed to know
that WebKit exists. The proper place for the knowledge of the existence of
update-webkit is in WebKitPort because some ports have specialized update
scripts (analogous to build-webkit).
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/scm.py:
- Scripts/modules/webkitport.py:
- 1:54 PM Changeset in webkit [51728] by
-
- 2 edits in trunk/WebKitTools
2009-12-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
update-webkit should call git svn rebase and resolve-ChangeLogs -f
https://bugs.webkit.org/show_bug.cgi?id=27162
Teach update-webkit about Git. I didn't add the call to
resolve-ChangeLogs -f because sometimes that script goes bananas. We
can iterate from here, however.
- Scripts/update-webkit:
- 9:50 AM Changeset in webkit [51727] by
-
- 3 edits2 adds in trunk
2009-12-05 Adam Langley <agl@google.com>
Reviewed by Adam Barth.
Check that a CSS format() argument is of a valid type.
https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582
- fast/css/url-format-non-string-expected.txt: Added
- fast/css/url-format-non-string.html: Added.
2009-12-05 Adam Langley <agl@google.com>
Reviewed by Adam Barth.
Check that a CSS format() argument is of a valid type.
https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582
Test: fast/css/url-format-non-string.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceSrc):
- 8:56 AM Changeset in webkit [51726] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Use a better URI for the unreachable test. localhost:80 is very
likely to be open.
- tests/testwebdatasource.c:
(load_finished_unreachable_cb):
(test_webkit_web_data_source_unreachable_uri):
- 7:35 AM Changeset in webkit [51725] by
-
- 2 edits in trunk
2009-12-05 Vincent Untz <vuntz@gnome.org>
Reviewed by Gustavo Noronha.
Fixes race for builds with introspection enabled, and parallel
make.
- GNUmakefile.am:
Dec 4, 2009:
- 5:21 PM Changeset in webkit [51724] by
-
- 3 edits3 adds in trunk
2009-12-04 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
JavaScript delete operator should return false for string properties
https://bugs.webkit.org/show_bug.cgi?id=32012
- runtime/StringObject.cpp: (JSC::StringObject::deleteProperty):
2009-12-04 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Add test for JavaScript string property deletion
https://bugs.webkit.org/show_bug.cgi?id=32012
- fast/js/script-tests/string-property-deletion.js: Added.
- fast/js/string-property-deletion-expected.txt: Added.
- fast/js/string-property-deletion.html: Added.
- 4:46 PM Changeset in webkit [51723] by
-
- 3 edits in trunk/WebKitSite
2009-12-04 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Eric Seidel.
Add reference to the GTK and QT build wiki pages
- building/tools.html:
- css/main.css:
- 4:39 PM Changeset in webkit [51722] by
-
- 2 edits in trunk/WebCore
2009-12-04 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium: make rounded borders heavier.
Skia draws its rounded corners differently from the other ports.
Whereas they have anti-aliased clipping regions, Skia only has 1-bit
regions. (Which is technically more correct, but somewhat unhelpful
for us.) Instead, with Skia we use a layer and collect all the
clipping paths in effect. When the state is popped, we paint
transparency outside the clipping paths and merge the layer down.
This appears to cause rounded borders to look a little thin, which is
addressed in this patch.
This is well covered by existing tests but will require new baselines
in the Chromium tree.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip):
- 4:31 PM Changeset in webkit [51721] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-04 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Add test for web socket send.
- websocket/tests/script-tests/send.js: Added. (endTest): (ws.onopen): (ws.onmessage.ws.onmessage): (ws.onmessage): (ws.onclose): (timeOutCallback):
- websocket/tests/send-expected.txt: Added.
- websocket/tests/send.html: Added.
- websocket/tests/send_wsh.py: Added.
- 4:24 PM Changeset in webkit [51720] by
-
- 3 edits3 adds in trunk/WebKit/chromium
2009-12-04 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32095
Implement WebRegularExpression, a WebKit API for accessing
WebCore::RegularExpression.
- WebKit.gyp:
- public/WebRegularExpression.h: Added.
- public/WebTextCaseSensitivity.h: Added. (WebKit::):
- src/AssertMatchingEnums.cpp:
- src/WebRegularExpression.cpp: Added. (WebKit::WebRegularExpression::WebRegularExpression): (WebKit::WebRegularExpression::~WebRegularExpression): (WebKit::WebRegularExpression::match):
- 3:56 PM Changeset in webkit [51719] by
-
- 4 edits in trunk/WebKit/chromium
[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part two: Remove deprecated APIs.
https://bugs.webkit.org/show_bug.cgi?id=31893
Reviewed by Darin Fisher.
- public/WebView.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- 3:18 PM Changeset in webkit [51718] by
-
- 3 edits2 adds in trunk
2009-12-04 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7441571> Hardware-backed layers are skipped when printing
When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
paint. This also causes 3D transforms to be flattened to 2D.
Test: printing/compositing-layer-printing.html
- page/FrameView.cpp: (WebCore::FrameView::paintContents):
- 3:13 PM Changeset in webkit [51717] by
-
- 2 edits in trunk/WebCore
Fix up some issues in my SVGListTraits change from yesterday.
Reviewed by Deth Bakin
- 2:10 PM Changeset in webkit [51716] by
-
- 2 edits in trunk/LayoutTests
Skip test that is failing because of new behaviour enforced by
libsoup. Bug reported.
- platform/gtk/Skipped:
- 2:00 PM Changeset in webkit [51715] by
-
- 5 edits in trunk/WebKitTools
Add some missing methods for showing and hiding the
Web Inspector.
Reviewed by Adam Treat.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::~WebPage):
(WebCore::WebPage::webInspector):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::hideWebInspector):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 1:54 PM Changeset in webkit [51714] by
-
- 2 edits in trunk/LayoutTests
Skip tests that require support for frame loader callbacks
reporting, and a new test.
- platform/gtk/Skipped:
- 1:45 PM BuildBot edited by
- (diff)
- 1:35 PM Changeset in webkit [51713] by
-
- 2 edits in trunk/WebKitTools
Unreviewed build fix.
[Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- 1:19 PM Changeset in webkit [51712] by
-
- 1 edit1 move in trunk/LayoutTests
2009-12-04 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha Silva.
Move the render result to svg/custom as a cross platform render result.
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
- svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
- 1:13 PM Changeset in webkit [51711] by
-
- 2 edits in trunk/WebCore
Not reviewed: chromium build fix.
Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
portAllowed() into KURL.h/KURL.cpp. Cloning code.
- platform/KURLGoogle.cpp:
(WebCore::isDefaultPortForProtocol):
(WebCore::portAllowed):
- 1:03 PM Changeset in webkit [51710] by
-
- 2 edits in trunk/WebCore
2009-12-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove suppress highlight when restoring selected node.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
- 1:01 PM Changeset in webkit [51709] by
-
- 6 edits in trunk
WebKitTools: Implement the setAllowUniversalAccessFromFileURLs method
for the Qt LayoutTestController.
Reviewed by Adam Treat.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests: Remove test that works after adding setAllowUniversalAccessFromFileURLs
to Qt's version of the LayoutTestController.
Reviewed by Adam Treat.
- platform/qt/Skipped:
- 12:50 PM BuildBot edited by
- (diff)
- 12:24 PM BuildBot edited by
- (diff)
- 12:19 PM Changeset in webkit [51708] by
-
- 5 edits4 adds in trunk
2009-12-04 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929
The focalPoint of a radial gradient is temporarly substracted by
the centralPoint, if the focalPoint is not in the radius of the
gradient. This is needed to calculate a new postion of the focalPoint
according to the specification. But the new focalPoint needs to be
moved by the centralPoint after this calculation, which is not the case
at the moment. This patch fixes this issue. It was also introduced a
deviation of maximal 0.2% for Cairo to get around the fixed point numbers
in Cairo.
W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
of the new focalPoint caused wrong results for the last three tests.
Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929
In SVG a focalPoint must be inside the radius of a radial gradient.
It this isn't the case, we have to move the focalPoint into the radius.
This checks the correct behavior of WebKit on false values for fx, fy.
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
- svg/custom/radial-gradient-with-outstanding-focalPoint.svg: Added.
- 12:16 PM Changeset in webkit [51707] by
-
- 2 edits in trunk/WebCore
2009-12-04 Anton Muhin <antonm@chromium.org>
Reviewed by Dmitry Titov.
Do not use WebCore::String::String(const UChar*, int length) to convert
short v8 strings.
Plus added string traits.
https://bugs.webkit.org/show_bug.cgi?id=31415
- bindings/v8/V8Binding.cpp: (WebCore::): (WebCore::v8StringToWebCoreString):
- 12:04 PM Changeset in webkit [51706] by
-
- 12 edits2 adds in trunk
REGRESSION: AX: buttons now extremely repetitive
https://bugs.webkit.org/show_bug.cgi?id=32164
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isButton):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(isAttributeSupportedCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isAttributeSupported):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isAttributeSupported):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isAttributeSupported):
LayoutTests:
- platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:
- platform/mac/accessibility/button-shouldnot-have-axvalue-expected.txt: Added.
- platform/mac/accessibility/button-shouldnot-have-axvalue.html: Added.
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- 12:01 PM Changeset in webkit [51705] by
-
- 2 edits in trunk/WebCore
2009-12-04 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Darin Adler.
Check whether the right side of a string append is non-empty
https://bugs.webkit.org/show_bug.cgi?id=32151
Especially beneficial for CachedScript::script() method
which usually appends an empty string returned by flush()
to its m_script member. m_script is often hundreds of kbytes
which is duplated without reason.
- platform/text/String.cpp: (WebCore::String::append):
- 11:51 AM BuildBot edited by
- (diff)
- 11:49 AM Changeset in webkit [51704] by
-
- 3 edits2 adds in trunk
Mail.app crashes when indenting table pasted from Numbers.app.
<rdar://problem/7209507>
https://bugs.webkit.org/show_bug.cgi?id=32166
Reviewed by John Sullivan.
WebCore:
Test: LayoutTests/editing/execCommand/indent-partial-table.html
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
after the selection has not been moved.
LayoutTests:
- editing/execCommand/indent-partial-table-expected.txt: Added.
- editing/execCommand/indent-partial-table.html: Added.
- 11:16 AM Changeset in webkit [51703] by
-
- 9 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32085
WebSocket should block the same ports that are blocked for resource loading
Test: websocket/tests/url-parsing.html
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::localURLSchemes):
- page/SecurityOrigin.h: Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin is not even in WebCore/platform directory).
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host): (WebCore::HTMLAnchorElement::setHost): (WebCore::HTMLAnchorElement::setPort): Updated for the new location of isDefaultPortForProtocol().
- platform/KURL.cpp: (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively, since the function deosn't require lower case input. (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin. (WebCore::portAllowed): Moved from ResourceHandle.
- platform/KURL.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the new location of portAllowed().
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR if trying to connect to a blocked port.
- 10:12 AM Changeset in webkit [51702] by
-
- 2 edits in trunk/WebKit/qt
2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Corrects QtLauncher style
- QtLauncher/main.cpp: (WebPage::acceptNavigationRequest): (MainWindow::MainWindow): (MainWindow::webPage): (MainWindow::webView): (MainWindow::changeLocation): (MainWindow::loadFinished): (MainWindow::showLinkHover): (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::print): (MainWindow::setEditable): (MainWindow::dumpHtml): (MainWindow::selectElements): (MainWindow::newWindow): (MainWindow::setupUI): (WebPage::createWindow): (WebPage::createPlugin): (main):
- 10:04 AM Changeset in webkit [51701] by
-
- 2 edits in trunk/WebKit/qt
2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher: add a menu to show or hide the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=32149
- QtLauncher/main.cpp: (WebInspector::WebInspector): (WebInspector::showEvent): (WebInspector::hideEvent): (MainWindow::MainWindow): (MainWindow::setupUI):
- 9:57 AM Changeset in webkit [51700] by
-
- 6 edits in trunk/LayoutTests
2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443
Update the test results for the new FontCache implementation.
- platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
- platform/qt/css1/font_properties/font_variant-expected.txt:
- platform/qt/css1/pseudo/firstline-expected.txt:
- platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
- 9:50 AM Changeset in webkit [51699] by
-
- 6 edits1 delete in trunk/WebCore
2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443
Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.
In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.
FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.
Existing tests cover the change.
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/qt/FontFallbackListQt.cpp: Removed. We now use the implementation from FontFallbackList.cpp
- platform/graphics/qt/FontPlatformData.h: Add hashing capabilities to be able to use the data with the FontCache. This was previously done in FontCacheQt.cpp (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
- 9:43 AM Changeset in webkit [51698] by
-
- 3 edits in trunk/WebKit/qt
2009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Antti Koivisto.
Split out the renderPrivate in two methods, one for working on
relative coordinates (relative to the viewport) and one for
working on absolute coordinates. The latter is more effecient
for implementing tiling, as you don't need translate the coords,
and because it avoid clipping to the viewport.
No behaviour changes, so no new tests.
- Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords): (QWebFramePrivate::renderRelativeCoords): (QWebFrame::render):
- Api/qwebframe_p.h:
- 9:14 AM Changeset in webkit [51697] by
-
- 2 edits in trunk/WebCore
Fix wrong assert that was only working through sheer luck.
https://bugs.webkit.org/show_bug.cgi?id=32162
Patch by Adam Treat <atreat@rim.com> on 2009-12-04
Reviewed by Dan Bernstein.
- platform/text/BidiContext.cpp:
(WebCore::BidiContext::create):
- 7:36 AM Changeset in webkit [51696] by
-
- 4 edits in trunk
[Qt] Allow removing 'qrc' as a local security origin scheme
Reviewed by Simon Hausmann.
WebCore:
- page/SecurityOrigin.cpp:
WebKit/qt:
- tests/qwebpage/tst_qwebpage.cpp:
- 7:36 AM Changeset in webkit [51695] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Clean up argument parsing in the QtLauncher
Reviewed by Simon Hausmann.
- QtLauncher/main.cpp:
- 5:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:56 AM Changeset in webkit [51694] by
-
- 2 edits in trunk/WebKit/qt
2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Prevent the inspector from closing its wrapping widget.
This is not necessary anymore since we now hide the embedded
close button.
https://bugs.webkit.org/show_bug.cgi?id=32149
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):
- 4:07 AM Changeset in webkit [51693] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=32109
Reviewed by Eric Seidel.
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
struct name - instantiated at: WebCore/'location'
struct CollectionCache - dom/Document.cpp:4029
- html/CollectionCache.h:
- 3:30 AM Changeset in webkit [51692] by
-
- 4 edits6 adds in trunk
2009-12-04 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111
- fast/dom/Geolocation/resources/permission-denied-already-clear-watch.js: Added. Tests clearing the watch from the error callback after a permission denied message when permissions have already been denied.
- fast/dom/Geolocation/permission-denied-already-clear-watch.html: Added. HTML wrapper for above test.
- fast/dom/Geolocation/permission-denied-already-clear-watch-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/timeout-clear-watch.js: Added. Tests clearing the watch from the error callback due to a timeout.
- fast/dom/Geolocation/timeout-clear-watch.html: Added. HTML wrapper for above test.
- fast/dom/Geolocation/timeout-clear-watch-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips new tests.
2009-12-04 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111
In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
fatal error was registered on this GeoNotifier or if this request has timed
out. If the request is a watch, and is cleared by a call to clearWatch in the
callback, the GeoNotifier object will be destroyed. We must therefore cache the
m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
Geolocation::requestTimedOut.
Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html
fast/dom/Geolocation/timeout-clear-watch.html
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
- 2:37 AM Changeset in webkit [51691] by
-
- 2 edits in trunk/LayoutTests
[Qt] Re-enable audio/video tests after updated buildbot's Qt
to Phonon supported one, and put 2 bad tests into skiplist.
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- 2:33 AM Changeset in webkit [51690] by
-
- 3 edits in trunk/WebCore
Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=
Reviewed by Eric Seidel.
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class TransformOperations - rendering/style/RenderStyle.h:1175
Noncopyable.h's include added to SharedTimer.h.
- platform/SharedTimer.h:
- platform/graphics/transforms/TransformOperations.h:
- 2:18 AM Changeset in webkit [51689] by
-
- 4 edits in trunk
2009-12-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846
Bump libsoup required version to 2.29.3 for DNS prefetching.
- configure.ac:
WebCore:
2009-12-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846
Enable DNS prefetching.
Based on a patch by José Millán.
- platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
- 12:56 AM Changeset in webkit [51688] by
-
- 3 edits in trunk/WebCore
Roll out r51687 because it breaks the Leopard builds.
- 12:38 AM Changeset in webkit [51687] by
-
- 3 edits in trunk/WebCore
2009-12-04 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class TransformOperations - rendering/style/RenderStyle.h:1175
- platform/SharedTimer.h:
- platform/graphics/transforms/TransformOperations.h:
- 12:25 AM Changeset in webkit [51686] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-04 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Fisher.
Add test to see if unicode messages can be sent over web socket.
- websocket/tests/script-tests/unicode.js: Added. (endTest): (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
- websocket/tests/unicode-expected.txt: Added.
- websocket/tests/unicode.html: Added.
- websocket/tests/unicode_wsh.py: Added.
- 12:15 AM Changeset in webkit [51685] by
-
- 5 edits in trunk/WebCore
2009-12-04 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for the svg directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
struct ResourceSet - svg/graphics/SVGResource.cpp:148
class SVGFontData - css/CSSFontFaceSource.cpp:156
class SVGDocumentExtensions - dom/Document.cpp:3962
class SVGViewSpec - svg/SVGSVGElement.cpp:191
- svg/SVGDocumentExtensions.h:
- svg/SVGFontData.h:
- svg/SVGViewSpec.h:
- svg/graphics/SVGResource.cpp:
Dec 3, 2009:
- 11:50 PM Changeset in webkit [51684] by
-
- 7 edits4 adds in trunk
WAI-ARIA: aria-activedescendant doesn't work as intended
https://bugs.webkit.org/show_bug.cgi?id=32100
Reviewed by Beth Dakin.
WebCore:
Fixes a number of issues regarding the "tree" role and aria-activedescendant.
- The indexes were being reported incorrectly by treeitems.
- aria-activedescendant changes were not being sent to the containing item.
- The tree's selected rows need to consult aria-activedescendant.
- Since a tree changes what it returns as its children (it returns its rows) the mac-specific array indexing methods need to correctly handle the tree case.
Tests: platform/mac/accessibility/aria-tree-activedescendant.html
platform/mac/accessibility/aria-tree-index-of-items.html
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/aria-tree-activedescendant-expected.txt: Added.
- platform/mac/accessibility/aria-tree-activedescendant.html: Added.
- platform/mac/accessibility/aria-tree-index-of-items-expected.txt: Added.
- platform/mac/accessibility/aria-tree-index-of-items.html: Added.
- 11:48 PM Changeset in webkit [51683] by
-
- 5 edits in trunk/WebCore
2009-12-03 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for the xml directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134
Inherits the following classes from FastAllocBase because these are instantiated by 'new':
class NodeTest - xml/XPathGrammar.y:258
class NodeSet - xml/XPathValue.cpp:52
struct EvaluationContext - xml/XPathExpressionNode.cpp:40
- xml/XMLHttpRequest.cpp:
- xml/XPathExpressionNode.h:
- xml/XPathNodeSet.h:
- xml/XPathStep.h:
- 11:42 PM Changeset in webkit [51682] by
-
- 3 edits in trunk/WebKitTools
2009-12-03 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
check-webkit-style should check for camelCase variable names
https://bugs.webkit.org/show_bug.cgi?id=32051
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 10:40 PM Changeset in webkit [51681] by
-
- 4 edits1 add in trunk/WebCore
New History changes do not compile for Chromium/V8
https://bugs.webkit.org/show_bug.cgi?id=32148
Reviewed by Adam Barth.
Existing tests suffice (just trying to get code to compile).
- WebCore.gypi:
Added V8HistoryCustom.cpp and other missing files.
- bindings/v8/custom/V8CustomBinding.h:
Added custom handlers for History.pushState()/replaceState().
- bindings/v8/custom/V8HistoryCustom.cpp: Added.
Added custom handlers for History.pushState()/replaceState().
- history/BackForwardListChromium.cpp:
(WebCore::BackForwardList::pushStateItem):
Stubbed out this routine for now - will implement in the future.
- 10:19 PM Changeset in webkit [51680] by
-
- 3 edits in trunk/WebCore
2009-12-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
OwnPtr<XBLBindingManager> Document::m_bindingManager;
https://bugs.webkit.org/show_bug.cgi?id=32147
The document actually owns the bindingManager. That's what the code
should say.
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h: (WebCore::Document::bindingManager):
- 9:55 PM Changeset in webkit [51679] by
-
- 3 edits in trunk/WebCore
2009-12-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
OwnPtr<Tokenizer> Document::m_tokenizer;
https://bugs.webkit.org/show_bug.cgi?id=32145
The document actually owns the tokenizer. That's what the code should say.
- dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose):
- dom/Document.h: (WebCore::Document::tokenizer):
- 9:54 PM Changeset in webkit [51678] by
-
- 3 edits in trunk/WebCore
2009-12-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
OwnPtr<RenderArena> Document::m_renderArena;
https://bugs.webkit.org/show_bug.cgi?id=32146
The document owns the renderArena. That's what the code should say.
- dom/Document.cpp: (WebCore::Document::Document): Also, removed a redundant initialization of the tokenizer that I missed in my previous patch. (WebCore::Document::~Document): (WebCore::Document::attach): (WebCore::Document::detach):
- dom/Document.h: (WebCore::Document::renderArena):
- 9:54 PM Changeset in webkit [51677] by
-
- 5 edits in trunk
Revert r51633
This reverts commit 4c9cc0b9a12d38654b9c687ffc1671c7307b397a.
- 9:33 PM QtWebKitBackportingFixes edited by
- (diff)
- 9:28 PM Changeset in webkit [51676] by
-
- 3 edits in trunk/WebCore
2009-12-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The code should say that Document owns DocLoader
https://bugs.webkit.org/show_bug.cgi?id=32143
It's the truth.
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h: (WebCore::Document::docLoader):
- 6:53 PM Changeset in webkit [51675] by
-
- 2 edits in trunk/JavaScriptCore
Try and fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a symbol that should be exported.
- 6:35 PM Changeset in webkit [51674] by
-
- 2 edits in trunk/JavaScriptCore
Try and fix the Mac build.
- JavaScriptCore.exp: Export a symbol that should be exported.
- 6:28 PM Changeset in webkit [51673] by
-
- 3 edits in trunk/LayoutTests
Fixing layout test bustage on platforms.
AX: VO just says "term" on many web sites
https://bugs.webkit.org/show_bug.cgi?id=32139
- platform/mac-leopard/accessibility/lists-expected.txt:
- platform/mac/accessibility/radio-button-group-members-expected.txt:
- 6:17 PM Changeset in webkit [51672] by
-
- 6 edits in trunk/JavaScriptCore
REGRESSION(4.0.3-48777): Crash in JSC::ExecState::propertyNames() (Debug-only?)
https://bugs.webkit.org/show_bug.cgi?id=32133
Reviewed by Gavin Barraclough.
Work around odd GCC-ism and correct the scopechain for use by
calls made while a cachedcall is active on the callstack.
- 6:15 PM Changeset in webkit [51671] by
-
- 9 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32136
Add a rope representation to JSString. Presently JSString always holds its data in UString form.
Instead, allow the result of a string concatenation to be represented in a tree form - with a
variable sized, reference-counted rope node retaining a set of UString::Reps (or other rope nopes).
Reviewed by Oliver "Brraaaaiiiinnnnnzzzzzzzz" Hunt.
Strings must still currently be resolved down to a flat UString representation before being used,
but by holding the string in a rope representation during construction we can avoid copying data
until we know the final size of the string.
~2% progression on SunSpider (~25% on date-format-xparb, ~20% on string-validate-input).
- JavaScriptCore.exp:
- Update exports.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Make use of new JSString::length() method to avoid prematurely resolving ropes.
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- Switch the string length trampoline to read the length directly from JSString::m_length, rather than from the JSString's UString::Rep's 'len' property.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Modify op_add such that addition of two strings, where either or both strings are already in rope representation, produces a rope as a result.
- runtime/JSString.cpp:
(JSC::JSString::Rope::~Rope):
(JSC::copyChars):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toBoolean):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::Fiber):
(JSC::JSString::Rope::Fiber::destroy):
(JSC::JSString::Rope::Fiber::isRope):
(JSC::JSString::Rope::Fiber::rope):
(JSC::JSString::Rope::Fiber::string):
(JSC::JSString::Rope::create):
(JSC::JSString::Rope::initializeFiber):
(JSC::JSString::Rope::ropeLength):
(JSC::JSString::Rope::stringLength):
(JSC::JSString::Rope::fibers):
(JSC::JSString::Rope::Rope):
(JSC::JSString::Rope::operator new):
(JSC::JSString::JSString):
(JSC::JSString::value):
(JSC::JSString::length):
(JSC::JSString::isRope):
(JSC::JSString::rope):
(JSC::JSString::string):
(JSC::JSString::canGetIndex):
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSubstring):
(JSC::JSString::getStringPropertySlot):
- Add rope form.
- runtime/Operations.h:
(JSC::jsAdd):
(JSC::concatenateStrings):
- Update string concatenation, and addition of ropes, to produce ropes.
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- Make use of new JSString::length() method to avoid prematurely resolving ropes.
- 6:06 PM Changeset in webkit [51670] by
-
- 13 edits2 adds in trunk
AX: VO just says "term" on many web sites
https://bugs.webkit.org/show_bug.cgi?id=32139
Reviewed by Eric Seidel.
WebCore:
Test: platform/mac/accessibility/definition-list-term.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper roleDescription]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getRoleDescriptionCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::roleDescription):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::roleDescription):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::roleDescription):
LayoutTests:
- platform/mac/accessibility/aria-grouping-roles-expected.txt:
- platform/mac/accessibility/aria-grouping-roles.html:
- platform/mac/accessibility/definition-list-term-expected.txt: Added.
- platform/mac/accessibility/definition-list-term.html: Added.
- platform/mac/accessibility/lists-expected.txt:
- 5:00 PM Changeset in webkit [51669] by
-
- 16 edits2 adds in trunk
Implement WAI-ARIA scrollbar role and related property aria-orientation
https://bugs.webkit.org/show_bug.cgi?id=32126
Reviewed by Beth Dakin.
WebCore:
Test: accessibility/aria-scrollbar-role.html
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isScrollbar):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::orientation):
(WebCore::AccessibilityRenderObject::canHaveChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getOrientationCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::orientation):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::orientation):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::orientation):
LayoutTests:
- accessibility/aria-scrollbar-role-expected.txt: Added.
- accessibility/aria-scrollbar-role.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 4:16 PM Changeset in webkit [51668] by
-
- 4 edits4 adds in trunk
Fixed <rdar://problem/7401617> Selection painting issue in hardware-
accelerated layers
which is another part of https://bugs.webkit.org/show_bug.cgi?id=23628
Fix selection painting to do container-relative repaints
Reviewed by Darin Adler.
Test: fast/repaint/block-selection-gap-in-composited-layer.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
gap rects in the coordinate space of the repaint container.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
FIXME.
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Map block selection gap rects from
the repaint container’s coordinate space to the view’s coordinate space
before adding them to the cached selection bounds.
(WebCore::RenderView::clearSelection): Changed to use
repaintRectangleInViewAndCompositedLayers() so that the selection rect
is invalidated in composited layers as well.
- 4:07 PM Changeset in webkit [51667] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32132
websocket/tests/simple.html fails on Windows
- websocket/tests/script-tests/simple.js:
- websocket/tests/simple-expected.txt: Make the test weaker - readyState could already grow by the time a posted event gets dispatched.
- platform/win/Skipped: Un-skip the test.
- 3:37 PM Changeset in webkit [51666] by
-
- 2 edits in trunk/LayoutTests
Make shorthand-transitions.html less flaky.
The test currently allows for timing related differences by using a tolerance, but the tolerance
is inconsistent in the test, even for values read at the same time (some values are allowed a 100ms
difference, others are only allowed 50ms). This change makes all values have a 100ms tolerance.
(open question: is 100ms enough? I've looked through a bunch of logs of failures and it seems to be,
so this should definitely help reduce but this may not entirely eliminate flakiness).
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32134
- transitions/shorthand-transitions.html:
- 3:24 PM Changeset in webkit [51665] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-03 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Eric Seidel.
[Qt] Add expected files for new tests we pass.
Compared to the Mac expected png files.
- platform/qt/fast/css/namespaces/namespaces-escapes-expected.txt: Added.
- platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.txt: Added.
- 2:17 PM Changeset in webkit [51664] by
-
- 2 edits in trunk/WebKitTools
2009-12-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Minor correction to r51663.
- DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH):
GetEnvironmentVariable -> GetEnvironmentVariableW.
- 2:10 PM Changeset in webkit [51663] by
-
- 2 edits in trunk/WebKitTools
2009-12-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
https://bugs.webkit.org/show_bug.cgi?id=30256
Add the QuickTime dll directory to the PATH environment variable so
inialization can succeed.
- DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH): (initialize):
- 2:08 PM Changeset in webkit [51662] by
-
- 2 edits in trunk/WebKitTools
2009-12-03 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
- 2:01 PM Changeset in webkit [51661] by
-
- 8 edits in trunk/WebKitTools
2009-12-03 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Update pywebsocket to 0.4.3
This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
Stack trace is logged now in INFO level.
https://bugs.webkit.org/show_bug.cgi?id=32097
- pywebsocket/mod_pywebsocket/dispatch.py:
- pywebsocket/mod_pywebsocket/msgutil.py:
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/mod_pywebsocket/util.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_dispatch.py:
- pywebsocket/test/test_util.py:
- 1:54 PM Changeset in webkit [51660] by
-
- 9 edits1 add in trunk
2009-12-03 Jonathan Dixon <joth@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
https://bugs.webkit.org/show_bug.cgi?id=32066
Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
as it is intended as a development and testing aid, not a user control. To completely remove geolocation
from a given port, the compile time ENABLE_GEOLOCATION should still be used.
Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
make that the default just yet.
- WebCore.gypi:
- page/Settings.cpp: (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value (WebCore::Settings::setGeolocationEnabled): Setter for m_geolocationEnabled flag
- page/Settings.h: (WebCore::Settings::geolocationEnabled): Add m_geolocationEnabled flag
- platform/chromium/GeolocationServiceChromium.cpp: Added. (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium) (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true
2009-12-03 Jonathan Dixon <joth@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
https://bugs.webkit.org/show_bug.cgi?id=32066
Add the plumbing to map WebSettings through to WebCore::Settings
- features.gypi:
- public/WebSettings.h: Add setGeolocationEnabled API to interface
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setGeolocationEnabled): Calls through to WebCore::Settings::setGeolocationEnabled
- src/WebSettingsImpl.h: Add setGeolocationEnabled interface function
- 1:43 PM Changeset in webkit [51659] by
-
- 2 edits in trunk/WebCore
SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
<rdar://problem/7198592>
https://bugs.webkit.org/show_bug.cgi?id=32129
Reviewed by John Sullivan.
Fixed the way the next paragraph is calculated.
I've added a repro case in Safari and attached it to the Bugzilla bug.
- editing/Editor.cpp:
(WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
next paragraph in the loop.
- 1:37 PM Changeset in webkit [51658] by
-
- 2 edits in trunk/WebKit/qt
2009-12-03 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Eric Seidel.
Fix compilation when SVG is disabled.
- Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):
- 1:27 PM Changeset in webkit [51657] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Alexey Proskuryakov.
Skip failing WebSocket test on Windows.
- platform/win/Skipped:
- 1:25 PM Changeset in webkit [51656] by
-
- 4 edits in trunk/WebKitTools
Fix JSClassRef leak.
Reviewed by Gavin Barraclough.
- DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::makeWindowObject):
- DumpRenderTree/GCController.cpp:
(GCController::makeWindowObject):
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
- 1:19 PM Changeset in webkit [51655] by
-
- 3 edits in trunk/LayoutTests
Rubberstamped by Oliver Hunt.
Fix layout tests by removing the full outputting of the Date object and just outputting the milliseconds since the epoch.
- fast/loader/stateobjects/pushstate-object-types-expected.txt:
- fast/loader/stateobjects/pushstate-object-types.html:
- 1:06 PM Changeset in webkit [51654] by
-
- 1 edit1 copy2 adds in trunk/LayoutTests
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32130
Add a test for sending non-trivial amount of data over WebSocket
- websocket/tests/echo_wsh.py: Copied from WebKitTools/pywebsocket/example/echo_wsh.py.
- websocket/tests/simple-stress-expected.txt: Added.
- websocket/tests/simple-stress.html: Added.
- 12:59 PM Changeset in webkit [51653] by
-
- 7 edits in trunk/LayoutTests
Rubberstamped by Sam Weinig.
Fix my absolute URL snafu by outputting only the last path component for these URLs,
which is all that is relevant.
- fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
- 12:38 PM Changeset in webkit [51652] by
-
- 2 edits in trunk/WebCore
Build fix
- 11:51 AM Changeset in webkit [51651] by
-
- 2 edits in trunk/WebCore
Build fix
- 11:39 AM Changeset in webkit [51650] by
-
- 2 edits in trunk/WebCore
No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.
Long live our auto-generated overlords that I didn't know about...
- WebCore.base.exp:
- 11:34 AM Changeset in webkit [51649] by
-
- 6 edits in trunk
REGRESSION (r51627): 3 SVG tests are failing
https://bugs.webkit.org/show_bug.cgi?id=32117
Reviewed by Dan Bernstein.
Null checking Items in the SVGList is insufficient as items may
be floats, etc so add SVGListTraits::isNull and add appropriate
specializations.
Test: svg/dom/svglist-exception-on-out-bounds-error.html
- 11:32 AM Changeset in webkit [51648] by
-
- 2 edits in trunk/WebCore
No review - release build fix.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::documentDetached):
- 11:27 AM Changeset in webkit [51647] by
-
- 2 edits in trunk/WebCore
No review - release build fix.
- loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
- 11:25 AM Changeset in webkit [51646] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force Interfaces rebuild and fix Windows build.
- 11:18 AM Changeset in webkit [51645] by
-
- 12 edits2 adds in trunk
WebCore: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
https://bugs.webkit.org/show_bug.cgi?id=32079
Reviewed by Adele Peterson.
The fix consists in preventing Undos and Redos to be applied to elements that
are no longer editable. We do not attempt to remove the commands from the queue.
It is a relatively simple fix that comes with a little extra overhead for the apply
and unapply methods where we are now performing the editability check.
Test: editing/undo/undo-indent-noneditable.html
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/JoinTextNodesCommand.cpp:
(WebCore::JoinTextNodesCommand::doApply):
(WebCore::JoinTextNodesCommand::doUnapply):
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply):
(WebCore::SplitTextNodeCommand::doUnapply):
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
(WebCore::WrapContentsInDummySpanCommand::doReapply):
LayoutTests: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
https://bugs.webkit.org/show_bug.cgi?id=32079
Reviewed by Adele Peterson.
Added test to verify that undo has no effect when an element is
no longer editable.
- editing/undo/undo-indent-noneditable-expected.txt: Added.
- editing/undo/undo-indent-noneditable.html: Added.
- 11:04 AM Changeset in webkit [51644] by
-
- 67 edits29 adds in trunk
<rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
Reviewed by Sam Weinig.
WebCore:
Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/pushstate-then-replacestate.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
fast/loader/stateobjects/replacestate-then-pushstate.html
http/tests/loading/state-object-security-exception.html
Derived sources and project file changes:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am
- WebCore.pro
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add the new PopStateEvent:
- dom/PopStateEvent.cpp: Added.
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::initPopStateEvent):
- dom/PopStateEvent.h: Added.
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::isPopStateEvent):
(WebCore::PopStateEvent::state):
- dom/PopStateEvent.idl: Added.
- bindings/js/JSPopStateEventCustom.cpp: Added.
(WebCore::JSPopStateEvent::initPopStateEvent):
(WebCore::JSPopStateEvent::state):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- dom/Event.cpp:
(WebCore::Event::isPopStateEvent):
- dom/Event.h:
- dom/EventNames.h:
Add the "onpopstate" attribute:
- html/HTMLAttributeNames.in:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.idl:
- page/DOMWindow.h:
- page/DOMWindow.idl:
Add pushState and replaceState management to the loader and history machinery:
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining
both the same-document fragment scroll case with the new same-document state object activation case.
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
- loader/HistoryController.h:
- history/BackForwardList.cpp:
(WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
(WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward
list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
meant to remain.
(WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then
insert the new item.
(WebCore::BackForwardList::removeItem):
- history/BackForwardList.h:
- page/History.cpp:
(WebCore::History::urlForState):
(WebCore::History::stateObjectAdded):
- page/History.h:
- page/History.idl:
Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::setDocument):
(WebCore::HistoryItem::documentDetached):
- history/HistoryItem.h:
(WebCore::HistoryItem::stateObject):
(WebCore::HistoryItem::document):
- dom/Document.cpp:
(WebCore::Document::detach): Notify all back/forward history items owned by this Document that it
is going away.
(WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
(WebCore::Document::unregisterHistoryItem): Ditto.
- dom/Document.h:
Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
URL changes as the result of pushState(), replaceState(), or a popstate navigation:
- dom/Document.cpp:
(WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set
the pending state object.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):
- loader/DocumentLoader.h:
- loader/FrameLoaderClient.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):
Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::navigateWithinDocument):
(WebCore::FrameLoader::navigateToDifferentDocument):
(WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- page/Page.cpp:
(WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.
WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidPopStateWithinPage):
- src/FrameLoaderClientImpl.h:
WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebFrameLoadDelegatePrivate.h:
- WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]):
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
- Interfaces/IWebFrameLoadDelegatePrivate2.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidPopStateWithinPage):
- WebKitSupport/FrameLoaderClientWx.h:
WebKitTools:
Keep DRT-win building...
- DumpRenderTree/win/FrameLoadDelegate.h:
(FrameLoadDelegate::didPushStateWithinPageForFrame):
(FrameLoadDelegate::didReplaceStateWithinPageForFrame):
(FrameLoadDelegate::didPopStateWithinPageForFrame):
LayoutTests:
Update expected results of old tests:
- fast/dom/Window/window-appendages-cleared-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- http/tests/security/cross-frame-access-enumeration-expected.txt:
New tests:
- fast/loader/stateobjects: Added.
- fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt: Added.
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt: Added.
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Added.
- fast/loader/stateobjects/document-destroyed-navigate-back.html: Added.
- fast/loader/stateobjects/popstate-after-load-complete-addeventlistener-expected.txt: Added.
- fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html: Added.
- fast/loader/stateobjects/popstate-after-load-complete-body-attribute-expected.txt: Added.
- fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html: Added.
- fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute-expected.txt: Added.
- fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html: Added.
- fast/loader/stateobjects/popstate-after-load-complete-window-attribute-expected.txt: Added.
- fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html: Added.
- fast/loader/stateobjects/pushstate-object-types-expected.txt: Added.
- fast/loader/stateobjects/pushstate-object-types.html: Added.
- fast/loader/stateobjects/pushstate-then-replacestate-expected.txt: Added.
- fast/loader/stateobjects/pushstate-then-replacestate.html: Added.
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt: Added.
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html: Added.
- fast/loader/stateobjects/replacestate-then-pushstate-expected.txt: Added.
- fast/loader/stateobjects/replacestate-then-pushstate.html: Added.
- fast/loader/stateobjects/resources: Added.
- fast/loader/stateobjects/resources/navigate-back.html: Added.
- http/tests/loading/state-object-security-exception-expected.txt: Added.
- http/tests/loading/state-object-security-exception.html: Added.
- 10:53 AM Changeset in webkit [51643] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Xan Lopez.
Platform-specific result for test. GIO identifies the file as
application/javascript, as opposed to other platforms identifying
it as application/x-javascript.
- platform/gtk/inspector/timeline-network-resource-expected.txt: Added.
- 10:04 AM Changeset in webkit [51642] by
-
- 3 edits in trunk/WebCore
2009-12-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
r51621 changed JS bindings only, broke v8's.
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
- bindings/v8/ScriptFunctionCall.h:
- 9:16 AM Changeset in webkit [51641] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Oliver Hunt.
Re-baseline required after r51522.
- platform/gtk/editing/deleting/5390681-2-expected.txt:
- 9:09 AM Changeset in webkit [51640] by
-
- 2 edits in trunk/LayoutTests
Skipping new tests, and tests that require new DRT functionality.
- 9:06 AM Changeset in webkit [51639] by
-
- 2 edits in trunk/WebKitTools
Unreviewed build fix.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
[Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- 8:57 AM Changeset in webkit [51638] by
-
- 6 edits in trunk/WebCore
2009-12-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
https://bugs.webkit.org/show_bug.cgi?id=32094
Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
- bindings/v8/custom/V8CustomBinding.h:
- 8:43 AM Changeset in webkit [51637] by
-
- 4 edits in trunk
2009-12-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Chromium: Add support for settings containing ":"
- src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::loadSettings):
- 6:25 AM Changeset in webkit [51636] by
-
- 4 edits in trunk/WebCore
repaint events from outside the viewport aren't received
https://bugs.webkit.org/show_bug.cgi?id=32081
Reviewed by Simon Fraser.
When using a tiled backing store for painting, you need to receive
event from outside the viewport. Setting the viewport to the size
of the contents is not an option if you want to make use of WebCore's
infrastructure for drawing scrollbars etc.
A new property, paintsEntireContents, has been introduced for the
above use-case. It is settable, as tiling will be optional for Qt,
and for the not yet upstreamed EFL port, there will be two different
views, where only one of them are tiled.
No change in behavior, so no new tests added.
- page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
- platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setPaintsEntireContents):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(WebCore::ScrollView::paintsEntireContents):
- 6:24 AM Changeset in webkit [51635] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip layoutTestController.notifyDone() related tests which got revealed in r51634
until there is a fix for the issue.
https://bugs.webkit.org/show_bug.cgi?id=31626
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/Skipped:
- 6:20 AM Moving to Git edited by
- Add Gerrit2 link and the fact that cygwin is already a requirement on … (diff)
- 6:06 AM Changeset in webkit [51634] by
-
- 5 edits in trunk
WebKitTools: [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
Prevent DRT from showing the main view if these childs get deleted.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::closeRemainingWindows):
(WebCore::DumpRenderTree::createWindow):
(WebCore::DumpRenderTree::windowCount):
- DumpRenderTree/qt/DumpRenderTree.h:
LayoutTests: [Qt] Re-enable previously skipped tests.
https://bugs.webkit.org/show_bug.cgi?id=31591
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/Skipped:
- 5:52 AM Changeset in webkit [51633] by
-
- 5 edits in trunk
Reviewed by Eric Seidel.
Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
https://bugs.webkit.org/show_bug.cgi?id=31802
No test since this is already covered by existing pixel tests.
- platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
- platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations
of Core Text functions that are public on 10.6 but SPI on 10.5.
- 5:15 AM Changeset in webkit [51632] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().
- platform/qt/Skipped:
- inspector/settings-set-get.html added.
- 4:46 AM Changeset in webkit [51631] by
-
- 35 edits2 adds in trunk
2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Simplify the settings support in inspector controller.
Test: inspector/settings-set-get.html
- WebCore.Inspector.exp:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setting): (WebCore::InspectorController::setSetting): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::setAttachedWindowHeight): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showWindow): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
- inspector/InspectorController.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setting): (WebCore::InspectorFrontendHost::setSetting):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): (WebCore::EmptyInspectorClient::storeSetting):
WebKit/chromium
- src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings):
- src/InspectorClientImpl.h:
WebKit/cf
- WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::populateSetting): (WebInspectorClient::storeSetting):
WebKit/gtk
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
- WebCoreSupport/InspectorClientGtk.h:
WebKit/haiku
- WebCoreSupport/InspectorClientHaiku.cpp: (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting):
- WebCoreSupport/InspectorClientHaiku.h:
WebKit/mac
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):
WebKit/qt
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting): (WebCore::variantToSetting): (WebCore::settingToVariant):
- WebCoreSupport/InspectorClientQt.h:
WebKit/win
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::showWindowWithoutNotifications):
- WebCoreSupport/WebInspectorClient.h:
WebKit/wx
- WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): (WebCore::InspectorClientWx::storeSetting):
- WebKitSupport/InspectorClientWx.h:
- 4:31 AM Changeset in webkit [51630] by
-
- 6 edits in trunk
[Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
https://bugs.webkit.org/show_bug.cgi?id=31915
Reviewed by Brady Eidson.
WebCore:
No change in functionality so no new tests required.
- history/HistoryItem.cpp:
(WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
(WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
(WebCore::HistoryItem::setURLString): ditto.
(WebCore::HistoryItem::setOriginalURLString): ditto.
(WebCore::HistoryItem::setReferrer): ditto.
(WebCore::HistoryItem::setTitle): ditto.
(WebCore::HistoryItem::setTarget): ditto.
(WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
(WebCore::HistoryItem::clearDocumentState): ditto.
(WebCore::HistoryItem::setIsTargetItem): ditto.
(WebCore::HistoryItem::addChildItem): ditto.
(WebCore::HistoryItem::setFormInfoFromRequest): ditto.
- history/HistoryItem.h: Update signature of notifyHistoryItemChanged.
WebKit/mac:
- History/WebHistoryItem.mm:
(WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch.
- History/WebHistoryItemInternal.h: ditto.
- 4:18 AM Changeset in webkit [51629] by
-
- 25 edits in trunk
[Android] The FrameLoaderClient is unaware of BackForwardList changes.
https://bugs.webkit.org/show_bug.cgi?id=31914
Reviewed by Brady Eidson.
WebCore:
This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
- history/BackForwardList.cpp:
(WebCore::BackForwardList::addItem): Execute the callback.
(WebCore::BackForwardList::goBack): ditto.
(WebCore::BackForwardList::goForward): ditto.
(WebCore::BackForwardList::goToItem): ditto.
(WebCore::BackForwardList::setCapacity): dito.
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
- loader/FrameLoaderClient.h:
WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.
- src/FrameLoaderClientImpl.h:
WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/haiku:
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.
- WebCoreSupport/FrameLoaderClientHaiku.h:
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.
- WebKitSupport/FrameLoaderClientWx.h:
- 3:52 AM Changeset in webkit [51628] by
-
- 2 edits3 adds in trunk/WebCore
[Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
https://bugs.webkit.org/show_bug.cgi?id=31913
Reviewed by Brady Eidson.
Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.
No new tests required as this is Android specific code.
- history/HistoryItem.h: Add Android specific member data to HistoryItem.
- history/android: Added.
- history/android/AndroidWebHistoryBridge.h: Added.
- history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.
(WebCore::HistoryItem::bridge): Added.
(WebCore::HistoryItem::setBridge): Added.
- 1:22 AM Changeset in webkit [51627] by
-
- 8 edits2 adds in trunk
NULL ptr in SVGPathSegList::getPathSegAtLength()
https://bugs.webkit.org/show_bug.cgi?id=30313
Reviewed by Maciej Stachowiak.
Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
Add null checks to SVGList's content manipulation functions to prevent
null values from entering the list in the first place.
Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html
Dec 2, 2009:
- 11:27 PM Changeset in webkit [51626] by
-
- 4 edits2 adds8 deletes in trunk/LayoutTests
2009-12-02 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Rewrite two tests with dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=32014
- fast/block/positioning/complex-percentage-height-expected.txt: Added.
- fast/block/positioning/complex-percentage-height.html:
- fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
- fast/lists/item-not-in-list-line-wrapping.html:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed.
- platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed.
- platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed.
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed.
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
- platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
- 10:46 PM Changeset in webkit [51625] by
-
- 1 edit2 adds in trunk/JavaScriptCore
Add files missed in prior patch.
Reviewed by Gavin Barraclough.
- 10:25 PM Changeset in webkit [51624] by
-
- 9 edits in trunk/JavaScriptCore
Add zombies to JSC
https://bugs.webkit.org/show_bug.cgi?id=32103
Reviewed by Gavin Barraclough.
Add a compile time flag to make the JSC collector replace "unreachable"
objects with zombie objects. The zombie object is a JSCell subclass that
ASSERTs on any attempt to use the JSCell methods. In addition there are
a number of additional assertions in bottleneck code to catch zombie usage
as quickly as possible.
Grrr. Argh. Brains.
- 10:14 PM Changeset in webkit [51623] by
-
- 9 edits2 adds in trunk
2009-12-02 Yusuke Sato <yusukes@chromium.org>
Reviewed by Eric Seidel.
Sanitize web fonts using the OTS library
https://bugs.webkit.org/show_bug.cgi?id=31106
Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
and attempts to validate and sanitize them. We hope this reduces the attack surface
of the system font libraries.
- WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
- WebCore.gypi: Added new files below.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font. (WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.cpp: Ditto. (WebCore::createFontCustomPlatformData):
- platform/graphics/opentype/OpenTypeSanitizer.cpp: Added. (WebCore::OpenTypeSanitizer::sanitize):
- platform/graphics/opentype/OpenTypeSanitizer.h: Added. (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):
2009-12-02 Yusuke Sato <yusukes@chromium.org>
Reviewed by Eric Seidel.
Sanitize web fonts using the OTS library
https://bugs.webkit.org/show_bug.cgi?id=31106
- DEPS: Added dependency to the OpenType sanitizer library.
- features.gypi: Added ENABLE_OPENTYPE_SANITIZER=1.
- 9:31 PM Changeset in webkit [51622] by
-
- 5 edits1 add in trunk/WebKitTools
2009-12-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(51595): commit-queue is throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=32083
- Scripts/modules/commands/queues.py:
- Don't use default value of [] as it ends up getting shared.
- Make log_progress accept arrays of ints as well as strings.
- Return an exit code from execute()
- Scripts/modules/commands/queues_unittest.py: Added.
- Test to make sure log_progress will accept ints.
- Test to make sure run_bugzilla_tool will accept ints.
- Scripts/modules/workqueue.py:
- Print the stack trace on unexpected exceptions for easier debugging.
- Scripts/run-webkit-unittests:
- Add queues_unittest.
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/workqueue.py:
- Scripts/run-webkit-unittests:
- 9:20 PM Changeset in webkit [51621] by
-
- 5 edits in trunk/WebCore
Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
https://bugs.webkit.org/show_bug.cgi?id=32098
Reviewed by Sam Weinig.
Fix is simply to make the ScriptFunctionCall stack allocated as nature intended
Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
that an explicit String cast would not be necessary.
To prevent something like this happening again in future i've added private
operator new implementations to ScriptFunctionCall making this type of mistake
produce errors when compiling.
Test case: Inspector tests now pass with GC on every alloc enabled.
- 9:10 PM Changeset in webkit [51620] by
-
- 2 edits in trunk/WebKit/mac
Fix a mistake in the previous change
Reviewed by Mark Rowe.
- WebView/WebView.mm:
(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Make sure to include the image types’ view and representation classes
even when plug-ins are not allowed.
- 9:08 PM Changeset in webkit [51619] by
-
- 3 edits in trunk/WebKitTools
2009-12-02 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style is too noisy about namespace indenting issues.
https://bugs.webkit.org/show_bug.cgi?id=32096
- Scripts/modules/cpp_style.py: Added a _FileState object to be able to track file level information. In this case, it simply tracks whether the error has already been given, so that it isn't done again.
- Scripts/modules/cpp_style_unittest.py: Modified test cases to pass in the _FileState object and fix a test that expected to see the namespace error twice (now it only occurs once). No new tests because existing tests cover the change in functionality.
- 4:38 PM Changeset in webkit [51618] by
-
- 3 edits1 add in trunk/WebKitTools
Reviewed by Eric Seidel.
[wx] Get DumpRenderTree building after waf switch.
https://bugs.webkit.org/show_bug.cgi?id=32041
- 4:22 PM Changeset in webkit [51617] by
-
- 8 edits in trunk/WebKit/mac
Fixed <rdar://problem/7254127> WebKit can load plug-ins even when
plug-ins are disabled
Reviewed by Anders Carlsson.
Ensure that the shared WebPluginDatabase is not instantiated if no
WebViews are used that have plug-ins enabled.
- DefaultDelegates/WebDefaultPolicyDelegate.m:
(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
Call -[WebView _canShowMIMEType:] on the WebView instead of calling the
class method.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canShowMIMEType): Ditto.
(WebFrameLoaderClient::transitionToCommittedForNewPage): Call
-[WebFrameView _viewClassForMIMEType:] on the WebView instead of calling
the class method.
(WebFrameLoaderClient::objectContentType): Ditto.
- WebView/WebDataSource.mm:
(+[WebDataSource _representationClassForMIMEType:allowingPlugins:]):
Added the allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebDataSource _makeRepresentation]): Pass an allowPlugins value
based on the WebView’s preferences.
- WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]): Call
-[WebFrameView _viewClassForMIMEType:] instead of calling the class
method.
(+[WebFrameView _viewClassForMIMEType:allowingPlugins:]): Added the
allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebFrameView _viewClassForMIMEType:]): Added. Passes an allowPlugins
value based on the WebView’s preferences.
- WebView/WebFrameViewInternal.h:
- WebView/WebView.mm:
(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Added the allowPlugins parameter. If false, skip the instantiation of
the shared WebPluginDatabase.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Pass an
allowPlugins value based on the WebView’s preferences.
(+[WebView _canShowMIMEType:allowingPlugins:]): Passes allowPlugins to
+_viewClass:andRepresentationClass:forMIMEType:allowingPlugins:.
(+[WebView canShowMIMEType:]): Changed to pass YES to
+_canShowMIMEType:allowingPlugins:.
(-[WebView _canShowMIMEType:]): Added. Passes an allowPlugins value
based on the WebView’s preferences.
(-[WebView _pluginForMIMEType:]): Return nil if plug-ins are disabled.
(-[WebView _pluginForExtension:]): Ditto.
(-[WebView _isMIMETypeRegisteredAsPlugin:]): Return NO if plug-ins are
disabled.
- WebView/WebViewInternal.h:
- 3:39 PM Changeset in webkit [51616] by
-
- 2 edits in trunk/WebKit/mac
Fixes a crash when scrolling a frame that goes away mid-scroll.
<rdar://problem/7400263>
Reviewed by John Sullivan.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.
- 3:25 PM Changeset in webkit [51615] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32089
Test that WebSocket.readyState is set correctly
- websocket/tests/script-tests/simple.js: (ws.onopen): (ws.onmessage): (ws.onclose):
- websocket/tests/simple-expected.txt: Added readyState logging.
- 3:21 PM Changeset in webkit [51614] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-02 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32029
Mousewheel event delta has reversed sign on Linux Chrome.
No new tests (layout tests don't cover event conversion code).
Manual test: http://www.switchonthecode.com/tutorials/javascript-tutorial-the-scroll-wheel
- src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseWheelEvent):
- 1:36 PM Changeset in webkit [51613] by
-
- 2 edits in trunk/LayoutTests
Make change-values-during-transition less flaky. Transition is 1 sec duration,
translating 100px, starting at 0, so it should be at 50px at 500ms, not 600ms.
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31997
- transitions/change-values-during-transition.html:
isEqual: Remove unnecessary code - tolerance always passed in and always default value.
getXPosition: Extract into a function, since it is duplicated twice.
check2: Still run second check if the first fails, just give more debugging output.
start: Remove final setTimeout - nothing changes between the end of check2 and here,
so this is just making the test take 100ms longer.
- 1:24 PM Changeset in webkit [51612] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix the Safari build.
- 1:10 PM Changeset in webkit [51611] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Skip http/tests/cache/subresource-failover-to-network.html because it
is flaky on Windows, fixing it is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=32038.
- platform/win/Skipped:
- 11:47 AM Changeset in webkit [51610] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing layoutTestController.evaluateInWebInspector().
- platform/qt/Skipped:
- inspector/elements-panel-selection-on-refresh.html added.
- inspector/timeline-event-dispatch.html added.
- 11:34 AM Changeset in webkit [51609] by
-
- 1 edit in trunk/WebKit/win/DOMHTMLClasses.h
Build fix.
- 11:27 AM Changeset in webkit [51608] by
-
- 7 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
pass more CSS test suite stuff. Make the grammar stop enforcing the ordering of @namespace vs.
@variables vs. @import. Just let the parser handle that instead. This simplifies the grammar and
makes error handling deal with more cases correctly.
Reviewed by Darin Adler.
Added fast/css/namespaces/namespaces-invalid-at-rules.xml
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::addNamespace):
(WebCore::CSSParser::createVariablesRule):
- css/CSSParser.h:
- 11:24 AM Changeset in webkit [51607] by
-
- 2 edits in trunk/WebKit/win
Move setValueForUser to the end of the DOMHTMLInputElement interface
so it is fine for binary compatibility.
Directed by Steve Falkenburg.
- Interfaces/DOMHTML.idl:
- 11:21 AM Changeset in webkit [51606] by
-
- 3 edits in trunk/WebKit/win
Expose setValueForUser for the COM DOMHTMLInputElement.
<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
Reviewed by Dan Bernstein.
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::setValueForUser):
- Interfaces/DOMHTML.idl:
- 11:17 AM Changeset in webkit [51605] by
-
- 2 edits in trunk/WebCore
2009-12-02 Yusuke Sato <yusukes@chromium.org>
Reviewed by Dan Bernstein.
Safari/Chromium for Windows fails to load CJK WebFonts
https://bugs.webkit.org/show_bug.cgi?id=31804
- platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
- 11:10 AM Changeset in webkit [51604] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-02 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Adds a timeline test for EventDispatch records.
- inspector/timeline-event-dispatch-expected.txt: Added.
- inspector/timeline-event-dispatch.html: Added.
- 11:03 AM Changeset in webkit [51603] by
-
- 3 edits2 adds in trunk/WebCore
2009-12-02 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Chromium: Need tickmarks in scrollbar
https://bugs.webkit.org/show_bug.cgi?id=32069
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/ScrollbarThemeChromiumMac.h: Added.
- platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
- 10:34 AM Changeset in webkit [51602] by
-
- 10 edits in trunk
WebCore: Expose a function to set the value of an input element on behalf of the user.
This function will dispatch the change event so the page is notified when autofill
happens. Also dispatch a change event when a select element is changed by autofill.
<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
a change event is fired. This method is called by Safari autofill.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
of dispatching the change event directly to be consistent.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
(WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
- html/InputElement.h: Added setValueForUser.
WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header.
Reviewed by Darin Adler.
- MigrateHeaders.make:
- 10:32 AM Changeset in webkit [51601] by
-
- 12 edits2 adds in trunk
2009-12-02 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: DOM tree selection disappears upon page refresh.
Test: inspector/elements-panel-selection-on-refresh.html
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
- inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend):
- inspector/front-end/InjectedScriptAccess.js:
- 7:33 AM Changeset in webkit [51600] by
-
- 3 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
all the @-rules we support. When escape sequences are present, the lexical scanner
just returns a generic token name: ATKEYWORD. We have to process the escape sequences
and then recheck against the rules we support with the final processed name. If we
find a match, we mutate the token value to the appropriate rule name token, e.g.,
NAMESPACE_SYM.
Reviewed by Dan Bernstein.
Added fast/css/namespaces/namespaces-escapes.xml
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
(WebCore::CSSParser::recheckAtKeyword):
(WebCore::CSSParser::text):
- css/CSSParser.h:
- 6:52 AM Changeset in webkit [51599] by
-
- 5 edits in trunk
2009-12-02 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.:w
Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
https://bugs.webkit.org/show_bug.cgi?id=31877
Should be covered by buildbots.
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::enableFasterDOMStoreAccess): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
- bindings/v8/V8DOMMap.h:
2009-12-02 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
https://bugs.webkit.org/show_bug.cgi?id=31877
- src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
- 5:12 AM Changeset in webkit [51598] by
-
- 15 edits4 deletes in trunk/WebCore
2009-12-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Code clean up: remove ScriptObjectQuarantine.* as a whole.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/ScriptObjectQuarantine.cpp: Removed.
- bindings/js/ScriptObjectQuarantine.h: Removed.
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptObjectQuarantine.cpp: Removed.
- bindings/v8/ScriptObjectQuarantine.h: Removed.
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/InspectorController.cpp:
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorFrontend.cpp:
- 4:55 AM Changeset in webkit [51597] by
-
- 2 edits in trunk/LayoutTests
[Qt] r51577 made fast/frames/sandboxed-iframe-plugins.html crash.
- platform/qt/Skipped:
- fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher)
- 2:51 AM Changeset in webkit [51596] by
-
- 3 edits in trunk/WebKitTools
2009-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] build-attachment shouldn't check whether the builders are red
https://bugs.webkit.org/show_bug.cgi?id=32062
build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- 2:44 AM Changeset in webkit [51595] by
-
- 3 edits in trunk/WebKitTools
2009-12-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(51590): style-queue and build-queue think their empty when they are not
https://bugs.webkit.org/show_bug.cgi?id=32061
- Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
- Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
- 2:18 AM Changeset in webkit [51594] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Skip new tests.
- platform/qt/Skipped:
- svg/custom/mask-with-all-units.svg added.
- fast/css/namespaces/namespaces-comments.xml added.
- fast/css/namespaces/namespaces-empty.xml added.
- 1:59 AM Writing Layout Tests for DumpRenderTree edited by
- Document setCanOpenWindows (based on an example I found, not actual … (diff)
- 1:43 AM Changeset in webkit [51593] by
-
- 3 edits in trunk/WebKitTools
2009-12-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
build-queue is throwing exceptions and complaining about
lack of --no-update on build-attachment. Make it stop.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- 1:15 AM Changeset in webkit [51592] by
-
- 2 edits in trunk/WebKitTools
2009-12-02 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Forgot to declare my variables. :(
- QueueStatusServer/queue_status.py:
- 1:11 AM Changeset in webkit [51591] by
-
- 3 edits1 add in trunk/WebKitTools
2009-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement status bubble view
https://bugs.webkit.org/show_bug.cgi?id=32057
The status bubble is a compact representation of the queue status for a
given patch. This will eventually help us reduce the comment spam from
the queues.
- QueueStatusServer/index.html: Added HTML5 doctype for sanity.
- QueueStatusServer/queue_status.py:
- QueueStatusServer/status_bubble.html: Added.
- 1:04 AM Changeset in webkit [51590] by
-
- 8 edits in trunk/WebKitTools
2009-12-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
trim commands/*.py includes now that commands are unit tested
https://bugs.webkit.org/show_bug.cgi?id=32056
In the course of ensuring that the unit tests still
passed after this change, I had to actually make them
pass in the first place.
- Scripts/modules/bugzilla.py:
- Fix _parse_attachment_ids_request_query to return ints instead of strings.
- Scripts/modules/commands/download.py: Remove unneeded imports.
- Scripts/modules/commands/queries.py: Ditto.
- Scripts/modules/commands/queues.py: Ditto.
- Scripts/modules/commands/upload.py: Ditto.
- Scripts/modules/scm_unittest.py:
- Fix to expect the \n after the path since echo adds an \n.
- 12:19 AM Changeset in webkit [51589] by
-
- 4 edits17 adds in trunk
2009-12-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket handshake check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617
- websocket/tests/echo-location_wsh.py: Added.
- websocket/tests/no-query_wsh.py: Added.
- websocket/tests/script-tests/url-with-credential.js: Added.
- websocket/tests/script-tests/url-with-empty-query.js: Added.
- websocket/tests/script-tests/url-with-fragment.js: Added.
- websocket/tests/script-tests/url-with-query-for-no-query.js: Added.
- websocket/tests/script-tests/url-with-query.js: Added.
- websocket/tests/url-with-credential-expected.txt: Added.
- websocket/tests/url-with-credential.html: Added.
- websocket/tests/url-with-empty-query-expected.txt: Added.
- websocket/tests/url-with-empty-query.html: Added.
- websocket/tests/url-with-fragment-expected.txt: Added.
- websocket/tests/url-with-fragment.html: Added.
- websocket/tests/url-with-query-expected.txt: Added.
- websocket/tests/url-with-query-for-no-query-expected.txt: Added.
- websocket/tests/url-with-query-for-no-query.html: Added.
- websocket/tests/url-with-query.html: Added.
2009-12-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket handshake check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617
Tests: websocket/tests/url-with-credential.html
websocket/tests/url-with-empty-query.html
websocket/tests/url-with-fragment.html
websocket/tests/url-with-query-for-no-query.html
websocket/tests/url-with-query.html
- platform/KURLGoogle.cpp: (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
- websockets/WebSocketHandshake.cpp: (WebCore::resourceName): added. add query component to path if specified. (WebCore::WebSocketHandshake::clientLocation): (WebCore::WebSocketHandshake::clientHandshakeMessage):
Dec 1, 2009:
- 10:26 PM Changeset in webkit [51588] by
-
- 2 edits in trunk/WebCore
Incorrect code in WebGLRenderingContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=32046
Reviewed by Eric Seidel.
Fix incorrect code that happened to work. != has higher precendence than &.
The simplest fix is to remove the "!= 0" which violates WebKit style
guidelines anyway.
Also added periods to few comments in the same function.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArray):
- 9:51 PM Changeset in webkit [51587] by
-
- 4 edits in trunk/WebKitSite
2009-12-01 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added clarifications to the web site regarding coding style and
code cleanup--
Changes include the following:
- Expanded the style guidelines regarding "using" statements.
- Made the style guidelines page validate as HTML.
- Added that legacy WebKit components should not be cleaned up.
- Added that it is more acceptable to update style when already touching code.
- coding/coding-style.html:
- coding/contributing.html:
- projects/cleanup/index.html:
- 9:50 PM Changeset in webkit [51586] by
-
- 5 edits in trunk/LayoutTests
2009-12-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Update expectations of css2.1/t1205-c56* for Qt
https://bugs.webkit.org/show_bug.cgi?id=32015
- platform/qt/Skipped:
- platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
- platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
- 9:44 PM Changeset in webkit [51585] by
-
- 2 edits in trunk/WebKitTools
2009-12-01 Yaar Schnitman <yaar@chromium.org>
build-webkit: Remove flex,bison,gperf check for chromium
https://bugs.webkit.org/show_bug.cgi?id=32043
- Scripts/webkitdirs.pm:
- 9:17 PM Changeset in webkit [51584] by
-
- 7 edits3 adds in trunk
2009-12-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708
- fast/forms/input-minmax-expected.txt:
- fast/forms/input-pattern-expected.txt: Added.
- fast/forms/input-pattern.html: Added.
- fast/forms/input-step-expected.txt:
- fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string.
- fast/forms/script-tests/input-pattern.js: Added.
- fast/forms/script-tests/input-step.js: Change the result for null.
2009-12-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708
- html/HTMLInputElement.idl:
- 8:54 PM Changeset in webkit [51583] by
-
- 3 edits in trunk/WebKitTools
Build fixage for Windows/GTK for DumpRenderTree.
WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
- 8:40 PM Changeset in webkit [51582] by
-
- 11 edits2 adds in trunk
WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-drag-drop.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
(WebCore::AccessibilityObject::isARIAGrabbed):
(WebCore::AccessibilityObject::setARIAGrabbed):
(WebCore::AccessibilityObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::isARIAGrabbed):
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- html/HTMLAttributeNames.in:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getARIADropEffectsCallback):
(getARIAIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
LayoutTests:
- platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
- platform/mac/accessibility/aria-drag-drop.html: Added.
- 7:49 PM Changeset in webkit [51581] by
-
- 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp
Typo fix.
- 7:44 PM Changeset in webkit [51580] by
-
- 3 edits in trunk/WebCore
2009-12-01 Adam Barth <abarth@webkit.org>
Unreviewed port of @sandbox to V8.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- 7:28 PM Changeset in webkit [51579] by
-
- 1 edit2 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=21288
Reviewed by Darin Adler.
Add sneaky test that has tabs.
- fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
- 7:02 PM Changeset in webkit [51578] by
-
- 1 edit in trunk/WebCore/loader/FrameLoaderTypes.h
Change unsigned to int to fix the Windows build.
- 6:40 PM Changeset in webkit [51577] by
-
- 23 edits55 adds in trunk
2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288
- fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
- fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
- fast/frames/resources/sandboxed-iframe-navigated.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
- fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
- fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
- fast/frames/sandboxed-iframe-forms-expected.txt: Added.
- fast/frames/sandboxed-iframe-forms.html: Added.
- fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
- fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-parent.html: Added.
- fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
- fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
- fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
- fast/frames/sandboxed-iframe-plugins.html: Added.
- fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting.html: Added.
- fast/frames/sandboxed-iframe-storage-expected.txt: Added.
- fast/frames/sandboxed-iframe-storage.html: Added.
- http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
- http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
- http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
- http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
- http/tests/security/sandboxed-iframe-document-cookie.html: Added.
- http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
- http/tests/security/sandboxed-iframe-modify-self.html: Added.
- http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
- http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.
2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288
Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
fast/frames/sandboxed-iframe-forms.html
fast/frames/sandboxed-iframe-navigation-allowed.html
fast/frames/sandboxed-iframe-navigation-parent.html
fast/frames/sandboxed-iframe-navigation-targetlink.html
fast/frames/sandboxed-iframe-navigation-windowopen.html
fast/frames/sandboxed-iframe-plugins.html
fast/frames/sandboxed-iframe-scripting.html
fast/frames/sandboxed-iframe-storage.html
http/tests/security/sandboxed-iframe-document-cookie.html
http/tests/security/sandboxed-iframe-modify-self.html
http/tests/security/xss-DENIED-sandboxed-iframe.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
- bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation (WebCore::createWindow):
- bindings/js/ScriptController.cpp: sandboxing scripts (WebCore::ScriptController::isEnabled):
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): raise exception when accessed from sandbox (WebCore::Document::setCookie): raise exception when accessed from sandbox (WebCore::Document::initSecurityContext): updae sandbox status (WebCore::Document::updateSandboxFlags):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLAppletElement.cpp: sandboxing applets (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::renderWidgetForJSBindings): (WebCore::HTMLAppletElement::canEmbedJava):
- html/HTMLAppletElement.h:
- html/HTMLAttributeNames.in:
- html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
- html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::sandboxFlags):
- html/HTMLIFrameElement.cpp: sandbox attribute parsing (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
- html/HTMLIFrameElement.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
- loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::submitForm): sandboxing forms (WebCore::FrameLoader::requestObject): sandboxing plugins (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
- loader/FrameLoader.h: (WebCore::FrameLoader::ownerElementSandboxFlagsChanged): (WebCore::FrameLoader::isSandboxed): (WebCore::FrameLoader::sandboxFlags):
- loader/FrameLoaderTypes.h: (WebCore::):
- page/DOMWindow.cpp: disable storage and databases in sandboxed frames (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::openDatabase):
- page/SecurityOrigin.cpp: added sandboxing status (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::toString):
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- 6:04 PM Changeset in webkit [51576] by
-
- 7 edits2 adds in trunk
ARIA: support a way to create a static text object
https://bugs.webkit.org/show_bug.cgi?id=32030
Reviewed by David Kilzer.
WebCore:
Test: accessibility/aria-text-role.html
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/aria-text-role-expected.txt: Added.
- accessibility/aria-text-role.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 5:56 PM Changeset in webkit [51575] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. GTK DRT try 2.
- 5:51 PM Changeset in webkit [51574] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. Try to fix gtk DRT build.
- 5:48 PM Changeset in webkit [51573] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to rebuild Interfaces and fix the Windows build.
- 5:41 PM Changeset in webkit [51572] by
-
- 3 edits in trunk/WebCore
Inspector crashes when collecting on every allocation
https://bugs.webkit.org/show_bug.cgi?id=32044
Reviewed by Maciej Stachowiak.
The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.
- 5:40 PM Changeset in webkit [51571] by
-
- 2 edits in trunk
Build fix by using DOMNode::node() to go from a DOMNode to a node, and
added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.
- 5:26 PM Changeset in webkit [51570] by
-
- 3 edits in trunk/WebKitTools
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
https://bugs.webkit.org/show_bug.cgi?id=32033
Reviewed by Eric Seidel.
- Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
instead of startswith.
- Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
- 5:03 PM Changeset in webkit [51569] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
- 4:53 PM Changeset in webkit [51568] by
-
- 4 edits in trunk/WebKit
Not reviewed. Try to fix qt/win builds.
- 4:41 PM Changeset in webkit [51567] by
-
- 29 edits8 adds in trunk
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::pauseSVGAnimation):
- WebFrame.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
- WebView/WebFramePrivate.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
to sample a svg animateMotion/animateColor/animate/set element at certain times.
After the desired SVG animation starts and calling the method above, it's immediately forwarded to
the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
a callback is fired used to sample the animation value at the target time. It's modelled similar
to the CSS animation/transition testing framework, inspired by
LayoutTests/animations/animation-test-helpers.js.
Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
interaction, while animating.
Test: svg/animations/animVal-basics.html
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
- svg/SVGDocumentExtensions.h:
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add LayoutTests/svg/animations directory, containing a new
framework for SVG animation test with sampling at certain times.
Added one example test, which will be extended soon to cover animVal
support, once basic support has been implemented.
- svg/animations: Added.
- svg/animations/animVal-basics-expected.txt: Added.
- svg/animations/animVal-basics.html: Added.
- svg/animations/resources: Added.
- svg/animations/resources/SVGAnimationTestCase.js: Added. (isCloseEnough): (moveAnimationTimelineAndSample): (startTest): (sampleAnimation): (runAnimationTest):
- svg/animations/script-tests: Added.
- svg/animations/script-tests/TEMPLATE.html: Added.
- svg/animations/script-tests/animVal-basics.js: Added. (sample1): (sample2): (sample3): (executeTest):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add new 'sampleSVGAnimationForElementAtTime' DRT method,
used by the new SVG animation testing framework, implemented
for qt/gtk/win/mac.
- DumpRenderTree/LayoutTestController.cpp: (sampleSVGAnimationForElementAtTimeCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- 4:05 PM Changeset in webkit [51566] by
-
- 14 edits in trunk
JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used.
This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.
WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
https://bugs.webkit.org/show_bug.cgi?id=31749
Reviewed by Darin Adler.
- 3:59 PM Changeset in webkit [51565] by
-
- 2 edits in trunk/WebCore
More Windows build fix.
- platform/network/cf/CredentialStorageCFNet.cpp: (WebCore::CredentialStorage::getFromPersistentStorage):
- 3:52 PM Changeset in webkit [51564] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
- 3:40 PM Changeset in webkit [51563] by
-
- 2 edits in trunk/LayoutTests
Skip more tests that fail with specific versions of CFNetwork on Windows
Rubber-stamped in advance by Brady Eidson.
- platform/win/Skipped:
- 3:36 PM Changeset in webkit [51562] by
-
- 4 edits in trunk/WebKit/mac
Simplify [WebView userAgentForURL:]. No need to call into helper function.
Reviewed by Mark Rowe.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
- WebView/WebView.mm:
(-[WebView userAgentForURL:]):
- WebView/WebViewInternal.h:
- 3:35 PM Changeset in webkit [51561] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork
- 3:34 PM Changeset in webkit [51560] by
-
- 4 edits in trunk/WebKit/chromium
[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part one: Add new APIs. (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893
Reviewed by Darin Fisher.
- public/WebView.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
- src/WebViewImpl.h:
- 2:12 PM Changeset in webkit [51559] by
-
- 6 edits in trunk
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Updated layout test to reflect change to localized string and
rebased the result.
- inspector/elements-img-tooltip-expected.txt:
- inspector/elements-img-tooltip.html:
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Added missing localized strings (that I left out of the patch for bug #21554):
%d × %d pixels
%d × %d pixels (Natural: %d × %d pixels)
Also, changed formatting of these stings to conform with existing ones (added
a space on both sides of the multiply sign).
- English.lproj/localizedStrings.js: Added stings.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- 2:05 PM Changeset in webkit [51558] by
-
- 2 edits in trunk/WebKit/qt
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Makes QtLauncher default to the http scheme for URLs.
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation): (main):
- 1:33 PM Changeset in webkit [51557] by
-
- 2 edits in trunk/LayoutTests
Skip a test that fails with some versions of CFNetwork on Windows
Rubber-stamped by Brady Eidson.
- platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.
- 1:32 PM Changeset in webkit [51556] by
-
- 2 edits4 adds in trunk
Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.
Reviewed by Simon Fraser.
Added fast/css/namespaces/namespaces-empty.xml
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):
- 1:17 PM Changeset in webkit [51555] by
-
- 2 edits in trunk/JavaScriptCore
Revert 51551 because it broke GTK+.
- 12:59 PM Changeset in webkit [51554] by
-
- 2 edits in trunk/WebKitTools
Remove user content before running each test on Windows
Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.
- 12:08 PM Changeset in webkit [51553] by
-
- 2 edits in trunk/WebCore
2009-12-01 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Escape key in the Search Field should be more User Friendly
https://bugs.webkit.org/show_bug.cgi?id=32005
- inspector/front-end/inspector.js: (WebInspector.loaded): add mousedown listener on the search field (WebInspector.searchFieldManualFocus): user clicked to focus on the search field (WebInspector.searchKeyDown): handle escape
- 11:08 AM Changeset in webkit [51552] by
-
- 2 edits in trunk/LayoutTests
Enabling WebSocket tests on Windows again - let's see what errors get logged.
- platform/win/Skipped:
- 11:01 AM Changeset in webkit [51551] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-01 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250
- wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is already define in config.h
- 10:56 AM Changeset in webkit [51550] by
-
- 2 edits in trunk/WebKitTools
2009-12-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Make pywebsocket log errors to a file
https://bugs.webkit.org/show_bug.cgi?id=31604
- Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory (by passing the path to the server via a recently added -l option).
- 10:55 AM Changeset in webkit [51549] by
-
- 2 edits4 adds in trunk
@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec. Not doing so prevent comments from being used immmediately after the namespace prefix.
Reviewed by David Kilzer.
Added fast/css/namespaces-comments.xml
- css/CSSGrammar.y:
- 10:41 AM Changeset in webkit [51548] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-01 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Darin Fisher.
Only fire start/stop events when main frame is not loading.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
- 10:38 AM Changeset in webkit [51547] by
-
- 2 edits in trunk/LayoutTests
Add a timing-out test to the Skipped file on Windows
Rubber-stamped by Ada Chan.
- platform/win/Skipped: Added
fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.
- 10:35 AM Changeset in webkit [51546] by
-
- 2 edits in trunk/WebKitTools
Fix tests that use the TestNetscapePlugin in Debug_Internal builds
Reviewed by Ada Chan.
Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds
- DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
directory in Debug and Debug_All builds, but not in Debug_Internal
builds.
- 10:01 AM Changeset in webkit [51545] by
-
- 2 edits in trunk/WebKitTools
Re-enable DRT's watchdog timer on Windows
It was accidentally disabled in r50907.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.
- 9:24 AM Changeset in webkit [51544] by
-
- 2 edits in trunk/WebCore
2009-12-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Timothy Hatcher.
Reloading WebInspector from context menu is closing it instead of reloading.
https://bugs.webkit.org/show_bug.cgi?id=32004
When reloading WebInspector, don't delete its m_page.
- inspector/InspectorController.cpp: (WebCore::InspectorController::close):
- 9:20 AM Changeset in webkit [51543] by
-
- 2 edits7 adds in trunk/LayoutTests
Add expected Windows failure results for tests that use textInputController
<http://webkit.org/b/32021> covers fixing these tests.
Rubber-stamped by Sam Weinig.
- platform/win/Skipped: Removed tests that use textInputController.
- platform/win/editing/selection/5825350-1-expected.txt: Added.
- platform/win/editing/selection/5825350-2-expected.txt: Added.
- platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
- platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
- platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
- platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
- platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.
- 8:51 AM Changeset in webkit [51542] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().
- platform/qt/Skipped: inspector/timeline-network-resource.html added.
- 8:46 AM Changeset in webkit [51541] by
-
- 3 edits in trunk/WebKitTools
2009-12-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
check-webkit-style complains about #imports with / in them
https://bugs.webkit.org/show_bug.cgi?id=32022
We need to exclude #import directives in addition to #include from the
binary operator whitespace checks.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 8:46 AM Changeset in webkit [51540] by
-
- 8 edits6 adds in trunk/WebCore
2009-12-01 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
Adds V8 bindings for Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=30206
Also adds Geolocation files to Chrome build files.
- WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
- WebCore.gypi: Modified. Adds Geolocation files.
- bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
- bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
- bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
- bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
- bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
- bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
- bindings/v8/custom/V8CustomPositionCallback.cpp: Added. (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor. (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor. (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
- bindings/v8/custom/V8CustomPositionCallback.h: Added. (WebCore::V8CustomPositionCallback::create): Added. Factory method.
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added. (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor. (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor. (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
- bindings/v8/custom/V8CustomPositionErrorCallback.h: Added. (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
- bindings/v8/custom/V8GeolocationCustom.cpp: Added. (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error. (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument. (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument. (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
- 8:19 AM Changeset in webkit [51539] by
-
- 2 edits3 adds in trunk/LayoutTests
2009-12-01 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Adds test for Timeline network resource records.
- inspector/timeline-network-resource-expected.txt: Added.
- inspector/timeline-network-resource.html: Added.
- inspector/timeline-network-resource.js: Added.
- inspector/timeline-test.js: (printTimelineRecords):
- 8:17 AM Changeset in webkit [51538] by
-
- 4 edits in trunk/WebCore
2009-12-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Provide a way to get ScriptState for the inspected page.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromPage):
- 8:09 AM Changeset in webkit [51537] by
-
- 5 edits in trunk
Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
https://bugs.webkit.org/show_bug.cgi?id=30778
- 7:45 AM Changeset in webkit [51536] by
-
- 2 edits in trunk/WebCore
2009-12-01 Mads Ager <ager@chromium.org>
Reviewed by Eric Seidel.
[V8] Don't crash in DOMWindow event getter in OOM situations
https://bugs.webkit.org/show_bug.cgi?id=32017
Add missing null handle checks in DOMWindow event property
accessors. V8Proxy::context(frame) can return a null handle in
OOM situations either if failing to initialize a context or if an
OOM is handled gracefully and javascript is disabled.
No new tests because we don't have a good way to test
out-of-memory bugs.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- 6:44 AM Changeset in webkit [51535] by
-
- 6 edits in trunk
Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
https://bugs.webkit.org/show_bug.cgi?id=31672
- 6:22 AM Changeset in webkit [51534] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Not reviewed: chromium build fix, added missing import.
- inspector/InspectorFrontendHost.cpp:
- 3:26 AM Changeset in webkit [51533] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing textInputController.selectedRange().
- platform/qt/Skipped:
- editing/selection/mixed-editability-10.html added.
- editing/selection/5825350-1.html added.
- editing/selection/5825350-2.html added.
- 1:45 AM Changeset in webkit [51532] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fix windows build via unexcluding generated files from
project.
- WebCore.vcproj/WebCore.vcproj:
- 1:33 AM Changeset in webkit [51531] by
-
- 2 edits in trunk/WebCore
Stop copying IDL files in to the WebCore framework wrapper.
- WebCore.xcodeproj/project.pbxproj:
- 1:28 AM Changeset in webkit [51530] by
-
- 2 edits in trunk/WebCore
Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.
This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.
- WebCore.xcodeproj/project.pbxproj:
- 12:45 AM Changeset in webkit [51529] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix (bad vcproj in r51528).
- WebCore.vcproj/WebCore.vcproj:
- 12:07 AM Changeset in webkit [51528] by
-
- 49 edits5 copies7 adds2 deletes in trunk/WebCore
2009-11-27 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Split InspectorBackend into three parts: backend,
injected script host and frontend host.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSInspectorBackendCustom.cpp: Removed.
- bindings/js/JSInspectorFrontendHostCustom.cpp: Added. (WebCore::JSInspectorFrontendHost::search): (WebCore::JSInspectorFrontendHost::setting): (WebCore::JSInspectorFrontendHost::setSetting):
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/ScriptObject.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- inspector/InjectedScriptHost.cpp: Added. (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::nodeForId): (WebCore::InjectedScriptHost::wrapObject): (WebCore::InjectedScriptHost::unwrapObject): (WebCore::InjectedScriptHost::pushNodePathToFrontend): (WebCore::InjectedScriptHost::addNodesToSearchResult): (WebCore::InjectedScriptHost::currentCallFrame): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::inspectorFrontend):
- inspector/InjectedScriptHost.h: Added. (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorController): (WebCore::InjectedScriptHost::disconnectController):
- inspector/InjectedScriptHost.idl: Added.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::InspectorBackend): (WebCore::InspectorBackend::storeLastActivePanel): (WebCore::InspectorBackend::toggleNodeSearch): (WebCore::InspectorBackend::resourceTrackingEnabled): (WebCore::InspectorBackend::debuggerEnabled): (WebCore::InspectorBackend::enableDebugger): (WebCore::InspectorBackend::disableDebugger): (WebCore::InspectorBackend::addBreakpoint): (WebCore::InspectorBackend::updateBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::resumeDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptions): (WebCore::InspectorBackend::setPauseOnExceptions): (WebCore::InspectorBackend::profilerEnabled): (WebCore::InspectorBackend::enableProfiler): (WebCore::InspectorBackend::disableProfiler): (WebCore::InspectorBackend::startProfiling): (WebCore::InspectorBackend::stopProfiling): (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile): (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::highlightDOMNode): (WebCore::InspectorBackend::hideDOMNodeHighlight): (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie): (WebCore::InspectorBackend::didEvaluateForTestInFrontend): (WebCore::InspectorBackend::nodeForId):
- inspector/InspectorBackend.h: (WebCore::InspectorBackend::create):
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorFrontendHost): (WebCore::InspectorController::injectedScriptHost):
- inspector/InspectorFrontendHost.cpp: Added. (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::windowUnloading): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::localizedStringsURL): (WebCore::InspectorFrontendHost::hiddenPanels): (WebCore::InspectorFrontendHost::platform): (WebCore::InspectorFrontendHost::port): (WebCore::InspectorFrontendHost::addResourceSourceToFrame): (WebCore::InspectorFrontendHost::addSourceToFrame):
- inspector/InspectorFrontendHost.h: Added. (WebCore::InspectorFrontendHost::create): (WebCore::InspectorFrontendHost::inspectorController): (WebCore::InspectorFrontendHost::disconnectController):
- inspector/InspectorFrontendHost.idl: Added.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): ():
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype):
- inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.getCallFrames): (InjectedScript._callFrameForId): (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._window): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript.pushNodeToFrontend): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/InspectorBackendStub.js: Added. (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.wrapCallback): (.WebInspector.InspectorBackendStub.prototype.platform): (.WebInspector.InspectorBackendStub.prototype.port): (.WebInspector.InspectorBackendStub.prototype.closeWindow): (.WebInspector.InspectorBackendStub.prototype.attach): (.WebInspector.InspectorBackendStub.prototype.detach): (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel): (.WebInspector.InspectorBackendStub.prototype.clearMessages): (.WebInspector.InspectorBackendStub.prototype.searchingForNode): (.WebInspector.InspectorBackendStub.prototype.search): (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch): (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted): (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode): (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode): (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight): (.WebInspector.InspectorBackendStub.prototype.inspectedWindow): (.WebInspector.InspectorBackendStub.prototype.loaded): (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL): (.WebInspector.InspectorBackendStub.prototype.windowUnloading): (.WebInspector.InspectorBackendStub.prototype.hiddenPanels): (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.addBreakpoint): (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint): (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint): (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger): (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.resumeDebugger): (.WebInspector.InspectorBackendStub.prototype.profilerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler): (.WebInspector.InspectorBackendStub.prototype.startProfiling): (.WebInspector.InspectorBackendStub.prototype.stopProfiling): (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders): (.WebInspector.InspectorBackendStub.prototype.getProfile): (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot): (.WebInspector.InspectorBackendStub.prototype.databaseTableNames): (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.setSetting): (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setting):
- inspector/front-end/InspectorControllerStub.js:
- inspector/front-end/InspectorFrontendHostStub.js: Added. (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.platform): (.WebInspector.InspectorFrontendHostStub.prototype.port): (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow): (.WebInspector.InspectorFrontendHostStub.prototype.attach): (.WebInspector.InspectorFrontendHostStub.prototype.detach): (.WebInspector.InspectorFrontendHostStub.prototype.search): (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy): (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.loaded): (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.setSetting): (.WebInspector.InspectorFrontendHostStub.prototype.setting):
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
- inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.get platform): (WebInspector.get port): (WebInspector.set currentPanel): (WebInspector._createPanels): (WebInspector._loadPreferences): (WebInspector.set attached): (WebInspector._updateHoverHighlight): (WebInspector.loaded): (windowLoaded): (WebInspector.windowUnload): (WebInspector.close): (WebInspector.toolbarDrag): (WebInspector.UIString):
Nov 30, 2009:
- 11:37 PM Changeset in webkit [51527] by
-
- 24 edits2 adds in trunk
2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264
css2.1/t1205-c565-list-pos-00-b.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23263
Ignore whitespaces after list markers.
Rendering of this was already done for the case where inside=false.
This fixes the rendering of inside=true case and calcInlinePrefWidths.
Test: fast/lists/calc-width-with-space.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264
- editing/pasteboard/copy-crash-expected.txt:
- fast/lists/calc-width-with-space-expected.txt: Added.
- fast/lists/calc-width-with-space.html: Added.
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
- platform/mac/fast/repaint/list-marker-expected.checksum:
- platform/mac/fast/repaint/list-marker-expected.png:
- platform/mac/fast/repaint/list-marker-expected.txt:
- platform/qt/Skipped:
- 11:25 PM Changeset in webkit [51526] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
check-webkit-style is slightly too verbose
https://bugs.webkit.org/show_bug.cgi?id=32010
check-webkit-style prints out a bunch of "done" lines that seem redundant,
especially for the style-queue.
- Scripts/modules/cpp_style.py:
- 10:41 PM Changeset in webkit [51525] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
[GTK] Moved the functions that are closing the result log of the
tests to the last line of the runTest function, this avoids
reporting crashes in the wrong test if there is a problem when
reseting the state after the test.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
- 7:33 PM Changeset in webkit [51524] by
-
- 5 edits in trunk/WebCore
2009-11-30 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed Chromium build fix introduced by r51212
Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
as the first argument.
Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
Add debuggerWorld() and pluginWorld() in ScriptState.h.
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): (WebCore::scriptStateFromPage): (WebCore::mainThreadNormalWorld):
- bindings/v8/ScriptState.h: (WebCore::debuggerWorld): (WebCore::pluginWorld):
- 5:18 PM Changeset in webkit [51523] by
-
- 5 edits in trunk/WebKitTools
Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test
Reviewed by Geoffrey Garen.
Don't cache JSClassRefs, a change to the prototype chain will
last between tests.
- DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::getJSClass):
- DumpRenderTree/GCController.cpp:
(GCController::getJSClass):
- DumpRenderTree/GCController.h:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::getJSClass):
- 4:44 PM Changeset in webkit [51522] by
-
- 15 edits2 adds in trunk
WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
Reviewed by Darin Adler.
The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.
Test: editing/selection/mixed-editability-10.html
- WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
- dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
- dom/Position.h:
(WebCore::Position::):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
- dom/PositionIterator.h:
- editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
- rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
- rendering/RenderText.h:
LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
Reviewed by Darin Adler.
- editing/selection/5825350-1-expected.txt:
- editing/selection/5825350-1.html: Modified to use caret rectangle.
- editing/selection/5825350-2-expected.txt:
- editing/selection/5825350-2.html: Modified to use caret rectangle.
- editing/selection/mixed-editability-10-expected.txt: Added.
- editing/selection/mixed-editability-10.html: Added.
- platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.
- 4:40 PM Changeset in webkit [51521] by
-
- 3 edits in trunk/WebKitTools
2009-11-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.2.1.
This is to fix a bug that some messages are logged to stderr even when the log file is specified.
https://bugs.webkit.org/show_bug.cgi?id=31976
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- 4:12 PM Changeset in webkit [51520] by
-
- 2 edits in trunk/WebCore
wx build fix, add header needed for wx build.
- 4:08 PM Changeset in webkit [51519] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries
Reviewed by David Kilzer.
The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined. We work around this by forcing the check to
be performed against the x86_64 architecture.
- DerivedSources.make:
- 4:07 PM Changeset in webkit [51518] by
-
- 3 edits in trunk/WebKitTools
2009-11-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Generate pass messages for style-queue
https://bugs.webkit.org/show_bug.cgi?id=31995
With this change, the style-queue posts "pass" messages to bugs as
well. Also, added more information to the state store w.r.t. passing
and failing.
- Scripts/modules/commands/queues.py:
- Scripts/modules/patchcollection.py:
- 3:55 PM Changeset in webkit [51517] by
-
- 3 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>
Reviewed by Oliver Hunt.
Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>
Reviewed by Oliver Hunt.
- fast/multicol/huge-column-gap-crash-expected.txt: Added.
- fast/multicol/huge-column-gap-crash.html: Added.
- 3:48 PM Changeset in webkit [51516] by
-
- 4 edits in trunk
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error
The network connection was closed, but the close event wasn't dispatched.
Tested by websocket/tests/handshake-error.html, which is un-skipped now.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): Call client didHandle() method. This looks strange in CFNetwork implementation, because it's the client that asked to close the stream, so it shouldn't need the callback. It makes more sense in cross-process implementation, because closing is async there.
- 3:45 PM UsingGitWithWebKit edited by
- (diff)
- 3:20 PM Changeset in webkit [51515] by
-
- 2 edits in trunk/WebKit/qt
2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com>
Reviewed by Simon Hausmann.
[Qt][Symbian] Report SymbianOS in user agent string for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31961
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- 2:10 PM Changeset in webkit [51514] by
-
- 2 edits in trunk/JavaScriptCore
Windows Build fix. Reviewed by NOBODY.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 2:02 PM Changeset in webkit [51513] by
-
- 2 edits in trunk/WebKit
Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.
- WebKit.xcodeproj/project.pbxproj:
- 1:48 PM Changeset in webkit [51512] by
-
- 36 edits in trunk
Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
Reviewed by Geoff Garen.
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.
- API/JSBase.cpp:
(JSEvaluateScript):
- API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
- JavaScriptCore.exp:
- runtime/JSGlobalData.cpp:
- runtime/JSGlobalData.h:
WebCore:
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld(). Switch this to obtain the world from the ExecsState's lexical global
object instead. Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.
- WebCore.base.exp:
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
- dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
- dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
- dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
WebKit/mac:
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
- 1:43 PM Changeset in webkit [51511] by
-
- 4 edits6 deletes in trunk
2009-11-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): (WebCore::HTMLMediaElement::noneSupported): (WebCore::HTMLMediaElement::mediaEngineError): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::userCancelledLoad):
Call scheduleEvent instead of scheduleProgressEvent.
(WebCore::HTMLMediaElement::progressEventTimerFired):
Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
after scheduling a 'progress' event so the controller will update download
progress indicator.
- html/HTMLMediaElement.h:
Remove scheduleProgressEvent prototype.
2009-11-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513
Remove progress event tests.
- media/progress-event-at-least-one-expected.txt: Removed.
- media/progress-event-at-least-one.html: Removed.
- media/progress-event-expected.txt: Removed.
- media/progress-event-total-expected.txt: Removed.
- media/progress-event-total.html: Removed.
- media/progress-event.html: Removed.
- 1:41 PM Changeset in webkit [51510] by
-
- 4 edits in trunk/WebKit/win
Fix double-free of BSTRs passed to WebNavigationData::createInstance
WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.
The fix is to only convert to WebCore::BString inside
WebNavigationData.
Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test
I couldn't find a way to reproduce this in DumpRenderTree.
Reviewed by Steve Falkenburg.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.
- WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
- WebNavigationData.h:
Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.
- 1:38 PM Changeset in webkit [51509] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.
- 1:35 PM Changeset in webkit [51508] by
-
- 3 edits in trunk/LayoutTests
2009-11-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
https://bugs.webkit.org/show_bug.cgi?id=31465
- platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to Skipped list, and filed bug 31659 to investigate.
- websocket/tests/handshake-error_wsh.py: Call write() on a correct object.
- 1:27 PM Changeset in webkit [51507] by
-
- 1 delete in trunk/WebKit/Info.plist
Remove file git invisibly added
- 1:19 PM Changeset in webkit [51506] by
-
- 9 edits1 add in trunk
2009-11-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Wrong console output for Regexp escape sequence
https://bugs.webkit.org/show_bug.cgi?id=31538
Updated inspector/console-format.html
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): style issues. (WebInspector.ConsoleView.createFilterElement): style issues. (WebInspector.ConsoleView): added _customFormatters table. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues. (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic. (WebInspector.ConsoleView.prototype._formatobject): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts. (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting. (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting. (WebInspector.ConsoleCommandResult):
- inspector/front-end/InjectedScript.js: simplified regex formatting.
- inspector/front-end/inspector.js: (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
- inspector/front-end/utilities.js: (Element.prototype.hasStyleClass): update inaccurate comment. (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
- 12:42 PM Changeset in webkit [51505] by
-
- 3 edits in trunk/JavaScriptCore
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove obsolete PLATFORM(KDE) code
https://bugs.webkit.org/show_bug.cgi?id=31958
KDE is now using unpatched QtWebKit.
- parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
- wtf/Platform.h: Remove PLATFORM(KDE) definition and code section that is guarded with it.
- 11:55 AM Changeset in webkit [51504] by
-
- 2 edits in trunk/LayoutTests
Skipping test that fails because of broken DND, and some tests
requiring new results.
- platform/gtk/Skipped:
- 11:31 AM Changeset in webkit [51503] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.17
Tagging 1.1.17.
- 11:27 AM Changeset in webkit [51502] by
-
- 2 edits in trunk
Rubber-stamped by Xan Lopez.
Make sure we distribute and install GObject Introspection files.
- GNUmakefile.am:
- 10:59 AM Changeset in webkit [51501] by
-
- 3 edits in trunk/WebCore
2009-11-30 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
https://bugs.webkit.org/show_bug.cgi?id=31895
No new tests. This is already covered by:
fast/dom/CSSStyleDeclaration/css-computed-style-item.html
fast/dom/CSSStyleDeclaration/css-style-item.html
- bindings/v8/V8Collection.h: (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionStringIndexedGetter):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- 10:50 AM Changeset in webkit [51500] by
-
- 2 edits in trunk/WebKit/win
WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
- 10:36 AM QtBackLog edited by
- The first set of network changes landed, mark the item as completed. (diff)
- 9:54 AM Changeset in webkit [51499] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Simon Fraser.
Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.
- Scripts/run-webkit-tests:
- 9:41 AM Changeset in webkit [51498] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
https://bugs.webkit.org/show_bug.cgi?id=31932
Build fix only, no new tests.
- bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
- 9:34 AM Changeset in webkit [51497] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds PassOwnPtr include to ScriptExecutionContext.h.
https://bugs.webkit.org/show_bug.cgi?id=31929
Build fix only, no new tests.
- dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
- 9:25 AM Changeset in webkit [51496] by
-
- 3 edits4 adds in trunk
2009-11-30 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.
- platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
- platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
- platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
- svg/custom/mask-with-all-units.svg: Added.
2009-11-30 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=31980
It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.
Test: svg/custom/mask-with-all-units.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 9:17 AM Changeset in webkit [51495] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31928
Build fix only, no new tests.
- page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
- 9:10 AM Changeset in webkit [51494] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
update-webkit --chromium forces gclient sync
- Scripts/update-webkit-chromium:
- 9:03 AM Changeset in webkit [51493] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=31926
Build fix only, no new tests.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
- 8:56 AM Changeset in webkit [51492] by
-
- 2 edits in trunk/WebCore
2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Chrome::contentsSizeChanged() is called when the content size has not changed
https://bugs.webkit.org/show_bug.cgi?id=31978
Do not trigger contentsSizeChaned() is the new size is the same as the old one.
- page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
- 8:49 AM Changeset in webkit [51491] by
-
- 2 edits in trunk/WebKit/qt
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix minor waning in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=31963
- tests/qwebpage/tst_qwebpage.cpp: (ErrorPage::extension): Remove info wariable as it is not used.
- 8:42 AM Changeset in webkit [51490] by
-
- 4 edits in trunk/WebCore
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix some compiler warnings seen on QtWebKit/Mac
https://bugs.webkit.org/show_bug.cgi?id=31962
No new tests as there is no functional change.
- platform/network/ResourceHandle.h: Make destructor virtual as after r50772 ResourceHandle has virtual functions.
- plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace not a label
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format specifier
- 7:36 AM QtWebKitJournal edited by
- (diff)
- 7:31 AM Changeset in webkit [51489] by
-
- 4 edits in trunk
Versioning.
- 7:30 AM QtWebKitJournal edited by
- (diff)
- 7:30 AM Changeset in webkit [51488] by
-
- 1 copy in tags/Safari-532.5
New tag.
- 7:13 AM Changeset in webkit [51487] by
-
- 2 edits in trunk
Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.
- 7:09 AM QtWebKitJournal edited by
- (diff)
- 7:00 AM QtWebKitJournal edited by
- (diff)
- 5:53 AM Changeset in webkit [51486] by
-
- 9 edits in trunk
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump versions for 1.1.17 release.
- configure.ac:
WebCore:
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add new headers to sources list.
- GNUmakefile.am:
WebKit/gtk:
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Prepare for 1.1.17 release.
- NEWS:
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 4:08 AM Changeset in webkit [51485] by
-
- 2 edits in trunk/WebCore
[Qt] Mac Plugins : Get context menu to work in QGraphicsView
Reviewed by Holger Freyther.
Flash expects the value in record.where to be the global position for
displaying the context menu.
- 3:27 AM Changeset in webkit [51484] by
-
- 4 edits in trunk
[Qt] Fix compilation with win32-icc
Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.
.:
Include os-win32 for stdint.h since MS does not ship that in their PSDK.
- WebKit.pri:
The Intel compiler does not support the has_trivial_constructor type
trait. The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).
- wtf/TypeTraits.h:
- 2:39 AM Changeset in webkit [51483] by
-
- 2 edits in trunk/WebCore
Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
https://bugs.webkit.org/show_bug.cgi?id=31925
Reviewed by Eric Seidel.
This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.
Build fix only, no new tests.
- bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
- 1:41 AM Changeset in webkit [51482] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing features.
- platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.
- 12:58 AM QtWebKitBackportingFixes edited by
- (diff)
Nov 29, 2009:
- 8:50 PM Changeset in webkit [51481] by
-
- 2 edits in trunk/WebCore
Build fix.
Correct draw signature used in ImageCairoWin.cpp.
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- 8:15 PM Changeset in webkit [51480] by
-
- 6 edits in trunk
postMessage should serialize File objects
https://bugs.webkit.org/show_bug.cgi?id=31955
Reviewed by Sam Weinig.
Update SerializedScriptValue to include support for
File objects in the serialized object graph.
- 7:54 PM Changeset in webkit [51479] by
-
- 2 edits in trunk/WebKitTools
2009-11-29 Eric Seidel <eric@webkit.org>
Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
- Scripts/modules/committers.py:
- 7:45 PM Changeset in webkit [51478] by
-
- 9 edits in trunk/LayoutTests
2009-11-29 Simon Fraser <Simon Fraser>
Rubber-stamped by Eric Seidel.
Fix up some compositing layout tests.
- compositing/layers-inside-overflow-scroll.html:
- compositing/self-painting-layers.html: Use the 'loadeddata' event, instead of 'load', to know when the video loads.
- platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
- platform/mac/compositing/repaint/content-into-overflow-expected.png:
- platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
- platform/mac/compositing/repaint/overflow-into-content-expected.png:
- platform/mac/compositing/self-painting-layers-expected.checksum:
- platform/mac/compositing/self-painting-layers-expected.png: Update with correct pixel results.
- 7:26 PM Changeset in webkit [51477] by
-
- 3 edits in trunk/WebKitTools
2009-11-29 Eric Seidel <eric@webkit.org>
No review, just adding missing svn property.
Set svn:executable property on new scripts.
These were added by commit-queue commits, but the executable
property was lost due to a bug in svn-apply:
https://bugs.webkit.org/show_bug.cgi?id=27204
- Scripts/update-webkit-chromium: Added property svn:executable.
- Scripts/validate-committer-lists: Added property svn:executable.
- 7:21 PM Changeset in webkit [51476] by
-
- 10 edits in trunk/WebCore
2009-11-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Optimize the hierarchy rebuilding of compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31879
When updating the compositing layer hierarchy, instead of removing all
child layers and then re-adding them one by one, build a vector of child
layers, and set them in one go.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child GraphicsLayers.
- platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
- platform/graphics/win/GraphicsLayerCACF.h: Ditto.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to set the bit that notes that sublayers changed.
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to udpate sublayers, with a note that this is not efficient.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): When updating compositing layers, use the faster updateLayerTreeGeometry() if we know that no layer hierarchy changes are needed, and, at the root, use the vector returned from rebuildCompositingLayerTree() to attach the root layer. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to collect child layers into Vectors of GraphicsLayers, which can be set as layer children in one go. (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from rebuildCompositingLayerTree() for simplicity, and called when we just need to update layer geometry, without doing any reparenting.
- 7:12 PM Changeset in webkit [51475] by
-
- 1 edit1 add in trunk/WebKitTools
2009-11-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Need a way to validate that committers.py includes all committers/reviewers
https://bugs.webkit.org/show_bug.cgi?id=30970
Add a script which knows how to compare our public committer/reviewer
lists and show discrepancies between them.
Validates mailing lists vs. committers.py:
- committers.py committers missing from webkit-committers@lists
- webkit-committers@lists members missing from committers.py
- committers.py reviewers missing from webkit-reviewers@lists
- webkit-reviewers@lists members missing from committers.py
- webkit-reviewers@lists members missing from committers.py reviewer list
Validates committers.py vs. trunk/ SVN history:
- committers who have not committed in over a year
- SVN committers missing from committers.py
- committers.py members who have no record in SVN.
All of these lists still show "false positives" until a few more committers.py updates are made, like:
https://bugs.webkit.org/show_bug.cgi?id=31366
- Scripts/validate-committer-lists: Added.
- 7:10 PM Changeset in webkit [51474] by
-
- 2 edits in trunk/WebCore
2009-11-29 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Updated comment to reflect latest XSSAuditor bindings.
No functionality was changed. So, no new tests.
- page/XSSAuditor.h:
- 6:45 PM Changeset in webkit [51473] by
-
- 12 edits in trunk/WebCore
2009-11-29 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Removes unnecessary #include files.
No functionality was changed. So, no new tests.
- css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and Pair.h
- css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
- css/CSSFontFaceSrcValue.cpp: Removed include Node.h
- css/CSSFontSelector.cpp: Removed include NodeList.h
- css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
- css/CSSImageValue.cpp: Removed include RenderStyle.h
- css/CSSImportRule.cpp: Removed include MediaList.h
- css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
- css/CSSRule.cpp: Removed include CSSStyleSheet.h
- css/CSSStyleSelector.cpp: Removed include CSSFontFace.h, CSSFontFaceSource.h, and CSSProperty.h
- page/EventSource.h: Removed include EventListener.h
- 5:32 PM Changeset in webkit [51472] by
-
- 4 edits in trunk/WebCore
2009-11-29 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
forward declared it.
As a side effect, we need to #include KeyframeList.h in
RenderLayerBacking.cpp.
No functionality was changed. So, no new tests.
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h: Removed #include KeyframeList.h
- rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
- 5:02 PM Changeset in webkit [51471] by
-
- 3 edits2 adds in trunk
2009-11-29 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Test using Id as index of node list.
https://bugs.webkit.org/show_bug.cgi?id=31428
- fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
- fast/dom/Element/id-in-node-list-index01.html: Added.
2009-11-29 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Continue to search for matching node in the case where multiple nodes
have the same id.
https://bugs.webkit.org/show_bug.cgi?id=31428
Test: fast/dom/Element/id-in-node-list-index01.html
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
- 4:50 PM Changeset in webkit [51470] by
-
- 3 edits in trunk/WebCore
2009-11-29 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
forward declared it.
No functionality was changed. So, no new tests.
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- 4:06 PM Changeset in webkit [51469] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-11-29 Daniel Bates <dbates@webkit.org>
Unreviewed, fix change log entry date.
For some reason, bugzilla-tool did not update the date in the change
log entry for my last commit (r51468). So, this commit fixes the date
of that entry.
- 3:55 PM Changeset in webkit [51468] by
-
- 2 edits in trunk/WebCore
2009-11-28 Daniel Bates <dbates@webkit.org>
Reviewed by Dan Bernstein.
Removed #include StringImpl, StyleImage. Instead, forward declared them.
Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
since it seems we only really used it to include PassRefPtr.h.
No functionality was changed. So, no new tests.
- rendering/style/ContentData.h:
- 12:11 PM Changeset in webkit [51467] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Mac build has JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=31828
- wtf/Platform.h: Enable JIT for Qt Mac builds
- 7:57 AM Changeset in webkit [51466] by
-
- 11 edits in trunk/WebCore
2009-11-29 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31906
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class SQLTransactionClient - storage/DatabaseThread.cpp:45
class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
class OriginUsageRecord - storage/OriginQuotaManager.cpp:66
class DatabaseTracker - storage/DatabaseTracker.cpp:62
class ScrollbarTheme - (its child class) rendering/RenderScrollbarTheme.cpp:35
class RenderSelectionInfoBase - (its child class) rendering/RenderView.cpp:310
class RenderOverflow - rendering/RenderBox.cpp:2846
Inherits the following classes from FastAllocBase because these are instantiated by 'new':
struct FillLayer - css/CSSStyleSelector.cpp:197
struct ShadowData - rendering/style/ShadowData.cpp:35
class CounterContent - css/CSSStyleSelector.cpp:4111
- platform/ScrollbarTheme.h:
- rendering/RenderOverflow.h:
- rendering/RenderSelectionInfo.h:
- rendering/style/CounterContent.h:
- rendering/style/FillLayer.h:
- rendering/style/ShadowData.h:
- storage/DatabaseTracker.h:
- storage/OriginUsageRecord.h:
- storage/SQLTransactionClient.h:
- storage/SQLTransactionCoordinator.h:
Nov 28, 2009:
- 10:36 PM QtWebKitBackportingFixes edited by
- (diff)
- 10:31 PM QtWebKitBackportingFixes edited by
- (diff)
- 5:53 PM Changeset in webkit [51465] by
-
- 2 edits in trunk/WebKitTools
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31950
Now we cache the last status that we get back from QueueStatusServer.
Eventually we'll have to do something more fancy if we want to support
a "try again" button on QueueStatusServer, but we can cross that bridge
when we come to it.
- Scripts/modules/patchcollection.py:
- 5:50 PM Changeset in webkit [51464] by
-
- 8 edits in trunk/WebKitTools
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
StyleQueue scans ~100 bug pages every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31947
Instead of getting the pending-review attachment ids by scanning each
bug (which results in a network request), we should just get them all
from webkit.org/pending-review in one shot.
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/queries_unittest.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/patchcollection.py:
- 4:20 PM Changeset in webkit [51463] by
-
- 3 edits in trunk/WebKitTools
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] CC webkit-bot-watchers whenever the bots touch bugs
https://bugs.webkit.org/show_bug.cgi?id=31952
The mailing list is open for anyone to subscribe.
- Scripts/modules/bugzilla.py:
- Scripts/modules/commands/queues.py:
- 4:17 PM Changeset in webkit [51462] by
-
- 3 edits in trunk/WebKitTools
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] style-queue should report style errors to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=31945
Currently, we're just logging the style errors locally. With this
patch we'll actually log the errors to bugzilla. Note: I plan to run
with the "local-only" logging during development.
- Scripts/modules/commands/queues.py:
- Scripts/modules/scm.py:
- 1:48 PM Changeset in webkit [51461] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
https://bugs.webkit.org/show_bug.cgi?id=31943
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- 10:27 AM Changeset in webkit [51460] by
-
- 4 edits in trunk/WebKitTools
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] style-queue shouldn't reject patches from the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31944
Currently the style-queue subprocess gets confused and thinks its the
commit-queue. If the patch has an error, it rejects it from the
commit-queue. Instead, we should have style-queue specific logic.
This patch doesn't add that logic, but it gives us a callback we can
use to add that logic.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py:
- 8:39 AM Changeset in webkit [51459] by
-
- 3 edits2 adds in trunk
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test: http/tests/security/calling-versus-current.html
We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):
2009-11-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test that we're using the calling security context in a simple case.
- http/tests/security/calling-versus-current-expected.txt: Added.
- http/tests/security/calling-versus-current.html: Added.
- 7:21 AM BuildingGtk edited by
- (diff)
- 6:27 AM Changeset in webkit [51458] by
-
- 3 edits in trunk/WebKit/qt
2009-11-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] SoftwareInputPanelRequest event sent when clicking in newly loaded page
Don't set the event unless there is a focused node we can use
for editing afterwards.
- Api/qwebpage.cpp: (QWebPagePrivate::handleSoftwareInputPanel):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 2:31 AM Changeset in webkit [51457] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Seems a typo. We don't need ~270k memory to determine the vptrs.
- runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):
- 1:09 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:07 AM QtWebKitBackportingFixes edited by
- (diff)
Nov 27, 2009:
- 11:39 PM Changeset in webkit [51456] by
-
- 3 edits in trunk/WebKit/chromium
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add separate method for pause command to WebDevToolsAgent
and WebDevToolsFrontendClient interfaces so that pause command
can be processed on the IO thread.
- public/WebDevToolsAgent.h:
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::dockWindow): (WebKit::WebDevToolsFrontendClient::undockWindow):
- 10:15 PM Changeset in webkit [51455] by
-
- 2 edits in trunk/WebCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium build fix introduced by r51428.
[Chromium] Ignore line-height CSS property for PushButton
https://bugs.webkit.org/show_bug.cgi?id=31712
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
- 9:33 PM Changeset in webkit [51454] by
-
- 2 edits in trunk/WebCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium test fix by reverting r51413.
[v8] Do not check the thread when accessing DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=31877
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
- 4:32 PM Changeset in webkit [51453] by
-
- 2 edits in trunk/WebCore
2009-11-27 Daniel Bates <dbates@webkit.org>
Unreviewed, comment fix.
Corrected misspelling of the word "implemented".
- inspector/front-end/InjectedScriptAccess.js:
- 4:18 PM Changeset in webkit [51452] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
Build fix for chromium after r51423.
Exclude gtk directory from chromium build.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 3:46 PM Changeset in webkit [51451] by
-
- 1 edit1 move in trunk/WebKitTools
Rubber stamped by Eric Seidel.
Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
- CommitQueueStatus: Removed.
- CommitQueueStatus/app.yaml: Removed.
- CommitQueueStatus/filters: Removed.
- CommitQueueStatus/filters/init.py: Removed.
- CommitQueueStatus/filters/webkit_extras.py: Removed.
- CommitQueueStatus/index.html: Removed.
- CommitQueueStatus/index.yaml: Removed.
- CommitQueueStatus/queue_status.py: Removed.
- CommitQueueStatus/stylesheets: Removed.
- CommitQueueStatus/stylesheets/main.css: Removed.
- CommitQueueStatus/update_status.html: Removed.
- QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
- 3:39 PM Changeset in webkit [51450] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939
Actually address reviewer comments!
- Scripts/bugzilla-tool:
- 3:36 PM Changeset in webkit [51449] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] style-queue fails to apply a bunch of patches for no reason
https://bugs.webkit.org/show_bug.cgi?id=31942
By passing --non-interactive to check-style, we convince check-style
to pass --force to svn-apply, which lets it apply more patches.
- Scripts/modules/commands/queues.py:
- 3:35 PM Changeset in webkit [51448] by
-
- 3 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Support --status-host in style-queue
https://bugs.webkit.org/show_bug.cgi?id=31941
- Scripts/modules/commands/queues.py:
- Scripts/modules/statusbot.py:
- 3:34 PM Changeset in webkit [51447] by
-
- 5 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939
Before processing a patch, the try-queues now ask the web service
whether they have already processed the patch. This is an initial cut
of this functionality. I expect we're make it richer over time.
- Scripts/bugzilla-tool:
- Scripts/modules/commands/queues.py:
- Scripts/modules/patchcollection.py:
- 3:34 PM Changeset in webkit [51446] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PatchStatus does not return status
https://bugs.webkit.org/show_bug.cgi?id=31938
We need to parse attachment_id as an int. Otherwise, we can't find
anything in the datastore.
- CommitQueueStatus/queue_status.py:
- 3:04 PM Changeset in webkit [51445] by
-
- 17 edits in trunk
2009-11-27 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Makes the error messages more descriptive when we refuse to load an object/embed or
refuse to load from the document base URL.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2009-11-27 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Rebased results because of new error messages.
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-src-inject-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- 10:49 AM Changeset in webkit [51444] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make commit-queue status not throw an exception where there is not
status
https://bugs.webkit.org/show_bug.cgi?id=31936
We need to actually fetch the results of the query to see what's in the
datastore.
- CommitQueueStatus/queue_status.py:
- 10:09 AM Changeset in webkit [51443] by
-
- 3 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] unit test ApplyPatches and ApplyAttachment
https://bugs.webkit.org/show_bug.cgi?id=31935
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- 9:37 AM Changeset in webkit [51442] by
-
- 4 edits1 add in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Unit test download commands
https://bugs.webkit.org/show_bug.cgi?id=31923
Adds download_unittest and fixes a bug found while testing.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/download.py:
Fixed a bug where we'd throw an error because [].append returns
None.
- Scripts/modules/commands/download_unittest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/run-webkit-unittests:
- 8:21 AM Changeset in webkit [51441] by
-
- 3 edits in trunk/LayoutTests
2009-11-27 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
https://bugs.webkit.org/show_bug.cgi?id=31919
Temporarily disabled portion of test which is failing on some
machines but not others. Root cause will be investigated under
https://bugs.webkit.org/show_bug.cgi?id=31843 .
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/script-tests/gl-object-get-calls.js:
- 5:07 AM Changeset in webkit [51440] by
-
- 10 edits in trunk
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
- src/WebViewImpl.h:
- 3:12 AM Changeset in webkit [51439] by
-
- 18 edits in trunk/WebCore
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Instead of generating negative identifiers for cached resources in
InspectorController and extending identifier type from 'unsigned long' to 'long
long' reuse progress tracker from the inspected page to generate those
identifiers. It guarantees that InspectorResources have unique ids since
all of them are generated by that progress tracker.
Added a couple new overloaded methods to Script* objects that accept
long and unsigned long arguments. These types of argumens have already
been passed as long long.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
- bindings/v8/ScriptFunctionCall.h:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/v8/ScriptObject.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode):
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::createCached):
- inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'. (WebCore::InspectorResource::create): (WebCore::InspectorResource::identifier):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord):
- 12:45 AM Changeset in webkit [51438] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix found while writing unit tests.
- Scripts/modules/commands/download.py:
- 12:04 AM Changeset in webkit [51437] by
-
- 7 edits1 delete in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 6: Kill the rest.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/scm.py:
- Scripts/modules/webkitlandingscripts.py: Removed.
- 12:02 AM Changeset in webkit [51436] by
-
- 5 edits1 add in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Unit test upload commands
https://bugs.webkit.org/show_bug.cgi?id=31903
Adds unit tests for all but two of the upload commands. The two
remaining ones are more difficult. I'll return to them later. The
goal of these tests is just to run the commands. We can test more
detailed behavior later.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- Scripts/modules/mock.py: Added.
- Scripts/modules/mock_bugzillatool.py:
Nov 26, 2009:
- 11:56 PM Changeset in webkit [51435] by
-
- 4 edits1 add in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 5: Kill run_and_throw_if_fail.
- Scripts/modules/buildsteps.py:
- Scripts/modules/processutils.py: Added.
- Scripts/modules/webkitlandingscripts.py:
- 11:56 PM Changeset in webkit [51434] by
-
- 4 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 4: Kill run_webkit_script.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:55 PM Changeset in webkit [51433] by
-
- 4 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 3: Kill build_webkit.
- Scripts/modules/buildsteps.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:55 PM Changeset in webkit [51432] by
-
- 5 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 2: Kill ensure_builders_are_green.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:54 PM Changeset in webkit [51431] by
-
- 5 edits1 add in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py: Added.
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:51 PM Changeset in webkit [51430] by
-
- 3 edits in trunk/LayoutTests
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed red bot fix.
Skip tests introduced by the previous change as it seems to be failing.
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:11 PM Changeset in webkit [51429] by
-
- 4 edits2 adds in trunk
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966
A test case where a user drags the mouse from an empty inline
element to above texts.
- editing/selection/last-empty-inline-expected.txt: Added.
- editing/selection/last-empty-inline.html: Added.
- platform/win/Skipped:
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966
When an empty inline element is clicked, the root inline box has
no leaf children. Use the renderer of a normal child instead.
This change resolves Windows port's assertion failure in a layout test.
Also, this fixes the behavior when a user drags the mouse from an
empty inline element to above texts.
Test: editing/selection/last-empty-inline.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
- 9:59 PM Changeset in webkit [51428] by
-
- 3 edits in trunk/WebCore
2009-11-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Ignore line-height CSS property specified to push buttons on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31712
LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.
- <select>
- <input type=button>
- <input type=search>
This change addresses the <input type=button> issue with Chromium/Windows
and Chromium/Linux.
- rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
- rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().
- 9:53 PM Changeset in webkit [51427] by
-
- 2 edits2 adds4 deletes in trunk/LayoutTests
2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Eric Seidel.
Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
so that the expected results can be independent of platform differences.
https://bugs.webkit.org/show_bug.cgi?id=31580
- fast/parser/comment-in-textarea-expected.txt: Added.
- fast/parser/comment-in-textarea.html:
- fast/parser/script-tests/comment-in-textarea.js: Added.
- platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
- platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
- platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
- platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.
- 9:46 PM Changeset in webkit [51426] by
-
- 3 edits in trunk/WebCore
2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Eric Seidel.
Remove the special charset meta tag in the clipboard so that
copy-and-paste with interchange breaklines/spaces works correctly
within WebKit.
No new tests. Layout tests that involve copy-and-paste with
interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
should pass on Mac/Chromium with this fix.
- platform/chromium/ClipboardChromium.cpp:
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::documentFragment):
- 9:33 PM Changeset in webkit [51425] by
-
- 2 edits in trunk/WebCore
2009-11-26 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Eric Seidel.
Compile with QT_NO_WHEELEVENT defined.
- platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):
- 9:20 PM Changeset in webkit [51424] by
-
- 2 edits in trunk/JavaScriptCore
Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901
Reviewed by Gavin Barraclough.
Correct the logic of jneq_null. This is already covered by existing tests.
- 8:06 PM Changeset in webkit [51423] by
-
- 15 edits2 moves in trunk
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- GNUmakefile.am: Change the path for GOwnPtr.*.
- JavaScriptCore.gyp/JavaScriptCore.gyp: Remove GOwnPtr.cpp from the exclude list.
- JavaScriptCore.gypi: Change the path for GOwnPtr.*.
- wscript: Remove GOwnPtr.cpp from the exclude list.
- wtf/GOwnPtr.cpp: Removed.
- wtf/GOwnPtr.h: Removed.
- wtf/Threading.h: Change the path for GOwnPtr.h.
- wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
- wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
- wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
No new tests as there is no functional change.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the path for GOwnPtr.h.
- platform/text/TextEncoding.cpp: Ditto.
- platform/text/gtk/TextCodecGtk.cpp: Ditto.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- GNUmakefile.am: Add JavaScriptCore/wtf/gtk to the include path.
- 1:22 PM Changeset in webkit [51422] by
-
- 10 edits in trunk
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Not reviewed. Build fix: revert r51421.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Not reviewed. Build fix: revert r51421.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- 12:59 PM Changeset in webkit [51421] by
-
- 10 edits in trunk
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
- src/WebViewImpl.h:
- 12:27 PM Changeset in webkit [51420] by
-
- 5 edits2 adds in trunk
2009-11-26 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Tests that the tooltip text for an image is its dimensions.
- inspector/elements-img-tooltip-expected.txt: Added.
- inspector/elements-img-tooltip.html: Added.
2009-11-26 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Implements support for hovering over <img> src to display the height and width of that image
in a tooltip. Displays both the displayable and natural dimensions of the image.
Test: inspector/elements-img-tooltip.html
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added. (WebInspector.ElementsTreeElement.prototype._updateTitle.callback): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.getPropertiesAsync): Added.
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode): Added tooltipText argument. (WebInspector.linkifyURL): Ditto.
- 10:06 AM Changeset in webkit [51419] by
-
- 2 edits in trunk/WebCore
wx build fix after drawPattern API change.
- 8:50 AM Changeset in webkit [51418] by
-
- 8 adds in trunk/LayoutTests/fast/canvas/webgl
Missed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091
- 8:50 AM Changeset in webkit [51417] by
-
- 2 edits in trunk/WebKitTools
2009-11-26 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Adam Barth.
Remove directory prefixes from linux commands
SCM unittests can cause errors on some systems if we use absolute reference to
the commands, so directory prefixes have been removed.
- Scripts/modules/scm_unittest.py:
- 7:59 AM Changeset in webkit [51416] by
-
- 7 edits in trunk/WebCore
2009-11-26 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use an internal field instead of hidden property to speedup lookup
of entered isolated world.
Plus some inlinings.
https://bugs.webkit.org/show_bug.cgi?id=31884
Covered by layout tests + manual running of some benchmarks as
content scripts.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::setDOMWrapper):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered): (WebCore::V8IsolatedWorld::getGlobalObject):
- bindings/v8/custom/V8CustomBinding.h:
- 7:06 AM Changeset in webkit [51415] by
-
- 1 edit3 deletes in trunk/WebKit/qt
Rubber-stamped by Holger Freyther.
Removed unused ICO image plugin handler.
- Plugins/ICOHandler.cpp: Removed.
- Plugins/ICOHandler.h: Removed.
- Plugins/Plugins.pro: Removed.
- 6:34 AM Changeset in webkit [51414] by
-
- 2 edits1 move in trunk/WebCore
2009-11-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Corrects build break on Windows.
Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.
- WebCore.pro:
- platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
- 5:20 AM Changeset in webkit [51413] by
-
- 2 edits in trunk/WebCore
2009-11-26 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
https://bugs.webkit.org/show_bug.cgi?id=31877
Covered by layout tests and buildbots.
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
- 5:04 AM Changeset in webkit [51412] by
-
- 2 edits in trunk/WebCore
[Qt] Mac Plugins : Pass mouse position relative to the fake window
Reviewed by Holger Freyther.
When using off-screen rendering, we need to pass mouse events relative
to the fake window instead of the global position.
- 4:44 AM QtWebKitMirrorGuide edited by
- Mention the Math.random() problem with the test content. (diff)
- 4:33 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 4:31 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 4:26 AM QtWebKitPerformanceToolBackLog: edited by
- Fix the marking of completed items. (diff)
- 4:23 AM QtBackLog edited by
- Put the commits and date into the right column (diff)
- 4:21 AM QtBackLog edited by
- Mention the network change, and the issue that QtWebKit is using less … (diff)
- 4:18 AM QtBackLog edited by
- Complete the QtPlugin work (diff)
- 3:16 AM Changeset in webkit [51411] by
-
- 2 edits in trunk/WebCore
[Qt] Use QNetworkReply::rawHeaderPairs
https://bugs.webkit.org/show_bug.cgi?id=31826
The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.
Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:34 AM Changeset in webkit [51410] by
-
- 11 edits2 adds in trunk
[Qt] Add automatic test case for plugins that use QWidget
https://bugs.webkit.org/show_bug.cgi?id=31203
Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.
WebCore:
- rendering/RenderTreeAsText.cpp:
(WebCore::operator<<): Add special case for RenderPart
WebKitTools:
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::createPlugin):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/DumpRenderTree.pro:
LayoutTest:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/plugins/netscape-dom-access-expected.txt: Added
- platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
- platform/win/Skipped:
- plugins/qt-qwidget-plugin.html: Added.
- 2:31 AM Changeset in webkit [51409] by
-
- 6 edits in trunk
[Qt] Call Widget::setSelfVisible from hide/show
https://bugs.webkit.org/show_bug.cgi?id=31203
Call Widget::setSelfVisible from Widget::show and
Widget::hide and use isParentVisible to decide
if the widget should be shown. This way client
code can rely on isVisible.
Change PluginViewQt::show, PluginViewQt::hide to
call the base class as it is doing the right thing
now. Add an assert verify that platfomWidget and
platformPluginWidget are the same.
- manual-tests/qt/qtplugin.html: Modify manual test
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::show):
(WebCore::Widget::hide):
[Qt] Do not show the QWidget when the WebCore::Widget is hidden
https://bugs.webkit.org/show_bug.cgi?id=31203
The clipping code was making a QWidget visible even if the
WebCore::Widget was hidden. Fix the bug by calling setVisible
only if the WebCore::Widget Widget::isSelfVisible.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
(WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
(FrameLoaderClientQt::createPlugin): Hide the QWidget by default
- 2:31 AM Changeset in webkit [51408] by
-
- 2 edits in trunk/WebCore
Fix compilation of REQUEST_DEBUG debug code
https://bugs.webkit.org/show_bug.cgi?id=31850
In r47907 the single parameter KURL constructor to parse
from a WebCore::String was replaced with a two parameter
constructor. I think in this debug case parsing the urls
again is no problem and I have changed the code to use the
two parameter version.
- loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):
- 12:43 AM Changeset in webkit [51407] by
-
- 3 edits in trunk/WebCore
2009-11-26 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Pavel Feldman.
[V8] Avoid using JavaScript objects as context data
https://bugs.webkit.org/show_bug.cgi?id=31873
Change the context "data" from a JavaScript object holding the two properties type and value to
a string holding type and value separated by a comma.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::setContextDebugId): (WebCore::V8Proxy::contextDebugId):
Nov 25, 2009:
- 10:16 PM Changeset in webkit [51406] by
-
- 10 edits in trunk/WebKitTools
2009-11-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Update pywebsocket to 0.4.2
Update pywebsocket to 0.4.2
https://bugs.webkit.org/show_bug.cgi?id=31861
- pywebsocket/example/echo_client.py:
- pywebsocket/example/echo_wsh.py:
- pywebsocket/mod_pywebsocket/init.py:
- pywebsocket/mod_pywebsocket/dispatch.py:
- pywebsocket/mod_pywebsocket/msgutil.py:
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_dispatch.py:
- pywebsocket/test/test_msgutil.py:
- 7:02 PM Changeset in webkit [51405] by
-
- 4 edits2 copies in trunk/WebKitTools
2009-11-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add unit test for mark-fixed
https://bugs.webkit.org/show_bug.cgi?id=31896
- Scripts/modules/commands/commandtest.py: Added.
- Scripts/modules/commands/queries_unittest.py:
- Scripts/modules/commands/upload_unittest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/run-webkit-unittests:
- 6:25 PM Changeset in webkit [51404] by
-
- 2 edits in trunk/WebKitTools
2009-11-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool should have a mark-fixed command
https://bugs.webkit.org/show_bug.cgi?id=31853
Pretty simple stuff.
- Scripts/modules/commands/upload.py:
- 6:22 PM Changeset in webkit [51403] by
-
- 8 edits in trunk/WebKitTools
2009-11-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
'bugzilla-tool help' should only show common commands like how 'git help' does
https://bugs.webkit.org/show_bug.cgi?id=31772
I also took this opportunity to make 'help' a real Command.
Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
- Scripts/bugzilla-tool:
- change should_show_command_help to should_show_in_main_help
- Scripts/modules/commands/download.py:
- Mark commands as being shown in main help or not.
- show_in_main_help = False is not required (default is false), but it seemed to make the commands more self-documenting.
- Scripts/modules/commands/queries.py: ditto
- Scripts/modules/commands/queues.py: ditto
- Scripts/modules/commands/upload.py: ditto
- Scripts/modules/multicommandtool.py:
- Make Command hold a pointer to tool in self.tool. Most Command subclasses do not take advantage of this yet, but it was required for HelpCommand to be able to reach the tool from _help_epilog().
- Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
- Move MultiCommandTool._help_epilog to Command._help_epilog
- Move "help" logic into HelpCommand.execute()
- Change should_show_command_help to should_show_in_main_help and add a default implementation.
- Scripts/modules/multicommandtool_unittest.py:
- Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
- 4:57 PM Changeset in webkit [51402] by
-
- 6 edits in trunk
WebCore:
2009-11-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
[Chromium] Implement canSetValueAttribute in the API, the clean-up part.
https://bugs.webkit.org/show_bug.cgi?id=31894
- accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.
WebKit/chromium:
2009-11-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
[Chromium] Implement canSetValueAttribute in the API.
https://bugs.webkit.org/show_bug.cgi?id=31894
- public/WebAccessibilityObject.h: Added decl.
- src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.
- 4:51 PM Changeset in webkit [51401] by
-
- 2 edits in trunk/LayoutTests
[Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910
- platform/qt/Skipped: fast/js/global-constructors.html added.
- 4:44 PM Changeset in webkit [51400] by
-
- 3 edits3 adds in trunk
2009-11-25 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891
Fixed computation of number of elements for bound array objects.
Test: fast/canvas/webgl/index-validation.html
- fast/canvas/webgl/index-validation-expected.txt: Added.
- fast/canvas/webgl/index-validation.html: Added.
- fast/canvas/webgl/script-tests/index-validation.js: Added.
2009-11-25 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891
Fixed computation of number of elements for bound array objects.
Test: fast/canvas/webgl/index-validation.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):
- 4:41 PM Changeset in webkit [51399] by
-
- 2 edits in trunk/WebKitTools
Patch by Mark Rowe.
Reviewed by Dan Bernstein.
The buildbots are failing on Windows because when they were upgraded
to 4.0.4, Apple Application Support was not in their path. Add it to
the path to fix the buildots.
- Scripts/webkitdirs.pm:
- 4:29 PM Changeset in webkit [51398] by
-
- 2 edits in trunk/LayoutTests
[Qt] Remove a bunch of now passing fast tests from skiplist.
And add a crasher/crashed pair into skiplist.
- platform/qt/Skipped:
- 3:44 PM Changeset in webkit [51397] by
-
- 2 edits in trunk/WebCore
Update SharedScript to use eventNames() instead of EventNames()
https://bugs.webkit.org/show_bug.cgi?id=31890
Reviewed by David Levin.
- SharedScript/WebKitSharedScript.cpp:
(WebCore::LoadEventTask::performTask):
- 3:29 PM Changeset in webkit [51396] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing layoutTestController feature.
- platform/qt/Skipped:
- http/tests/cache/subresource-failover-to-network.html added.
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.
- "3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.
- 2:26 PM Changeset in webkit [51395] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests doesn't accept directories/files with --skipped=only parameter
https://bugs.webkit.org/show_bug.cgi?id=31799
Reviewed by David Kilzer.
- Scripts/run-webkit-tests: Fixed.
- 1:09 PM Changeset in webkit [51394] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-25 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
[Chromium] Unable to repost form data by hitting reload
https://bugs.webkit.org/show_bug.cgi?id=31882
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadData):
- 1:08 PM Changeset in webkit [51393] by
-
- 10 edits in trunk
2009-11-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7409331> Windows: Support closed caption in <video> element
Enable closed captions in QuickTime/Windows media engine.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
New, all through to m_qtMovie.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
Make all but the destructor private since MediaPlayer call through the media
engine interface.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):
Use handy new constants for QuickTime track types.
(QTMovieWin::hasClosedCaptions):
(QTMovieWin::setClosedCaptionsVisible):
New, closed caption support.
- platform/graphics/win/QTMovieWin.h:
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
Deal with closed caption buttons.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::shouldRenderMediaControlPart):
New, don't ask the media engine if it has closed captions unless the Safari theme will
be able to render the button.
(WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
New.
- rendering/RenderThemeWin.h:
2009-11-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7409331> Windows: Support closed caption in <video> element
- platform/win/Skipped:
Enable the closed caption test.
- 12:04 PM Changeset in webkit [51392] by
-
- 5 edits in trunk/WebCore
2009-11-25 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
MessagePorts always look remotely entangled even when closed.
https://bugs.webkit.org/show_bug.cgi?id=31698
Tests: Existing tests suffice, Chromium soak test passes now.
- bindings/v8/custom/V8CustomBinding.h: Removed kMessagePortEntangledPortIndex which is no longer used.
- bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Simplified GC code to reflect the Chromium MessagePort implementation (locallyEntangledPort() always returns false). (WebCore::GCEpilogueVisitor::visitDOMWrapper): Cleaned up epilogue code to handle the case where the port gets closed in mid-GC (due to the parent context being freed).
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::close): Now sets the closed flag. (WebCore::MessagePort::disentanglePorts): Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
- dom/MessagePort.h: Added a m_closed flag and updated isEntangled() to check it. (WebCore::MessagePort::isEntangled): Now returns false if the port has been closed. (WebCore::MessagePort::isCloned): Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).
- 12:02 PM Changeset in webkit [51391] by
-
- 3 edits in trunk/WebKitTools
2009-11-25 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Change run_command to give back stderr by default
https://bugs.webkit.org/show_bug.cgi?id=31734
Change run_command to give back stderr by default.
Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
Change the related unittest call.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 10:22 AM Changeset in webkit [51390] by
-
- 2 edits in trunk/LayoutTests
Skip test that needs structure we do not provide yet
- 10:03 AM Changeset in webkit [51389] by
-
- 4 edits in trunk/WebKit/chromium
2009-11-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[Chromium] Plumb setNeedsSiteSpecificQuirks throught WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=31878
- public/WebSettings.h: Added decl.
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setNeedsSiteSpecificQuirks): Added impl.
- src/WebSettingsImpl.h:
- 9:12 AM Changeset in webkit [51388] by
-
- 2 edits in trunk/WebCore
[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-25
Reviewed by Simon Hausmann.
Fix inline assembly, don't dereference the function pointer twice.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
- 9:02 AM Changeset in webkit [51387] by
-
- 4 edits in trunk
[Qt] Remove the Referer header when redirecting to a non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31785
Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.
This makes Qt pass two tests introduced in r50226.
WebCore:
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
LayoutTests:
- platform/qt/Skipped:
- 8:50 AM Changeset in webkit [51386] by
-
- 3 edits in trunk/WebCore
The select elements do not reflect the actual choice the user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831
Patch by Andrei Popescu <andreip@google.com> on 2009-11-25
Reviewed by Dimitri Glazkov.
Handle the drawing of the listboxes in Android code.
No new features, just fixing an Android problem. Existing layout tests are sufficient.
- platform/android/RenderThemeAndroid.cpp:
(WebCore::theme):
(WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::adjustButtonStyle):
(WebCore::RenderThemeAndroid::paintTextArea):
(WebCore::RenderThemeAndroid::adjustListboxStyle):
- platform/android/RenderThemeAndroid.h:
- 8:15 AM Changeset in webkit [51385] by
-
- 2 edits in trunk/WebCore
2009-11-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Load InspectorResource mime type from CachedResource for 304 responses
For network libraries that do not merge cache data into 304 ResourceResponses,
the mime type for cached resources is unknown.
https://bugs.webkit.org/show_bug.cgi?id=31868
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::type):
- 8:06 AM Changeset in webkit [51384] by
-
- 1 edit2 adds in trunk/WebCore
2009-11-25 Andrei Popescu <andreip@google.com>
Reviewed by Eric Seidel.
Android is missing implementation of SSL Key generator functions.
https://bugs.webkit.org/show_bug.cgi?id=31825
This change adds the PlatformBridge class to platform/android.
PlarformBridge is used to access the embedding layer for things
such as key generator, cookies, plugins, etc.
No new tests required, this is platform code.
- platform/android/PlatformBridge.h: Added.
- platform/android/SSLKeyGeneratorAndroid.cpp: Added. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
- 8:05 AM Changeset in webkit [51383] by
-
- 5 edits in trunk/WebKitTools
2009-11-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Centralize required argument parsing in Command
https://bugs.webkit.org/show_bug.cgi?id=31872
- Scripts/modules/commands/download.py: remove custom required arg message.
- Scripts/modules/commands/upload.py: ditto.
- Scripts/modules/multicommandtool.py:
- Add _parse_required_arguments.
- Pass program name off to OptionParser.
- Add name() for access to tool name.
- Add check_arguments_and_execute and make it return a return code.
- Replace a couple uses of + with %.
- Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
- 7:59 AM Changeset in webkit [51382] by
-
- 2 edits in trunk/WebCore
2009-11-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] use gst_init_check() instead of gst_init()
https://bugs.webkit.org/show_bug.cgi?id=31864
Use gst_init_check() instead of gst_init() to prevent eventual
unexpected exit of the application.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::isAvailable):
- 7:46 AM Changeset in webkit [51381] by
-
- 3 edits1 add in trunk/WebKitTools
2009-11-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
https://bugs.webkit.org/show_bug.cgi?id=31870
- Scripts/modules/commands/queries_unittest.py: Use the new class.
- Scripts/modules/multicommandtool_unittest.py: Ditto.
- Scripts/modules/outputcapture.py: Added.
- 5:01 AM Changeset in webkit [51380] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
Some tests are crashing from time to time
https://bugs.webkit.org/show_bug.cgi?id=31866
Make sure we do not notify the client of a finished load, if the
load has been cancelled, or the client is gone.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- 3:02 AM Changeset in webkit [51379] by
-
- 6 edits in trunk/WebCore
[Android] Upstream Android changes to WebCore/bridge/jni
https://bugs.webkit.org/show_bug.cgi?id=31824
Reviewed by Eric Seidel.
No new tests required as no new functionality.
- bridge/jni/jni_class.cpp:
(JavaClass::JavaClass): Add calls to delete allocated references, to avoid potential leaks.
- bridge/jni/jni_instance.cpp: Add an Android include path.
- bridge/jni/jni_instance.h: Add getter/setter for JObjectWrapper::_instance and make the JavaInstance ctor and member variables protected. Both needed for the Android port, see bug for discussion.
(JSC::Bindings::JObjectWrapper::instance): Added.
(JSC::Bindings::JObjectWrapper::setInstance): Added.
- bridge/jni/jni_runtime.cpp:
(JavaMethod::JavaMethod): Delete an allocated reference to avoid a potential leak.
- bridge/jni/jni_utility.h:
(JSC::Bindings::callJNIMethodV): Delete an allocated reference to avoid a potential leak.
- 1:40 AM QtWebKitContrib edited by
- (diff)
- 12:25 AM Changeset in webkit [51378] by
-
- 11 edits in trunk/WebCore
Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31827
Reviewed by Eric Seidel.
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class PluginRequest - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase - plugins/PluginDatabase.cpp:50
struct MimeClassInfo - plugins/PluginInfoStore.cpp:50
struct PluginInfo - plugins/PluginInfoStore.cpp:40
class RenderArena - dom/Document.cpp:1401
class RenderImageScaleData - rendering/RenderImage.cpp:149
class TableLayout - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo - rendering/RenderBlock.cpp:3590
struct FloatingObject - rendering/RenderBlock.cpp:2300
struct MaxMargin - rendering/RenderBlock.cpp:4794
class RenderMarquee - rendering/RenderLayer.cpp:3277
- plugins/PluginData.h:
- plugins/PluginDatabase.h:
- plugins/PluginMainThreadScheduler.h:
- plugins/PluginView.h:
- rendering/RenderArena.h:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderImage.cpp:
- rendering/RenderMarquee.h:
- rendering/TableLayout.h:
