Timeline
Apr 14, 2010:
- 11:49 PM April 2010 Meeting edited by
- (diff)
- 9:48 PM Changeset in webkit [57633] by
-
- 3 edits4 adds in trunk
2010-04-14 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Repaint of fixed, transformed element is broken
https://bugs.webkit.org/show_bug.cgi?id=37637
RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.
Also cache style()->position() in a local variable for performance.
Test: fast/repaint/fixed-tranformed.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
- 9:47 PM Changeset in webkit [57632] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
Reviewed by Tor Arne Vestbø.
- wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
- wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
- 9:04 PM Changeset in webkit [57631] by
-
- 8 edits in trunk
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615
specification: http://dev.w3.org/2006/waf/widgets-vmmf/
- fast/media/media-feature-wgt-view-mode.html:
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615
test: fast/media/media-feature-wgt-view-mode.html
specification: http://dev.w3.org/2006/waf/widgets-vmmf/
- css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
- page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615
test: fast/media/media-feature-wgt-view-mode.html
specification: http://dev.w3.org/2006/waf/widgets-vmmf/
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
- WebCoreSupport/ChromeClientQt.h:
- 8:37 PM Changeset in webkit [57630] by
-
- 2 edits in trunk/WebCore
2010-04-14 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix Qt build.
- bindings/js/JSNodeCustom.cpp:
- 8:34 PM Changeset in webkit [57629] by
-
- 6 edits in trunk
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622
Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.
- Api/qwebpage.cpp: (qt_wrt_setViewMode):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622
Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
- 8:17 PM Changeset in webkit [57628] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a memory leak in QScriptValue::inherits.
[Qt] QScriptValue::inherits has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37617
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::inherits):
- 8:11 PM Changeset in webkit [57627] by
-
- 16 edits in trunk
2010-04-14 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Javascript URL can be set as iframe.src via multiple DOM aliases
https://bugs.webkit.org/show_bug.cgi?id=37031
Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
- bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSElementCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::setNamedItem): (WebCore::JSNamedNodeMap::setNamedItemNS):
- bindings/js/JSNodeCustom.cpp: (WebCore::isAttrFrameSrc): (WebCore::JSNode::setNodeValue): (WebCore::JSNode::setTextContent): (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
- bindings/v8/custom/V8AttrCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback): (WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::isFrameSrc): (WebCore::V8Node::textContentAccessorSetter): (WebCore::V8Node::nodeValueAccessorSetter): (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
- dom/Attr.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
2010-04-14 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Fix frame/iframe src setting for JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=37031
- http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
- http/tests/security/xss-DENIED-iframe-src-alias.html:
- 8:07 PM Changeset in webkit [57626] by
-
- 3 edits in trunk/JavaScriptCore
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a few memory leaks in QScriptEngine.
Syntax checking caused memory leak, not all temporary variables were released.
[Qt] Syntax checking in the QtScript cause a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37610
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
- qt/api/qscriptsyntaxcheckresult.cpp: (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
- 7:58 PM Changeset in webkit [57625] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak inside QScriptEnginePrivate::makeJSValue.
QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.
[Qt] tst_QScriptValue::toString has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37598
- qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):
- 6:39 PM Changeset in webkit [57624] by
-
- 2 edits in trunk/WebCore
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
We have to check if the resource handler is cancelled before
checking the client, other case it could crash.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
- 6:06 PM Changeset in webkit [57623] by
-
- 2 edits in trunk/WebKit/qt
2010-04-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Rendering artifacts on Qt plugins when scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=37152
Because we no longer repaint the entire viewport on scroll,
we must trigger a repaint of QtPluginWidgets when their geometry changes.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 5:59 PM Changeset in webkit [57622] by
-
- 2 edits1 add in trunk/WebKitTools
2010-04-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Add some very minimal unit tests for new-run-webkit-tests. This should
be enough to catch egregious brokenness like syntax errors and import
declaration issues.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
- 5:46 PM Changeset in webkit [57621] by
-
- 6 edits in trunk/WebKit2
2010-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix horizontal scrollbar repainting
https://bugs.webkit.org/show_bug.cgi?id=37626
Make sure that the update chunk is flipped because that's what WebCore expects.
- Shared/mac/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
- Shared/mac/UpdateChunk.h: Add new createImage member function that creates a CGImageRef from the update chunk.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): Pass the right rectangle here; CoreGraphics wants it in non-flipped coordinates.
(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
Create a flipped backing store.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): Flip the update chunk.
- 5:13 PM Changeset in webkit [57620] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-12 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578
- DEPS: Pull sub deps from chromium's DEPS file
- 4:33 PM Changeset in webkit [57619] by
-
- 5 edits in trunk
Versioning.
- 4:31 PM Changeset in webkit [57618] by
-
- 1 copy in tags/Safari-533.5
New tag.
- 4:25 PM Changeset in webkit [57617] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Xan Lopez <xlopez@igalia.com>
[GTK] scrollbars/scrollbar-crash-on-refresh.html is flakey on debug bots
https://bugs.webkit.org/show_bug.cgi?id=37623
We are on a mission here, people.
- platform/gtk/Skipped:
- 4:11 PM Changeset in webkit [57616] by
-
- 5 edits2 deletes in trunk
2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614
"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).
- inspector/console-resource-errors-expected.txt: Removed.
- inspector/console-resource-errors.html: Removed.
2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614
"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- 4:01 PM Changeset in webkit [57615] by
-
- 5 edits in trunk/WebKit/win
Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
Fixes <http://webkit.org/b/37619>.
Reviewed by Steve Falkenburg.
- Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
- Interfaces/WebKit.idl: Touched to force a build.
- WebScriptWorld.cpp:
(WebScriptWorld::unregisterWorld):
- WebScriptWorld.h:
Added. Just calls through to DOMWrapperWorld::unregisterWorld.
- 3:32 PM Changeset in webkit [57614] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping fast/workers/shared-worker-frame-lifecycle.html
https://bugs.webkit.org/show_bug.cgi?id=37616
- platform/gtk/Skipped:
- 3:15 PM Changeset in webkit [57613] by
-
- 2 edits in trunk/WebCore
2010-04-14 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
Don't cache SimpleFontData* in getLastResortFallbackFont. The cached entry may be invalidated.
https://bugs.webkit.org/show_bug.cgi?id=37599
- platform/graphics/win/FontCacheWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
- 3:06 PM Changeset in webkit [57612] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping printing, I've duplicated the other printing bugs and
left this one.
https://bugs.webkit.org/show_bug.cgi?id=37613
- platform/gtk/Skipped:
- 2:53 PM Changeset in webkit [57611] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix the build
- 2:51 PM Changeset in webkit [57610] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping inspector/timeline-layout.html fails
https://bugs.webkit.org/show_bug.cgi?id=37611
- platform/gtk/Skipped:
- 2:49 PM Changeset in webkit [57609] by
-
- 5 edits2 adds in trunk
2010-04-14 Andrey Kosyakov <caseq@chromium.ru>
Reviewed by Timothy Hatcher.
Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215
- inspector/console-resource-errors-expected.txt: Added.
- inspector/console-resource-errors.html: Added.
2010-04-14 Andrey Kosyakov <caseq@chromium.ru>
Reviewed by Timothy Hatcher.
Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215
Test: inspector/console-resource-errors.html
- inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- 2:38 PM Changeset in webkit [57608] by
-
- 5 edits in trunk/JavaScriptCore
2010-04-14 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::jitCompileRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!):
- yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
- 2:24 PM Changeset in webkit [57607] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping printing/page-break-always.html
https://bugs.webkit.org/show_bug.cgi?id=37607
- platform/gtk/Skipped:
- 2:10 PM Changeset in webkit [57606] by
-
- 6 edits1 delete in trunk
2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605
"Broke Chromium build" (Requested by dglazkov on #webkit).
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
- platform/chromium/PopupMenuChromium.h:
2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605
"Broke Chromium build" (Requested by dglazkov on #webkit).
- WebKit.gyp:
- src/WebViewImpl.h:
- tests/PopupMenuTest.cpp: Removed.
- 2:08 PM Changeset in webkit [57605] by
-
- 3 edits2 adds in trunk/WebKit2
Add WKRetainPtr helper class as private header
https://bugs.webkit.org/show_bug.cgi?id=37603
Reviewed by Anders Carlsson.
WKRetainPtr is just like RetainPtr, but works for WK types instead of
CF/NS types.
- UIProcess/API/cpp: Added.
- UIProcess/API/cpp/WKRetainPtr.h: Added.
- WebKit2.xcodeproj/project.pbxproj: Add new file.
- win/WebKit2.vcproj: Ditto.
- 1:51 PM Changeset in webkit [57604] by
-
- 10 edits in trunk
2010-04-14 Aaron Boodman <aa@chromium.org>
Reviewed by David Levin.
Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.
Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
- notifications/Notification.cpp: (WebCore::Notification::Notification): Accept resolved KURL instead of relative string.
- notifications/Notification.h: (WebCore::Notification::create): Ditto. (WebCore::Notification::iconURL): Return resolved KURL instead of relative string.
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): Immediately resolve URL instead of passing off relative string. (WebCore::NotificationCenter::createNotification): Ditto.
- notifications/NotificationContents.h: (WebCore::NotificationContents::NotificationContents): Accept resolved KURL instead of relative string. (WebCore::NotificationContents::icon): Return resolved URL.
2010-04-14 Aaron Boodman <aa@chromium.org>
Reviewed by David Levin.
Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.
Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
- public/WebNotification.h: Remove deprecated icon() method.
- src/WebNotification.cpp: Ditto.
2010-04-14 Aaron Boodman <aa@chromium.org>
Reviewed by David Levin.
Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.
Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
- WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed.
- 1:39 PM Changeset in webkit [57603] by
-
- 3 edits in trunk/WebCore
2010-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton.
https://bugs.webkit.org/show_bug.cgi?id=37601
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm: (-[WebCoreFlippedView isFlipped]): (WebCore::paintButton): (WebCore::ThemeMac::ensuredView):
- 1:32 PM Changeset in webkit [57602] by
-
- 2 edits2 adds in trunk/WebKitTools
Add a way for the buildbot to kill any old processes that are running. This
is useful because the Windows bots can get in states where a process remains
running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
state, and the processes must be killed manually.
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
the old processes that might be running.
- BuildSlaveSupport/win/kill-old-processes: Added.
- 1:26 PM Changeset in webkit [57601] by
-
- 3 edits in trunk/WebKit2
Make the WebProcess a LSUIElement to suppress its icon from the Dock.
Reviewed by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Info.plist:
- 1:23 PM Changeset in webkit [57600] by
-
- 4 edits in trunk/WebKitTools
Tear down WebKit more completely on window closing and application
termination. We still don't block application termination for pending
close, but this is a step in the right direction.
Reviewed by Anders Carlsson.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate applicationWillTerminate:]):
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController dealloc]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):
- 1:21 PM Changeset in webkit [57599] by
-
- 6 edits1 add in trunk
2010-04-14 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
- platform/chromium/PopupMenuChromium.h:
2010-04-14 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436
- WebKit.gyp:
- src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
- tests/PopupMenuTest.cpp: Added.
- 1:18 PM Changeset in webkit [57598] by
-
- 2 edits in trunk/LayoutTests
Skip xss-DENIED-iframe-src-alias.html on Windows
I thought that skipping this test was causing other http tests to time
out, but Brian Weinstein pointed out that the timing-out tests come
before this one so shouldn't be affected by it.
<http://webkit.org/b/37096> tracks making this test not time out.
Rubber-stamped by Brian Weinstein.
- platform/win/Skipped:
- 1:01 PM Changeset in webkit [57597] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-14 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
Add tests for ipv6 address canonicalization.
https://bugs.webkit.org/show_bug.cgi?id=37583
- fast/url/ipv6-expected.txt: Added.
- fast/url/ipv6.html: Added.
- fast/url/script-tests/ipv6.js: Added.
- 12:44 PM PythonGuidelines edited by
- Clarified suggested import ordering style guideline. (diff)
- 12:42 PM Changeset in webkit [57596] by
-
- 3 edits in trunk/WebKit2
2010-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Factor code to paint into an update chunk out into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=37594
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::setSize):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
- 12:24 PM Changeset in webkit [57595] by
-
- 2 edits in trunk/WebCore
Remove an incorrect ASSERT in UniscribeHelper::draw().
https://bugs.webkit.org/show_bug.cgi?id=37533
Reviewed by Jian Li.
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
- 11:56 AM Changeset in webkit [57594] by
-
- 2 edits in trunk/WebCore
2010-04-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: readline shortcuts don't work in Chromium.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype._moveCaretToStartOfPrompt):
- 11:45 AM Changeset in webkit [57593] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping printing/page-break-always-for-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=37592
- platform/gtk/Skipped:
- 11:42 AM Changeset in webkit [57592] by
-
- 2 edits in trunk/WebCore
2010-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
https://bugs.webkit.org/show_bug.cgi?id=37582
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype._tabKeyPressed):
- 11:30 AM Changeset in webkit [57591] by
-
- 8 edits in trunk
2010-04-14 Jeff Schiller <codedread@gmail.com>
Reviewed by Dirk Schulze.
Update path parser test for Bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413
now that all path segments render up until the first error
- platform/mac/svg/custom/path-bad-data-expected.txt: updated path segments that render
- svg/custom/path-bad-data.svg: updated test to ensure reference image is the same
- svg/dom/fuzz-path-parser-expected.txt: updated path segments that render
- svg/dom/path-parser-expected.txt: updated path segments that render
- svg/dom/script-tests/path-parser.js: changed expected results for path segments that render ():
2010-04-14 Jeff Schiller <codedread@gmail.com>
Reviewed by Dirk Schulze.
Render SVG Paths up to first error, bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413
- svg/SVGParserUtilities.cpp: (WebCore::SVGPathSegListBuilder::build):
- 11:18 AM Changeset in webkit [57590] by
-
- 2 edits in trunk/WebCore
2010-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Ctrl-L (Clear History) does nothing on Windows
https://bugs.webkit.org/show_bug.cgi?id=37579
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
- 10:51 AM Changeset in webkit [57589] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping printing/numberOfPages.html
https://bugs.webkit.org/show_bug.cgi?id=37585
- platform/gtk/Skipped:
- 10:42 AM Changeset in webkit [57588] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Add port URL tests
https://bugs.webkit.org/show_bug.cgi?id=37524
This went pretty well.
- fast/url/port-expected.txt: Added.
- fast/url/port.html: Added.
- fast/url/script-tests/port.js: Added.
- 10:27 AM Changeset in webkit [57587] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-04-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use pretty patch for confirming webkit-patch diffs
https://bugs.webkit.org/show_bug.cgi?id=37489
- Scripts/webkitpy/common/prettypatch.py: Added.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/confirmdiff.py:
- 10:16 AM Changeset in webkit [57586] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Add LayoutTests for parsing "path" URLs
https://bugs.webkit.org/show_bug.cgi?id=37581
- fast/url/path-url-expected.txt: Added.
- fast/url/path-url.html: Added.
- fast/url/script-tests/path-url.js: Added.
- 10:06 AM Changeset in webkit [57585] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Add LayoutTests for parsing standard URLs
https://bugs.webkit.org/show_bug.cgi?id=37580
- fast/url/script-tests/standard-url.js: Added.
- fast/url/standard-url-expected.txt: Added.
- fast/url/standard-url.html: Added.
- 9:39 AM Changeset in webkit [57584] by
-
- 2 edits in trunk/LayoutTests
Roll out r57566
It seems to have caused other http tests to hang on Windows.
- platform/win/Skipped:
- 9:26 AM Changeset in webkit [57583] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-14 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Maciej Stachowiak.
Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888
When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.
Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.
Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.
- wtf/VMTags.h:
- 9:17 AM WebInspector edited by
- Fix column title, add Chrome/Chromium-specific shortcuts (diff)
- 9:08 AM Changeset in webkit [57582] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Skip some and add test expectations for other layout tests which started to fail
against Chromium after http://trac.webkit.org/changeset/57535/
- platform/chromium/test_expectations.txt:
- 8:48 AM WebInspector edited by
- Add Win/Linux shortcuts (diff)
- 8:19 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 8:10 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 8:07 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 8:02 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 7:56 AM Changeset in webkit [57581] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skipping another crash on the 64bit Gtk slave.
- platform/gtk/Skipped:
- 7:52 AM Changeset in webkit [57580] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping plugins/open-and-close-window-with-plugin.html
https://bugs.webkit.org/show_bug.cgi?id=37572
Skipping media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=37573
- platform/gtk/Skipped:
- 7:45 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 7:25 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 7:12 AM Changeset in webkit [57579] by
-
- 26 edits147 adds1 delete in trunk/LayoutTests/platform
Not reviewed.
BUG=http://code.google.com/p/chromium/issues/detail?id=41450
- 6:49 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:12 AM Changeset in webkit [57578] by
-
- 2 edits in trunk/WebCore
2010-04-14 Anton Muhin <antonm@chromium.org>
Not review, build fix.
Add <limits.h> include to bring UINT_MAX.
- html/canvas/WebGLArray.h:
- 4:11 AM Changeset in webkit [57577] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57573.
http://trac.webkit.org/changeset/57573
https://bugs.webkit.org/show_bug.cgi?id=37569
Revert r57573 which unskipped http/tests/media/video-
cookie.html on SnowLeopard Intel Release (Tests). Let's get a
core builder back to green again. (Requested by WildFox on
#webkit).
- platform/mac/Skipped:
- 4:00 AM Changeset in webkit [57576] by
-
- 2 edits in trunk/WebCore
2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to unbreak build - NodeRenderStyle.h is an _interessting_ concept...
- rendering/style/SVGRenderStyle.cpp: Include 'NodeRenderStyle.h'
- 3:44 AM Changeset in webkit [57575] by
-
- 14 edits in trunk/WebCore
2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
https://bugs.webkit.org/show_bug.cgi?id=37568
Cleanup SVGRenderStyle / SVGRenderStyleDefs:
- use copy constructors in initialization list to initialize members, instead of assignment operators in the body
- fix style issues (misplaced references, abbrevations)
- merge StyleClipData/StyleMaskData to save memory, rename it StyleResourceData
- move filter property in StyleResourceData
- rename StyleMarkerData to StyleInheritedResourceData to highlight the difference to StyleResourceData
- unify naming schemes for all resources (filter/clipper/masker/markers)
- clipPath() -> clipperResource()
- maskElement() -> maskerResource()
- startMarker() -> markerStartResource()
- midMarker() -> markerMidResource()
- endMarker() -> markerEndResource()
- filter() -> filterResource()
Adapt all callsites to the renames above.
No new tests, as this doesn't affect anything except memory overhead.
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::deregisterFromResources):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeResources):
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle): (WebCore::SVGRenderStyle::operator==): (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
- rendering/style/SVGRenderStyle.h:
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==): (WebCore::StyleStopData::StyleStopData): (WebCore::StyleStopData::operator==): (WebCore::StyleTextData::StyleTextData): (WebCore::StyleMiscData::StyleMiscData): (WebCore::StyleMiscData::operator==): (WebCore::StyleShadowSVGData::StyleShadowSVGData): (WebCore::StyleShadowSVGData::operator==): (WebCore::StyleResourceData::StyleResourceData): (WebCore::StyleResourceData::operator==): (WebCore::StyleInheritedResourceData::StyleInheritedResourceData): (WebCore::StyleInheritedResourceData::operator==):
- rendering/style/SVGRenderStyleDefs.h: (WebCore::StyleFillData::operator!=): (WebCore::StyleStopData::operator!=): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy): (WebCore::StyleMiscData::operator!=): (WebCore::StyleShadowSVGData::create): (WebCore::StyleShadowSVGData::copy): (WebCore::StyleShadowSVGData::operator!=): (WebCore::StyleResourceData::create): (WebCore::StyleResourceData::copy): (WebCore::StyleResourceData::operator!=): (WebCore::StyleInheritedResourceData::create): (WebCore::StyleInheritedResourceData::copy): (WebCore::StyleInheritedResourceData::operator!=):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- 3:23 AM Changeset in webkit [57574] by
-
- 9 edits2 adds in trunk
2010-04-14 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718
- fast/canvas/webgl/read-pixels-expected.txt: Verify pixelStorei and readPixels.
- fast/canvas/webgl/read-pixels.html: Ditto.
2010-04-14 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718
Test: fast/canvas/webgl/read-pixels.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init members to support pack_alignment. (WebCore::WebGLRenderingContext::pixelStorei): Save pack/unpack_alignment. (WebCore::WebGLRenderingContext::readPixels): Validate enum and deal with pack_alignment.
- html/canvas/WebGLRenderingContext.h: Add members to support pack_alignment.
- platform/graphics/GraphicsContext3D.h: Refactor readPixels.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
2010-04-14 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718
- src/GraphicsContext3D.cpp: Refactor readPixels.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
- 3:11 AM Changeset in webkit [57573] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Nicolas Weber <thakis@chromium.org>
Reviewed by Gustavo Noronha Silva.
Remove passing test from Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=34287
- platform/mac/Skipped: video-cookie.html seems to be passing, so remove it from Skipped list.
- 2:00 AM Changeset in webkit [57572] by
-
- 6 edits in trunk/WebKitTools
2010-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach webkit-patch how to handle revisions missing ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=37519
Make commit_info_for_revision return None when revision
is missing a ChangeLog. Previously we would throw an array index
exception.
Teach callers how to handle None.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- 1:51 AM Changeset in webkit [57571] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Re-write testProfilerTab to match the new implementation.
- src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab):
- 12:34 AM Changeset in webkit [57570] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping media/audio-data-url.html
https://bugs.webkit.org/show_bug.cgi?id=37564
- platform/gtk/Skipped:
- 12:15 AM Changeset in webkit [57569] by
-
- 2 edits in trunk/LayoutTests
2010-04-14 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping plugins/update-widgets-crash.html
https://bugs.webkit.org/show_bug.cgi?id=37562
- platform/gtk/Skipped:
- 12:03 AM Changeset in webkit [57568] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping media/video-seeking.html
https://bugs.webkit.org/show_bug.cgi?id=37551
Skipping media/video-timeupdate-reverse-play.html
https://bugs.webkit.org/show_bug.cgi?id=37552
Skipping media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=37556
Skipping http/tests/misc/image-blocked-src-change.html
https://bugs.webkit.org/show_bug.cgi?id=37557
Skipping inspector/console-clear.html
https://bugs.webkit.org/show_bug.cgi?id=37558
Skipping inspector/console-format-collections.html
https://bugs.webkit.org/show_bug.cgi?id=37559
Skipping svg/dom/SVGScriptElement/script-set-href.svg
https://bugs.webkit.org/show_bug.cgi?id=37560
- platform/gtk/Skipped:
Apr 13, 2010:
- 11:36 PM Changeset in webkit [57567] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping svg/custom/use-instanceRoot-as-event-target.xhtml
https://bugs.webkit.org/show_bug.cgi?id=37544
Skipping plugins/setProperty.html
https://bugs.webkit.org/show_bug.cgi?id=37545
Skipping media/audio-delete-while-slider-thumb-clicked.html
https://bugs.webkit.org/show_bug.cgi?id=37546
Skipping media/video-currentTime-set2.html
https://bugs.webkit.org/show_bug.cgi?id=37547
Skipping media/video-seekable.html
https://bugs.webkit.org/show_bug.cgi?id=37548
Skipping media/video-currentTime-set.html
https://bugs.webkit.org/show_bug.cgi?id=37549
Skipping fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=37550
Skipping media/video-seeking.html
https://bugs.webkit.org/show_bug.cgi?id=37551
Skipping media/video-timeupdate-reverse-play.html
https://bugs.webkit.org/show_bug.cgi?id=37552
- platform/gtk/Skipped:
- 11:22 PM Changeset in webkit [57566] by
-
- 2 edits in trunk/LayoutTests
Skip xss-DENIED-iframe-src-alias.html on Windows
<http://webkit.org/b/37096> tracks making this test not time out.
Reviewed by Eric Seidel.
- platform/win/Skipped:
- 11:13 PM Changeset in webkit [57565] by
-
- 2 edits in trunk/LayoutTests
Update Windows results for text-control-intrinsic-widths.html
<http://webkit.org/b/37091> tracks deciding whether these results are
better than the previous ones or not.
Reviewed by Eric Seidel.
- platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
- 11:12 PM Changeset in webkit [57564] by
-
- 2 edits in trunk/WebCore
2010-04-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(r57511): many new graphics / svg related leaks
https://bugs.webkit.org/show_bug.cgi?id=37527
The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient):
- 11:12 PM Changeset in webkit [57563] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows failing results for mouse-drag-from-frame-to-other-frame.html
<http://webkit.org/b/37494> tracks fixing this test.
Reviewed by Eric Seidel.
- platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Added.
- 11:11 PM Changeset in webkit [57562] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows failing results for font-face-opentype.html
<http://webkit.org/b/37089> tracks fixing this test.
Reviewed by Eric Seidel.
- platform/win/fast/css/font-face-opentype-expected.txt: Added.
- 11:09 PM Changeset in webkit [57561] by
-
- 3 edits in trunk/WebKitTools
2010-04-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
https://bugs.webkit.org/show_bug.cgi?id=33297
This is an experiment. The bots have been green for
a while. We'll see if adding them under sheriff-bot protection
will keep them green.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 10:56 PM Changeset in webkit [57560] by
-
- 3 edits in trunk/LayoutTests
2010-04-13 Darin Fisher <darin@chromium.org>
Update skipped lists for failing tests:
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html
- platform/mac-tiger/Skipped:
- platform/qt/Skipped:
- 10:29 PM Changeset in webkit [57559] by
-
- 12 edits in trunk
2010-04-13 Zhenyao Mo <zmo@google.com>
Reviewed by Oliver Hunt.
Fix a potential integer overflow in WebGL*Array::slice()
https://bugs.webkit.org/show_bug.cgi?id=37466
- fast/canvas/webgl/array-unit-tests-expected.txt: Add tests that would cause overflow without this fix, but work fine with this fix.
- fast/canvas/webgl/array-unit-tests.html: Ditto.
2010-04-13 Zhenyao Mo <zmo@google.com>
Reviewed by Oliver Hunt.
Fix a potential integer overflow in WebGL*Array::slice()
https://bugs.webkit.org/show_bug.cgi?id=37466
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::clampOffsetAndNumElements): Input parameter "offset"'s semantic changed from in bytes from buffer to in elements from array view; calculate offset in bytes from buffer inside the function, avoiding overflow.
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::slice): Changed according to new semantic of WebCore::WebGLArray::clampOffsetAndNumElements.
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::slice): Ditto.
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::slice): Ditto.
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::slice): Ditto.
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::slice): Ditto.
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::slice): Ditto.
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::slice): Ditto.
- 9:52 PM Changeset in webkit [57558] by
-
- 6 edits4 adds in trunk
2010-04-13 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
If the browsing context's session history contains only one Document,
and that was the about:blank Document created when the browsing context
was created, then the navigation must be done with replacement enabled.
Tests: fast/loader/frame-location-change-not-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::findFrameForNavigation):
- loader/HistoryController.cpp: (WebCore::HistoryController::currentItemShouldBeReplaced):
- loader/HistoryController.h:
- 9:29 PM Changeset in webkit [57557] by
-
- 2 edits in trunk/WebKitTools
2010-04-13 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing a constant in the Rietveld unit test.
- Scripts/webkitpy/common/net/rietveld_unittest.py
- 9:12 PM Changeset in webkit [57556] by
-
- 2 edits in trunk/WebKitTools
2010-04-13 Eric Seidel <eric@webkit.org>
Unreviewed, just adding missing Mock to fix python tests.
- Scripts/webkitpy/tool/mocktool.py:
- 5:29 PM Changeset in webkit [57555] by
-
- 8 edits in trunk
Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
its own lifetime, so a DOMWrapperWorld's controller can throw away
its wrappers even before its refcount reaches 0.
Reviewed by Oliver Hunt.
WebCore:
- WebCore.base.exp:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::registerWorld):
(WebCore::DOMWrapperWorld::unregisterWorld):
- bindings/js/DOMWrapperWorld.h: Factored out DOMWrapperWorld registration
and unregistration into helper functions, so unregistering could be done manually.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::destroyWindowShell): Added an ASSERT to match
similar code.
WebKit/mac:
- WebView/WebScriptWorld.h:
- WebView/WebScriptWorld.mm:
(-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.
- 5:28 PM Changeset in webkit [57554] by
-
- 2 edits in trunk/LayoutTests
Update the test results after r57544.
- http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt:
- 5:25 PM Changeset in webkit [57553] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Skipping fast/js/kde/string-1-n.html,
See https://bugs.webkit.org/show_bug.cgi?id=37532
Skipping fast/js/kde/string-2-n.html.
https://bugs.webkit.org/show_bug.cgi?id=37534
Skipping inspector/console-format.html
https://bugs.webkit.org/show_bug.cgi?id=37535
Skipping media/video-reverse-play-duration.html
https://bugs.webkit.org/show_bug.cgi?id=37536
Skipping plugins/round-trip-npobject.html
https://bugs.webkit.org/show_bug.cgi?id=37537
Skipping svg/custom/use-on-clip-path-with-transformation.svg
https://bugs.webkit.org/show_bug.cgi?id=37539
Skipping http/tests/security/xss-DENIED-mime-type-execute-as-html.html
https://bugs.webkit.org/show_bug.cgi?id=37540
- platform/gtk/Skipped:
- 5:23 PM Changeset in webkit [57552] by
-
- 11 edits1 copy2 adds in trunk/WebKitTools
2010-04-13 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
Add experimental prototype Rietveld integration to webkit-patch upload
https://bugs.webkit.org/show_bug.cgi?id=37418
This patch adds bare-bones integrtion with Rietveld for code reviews.
The behavior is hidden behind the --fancy-review command line flag.
Currently, there's no support for uploading more than one patch per
issue (which is a nice feature of Rietveld). The plan is to play with
this for a bit and see if it's useful.
Modified from Adam's original patch to autoinstall the rietveld upload script.
- Scripts/webkitpy/common/config/init.py:
- Scripts/webkitpy/common/net/rietveld.py: Added.
- Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/options.py:
- Scripts/webkitpy/tool/steps/postcodereview.py: Added.
- Scripts/webkitpy/tool/steps/postdiff.py:
- 5:22 PM Changeset in webkit [57551] by
-
- 1 edit1 add in trunk/WebKitTools
Add Makefile to MiniBrowser.
Rubber-stamped by Mark Rowe.
- MiniBrowser/Makefile: Added.
- 4:54 PM Changeset in webkit [57550] by
-
- 3 edits in trunk/WebKitTools
2010-04-13 Eric Seidel <eric@webkit.org>
Unreviewed, just adding a sanity check.
Add check to make sure commit-queue can never commit too short a message
https://bugs.webkit.org/show_bug.cgi?id=37528
The commit-queue made bogus messages here:
http://trac.webkit.org/changeset/57532
http://trac.webkit.org/changeset/57534
This was a regression caused by adding unicode parsing for
our ChangeLog files. Popen does not seem to play nice with
unicode strings.
I'm also adding an "assert" to make sure short ChangeLogs never happen again.
- Scripts/webkitpy/common/system/executive.py:
- Cast input to strings before passing to POpen
- Scripts/webkitpy/tool/steps/commit.py:
- Validate that commit messages are not to short.
- 4:51 PM Changeset in webkit [57549] by
-
- 4 edits in trunk/WebKit2
Fix reported leaks when quitting MiniBrowser with open pages.
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.h: Make close() public.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::didClose): If the UIProcess disappears, close
the live pages in an effort to not leak.
- WebProcess/WebProcess.h:
- 4:30 PM Changeset in webkit [57548] by
-
- 5 edits in trunk/WebKit2
Do a JS collection and clear the memory cache to improve leaks output
when exiting. Only do this in debug builds as it is slow.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.h:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shutdown):
(WebKit::WebProcess::didClose):
- 4:29 PM April 2010 Meeting edited by
- (diff)
- 4:22 PM Changeset in webkit [57547] by
-
- 2 edits in trunk/WebKit2
Post a null event after calling [NSApp stop] to flush the run loop
and finish teardown.
Reviewed by Adele Peterson.
- Platform/mac/RunLoopMac.mm:
(RunLoop::stop):
- 4:20 PM CommitterTips edited by
- (diff)
- 4:19 PM Changeset in webkit [57546] by
-
- 2 edits in trunk/WebKitTools
Robustify new-run-webkit-tests against paths with spaces in them
Reviewed by Eric Seidel.
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
(LayoutTestApacheHttpd.init): Quote all paths that we pass to
Apache to ensure that paths with spaces in them are interpreted
correctly.
- 4:04 PM Changeset in webkit [57545] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed fix, update platform specific expected file after r57534.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
- 3:58 PM Changeset in webkit [57544] by
-
- 5 edits2 adds in trunk
2010-04-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Fisher.
Based on W3C spec and Firefox behavior, while invoking XHR Send with parameter
as String, the charset in Content-Type should be forced to set to UTF-8.
Test: http/tests/xmlhttprequest/request-encoding2.html
- platform/network/HTTPParsers.cpp: (WebCore::extractCharsetFromMediaType): (WebCore::findCharsetInMediaType):
- platform/network/HTTPParsers.h:
- xml/XMLHttpRequest.cpp: (WebCore::setCharsetInMediaType): (WebCore::XMLHttpRequest::send):
2010-04-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Fisher.
Added test for forcing UTF-8 charset.
https://bugs.webkit.org/show_bug.cgi?id=34653
- http/tests/xmlhttprequest/request-encoding2-expected.txt: Added.
- http/tests/xmlhttprequest/request-encoding2.html: Added.
- 3:55 PM Changeset in webkit [57543] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Skipping more new tests, we still do not have results. Remove test
that does not exist anymore:
svg/custom/clip-path-display-none-child.svg
- platform/gtk/Skipped:
- 3:50 PM Changeset in webkit [57542] by
-
- 2 edits in trunk/WebKitTools
Unreviewed buildfix after r57537.
- DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
- 3:44 PM Changeset in webkit [57541] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Skipping fast/history/multiple-classes-visited.html test,
See https://bugs.webkit.org/show_bug.cgi?id=37526
- platform/gtk/Skipped:
- 3:43 PM Changeset in webkit [57540] by
-
- 3 edits1 copy in trunk/WebKitTools
Make building new webkit API and MiniBrowser a little easier.
Reviewed by Maciej Stachowiak.
- Scripts/build-webkit: Make building with --webkit2 build the
MiniBrowser as well and tell you how to use it.
- Scripts/run-minibrowser: Copied from Scripts/run-safari.
- Scripts/webkitdirs.pm: Add runMiniBrowser function.
- 3:34 PM Changeset in webkit [57539] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r57530, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()
- platform/qt/Skipped:
- storage/statement-error-callback-isolated-world.html skipped.
- storage/statement-success-callback-isolated-world.html skipped.
- storage/transaction-callback-isolated-world.html skipped.
- storage/transaction-error-callback-isolated-world.html skipped.
- 3:31 PM Changeset in webkit [57538] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Skipping new tests, we still do not have results.
- platform/gtk/Skipped:
- 3:23 PM Changeset in webkit [57537] by
-
- 24 edits2 adds in trunk
SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449
Reviewed by Dave Hyatt.
WebCore:
Test: http/tests/xmlhttprequest/origin-whitelisting-removal.html
- WebCore.base.exp: Added SecurityOrigin::removeOriginAccessWhitelistEntry.
- page/OriginAccessEntry.h:
(WebCore::OriginAccessEntry::protocol): Added. Returns m_protocol.
(WebCore::OriginAccessEntry::host): Added. Returns m_host.
(WebCore::OriginAccessEntry::subdomainSettings): Added. Returns m_subdomainSettings.
(WebCore::operator==): Added. Compares OriginAccessEntry.
(WebCore::operator!=): Ditto.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): Use the add method to prevent a
second hash lookup.
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry): Added. Find a matching
OriginAccessEntry and remove it.
- page/SecurityOrigin.h: Added removeOriginAccessWhitelistEntry.
WebKit/mac:
- WebView/WebView.mm:
(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
Call SecurityOrigin::removeOriginAccessWhitelistEntry.
- WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
- WebView.h: Added removeOriginAccessWhitelistEntry.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
(LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::removeOriginAccessWhitelistEntry): Added.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeOriginAccessWhitelistEntry): Added.
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
LayoutTests:
- http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-removal.html: Added.
- platform/gtk/Skipped: Added origin-whitelisting-removal.html.
- platform/qt/Skipped: Ditto.
- 3:23 PM Changeset in webkit [57536] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
Make Joseph Pecoraro a reviewer.
- 3:15 PM Changeset in webkit [57535] by
-
- 40 edits in trunk
Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449
Reviewed by Dave Hyatt.
WebCore:
- WebCore.base.exp:
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::resetOriginAccessWhitelists):
- page/SecurityOrigin.h:
WebKit/chromium:
- src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
(WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
WebKit/gtk:
- webkit/webkitprivate.cpp:
(webkit_white_list_access_from_origin):
(webkit_reset_origin_access_white_lists):
WebKit/mac:
- WebView/WebView.mm:
(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):
- WebView/WebViewPrivate.h:
WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::addOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):
- WebView.h:
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(addOriginAccessWhitelistEntryCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::addOriginAccessWhitelistEntry):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::addOriginAccessWhitelistEntry):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
LayoutTests:
- http/tests/security/local-image-from-remote-whitelisted-expected.txt:
- http/tests/security/local-image-from-remote-whitelisted.html:
- http/tests/xmlhttprequest/origin-whitelisting-all.html:
- http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
- http/tests/xmlhttprequest/origin-whitelisting-https.html:
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html:
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
- http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:
- 3:01 PM Changeset in webkit [57534] by
-
- 2 edits in trunk/LayoutTests
2
- 2:59 PM Changeset in webkit [57533] by
-
- 6 edits in trunk/WebCore
Tidied up some more DOMWrapperWorld lifetime issues.
Reviewed by Mark Rowe.
Made DOMWrapperWorld aware of its JSDOMWindowShells, so it can clear them.
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::didCreateWindowShell):
(WebCore::DOMWrapperWorld::didDestroyWindowShell): Functionality for
tracking window shells that reference a given DOMWrapperWorld.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
- bindings/js/ScriptController.h: Refactored to update a DOMWrapperWorld
when adding or removing a JSDOMWindowShell.
- dom/Document.cpp:
(WebCore::Document::destroyAllWrapperCaches): Changed to use isEmpty(),
which is slightly faster and simpler than iterator comparison.
- 2:51 PM Changeset in webkit [57532] by
-
- 2 edits in trunk/WebKitTools
2
- 2:28 PM Changeset in webkit [57531] by
-
- 3 edits in trunk/WebKitTools
2010-04-13 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
the commit-queue hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37511
We were failing to read reviewers out of ChangeLogs
when the reviewer has unicode characters in his/her name.
I fixed this by explicitly decoding from utf8 every time we
read in a ChangeLog file (they are always UTF8).
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- 2:19 PM Changeset in webkit [57530] by
-
- 26 edits8 adds in trunk
WebCore: Make all HTML5 DB callbacks run in the correct context.
https://bugs.webkit.org/show_bug.cgi?id=27698
Reviewed by Adam Barth.
Tests: storage/statement-error-callback-isolated-world.html
storage/statement-success-callback-isolated-world.html
storage/transaction-callback-isolated-world.html
storage/transaction-error-callback-isolated-world.html
- bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.h:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.h:
- bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.h:
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
(WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
(WebCore::V8CustomSQLStatementCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementCallback.h:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
(WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
(WebCore::V8CustomSQLTransactionCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
(WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
- storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
(WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):
LayoutTests: Test that the HTML5 DB callbacks run in the correct context.
https://bugs.webkit.org/show_bug.cgi?id=27698
Reviewed by Adam Barth.
- storage/statement-error-callback-isolated-world-expected.txt: Added.
- storage/statement-error-callback-isolated-world.html: Added.
- storage/statement-success-callback-isolated-world-expected.txt: Added.
- storage/statement-success-callback-isolated-world.html: Added.
- storage/transaction-callback-isolated-world-expected.txt: Added.
- storage/transaction-callback-isolated-world.html: Added.
- storage/transaction-error-callback-isolated-world-expected.txt: Added.
- storage/transaction-error-callback-isolated-world.html: Added.
- 1:14 PM BuildingQtOnLinux edited by
- (diff)
- 1:13 PM BuildingQtOnLinux edited by
- (diff)
- 12:14 PM Changeset in webkit [57529] by
-
- 4 edits in trunk
2010-04-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix search behavior in Profiles tab.
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView):
2010-04-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix search behavior in Heap profiles.
- src/js/HeapProfilerPanel.js:
- 11:58 AM Changeset in webkit [57528] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37513, clean up StyleBoxData and the RenderStyle variable that uses it.
Reviewed by Oliver Hunt.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::width):
(WebCore::InheritedFlags::height):
(WebCore::InheritedFlags::minWidth):
(WebCore::InheritedFlags::maxWidth):
(WebCore::InheritedFlags::minHeight):
(WebCore::InheritedFlags::maxHeight):
(WebCore::InheritedFlags::verticalAlignLength):
(WebCore::InheritedFlags::boxSizing):
(WebCore::InheritedFlags::setWidth):
(WebCore::InheritedFlags::setHeight):
(WebCore::InheritedFlags::setMinWidth):
(WebCore::InheritedFlags::setMaxWidth):
(WebCore::InheritedFlags::setMinHeight):
(WebCore::InheritedFlags::setMaxHeight):
(WebCore::InheritedFlags::setVerticalAlignLength):
(WebCore::InheritedFlags::hasAutoZIndex):
(WebCore::InheritedFlags::setHasAutoZIndex):
(WebCore::InheritedFlags::zIndex):
(WebCore::InheritedFlags::setZIndex):
(WebCore::InheritedFlags::setBoxSizing):
- rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):
- rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
(WebCore::StyleBoxData::zIndex):
(WebCore::StyleBoxData::hasAutoZIndex):
(WebCore::StyleBoxData::boxSizing):
- 11:28 AM WikiStart edited by
- (diff)
- 11:17 AM Changeset in webkit [57527] by
-
- 4 edits in trunk/WebCore
Minor fix to pass RenderProgress instead of RenderObject
https://bugs.webkit.org/show_bug.cgi?id=37481
Reviewed by Tor Arne Vestbo.
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityProgressIndicator.cpp:
- accessibility/AccessibilityProgressIndicator.h:
- 11:10 AM Changeset in webkit [57526] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37510, clean up StyleBackgroundData
Reviewed by Oliver Hunt.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::hasBackground):
(WebCore::InheritedFlags::hasBackgroundImage):
(WebCore::InheritedFlags::hasFixedBackgroundImage):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyle):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::accessBackgroundLayers):
(WebCore::InheritedFlags::backgroundLayers):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::resetOutline):
(WebCore::InheritedFlags::setBackgroundColor):
(WebCore::InheritedFlags::setBackgroundXPosition):
(WebCore::InheritedFlags::setBackgroundYPosition):
(WebCore::InheritedFlags::setBackgroundSize):
(WebCore::InheritedFlags::setBackgroundSizeLength):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::clearBackgroundLayers):
(WebCore::InheritedFlags::inheritBackgroundLayers):
(WebCore::InheritedFlags::setOutlineOffset):
- rendering/style/StyleBackgroundData.h:
(WebCore::StyleBackgroundData::background):
(WebCore::StyleBackgroundData::color):
(WebCore::StyleBackgroundData::outline):
- 11:04 AM Changeset in webkit [57525] by
-
- 2 edits in trunk/WebKitTools
Revert r57523
- 11:00 AM Changeset in webkit [57524] by
-
- 2 edits in trunk/WebKitTools
Fix run-webkit-tests on Windows with spaces in the path
Fixes <http://webkit.org/b/37509>.
Reviewed by Steve Falkenburg.
- Scripts/run-webkit-tests:
(convertPathUsingCygpath): Remove spaces from the path before passing
them to cygpath, then add them back in after conversion, as some
versions of cygpath seem to convert spaces into newlines.
- 10:59 AM Changeset in webkit [57523] by
-
- 2 edits in trunk/WebKitTools
Revert "run-webkit-tests should respect argument order"
This reverts commit adc7db320e18d5a866dbf63a2ed7192471c86c85.
- 10:46 AM Changeset in webkit [57522] by
-
- 2 edits in trunk/WebCore
2010-04-13 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Use the system clipboard instead of a private clipboard.
Fix various problems in the previous implementation.
No new tests needed.
- platform/haiku/PasteboardHaiku.cpp:
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::generalPasteboard):
- Don't leak the pasteboard at program exit.
(WebCore::AutoClipboardLocker::AutoClipboardLocker):
(WebCore::AutoClipboardLocker::~AutoClipboardLocker):
(WebCore::AutoClipboardLocker::isLocked):
- helper class for locking a BClipboard.
(WebCore::Pasteboard::writeSelection):
- Use AddData(B_MIME_TYPE) as required by clipboard protocol.
- Make sure we don't end up with unwanted UTF-8 characters for regular line breaks.
(WebCore::Pasteboard::writePlainText):
- Use AddData(B_MIME_TYPE) as required by clipboard protocol.
(WebCore::Pasteboard::plainText):
- Use FindData(B_MIME_TYPE) as required by clipboard protocol.
(WebCore::Pasteboard::documentFragment):
- Implemented.
(WebCore::Pasteboard::writeURL):
- Needs to use AddData(B_MIME_TYPE) instead of AddString().
(WebCore::Pasteboard::clear):
- 10:20 AM Changeset in webkit [57521] by
-
- 3 edits in trunk/WebCore
2010-04-13 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Fix bridging Widget to native top-level BView.
https://bugs.webkit.org/show_bug.cgi?id=37419
In the Haiku port, there is no mapping between native widgets
and WebCore Widget instances. There is only a top-level BView
which renders a web page into a bitmap. For certain WebCore widget
functionality, we need to access this BView, like for setting the
current cursor or forcing focus. On the other hand, setting a
platform widget pointer on Widget results into completely different
behavior, like ScrollView tries to forward everything instead of
handling stuff itself. To make this work, the pointer to a "top-level"
BView is stored in every Widget for the Haiku port.
No new tests needed.
- platform/Widget.h:
- Added the m_topLevelPlatformWidget member for the Haiku platform.
(WebCore::Widget::setPlatformWidget):
(WebCore::Widget::topLevelPlatformWidget):
(WebCore::Widget::setTopLevelPlatformWidget):
- platform/haiku/WidgetHaiku.cpp:
(WebCore::AutoPlatformWidgetLocker::AutoPlatformWidgetLocker):
(WebCore::AutoPlatformWidgetLocker::~AutoPlatformWidgetLocker):
(WebCore::AutoPlatformWidgetLocker::isLocked):
- helper class for locking the BView looper thread with a timeout
(WebCore::Widget::Widget):
(WebCore::Widget::setFocus):
- Make sure the top-level view receives keyboard input.
(WebCore::Widget::setCursor):
- Set the cursor on the top-level view.
(WebCore::Widget::show):
(WebCore::Widget::hide):
- Don't show/hide the top-level view, but make the code correct for whenever we would map an individual BView per Widget.
- Use setSelfVisible() and isParentVisible() like in other ports.
- 10:08 AM Changeset in webkit [57520] by
-
- 4 edits in trunk
2010-04-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by David Levin.
Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
No new tests as there is no new functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.
2010-04-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by David Levin.
Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
- src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
- 9:49 AM Changeset in webkit [57519] by
-
- 2 edits in trunk/WebCore
2010-04-13 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add a null ptr check for m_popupClient.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::abandon): Add a null ptr check
- 9:42 AM April 2010 Meeting edited by
- (diff)
- 8:56 AM Changeset in webkit [57518] by
-
- 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
2010-04-13 William Siegrist <wsiegrist@apple.com>
Add a temporary bot to test new-run-webkit-tests
- 8:52 AM Mobile Features Talk edited by
- (diff)
- 8:51 AM Mobile Features Talk edited by
- (diff)
- 8:45 AM Mobile Features Talk edited by
- (diff)
- 8:44 AM Mobile Features Talk edited by
- (diff)
- 8:41 AM Mobile Features Talk edited by
- (diff)
- 8:41 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 8:38 AM Mobile Features Talk created by
- 8:36 AM April 2010 Meeting edited by
- (diff)
- 8:31 AM Changeset in webkit [57517] by
-
- 2 edits in trunk/WebCore
2010-04-13 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Use the system's default font family as last fall back font.
https://bugs.webkit.org/show_bug.cgi?id=37501
No new tests needed.
- platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- Use the system's default font family (from be_plain_font global).
- 8:21 AM Changeset in webkit [57516] by
-
- 2 edits in trunk/WebCore
2010-04-13 Eskil Blomfeldt <eblomfel@trolltech.com>, Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Use integer pixel metric QFont API to fix rounding errors in text rendering on the Mac
https://bugs.webkit.org/show_bug.cgi?id=36532
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::floatWidthForComplexText): (WebCore::Font::font):
- 8:11 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 7:54 AM Changeset in webkit [57515] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed fix, platform specific expected file updated after r57511.
- platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: updated.
- 7:50 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 7:36 AM Changeset in webkit [57514] by
-
- 2 edits in trunk/WebCore
2010-04-13 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Cannot effectively delete properties in the Styles sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=37499
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):
- 7:17 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:49 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:45 AM Changeset in webkit [57513] by
-
- 2 edits in trunk/WebCore
2010-04-13 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Use the Haiku MIME type data base as a fall back for unknown file extensions.
https://bugs.webkit.org/show_bug.cgi?id=34686
Covered by existing tests.
- platform/haiku/MIMETypeRegistryHaiku.cpp:
(WebCore::):
- fixed coding style issues
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- fall back to the system MIME database for unknown types.
- return empty String as last resort, this is used elsewhere as indicator for unknown types.
- 6:36 AM Changeset in webkit [57512] by
-
- 2 edits in trunk/WebCore
2010-04-13 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Use all the new system cursors available in recent Haiku revisions.
<https://bugs.webkit.org/show_bug.cgi?id=37385>
Covered by existing tests.
- platform/haiku/CursorHaiku.cpp:
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
- Adapted to maintain an owned BCursor instance.
(WebCore::createCursorByID):
- helper function to create a Cursor instance by BCursorID constant.
(WebCore::pointerCursor):
- NULL BCursor triggers using the system cursor.
(WebCore::moveCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
- Use the new system cursors.
- 5:45 AM Changeset in webkit [57511] by
-
- 28 edits130 adds1 delete in trunk
2010-04-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
<clipPath> doesn't correctly handle <text> elements
https://bugs.webkit.org/show_bug.cgi?id=12571
Adds support for text elements as clipPath, heterogenous clip rules, as well
as clipping of clipPath.
A fast code path let platforms clip simple shapes directly. All other variants
are drawn to a seperate ImageBuffer, which is used as a mask. This happens the same
way we like we do it on SVG Masking. This needs temporary changes to the RenderStyle
of clipPath childs. Values like stroke, resources, opacity have to be ignored.
Tests: svg/clip-path/clip-path-child-clipped.svg
svg/clip-path/clip-path-childs-clipped.svg
svg/clip-path/clip-path-clipped-evenodd-twice.svg
svg/clip-path/clip-path-clipped-no-content.svg
svg/clip-path/clip-path-clipped-nonzero.svg
svg/clip-path/clip-path-clipped.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-evenodd.svg
svg/clip-path/clip-path-nonzero-evenodd.svg
svg/clip-path/clip-path-nonzero.svg
svg/clip-path/clip-path-objectBoundingBox.svg
svg/clip-path/clip-path-on-clipped-use.svg
svg/clip-path/clip-path-on-g-and-child.svg
svg/clip-path/clip-path-on-g.svg
svg/clip-path/clip-path-on-svg-and-child.svg
svg/clip-path/clip-path-on-svg.svg
svg/clip-path/clip-path-recursive-call-by-child.svg
svg/clip-path/clip-path-recursive-call.svg
svg/clip-path/clip-path-text-and-shape.svg
svg/clip-path/clip-path-text-and-stroke.svg
svg/clip-path/clip-path-text.svg
svg/clip-path/clip-path-use-as-child.svg
svg/clip-path/clip-path-use-as-child2.svg
svg/clip-path/clip-path-use-as-child3.svg
svg/clip-path/clip-path-use-as-child4.svg
svg/clip-path/clip-path-use-as-child5.svg
svg/clip-path/clip-path-userSpaceOnUse.svg
svg/clip-path/clip-path-with-container.svg
svg/clip-path/clip-path-with-different-unittypes.svg
svg/clip-path/clip-path-with-different-unittypes2.svg
svg/clip-path/clip-path-with-invisibile-child.svg
svg/clip-path/clip-path-with-text-clipped.svg
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGShadowTreeRootContainer): identify use-element renderer
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::pathOnlyClipping): direct clipping for simple shapes (WebCore::RenderSVGResourceClipper::applyClippingToContext): direct clipping or maskImage? (WebCore::RenderSVGResourceClipper::createClipData): creates maskImage for clipping (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGShadowTreeRootContainer.h: identify use-Element by renderer (WebCore::RenderSVGShadowTreeRootContainer::isSVGShadowTreeRootContainer):
- rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): hack to get texts working on clipping (masks and pattern)
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::rendererClipChild): get renderer of referenced object
- svg/SVGUseElement.h:
2010-04-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
<clipPath> doesn't correctly handle <text> elements
https://bugs.webkit.org/show_bug.cgi?id=12571
33 new Tests for SVG's clip-path. Test behavior of different clip objects
like text as well as different clip rules.
Other older tests are rendered correctly now.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/batik/text/textEffect2-expected.checksum:
- platform/mac/svg/batik/text/textEffect2-expected.png:
- platform/mac/svg/batik/text/textEffect2-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.checksum:
- platform/mac/svg/batik/text/textProperties-expected.png:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/clip-path: Added.
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-clipped-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-clipped-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-nonzero-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-on-g-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-on-g-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-text-and-shape-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-text-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-text-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-text-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child5-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-with-container-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-with-container-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-with-container-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
- platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
- platform/mac/svg/custom/clip-path-child-changes-expected.txt:
- platform/mac/svg/custom/clip-path-href-changes-expected.txt:
- platform/mac/svg/custom/clip-path-units-changes-expected.txt:
- platform/mac/svg/custom/clip-path-with-transform-expected.txt:
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
- platform/mac/svg/filters/filterRes-expected.checksum:
- svg/clip-path: Added.
- svg/clip-path/clip-path-child-clipped.svg: Added.
- svg/clip-path/clip-path-childs-clipped.svg: Added.
- svg/clip-path/clip-path-clipped-evenodd-twice.svg: Added.
- svg/clip-path/clip-path-clipped-no-content.svg: Added.
- svg/clip-path/clip-path-clipped-nonzero.svg: Added.
- svg/clip-path/clip-path-clipped.svg: Added.
- svg/clip-path/clip-path-evenodd-nonzero.svg: Added.
- svg/clip-path/clip-path-evenodd.svg: Added.
- svg/clip-path/clip-path-nonzero-evenodd.svg: Added.
- svg/clip-path/clip-path-nonzero.svg: Added.
- svg/clip-path/clip-path-objectBoundingBox.svg: Added.
- svg/clip-path/clip-path-on-clipped-use.svg: Added.
- svg/clip-path/clip-path-on-g-and-child.svg: Added.
- svg/clip-path/clip-path-on-g.svg: Added.
- svg/clip-path/clip-path-on-svg-and-child.svg: Added.
- svg/clip-path/clip-path-on-svg.svg: Added.
- svg/clip-path/clip-path-recursive-call-by-child.svg: Added.
- svg/clip-path/clip-path-recursive-call.svg: Added.
- svg/clip-path/clip-path-text-and-shape.svg: Added.
- svg/clip-path/clip-path-text-and-stroke.svg: Added.
- svg/clip-path/clip-path-text.svg: Added.
- svg/clip-path/clip-path-use-as-child.svg: Added.
- svg/clip-path/clip-path-use-as-child2.svg: Added.
- svg/clip-path/clip-path-use-as-child3.svg: Added.
- svg/clip-path/clip-path-use-as-child4.svg: Added.
- svg/clip-path/clip-path-use-as-child5.svg: Added.
- svg/clip-path/clip-path-userSpaceOnUse.svg: Added.
- svg/clip-path/clip-path-with-container.svg: Added.
- svg/clip-path/clip-path-with-different-unittypes.svg: Added.
- svg/clip-path/clip-path-with-different-unittypes2.svg: Added.
- svg/clip-path/clip-path-with-invisibile-child.svg: Added.
- svg/clip-path/clip-path-with-text-clipped.svg: Added.
- svg/custom/clip-path-display-none-child.svg: Removed.
- 5:25 AM QtWebKitFeaturePlanning edited by
- (diff)
- 4:39 AM Changeset in webkit [57510] by
-
- 2 edits in trunk/LayoutTests
2010-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Checksum of svg/filters/filterRes.svg was not updated properly after rebasing.
It's only visible when using "run-webkit-tests --tolerance 0 -p svg"
- platform/mac/svg/filters/filterRes-expected.checksum:
- 3:48 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 3:35 AM Changeset in webkit [57509] by
-
- 28 edits in trunk/WebCore
2010-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG renderers should track transform/path changes, instead of pulling every time from SVG DOM
https://bugs.webkit.org/show_bug.cgi?id=15389
RenderPath caches repaint rectangles (fill/stroke bbox etc.) though this caching
was effectively useless because every layout() call caused them to be reset to empty rects.
Furthermore RenderPath::layout() queried the SVG DOM upon every invocation to retrieve
the Path object, instead of only doing it when necessary. Even the TransformationMatrix
was polled everytime from the SVG DOM.
Move the knownledge wheter we need to update path/transform into the render tree and
only update when necessary. This should result in a huge performance increase, with
the drawback of adding slightly more memory, because we need to add booleans indicating
the status of path/transform (is dirty?).
Doesn't affect any tests, only performance.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::layout):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::setNeedsTransformUpdate):
- rendering/RenderObject.h: (WebCore::RenderObject::setNeedsTransformUpdate): (WebCore::RenderObject::setNeedsBoundariesUpdate):
- rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::layout): (WebCore::RenderPath::invalidateCachedBoundaries): (WebCore::RenderPath::styleWillChange):
- rendering/RenderPath.h: (WebCore::RenderPath::setNeedsBoundariesUpdate): (WebCore::RenderPath::setNeedsPathUpdate): (WebCore::RenderPath::setNeedsTransformUpdate): (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::setNeedsTransformUpdate):
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients):
- rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::invalidateClients):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::layout):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::setNeedsTransformUpdate):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::setNeedsTransformUpdate): (WebCore::RenderSVGTransformableContainer::localTransform):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::svgAttributeChanged):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
- 2:34 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 12:49 AM Changeset in webkit [57508] by
-
- 4 edits in trunk
Unreviewed build fixes for Qt and Chromium ports.
Unreviewed Qt build fix: add new .idl files to WebCore.pri
- WebCore.pri:
Unreviewed Chromium build fix: pin to a newer V8 revision (4386).
- DEPS:
- 12:48 AM Changeset in webkit [57507] by
-
- 2 edits1 add in trunk/WebKitTools
2010-04-13 Adam Barth <abarth@webkit.org>
Unreviewed, but approved by Dumitru Daniliuc. (This patch is intended
to fix the downstream Chromium build bots. Hopefully it will work!)
Add a driver script for the new websocket server
https://bugs.webkit.org/show_bug.cgi?id=37495
websocket_server.py can't be run directly because its a module and not
a standalone script. This used to work by accident because it didn't
depend on any other modules.
- Scripts/new-run-webkit-websocketserver: Added.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 12:38 AM Changeset in webkit [57506] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, adding another fast/url/ test to Chromium's
test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 12:22 AM Changeset in webkit [57505] by
-
- 23 edits7 copies2 moves1 add2 deletes in trunk
2010-04-12 Mikhail Naganov <mnaganov@chromium.org>
Replace hand-written JavaScriptProfile* bindings with idl-based, and
in Chromium port, bind them to the new V8's profiler API that is
aligned with JSC.
https://bugs.webkit.org/show_bug.cgi?id=37448
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp:
- bindings/js/JSScriptProfileNodeCustom.cpp: Added. (WebCore::JSScriptProfileNode::callUID): (WebCore::JSScriptProfileNode::children):
- bindings/js/JavaScriptProfile.cpp: Removed.
- bindings/js/JavaScriptProfile.h: Removed.
- bindings/js/JavaScriptProfileNode.cpp: Removed.
- bindings/js/JavaScriptProfileNode.h: Removed.
- bindings/js/ScriptProfileNode.h: Added.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptProfile.cpp: Added. (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::head):
- bindings/v8/ScriptProfile.h: (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::ScriptProfile):
- bindings/v8/ScriptProfileNode.cpp: Added. (WebCore::ScriptProfileNode::functionName): (WebCore::ScriptProfileNode::url): (WebCore::ScriptProfileNode::lineNumber): (WebCore::ScriptProfileNode::totalTime): (WebCore::ScriptProfileNode::selfTime): (WebCore::ScriptProfileNode::numberOfCalls): (WebCore::ScriptProfileNode::children): (WebCore::ScriptProfileNode::visible): (WebCore::ScriptProfileNode::callUID):
- bindings/v8/ScriptProfileNode.h: Added. (WebCore::ScriptProfileNode::create): (WebCore::ScriptProfileNode::~ScriptProfileNode): (WebCore::ScriptProfileNode::ScriptProfileNode):
- bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
- bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::V8Console::profilesAccessorGetter):
- bindings/v8/custom/V8ScriptProfileCustom.cpp: Added. (WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Added. (WebCore::V8ScriptProfileNode::childrenAccessorGetter): (WebCore::V8ScriptProfileNode::callUIDAccessorGetter): (WebCore::toV8):
- inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
- inspector/ScriptProfile.idl: Added.
- inspector/ScriptProfileNode.idl: Added.
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
- page/Console.idl:
- platform/android/TemporaryLinkStubs.cpp:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):
- src/js/Tests.js:
- 12:01 AM Changeset in webkit [57504] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-04-13 Daniel Bates <dbates@rim.com>
Unreviewed, fix bug url mentioned in the change log
for change set 57502 <http://trac.webkit.org/changeset/57502>.
Inadvertently listed the bug url to be <https://bugs.webkit.org/show_bug.cgi?id=37480>.
Instead, it should be <https://bugs.webkit.org/show_bug.cgi?id=37490>.
Apr 12, 2010:
- 11:42 PM Changeset in webkit [57503] by
-
- 3 edits in trunk/LayoutTests
2010-04-12 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Finish IPv4 URL parsing test
https://bugs.webkit.org/show_bug.cgi?id=37493
I rushed the first version of this test because I wanted to get the
framework in the tree for other folks to work on the other tests. The
expected.txt file matches KURL but the PASS/FAIL indiciations match
GURL.
- fast/url/ipv4-expected.txt:
- fast/url/script-tests/ipv4.js:
- 11:09 PM Changeset in webkit [57502] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-12 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Implements the anchor tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.
- fast/url/anchor-expected.txt: Added.
- fast/url/anchor.html: Added.
- fast/url/script-tests/anchor.js: Added.
- 9:52 PM Changeset in webkit [57501] by
-
- 4 edits1 copy4 adds in trunk/LayoutTests
2010-04-12 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Implements all of the non-encoding specific query string tests from
<http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.
Also, moved JavaScript function canonicalize to external JavaScript
script /resources/utilities.js since this function is being called
by tests ipv4.html, query.html, and trivial.html.
- fast/url/ipv4.html:
- fast/url/query-expected.txt: Added.
- fast/url/query.html: Added.
- fast/url/resources: Added.
- fast/url/resources/utilities.js: Added. (canonicalize):
- fast/url/script-tests/TEMPLATE.html: Include external JavaScript script resources/utilities.js.
- fast/url/script-tests/query.js: Added.
- fast/url/trivial.html:
- 9:38 PM Changeset in webkit [57500] by
-
- 2 edits in trunk/WebKitTools
2010-04-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make new-run-webkit-test PrettyPatch failure reporting more awesome
https://bugs.webkit.org/show_bug.cgi?id=37487
I also fixed an Executive/executive typo.
- Scripts/webkitpy/layout_tests/port/base.py:
- 9:00 PM Changeset in webkit [57499] by
-
- 6 edits in trunk/WebKitTools
2010-04-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests should only build java support files on Mac
https://bugs.webkit.org/show_bug.cgi?id=37482
Only the mac needs java support files, so I pushed _build_java
down into the Mac port using a new hook "_check_port_build".
In the process I noticed a bunch of code which could be shared
between all ports and thus got rid of _tests_for_disabled_features
and version() copy/paste between all webkit ports.
I also made check_build only bother to check for ImageDiff if we're
using pixel tests.
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/qt.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- 8:00 PM Changeset in webkit [57498] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping two tests on Chromium because they fail.
- platform/chromium/test_expectations.txt:
- 7:46 PM Changeset in webkit [57497] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, trying to make scripts work on machines without
Ruby...
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:29 PM Changeset in webkit [57496] by
-
- 3 edits2 adds in trunk
Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
https://bugs.webkit.org/show_bug.cgi?id=37461
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
the node is currently offscreen in an scroll overflowed content.
Test: fast/events/spatial-navigation/snav-simple-content-overflow.html
- page/SpatialNavigation.cpp:
(WebCore::renderRectRelativeToRootDocument):
LayoutTests:
- fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
- fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.
- 7:28 PM Changeset in webkit [57495] by
-
- 2 edits in trunk/WebCore
Unreviewed style fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
- 7:13 PM Changeset in webkit [57494] by
-
- 10 edits4 adds in trunk
Accessibility support for progress element
https://bugs.webkit.org/show_bug.cgi?id=37275
Reviewed by Darin Adler.
WebCore:
Implement AccessibilityProgressIndicator to hook up progress element to accessibility framework.
Test: platform/mac/accessibility/progressbar.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityProgressIndicator.cpp: Added.
- accessibility/AccessibilityProgressIndicator.h: Added.
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
LayoutTests:
- platform/mac/accessibility/progressbar-expected.txt: Added.
- platform/mac/accessibility/progressbar.html: Added.
- 7:07 PM Changeset in webkit [57493] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing a test that started failing with r57492.
- storage/open-database-over-quota.html:
- 6:04 PM Changeset in webkit [57492] by
-
- 3 edits in trunk/WebCore
Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=33916
Reviewed by Dimitri Glazkov.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- 5:59 PM Changeset in webkit [57491] by
-
- 3 edits2 adds in trunk
2010-04-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
Add stub files for running new-run-webkit-tests for the Qt port
- platform/qt/test_expectations.txt: Added.
2010-04-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
Add stub files for running new-run-webkit-tests for the Qt port
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/qt.py: Added.
- 5:47 PM Changeset in webkit [57490] by
-
- 2 edits in trunk/WebCore
2010-04-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
WebKit should have more robust last-chance font fallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=37473
<rdar://problem/7789438> Crash in FontFallbackList::determinePitch
<rdar://problem/7233762> Crash in FontFallbackList::fontDataAt
Look harder for a suitable last-resort font. Previously, we checked for
"Times New Roman" followed by DEFAULT_GUI_FONT.
We now look for:
- Typically installed Unicode-capable fonts, in order of coverage
- DEFAULT_GUI_FONT
- SPI_GETNONCLIENTMETRICS fonts
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
- 5:11 PM Changeset in webkit [57489] by
-
- 3 edits3 adds in trunk/LayoutTests
2010-04-12 Adam Barth <abarth@webkit.org>
Reviewed by Jeremy Orlow.
Add some ip4v tests (will revise in a minute)
https://bugs.webkit.org/show_bug.cgi?id=37476
- fast/url/ipv4-expected.txt: Added.
- fast/url/ipv4.html: Added.
- fast/url/script-tests/ipv4.js: Added.
- fast/url/script-tests/trivial.js: (canonicalize):
- fast/url/trivial-expected.txt:
- 4:42 PM Changeset in webkit [57488] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-04-12 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Add a trivial test for URL parsing
https://bugs.webkit.org/show_bug.cgi?id=37475
Hopefully this will be the starting point for many URL tests.
- fast/url/script-tests/TEMPLATE.html: Added.
- fast/url/script-tests/trivial.js: Added. (canonicalize):
- fast/url/trivial-expected.txt: Added.
- fast/url/trivial.html: Added.
- 4:20 PM Changeset in webkit [57487] by
-
- 2 edits in trunk/WebKit2
Add #ifdef so that WKView is not included on the mac if not
compiling objective-c.
Reviewed by Anders Carlsson.
- UIProcess/API/C/WebKit2.h:
- 4:15 PM Changeset in webkit [57486] by
-
- 3 edits in trunk/WebKitTools
2010-04-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Modify run_webkit_tests.py to not call sys.exit() at the end of test
run; doing so makes it more difficult to embed the routine for,
among other things, unit tests. We push the exit calling up into
new-run-webkit-tests.
- Scripts/new-run-webkit-tests:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 4:10 PM Changeset in webkit [57485] by
-
- 1 edit1 add in trunk/WebKit2
Add WebKit2 solution file.
Reviewed by Adam Roben.
- WebKit2.sln: Added.
- 4:10 PM QtWebKitGraphics edited by
- (diff)
- 4:10 PM QtWebKitGraphics edited by
- (diff)
- 3:14 PM Changeset in webkit [57484] by
-
- 1 edit in trunk/WebCore/rendering/style/RenderStyle.cpp
Fix debug build bustage.
- 3:10 PM ReviewTool edited by
- (diff)
- 2:55 PM Changeset in webkit [57483] by
-
- 3 edits2 adds in trunk
2010-04-12 Eric Seidel <eric@webkit.org>
Unreviewed.
Add stub Gtk implementation for new-run-webkit-tests.
- platform/gtk/test_expectations.txt: Copied from LayoutTests/animations/resources/dynamic-stylesheet-insertion-inserted.css.
2010-04-12 Eric Seidel <eric@webkit.org>
Unreviewed.
Add stub Gtk implementation for new-run-webkit-tests.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/gtk.py: Added.
- 2:53 PM Changeset in webkit [57482] by
-
- 18 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37469, clean up ShadowData to be encapsulated properly.
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
- page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperShadow::blend):
- page/mac/FrameMac.mm:
(WebCore::Frame::fontAttributesForSelectionStart):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
- rendering/InlineTextBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateRects):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
- rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintCharacters):
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
(WebCore::RenderStyle::getBoxShadowExtent):
(WebCore::RenderStyle::getBoxShadowHorizontalExtent):
(WebCore::RenderStyle::getBoxShadowVerticalExtent):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::boxShadow):
- rendering/style/SVGRenderStyle.cpp:
(WebCore::getSVGShadowExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::~ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::blur):
(WebCore::ShadowData::spread):
(WebCore::ShadowData::style):
(WebCore::ShadowData::color):
(WebCore::ShadowData::next):
(WebCore::ShadowData::setNext):
- 2:53 PM April 2010 Meeting edited by
- (diff)
- 2:50 PM ReviewTool edited by
- (diff)
- 2:48 PM ReviewTool created by
- 1:51 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:49 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:48 PM Accelerated Compositing edited by
- (diff)
- 1:47 PM Changeset in webkit [57481] by
-
- 2 edits in trunk/LayoutTests
[Gtk] LayoutTests/platform/gtk/Skipped clean up
https://bugs.webkit.org/show_bug.cgi?id=37465
Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- 1:47 PM Accelerated Compositing edited by
- (diff)
- 1:45 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:42 PM Changeset in webkit [57480] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-04-12 William Siegrist <wsiegrist@apple.com>
Add new Qt bots for Windows release, Windows debug, Linux release minimal, Linux armv5 release, and Linux armv7 release.
- 1:41 PM Accelerated Compositing created by
- 1:40 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:39 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:37 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:30 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:30 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:29 PM Transforms-Transitions-Animations edited by
- (diff)
- 1:28 PM Transforms-Transitions-Animations created by
- 1:26 PM Changeset in webkit [57479] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37463, clean up NinePieceImage.
Reviewed by Mark Rowe.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::slices):
(WebCore::NinePieceImage::setSlices):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
- 12:28 PM Changeset in webkit [57478] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping a new test on Chromium, because the test is
using an API that is not yet implemented in Chromium.
- platform/chromium/test_expectations.txt:
- 12:23 PM Changeset in webkit [57477] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r57476, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()
- platform/qt/Skipped: fast/history/multiple-classes-visited.html skipped.
- 11:42 AM Changeset in webkit [57476] by
-
- 4 edits2 adds1 delete in trunk
https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.
Reviewed by Sam Weinig.
WebCore:
Added fast/history/multiple-classes-visited.html.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
LayoutTests:
- fast/history/multiple-classes-visited-expected.txt: Added.
- fast/history/multiple-classes-visited.html: Added.
- 11:31 AM April 2010 Meeting edited by
- add my name, alphabetize (diff)
- 11:03 AM Changeset in webkit [57475] by
-
- 2 edits in trunk/WebKitTools
2010-04-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests fails with exception on systems missing ruby
https://bugs.webkit.org/show_bug.cgi?id=37441
- Scripts/webkitpy/layout_tests/port/base.py:
- Catch failures similar to how wdiff code path does.
- After one failure, stop trying.
- 10:28 AM April 2010 Meeting edited by
- (diff)
- 10:28 AM April 2010 Meeting edited by
- (diff)
- 10:20 AM April 2010 Meeting edited by
- (diff)
- 10:02 AM April 2010 Meeting edited by
- (diff)
- 9:59 AM April 2010 Meeting edited by
- (diff)
- 9:58 AM April 2010 Meeting edited by
- (diff)
- 9:56 AM April 2010 Meeting edited by
- (diff)
- 9:46 AM Changeset in webkit [57474] by
-
- 2 edits in trunk/WebCore
2010-04-12 Dirk Schulze <krit@webkit.org>
Unreviewed build fix.
Make comma/whitespace around arc flags optional in SVG path syntax
https://bugs.webkit.org/show_bug.cgi?id=37431
Fix the SL build.
- svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag):
- 9:42 AM April 2010 Meeting edited by
- (diff)
- 9:41 AM April 2010 Meeting edited by
- (diff)
- 9:39 AM April 2010 Meeting edited by
- (diff)
- 9:28 AM April 2010 Meeting edited by
- (diff)
- 8:49 AM Changeset in webkit [57473] by
-
- 6 edits in trunk
2010-04-12 Jeff Schiller <codedread@gmail.com>
Reviewed by Dirk Schulze.
Add tests to handle that comma/whitespace around arc flags are optional
and that arc flags can only be 0 or 1 in SVG path syntax:
https://bugs.webkit.org/show_bug.cgi?id=37431
- svg/dom/fuzz-path-parser-expected.txt: One test now fails due to flags not 0 or 1
- svg/dom/path-parser-expected.txt: Add test results for missing whitespace and flags not 0 or 1
- svg/dom/script-tests/path-parser.js: Add 6 tests to check that whitespace is optional after flags and flags must be 0 or 1
2010-04-12 Jeff Schiller <codedread@gmail.com>
Reviewed by Dirk Schulze.
Make comma/whitespace around arc flags optional in SVG path syntax and ensure flags are
either 0 or 1: https://bugs.webkit.org/show_bug.cgi?id=37431
- svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): function to read in a 0 or 1 for largeArcFlag and sweepFlag (WebCore::SVGPathParser::parseSVG): modify/simplify arc parsing by using parseArcFlag()
- 8:24 AM April 2010 Meeting edited by
- (diff)
- 8:23 AM April 2010 Meeting edited by
- (diff)
- 8:12 AM April 2010 Meeting edited by
- (diff)
- 8:09 AM April 2010 Meeting edited by
- (diff)
- 8:07 AM April 2010 Meeting edited by
- (diff)
- 7:58 AM April 2010 Meeting edited by
- (diff)
- 7:57 AM April 2010 Meeting edited by
- (diff)
- 7:47 AM April 2010 Meeting edited by
- (diff)
- 7:37 AM April 2010 Meeting edited by
- (diff)
- 7:35 AM April 2010 Meeting edited by
- (diff)
- 6:47 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:59 AM Changeset in webkit [57472] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix for Mac when building with build-webkit --qt
Reviewed by nobody, build fix.
Specifying no configuration on Mac builds WebCore both in debug
and release. JavaScriptCore has to follow this rule as well.
- JavaScriptCore.pro:
- 3:52 AM BuildingQtOnLinux edited by
- added dependency on fontconfig (diff)
- 2:20 AM Changeset in webkit [57471] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
Inserting my name in the correct location.
- 1:03 AM Changeset in webkit [57470] by
-
- 2 edits in trunk/WebKitTools
2010-04-12 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix how we import simplejson based on how it's used in this file.
This fixes exceptions raised when trying to write the simplejson output.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Apr 11, 2010:
- 11:53 PM April 2010 Meeting edited by
- (diff)
- 11:19 PM April 2010 Meeting edited by
- (diff)
- 11:11 PM April 2010 Meeting edited by
- (diff)
- 10:47 PM April 2010 Meeting edited by
- (diff)
- 10:41 PM April 2010 Meeting edited by
- (diff)
- 9:54 PM Changeset in webkit [57469] by
-
- 41 edits2 deletes in trunk
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
- src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
- Android.mk:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- dom/Document.cpp: (WebCore::Document::close):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/DocumentWriter.cpp: Removed.
- loader/DocumentWriter.h: Removed.
- loader/FrameLoader.cpp: (WebCore::canReferToParentFrameEncoding): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::replaceDocument): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/FrameLoader.h:
- loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 9:34 PM April 2010 Meeting edited by
- (diff)
- 9:20 PM Changeset in webkit [57468] by
-
- 41 edits2 adds in trunk
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
- src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.
No tests because there is no behavior change (hopefully!).
- Android.mk:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- dom/Document.cpp: (WebCore::Document::close):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/DocumentWriter.cpp: Added.
- loader/DocumentWriter.h: Added.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
- loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 9:05 PM April 2010 Meeting edited by
- (diff)
- 8:52 PM Changeset in webkit [57467] by
-
- 4 edits in trunk/WebKitTools
2010-04-11 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored check-webkit-style so that the StyleChecker class
has no dependencies on patch-related concepts.
This patch is an intermediate step towards making the StyleChecker
class a generalized file processor that can do arbitary operations
on the files corresponding to a list of paths. This patch
also simplifies the unit-testing of patch-checking code.
- Scripts/check-webkit-style:
- Updated to use the new PatchChecker class.
- Scripts/webkitpy/style/checker.py:
- Refactored the StyleChecker.check_patch() method into the check() method of a new PatchChecker class.
- Scripts/webkitpy/style/checker_unittest.py:
- Refactored the unit tests as necessary, changing the StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
- 8:50 PM April 2010 Meeting edited by
- (diff)
- 8:02 PM April 2010 Meeting edited by
- (diff)
- 7:56 PM April 2010 Meeting edited by
- (diff)
- 7:54 PM Changeset in webkit [57466] by
-
- 6 edits in trunk/WebKitTools
2010-04-11 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
https://bugs.webkit.org/show_bug.cgi?id=37430
We need some basic unit testing of this script, or we're going to keep
breaking it like this. Added missing namespace qualifiers and
propagated renaming of an option.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/layout_tests/driver_test.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:47 PM Changeset in webkit [57465] by
-
- 2 edits1 add in trunk/LayoutTests
2010-04-11 Tony Chang <tony@chromium.org>
Not reviewed, layout test fix for QT bots.
Update paste expected results on QT and skip a new d&d test.
- platform/qt/Skipped:
- platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Added.
- 7:21 PM Changeset in webkit [57464] by
-
- 6 edits4 adds in trunk
2010-04-11 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193
- editing/pasteboard/onpaste-text-html-expected.txt: Added.
- editing/pasteboard/onpaste-text-html.html: Added.
- fast/events/ondrop-text-html-expected.txt: Added.
- fast/events/ondrop-text-html.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-04-07 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193
Tests: editing/pasteboard/onpaste-text-html.html
fast/events/ondrop-text-html.html
- platform/chromium/ClipboardChromium.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): add html type (WebCore::ClipboardChromium::clearData): implement clear text/html (WebCore::ClipboardChromium::getData): implement get text/html (similar to text/plain) (WebCore::ClipboardChromium::setData): implement set text/html
- 7:16 PM Changeset in webkit [57463] by
-
- 3 edits in trunk/WebKitTools
2010-04-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Break new-run-webkit-tests options into groups for easier re-use and possible relocation
https://bugs.webkit.org/show_bug.cgi?id=37408
new-run-webkit-tests currently has one huge function for
dealing with all options-parsing.
This patch is a first attempt at trying to split that large
function down into smaller (hopefully more readable?) chunks
dealing with the different areas of options.
For example, it would make sense to move configuration
options off into some module which deals with the vagries of
WebKit's configuration system. It would also make sense to move
Chromium options off onto the Chromium port object (where they are used).
It may make sense to move results.json options over to the results.json code.
This change is a first iteration, and we will certainly need more
refinement to this code over time. Hopefully I didn't make things
harder to read here.
- Scripts/webkitpy/layout_tests/driver_test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:07 PM April 2010 Meeting edited by
- add myself (diff)
- 6:58 PM Changeset in webkit [57462] by
-
- 3 edits in trunk/WebKitTools
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
create-rollout copy needs to be updated to reflect removal of --no-build
https://bugs.webkit.org/show_bug.cgi?id=37425
Removed --no-build and --no-test from the instructions because these
don't exist anymore.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Updated the expected results to reflect the new copy.
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- 6:04 PM Changeset in webkit [57461] by
-
- 5 edits in trunk
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424
broke chromium builders (Requested by tonywork on #webkit).
- DEPS:
- gyp_webkit:
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424
broke chromium builders (Requested by tonywork on #webkit).
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 5:49 PM Changeset in webkit [57460] by
-
- 5 edits in trunk
2010-04-11 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578
- DEPS:
- gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.
2010-04-11 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between WebKit.gyp and webkit.gyp.
- 4:57 PM April 2010 Meeting edited by
- (diff)
- 4:44 PM April 2010 Meeting edited by
- (diff)
- 4:22 PM April 2010 Meeting edited by
- Add tkent to attendees list (diff)
- 4:08 PM April 2010 Meeting edited by
- (diff)
- 4:05 PM April 2010 Meeting edited by
- (diff)
- 3:55 PM April 2010 Meeting edited by
- (diff)
- 3:47 PM April 2010 Meeting edited by
- (diff)
- 3:25 PM ApplicationsGtk edited by
- Added DeforaOS Surfer (diff)
- 3:23 PM ApplicationsGtk edited by
- Typos (diff)
- 3:18 PM April 2010 Meeting edited by
- (diff)
- 3:09 PM April 2010 Meeting edited by
- (diff)
- 2:42 PM April 2010 Meeting edited by
- (diff)
- 2:22 PM Changeset in webkit [57459] by
-
- 2 edits in tags/Safari-533.4.1/JavaScriptCore
Merge r57457.
- 2:15 PM April 2010 Meeting edited by
- (diff)
- 2:14 PM April 2010 Meeting edited by
- (diff)
- 2:14 PM April 2010 Meeting edited by
- (diff)
- 2:12 PM Changeset in webkit [57458] by
-
- 5 edits1 add in trunk/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=37417
Move duplicated internal CoreIPC message kinds to a
header.
Reviewed by Darin Adler.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- Platform/CoreIPC/CoreIPCMessageKinds.h: Added.
(CoreIPC::CoreIPCMessage::):
(CoreIPC::):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 2:05 PM April 2010 Meeting edited by
- (diff)
- 2:04 PM Changeset in webkit [57457] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/7851332> Fix the build.
Reviewed by Sam Weinig.
- wtf/FastMalloc.cpp:
(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.
- 2:04 PM April 2010 Meeting edited by
- (diff)
- 1:55 PM April 2010 Meeting edited by
- (diff)
- 1:54 PM April 2010 Meeting edited by
- (diff)
- 1:46 PM April 2010 Meeting edited by
- (diff)
- 1:43 PM April 2010 Meeting edited by
- (diff)
- 1:43 PM April 2010 Meeting edited by
- (diff)
- 1:42 PM April 2010 Meeting edited by
- (diff)
- 1:41 PM April 2010 Meeting edited by
- (diff)
- 1:41 PM April 2010 Meeting edited by
- (diff)
- 1:37 PM April 2010 Meeting edited by
- (diff)
- 1:35 PM April 2010 Meeting edited by
- (diff)
- 1:34 PM Changeset in webkit [57456] by
-
- 2 edits in trunk/WebKit2
Disable not-implemented warnings by default for now.
Rubber-stamped by Anders Carlsson.
- Shared/NotImplemented.h:
- 1:33 PM April 2010 Meeting edited by
- (diff)
- 1:32 PM April 2010 Meeting edited by
- (diff)
- 1:31 PM April 2010 Meeting edited by
- (diff)
- 1:31 PM April 2010 Meeting edited by
- (diff)
- 1:30 PM April 2010 Meeting edited by
- (diff)
- 1:30 PM April 2010 Meeting edited by
- (diff)
- 1:28 PM April 2010 Meeting edited by
- (diff)
- 1:25 PM April 2010 Meeting edited by
- (diff)
- 1:24 PM April 2010 Meeting edited by
- Typo fix (diff)
- 1:22 PM April 2010 Meeting edited by
- (diff)
- 1:20 PM April 2010 Meeting edited by
- (diff)
- 1:19 PM Changeset in webkit [57455] by
-
- 2 edits in trunk/WebKitTools
2010-04-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Eric Seidel.
svn-apply errors out when removing directories in git
https://bugs.webkit.org/show_bug.cgi?id=34871
- Scripts/svn-apply: (isDirectoryEmptyForRemoval): early break if the directory doesn't exist (scmRemove): have git ignore unmatched files
- 1:18 PM Changeset in webkit [57454] by
-
- 12 edits in trunk/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=37399
Remove use of STL data structures from CoreIPC code
Reviewed by Anders Carlsson.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeBytes):
(CoreIPC::ArgumentDecoder::removeAttachment):
- Platform/CoreIPC/ArgumentDecoder.h:
Use WTF::Deque instead of std::queue and WTF::Vector
instead of std::vector. Replace use of malloc/free with
fastMalloc/fastFree.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::addAttachment):
(CoreIPC::ArgumentEncoder::releaseAttachments):
- Platform/CoreIPC/ArgumentEncoder.h:
Use WTF::Vector instead of std::list. Replace use of malloc/free
with fastMalloc/fastFree.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchMessages):
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):
Use WTF::Vector instead of std::queue.
- Platform/RunLoop.cpp:
(RunLoop::performWork):
(RunLoop::scheduleWork):
- Platform/RunLoop.h:
Ditto.
- Platform/WorkQueue.h:
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::scheduleWork):
(WorkQueue::performWork):
Ditto.
- 1:17 PM April 2010 Meeting edited by
- (diff)
- 1:16 PM April 2010 Meeting edited by
- (diff)
- 1:15 PM April 2010 Meeting edited by
- (diff)
- 12:09 PM Changeset in webkit [57453] by
-
- 4 edits3 deletes in trunk/WebKitTools
2010-04-11 Daniel Bates <dbates@rim.com>
No review, rolling out 57440.
http://trac.webkit.org/changeset/57440
https://bugs.webkit.org/show_bug.cgi?id=27204
Did not handle Git patches that included both file and property
changes to the same file. Rolling this change out while I look
into this.
- Scripts/VCSUtils.pm:
- Scripts/svn-apply:
- Scripts/svn-unapply:
- Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
- Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
- Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
- 11:51 AM Changeset in webkit [57452] by
-
- 2 edits in trunk/WebKitSite
2010-04-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Eric Seidel.
Minor Updates and Cleanup to the Contributing Page
https://bugs.webkit.org/show_bug.cgi?id=37415
- coding/contributing.html:
- 11:43 AM Changeset in webkit [57451] by
-
- 3 edits in trunk/WebKitTools
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix typo in log path for AbstractQueue
https://bugs.webkit.org/show_bug.cgi?id=37414
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 10:34 AM Changeset in webkit [57450] by
-
- 2 edits in trunk/WebKitTools
2010-04-11 Adam Barth <abarth@webkit.org>
Unreviewed. Add missing import statement.
- Scripts/webkitpy/common/system/executive.py:
- 8:37 AM Changeset in webkit [57449] by
-
- 7 edits in trunk
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
Unskip:
http/tests/security/no-referrer.html
fast/loader/onload-willSendRequest-null-for-frame.html
fast/loader/onload-willSendRequest-null-for-script.html
- platform/qt/Skipped:
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
- WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 2:05 AM Changeset in webkit [57448] by
-
- 2 edits in trunk/WebKitTools
[Qt] Unreviewed buildfix for --debug build after r57433.
Refactor Qt DRT support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35844
- QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();
(launcherMain):
- 12:46 AM Changeset in webkit [57447] by
-
- 2 edits in trunk/WebKitTools
2010-04-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Mark Rowe.
Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
https://bugs.webkit.org/show_bug.cgi?id=37407
- Scripts/commit-log-editor:
- 12:41 AM Changeset in webkit [57446] by
-
- 8 edits in trunk/WebKitTools
2010-04-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add PrettyPatch links to new-run-webkit-tests output
https://bugs.webkit.org/show_bug.cgi?id=37406
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- We're leaking a file handle here, add a FIXME.
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Add pretty diff links.
- Scripts/webkitpy/layout_tests/port/base.py:
- Add support for generating pretty diffs using PrettyPatch.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- We're leaking another file handle here, another FIXME.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Update write_output_files signature.
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Remove unused arguments from write_output_files.
- Add support for dumping pretty diffs to write_output_files.
- Fix a bunch of file descriptor leaks in this file.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- Update write_output_files signature.
Apr 10, 2010:
- 11:57 PM Changeset in webkit [57445] by
-
- 4 edits in trunk/WebCore
2010-04-10 Adam Barth <abarth@webkit.org>
Unreviewed. Rename m_forceSandboxFlags to m_forcedSandoxFlags, as
requested by Darin Adler.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::updateSandboxFlags):
- loader/FrameLoader.h: (WebCore::FrameLoader::setForcedSandboxFlags):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 11:52 PM Changeset in webkit [57444] by
-
- 9 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
kill_process is copy/pasted in five places
https://bugs.webkit.org/show_bug.cgi?id=37405
We shouldn't replicate the kill_process logic in every port. Instead,
we should move the process interaction to Executive.
Dirk mentioned that he wanted this abstraction to make it easier to
mock things out for testing. It turns out this function is only used
in one place where it can't be used as a mock point for testing because
the corresponding create process actually creates a real process. In
the long term, we should indirect both these calls through a non-static
Executive as a mock point. However, we should wait on that until we
actually want to write the test.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- 11:13 PM Changeset in webkit [57443] by
-
- 10 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests shouldn't alter its path to import packages
https://bugs.webkit.org/show_bug.cgi?id=37404
- Scripts/new-run-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- Scripts/webkitpy/thirdparty/simplejson/decoder.py:
- 11:05 PM Changeset in webkit [57442] by
-
- 2 edits in trunk/WebKitTools
2010-04-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests should store results to a directory under the build tree
https://bugs.webkit.org/show_bug.cgi?id=37380
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 10:57 PM Changeset in webkit [57441] by
-
- 8 edits1 move in trunk
<rdar://problem/7845305> Further adoption of formal protocols for delegates.
Reviewed by Dan Bernstein.
Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/EmptyProtocolDefinitions.h: Renamed from WebKit/mac/Misc/EmptyProtocolDefinitions.h.
- platform/network/mac/ResourceHandleMac.mm:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- Misc/EmptyProtocolDefinitions.h: Removed.
- Misc/WebDownload.mm:
- WebKitPrefix.h:
- 10:46 PM Changeset in webkit [57440] by
-
- 4 edits3 adds in trunk/WebKitTools
2010-04-10 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Implement support for changing the executable bit of a file.
The executable bit is among the most changed file properties.
Future support can include other property changes.
Currently, if a patch changes the executable bit of a file
it is not respected by svn-apply or svn-unapply. Since the
commit-queue bot uses these tools as part of its workflow,
such patches cannot be committed by it. That is, such patches
need to be committed by hand. Instead, we should add support
for the executable bit so that such patches can be committed
by the commit-queue bot.
- Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. in copyright to Apple, Inc.
- Scripts/svn-apply:
- Scripts/svn-unapply:
- Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
- Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
- Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.
- 10:27 PM Changeset in webkit [57439] by
-
- 3 edits in trunk/WebKitTools
2010-04-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
https://bugs.webkit.org/show_bug.cgi?id=37401
The Git-based bots don't have this trouble because
Git.clean_working_directory fully removes files that were
marked as "add". SVN.clean_working_directory previously just
called "svn revert" which would leave added files in the
working directory untracked. This patch makes
SVN.clean_working_directory function more like
Git.clean_working_directory by removing added files after revert.
- Scripts/webkitpy/common/checkout/scm.py:
- Add SCM.absolute_path for easy conversion between repository-relative paths and absolute paths.
- Add SCM.add and SCM.added_files
- Make SVN.clean_working_directory remove any added_files after svn revert.
- The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add tests for added code.
- 10:17 PM Changeset in webkit [57438] by
-
- 4 edits in trunk/WebCore
2010-04-10 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Defense in depth: make sure an SVG document in the <img> context has
a unique origin.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Force the temporary rendering context into a unique origin.
- loader/FrameLoader.h: (WebCore::FrameLoader::setForceSandboxFlags): Support for setting sandbox flags that will always be applied.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags): Always apply any forced flags.
- 10:10 PM Changeset in webkit [57437] by
-
- 2 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests can't find ImageDiff on Windows
https://bugs.webkit.org/show_bug.cgi?id=37403
It turns out the build directory on Windows is structured differently
than it is on other platforms. Instead of assuming the normal
structure, we should just ask perl to figure it out for us.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 10:03 PM Changeset in webkit [57436] by
-
- 4 edits6 moves in trunk
2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Moving files associated with the GPU compositor from platform/graphics/skia to platform/graphics/chromium. Class
rename was done in a previous CL, this CL does the file move and rename.
https://bugs.webkit.org/show_bug.cgi?id=37231
No new functionality, no new tests.
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp.
- platform/graphics/chromium/GraphicsLayerChromium.h: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.h.
- platform/graphics/chromium/LayerChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerSkia.cpp.
- platform/graphics/chromium/LayerChromium.h: Copied from WebCore/platform/graphics/skia/LayerSkia.h.
- platform/graphics/chromium/LayerRendererChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.cpp.
- platform/graphics/chromium/LayerRendererChromium.h: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.h.
- platform/graphics/skia/GraphicsLayerSkia.cpp: Removed.
- platform/graphics/skia/GraphicsLayerSkia.h: Removed.
- platform/graphics/skia/LayerRendererSkia.cpp: Removed.
- platform/graphics/skia/LayerRendererSkia.h: Removed.
- platform/graphics/skia/LayerSkia.cpp: Removed.
- platform/graphics/skia/LayerSkia.h: Removed.
2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
https://bugs.webkit.org/show_bug.cgi?id=37231
- src/WebViewImpl.h:
- 9:03 PM Changeset in webkit [57435] by
-
- 2 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Change "Gathering files" status line to "Collecting tests". Gathering
the files sounds silly to me.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:51 PM Changeset in webkit [57434] by
-
- 4 edits1 add in trunk
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400
Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.
- platform/win/test_expectations.txt: Added.
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400
Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 6:35 PM Changeset in webkit [57433] by
-
- 17 edits2 adds in trunk
2010-04-10 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Refactor Qt DRT support in QtWebKit
- WebCore.pro: Add DumpRenderTreeSupportQt.cpp
2010-04-10 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Refactor Qt DRT support in QtWebKit
Move all QT DRT support functions to a static class.
- Api/qwebframe.cpp: Remove static functions.
- Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
- Api/qwebpage.cpp: Remove static functions.
- Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
- Api/qwebsecurityorigin.cpp: Remove static functions.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode):
- WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
- WebCoreSupport/EditorClientQt.h:
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
2010-04-10 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Refactor Qt DRT support in QtWebKit
Update Qt DRT to use new DumpRenderTreeSupportQt static class.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpFramesAsText):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/GCControllerQt.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
- DumpRenderTree/qt/GCControllerQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setMediaType): (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::setCaretBrowsingEnabled): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::workerThreadCount): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 6:25 PM Changeset in webkit [57432] by
-
- 2 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move global queue log to the logs directory so it survives git clean -f
https://bugs.webkit.org/show_bug.cgi?id=37395
- Scripts/webkitpy/tool/commands/queues.py:
- 6:16 PM Changeset in webkit [57431] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-10 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Eric Seidel.
Cleanup after chromium breakage. All interface methods are
returned to being abstract.
- public/WebNotificationPresenter.h:
- 6:06 PM Changeset in webkit [57430] by
-
- 2 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should spam when it encounters errors
https://bugs.webkit.org/show_bug.cgi?id=37329
We need to always update the status server so we don't get stuck in a
spam loop. I tried writing a test for this change, but it kind of
got out of control. We need a better way to do failure injection.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- 5:51 PM Changeset in webkit [57429] by
-
- 4 edits in trunk/WebCore
2010-04-10 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Missing CONTEXT_MENUS Guards
https://bugs.webkit.org/show_bug.cgi?id=37398
Added missing ENABLE(CONTEXT_MENUS) guards.
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient):
- inspector/InspectorFrontendHost.h:
- 5:49 PM Changeset in webkit [57428] by
-
- 2 edits in trunk/LayoutTests
2010-04-10 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Add slow expectations based on webkit-dev discussion.
- platform/mac/test_expectations.txt:
- 5:44 PM Changeset in webkit [57427] by
-
- 4 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium Mac canary.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/config/ports_unittest.py:
- Scripts/webkitpy/common/system/executive.py:
- 5:28 PM Changeset in webkit [57426] by
-
- 4 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Unreviewed.
Add the Apache bits to win.py for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37397
I still have run this yet, but I looked around to figure out what the
various paths appear to be. I'll figure out a way to remove the
copy/paste code in a future patch.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- 4:39 PM Changeset in webkit [57425] by
-
- 4 edits1 add in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sketch out the win port for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37393
I haven't tried running this yet, but we've got to start somewhere.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/win.py: Added.
- 3:44 PM Changeset in webkit [57424] by
-
- 6 edits in trunk/WebKitTools
2010-04-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
webkit-patch land should not build and test by default
https://bugs.webkit.org/show_bug.cgi?id=33631
Reverse the sense of --no-build and --no-test to be --build and --test.
Also, decoupled the build and test options so you can test without
building.
(Patch manngled by Adam Barth. All bugs are his fault.)
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/steps/options.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- 3:18 PM Changeset in webkit [57423] by
-
- 4 edits1 copy in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor WebKitPort out of MacPort to allow for WinPort
https://bugs.webkit.org/show_bug.cgi?id=37388
The split is a bit of a guess. We might have to adjust things once we
actually have a second port to work with.
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/webkit.py: Added.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 3:17 PM Changeset in webkit [57422] by
-
- 5 edits in trunk/WebKitTools
2010-04-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
run_webkit_tests.py shouldn't have platform-specific logic
https://bugs.webkit.org/show_bug.cgi?id=37387
Dirk Pranke pointed out that my last patch was wrong because I
introduced platform-specific logic into run_webkit_tests.py, limiting
the parallelism in Chromium to work around a bug in the main Mac port.
- Scripts/webkitpy/common/system/executive.py:
- Fix a typo pointed out by Chris Jerdonek.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:09 PM Changeset in webkit [57421] by
-
- 2 edits in trunk/WebKit2
Fix an obviously incorrect part of the Xcode configuration cleanup that resulted in debug builds
asserting shortly after launch.
- WebKit2.xcodeproj/project.pbxproj: Fix the setting of DEBUG_DEFINES for the Debug configuration.
- 2:39 PM Changeset in webkit [57420] by
-
- 2 edits in trunk/WebCore
2010-04-10 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix crash in Gradient::fill()
https://bugs.webkit.org/show_bug.cgi?id=37386
Covered by existing tests.
- platform/graphics/haiku/GradientHaiku.cpp:
(WebCore::Gradient::fill):
- Make sure the platform gradient is already cached before dereferencing its pointer.
- 2:30 PM Changeset in webkit [57419] by
-
- 2 edits in trunk/WebCore
2010-04-10 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix build of ImageHaiku.cpp
<https://bugs.webkit.org/show_bug.cgi?id=37384>
No new tests needed.
- platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::Image::drawPattern):
- include SharedBuffer.h
- changed parameter name to be in line with other ports, the code I landed in an earlier commit was already using this name.
- 5:28 AM Changeset in webkit [57418] by
-
- 4 edits in trunk
[Qt] Fix regressions in http/tests/navigation from r57416
2010-04-10 Robert Hogan <robert@webkit.org>
Unreviewed fix to regressions in r57416.
[Qt] Fix regressions in http/tests/navigation from r57416
Unskip tests skipped after regression in r57416.
- platform/qt/Skipped:
2010-04-10 Robert Hogan <robert@webkit.org>
Unreviewed fix to regressions in r57416.
[Qt] Fix regressions in http/tests/navigation from r57416
Reset willSendRequestReturnsNullOnRedirect after each test to
prevent it leaking to subsequent tests.
Error pointed out by Jakub Wieczorek.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- 3:41 AM Changeset in webkit [57417] by
-
- 2 edits4 adds in trunk/LayoutTests
2010-04-10 Robert Hogan <robert@webkit.org>
Unreviewed fix to regressions from r57416.
Add expected results missing from r57416
Skip 2 tests that now fail.
http/tests/navigation/postredirect-reload.html
http/tests/navigation/redirect302-basic.html
These regressions will be worked under:
https://bugs.webkit.org/show_bug.cgi?id=37237
- platform/qt/Skipped:
- platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
- 3:12 AM Changeset in webkit [57416] by
-
- 8 edits in trunk
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.
Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html
http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html
QNetworkReply::OperationCanceledError has a value of 5 rather than -999, so add platform-specific results accordingly.
Add platform-specific results for the the following, though leave them skipped for now. They've started failing again
since review was granted (see https://bugs.webkit.org/show_bug.cgi?id=37382):
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
- platform/qt/Skipped:
- platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.
Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html
http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html
QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly.
- WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-11 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.
Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
Prevent dumping resource load callbacks once layout test has dumped.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 2:09 AM Changeset in webkit [57415] by
-
- 2 edits in trunk/LayoutTests
2010-04-10 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, fixing description and expectation for media/video-replaces-poster.html.
- platform/chromium/test_expectations.txt:
- 2:06 AM Changeset in webkit [57414] by
-
- 2 edits in trunk/LayoutTests
2010-04-10 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, marking media/video-replaces-poster.html as flaky.
- platform/chromium/test_expectations.txt:
- 1:35 AM Changeset in webkit [57413] by
-
- 3 edits in trunk/LayoutTests
2010-04-10 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, checking in corrected baselines for media/video-replaces-poster.html
on Chromium Win.
- platform/chromium-win/media/video-replaces-poster-expected.checksum:
- platform/chromium-win/media/video-replaces-poster-expected.png:
- 1:18 AM Changeset in webkit [57412] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, platform specific expected files updated after r57408.
[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503
- platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
- 1:11 AM Changeset in webkit [57411] by
-
- 120 edits41 adds in trunk/LayoutTests
2010-04-10 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, enable the rest of the fast/media tests for Chromium Mac and Linux
by checking in new baselines.
- platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.png:
- platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.png:
- platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.png:
- platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.png:
- platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.png:
- platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.checksum:
- platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.png:
- platform/chromium-linux/fast/media/media-type-syntax-01-expected.checksum:
- platform/chromium-linux/fast/media/media-type-syntax-01-expected.png:
- platform/chromium-linux/fast/media/media-type-syntax-02-expected.checksum:
- platform/chromium-linux/fast/media/media-type-syntax-02-expected.png:
- platform/chromium-linux/fast/media/mq-animation-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-animation-expected.png: Added.
- platform/chromium-linux/fast/media/mq-aspect-ratio-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-aspect-ratio-expected.png: Added.
- platform/chromium-linux/fast/media/mq-compound-query-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-compound-query-01-expected.png:
- platform/chromium-linux/fast/media/mq-compound-query-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-compound-query-02-expected.png:
- platform/chromium-linux/fast/media/mq-compound-query-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-compound-query-03-expected.png:
- platform/chromium-linux/fast/media/mq-compound-query-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-compound-query-04-expected.png:
- platform/chromium-linux/fast/media/mq-compound-query-05-expected.checksum:
- platform/chromium-linux/fast/media/mq-compound-query-05-expected.png:
- platform/chromium-linux/fast/media/mq-grid-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-grid-01-expected.png:
- platform/chromium-linux/fast/media/mq-grid-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-grid-02-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.png:
- platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.checksum:
- platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.png:
- platform/chromium-linux/fast/media/mq-js-media-except-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
- platform/chromium-linux/fast/media/mq-js-media-except-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
- platform/chromium-linux/fast/media/mq-js-media-except-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
- platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.png:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.png:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.png:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.png:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.png:
- platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.checksum:
- platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.png:
- platform/chromium-linux/fast/media/mq-min-constraint-expected.checksum:
- platform/chromium-linux/fast/media/mq-min-constraint-expected.png:
- platform/chromium-linux/fast/media/mq-orientation-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-orientation-expected.png: Added.
- platform/chromium-linux/fast/media/mq-pixel-ratio-expected.checksum:
- platform/chromium-linux/fast/media/mq-pixel-ratio-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
- platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
- platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
- platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.png:
- platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.png:
- platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.png:
- platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.png:
- platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.png:
- platform/chromium-linux/fast/media/mq-simple-query-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-query-01-expected.png:
- platform/chromium-linux/fast/media/mq-simple-query-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-query-02-expected.png:
- platform/chromium-linux/fast/media/mq-simple-query-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-query-03-expected.png:
- platform/chromium-linux/fast/media/mq-simple-query-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-query-04-expected.png:
- platform/chromium-linux/fast/media/mq-simple-query-05-expected.checksum:
- platform/chromium-linux/fast/media/mq-simple-query-05-expected.png:
- platform/chromium-linux/fast/media/mq-transform-01-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-transform-01-expected.png: Added.
- platform/chromium-linux/fast/media/mq-transform-02-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-transform-02-expected.png: Added.
- platform/chromium-linux/fast/media/mq-transform-03-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-transform-03-expected.png: Added.
- platform/chromium-linux/fast/media/mq-transform-04-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-transform-04-expected.png: Added.
- platform/chromium-linux/fast/media/mq-transition-expected.checksum: Added.
- platform/chromium-linux/fast/media/mq-transition-expected.png: Added.
- platform/chromium-linux/fast/media/mq-valueless-expected.checksum:
- platform/chromium-linux/fast/media/mq-valueless-expected.png:
- platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
- platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
- platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
- platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
- platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
- platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
- platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
- platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
- platform/chromium-linux/fast/media/viewport-media-query-expected.checksum:
- platform/chromium-linux/fast/media/viewport-media-query-expected.png:
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:47 AM Changeset in webkit [57410] by
-
- 4 edits8 adds in trunk/LayoutTests
2010-04-10 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, checking in updated baselines and expectations for Chromium media layout tests.
- platform/chromium-linux/media/video-replaces-poster-expected.checksum: Added.
- platform/chromium-linux/media/video-replaces-poster-expected.png: Added.
- platform/chromium-mac/media/controls-drag-timebar-expected.txt: Added.
- platform/chromium-mac/media/video-currentTime-set-expected.txt:
- platform/chromium-mac/media/video-replaces-poster-expected.checksum: Added.
- platform/chromium-mac/media/video-replaces-poster-expected.png: Added.
- platform/chromium-win/media/controls-drag-timebar-expected.txt: Added.
- platform/chromium-win/media/video-currentTime-set-expected.txt:
- platform/chromium-win/media/video-replaces-poster-expected.checksum: Added.
- platform/chromium-win/media/video-replaces-poster-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:46 AM Changeset in webkit [57409] by
-
- 2 edits in trunk/LayoutTests
[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381
- platform/qt/Skipped: animations/dynamic-stylesheet-loading.html skipped until fix.
- 12:35 AM Changeset in webkit [57408] by
-
- 13 edits2 adds in trunk
2010-04-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503
Map WebKit notifications to Qt's SystemTray API and
implement DRT tracing.
This patch does not implement the security part of
WebKit notifications.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission):
- WebCoreSupport/NotificationPresenterClientQt.h: Added.
2010-04-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503
No new tests enabled as notification DRT tests are
disabled at the moment.
- WebCore.pri: Add files to the build system and turn on the feature by default.
- WebCore.pro: Add files to the build system
- bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission): (WebCore::JSNotification::addEventListener): (WebCore::JSNotification::removeEventListener): Fix build regresssion.
2010-04-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503
DRT stubs for notification. Enables to run and pass
3 (currently disabled) tests.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
