Timeline
Apr 25, 2011:
- 11:59 PM Changeset in webkit [84888] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=59427
Reviewed by Adam Barth.
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask8::create):
- 11:54 PM Changeset in webkit [84887] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
Reviewed by Dan Bernstein.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
- css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
- 11:46 PM Changeset in webkit [84886] by
-
- 8 edits in trunk/Source
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
Fix include ordering.
- WebView/WebDeviceOrientationProviderMock.mm:
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage):
- Lack of OwnPtr in HashMap is sad face. This code becomes very pretty if we could use OwnPtr in HashMap...
- Platform/RunLoop.cpp: (RunLoop::performWork): (RunLoop::scheduleWork):
- Platform/RunLoop.h:
- Platform/mac/WorkQueueMac.cpp: (WorkQueue::executeWorkItem):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverData):
- 11:31 PM Changeset in webkit [84885] by
-
- 3 edits2 adds in trunk
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
Test: editing/pasteboard/paste-before-tab-span.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after positionAvoidingPrecedingNodes, since that function could once again put our position inside a tab span.
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
- editing/pasteboard/paste-before-tab-span-expected.txt: Added.
- editing/pasteboard/paste-before-tab-span.html: Added.
- 11:26 PM Changeset in webkit [84884] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict error in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=59422
Reviewed by Adam Barth.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
- 11:24 PM Changeset in webkit [84883] by
-
- 7 edits in trunk/Source/WebKit/mac
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit1 should build cleanly with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59424
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/WebNetscapePluginEventHandler.h:
- Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
- WebView/WebDeviceOrientationProviderMock.mm:
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]):
- 11:23 PM Changeset in webkit [84882] by
-
- 5 edits2 adds in trunk
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
SunSpider reports no change.
The hasCustomProperties() check didn't check for a custom prototype.
- runtime/JSObject.h: (JSC::JSObject::hasCustomProperties): Changed to delegate to Structure because it is the "truth" about an object's pedigree.
- runtime/Structure.cpp: (JSC::Structure::Structure):
- runtime/Structure.h: (JSC::Structure::didTransition): Track whether a Structure has ever transitioned for any reason. If so, we have to assume that the object holding it is custom in some way.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
- fast/dom/gc-custom-prototype-expected.txt: Added.
- fast/dom/gc-custom-prototype.html: Added.
- fast/dom/script-tests/dataset-gc.js:
- 11:22 PM Changeset in webkit [84881] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr violations and whitelist known-tricky files
https://bugs.webkit.org/show_bug.cgi?id=59421
With this patch, WebCore builds cleanly with strict OwnPtrs.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort):
- dom/XMLDocumentParserLibxml2.cpp:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu):
- page/PluginHalter.cpp:
- platform/graphics/MediaPlayer.cpp:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
- svg/SVGDocumentExtensions.cpp:
- 11:07 PM April 2011 Meeting edited by
- (diff)
- 10:57 PM April 2011 Meeting edited by
- (diff)
- 10:56 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM Changeset in webkit [84880] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in DatasetDOMStringMap.h.
https://bugs.webkit.org/show_bug.cgi?id=59419
Reviewed by Adam Barth.
- dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::create):
- 10:40 PM Changeset in webkit [84879] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Eric Seidel.
KeyboardEvent.cpp should work with strict OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=59403
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent):
- 10:25 PM April 2011 Meeting edited by
- (diff)
- 10:24 PM April 2011 Meeting edited by
- (diff)
- 10:22 PM April 2011 Meeting edited by
- Adding the Oslo webkittens (diff)
- 10:10 PM Changeset in webkit [84878] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Update some call sites that referenced the old location for
the scripts {animation, transition}-test-helpers.js. These
scripts were moved in <http://trac.webkit.org/changeset/84872>,
and <http://trac.webkit.org/changeset/84874>, respectively.
- compositing/animation/computed-style-during-delay.html:
- compositing/reflections/animation-inside-reflection.html:
- compositing/reflections/nested-reflection-animated.html:
- compositing/reflections/nested-reflection-transition.html:
- compositing/transitions/scale-transition-no-start.html:
- compositing/transitions/singular-scale-transition.html:
- 10:05 PM Changeset in webkit [84877] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- 10:05 PM April 2011 Meeting edited by
- (diff)
- 9:57 PM April 2011 Meeting edited by
- (diff)
- 9:53 PM Changeset in webkit [84876] by
-
- 2 edits in trunk/Tools
Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 9:47 PM April 2011 Meeting edited by
- (diff)
- 9:34 PM April 2011 Meeting edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:01 PM April 2011 Meeting edited by
- (diff)
- 8:44 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:40 PM April 2011 Meeting edited by
- (diff)
- 8:37 PM April 2011 Meeting edited by
- Fix tony's nick (diff)
- 8:32 PM April 2011 Meeting edited by
- (diff)
- 8:31 PM April 2011 Meeting edited by
- (diff)
- 8:25 PM Changeset in webkit [84875] by
-
- 70 edits in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Clean up transition tests
https://bugs.webkit.org/show_bug.cgi?id=59410
General test cleanup: use the named variables as
arguments to runTransitionTest() for readability,
remove unnecessary titles and meta tags, remove
style and script tag attributes etc. No substantive
changes.
- 8:25 PM April 2011 Meeting edited by
- Fix the attendee list (diff)
- 8:24 PM April 2011 Meeting edited by
- Added some attendees (diff)
- 8:17 PM Changeset in webkit [84874] by
-
- 30 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move transition-test-helpers.js to resources/
https://bugs.webkit.org/show_bug.cgi?id=59397
Move transition-test-helpers.js and fix tests.
- transitions/background-transitions.html:
- transitions/border-radius-transition.html:
- transitions/clip-transition.html:
- transitions/color-transition-all.html:
- transitions/color-transition-premultiplied.html:
- transitions/default-timing-function.html:
- transitions/font-family-during-transition.html:
- transitions/mask-transitions.html:
- transitions/min-max-width-height-transitions.html:
- transitions/mismatched-shadow-styles.html:
- transitions/move-after-transition.html:
- transitions/multiple-background-size-transitions.html:
- transitions/multiple-background-transitions.html:
- transitions/multiple-mask-transitions.html:
- transitions/multiple-shadow-transitions.html:
- transitions/negative-delay.html:
- transitions/resources/interrupted-accelerated-transition-final.html:
- transitions/resources/transition-test-helpers.js: (roundNumber): (isCloseEnough): (isShadow): (): (expected): (callback.delay):
- transitions/shorthand-border-transitions.html:
- transitions/shorthand-transitions.html:
- transitions/steps-timing-function.html:
- transitions/svg-text-shadow-transition.html:
- transitions/text-indent-transition.html:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match.html:
- transitions/transition-drt-api-delay.html:
- transitions/transition-end-event-rendering.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-shorthand-delay.html:
- transitions/zero-duration-in-list.html:
- 8:16 PM Changeset in webkit [84873] by
-
- 4 edits2 adds4 deletes in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Make a couple of animation tests into text tests
https://bugs.webkit.org/show_bug.cgi?id=59389
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html: No need for these two to be text tests.
- animations/state-at-end-event.html: General cleanup.
- animations/animation-drt-api-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/state-at-end-event.html:
- platform/mac/animations/animation-drt-api-expected.png: Removed.
- platform/mac/animations/animation-drt-api-expected.txt: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
- 8:16 PM Changeset in webkit [84872] by
-
- 48 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move animation-test-helpers.js into resources directory
https://bugs.webkit.org/show_bug.cgi?id=59365
Move animation-test-helpers.js and fix the tests accordingly.
- animations/3d/matrix-transform-type-animation.html:
- animations/3d/transform-perspective.html:
- animations/animation-direction.html:
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/big-rotation.html:
- animations/change-keyframes-name.html:
- animations/change-keyframes.html:
- animations/change-one-anim.html:
- animations/combo-transform-rotate+scale.html:
- animations/dynamic-stylesheet-loading.html:
- animations/generic-from-to.html:
- animations/import.html:
- animations/keyframe-timing-functions-transform.html:
- animations/keyframe-timing-functions.html:
- animations/keyframe-timing-functions2.html:
- animations/keyframes-comma-separated.html:
- animations/keyframes-out-of-order.html:
- animations/keyframes.html:
- animations/lineheight-animation.html:
- animations/longhand-timing-function.html:
- animations/matrix-anim.html:
- animations/missing-from-to-transforms.html:
- animations/missing-from-to.html:
- animations/missing-keyframe-properties-repeating.html:
- animations/missing-keyframe-properties-timing-function.html:
- animations/missing-keyframe-properties.html:
- animations/missing-values-first-keyframe.html:
- animations/missing-values-last-keyframe.html:
- animations/multiple-animations.html:
- animations/multiple-keyframes.html:
- animations/negative-delay.html:
- animations/opacity-transform-animation.html:
- animations/play-state-suspend.html:
- animations/play-state.html:
- animations/resources/animation-test-helpers.js: (isCloseEnough): (matrixStringToArray): (checkExpectedValue): (endTest): (startTest): (runAnimationTest.else): (runAnimationTest): (waitForAnimationToStart):
- animations/simultaneous-start-left.html:
- animations/simultaneous-start-transform.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation.html:
- animations/timing-functions.html:
- animations/transition-and-animation-1.html:
- animations/transition-and-animation-2.html:
- animations/transition-and-animation-3.html:
- animations/unanimated-style.html:
- animations/width-using-ems.html:
- 8:14 PM Changeset in webkit [84871] by
-
- 3 edits2 deletes in trunk
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- svg/custom/use-crash-in-non-wellformed-document.svg: Removed.
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument):
- 8:00 PM Changeset in webkit [84870] by
-
- 2 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84753.
- 8:00 PM Changeset in webkit [84869] by
-
- 5 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84752.
- 7:59 PM Changeset in webkit [84868] by
-
- 5 edits in tags/Safari-534.31.1/Source
Versioning.
- 7:56 PM Changeset in webkit [84867] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing, add missing baselines for Chromium Mac SL.
- platform/chromium/test_expectations.txt:
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- 7:48 PM Changeset in webkit [84866] by
-
- 1 copy in tags/Safari-534.31.1
New tag.
- 7:26 PM Changeset in webkit [84865] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/focusingUnloadedFrame.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59371
- fast/events/focusingUnloadedFrame-expected.txt: Added.
- fast/events/focusingUnloadedFrame.html:
- platform/chromium-linux/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/mac-leopard/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- 7:07 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM Changeset in webkit [84864] by
-
- 3 edits2 adds in trunk
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
- svg/SVGUseElement.cpp: (WebCore::isWellFormedDocument): (WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
Test case to verify webkit doesn't crash when a <use> element
is pending on resource and the document is not well-formed.
Test passes if no crash occurs in debug mode.
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
- svg/custom/use-crash-in-non-wellformed-document.svg: Added.
- 7:02 PM TextInputTestSuite created by
- 7:02 PM Changeset in webkit [84863] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Convert fast/loader/start-load-in-unload.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59384
- fast/loader/start-load-in-unload-expected.txt: Added.
- fast/loader/start-load-in-unload.html:
- platform/chromium-linux/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/mac-leopard/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/qt/fast/loader/start-load-in-unload-expected.txt: Removed.
- 7:01 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM Changeset in webkit [84862] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Tony Chang <tony@chromium.org>
Reviewed by Antonio Gomes.
replace a setTimeout with a onload event to save 2 seconds in a test
https://bugs.webkit.org/show_bug.cgi?id=59350
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:
- 6:44 PM Changeset in webkit [84861] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/event-sender-mouse-moved.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59366
- fast/events/event-sender-mouse-moved-expected.txt: Added.
- fast/events/event-sender-mouse-moved.html:
- platform/chromium-linux/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/gtk/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/mac-leopard/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/qt/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- 6:40 PM Changeset in webkit [84860] by
-
- 11 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.
Reviewed by Geoff Garen.
If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.
Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
- dfg/DFGSpeculativeJIT.h:
- runtime/Executable.cpp:
(JSC::tryDFGCompile):
- 6:28 PM Changeset in webkit [84859] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the news file for the 1.4.0 release.
- NEWS: Update news.
- 6:23 PM Changeset in webkit [84858] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing.
- platform/chromium/test_expectations.txt:
- 5:31 PM Changeset in webkit [84857] by
-
- 15 edits1 copy in trunk/Source/WebCore
2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Tony Chang.
Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028
The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
Moving the code for base class we can reduce the efforts to support DataTransferItems
element in different platforms.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem): (WebCore::DataTransferItem::owner): (WebCore::DataTransferItem::kind): (WebCore::DataTransferItem::type):
- dom/DataTransferItem.h:
- dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp. (WebCore::DataTransferItems::DataTransferItems): (WebCore::DataTransferItems::length): (WebCore::DataTransferItems::item): (WebCore::DataTransferItems::deleteItem): (WebCore::DataTransferItems::clear): (WebCore::DataTransferItems::add):
- dom/DataTransferItems.h:
- platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItem::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
- platform/chromium/DataTransferItemChromium.h:
- platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
- platform/chromium/DataTransferItemsChromium.h:
- 5:24 PM Changeset in webkit [84856] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION(75137): directly composited images are double-drawn sometimes
https://bugs.webkit.org/show_bug.cgi?id=58632
Depending on the order of operations (layout, creating compositing
layers and creating simple image layers) a layer can have both image
content and have m_drawsContent=true. In this case 2 copies of the image
are drawn in the layer. If the image has alpha, it looks wrong.
I added an updateDrawsContent() call after setting the image contents
to make sure it's correct.
I couldn't create a test case that shows the problem because layerTreeAsText()
doesn't emit enough info to show this level of detail. I've opened
https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
- 5:18 PM Changeset in webkit [84855] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400
Reviewed by James Robinson.
- wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
- 5:13 PM Changeset in webkit [84854] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in InlineFlowBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=59392
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::setLayoutOverflow): (WebCore::InlineFlowBox::setVisualOverflow):
- 5:11 PM Changeset in webkit [84853] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in TransformState.cpp
https://bugs.webkit.org/show_bug.cgi?id=59380
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- 5:07 PM Changeset in webkit [84852] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
DOMWindow.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59356
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessageTimerFired):
- page/DOMWindow.h:
- 5:06 PM Changeset in webkit [84851] by
-
- 6 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 5:04 PM Changeset in webkit [84850] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Re-land changes to ValidationMessage.
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 5:00 PM Changeset in webkit [84849] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Change FAILS_ to DISABLED_ in r84813.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 4:56 PM Changeset in webkit [84848] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Ojan Vafai <ojan@chromium.org>
Reviewed by James Robinson.
fix OwnPtr strict error in FrameView.cpp
https://bugs.webkit.org/show_bug.cgi?id=59402
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::addWidgetToUpdate):
- 4:55 PM Changeset in webkit [84847] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r84844.
http://trac.webkit.org/changeset/84844
https://bugs.webkit.org/show_bug.cgi?id=59395
Checked in too much.
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:54 PM Changeset in webkit [84846] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
JavaScriptCore should play nice strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59401
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
- heap/Heap.cpp: (JSC::TypeCounter::TypeCounter):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope):
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
- 4:52 PM Changeset in webkit [84845] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
Make ActiveDOMCallback play nice with OwnPtr strict mode
https://bugs.webkit.org/show_bug.cgi?id=59398
- bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMCallback::ActiveDOMCallback):
- 4:51 PM Changeset in webkit [84844] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:45 PM Changeset in webkit [84843] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r84835.
http://trac.webkit.org/changeset/84835
https://bugs.webkit.org/show_bug.cgi?id=59394
Breaks compile because Deque<OwnPtr> doesn't work
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:43 PM Changeset in webkit [84842] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Sam Weinig.
Fix OwnPtr strict mode violation in ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=59396
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
- 4:43 PM Changeset in webkit [84841] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378
Reviewed by Adam Roben.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.
- 4:41 PM Changeset in webkit [84840] by
-
- 5 edits1 copy in trunk/Tools
2011-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
https://bugs.webkit.org/show_bug.cgi?id=56090
Make LeaksViewer work with versions of browsers that don't support message
passing of cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: (LeaksParser.this._worker.onmessage): (LeaksParser): (LeaksParser.prototype.addLeaksFile): Use LeaksParserImpl directly if we don't support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js. (LeaksParserImpl): (LeaksParserImpl.prototype.addLeaksFile): (LeaksParserImpl.prototype._incorporateLeaks):
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: (onmessage): Factor out LeaksParser implementation into LeaksParserImpl.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: (workersSupportCyclicStructures): Add function to detect if workers support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Add LeaksParserImpl.js include.
- 4:41 PM Changeset in webkit [84839] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Convert a test to dump as text.
Reviewed by Sam Weinig.
- fast/dom/jsDevicePixelRatio-expected.txt: Added.
- fast/dom/jsDevicePixelRatio.html:
- platform/chromium-linux/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/mac-leopard/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- 4:39 PM Changeset in webkit [84838] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Huang Dongsung <luxtella@company100.net>
Reviewed by Dirk Schulze.
[Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
https://bugs.webkit.org/show_bug.cgi?id=59308
An unused local variable is created and even allocates heap memory.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- 4:37 PM Changeset in webkit [84837] by
-
- 3 edits in trunk/Source/WebCore
Qt build fix: Updated files not used by other ports for rename.
- bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):
- 4:36 PM Changeset in webkit [84836] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
WebCore/css/CSS* files should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59382
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::parseValue):
- 4:35 PM Changeset in webkit [84835] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:35 PM Changeset in webkit [84834] by
-
- 3 edits in trunk/LayoutTests
2011-04-25 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline and skip a couple of failing tests.
- platform/gtk/Skipped: skip http/tests/security/mixedContent/insecure-css-in-main-frame.html and editing/text-iterator/findString.html
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- 4:30 PM Changeset in webkit [84833] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strictness issues in WebCore/inspector/
https://bugs.webkit.org/show_bug.cgi?id=59387
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::ensureSourceData):
- 4:25 PM Changeset in webkit [84832] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381
Reviewed by Beth Dakin.
This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
- dom/Node.h: Hello fast code!
- xml/XPathNamespace.cpp: Removed.
- xml/XPathNamespace.h: Removed.
- 4:25 PM Changeset in webkit [84831] by
-
- 1 edit1 add8 deletes in trunk/LayoutTests
Move text-only results of a test that was switched to dump as text in r72166
alongside the test, and remove old expected pixel results.
- fast/dom/setPrimitiveValue-expected.txt: Added.
- platform/chromium-linux/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/chromium-win/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/gtk/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/mac-leopard/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.txt: Removed.
- 4:24 PM Changeset in webkit [84830] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HistoryItemMac should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59388
- history/mac/HistoryItemMac.mm: (WebCore::HistoryItem::setTransientProperty):
- 4:20 PM Changeset in webkit [84829] by
-
- 2 edits in trunk/Source/WebCore
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375
Reviewed by Kenneth Russell.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):
- 4:19 PM Changeset in webkit [84828] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
CheckedRadioButton should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59386
- dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::addButton):
- 4:17 PM Changeset in webkit [84827] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Resource*.cpp should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59383
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- 4:15 PM Changeset in webkit [84826] by
-
- 2 edits in trunk/Tools
2011-04-25 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
https://bugs.webkit.org/show_bug.cgi?id=59373
- Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
- 4:14 PM Changeset in webkit [84825] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- wtf/ListHashSet.h:
- 4:09 PM Changeset in webkit [84824] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>
Reviewed by Timothy Hatcher.
When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
and height.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.
- 4:09 PM Changeset in webkit [84823] by
-
- 2 edits1 move8 deletes in trunk/LayoutTests
Convert fast/events/label-focus.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=59364
Reviewed by Adam Roben.
- fast/events/label-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/events/label-focus-expected.txt.
- fast/events/label-focus.html:
- platform/chromium-linux/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.txt: Removed.
- platform/gtk/fast/events/label-focus-expected.png: Removed.
- platform/gtk/fast/events/label-focus-expected.txt: Removed.
- platform/mac-leopard/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.txt: Removed.
- platform/qt/fast/events/label-focus-expected.txt: Removed.
- 4:08 PM Changeset in webkit [84822] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59374
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::initGroup):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserScriptToWorld): (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/mac/PageMac.cpp: (WebCore::Page::addSchedulePair):
- 4:06 PM Changeset in webkit [84821] by
-
- 2 edits in trunk/Source/JavaScriptCore
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 4:02 PM Changeset in webkit [84820] by
-
- 2 edits in trunk/Source/WebCore
Build fix: This time for sure!
- dom/make_names.pl:
- 3:58 PM Changeset in webkit [84819] by
-
- 2 edits in trunk/Source/WebCore
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.
- dom/make_names.pl:
- 3:57 PM Changeset in webkit [84818] by
-
- 2 edits1 add6 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Sam Weinig.
- fast/css/affected-by-hover-after-style-change.html:
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84817] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362
- fast/events/onloadFrameCrash-expected.txt: Added.
- fast/events/onloadFrameCrash.html: Modified to dump as text.
- platform/gtk/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/gtk/fast/events/onloadFrameCrash-expected.txt: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84816] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=59368
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
- 3:54 PM Changeset in webkit [84815] by
-
- 10 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix strict OwnPtr violations in Render*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59361
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
- rendering/RenderBox.cpp: (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
- rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::ensureBacking):
- rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
- rendering/RenderView.cpp: (WebCore::RenderView::compositor):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::addCachedPseudoStyle): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/SVGResources.cpp: (WebCore::SVGResources::SVGResources):
- 3:48 PM Changeset in webkit [84814] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Attempt to fix the compile.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::loadWithNextMediaEngine):
- 3:47 PM Changeset in webkit [84813] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by James Robinson.
Suppress test failure in Chromium webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=59358
Looks like this started failing after
http://trac.webkit.org/changeset/84631.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 3:47 PM Changeset in webkit [84812] by
-
- 18 edits in trunk/Source/WebCore
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.
Rubber-stamped by Beth Dakin.
- bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
- 3:45 PM Changeset in webkit [84811] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
HTMLDocumentParser should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59363
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
- 3:41 PM Changeset in webkit [84810] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Frame.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59360
- page/Frame.cpp: (WebCore::createRegExpForLabels):
- 3:39 PM Changeset in webkit [84809] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Adam Roben.
- fast/css/zoom-property-parsing-expected.txt: Added.
- fast/css/zoom-property-parsing.html:
- platform/chromium-linux/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/mac-leopard/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.txt: Removed.
- 3:38 PM Changeset in webkit [84808] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr in Element.cpp
https://bugs.webkit.org/show_bug.cgi?id=59357
- dom/NodeRareData.h: (WebCore::NodeRareData::ensureEventTargetData):
- 3:32 PM Changeset in webkit [84807] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Missed the Chromium Mac baseline in the previous change.
- platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 3:28 PM Changeset in webkit [84806] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr issues in Media*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59354
There's still a tricky case in MediaPlayer.cpp, but we'll worry about
that later.
- css/MediaQueryMatcher.cpp: (WebCore::MediaQueryMatcher::addListener):
- dom/Document.cpp:
- platform/graphics/MediaPlayer.cpp: (WebCore::createNullMediaPlayer):
- 3:22 PM Changeset in webkit [84805] by
-
- 4 edits in trunk/Source
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- wtf/ListHashSet.h: (WTF::::ListHashSet):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor):
- 2:48 PM Changeset in webkit [84804] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347
Reviewed by Adam Barth.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 2:48 PM Changeset in webkit [84803] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 2:48 PM Changeset in webkit [84802] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Worker*.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59346
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::createResourceRequest):
- 2:31 PM April 2011 Meeting/WebKit2 created by
- 2:30 PM April 2011 Meeting edited by
- (diff)
- 2:21 PM Changeset in webkit [84801] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Remove bad use of OwnPtr::set() in IconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=59344
Needed for strict OwnPtr compliance.
- loader/icon/IconDatabase.cpp: (WebCore::readySQLiteStatement):
- 2:21 PM Changeset in webkit [84800] by
-
- 11 edits in trunk/Source/JavaScriptCore
2011-04-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make ClassInfo required when creating a Structure
https://bugs.webkit.org/show_bug.cgi?id=59340
Add ClassInfo to all those types which currently don't
have it, and add an assertion to Structure::create to
ensure that the provided classInfo is not null.
- runtime/Executable.h: (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
- runtime/GetterSetter.cpp:
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSString.cpp:
- runtime/JSString.h: (JSC::RopeBuilder::createStructure):
- runtime/Structure.h: (JSC::Structure::create): (JSC::JSCell::createDummyStructure):
- 2:16 PM Changeset in webkit [84799] by
-
- 2 edits in trunk/Source/JavaScriptCore
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342
Reviewed by Adam Barth.
This patch is to prepare for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):
- 1:57 PM Changeset in webkit [84798] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
ImageBuffer.h should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59341
This patch is to prepare for the strict OwnPtr hack-a-thon.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):
- 1:50 PM Changeset in webkit [84797] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
WebCore build on Windows should include windows.h in its precompiled header to speed builds
https://bugs.webkit.org/show_bug.cgi?id=59339
windows.h is included by several of the underlying wtf headers, including Atomics.h and
ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
(a 12% speedup).
- WebCorePrefix.h: Include windows.h
- 1:19 PM Changeset in webkit [84796] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950
split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
and apply related changes (only for SH4 platforms).
- assembler/MacroAssemblerSH4.cpp:
- assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::compare32): (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerSH4::branchDouble): (JSC::MacroAssemblerSH4::branch32): (JSC::MacroAssemblerSH4::branchTest8): (JSC::MacroAssemblerSH4::branch8): (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32): (JSC::MacroAssemblerSH4::test8): (JSC::MacroAssemblerSH4::branch16): (JSC::MacroAssemblerSH4::branchTest32): (JSC::MacroAssemblerSH4::branchAdd32): (JSC::MacroAssemblerSH4::branchMul32): (JSC::MacroAssemblerSH4::branchSub32): (JSC::MacroAssemblerSH4::branchOr32): (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32): (JSC::MacroAssemblerSH4::branchPtrWithPatch): (JSC::MacroAssemblerSH4::SH4Condition):
- assembler/SH4Assembler.h: (JSC::SH4Assembler::cmpEqImmR0):
- 1:16 PM Changeset in webkit [84795] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PropertyMapHashTable should work with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59337
This patch is in preparation for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::addDeletedOffset):
- 1:04 PM Changeset in webkit [84794] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebCore
Merging r84793
- 1:00 PM Changeset in webkit [84793] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
https://bugs.webkit.org/show_bug.cgi?id=59311
- platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar disconnect any lingering signal handlers. This prevents an adjustment from controlling the active ScrollView and some zombie ScrollView.
- 12:34 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:23 PM Changeset in webkit [84792] by
-
- 2 edits in trunk/Source/JavaScriptCore
Nixed MarkStack::deprecatedAppend, since it has no clients left.
Reviewed by Sam Weinig.
- heap/MarkStack.h:
- 12:23 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:21 PM Changeset in webkit [84791] by
-
- 3 edits in trunk/Source/WebCore
Another shot at fixing the EFL build.
- UseJSC.cmake:
- bindings/js/JSDOMBinding.cpp:
- 12:14 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:13 PM Changeset in webkit [84790] by
-
- 2 edits in trunk/Source/WebCore
Try to fix EFL build.
- UseJSC.cmake: Added a missing file.
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:02 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:01 PM QtWebKitFeatures21 edited by
- (diff)
- 11:56 AM Changeset in webkit [84789] by
-
- 27 edits in trunk/Source/WebCore
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=59333
- WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
- bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject lifetime management.
- dom/Document.idl: No need for a custom mark function anymore, since ActiveDOMObjets now manage their own lifetimes.
- dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity): Correctly report that we have pending activity when we're remotely entangled, instead of relying on our clients to know this about us and do the check for us.
- dom/MessagePort.h: FIXME!
- dom/MessagePort.idl:
- fileapi/DOMFileSystem.idl:
- fileapi/FileReader.idl:
- fileapi/FileWriter.idl:
- notifications/Notification.idl:
- notifications/NotificationCenter.idl:
- page/EventSource.idl:
- storage/IDBDatabase.idl:
- storage/IDBRequest.idl:
- storage/IDBTransaction.idl:
- webaudio/AudioContext.idl:
- websockets/WebSocket.idl:
- workers/AbstractWorker.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): No need to make up for MessagePort::hasPendingActivity being wrong anymore, since it's now right.
- xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
- 11:55 AM detect a RenderObject is destroyed unsafely created by
- 11:48 AM April 2011 Meeting edited by
- (diff)
- 11:47 AM April 2011 Meeting edited by
- (diff)
- 11:33 AM April 2011 Meeting Hardware Acceleration Track created by
- 11:32 AM April 2011 Meeting/Getting compile time under control created by
- 11:31 AM April 2011 Meeting edited by
- (diff)
- 11:24 AM QtWebKitFeatures21 edited by
- (diff)
- 11:15 AM Changeset in webkit [84788] by
-
- 2 edits2 copies in branches/chromium/742
Merge 84755 - 2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 * fast/table/auto-100-percent-width.html: Added. * platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 Test: fast/table/auto-100-percent-width.html * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
TBR=commit-queue@webkit.org
- 11:02 AM Changeset in webkit [84787] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2]fast/dom/shadow/gc-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=59335
- platform/qt-wk2/Skipped: Add fast/dom/shadow/gc-shadow.html.
- 10:47 AM Changeset in webkit [84786] by
-
- 2 edits in trunk/LayoutTests
[Qt] New tests introduced in r84742 fail
https://bugs.webkit.org/show_bug.cgi?id=59334
- platform/qt/Skipped:
- 10:41 AM Changeset in webkit [84785] by
-
- 15 edits in trunk/Source/WebKit2
Windows part of - WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>
Reviewed by Adam Roben.
Implement attaching and detaching of the Web Inspector on Windows,
and also support setAttachedWindowHeight when the user changes the height
of the docked inspector.
This patch doesn't remember whether the user prefers attached or detached, and
doesn't remember the user's preferred docked height, but that will be a separate
bug.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code.
(WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose
calls detach if the inspector was docked, and detach needs to know whether or not the window is
visible.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Add new messages.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageClient): Add a getter for the page client.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected
web view to the WebInspectorProxy.
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well
with the docked inspector.
(WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying.
(WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent
window, so the inspected web view and the inspector are siblings.
(WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach.
(WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend
from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the
inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is
something WebCore should handle.
(WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty.
This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message
from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attach): Send a message to the UIProcess.
(WebKit::WebInspector::detach): Ditto.
(WebKit::WebInspector::setAttachedWindowHeight): Ditto.
- WebProcess/WebPage/WebInspector.h: Remove some dead code.
- 10:37 AM April 2011 Meeting edited by
- (diff)
- 10:24 AM Changeset in webkit [84784] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; add failing test to mac-wk2/Skipped list.
- platform/mac-wk2/Skipped:
- 10:19 AM Changeset in webkit [84783] by
-
- 1 edit5 adds in trunk/LayoutTests
[Snow Leopard Intel WebKit2 Release Tests] editing/undo/undo-iframe-location-change.html and
compositing/iframes/invisible-nested-iframe-show.html failing since r84037.
https://bugs.webkit.org/show_bug.cgi?id=58990
Add failing expected results for SL WK2 to get the bots green.
These tests are already Skipped on Windows or have their own expected results.
- platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/mac-wk2/editing/undo/undo-iframe-location-change-expected.txt: Added.
- 10:18 AM Changeset in webkit [84782] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 10:10 AM Changeset in webkit [84781] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector: Support highlighting page elements
https://bugs.webkit.org/show_bug.cgi?id=59263
<rdar://problem/8767659>
Reviewed by Alice Liu.
Support highlighting of page elements for the inspector in WebKit2 by
having the WebInspectorClient be a PageOverlay Client and be responsible
for calling InspectorController::drawNodeHighlight.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created,
or call setNeedsDisplay if it has.
(WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists.
(WebKit::WebInspectorClient::pageOverlayDestroyed):
(WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null
WebPage), clear the member variable.
(WebKit::WebInspectorClient::didMoveToWebPage):
(WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight.
(WebKit::WebInspectorClient::mouseEvent):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable.
- 10:04 AM April 2011 Meeting edited by
- (diff)
- 10:00 AM April 2011 Meeting edited by
- (diff)
- 9:57 AM April 2011 Meeting edited by
- (diff)
- 9:47 AM Changeset in webkit [84780] by
-
- 6 edits1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: worker messages should be routed to corresponding worker front-end
https://bugs.webkit.org/show_bug.cgi?id=59323
Added WorkerManager which is responsible for routing messages between
Page inspector front-end and Worker inspector front-ends.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkerManager.js: Added. (WebInspector.WorkerManager): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded): (WebInspector.WorkerManager.loaded): (WebInspector.WorkerFrontendStub): (WebInspector.WorkerFrontendStub.prototype._receiveMessage): (WebInspector.WorkerDispatcher): (WebInspector.WorkerDispatcher.prototype._receiveMessage): (WebInspector.WorkerDispatcher.prototype.workerCreated): (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 9:45 AM April 2011 Meeting edited by
- Moar (diff)
- 9:45 AM Changeset in webkit [84779] by
-
- 2 edits in trunk/Tools
2011-04-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a few Chromium contributors to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 9:39 AM Changeset in webkit [84778] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] Should be easy to copy data.
https://bugs.webkit.org/show_bug.cgi?id=45662
Adds context menu items to copy resource location, resource request headers, and resource response headers.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
- 9:32 AM April 2011 Meeting edited by
- (diff)
- 9:24 AM April 2011 Meeting edited by
- (diff)
- 9:22 AM April 2011 Meeting edited by
- (diff)
- 9:20 AM April 2011 Meeting edited by
- (diff)
- 9:19 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:14 AM April 2011 Meeting edited by
- (diff)
- 9:06 AM April 2011 Meeting edited by
- (diff)
- 8:51 AM Changeset in webkit [84777] by
-
- 3 edits4 adds in trunk
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
- inspector/styles/parse-utf8-bom-expected.txt: Added.
- inspector/styles/parse-utf8-bom.html: Added.
- inspector/styles/resources/parse-utf8-bom-main.css: Added. (h1): (h2):
- inspector/styles/resources/parse-utf8-bom-reset.css: Added.
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
Use TextResourceDecoder to determine external stylesheet charsets correctly.
Test: inspector/styles/parse-utf8-bom.html
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::originalStyleSheetText):
- 8:13 AM Changeset in webkit [84776] by
-
- 2 edits in trunk/LayoutTests
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 7:38 AM April 2011 Meeting edited by
- (diff)
- 7:27 AM April 2011 Meeting edited by
- (diff)
- 7:18 AM Changeset in webkit [84775] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: Inspector.json cleanup.
- inspector/Inspector.json:
- 7:12 AM Changeset in webkit [84774] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: move Frame and Resource Tree management into the Page agent.
https://bugs.webkit.org/show_bug.cgi?id=59321
- inspector/report-protocol-errors.html:
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 7:01 AM April 2011 Meeting edited by
- (diff)
- 6:27 AM Changeset in webkit [84773] by
-
- 19 edits2 copies1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 4:25 AM Changeset in webkit [84772] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- Page domain is documented
- setUserAgentOverride is moved to the Network agent
- setSearchingForNode -> setInspectModeEnabled
- highlightDOMNode -> highlightNode
- reloadPage -> reload
- openInNewWindow -> open with optional parameter
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setInspectModeEnabled): (WebCore::InspectorDOMAgent::highlightNode):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideNodeHighlight):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::clearFrontend): (WebCore::InspectorPageAgent::reload): (WebCore::InspectorPageAgent::open):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
- inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.openResource): (WebInspector.documentKeyDown):
- 4:18 AM Changeset in webkit [84771] by
-
- 11 edits1 delete in trunk/Source/WebKit/efl
2011-04-25 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Remove ewk_eapi.h
https://bugs.webkit.org/show_bug.cgi?id=59091
- ewk/EWebKit.h:
- ewk/ewk_contextmenu.h:
- ewk/ewk_cookies.h:
- ewk/ewk_eapi.h: Removed.
- ewk/ewk_frame.h:
- ewk/ewk_history.h:
- ewk/ewk_main.h:
- ewk/ewk_settings.h:
- ewk/ewk_tiled_matrix.h:
- ewk/ewk_tiled_model.h:
- ewk/ewk_window_features.h:
- 2:59 AM Changeset in webkit [84770] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Fix tests after URL parsing fix
https://bugs.webkit.org/show_bug.cgi?id=59317
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Update expectations.
- fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Update expectations.
- fast/loader/url-parse-1-expected.txt: Update expectations.
- http/tests/loading/cross-origin-XHR-willLoadRequest.html: Replace single slash in an http: URL with a double slash - the single slash seemed to be erroneous.
- 1:26 AM Changeset in webkit [84769] by
-
- 16 edits in trunk/Source
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
Switch the scrollbar's overlay style depending on its frame's background color.
This refactors the getDocumentBackgroundColor method needed for gestures. The style
is determined and set on every paint() call to the Mac scrollbar theme.
- WebCore.exp.in: adding method to allow changing style
- page/Frame.cpp: (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
- page/Frame.h:
- page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
- page/FrameView.h:
- platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
- platform/ScrollableArea.h: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color
- 12:29 AM April 2011 Meeting edited by
- (diff)
- 12:28 AM Changeset in webkit [84768] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Added Radar link
- 12:26 AM Changeset in webkit [84767] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315
Reviewed by Maciej Stachowiak.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize new member variables.
(WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
is scrolled a distance equal to the change in the mouse position.
(WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
the document rather than the thumb, and pass the result to moveThumb.
(WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
- platform/Scrollbar.h:
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
returns false.
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
Option key is down.
Apr 24, 2011:
- 11:47 PM April 2011 Meeting edited by
- (diff)
- 11:45 PM April 2011 Meeting edited by
- (diff)
- 11:22 PM Changeset in webkit [84766] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-04-24 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Add Chromium baselines for fast/table/auto-100-percent-width.html.
Mark fast/dom/HTMLMeterElement/meter-element.html and
http/tests/misc/will-send-request-returns-null-on-redirect.html
as failing - need triage.
- platform/chromium-mac/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium-win/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:02 PM April 2011 Meeting edited by
- (diff)
- 10:36 PM Changeset in webkit [84765] by
-
- 4 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html (again).
- platform/chromium-linux/fast/url/standard-url-expected.txt:
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 10:12 PM April 2011 Meeting edited by
- adding /me to interesting talkings (diff)
- 9:56 PM April 2011 Meeting edited by
- (diff)
- 9:55 PM April 2011 Meeting edited by
- (diff)
- 9:22 PM ThreadCommunication edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:06 PM April 2011 Meeting edited by
- (diff)
- 8:49 PM April 2011 Meeting edited by
- (diff)
- 8:43 PM April 2011 Meeting edited by
- (diff)
- 7:43 PM April 2011 Meeting edited by
- (diff)
- 5:47 PM Changeset in webkit [84764] by
-
- 80 edits in trunk/Source/WebCore
2011-04-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
https://bugs.webkit.org/show_bug.cgi?id=59307
- WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSDOMBinding.h: (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because they're reasonably generic.
- bindings/js/JSDOMImplementationCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSDOMTokenListCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper. This is one of the few cases where a DOM object is considered a stand-alone root. It's not as efficient as the shared root case, but workers and message ports are very rare objects, so it's no big deal.
- bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
- bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
- bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, a stand-alone root.
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots system for marking WebGL contexts and their associated satellite objects.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, stand-alone roots.
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner XHR because it is not reachable from us.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/MediaList.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/MessagePort.idl:
- dom/NamedNodeMap.idl:
- fileapi/Blob.idl:
- html/DOMTokenList.idl: Opt in to autogeneration.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
- html/HTMLCollection.idl:
- html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::ref): (WebCore::CanvasRenderingContext::deref):
- html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::create): (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
Inlined some functions to match our standard idiom and to make the code
in the header document itself.
- html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
- html/canvas/OESStandardDerivatives.cpp: (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::create):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.cpp: (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::create):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESVertexArrayObject.cpp: (WebCore::OESVertexArrayObject::OESVertexArrayObject): (WebCore::OESVertexArrayObject::create):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLExtension.cpp: (WebCore::WebGLExtension::WebGLExtension):
- html/canvas/WebGLExtension.h: (WebCore::WebGLExtension::ref): (WebCore::WebGLExtension::deref): (WebCore::WebGLExtension::context):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::~WebGLRenderingContext): (WebCore::WebGLRenderingContext::getExtension):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
- html/canvas/WebKitLoseContext.h:
- html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL canavs rendering contexts to match the model for 2D canvas rendering contexts. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable. (Previously, satellite objects would magically stop working when the last reference to their owner object was dropped. Now, satellite objects keep their owner alive through reference counting.)
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- page/WorkerNavigator.idl:
- plugins/DOMMimeTypeArray.h: (WebCore::DOMMimeTypeArray::frame):
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPluginArray.h: (WebCore::DOMPluginArray::frame):
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- workers/WorkerLocation.idl: Opt in to autogeneration.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
- xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::ref): (WebCore::XMLHttpRequestUpload::deref): (WebCore::XMLHttpRequestUpload::xmlHttpRequest): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
- xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and its associated upload object to match the model for canvas. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable.
- 5:38 PM April 2011 Meeting edited by
- Make the title of RenderObject guard more descriptive (diff)
- 4:39 PM April 2011 Meeting edited by
- (diff)
- 4:13 PM April 2011 Meeting edited by
- (diff)
- 4:09 PM Changeset in webkit [84763] by
-
- 3 edits2 deletes in trunk
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- fast/dom/shadow/append-child-text-expected.txt: Removed.
- fast/dom/shadow/append-child-text.html: Removed.
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- dom/Node.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer):
- 3:53 PM Changeset in webkit [84762] by
-
- 9 edits in trunk
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
URLs like http:/example.com/ or http:example.com/ are now correctly
canonicalized as http://example.com/
The code still doesn't quite match other browsers - at least some
other browsers seem to base parsing behavior on whether they
recongize a scheme from a fixed list, and ignore whether is
present in the URL or not.
- platform/KURL.cpp: (WebCore::isNonFileHierarchicalScheme): New helper function. (WebCore::KURL::parse): For a particular list of whitelisted schemes, assume they are hierarchical and need an authority even if there is no after the :/
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
Added some new test cases. Also updated results for the
change. The changes are progressions.
- fast/url/relative-expected.txt:
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/standard-url-expected.txt:
- 2:48 PM Changeset in webkit [84761] by
-
- 3 edits1 add in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html
- platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 2:37 PM Changeset in webkit [84760] by
-
- 2 edits in trunk/Source/WebCore
LLVM Compiler build fix.
- page/ContentSecurityPolicy.cpp: Removed an unused function.
- 2:20 PM Changeset in webkit [84759] by
-
- 3 edits2 adds in trunk
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
- fast/dom/shadow/append-child-text-expected.txt: Added.
- fast/dom/shadow/append-child-text.html: Added.
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
Text nodes need to consult their host element for style.
Test: fast/dom/shadow/append-child-text.html
- dom/Node.cpp: (WebCore::NodeRendererFactory::styleForRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
- 11:38 AM Component Model edited by
- (diff)
- 11:38 AM Component Model edited by
- (diff)
- 11:37 AM Component Model edited by
- (diff)
- 11:36 AM Changeset in webkit [84758] by
-
- 15 edits in trunk
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Update tests to use the new syntax.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html:
- http/tests/security/contentSecurityPolicy/image-allowed.html:
- http/tests/security/contentSecurityPolicy/image-blocked.html:
- http/tests/security/contentSecurityPolicy/inline-script-allowed.html:
- http/tests/security/contentSecurityPolicy/style-allowed.html:
- http/tests/security/contentSecurityPolicy/style-blocked.html:
- http/tests/security/contentSecurityPolicy/xsl-allowed.php:
- http/tests/security/contentSecurityPolicy/xsl-blocked.php:
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Brandon removed disable-xss-protection in favor of unsafe-inline and
allow-eval in favor of unsafe-eval. This change in syntax also means
the options directive no longer exists.
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSourceList::allowInline): (WebCore::CSPSourceList::allowEval): (WebCore::CSPSourceList::CSPSourceList): (WebCore::CSPSourceList::parseSource): (WebCore::CSPSourceList::addSourceUnsafeInline): (WebCore::CSPSourceList::addSourceUnsafeEval): (WebCore::CSPDirective::allowInline): (WebCore::CSPDirective::allowEval): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 11:29 AM Changeset in webkit [84757] by
-
- 3 edits1 add in trunk/Source
../WebCore: Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- manual-tests/back-from-document-with-scrollbar.html: Added.
../WebKit2: <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndWindow): Null-check the document.
(WebKit::WebChromeClient::invalidateContentsForSlowScroll): Ditto.
- 10:50 AM April 2011 Meeting edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:23 AM Component Model edited by
- (diff)
- 9:02 AM Component Model created by
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:40 AM April 2011 Meeting edited by
- (diff)
- 2:23 AM April 2011 Meeting edited by
- (diff)
- 2:14 AM Changeset in webkit [84756] by
-
- 5 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Test canonicalization of scheme:/host
https://bugs.webkit.org/show_bug.cgi?id=59296
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/standard-url-expected.txt:
- 1:17 AM Changeset in webkit [84755] by
-
- 3 edits2 adds in trunk
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
- fast/table/auto-100-percent-width.html: Added.
- platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
Test: fast/table/auto-100-percent-width.html
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
