Timeline
Jan 22, 2015:
- 11:31 PM Changeset in webkit [178985] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 11:04 PM Changeset in webkit [178984] by
-
- 4 edits in trunk/Source/JavaScriptCore
EdenCollections unnecessarily visit SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=140762
Reviewed by Geoffrey Garen.
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores): Also added a GCPhase for copying
backing stores, which is a significant portion of garbage collection.
(JSC::Heap::visitSmallStrings): Check to see if we need to visit
SmallStrings based on the collection type.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::visitStrongReferences): Set the fact that we have
visited the SmallStrings since the last modification.
- runtime/SmallStrings.h:
(JSC::SmallStrings::needsToBeVisited): If we're doing a
FullCollection, we need to visit. Otherwise, it depends on whether
we've been visited since the last modification/allocation.
- 10:26 PM Changeset in webkit [178983] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Move leading whitespace handling from removeTrailingWhitespace() to initializeNewLine().
https://bugs.webkit.org/show_bug.cgi?id=140757
Reviewed by Antti Koivisto.
Checking if overflowed pre-wrap whitespace needs to be ignored should not be part of the trailing whitespace handling.
Move it to initializeNewLine().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isLineBreak):
- 9:38 PM Changeset in webkit [178982] by
-
- 6 edits in branches/safari-600.5-branch/Source
Merge r174708. rdar://problem/19451256
- 9:38 PM Changeset in webkit [178981] by
-
- 1 edit3 adds in branches/safari-600.5-branch/LayoutTests
Merge r175264. rdar://problem/19451378
- 8:17 PM Changeset in webkit [178980] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][WK2] Ignore synthetic click initiated on a previous page
https://bugs.webkit.org/show_bug.cgi?id=139556
rdar://problem/18586008
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-22
Reviewed by David Kilzer.
Under the right accumulation of bad luck, a synthetic click could be generated
on a page that never asked for it.
What happened was:
1) Page Foo listen to touch event.
2) In response to touch events, Foo decides to navigate to page Bar
*but* it does not cancel the native gesture recognizers with preventDefault().
3) Page Bar loads.
4) The native gesture recognizer ask us to click, we forward that to the WebProcess
and generate a synthetic mouse event.
-> Bar receives a click.
If you are unlucky enough, it looks like a single tap does a double click.
There are two ways this patch avoids the problem:
First, in the UIProcess, we just cancel the HighlightLongPressGestureRecognizer
on didCommitLoadForMainFrame. This prevents "fast clicks" from accidentally going through.
This is not bullet proof because we get didCommitLoadForMainFrame asynchronously but
killing the timer and gesture seems like a good idea.
Second, we skip any tap command at the WebProcess level when it was issued for
the previous page. This is using the same principle we used for VisibleContentRect:
any input generated before the current layer tree commit is useless for the current page.
We track the commit ID in the UIProcess when we decide to do the tracking or not.
Note that we keep the ID regardless of the tracking state, it does not matter if we have sent
touch events, what matters is what content was on screen when the touch events were handled.
If the user interaction result in a tap, we send the commit ID along the tap commands.
In the WebProcess, we know the actual layer tree commit associated with the current page.
If the tap was generated with a layer ID preceding the current page, we fail the command.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLoadForMainFrame]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _attemptClickAtLocation:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):
- 8:06 PM Changeset in webkit [178979] by
-
- 2 edits in trunk/Tools
configure-xcode-for-ios-development needs to import webkitdirs.pm
<http://webkit.org/b/140704>
Fixes the following runtime error:
Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
- Scripts/configure-xcode-for-ios-development: Add back code to
import webkitdirs.pm for the exitStatus() method. Not sure why
I removed it before patch review.
- 7:32 PM Changeset in webkit [178978] by
-
- 3 edits2 deletes in trunk/Source/WebKit
Remove unused class EmojiFallbackFontSelector.
<https://webkit.org/b/140809>
Reviewed by Antti Koivisto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/ios:
This class no longer has any clients.
- Misc/EmojiFallbackFontSelector.cpp: Removed.
- Misc/EmojiFallbackFontSelector.h: Removed.
- 6:21 PM Changeset in webkit [178977] by
-
- 6 edits in branches/safari-600.5-branch/Source/WebCore
Merged r178967. <rdar://19572776>
- 6:17 PM Changeset in webkit [178976] by
-
- 1 edit2 adds in trunk/LayoutTests
Import fast/css/font-shorthand-line-height.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=140801
Reviewed by Andreas Kling.
Import fast/css/font-shorthand-line-height.html layout test from Blink
to get better test coverage for 'line-height' font shorthands cascades:
https://src.chromium.org/viewvc/blink?view=rev&revision=184346
I am working on expanding the font shorthand at parsing time (like
other shorthands) via Bug 140577 and I want to make sure I don't break
line-height in the process.
- fast/css/font-shorthand-line-height-expected.txt: Added.
- fast/css/font-shorthand-line-height.html: Added.
- 5:57 PM Changeset in webkit [178975] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Cocoa] Drop WKWebViewConfiguration._featureCounterEnabled SPI.
https://bugs.webkit.org/show_bug.cgi?id=140799
Reviewed by Dan Bernstein.
Drop WKWebViewConfiguration._featureCounterEnabled SPI now that the
client-side has been updated.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]):
(-[WKWebViewConfiguration _featureCounterEnabled]): Deleted.
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 5:28 PM Changeset in webkit [178974] by
-
- 1 copy in tags/Safari-600.4.3
New tag.
- 5:19 PM Changeset in webkit [178973] by
-
- 2 edits in trunk/Source/WebKit2
Fix ENABLE(NETWORK_CACHE) build
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
- 5:16 PM Changeset in webkit [178972] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Unreviewed test fix after r178965.
- WebView.cpp: Supply missing implementation of 'setEditable'. It
currently asserts, causing all debug tests to fail.
- 4:47 PM Changeset in webkit [178971] by
-
- 2 edits in trunk/Tools
REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
https://bugs.webkit.org/show_bug.cgi?id=140795
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
r178847 accidentally remove the scheduler for this bot. Re-add it to the
Yosemite scheduler.
- 4:44 PM Changeset in webkit [178970] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
https://bugs.webkit.org/show_bug.cgi?id=140268
Reviewed by Timothy Hatcher.
UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
a resource can't be found or has another error that isn't a web inspector error.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Models/Resource.js: Change reject to resolve.
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.
- UserInterface/Models/SourceCode.js: Use correct inheritance style.
- UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
(WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.
- 4:31 PM Changeset in webkit [178969] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Media controls disappear when loading a HLS live stream
https://bugs.webkit.org/show_bug.cgi?id=140792
rdar://problem/19491658
Reviewed by Dean Jackson.
Overload reconnectControls to reconnect the "start playback" button
if the control type has been set to "StartPlaybackButton".
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.reconnectControls):
- 4:18 PM Changeset in webkit [178968] by
-
- 5 edits in trunk/Source
[Win] No plugin content on some sites.
https://bugs.webkit.org/show_bug.cgi?id=140780
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-22
Reviewed by Anders Carlsson.
Source/WebCore:
Return script instance from ScriptController::createScriptInstanceForWidget(),
instead of always returning null.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::bindingInstance):
Source/WebKit/win:
Add override modifier to bindingInstance method.
- Plugins/PluginView.h:
- 4:17 PM Changeset in webkit [178967] by
-
- 6 edits in trunk/Source/WebCore
[Mac][EME] Adopt changes to AVStreamSession class methods
https://bugs.webkit.org/show_bug.cgi?id=140778
rdar://problem/19458200
Reviewed by Eric Carlson.
AVStreamSession class methods have added a "storageDirectoryAtURL:" parameter so as to be able to
read and modify records stored at non-default storage locations.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::mediaKeysStorageDirectory): Implement client method by querying document and settings.
- Modules/encryptedmedia/MediaKeySession.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): Check whether the AVStreamSession class responds to new selector before calling.
(WebCore::CDMSessionMediaSourceAVFObjC::update): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::storagePath): Fetch the storage path from the client.
- 4:15 PM Changeset in webkit [178966] by
-
- 3 edits2 adds in trunk
REGRESSION (174847): can't view NHK(Japan's national public broadcasting organization)’s news pages
https://bugs.webkit.org/show_bug.cgi?id=140794
Reviewed by Anders Carlsson.
Source/WebCore:
If a document.open has been set, return it instead of always returning a new,
non-cached instance of jsHTMLDocumentPrototypeFunctionOpen.
Test: js/dom/document-overwrite-open.html
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
LayoutTests:
- js/dom/document-overwrite-open-expected.txt: Added.
- js/dom/document-overwrite-open.html: Added.
- 3:46 PM Changeset in webkit [178965] by
-
- 11 edits in trunk
[Win] Expose missing editing features through WebView interface
https://bugs.webkit.org/show_bug.cgi?id=140773
<rdar://problem/19565421>
Reviewed by Dean Jackson.
Connect the various WebView editing delegate methods to our
test infrastructure. Also prefer _bstr_t to raw BSTR types
to simplify life cycle management.
Source/WebKit/win:
- DOMCoreClasses.cpp: Flesh out the DOMRange object.
(DOMElement::createInstance):
(DOMRange::QueryInterface):
(DOMRange::DOMRange):
(DOMRange::~DOMRange):
(DOMRange::createInstance):
(DOMRange::startContainer):
(DOMRange::startOffset):
(DOMRange::endContainer):
(DOMRange::endOffset):
(DOMRange::collapsed):
(DOMRange::commonAncestorContainer):
(DOMRange::setStart):
(DOMRange::setEnd):
(DOMRange::setStartBefore):
(DOMRange::setStartAfter):
(DOMRange::setEndBefore):
(DOMRange::setEndAfter):
(DOMRange::collapse):
(DOMRange::selectNode):
(DOMRange::selectNodeContents):
(DOMRange::compareBoundaryPoints):
(DOMRange::deleteContents):
(DOMRange::extractContents):
(DOMRange::cloneContents):
(DOMRange::insertNode):
(DOMRange::surroundContents):
(DOMRange::cloneRange):
(DOMRange::toString):
(DOMRange::detach):
- DOMCoreClasses.h:
(DOMRange::AddRef):
(DOMRange::Release):
(DOMRange::throwException):
(DOMRange::callWebScriptMethod):
(DOMRange::evaluateWebScript):
(DOMRange::removeWebScriptKey):
(DOMRange::stringRepresentation):
(DOMRange::webScriptValueAtIndex):
(DOMRange::setWebScriptValueAtIndex):
(DOMRange::setException):
- Interfaces/IWebEditingDelegate.idl:
- Interfaces/IWebView.idl:
- WebCoreSupport/WebEditorClient.cpp: Connect more methods
to actual editing features in WebCore.
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::didEndEditing):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldInsertNode):
(WebEditorClient::shouldInsertText):
(WebEditorClient::shouldChangeSelectedRange):
(WebEditorClient::webViewDidChangeTypingStyle):
(WebEditorClient::webViewDidChangeSelection):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):
- WebView.cpp:
(WebView::setEditingDelegate): Added.
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/EditingDelegate.cpp:
(EditingDelegate::QueryInterface):
(dumpPath):
(dump):
(EditingDelegate::shouldBeginEditingInDOMRange):
(EditingDelegate::shouldEndEditingInDOMRange):
(EditingDelegate::shouldInsertNode):
(EditingDelegate::shouldInsertText):
(EditingDelegate::shouldDeleteDOMRange):
(EditingDelegate::shouldChangeSelectedDOMRange):
(EditingDelegate::shouldApplyStyle):
(EditingDelegate::shouldChangeTypingStyle):
(EditingDelegate::doPlatformCommand):
(EditingDelegate::webViewDidBeginEditing):
(EditingDelegate::webViewDidChange):
(EditingDelegate::webViewDidEndEditing):
(EditingDelegate::webViewDidChangeTypingStyle):
(EditingDelegate::webViewDidChangeSelection):
(EditingDelegate::checkSpellingOfString):
(EditingDelegate::onNotify):
- DumpRenderTree/win/EditingDelegate.h:
- 3:42 PM Changeset in webkit [178964] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Reset LineState when starting a new line.
https://bugs.webkit.org/show_bug.cgi?id=140789
Reviewed by Antti Koivisto.
Reset LineState when starting a new line to ensure we always
start with a clean state.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createTextRuns):
- 3:35 PM Changeset in webkit [178963] by
-
- 12 edits15 adds in trunk
[WebGL2] Create empty interface files for new WebGL2 objects.
https://bugs.webkit.org/show_bug.cgi?id=140779.
<rdar://problem/15002288>
Reviewed by Dean Jackson.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLQuery.cpp: Added.
(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):
- html/canvas/WebGLQuery.h: Added.
- html/canvas/WebGLQuery.idl: Added.
- html/canvas/WebGLSampler.cpp: Added.
(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):
- html/canvas/WebGLSampler.h: Added.
- html/canvas/WebGLSampler.idl: Added.
- html/canvas/WebGLSharedObject.h:
(WebCore::WebGLSharedObject::isQuery):
(WebCore::WebGLSharedObject::isSampler):
(WebCore::WebGLSharedObject::isSync):
(WebCore::WebGLSharedObject::isTransformFeedback):
(WebCore::WebGLSharedObject::isVertexArrayObject):
- html/canvas/WebGLSync.cpp: Added.
(WebCore::WebGLSync::create):
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):
- html/canvas/WebGLSync.h: Added.
- html/canvas/WebGLSync.idl: Added.
- html/canvas/WebGLTransformFeedback.cpp: Added.
(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):
- html/canvas/WebGLTransformFeedback.h: Added.
- html/canvas/WebGLTransformFeedback.idl: Added.
- html/canvas/WebGLVertexArrayObject.cpp: Added.
(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObject.h: Added.
- html/canvas/WebGLVertexArrayObject.idl: Added.
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 3:35 PM Changeset in webkit [178962] by
-
- 2 edits in tags/Safari-601.1.15.1/Source/WebKit2
Merged r178958. rdar://problem/19438402
- 3:34 PM Changeset in webkit [178961] by
-
- 2 edits in trunk/WebKitLibraries
[iOS] Fix build for external iphoneos SDK
Reviewed by Daniel Bates.
- WebKitSystemInterface.h: Remove import of the
<IOSurface/IOSurface.h> header, and add a typedef for
IOSurfaceRef in its place.
- 3:32 PM Changeset in webkit [178960] by
-
- 5 edits in tags/Safari-601.1.15.1/Source
Versioning.
- 3:30 PM Changeset in webkit [178959] by
-
- 1 copy in tags/Safari-601.1.15.1
New tag.
- 3:21 PM Changeset in webkit [178958] by
-
- 2 edits in trunk/Source/WebKit2
UserData decoding of WKTypeRefWrapper always fails
https://bugs.webkit.org/show_bug.cgi?id=140791
<rdar://problem/19438402>
Reviewed by Anders Carlsson.
- Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCObjectGraph::decode):
Add a missing break.
- 3:20 PM Changeset in webkit [178957] by
-
- 2 edits in trunk/LayoutTests
Skip another copy of oes-vertex-array-object test, because it has the same problems
as the old one.
- platform/mac/TestExpectations:
- 3:16 PM Changeset in webkit [178956] by
-
- 18 edits12 adds1 delete in trunk/LayoutTests
[Win] Unreviewed test gardening.
Clean up editing-related tests and rebaseline some output.
- platform/win/TestExpectations:
- platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
- platform/win/editing/pasteboard/4641033-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-1-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-2-expected.txt: Added.
- platform/win/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
- platform/win/editing/selection/3690703-2-expected.txt:
- platform/win/editing/selection/3690703-expected.txt:
- platform/win/editing/selection/3690719-expected.txt:
- platform/win/editing/selection/4975120-expected.txt: Added.
- platform/win/editing/selection/5240265-expected.txt:
- platform/win/editing/selection/caret-before-select-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-left-expected.txt:
- platform/win/editing/selection/caret-rtl-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-right-expected.txt:
- platform/win/editing/selection/drag-select-1-expected.txt: Added.
- platform/win/editing/selection/mixed-editability-10-expected.txt:
- platform/win/editing/selection/replaced-boundaries-3-expected.txt: Added.
- platform/win/editing/selection/select-box-expected.txt: Added.
- platform/win/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/editing/selection/selection-button-text-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- 3:13 PM Changeset in webkit [178955] by
-
- 2 edits in trunk/Source/WebCore
Fix remaining multiple targets per rule issues in DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=140790
Reviewed by David Kilzer.
Fix remaining multiple target per rule issues in DerivedSources.make,
similarly to Bug 140784 and Bug 140756.
This was causing us to run scripts several times to generate the same
files and may lead to malformed files in case of concurrency.
- DerivedSources.make:
- 3:12 PM Changeset in webkit [178954] by
-
- 17 edits in trunk
Add a build flag for ES6 class syntax
https://bugs.webkit.org/show_bug.cgi?id=140760
Reviewed by Michael Saboff.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added ES6_CLASS_SYNTAX build flag and used it in tokenizer to recognize
"class", "extends", "static" and "super" keywords.
- Configurations/FeatureDefines.xcconfig:
- parser/Keywords.table:
- parser/ParserTokens.h:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:09 PM Changeset in webkit [178953] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip flakey inspector test.
- 2:23 PM Changeset in webkit [178952] by
-
- 2 edits in trunk/Source/WebCore
SVGNames.cpp and HTMLNames.cpp are sometimes malformed
https://bugs.webkit.org/show_bug.cgi?id=140784
<rdar://problem/17701233>
Reviewed by David Kilzer.
Due to bad rules in DerivedSources.make, make_names.pl was called
several times with the same arguments during build. This is because
SVG/HTML/MathML each had several targets associated to the same
command. This would cause the command (make_names.pl) to be called
once per target. However, make_names.pl only needs to be executed
once to generate all of the files currently marked as target.
Calling make_names.pl several times for the same files is not only
wasteful, but it can also lead to malformed generated files if the
scripts instances are executed in parallel as they will read / write
from / to the same files.
This patch uses INTERMEDIATE targets instead so that we can still
indicate which files are generated by make_names.pl but only run
the script once.
This is a similar fix as for Bug 140756. There may several other
similar issues in DerivedSources.make but this patch focuses on
make_names.pl. I will take care of other in follow-ups if needed.
- DerivedSources.make:
- 2:21 PM Changeset in webkit [178951] by
-
- 4 edits in trunk/Source/WebCore
Have Counter::create() return a Ref<Counter>
https://bugs.webkit.org/show_bug.cgi?id=140777
Reviewed by Andreas Kling.
Have Counter::create() return a Ref<Counter> instead of a PassRefPtr.
The CSSPrimitiveValue class needed some updates as well to support
constructing a CSSPrimitiveValue object from a Ref<>.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::cloneForCSSOM):
- 2:20 PM Changeset in webkit [178950] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r178426. rdar://problem/19526069
- 2:19 PM Changeset in webkit [178949] by
-
- 21 edits4 deletes in trunk/Source
Drop the legacy FeatureCounter class
https://bugs.webkit.org/show_bug.cgi?id=140749
Reviewed by Andreas Kling.
Drop the legacy FeatureCounter class and use DiagnosticLoggingClient
instead.
Source/WebCore:
- CMakeLists.txt:
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::mediaKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::reasonKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::resourceRequestKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::zoomedKey):
- page/DiagnosticLoggingKeys.h:
- page/Settings.in:
- platform/FeatureCounter.cpp: Removed.
- platform/FeatureCounter.h: Removed.
- platform/FeatureCounterKeys.h: Removed.
- platform/ios/FeatureCounter.mm: Removed.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::willStartUserTriggeredZooming):
- 2:17 PM Changeset in webkit [178948] by
-
- 2 edits in trunk/Source/WebCore
When extending the fallback transitions with their closure, we are modifying the Set while iterating it
https://bugs.webkit.org/show_bug.cgi?id=140785
Reviewed by Andreas Kling.
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::populateTransitions):
Make that in two steps: accumulate the fallback transitions then add the closure
of every element.
- 2:16 PM Changeset in webkit [178947] by
-
- 5 edits5 adds in branches/safari-600.5-branch
Merge r178038. rdar://problem/19451263
- 2:16 PM Changeset in webkit [178946] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177611. rdar://problem/19451361
- 2:16 PM Changeset in webkit [178945] by
-
- 1 edit5 adds in branches/safari-600.5-branch/LayoutTests
Merge r177408. rdar://problem/19451330
- 2:16 PM Changeset in webkit [178944] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r177360. rdar://problem/19451319
- 2:13 PM Changeset in webkit [178943] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
- http/tests/appcache/404-resource-with-slow-main-resource.php: Try updating the
tiemout, as it's not sufficient for appcache load to fail on some bots.
- http/tests/appcache/404-resource-with-slow-main-resource.php:
- 2:02 PM Changeset in webkit [178942] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177292. rdar://problem/19452139
- 2:02 PM Changeset in webkit [178941] by
-
- 18 edits in branches/safari-600.5-branch/Source
Merge r177152. rdar://problem/19451288
- 1:57 PM Changeset in webkit [178940] by
-
- 118 edits2 moves in trunk/Source
Rename SimpleFontData to Font
https://bugs.webkit.org/show_bug.cgi?id=140496
Reviewed by Zalan Bujtas.
The fallback supporting Font type was renamed FontCascade.
We can now rename SimpleFontData to Font matching the usual definition.
- 1:54 PM Changeset in webkit [178939] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Make trailing whitespace handling more explicit.
https://bugs.webkit.org/show_bug.cgi?id=140776
Reviewed by Antti Koivisto.
Differentiate between committed and uncommitted trailing whitespace.
This enables further cleanup in removeTrailingWhitespace().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::LineState::LineState): Deleted.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::LineState::resetTrailingWhitespace): Deleted.
- 1:40 PM Changeset in webkit [178938] by
-
- 6 edits in trunk/Source
ibtoold crash below -[WebView close]
https://bugs.webkit.org/show_bug.cgi?id=140782
-and corresponding-
rdar://problem/19558472
Reviewed by Tim Horton.
Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
Source/WebKit/mac:
it is because interface builder is messing with our views.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _cancelImmediateAction]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController _updateImmediateActionItem]):
Source/WebKit2:
it is because interface builder can mess with our views.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _cancelImmediateAction]):
(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController _updateImmediateActionItem]):
- 1:04 PM Changeset in webkit [178937] by
-
- 6 edits2 adds in trunk
Crash in URL::protocol() after appcache load fails
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
Reviewed by Dan Bates.
Source/WebCore:
Test: http/tests/appcache/404-resource-with-slow-main-resource.php
Not every cache that isn't being updated is complete. It could also be in a zombie
state after failing to load. We get rid of the cache once the main resource finishes
loading, but while it's being loaded, the zombie still looks like a regular
candidate application cache.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isComplete):
- loader/appcache/ApplicationCache.h:
Removed const from isComplete(), because otherwise we couldn't use ApplicationCacheGroup::m_caches.contains().
Constness doesn't make a lot of sense for these objects anyway.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::failedLoadingMainResource): Toned down an assertion.
We can fail a main resource load when the document has a zombie appcache, too.
- loader/appcache/ApplicationCacheGroup.h:
(WebCore::ApplicationCacheGroup::cacheIsComplete):
(WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): Deleted.
These functions are only used in ApplicationCache::isComplete().
LayoutTests:
- http/tests/appcache/404-resource-with-slow-main-resource-expected.txt: Added.
- http/tests/appcache/404-resource-with-slow-main-resource.php: Added.
- 12:35 PM Changeset in webkit [178936] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177033. rdar://problem/19451244
- 12:34 PM Changeset in webkit [178935] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177011. rdar://problem/19451253
- 12:34 PM Changeset in webkit [178934] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r176982. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178933] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176971. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178932] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176768. rdar://problem/19451369
- 12:03 PM Changeset in webkit [178931] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176285. rdar://problem/19452164
- 12:01 PM Changeset in webkit [178930] by
-
- 2 edits in trunk/Source/WebCore
Avoid defining always empty Vector<TextCheckingResult>
https://bugs.webkit.org/show_bug.cgi?id=140765
Reviewed by Alexey Proskuryakov.
Pass an empty vector direclty instead.
No new tests. No behavior change.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckCancel):
- 11:38 AM Changeset in webkit [178929] by
-
- 2 edits in trunk/Source/WebCore
makeprop.pl script is called too many times during build
https://bugs.webkit.org/show_bug.cgi?id=140756
<rdar://problem/19467942>
Reviewed by David Kilzer.
The makeprop.pl script was called 4 times (instead of once) during
build due to a bad Makefile rule in DerivedSources.make. makeprop.pl
had 4 associated targets and thus was called 4 times (with the same
parameter). Calling it once is sufficient to generate all 4 files
that were marked as target. This patch uses an INTERMEDIATE target
instead so that we can indicate that several files are generated
by the same command.
I believe this may be the reason for the sporatic build failures
that look like:
"""
CSSPropertyNames.gperf: No keywords in input file!
calling gperf failed: 256 at WebCore/css/makeprop.pl line 1036.
"""
The makeprop.pl script is generating gperf's input file and calling the
gperf executable on this file. If the script is executed several times
in parallel, it would explain the build failures as several instances
of makeprop.pl may be writing / reading from the same
CSSPropertyNames.gperf file.
- DerivedSources.make:
- 11:34 AM Changeset in webkit [178928] by
-
- 31 edits3 deletes in trunk
Unreviewed, rolling out r178894.
https://bugs.webkit.org/show_bug.cgi?id=140775
Broke JSC and bindings tests (Requested by ap_ on #webkit).
Reverted changeset:
"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
https://bugs.webkit.org/show_bug.cgi?id=140426
http://trac.webkit.org/changeset/178894
- 11:27 AM Changeset in webkit [178927] by
-
- 9 edits2 copies1 add in trunk/Source
[iOS] Fix iphoneos SDK builds for ios-ews queue
<http://webkit.org/b/140748>
Reviewed by Daniel Bates.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add new SPI headers.
- platform/graphics/cg/ImageBufferCG.cpp: Switch to using
"IOSurfaceSPI.h" from <IOSurface/IOSurface.h>.
- platform/graphics/cg/ImageBufferDataCG.cpp: Ditto.
- platform/graphics/cocoa/IOSurface.mm: Ditto. Move definitions
in <IOSurface/IOSurfacePrivate.h> into "IOSurfaceSPI.h".
- platform/spi/cg/CoreGraphicsSPI.h: Switch to
WTF_EXTERN_C_{BEGIN,END}. Add
CGContextGetFontAntialiasingStyle() and
CGContextSetFontAntialiasingStyle().
- platform/spi/cocoa/IOPMLibSPI.h: Switch to use IOReturnSPI.h.
- platform/spi/cocoa/IOReturnSPI.h: Add.
- platform/spi/cocoa/IOSurfaceSPI.h: Add.
- platform/spi/cocoa/IOTypesSPI.h: Add.
Source/WebKit2:
- Platform/spi/ios/BKSProcessAssertionSPI.h: Add -invalidate
definition. Sort @property to the top of BKSProcessAssertion.
- 11:05 AM Changeset in webkit [178926] by
-
- 5 edits3 adds in trunk
BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope.
<https://webkit.org/b/140743>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
BytecodeGenerator::initializeCapturedVariable() was setting the 5th operand to
op_put_to_scope to an inappropriate value (i.e. 0). As a result, the execution
of put_to_scope could store a wrong inferred value into the VariableWatchpointSet
for which ever captured variable is at local index 0. In practice, this turns
out to be the local for the Arguments object. In this reproduction case in the
bug, the wrong inferred value written there is the boolean true.
Subsequently, DFG compilation occurs and CreateArguments is emitted to first do
a check of the local for the Arguments object. But because that local has a
wrong inferred value, the check always discovers a non-null value and we never
actually create the Arguments object. Immediately after this, an OSR exit
occurs leaving the Arguments object local uninitialized. Later on at arguments
tear off, we run into a boolean true where we had expected to find an Arguments
object, which in turn, leads to the crash.
The fix is to:
- In the case where the resolveModeType is LocalClosureVar, change the 5th operand of op_put_to_scope to be a boolean. True means that the local var is watchable. False means it is not watchable. We no longer pass the local index (instead of true) and UINT_MAX (instead of false).
This allows us to express more clearer in the code what that value means,
as well as remove the redundant way of getting the local's identifier.
The identifier is always the one passed in the 2nd operand.
- Previously, though intuitively, we know that the watchable variable identifier should be the same as the one that is passed in operand 2, this relationship was not clear in the code. By code analysis, I confirmed that the callers of BytecodeGenerator::emitPutToScope() always use the same identifier for operand 2 and for filling out the ResolveScopeInfo from which we get the watchable variable identifier later. I've changed the code to make this clear now by always using the identifier passed in operand 2.
- In the case where the resolveModeType is LocalClosureVar, initializeCapturedVariable() and emitPutToScope() will now query hasWatchableVariable() to determine if the local is watchable or not. Accordingly, we pass the boolean result of hasWatchableVariable() as operand 5 of op_put_to_scope.
Also added some assertions.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeCapturedVariable):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::emitPutToScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasWatchableVariable):
(JSC::BytecodeGenerator::watchableVariableIdentifier):
(JSC::BytecodeGenerator::watchableVariable): Deleted.
LayoutTests:
- js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Added.
- js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Added.
- js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Added.
(foo):
- 10:51 AM Changeset in webkit [178925] by
-
- 2 edits in trunk/Tools
[iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
runtime in simctl output
https://bugs.webkit.org/show_bug.cgi?id=140751
Reviewed by David Kilzer.
Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
with an error because it does not know how to parse the output of the simctl tool
to identify an Apple Internal runtime.
- Scripts/webkitpy/xcode/simulator.py:
(Runtime.init): Add parameter is_internal_runtime (defaults to False).
(Runtime.eq): Take is_internal_runtime when comparing two Runtime objects for equality.
(Runtime.repr): Update printable representation of Runtime object to indicate whether
the runtime is an internal runtime.
(Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
(Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
appropriate value.
(Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
it updates the appropriate Runtime object.
(Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
looking up a Runtime object for an internal runtime.
- 10:47 AM Changeset in webkit [178924] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r175771. rdar://problem/19451238
- 10:47 AM Changeset in webkit [178923] by
-
- 7 edits in branches/safari-600.5-branch/Source/WebKit2
Merge r175759. rdar://problem/19450899
- 10:47 AM Changeset in webkit [178922] by
-
- 4 edits2 adds in branches/safari-600.5-branch
Merge r175131. rdar://problem/19452187
- 10:46 AM Changeset in webkit [178921] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r174716. rdar://problem/19451273
- 10:46 AM Changeset in webkit [178920] by
-
- 3 edits in branches/safari-600.5-branch
Merge r174698. rdar://problem/19451342
- 10:25 AM Changeset in webkit [178919] by
-
- 8 edits5 adds in trunk/LayoutTests
[Win] More unskips and rebaselines.
- platform/win/TestExpectations:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- platform/win/inspector-protocol: Added.
- platform/win/inspector-protocol/debugger: Added.
- platform/win/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
- platform/win/svg/text/kerning-expected.txt:
- platform/win/svg/text/multichar-glyph-expected.txt:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- 10:07 AM Changeset in webkit [178918] by
-
- 3 edits in trunk/Source/JavaScriptCore
PropertyListNode::emitNode duplicates the code to put a constant property
https://bugs.webkit.org/show_bug.cgi?id=140761
Reviewed by Geoffrey Garen.
Extracted PropertyListNode::emitPutConstantProperty to share the code.
Also made PropertyListNode::emitBytecode private since nobody is calling this function directly.
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty): Added.
- parser/Nodes.h:
- 9:59 AM Changeset in webkit [178917] by
-
- 2 edits in trunk/Tools
LeaksViewer doesn't show recent builds if there are less than 10
https://bugs.webkit.org/show_bug.cgi?id=140716
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
- 9:21 AM Changeset in webkit [178916] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed gardening.
Activate ENABLE(MOUSE_CURSOR_SCALE). This works on Windows and causes more tests to pass.
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 5:46 AM Changeset in webkit [178915] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix up slave distribution for Apple bots.
- 5:14 AM Changeset in webkit [178914] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix json.
- 5:12 AM Changeset in webkit [178913] by
-
- 2 edits in trunk/Tools
Add Apple build slaves.
Fixed text alignment for slave list.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:22 AM Changeset in webkit [178912] by
-
- 4 edits2 adds in trunk/LayoutTests
AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=140721
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.
The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.
- accessibility/list-detection.html:
- platform/efl/TestExpectations:
- platform/efl/accessibility/list-detection-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/list-detection-expected.txt: Added.
- 2:35 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:23 AM Changeset in webkit [178911] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Expected gutter highlight when selecting console input line, just like output line
https://bugs.webkit.org/show_bug.cgi?id=140696
Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
- 2:21 AM Changeset in webkit [178910] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning in WebKit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=140758
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2015-01-22
Reviewed by Csaba Osztrogonác.
Fix build warnings by using UNUSED_PARAM macro
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):
- 2:18 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:09 AM Changeset in webkit [178909] by
-
- 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174381. rdar://problem/19450841
- 2:08 AM Changeset in webkit [178908] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r174377. rdar://problem/19451247
- 2:08 AM Changeset in webkit [178907] by
-
- 8 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174371. rdar://problem/19450845
- 2:08 AM Changeset in webkit [178906] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r174345. rdar://problem/19451258
- 2:08 AM Changeset in webkit [178905] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r173790. rdar://problem/19451354
- 2:04 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:32 AM Changeset in webkit [178904] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r173688. rdar://problem/19451277
- 1:31 AM Changeset in webkit [178903] by
-
- 4 edits32 adds in branches/safari-600.5-branch
Merge r172797. rdar://problem/19451324
- 1:31 AM Changeset in webkit [178902] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit
Merge r172509. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178901] by
-
- 6 edits2 adds in branches/safari-600.5-branch
Merge r172504. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178900] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r172326. rdar://problem/19452126
- 1:11 AM Changeset in webkit [178899] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171404. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178898] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171392. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178897] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171388. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178896] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171385. rdar://problem/19451349
- 12:56 AM Changeset in webkit [178895] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
https://bugs.webkit.org/show_bug.cgi?id=140720
Reviewed by David Hyatt.
Source/WebCore:
Section "11.5. Resolve Intrinsic Track Sizes" of the specs forces
us to ignore items spanning tracks with flex sizing functions when
resolving the content-based track sizing functions. Items with
span < 2 are not affected by this rule (as they will belong to a
single track). This way the algorithm ensures that min-content and
max-content restrictions are fulfilled before distributing the
extra space.
Test: fast/css-grid-layout/flex-and-content-sized-resolution-columns.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::spanningItemCrossesFlexibleSizedTracks):
(WebCore::integerSpanForDirection):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
- rendering/RenderGrid.h:
LayoutTests:
- fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: Added.
- 12:54 AM Changeset in webkit [178894] by
-
- 31 edits3 adds in trunk
put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
https://bugs.webkit.org/show_bug.cgi?id=140426
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutById):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::emitPutTransitionStubAndGetOldStructure):
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):
- runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):
- runtime/JSString.cpp:
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::getStringPropertySlot):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
- runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
- runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
Source/WebCore:
Test: js/dfg-put-by-val-direct-with-edge-numbers.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):
LayoutTests:
- js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
- js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
- js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.
(lookupWithKey):
(dfgShouldThrow):
(lookupWithKey2):
(toStringThrowsError.toString):
- 12:36 AM Changeset in webkit [178893] by
-
- 6 edits in trunk
[CSS Grid Layout] Size tracks using a list of all items sorted by span
https://bugs.webkit.org/show_bug.cgi?id=140615
Reviewed by Andreas Kling.
Source/WebCore:
In r173620 we fixed
RenderGrid::resolveContentBasedTrackSizingFunctions() so that it
now collects all items spanning content-sized tracks and process
them one by one after sorting them by ascending span.
The problem is that it was incorrectly implemented, it has two
important bugs. First one is that the hash table that collects
items is regenerated after processing each track, so it's actually
doing nothing. Secondly we're only sorting the items on each
track, instead of all the items in the grid.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
LayoutTests:
- fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
Added tons of new test cases.
- fast/css-grid-layout/grid-content-sized-columns-resolution.html: Ditto.
- fast/css-grid-layout/grid-preferred-logical-widths.html:
Adjusted results.
- 12:30 AM Changeset in webkit [178892] by
-
- 11 edits in trunk/Source/WebKit2
[GTK] Use API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138467
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuPopulate): Add a version that receives a Vector<WebContextMenuItemData>&.
(webkitContextMenuCreate): Change it to receive a const
Vector<WebContextMenuItemData>& instead of a API::Array* and also
add a another version that receives const Vector<ContextMenuItem>&.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView): Use a class derived from
API::ContextMenuClient to implement the context menu client.
(getContextMenuFromProposedMenu): Deleted.
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate): Change it to receive a const
WebContextMenuItemData& and added another version that receives a
const ContextMenuItem&.
- UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
- UIProcess/API/gtk/WebKitContextMenuPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu): Remove the creation of a
WebHitTestResult::Data, since it receives it now as parameter.
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:
(webkitWebHitTestResultCreate): Change it to receive a const
HitTestResult& instead of const InjectedBundleHitTestResult&.
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Use a class derived from
API::InjectedBundle::PageContextMenuClient to implement the
context menu client.
(getContextMenuFromDefaultMenu): Deleted.
- 12:05 AM Changeset in webkit [178891] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Try to fix Debug build after r178889.
- UIProcess/API/C/WKPage.cpp: Include Logging.h.
- 12:02 AM Changeset in webkit [178890] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171357. rdar://problem/19451349
Jan 21, 2015:
- 11:53 PM Changeset in webkit [178889] by
-
- 13 edits1 copy1 move1 delete in trunk/Source/WebKit2
Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138466
Reviewed by Anders Carlsson.
Move ContextMenuClient to use API classes in both UI and Injected
Bundle APIs.
- CMakeLists.txt: Remove WebPageContextMenuClient.cpp.
- UIProcess/API/APIContextMenuClient.h: Renamed from Source/WebKit2/UIProcess/WebPageContextMenuClient.h.
(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):
(API::ContextMenuClient::hideContextMenu):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/WebPageContextMenuClient.cpp: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setContextMenuClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::initializeContextMenuClient): Deleted.
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj: Remove deleted files and add
new files to compilation.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h.
(API::InjectedBundle::PageContextMenuClient::~PageContextMenuClient):
(API::InjectedBundle::PageContextMenuClient::getCustomMenuFromDefaultItems):
(API::InjectedBundle::PageContextMenuClient::prepareForActionMenu):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::InjectedBundlePageContextMenuClient):
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
(WebKit::InjectedBundlePageContextMenuClient::prepareForActionMenu):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::menuItemsWithUserData):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setInjectedBundleContextMenuClient):
(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundleContextMenuClient): Deleted.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleContextMenuClient):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
- 10:39 PM Changeset in webkit [178888] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
Consolidate out arguments of parseFunctionInfo into a struct
https://bugs.webkit.org/show_bug.cgi?id=140754
Reviewed by Oliver Hunt.
Introduced ParserFunctionInfo for storing out arguments of parseFunctionInfo.
- JavaScriptCore.xcodeproj/project.pbxproj:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty): This one takes a property name in addition to
ParserFunctionInfo since the property name and the function name could differ.
(JSC::ASTBuilder::createFuncDeclStatement):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/Parser.h:
- parser/ParserFunctionInfo.h: Added.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createClassDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
- 10:01 PM Changeset in webkit [178887] by
-
- 14 edits4 adds in trunk/LayoutTests
[Win] Rebaseline SVG results from test machine.
- platform/win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
- platform/win/css2.1/20110323/replaced-elements-001-expected.png: Added.
- platform/win/css2.1/20110323/replaced-elements-001-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- 9:31 PM Changeset in webkit [178886] by
-
- 2 edits in trunk/LayoutTests
[Win] Update expectations file for failures on test machine.
- platform/win/TestExpectations:
- 8:57 PM Changeset in webkit [178885] by
-
- 2 edits2 adds in trunk/LayoutTests
[Win] Add more tests and baselines.
Stop skipping a number of tests that are fully functional. Add some
Windows baselines.
- platform/win/TestExpectations:
- platform/win/printing/setPrinting-expected.txt: Added.
- platform/win/printing/width-overflow-expected.txt: Added.
- 6:56 PM Changeset in webkit [178884] by
-
- 4 edits in trunk/Source/JavaScriptCore
Change Heap::m_compiledCode to use a Vector
https://bugs.webkit.org/show_bug.cgi?id=140717
Reviewed by Andreas Kling.
Right now it's a DoublyLinkedList, which is iterated during each
collection. This contributes to some of the longish Eden pause times.
A Vector would be more appropriate and would also allow ExecutableBase
to be 2 pointers smaller.
- heap/Heap.cpp:
(JSC::Heap::deleteAllCompiledCode):
(JSC::Heap::deleteAllUnlinkedFunctionCode):
(JSC::Heap::clearUnmarkedExecutables):
- heap/Heap.h:
- runtime/Executable.h: No longer need to inherit from DoublyLinkedListNode.
- 6:08 PM Changeset in webkit [178883] by
-
- 2 edits in trunk/LayoutTests
[Win] More gardening.
Unskip the flexbox tests. These have been functional in Windows for YEARS!
- platform/win/TestExpectations:
- 6:06 PM Changeset in webkit [178882] by
-
- 4 edits in trunk/Source/JavaScriptCore
BytecodeGenerator shouldn't expose all of its member variables
https://bugs.webkit.org/show_bug.cgi?id=140752
Reviewed by Mark Lam.
Added "private:" and removed unused data members as detected by clang.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::lastOpcodeID): Added. Used in BinaryOpNode::emitBytecode.
- bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
- 6:06 PM Changeset in webkit [178881] by
-
- 2 edits in trunk/Tools
Teach build.webkit.org about bot308 and bot309.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:31 PM Changeset in webkit [178880] by
-
- 2 edits in trunk/LayoutTests
[Win] Gardening pass over file.
Convert Skips to Failure wherever possible. Try to delete unnecessary skips/failures.
- platform/win/TestExpectations:
- 5:21 PM Changeset in webkit [178879] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r178072. rdar://problem/19395123
- 5:20 PM Changeset in webkit [178878] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177329. rdar://problem/19419784
- 5:19 PM Changeset in webkit [178877] by
-
- 3 edits1 copy in branches/safari-600.1.4.15-branch
Merged r177115. rdar://problem/19420090
- 5:10 PM Changeset in webkit [178876] by
-
- 2 edits in trunk/LayoutTests
After updating tests to use kerning, ligatures, and printer fonts, some tests fail
https://bugs.webkit.org/show_bug.cgi?id=139968
- platform/mac/TestExpectations:
Mark svg/custom/svg-fonts-without-missing-glyph.xhtml as flaky.
- 5:03 PM Changeset in webkit [178875] by
-
- 4 edits in trunk
Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
https://bugs.webkit.org/show_bug.cgi?id=140746
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-21
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
Do not add impure properties to the descriptor object that will
eventually be sent to the frontend.
LayoutTests:
Unskip the test now that is doesn't ASSERT in debug builds.
- 4:50 PM Changeset in webkit [178874] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS release build after <http://trac.webkit.org/changeset/178868>
(https://bugs.webkit.org/show_bug.cgi?id=140742)
Substitute ASSERT_UNUSED() for ASSERT() since the parameter layer is used only in the assertion expression.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack):
- 4:22 PM Changeset in webkit [178873] by
-
- 2 edits in trunk/Tools
Add two Apple Mavericks slaves.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:04 PM Changeset in webkit [178872] by
-
- 3 edits90 deletes in trunk/LayoutTests
Update iOS WebKit2 expected results for compositing tests
Following the patch for bug #140742, <https://bugs.webkit.org/show_bug.cgi?id=140742>, we can remove
all iOS WebKit2-specific expected results that are identical to the platform-independent results.
- platform/ios-simulator-wk2/TestExpectations: Add WebKit2-specific failures: compositing/reflections/nested-reflection-on-overflow.html
and compositing/repaint/invalidations-on-composited-layers.html.
- platform/ios-simulator-wk2/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.
[...]
- platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Removed.
- platform/ios-simulator-wk2/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/ios-simulator-wk2/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
- platform/ios-simulator/TestExpectations: Remove tests that now pass in both iOS WebKit1 and WebKit2.
- 3:56 PM WebKitGTK/Roadmap edited by
- Add link to long-tap context-menu bug (diff)
- 3:52 PM Changeset in webkit [178871] by
-
- 3 edits in trunk/LayoutTests
Update iOS WebKit test expectations for compositing tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 3:47 PM WebKitGTK/Roadmap edited by
- Add link to Python web-extension bug (diff)
- 3:47 PM Changeset in webkit [178870] by
-
- 7 edits in trunk/Source/WebKit2
[iOS] WebKitTestRunner: Tests fail due to incorrect web view size
<https://bugs.webkit.org/show_bug.cgi?id=139736>
<rdar://problem/19282196>
This starts happening after we fail to reset the test controller to
consistent values in TestInvocation::invoke(). When we terminate the
web process and relaunch it, the new WebPage object created in the web
process is using the default ViewportConfiguration with dimensions of
1024x768.
The PageClient on iOS currently notifies the WKWebView and the
WKContentView when the web process is relaunched. This patch extends
that to also notify the WKView.
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_didRelaunchProcess.
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
Call the new method that accepts a WKView.
(-[WKView _didRelaunchProcess]):
Call -_frameOrBoundsChanged to update the web process's size to the
size of the WKView.
- UIProcess/ios/PageClientImplIOS.h:
Add a constructor that takes a WKView, and add a member var to hold it.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClientImpl):
Implement the constructor that takes a WKView.
(WebKit::PageClientImpl::didRelaunchProcess):
Tell the WKView that the web process relaunched.
- UIProcess/ios/WKContentView.h:
Declare an initializer that takes a WKView.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Split out from -[WKContentView initWithFrame:processPool:configuration:webView:].
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
Perform some initialization, including creating the PageClient, and
call the common initializer.
(-[WKContentView initWithFrame:processPool:configuration:wkView:]):
Ditto.
- 3:44 PM Changeset in webkit [178869] by
-
- 10 edits in trunk/Source/WebKit2
Add WKPageGroupRef SPI for user content filters
https://bugs.webkit.org/show_bug.cgi?id=140728
Reviewed by Anders Carlsson.
While Safari is transitioning to WKUserContentController, it is useful
for them to have access to have access to content filters on the page group
where they currently have user content related functionality.
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):
- UIProcess/API/C/WKPageGroup.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addUserContentFilter):
(WebKit::WebPageGroup::removeAllUserContentFilters):
- UIProcess/WebPageGroup.h:
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::addUserContentFilter):
(WebKit::WebPageGroupProxy::removeAllUserContentFilters):
- WebProcess/WebPage/WebPageGroupProxy.h:
- WebProcess/WebPage/WebPageGroupProxy.messages.in:
- 3:42 PM Changeset in webkit [178868] by
-
- 8 edits1 delete in trunk
[iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque difference
https://bugs.webkit.org/show_bug.cgi?id=140742
Reviewed by Simon Fraser.
Source/WebCore:
Make RenderLayerBacking::layerTreeAsText() (including internals.layerTreeAsText()) always
report that the main frame's RenderView layer is opaque when running iOS DumpRenderTree to
avoid test failures and the need to maintain for iOS WebKit1 an almost identical copy of the
platform-independent compositing test results.
The main frame's RenderView layer is always transparent in iOS WebKit1 since it does
not make use of a tiled cache layer and defers to UIKit to handle the final compositing
of the web view, including applying the page scale factor.
- platform/RuntimeApplicationChecksIOS.mm:
(WebCore::applicationIsDumpRenderTree): The app bundle identifier of DumpRenderTree has
the form org.webkit.DumpRenderTreeX where X is some non-negative integer.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties): Modified to report that a layer is opaque when
GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack() returns true.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added
default implementation (returns false).
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added;
returns true when running in DumpRenderTree and the passed GraphicsLayer corresponds to the main frame's
RenderView layer.
- rendering/RenderLayerBacking.h:
LayoutTests:
Update test expectations and remove an unnecessary test result.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt: Removed.
- 3:29 PM Changeset in webkit [178867] by
-
- 4 edits2 adds in trunk
Add iOS WebKit1 TestExpectation file
https://bugs.webkit.org/show_bug.cgi?id=140739
Reviewed by David Kilzer.
Tools:
Teach run-webkit-tests to look for iOS WebKit1-specific test results and
expectations in directory LayoutTests/platform/ios-simulator-wk1.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_baseline_search_path):
LayoutTests:
iOS WebKit1 is different enough from iOS WebKit2 that it would benefit from having its
own TestExpectation file. We can work to reduce such differences over time.
- platform/ios-simulator-wk1/TestExpectations: Added.
- platform/ios-simulator/TestExpectations: Move iOS WebKit1-specific test expectation from here
to file LayoutTests/platform/ios-simulator-wk1/TestExpectations.
- 3:21 PM Changeset in webkit [178866] by
-
- 2 edits in trunk/Tools
[iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
<http://webkit.org/b/140704>
Reviewed by Daniel Bates.
- Scripts/configure-xcode-for-ios-development:
- Update copyright.
- Remove FIXME addressed by r178709.
- Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
(copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
missing headers from iphonesimulator SDK to iphoneos SDK.
(sdkDirectory): Add method that returns SDK directory.
(sdkPlatformDirectory): Extract method from
xcodeSDKSpecificationsPath() that returns SDK platform
directory.
(xcodeSDKSpecificationsPath): Update to use
sdkPlatformDirectory().
- 3:14 PM Changeset in webkit [178865] by
-
- 2 edits in trunk/Source/WebCore
WebGL2 (spec section 3.1): Add new types to WebGL2 API.
https://bugs.webkit.org/show_bug.cgi?id=140741.
<rdar://problem/19552962>
Reviewed by Dean Jackson.
- html/canvas/WebGL2RenderingContext.idl:
- 3:04 PM Changeset in webkit [178864] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Change Annotator's isActive getter into an isActive() function.
https://bugs.webkit.org/show_bug.cgi?id=140729
Reviewed by Timothy Hatcher.
This patch also makes the child classes of Annotator use
the function instead of accessing the property directly.
- UserInterface/Controllers/Annotator.js:
(WebInspector.Annotator.prototype.isActive):
(WebInspector.Annotator.prototype.get isActive): Deleted.
- UserInterface/Controllers/BasicBlockAnnotator.js:
(WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
- 2:51 PM Changeset in webkit [178863] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
https://bugs.webkit.org/show_bug.cgi?id=140727
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/BasicBlockAnnotator.js:
(WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
(WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyClosingBrace):
BasicBlockAnnotator tries to no longer highlight a basic block if it is only
whitespace and a closing brace. These ranges are often after statements
that make these basic blocks unreachable, such as a return/break/continue
statement occurring inside a if/else/while/for block. This check won't
match every highlighted empty closing brace, but catches most of them
because it only does intra block analysis instead of inter block analysis.
- 2:51 PM Changeset in webkit [178862] by
-
- 4 edits in trunk/Source/WebCore
Simple line layout: Move nextTextFragment() to FlowContents class.
https://bugs.webkit.org/show_bug.cgi?id=140738
Reviewed by Antti Koivisto.
This is in preparation to make FlowContents an iterator class.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::TextFragment::TextFragment): Deleted.
(WebCore::SimpleLineLayout::TextFragment::isEmpty): Deleted.
(WebCore::SimpleLineLayout::nextFragment): Deleted.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::nextTextFragment):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::FlowContents::TextFragment::isEmpty):
- 2:49 PM Changeset in webkit [178861] by
-
- 14 edits2 adds in trunk
bmalloc: support aligned allocation
https://bugs.webkit.org/show_bug.cgi?id=140732
Reviewed by Andreas Kling.
PerformanceTests:
- MallocBench/MallocBench.xcodeproj/project.pbxproj:
- MallocBench/MallocBench/Benchmark.cpp:
- MallocBench/MallocBench/memalign.cpp:
(test):
(benchmark_memalign): Added a test for specific interesting memalign values.
- MallocBench/MallocBench/stress_aligned.cpp: Added.
(benchmark_stress_aligned):
- MallocBench/MallocBench/stress_aligned.h: Added. Added a stress test
for arbitrary memalign values.
Source/bmalloc:
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocate): New function for aligned allocation.
Small and medium requests just allocate and free until they find an
aligned pointer. This is slightly inefficient in the worst case, but
still constant-time with little-to-no space overhead.
Large requests use a new API that requires the client to specify both
its ideal size and alignment, and the worst-case size you would have to
allocate in order to produce some interior pointer of the requested size
and alignment. We put the burden of this calculation on the client
because it simplifies things if we guarantee that allocation won't fail.
XLarge requests are easy: we just forward them to vmAllocate, which
already supported aligned requests.
- bmalloc/BoundaryTag.h:
- bmalloc/BoundaryTagInlines.h:
(bmalloc::BoundaryTag::mergeLeft):
(bmalloc::BoundaryTag::mergeRight):
(bmalloc::BoundaryTag::merge):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::split):
(bmalloc::BoundaryTag::allocate): No behavior change here. I just
refactored the interface to remove some reference out parameters in
order to clarify what changes and what doesn't.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateXLarge): Added an alignment API.
(bmalloc::Heap::allocateLarge):
- bmalloc/Heap.h: Added an alignment API. I split out allocateLarge into
a few variants, so aligned and unaligned allocation could share some code.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::take):
- bmalloc/SegregatedFreeList.h: Changed to use a separate, explicit API
for aligned allocation. It turns out that the aligned path is pretty
different, since it ends up searching for two potential ways to satisfy
an allocation: either large enough and aligned, or large enough to split
into something not aligned and something large enough and aligned.
- bmalloc/VMAllocate.h:
(bmalloc::vmAllocate): Switched alignment to come before size because
that's how the memalign API specifies it.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeRange): Added an alignment API.
- 2:43 PM Changeset in webkit [178860] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Updated split such that it does not include the empty end of input string match.
https://bugs.webkit.org/show_bug.cgi?id=138129
<rdar://problem/18807403>
Reviewed by Filip Pizlo.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
- tests/stress/empty_eos_regex_split.js: Added.
- 2:33 PM Changeset in webkit [178859] by
-
- 13 edits in trunk/Source/WebCore
DocumentLoader::timing() should return a reference.
<https://webkit.org/b/128272>
Reviewed by Antti Koivisto.
There is always a DocumentLoadTiming object, so return it by
reference since it can never be null.
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForTiming):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::timing):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
- page/Performance.cpp:
(WebCore::Performance::now):
- page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount):
- page/PerformanceResourceTiming.cpp:
(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
- page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::documentLoadTiming):
- 2:30 PM Changeset in webkit [178858] by
-
- 4 edits in trunk/Source
Crash in QuickLook preview delegate method
https://bugs.webkit.org/show_bug.cgi?id=140740
-and corresponding-
rdar://problem/19540806
Reviewed by Tim Horton.
Clear out the delegate.
Source/WebKit/mac:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
Source/WebKit2:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
- 1:56 PM Changeset in webkit [178857] by
-
- 8 edits in trunk/Source/WebCore
Handle the transition on any character as a separate type of transition
https://bugs.webkit.org/show_bug.cgi?id=140711
Reviewed by Andreas Kling.
Instead of considering the universal transition as 127 transitions, it is now
handled as a separate type of transition.
The goal is to reduce the number of exit edge to consider for each node. Instead
of having 127 for any partition containing one universal transition, we have
as few exit edges as necessary + one universal transition.
In the NFA, the universal transition is stored directly on NFANode in a new
HashSet (transitionsOnAnyCharacter).
The target nodes are made exclusive between "transitionsOnAnyCharacter" and "transitions"
by construction. That is not strictly needed but it simplify debugging at the moment.
When converting a NFA to a DFA, we first find all the node that transition on any character.
Then, when we iterate over "real" transition, we also augment that set with the set on
any character.
When creating the DFA node, we first consider each "real" transition, then we have a single
"fallback" transition for any character that has not been handled yet.
When matching, we first search for any real transition. If there is none but a fallback exists,
we take the fallback.
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::nextState):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::DFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.
- contentextensions/DFANode.h:
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::addTransition):
(WebCore::ContentExtensions::NFA::addTransitionsOnAnyCharacter):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.
- contentextensions/NFA.h:
- contentextensions/NFANode.h:
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::populateTransitions):
(WebCore::ContentExtensions::getOrCreateDFANode):
(WebCore::ContentExtensions::NFAToDFA::convert):
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::GraphBuilder::generateTransition):
- 1:43 PM Changeset in webkit [178856] by
-
- 22 edits in trunk/Source/JavaScriptCore
Eliminate Scope slot from JavaScript CallFrame
https://bugs.webkit.org/show_bug.cgi?id=136724
Reviewed by Geoffrey Garen.
This finishes the removal of the scope chain slot from the call frame header.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLJSCall.cpp:
(JSC::FTL::JSCall::emit):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- interpreter/JSStack.h:
- interpreter/VMInspector.cpp:
(JSC::VMInspector::dumpFrame):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/Repatch.cpp:
(JSC::generateByIdStub):
(JSC::linkClosureCall):
- jit/ThunkGenerators.cpp:
(JSC::virtualForThunkGenerator):
(JSC::nativeForGenerator):
Deleted ScopeChain slot from JSStack. Removed all code where ScopeChain was being
read or set. In most cases this was where we make JS calls.
- interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Deleted.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- interpreter/ProtoCallFrame.cpp:
(JSC::ProtoCallFrame::init):
- interpreter/ProtoCallFrame.h:
(JSC::ProtoCallFrame::scope): Deleted.
(JSC::ProtoCallFrame::setScope): Deleted.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
Removed the related scopeChainValue member from ProtoCallFrame. Reduced the number of
registers that needed to be copied from the ProtoCallFrame to a callee's frame
from 5 to 4.
- llint/LowLevelInterpreter32_64.asm:
In addition to the prior changes, also deleted the unused macro getDeBruijnScope.
- 11:46 AM Changeset in webkit [178855] by
-
- 3 edits in trunk/Source/JavaScriptCore
Eliminate construct methods from NullGetterFunction and NullSetterFunction classes
https://bugs.webkit.org/show_bug.cgi?id=140708
Reviewed by Mark Lam.
Eliminated construct methods and change getConstructData() for both classes to return
ConstructTypeNone as they can never be called.
- runtime/NullGetterFunction.cpp:
(JSC::NullGetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.
- runtime/NullSetterFunction.cpp:
(JSC::NullSetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.
- 11:35 AM Changeset in webkit [178854] by
-
- 470 edits20 moves1 add in trunk/LayoutTests/imported/w3c
Move w3c/canvas/resources/ common resources to w3c/resources/.
https://bugs.webkit.org/show_bug.cgi?id=140712.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-21
Reviewed by Alexey Proskuryakov.
Move the w3c common resources from w3c/canvas/resources/ to w3c/resources/. All
the paths to the common resources from the w3c/canvas and w3c/common should be
../resources/<file name> instead of resources/<file name>
- canvas/2d.clearRect.basic.html:
- canvas/2d.clearRect.clip.html:
- canvas/2d.clearRect.globalalpha.html:
- canvas/2d.clearRect.globalcomposite.html:
- canvas/2d.clearRect.negative.html:
- canvas/2d.clearRect.nonfinite.html:
- canvas/2d.clearRect.path.html:
- canvas/2d.clearRect.shadow.html:
- canvas/2d.clearRect.transform.html:
- canvas/2d.clearRect.zero.html:
- canvas/2d.composite.canvas.copy.html:
- canvas/2d.composite.canvas.destination-atop.html:
- canvas/2d.composite.canvas.destination-in.html:
- canvas/2d.composite.canvas.destination-out.html:
- canvas/2d.composite.canvas.destination-over.html:
- canvas/2d.composite.canvas.lighter.html:
- canvas/2d.composite.canvas.source-atop.html:
- canvas/2d.composite.canvas.source-in.html:
- canvas/2d.composite.canvas.source-out.html:
- canvas/2d.composite.canvas.source-over.html:
- canvas/2d.composite.canvas.xor.html:
- canvas/2d.composite.clip.copy.html:
- canvas/2d.composite.clip.destination-atop.html:
- canvas/2d.composite.clip.destination-in.html:
- canvas/2d.composite.clip.destination-out.html:
- canvas/2d.composite.clip.destination-over.html:
- canvas/2d.composite.clip.lighter.html:
- canvas/2d.composite.clip.source-atop.html:
- canvas/2d.composite.clip.source-in.html:
- canvas/2d.composite.clip.source-out.html:
- canvas/2d.composite.clip.source-over.html:
- canvas/2d.composite.clip.xor.html:
- canvas/2d.composite.globalAlpha.canvas.html:
- canvas/2d.composite.globalAlpha.canvaspattern.html:
- canvas/2d.composite.globalAlpha.fill.html:
- canvas/2d.composite.globalAlpha.image.html:
- canvas/2d.composite.globalAlpha.imagepattern.html:
- canvas/2d.composite.image.copy.html:
- canvas/2d.composite.image.destination-atop.html:
- canvas/2d.composite.image.destination-in.html:
- canvas/2d.composite.image.destination-out.html:
- canvas/2d.composite.image.destination-over.html:
- canvas/2d.composite.image.lighter.html:
- canvas/2d.composite.image.source-atop.html:
- canvas/2d.composite.image.source-in.html:
- canvas/2d.composite.image.source-out.html:
- canvas/2d.composite.image.source-over.html:
- canvas/2d.composite.image.xor.html:
- canvas/2d.composite.uncovered.image.copy.html:
- canvas/2d.composite.uncovered.image.destination-atop.html:
- canvas/2d.composite.uncovered.image.destination-in.html:
- canvas/2d.composite.uncovered.image.source-in.html:
- canvas/2d.composite.uncovered.image.source-out.html:
- canvas/2d.composite.uncovered.pattern.copy.html:
- canvas/2d.composite.uncovered.pattern.destination-atop.html:
- canvas/2d.composite.uncovered.pattern.destination-in.html:
- canvas/2d.composite.uncovered.pattern.source-in.html:
- canvas/2d.composite.uncovered.pattern.source-out.html:
- canvas/2d.drawImage.3arg.html:
- canvas/2d.drawImage.5arg.html:
- canvas/2d.drawImage.9arg.basic.html:
- canvas/2d.drawImage.9arg.destpos.html:
- canvas/2d.drawImage.9arg.destsize.html:
- canvas/2d.drawImage.9arg.sourcepos.html:
- canvas/2d.drawImage.9arg.sourcesize.html:
- canvas/2d.drawImage.alpha.html:
- canvas/2d.drawImage.animated.apng.html:
- canvas/2d.drawImage.animated.gif.html:
- canvas/2d.drawImage.animated.poster.html:
- canvas/2d.drawImage.broken.html:
- canvas/2d.drawImage.canvas.html:
- canvas/2d.drawImage.clip.html:
- canvas/2d.drawImage.composite.html:
- canvas/2d.drawImage.floatsource.html:
- canvas/2d.drawImage.image.incomplete.empty.html:
- canvas/2d.drawImage.image.incomplete.omitted.html:
- canvas/2d.drawImage.incomplete.html:
- canvas/2d.drawImage.negativedest.html:
- canvas/2d.drawImage.negativedir.html:
- canvas/2d.drawImage.negativesource.html:
- canvas/2d.drawImage.nonfinite.html:
- canvas/2d.drawImage.nowrap.html:
- canvas/2d.drawImage.path.html:
- canvas/2d.drawImage.self.1.html:
- canvas/2d.drawImage.self.2.html:
- canvas/2d.drawImage.transform.html:
- canvas/2d.drawImage.zerocanvas.html:
- canvas/2d.drawImage.zerosource.html:
- canvas/2d.fillRect.basic.html:
- canvas/2d.fillRect.clip.html:
- canvas/2d.fillRect.negative.html:
- canvas/2d.fillRect.nonfinite.html:
- canvas/2d.fillRect.path.html:
- canvas/2d.fillRect.shadow.html:
- canvas/2d.fillRect.transform.html:
- canvas/2d.fillRect.zero.html:
- canvas/2d.fillStyle.invalidstring.html:
- canvas/2d.fillStyle.invalidtype.html:
- canvas/2d.fillStyle.parse.current.basic.html:
- canvas/2d.fillStyle.parse.current.changed.html:
- canvas/2d.fillStyle.parse.invalid.hex1.html:
- canvas/2d.fillStyle.parse.invalid.hex2.html:
- canvas/2d.fillStyle.parse.invalid.hex3.html:
- canvas/2d.fillStyle.parse.invalid.hex4.html:
- canvas/2d.fillStyle.parse.invalid.hex5.html:
- canvas/2d.fillStyle.parse.invalid.hex6.html:
- canvas/2d.fillStyle.parse.invalid.hex7.html:
- canvas/2d.fillStyle.parse.invalid.hex8.html:
- canvas/2d.fillStyle.parse.invalid.hsl-1.html:
- canvas/2d.fillStyle.parse.invalid.hsl-2.html:
- canvas/2d.fillStyle.parse.invalid.hsl-3.html:
- canvas/2d.fillStyle.parse.invalid.hsl-4.html:
- canvas/2d.fillStyle.parse.invalid.hsl-5.html:
- canvas/2d.fillStyle.parse.invalid.hsl-6.html:
- canvas/2d.fillStyle.parse.invalid.hsla-1.html:
- canvas/2d.fillStyle.parse.invalid.hsla-2.html:
- canvas/2d.fillStyle.parse.invalid.name-1.html:
- canvas/2d.fillStyle.parse.invalid.name-2.html:
- canvas/2d.fillStyle.parse.invalid.name-3.html:
- canvas/2d.fillStyle.parse.invalid.name-4.html:
- canvas/2d.fillStyle.parse.invalid.name-5.html:
- canvas/2d.fillStyle.parse.invalid.rgb-1.html:
- canvas/2d.fillStyle.parse.invalid.rgb-2.html:
- canvas/2d.fillStyle.parse.invalid.rgb-3.html:
- canvas/2d.fillStyle.parse.invalid.rgb-4.html:
- canvas/2d.fillStyle.parse.invalid.rgb-5.html:
- canvas/2d.fillStyle.parse.invalid.rgb-6.html:
- canvas/2d.fillStyle.parse.invalid.rgb-7.html:
- canvas/2d.fillStyle.parse.invalid.rgba-1.html:
- canvas/2d.fillStyle.parse.invalid.rgba-2.html:
- canvas/2d.fillStyle.parse.invalid.rgba-3.html:
- canvas/2d.fillStyle.parse.invalid.rgba-4.html:
- canvas/2d.fillStyle.parse.invalid.rgba-5.html:
- canvas/2d.fillStyle.parse.invalid.rgba-6.html:
- canvas/2d.fillStyle.parse.invalid.rgba-7.html:
- canvas/2d.getcontext.shared.html:
- canvas/2d.gradient.empty.html:
- canvas/2d.gradient.interpolate.outside.html:
- canvas/2d.gradient.interpolate.overlap2.html:
- canvas/2d.gradient.interpolate.solid.html:
- canvas/2d.gradient.interpolate.zerosize.fill.html:
- canvas/2d.gradient.interpolate.zerosize.fillRect.html:
- canvas/2d.gradient.interpolate.zerosize.fillText.html:
- canvas/2d.gradient.interpolate.zerosize.html:
- canvas/2d.gradient.interpolate.zerosize.stroke.html:
- canvas/2d.gradient.interpolate.zerosize.strokeRect.html:
- canvas/2d.gradient.interpolate.zerosize.strokeText.html:
- canvas/2d.gradient.linear.transform.1.html:
- canvas/2d.gradient.linear.transform.2.html:
- canvas/2d.gradient.linear.transform.3.html:
- canvas/2d.gradient.object.crosscanvas.html:
- canvas/2d.gradient.object.update.html:
- canvas/2d.gradient.radial.cone.behind.html:
- canvas/2d.gradient.radial.cone.beside.html:
- canvas/2d.gradient.radial.cone.bottom.html:
- canvas/2d.gradient.radial.cone.cylinder.html:
- canvas/2d.gradient.radial.cone.front.html:
- canvas/2d.gradient.radial.cone.shape1.html:
- canvas/2d.gradient.radial.cone.shape2.html:
- canvas/2d.gradient.radial.cone.top.html:
- canvas/2d.gradient.radial.equal.html:
- canvas/2d.gradient.radial.inside1.html:
- canvas/2d.gradient.radial.inside2.html:
- canvas/2d.gradient.radial.inside3.html:
- canvas/2d.gradient.radial.outside1.html:
- canvas/2d.gradient.radial.outside2.html:
- canvas/2d.gradient.radial.outside3.html:
- canvas/2d.gradient.radial.touch1.html:
- canvas/2d.gradient.radial.touch2.html:
- canvas/2d.gradient.radial.touch3.html:
- canvas/2d.gradient.radial.transform.1.html:
- canvas/2d.gradient.radial.transform.2.html:
- canvas/2d.gradient.radial.transform.3.html:
- canvas/2d.imageData.get.unaffected.html:
- canvas/2d.imageData.put.basic.html:
- canvas/2d.imageData.put.clip.html:
- canvas/2d.imageData.put.created.html:
- canvas/2d.imageData.put.cross.html:
- canvas/2d.imageData.put.dirty.negative.html:
- canvas/2d.imageData.put.dirty.outside.html:
- canvas/2d.imageData.put.dirty.rect1.html:
- canvas/2d.imageData.put.dirty.rect2.html:
- canvas/2d.imageData.put.dirty.zero.html:
- canvas/2d.imageData.put.modified.html:
- canvas/2d.imageData.put.path.html:
- canvas/2d.imageData.put.unaffected.html:
- canvas/2d.imageData.put.wrongtype.html:
- canvas/2d.line.cap.butt.html:
- canvas/2d.line.cap.closed.html:
- canvas/2d.line.cap.open.html:
- canvas/2d.line.cap.round.html:
- canvas/2d.line.cap.square.html:
- canvas/2d.line.cross.html:
- canvas/2d.line.join.bevel.html:
- canvas/2d.line.join.closed.html:
- canvas/2d.line.join.miter.html:
- canvas/2d.line.join.open.html:
- canvas/2d.line.join.parallel.html:
- canvas/2d.line.join.round.html:
- canvas/2d.line.miter.acute.html:
- canvas/2d.line.miter.exceeded.html:
- canvas/2d.line.miter.lineedge.html:
- canvas/2d.line.miter.obtuse.html:
- canvas/2d.line.miter.rightangle.html:
- canvas/2d.line.miter.within.html:
- canvas/2d.line.union.html:
- canvas/2d.line.width.basic.html:
- canvas/2d.line.width.scaledefault.html:
- canvas/2d.line.width.transformed.html:
- canvas/2d.path.arc.angle.1.html:
- canvas/2d.path.arc.angle.2.html:
- canvas/2d.path.arc.angle.3.html:
- canvas/2d.path.arc.angle.4.html:
- canvas/2d.path.arc.angle.5.html:
- canvas/2d.path.arc.angle.6.html:
- canvas/2d.path.arc.default.html:
- canvas/2d.path.arc.empty.html:
- canvas/2d.path.arc.end.html:
- canvas/2d.path.arc.nonempty.html:
- canvas/2d.path.arc.nonfinite.html:
- canvas/2d.path.arc.scale.1.html:
- canvas/2d.path.arc.scale.2.html:
- canvas/2d.path.arc.selfintersect.1.html:
- canvas/2d.path.arc.selfintersect.2.html:
- canvas/2d.path.arc.shape.1.html:
- canvas/2d.path.arc.shape.2.html:
- canvas/2d.path.arc.shape.3.html:
- canvas/2d.path.arc.shape.4.html:
- canvas/2d.path.arc.shape.5.html:
- canvas/2d.path.arc.twopie.1.html:
- canvas/2d.path.arc.twopie.2.html:
- canvas/2d.path.arc.twopie.3.html:
- canvas/2d.path.arc.twopie.4.html:
- canvas/2d.path.arc.zero.1.html:
- canvas/2d.path.arc.zero.2.html:
- canvas/2d.path.arc.zeroradius.html:
- canvas/2d.path.arcTo.coincide.1.html:
- canvas/2d.path.arcTo.coincide.2.html:
- canvas/2d.path.arcTo.collinear.1.html:
- canvas/2d.path.arcTo.collinear.2.html:
- canvas/2d.path.arcTo.collinear.3.html:
- canvas/2d.path.arcTo.ensuresubpath.1.html:
- canvas/2d.path.arcTo.ensuresubpath.2.html:
- canvas/2d.path.arcTo.nonfinite.html:
- canvas/2d.path.arcTo.scale.html:
- canvas/2d.path.arcTo.shape.curve1.html:
- canvas/2d.path.arcTo.shape.curve2.html:
- canvas/2d.path.arcTo.shape.end.html:
- canvas/2d.path.arcTo.shape.start.html:
- canvas/2d.path.arcTo.transformation.html:
- canvas/2d.path.arcTo.zero.1.html:
- canvas/2d.path.arcTo.zero.2.html:
- canvas/2d.path.beginPath.html:
- canvas/2d.path.bezierCurveTo.basic.html:
- canvas/2d.path.bezierCurveTo.ensuresubpath.1.html:
- canvas/2d.path.bezierCurveTo.ensuresubpath.2.html:
- canvas/2d.path.bezierCurveTo.nonfinite.html:
- canvas/2d.path.bezierCurveTo.scaled.html:
- canvas/2d.path.bezierCurveTo.shape.html:
- canvas/2d.path.clip.basic.1.html:
- canvas/2d.path.clip.basic.2.html:
- canvas/2d.path.clip.empty.html:
- canvas/2d.path.clip.intersect.html:
- canvas/2d.path.clip.unaffected.html:
- canvas/2d.path.clip.winding.1.html:
- canvas/2d.path.clip.winding.2.html:
- canvas/2d.path.closePath.empty.html:
- canvas/2d.path.closePath.newline.html:
- canvas/2d.path.closePath.nextpoint.html:
- canvas/2d.path.fill.closed.basic.html:
- canvas/2d.path.fill.closed.unaffected.html:
- canvas/2d.path.fill.winding.add.html:
- canvas/2d.path.fill.winding.subtract.1.html:
- canvas/2d.path.fill.winding.subtract.2.html:
- canvas/2d.path.fill.winding.subtract.3.html:
- canvas/2d.path.initial.html:
- canvas/2d.path.lineTo.basic.html:
- canvas/2d.path.lineTo.ensuresubpath.1.html:
- canvas/2d.path.lineTo.ensuresubpath.2.html:
- canvas/2d.path.lineTo.nextpoint.html:
- canvas/2d.path.lineTo.nonfinite.html:
- canvas/2d.path.moveTo.basic.html:
- canvas/2d.path.moveTo.multiple.html:
- canvas/2d.path.moveTo.newsubpath.html:
- canvas/2d.path.moveTo.nonfinite.html:
- canvas/2d.path.quadraticCurveTo.basic.html:
- canvas/2d.path.quadraticCurveTo.ensuresubpath.1.html:
- canvas/2d.path.quadraticCurveTo.ensuresubpath.2.html:
- canvas/2d.path.quadraticCurveTo.nonfinite.html:
- canvas/2d.path.quadraticCurveTo.scaled.html:
- canvas/2d.path.quadraticCurveTo.shape.html:
- canvas/2d.path.rect.basic.html:
- canvas/2d.path.rect.closed.html:
- canvas/2d.path.rect.end.1.html:
- canvas/2d.path.rect.end.2.html:
- canvas/2d.path.rect.newsubpath.html:
- canvas/2d.path.rect.nonfinite.html:
- canvas/2d.path.rect.selfintersect.html:
- canvas/2d.path.rect.zero.1.html:
- canvas/2d.path.rect.zero.2.html:
- canvas/2d.path.rect.zero.3.html:
- canvas/2d.path.rect.zero.4.html:
- canvas/2d.path.rect.zero.5.html:
- canvas/2d.path.rect.zero.6.html:
- canvas/2d.path.stroke.empty.html:
- canvas/2d.path.stroke.prune.arc.html:
- canvas/2d.path.stroke.prune.closed.html:
- canvas/2d.path.stroke.prune.corner.html:
- canvas/2d.path.stroke.prune.curve.html:
- canvas/2d.path.stroke.prune.line.html:
- canvas/2d.path.stroke.prune.rect.html:
- canvas/2d.path.stroke.scale1.html:
- canvas/2d.path.stroke.scale2.html:
- canvas/2d.path.stroke.skew.html:
- canvas/2d.path.stroke.unaffected.html:
- canvas/2d.path.stroke.union.html:
- canvas/2d.path.transformation.basic.html:
- canvas/2d.path.transformation.changing.html:
- canvas/2d.path.transformation.multiple.html:
- canvas/2d.pattern.animated.gif.html:
- canvas/2d.pattern.basic.canvas.html:
- canvas/2d.pattern.basic.image.html:
- canvas/2d.pattern.basic.nocontext.html:
- canvas/2d.pattern.basic.type.html:
- canvas/2d.pattern.crosscanvas.html:
- canvas/2d.pattern.image.incomplete.empty.html:
- canvas/2d.pattern.image.incomplete.omitted.html:
- canvas/2d.pattern.modify.canvas1.html:
- canvas/2d.pattern.modify.canvas2.html:
- canvas/2d.pattern.modify.image1.html:
- canvas/2d.pattern.modify.image2.html:
- canvas/2d.pattern.paint.norepeat.basic.html:
- canvas/2d.pattern.paint.norepeat.coord1.html:
- canvas/2d.pattern.paint.norepeat.coord2.html:
- canvas/2d.pattern.paint.norepeat.coord3.html:
- canvas/2d.pattern.paint.norepeat.outside.html:
- canvas/2d.pattern.paint.orientation.canvas.html:
- canvas/2d.pattern.paint.orientation.image.html:
- canvas/2d.pattern.paint.repeat.basic.html:
- canvas/2d.pattern.paint.repeat.coord1.html:
- canvas/2d.pattern.paint.repeat.coord2.html:
- canvas/2d.pattern.paint.repeat.coord3.html:
- canvas/2d.pattern.paint.repeat.outside.html:
- canvas/2d.pattern.paint.repeatx.basic.html:
- canvas/2d.pattern.paint.repeatx.coord1.html:
- canvas/2d.pattern.paint.repeatx.outside.html:
- canvas/2d.pattern.paint.repeaty.basic.html:
- canvas/2d.pattern.paint.repeaty.coord1.html:
- canvas/2d.pattern.paint.repeaty.outside.html:
- canvas/2d.pattern.repeat.empty.html:
- canvas/2d.pattern.repeat.null.html:
- canvas/2d.shadow.alpha.1.html:
- canvas/2d.shadow.canvas.alpha.html:
- canvas/2d.shadow.canvas.basic.html:
- canvas/2d.shadow.canvas.transparent.1.html:
- canvas/2d.shadow.canvas.transparent.2.html:
- canvas/2d.shadow.clip.1.html:
- canvas/2d.shadow.clip.2.html:
- canvas/2d.shadow.clip.3.html:
- canvas/2d.shadow.composite.1.html:
- canvas/2d.shadow.composite.2.html:
- canvas/2d.shadow.composite.3.html:
- canvas/2d.shadow.enable.blur.html:
- canvas/2d.shadow.enable.off.1.html:
- canvas/2d.shadow.enable.off.2.html:
- canvas/2d.shadow.enable.x.html:
- canvas/2d.shadow.enable.y.html:
- canvas/2d.shadow.gradient.basic.html:
- canvas/2d.shadow.gradient.transparent.1.html:
- canvas/2d.shadow.gradient.transparent.2.html:
- canvas/2d.shadow.image.alpha.html:
- canvas/2d.shadow.image.basic.html:
- canvas/2d.shadow.image.scale.html:
- canvas/2d.shadow.image.section.html:
- canvas/2d.shadow.image.transparent.1.html:
- canvas/2d.shadow.image.transparent.2.html:
- canvas/2d.shadow.offset.negativeX.html:
- canvas/2d.shadow.offset.negativeY.html:
- canvas/2d.shadow.offset.positiveX.html:
- canvas/2d.shadow.offset.positiveY.html:
- canvas/2d.shadow.outside.html:
- canvas/2d.shadow.pattern.alpha.html:
- canvas/2d.shadow.pattern.basic.html:
- canvas/2d.shadow.pattern.transparent.1.html:
- canvas/2d.shadow.pattern.transparent.2.html:
- canvas/2d.shadow.stroke.basic.html:
- canvas/2d.shadow.stroke.cap.1.html:
- canvas/2d.shadow.stroke.cap.2.html:
- canvas/2d.shadow.stroke.join.1.html:
- canvas/2d.shadow.stroke.join.2.html:
- canvas/2d.shadow.stroke.join.3.html:
- canvas/2d.shadow.transform.1.html:
- canvas/2d.shadow.transform.2.html:
- canvas/2d.state.saverestore.bitmap.html:
- canvas/2d.state.saverestore.clip.html:
- canvas/2d.state.saverestore.path.html:
- canvas/2d.state.saverestore.transformation.html:
- canvas/2d.strokeRect.basic.html:
- canvas/2d.strokeRect.clip.html:
- canvas/2d.strokeRect.globalalpha.html:
- canvas/2d.strokeRect.globalcomposite.html:
- canvas/2d.strokeRect.negative.html:
- canvas/2d.strokeRect.nonfinite.html:
- canvas/2d.strokeRect.path.html:
- canvas/2d.strokeRect.shadow.html:
- canvas/2d.strokeRect.transform.html:
- canvas/2d.strokeRect.zero.1.html:
- canvas/2d.strokeRect.zero.2.html:
- canvas/2d.strokeRect.zero.3.html:
- canvas/2d.strokeRect.zero.5.html:
- canvas/2d.text.draw.align.center.html:
- canvas/2d.text.draw.align.end.ltr.html:
- canvas/2d.text.draw.align.end.rtl.html:
- canvas/2d.text.draw.align.left.html:
- canvas/2d.text.draw.align.right.html:
- canvas/2d.text.draw.align.start.ltr.html:
- canvas/2d.text.draw.align.start.rtl.html:
- canvas/2d.text.draw.baseline.alphabetic.html:
- canvas/2d.text.draw.fill.maxWidth.bound.html:
- canvas/2d.text.draw.fill.maxWidth.fontface.html:
- canvas/2d.text.draw.fill.maxWidth.negative.html:
- canvas/2d.text.draw.fill.maxWidth.small.html:
- canvas/2d.text.draw.fill.maxWidth.zero.html:
- canvas/2d.text.draw.fill.unaffected.html:
- canvas/2d.text.draw.fontface.html:
- canvas/2d.text.draw.fontface.notinpage.html:
- canvas/2d.text.draw.fontface.repeat.html:
- canvas/2d.text.draw.kern.consistent.html:
- canvas/2d.text.draw.space.basic.html:
- canvas/2d.text.draw.space.collapse.nonspace.html:
- canvas/2d.text.draw.stroke.unaffected.html:
- canvas/2d.transformation.order.html:
- canvas/2d.transformation.rotate.direction.html:
- canvas/2d.transformation.rotate.nonfinite.html:
- canvas/2d.transformation.rotate.radians.html:
- canvas/2d.transformation.rotate.wrap.html:
- canvas/2d.transformation.rotate.wrapnegative.html:
- canvas/2d.transformation.rotate.zero.html:
- canvas/2d.transformation.scale.basic.html:
- canvas/2d.transformation.scale.large.html:
- canvas/2d.transformation.scale.multiple.html:
- canvas/2d.transformation.scale.negative.html:
- canvas/2d.transformation.scale.nonfinite.html:
- canvas/2d.transformation.scale.zero.html:
- canvas/2d.transformation.setTransform.multiple.html:
- canvas/2d.transformation.setTransform.nonfinite.html:
- canvas/2d.transformation.setTransform.skewed.html:
- canvas/2d.transformation.transform.identity.html:
- canvas/2d.transformation.transform.multiply.html:
- canvas/2d.transformation.transform.nonfinite.html:
- canvas/2d.transformation.transform.skewed.html:
- canvas/2d.transformation.translate.basic.html:
- canvas/2d.transformation.translate.nonfinite.html:
- canvas/2d.voidreturn.html:
- canvas/initial.reset.clip.html:
- canvas/initial.reset.gradient.html:
- canvas/initial.reset.pattern.html:
- canvas/initial.reset.transform.html:
- canvas/resources/anim-gr.gif: Removed.
- canvas/resources/anim-gr.png: Removed.
- canvas/resources/anim-poster-gr.png: Removed.
- canvas/resources/background.png: Removed.
- canvas/resources/broken.png: Removed.
- canvas/resources/clear-100x50.png: Removed.
- canvas/resources/ggrr-256x256.png: Removed.
- canvas/resources/green-100x50.png: Removed.
- canvas/resources/green-16x16.png: Removed.
- canvas/resources/green-1x1.png: Removed.
- canvas/resources/green.png: Removed.
- canvas/resources/red-16x16.png: Removed.
- canvas/resources/red.png: Removed.
- canvas/resources/redtransparent.png: Removed.
- canvas/resources/rgrg-256x256.png: Removed.
- canvas/resources/rrgg-256x256.png: Removed.
- canvas/resources/transparent.png: Removed.
- canvas/resources/transparent50.png: Removed.
- canvas/resources/yellow.png: Removed.
- canvas/resources/yellow75.png: Removed.
- canvas/security.dataURI.html:
- canvas/security.drawImage.canvas.html:
- canvas/security.drawImage.image.html:
- canvas/security.pattern.canvas.fillStyle.html:
- canvas/security.pattern.canvas.strokeStyle.html:
- canvas/security.pattern.canvas.timing.html:
- canvas/security.pattern.create.html:
- canvas/security.pattern.cross.html:
- canvas/security.pattern.image.fillStyle.html:
- canvas/security.pattern.image.strokeStyle.html:
- canvas/security.reset.html:
- resources: Added.
- resources/anim-gr.gif: Added.
- resources/anim-gr.png: Added.
- resources/anim-poster-gr.png: Added.
- resources/background.png: Added.
- resources/broken.png: Added.
- resources/clear-100x50.png: Added.
- resources/ggrr-256x256.png: Added.
- resources/green-100x50.png: Added.
- resources/green-16x16.png: Added.
- resources/green-1x1.png: Added.
- resources/green.png: Added.
- resources/red-16x16.png: Added.
- resources/red.png: Added.
- resources/redtransparent.png: Added.
- resources/rgrg-256x256.png: Added.
- resources/rrgg-256x256.png: Added.
- resources/transparent.png: Added.
- resources/transparent50.png: Added.
- resources/yellow.png: Added.
- resources/yellow75.png: Added.
- 11:33 AM Changeset in webkit [178853] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r178180): Membuster regressed ~4%
https://bugs.webkit.org/show_bug.cgi?id=140495
Reviewed by Andreas Kling.
After r178180 we keep system fallback fonts that are used on glyph pages alive.
Previously we would traverse the glyph pages and remove entries referencing system fallbacks.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/FontCascade.cpp:
(WebCore::pruneUnreferencedEntriesFromFontGlyphsCache):
(WebCore::pruneSystemFallbackFonts):
- platform/graphics/FontCascade.h:
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::pruneSystemFallbacks):
When clearing the font cache also remove the cached glyph pages that may contain system fallback fonts
and release the fallbacks.
- platform/graphics/FontGlyphs.h:
- 11:31 AM Changeset in webkit [178852] by
-
- 2 edits in trunk/Tools
https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
https://bugs.webkit.org/show_bug.cgi?id=140731
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
- 11:27 AM Changeset in webkit [178851] by
-
- 5 edits in trunk/LayoutTests
[Win] Unreviewed gardening based on TestBot runs.
Update a few failure cass with bug reports. Rebaseline a handful of tests.
- platform/win/TestExpectations: Update based on bug reports.
- platform/win/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- 11:13 AM Changeset in webkit [178850] by
-
- 4 edits in trunk/Source/WebKit2
AsyncRequestImpl casting in AsyncRequest::completeRequest() is incorrect
https://bugs.webkit.org/show_bug.cgi?id=139724
Reviewed by Darin Adler.
AsyncRequestImpl casting in AsyncRequest::completeRequest() relies on
the parameter pack to properly determine the type of the AsyncRequestImpl
object. The casting result can be incorrect when an argument is passed
by reference while the original object was constructed with a callback
that expects an argument that's passed by value.
To avoid this the AsyncRequestImpl template is now instantiated with
raw types, with callback parameters remaining raw types in case
of being integral (enforcing passing-by-value these arguments when
dispatching), and const references being used otherwise (enforcing
passing-by-reference).
This enables casting AsyncRequest objects to the correct AsyncRequestImpl<>
by running the parameter pack through std::decay.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
- Shared/AsyncRequest.h:
(WebKit::AsyncRequest::completeRequest):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::get):
- 10:59 AM Changeset in webkit [178849] by
-
- 8 edits in trunk
[Win] eventSender does not support scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=140726
<rdar://problem/19549865>
Reviewed by Dean Jackson.
Source/WebKit/win:
- Interfaces/IWebViewPrivate.idl: Add scaleWebView API.
- WebView.cpp:
(WebView::scaleWebView):
Connect WebCore implementation to the Windows COM interface.
- WebView.h:
Tools:
- DumpRenderTree/win/EventSender.cpp:
(scalePageByCallback): Provide implementation using new WebView method.
LayoutTests:
- platform/win/TestExpectations: Unskip test.
- 10:55 AM Changeset in webkit [178848] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API
https://bugs.webkit.org/show_bug.cgi?id=140655
Reviewed by Anders Carlsson.
Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API.
Instead, introduce a new _WKDiagnosticLoggingResultType enum in
_WKDiagnosticLoggingDelegate.h.
A few defines mapping WKDiagnosticLoggingResultType enum and its values
to the new _WKDiagnosticLoggingResultType are temporarily added until
the client-side is transitioned.
- UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
- UIProcess/Cocoa/DiagnosticLoggingClient.mm:
(WebKit::toWKDiagnosticLoggingResultType):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
- 10:52 AM Changeset in webkit [178847] by
-
- 2 edits in trunk/Tools
Remove Apple Mountain Lion Build & Test slaves.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:47 AM Changeset in webkit [178846] by
-
- 1 edit1 copy1 delete in branches/safari-600.1.4.15-branch
Merged r177088. rdar://problem/19339033
- 10:46 AM Changeset in webkit [178845] by
-
- 6 edits1 copy in branches/safari-600.1.4.15-branch
Merged r177000. rdar://problem/19339033
- 10:44 AM Changeset in webkit [178844] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176977. rdar://problem/19420073
- 10:43 AM Changeset in webkit [178843] by
-
- 3 edits3 copies in branches/safari-600.1.4.15-branch
Merged r176972. rdar://problem/19450085
- 10:42 AM Changeset in webkit [178842] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WTF
Merged r176982. rdar://problem/19419996
- 10:41 AM Changeset in webkit [178841] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176971. rdar://problem/19419996
- 10:40 AM Changeset in webkit [178840] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176969. rdar://problem/19302738
- 10:39 AM Changeset in webkit [178839] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176948. rdar://problem/19419766
- 10:38 AM Changeset in webkit [178838] by
-
- 9 edits in branches/safari-600.1.4.15-branch
Merged r176904. rdar://problem/19419865
- 10:32 AM Changeset in webkit [178837] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176768. rdar://problem/19450126
- 10:31 AM Changeset in webkit [178836] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176734. rdar://problem/19420067
- 10:30 AM Changeset in webkit [178835] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176701. rdar://problem/19419925
- 10:30 AM Changeset in webkit [178834] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176484. rdar://problem/19419988
- 10:29 AM Changeset in webkit [178833] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176471. rdar://problem/19419820
- 10:28 AM Changeset in webkit [178832] by
-
- 4 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176447. rdar://problem/19419828
- 10:25 AM Changeset in webkit [178831] by
-
- 4 edits3 copies in branches/safari-600.1.4.15-branch
Merged r176372. rdar://problem/19419916
- 10:24 AM Changeset in webkit [178830] by
-
- 5 edits9 copies in branches/safari-600.1.4.15-branch
Merged r176354. rdar://problem/19432696
- 10:20 AM Changeset in webkit [178829] by
-
- 7 edits in branches/safari-600.1.4.15-branch
Merged r176318. rdar://problem/19339000
- 10:06 AM Changeset in webkit [178828] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176305. rdar://problem/19395081
- 10:05 AM Changeset in webkit [178827] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176285. rdar://problem/19420011
- 9:02 AM Changeset in webkit [178826] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening after reactivating some tests.
- platform/win/TestExpectations: Add failure entries for a few tests with bug reports.
- 9:00 AM Changeset in webkit [178825] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Use C++ lambdas in ProcessLauncher class
https://bugs.webkit.org/show_bug.cgi?id=138186
Reviewed by Darin Adler.
Replace uses of WTF::bind() in the ProcessLauncher class with C++ lambdas.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):
- 8:55 AM Changeset in webkit [178824] by
-
- 2 edits in trunk/Source/WebKit2
Clean up ViewUpdateDispatcher
https://bugs.webkit.org/show_bug.cgi?id=140619
Reviewed by Darin Adler.
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
Replace WTF::bind() with a C++ lambda.
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
Use WTF::move() to move the HashMap member into the local variable.
- 2:20 AM Changeset in webkit [178823] by
-
- 2 edits in trunk
[EFL][WK2] EFL MiniBrowser doesn't run because shared library is not found
https://bugs.webkit.org/show_bug.cgi?id=140049
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsCommon.cmake:
- 2:02 AM Changeset in webkit [178822] by
-
- 7 edits4 adds in trunk
first-letter pseudo-element from ancestors is not being ignored in grids and flexboxes
https://bugs.webkit.org/show_bug.cgi?id=138424
Reviewed by Benjamin Poulain.
Source/WebCore:
Source/WebCore:
According to the grid and flexbox specs:
"::first-letter pseudo-element do not apply to grid/flex containers".
http://dev.w3.org/csswg/css-grid/#grid-containers
http://dev.w3.org/csswg/css-flexbox/#flex-containers
Check also the CSS WG mailing list discussion:
http://lists.w3.org/Archives/Public/www-style/2014Dec/0305.html
This was almost working right, except in the case that an ancestor was
setting the ::first-letter pseudo-element.
Added a few more cases to the current tests in order to check this
behavior.
Also created some new tests to increase coverage
Tests: fast/css/first-letter-from-ancestors-not-apply-inline-elements.html
fast/css/first-letter-ignores-display-property.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getFirstLetter): Go to the next sibling when
looking for the first text child if you reach a grid or flexbox.
LayoutTests:
Modified current tests to check that first-letter from ancestors is
ignored too.
Added 2 new tests to increase coverage.
- css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt:
- css3/flexbox/flexbox-ignore-container-firstLetter.html:
- fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt:
- fast/css-grid-layout/grid-container-ignore-first-letter.html:
- fast/css/first-letter-from-ancestors-not-apply-inline-elements-expected.html: Added.
- fast/css/first-letter-from-ancestors-not-apply-inline-elements.html: Added.
- fast/css/first-letter-ignores-display-property-expected.html: Added.
- fast/css/first-letter-ignores-display-property.html: Added.
- 1:52 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:51 AM WebKitGTK/Roadmap edited by
- (diff)
- 12:46 AM Changeset in webkit [178821] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align warning in Source/WebCore/platform/efl/EflScreenUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=140670
Reviewed by Darin Adler.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::createCustomCursor):
- 12:45 AM Changeset in webkit [178820] by
-
- 262 edits in trunk
Remove ENABLE(INSPECTOR) ifdef guards
https://bugs.webkit.org/show_bug.cgi?id=140668
Reviewed by Darin Adler.
.:
- Source/PlatformEfl.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- bindings/ScriptValue.cpp:
(Deprecated::ScriptValue::toInspectorValue):
- bindings/ScriptValue.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/ContentSearchUtilities.cpp:
- inspector/ContentSearchUtilities.h:
- inspector/IdentifiersFactory.cpp:
- inspector/IdentifiersFactory.h:
- inspector/InjectedScript.cpp:
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
- inspector/InjectedScriptModule.h:
- inspector/InspectorAgentRegistry.cpp:
- inspector/InspectorBackendDispatcher.cpp:
- inspector/InspectorBackendDispatcher.h:
- inspector/InspectorProtocolTypes.h:
- inspector/JSGlobalObjectConsoleClient.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectScriptDebugServer.cpp:
- inspector/JSGlobalObjectScriptDebugServer.h:
- inspector/JSInjectedScriptHost.cpp:
- inspector/JSInjectedScriptHost.h:
- inspector/JSInjectedScriptHostPrototype.cpp:
- inspector/JSInjectedScriptHostPrototype.h:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
- inspector/JSJavaScriptCallFramePrototype.h:
- inspector/JavaScriptCallFrame.cpp:
- inspector/JavaScriptCallFrame.h:
- inspector/ScriptCallFrame.cpp:
(Inspector::ScriptCallFrame::buildInspectorObject):
- inspector/ScriptCallFrame.h:
- inspector/ScriptCallStack.cpp:
(Inspector::ScriptCallStack::buildInspectorArray):
- inspector/ScriptCallStack.h:
- inspector/ScriptDebugServer.cpp:
- inspector/agents/InspectorAgent.cpp:
- inspector/agents/InspectorAgent.h:
- inspector/agents/InspectorConsoleAgent.cpp:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorRuntimeAgent.cpp:
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.cpp:
- inspector/agents/JSGlobalObjectConsoleAgent.h:
- inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
- inspector/agents/JSGlobalObjectDebuggerAgent.h:
- inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
- inspector/agents/JSGlobalObjectRuntimeAgent.h:
- inspector/scripts/codegen/cpp_generator_templates.py:
(CppGeneratorTemplates):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::inspectorRepresentation):
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- bindings/js/JSCommandLineAPIHostCustom.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/js/ScriptController.h:
- bindings/js/ScriptGlobalObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptGlobalObject.h:
- bindings/js/WorkerScriptDebugServer.cpp:
- bindings/js/WorkerScriptDebugServer.h:
- dom/Node.cpp:
(WebCore::Node::inspect):
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.idl:
- inspector/CommandLineAPIModule.cpp:
- inspector/CommandLineAPIModule.h:
- inspector/DOMEditor.cpp:
- inspector/DOMEditor.h:
- inspector/DOMPatchSupport.cpp:
- inspector/DOMPatchSupport.h:
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorClient.cpp:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseInstrumentation.h:
(WebCore::InspectorInstrumentation::didOpenDatabase):
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorHistory.cpp:
- inspector/InspectorHistory.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::mediaQueryResultChanged):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
(WebCore::InspectorInstrumentation::handleTouchEvent):
(WebCore::InspectorInstrumentation::handleMousePress):
(WebCore::InspectorInstrumentation::forcePseudoState):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didCallFunction):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::didEvaluateScript):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::didFireTimer):
(WebCore::InspectorInstrumentation::didInvalidateLayout):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::didLayout):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore::InspectorInstrumentation::didScrollLayer):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::didRecalculateStyle):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):
(WebCore::InspectorInstrumentation::applyEmulatedMedia):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::continueAfterPingLoader):
(WebCore::InspectorInstrumentation::markResourceAsCached):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
(WebCore::InspectorInstrumentation::continueWithPolicyDownload):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::didFailXHRLoading):
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
(WebCore::InspectorInstrumentation::didReceiveXHRResponse):
(WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::scriptImported):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
(WebCore::InspectorInstrumentation::didReceiveScriptResponse):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::frameDocumentUpdated):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEvent):
(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
(WebCore::InspectorInstrumentation::sessionCreated):
(WebCore::InspectorInstrumentation::sessionLoaded):
(WebCore::InspectorInstrumentation::sessionModified):
(WebCore::InspectorInstrumentation::segmentCreated):
(WebCore::InspectorInstrumentation::segmentCompleted):
(WebCore::InspectorInstrumentation::segmentLoaded):
(WebCore::InspectorInstrumentation::segmentUnloaded):
(WebCore::InspectorInstrumentation::captureStarted):
(WebCore::InspectorInstrumentation::captureStopped):
(WebCore::InspectorInstrumentation::playbackStarted):
(WebCore::InspectorInstrumentation::playbackPaused):
(WebCore::InspectorInstrumentation::playbackFinished):
(WebCore::InspectorInstrumentation::playbackHitPosition):
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
(WebCore::InspectorInstrumentation::didFireAnimationFrame):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed):
(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):
(WebCore::InspectorInstrumentation::hasFrontends): Deleted.
(WebCore::InspectorInstrumentation::consoleAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::runtimeAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::timelineAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::replayAgentEnabled): Deleted.
- inspector/InspectorLayerTreeAgent.cpp:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorReplayAgent.cpp:
- inspector/InspectorReplayAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp:
- inspector/InspectorStyleSheet.h:
- inspector/InspectorStyleTextEditor.cpp:
- inspector/InspectorStyleTextEditor.h:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerResource.h:
- inspector/InstrumentingAgents.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageConsoleAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/PageScriptDebugServer.cpp:
- inspector/PageScriptDebugServer.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/WebConsoleAgent.cpp:
- inspector/WebConsoleAgent.h:
- inspector/WebDebuggerAgent.cpp:
- inspector/WebDebuggerAgent.h:
- inspector/WebInjectedScriptHost.cpp:
- inspector/WebInjectedScriptHost.h:
- inspector/WebInjectedScriptManager.cpp:
- inspector/WebInjectedScriptManager.h:
- inspector/WorkerConsoleAgent.cpp:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::applicationCacheInfo):
- loader/appcache/ApplicationCacheHost.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
- page/Page.h:
- platform/ContextMenuItem.h:
- platform/efl/EflInspectorUtilities.cpp:
- platform/efl/EflInspectorUtilities.h:
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
- testing/Internals.cpp:
(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setInspectorIsUnderTest):
- testing/Internals.h:
- testing/Internals.idl:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerGlobalScope.h:
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSendRequest):
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(registerWindowClass):
- WebInspector.cpp:
(WebInspector::setTimelineProfilingEnabled):
- WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
- WebNodeHighlight.h:
- WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
- WebView.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorGetTypeID):
(WKInspectorGetPage):
(WKInspectorIsConnected):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorConnect):
(WKInspectorShow):
(WKInspectorHide):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetInspector):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- UIProcess/PageClient.h:
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
- UIProcess/efl/WebInspectorProxyEfl.cpp:
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableInspectorNodeSearch):
- UIProcess/ios/WebInspectorProxyIOS.mm:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::disableInspectorNodeSearch):
- UIProcess/mac/WebInspectorProxyMac.mm:
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorGetTypeID):
(WKBundleInspectorShow):
(WKBundleInspectorClose):
(WKBundleInspectorEvaluateScriptForTest):
(WKBundleInspectorSetPageProfilingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetInspector):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in:
- WebProcess/WebPage/WebInspectorUI.cpp:
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebPage/WebInspectorUI.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/efl/WebInspectorEfl.cpp:
- WebProcess/WebPage/efl/WebInspectorUIEfl.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::disableInspectorNodeSearch):
- WebProcess/WebPage/mac/WebInspectorMac.mm:
- WebProcess/WebPage/mac/WebInspectorUIMac.mm:
- config.h:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):
- Scripts/webkitperl/FeatureList.pm:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::showWebInspector):
(WTR::TestRunner::closeWebInspector):
(WTR::TestRunner::evaluateInWebInspector):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 12:20 AM Changeset in webkit [178819] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175818. rdar://problem/19419835
- 12:18 AM Changeset in webkit [178818] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175812. rdar://problem/19420081
- 12:17 AM Changeset in webkit [178817] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175771. rdar://problem/19450090
- 12:16 AM Changeset in webkit [178816] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175718. rdar://problem/19395083
- 12:15 AM Changeset in webkit [178815] by
-
- 6 edits2 copies in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175698. rdar://problem/19419806
- 12:13 AM Changeset in webkit [178814] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175636. rdar://problem/19419798
- 12:12 AM Changeset in webkit [178813] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175334. rdar://problem/19302743
- 12:11 AM Changeset in webkit [178812] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175277. rdar://problem/19419795
- 12:10 AM Changeset in webkit [178811] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175266. rdar://problem/19420035
- 12:06 AM Changeset in webkit [178810] by
-
- 4 edits3 copies in branches/safari-600.1.4.15-branch
Merged r175236. rdar://problem/19432709
Jan 20, 2015:
- 11:37 PM Changeset in webkit [178809] by
-
- 9 edits in branches/safari-600.4-branch
Rollout r178679. rdar://problem/19448129
- 11:23 PM Changeset in webkit [178808] by
-
- 21 edits157 adds in trunk/LayoutTests
[Win] Unreviewed gardening.
Rebaseline and clean-up of skipped files.
- platform/win/TestExpectations:
- platform/win/css2.1/20110323: Added.
- platform/win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/win/css2.1/20110323/border-conflict-style-079-expected.png: Added.
- platform/win/css2.1/20110323/border-conflict-style-088-expected.png: Added.
- platform/win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
- platform/win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
- platform/win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
- platform/win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
- platform/win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
- platform/win/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
- platform/win/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
- platform/win/css2.1/20110323/height-width-table-001-expected.png: Added.
- platform/win/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
- platform/win/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
- platform/win/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/win/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/win/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-001-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-002-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-003-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-004-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-005-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-006-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-007-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-008-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-009-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-010-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-012-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-013-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-014-expected.png: Added.
- platform/win/css2.1/20110323/margin-applies-to-015-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-001-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-002-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
- platform/win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
- platform/win/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
- platform/win/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
- platform/win/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
- platform/win/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Added.
- platform/win/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
- platform/win/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
- platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added.
- platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
- platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
- platform/win/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
- platform/win/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
- platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
- platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/win/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
- platform/win/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
- platform/win/css2.1/t09-c5526c-display-00-e-expected.png: Added.
- platform/win/css2.1/t09-c5526c-display-00-e-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-01-b-expected.png: Added.
- platform/win/css2.1/t0905-c414-flt-01-b-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-02-c-expected.png: Added.
- platform/win/css2.1/t0905-c414-flt-02-c-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-03-c-expected.png: Added.
- platform/win/css2.1/t0905-c414-flt-03-c-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-04-c-expected.png: Added.
- platform/win/css2.1/t0905-c414-flt-04-c-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
- platform/win/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
- platform/win/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Added.
- platform/win/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
- platform/win/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
- platform/win/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Added.
- platform/win/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
- platform/win/css2.1/t090501-c414-flt-01-b-expected.png: Added.
- platform/win/css2.1/t090501-c414-flt-01-b-expected.txt: Added.
- platform/win/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
- platform/win/css2.1/t090501-c414-flt-03-b-g-expected.txt: Added.
- platform/win/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt: Added.
- platform/win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
- platform/win/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Added.
- platform/win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
- platform/win/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Added.
- platform/win/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png: Added.
- platform/win/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: Added.
- platform/win/css2.1/t1202-counter-03-b-expected.txt: Added.
- platform/win/css2.1/t1202-counter-04-b-expected.png: Added.
- platform/win/css2.1/t1202-counter-04-b-expected.txt:
- platform/win/css2.1/t1202-counters-03-b-expected.png: Added.
- platform/win/css2.1/t1202-counters-03-b-expected.txt: Added.
- platform/win/css2.1/t1202-counters-04-b-expected.png: Added.
- platform/win/css2.1/t1202-counters-04-b-expected.txt:
- platform/win/css2.1/t1205-c566-list-stl-01-c-g-expected.png: Added.
- platform/win/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Added.
- platform/win/css3/selectors3: Added.
- platform/win/css3/selectors3/html: Added.
- platform/win/css3/selectors3/html/css3-modsel-161-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-161-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-19b-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-23-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-24-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-24-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-25-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-25-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-64-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-64-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-68-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-68-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-69-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
- platform/win/css3/selectors3/html/css3-modsel-70-expected.png: Added.
- platform/win/css3/selectors3/html/css3-modsel-70-expected.txt: Added.
- platform/win/css3/selectors3/xhtml: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-64-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-68-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png: Added.
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt: Added.
- platform/win/css3/selectors3/xml: Added.
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-19b-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-24-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-64-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-64-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-68-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.png: Added.
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt: Added.
- platform/win/fast/block/float/016-expected.png: Added.
- platform/win/fast/block/float/016-expected.txt: Added.
- platform/win/fast/css/non-standard-checkbox-size-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- 11:22 PM Changeset in webkit [178807] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit/mac
Merge r178680. rdar://problem/19489593
- 11:22 PM Changeset in webkit [178806] by
-
- 9 edits in branches/safari-600.4-branch
Merge r178679. rdar://problem/19448129
- 11:21 PM Changeset in webkit [178805] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit/mac
Merge r178676. rdar://problem/19489593
- 11:21 PM Changeset in webkit [178804] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit/mac
Merge r178605. rdar://problem/19490114
- 11:21 PM Changeset in webkit [178803] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r178595. rdar://problem/19490114
- 11:17 PM Changeset in webkit [178802] by
-
- 4 edits4 deletes in trunk/Tools
Update build.webkit.org/dashboard to match current Mac queues.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
(table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
- 10:48 PM Changeset in webkit [178801] by
-
- 5 edits in trunk/Source
Versioning.
- 10:47 PM Changeset in webkit [178800] by
-
- 1 copy in tags/Safari-601.1.15
New tag.
- 10:40 PM Changeset in webkit [178799] by
-
- 2 edits in trunk/LayoutTests
inspector/model/remote-object-get-properties.html asserts
- TestExpectations: Skip the test for now.
- 9:08 PM Changeset in webkit [178798] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (Yosemite): HTTP tests time out waiting for subresources
https://bugs.webkit.org/show_bug.cgi?id=140715
Rubber-stamped by Mark Rowe.
Enable Apache performance logging to better isolate the issue.
- http/conf/apache2.4-httpd.conf:
- 8:55 PM Changeset in webkit [178797] by
-
- 4 edits in trunk/Source/WebKit/mac
Remove USE(GLIB) code from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=140714
Reviewed by Andreas Kling.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
(-[WebView _clearGlibLoopObserver]): Deleted.
(glibContextIterationCallback): Deleted.
(-[WebView _scheduleGlibContextIterations]): Deleted.
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
- 8:22 PM Changeset in webkit [178796] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Clean up InjectedScriptSource.js
https://bugs.webkit.org/show_bug.cgi?id=140709
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-20
Reviewed by Timothy Hatcher.
This patch includes some relevant Blink patches and small changes.
Patch by <aandrey@chromium.org>
DevTools: Remove console last result $_ on console clear.
https://src.chromium.org/viewvc/blink?revision=179179&view=revision
Patch by <eustas@chromium.org>
[Inspect DOM properties] incorrect CSS Selector Syntax
https://src.chromium.org/viewvc/blink?revision=156903&view=revision
- inspector/InjectedScriptSource.js:
- 6:44 PM Changeset in webkit [178795] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Remove variable objectId from output.
- inspector/model/remote-object-get-properties-expected.txt:
- inspector/model/remote-object-get-properties.html:
- 6:16 PM Changeset in webkit [178794] by
-
- 10 edits in trunk/Source/WebCore
Simplify DiagnosticLoggingClient call sites
https://bugs.webkit.org/show_bug.cgi?id=140701
Reviewed by Andreas Kling.
Simplify DiagnosticLoggingClient call sites by:
- Moving the Settings::diagnosticLoggingEnabled() check inside the MainFrame::diagnosticLoggingClient() getter.
- Having MainFrame::diagnosticLoggingClient() return a reference instead of a pointer (returning a dummy client if necessary).
Otherwise, each call site needs to both check the setting and do a
null-check on the client which is a bit annoying.
- history/PageCache.cpp:
(WebCore::logPageCacheFailureDiagnosticMessage):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::logNavigation):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
- page/DiagnosticLoggingClient.h:
(WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Deleted.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Deleted.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Deleted.
- page/MainFrame.cpp:
(WebCore::MainFrame::diagnosticLoggingClient):
- page/MainFrame.h:
- 5:59 PM Changeset in webkit [178793] by
-
- 3 edits in trunk/LayoutTests
[Win] Rebaseline a test, unskip some working tests.
- platform/win/TestExpectations:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 5:59 PM Changeset in webkit [178792] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
config fix after r178790.
- 5:54 PM Changeset in webkit [178791] by
-
- 5 edits in trunk/Source/JavaScriptCore
Web Inspector: Cleanup RuntimeAgent a bit
https://bugs.webkit.org/show_bug.cgi?id=140706
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-20
Reviewed by Timothy Hatcher.
- inspector/InjectedScript.h:
- inspector/InspectorBackendDispatcher.h:
- inspector/ScriptCallFrame.cpp:
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::run):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::recompileAllJSFunctionsForTypeProfiling):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
- 5:37 PM Changeset in webkit [178790] by
-
- 2 edits in trunk/Tools
Update Apple MountainLion Leaks slave to Yosemite
Update Apple MountainLion Release (32-bit) Build slave to Yosemite
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:16 PM Changeset in webkit [178789] by
-
- 2 edits in trunk/LayoutTests
[Win] More test gardening.
- platform/win/TestExpectations: Mark several tests as failing now that bug
reports have been filed for them.
- 5:12 PM Changeset in webkit [178788] by
-
- 3 edits in trunk/Source/JavaScriptCore
Made Identity in the DFG allocate a new temp register and move
the old data to it.
https://bugs.webkit.org/show_bug.cgi?id=140700
<rdar://problem/19339106>
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Added scratch registers for Identity.
- tests/mozilla/mozilla-tests.yaml: enabled previously failing test
- 5:10 PM Changeset in webkit [178787] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Use spread operator in a few places
https://bugs.webkit.org/show_bug.cgi?id=140699
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-20
Reviewed by Geoffrey Garen.
- UserInterface/Controllers/ProbeManager.js:
(WebInspector.ProbeManager.prototype.get probeSets):
Simplify by using the spread operator.
- UserInterface/Models/TimelineRecording.js:
This actually fixes an issue. The one place this was used was expecting
an array and called ".length" on the result. However, the iterator being
returned does not have a ".length" property so it was always undefined.
- 5:08 PM Changeset in webkit [178786] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r175241. rdar://problem/19419939
- 5:06 PM Changeset in webkit [178785] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175135. rdar://problem/19420028
- 5:05 PM Changeset in webkit [178784] by
-
- 4 edits2 copies in branches/safari-600.1.4.15-branch
Merged r175131. rdar://problem/19420045
- 5:04 PM Changeset in webkit [178783] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174832. rdar://problem/19420050
- 5:03 PM Changeset in webkit [178782] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174756. rdar://problem/19420050
- 5:02 PM Changeset in webkit [178781] by
-
- 9 edits in branches/safari-600.1.4.15-branch
Merged r174741. rdar://problem/19369440
- 5:00 PM Changeset in webkit [178780] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r174716. rdar://problem/19432665
- 4:59 PM Changeset in webkit [178779] by
-
- 10 edits in branches/safari-600.1.4.15-branch
Merged r174712. rdar://problem/19419947
- 4:56 PM Changeset in webkit [178778] by
-
- 1 edit2 copies2 deletes in branches/safari-600.1.4.15-branch/LayoutTests
Merged r174614. rdar://problem/19419964
- 4:55 PM Changeset in webkit [178777] by
-
- 6 edits2 copies in branches/safari-600.1.4.15-branch
Merged r174540. rdar://problem/19419964
- 4:52 PM Changeset in webkit [178776] by
-
- 2 edits in trunk/Tools
Update LeaksViewer from MountainLion to Yosemite
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):
- 4:51 PM Changeset in webkit [178775] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174345. rdar://problem/19450106
- 4:50 PM Changeset in webkit [178774] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Tools
Merged r174376. rdar://problem/19419888
- 4:50 PM Changeset in webkit [178773] by
-
- 4 edits2 copies in branches/safari-600.1.4.15-branch
Merged r174330. rdar://problem/19419888
- 4:48 PM Changeset in webkit [178772] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174148. rdar://problem/19419899
- 4:47 PM Changeset in webkit [178771] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r173934. rdar://problem/19419953
- 4:46 PM Changeset in webkit [178770] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r173790. rdar://problem/19433162
- 4:42 PM Changeset in webkit [178769] by
-
- 3 edits93 adds in trunk/LayoutTests
[Win] Unreviewed test gardening.
Now that Mac has switched to new SVG font results, commit the old Mac output for
use with Windows tests until they are also cut over.
- platform/win/TestExpectations:
- platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
- platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
- platform/win/svg/custom/glyph-setting-d-attribute-expected.png: Added.
- platform/win/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
- platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
- platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
- platform/win/svg/foreignObject: Added.
- platform/win/svg/foreignObject/text-tref-02-b-expected.png: Added.
- platform/win/svg/foreignObject/text-tref-02-b-expected.txt: Added.
- platform/win/svg/text/kerning-expected.png: Added.
- platform/win/svg/text/kerning-expected.txt: Added.
- platform/win/svg/text/multichar-glyph-expected.png: Added.
- platform/win/svg/text/multichar-glyph-expected.txt: Added.
- platform/win/svg/transforms: Added.
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- 4:34 PM Changeset in webkit [178768] by
-
- 11 edits2 adds in trunk
Web Inspector: Expanding event objects in console shows undefined for most values, it should have real values
https://bugs.webkit.org/show_bug.cgi?id=137306
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-20
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Provide another optional parameter to getProperties, to gather a list
of all own and getter properties.
- inspector/InjectedScript.cpp:
(Inspector::InjectedScript::getProperties):
- inspector/InjectedScript.h:
- inspector/InjectedScriptSource.js:
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getProperties):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
Source/WebInspectorUI:
When first expanding an object, show all the object's own properties and any
getter properties that may be on its prototype chain. Now, we only fetch
own properties, for proto properties.
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getOwnAndGetterProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype.get hasChildren): Deleted.
- UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
LayoutTests:
- inspector/model/remote-object-get-properties-expected.txt: Added.
- inspector/model/remote-object-get-properties.html: Added.
- 4:30 PM Changeset in webkit [178767] by
-
- 13 edits2 adds in trunk
Web Inspector: Should show dynamic specificity values
https://bugs.webkit.org/show_bug.cgi?id=140647
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-20
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- inspector/protocol/CSS.json:
Clarify CSSSelector optional values and add "dynamic" property indicating
if the selector can be dynamic based on the element it is matched against.
Source/WebCore:
Test: inspector/css/selector-dynamic-specificity.html
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::buildObjectForRule):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
When building a response for a particular element, pass the element along.
- inspector/InspectorStyleSheet.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::hasDynamicSpecificity):
(WebCore::buildObjectForSelectorHelper):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelector):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
When building a response for a Selector, include the specificity if we know
the element in context.
Source/WebInspectorUI:
For dynamic selectors, provide text in the tooltip describing that the
specificity is dynamic and may change, and pointing out the element
the current value was calculated against.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Models/CSSSelector.js:
(WebInspector.CSSSelector):
(WebInspector.CSSSelector.prototype.get specificity):
(WebInspector.CSSSelector.prototype.get dynamic):
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
(WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
LayoutTests:
- inspector/css/selector-dynamic-specificity-expected.txt: Added.
- inspector/css/selector-dynamic-specificity.html: Added.
- 4:28 PM Changeset in webkit [178766] by
-
- 3 edits in trunk/LayoutTests
http/tests/xmlhttprequest/xmlhttprequest-responseURL.html uses an incorrect resource path
https://bugs.webkit.org/show_bug.cgi?id=140689
Reviewed by Tim Horton.
- http/tests/xmlhttprequest/xmlhttprequest-responseURL-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-responseURL.html:
- 4:26 PM Changeset in webkit [178765] by
-
- 2 edits in trunk/LayoutTests
Noise about undefined $ENV{"HTTP_ORIGIN"} in Apache logs on several tests
https://bugs.webkit.org/show_bug.cgi?id=140690
Reviewed by Tim Horton.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
- 4:25 PM Changeset in webkit [178764] by
-
- 2 edits1 move in trunk/LayoutTests
malformed header from script 'noContentLength.asis': Bad header
https://bugs.webkit.org/show_bug.cgi?id=140693
Reviewed by Tim Horton.
Changed the resource to actually have no Content-Length, and adjusted incorrect test
expectations.
- http/tests/xmlhttprequest/resources/noContentLength.asis: Removed.
- http/tests/xmlhttprequest/resources/noContentLength.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/resources/noContentLength.asis.
- http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:
- 4:21 PM Changeset in webkit [178763] by
-
- 2 edits in trunk/LayoutTests
Apache logs a warning in http/tests/resources/post-and-verify-hybrid.cgi
https://bugs.webkit.org/show_bug.cgi?id=140680
Reviewed by Tim Horton.
- http/tests/resources/post-and-verify-hybrid.cgi: Fix a "useless use of a variable
in void context".
- 4:13 PM Changeset in webkit [178762] by
-
- 2 edits in trunk/Source/WebCore
[Win] Build fix after r178760.
Windows will not accept a variable as the size declaration for an array.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendGSUBTable): Make size argument a const.
- 4:05 PM Changeset in webkit [178761] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed Windows project file gardening.
- WebCore.vcxproj/WebCore.vcxproj: Add missing SVG files and put things in their proper
folders.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 3:32 PM Changeset in webkit [178760] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed gardening.
- win/tools/vsprops/FeatureDefines.props: Add feature definition for SVG converter,
but do NOT turn it on.
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
- 3:11 PM Changeset in webkit [178759] by
-
- 2 edits in trunk/Source/WebCore
URLFilterParser dismisses the last atom when parsing a builtin character class
https://bugs.webkit.org/show_bug.cgi?id=140695
Reviewed by Andreas Kling.
The pending atom was not sunk before creating the new atom.
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::GraphBuilder::atomBuiltInCharacterClass):
- 3:10 PM Changeset in webkit [178758] by
-
- 5 edits1 add in trunk/Source/WebCore
Fast path for casting JSValue to JSDocument*.
<https://webkit.org/b/134655>
Add a custom JSType bit for JSDocument so we can quickly cast to it
from JSValue in the DocumentPrototype functions. This removes a bunch
of grunt work and branches from common functions like getElementById.
Also removed GetCastingHelperForBaseObject and replace it with
simple jsCasts since we don't need dynamic type checks for the base.
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWrapper.h:
- bindings/js/JSDocumentCustom.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GetCastingHelperForThisObject):
(GenerateImplementation):
(GetCastingHelperForBaseObject): Deleted.
- dom/Document.idl:
- 2:43 PM Changeset in webkit [178757] by
-
- 7 edits in trunk/Tools
Fix EWS python unit tests and address code comments as per 140476
https://bugs.webkit.org/show_bug.cgi?id=140637
Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2015-01-20
Reviewed by David Kilzer.
- Scripts/webkitpy/port/base.py:
(Port):
(Port.init):
Adds DEFAULT_ARCHITECTURE member.
(Port.architecture):
Removes architecture member and instead uses
self.get_option('architecture'). Also removes redundant architecture
method.
(Port.set_architecture):
Adds a setter for the architecture variable to be able to set a flag
upon modification.
(Port.test_configuration):
Uses self.architecture() instead of self._architecture.
- Scripts/webkitpy/port/ios.py:
Overrides DEFAULT_ARCHITECTURE.
(IOSPort):
(IOSPort.determine_full_port_name):
Uses subprocess.check_output instead of Popen. Uses rstrip instead of
strip. Fixes regex to not match arbitrary characters after the
relevent digits are matched.
(IOSPort.init):
Removes old _architecture defaulting strategy.
(IOSPort._build_driver_flags):
Uses self.architecture() instead of self._architecture.
(IOSSimulatorPort):
Overrides DEFAULT_ARCHITECTURE.
(IOSSimulatorPort.init):
Removes old _architecture defaulting strategy.
- Scripts/webkitpy/port/mac.py:
(MacPort):
Overrides DEFAULT_ARCHITECTURE.
(MacPort.init):
Removes old _architecture defaulting strategy.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.run_command):
Checks the did_override_architecture flag to determine whether to add
the --architecture option.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Uses ews.architecture rather than trying to discern the correct
architecture using a port object.
(EarlyWarningSystemTest._default_expected_logs):
- Scripts/webkitpy/tool/commands/queues.py:
Removes use of optparse, and removes the import statement.
(AbstractQueue.init):
(PatchProcessingQueue.begin_work_queue):
- 2:43 PM Changeset in webkit [178756] by
-
- 32 edits3 deletes in trunk
Unreviewed, rolling out r178751.
https://bugs.webkit.org/show_bug.cgi?id=140694
Caused 32-bit JSC test failures (Requested by JoePeck on
#webkit).
Reverted changeset:
"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
https://bugs.webkit.org/show_bug.cgi?id=140426
http://trac.webkit.org/changeset/178751
- 2:21 PM Changeset in webkit [178755] by
-
- 5 edits in trunk/Source/WebKit2
[iOS][WK2] Redraw find-in-page indicator on rotation
https://bugs.webkit.org/show_bug.cgi?id=140632
<rdar://problem/18858394>
Reviewed by Tim Horton.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::redraw): Add method to redraw find indicator (only used by iOS).
- WebProcess/WebPage/FindController.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameDidLayout):
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator): Redraw should not trigger zoom.
- 2:07 PM Changeset in webkit [178754] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Use FlowContents::Segment::text instead of renderer when possible.
https://bugs.webkit.org/show_bug.cgi?id=140692
Reviewed by Myles C. Maxfield.
No change in functionality.
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
- 1:49 PM Changeset in webkit [178753] by
-
- 11 edits in trunk/Source
Switch to comparing PLATFORM_NAME in terms of macosx
<http://webkit.org/b/139516>
Reviewed by Timothy Hatcher.
Source/WebCore:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- generate-export-file:
(preprocessorMacros):
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- MigrateHeaders.make:
- postprocess-headers.sh:
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- mac/rewrite-availability-macros.sh: Remove the else block that
checked for an unknown PLATFORM_NAME.
- 1:46 PM Changeset in webkit [178752] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix 32bits builds after r178743
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::shouldBlockURL):
- 1:14 PM Changeset in webkit [178751] by
-
- 32 edits3 adds in trunk
put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
https://bugs.webkit.org/show_bug.cgi?id=140426
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutById):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::emitPutTransitionStubAndGetOldStructure):
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):
- runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):
- runtime/JSString.cpp:
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::getStringPropertySlot):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
- runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
- runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
Source/WebCore:
Test: js/dfg-put-by-val-direct-with-edge-numbers.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):
LayoutTests:
- js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
- js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
- js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.
(lookupWithKey):
(lookupWithKey2):
(toStringThrowsError.toString):
- resources/js-test-pre.js:
- 12:58 PM Changeset in webkit [178750] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r173737. rdar://problem/19420100
- 12:57 PM Changeset in webkit [178749] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r173688. rdar://problem/19432669
- 12:56 PM Changeset in webkit [178748] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r173504. rdar://problem/19419972
- 12:54 PM Changeset in webkit [178747] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r173501. rdar://problem/19419972
- 12:54 PM Changeset in webkit [178746] by
-
- 3 edits in trunk/Source/WebCore
Drop width / height shorthands code from StylePropertyShorthand.*
https://bugs.webkit.org/show_bug.cgi?id=140686
Reviewed by Andreas Kling.
Drop width / height shorthands code from StylePropertyShorthand.*.
width / height are not shorthands for min-width/max-width and
min-height/max-height. Also, only matchingCustomShorthandsForLonghand()
treats these as shorthands. For e.g, the reverse method
(indexOfShorthandForLonghand()) does not.
- css/StylePropertyShorthand.cpp:
(WebCore::widthShorthand): Deleted.
(WebCore::heightShorthand): Deleted.
- css/StylePropertyShorthand.h:
(WebCore::matchingCustomShorthandsForLonghand):
- 12:53 PM Changeset in webkit [178745] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source
Merged r173071. rdar://problem/19419981
- 12:52 PM Changeset in webkit [178744] by
-
- 4 edits32 copies in branches/safari-600.1.4.15-branch
Merged r172797. rdar://problem/19450115
- 12:46 PM Changeset in webkit [178743] by
-
- 4 edits in trunk/Source/WebCore
Add a mechanism to ignore previous content extension rules
https://bugs.webkit.org/show_bug.cgi?id=140663
Reviewed by Andreas Kling.
- contentextensions/ContentExtensionRule.h:
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::shouldBlockURL):
- contentextensions/ContentExtensionsManager.cpp:
(WebCore::ContentExtensions::ExtensionsManager::loadAction):
- 12:46 PM Changeset in webkit [178742] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit
Merged r172509. rdar://problem/19432702
- 12:45 PM Changeset in webkit [178741] by
-
- 6 edits2 copies in branches/safari-600.1.4.15-branch
Merged r172504. rdar://problem/19432702
- 12:44 PM Changeset in webkit [178740] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r172326. rdar://problem/19450253
- 12:43 PM Changeset in webkit [178739] by
-
- 3 edits in trunk/Source/WebCore
Resolve the epsilon transitions for each state upfront instead of dynamically
https://bugs.webkit.org/show_bug.cgi?id=140654
Reviewed by Andreas Kling.
Instead of recomputing the epsilon-closure for each set, we compute the closure
of every element at the beginning of the transformation.
We then remove the epsilon transitions from the NFA to simplify populateTransitions().
The epsilon transitions are still there, but they are now in a separate graph we use
in parallel.
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::epsilonClosureExcludingSelf):
(WebCore::ContentExtensions::resolveEpsilonClosures):
(WebCore::ContentExtensions::extendSetWithClosure):
(WebCore::ContentExtensions::populateTransitions):
(WebCore::ContentExtensions::NFAToDFA::convert):
(WebCore::ContentExtensions::epsilonClosure): Deleted.
(WebCore::ContentExtensions::populateTransitionsExcludingEpsilon): Deleted.
- contentextensions/NFAToDFA.h:
- 12:42 PM Changeset in webkit [178738] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r172215. rdar://problem/19419921
- 12:41 PM Changeset in webkit [178737] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r172199. rdar://problem/19419882
- 12:40 PM Changeset in webkit [178736] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r171984. rdar://problem/19419849
- 12:40 PM Changeset in webkit [178735] by
-
- 9 edits3 copies in branches/safari-600.1.4.15-branch
Merged r171941. rdar://problem/19419871
- 12:37 PM Changeset in webkit [178734] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r171775. rdar://problem/19419960
- 12:37 PM Changeset in webkit [178733] by
-
- 5 edits in trunk/Source/WebCore
Log types of resources being loaded using DiagnosticLoggingClient
https://bugs.webkit.org/show_bug.cgi?id=140682
Reviewed by Andreas Kling.
Log types of resources being loaded using DiagnosticLoggingClient
instead of the legacy FeatureCounter.
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::logResourceLoadedUsingFeatureCounter): Deleted.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::otherKey):
(WebCore::DiagnosticLoggingKeys::mainResourceKey):
(WebCore::DiagnosticLoggingKeys::loadedKey):
(WebCore::DiagnosticLoggingKeys::imageKey):
(WebCore::DiagnosticLoggingKeys::rawKey):
(WebCore::DiagnosticLoggingKeys::resourceKey):
(WebCore::DiagnosticLoggingKeys::scriptKey):
(WebCore::DiagnosticLoggingKeys::styleSheetKey):
(WebCore::DiagnosticLoggingKeys::svgDocumentKey):
(WebCore::DiagnosticLoggingKeys::fontKey):
- page/DiagnosticLoggingKeys.h:
- platform/FeatureCounterKeys.h:
- 12:36 PM Changeset in webkit [178732] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r171708. rdar://problem/19419842
- 12:35 PM Changeset in webkit [178731] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r171692. rdar://problem/19419903
- 12:33 PM Changeset in webkit [178730] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source/JavaScriptCore
Merged r171691. rdar://problem/19420038
- 12:29 PM Changeset in webkit [178729] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Remove redundant style.preserveNewline check when collapsing trailing whitespace.
https://bugs.webkit.org/show_bug.cgi?id=140684
Reviewed by Antti Koivisto.
FlowContents::isLineBreak() checks whether we are at a hard newline.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
- 11:35 AM Changeset in webkit [178728] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(178696): Sporadic crashes while garbage collecting
https://bugs.webkit.org/show_bug.cgi?id=140688
Reviewed by Geoffrey Garen.
Added missing visitor.append(&thisObject->m_nullSetterFunction).
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- 11:29 AM Changeset in webkit [178727] by
-
- 7 edits in trunk/Source/bmalloc
bmalloc: a little bit of cleanup
https://bugs.webkit.org/show_bug.cgi?id=140687
Reviewed by Anders Carlsson.
- bmalloc/Algorithm.h:
(bmalloc::isPowerOfTwo): Added a check for 0, since 0 would break a lot
of code.
- bmalloc/BoundaryTag.h:
- bmalloc/BoundaryTagInlines.h:
(bmalloc::BoundaryTag::mergeLeft):
(bmalloc::BoundaryTag::mergeRight):
(bmalloc::BoundaryTag::merge):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::split):
(bmalloc::BoundaryTag::allocate):
(bmalloc::BoundaryTag::mergeLargeLeft): Deleted.
(bmalloc::BoundaryTag::mergeLargeRight): Deleted.
(bmalloc::BoundaryTag::mergeLarge): Deleted.
(bmalloc::BoundaryTag::splitLarge): Deleted. Removed the word "Large"
from all these functions, since boundary tags always pertain to large
objects, and putting the word "Large" everywhere wasn't helping to
explain that.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::findXLarge):
(bmalloc::Heap::deallocateXLarge):
- bmalloc/Heap.h:
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateXLarge): Deleted.
(bmalloc::VMHeap::findXLarge): Deleted.
(bmalloc::VMHeap::deallocateXLarge): Deleted. Moved XLarge allocation
from VMHeap to Heap. Since the purpose of the VMHeap is to cache VM
ranges, and the VMHeap never caches any XLarge ranges, it doesn't
really make sense for the VMHeap to be involved.
- 11:28 AM Changeset in webkit [178726] by
-
- 2 edits in trunk/LayoutTests
[mac] Fix test expectations after r178188
https://bugs.webkit.org/show_bug.cgi?id=140641
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-01-20
Reviewed by Alexey Proskuryakov.
Remove references to removed tests.
- platform/mac/TestExpectations:
removed reference to fast/workers/storage/use-same-database-in-page-and-workers.html
- 11:12 AM Changeset in webkit [178725] by
-
- 3 edits in trunk/Source/WTF
Fix failed to build for Linux/MIPS64EL
https://bugs.webkit.org/show_bug.cgi?id=124370
Patch by YunQiang Su <wzssyqa@gmail.com> on 2015-01-20
Reviewed by Darin Adler.
Add MIPS64EL support.
- wtf/Platform.h:
- wtf/dtoa/utils.h:
- 10:51 AM Changeset in webkit [178724] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source
Versioning.
- 10:40 AM Changeset in webkit [178723] by
-
- 12 edits2 adds in trunk/Source
Add a way to collect scrolling performance data (viewport tile coverage) with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=140474
Reviewed by Tim Horton.
Source/WebCore:
Add accessors for standard names for container CALayer for each of the tile grids,
and when tile grids are swapped, update those names as appropriate.
- WebCore.exp.in:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::tileGridContainerLayerName):
(WebCore::TileController::zoomedOutTileGridContainerLayerName):
(WebCore::TileController::setContentsScale):
- platform/graphics/ca/TileController.h:
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::TileGrid):
(WebCore::TileGrid::setIsZoomedOutTileGrid):
- platform/graphics/ca/TileGrid.h:
Source/WebKit2:
Add a private method to enable scrolling data collection to WKWebView. When enabled, create
a RemoteLayerTreeScrollingPerformanceData object that collects "blank pixel" data on
every layer tree commit and scroll, and stores them in a vector. A second SPI call
allows retrieval of an NSArray of this data.
To allow RemoteLayerTreeScrollingPerformanceData to find the correct layer which
contains the main tile grid, we set a layer name on the appropriate layer (even
in release builds).
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView visibleRectInScreenCoordinates]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView _setScrollPerformanceDataCollectionEnabled:]):
(-[WKWebView _scrollPerformanceDataCollectionEnabled]):
(-[WKWebView _scrollPerformanceData]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.h: Added.
(WebKit::RemoteLayerTreeScrollingPerformanceData::BlankPixelCount::BlankPixelCount):
- UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm: Added.
(WebKit::RemoteLayerTreeScrollingPerformanceData::RemoteLayerTreeScrollingPerformanceData):
(WebKit::RemoteLayerTreeScrollingPerformanceData::~RemoteLayerTreeScrollingPerformanceData):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didCommitLayerTree):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didScroll):
(WebKit::RemoteLayerTreeScrollingPerformanceData::BlankPixelCount::canCoalesce):
(WebKit::RemoteLayerTreeScrollingPerformanceData::appendBlankPixelCount):
(WebKit::RemoteLayerTreeScrollingPerformanceData::data):
(WebKit::findTileGridContainerLayer):
(WebKit::RemoteLayerTreeScrollingPerformanceData::blankPixelCount):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setScrollPerformanceDataCollectionEnabled):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::scrollPerformanceDataCollectionEnabled):
(WebKit::WebPageProxy::scrollingPerformanceData):
- WebKit2.xcodeproj/project.pbxproj:
- 10:27 AM Changeset in webkit [178722] by
-
- 4 edits in trunk/Source/WTF
Make ASan do bounds checks for WTF::Vector
https://bugs.webkit.org/show_bug.cgi?id=140631
rdar://problem/19437718
Reviewed by Darin Adler.
- wtf/SizeLimits.cpp: Disable Vector object size checks for ASan enabled builds.
- wtf/Vector.h:
(WTF::VectorBuffer::endOfBuffer):
(WTF::Vector::Vector):
(WTF::Vector::~Vector):
(WTF::Vector::swap):
(WTF::OverflowHandler>::Vector):
(WTF::=):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::asanSetInitialBufferSizeTo):
(WTF::OverflowHandler>::asanSetBufferSizeToFullCapacity):
(WTF::OverflowHandler>::asanBufferSizeWillChangeTo):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::appendSlowCase):
(WTF::OverflowHandler>::uncheckedAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::releaseBuffer):
- wtf/Compiler.h: Changed ASAN_ENABLED macro fallback value from false to 0,
MSVC was not happy with false.
- 10:26 AM Changeset in webkit [178721] by
-
- 31 edits1 delete in trunk/LayoutTests
fast/hidpi/image-srcset-change-dynamically-from-js-2x.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140649
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing on some bots
https://bugs.webkit.org/show_bug.cgi?id=134769
Reviewed by Darin Adler.
Streamline resources/srcset-helper.js and remove races.
- TestExpectations: Unskip fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html.
- fast/hidpi/resources/srcset-helper.js: Deleted. We aleady had a copy in /resources,
no need for two copies.
- resources/srcset-helper.js: This script used to depend on setBackingScaleFactor
invoke its callback really fast, which is not guaranteed. Also, it had broken logic
that used non-existent window.deviceScaleFactor.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x.html:
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-expected.txt:
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html:
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml-expected.txt:
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html:
Updated to run the tests from runTest() function, not a load event handler.
Where appropriate, changed from testRunner.dumpResourceLoadCallbacks() to
testRunner.dumpResourceResponseMIMETypes(), because the latter doesn't unnecessarily
include reloaded scripts. It feels somewhat hacky, but the hack is already used in
fast/hidpi, and it improves output.
- fast/hidpi/image-srcset-change-dynamically-from-js-1x.html:
- fast/hidpi/image-srcset-change-dynamically-from-js-2x.html:
- fast/hidpi/image-srcset-fraction-1.5x.html:
- fast/hidpi/image-srcset-fraction.html:
- fast/hidpi/image-srcset-intrinsic-size.html:
- fast/hidpi/image-srcset-invalid-descriptor.html:
- fast/hidpi/image-srcset-invalid-inputs-except-one.html:
- fast/hidpi/image-srcset-nomodifier.html:
- fast/hidpi/image-srcset-only-src-attribute.html:
- fast/hidpi/image-srcset-remove-dynamically-from-js.html:
- fast/hidpi/image-srcset-same-alternative-for-both-attributes.html:
- fast/hidpi/image-srcset-simple-1x.html:
- fast/hidpi/image-srcset-simple-2x.html:
- fast/hidpi/image-srcset-space-left-nomodifier.html:
- fast/hidpi/image-srcset-space-prefix-nomodifier.html:
- fast/hidpi/image-srcset-space-suffix-nomodifier.html:
- fast/hidpi/image-srcset-space-surrounded-nomodifier.html:
- fast/hidpi/image-srcset-src-selection-1x-both.html:
- fast/hidpi/image-srcset-src-selection-1x.html:
- fast/hidpi/image-srcset-src-selection-2x.html:
- fast/hidpi/image-srcset-viewport-modifiers.html:
Updated to run the tests from runTest() function, not a load event handler.
- http/tests/loading/sizes/preload-image-sizes-2x-expected.txt: Updated results
for srcset-helper.js now always starting the redirect after the load is fully finished.
- svg/css/svg-resource-fragment-identifier-img-src.html: Updated for the unified
location of the script.
- 9:51 AM Changeset in webkit [178720] by
-
- 2 edits in trunk/Tools
Attempt to fix Mountain Lion and EFL tests.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Disable Process-per-tab and network process on Mountain Lion and EFL.
- 9:34 AM Changeset in webkit [178719] by
-
- 11 edits in trunk/Source
Remove non-Windows cruft from WebKit/win/Plugins
https://bugs.webkit.org/show_bug.cgi?id=140675
Reviewed by Anders Carlsson.
Source/WebKit/win:
- Plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
- Plugins/PluginDebug.cpp:
(WebCore::prettyNameForNPNVariable):
(WebCore::prettyNameForNPPVariable):
(WebCore::prettyNameForDrawingModel): Deleted.
(WebCore::prettyNameForEventModel): Deleted.
- Plugins/PluginDebug.h:
- Plugins/PluginPackage.cpp:
(WebCore::PluginPackage::compareFileVersion):
(WebCore::PluginPackage::determineQuirks): Deleted.
(WebCore::PluginPackage::determineModuleVersionFromDescription): Deleted.
(WebCore::PluginPackage::hash): Deleted.
(WebCore::PluginPackage::equal): Deleted.
- Plugins/PluginView.cpp:
(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::stop):
(WebCore::PluginView::setValue):
(WebCore::PluginView::PluginView):
- Plugins/PluginView.h:
(WebCore::PluginView::platformPluginWidget): Deleted.
(WebCore::PluginView::setPlatformPluginWidget): Deleted.
- Plugins/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):
(WebCore::registerPluginView):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):
- Plugins/npapi.cpp:
(NPN_InvalidateRect):
Source/WTF:
- wtf/FeatureDefines.h:
- 9:25 AM Changeset in webkit [178718] by
-
- 3 edits in trunk/Source/WebCore
Fix unused-private-field warning in IconEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=140676
Reviewed by Darin Adler.
- platform/graphics/Icon.h:
- platform/graphics/efl/IconEfl.cpp:
(WebCore::Icon::Icon): Deleted.
- 9:23 AM Changeset in webkit [178717] by
-
- 3 edits in trunk/Source/WebCore
Fix unused-private-field warning in FontCustomPlatformDataFreeType.cpp
https://bugs.webkit.org/show_bug.cgi?id=140677
Reviewed by Martin Robinson.
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
- 9:21 AM Changeset in webkit [178716] by
-
- 2 edits in trunk/Source/WebCore
Plugin content not loaded.
https://bugs.webkit.org/show_bug.cgi?id=140672
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-20
Reviewed by Brent Fulgham.
It seems this is caused by a std::unique_ptr in CClass::methodNamed being moved,
resetting its raw pointer. The raw pointer, which now is null, is then returned
from the method.
- bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodNamed):
(JSC::Bindings::CClass::fieldNamed):
- 9:11 AM Changeset in webkit [178715] by
-
- 32 edits3 deletes in trunk
Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
https://bugs.webkit.org/show_bug.cgi?id=140679
Reviewed by Anders Carlsson.
Source/WebCore:
First step in removing the SVG instance tree.
All based on redoing the same excellent work Rob Buis did to remove this in Blink in crbug.com/313438.
- CMakeLists.txt: Removed the source files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/EventHandler.cpp:
(WebCore::EventHandler::clear): Removed code to set unused m_instanceUnderMouse.
(WebCore::EventHandler::updateMouseEventTargetNode): Ditto.
- page/EventHandler.h: Removed m_instanceUnderMouse.
- svg/SVGAllInOne.cpp: Removed the source files.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::childNodes): Deleted.
- svg/SVGElementInstance.h: Removed childNodes.
- svg/SVGElementInstance.idl: Ditto.
- svg/SVGElementInstanceList.cpp: Removed.
- svg/SVGElementInstanceList.h: Removed.
- svg/SVGElementInstanceList.idl: Removed.
- svg/SVGUseElement.cpp:
(WebCore::dumpInstanceTree): Deleted.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Removed DUMP_INSTANCE_TREE and
DUMP_SHADOW_TREE code.
Tools:
- Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
Removed a reference to SVGElementInstanceList.
LayoutTests:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/ios-sim-deprecated/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/ios-sim-deprecated/fast/js/global-constructors-expected.txt:
- platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- svg/custom/global-constructors-expected.txt:
- svg/custom/script-tests/global-constructors.js:
- svg/dom/svg2-inheritance-expected.txt:
- svg/dom/svg2-inheritance.html:
Removed all tests and results referencing SVGElementInstanceList.
- 8:52 AM Changeset in webkit [178714] by
-
- 43 edits4 deletes in trunk/Source
Web Replay: code generator should take supplemental specifications and allow cross-framework references
https://bugs.webkit.org/show_bug.cgi?id=136312
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Some types are shared between replay inputs from different frameworks.
Previously, these type declarations were duplicated in every input
specification file in which they were used. This caused some type encoding
traits to be emitted twice if used from WebCore inputs and WebKit2 inputs.
This patch teaches the replay inputs code generator to accept multiple
input specification files. Inputs can freely reference types from other
frameworks without duplicating declarations.
On the code generation side, the model could contain types and inputs from
frameworks that are not the target framework. Only generate code for the
target framework.
To properly generate cross-framework type encoding traits, use
Type.encoding_type_argument in more places, and add the export macro for WebCore
and the Test framework.
Adjust some tests so that enum coverage is preserved by moving the enum types
into "Test" (the target framework for tests).
- JavaScriptCore.vcxproj/copy-files.cmd:
For Windows, copy over JSInputs.json as if it were a private header.
- JavaScriptCore.xcodeproj/project.pbxproj: Make JSInputs.json a private header.
- replay/JSInputs.json:
Put all primitive types and WTF types in this specification file.
- replay/scripts/CodeGeneratorReplayInputs.py:
(Input.init):
(InputsModel.init): Keep track of the input's framework.
(InputsModel.parse_specification): Parse the framework here. Adjust to new format,
and allow either types or inputs to be missing from a single file.
(InputsModel.parse_type_with_framework):
(InputsModel.parse_input_with_framework):
(Generator.should_generate_item): Added helper method.
(Generator.generate_header): Filter inputs to generate.
(Generator.generate_implementation): Filter inputs to generate.
(Generator.generate_enum_trait_declaration): Filter enums to generate.
Add WEBCORE_EXPORT macro to enum encoding traits.
(Generator.generate_for_each_macro): Filter inputs to generate.
(Generator.generate_enum_trait_implementation): Filter enums to generate.
(generate_from_specifications): Added.
(generate_from_specifications.parse_json_from_file):
(InputsModel.parse_toplevel): Deleted.
(InputsModel.parse_type_with_framework_name): Deleted.
(InputsModel.parse_input): Deleted.
(generate_from_specification): Deleted.
- replay/scripts/CodeGeneratorReplayInputsTemplates.py:
- replay/scripts/tests/expected/fail-on-no-inputs.json-error: Removed.
- replay/scripts/tests/expected/fail-on-no-types.json-error: Removed.
- replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.cpp:
- replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.cpp:
- replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp:
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:
- replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.h:
- replay/scripts/tests/fail-on-c-style-enum-no-storage.json:
- replay/scripts/tests/fail-on-duplicate-enum-type.json:
- replay/scripts/tests/fail-on-duplicate-input-names.json:
- replay/scripts/tests/fail-on-duplicate-type-names.json:
- replay/scripts/tests/fail-on-enum-type-missing-values.json:
- replay/scripts/tests/fail-on-missing-input-member-name.json:
- replay/scripts/tests/fail-on-missing-input-name.json:
- replay/scripts/tests/fail-on-missing-input-queue.json:
- replay/scripts/tests/fail-on-missing-type-mode.json:
- replay/scripts/tests/fail-on-missing-type-name.json:
- replay/scripts/tests/fail-on-no-inputs.json:
Removed, no longer required to be in a single file.
- replay/scripts/tests/fail-on-no-types.json:
Removed, no longer required to be in a single file.
- replay/scripts/tests/fail-on-unknown-input-queue.json:
- replay/scripts/tests/fail-on-unknown-member-type.json:
- replay/scripts/tests/fail-on-unknown-type-mode.json:
- replay/scripts/tests/generate-enum-encoding-helpers-with-guarded-values.json:
- replay/scripts/tests/generate-enum-encoding-helpers.json:
- replay/scripts/tests/generate-enum-with-guard.json:
Include enums that are and are not generated.
- replay/scripts/tests/generate-enums-with-same-base-name.json:
- replay/scripts/tests/generate-event-loop-shape-types.json:
- replay/scripts/tests/generate-input-with-guard.json:
- replay/scripts/tests/generate-input-with-vector-members.json:
- replay/scripts/tests/generate-inputs-with-flags.json:
- replay/scripts/tests/generate-memoized-type-modes.json:
Source/WebCore:
Changes covered by existing input generator tests.
- DerivedSources.make: Add JSInputs.json as supplemental specification.
- replay/WebInputs.json: Moved common types to JSInputs.json.
- 8:49 AM Changeset in webkit [178713] by
-
- 2 edits in trunk/Tools
[GTK] WebViewTest should prohibit overriding initializeWebExtensions()
https://bugs.webkit.org/show_bug.cgi?id=140028
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-20
Reviewed by Carlos Garcia Campos.
This won't work as expected, since this function is called before the
WebViewTest constructor completes.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
- 8:48 AM Changeset in webkit [178712] by
-
- 2 edits in trunk/Source/WebCore
Fix unused-const-variable warning in RenderLayerCompositor.cpp
https://bugs.webkit.org/show_bug.cgi?id=140678
Reviewed by Simon Fraser.
- rendering/RenderLayerCompositor.cpp:
- 8:24 AM Changeset in webkit [178711] by
-
- 2 edits in trunk/Source/WebCore
[gstreamer] Fix expression result unused warning in GRefPtrGStreamer.cpp
https://bugs.webkit.org/show_bug.cgi?id=140671
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::refGPtr<GstToc>):
- 8:10 AM WebKitGTK/Roadmap edited by
- (diff)
- 8:03 AM Changeset in webkit [178710] by
-
- 18 edits2 adds in trunk
Support "plus-darker" in mix-blend mode
https://bugs.webkit.org/show_bug.cgi?id=140646
<rdar://problem/19523370>
Reviewed by Simon Fraser.
Source/WebCore:
Support the "plus-darker" blending mode to CSS.
See: https://lists.w3.org/Archives/Public/public-fx/2015JanMar/0021.html
Test: css3/blending/svg-blend-plus-darker.html
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): mix-blend-mode can now accept
the new keyword.
- css/CSSPrimitiveValueMappings.h: Add the mappings.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator BlendMode):
- platform/graphics/GraphicsTypes.cpp: Add the new GraphicsType.
- platform/graphics/GraphicsTypes.h:
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Map to the CA compositing filter.
(PlatformCAFilters::setBlendingFiltersOnLayer):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation): Map to the CG blending flag.
Source/WebKit2:
Output the appropriate blending type when logging.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
LayoutTests:
Add tests and new expected results for plus-darker.
- css3/blending/blend-mode-property-parsing-expected.txt:
- css3/blending/blend-mode-simple-composited.html:
- css3/blending/blend-mode-simple.html:
- css3/blending/script-tests/blend-mode-property-parsing.js:
- css3/blending/svg-blend-plus-darker.html: Added.
- platform/mac/css3/blending/blend-mode-simple-composited-expected.png:
- platform/mac/css3/blending/blend-mode-simple-composited-expected.txt:
- platform/mac/css3/blending/blend-mode-simple-expected.png:
- platform/mac/css3/blending/blend-mode-simple-expected.txt:
- platform/mac/css3/blending/svg-blend-plus-darker-expected.txt: Added.
- 7:51 AM Changeset in webkit [178709] by
-
- 2 edits in trunk/Tools
configure-xcode-for-ios-development needs to update iPhoneOS SDK
<http://webkit.org/b/140661>
Reviewed by Daniel Bates.
- Scripts/configure-xcode-for-ios-development: Add for() loop to
run createXcodeSpecificationFilesForSDKIfNeeded() for both
"iphoneos" and "iphonesimulator" SDKs.
(createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
the main body of the script.
- 6:01 AM Changeset in webkit [178708] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] Cannot compile 2.7.3 on PowerPC machines
https://bugs.webkit.org/show_bug.cgi?id=140616
Include climits for INT_MAX and wtf/DataLog.h for dataLogF
Patch by Tomas Popela <tpopela@redhat.com> on 2015-01-20
Reviewed by Csaba Osztrogonác.
- runtime/BasicBlockLocation.cpp:
- 5:47 AM Changeset in webkit [178707] by
-
- 1 copy in releases/WebKitGTK/webkit-2.7.4
WebKitGTK+ 2.7.4
- 5:43 AM Changeset in webkit [178706] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.7.4.
- 5:00 AM Changeset in webkit [178705] by
-
- 3 edits2 adds in trunk/LayoutTests
[EFL] [GTK] Change/supplement expectations for two accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=140620
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-20
- platform/efl/TestExpectations:
- platform/efl/accessibility/media-element-expected.txt: Currently, accessibility/media-element.html is positive for EFL with a new, richer description.
- platform/efl/accessibility/render-counter-text-expected.txt: Added. Omitted file by r178508.
- platform/gtk/accessibility/render-counter-text-expected.txt: Added. Omitted file by r178508.
- 4:53 AM WebKitGTK/Roadmap edited by
- (diff)
- 4:33 AM Changeset in webkit [178704] by
-
- 2 edits in trunk/Source/WebCore
Fix 'register' storage class specifier is deprecated warning
https://bugs.webkit.org/show_bug.cgi?id=140669
Reviewed by Carlos Garcia Campos.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 3:46 AM WebKitGTK/Roadmap edited by
- (diff)
- 3:46 AM WebKitGTK/Roadmap edited by
- (diff)
- 3:46 AM WebKitGTK/Roadmap edited by
- (diff)
- 3:42 AM WebKitGTK/Roadmap created by
- 3:22 AM Changeset in webkit [178703] by
-
- 8 edits in trunk
[GTK] Add API to set the web view editable into WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=139443
Patch by Tomas Popela <tpopela@redhat.com> on 2015-01-20
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Provide a way to set the web view editable, without accessing the DOM
and setting the contenteditable attribute to elements.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_is_editable):
(webkit_web_view_set_editable):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
Tools:
Create the new test cases for setting the editable property on the web
view and on the contenteditable enabled document. Also rework the
current tests that are expecting that the web view is editable.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
(loadTestHtml):
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(testWebViewEditorSelectAllNonEditable):
(testWebViewEditorSelectAllEditable):
(runEditorEditableCutTests):
(testWebViewEditorEditableOnNonEditable):
(testWebViewEditorEditableOnContentEditable):
(testWebViewEditorNonEditable):
(beforeAll):
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::isEditable):
(WebViewTest::setEditable):
- 2:07 AM Changeset in webkit [178702] by
-
- 5 edits in trunk/Source/WebCore
Use DiagnosticLoggingClient to log page cache failures
https://bugs.webkit.org/show_bug.cgi?id=140650
Reviewed by Andreas Kling.
Use DiagnosticLoggingClient to log page cache failures instead of the
legacy FeatureCounter.
- history/PageCache.cpp:
(WebCore::logPageCacheFailureDiagnosticMessage):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
(WebCore::pruningReasonToDiagnosticLoggingKey):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::pruningReasonToFeatureCounterKey): Deleted.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::successKey):
(WebCore::DiagnosticLoggingKeys::failureKey):
(WebCore::DiagnosticLoggingKeys::pageLoadedKey):
(WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
(WebCore::DiagnosticLoggingKeys::navigationKey):
(WebCore::DiagnosticLoggingKeys::pageCacheKey):
(WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
(WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
(WebCore::DiagnosticLoggingKeys::isErrorPageKey):
(WebCore::DiagnosticLoggingKeys::hasPluginsKey):
(WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
(WebCore::DiagnosticLoggingKeys::hasOpenDatabasesKey):
(WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
(WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
(WebCore::DiagnosticLoggingKeys::loadingAPISenseKey):
(WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
(WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
(WebCore::DiagnosticLoggingKeys::applicationCacheKey):
(WebCore::DiagnosticLoggingKeys::deniedByClientKey):
(WebCore::DiagnosticLoggingKeys::deviceMotionKey):
(WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
(WebCore::DiagnosticLoggingKeys::deviceProximityKey):
(WebCore::DiagnosticLoggingKeys::reloadKey):
(WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
(WebCore::DiagnosticLoggingKeys::sameLoadKey):
(WebCore::DiagnosticLoggingKeys::expiredKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToCapacityReached):
(WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
(WebCore::DiagnosticLoggingKeys::passKey): Deleted.
(WebCore::DiagnosticLoggingKeys::failKey): Deleted.
(WebCore::DiagnosticLoggingKeys::noopKey): Deleted.
- page/DiagnosticLoggingKeys.h:
- platform/FeatureCounterKeys.h:
- 1:19 AM Changeset in webkit [178701] by
-
- 5 edits in trunk
[CSS Grid Layout] Wrong arguments passed to computeNormalizedFractionBreadth
https://bugs.webkit.org/show_bug.cgi?id=139058
Reviewed by Andreas Kling.
Source/WebCore:
The method RenderGrid::computeNormalizedFractionBreadth() is
supposed to get as fourth argument either the grid element's
content box size or the max-size of a particular grid item. For
the former we were incorrectly passing the free space after
distributing the available space to tracks.
Apart from that, that method has a bug in its implementation. As
we were using the free space instead of the grid element's content
box size, we didn't have to subtract the usedBreadth of grid
tracks from the passed in value. That did not work for the case of
the caller passing the max-size of a particular item.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
LayoutTests:
- TestExpectations: Removed the test added in r148643 (missing
from r148642) as the test works as expected now.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
- 12:29 AM Changeset in webkit [178700] by
-
- 6 edits in trunk
[GTK] Add an option to create WebKitWebView snapshots with transparent background
https://bugs.webkit.org/show_bug.cgi?id=140617
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add WEBKIT_SNAPSHOT_OPTIONS_TRANSPARENT_BACKGROUND flag to not
fill with white the background before rendering the snapshot.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_snapshot): Pass a TransparentBackground
boolean argument to the WEbProcess.
- UIProcess/API/gtk/WebKitWebView.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageDidReceiveMessage): Set the FrameView background as
transparent when TransparentBackground option is True before
rendering the snapshot.
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewSnapshot): Check that the same snapshot with
transparent background is different than the default one filled
with white.
- 12:25 AM Changeset in webkit [178699] by
-
- 12 edits in trunk
[GTK] Add API to change the WebKitWebView background color
https://bugs.webkit.org/show_bug.cgi?id=140610
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When a color different than the default one (opaque white) is
used, the SetDrawsBackground message is sent to the WebProcess with
a False value to indicate WebCore to not render backgrounds. The
background color passed is saved in the WebPageProxy and used by
the backing store to fill the background before the actual
contents are rendered in the WebView.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_background_color):
(webkit_web_view_get_background_color):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_backgroundColor member.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::backgroundColor): Return m_backgroundColor.
(WebKit::WebPageProxy::setBackgroundColor): Set m_backgroundColor.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate): Fill the damage region
with the WebPageProxy background color when the WebProcess is not
rendering backgrounds. If the background color is not fully opaque
we need to clear the region before filling it with the color.
Tools:
Add --bg-color command line option to MiniBrowser to be able to
manually test the API passing any RGBA color to MiniBrowser.
Also add a simple unit test to check that getting and setting
colors from the API point of view.
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_set_background_color):
- MiniBrowser/gtk/BrowserWindow.h:
- MiniBrowser/gtk/main.c:
(createBrowserWindow):
(parseBackgroundColor):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewBackgroundColor):
(beforeAll):
Jan 19, 2015:
- 9:58 PM Changeset in webkit [178698] by
-
- 2 edits in trunk/LayoutTests
Re-enable js/dom/string-replace-exception-crash.html as root problem is fixed.
https://bugs.webkit.org/show_bug.cgi?id=140666
Rubber Stamped by Filip Pizlo.
- platform/mac/TestExpectations:
Re-enabled js/dom/string-replace-exception-crash.html.
- 9:55 PM Changeset in webkit [178697] by
-
- 2 edits in trunk/Tools
[Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
https://bugs.webkit.org/show_bug.cgi?id=140665
Reviewed by Brian Burg.
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
match expected test output.
- 9:28 PM Changeset in webkit [178696] by
-
- 9 edits5 adds in trunk
A "cached" null setter should throw a TypeException when called in strict mode and doesn't
https://bugs.webkit.org/show_bug.cgi?id=139418
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Made a new NullSetterFunction class similar to NullGetterFunction. The difference is that
NullSetterFunction will throw a TypeError per the ECMA262 spec for a strict mode caller.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
Added new files NullSetterFunction.cpp and NullSetterFunction.h.
- runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::isSetterNull):
(JSC::GetterSetter::setSetter):
Change setter instances from using NullGetterFunction to using NullSetterFunction.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::nullSetterFunction):
Added m_nullSetterFunction and accessor.
- runtime/NullSetterFunction.cpp: Added.
(JSC::GetCallerStrictnessFunctor::GetCallerStrictnessFunctor):
(JSC::GetCallerStrictnessFunctor::operator()):
(JSC::GetCallerStrictnessFunctor::callerIsStrict):
(JSC::callerIsStrict):
Method to determine if the caller is in strict mode.
(JSC::callReturnUndefined):
(JSC::constructReturnUndefined):
(JSC::NullSetterFunction::getCallData):
(JSC::NullSetterFunction::getConstructData):
- runtime/NullSetterFunction.h: Added.
(JSC::NullSetterFunction::create):
(JSC::NullSetterFunction::createStructure):
(JSC::NullSetterFunction::NullSetterFunction):
Class with handlers for a null setter.
LayoutTests:
New regression test.
- js/regress-139418-expected.txt: Added.
- js/regress-139418.html: Added.
- js/script-tests/regress-139418.js: Added.
(InnerObjectNoSetter):
(InnerObjectNoSetter.prototype.get enabled):
(StrictOuterObject):
(StrictOuterObject.prototype.get enabled):
(StrictOuterObject.prototype.set enabled):
- 9:17 PM Changeset in webkit [178695] by
-
- 10 edits1 add1 delete in trunk/Source
Web Inspector: Provide a front end for JSC's Control Flow Profiler
https://bugs.webkit.org/show_bug.cgi?id=138454
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
This patch puts the final touches on what JSC needs to provide
for the Web Inspector to show a UI for the control flow profiler.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::recompileAllJSFunctionsForTypeProfiling):
- runtime/ControlFlowProfiler.cpp:
(JSC::ControlFlowProfiler::getBasicBlocksForSourceID):
- runtime/FunctionHasExecutedCache.cpp:
(JSC::FunctionHasExecutedCache::getFunctionRanges):
(JSC::FunctionHasExecutedCache::getUnexecutedFunctionRanges): Deleted.
- runtime/FunctionHasExecutedCache.h:
Source/WebInspectorUI:
This patch creates a user interface for JSC's control flow profiler.
The Web Inspector gets basic block ranges from JSC, and displays
basic blocks that have not executed as having a gray background.
BasicBlockAnnotator is the class responsible for this UI logic.
It also does a few nifty things when presenting a UI for this gray
background color: if an entire line of code is within the basic
block's boundary, the annotator will not just highlight the background
behind the text, but the background of the entire line itself. This
provides a nicer experience when glancing through large JavaScript files.
This patch also adds some necessary wrapper methods inside TextEditor
for accessing CodeMirror's text highlighting functionality. It also
creates a way for TextEditor and SourceCodeTextEditor to listen
for focus events inside CodeMirror.
- UserInterface/Controllers/AnnotatorManager.js: Removed.
- UserInterface/Controllers/BasicBlockAnnotator.js: Added.
(WebInspector.BasicBlockAnnotator):
(WebInspector.BasicBlockAnnotator.prototype.clearAnnotations):
(WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
(WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges.):
(WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
(WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
(WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyWhitespace):
(WebInspector.BasicBlockAnnotator.prototype._canGrayOutEntireLine):
(WebInspector.BasicBlockAnnotator.prototype._grayOutLine):
(WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker.get marker):
(WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker):
- UserInterface/Main.html:
- UserInterface/Views/SourceCodeTextEditor.css:
(.basic-block-has-not-executed):
(.basic-block-has-not-executed-prepend::before):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.hidden):
(WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.gainedFocus):
(WebInspector.SourceCodeTextEditor.prototype.lostFocus):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
(WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
(WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
(WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
(WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.getTextInRange):
(WebInspector.TextEditor.prototype.addStyleToTextRange):
(WebInspector.TextEditor.prototype.gainedFocus):
(WebInspector.TextEditor.prototype.lostFocus):
- 9:09 PM Changeset in webkit [178694] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Only use LLVM static library arguments on 64-bit builds of libllvmForJSC.dylib
<http://webkit.org/b/140658>
Reviewed by Filip Pizlo.
- Configurations/LLVMForJSC.xcconfig: Set OTHER_LDFLAGS_LLVM
only when building for 64-bit architectures.
- 9:01 PM Changeset in webkit [178693] by
-
- 5 edits in trunk/Source/JavaScriptCore
ClosureCallStubRoutine no longer needs codeOrigin
https://bugs.webkit.org/show_bug.cgi?id=140659
Reviewed by Michael Saboff.
Once upon a time, we would look for the CodeOrigin associated with a return PC. This search
would start with the CodeBlock according to the caller frame's call frame header. But if the
call was a closure call, the return PC would be inside some closure call stub. So if the
CodeBlock search failed, we would search *all* closure call stub routines to see which one
encompasses the return PC. Then, we would use the CodeOrigin stored in the stub routine
object. This was all a bunch of madness, and we actually got rid of it - we now determine
the CodeOrigin for a call frame using the encoded code origin bits inside the tag of the
argument count.
This patch removes the final vestiges of the madness:
- Remove the totally unused method declaration for the thing that did the closure call stub search.
- Remove the CodeOrigin field from the ClosureCallStubRoutine. Except for that crazy search that we no longer do, everyone else who finds a ClosureCallStubRoutine will find it via the CallLinkInfo. The CallLinkInfo also has the CodeOrigin, so we don't need this field anymore.
- bytecode/CodeBlock.h:
- jit/ClosureCallStubRoutine.cpp:
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
- jit/ClosureCallStubRoutine.h:
(JSC::ClosureCallStubRoutine::executable):
(JSC::ClosureCallStubRoutine::codeOrigin): Deleted.
- jit/Repatch.cpp:
(JSC::linkClosureCall):
- 8:47 PM Changeset in webkit [178692] by
-
- 7 edits in trunk/Source/JavaScriptCore
Basic block start offsets should never be larger than end offsets in the control flow profiler
https://bugs.webkit.org/show_bug.cgi?id=140377
Reviewed by Filip Pizlo.
The bytecode generator will emit code more than once for some AST nodes. For instance,
the finally block of TryNode will emit two code paths for its finally block: one for
the normal path, and another for the path where an exception is thrown in the catch block.
This repeated code emission of the same AST node previously broke how the control
flow profiler computed text ranges of basic blocks because when the same AST node
is emitted multiple times, there is a good chance that there are ranges that span
from the end offset of one of these duplicated nodes back to the start offset of
the same duplicated node. This caused a basic block range to report a larger start
offset than end offset. This was incorrect. Now, when this situation is encountered
while linking a CodeBlock, the faulty range in question is ignored.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
- bytecode/CodeBlock.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitMultiLoopBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::TryNode::emitBytecode):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseConditionalExpression):
- runtime/ControlFlowProfiler.cpp:
(JSC::ControlFlowProfiler::ControlFlowProfiler):
- runtime/ControlFlowProfiler.h:
(JSC::ControlFlowProfiler::dummyBasicBlock):
- 8:04 PM Changeset in webkit [178691] by
-
- 82 edits1 add6 deletes in trunk
[SVG -> OTF Converter] Flip the switch on
https://bugs.webkit.org/show_bug.cgi?id=140592
Source/JavaScriptCore:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Updating test expected results.
svg/W3C-SVG-1.1/fonts-glyph-04-t.svg tests something which isn't spec'ed
and is impossible to perform with the converter, so I have deleted that
test.
svg/custom/skip-underline-missing-glyph-expected.html was testing
incorrect behavior, so I have updated the test.
The getStartPositionOfChar() calls in svg/text/kerning.svg and
svg/text/multichar-glyph.svg are currently impossible to be implemented
correctly with the converter, so I have updated the expected results to
test for the updated results of those calls.
Reviewed by Antti Koivisto.
- platform/mac/TestExpectations:
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Removed.
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/mac/svg/custom/glyph-setting-d-attribute-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/custom/svg-fonts-fallback-expected.txt:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/text/kerning-expected.txt:
- platform/mac/svg/text/multichar-glyph-expected.txt:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/mac-mountainlion/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/mac-mountainlion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac-mountainlion/svg/custom/svg-fonts-fallback-expected.txt:
- platform/mac-mountainlion/svg/text/kerning-expected.txt:
- platform/mac-mountainlion/svg/text/multichar-glyph-expected.txt:
- platform/mac-mountainlion/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
- svg/W3C-SVG-1.1/fonts-glyph-04-t-w3c.png: Removed.
- svg/W3C-SVG-1.1/fonts-glyph-04-t.svg: Removed.
- svg/custom/skip-underline-missing-glyph-expected.html: Removed.
- svg/custom/skip-underline-missing-glyph-expected.txt: Added.
- svg/custom/skip-underline-missing-glyph.html:
- 7:48 PM WebKitGTK/StableRelease edited by
- (diff)
- 7:46 PM Changeset in webkit [178690] by
-
- 6 edits in trunk/Source/WebKit2
<https://webkit.org/b/140504> REGRESSION (r178452): Visited link coloring only appears to work in the first web process
Roll out r178452 since it broke visited link coloring.
Reviewed by Anders Carlsson.
- UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::~VisitedLinkProvider):
(WebKit::VisitedLinkProvider::addProcess):
(WebKit::VisitedLinkProvider::removeProcess):
(WebKit::VisitedLinkProvider::removeAll):
(WebKit::VisitedLinkProvider::webProcessWillOpenConnection):
(WebKit::VisitedLinkProvider::webProcessDidCloseConnection):
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkProvider::resizeTable):
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::processDidFinishLaunching):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::addVisitedLinkProvider):
(WebKit::WebProcessProxy::didDestroyVisitedLinkProvider):
- UIProcess/WebProcessProxy.h:
- 7:43 PM Changeset in webkit [178689] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r178683.
https://bugs.webkit.org/show_bug.cgi?id=140657
Lots of asserts in tests. (Requested by JoePeck on #webkit).
Reverted changeset:
"LayoutState and subtree layout code should use
RenderElement."
https://bugs.webkit.org/show_bug.cgi?id=126878
http://trac.webkit.org/changeset/178683
- 7:38 PM Changeset in webkit [178688] by
-
- 13 edits in trunk/Source/WebKit2
Sprinkle some CTTE on API::PolicyClient and API::FormClient
https://bugs.webkit.org/show_bug.cgi?id=140656
Reviewed by Tim Horton.
- Use references rather than pointers where possible.
- Store and pass the listeners as Refs.
- Make API::FormClient more like API::PolicyClient by making it the responsibility of the client implementation to call the default policy.
- UIProcess/API/APIFormClient.h:
(API::FormClient::willSubmitForm):
- UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPagePolicyClient):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setFormDelegate:]):
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForNewWindowAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::willSubmitForm):
- 6:10 PM Changeset in webkit [178687] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
Avoid compiling files twice when they are included in an 'AllInOne.cpp' file.
- WebCore.vcxproj/WebCore.vcxproj: Mark several files as 'not to be built', since
they are also build as part of an 'AllInOne.cpp' file.
- 6:06 PM Changeset in webkit [178686] by
-
- 5 edits in trunk/Tools
Remove the support for custom suffixes on ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=140648
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-19
Reviewed by David Kilzer.
Custom suffixes were used for the iOS branch of WebKit.
Now that everything is opensource, there is no need for it.
- Scripts/VCSUtils.pm:
(changeLogSuffix): Deleted.
(changeLogFileName): Deleted.
- Scripts/commit-log-editor:
- Scripts/prepare-ChangeLog:
(getLatestChangeLogs):
(generateNewChangeLogs):
(generateFileList):
- Scripts/resolve-ChangeLogs:
(findChangeLog):
- 5:35 PM Changeset in webkit [178685] by
-
- 21 edits1 add in trunk/Source/WebKit2
Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration
https://bugs.webkit.org/show_bug.cgi?id=140601
Reviewed by Anders Carlsson.
- Converts _WKProcessPoolConfiguration to be backed via API::ProcessPoolConfiguration.
- Expands API::ProcessPoolConfiguration to add all the parameters necessary to fully initialize a WebProcessPool. This allows -[WKProcessPool _initWithConfiguration:] to be a simple pass through initializer, which in turn allows us to consider WebProcessPools created on the C++ and Objective-C sides as equivalent.
- Makes WebProcessPool own the reference to the API::ProcessPoolConfiguration (rather than the WKProcessPool wrapper).
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Create the API::ProcessPoolConfigurations using [_WKProcessPoolConfiguration alloc] as its
storage..
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::create):
(API::ProcessPoolConfiguration::createWithLegacyOptions):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::~ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):
(API::ProcessPoolConfiguration::webProcessPoolConfiguration): Deleted.
- UIProcess/API/APIProcessPoolConfiguration.h:
Add the remaining initialization parameters and add a convenience create function
for configuring legacy WebProcessPools (for use by the C-SPI).
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
- UIProcess/API/APIWebsiteDataStore.h:
- UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::defaultDataStoreConfiguration):
Expose helper for getting the website data directories for use in the ProcessPoolConfiguration.
- UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
(WKContextCreateWithConfiguration):
Use ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.
- UIProcess/API/C/WKContextConfigurationRef.cpp:
(WKContextConfigurationCreate):
Update for ProcessPoolConfiguration::create() returning a Ref. Note, this function
was not changed to call ProcessPoolConfiguration::createWithLegacyOptions() since
it has not been around long enough to warrant it.
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
Use ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool description]):
Change to pull the configuration from the underlying API::Object.
(-[WKProcessPool _configuration]):
Change to pull the configuration from the underlying API::Object and call the new
copy() helper on it.
(-[WKProcessPool _initWithConfiguration:]):
Convert to be a simple pass through to API::Object::constructInWrapper.
(websiteDataDirectoryURL): Deleted.
Moved to APIWebsiteDataStore.h
- UIProcess/API/Cocoa/WKProcessPoolInternal.h:
Removes the _WKProcessPoolConfiguration member, now that it is stored on the WebProcessPool.
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration init]):
(-[_WKProcessPoolConfiguration dealloc]):
Added to support API::Object bridging.
(-[_WKProcessPoolConfiguration injectedBundleURL]):
(-[_WKProcessPoolConfiguration setInjectedBundleURL:]):
Convert to getting the URL from the underlying object. Moved the exception
that used to be on creation of the WKProcessPool.
(-[_WKProcessPoolConfiguration maximumProcessCount]):
(-[_WKProcessPoolConfiguration setMaximumProcessCount:]):
Convert to getting the count from the underlying object.
(-[_WKProcessPoolConfiguration cachePartitionedURLSchemes]):
Convert to constructing the NSArray on demand from the underlying Vector.
(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):
Converts the NSArray to a Vector rather than storing the array.
- UIProcess/API/Cocoa/_WKProcessPoolConfigurationInternal.h: Added.
(API::wrapper):
Add boilerplate for API::Object bridging.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
Update to use API::ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorProcessPool):
Update to call API::ProcessPoolConfiguration::createWithLegacyOptions().
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::create):
(WebKit::websiteDataStoreConfiguration):
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::applyPlatformSpecificConfigurationDefaults): Deleted.
This functionality was moved to the constructor of the API::ProcessPoolConfiguration.
- UIProcess/WebProcessPool.h:
Changed to take (and store) a API::ProcessPoolConfiguration rather than the WebProcessPoolConfiguration.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.
- UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.
Renamed to make it clear these were the legacy locations for these directories.
- WebKit2.xcodeproj/project.pbxproj:
Added new files.
- 4:58 PM Changeset in webkit [178684] by
-
- 3 edits in trunk/Source/WebCore
Stop using FeatureCounter to log navigation types
https://bugs.webkit.org/show_bug.cgi?id=140642
Reviewed by Andreas Kling.
Stop using FeatureCounter to log navigation types now that
DiagnosticLoggingClient is working on iOS.
- loader/FrameLoader.cpp:
(WebCore::logNavigation):
- platform/FeatureCounterKeys.h:
- 4:39 PM Changeset in webkit [178683] by
-
- 11 edits in trunk/Source/WebCore
LayoutState and subtree layout code should use RenderElement.
<https://webkit.org/b/126878>
Subtree layout will never begin at a RenderText, so tighten up
the code to operate on RenderElements instead of RenderObjects.
Reviewed by Antti Koivisto.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willLayout):
- page/FrameView.cpp:
(WebCore::FrameView::layoutRoot):
(WebCore::FrameView::layout):
- page/FrameView.h:
Make FrameView::layoutRoot() return RenderElement*.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeDestroyed):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObject.h:
Move subtree layout root clearing logic in willBeDestroyed()
from RenderObject to RenderElement.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
- rendering/RenderView.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
Make all of these functions take RenderElement instead of
RenderObject since layout never starts from a RenderText.
(WebCore::RenderView::shouldDisableLayoutStateForSubtree):
Tweak loop since it's never null on first iteration.
- 4:36 PM Changeset in webkit [178682] by
-
- 2 edits in trunk
[CMAKE] Fix cmake warning
https://bugs.webkit.org/show_bug.cgi?id=140497
Reviewed by Gustavo Noronha Silva.
r173155 already tried to fix cmake warning though, the warning is still exist.
CMAKE_LINK_INTERFACE_LIBRARIES seems to cause this warning. Individual target is
already set for their libraries though, INTERFACE_LINK_LIBRARIES contains the list
of transitive link dependencies, and CMAKE_LINK_INTERFACE_LIBRARIES can override
the INTERFACE_LINK_LIBRARIES property when CMP0022 is not set. CMake warns this override.
To avoid it, EFL port doesn't set CMAKE_LINK_INTERFACE_LIBRARIES.
- CMakeLists.txt:
- 4:24 PM Changeset in webkit [178681] by
-
- 6 edits in trunk/Source
Source/WebCore:
Speculative build fix.
- platform/spi/mac/NSViewSPI.h:
Source/WebKit/mac:
Speculative build fix.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit2:
Speculative build fix.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processPool:configuration:webView:]):
- 4:17 PM Changeset in webkit [178680] by
-
- 2 edits in trunk/Source/WebKit/mac
Speculative build fix.
- WebView/WebView.mm:
(-[WebView _convertRectFromRootView:]):
- 3:46 PM Changeset in webkit [178679] by
-
- 10 edits in trunk
Adjust naming of action menu SPI
https://bugs.webkit.org/show_bug.cgi?id=140644
<rdar://problem/19448129>
Reviewed by Brian Weinstein.
- platform/spi/mac/NSViewSPI.h:
Add an underscore.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController willOpenMenu:withEvent:]):
(-[WebActionMenuController didCloseMenu:withEvent:]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView prepareForMenu:withEvent:]):
(-[WebView willOpenMenu:withEvent:]):
(-[WebView didCloseMenu:withEvent:]):
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processPool:configuration:webView:]):
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController willOpenMenu:withEvent:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController menuNeedsUpdate:]):
(-[WKActionMenuController _updateActionMenuItems]):
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
(-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
(TestWebKitAPI::TEST):
- 3:43 PM Changeset in webkit [178678] by
-
- 6 edits in trunk/LayoutTests
[Win] Unreviewed Windows gardening.
Rebaseline a few tests based on current bot output.
- platform/win/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/win/fast/regions/region-dynamic-after-before-expected.txt:
- platform/win/fast/regions/region-generated-content-before-after-expected.txt:
- platform/win/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/win/fast/text/international/thai-baht-space-expected.txt:
- 3:25 PM Changeset in webkit [178677] by
-
- 3 edits in trunk/LayoutTests
[Mac] Test fix after r178674.
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- 3:24 PM Changeset in webkit [178676] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is
offset by flipped-ness
https://bugs.webkit.org/show_bug.cgi?id=140643
-and corresponding-
rdar://problem/19489593
Reviewed by Tim Horton.
We universally flipped because we assumed that the root view was flipped and the
WebView was not. However, in Dictionary, the WebView is flipped! So this patch
fixes that assumption by checking the WebView’s flipped-ness.
- WebView/WebView.mm:
(-[WebView _convertRectFromRootView:]):
- 3:09 PM Changeset in webkit [178675] by
-
- 11 edits in trunk
Canonicalization of :lang() should preserve the :lang()'s arguments representations
https://bugs.webkit.org/show_bug.cgi?id=139928
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2015-01-19
Reviewed by Benjamin Poulain.
Source/WebCore:
Preserve the representation of IDENT and STRING when serializing the
:lang(). For example, :lang(foo,"bar", baz) should be serialize as
:lang(foo, "bar", baz) instead of :lang(foo, bar, baz).
Rename CSSParserSelector::setArgumentList, CSSSelector::setArgumentList
and CSSSelector::argumentList to CSSParserSelector::setLangArgumentList,
CSSSelector::setLangArgumentList and CSSSelector::langArgumentList
respectively, since those methods are being exclusively used in respect
with :lang().
Update the test of serializing :lang() with IDENT and STRING arguments.
- css/CSSGrammar.y.in:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::setLangArgumentList):
(WebCore::CSSParserSelector::setArgumentList): Deleted.
- css/CSSParserValues.h:
(WebCore::CSSParserString::tokenType):
(WebCore::CSSParserString::setTokenType):
- css/CSSSelector.cpp:
(WebCore::appendLangArgumentList):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setLangArgumentList):
(WebCore::appendArgumentList): Deleted.
(WebCore::CSSSelector::setArgumentList): Deleted.
- css/CSSSelector.h:
(WebCore::CSSSelector::langArgumentList):
(WebCore::CSSSelector::argumentList): Deleted.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
LayoutTests:
- fast/css/css-lang-selector-with-string-arguments-text-expected.txt:
- fast/css/css-lang-selector-with-string-arguments-text.html:
- 2:15 PM Changeset in webkit [178674] by
-
- 85 edits3 copies8 adds in trunk
WebGL2: Support webgl2 context creation.
https://bugs.webkit.org/show_bug.cgi?id=126408
<rdar://problem/15002170>
Reviewed by Dean Jackson.
Tests covered by existing Khronos tests for WebGL 1.0 conformance.
Create a WebGLRenderingContextBase class that extends to a WebGLRenderingContext and WebGL2RenderingContext.
Replace all previous instances of WebGLRenderingContext usages with WebGLRenderingContextBase usages for now.
As the first step, the WebGL1 and WebGL2 contexts will have the exact same functionality.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/js/JSWebGL2RenderingContextCustom.cpp: Added.
(WebCore::JSWebGL2RenderingContext::visitAdditionalChildren):
- bindings/js/JSWebGLRenderingContextBaseCustom.cpp: Added.
- bindings/js/JSWebGLRenderingContextCustom.cpp: Move code to JSWebGLRenderingContextBaseCustom.cpp.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::getImageData):
- html/canvas/ANGLEInstancedArrays.cpp:
(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
(WebCore::ANGLEInstancedArrays::supported):
- html/canvas/ANGLEInstancedArrays.h:
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::isWebGL1):
(WebCore::CanvasRenderingContext::isWebGL2):
(WebCore::CanvasRenderingContext::is3d):
- html/canvas/EXTBlendMinMax.cpp:
(WebCore::EXTBlendMinMax::EXTBlendMinMax):
- html/canvas/EXTBlendMinMax.h:
- html/canvas/EXTFragDepth.cpp:
(WebCore::EXTFragDepth::EXTFragDepth):
- html/canvas/EXTFragDepth.h:
- html/canvas/EXTShaderTextureLOD.cpp:
(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):
- html/canvas/EXTShaderTextureLOD.h:
- html/canvas/EXTTextureFilterAnisotropic.cpp:
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
- html/canvas/EXTTextureFilterAnisotropic.h:
- html/canvas/EXTsRGB.cpp:
(WebCore::EXTsRGB::EXTsRGB):
- html/canvas/EXTsRGB.h:
- html/canvas/OESElementIndexUint.cpp:
(WebCore::OESElementIndexUint::OESElementIndexUint):
- html/canvas/OESElementIndexUint.h:
- html/canvas/OESStandardDerivatives.cpp:
(WebCore::OESStandardDerivatives::OESStandardDerivatives):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESTextureFloat.cpp:
(WebCore::OESTextureFloat::OESTextureFloat):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloatLinear.cpp:
(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):
- html/canvas/OESTextureFloatLinear.h:
- html/canvas/OESTextureHalfFloat.cpp:
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
- html/canvas/OESTextureHalfFloat.h:
- html/canvas/OESTextureHalfFloatLinear.cpp:
(WebCore::OESTextureHalfFloatLinear::OESTextureHalfFloatLinear):
- html/canvas/OESTextureHalfFloatLinear.h:
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::OESVertexArrayObject):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGL2RenderingContext.cpp: Added.
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
- html/canvas/WebGL2RenderingContext.h: Added.
- html/canvas/WebGL2RenderingContext.idl: Added.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::create):
(WebCore::WebGLBuffer::WebGLBuffer):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLCompressedTextureATC.cpp:
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::supported):
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTexturePVRTC.cpp:
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::supported):
- html/canvas/WebGLCompressedTexturePVRTC.h:
- html/canvas/WebGLCompressedTextureS3TC.cpp:
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::supported):
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLContextGroup.cpp:
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::loseContextGroup):
- html/canvas/WebGLContextGroup.h:
- html/canvas/WebGLContextObject.cpp:
(WebCore::WebGLContextObject::WebGLContextObject):
- html/canvas/WebGLContextObject.h:
(WebCore::WebGLContextObject::context):
- html/canvas/WebGLDebugRendererInfo.cpp:
(WebCore::WebGLDebugRendererInfo::WebGLDebugRendererInfo):
- html/canvas/WebGLDebugRendererInfo.h:
- html/canvas/WebGLDebugShaders.cpp:
(WebCore::WebGLDebugShaders::WebGLDebugShaders):
- html/canvas/WebGLDebugShaders.h:
- html/canvas/WebGLDepthTexture.cpp:
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
- html/canvas/WebGLDepthTexture.h:
- html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::WebGLDrawBuffers):
(WebCore::WebGLDrawBuffers::supported):
(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):
- html/canvas/WebGLDrawBuffers.h:
- html/canvas/WebGLExtension.cpp:
(WebCore::WebGLExtension::WebGLExtension):
- html/canvas/WebGLExtension.h:
(WebCore::WebGLExtension::context):
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::create):
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLLoseContext.cpp:
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::loseContext):
- html/canvas/WebGLLoseContext.h:
- html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::create):
(WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::create):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp: Move implementation to WebGLRenderingContextBase.cpp.
- html/canvas/WebGLRenderingContext.h: Move implementation to WebGLRenderingContextBase.h.
- html/canvas/WebGLRenderingContext.idl: Move implementation to WebGLRenderingContextBase.idl.
- html/canvas/WebGLRenderingContextBase.cpp: Added.
- html/canvas/WebGLRenderingContextBase.h: Added.
- html/canvas/WebGLRenderingContextBase.idl: Added.
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::create):
(WebCore::WebGLShader::WebGLShader):
- html/canvas/WebGLShader.h:
- html/canvas/WebGLSharedObject.cpp:
(WebCore::WebGLSharedObject::WebGLSharedObject):
- html/canvas/WebGLSharedObject.h:
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::create):
(WebCore::WebGLTexture::WebGLTexture):
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::create):
(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
- html/canvas/WebGLVertexArrayObjectOES.h:
Layout test fixes:
- fast/canvas/webgl/bad-arguments-test-expected.txt:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 2:02 PM Changeset in webkit [178673] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r178250): ~2% PLT regression
https://bugs.webkit.org/show_bug.cgi?id=140640
Reviewed by Andreas Kling.
- platform/graphics/FontCache.cpp:
The patch accidentally contained a change to reduce the size of the cache (to verify that purgin works).
Restore it back to the original value.
- 1:58 PM Changeset in webkit [178672] by
-
- 4 edits1 move in trunk
[GTK] Generate the make dist manifest from a CMake template file
https://bugs.webkit.org/show_bug.cgi?id=139387
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-19
Reviewed by Martin Robinson.
.:
Generate manifest.txt from manifest.txt.in. Only expose the dist and
distcheck targets for developer builds, as they won't work when
building from a tarball because the manifest is not distributed.
- Source/PlatformGTK.cmake:
Tools:
Remove the code that performs variable substitution on manifest.txt.
Replace the custom variables used in that file with CMake variables.
- gtk/make-dist.py:
(Manifest.add_directory):
(Manifest.get_full_source_path):
(Manifest.process_line):
(Manifest.resolve_variables): Deleted.
(Manifest.get_full_tarball_path): Deleted.
- gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
- 1:03 PM Changeset in webkit [178671] by
-
- 5 edits in trunk
[WinCairo][Video] Windows Media Foundation implementation is not completed.
https://bugs.webkit.org/show_bug.cgi?id=140337
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-19
Reviewed by Alex Christensen.
Source/WebCore:
This patch aims to complete some of the methods which are not implemented.
Currently, only MP4 is supported.
Video is rendered in a child window of the main window.
We should eventually render the video directly in the main window,
by reading and painting individual video frames from the stream.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaFoundation::supportsType):
(WebCore::MediaPlayerPrivateMediaFoundation::load):
(WebCore::MediaPlayerPrivateMediaFoundation::play):
(WebCore::MediaPlayerPrivateMediaFoundation::pause):
(WebCore::MediaPlayerPrivateMediaFoundation::naturalSize):
(WebCore::MediaPlayerPrivateMediaFoundation::hasVideo):
(WebCore::MediaPlayerPrivateMediaFoundation::hasAudio):
(WebCore::MediaPlayerPrivateMediaFoundation::setVisible):
(WebCore::MediaPlayerPrivateMediaFoundation::paused):
(WebCore::MediaPlayerPrivateMediaFoundation::readyState):
(WebCore::MediaPlayerPrivateMediaFoundation::didLoadingProgress):
(WebCore::MediaPlayerPrivateMediaFoundation::setSize):
(WebCore::MediaPlayerPrivateMediaFoundation::paint):
(WebCore::MediaPlayerPrivateMediaFoundation::createSession):
(WebCore::MediaPlayerPrivateMediaFoundation::endSession):
(WebCore::MediaPlayerPrivateMediaFoundation::startCreateMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::createTopologyFromSource):
(WebCore::MediaPlayerPrivateMediaFoundation::addBranchToPartialTopology):
(WebCore::MediaPlayerPrivateMediaFoundation::VideoViewWndProc):
(WebCore::MediaPlayerPrivateMediaFoundation::registerVideoWindowClass):
(WebCore::MediaPlayerPrivateMediaFoundation::createVideoWindow):
(WebCore::MediaPlayerPrivateMediaFoundation::destroyVideoWindow):
(WebCore::MediaPlayerPrivateMediaFoundation::createOutputNode):
(WebCore::MediaPlayerPrivateMediaFoundation::createSourceStreamNode):
(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::AsyncCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::~AsyncCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::QueryInterface):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::AddRef):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Release):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::GetParameters):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Invoke):
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
WebKitLibraries:
Link with Media Foundation libraries.
- win/tools/vsprops/WinCairo.props:
- 1:01 PM Changeset in webkit [178670] by
-
- 2 edits in trunk/Tools
[Win] Correct merge error in last commit.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(findAccessibleObjectById): Undo accidental paste made during landing.
- 12:58 PM Changeset in webkit [178669] by
-
- 16 edits in trunk
[Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
https://bugs.webkit.org/show_bug.cgi?id=139906
Reviewed by Dean Jackson.
WebKit on Windows was creating uninitialized VARIANT structures, then attempting
to use them. This patch fixes that.
Source/WebKit/win:
Identified by dom/html/level2/html/HTMLIFrameElement03.html (and others)
- COMEnumVariant.h:
(COMEnumVariant<ContainerType>::Next):
- COMPropertyBag.h:
(HashType>::Read):
- DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::decidePolicyForNavigationAction):
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
- WebDatabaseManager.cpp:
(DatabaseDetailsPropertyBag::Read):
- WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read):
- WebFrame.cpp:
(EnumChildFrames::Next):
- WebView.cpp:
(WebView::notifyDidAddIcon):
Tools:
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(findAccessibleObjectById):
(AccessibilityController::focusedElement):
(logEventProc):
(notificationListenerProc):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::titleUIElement):
(self):
(AccessibilityUIElement::role):
(AccessibilityUIElement::valueDescription):
(accessibilityState):
(AccessibilityUIElement::isChecked):
- DumpRenderTree/win/DumpRenderTree.cpp:
(dumpFrameScrollPosition):
(dumpFramesAsText):
- DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::decidePolicyForNavigationAction):
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::exceededDatabaseQuota):
- WinLauncher/Common.cpp:
(setWindowText):
- 12:49 PM Changeset in webkit [178668] by
-
- 16 edits in trunk/Source
Web Replay: convert to is<T> and downcast<T> for decoding replay inputs
https://bugs.webkit.org/show_bug.cgi?id=140512
Reviewed by Chris Dumez.
Source/JavaScriptCore:
Generate a SPECIALIZE_TYPE_TRAITS_* chunk of code for each input. This cannot
be done using REPLAY_INPUT_NAMES_FOR_EACH macro since that doesn't fully qualify
input types, and the type traits macro is defined in namespace WTF.
- replay/NondeterministicInput.h: Make overridden methods public.
- replay/scripts/CodeGeneratorReplayInputs.py:
(Generator.generate_header):
(Generator.qualified_input_name): Allow forcing qualification. WTF is never a target framework.
(Generator.generate_input_type_trait_declaration): Added.
- replay/scripts/CodeGeneratorReplayInputsTemplates.py: Add a template.
- replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.h:
- replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.h:
Source/WebCore:
No new tests, no behavior changed.
- replay/EventLoopInput.h: Make overridden methods public.
- replay/MemoizedDOMResult.h: Add type trait specialization here. It is
special-cased because the input type parameter doesn't work with macros.
- replay/SerializationMethods.cpp:
(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
Use is() and downcast() when dispatching to encoders based on type.
- 12:34 PM Changeset in webkit [178667] by
-
- 2 edits in trunk/Source/WebCore
Replace use of WTF::bind() in MemoryPressureHandlerLinux.cpp with a C++ lambda
https://bugs.webkit.org/show_bug.cgi?id=140614
Reviewed by Carlos Garcia Campos.
Use a C++ lambda instead of WTF::bind() in the MemoryPressureHandler
implementation for Linux.
- platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent):
- 12:32 PM Changeset in webkit [178666] by
-
- 2 edits in trunk/LayoutTests
Update expectations for media/track/track-forced-subtitles-in-band.html.
This test was marked as flaky on Yosemite, but the bug that tracked that was already
fixed. The test is flaky on Mavericks and above for some other reason.
- platform/mac/TestExpectations:
- 12:31 PM Changeset in webkit [178665] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Use C++ lambda instead of WTF::bind() in ThreadedCompositor::updateSceneState()
https://bugs.webkit.org/show_bug.cgi?id=140613
Reviewed by Carlos Garcia Campos.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::updateSceneState): Replace the use of WTF::bind() with a C++ lambda.
- 12:30 PM Changeset in webkit [178664] by
-
- 2 edits in trunk/Source/WebCore
Replace uses of WTF::bind() in MockMediaPlayerMediaSource with C++ lambdas
https://bugs.webkit.org/show_bug.cgi?id=140612
Reviewed by Philippe Normand.
Use C++ lambdas in place of WTF::bind() in the MockMediaPlayerMediaSource class.
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::play):
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance):
(WebCore::MockMediaPlayerMediaSource::seekCompleted):
- 12:17 PM Changeset in webkit [178663] by
-
- 61 edits1 copy5 adds1 delete in trunk
Unreviewed, rolling out r178653.
https://bugs.webkit.org/show_bug.cgi?id=140634
Broke multiple SVG tests on Mountain Lion (Requested by ap on
#webkit).
Reverted changeset:
"[SVG -> OTF Converter] Flip the switch on"
https://bugs.webkit.org/show_bug.cgi?id=140592
http://trac.webkit.org/changeset/178653
- 12:03 PM Changeset in webkit [178662] by
-
- 5 edits3 adds in trunk
ES6: Support Array.of construction
https://bugs.webkit.org/show_bug.cgi?id=140605
<rdar://problem/19513655>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add and implementation of Array.of, described in 22.1.2.3 of the ES6
specification (15 Jan 2015). The Array.of() method creates a new Array
instance with a variable number of arguments, regardless of number or type
of the arguments.
- runtime/ArrayConstructor.cpp:
(JSC::arrayConstructorOf): Create a new empty Array, then iterate
over the arguments, setting them to the appropriate index.
LayoutTests:
Add 'of' to the Array properties, and a
test for Array.of().
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-of-expected.txt: Added.
- js/array-of.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-of.js: Added.
- 12:02 PM Changeset in webkit [178661] by
-
- 6 edits in trunk/Source/WebCore
Layers need to be already updated before we call adjustViewSize
https://bugs.webkit.org/show_bug.cgi?id=135514
Reviewed by Simon Fraser.
Tested by 'fast/dynamic/layer-no-longer-paginated.html'
Defer painting operations until we have finished layout. This
has a couple of benefits:
(1) We do not attempt to modify render layers during layout.
(2) In WK1 we do not attempt to paint during layout.
Add a new virtual predicate to ScrollView indicating when we are in
layout so that calls to setContentsSize do not attempt
to adjust scrollbars.
Modify FrameView to set its ScrollView state to block paint
operations during layout. Also add a post-layout handler to
complete the scrollbar updates after layout is finished.
- WebCore.exp.in: Move linker symbol to ScrollView (from FrameView).
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::shouldDeferScrollUpdateAfterContentSizeChange): Added.
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget): Removed (Renamed).
(WebCore::FrameView::scrollPositionChangedViaPlatformWidgetImpl): Added (Renamed)
(WebCore::FrameView::paintContents): Do not paint if we are inside view size adjustment.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPositionChangedViaPlatformWidget): Added. Checks whether we need to defer
painting, and calls virtual scrollPositionChangedViaPlatformWidgetImpl if we do not.
(WebCore::FrameView::scrollPositionChangedViaPlatformWidgetImpl): Added.
(WebCore::ScrollView::handleDeferredScrollUpdateAfterContentSizeChange): Added.
(WebCore::ScrollView::scrollTo): If we should defer painting, cache the
the scroll delta and apply it after the layout is complete.
(WebCore::ScrollView::completeUpdatesAfterScrollTo): Split off part of 'scrollTo' into its own method
so we can reuse it in handleDeferredScrollUpdateAfterContentSizeChange.
- platform/ScrollView.h:
(WebCore::ScrollView::shouldDeferScrollUpdateAfterContentSizeChange): Added.
- 11:45 AM Changeset in webkit [178660] by
-
- 7 edits in trunk
Add "override" to fix the build with newer clangs.
Source/WebKit2:
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::transformObjectsToHandles):
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
Tools:
- TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
(TestWebKitAPI::CalculationDeletionTestNode::operator==):
- 11:30 AM Changeset in webkit [178659] by
-
- 5 edits in branches/safari-600.5-branch/Source
Versioning.
- 11:28 AM Changeset in webkit [178658] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 11:26 AM Changeset in webkit [178657] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 11:04 AM Changeset in webkit [178656] by
-
- 3 edits in trunk/Tools
[iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
<http://webkit.org/b/140623>
Reviewed by Daniel Bates.
- Scripts/build-webkit: Update help for --device switch.
- Scripts/webkitdirs.pm:
(determineXcodeSDK): When passing --device, prefer the internal
iOS SDK if it exists, else fall back to the external iOS SDK.
(buildXCodeProject): Use xcodeSDK() as -sdk argument for
xcodebuild instead of trying to sanitize values.
- 10:50 AM Changeset in webkit [178655] by
-
- 3 edits2 adds in trunk
HTMLMediaElement::isPlayingAudio() should return false if the element is explicitly muted by script.
https://bugs.webkit.org/show_bug.cgi?id=140524
Reviewed by Andreas Kling.
Source/WebCore:
Test: media/muted-video-is-playing-audio.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMuted):
Call Document::updateIsPlayingAudio() to recalculate the overall audio playing state.
(WebCore::HTMLMediaElement::isPlayingAudio):
HTMLMediaElement::isPlayingAudio() should return false if the media element is explicitly muted.
LayoutTests:
The test contains a looping video. It makes sure initially Page::isPlayingAudio() returns true.
It should return false after the video is muted, and true again after the video is unmuted.
- media/muted-video-is-playing-audio-expected.txt: Added.
- media/muted-video-is-playing-audio.html: Added.
- 10:40 AM Changeset in webkit [178654] by
-
- 2 edits in trunk/Source/WebKit
Try to fix build warnings with newer versions of clang.
- Storage/StorageAreaImpl.h:
- 10:37 AM Changeset in webkit [178653] by
-
- 61 edits1 add6 deletes in trunk
[SVG -> OTF Converter] Flip the switch on
https://bugs.webkit.org/show_bug.cgi?id=140592
Source/JavaScriptCore:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Reviewed by Antti Koivisto.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Updating test expected results.
svg/W3C-SVG-1.1/fonts-glyph-04-t.svg tests something which isn't spec'ed
and is impossible to perform with the converter, so I have deleted that
test.
svg/custom/skip-underline-missing-glyph-expected.html was testing
incorrect behavior, so I have updated the test.
The getStartPositionOfChar() calls in svg/text/kerning.svg and
svg/text/multichar-glyph.svg are currently impossible to be implemented
correctly with the converter, so I have updated the expected results to
test for the updated results of those calls.
Reviewed by Antti Koivisto.
- platform/mac/TestExpectations:
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Removed.
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/mac/svg/custom/glyph-setting-d-attribute-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/custom/svg-fonts-fallback-expected.txt:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/text/kerning-expected.txt:
- platform/mac/svg/text/multichar-glyph-expected.txt:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
- svg/W3C-SVG-1.1/fonts-glyph-04-t-w3c.png: Removed.
- svg/W3C-SVG-1.1/fonts-glyph-04-t.svg: Removed.
- svg/custom/skip-underline-missing-glyph-expected.html: Removed.
- svg/custom/skip-underline-missing-glyph-expected.txt: Added.
- svg/custom/skip-underline-missing-glyph.html:
- 10:32 AM Changeset in webkit [178652] by
-
- 2 edits in trunk/LayoutTests
Mark a couple slow tests as such.
- 10:05 AM Changeset in webkit [178651] by
-
- 2 edits in trunk/Tools
"Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
https://bugs.webkit.org/show_bug.cgi?id=140606
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
- 9:43 AM Changeset in webkit [178650] by
-
- 1 edit1 delete in trunk/LayoutTests
[Win] Unreviewed gardening: Remove unneeded win-specific result.
At one point, Windows error messages did not include line numbers and needed its own results.
This is no longer the case, and any such results should be removed
- platform/win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Removed.
- 9:35 AM Changeset in webkit [178649] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening: Mark some passing tests appropriately.
- platform/win/TestExpectations:
- 9:25 AM Changeset in webkit [178648] by
-
- 32 edits in trunk
Console log sometimes prefixed with line number
https://bugs.webkit.org/show_bug.cgi?id=105280
Reviewed by Darin Adler.
Source/WebCore:
Improve the logic for determining whether a console message should be associated
with a source code location.
- dom/ScriptableDocumentParser.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::shouldAssociateConsoleMessagesWithTextPosition):
- html/parser/HTMLDocumentParser.h:
- page/PageConsoleClient.cpp:
(WebCore::getParserLocationForConsoleMessage):
(WebCore::PageConsoleClient::addMessage):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::pauseParsing):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::shouldAssociateConsoleMessagesWithTextPosition):
LayoutTests:
Some messages lost line numbers now. Some of these were definitely wrong, others
were roughly right. Unfortunately, it is not currently possible to figure out whether
ScriptController actually executes a script after passing control to it. So the cases
where it refuses to execute the script and logs a message are handled like those
where it does.
I think that it shouldn't be a big obstacle in practice, it is easy enough to find
a script in a page when Web Inspector tells you that scripts were not allowed.
- fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
- fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
- fast/frames/sandboxed-iframe-scripting-04-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
- http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
- http/tests/security/no-javascript-refresh-expected.txt:
- http/tests/security/no-javascript-refresh-spaces-expected.txt:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
Unmark tests that were broken by this.
- 8:32 AM Changeset in webkit [178647] by
-
- 2 edits in trunk/Source/WebCore
[SVG -> OTF Converter] Glyphs get clipped weirdly
https://bugs.webkit.org/show_bug.cgi?id=137095
Reviewed by Antti Koivisto.
The Adobe CFF spec doesn't actually tell you how to serialize a
"FontBBox." After trial and error, it seems to be (x, y, width,
height).
Test: svg/text/kerning.svg
svg/W3C-SVG-1.1/fonts-kern-01-t.svg
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendHEADTable):
(WebCore::SVGToOTFFontConverter::appendCFFTable):
(WebCore::SVGToOTFFontConverter::appendVHEATable):
(WebCore::CFFBuilder::CFFBuilder):
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):
(WebCore::SVGToOTFFontConverter::processGlyphElement):
- 7:27 AM Changeset in webkit [178646] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r178486): It broke the !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=140611
Reviewed by Eric Carlson.
- testing/Internals.cpp:
(WebCore::Internals::elementIsBlockingDisplaySleep):
- testing/Internals.h:
- 6:23 AM Changeset in webkit [178645] by
-
- 2 edits in trunk/LayoutTests
[Win] REGRESSION(r177542 or r177613): svg/W3C tests are broken
https://bugs.webkit.org/show_bug.cgi?id=139972
Unreviewed gardening, unskip now passing tests after r178139.
- platform/win/TestExpectations:
- 5:33 AM Changeset in webkit [178644] by
-
- 5 edits in trunk/Tools
[GTK] [WK2] TestWebKitWebView snapshot fails
https://bugs.webkit.org/show_bug.cgi?id=120404
Reviewed by Žan Doberšek.
Rework the test to make sure the snapshot is always created at the
desired size.
- Scripts/run-gtk-tests:
(TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewSnapshot): Use a fixed size for the document, and
disable scrollbars to make sure the visible area is always the
WebView size.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
and height parameters to create the window with a given size.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
- 3:21 AM Changeset in webkit [178643] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, when committing r178642 I forgot to add the
TestExpectations change.
- TestExpectations: Added
fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html.
- 1:44 AM Changeset in webkit [178642] by
-
- 9 edits2 adds in trunk
[CSS Grid Layout] Tracks shrink sometimes with indefinite remaining space
https://bugs.webkit.org/show_bug.cgi?id=139059
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/css-grid-layout/grid-grow-tracks-to-their-max.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
LayoutTests:
The third step of the grid track sizing algorithm (method
ComputeUsedBreadthOfGridTracks in the old specs version of the
algorithm) tries to grow all grid tracks until the remaining space
is exhausted. Should the remaining space is undefined we should fill
the tracks up to their limits. This is specified in pseudocode like
this:
For each Grid track t in GridTracks
t.UsedBreadth = t.MaxBreadth
That's correct for most of the cases, but it becomes
wrong whenever t.UsedBreadth > t.MaxBreadth something that is not
incorrect. What we actually want to do is to grow the track to its
maximum if and only if the used breadth is smaller than the maximum.
- TestExpectations: Added a test which is correct but starts to fail
due to another bug (wkb.ug/139058).
- fast/css-grid-layout/grid-auto-columns-rows-update.html:
- fast/css-grid-layout/grid-grow-tracks-to-their-max-expected.txt: Added.
- fast/css-grid-layout/grid-grow-tracks-to-their-max.html: Added.
- fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
- fast/css-grid-layout/minmax-max-content-resolution-rows.html:
- fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
- fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html:
- fast/css-grid-layout/percent-of-indefinite-track-size.html:
Jan 18, 2015:
- 11:15 PM Changeset in webkit [178641] by
-
- 5 edits in trunk/Tools
iOS EWS queue name should be consistent
<http://webkit.org/b/140585>
Reviewed by Daniel Bates.
- Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
to 'ios'.
- Scripts/webkitpy/common/config/ports.py: Ditto.
(DeprecatedPort.port):
(IOSPort):
- Scripts/webkitpy/port/ios.py: Ditto.
(IOSPort):
- Scripts/webkitpy/port/factory.py:
(PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
appears before ios.IOSPort. If this is not done,
run-webkit-tests --ios-simulatorwill get the wrong Port class
(IOSPort instead of IOSSimulatorPort) due to the way that
PortFactory.get() uses prefix matching of <Port>.port_name to
find the correct class to use.
- 11:07 PM Changeset in webkit [178640] by
-
- 2 edits in trunk/LayoutTests
http/tests/navigation/navigation-interrupted-by-fragment.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=140607
- platform/mac-wk2/TestExpectations: Added an expectation.
- 10:57 PM Changeset in webkit [178639] by
-
- 4 edits in trunk/Source/WebCore
Update bindings generation test results after <https://trac.webkit.org/changeset/178633>.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
- 9:32 PM Changeset in webkit [178638] by
-
- 4 edits in trunk/Source/WebCore
Generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=140599
Reviewed by Antti Koivisto.
Generate matchingShorthandsForLonghand() implementation from
CSSPropertyNames.in. We already have all the information we need in
CSSPropertyNames.in to generate the big switch() in
matchingShorthandsForLonghand().
A few shorthands still aren't generated. I will look into getting rid
of the custom code in a follow-up patch.
- css/StylePropertyShorthand.cpp:
(WebCore::makeVector): Deleted.
(WebCore::matchingShorthandsForLonghand): Deleted.
- css/StylePropertyShorthand.h:
(WebCore::matchingCustomShorthandsForLonghand):
- css/makeprop.pl:
(constructShorthandsVector):
- 9:14 PM Changeset in webkit [178637] by
-
- 3 edits2 adds in trunk
Out of bounds write in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=140594
<rdar://problem/19449135>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
In the case where we have a canvas object that does
not have premultiplied alpha (an option you can select
when using WebGL) we have to multiply out the alpha when
converting to JPEG via toDataURL.
For this we created a buffer, but were not accurately
resizing it before flattening the alpha.
Test: fast/canvas/webgl/toDataURL-unpremultipliedAlpha.html
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageDataToDataURL): Call resize once we've
determined we have enough space.
LayoutTests:
Creates a WebGL context that does not have
premultiplied alpha, fills it with 50% transparent white,
and attempts to convert the canvas to a JPEG data URL. This
exercises the code path that was not accurately
allocating data (to flatten the alpha).
- fast/canvas/webgl/toDataURL-unpremultipliedAlpha-expected.txt: Added.
- fast/canvas/webgl/toDataURL-unpremultipliedAlpha.html: Added.
- 4:03 PM Changeset in webkit [178636] by
-
- 5 edits in trunk/Source
Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
(https://bugs.webkit.org/show_bug.cgi?id=129441)
Source/WebKit/mac:
Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
- WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView layoutSublayers:]):
Source/WebKit2:
- UIProcess/WKInspectorHighlightView.mm:
(-[WKInspectorHighlightView update:]): Substitute HighlightType::Node and
HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Pass lvalue reference to WebCore::Highlight
instead of pointer in call to InspectorController::getHighlight().
- 2:16 PM Changeset in webkit [178635] by
-
- 4 edits in trunk/Source/WebKit2
Fix style issues and add availability macros missed in r178634
https://bugs.webkit.org/show_bug.cgi?id=140597
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
Add missing availability macros.
- UIProcess/API/Cocoa/_WKUserContentFilter.h:
- UIProcess/API/Cocoa/_WKUserContentFilter.mm:
(-[_WKUserContentFilter initWithName:serializedRules:]):
(-[_WKUserContentFilter _initWithName:serializedRules:]): Deleted.
Removed unnecessary leading underscore from init method.
- 1:54 PM Changeset in webkit [178634] by
-
- 33 edits8 adds2 deletes in trunk/Source
Add initial experimental user content filtering API
https://bugs.webkit.org/show_bug.cgi?id=140584
Reviewed by Benjamin Poulain.
Source/WebCore:
Change content extensions to be managed through the UserContentController.
- WebCore.exp.in:
Update exports.
- WebCore.xcodeproj/project.pbxproj:
Update for removed files.
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::removeAllRuleLists):
(WebCore::ContentExtensions::ContentExtensionsBackend::sharedInstance): Deleted.
- contentextensions/ContentExtensionsBackend.h:
Remove concept of a shared instance and add a removeAllRuleLists() function.
- contentextensions/ContentExtensionsInterface.cpp: Removed.
- contentextensions/ContentExtensionsInterface.h: Removed.
Since there is no shared instance anymore, checking if a URL should be blocked
now has to go directly to the backend.
- contentextensions/ContentExtensionsManager.cpp:
(WebCore::ContentExtensions::ExtensionsManager::createRuleList):
(WebCore::ContentExtensions::ExtensionsManager::loadExtension): Deleted.
- contentextensions/ContentExtensionsManager.h:
Update interface to accommodate the lack of a shared instance. Now, all this
file does is take a serialized rule list and outputs the Vector of ContentExtensionRules
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
Check with the UserContentController to see if the URL should be blocked.
- page/UserContentController.cpp:
(WebCore::UserContentController::addUserContentFilter):
(WebCore::UserContentController::removeAllUserContentFilters):
(WebCore::UserContentController::contentFilterBlocksURL):
- page/UserContentController.h:
Add single point of interaction for both the WebKit level to add and remove
content filters and WebCore to check to see if URLs should be blocked.
Source/WebKit2:
Moves content filtering from being per-ProcessPool to per-UserContentController.
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- UIProcess/API/APIUserContentFilter.cpp: Added.
(API::UserContentFilter::UserContentFilter):
(API::UserContentFilter::~UserContentFilter):
- UIProcess/API/APIUserContentFilter.h: Added.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKUserContentFilterRef.cpp: Added.
(WKUserContentFilterGetTypeID):
(WKUserContentFilterCreate):
- UIProcess/API/C/WKUserContentFilterRef.h: Added.
- UIProcess/API/C/WebKit2_C.h:
- UIProcess/API/Cocoa/_WKUserContentFilter.h: Added.
- UIProcess/API/Cocoa/_WKUserContentFilter.mm: Added.
(WKUserContentControllerAddUserContentFilter):
(WKUserContentControllerRemoveAllUserContentFilters):
(-[_WKUserContentFilter _initWithName:ruleList:]):
- UIProcess/API/Cocoa/_WKUserContentFilterInternal.h: Added.
Add a basic UserContentFilter type and expose it via both the Objective-C API (as _WKUserContentFilter)
and via the C SPI (as WKUserContentFilterRef).
- UIProcess/API/C/WKUserContentControllerRef.h:
- UIProcess/API/C/WKUserContentControllerRef.cpp:
Add C-SPI to set and remove WKUserContentFilterRefs.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _loadContentExtensionWithIdentifier:serializedRules:successCompletionHandler:errorCompletionHandler:]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::loadContentExtension): Deleted.
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::loadContentExtension): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Remove the old SPI for loading content filters that was per-ProcessPool. Content filters now follow
the same pattern as UserScripts and UserStyleSheets as being per-UserContentController.
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController _addUserContentFilter:]):
(-[WKUserContentController _removeAllUserContentFilters]):
- UIProcess/API/Cocoa/WKUserContentControllerInternal.h:
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h: Added.
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserContentFilter):
(WebKit::WebUserContentControllerProxy::removeAllUserContentFilters):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserContentFilters):
(WebKit::WebUserContentController::removeAllUserContentFilters):
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
Pipe user content filters over to all the WebProcesses that the UserContentController is
connected to.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 12:57 PM Changeset in webkit [178633] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION (r125251): wrapper lifetimes of SVGElementInstance are incorrect
https://bugs.webkit.org/show_bug.cgi?id=132148
Reviewed by Anders Carlsson.
Test: svg/custom/use-instanceRoot-event-listeners.xhtml
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::addEventListener): Updated for the new return type
of JSListener::create. For the event type, use JSString::toAtomicString instead of
calling JSString::value and then converting to an AtomicString.
(WebCore::JSDOMWindow::removeEventListener): Same changes as for addEventListener.
- bindings/js/JSEventListener.cpp:
(WebCore::forwardsEventListeners): Added. Helper to detect the special case needed
for SVGElementInstance. In the future, for better encapsulation, we could use virtual
functions, but for now hard coding this single class seems fine.
(WebCore::correspondingElementWrapper): Added. For use if forwardsEventListeners
returns true, to find out where event listeners will be forwarded.
(WebCore::createJSEventListenerForAttribute): Added. Replaces the old function
createJSAttributeEventListener, for SVGElementInstance attributes only.
(WebCore::createJSEventListenerForAdd): Added. Helper function to avoid repeated
generated code in the addElementListener bindings other than the DOMWindow one.
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create): Changed to return a Ref instead of a PassRefPtr.
(WebCore::createJSEventListenerForAttribute): Renamed from createJSAttributeEventListener,
changed to return a RefPtr instead of a PassRefPtr and to take references rather than
pointers for non-null things.
(WebCore::createJSEventListenerForRemove): Added. Small wrapper that calls
createJSEventListenerForAdd since they are currently identical.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeEventListenerCall): Removed the special case for JSSVGElementInstance
and updated to call the new createJSEventListenerForAttribute. The special case for
SVGElementInstance is now in JSEventListener.h/cpp, which is nicer since we prefer to
keep the generated code simpler if possible.
(GenerateEventListenerCall): Removed the special case for JSSVGElementInstance. This
has been dead code since the explicit definition of add/removeEventListener was removed
from SVGElementInstance.idl, and was also a problem if someone were to use the
addEventListener function from EventTarget on an SVGElementInstance object. The function
needs to be generic at runtime. Use toAtomicString as in JSDOMWindow::addEventListener above.
Call the two new functions, createJSEventListenerForAdd and createJSEventListenerForRemove.
Those new functions properly handle SVGElementInstance.
(GenerateImplementation): Don't pass the class name to GenerateAttributeEventListenerCall
or GenerateEventListenerCall any more.
(GenerateConstructorDefinition): Use JSString::toAtomicString instead of calling
JSString::value and then converting to AtomicString.
- 12:03 PM WebKitGTK/2.4.x edited by
- (diff)
- 12:00 PM WebKitGTK/2.4.x edited by
- (diff)
- 11:52 AM WebKitGTK/2.4.x edited by
- (diff)
- 11:50 AM WebKitGTK/2.4.x edited by
- (diff)
- 10:39 AM Changeset in webkit [178632] by
-
- 2 edits in trunk/Tools
build.webkit.org/dashboard: OS X EWS is now on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=140595
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
- 9:07 AM Changeset in webkit [178631] by
-
- 13 edits1 add in trunk/Source
Web Inspector: highlight data for overlay should use protocol type builders
https://bugs.webkit.org/show_bug.cgi?id=129441
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Add a new domain for overlay types.
- CMakeLists.txt:
- DerivedSources.make:
- inspector/protocol/OverlayTypes.json: Added.
Source/WebCore:
As a first step towards cleaning up the inspector overlay, convert highlight
data construction to use protocol type builders. It's now really obvious what
data is being sent to the inspector overlay page.
This change paves the way towards using inspector protocol commands and events
if we want to support more interactive functionality in the inspector overlay.
This patch makes a few style cleanups, such as standardizing variable names,
using default member initializers, passing by reference, and fixing casts.
No new tests, no behavior changed.
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::buildObjectForHighlightedNode):
(WebCore::InspectorController::inspect): Deleted.
- inspector/InspectorController.h:
- inspector/InspectorOverlay.cpp:
(WebCore::buildRendererHighlight):
(WebCore::buildNodeHighlight):
(WebCore::buildQuadHighlight):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::buildObjectForPoint):
(WebCore::buildObjectForRect):
(WebCore::buildArrayForQuad):
(WebCore::buildObjectForHighlight):
(WebCore::buildObjectForRegion):
(WebCore::buildObjectForFlowRegions):
(WebCore::buildObjectForSize):
(WebCore::buildQuadObjectForCSSRegionContentClip):
Simplify how the clipping area is encoded. It's now 'regionClippingArea'
stored on a FragmentHighlightData instance.
(WebCore::InspectorOverlay::updatePaintRectsTimerFired):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::buildArrayForRendererFragments):
(WebCore::appendPathCommandAndPoints):
(WebCore::appendPathSegment):
(WebCore::buildObjectForShapeOutside):
(WebCore::buildObjectForElementData):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reset):
(WebCore::buildObjectForRegionHighlight): Deleted.
(WebCore::buildObjectForCSSRegionsHighlight): Deleted.
(WebCore::buildObjectForCSSRegionContentClip): Deleted.
(WebCore::buildObjectForRendererFragments): Deleted.
(WebCore::buildObjectForElementInfo): Deleted.
- inspector/InspectorOverlay.h:
(WebCore::Highlight::Highlight):
- inspector/InspectorOverlayPage.js:
(_createElementTitle):
(_drawElementTitle):
(_drawFragmentHighlight):
(drawNodeHighlight):
- testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update symbol.
