⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 16, 2009:

11:16 PM Changeset in webkit [51067] by zoltan@webkit.org
  • 4 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2009-11-16
Reviewed by Gavin Barraclough.

Minor fixes for JSVALUE32_64: branchConvertDoubleToInt32
failed on a CortexA8 CPU, but not on a simulator; and
JITCall.cpp modifications was somehow not committed to mainline.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::fmrs_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

10:31 PM Changeset in webkit [51066] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2009-11-16 Kent Tamura <​tkent@chromium.org>

Unreviewd build fix.

  • Fix typo in WebCore.vcproj.
  • Intlude limits.h for INT_MAX.
  • Enclose with parenthesis to suspress warning.
  • WebCore.vcproj/WebCore.vcproj:
  • html/ISODateTime.cpp: (WebCore::ISODateTime::addDay):
9:50 PM Changeset in webkit [51065] by kevino@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Make sure wx scrollbar drawing code factors in transforms when switching backends,
fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.

​https://bugs.webkit.org/show_bug.cgi?id=31570

9:39 PM Changeset in webkit [51064] by Girish Ramakrishnan
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Add myself to commiters.py

9:13 PM Changeset in webkit [51063] by tkent@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

2009-11-16 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

Introduce WebCore::ISODateTime class.
​https://bugs.webkit.org/show_bug.cgi?id=31340

This class represents a value of date/time types of the HTML5 INPUT
element, and has some parsing methods for ISO 8601.

This change has no tests because the class is not used yet.

  • GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • WebCoreSources.bkl: ditto.
  • html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class. (WebCore::isLeapYear): (WebCore::maxDayOfMonth): (WebCore::dayOfWeek): (WebCore::ISODateTime::maxWeekNumberInYear): (WebCore::countDigits): (WebCore::toInt): (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek(). (WebCore::ISODateTime::addDay): Private helper for parseTimeZone(). (WebCore::ISODateTime::addMinute): ditto. (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime(). (WebCore::ISODateTime::parseMonth): Parser for <input type=month>. (WebCore::ISODateTime::parseDate): Parser for <input type=date>. (WebCore::ISODateTime::parseWeek): Parser for <input type=week>. (WebCore::ISODateTime::parseTime): Parser for <input type=time>. (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>. (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
  • html/ISODateTime.h: Added. Declare WebCore::ISODateTime class. (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::millisecond): (WebCore::ISODateTime::second): (WebCore::ISODateTime::minute): (WebCore::ISODateTime::hour): (WebCore::ISODateTime::monthDay): (WebCore::ISODateTime::month): (WebCore::ISODateTime::fullYear): (WebCore::ISODateTime::week):
7:05 PM BuildingQtOnLinux edited by dbates@webkit.org
Added missing "libsqlite3-dev" dependency for Ubuntu (diff)
4:09 PM Changeset in webkit [51062] by ap@apple.com
  • 2 edits in trunk/WebCore

Fix a typo in previous commit.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
4:04 PM Changeset in webkit [51061] by ap@apple.com
  • 2 edits in trunk/WebCore

Fix a typo in previous commit.

  • platform/network/cf/SocketStreamHandleCFNet.cpp:
3:57 PM Changeset in webkit [51060] by ap@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named differently in Tiger CFNetwork.
3:32 PM Changeset in webkit [51059] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Disabling WebSocket tests on Tiger and Windows again, as they still time out.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
3:08 PM Changeset in webkit [51058] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-11-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.

Fix a bug in the code that was dormant until ​http://trac.webkit.org/changeset/50784.

Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html

  • platform/KURLGoogle.cpp: (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
2:58 PM Changeset in webkit [51057] by ap@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Jon Honeycutt.

A better Windows build fix

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Use a macro that inserts declspec(dllimport) when appropriate for CFNetwork imports.
2:57 PM Changeset in webkit [51056] by yael.aharon@nokia.com
  • 5 edits in trunk/WebCore

Rename protocolIsValid to isValidProtocol.
​https://bugs.webkit.org/show_bug.cgi?id=31503

Reviewed by Darin Adler.

This name change was suggested in ​https://bugs.webkit.org/show_bug.cgi?id=29972#c19.

No new tests since no new functionality was introduced.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setProtocol):

  • platform/KURL.cpp:

(WebCore::isValidProtocol):

  • platform/KURL.h:
  • platform/KURLGoogle.cpp:

(WebCore::isValidProtocol):

2:41 PM Changeset in webkit [51055] by Chris Fleizach
  • 8 edits
    2 adds in trunk

AX: aria-labelledby duplicates some of its WAI-ARIA label
​https://bugs.webkit.org/show_bug.cgi?id=31565

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/aria-labelledby-overrides-label.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(titleUIElementCallback):
(getIsValidCallback):
(AccessibilityUIElement::getJSClass):

LayoutTests:

  • accessibility/aria-labelledby-overrides-label-expected.txt: Added.
  • accessibility/aria-labelledby-overrides-label.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
2:40 PM Changeset in webkit [51054] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-11-16 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Handle the case of a null NPObject* in NPN_SetException in
the V8 bindings. This allow out of process plugins calling
NPN_SetException to just send null instead of sending an
NPObject* that would be an address in a different
process's memory space.

​https://bugs.webkit.org/show_bug.cgi?id=31561

  • bindings/v8/NPV8Object.cpp: (_NPN_SetException): Allow null NPObject* and just throw a general error.
2:30 PM Changeset in webkit [51053] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2:21 PM Changeset in webkit [51052] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] ASSERT failure while running DRT
​https://bugs.webkit.org/show_bug.cgi?id=30978

Reviewed by Kenneth Rohde Christiansen.

Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObjectImp::createStructure):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::createStructure):

1:51 PM Changeset in webkit [51051] by mrowe@apple.com
  • 1 edit
    1 add in trunk/WebCore

Attempt to fix the build. Land a file that was missing from r51049.

  • bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.

(WebCore::setWebGLArrayFromArray):

1:31 PM Changeset in webkit [51050] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

r50942 broke output from created windows. Make the
m_enableTextOutput a member of the DRT and not the
WebPage.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::javaScriptAlert):
(WebCore::WebPage::javaScriptConsoleMessage):
(WebCore::WebPage::javaScriptConfirm):
(WebCore::WebPage::javaScriptPrompt):
(WebCore::WebPage::acceptNavigationRequest):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::createWindow):

  • DumpRenderTree/qt/DumpRenderTree.h:

(WebCore::DumpRenderTree::setTextOutputEnabled):
(WebCore::DumpRenderTree::isTextOutputEnabled):
(WebCore::WebPage::shouldInterruptJavaScript):
(WebCore::WebPage::isTextOutputEnabled):
(WebCore::WebPage::setViewGeometry):

1:30 PM Changeset in webkit [51049] by cmarrin@apple.com
  • 53 edits in trunk

Update API of WebGLArray and friends
​https://bugs.webkit.org/show_bug.cgi?id=31175

1:28 PM Changeset in webkit [51048] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
1:28 PM Changeset in webkit [51047] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

API documentation fixes.

Reviewed by Kenneth Rohde Christiansen.

  • Api/qgraphicswebview.cpp: Removed duplicate docs.
  • Api/qwebelement.cpp: Added missing docs.
  • Api/qwebsettings.cpp: Ditto.
1:01 PM Changeset in webkit [51046] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Enable support for webkit-box-shadow in Cairo builds.
​https://bugs.webkit.org/show_bug.cgi?id=26102.

Reviewed by Oliver Hunt.

Covered by existing fast/box-shadow tests.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Add support for fillRect shadows.
12:36 PM Changeset in webkit [51045] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not in WebKitSupportLibrary.
12:05 PM Changeset in webkit [51044] by kenneth@webkit.org
  • 3 edits
    4 moves
    4 adds in trunk/WebKitTools

Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
as the implementation is being used by at least Qt and Gtk+.

Reviewed by Gustavo Noronha Silva.

Update buildsystems as well.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  • GNUmakefile.am:
11:08 AM Changeset in webkit [51043] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Anders Carlsson.

  • security/security-group-members.html:
10:58 AM Changeset in webkit [51042] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Adele Peterson.

  • security/security-group-members.html:
10:40 AM Changeset in webkit [51041] by ap@apple.com
  • 5 edits in trunk

WebKitTools:
2009-11-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Disable wss until all platforms support pyOpenSSL

​https://bugs.webkit.org/show_bug.cgi?id=31479

  • Scripts/run-webkit-tests:

LayoutTests:

Re-enabling WebSocket tests on Tiger and Windows, now that SSL is disabled.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
9:59 AM Changeset in webkit [51040] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31494
Add unauthenticated proxy support to SocketStreamHandleCFNet

Cannot be tested in DRT.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS. (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
8:54 AM WebKit Team edited by keishi@webkit.org
(diff)
8:51 AM Changeset in webkit [51039] by keishi@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Adding myself to committers.py.

7:38 AM Changeset in webkit [51038] by tonikitoo@webkit.org
  • 8 edits
    2 adds in trunk

[Qt] Broken back/forward after using ErrorPageExtension to set error page
​https://bugs.webkit.org/show_bug.cgi?id=30573

Reviewed by Antti Koivisto.

WebCore:

Make FrameLoader::checkLoadCompleteForThisFrame method
to check for any working DocumentLoader instance (through
activeDocumentLoader()) instead of only checking for
'm_provisionalDocumentLoader' in order to decide to if
it is going to reset of not the back and forward history.
after an error page has been loaded.

Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKit/qt:

Implemented autotests for covering the back/forward
reset problem involving error pages.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtension):

LayoutTests:

Skipped fast/history/back-forward-reset-after-error-handling.html
in mac, gtk and win DRT, because their DRT do not support yet
error pages handling.

  • fast/history/back-forward-reset-after-error-handling.html:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
7:37 AM Changeset in webkit [51037] by tonikitoo@webkit.org
  • 5 edits in trunk/WebKitTools

[Qt] Implement load error pages support for Qt's DRT.
​https://bugs.webkit.org/show_bug.cgi?id=31509

Reviewed by Kenneth Christiansen.

For now, it will not be a default feature, and layout tests
that want to make use of this have to explicitily call
'handleErrorPages();' for the test source.

Any of the other DumpRenderTree's (mac, win and gtk)
support handling error pages. Qt's will be the first.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::supportsExtension):
(WebCore::WebPage::extension):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::shouldHandleErrorPages):
(LayoutTestController::handleErrorPages):

7:05 AM QtWebKitContrib edited by Simon Hausmann
(diff)
6:59 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:58 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:30 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:26 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:24 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:18 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:12 AM QtWebKit edited by kenneth@webkit.org
(diff)
6:06 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:05 AM QtWebKit edited by kenneth@webkit.org
(diff)
6:04 AM QtWebKit edited by Simon Hausmann
(diff)
5:59 AM QtWebKitJournal edited by Simon Hausmann
(diff)
5:47 AM Changeset in webkit [51036] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
​https://bugs.webkit.org/show_bug.cgi?id=31549

Renamed --commit-queue to --non-interactive in most places
and remove the code in land-patches which is no longer needed.

  • Scripts/bugzilla-tool:
5:43 AM Changeset in webkit [51035] by kenneth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Added new Qt expected results for animation tests.

  • platform/qt/animations/change-transform-in-end-event-expected.txt: Added.
  • platform/qt/animations/state-at-end-event-expected.txt: Added.
  • platform/qt/animations/state-at-end-event-transform-expected.txt: Added.
5:34 AM Changeset in webkit [51034] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

The commit-queue should use land-attachment
​https://bugs.webkit.org/show_bug.cgi?id=31548

  • Scripts/bugzilla-tool:
5:25 AM Changeset in webkit [51033] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
5:20 AM Changeset in webkit [51032] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix Qt build on Windows CE 6.

Patch by Joerg Bornemann <​joerg.bornemann@trolltech.com> on 2009-11-16
Reviewed by Simon Hausmann.

  • JavaScriptCore.pri: Add missing include path.
  • wtf/Platform.h: Include ce_time.h for Windows CE 6.
5:05 AM Changeset in webkit [51031] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
4:29 AM Changeset in webkit [51030] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move StyleQueue over to using PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31544

That's what the class it's for.

  • Scripts/bugzilla-tool:
  • Scripts/modules/patchcollection.py:
  • Scripts/modules/patchcollection_unittest.py:
4:11 AM Changeset in webkit [51029] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
​https://bugs.webkit.org/show_bug.cgi?id=31543

Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.

  • Scripts/bugzilla-tool:
4:04 AM Changeset in webkit [51028] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Disable the style queue from posting to the commit queue status page.

  • Scripts/bugzilla-tool:
3:54 AM Changeset in webkit [51027] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

  • Scripts/modules/patchcollection.py: Added.
  • Scripts/modules/patchcollection_unittest.py: Added.
  • Scripts/run-webkit-unittests:
3:47 AM Changeset in webkit [51026] by abarth@webkit.org
  • 2 edits
    1 copy
    1 add in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

  • Scripts/modules/patchcollection.py: Added.
  • Scripts/modules/patchcollection_unittest.py: Added.
  • Scripts/run-webkit-unittests:
3:31 AM Changeset in webkit [51025] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool check-style should work with attachment ids instead of bug ids
​https://bugs.webkit.org/show_bug.cgi?id=31540

  • Scripts/bugzilla-tool:
3:04 AM Changeset in webkit [51024] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WorkQueue is the only place that should know about special exit codes
​https://bugs.webkit.org/show_bug.cgi?id=31534

Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
and add tests for handling exit codes.
I also cleaned up workqueue_unittest.py more.

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
3:02 AM Changeset in webkit [51023] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Re-factor workqueue_unittest to allow for more than one test.
​https://bugs.webkit.org/show_bug.cgi?id=31535

  • Scripts/modules/workqueue_unittest.py:
3:00 AM Changeset in webkit [51022] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
​https://bugs.webkit.org/show_bug.cgi?id=31532

  • Scripts/bugzilla-tool: fix a couple obvious typos.
2:50 AM Changeset in webkit [51021] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
​https://bugs.webkit.org/show_bug.cgi?id=31532

The next patch will move these methods into WebKitLandingScripts.

  • Scripts/bugzilla-tool:
    • Split out _land_patch and _close_bug_if_no_active_patches.
2:45 AM Changeset in webkit [51020] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix silly copy-and-paste code. I am a terrible coder.

  • Scripts/modules/bugzilla.py:
2:34 AM Changeset in webkit [51019] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a StyleQueue
​https://bugs.webkit.org/show_bug.cgi?id=31537

The first iteration of the style queue only produces output locally.
There is also a limit of 10 patches because it's not that useful to
iterate through the entire review queue at this point. We can remove
the limit later.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
1:25 AM Changeset in webkit [51018] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=31531

Adds basic unit testing for WorkQueue. Just runs through one cycle.

  • Scripts/bugzilla-tool:
  • Scripts/modules/statusbot.py:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py: Added.
  • Scripts/run-webkit-unittests:
12:49 AM Changeset in webkit [51017] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=31530

  • Scripts/bugzilla-tool:
12:39 AM Changeset in webkit [51016] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs apply-attachment
​https://bugs.webkit.org/show_bug.cgi?id=31528

  • Scripts/bugzilla-tool:
    • Add ApplyAttachment command.
    • Abstract applying code into WebKitApplyingScripts.
    • Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
  • Scripts/modules/bugzilla.py:
    • Add fetch_attachment and bug_id_for_attachment_id.
  • Scripts/modules/bugzilla_unittest.py:
    • Add test for new parsing.
    • Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
12:38 AM Changeset in webkit [51015] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Document check-style's use of force_clean.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
12:28 AM Changeset in webkit [51014] by abarth@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move WorkQueue to its own file
​https://bugs.webkit.org/show_bug.cgi?id=31529

WorkQueue and WorkQueueDelegate are separate concerns from
bugzilla-tool. Also added a missing include to logging.py.

  • Scripts/bugzilla-tool:
  • Scripts/modules/logging.py:
  • Scripts/modules/workqueue.py:
12:11 AM Changeset in webkit [51013] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Siedel.

Move OutputTee to logging.py.

  • Scripts/bugzilla-tool:
  • Scripts/modules/logging.py:
12:07 AM Changeset in webkit [51012] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor bugzilla-tool to allow for multiple queues
​https://bugs.webkit.org/show_bug.cgi?id=31513

Divide the commit queue class into three class to make creating
additional queues easier.

  • Scripts/bugzilla-tool:

Nov 15, 2009:

10:19 PM Changeset in webkit [51011] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Fixing broken layout test.

Need to implement ARIA role="directory"
​https://bugs.webkit.org/show_bug.cgi?id=31516

Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
10:02 PM Changeset in webkit [51010] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2009-11-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

svn-apply may not handle git patches created by bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=31457

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
8:44 PM Changeset in webkit [51009] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2009-11-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Correct an error in the previous commit

  • public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory, not WebAccessibilityDirectoryRole.
7:48 PM Changeset in webkit [51008] by Dimitri Glazkov
  • 3 edits in trunk/WebKit/chromium

2009-11-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Bring WebAccessibilityRole up to sync after
​http://trac.webkit.org/changeset/51007.

  • public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
  • src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and WebAccessibilityRoleDirectory.
6:05 PM Changeset in webkit [51007] by Chris Fleizach
  • 10 edits
    2 adds in trunk

Need to implement ARIA role="directory"
​https://bugs.webkit.org/show_bug.cgi?id=31516

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-directory.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isOrderedList):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::createARIARoleMap):

WebKit/mac:

Fix a spelling error in the comment of a localized (accessibility) string.

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

LayoutTests:

  • platform/mac/accessibility/aria-directory-expected.txt: Added.
  • platform/mac/accessibility/aria-directory.html: Added.
3:34 PM Changeset in webkit [51006] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-15 Dave Tapuska <​dtapuska@rim.com>

Reviewed by George Staikos.


Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp

​https://bugs.webkit.org/show_bug.cgi?id=31475


  • platform/text/StringHash.h: (WebCore::StringHash::equal):
3:32 PM Changeset in webkit [51005] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

bugzilla-tool should post git binary diff
​https://bugs.webkit.org/show_bug.cgi?id=31458

Add --binary option to Git.create_patch.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
3:29 PM Changeset in webkit [51004] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-15 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.

​https://bugs.webkit.org/show_bug.cgi?id=31490

  • bindings/v8/V8DOMWrapper.cpp:
3:28 PM Changeset in webkit [51003] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-15 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.

  • platform/haiku/FileChooserHaiku.cpp:
3:26 PM Changeset in webkit [51002] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-15 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

[Haiku] Build fix. ColorSpace name had a wrong CamelCase.

  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
3:24 PM Changeset in webkit [51001] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add bugzilla-tool check-style
​https://bugs.webkit.org/show_bug.cgi?id=31515

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
3:15 PM Changeset in webkit [51000] by dbates@webkit.org
  • 8 edits in trunk/WebCore

2009-11-15 Daniel Bates <​dbates@webkit.org>

No review, rolling out r50999.
​http://trac.webkit.org/changeset/50999

Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setUserEdited): (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited): (WebCore::RenderTextControl::isUserEdited):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
2:55 PM Changeset in webkit [50999] by dbates@webkit.org
  • 8 edits in trunk/WebCore

2009-11-15 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
Note: See TracTimeline for information about the timeline view.