Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 13, 2013:

11:52 PM Changeset in webkit [150056] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

Make -[WebNavigationData url] the destination of the navigation
​https://bugs.webkit.org/show_bug.cgi?id=114904

Reviewed by Dave Kilzer.

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with the
current URL, not the original request URL.

10:42 PM Changeset in webkit [150055] by eric.carlson@apple.com

• 6 edits in trunk/Source/WebCore

[Mac] update in-band caption attributes
​https://bugs.webkit.org/show_bug.cgi?id=116057

Reviewed by Dean Jackson.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::updateCueFromCueData): Copy highlight color.

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): "highlight" color sets the cue

background, "background" color sets the cue container background.

• html/track/TextTrackCueGeneric.h:

• platform/graphics/InbandTextTrackPrivateClient.h:

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process "highlight" color.

9:09 PM Changeset in webkit [150054] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r150049): Fix RetainPtr<> type in PasteboardIOS.mm

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeImage): Use RetainPtr<CFStringRef>
instead of RetainPtr<NSString>.

9:04 PM Changeset in webkit [150053] by benjamin@webkit.org

• 13 edits
  1 delete in trunk/Source/WebCore

Remove platform/graphic's Generator
​https://bugs.webkit.org/show_bug.cgi?id=116084

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-13
Reviewed by Darin Adler.

The Generator no longer abstract anything useful, its only
implementation is Gradient.

• GNUmakefile.list.am:
• WebCore.exp.in:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/GeneratedImage.h:
• platform/graphics/Generator.h: Removed.
• platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):

• platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
(GeneratorGeneratedImage):

• platform/graphics/Gradient.h:

(WebCore):
(Gradient):

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):

• platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

8:36 PM Changeset in webkit [150052] by ryuan.choi@samsung.com

• 2 edits
  2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several tests which already passed and add png expected results.

• platform/efl/TestExpectations:
• platform/efl/editing/selection/doubleclick-crash-expected.png: Added.
• platform/efl/editing/selection/select-missing-image-expected.png: Added.

8:20 PM Changeset in webkit [150051] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Nightly build's jsc doesn't work without DYLD_FRAMEWORK...
​https://bugs.webkit.org/show_bug.cgi?id=79065

Patch by Alvaro Lopez Ortega <​alvaro@alobbs.com> on 2013-05-13
Reviewed by Darin Adler.

Fixes the build process so the depencencies of the jsc binary are
modified before its copied to its target directory. In this way
jsc should always use relative reference to the JavaScriptCore
libraries.

• JavaScriptCore.xcodeproj/project.pbxproj: Fixes the commands in

the "Copy Into Framework" target.

7:49 PM Changeset in webkit [150050] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Objective-C API: scanExternalObjectGraph should not create new JSVirtualMachine wrappers
​https://bugs.webkit.org/show_bug.cgi?id=116074

If scanExternalObjectGraph creates a new JSVirtualMachine wrapper during collection, when the
scanExternalObjectGraph call finishes and the autorelease pool is drained we will dealloc the
JSVirtualMachine which will cause us to try to take the API lock for the corresponding VM.
If this happens on a GC thread other than the "main" thread, we will deadlock. The solution
is to just check the VM cache, and if there is no JSVirtualMachine wrapper, return early.

Reviewed by Darin Adler.

• API/JSVirtualMachine.mm:

(scanExternalObjectGraph):

7:21 PM Changeset in webkit [150049] by ddkilzer@apple.com

• 4 edits
  3 adds in trunk/Source/WebCore

Upstream iOS Clipboard and Pasteboard changes
<​http://webkit.org/b/116062>

Reviewed by Darin Adler.

• WebCore.xcodeproj/project.pbxproj:
• dom/Clipboard.h:
• platform/Pasteboard.h:
• platform/ios/ClipboardIOS.h: Added.
• platform/ios/ClipboardIOS.mm: Added.
• platform/ios/PasteboardIOS.mm: Added.

7:14 PM Changeset in webkit [150048] by allan.jensen@digia.com

• 2 edits in trunk/LayoutTests

compositing/transitions/transform-on-large-layer.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=110099

Reviewed by Darin Adler.

Only set the timeout for test end after the resize event has been
received. This helps slow test bots, and also makes it easier to
tell rendering failures from failures to send resize event.

• compositing/transitions/transform-on-large-layer.html:

7:11 PM Changeset in webkit [150047] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Mac] Use pageScaleFactor * deviceScaleFactor in requiresTiledLayer() and computePixelAlignment() of GraphicsLayerCA.
​https://bugs.webkit.org/show_bug.cgi?id=107359

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-05-13
Reviewed by Darin Adler.

Currently GraphicsLayerCA uses pageScaleFactor in requiresTiledLayer() and
computePixelAlignment(), but we must use pageScaleFactor * deviceScaleFactor in
them.
It is because:

1. requiresTiledLayer() uses the scale to compute an actual layer size in the device

pixel unit.

2. computePixelAlignment() uses the scale to compute an aligned layer position

in the device pixel unit.

No new tests. We can not test about requiresTiledLayer() because it depends on
gpu. computePixelAlignment() is correct now because fortunately Mac uses
only 2 (for retina display) as a deviceScaleFactor.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::computePixelAlignment):

7:00 PM Changeset in webkit [150046] by commit-queue@webkit.org

• 12 edits in trunk

Added testRunner.setPrinting.
​https://bugs.webkit.org/show_bug.cgi?id=42693
rdar://problem/8213845

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-13
Reviewed by Darin Adler.

Source/WebKit2:

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting): Added.

• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Added WKBundlePageCopyRenderTreeExternalRepresentationForPrinting declaration.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeExternalRepresentationForPrinting): Added.

• WebProcess/WebPage/WebPage.h:

Added renderTreeExternalRepresentationForPrinting declaration.

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Added setPrinting JavaScript function.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
Dump the external representation for printing if setPrinting has been called.

• WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::isPrinting): Added.
(WTR::TestRunner::setPrinting): Added.
Added and initialized m_isPrinting member boolean.

LayoutTests:

• platform/wk2/TestExpectations:

Unskipped printing tests.

5:59 PM Changeset in webkit [150045] by Christophe Dumez

• 27 edits
  3 moves in trunk

Rename BarInfo to BarProp and remove [NoInterfaceObject]
​https://bugs.webkit.org/show_bug.cgi?id=116027

Reviewed by Andreas Kling.

Source/WebCore:

Rename BarInfo to BarProp and remove [NoInterfaceObject] extended attribute from
the IDL interface to match the specification:
​http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop

The new behavior also matches Firefox and Blink.

No new tests, covered by LayoutTests/fast/js/global-constructors-attributes.html.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.order:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/GNUmakefile.am:
• page/BarProp.cpp: Renamed from Source/WebCore/page/BarInfo.cpp.
• page/BarProp.h: Renamed from Source/WebCore/page/BarInfo.h.
• page/BarProp.idl: Renamed from Source/WebCore/page/BarInfo.idl.
• page/DOMWindow.cpp:
• page/DOMWindow.h:
• page/DOMWindow.idl:

LayoutTests:

Rebaseline fast/js/global-constructors-attributes.html now that there is a new
'BarProp' global constructor.

Rebaseline a few other tests now that BarInfo was renamed to BarProp.

• fast/dom/Window/window-lookup-precedence-expected.txt:
• fast/js/global-constructors-attributes-expected.txt:
• fast/loader/window-properties-restored-from-page-cache-expected.txt:
• http/tests/security/cross-frame-access-put-expected.txt:
• platform/efl/fast/js/global-constructors-attributes-expected.txt:
• platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/gtk/fast/js/global-constructors-attributes-expected.txt:
• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
• platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/qt/fast/js/global-constructors-attributes-expected.txt:

4:17 PM Changeset in webkit [150044] by andersca@apple.com

• 6 edits in trunk/Source

Remove ChromeClient::willPopupMenu
​https://bugs.webkit.org/show_bug.cgi?id=116063

Reviewed by Andreas Kling.

Source/WebCore:

Remove ChromeClient::willPopupMenu.

• page/ChromeClient.h:

Source/WebKit/mac:

ChromeClient::willPopupMenu is only called in one place from WebKit, so just move the function to the call site.

• WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::show):

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

4:16 PM Changeset in webkit [150043] by Beth Dakin

• 13 edits in trunk/Source/WebCore

Headers and footers should be pinned to the left edge of the window when scrolling
horizontally
​https://bugs.webkit.org/show_bug.cgi?id=116061
-and corresponding-
<rdar://problem/13599215>

Reviewed by Simon Fraser.

The scrolling thread will need to know about the header and footer layers in order
the implement this custom scrolling behavior.

These getters will fetch the header or footer layer from the FrameView as
appropriate.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):

• page/scrolling/ScrollingCoordinator.h:

When we’re scrolling on the main thread, adjust the position of the header and
footer layers here.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

ScrollingStateScrollingNode now stores GraphicsLayers and PlatformLayers for the
header and footer, just like it already does for the counterScrollingLayer.

• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

• page/scrolling/ScrollingStateScrollingNode.h:

(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::headerLayer):
(WebCore::ScrollingStateScrollingNode::footerLayer):

Setters for the new layers.

• page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::setHeaderLayerForNode):
(WebCore::ScrollingCoordinatorMac::setFooterLayerForNode):

These setters and getters mirror the existing one for counterScrollingLayer.

• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::headerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::footerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):

And the ScrollingTree will store CALayers for the header and footer.

• page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:

(ScrollingTreeScrollingNodeMac):

• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):

This is where the magic happens when we are scrolling on the scrolling thread.
Adjust the horizontal position the behave like a fixed object, but keep the
vertical position what it was when layer was created.
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

RenderLayerCompositor must now provide getters for the header and footer.

• rendering/RenderLayerCompositor.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::headerLayer):
(WebCore::RenderLayerCompositor::footerLayer):

Set the anchor point for when we adjust the position later on. Also call
frameViewRootLayerDidChange() to get the new layers picked up and sent to the
scrolling tree.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):

4:11 PM Changeset in webkit [150042] by benjamin@webkit.org

• 8 edits in trunk/Source

Improve stringProtoFuncLastIndexOf for the prefix case
​https://bugs.webkit.org/show_bug.cgi?id=115952

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLastIndexOf):
Use the optimized string search when possible.

On Joseph Pecoraro's tests, this gives a ~30% speed improvement.

Source/WTF:

Add an optimized version of StringImpl::startsWith() for JavaScriptCore.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::startsWith):

• wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::startsWith):

• wtf/text/WTFString.h:

(WTF::String::startsWith):

2:53 PM Changeset in webkit [150041] by timothy@apple.com

• 32 edits in trunk/Source

Add support for updating the Web Inspector toolbar height.

​https://bugs.webkit.org/show_bug.cgi?id=115996

Reviewed by Joseph Pecoraro and Benjamin Poulain.

Source/WebCore:

• inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setToolbarHeight):

• inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

• inspector/InspectorFrontendHost.idl:
• testing/Internals.cpp:

Source/WebKit/efl:

• WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorFrontendClientEfl::setToolbarHeight):

• WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

• WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorFrontendClient::setToolbarHeight):

• WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::setToolbarHeight):

Source/WebKit/qt:

• WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::setToolbarHeight):

• WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::setToolbarHeight):

• WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

• UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::setToolbarHeight):
(WebInspectorProxy):

• UIProcess/WebInspectorProxy.messages.in:
• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):
(WebKit):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

• UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

• WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::setToolbarHeight):

• WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::setToolbarHeight):

• WebProcess/WebPage/WebInspector.h:

2:29 PM Changeset in webkit [150040] by dino@apple.com

• 4 edits
  2 adds in trunk

toDataURL can return an empty image in some cases
​https://bugs.webkit.org/show_bug.cgi?id=115981
<rdar://problem/13760256>

Reviewed by Darin Adler.

Source/WebCore:

In some accelerated rendering cases, calling toDataURL on
an off-screen canvas produced an empty image. The solution
was to force a CGContextFlush before extracting the data
for image generation.

While here, I collected the flushing code from other methods
into a single place. Also we were getting into a situation where
we called flush two times in a row.

Test: fast/canvas/toDataURL-not-empty.html

• platform/graphics/ImageBuffer.h:

(ImageBuffer): Define two new methods flushContext and flushContextIfNecessary.

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::context): Call flushContextIfNecessary.
(WebCore::ImageBuffer::flushContextIfNecessary): Moved the 10.7 code in here.
(WebCore::ImageBuffer::flushContext): Calls CGContextFlush.
(WebCore::ImageBuffer::getUnmultipliedImageData): Call new helper.
(WebCore::ImageBuffer::getPremultipliedImageData): Call new helper.
(WebCore::ImageBuffer::toDataURL): Flush the CG context.

LayoutTests:

Make sure that a canvas with content is not the same as one
without content.

• fast/canvas/toDataURL-not-empty-expected.txt: Added.
• fast/canvas/toDataURL-not-empty.html: Added.

2:27 PM Changeset in webkit [150039] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/table/crash-split-table-section-no-cell-recalc.html as crashing
on EFL port.

• platform/efl/TestExpectations:

2:02 PM Changeset in webkit [150038] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

Regressions in flexbox layout caused by the flexing optimizations.
​https://bugs.webkit.org/show_bug.cgi?id=116058
<rdar://problem/13863647>

Reviewed by Beth Dakin.

Roll out the flex-related changes from r149597 so that the layout
algorithm goes back to the way it was. Leave the repainting optimizations
in place though.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

1:43 PM Changeset in webkit [150037] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several tests that stopped crashing after r150030.

• platform/efl-wk2/TestExpectations:

1:39 PM Changeset in webkit [150036] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/css/variables/var-inside-shape.html as failing on EFL after
r150025.

• platform/efl/TestExpectations:

1:29 PM Changeset in webkit [150035] by Philippe Normand

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r150014.
​http://trac.webkit.org/changeset/150014
​https://bugs.webkit.org/show_bug.cgi?id=86410

Broke video playback on WK2 and some webgl tests

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(MediaPlayerPrivateGStreamerBase):

1:07 PM Changeset in webkit [150034] by rniwa@webkit.org

• 4 edits in trunk/Source

Sometimes NSUndoManager can get into an inconsistent state
​https://bugs.webkit.org/show_bug.cgi?id=116050

Reviewed by Enrica Casucci.

Always group undo items to work around a bug in NSUndoManager that manifests
when we call removeAllActionsWithTarget.

Source/WebKit/mac:

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::registerUndoOrRedoStep):

Source/WebKit2:

• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):

1:06 PM Changeset in webkit [150033] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/animation/request-animation-frame-too-rapid.html as failing on EFL WK2
due to r150015.

• platform/efl-wk2/TestExpectations:

12:37 PM Changeset in webkit [150032] by hmuller@adobe.com

• 9 edits
  6 adds
  2 deletes in trunk/LayoutTests

[CSS Exclusions] Simple shape-outside tests fail when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115767

Reviewed by Dirk Schulze.

The overall goal of this change was to restore the (last) four excluded exclusions ref-tests
by making them work correctly when subpixel layout is disabled. All of the tests were
substantially simplified, as was the supporting javascript code. The original
shape-outside-floats-simple-rounded-rectangle test was replaced by three separate tests
because the original was bigger then then the 800x600 limit and because it unncessarily
combined three indepedent test cases.

• fast/exclusions/resources/rounded-rectangle.js:

(ellipseXIntercept): Return the 1st quadrant X intercept for an ellipse given a first quadrant Y intercept.
(scanConvertRoundedRectangleOutside): Return the line segment intervals that overlap a rounded rectangle.
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Insert a stack of float divs that match the left or right edge of a rounded rectangle.

• fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Removed.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Removed.
• platform/mac/TestExpectations:

12:35 PM Changeset in webkit [150031] by Christophe Dumez

• 4 edits
  2 deletes in trunk

Unreviewed, rolling out r150022.
​http://trac.webkit.org/changeset/150022
​https://bugs.webkit.org/show_bug.cgi?id=114044

Causes assertions in media tests

Source/WebCore:

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

LayoutTests:

• media/video-seek-after-end-expected.txt: Removed.
• media/video-seek-after-end.html: Removed.

12:31 PM Changeset in webkit [150030] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

[WK2] Crash in WebKit::StorageAreaMap::didSetItem()
​https://bugs.webkit.org/show_bug.cgi?id=116026

Reviewed by Andreas Kling.

Make sure that we ignore any leftover messages from the UI process after we've reset
the storage map. Achieve this by keeping a seed count in the StorageAreaMap object that's incremented
everytime the map is reset. Associate every storage area change with the seed and ignore any incoming
notification messages from the UI process if the seeds are different.

• Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/Storage/StorageManager.messages.in:
• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::resetValues):
(WebKit::StorageAreaMap::loadValuesIfNeeded):
(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::didRemoveItem):
(WebKit::StorageAreaMap::didClear):
(WebKit::StorageAreaMap::applyChange):

• WebProcess/Storage/StorageAreaMap.h:

(StorageAreaMap):

• WebProcess/Storage/StorageAreaMap.messages.in:

12:30 PM Changeset in webkit [150029] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Source/WebCore: Floats should not overhang from flex items
​https://bugs.webkit.org/show_bug.cgi?id=115925

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.

Allowing floats to overhand from flex items is not only against the
spec, it causes bad bugs. Fix this by having flex items properly avoid
floats.

Test: fast/block/float/float-not-removed-crash2.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::avoidsFloats): Add flex items to avoid floats.

• rendering/RenderBox.h:

(WebCore::RenderBox::isFlexItemIncludingDeprecated): Determine if the current box is a

flex item or deprecated flex item.

LayoutTests: Fix the float logic to not return an anonymous block ancestor
​https://bugs.webkit.org/show_bug.cgi?id=115925

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.

Cleaned up fuzzer test. Note that this will only crash when run under
a memory checker like ASAN.

• fast/block/float/float-not-removed-crash2-expected.txt: Added.
• fast/block/float/float-not-removed-crash2.html: Added.

12:23 PM Changeset in webkit [150028] by Csaba Osztrogonác

• 2 edits in trunk/Tools

[webkitpy] Make FileInfo.repository_name support SVN version > 1.6
​https://bugs.webkit.org/show_bug.cgi?id=116016

Reviewed by Dirk Pranke.

Same fix as in the upstream style checker, but without hg support.
( ​http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )

• Scripts/webkitpy/style/checkers/cpp.py:

(FileInfo.repository_name):

12:11 PM Changeset in webkit [150027] by zoltan@webkit.org

• 10 edits
  1 copy
  13 adds in trunk

[CSS Regions][CSS Exclusions] Shape-inside on regions should respect region borders and paddings
​https://bugs.webkit.org/show_bug.cgi?id=115456

Reviewed by David Hyatt.

I refactored the computation logic of shape-inside on regions by removing access to RenderFlowThread from ExclusionShapeInfo's logicalTopOffset
function, this means all the logic is now existing in RenderBlockLineLayout.cpp. By modifying the logicalTopOffset it turned out that the borders
and padding hadn't worked correctly, since borders and paddings were counted twice in the shape-inside's computation. This patch adds the necessary
modifications to let it respect the borders and padding in the correct way. I created 2 new helper functions to prevent increasing the code size of
the layoutRunsAndFloatsInRange function.

Source/WebCore:

I introduced 7 new tests to test for testing the correct behavior.

Tests: fast/regions/shape-inside/shape-inside-on-first-region-block-content.html

fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-second-region-block-content.html
fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content.html
fast/regions/shape-inside/shape-inside-with-region-borders.html
fast/regions/shape-inside/shape-inside-with-region-padding.html

• rendering/ExclusionShapeInfo.cpp:

(WebCore): Remove FlowThread logic from logicalTopOffset move definition to header.

• rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::logicalTopOffset): Moved from cpp.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Add condition for RenderRegions.

• rendering/RenderBlock.h:

(RenderBlock): Add definition to the new helper members.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Modified the flow thread case to return the appropriate region.
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Added new helper function. Modify the shape-inside on regions
line boundaries and position computation logic.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Added new helper function which handles the flow thread case also.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified the code to use the helper functions.

LayoutTests:

• fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Modify to not use shape-inside for testing.
• fast/regions/shape-inside/shape-inside-on-additional-regions.html: Fix the shape-inside's dimension.
• fast/regions/shape-inside/shape-inside-on-first-region-block-content-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-first-region-block-content.html: Added.
• fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html: Added.
• fast/regions/shape-inside/shape-inside-on-regions-expected.html: Match the shape-inside height to the container's height.
• fast/regions/shape-inside/shape-inside-on-regions-inline-content-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-regions.html: Match the shape-inside height to the container's height.
• fast/regions/shape-inside/shape-inside-on-second-region-block-content-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-second-region-block-content.html: Added.
• fast/regions/shape-inside/shape-inside-on-second-region-inline-content-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html: Added.
• fast/regions/shape-inside/shape-inside-with-region-borders-expected.html: Added.
• fast/regions/shape-inside/shape-inside-with-region-borders.html: Added.
• fast/regions/shape-inside/shape-inside-with-region-padding-expected.html: Added.
• fast/regions/shape-inside/shape-inside-with-region-padding.html: Added.

12:06 PM Changeset in webkit [150026] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit/win

Unreviewed. AppleWin VS2005 build fix.

• WebKit.vcproj/WebKitExports.def.in:

11:37 AM Changeset in webkit [150025] by betravis@adobe.com

• 3 edits
  2 adds in trunk

[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
​https://bugs.webkit.org/show_bug.cgi?id=115919

Reviewed by Dean Jackson.

Source/WebCore:

Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default
to true. CSS Exclusions can still be enabled / disabled in platforms by
setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files.

Test: fast/exclusions/css-exclusions-enabled.html

• bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

LayoutTests:

Adding a test to make sure CSS Exclusions can be enabled, and are enabled by
default.

• fast/exclusions/css-exclusions-enabled-expected.txt: Added.
• fast/exclusions/css-exclusions-enabled.html: Added.

11:24 AM Changeset in webkit [150024] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] Avoid dispensable calls to WebView::updateViewportSize()
​https://bugs.webkit.org/show_bug.cgi?id=116045

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Darin Adler.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setSize):

11:16 AM Changeset in webkit [150023] by commit-queue@webkit.org

• 30 edits
  3 adds in trunk

Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows
​https://bugs.webkit.org/show_bug.cgi?id=52185

Patch by Suchit Agrawal <​a.suchit@samsung.com> on 2013-05-13
Reviewed by David Hyatt.

Source/WebCore:

Cells heights are not proper when rowspan cell have its own height and rowspan height
is more than the height of the rows present in rowspan.

After calculating logical height of the rows in the table, we are recalculating the height
of the rows present in rowspan. Based on the ratio of row's logical height, we are
distributing rowspan cell height in rows.

Test: fast/table/table-rowspan-height-distribution-in-rows.html

• rendering/RenderTableSection.cpp:

(WebCore):

Update the logical height of the rows based on rowspan cell height.
(WebCore::RenderTableSection::distributeRowSpanHeightToRows):

It calculates logical height of the rows in the table.
(WebCore::RenderTableSection::calcRowLogicalHeight):

Added new private API to distribute rowSpan cell height in rows.

• rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Test case updated.

• fast/css/vertical-align-baseline-rowspan-007.htm:

Reference Test cases updated.

• fast/css/vertical-align-baseline-rowspan-007-expected.html:
• fast/css/vertical-align-baseline-rowspan-008-expected.html:

Added test cases based on changes in the code and different scenarios for rowspan height
distribution in rows.

• fast/table/table-rowspan-height-distribution-in-rows.html: Added.
• platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.png: Added.
• platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Added.

Test cases need to rebaseline in qt, efl, gtk and mac platforms.

• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:

Test case results are updated in qt platform.

• platform/qt/tables/mozilla/bugs/bug17548-expected.png:
• platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
• platform/qt/tables/mozilla/bugs/bug220536-expected.png:
• platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
• platform/qt/tables/mozilla/bugs/bug7714-expected.png:
• platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
• platform/qt/tables/mozilla/core/bloomberg-expected.png:
• platform/qt/tables/mozilla/core/bloomberg-expected.txt:
• platform/qt/tables/mozilla/other/test6-expected.png:
• platform/qt/tables/mozilla/other/test6-expected.txt:
• platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
• platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
• platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
• platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
• platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
• platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
• platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
• tables/mozilla/core/bloomberg-expected.txt:
• tables/mozilla_expected_failures/bugs/bug23847-expected.txt:

10:07 AM Changeset in webkit [150022] by kbalazs@webkit.org

• 4 edits
  2 adds in trunk

[GStreamer] cannot seek after video finished
​https://bugs.webkit.org/show_bug.cgi?id=114044

Patch by Balazs Kelemen <​b.kelemen@sisa.samsung.com> on 2013-04-30
Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-seek-after-end.html

Rework the seeking logic to be able to seek after reseting the pipeline.
In addition to solve the actual problem this patch supposed to make seeking
more robust and correct.
The previous implementation tried to hide the complexity of asynchronous operations
on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus
but instead reported the seek as finished when it saw an asynchronous pending state
(GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done.
Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks.
Seeks are not the only operations executed asynchronously, changing the pipeling state is
similar. It means a seek can overlap with onother ongoing asynchronous operation.
This change address this by introducing an invariant for seeks, which is that we only request
a seek if there are no other ongoing asynchronous operations and the pipeline state is either
paused or playing (which is recommended anyway according to GStreamer's documentation).
This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the
seek has been completed.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::toGstClockTime): Factored time conversation into a helper.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available
if the pipeline still has a pending state. As a workaround, if we are right after a seek we can
use the seek time. Avoiding this situation would be possible by not allowing any asynchronous
operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce
this workaround. Otherwise those overlapping operations are handled fine by GStreamer.

(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables.
This function called when there is an intent to restart playback but it does not actually restart it.
(WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline.
(WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that.
If there is an ongoing asynchronous operation make the seek pending, otherwise do it now.
Now we handle overlapping seeks as well because I saw that it can happen in some tests.
Added an early return for live streams as it doesn't makes sense to try seeking in them.

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring.
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is
now handled in asyncStateChangeDone.
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline
has an asynchronous pending state because it would fail. It does actually happen when we get a duration message
after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug
in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

LayoutTests:

• media/video-seek-after-end-expected.txt: Added.
• media/video-seek-after-end.html: Added.

9:44 AM Changeset in webkit [150021] by jocelyn.turcotte@digia.com

• 2 edits in trunk/Source/WebKit/qt

[Qt] Fix a crash on startup in FrameLoaderClientQt::callPolicyFunction with MSVC

Reviewed by Allan Sandfeld Jensen.

It's not clear why it crashes, but here's my guess by looking at the generated
assembly code:
Since we're using a member function pointer to PolicyChecker, the representation
is not necessarily just a simple pointer and might be a bigger structure used
to handle virtual functions resolution.
For a function taking such a function "pointer" as parameter, the compiler doesn't
seem to have the caller and callee agree on which convention to use if the function
pointer's class is non-virtual and only one of the ends doesn't know about it.

Including the definition of the member function pointer's class fixes the crash.

• WebCoreSupport/FrameLoaderClientQt.cpp:

9:19 AM Changeset in webkit [150020] by jonlee@apple.com

• 3 edits in trunk/Source/WebKit2

[WK2] Notification manager removal should not be tied to termination of web processes
​https://bugs.webkit.org/show_bug.cgi?id=116038
<rdar://problem/10968680>

Reviewed by Ryosuke Niwa.

WebNotificationManagerProxy incorrectly removes the manager when web processes close.
Since it is a supplemental on the web context, the manager should only be removed
when the context is destroyed.

• UIProcess/Notifications/WebNotificationManagerProxy.cpp:
• UIProcess/Notifications/WebNotificationManagerProxy.h: Remove implementation of

processDidClose().

9:19 AM Changeset in webkit [150019] by Carlos Garcia Campos

• 2 edits in trunk/Source/WTF

Unreviewed. Fix Qt Linux MIPS32R2 build after r149879.

Bring back GLIB_CHECK_VERSION for GBytes since Qt Linux MIPS32R2
depends on glib 2.24.2.

• wtf/gobject/GRefPtr.cpp:

(_GBytes):
(WTF::refGPtr):
(WTF::derefGPtr):

8:45 AM Changeset in webkit [150018] by Martin Robinson

• 3 edits
  2 adds in trunk/Source/WebKit2

[GTK] [WebKit2] Use a template file for generated GObject enum files
​https://bugs.webkit.org/show_bug.cgi?id=115867

Reviewed by Carlos Garcia Campos.

• GNUmakefile.am: Use a template file instead of specifying portions of the file on the command-line.
• UIProcess/API/gtk/WebKitEnumTypes.cpp.template: Added.
• UIProcess/API/gtk/WebKitEnumTypes.h.template: Added.
• UIProcess/API/gtk/WebKitFindController.cpp: We can no longer rely on WebKitEnumTypes.h to pull in WebKitWebView.h.

8:45 AM Changeset in webkit [150017] by akling@apple.com

• 1 edit in trunk/Source/WebKit/mac/ChangeLog

Remove accidental unrelated ChangeLog entry from r150016.

8:29 AM Changeset in webkit [150016] by Darin Adler

• 6 edits in trunk/Source

Source/WebCore: [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116009

Reviewed by Andreas Kling.

• dom/Clipboard.cpp:

(WebCore::Clipboard::writeRange): Added. Moved from ClipboardMac,
but added some FIXMEs.
(WebCore::Clipboard::writePlainText): Ditto.
(WebCore::Clipboard::writeURL): Ditto.

• dom/Clipboard.h: Made writeURL, writeRange, and writePlainText

non-virtual in non-legacy clipboard implementations.

• platform/mac/ClipboardMac.h: Removed writeRange, writeURL, and

writePlainText.

• platform/mac/ClipboardMac.mm: Ditto.

Source/WebKit/mac: [Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
​https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>

Reviewed by Andreas Kling.

• WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.

8:29 AM Changeset in webkit [150015] by commit-queue@webkit.org

• 10 edits in trunk/Source

[CoordGfx] requestAnimationFrame performance issues
​https://bugs.webkit.org/show_bug.cgi?id=112345

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-13
Reviewed by Jocelyn Turcotte.

Source/WebCore:

Removed current requestAnimationFrame logic from CoordinatedGraphics. The new logic
is entirely in WebKit2 CoordinatedLayerTreeHost.

Covered by existing tests in fast/animations.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Changed the logic of requestAnimationFrame in Coordinated Graphics.
We don't send any IPC messages for requestAnimationFrame. Instead, we do one of two things:

• If there is already a frame pending in the UI process, do nothing, as the animations would be serviced when the frame is returned to the web process.
• If there is no frame pending, we schedule a flush, making sure that that flush occurs at least 1/60 seconds after the last animation service, so that we don't get an infinite loop of flushes.

• UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::requestAnimationFrame):

• UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:

8:14 AM Changeset in webkit [150014] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[texmap][GStreamer] Composited Video support
​https://bugs.webkit.org/show_bug.cgi?id=86410

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-05-13
Reviewed by Philippe Normand.

Enable the video accelerated compositing using the WebKit's
TextureMapper.

This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.

No new tests, already covered by existing tests.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true

8:05 AM Changeset in webkit [150013] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Document: Use a DeferrableOneShotTimer to throw out StyleResolver when unused.
<​http://webkit.org/b/115929>

Reviewed by Anders Carlsson.

Nothing exciting here, just replacing a rickety-looking punting mechanism with a proper
DeferrableOneShotTimer. Note that the timeout changes from 60 to 30 seconds because DOST
works by punting a full interval on next timeout.

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAccessStyleResolver):
(WebCore::Document::styleResolverThrowawayTimerFired):

• dom/Document.h:

(Document):

7:59 AM Changeset in webkit [150012] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] WKView needs API for handling opacity
​https://bugs.webkit.org/show_bug.cgi?id=116032

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Kenneth Rohde Christiansen.

Add WKViewSetOpacity and WKViewOpacity APIs and use them in
WebView.cpp.

• UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewSetOpacity):
(WKViewOpacity):

• UIProcess/API/C/CoordinatedGraphics/WKView.h:
• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::paintToCurrentGLContext):

• UIProcess/CoordinatedGraphics/WebView.h:

(WebKit::WebView::setOpacity):
(WebKit::WebView::opacity):
(WebView):

7:55 AM Changeset in webkit [150011] by akling@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION(r149287): FoldingText only shows me half of my text.
<​http://webkit.org/b/115956>
<rdar://problem/13831099>

Reviewed by Antti Koivisto.

Check if the FrameView geometry changed post-layout, and send a resize event if needed.
This brings us closer to the original resize event behavior, with the exception that
setFrameRect() still fires an event right away if possible. This means we are still
guarded from FOUC's but frames that layout via [WebHTMLView layoutToMinimumPageWidth]
also get resize events like they used to.

No new tests, because I don't know how to test this.

• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):

Factor out the resize event logic from setFrameRect() so we can call it from both
there and performPostLayoutTasks(). sendResizeEventIfNeeded() only sends an event
if view geometry or zoom factor has changed since last time it was called.

7:26 AM Changeset in webkit [150010] by Antti Koivisto

• 10 edits in trunk/Source

Remove unneeded counters from ScopeContentDistribution.
​https://bugs.webkit.org/show_bug.cgi?id=116028

Reviewed by Andreas Kling.

They don't do much.

• WebCore.exp.in:
• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

• dom/ShadowRoot.h:

No need for registration code anymore.

• html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::ScopeContentDistribution):

Default m_insertionPointListIsValid to true to avoid crawling when there are no InsertionPoints.

(WebCore::ScopeContentDistribution::ensureInsertionPointList):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):

• html/shadow/ContentDistributor.h:

Remove distributeNodeChildrenTo, it was only used by the older/younger shadow root code.

• testing/Internals.cpp:
• testing/Internals.h:
• testing/Internals.idl:

7:10 AM EFLHistoryApiTutorial edited by saulo@gmx.com

(diff)

7:03 AM Changeset in webkit [150009] by commit-queue@webkit.org

• 2 edits
  1 delete in trunk/PerformanceTests

Web Inspector: Get rid of native-memory-snapshot in performance test
​https://bugs.webkit.org/show_bug.cgi?id=116013

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Andreas Kling.

Remove native-memory-snapshot.html from PerformanceTests.

• inspector/native-memory-snapshot.html: Removed.
• inspector/performance-test.js:

(initialize_TimeTracker.Timer):
(initialize_TimeTracker.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

6:55 AM Changeset in webkit [150008] by zandobersek@gmail.com

• 4 edits in trunk

[GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
​https://bugs.webkit.org/show_bug.cgi?id=115918

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Due to layer violations and circular dependencies the WebKitPluginProcess requires for the
libraries containing the built code of the intertwining Platform and WebCore layers to be
specified multiple times when linking. This can be avoided by packing the two layers' archives
into one big archive, named after the WebCore layer due to no clear boundary between it and the
Platform layer. The big archive can then be specified only once when linking, simplifying the code
and suppressing all the layering violations so they do not cause build problems.

First the libtool libraries that the WebCore layer (as required by the WebKitPluginProcess) depends on
are specified. These are then used as dependencies for the archive creation rule as well as the list
from which the archive file paths are constructed and then used to dump the member files from these archives.
The member files are then added to the big archive. The latter is added to the list of libraries the
WebKitPluginProcess requires to successfully link.

• GNUmakefile.am:

Tools:

Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
when linking, simplifying the code and suppressing all the layering violations so they do not cause build
problems.

First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
These are then used as dependencies for the archive creation rule as well as the list from which the archive
file paths are constructed and then used to dump the member files from these archives. The member files are
then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
successfully link.

• TestWebKitAPI/GNUmakefile.am:

6:52 AM Changeset in webkit [150007] by andersca@apple.com

• 11 edits
  1 delete in trunk

Remove UnusedParam.h
​https://bugs.webkit.org/show_bug.cgi?id=116029

Reviewed by Andreas Kling.

Source/WTF:

Remove UnusedParam.h, it's empty now.

• GNUmakefile.list.am:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/UnusedParam.h: Removed.

Tools:

Stop including UnusedParam.h.

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
• WebKitTestRunner/qt/TestInvocationQt.cpp:

6:14 AM Changeset in webkit [150006] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.0.2

Tagging the WebKitGTK+ 2.0.2 release

5:30 AM Changeset in webkit [150005] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 2.0.2 release.

.:

• Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

• NEWS: Added release notes for 2.0.2.

4:32 AM Changeset in webkit [150004] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several test cases as crashing on EFL port.

• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

4:08 AM Changeset in webkit [150003] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 ref tests as failing on EFL port.

• platform/efl/TestExpectations:

4:00 AM Changeset in webkit [150002] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip 2 HTTP tests that time out of EFL port.

• platform/efl/TestExpectations:

3:53 AM Changeset in webkit [150001] by Christophe Dumez

• 1 edit
  6 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Provide EFL baselines for several compositing test cases.

• platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
• platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
• platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
• platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.

3:50 AM Changeset in webkit [150000] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Web Inspector: Remove unused references from projects in Visual Studio
​https://bugs.webkit.org/show_bug.cgi?id=116002

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Csaba Osztrogonác.

nativeMemoryProfiler.css and NativeMemorySnapshotView.js were removed in r149807.

No new tests, no behavior change.

• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

1:53 AM Changeset in webkit [149999] by commit-queue@webkit.org

• 20 edits in trunk

WebProcess consuming very high CPU on linkedin.com
​https://bugs.webkit.org/show_bug.cgi?id=115601

Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-13
Reviewed by Andreas Kling.

Disable WEB_TIMING_MINIMAL.
Turn off window.performance and performance.now(). Some JS frameworks expect
additional Web Timing APIs, when performance.now() is available.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• dom/EventTargetFactory.in:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore):

• page/DOMWindow.h:

(DOMWindow):

• page/DOMWindow.idl:
• page/Performance.cpp:

(WebCore::Performance::timing):

• page/Performance.h:

(Performance):

• page/Performance.idl:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

LayoutTests:

• platform/mac/TestExpectations:
• fast/js/global-constructors-attributes-expected.txt:

1:37 AM Changeset in webkit [149998] by Darin Adler

• 2 edits in trunk/Source/WebKit/mac

[Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
​https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>

Reviewed by Dan Bernstein.

• WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.

12:55 AM Changeset in webkit [149997] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r149666 - [GTK] Initialize WebKitWebPlugin path to prevent double-free
​https://bugs.webkit.org/show_bug.cgi?id=115624

Patch by Tomas Popela <​tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.

Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.

• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):

• webkit/webkitwebpluginprivate.h:

12:46 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:43 AM Changeset in webkit [149996] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r149735 - [GStreamer] Does memory buffering even with preload set to none
​https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

12:33 AM Changeset in webkit [149995] by kadam@inf.u-szeged.hu

• 1 edit
  6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files.

• platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.
• platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added after r149915.
• platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added after r149915.
• platform/qt-5.0-wk2/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added after r149914.
• platform/qt/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.

12:20 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:17 AM Changeset in webkit [149994] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r149494 - Updated WebKitGTK+ Translation for Odia [or] language.
​https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

• or.po: updated translation.

12:15 AM Changeset in webkit [149993] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r149486 - Segmentation Fault with Romanian locale. Evolution not starting.
​https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

• webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

12:14 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:11 AM Changeset in webkit [149992] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r149192 - [GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
​https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux

12:07 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

May 12, 2013:

11:55 PM Changeset in webkit [149991] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.0

Merge r148840 - [GStreamer] Media attribute preload="none" is not honored
​https://bugs.webkit.org/show_bug.cgi?id=114357

Reviewed by Philippe Normand.

Source/WebCore:

Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.

Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.

LayoutTests:

• http/tests/media/video-preload-expected.txt: Added.
• http/tests/media/video-preload.html: Added.

11:52 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

11:48 PM Changeset in webkit [149990] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.0

Merge r148788 - [GTK] Fix unit test webkit2/WebKitFindController/hide
​https://bugs.webkit.org/show_bug.cgi?id=89810

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-20
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

The test had some hacks in order to compare a page with highlighted
results after using the find command with the original page. Now it uses
the snapshots API that allows to make the test simpler and more
reliable.

• UIProcess/API/gtk/tests/TestMain.h:

(Test::cairoSurfacesEqual): Moved helper function to compare two cairo
surfaces from TestWebKitWebView.
(Test):

• UIProcess/API/gtk/tests/TestWebKitFindController.cpp:

(testFindControllerHide): Modify test to use snapshots.

• UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSnapshot): Move basic snapshop methods to WebViewTest to
share them with TestWebKitFindController test.

• UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest): Initialize cairo surface.
(WebViewTest::~WebViewTest): Destroy cairo surface.
(onSnapshotReady): Callback to set the cairo surface when the snapshot
is ready.
(WebViewTest::getSnapshotAndWaitUntilReady): Method that takes a
snapshot and returns the cairo surface when it is ready.

• UIProcess/API/gtk/tests/WebViewTest.h: Add new method headers and

attribute for the cairo surface.

Tools:

• Scripts/run-gtk-tests:

(TestRunner): Unskip test webkit2/WebKitFindController/hide.

11:40 PM Changeset in webkit [149989] by eric.carlson@apple.com

• 3 edits
  3 adds in trunk

REGRESSION (r149749): Video becomes invisible when it starts playing at newyorkbygehry.com
​https://bugs.webkit.org/show_bug.cgi?id=115963

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/video-remove-insert-repaints.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto): Set m_inActiveDocument when inserted into a document.
(WebCore::HTMLMediaElement::removedFrom): Fix logging.

LayoutTests:

• media/video-remove-insert-repaints.html: Added.
• media/video-remove-insert-repaints-expected.txt: Added.
• platform/mac/media/video-remove-insert-repaints-expected.png: Added.

11:39 PM Changeset in webkit [149988] by commit-queue@webkit.org

• 2 edits
  6 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=116004

Unreviewed EFL gardening

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-05-12

• platform/efl-wk2/TestExpectations:
• platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
• platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
• platform/efl/fast/text/text-combine-different-fonts-expected.txt: Added.
• platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
• platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.

11:25 PM Changeset in webkit [149987] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

Move sudden termination symbols to the Mac-only section

• WebCore.exp.in: Move the sudden termination symbols to the

!PLATFORM(IOS) section for reals this time.

11:24 PM Changeset in webkit [149986] by Darin Adler

• 2 edits in trunk/Source/WebCore

Fix Mac build.

• platform/mac/PasteboardMac.mm: Add back include of ClipboardMac.h that was removed by accident a couple of patches back.

10:35 PM Changeset in webkit [149985] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Moved files function from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116008

Reviewed by Anders Carlsson.

• dom/Clipboard.cpp:

(WebCore::Clipboard::files): Added. Moved the DOM-depdendent and
platform-independent part of the files function in ClipboardMac here.

• dom/Clipboard.h: Made files function non-virtual in non-legacy case.

• platform/Pasteboard.h: Removed static member function

absoluteURLsFromPasteboardFilenames since it can now be private to
PasteboardMac. Added member function readFilenames.

• platform/mac/ClipboardMac.h: Removed function member files and also

now-unused data member m_clipboardContents.

• platform/mac/ClipboardMac.mm: Removed files function.

(WebCore::ClipboardMac::ClipboardMac): Removed code to initialize
m_clipboardContents.

• platform/mac/PasteboardMac.mm:

(WebCore::absoluteURLsFromPasteboardFilenames): Changed from a static
member function to a file-local function.
(WebCore::absoluteURLsFromPasteboard): Changed to call the function
above in its new location.
(WebCore::Pasteboard::readFilenames): Added. Code from ClipboardMac,
minus the DOM-specific parts. Added a FIXME about the peculiar round
trip through NSURL this code takes.

10:32 PM Changeset in webkit [149984] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Fix WebKit2 build.

• WebCore.exp.in:

Put WebCore::disableSuddenTermination and WebCore::enableSuddenTermination symbols in the right section.

10:26 PM Changeset in webkit [149983] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Move types function from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116007

Reviewed by Anders Carlsson.

• dom/Clipboard.cpp:

(WebCore::Clipboard::types): Added. Calls through to Pasteboard
after doing checks needed at this level.

• dom/Clipboard.h: Made types function non-virtual in non-legacy case,

and removed non-helpful comment.

• platform/Pasteboard.h: Updated includes and comments at the top of

the file a bit. Removed static member function addHTMLClipboardTypesForCocoaType,
since it can now be private to PasteboardMac. Added member function types.

• platform/mac/ClipboardMac.h: Removed types function.
• platform/mac/ClipboardMac.mm: Ditto.

• platform/mac/PasteboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType): Made this a file-local
function instead of a static member function.
(WebCore::Pasteboard::types): Added. Moved from ClipboardMac.

10:19 PM Changeset in webkit [149982] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Move setData from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116006

Reviewed by Anders Carlsson.

• dom/Clipboard.cpp:

(WebCore::Clipboard::setData): Added. Calls through to Pasteboard
after doing checks needed at this level.

• dom/Clipboard.h: Made setData non-virtual in non-legacy case.

• platform/Pasteboard.h: Updated includes and forward declarations.

Removed static member function cocoaTypeFromHTMLClipboardType, since
it can now be private to PasteboardMac. Added static member function
addHTMLClipboardTypesForCocoaType, which is shared between the
ClipboardMac and PasteboardMac files for now. Added writeString.

• platform/mac/ClipboardMac.h: Removed setData.

• platform/mac/ClipboardMac.mm: Removed utiTypeFromCocoaType,

addHTMLClipboardTypesForCocoaType, and setData.
(WebCore::ClipboardMac::types): Call addHTMLClipboardTypesForCocoaType
as a Pasteboard static member function, for now.

• platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType): Added. Moved from ClipboardMac.
(WebCore::Pasteboard::readString): Changed to call
cocoaTypeFromHTMLClipboardType as a file-local function, not a member
function (in fact, we didn't need to repeat the class name before, either,
so this is just removing something we didn't need).
(WebCore::utiTypeFromCocoaType): Added. Moved from ClipboardMac.
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Ditto.
(WebCore::Pasteboard::writeString): Ditto.

9:44 PM Changeset in webkit [149981] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Move getData from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116005

Reviewed by Anders Carlsson.

• dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Added a new boolean argument, forFileDrag,
to the constructor. Maybe we can find a better way to do this once we move
all the platforms over, but this boolean seems a good way to do it for now.
(WebCore::Clipboard::getData): Added. Calls through to Pasteboard after
doing the canReadData check, which is part of DOM rules, not the platform.
Also checks for the file drag case like the old ClipboardMac code did.

• dom/Clipboard.h: Made getData non-virtual in non-legacy case.

• platform/Pasteboard.h: Added a static member function named

absoluteURLsFromPasteboardFilenames, temporary so it can be shared between
ClipboardMac and PasteboardMac. Added a readString public function member,
and a m_changeCount data member. The type of m_changeCount is long since
that can always hold an NSInteger but yet is a type we can compile without
including the header file that defines NSInteger.

• platform/mac/ClipboardMac.h: Removed getData.
• platform/mac/ClipboardMac.mm: Removed getData.

(WebCore::ClipboardMac::ClipboardMac): Added code to pass in the new
forFileDrag boolean.
(WebCore::ClipboardMac::files): Call absoluteURLsFromPasteboardFilenames
as a static member function in Pasteboard since we moved it there.

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::Pasteboard): Initialize the change count, so later
pasteboard operations can check it.
(WebCore::Pasteboard::absoluteURLsFromPasteboardFilenames): Added. Moved
here from ClipboardMac.
(WebCore::absoluteURLsFromPasteboard): Ditto.
(WebCore::Pasteboard::readString): Added. Moved here from ClipboardMac.

9:24 PM Changeset in webkit [149980] by andersca@apple.com

• 169 edits in trunk/Source

Stop including UnusedParam.h
​https://bugs.webkit.org/show_bug.cgi?id=116003

Reviewed by Sam Weinig.

UnusedParam.h is empty now so there's no need to include it anymore.

Source/JavaScriptCore:

• API/APICast.h:
• API/tests/JSNode.c:
• API/tests/JSNodeList.c:
• API/tests/minidom.c:
• API/tests/testapi.c:
• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssemblerCodeRef.h:
• bytecode/CodeBlock.cpp:
• heap/HandleStack.h:
• interpreter/JSStackInlines.h:
• jit/CompactJITCodeMap.h:
• jit/ExecutableAllocator.h:
• parser/SourceProvider.h:
• runtime/DatePrototype.cpp:
• runtime/JSNotAnObject.cpp:
• runtime/JSSegmentedVariableObject.h:
• runtime/JSVariableObject.h:
• runtime/Options.cpp:
• runtime/PropertyOffset.h:

Source/WebCore:

• Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
• Modules/indexeddb/IDBFactoryBackendImpl.cpp:
• Modules/indexeddb/IDBObjectStore.cpp:
• Modules/webdatabase/DatabaseServer.cpp:
• Modules/webdatabase/DatabaseThread.cpp:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/objc/DOMObject.mm:
• css/CSSCursorImageValue.cpp:
• css/DeprecatedStyleBuilder.cpp:
• dom/EventDispatcher.cpp:
• dom/Node.cpp:
• editing/AlternativeTextController.h:
• editing/Editor.cpp:
• html/HTMLPlugInElement.cpp:
• html/canvas/CanvasRenderingContext2D.cpp:
• html/canvas/OESVertexArrayObject.h:
• html/parser/HTMLConstructionSite.cpp:
• html/parser/HTMLTokenizer.cpp:
• html/track/InbandTextTrack.cpp:
• inspector/InspectorCanvasInstrumentation.h:
• inspector/InspectorConsoleInstrumentation.h:
• inspector/InspectorController.cpp:
• inspector/InspectorCounters.h:
• inspector/InspectorDatabaseInstrumentation.h:
• inspector/InspectorInstrumentation.h:
• loader/DocumentThreadableLoader.cpp:
• loader/PingLoader.cpp:
• loader/appcache/ApplicationCacheGroup.cpp:
• loader/cache/CachedResourceLoader.cpp:
• loader/mac/DocumentLoaderMac.cpp:
• page/ChromeClient.h:
• page/Console.cpp:
• page/FrameView.cpp:
• page/PageConsole.cpp:
• page/animation/AnimationController.cpp:
• page/animation/ImplicitAnimation.cpp:
• page/animation/KeyframeAnimation.cpp:
• platform/LocalizedStrings.cpp:
• platform/ScrollAnimator.h:
• platform/ThreadGlobalData.cpp:
• platform/blackberry/AsyncFileSystemBlackBerry.cpp:
• platform/graphics/Font.cpp:
• platform/graphics/GlyphBuffer.h:
• platform/graphics/Gradient.cpp:
• platform/graphics/ShadowBlur.cpp:
• platform/graphics/SimpleFontData.cpp:
• platform/graphics/SimpleFontData.h:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/blackberry/GradientBlackBerry.cpp:
• platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
• platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:
• platform/graphics/ca/mac/WebTileLayer.mm:
• platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/graphics/cg/ImageBufferCG.cpp:
• platform/graphics/cg/ImageSourceCG.cpp:
• platform/graphics/clutter/PlatformClutterAnimation.cpp:
• platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
• platform/graphics/gstreamer/GStreamerVersioning.cpp:
• platform/graphics/mac/GraphicsContext3DMac.mm:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
• platform/graphics/mac/SimpleFontDataMac.mm:
• platform/graphics/mac/WebGLLayer.mm:
• platform/graphics/mac/WebLayer.mm:
• platform/graphics/mac/WebTiledLayer.mm:
• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
• platform/graphics/qt/GraphicsContext3DQt.cpp:
• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/wince/ImageBufferWinCE.cpp:
• platform/mac/PasteboardMac.mm:
• platform/mac/ScrollAnimatorMac.mm:
• platform/mac/ScrollViewMac.mm:
• platform/mac/ScrollbarThemeMac.mm:
• platform/mac/SharedTimerMac.mm:
• platform/mac/WebCoreFullScreenPlaceholderView.mm:
• platform/mac/WebCoreObjCExtras.mm:
• platform/mac/WebFontCache.mm:
• platform/mac/WebVideoFullscreenController.mm:
• platform/mac/WebVideoFullscreenHUDWindowController.mm:
• platform/mac/WebWindowAnimation.mm:
• platform/network/blackberry/CredentialStorageBlackBerry.cpp:
• platform/network/cf/ResourceErrorCF.cpp:
• platform/network/mac/CookieStorageMac.mm:
• platform/network/mac/ResourceHandleMac.mm:
• platform/network/win/ResourceHandleWin.cpp:
• platform/text/TextEncodingDetectorICU.cpp:
• rendering/RenderFlowThread.h:
• rendering/RenderImage.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderObject.cpp:
• rendering/RenderTreeAsText.cpp:
• rendering/svg/RenderSVGResourceClipper.cpp:
• rendering/svg/RenderSVGResourceFilter.cpp:
• rendering/svg/RenderSVGResourceGradient.cpp:
• rendering/svg/RenderSVGResourceMasker.cpp:
• rendering/svg/SVGRenderSupport.cpp:
• rendering/svg/SVGTextLayoutEngineSpacing.cpp:
• workers/WorkerContext.cpp:
• workers/WorkerScriptLoader.cpp:
• xml/XMLHttpRequest.cpp:
• xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/efl:

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
• ewk/ewk_js.cpp:
• ewk/ewk_security_origin.cpp:
• ewk/ewk_view.cpp:
• ewk/ewk_web_database.cpp:

Source/WebKit/gtk:

• webkit/webkitapplicationcache.cpp:

Source/WebKit/mac:

• Plugins/WebNetscapePluginEventHandlerCocoa.mm:
• WebView/WebDashboardRegion.mm:
• WebView/WebFullScreenController.mm:

Source/WebKit/win:

• WebSecurityOrigin.cpp:

Source/WebKit2:

• UIProcess/API/C/WKContext.cpp:
• UIProcess/API/C/WKInspector.cpp:
• UIProcess/API/C/WKPage.cpp:
• UIProcess/API/efl/ewk_text_checker.cpp:
• UIProcess/API/efl/ewk_view.cpp:
• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
• UIProcess/API/efl/tests/test_ewk2_view.cpp:
• UIProcess/mac/WKFullScreenWindowController.mm:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
• WebProcess/ResourceCache/WebResourceCacheManager.cpp:

Source/WTF:

• wtf/Atomics.h:
• wtf/BoundsCheckedPointer.h:
• wtf/DateMath.h:
• wtf/FastMalloc.cpp:
• wtf/NumberOfCores.cpp:
• wtf/OSAllocator.h:
• wtf/OSAllocatorPosix.cpp:
• wtf/PageAllocation.h:
• wtf/RefCounted.h:
• wtf/TCSystemAlloc.cpp:
• wtf/ThreadingPthreads.cpp:
• wtf/Vector.h:
• wtf/dtoa/cached-powers.cc:
• wtf/dtoa/fixed-dtoa.cc:

8:51 PM Changeset in webkit [149979] by Darin Adler

• 5 edits in trunk/Source/WebCore

[Mac] Move clearAllData from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116001

Reviewed by Andreas Kling.

• dom/Clipboard.cpp:

(WebCore::Clipboard::clearAllData): Added. Calls through to Pasteboard after
doing the canWriteData check, which is part of DOM rules, not the platform.

• dom/Clipboard.h: Made clearAllData non-virtual in non-legacy case.

• platform/mac/ClipboardMac.h: Removed clearAllData.
• platform/mac/ClipboardMac.mm: Ditto.

7:56 PM Changeset in webkit [149978] by andersca@apple.com

• 3 edits in trunk/Source/WTF

Move UNUSED_PARAM and UNUSED_LABEL macros to Compiler.h
​https://bugs.webkit.org/show_bug.cgi?id=115997

Reviewed by Benjamin Poulain.

UnusedParam.h predates Compiler.h and the macros defined there should just go into Compiler.h

• wtf/Compiler.h:

(unusedParam):

• wtf/UnusedParam.h:

7:41 PM Changeset in webkit [149977] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Move clearData from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=116000

Reviewed by Andreas Kling.

• dom/Clipboard.cpp:

(WebCore::Clipboard::clearData): Added. Calls through to Pasteboard after
doing the canWriteData check, which is part of DOM rules, not the platform.

• dom/Clipboard.h: Made clearData non-virtual in non-legacy case.

• platform/Pasteboard.h: Added an overload of the clear function that takes

a single type and clears only that type. Also temporarily exported the
cocoaTypeFromHTMLClipboardType function as a static member so it can be used
in both ClipboardMac and PasteboardMac during the transition.

• platform/mac/ClipboardMac.h: Removed clearData.
• platform/mac/ClipboardMac.mm: Removed clearData.

(WebCore::ClipboardMac::getData): Changed to call cocoaTypeFromHTMLClipboardType
as a Pasteboard class static member function.
(WebCore::ClipboardMac::setData): Ditto.

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::cocoaTypeFromHTMLClipboardType): Moved here from
ClipboardMac.
(WebCore::Pasteboard::clear): Added. Moved here from ClipboardMac.

7:28 PM Changeset in webkit [149976] by Darin Adler

• 7 edits in trunk/Source/WebCore

[Mac] Move hasData from ClipboardMac to PasteboardMac
​https://bugs.webkit.org/show_bug.cgi?id=115999

Reviewed by Andreas Kling.

• dom/Clipboard.cpp:

(WebCore::Clipboard::hasData): Added. Calls through to Pasteboard.

• dom/Clipboard.h: Added LEGACY_VIRTUAL and LEGACY_PURE macros,

only for within this header file. These help us keep many functions
as pure virtual in the legacy style Clipboard class, but have them
be non-virtual in the normal/future style. Use LEGACY_VIRTUAL and
LEGACY_PURE to make the hasData member non-virtual.

• platform/Pasteboard.h: Added hasData, and added some blank lines and a FIXME.

• platform/mac/ClipboardMac.h: Removed hasData override.
• platform/mac/ClipboardMac.mm: Ditto.

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::hasData): Added. Moved code here from ClipboardMac.

7:14 PM Changeset in webkit [149975] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r149971): sudden termination is a Mac-only concept

• WebCore.exp.in: Move sudden termination symbols to Mac-only

section.

7:00 PM Changeset in webkit [149974] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Node: Use FINAL instead of the non-virtual shadowing hack.
<​http://webkit.org/b/115995>

Reviewed by Anders Carlsson.

Decorate Element/Attr implementations of prefix/localName/namespaceURI getters with FINAL
so that call sites with a more specific pointer type than Node* can avoid the virtual dispatch.

• dom/Attr.h:
• dom/Element.h:
• dom/Node.cpp:
• dom/Node.h:

6:31 PM Changeset in webkit [149973] by ryuan.choi@samsung.com

• 3 edits in trunk/LayoutTests

REGRESSION (r149668): 4 reftest failures under fast/regions on GTK
​https://bugs.webkit.org/show_bug.cgi?id=115783

Unreviewed rebaseline. They were fixed after r149802.

• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:

6:25 PM Changeset in webkit [149972] by Darin Adler

• 6 edits in trunk/Source/WebCore

[Mac] Give every Clipboard an underlying Pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=115979

Reviewed by Andreas Kling.

This is the first step in Clipboard and Pasteboard refactoring
to fix the overlap and many layering violations.

• dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Add an m_pasteboard data member,
Mac-only for now, but eventually for all platforms.
(WebCore::Clipboard::~Clipboard): No longer inline the destructor.

• dom/Clipboard.h: Add WTF_USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS

flag, currently true for all non-Mac platforms. Make the constructor
no longer inline. Added a PassOwnPtr<Pasteboard> argument to the
constructor and an OwnPtr<Pasteboard> data member.

• platform/Pasteboard.h: Added a create function to make it easy

to create a pasteboard given a pasteboard name.

• platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::ClipboardMac): Create a pasteboard and pass
it to the Clipboard constructor.

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::create): Added.

4:16 PM Changeset in webkit [149971] by akling@apple.com

• 17 edits in trunk/Source

Unload event listeners should prevent Safari from insta-killing the web process on last tab close.
<​http://webkit.org/b/115988>
<rdar://problem/13870943>

Reviewed by Anders Carlsson.

Source/WebCore:

Add two methods to Chrome (and ChromeClient):

• enableSuddenTermination()
• disableSuddenTermination()

..and call these from DOMWindow instead of the free global functions.

For WebKit1, it just calls the NSProcessInfo methods to keep behavior the same.
For WebKit2, the new methods plumb through the information to the UI process.

Also updated the DOMWindow logic to think in terms of per-DOMWindow sudden termination counters
instead of a process-global one, since that gets confusing in a WK2 world.
When a DOMWindow transitions between having/not having unload/beforeunload event listeners,
we send a notification to the Chrome.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• page/Chrome.h:

(WebCore::Chrome::enableSuddenTermination):
(WebCore::Chrome::disableSuddenTermination):

• page/ChromeClient.h:

(WebCore::ChromeClient::enableSuddenTermination):
(WebCore::ChromeClient::disableSuddenTermination):

• page/DOMWindow.cpp:

(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::enableSuddenTermination):
(WebCore::DOMWindow::disableSuddenTermination):

• page/DOMWindow.h:

(DOMWindow):

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::enableSuddenTermination):
(WebChromeClient::disableSuddenTermination):

Source/WebKit2:

Let WebCore control the UI process's suppression of the sudden termination mechanism.
This is implemented by having WebChromeClient push Enable/DisableSuddenTermination messages
over to the UI process where the appropriate NSProcessInfo calls are made.

We also use this information when deciding whether to insta-kill a web process when its last
page is closed. This mechanism is re-usable in WebCore to protect against sudden termination
by the UI process.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::enableSuddenTermination):
(WebKit::WebProcessProxy::disableSuddenTermination):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/WebProcessProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::enableSuddenTermination):
(WebKit::WebChromeClient::disableSuddenTermination):

• WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

2:27 PM Changeset in webkit [149970] by andersca@apple.com

• 12 edits
  1 delete in trunk/Source

Remove Complex.h from WTF
​https://bugs.webkit.org/show_bug.cgi?id=115989

Reviewed by Beth Dakin.

Source/WebCore:

Replace Complex declarations with std::complex<double>. Pass by value since the struct
is small enough to go into two registers on X86-64.

• Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):

• platform/audio/Biquad.cpp:

(WebCore::Biquad::setZeroPolePairs):
(WebCore::Biquad::setAllpassPole):
(WebCore::Biquad::getFrequencyResponse):

• platform/audio/Biquad.h:
• platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::interpolateFrequencyComponents):
(WebCore::FFTFrame::extractAverageGroupDelay):
(WebCore::FFTFrame::addConstantGroupDelay):

Source/WTF:

Complex.h contains a typedef and a single function (that already has an equivalent in the STL).
The header is used by three files in WebCore, so just use std::complex<double> and std::polar directly.

• GNUmakefile.list.am:
• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Complex.h: Removed.

11:46 AM Changeset in webkit [149969] by Simon Fraser

• 5 edits
  2 adds in trunk

Dropdowns on ​http://www.exploratorium.edu don't show anything
​https://bugs.webkit.org/show_bug.cgi?id=115991

Source/WebCore:

Reviewed by Dan Bernstein.

We can't optimize away the backing store of a layer by saying that
it paints into a composited ancestor if its composited bounds are not contained
by that ancestor.

Test: compositing/backing/no-backing-for-clip-overhang.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Pass in our
previously computed composited bounds relative to our composited ancestor,
and its composited bounds.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore): If the ancestor's
composited bounds don't contain the layer's composited bounds, the layer
needs its own backing store.

• rendering/RenderLayerCompositor.h:

LayoutTests:

Reviewed by Dan Bernstein.

Layer tree dump test with an overflow:hidden that projects outside its
ancestor, and is forced to composite by a composited child.

• compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
• compositing/backing/no-backing-for-clip-overhang.html: Added.

11:22 AM Changeset in webkit [149968] by Martin Robinson

• 7 edits
  8 adds in trunk

[GTK] Add a basic cmake build for WTF and JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=115967

Reviewed by Laszlo Gombos.

.:

• CMakeLists.txt: Add GTK+ to the list of ports.
• Source/CMakeLists.txt: We do not try to build WebCoreTestSupport when WebCore is disabled.
• Source/cmake/FindGAIL3.cmake: Added.
• Source/cmake/FindGDK3.cmake: Added.
• Source/cmake/FindGStreamer.cmake: Use the passed in minimum version.
• Source/cmake/FindGTK3.cmake: Added.
• Source/cmake/FindXt.cmake: Added.
• Source/cmake/OptionsEfl.cmake: Pass in the minimum version.
• Source/cmake/OptionsGTK.cmake: Added.

Source/JavaScriptCore:

• PlatformGTK.cmake: Added.
• shell/PlatformGTK.cmake: Added.

Source/WTF:

• wtf/PlatformGTK.cmake: Added.

11:12 AM Changeset in webkit [149967] by commit-queue@webkit.org

• 103 edits in trunk

Unreviewed, rolling out r149955.
​http://trac.webkit.org/changeset/149955
​https://bugs.webkit.org/show_bug.cgi?id=115990

Broke lots of tests (Requested by smfr on #webkit).

Source/WebCore:

• WebCore.exp.in:
• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.h:

(InlineTextBox):

• rendering/RenderApplet.h:
• rendering/RenderBR.h:
• rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::virtualContinuation):
(WebCore::RenderBlock::virtualChildren):
(WebCore::RenderBlock::isRenderBlock):
(WebCore::RenderBlock::isBlockFlow):
(WebCore::RenderBlock::isInlineBlockOrInlineTable):
(WebCore::RenderBlock::dirtyLinesFromChangedChild):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):

• rendering/RenderBox.h:

(WebCore::RenderBox::borderBoundingBox):
(RenderBox):
(WebCore::RenderBox::marginLogicalLeft):
(WebCore::RenderBox::marginLogicalRight):

• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::isBoxModelObject):

• rendering/RenderButton.h:
• rendering/RenderCombineText.h:
• rendering/RenderCounter.h:
• rendering/RenderDeprecatedFlexibleBox.h:
• rendering/RenderDetailsMarker.h:
• rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::isEmbeddedObject):
(WebCore::RenderEmbeddedObject::virtualChildren):

• rendering/RenderFieldset.h:
• rendering/RenderFileUploadControl.h:
• rendering/RenderFlexibleBox.h:
• rendering/RenderFlowThread.h:
• rendering/RenderFrame.h:
• rendering/RenderFrameSet.h:
• rendering/RenderFullScreen.cpp:
• rendering/RenderFullScreen.h:
• rendering/RenderGrid.h:
• rendering/RenderHTMLCanvas.h:
• rendering/RenderIFrame.h:
• rendering/RenderImage.h:

(RenderImage):
(WebCore::RenderImage::isRenderImage):

• rendering/RenderInline.h:

(RenderInline):
(WebCore::RenderInline::virtualContinuation):
(WebCore::RenderInline::virtualChildren):
(WebCore::RenderInline::isRenderInline):
(WebCore::RenderInline::layout):
(WebCore::RenderInline::requiresLayer):
(WebCore::RenderInline::offsetWidth):
(WebCore::RenderInline::offsetHeight):
(WebCore::RenderInline::borderBoundingBox):
(WebCore::RenderInline::dirtyLinesFromChangedChild):

• rendering/RenderLayerModelObject.h:
• rendering/RenderListBox.h:
• rendering/RenderListItem.h:
• rendering/RenderListMarker.h:
• rendering/RenderMedia.h:

(WebCore::RenderMedia::virtualChildren):
(WebCore::RenderMedia::canHaveChildren):
(WebCore::RenderMedia::isMedia):
(WebCore::RenderMedia::isImage):
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):

• rendering/RenderMediaControlElements.h:
• rendering/RenderMenuList.h:
• rendering/RenderMeter.h:
• rendering/RenderMultiColumnBlock.h:
• rendering/RenderMultiColumnFlowThread.h:
• rendering/RenderMultiColumnSet.h:
• rendering/RenderNamedFlowThread.h:
• rendering/RenderPart.h:

(RenderPart):
(WebCore::RenderPart::isRenderPart):
(WebCore::RenderPart::renderName):

• rendering/RenderProgress.h:
• rendering/RenderRegion.h:

(WebCore::RenderRegion::isRenderRegion):

• rendering/RenderRegionSet.h:
• rendering/RenderReplaced.h:

(RenderReplaced):
(WebCore::RenderReplaced::renderName):

• rendering/RenderReplica.h:
• rendering/RenderRuby.h:
• rendering/RenderRubyBase.h:
• rendering/RenderRubyRun.h:
• rendering/RenderRubyText.h:
• rendering/RenderScrollbarPart.h:
• rendering/RenderSearchField.h:
• rendering/RenderSlider.h:
• rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

• rendering/RenderTable.h:

(RenderTable):
(WebCore::RenderTable::renderName):
(WebCore::RenderTable::isTable):
(WebCore::RenderTable::avoidsFloats):

• rendering/RenderTableCaption.h:
• rendering/RenderTableCell.h:
• rendering/RenderTableCol.h:
• rendering/RenderTableRow.h:
• rendering/RenderTableSection.h:
• rendering/RenderText.h:

(RenderText):
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
(WebCore::RenderText::styleWillChange):
(WebCore::RenderText::length):
(WebCore::RenderText::paint):
(WebCore::RenderText::layout):

• rendering/RenderTextControl.h:

(RenderTextControl):
(WebCore::RenderTextControl::renderName):
(WebCore::RenderTextControl::isTextControl):
(WebCore::RenderTextControl::avoidsFloats):

• rendering/RenderTextControlMultiLine.h:
• rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):

• rendering/RenderTextFragment.h:
• rendering/RenderTextTrackCue.h:
• rendering/RenderVideo.h:
• rendering/RenderView.h:
• rendering/RenderWidget.h:

(RenderWidget):
(WebCore::RenderWidget::isWidget):

• rendering/RenderWordBreak.h:
• rendering/RootInlineBox.h:

(RootInlineBox):

• rendering/mathml/RenderMathMLBlock.h:
• rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

• rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::setNeedsBoundariesUpdate):
(WebCore::RenderSVGContainer::virtualChildren):
(WebCore::RenderSVGContainer::isSVGContainer):
(WebCore::RenderSVGContainer::renderName):
(RenderSVGContainer):
(WebCore::RenderSVGContainer::objectBoundingBox):
(WebCore::RenderSVGContainer::strokeBoundingBox):
(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):

• rendering/svg/RenderSVGEllipse.h:
• rendering/svg/RenderSVGForeignObject.h:
• rendering/svg/RenderSVGGradientStop.h:
• rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::renderName):
(RenderSVGHiddenContainer):
(WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):

• rendering/svg/RenderSVGImage.h:
• rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::renderName):
(WebCore::RenderSVGInline::requiresLayer):
(WebCore::RenderSVGInline::isSVGInline):
(RenderSVGInline):

• rendering/svg/RenderSVGInlineText.h:
• rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::requiresLayer):
(RenderSVGModelObject):

• rendering/svg/RenderSVGPath.h:
• rendering/svg/RenderSVGRect.h:
• rendering/svg/RenderSVGResourceClipper.h:
• rendering/svg/RenderSVGResourceContainer.h:

(RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):

• rendering/svg/RenderSVGResourceFilter.h:
• rendering/svg/RenderSVGResourceFilterPrimitive.h:
• rendering/svg/RenderSVGResourceGradient.h:

(RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::resourceBoundingBox):

• rendering/svg/RenderSVGResourceLinearGradient.h:
• rendering/svg/RenderSVGResourceMarker.h:
• rendering/svg/RenderSVGResourceMasker.h:
• rendering/svg/RenderSVGResourcePattern.h:
• rendering/svg/RenderSVGResourceRadialGradient.h:
• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(RenderSVGShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):

• rendering/svg/RenderSVGTSpan.h:
• rendering/svg/RenderSVGText.h:
• rendering/svg/RenderSVGTextPath.h:
• rendering/svg/RenderSVGTransformableContainer.h:
• rendering/svg/RenderSVGViewportContainer.h:

Tools:

• Scripts/webkitpy/port/mac.py:

10:58 AM Changeset in webkit [149966] by Martin Robinson

• 4 edits in trunk

Move defines to platform

[GTK] Move defines that will never be configured to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=115965

Reviewed by Andreas Kling.

.:

• Source/autotools/SetupAutoconfHeader.m4: Move some unchanging defines to Platform.h.

Source/WTF:

• wtf/Platform.h: Add new defines that were previously in the autoconf header.

10:50 AM Changeset in webkit [149965] by andersca@apple.com

• 7 edits in trunk/Source

Simplify AutodrainedPool
​https://bugs.webkit.org/show_bug.cgi?id=115986

Reviewed by Andreas Kling.

Source/WebCore:

Remove calls to AutodrainedPool::cycle as well as the iteration counter passed to the constructor.
Instead, just declare RAII pools where it seems necessary.

• Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

• fileapi/FileThread.cpp:

(WebCore::FileThread::runLoop):

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):

Source/WTF:

Remove the ability to cycle an AutodrainedPool, as well as the iteration count.
Creating and draining pools is fast enough now that we don't need to try to be clever about it.

• wtf/AutodrainedPool.h:

(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):

• wtf/AutodrainedPoolMac.mm:

(WTF::AutodrainedPool::AutodrainedPool):

10:47 AM Changeset in webkit [149964] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13402976> Sandbox violations in com.nvidia.OpenGL on Lion.

Reviewed by Dan Bernstein.

• WebProcess/com.apple.WebProcess.sb.in: Silence the violations (on Lion only).

9:45 AM Changeset in webkit [149963] by andersca@apple.com

• 9 edits
  1 delete in trunk/Source/WTF

Move RemoteMemoryReader into FastMalloc.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115985

Reviewed by Andreas Kling.

RemoteMemoryReader is only used in FastMalloc.cpp, and even had one of its member functions
implemented there, so move the entire class template there and remove MallocZoneSupport.h.

• GNUmakefile.list.am:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/FastMalloc.cpp:

(WTF):
(PageHeapAllocator):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

• wtf/MallocZoneSupport.h: Removed.

9:37 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

9:33 AM Changeset in webkit [149962] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.0/Source

Merge r147640 - Fix the build with GCC 4.8
​https://bugs.webkit.org/show_bug.cgi?id=113147

Reviewed by Allan Sandfeld Jensen.

Source/JavaScriptCore:

Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.

• runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Source/WTF:

Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.

• wtf/Compiler.h:

8:26 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

8:22 AM Changeset in webkit [149961] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.0/Source/WTF

Merge r146993 - Support C++11 static_assert
​https://bugs.webkit.org/show_bug.cgi?id=113308

Reviewed by Alexey Proskuryakov.

Use the C++11 static_assert for COMPILE_ASSERT when it is available. Note that
even when compiling with C++11 support, static_assert will not always be available
since Assertions.h may also be used outside of C++.

C11 _Static_assert is enabled for GCC when it has C11 support (gcc>=4.7 -std=c11).

• wtf/Assertions.h:
• wtf/Compiler.h:

8:12 AM Changeset in webkit [149960] by akling@apple.com

• 184 edits in trunk/Source/WebCore

Apply FINAL to the Node hierarchy.
<​http://webkit.org/b/115984>

Mostly from Blink r149454 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149454>

A couple of the stable DOM/ microbenchmarks are perf positive on Linux clang:

• CloneNodes time reduced from 162.4 to 156.5 ms.
• CreateNodes time reduced from 113.9 to 104.9 ms.

• dom/: Beat things with the FINAL stick.
• html/: Ditto.
• svg/: Ditto.

7:23 AM Changeset in webkit [149959] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Devirtualize some things on Document.

From Blink r149967 by <​esprehn@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149967>

Several methods on Document are virtual but don't override a super class method
and don't need to be virtual. This patch devirtualizes:

• createElementNS()
• finishedParsing()
• suspendScriptedAnimationControllerCallbacks()
• resumeScriptedAnimationControllerCallbacks()

It also removes the suspend and resume callbacks from ScriptExecutionContext
since they didn't need to be there.

• dom/Document.h:
• dom/ScriptExecutionContext.h:

7:11 AM Changeset in webkit [149958] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WTF

Merge r145701 - Support C++11 features in GCC <4.6
​https://bugs.webkit.org/show_bug.cgi?id=111553

Reviewed by Simon Hausmann.

Enable support for rvalue references from gcc 4.3, deleted functions
from gcc 4.4, explicit conversion from gcc 4.5, and strongly typed
enums from gcc 4.6.

• wtf/Compiler.h:

7:05 AM Changeset in webkit [149957] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove redundant call to removeAllEventListeners() in Document::open().

From Blink r150175 by <​dcheng@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=150175>

Document::open() already calls Document::removeAllEventListeners(), which
removes the event listeners from the DOMWindow it's attached to, so
there's no need to do it manually here as well.

• dom/Document.cpp:

(WebCore::Document::open):

6:57 AM Changeset in webkit [149956] by akling@apple.com

• 2 edits in trunk/LayoutTests

Rebaseline fast/js/global-constructors-attributes.html for mac-lion after r149920.

• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:

6:38 AM Changeset in webkit [149955] by akling@apple.com

• 102 edits in trunk

Apply FINAL to the RenderObject hierarchy.
<​http://webkit.org/b/115977>

Mostly from Blink r148795 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=148795>

• rendering/: Beat things with the FINAL stick.
• WebCore.exp.in: Export a now-needed symbol.

4:23 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:19 AM Changeset in webkit [149954] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r145881 - Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
​https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <​tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

• GtkLauncher/main.c:

(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

4:19 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:15 AM Changeset in webkit [149953] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.0

Merge r148860 - [WebKit2] Plugins without a MIME Type fail to load
​https://bugs.webkit.org/show_bug.cgi?id=112834

Reviewed by Benjamin Poulain.

Source/WebKit2:

The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.

• WebProcess/WebPage/WebPage.h:

(WebPage):

LayoutTests:

• platform/wk2/TestExpectations: Unskip

plugins/no-mime-with-valid-extension.html.

2:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

Only bug fixes in the stable branch (diff)

2:05 AM Changeset in webkit [149952] by Carlos Garcia Campos

• 44 edits in trunk

[GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=115914

Reviewed by Martin Robinson.

Source/WebCore:

• platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::hideHud):
(WebCore::FullscreenVideoControllerGtk::initializeWindow):

• platform/gtk/GtkVersioning.c:
• platform/gtk/GtkVersioning.h:
• platform/gtk/WidgetRenderingContext.cpp:

(WebCore::WidgetRenderingContext::WidgetRenderingContext):

• plugins/gtk/gtk2xtbin.c:

(gtk_xtbin_realize):

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::contentsSizeChanged):

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

• tests/testapplicationcache.c:
• tests/testatk.c:
• tests/testatkroles.c:

(main):

• tests/testcontextmenu.c:
• tests/testcopyandpaste.c:

(main):

• tests/testdomdocument.c:
• tests/testdomdomwindow.c:
• tests/testdomnode.c:
• tests/testdownload.c:

(main):

• tests/testfavicondatabase.c:

(main):

• tests/testglobals.c:
• tests/testhittestresult.c:
• tests/testhttpbackend.c:

(main):

• tests/testkeyevents.c:

(main):

• tests/testloading.c:
• tests/testmimehandling.c:

(main):

• tests/testnetworkrequest.c:

(main):

• tests/testnetworkresponse.c:

(main):

• tests/testwebbackforwardlist.c:

(main):

• tests/testwebdatasource.c:

(main):

• tests/testwebframe.c:

(main):

• tests/testwebhistoryitem.c:

(main):

• tests/testwebinspector.c:

(main):

• tests/testwebplugindatabase.c:

(main):

• tests/testwebresource.c:

(main):

• tests/testwebsettings.c:

(main):

• tests/testwebview.c:
• tests/testwindow.c:

(main):

• webkit/webkitwebview.cpp:

(webkit_web_view_realize):
(webkit_web_view_show_help):
(webkit_web_view_class_init):
(webkit_web_view_set_tooltip_text):

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

Tools:

• GtkLauncher/main.c:

(createToolbar):

• MiniBrowser/gtk/BrowserWindow.c:

(_BrowserWindow):
(browserWindowSetStatusText):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):

May 11, 2013:

11:15 PM Changeset in webkit [149951] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix after r149932

Patch by Brent Fulgham <Brent Fulgham> on 2013-05-11

• make-export-file-generator: Don't attempt to import

(or use) non-existent cxxabi functions on Windows.

10:39 PM Changeset in webkit [149950] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Add more info to compositing log channel output
​https://bugs.webkit.org/show_bug.cgi?id=115978

Reviewed by Dean Jackson.

Add to compositing log channel output whether a layer paints
into its compositing ancestor.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

9:54 PM Changeset in webkit [149949] by Simon Fraser

• 4 edits
  4 adds in trunk

REGRESSION: Fixed background on ColterReed.com scrolls
​https://bugs.webkit.org/show_bug.cgi?id=115951

Source/WebCore:

Reviewed by Beth Dakin.

The logic for painting the fixed root background into its own layer was
broken when the document element's layer was composited. This could be caused
by a negative z-index child of the body, or by an explicit compositing-causing
style on the <html>.

There were two issues. First, when painting the layer for the fixed root
background, we would simply short-circuit the fixed background paint in
RenderLayer::paintLayer(), when checking for a composited layer. We have
to continue to paint through the composited <html> layer to get the root
background in this case.

Secondly, RenderLayerBacking::paintIntoLayer() would only set the PaintLayerPaintingSkipRootBackground
flag if this RenderLayerBacking had a m_backgroundLayer. However, when the <html> is
composited, we need to skip painting the root layer for both the RenderView's backing,
and for the <html>'s backing. Checking whether there is *any* layer that paints
the fixed root background (i.e. checking compositor()->fixedRootBackgroundLayer())
is a simple way to fix this test.

Tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html

platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html

• rendering/RenderLayer.cpp:

(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

LayoutTests:

Reviewed by Beth Dakin.

Tests with a fixed background and two different ways of making the <html> composited.

• platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html-expected.html: Added.
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html: Added.
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed-expected.html: Added.
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html: Added.

9:28 PM Changeset in webkit [149948] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Possible crash when going Back while loading PDF
​https://bugs.webkit.org/show_bug.cgi?id=115972

Reviewed by Dan Bernstein.

It's possible for m_frame to be null when Document::findUnsafeParentScrollPropagationBoundary()
is called, so null-check currentFrame.

• dom/Document.cpp:

(WebCore::Document::findUnsafeParentScrollPropagationBoundary):

5:53 PM Changeset in webkit [149947] by ap@apple.com

• 3 edits in trunk/Source/WebCore

<rdar://problem/13823864> TextCodecICU complains about ambiguous codec names with current ICU release
​https://bugs.webkit.org/show_bug.cgi?id=115953

Reviewed by Darin Adler.

Store and use canonical converter name to create converters.

As a side effect, we now actually reuse cached converters - previously we would compare
a standard encoding name to internal canonical one, which rarely match.

• platform/text/TextCodecICU.h:
• platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::create): Pass canonical ICU converter name to constructor. (WebCore::TextCodecICU::registerEncodingNames):
  • Updated terminology.
  • Added a comment that special cases should be kept in sync between registerEncodingNames and registerCodecs.
  • Moved maccyrillic alias to a correct section. It's not present in ICU even today.
  • Changed a few aliases to actually map to standard name, not to an overridden one (this doesn't change behavior since addToTextEncodingNameMap looks up canonical name, but is clearer).

(WebCore::TextCodecICU::registerCodecs): Store a converter name to use with each
canonical encoding name.
(WebCore::TextCodecICU::TextCodecICU): Ditto.
(WebCore::TextCodecICU::releaseICUConverter): Reset the converter to remove any
leftover data.
(WebCore::TextCodecICU::createICUConverter):

• Compare converter name to converter name, not to another alias name.
• Use proper string comparison instead of pointer comparison.
• When creating a converter, assert that the name is not ambigous - canonical converter names should never be, otherwise there would be no way to create the converter without ambiguity.

5:26 PM Changeset in webkit [149946] by mhahnenberg@apple.com

• 6 edits
  2 adds
  2 deletes in branches/dfgFourthTier/Source/JavaScriptCore

Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
​https://bugs.webkit.org/show_bug.cgi?id=115938

We're going to add some more types of check hoisting soon, so let's have
the right name here.

Rubber stamped by Filip Pizlo.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
• dfg/DFGStructureCheckHoistingPhase.h: Removed.
• dfg/DFGTypeCheckHoistingPhase.cpp: Added.

(DFG):
(TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::shouldConsiderForHoisting):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheck):
(CheckData):
(JSC::DFG::TypeCheckHoistingPhase::CheckData::CheckData):
(JSC::DFG::performTypeCheckHoisting):

• dfg/DFGTypeCheckHoistingPhase.h: Added.

4:42 PM Changeset in webkit [149945] by rakuco@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r149944.

• Platform/CoreIPC/ArgumentEncoder.cpp: Include <sys/mman.h> for mmap(2).

4:28 PM Changeset in webkit [149944] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Don't pass malloced pointers as out-of-line data when sending Mach messages
​https://bugs.webkit.org/show_bug.cgi?id=115970
<rdar://problem/13144680>

Reviewed by Sam Weinig.

Give ArgumentEncoder an inline buffer of 512 bytes. If we need more than that, use mmap to allocate data
since that gives us fresh zero-filled memory that we can safely share.

• Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::ArgumentEncoder):
Set up the buffer pointers to point to the inline buffer.

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
Unmap the buffer if necessary.

(CoreIPC::ArgumentEncoder::grow):
Grow the allocation exponentially, rounded up to the nearest page. This is a simplification from the
current strategy, but most messages are either tiny in which case they will fit inside the inline buffer,
or big in which case we'll end up doing less allocations + memory copying.

• Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):

4:26 PM Changeset in webkit [149943] by mhahnenberg@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

SpeculativeJIT::checkArray should use the correct ExitKind
​https://bugs.webkit.org/show_bug.cgi?id=115943

Currently it uses Uncountable, which gives us no information if we end up exiting due to a
mismatched ClassInfo pointer. It should instead use BadType and should pass the correct
JSValueSource and Node instead of passing empty values.

Reviewed by Filip Pizlo.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):

2:42 PM Changeset in webkit [149942] by Antoine Quint

• 3 edits in trunk/Source/WebCore

[Mac] The captions menu should not use a canned max-width and max-height
​https://bugs.webkit.org/show_bug.cgi?id=115968

Reviewed by Eric Carlson.

Use more real estate to display the captions menu should the caption names
be long.

• css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):
Make the captions menu scale to a max-width and max-height to allow 4px
above and below the menu, except on the right where it always aligns with
the captions icon in the media controller.

• html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::createControls):
Move the captions menu element to be a child of the controls instead of
the panel such that it may scale relative to the controls when using %
CSS values.

2:07 PM Changeset in webkit [149941] by fpizlo@apple.com

• 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Jump and ForceOSRExit
​https://bugs.webkit.org/show_bug.cgi?id=115942

Reviewed by Oliver Hunt.

Added two obvious nodes: Jump and ForceOSRExit. We already had everything we needed
to support them.

Adding these increases our coverage a fair bit, and revealed a bug: LLVM's full
instruction selector currently appears to mishandle doubles in constant pools (or
just constant pools in general) with the small code model in the MCJIT. But switching
to FastISel "fixes" it. That's what this patch does, for now. This will probably
actually be permanent; the FastISel does pretty much everything we would ever want,
at least in the foreseeable future.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):
(FTL):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::compileForceOSRExit):

• runtime/Options.h:

(JSC):

1:57 PM Changeset in webkit [149940] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r149904.

• GNUmakefile.list.am: Adding missing build targets.

1:08 PM Changeset in webkit [149939] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Bogus -webkit-columns value in fast/text/international/spaces-combined-in-vertical-text.html
​https://bugs.webkit.org/show_bug.cgi?id=115164

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-05-11
Reviewed by Rob Buis.

Remove bogus -webkit-columns property.

• fast/text/international/spaces-combined-in-vertical-text.html:

1:07 PM Changeset in webkit [149938] by Christophe Dumez

• 2 edits in trunk/Source/WebKit2

Unreviewed, Fix WK2 EFL build after r149904.

Add new PluginInformation.cpp file to CMake.

• CMakeLists.txt:

12:47 PM Changeset in webkit [149937] by Christophe Dumez

• 2 edits in trunk/Source/WebKit2

Unreviewed, fix WK2 EFL build after r149904.

Add new WKPluginInformation.cpp file to CMake.

• CMakeLists.txt:

12:09 PM Changeset in webkit [149936] by jochen@chromium.org

• 5 edits
  2 adds in trunk

Disallow a window to focus itself via javascript URLs or using target _self
​https://bugs.webkit.org/show_bug.cgi?id=115906

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: fast/dom/Window/window-focus-self.html

• loader/FrameLoader.cpp:

(WebCore::createWindow):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

LayoutTests:

• fast/dom/Window/window-focus-self-expected.txt: Added.
• fast/dom/Window/window-focus-self.html: Added.
• platform/wk2/TestExpectations: test uses unimplemented setWindowIsKey.

12:07 PM Changeset in webkit [149935] by Christophe Dumez

• 58 edits in trunk/Source/WebCore

Fix several style warnings in generated bindings
​https://bugs.webkit.org/show_bug.cgi?id=115961

Reviewed by Kentaro Hara.

Fix several style errors in the bindings generated under
Source/WebCore/bindings/scripts/test/

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):
(WriteData):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(WriteData):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):

• bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
• bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
• bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
• bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
• bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
• bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
• bindings/scripts/test/CPP/WebDOMTestException.cpp:
• bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
• bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
• bindings/scripts/test/CPP/WebDOMTestNode.cpp:
• bindings/scripts/test/CPP/WebDOMTestObj.cpp:
• bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::releaseImplIfNotNull):

• bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestNodeInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestObjInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:

(WebCore):

11:53 AM Changeset in webkit [149934] by akling@apple.com

• 3 edits in trunk/Source/WebKit2

When possible, terminate web processes immediately when closing their last page.
<​http://webkit.org/b/115964>
<rdar://problem/13869266>

Reviewed by Geoffrey Garen.

When we're using a network process, there's no need for the UI process to wait for web processes
to clear resource caches and terminate nicely.

We can just kill them off right away in WebProcessProxy::removeWebPage() when the last page is closed.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeWebPage):

Terminate the child process immediately if possible.

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::canTerminateChildProcess):
(WebKit::WebProcessProxy::shouldTerminate):

Broke out the logic from the shouldTerminate() IPC message handler into a separate function
so we can call it from removeWebPage().

11:00 AM Changeset in webkit [149933] by andersca@apple.com

• 8 edits
  1 add in trunk

Crash when terminating a process that has not been fully launched
​https://bugs.webkit.org/show_bug.cgi?id=115962
<rdar://problem/13660916>

Reviewed by Andreas Kling.

Source/WebKit2:

Handle terminating a process that has not been fully launched.

• UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
If we have been invalidated, dispose the connection identifier.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):
If we're still launching the process, invalidate so the client won't get an unexpected
didFinishLaunching callback.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::requestTermination):
Check if webConnection() is null before calling it. (It will be null if the process isn't fully launched).

Tools:

Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
before the process has had a chance to be fully launched.

• TestWebKitAPI/GNUmakefile.am:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/WebKit2.pro:

9:09 AM Changeset in webkit [149932] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Make it a build error to put invalid C++ symbol names in WebCore.exp.in
​https://bugs.webkit.org/show_bug.cgi?id=115958

Reviewed by Andreas Kling.

While invalid C++ symbols will eventually show up as a link error since the symbol won't be found,
this makes it easier to catch invalid symbols inside of #ifdefs.

• make-export-file-generator:

Try to demangle C++ symbols before printing them.

7:09 AM Changeset in webkit [149931] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r149718): Move exported symbol into ENABLE(FULLSCREEN_API) section

Fixes the following build failure when ENABLE(FULLSCREEN_API) is
off:

Undefined symbols for architecture i386:

"ZNK7WebCore7Element25containsFullScreenElementEv", referenced from:

-exported_symbol[s_list] command line option

• WebCore.exp.in: Move the symbol.

5:14 AM Changeset in webkit [149930] by robert@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, remove some lint accidentally left in r149929.

• rendering/InlineFlowBox.cpp:

(WebCore::verticalAlignApplies):

5:08 AM Changeset in webkit [149929] by robert@webkit.org

• 5 edits
  2 adds in trunk

Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height
​https://bugs.webkit.org/show_bug.cgi?id=111974

Source/WebCore:

Reviewed by Ryosuke Niwa.

Per ​http://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align 'vertical-align' only applies to inline and table-cell
elements.

Test: fast/css/vertical-align-block-elements.html

• rendering/InlineFlowBox.cpp:

(WebCore::isTextInBlockElement):
(WebCore):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

LayoutTests:

Reviewed by Ryosuke Niwa.

• editing/execCommand/query-command-state-expected.txt:
• editing/execCommand/script-tests/query-command-state.js: Remove invalid tests, vertical-align does not apply to div elements.

(runTests):

• fast/css/vertical-align-block-elements-expected.html: Added.
• fast/css/vertical-align-block-elements.html: Added.

1:36 AM Changeset in webkit [149928] by benjamin@webkit.org

• 7 edits in trunk/Source/WebCore

Make CanvasStyle a plain object instead of an RefCounted object
​https://bugs.webkit.org/show_bug.cgi?id=115775

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-11
Reviewed by Andreas Kling.

CanvasStyle is just 2 words wide. We do not gain anything from allocating
it on the heap. Change the object to be just a type and some data.

• bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toJS):
(WebCore::toHTMLCanvasStyle):

• html/HTMLCanvasElement.cpp:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

• html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::strokeStyle):
(CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::fillStyle):
(State):

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::createFromString):
(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore):
(WebCore::CanvasStyle::operator=):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

• html/canvas/CanvasStyle.h:

(CanvasStyle):
(WebCore::CanvasStyle::isValid):
(WebCore::CanvasStyle::CanvasStyle):
(WebCore):
(WebCore::CanvasStyle::operator=):

12:56 AM Changeset in webkit [149927] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Gradient::platformGradient: Vector reserveCapacity -> reserveInitialCapacity
​https://bugs.webkit.org/show_bug.cgi?id=115779

Reviewed by Andreas Kling.

• platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformGradient): Clang is surprisingly smart at removing
all the branches of this function. Remove two more with reserveInitialCapacity.

12:47 AM Changeset in webkit [149926] by benjamin@webkit.org

• 2 edits in trunk/Websites/planet.webkit.org

Remove irrelevant blogs from Planet WebKit
​https://bugs.webkit.org/show_bug.cgi?id=115620

Reviewed by Ryosuke Niwa.

• config.ini:

May 10, 2013:

10:51 PM Changeset in webkit [149925] by ap@apple.com

• 8 edits
  2 adds
  3 deletes in trunk

<rdar://problem/13666412> Clean up some edge cases of URL parsing.
​https://bugs.webkit.org/show_bug.cgi?id=104919

Reviewed by Darin Adler.

WebCore:

• page/SecurityOrigin.cpp: (WebCore::schemeRequiresHost): (WebCore::shouldTreatAsUniqueOrigin): Updated function name and comments (host is not the same as authority). We still need this check - KURL can still produce http URLs with an empty host (even as this patch reduces the number of such cases). So can Gecko and current draft of URL Standard. It would be good to have a guarantee that such useless URLs can not come out of URL parser, as relying on downstream code re-parsing the URL correctly would be fragile.

• platform/KURL.cpp: (WebCore::hostPortIsEmptyButCredentialsArePresent): Updated an argument name for correctness. (WebCore::KURL::parse):

1. Reverted behavior changes from <​http://trac.webkit.org/changeset/82181> - I could find no reason to allow "@" in hostnames, and having a URL like this re-parsed by a different parser would likely produce different results. It's better to just treat these edge case URLs as invalid.
2. When hostname component is a lone colon, preserve it in parsed URL string, as otherwise path would get pushed in its place when re-parsing.
3. When authority component is a lone colon, don't forget to "" after scheme, too.
4. Added some assertions about contents of authority component, to catch potential mis-parsing earlier.

LayoutTests:

• fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:
• fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Updated expectations of one sub-test. We previously tried to keep the test passing as is (see bug 57291), but I couldn't find any reason to prefer the old behavior.

• fast/url/host-expected.txt:
• fast/url/host.html: Updated one subtest to new results, which match at least Gecko (original of the test actually claims that all browsers including Safari already do what we'll do now).

• fast/url/segments-userinfo-vs-host-expected.txt: Added.
• fast/url/segments-userinfo-vs-host.html: Added. Added a number of tests, with detailed explanations of the differences with Firefox, and with rationales.

• http/tests/uri/username-with-no-hostname-expected.txt: Removed.
• http/tests/uri/username-with-no-hostname.html-disabled: Removed.
• platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Removed. This test has been disabled for a long time, and being an end-to-end test for invalid URL handling, it would be difficult to make work again. We have multiple parsing tests for URLs like this.

10:45 PM Changeset in webkit [149924] by ap@apple.com

• 3 edits in trunk/Source/WebCore

Make TextCodecICU not depend on TextEncoding
​https://bugs.webkit.org/show_bug.cgi?id=115848

Reviewed by Darin Adler.

• platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::create): (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::TextCodecICU::decode): (WebCore::TextCodecICU::encode):
• platform/text/TextCodecICU.h: Use a plain encoding string in platform encoder wrapper, not a higher level concept.

10:03 PM Changeset in webkit [149923] by commit-queue@webkit.org

• 20 edits in trunk/Source

Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save
​https://bugs.webkit.org/show_bug.cgi?id=115564

Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Benjamin Poulain.

Source/WebKit/mac:

Clean up save() and append() implementations.

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

Source/WebKit2:

Implement InspectorFrontendHost's save() and append() methods for
Mac WebKit2. Add canSave() for all ports.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::save):
(WebKit):
(WebKit::WebInspectorProxy::append):

• UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

• UIProcess/WebInspectorProxy.messages.in:
• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

• UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

• WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::canSave):
(WebKit):
(WebKit::WebInspectorFrontendClient::save):
(WebKit::WebInspectorFrontendClient::append):

• WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::save):
(WebKit):
(WebKit::WebInspector::append):
(WebKit::WebInspector::didSave):
(WebKit::WebInspector::didAppend):

• WebProcess/WebPage/WebInspector.h:

(WebInspector):

• WebProcess/WebPage/WebInspector.messages.in:
• WebProcess/WebPage/efl/WebInspectorEfl.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

• WebProcess/WebPage/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

• WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::canSave):
(WebKit):

• WebProcess/WebPage/qt/WebInspectorQt.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

6:59 PM Changeset in webkit [149922] by Laszlo Gombos

• 18 edits in trunk

Remove Mac OS X Leopard (10.5) support
​https://bugs.webkit.org/show_bug.cgi?id=107964

Reviewed by Ryosuke Niwa.

Removed the code for 10.5 and removed if-def for 10.6.

Source/WebCore:

No new tests, covered by existing tests.

• platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary):

• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/mac/EmptyProtocolDefinitions.h:
• platform/mac/NSScrollerImpDetails.h:
• platform/mac/WebCoreSystemInterface.h:
• platform/text/mac/HyphenationMac.mm:

Source/WebKit/mac:

• DefaultDelegates/WebDefaultContextMenuDelegate.mm:
• Misc/WebKitErrors.m:

(-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

• WebView/WebClipView.mm:

(-[WebClipView _immediateScrollToPoint:]):

• WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]):

• WebView/WebView.mm:

Tools:

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(convertMIMEType):
(createXMLStringFromWebArchiveData):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::authenticateSession):
(TestRunner::setTextDirection):

• WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:

(convertMIMEType):
(createXMLStringFromWebArchiveData):

6:27 PM Changeset in webkit [149921] by Laszlo Gombos

• 16 edits in trunk/Source

Remove USE(OS_RANDOMNESS)
​https://bugs.webkit.org/show_bug.cgi?id=108095

Reviewed by Darin Adler.

Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
ports.

Source/JavaScriptCore:

• jit/JIT.cpp:

(JSC::JIT::JIT):

Source/WebCore:

No new tests as this is covered by existing tests.

• page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

• platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

Source/WebKit/blackberry:

• WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

• wtf/CryptographicallyRandomNumber.cpp:

(WTF::cryptographicallyRandomValues):

• wtf/CryptographicallyRandomNumber.h:
• wtf/OSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

• wtf/OSRandomSource.h:
• wtf/Platform.h:
• wtf/RandomNumber.cpp:

(WTF::randomNumber):

• wtf/RandomNumber.h:
• wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

6:24 PM Changeset in webkit [149920] by Christophe Dumez

• 25 edits in trunk

Remove [NoInterfaceObject] from several WebAudio IDL interfaces
​https://bugs.webkit.org/show_bug.cgi?id=115894

Reviewed by Darin Adler.

Source/WebCore:

Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set,
meaning that there was no corresponding attribute on the global window object.
This behavior is not according to the specification:
​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html

This patch removes the [NoInterfaceObject] extended attribute where needed to
match the specification.

No new tests, already covered by existing tests.

• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioDestinationNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ConvolverNode.idl:
• Modules/webaudio/DelayNode.idl:
• Modules/webaudio/DynamicsCompressorNode.idl:
• Modules/webaudio/GainNode.idl:
• Modules/webaudio/MediaElementAudioSourceNode.idl:
• Modules/webaudio/MediaStreamAudioDestinationNode.idl:
• Modules/webaudio/MediaStreamAudioSourceNode.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/ScriptProcessorNode.idl:
• Modules/webaudio/WaveShaperNode.idl:
• Modules/webaudio/WaveTable.idl:

LayoutTests:

Rebaseline fast/js/global-constructors-attributes.html now that more
global constructors are exposed.

• fast/js/global-constructors-attributes-expected.txt:
• platform/efl/fast/js/global-constructors-attributes-expected.txt:

6:23 PM Changeset in webkit [149919] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Copy WKPluginInformation.h header to the WebKit2 Framework private headers.
​https://bugs.webkit.org/show_bug.cgi?id=115940

Patch by Remy Demarest <​rdemarest@apple.com> on 2013-05-10
Reviewed by Darin Adler.

• WebKit2.xcodeproj/project.pbxproj:

Move WKPluginInformation.h file from the framework's Project Headers to
Private Headers.

5:59 PM Changeset in webkit [149918] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it
​https://bugs.webkit.org/show_bug.cgi?id=115840

Source/WebCore:

Reviewed by Antti Koivisto.

In r107836, we moved some box-shadow painting into the paintFillLayer code for performance.
However, in r145680 we started to skip background painting when we know the background is
obscured. This broke shadow painting in some cases.

Fix by always painting the background fill layers if we know that they will also
paint the shadow.

Test: fast/box-shadow/box-shadow-obscured-backgrounds.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBackground):

LayoutTests:

Reviewed by Antti Koivisto.

• fast/box-shadow/box-shadow-obscured-backgrounds-expected.html: Added.
• fast/box-shadow/box-shadow-obscured-backgrounds.html: Added.

5:52 PM Changeset in webkit [149917] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt][Mac] Unreviewed. Roll out the fix attempt in r149912.

• Target.pri:

5:46 PM Changeset in webkit [149916] by Brent Fulgham

• 3 edits
  1 add in trunk/Tools

[Windows] Allow VS2010 Build to use VS2005 Support Libraries
​https://bugs.webkit.org/show_bug.cgi?id=115935

Reviewed by Jer Noble.

• WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
• WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference

to the new manifest file.

• WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.

5:32 PM Changeset in webkit [149915] by Simon Fraser

• 3 edits
  4 adds in trunk

REGRESSION (r143626): Element shows as garbage in image gallery
​https://bugs.webkit.org/show_bug.cgi?id=115946

Source/WebCore:

Reviewed by Antti Koivisto.

RenderLayer::backgroundIsKnownToBeOpaqueInRect() used hasVisibleContent()
to check whether the layer's content was hidden via the visibility property.
However, this assumed that a passing hasVisibleContent() check meant that the
entire area was covered by the renderers and layers checked layer.

This is not always true. It's possible to have a visibility:hidden layer
with a non-covering visbility:visible child, or even a single RenderText
child that happens to have visibility:visible style. In these situations,
hasVisibleContent() returns true but the entire area is not painted.

So we have to fall back to on a more conservative check using the
visibility style, which will give is a reliable answer for the current layer.

Tests: compositing/contents-opaque/hidden-with-visible-child.html

compositing/contents-opaque/hidden-with-visible-text.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Antti Koivisto.

Test that dumps layers for a visibility:hidden element with a child text node,
and with a visibility:visible child. The resulting compositing layer should
not be marked as opaque.

• compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
• compositing/contents-opaque/hidden-with-visible-child.html: Added.
• compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
• compositing/contents-opaque/hidden-with-visible-text.html: Added.

5:31 PM Changeset in webkit [149914] by Simon Fraser

• 3 edits
  2 adds in trunk

Garbage down left side of nytimes.com page (if subscriber)
​https://bugs.webkit.org/show_bug.cgi?id=115839

Source/WebCore:

Reviewed by Antti Koivisto.

RenderLayer::backgroundIsKnownToBeOpaqueInRect() would incorrectly return true
for layers where the given rect wasn't contained in the background rect, but
where some child layer obscured the rect, even though clipping hid part
of that child layer.

So bail from RenderLayer::backgroundIsKnownToBeOpaqueInRect() if we have
any overflow clipping. This could be enhanced in future to test whether child
layers obscure the clipping rect, but that would be more expensive.

Test: compositing/contents-opaque/overflow-hidden-child-layers.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Antti Koivisto.

• compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
• compositing/contents-opaque/overflow-hidden-child-layers.html: Added.

4:42 PM Changeset in webkit [149913] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix AppleConnect issues for WiFi interfaces
<rdar://problem/13776227&13776240&13776281>
​https://bugs.webkit.org/show_bug.cgi?id=115932

Patch by Simon Cooper <​scooper@apple.com> on 2013-05-10
Reviewed by Alexey Proskuryakov.

Add support for WiFi interfaces for the AppleConnect plugin.
Remove the FIXME.

• Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:

4:36 PM Changeset in webkit [149912] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt][Mac] Unreviewed speculative build fix after r149904.

• Target.pri:

4:15 PM Changeset in webkit [149911] by mhahnenberg@apple.com

• 8 edits
  2 adds in trunk/Source/JavaScriptCore

Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
​https://bugs.webkit.org/show_bug.cgi?id=115938

We're going to add some more types of check hoisting soon, so let's have the right name here.

Rubber stamped by Filip Pizlo.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
• dfg/DFGStructureCheckHoistingPhase.h: Removed.
• dfg/DFGTypeCheckHoistingPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp.

(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::performTypeCheckHoisting):

• dfg/DFGTypeCheckHoistingPhase.h: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.h.

3:56 PM Changeset in webkit [149910] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareStrictEqConstant
​https://bugs.webkit.org/show_bug.cgi?id=115941

Reviewed by Mark Hahnenberg.

Pretty simple, but factors out the craziness of comparing against null or undefined
in a way that is reusable for both == and ===.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):

3:50 PM Changeset in webkit [149909] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149904.

• Target.pri:

3:22 PM Changeset in webkit [149908] by fpizlo@apple.com

• 7 edits
  2 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareEqConstant
​https://bugs.webkit.org/show_bug.cgi?id=115939

Reviewed by Oliver Hunt and Mark Hahnenberg.

The most interesting part of this patch is the way I make it easier to deal with
the inputs to Phi functions. This adds the notion of ValueFromBlock, which you
can get by doing m_out.anchor(value). You can build up a vector of these, and then
pass them to m_out.phi(type, vector) in one go.

• JavaScriptCore.xcodeproj/project.pbxproj:
• ftl/FTLAbbreviatedTypes.h: Added.

(FTL):

• ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::addIncoming):
(JSC::FTL::buildPhi):

• ftl/FTLAbstractHeapRepository.h:

(FTL):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):

• ftl/FTLOutput.h:

(JSC::FTL::Output::phi):
(Output):
(JSC::FTL::Output::anchor):

• ftl/FTLValueFromBlock.h: Added.

(FTL):
(ValueFromBlock):
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::value):
(JSC::FTL::ValueFromBlock::block):

2:28 PM Changeset in webkit [149907] by zhajiang@rim.com

• 5 edits in trunk

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-10.
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Fix the following warnings for BlackBerry:
BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within

'

' [-Wparentheses].

WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
as truth value [-Wparentheses].
WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
as truth value [-Wparentheses]

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):

Tools:

Fix the following warnings for BlackBerry:
DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
used as truth value [-Wparentheses].

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

2:11 PM Changeset in webkit [149906] by eric.carlson@apple.com

• 8 edits
  2 adds in trunk

In-band captions not visible immediately after track mode change
​https://bugs.webkit.org/show_bug.cgi?id=115922

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-in-band-mode.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged): Add cues for all loaded tracks, regardless

of track type.

LayoutTests:

• media/track/track-in-band-mode-expected.txt: Added.
• media/track/track-in-band-mode.html: Added.

• platform/efl/TestExpectations: Skip new test.
• platform/gtk/TestExpectations: Ditto.
• platform/mac/TestExpectations: Ditto.
• platform/qt/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.

1:54 PM Changeset in webkit [149905] by timothy@apple.com

• 3 edits in trunk/Source/WebCore

Web Inspector: determine the resource type in InspectorResourceAgent::willSendRequest.

This allows the Network timeline and Resources sidebar to filter Resources earlier,
before the server sends a response. Useful for long polling (comet) XHRs.

​https://webkit.org/b/74935
rdar://problem/13726105

Reviewed by Joseph Pecoraro.

• inspector/Inspector.json:

(Network.requestWillBeSent): Added.

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest): Send the type if it isn't Other along in requestWillBeSent.
(WebCore::InspectorResourceAgent::didReceiveResponse): Don't determine the type here anymore. Clear the CachedResource
if isNotModified like the old code path did by not setting cachedResource if !isNotModified.

1:46 PM Changeset in webkit [149904] by weinig@apple.com

• 12 edits
  5 adds in trunk/Source/WebKit2

Unify plug-in information dictionaries
<rdar://problem/13852080>
​https://bugs.webkit.org/show_bug.cgi?id=115891

Reviewed by Anders Carlsson.

This unifies the plug-in information dictionaries vended by WKContextCopyPlugInInfoForBundleIdentifier
and WKContextGetInfoForInstalledPlugIns with those from the WKPageLoaderClient and WKPageUIClient.

All the old keys will continue to work, but have been deprecated in favor of new keys defined in
WKPluginInformation.h

• Shared/API/c/WKPluginInformation.cpp: Added.
• Shared/API/c/WKPluginInformation.h: Added.

Export new keys as SPI.

• Shared/Plugins/Netscape/PluginInformation.h: Added.
• Shared/Plugins/Netscape/PluginInformation.cpp: Added.

(WebKit::pluginInformationBundleIdentifierKey):
(WebKit::pluginInformationBundleVersionKey):
(WebKit::pluginInformationPathKey):
(WebKit::pluginInformationDisplayNameKey):
(WebKit::pluginInformationDefaultLoadPolicyKey):
(WebKit::pluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WebKit::pluginInformationHasSandboxProfileKey):
(WebKit::pluginInformationFrameURLKey):
(WebKit::pluginInformationMIMETypeKey):
(WebKit::pluginInformationPageURLKey):
(WebKit::pluginInformationPluginspageAttributeURLKey):
(WebKit::pluginInformationPluginURLKey):
Add new keys.

(WebKit::pluginModuleInformation):
(WebKit::createPluginInformationDictionary):
Add creation functions to simplify multiple sites.

• Shared/Plugins/Netscape/mac/PluginInformationMac.mm: Added.

(WebKit::platformPluginModuleInformation):
Add platform specific data to the dictionary.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):
(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):

• UIProcess/API/C/WKPage.h:

Deprecate the old keys.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier):
(WKContextGetInfoForInstalledPlugIns):
Simplify by using the new createPluginInformationDictionary functions.

(WKPlugInInfoPathKey):
(WKPlugInInfoBundleIdentifierKey):
(WKPlugInInfoVersionKey):
(WKPlugInInfoLoadPolicyKey):
(WKPlugInInfoUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WKPlugInInfoIsSandboxedKey):
Deprecate the old keys.

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):

• UIProcess/WebLoaderClient.h:
• UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::unavailablePluginButtonClicked):

• UIProcess/WebUIClient.h:

Optimize for the most recent callback type which takes a dictionary,
and pull out the necessary bits from it for deprecated callbacks as necessary.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Use createPluginInformationDictionary() consistently, to get consistent results for callbacks.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:35 PM Changeset in webkit [149903] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Web Inspector: implement runOpenPanel callback for WebKit2 inspector
​https://bugs.webkit.org/show_bug.cgi?id=115865

Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Sam Weinig.

• UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::inspectorWindow):
Add an accessor for m_inspectorWindow.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::runOpenPanel):
Show the open panel dialog when requested.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Register the callback when the inspector page is created.

1:34 PM Changeset in webkit [149902] by commit-queue@webkit.org

• 13 edits in trunk

[WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
​https://bugs.webkit.org/show_bug.cgi?id=115928

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-05-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WKViewSetThemePath was moved to WKViewEfl.h since it is EFL specific.

• UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
• UIProcess/API/C/CoordinatedGraphics/WKView.h:
• UIProcess/API/C/efl/WKViewEfl.cpp:

(WKViewSetThemePath):

• UIProcess/API/C/efl/WKViewEfl.h:
• UIProcess/CoordinatedGraphics/WebView.cpp:
• UIProcess/CoordinatedGraphics/WebView.h:

(WebView):

• UIProcess/efl/ViewClientEfl.cpp:
• UIProcess/efl/WebInspectorProxyEfl.cpp:
• UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::setThemePath):

• UIProcess/efl/WebViewEfl.h:

(WebViewEfl):

Tools:

WKViewSetThemePath was moved to WKViewEfl.h.

• TestWebKitAPI/efl/PlatformWebView.cpp:

12:24 PM Changeset in webkit [149901] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed mac-lion rebaselines.

• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:

12:12 PM Changeset in webkit [149900] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareStrictEq
​https://bugs.webkit.org/show_bug.cgi?id=115927

Reviewed by Mark Hahnenberg.

Do the sensible thing, and make it so that for common cases, CompareEq is
implemented in terms of CompareStrictEq in the FTL backend. All of the cases
we currently support can be done this way.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):

12:10 PM Changeset in webkit [149899] by Laszlo Gombos

• 5 edits in trunk/Source/WebCore

[CMake] Consolidate list of files to build for WebCore plugin support
​https://bugs.webkit.org/show_bug.cgi?id=104429

Reviewed by Rob Buis.

Move the common files to support plugins and the logic for disabling
plugins) to CMakeLists.txt from PlatformXXX.cmake.

No new tests as there is no new functionality.

• CMakeLists.txt:
• PlatformBlackBerry.cmake:
• PlatformEfl.cmake:
• PlatformWinCE.cmake:

12:04 PM Changeset in webkit [149898] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Int32ToDouble
​https://bugs.webkit.org/show_bug.cgi?id=115926

Reviewed by Mark Hahnenberg.

This node exists mainly to help the DFG see that a node may have both an int
and a double representation. But in the FTL, nodes already have multiple
representations. So this is just a no-op for the FTL.

I considered making it so that the node isn't even inserted if we're doing
FTL compilation, but that would have required a bunch of conditionalizing in
the DFG's optimization phases, which sort of expect this node to be present
and necessary.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(LowerDFGToLLVM):

12:02 PM Changeset in webkit [149897] by robert@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r148121): Empty Span does not get a linebox when it's in an anonymous block
​https://bugs.webkit.org/show_bug.cgi?id=115818

Reviewed by David Hyatt.

Source/WebCore:

r148121 only worried about split inlines inside anonymous blocks - it ought to have
catered for empty inlines, with no continuations, inside a single solitary anonymous block too.

Test: fast/inline/anonymous-block-with-empty-inline.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::hasInlineDirectionBordersPaddingOrMargin):

LayoutTests:

• fast/inline/anonymous-block-with-empty-inline-expected.txt: Added.
• fast/inline/anonymous-block-with-empty-inline.html: Added.

11:47 AM Changeset in webkit [149896] by fpizlo@apple.com

• 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support LogicalNot
​https://bugs.webkit.org/show_bug.cgi?id=115924

Reviewed by Mark Hahnenberg.

• ftl/FTLAbbreviations.h:

(JSC::FTL::buildNot):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(LowerDFGToLLVM):

• ftl/FTLOutput.h:

(JSC::FTL::Output::bitNot):

11:39 AM Changeset in webkit [149895] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GTK] Remove unnecessary includes in WidgetGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115912

Reviewed by Andreas Kling.

No new tests - no new functionality.

• platform/gtk/WidgetGtk.cpp: Remove the unnecessary includes of the Chrome.h, Frame.h, FrameView.h,

Page.h and RenderObject.h headers as the included declarations are not used anywhere. ScrollView.h is
included instead as it is required and was previously included by one of the removed header inclusions.

11:38 AM Changeset in webkit [149894] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Cairo] Remove the unnecessary ImageData.h include in ImageBufferCairo.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115911

Reviewed by Carlos Garcia Campos.

No new tests - no new functionality.

• platform/graphics/cairo/ImageBufferCairo.cpp: Remove the ImageData.h include

as the included declarations are not used anywhere.

11:37 AM Changeset in webkit [149893] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115910

Reviewed by Laszlo Gombos.

No new tests - no new functionality.

• platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include

as the included declarations are not used anywhere.

11:31 AM Changeset in webkit [149892] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareGreater, CompareLessEq, and CompareGreaterEq
​https://bugs.webkit.org/show_bug.cgi?id=115923

Reviewed by Mark Hahnenberg.

Also fixed a bug where double CompareLess would assert.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):

11:20 AM Changeset in webkit [149891] by dino@apple.com

• 3 edits
  2 adds in trunk

Include tab character as a word end for kerning
​https://bugs.webkit.org/show_bug.cgi?id=115915
<rdar://problem/13861491>

Reviewed by Enrica Casucci.

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=112507
which only looked for a space character as a word end. It should
look for tab characters too.

Source/WebCore:

Test: fast/text/word-space-with-kerning-4.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Look for '\t'.

LayoutTests:

• fast/text/word-space-with-kerning-4-expected.html: Added.
• fast/text/word-space-with-kerning-4.html: Added.

11:12 AM Changeset in webkit [149890] by fpizlo@apple.com

• 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL CompareEq ObjectUse should handle masquerading
​https://bugs.webkit.org/show_bug.cgi?id=115920

Reviewed by Mark Hahnenberg.

We don't yet support watchpoints, but this does all the wiring right up to the
part where we would have emitted watchpoints. I've also written this in a way that
makes it easy to use the case where you would have anyway speculated non-masquerading
even if the watchpoint was invalidated.

This is inherently racy, of course: but the only race here is that you might first
set the watchpoint, and then the watchpoint is invalidated, and then you compile rest
of the code in a way that doesn't need the watchpoint. That's fine, since the FTL
will remember that it had set the watchpoint and then cancel the compilation.

• ftl/FTLAbbreviations.h:

(JSC::FTL::int8Type):

• ftl/FTLAbstractHeapRepository.h:

(FTL):

• ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

• ftl/FTLCommonValues.h:

(CommonValues):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowNonNullObject):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):

• ftl/FTLOutput.h:

(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::load8):
(JSC::FTL::Output::isZero8):
(JSC::FTL::Output::notZero8):
(JSC::FTL::Output::testIsZero8):
(JSC::FTL::Output::testNonZero8):

10:48 AM Changeset in webkit [149889] by akling@apple.com

• 2 edits in trunk/Tools

I accidentally the Java testing.

• Scripts/webkitpy/port/mac.py:

10:39 AM Changeset in webkit [149888] by andersca@apple.com

• 8 edits
  2 deletes in trunk/Source/WebCore

Remove EventTracer
​https://bugs.webkit.org/show_bug.cgi?id=115916

Reviewed by Sam Weinig.

EventTracer is dead code, remove it.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• platform/EventTracer.cpp: Removed.
• platform/EventTracer.h: Removed.

10:36 AM Changeset in webkit [149887] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GTK] Generated files are regenerated always
​https://bugs.webkit.org/show_bug.cgi?id=115908

Reviewed by Carlos Garcia Campos.

No new tests - no change in functionality.

• GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.

The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.

10:34 AM Changeset in webkit [149886] by akling@apple.com

• 10 edits in trunk

Caching of generated images in CSS should be smarter.
<​http://webkit.org/b/115902>
<rdar://problem/13542727>

Reviewed by Antti Koivisto.

Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level.

CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache.
Generated images are kept for 3 seconds after last use.

The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc)
would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested
for each of the descendent renderers that inherit their background from the same parent.
The cache wasn't smart enough for this, it just thought the background renderer was changing size
a lot, and would regenerate the image over and over.

We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern().
This removes the eviction timer from that cache so that the intermediate images can live a bit longer.

(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):

Renamed from getImage() and putImage().

(WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):

Let the CachedGeneratedImage throw itself out from cache when the timer fires.

• css/CSSImageGeneratorValue.h:

(CachedGeneratedImage):

Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size
as the hash key.

• platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):

• platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

Keep the intermediate image for drawPattern() until destruction instead of dropping it on
a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache
after 3 seconds of disuse rather than kept for the lifetime of the renderer.

• css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

• css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

• rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::addClient):

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):

CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly.

10:20 AM Changeset in webkit [149885] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r149439): Video turns blank upon entering full screen for the first time
​https://bugs.webkit.org/show_bug.cgi?id=115617

Reviewed by Eric Carlson.

Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
first-full screen behavior.

• UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

10:16 AM Changeset in webkit [149884] by zandobersek@gmail.com

• 7 edits in trunk/Source/WebKit2

[WK2] Make the WebSoupRequestManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115717

Reviewed by Andreas Kling.

WebSoupRequestManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_soupRequestManager member variable in
the WebProcess class and brings the WebSoupRequestManager in line with other manager classes
of which instances are controlled by the WebProcess class.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebSoupRequestManager as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_soupRequestManager member variable and its getter method.

• WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync): Access the WebSoupRequestManager as a supplement.
(webkitSoupRequestGenericSendFinish): Ditto.

• WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Access the WebSoupRequestManager as a supplement.

• WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::supplementName): Specify the supplement's name.

• WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager): Inherit from the WebProcessSupplement interface.

10:04 AM Changeset in webkit [149883] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Module Cairo fails to build under jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=115854

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-05-10
Reviewed by Martin Robinson.

Make cairo depend on glib in jhbuild.modules.

• gtk/jhbuild.modules:

10:03 AM Changeset in webkit [149882] by andersca@apple.com

• 10 edits
  3 deletes in trunk/Source/WebCore

Remove MemoryUsageSupport class
​https://bugs.webkit.org/show_bug.cgi?id=115913

Reviewed by Andreas Kling.

MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent,
and the function called always returns zero on all platforms! Remove it.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorMemoryAgent.cpp:
• inspector/InspectorTimelineAgent.cpp:

(WebCore):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):

• platform/MemoryUsageSupport.cpp: Removed.
• platform/MemoryUsageSupport.h: Removed.
• platform/qt/MemoryUsageSupportQt.cpp: Removed.

9:38 AM Changeset in webkit [149881] by rniwa@webkit.org

• 7 edits
  2 adds in trunk

REGRESSION (r149652): Videos do not play on cnn.com, just black box
​https://bugs.webkit.org/show_bug.cgi?id=115887

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by window and document named item maps counting the same element twice
when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove
an element per id and name attribute updates when it had already been added or removed by
name and id attribute updates respectively.

We do this by checking whether the other attribute affects the element's precense in window
and document named item maps and avoiding to add or remove the attribute when they do and
the other attribute is present in updateId and updateName.

Consider a scenario when an object element has id "foo", and name attribute is about to be also
set to "foo". If the id attribute doesn't affect element's presense in window or document
named item maps, we're done. If it does, then the maps already have this element so we don't
want to add it again. Conversely, if the element already has id and name attributes set to
"foo", and we're moving the id attribute, then we want to remove the element from the maps only
if the id doesn't affect the presence of the element in the maps.

Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely
because updateId and updateName are called when both id and name attributes are present so skip
this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry.

Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html

fast/dom/HTMLDocument/object-with-same-id-and-name.html

• dom/Element.cpp:

(WebCore::Element::insertedInto): Call updateId and updateName with
AlwaysUpdateHTMLDocumentNamedItemMaps.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::updateName): Don't add or remove this element if the id attribute has already
done so except when we're inserting, removing, or cloning an element.
(WebCore::Element::updateId): Ditto for the name attribute.
(WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this
function when this element is in the document. We can't update window and documemt named item
maps here because image element's id attribute value, for example, is present in the document's
named item map if it has a name attribute. Since this function calls updateId and updateName
before updating attributes, this check is going to fail in DocumentNameCollection's
nodeMatchesIfIdAttributeMatch and bad things will happen.

• dom/Element.h:

• editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before
inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

LayoutTests:

Add regression tests.

• fast/dom/HTMLDocument/image-with-same-id-and-name-expected.txt: Added.
• fast/dom/HTMLDocument/image-with-same-id-and-name.html: Added.
• fast/dom/HTMLDocument/object-with-same-id-and-name-expected.txt: Added.
• fast/dom/HTMLDocument/object-with-same-id-and-name.html: Added.

9:18 AM Changeset in webkit [149880] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Don't trust character widths for internal OS X fonts in form controls
​https://bugs.webkit.org/show_bug.cgi?id=115883
<rdar://problem/13817757>

Reviewed by Darin Adler.

We ignore the character width for a bunch of fonts when predicting
the width of a form control. Some of the internal fonts in OS X are
not in the ignored list. Rather than add them, simply test for
fonts whose family begins with a period character ".".

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for

any family that starts with "."

9:11 AM Changeset in webkit [149879] by Carlos Garcia Campos

• 11 edits in trunk

[GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=115904

Reviewed by Martin Robinson.

Source/WebCore:

• bindings/gobject/WebKitDOMEventTarget.cpp:
• platform/gtk/GtkVersioning.c:
• platform/gtk/GtkVersioning.h:

Source/WebKit2:

• UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(startTestServerMonitor):

• UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:

(startTestServerMonitor):

Source/WTF:

• wtf/gobject/GRefPtr.cpp:

Tools:

• ImageDiff/gtk/ImageDiff.cpp:

(main):

9:01 AM Changeset in webkit [149878] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864.

• workers/SharedWorkerThread.cpp: include "SecurityOrigin.h"

8:27 AM Changeset in webkit [149877] by kbalazs@webkit.org

• 2 edits in trunk/Tools

Add my new address to contributors.json. (Unreviewed)

• Scripts/webkitpy/common/config/contributors.json:

7:05 AM Changeset in webkit [149876] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

Fix build after r149864.

Unreviewed build fix.

• loader/ThreadableLoader.h: include <wtf/text/AtomicString.h>

when building with RESOURCE_TIMING enabled.

6:26 AM WebKit Team edited by Christophe Dumez

Move myself to the Reviewers list (diff)

6:19 AM Changeset in webkit [149875] by Christophe Dumez

• 2 edits in trunk/Tools

Unreviewed. Move myself to the reviewers list.

• Scripts/webkitpy/common/config/contributors.json:

6:16 AM Changeset in webkit [149874] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/dom/Range/getClientRects.html for EFL port.
Skip accessibility/poorly-formed-aria-table.html introduced in
r149858 but failing on EFL port.

• platform/efl/TestExpectations:
• platform/efl/fast/dom/Range/getClientRects-expected.txt:

6:00 AM Changeset in webkit [149873] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Fix build.

• bindings/js/ScriptController.cpp:

5:53 AM Changeset in webkit [149872] by zarvai@inf.u-szeged.hu

• 2 edits
  2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/fast/js/global-constructors-attributes-expected.txt: Rebaselining after r149845.
• platform/qt/inspector/console/command-line-api-expected.txt: Added after r149829.

5:51 AM Changeset in webkit [149871] by andersca@apple.com

• 13 edits
  1 delete in trunk/Source/WebCore

Remove ScriptInstance.h
​https://bugs.webkit.org/show_bug.cgi?id=115900

Reviewed by Andreas Kling.

Remove yet another abstraction now that we don't support V8.

• GNUmakefile.list.am:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/ScriptController.h:

(Bindings):
(ScriptController):

• bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::createScriptInstanceForWidget):

• bindings/js/ScriptInstance.h: Removed.
• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::getInstance):

• html/HTMLPlugInElement.h:

(Bindings):
(HTMLPlugInElement):

• platform/graphics/wince/MediaPlayerProxy.h:

(WebMediaPlayerProxy):

• rendering/RenderEmbeddedObject.cpp:
• rendering/RenderSnapshottedPlugIn.cpp:

5:49 AM Changeset in webkit [149870] by Christophe Dumez

• 3 edits
  3 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Skip several remaining shadow dom tests and rebaseline a few others.

• platform/efl/TestExpectations:
• platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
• platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt:
• platform/efl/inspector/console/command-line-api-expected.txt: Added.

5:22 AM Changeset in webkit [149869] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r149866.
​http://trac.webkit.org/changeset/149866
​https://bugs.webkit.org/show_bug.cgi?id=115898

Broke tests

• dom/Document.cpp:

(WebCore::Document::setDomain):
(WebCore::Document::initSecurityContext):

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::setDomainFromDOM):
(WebCore::SecurityOrigin::grantUniversalAccess):

• page/SecurityOrigin.h:

(SecurityOrigin):

5:21 AM Changeset in webkit [149868] by Christophe Dumez

• 2 edits in trunk/Tools

Unreviewed. Add my email to a few watchlists.

• Scripts/webkitpy/common/config/watchlist:

5:17 AM Changeset in webkit [149867] by abucur@adobe.com

• 3 edits in trunk/Source/WebCore

Remove overflow dead code
​https://bugs.webkit.org/show_bug.cgi?id=115893

Reviewed by Antti Koivisto.

The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.

Tests: no tests, code cleanup.

• rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
• rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,

setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
setMinXVisualOverflow and setMaxXVisualOverflow.

4:59 AM Changeset in webkit [149866] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Begin making SecurityOrigin immutable
​https://bugs.webkit.org/show_bug.cgi?id=115898

Reviewed by Andreas Kling.

Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with
member functions that return new SecurityOrigin objects.

• dom/Document.cpp:

(WebCore::Document::setDomain):
Update the security origin to one returned by copyWithDomainSetFromDOM.

(WebCore::Document::initSecurityContext):
Set the security origin to one returned by copyWithUniversalAccessGranted().

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment,
but all the boolean parameters could be replaced by a bitmask of flags.

(WebCore::SecurityOrigin::isolatedCopy):
Call the new constructor.

(WebCore::SecurityOrigin::copyWithDomainSetFromDOM):
Return a new security origin with m_domainWasSetInDOM set to true and the domain updated.

(WebCore::SecurityOrigin::copyWithUniversalAccessGranted):
Return a new security origin with m_universalAccess set to true.

4:18 AM Changeset in webkit [149865] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Remove ScriptController::updateSecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=115895

Reviewed by Antti Koivisto.

ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone.

• bindings/js/ScriptController.cpp:
• bindings/js/ScriptController.h:
• dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::setDomain):

• dom/Document.h:

(Document):

• dom/SecurityContext.cpp:

(WebCore::SecurityContext::enforceSandboxFlags):

• dom/SecurityContext.h:

(SecurityContext):

4:12 AM Changeset in webkit [149864] by andersca@apple.com

• 15 edits in trunk/Source/WebCore

Stop including SecurityOrigin.h where unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=115897

Reviewed by Antti Koivisto.

Move rarely called functions out of line so headers don't have to include SecurityOrigin.h

• Modules/indexeddb/IDBFactoryBackendImpl.h:
• Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::databaseDebugName):

• Modules/webdatabase/DatabaseBackendBase.h:

(DatabaseBackendBase):

• Modules/webdatabase/DatabaseSync.h:
• bindings/js/JSDOMWindowCustom.h:
• html/parser/XSSAuditor.cpp:
• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
(WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions):
(WebCore::ThreadableLoader::create):

• loader/ThreadableLoader.h:

(ThreadableLoaderOptions):

• loader/WorkerThreadableLoader.cpp:
• workers/DedicatedWorkerContext.cpp:
• workers/DedicatedWorkerThread.cpp:
• workers/SharedWorkerContext.cpp:
• workers/WorkerThread.cpp:
• workers/WorkerThread.h:

2:37 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com

(diff)

2:32 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com

(diff)

2:29 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com

(diff)

1:45 AM Changeset in webkit [149863] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Unicode support missing from string representation of Contributors in committers.py
​https://bugs.webkit.org/show_bug.cgi?id=115859

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-05-10
Reviewed by Darin Adler.

Contributors, in committers.py, provided a string representation in str which
didn't support unicode characters, so printing a contributor would fail in that case.
This patch implements unicode and makes str use it to represent a contributor.
The unit tests are updated accordingly, so they ensure that a unicode name can be shown.

• Scripts/webkitpy/common/config/committers.py: Move the existing string representation

to the newly implemented method unicode, and make str display its utf-8 encoded
representation.
(Contributor.str):
(Contributor):
(Contributor.unicode):

• Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that

a contributor with unicode characters can be represented as a string.
(CommittersTest):
(CommittersTest.test_contributor_encoding):

12:41 AM Changeset in webkit [149862] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r149839.

• platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):

May 9, 2013:

8:29 PM Changeset in webkit [149861] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG shouldn't allocate in the GC heap
​https://bugs.webkit.org/show_bug.cgi?id=115598

Reviewed by Geoffrey Garen.

I believe that we've now fixed this, and this patch just adds the relevant assertion.

• runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

7:45 PM Changeset in webkit [149860] by fpizlo@apple.com

• 12 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CodeBlock should be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=115594

Reviewed by Geoffrey Garen.

This makes it possible to have the currently-being-compiled CodeBlock not be
installed in Executable, while also allowing it to point to its intended
alternative(). So long as we were using ownership and not reference counting, it
would have been difficult to have both CodeBlock::m_alternative and
Executable::m_codeBlockForBlah point to the previous CodeBlock.

I also took the opportunity to clean up a bunch of code that appears to have
rotted.

• assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::operator==):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::releaseAlternative):
(JSC::CodeBlock::setAlternative):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

• heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

• heap/DFGCodeBlocks.h:

(DFGCodeBlocks):

• heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):

• heap/Heap.h:
• jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

• runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(EvalExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::codeBlockFor):

• runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

6:46 PM Changeset in webkit [149859] by commit-queue@webkit.org

• 6 edits in trunk/LayoutTests

Unskipped the webarchive tests for Mac that are not skipped for a reason other than
dumpDOMAsWebArchive not being implemented, which was fixed in r149692.
​https://bugs.webkit.org/show_bug.cgi?id=115819

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-09
Reviewed by Benjamin Poulain.

• platform/efl-wk2/TestExpectations:

Skip webarchive tests.

• platform/gtk-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-mac-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-wk2/TestExpectations:

Skip webarchive tests.

• platform/wk2/TestExpectations:

Removed universal skipping of webarchive tests, noted which tests are still skipped with bug numbers.

5:57 PM Changeset in webkit [149858] by Chris Fleizach

• 10 edits
  2 adds in trunk

AX: VoiceOver is no longer seeing items in poorly formed tables
​https://bugs.webkit.org/show_bug.cgi?id=115837

Reviewed by Darin Adler.

Source/WebCore:

In case the author didn't include the rows of a table as the
direct children, a table needs to dive down its descendant chain
until the rows are found.

I also took the opportunity to clean up a bit around what the different
meanings of table are in the accessibility classes.

Test: accessibility/poorly-formed-aria-table.html

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):
(WebCore::AccessibilityARIAGrid::addChildren):

• accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

• accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore):

• accessibility/AccessibilityARIAGridRow.h:

(AccessibilityARIAGridRow):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isTable):

• accessibility/AccessibilityTable.h:

(AccessibilityTable):
(WebCore::AccessibilityTable::isTable):
(WebCore::toAccessibilityTable):

• accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

• accessibility/poorly-formed-aria-table-expected.txt: Added.
• accessibility/poorly-formed-aria-table.html: Added.

5:12 PM Changeset in webkit [149857] by zoltan@webkit.org

• 6 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
​https://bugs.webkit.org/show_bug.cgi?id=115053

Reviewed by Alexandru Chiculita.

I changed the tests to use Ahem font (overflow will be the same on every port) and modify the markup in order to be the similar
for the two tests. The change fixes both tests and make them passing on Qt as well. I removed the tests from the TestExpectations.

• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
• fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
• fast/exclusions/shape-inside/shape-inside-percentage.html:
• platform/qt/TestExpectations:

4:55 PM Changeset in webkit [149856] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

REGRESSION: Disabled multiline select element now responds to (certain) clicks
​https://bugs.webkit.org/show_bug.cgi?id=115710

Patch by Yael Aharon <​yael.aharon@intel.com> on 2013-05-09
Reviewed by Kent Tamura.

Source/WebCore:

After ​http://trac.webkit.org/changeset/140286, select elements can scroll whether they
are disabled or not. While they scroll, they also change the selected item.
This patch allows the select element to scroll, but does not change the selection
if the select element is disabled.

Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
Test: fast/forms/select/listbox-disabled-no-autoscroll.html

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::stopAutoscroll):

LayoutTests:

Test that a disabled element does not change selection while scrolling.

• fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt: Added.
• fast/forms/select/listbox-disabled-scroll-no-onchange.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll-expected.html: Added.

4:47 PM Changeset in webkit [149855] by Patrick Gansterer

• 4 edits in trunk/Tools

[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
​https://bugs.webkit.org/show_bug.cgi?id=92371

Reviewed by Brent Fulgham.

Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().

• DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
• DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem):
(dumpBackForwardList):

• DumpRenderTree/win/DumpRenderTree.vcproj:

4:41 PM Changeset in webkit [149854] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Clean up SecurityOrigin::databaseIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=115882

Reviewed by Beth Dakin.

Remove m_encodedHost and just call encodeHost from databaseIdentifier().
Also, use a StringBuilder when constructing the database identifier to avoid allocating
temporary String objects over and over.

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::databaseIdentifier):

• page/SecurityOrigin.h:

(SecurityOrigin):

4:21 PM Changeset in webkit [149853] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Remove m_securityOrigin from XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=115881

Reviewed by Alexey Proskuryakov.

The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):

• xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:03 PM Changeset in webkit [149852] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

3:50 PM Changeset in webkit [149851] by fpizlo@apple.com

• 16 edits
  4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should have its own notion of StructureChain, and it should be possible to validate it after compilation finishes
​https://bugs.webkit.org/show_bug.cgi?id=115841

Reviewed by Oliver Hunt.

This adds IntendedStructureChain, which is like StructureChain, except that it holds a bit
more information and can be validated independantly of its owning Structure and lexical
GlobalObject, since it remembers both of those things. It's also malloc'd and RefCounted
rather than GC'd, so it can be allocated in a concurrent compilation thread.

Gave this class a bunch of methods to allow the following idiom:

• Snapshot a structure chain concurrently. This structure chain may end up being wrong in case of races, but in that case we will find out when we try to validate it.

• Perform validation on the structure chain itself, without recomputing the chain. Previously, many chain validation methods (prototypeChainMayInterceptStoreTo() for example) recomputed the chain, and hence, were inherently racy: you could build one chain and then validate against a different chain, and hence not realize that the chain you did build was actually broken for your purposes, because the chain you checked was a different one.

• Validate that the chain is still the right one at any time, allowing the cancellation of compilation if there was a race.

Also added DFG::DesiredStructureChains, which tracks those intended structure chains that
the compiler had already chosen to use. If any of those are invalid at link time, throw
out the compilation.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

• bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::chain):
(GetByIdStatus):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

• bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::structureChain):
(PutByIdStatus):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDesiredStructureChains.cpp: Added.

(DFG):
(JSC::DFG::DesiredStructureChains::DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::~DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::areStillValid):

• dfg/DFGDesiredStructureChains.h: Added.

(DFG):
(DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::addLazily):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isStillValid):
(DFG):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• runtime/IntendedStructureChain.cpp: Added.

(JSC):
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::~IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::matches):
(JSC::IntendedStructureChain::chain):
(JSC::IntendedStructureChain::mayInterceptStoreTo):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):

• runtime/IntendedStructureChain.h: Added.

(JSC):
(IntendedStructureChain):
(JSC::IntendedStructureChain::head):
(JSC::IntendedStructureChain::size):
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
(JSC::IntendedStructureChain::last):

• runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::storedPrototypeObject):
(JSC):
(JSC::Structure::storedPrototypeStructure):

3:40 PM Changeset in webkit [149850] by Christophe Dumez

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r149836.

It broke at least EFL and GTK builds. Move new static members initialization
outside the class. Those need to have a definition outside the class because
their address is used (e.g. CodeCacheMap::nonGlobalWorkingSetMaxEntries).

• runtime/CodeCache.cpp:

(JSC):

• runtime/CodeCache.h:

(CodeCacheMap):

3:39 PM Changeset in webkit [149849] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Enable UI process storage
​https://bugs.webkit.org/show_bug.cgi?id=115879
<rdar://problem/12239765>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Flip the switch.

3:37 PM Changeset in webkit [149848] by andersca@apple.com

• 121 edits in trunk/Source/WebKit2

Remove extra spaces between right angle brackets in template declarations
​https://bugs.webkit.org/show_bug.cgi?id=115877

Reviewed by Beth Dakin.

C++11 doesn't require spaces between right angle brackets so remove all of them.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::sandboxExtensions):

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:

(NetworkBlobRegistry):

• NetworkProcess/HostRecord.h:

(HostRecord):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):

• NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcess):

• NetworkProcess/NetworkProcess.h:

(NetworkProcess):

• NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):

• NetworkProcess/NetworkResourceLoadScheduler.h:
• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• NetworkProcess/SchedulableLoader.h:

(SchedulableLoader):

• Platform/CoreIPC/ArgumentCoders.h:
• Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

• Platform/CoreIPC/Connection.h:

(Connection):

• Platform/WorkQueue.h:

(WorkQueue):

• PluginProcess/PluginProcess.h:

(PluginProcess):

• Scripts/webkit2/messages_unittest.py:

(CoreIPC):

• Shared/BlockingResponseMap.h:

(BlockingResponseMap):

• Shared/ChildProcessProxy.h:

(ChildProcessProxy):

• Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):

• Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(ImmutableArray):

• Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

• Shared/ImmutableDictionary.h:

(ImmutableDictionary):

• Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

• Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

• Shared/SessionState.cpp:
• Shared/StatisticsData.h:

(StatisticsData):

• Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

• Shared/WebArchive.cpp:

(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

• Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

• Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

• UIProcess/API/mac/WKPrintingView.h:

(WebFrameProxy):

• UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _drawPreview:]):

• UIProcess/API/mac/WKView.mm:

(WebKit):

• UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):

• UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:

(GeolocationPermissionRequestManagerProxy):

• UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:

(DynamicLinkerEnvironmentExtractor):

• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(CustomProtocolManagerProxy):

• UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:

(NotificationPermissionRequestManagerProxy):

• UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

• UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

• UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

• UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

• UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

• UIProcess/SharedWorkers/SharedWorkerProcessManager.h:

(SharedWorkerProcessManager):

• UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(SharedWorkerProcessProxy):

• UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

• UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::invalidateConnectionInternal):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

• UIProcess/WebBackForwardList.h:

(WebKit):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::enableProcessTermination):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

• UIProcess/WebContext.h:

(WebContext):

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

• UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

• UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

• UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

• UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

• UIProcess/WebFormClient.h:

(WebFormClient):

• UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

• UIProcess/WebLoaderClient.h:

(WebLoaderClient):

• UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

• UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

• UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

• UIProcess/WebPageProxy.cpp:

(ExceededDatabaseQuotaRecords):
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::pluginInformationDictionary):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::didReceiveEvent):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):

• WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):

• WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

• WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

(InjectedBundlePageEditorClient):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

(InjectedBundlePageFormClient):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

• WebProcess/Network/WebResourceLoadScheduler.h:

(WebResourceLoadScheduler):

• WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

• WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

(NPRuntimeObjectMap):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

• WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(NetscapePluginStream):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::runScriptsInPDFDocument):

• WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelAllStreams):

• WebProcess/Plugins/PluginView.h:

(PluginView):

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):

• WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

• WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

• WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::keyValueStorageOriginIdentifiers):

• WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::getClientPasteboardDataForRange):

• WebProcess/WebCoreSupport/WebEditorClient.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findStringMatches):

• WebProcess/WebPage/FindController.h:

(FindController):

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

• WebProcess/WebPage/WebPage.h:

(WebKit):
(WebPage):

• WebProcess/WebPage/mac/LayerTreeHostMac.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::webPageGroup):
(WebKit::addCaseFoldedCharacters):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setTextCheckerState):

• WebProcess/WebProcess.h:

(WebProcess):

3:26 PM Changeset in webkit [149847] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Implement WebPlatformStrategies::transientLocalStorageNamespace
​https://bugs.webkit.org/show_bug.cgi?id=115876
<rdar://problem/13852871>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
Return a session storage namespace for a random page when UI process storage is enabled,
otherwise call the base class implementation.

3:09 PM Changeset in webkit [149846] by roger_fong@apple.com

• 1 edit
  2 adds
  1 delete in trunk/LayoutTests

Unreviewed mac gardening.

• platform/mac/inspector/command-line-api-expected.txt: Removed.
• platform/mac/inspector/console: Added.
• platform/mac/inspector/console/command-line-api-expected.txt: Added.

2:47 PM Changeset in webkit [149845] by Christophe Dumez

• 17 edits in trunk

[NoInterfaceObject] extended attribute should be removed for several interfaces
​https://bugs.webkit.org/show_bug.cgi?id=115852

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove [NoInterfaceObject] extended attribute from the following Web IDL
interfaces: SecurityPolicy, History, Location, Navigator, Performance,
PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
PerformanceResourceTiming, PerformanceTiming and Screen.

These interfaces should not have the [NoInterfaceObject] extended attribute
according to their respective specifications:

• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
• ​https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
• ​http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
• ​http://www.w3.org/TR/navigation-timing/#performance
• ​https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
• ​http://www.w3.org/TR/navigation-timing/#performancenavigation
• ​http://www.w3.org/TR/navigation-timing/#performancetiming
• ​http://www.w3.org/TR/user-timing/#performancemark
• ​http://www.w3.org/TR/user-timing/#performancemeasure
• ​http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
• ​http://dev.w3.org/csswg/cssom-view/#the-screen-interface

The new behavior is consistent with the specifications, Firefox and soon Blink.

No new tests, already covered by existing tests.

• page/DOMSecurityPolicy.idl:
• page/History.idl:
• page/Location.idl:
• page/Navigator.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:

LayoutTests:

Rebaseline several layout tests whose output has changed now that a few more
global constructors are exposed.

• fast/dom/dom-constructors-expected.txt:
• fast/js/global-constructors-attributes-expected.txt:
• platform/efl/fast/js/global-constructors-attributes-expected.txt:

2:45 PM Changeset in webkit [149844] by robert@webkit.org

• 4 edits
  1 move
  3 deletes in trunk

REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
​https://bugs.webkit.org/show_bug.cgi?id=26394

Reviewed by David Hyatt.

Source/WebCore:

Text controls or any object that has scrollable content should not flex inside a table cell.
This makes our behaviour the same as IE, FF and Opera (Presto).

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

• fast/replaced/table-percent-height-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt.
• fast/replaced/table-percent-height-text-controls.html:
• platform/gtk/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.

2:35 PM Changeset in webkit [149843] by Patrick Gansterer

• 2 edits
  1 move in trunk/Tools

[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
​https://bugs.webkit.org/show_bug.cgi?id=92505

Reviewed by Brent Fulgham.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.

(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

• DumpRenderTree/pthreads: Removed.
• DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.

2:34 PM Changeset in webkit [149842] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.

• WebCore.exp.in:

2:18 PM Changeset in webkit [149841] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Update srcipt paths in editing/shadow/rightclick-on-meter-in-shadow-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=96223

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-05-09
Reviewed by Rob Buis.

The original paths don't exist at all.

• editing/shadow/rightclick-on-meter-in-shadow-crash.html:

2:03 PM Changeset in webkit [149840] by andersca@apple.com

• 14 edits in trunk/Source/WebCore

Add a StorageStrategy hook for creating transient local storage namespaces
​https://bugs.webkit.org/show_bug.cgi?id=115870

Reviewed by Geoffrey Garen.

• WebCore.exp.in:

Export symbol needed by WebKit2.

• dom/Document.cpp:

(WebCore::Document::topOrigin):

• dom/Document.h:
• dom/ScriptExecutionContext.h:
• workers/WorkerContext.h:

Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.

• page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):
Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.

• page/PageGroup.h:

Update HashMap declaration.

• storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::transientLocalStorageNamespace):
Add new implementation that will optionally call out to the storage strategy.

• storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
Move the default implementation here from PageGroup.

• storage/StorageStrategy.cpp:

(WebCore::StorageStrategy::transientLocalStorageNamespace):
Call the default implementation.

1:54 PM Changeset in webkit [149839] by enrica@apple.com

• 4 edits in trunk/Source/WebCore

A change in system environment should force all CSS properties to be recomputed.
​https://bugs.webkit.org/show_bug.cgi?id=115872
<rdar://problem/13781171>

Reviewed by Antti Koivisto.

When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.

• page/Page.cpp:

(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):

• page/Page.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):

1:35 PM Changeset in webkit [149838] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
<​http://webkit.org/b/115590>

Reviewed by Darin Adler.

Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.

• css/RuleSet.cpp:

(WebCore::RuleSet::findBestRuleSetAndAdd):

Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.

1:31 PM Changeset in webkit [149837] by roger_fong@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed mac port gardening.

• platform/mac-lion/fast/js: Added.
• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/mac/inspector/command-line-api-expected.txt: Added.

1:03 PM Changeset in webkit [149836] by oliver@apple.com

• 17 edits
  3 adds in trunk

Code cache stores bogus var references for functions in eval code
​https://bugs.webkit.org/show_bug.cgi?id=115747

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Non-global eval now uses a per-CodeBlock cache, and only use it
when we're at the top of a function's scope. This means that we
will no longer cache the parsing of a single string across
multiple functions, and we won't cache when we're nested inside
constructs like |with| and |catch| where previously we would, which
is good because caching in those cases is unsound.

• bytecode/EvalCodeCache.h:

(JSC):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::codeCacheForEval):
(UnlinkedCodeBlock):
(RareData):

• debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

• interpreter/Interpreter.cpp:

(JSC::eval):

• runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache):
(JSC::CodeCache::generateBytecode):
(JSC):
(JSC::CodeCache::getCodeBlock):

• runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(CodeCacheMap):
(JSC::CodeCacheMap::canPruneQuickly):
(JSC::CodeCacheMap::prune):
(JSC::CodeCache::create):
(CodeCache):

• runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::compileInternal):

• runtime/Executable.h:

(JSC::EvalExecutable::create):
(EvalExecutable):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createEvalCodeBlock):

• runtime/JSGlobalObject.h:

(JSGlobalObject):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

(VM):

LayoutTests:

Many tests

• fast/js/eval-cache-scoped-lookup-expected.txt: Added.
• fast/js/eval-cache-scoped-lookup.html: Added.
• fast/js/script-tests/eval-cache-scoped-lookup.js: Added.

(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):

12:41 PM Changeset in webkit [149835] by mhahnenberg@apple.com

• 1 edit in trunk/LayoutTests/ChangeLog

Fixing botched rebase of ChangeLog

12:38 PM Changeset in webkit [149834] by mhahnenberg@apple.com

• 4 edits
  3 adds in trunk

DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes
​https://bugs.webkit.org/show_bug.cgi?id=115805

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

It checks the observed ArrayModes to see if we have seen any ArrayWith* first. If so, it assumes it's
an Array::Array, even if we've also observed any NonArrayWith* in the ArrayProfile. This leads to the
code generated by jumpSlowForUnwantedArrayMode to check the indexing type against (shape | IsArray)
instead of just shape, which can cause us to exit a lot in the case that we saw a NonArray.

To fix this we need to add a case that checks for both ArrayWith* and NonArrayWith* cases first, which
should then use Array::PossiblyArray, then do the checks we were already doing.

• bytecode/ArrayProfile.h:

(JSC::hasSeenArray):
(JSC::hasSeenNonArray):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):

LayoutTests:

Added regression test for array access over polymorphic array vs. non-array indexing types.
With the fix, we get 3.666x faster on this microbenchmark.

Reviewed by Geoffrey Garen.

• fast/js/regress/array-nonarray-polymorphic-access-expected.txt: Added.
• fast/js/regress/array-nonarray-polymorphic-access.html: Added.
• fast/js/regress/script-tests/array-nonarray-polymorphic-access.js: Added.

(f):
(run):

12:24 PM Changeset in webkit [149833] by Darin Adler

• 7 edits in trunk/Source

RenderQuote has giant function for language to quotes map
​https://bugs.webkit.org/show_bug.cgi?id=115807

Reviewed by Anders Carlsson.

Source/WebCore:

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
(WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
assertion with && in it into two separate assertions.
(WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
to check that the number of distinct quote characters is small enough to fit into
our fixed size array below.
(WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
Returns a pointer to a struct that contains the four quote characters. This new
function doesn't have the massive amount of code that the old one did. We use the
standard library bsearch function to do a binary search.
(WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
character; one string for any given character.
(WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
(WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
(WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
used to be in the quotesData function.
(WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
special case for the first quote in a RenderView; sharing the code is better and
there is no significant performance difference. Also use m_isAttached directly
when looking at predecessores so there is no need for an isAttached function.
(WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
(WebCore::RenderQuote::updateDepth): Ditto.

• rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since

we call the originalText function in the class and we don't want to do a virtual
function dispatch for that. Removed uneeded const from an argument. Removed a
stray semicolon. Removed the quotesData and isAttached functions, since they are no
longer needed. Renamed m_attached to m_isAttached.

• rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that

takes four quote strings. This was only used to build up the quotes table.

• rendering/style/QuotesData.h: Ditto.

Source/WTF:

• wtf/unicode/CharacterNames.h: Added a couple of character names.

12:03 PM Changeset in webkit [149832] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Use explicit qualifiers for names in the std:: namespace
​https://bugs.webkit.org/show_bug.cgi?id=115868

Reviewed by Andreas Kling.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearAllSiteData):

• UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginForExtension):

• UIProcess/WebFrameProxy.cpp:
• UIProcess/WebProcessProxy.cpp:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):

• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::deliverDataToPlugin):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
• WebProcess/WebPage/DrawingAreaImpl.cpp:
• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):

• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::drawPDFPage):

• WebProcess/mac/WebProcessMac.mm:

12:00 PM Changeset in webkit [149831] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

• Api/InRegionScroller_p.h:
• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::transcode):

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::render):

• Api/WebPageCompositor.h:
• Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

• Api/WebSettings_p.h:

11:49 AM Changeset in webkit [149830] by commit-queue@webkit.org

• 14 edits
  3 adds in trunk

shouldUsePluginDocument() needs to be respected when a document is created
​https://bugs.webkit.org/show_bug.cgi?id=110308

Patch by Max Feil <​mfeil@rim.com> on 2013-05-09
Reviewed by Rob Buis.

Source/WebCore:

In DOMImplementation::createDocument() we should create
a PluginDocument for mime types that return "true" for
shouldAlwaysUsePluginDocument(), even if there is no pluginData
for them. This lets a client choose plugins for which the "missing
plugin" text or icon should appear more consistently. Otherwise
plugins referenced by iFrames will be treated as an HTMLDocument,
possibly resulting in binary files rendered as gibberish text.

Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Source/WebKit/blackberry:

This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):

• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/win:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit2:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

11:47 AM Changeset in webkit [149829] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Fix an exception when hovering native functions while paused in the debugger.

​https://webkit.org/b/115866
rdar://problem/13681982

Reviewed by Darin Adler and Joseph Pecoraro.

• inspector/InjectedScriptSource.js:

(InjectedScript.prototype.getFunctionDetails): Return an error if the details
is null or undefined.

11:42 AM Changeset in webkit [149828] by Darin Adler

• 2 edits in trunk/Source/WebCore

[Mac] CFError leak under Objective-C garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=115862

Reviewed by Benjamin Poulain.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
the CFError needs a CFRelease, not an -[NSObject release].

11:38 AM Changeset in webkit [149827] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
​https://bugs.webkit.org/show_bug.cgi?id=114953

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

data->layer needs a cast in order to call setHolePunchRect().

• plugins/blackberry/NPCallbacksBlackBerry.cpp:

(WebCore::npSetHolePunchHandler):

11:32 AM Changeset in webkit [149826] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update SelectionHandler to match check-webkit-style updates.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):

• WebKitSupport/SelectionHandler.h:

(SelectionHandler):

11:24 AM Changeset in webkit [149825] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Set up logging buffer on start of jsc executable
​https://bugs.webkit.org/show_bug.cgi?id=114688

Patch by Joe Mason <​jmason@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internal PR: 322715
Internally Reviewed By: Jeff Rogers

• jsc.cpp:

(main): call BB::Platform::setupApplicationLogging

11:13 AM Changeset in webkit [149824] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/graphics BlackBerry sources
to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::readPixelsIMG):
(WebCore::GraphicsContext3D::paintToCanvas):

• platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):

• platform/graphics/blackberry/IntRectBlackBerry.cpp:

(WebCore::IntRect::IntRect):

• platform/graphics/blackberry/LayerCompositingThread.h:

(WTF::::deref):

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::compositeLayersRecursive):

• platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setFrame):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

• platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::JPEGImageDecoder):

11:02 AM Changeset in webkit [149823] by mifenton@rim.com

• 5 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/network/blackberry
to match check-webkit-style updates.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleSetCookieHeader):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::shouldSendClientData):

• platform/network/blackberry/NetworkJob.h:

(NetworkJob):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::isRSSContent):
(WebCore::transcode):

10:59 AM Changeset in webkit [149822] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/blackberry to match check-webkit-style updates.

No functional changes.

• platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

• platform/blackberry/CookieMap.h:

(WebCore::CookieMap::count):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/LoggingBlackBerry.cpp:
• platform/blackberry/PageClientBlackBerry.h:

(Platform):
(Graphics):
(WebCore):

• platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

• platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:

(WebCore::signedPublicKeyAndChallengeString):

• platform/blackberry/ScrollAnimatorBlackBerry.h:

10:40 AM Changeset in webkit [149821] by msaboff@apple.com

• 4 edits
  4 adds in trunk/Source

JSC: There should be a disassembler for ARM Thumb 2
​https://bugs.webkit.org/show_bug.cgi?id=115827

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. The opcode coverage is currently not complete. It covers all
of the integer instructions JSC currently emits, but only a limited number of
floating point opcodes. Currently that is just the 64 bit vmov and vmsr instructions.

The disassembler is structured as a base opcode class ARMv7DOpcode with sub-classes
for each instruction group. There is a public format method that does the bulk of
the disassembly work. There are two broad sub-classes, ARMv7D16BitOpcode and
ARMv7D32BitOpcode, for the 16 bit and 32 bit opcodes. There are sub-classes under
those two classes for individual and related groups of opcodes. Instructions are
"dispatched" to the right subclass via two arrays of linked lists in the inner classes
OpcodeGroup. There is one such inner class for each ARMv7D16BitOpcode and ARMv7D32BitOpcode.
Each OpcodeGroup has a mask and a pattern that it applies to the instruction to determine
that it matches a particular group. OpcodeGroup uses a static method to reinterpret_cast
the Opcode object to the right base class for the instruction group for formatting.
The cast eliminates the need of allocating an object for each decoded instruction.
Unknown instructions are formatted as ".word 1234" or ".long 12345678" depending whether
the instruction is 16 or 32 bit.

• JavaScriptCore.xcodeproj/project.pbxproj:
• disassembler/ARMv7: Added.
• disassembler/ARMv7/ARMv7DOpcode.cpp: Added.

(ARMv7Disassembler):
(OpcodeGroupInitializer):
(JSC::ARMv7Disassembler::ARMv7DOpcode::init):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::saveITConditionAt):
(JSC::ARMv7Disassembler::ARMv7DOpcode::fetchOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::disassemble):
(JSC::ARMv7Disassembler::ARMv7DOpcode::bufferPrintf):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendFPRegisterName):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::appendModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::appendImmShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::appendFPRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::format):

• disassembler/ARMv7/ARMv7DOpcode.h: Added.

(ARMv7Disassembler):
(ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::is32BitInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::isFPInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::conditionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::shiftName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::inITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startingITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::endITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionNameNoITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSeparator):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendCharacter):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendString):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftType):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendPCRelativeOffset):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftAmount):
(ARMv7D16BitOpcode):
(OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeAddRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rm):
(ARMv7DOpcodeAddSPPlusImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::immediate8):
(ARMv7DOpcodeAddSubtract):
(ARMv7DOpcodeAddSubtractT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rn):
(ARMv7DOpcodeAddSubtractImmediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::rn):
(ARMv7DOpcodeAddSubtractImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::immediate8):
(ARMv7DOpcodeBranchConditionalT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::offset):
(ARMv7DOpcodeBranchExchangeT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::rm):
(ARMv7DOpcodeBranchT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::immediate11):
(ARMv7DOpcodeCompareImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::immediate8):
(ARMv7DOpcodeCompareRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::rn):
(ARMv7DOpcodeCompareRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rm):
(ARMv7DOpcodeDataProcessingRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rdn):
(ARMv7DOpcodeGeneratePCRelativeAddress):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::immediate8):
(ARMv7DOpcodeLoadFromLiteralPool):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::immediate8):
(ARMv7DOpcodeLoadStoreRegisterImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
(ARMv7DOpcodeLoadStoreRegisterImmediateWordAndByte):
(ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord):
(ARMv7DOpcodeLoadStoreRegisterOffsetT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rt):
(ARMv7DOpcodeLoadStoreRegisterSPRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::immediate8):
(ARMv7DOpcodeLogicalImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::immediate5):
(ARMv7DOpcodeMiscAddSubSP):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::immediate7):
(ARMv7DOpcodeMiscByteHalfwordOps):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::op):
(ARMv7DOpcodeMiscBreakpointT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::immediate8):
(ARMv7DOpcodeMiscCompareAndBranch):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::immediate6):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::rn):
(ARMv7DOpcodeMiscHint16):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opA):
(ARMv7DOpcodeMiscIfThenT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::firstCondition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::mask):
(ARMv7DOpcodeMiscPushPop):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
(ARMv7DOpcodeMoveImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::immediate8):
(ARMv7DOpcodeMoveRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rm):
(ARMv7D32BitOpcode):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rn):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rt):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeBranchRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::immediate11):
(ARMv7DOpcodeConditionalBranchT3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::immediate6):
(ARMv7DOpcodeBranchOrBranchLink):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::immediate10):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::isBL):
(ARMv7DOpcodeDataProcessingLogicalAndRithmetic):
(ARMv7DOpcodeDataProcessingModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::immediate12):
(ARMv7DOpcodeDataProcessingShiftedReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::type):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tbBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tBit):
(ARMv7DOpcodeDataProcessingReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op2):
(ARMv7DOpcodeDataProcessingRegShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::opName):
(ARMv7DOpcodeDataProcessingRegExtend):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendAndAddName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::rotate):
(ARMv7DOpcodeDataProcessingRegParallel):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::opName):
(ARMv7DOpcodeDataProcessingRegMisc):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::opName):
(ARMv7DOpcodeHint32):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::isDebugHint):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::debugOption):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::op):
(ARMv7DOpcodeFPTransfer):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opH):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opC):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vn):
(ARMv7DOpcodeDataLoad):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::op):
(ARMv7DOpcodeLoadRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::immediate2):
(ARMv7DOpcodeLoadSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::immediate8):
(ARMv7DOpcodeLoadUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::immediate12):
(ARMv7DOpcodeLongMultipleDivide):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlalOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlaldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlsldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdLo):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdHi):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::nBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::mBit):
(ARMv7DOpcodeDataPushPopSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::op):
(ARMv7DOpcodeDataStoreSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::op):
(ARMv7DOpcodeStoreSingleImmediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::immediate12):
(ARMv7DOpcodeStoreSingleImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::immediate8):
(ARMv7DOpcodeStoreSingleRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::immediate2):
(ARMv7DOpcodeUnmodifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::shBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::bitNumOrSatImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate16):
(ARMv7DOpcodeVMOVDoublePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::vm):
(ARMv7DOpcodeVMOVSinglePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::vm):
(ARMv7DOpcodeVMSR):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::rt):

• disassembler/ARMv7Disassembler.cpp: Added.

(JSC::tryToDisassemble):

Source/WTF:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. Enabled the disassembler for IOS bulds.

• wtf/Platform.h:

9:54 AM Changeset in webkit [149820] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebPage and WebPageClient to match check-webkit-style updates.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):

• Api/WebPageClient.h:
• Api/WebPage_p.h:

9:51 AM Changeset in webkit [149819] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update BackingStore to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):

• Api/BackingStore_p.h:

(BackingStoreGeometry):

9:36 AM WebKit Team edited by simon.pena@samsung.com

Adding myself (diff)

9:16 AM Changeset in webkit [149818] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.

• WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

• WebCoreSupport/CredentialManager.h:

(CredentialManager):

• WebCoreSupport/CredentialTransformData.cpp:
• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):

• WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::onLocationUpdate):

• WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

• WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

9:13 AM Changeset in webkit [149817] by crogers@google.com

• 29 edits in trunk/Source/WebCore

Require use of AudioBus::create() to avoid ref-counting issues
​https://bugs.webkit.org/show_bug.cgi?id=115836

Reviewed by Andreas Kling.

There were a couple of places still embedding raw AudioBus objects as
member variables or local variables causing ref-counting problems
now that AudioBus is ref-counted. Make AudioBus constructor private
to enforce use of AudioBus::create().

Adapted from Blink patch:
​https://chromiumcodereview.appspot.com/14628008/

• Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
(LocalAudioInputProvider):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):

• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

• Modules/webaudio/ScriptProcessorNode.h:

(ScriptProcessorNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):

• platform/audio/AudioFIFO.h:

(AudioFIFO):

• platform/audio/AudioPullFIFO.cpp:

(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::fillBuffer):

• platform/audio/AudioPullFIFO.h:

(AudioPullFIFO):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):
(WebCore):

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

• platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::render):

• platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS):

• platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):

• platform/audio/mac/AudioDestinationMac.h:

(AudioDestinationMac):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

9:09 AM Changeset in webkit [149816] by zhajiang@rim.com

• 5 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-09.
Reviewed by Rob Buis.

Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

• WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):

9:02 AM Changeset in webkit [149815] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):

8:51 AM Changeset in webkit [149814] by commit-queue@webkit.org

• 9 edits
  4 adds in trunk/Source

[BlackBerry] Upstream the input popups
​https://bugs.webkit.org/show_bug.cgi?id=114608

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team, including:

Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang

Source/WebCore:

• Resources/blackberry/colorControlBlackBerry.css: Added.

(.color-picker-popup-area):
(.color-picker-content):
(.color-picker-block):
(#color-picker-swatch-block):
(.color-picker-switcher):
(.color-picker-check-mark):
(.color-picker-option):
(.color-picker-button):
(.color-picker-highlight):
(input):
(.color-picker-sharp):
(.color-picker-off):
(.color-picker-inactive-font):
(.color-picker-row):
(.color-picker-hex-style):
(.color-picker-input):
(.color-picker-well):
(.color-picker-input .color-picker-well):
(.color-picker-slider):
(.color-picker-slider-output):
(.color-picker-range):
(.color-picker-range::-webkit-slider-thumb):
(.color-picker-range::-webkit-slider-thumb:active):
(.red-ranger-bg):
(.green-ranger-bg):
(.blue-ranger-bg):
(@media only screen and (height: 768px)):
(@media only screen and (height: 720px)):

• Resources/blackberry/colorControlBlackBerry.js: Added.

(.):

• Resources/blackberry/popupControlBlackBerry.css:

(body):
(.popup-area):
(.popup-header):
(.popup-content):
(.popup-buttons):
(.popup-button):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/selectControlBlackBerry.css:

(.popup-content):
(@media (min-height: 918px)):
(.option):
(@media only screen and (width: 720px) and (height: 720px)):
(.contents):
(.option:active):
(.selected):
(.selected .contents::after):
(.text):
(.disabled):
(.optgroup):
(.optgroup-option):

• Resources/blackberry/selectControlBlackBerry.js:

(.):

• Resources/blackberry/timeControlBlackBerry.css: Added.

(#popup-content-time):
(.column):
(.column:not(:last-child)):
(.cell):
(.yearmonthdate .cell div:last-child):
(.row-highlight-container):
(.row-highlight-filler):
(.row-highlight):
(.tall-bit):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/timeControlBlackBerry.js: Added.

(.):

Source/WebKit/blackberry:

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore):
(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/DatePickerClient.cpp:

(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):

• WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

• WebCoreSupport/SelectPopupClient.cpp:

(WebCore):
(WebCore::SelectPopupClient::generateHTML):

8:46 AM Changeset in webkit [149813] by rwlbuis@webkit.org

• 16 edits in trunk/Source/WebCore

[BlackBerry] texmap code generates warnings
​https://bugs.webkit.org/show_bug.cgi?id=115815

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-09
Reviewed by Benjamin Poulain.

Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
these files unconditionally.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
• platform/graphics/texmap/GraphicsLayerTextureMapper.h:
• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperBackingStore.cpp:
• platform/graphics/texmap/TextureMapperBackingStore.h:
• platform/graphics/texmap/TextureMapperFPSCounter.cpp:
• platform/graphics/texmap/TextureMapperFPSCounter.h:
• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperGL.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:
• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/TextureMapperTile.cpp:
• platform/graphics/texmap/TextureMapperTile.h:
• platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
• platform/graphics/texmap/TextureMapperTiledBackingStore.h:

8:44 AM Changeset in webkit [149812] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

PluginDatabase: add plugin directory for the BlackBerry port.
​https://bugs.webkit.org/show_bug.cgi?id=114943

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

XP_UNIX is defined for the BlackBerry port, but we don't want to
share the same code here.

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

8:43 AM Changeset in webkit [149811] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update DOMSupport to match check-webkit-style updates.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

8:42 AM Changeset in webkit [149810] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
​https://bugs.webkit.org/show_bug.cgi?id=115843

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internally reviewed by Mary Wu.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:35 AM Changeset in webkit [149809] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update FatFingers to match check-webkit-style updates.

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):

• WebKitSupport/FatFingers.h:

(FatFingersResult):

8:26 AM Changeset in webkit [149808] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.

• WebKitSupport/InRegionScrollableArea.cpp:
• WebKitSupport/TileIndexHash.h:
• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

8:16 AM Changeset in webkit [149807] by commit-queue@webkit.org

• 8 edits
  2 deletes in trunk/Source/WebCore

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
​https://bugs.webkit.org/show_bug.cgi?id=115850

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.

Removed the Memory Instrumentation Code after r148921.

No new tests, no behavior change.

• inspector/compile-front-end.py:
• inspector/front-end/NativeMemorySnapshotView.js: Removed.
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

• inspector/front-end/SettingsScreen.js:
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.css:
• inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

• inspector/front-end/nativeMemoryProfiler.css: Removed.

8:11 AM Changeset in webkit [149806] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Styles fixes required for InputHandler based on updated
check-webkit-style.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

• WebKitSupport/InputHandler.h:

7:26 AM Changeset in webkit [149805] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r149796.

• GNUmakefile.am: Add a phony target for the window constructors file and include it among

the dependencies for the non-generated code.

7:03 AM Changeset in webkit [149804] by timothy@apple.com

• 2 edits in trunk/Source/WebKit2

Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.

​https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.

6:50 AM Changeset in webkit [149803] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

[CSSRegions] Change fast/regions/webkit-flow-inlines-inside-regions-bounds[-vertical] tests to make them platform independent
​https://bugs.webkit.org/show_bug.cgi?id=115851

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Modified tests to make them platform independent by using Ahem and no font smoothing.

• fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds.html:

6:48 AM Changeset in webkit [149802] by commit-queue@webkit.org

• 10 edits in trunk/LayoutTests

[Qt][EFL][GTK] Failing CSS region tests
​https://bugs.webkit.org/show_bug.cgi?id=115785

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Updated tests to overcome platform differences
Unskip fixed CSS regions tests

• fast/regions/webkit-flow-double-pagination-float-push-expected.html:
• fast/regions/webkit-flow-double-pagination-float-push.html:
• fast/regions/webkit-flow-float-pushed-to-last-region-expected.html:
• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• fast/regions/webkit-flow-float-unable-to-push-expected.html:
• fast/regions/webkit-flow-float-unable-to-push.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds.html:
• platform/qt/TestExpectations:

6:12 AM Changeset in webkit [149801] by zarvai@inf.u-szeged.hu

• 9 edits
  10 copies
  36 adds in trunk/LayoutTests

[Qt] Unreviewed gardeing. Updating some png expected results.

• platform/qt-5.0-wk2/compositing/checkerboard-expected.png: Added.
• platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/inserting/typing-around-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-by-character-002-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-04-expecrted.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png: Added.
• platform/qt-5.0-wk2/fast/box-shadow/shadow-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/dom/34176-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
• platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Added.
• platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
• platform/qt-5.0-wk2/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/add-table-overpaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png:
• platform/qt-5.0-wk2/fast/repaint/change-transform-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/inline-outline-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png:
• platform/qt-5.0-wk2/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
• platform/qt-5.0-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
• platform/qt-5.0-wk2/fast/repaint/table-row-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
• platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-on-image-bounds-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/custom/use-disappears-after-style-update-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dom/rect-modify-rx-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/svgsvgelement-repaint-children-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/svg/text/tspan-dynamic-positioning-expected.png: Added.

6:11 AM Changeset in webkit [149800] by akling@apple.com

• 2 edits in trunk/Source/WebKit/qt

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<​http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

3:05 AM WebKitIDL edited by Christophe Dumez

Add documentation for [NoInterfaceObject] introduced in r149796 (diff)

2:40 AM WebKitIDL edited by Christophe Dumez

Move extended attribute to their correct place (diff)

2:18 AM Changeset in webkit [149799] by kadam@inf.u-szeged.hu

• 1 edit
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected file after r149758.

• platform/qt/fast/js/global-constructors-attributes-expected.txt: Added after r149758.

2:07 AM Changeset in webkit [149798] by mario@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Update Simon Pena email on his behalf.

• Scripts/webkitpy/common/config/contributors.json:

1:14 AM Changeset in webkit [149797] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt minimal build.

r149796 broke builds that have WEB_SOCKETS flag disabled.

• page/DOMWindow.idl:

12:38 AM Changeset in webkit [149796] by Christophe Dumez

• 215 edits
  4 deletes in trunk

Add support for [NoInterfaceObject] Web IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115714

Reviewed by Kentaro Hara.

.:

Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
optional argument.

• Source/cmake/WebKitMacros.cmake:

Source/WebCore:

*Constructor attributes on the global DOMWindow object are now automatically
generated for each non-callback interface that is not declared with the
[NoInterfaceObject] extended attribute. It is thus no longer needed for
developers to manually add *Constructor attributes for their new interfaces
unless they wish to register an "extra" constructor for their interface.

This patch does not modify at all the behavior on JS side. To achieve this,
[NoInterfaceObject] extended attribute is added to interfaces that should
not have it according to specification (e.g. History, Location, ...).
This can be improved later as the behavior should not change with this
patch.

No new tests, no behavior change.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeyNeededEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/filesystem/DOMFileSystem.idl:
• Modules/filesystem/DOMFileSystemSync.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryEntrySync.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/DirectoryReaderSync.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/EntryArray.idl:
• Modules/filesystem/EntryArraySync.idl:
• Modules/filesystem/EntrySync.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/FileEntrySync.idl:
• Modules/filesystem/FileWriter.idl:
• Modules/filesystem/FileWriterSync.idl:
• Modules/filesystem/Metadata.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Coordinates.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/geolocation/Geoposition.idl:
• Modules/geolocation/PositionError.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/IDBAny.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediastream/DOMWindowMediaStream.idl: Removed.
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/MediaStreamTrackEvent.idl:
• Modules/mediastream/NavigatorUserMediaError.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDTMFToneChangeEvent.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCDataChannelEvent.idl:
• Modules/mediastream/RTCIceCandidateEvent.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/DOMWindowNotifications.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/speech/DOMWindowSpeech.idl: Removed.
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/speech/SpeechGrammar.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechRecognitionAlternative.idl:
• Modules/speech/SpeechRecognitionError.idl:
• Modules/speech/SpeechRecognitionEvent.idl:
• Modules/speech/SpeechRecognitionResult.idl:
• Modules/speech/SpeechRecognitionResultList.idl:
• Modules/speech/SpeechSynthesis.idl:
• Modules/speech/SpeechSynthesisVoice.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioDestinationNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/AudioSourceNode.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ConvolverNode.idl:
• Modules/webaudio/DOMWindowWebAudio.idl: Removed.
• Modules/webaudio/DelayNode.idl:
• Modules/webaudio/DynamicsCompressorNode.idl:
• Modules/webaudio/GainNode.idl:
• Modules/webaudio/MediaElementAudioSourceNode.idl:
• Modules/webaudio/MediaStreamAudioDestinationNode.idl:
• Modules/webaudio/MediaStreamAudioSourceNode.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webaudio/ScriptProcessorNode.idl:
• Modules/webaudio/WaveShaperNode.idl:
• Modules/webaudio/WaveTable.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLError.idl:
• Modules/webdatabase/SQLResultSet.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/websockets/DOMWindowWebSocket.idl: Removed.
• Modules/websockets/WebSocket.idl:
• PlatformBlackBerry.cmake:
• UseJSC.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parseTypedef):

• bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):
(getFileContents):
(getPartialInterfaceNameFromIDL):
(isCallbackInterfaceFromIDL):
(trim):
(getInterfaceExtendedAttributesFromIDL):

• css/CSSFontFaceLoadEvent.idl:
• css/CSSFontFaceRule.idl:
• css/CSSSupportsRule.idl:
• css/CSSUnknownRule.idl:
• css/DOMWindowCSS.idl:
• css/FontLoader.idl:
• css/MediaQueryList.idl:
• css/MediaQueryListListener.idl:
• css/StyleMedia.idl:
• dom/CustomElementConstructor.idl:
• dom/DOMError.idl:
• dom/DOMNamedFlowCollection.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/NodeIterator.idl:
• dom/ShadowRoot.idl:
• dom/TreeWalker.idl:
• dom/WebKitNamedFlow.idl:
• fileapi/FileException.idl:
• fileapi/FileReaderSync.idl:
• html/HTMLAudioElement.idl:
• html/HTMLDetailsElement.idl:
• html/HTMLOptionElement.idl:
• html/MediaError.idl:
• html/MediaKeyError.idl:
• html/MicroDataItemValue.idl:
• html/RadioNodeList.idl:
• html/ValidityState.idl:
• html/canvas/CanvasRenderingContext.idl:
• html/canvas/DOMPath.idl:
• html/canvas/EXTDrawBuffers.idl:
• html/canvas/EXTTextureFilterAnisotropic.idl:
• html/canvas/OESElementIndexUint.idl:
• html/canvas/OESStandardDerivatives.idl:
• html/canvas/OESTextureFloat.idl:
• html/canvas/OESTextureHalfFloat.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/WebGLCompressedTextureATC.idl:
• html/canvas/WebGLCompressedTexturePVRTC.idl:
• html/canvas/WebGLCompressedTextureS3TC.idl:
• html/canvas/WebGLContextAttributes.idl:
• html/canvas/WebGLDebugRendererInfo.idl:
• html/canvas/WebGLDebugShaders.idl:
• html/canvas/WebGLDepthTexture.idl:
• html/canvas/WebGLLoseContext.idl:
• html/canvas/WebGLVertexArrayObjectOES.idl:
• html/track/AudioTrack.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrackRegionList.idl:
• html/track/VideoTrack.idl:
• html/track/VideoTrackList.idl:
• inspector/InjectedScriptHost.idl:
• inspector/InspectorFrontendHost.idl:
• inspector/JavaScriptCallFrame.idl:
• inspector/ScriptProfile.idl:
• inspector/ScriptProfileNode.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/AbstractView.idl:
• page/BarInfo.idl:
• page/Console.idl:
• page/Crypto.idl:
• page/DOMSecurityPolicy.idl:
• page/DOMWindow.idl:
• page/History.idl:
• page/Location.idl:
• page/MemoryInfo.idl:
• page/Navigator.idl:
• page/PagePopupController.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceEntryList.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:
• page/SpeechInputResult.idl:
• page/SpeechInputResultList.idl:
• page/WorkerNavigator.idl:
• page/make_settings.pl:

(generateInternalSettingsIdlFile):

• svg/ElementTimeControl.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGExternalResourcesRequired.idl:
• svg/SVGFilterPrimitiveStandardAttributes.idl:
• svg/SVGFitToViewBox.idl:
• svg/SVGLangSpace.idl:
• svg/SVGLocatable.idl:
• svg/SVGStyledElement.idl:
• svg/SVGTests.idl:
• svg/SVGTransformable.idl:
• svg/SVGURIReference.idl:
• testing/InternalSettings.idl:
• testing/Internals.idl:
• testing/MallocStatistics.idl:
• testing/TypeConversions.idl:
• workers/AbstractWorker.idl:
• workers/DedicatedWorkerContext.idl:
• workers/SharedWorker.idl:
• workers/SharedWorkerContext.idl:
• workers/WorkerContext.idl:
• workers/WorkerLocation.idl:
• xml/XPathExpression.idl:
• xml/XPathNSResolver.idl:

Tools:

Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

12:05 AM Changeset in webkit [149795] by commit-queue@webkit.org

• 5 edits in trunk

[GTK][AC] Buildfix after r149694
​https://bugs.webkit.org/show_bug.cgi?id=115797

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-05-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some interfaces, such as a return value and parameters of functions are changed.

No new tests since no functionality changed.

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

• platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

Tools:

Add CLUTTER_LIBS for linking TestWebCore.

• TestWebKitAPI/GNUmakefile.am:

May 8, 2013:

11:39 PM Changeset in webkit [149794] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Brent Fulgham.

Get rid of the following warning for BlackBerry:

NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

by not compiling any of the code to add protocols to the protocol whitelist.

• Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

11:38 PM Changeset in webkit [149793] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Windows] The function seekFile() is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=115246

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-08
Reviewed by Brent Fulgham.

Implemented seekFile() function for Windows.

• platform/win/FileSystemWin.cpp:

(WebCore::seekFile):

11:31 PM Changeset in webkit [149792] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Fix a typo in Settings.js
​https://bugs.webkit.org/show_bug.cgi?id=115849

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Joseph Pecoraro.

No new tests, no behavior change.

• inspector/front-end/Settings.js:

(WebInspector.Settings):

10:26 PM Changeset in webkit [149791] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

SecurityOrigin doesn’t need to forward declare or include Document
​https://bugs.webkit.org/show_bug.cgi?id=115847

Reviewed by Alexey Proskuryakov.

Merge ​https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.

Removed unused Document forward declaration+include from SecurityOrigin.

• page/SecurityOrigin.cpp:
• page/SecurityOrigin.h:

9:58 PM EFLWebKit edited by gyuyoung.kim@samsung.com

Update dependency pkgs (diff)

9:50 PM Changeset in webkit [149790] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Tools

[EFL] Remove unnecessary pkgs in EFL jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=114908

Reviewed by Laszlo Gombos.

p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.

• efl/jhbuild.modules:

8:52 PM Changeset in webkit [149789] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX: Don't use adoptCF() with NSDictionary * object

Fixes the following build failure:

In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
/usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."

static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");

/usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here

return RetainPtr<T>(AdoptCF, o);

Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here

RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));

1 error generated.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Switch from adoptCF() to
adoptNS(). This is in USE(CFNETWORK) code, so it's not
exercised on the Mac.

8:12 PM Changeset in webkit [149788] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

8:00 PM Changeset in webkit [149787] by Lucas Forschler

• 1 copy in tags/Safari-537.41

New Tag.

7:12 PM Changeset in webkit [149786] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Disable SHADOW DOM feature in FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=115834

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Gyuyoung Kim.

• Scripts/webkitperl/FeatureList.pm:

6:11 PM Changeset in webkit [149785] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove Editor::setSelectionOffsets
​https://bugs.webkit.org/show_bug.cgi?id=115831

Reviewed by Andreas Kling.

Removed the function added in r120985 for Chromium Android port.

• editing/Editor.cpp:
• editing/Editor.h:

6:02 PM Changeset in webkit [149784] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix a typo in a comment.

Rubber-stamped by Darin Adler.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

5:49 PM Changeset in webkit [149783] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Remove bogus StorageAreaMap assertions
​https://bugs.webkit.org/show_bug.cgi?id=115838

Reviewed by Sam Weinig.

It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didClear):

5:24 PM Changeset in webkit [149782] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Get rid of duplicate entry line in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=115828

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08

• platform/efl/TestExpectations:

5:20 PM Changeset in webkit [149781] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Handle incoming clear operations
​https://bugs.webkit.org/show_bug.cgi?id=115829

Reviewed by Sam Weinig.

Handle clear by building up a new storage map with our pending changes.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::applyChange):

4:51 PM Changeset in webkit [149780] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Potential use-after-free of Frame
​https://bugs.webkit.org/show_bug.cgi?id=115774

Reviewed by Simon Fraser.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.

• page/Frame.cpp:

(WebCore::Frame::setPrinting):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::deviceOrPageScaleFactorChanged):

4:43 PM Changeset in webkit [149779] by roger_fong@apple.com

• 5 edits in trunk/Source/WebCore

Unreviewed build fix, AppleWin port.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
(WebCore):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

4:38 PM Changeset in webkit [149778] by xingnan.wang@intel.com

• 24 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::AudioNodeOutput::pull
​https://bugs.webkit.org/show_bug.cgi?id=111362

Reviewed by Chris Rogers.

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::createFromAudioFileData):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):

• Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFileReader.h:

(WebCore):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/AudioResampler.h:

(AudioResampler):

• platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/Reverb.h:

(Reverb):

• platform/audio/efl/AudioBusEfl.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/mac/AudioFileReaderMac.h:

(AudioFileReader):

• platform/audio/qt/AudioBusQt.cpp:

(WebCore::AudioBus::loadPlatformResource):

4:31 PM Changeset in webkit [149777] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Don't apply changes while we're clearing the database
​https://bugs.webkit.org/show_bug.cgi?id=115826

Reviewed by Darin Adler.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::openDatabase):
Only call didOpenDatabaseWithOrigin if we actually did open the database.

(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Create the database if needed.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
Send back a DidGetValues message.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
Initialize m_hasPendingClear.

(WebKit::StorageAreaMap::clear):
Set m_hasPendingClear to true.

(WebKit::StorageAreaMap::resetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.

(WebKit::StorageAreaMap::didGetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::didClear):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::applyChange):
Don't apply the change if m_hasPendingClear is true.

• WebProcess/Storage/StorageAreaMap.messages.in:

Add DidGetValues message.

4:15 PM Changeset in webkit [149776] by Lucas Forschler

• 2 edits in trunk/Tools

Add Scheduler for Mac MtnLion 32bit Release builder.

Unreviewed.

• BuildSlaveSupport/build.webkit.org-config/config.json:

4:08 PM Changeset in webkit [149775] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
​https://bugs.webkit.org/show_bug.cgi?id=115808

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-05-08
Reviewed by Darin Adler.

The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.

• gdb/webkit.py:

(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.

3:41 PM Changeset in webkit [149774] by aestes@apple.com

• 5 edits
  2 adds in trunk

[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
​https://bugs.webkit.org/show_bug.cgi?id=115790

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

NSMutableSet does not support adding or removing nil objects, and
WTF::HashSet does not support adding, removing, or checking for null
WTF::Strings.

For the NSMutableSet case, make sure that we don't try to add or remove
nil NSStrings.

For the WTF::HashSet case, NSURL will return a nil NSString if we ask
it for its scheme when it is invalid, which we will convert to a null
WTF::String. Don't try to check if our HashSet of registered schemes
contains a null String.

• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
isn't null. We reject null schemes at the WKBrowsingContextController level.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.

• UIProcess/API/mac/WKBrowsingContextController.mm:

(+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.

Tools:

Added two API tests:

1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):

3:40 PM Changeset in webkit [149773] by Lucas Forschler

• 2 edits in trunk/Tools

Teach buildbot how to compile 32-bit on Mac.

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):
(ExtractTestResultsAndLeaks):

3:34 PM Changeset in webkit [149772] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Apply remote changes to storage maps locally
​https://bugs.webkit.org/show_bug.cgi?id=115825

Reviewed by Beth Dakin.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.

(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.

(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.

(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.

(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.

(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.

• WebProcess/Storage/StorageAreaMap.h:

3:26 PM Changeset in webkit [149771] by roger_fong@apple.com

• 2 edits
  1 copy in trunk/WebKitLibraries

Update WebKitLibraries/win to handle different architectures properly.

• win/lib32: Copied from win/lib.
• win/tools/WinTools.make:

3:08 PM Changeset in webkit [149770] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Simplify RetainPtrObjectHashTraits
​https://bugs.webkit.org/show_bug.cgi?id=115822

Reviewed by Benjamin Poulain.

RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.

• wtf/RetainPtr.h:

(WTF::RetainPtrObjectHashTraits::emptyValue):

3:05 PM Changeset in webkit [149769] by commit-queue@webkit.org

• 26 edits in trunk

[BlackBerry] Fix usage of BlackBerry::Platform::String
​https://bugs.webkit.org/show_bug.cgi?id=115781

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.

BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos

We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.

Source/WebCore:

• platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/CursorBlackBerry.cpp:

(WebCore::Cursor::Cursor):

• platform/blackberry/PlatformBlob.cpp:

(WebCore::PlatformBlob::nextDataItem):

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:

(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):

• platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::Image::loadPlatformResource):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):

• platform/network/blackberry/rss/RSSFilterStream.h:
• platform/text/blackberry/StringBlackBerry.cpp:

(WTF::String::operator BlackBerry::Platform::String):

Source/WebKit/blackberry:

• Api/JavaScriptVariant.cpp:

(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):

• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::base64Encode):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

• Api/WebPage.h:
• Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

• WebKitSupport/DefaultTapHighlight.cpp:

(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):

Tools:

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setUserStyleSheetLocation):

• DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:

(LoadHTMLStringItem::invoke):

3:02 PM Changeset in webkit [149768] by andersca@apple.com

• 6 edits in trunk/Source

Assert at compile time that we don't pass Objective-C object pointers to adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115823

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
Use adoptNS for CALayer.

Source/WebKit2:

Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

Source/WTF:

static_assert in adoptCF that the object passed in is not an Objective-C object.

• wtf/RetainPtr.h:

2:56 PM Changeset in webkit [149767] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Tools: add new BlackBerry include dirs.
​https://bugs.webkit.org/show_bug.cgi?id=115514

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.

iType include dirs are missing, and HarfBuzz needs to be fixed.

• Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

1:53 PM Changeset in webkit [149766] by eric.carlson@apple.com

• 4 edits
  2 adds in trunk

TextTrackCue should support empty content
​https://bugs.webkit.org/show_bug.cgi?id=115821

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-cue-empty-text-crash.html

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render

cues with no content.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.

LayoutTests:

• media/track/track-cue-empty-text-crash-expected.txt: Added.
• media/track/track-cue-empty-text-crash.html: Added.

1:48 PM Changeset in webkit [149765] by weinig@apple.com

• 5 edits
  2 adds in trunk/Source/WebKit2

Add SPI to determine if a plugin is sandboxed
​https://bugs.webkit.org/show_bug.cgi?id=115810

Reviewed by Anders Carlsson.

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/Plugins/mac/PluginSandboxProfile.h: Added.
• Shared/Plugins/mac/PluginSandboxProfile.mm: Added.

(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:45 PM Changeset in webkit [149764] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed AppleWin build fix.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):

1:33 PM Changeset in webkit [149763] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.

Get rid of the following warning for BlackBerry:

BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]

by using ASSERT_UNUSED instead of ASSERT.

• WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::create):

1:06 PM Changeset in webkit [149762] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
​https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>

Reviewed by Andreas Kling.

To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

1:02 PM Changeset in webkit [149761] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Coalesce WKView visibleRect changes
​https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>

Reviewed by Simon Fraser.

The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.

• UIProcess/WebPageProxy.h:

(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.

12:47 PM Changeset in webkit [149760] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove RetainPtr::adoptNS and RetainPtr::adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115817

Reviewed by Jessie Berlin.

These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.

Rewrite the move assignment operators to just call CFRelease explicitly.

• wtf/RetainPtr.h:

12:39 PM Changeset in webkit [149759] by zandobersek@gmail.com

• 12 edits in trunk

[GTK] Plumb the Automake build system for the Battery Status API feature
​https://bugs.webkit.org/show_bug.cgi?id=115718

Reviewed by Martin Robinson.

.:

• Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
• Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
• Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,

when the option is not given, is to disable the feature.

• Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
• Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.

Source/WebCore:

No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.

• GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.

Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.

• GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
• bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.

Tools:

• Scripts/webkitdirs.pm:

(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.

12:28 PM Changeset in webkit [149758] by Christophe Dumez

• 3 edits
  2 adds in trunk/LayoutTests

Add layout test that lists all global constructors
​https://bugs.webkit.org/show_bug.cgi?id=115724

Reviewed by Ryosuke Niwa.

Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.

• fast/js/global-constructors-attributes-expected.txt:
• fast/js/script-tests/global-constructors-attributes.js:

(classNameForObject):
(constructorPropertiesOnWindow):

• platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.

12:26 PM Changeset in webkit [149757] by rniwa@webkit.org

• 2 edits in trunk/Tools

new-run-webkit-websocketserver doesn't work after Chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

• Scripts/new-run-webkit-websocketserver:

(main):

12:19 PM Changeset in webkit [149756] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.

• fast/js/parse-error-external-script-in-eval.html:
• fast/js/parse-error-external-script-in-new-Function.html:

12:11 PM Changeset in webkit [149755] by roger_fong@apple.com

• 3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

11:54 AM Changeset in webkit [149754] by Darin Adler

• 4 edits in trunk

REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
​https://bugs.webkit.org/show_bug.cgi?id=115776

Reviewed by Anders Carlsson.

Source/WebCore:

I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0; if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.

LayoutTests:

• TestExpectations: Expect success again on this test.

11:52 AM Changeset in webkit [149753] by Lucas Forschler

• 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Unreviewed. Fix duplicate builddir.

11:46 AM Changeset in webkit [149752] by Lucas Forschler

• 2 edits in trunk/Tools

Configure buildbot for 32bit builder.
​https://bugs.webkit.org/show_bug.cgi?id=115769

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/config.json:

11:19 AM Changeset in webkit [149751] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
<rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices

Reviewed by Anders Carlsson.

• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more TextServices and NSInputManager directories.

10:35 AM Changeset in webkit [149750] by bfulgham@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Add my apple.com e-mail address to contributors.

10:16 AM Changeset in webkit [149749] by eric.carlson@apple.com

• 3 edits
  2 adds in trunk

Prevent crash when track is deleted during video element deletion.
​https://bugs.webkit.org/show_bug.cgi?id=106183

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-remove-crash.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we

do not process text track cues or dispatch related events.

LayoutTests:

• media/track/track-remove-crash-expected.txt: Added.
• media/track/track-remove-crash.html: Added.

10:03 AM Changeset in webkit [149748] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WebKit2

Remove BinarySemaphoreWin.cpp.

Rubber-stamped by Beth Dakin.

BinarySemaphoreWin has been moved to WTF, but the original was never removed.

• Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.

9:54 AM Changeset in webkit [149747] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WTF

Remove ThreadingNone.cpp

Rubber-stamped by Beth Dakin.

ThreadingNone.cpp is empty and not used anywhere.

• wtf/ThreadingNone.cpp: Removed.

9:52 AM Changeset in webkit [149746] by ddkilzer@apple.com

• 1 edit
  1 delete in trunk/LayoutTests

Remove chromium test results added in r149743

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.

9:46 AM Changeset in webkit [149745] by ddkilzer@apple.com

• 2 edits in trunk/Tools

BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(concatenateAttributeAndValue): Switch to appendVector().

9:41 AM Changeset in webkit [149744] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] Unreviewed buildfix after r149741.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):

9:33 AM Changeset in webkit [149743] by ddkilzer@apple.com

• 1 edit
  11 adds in trunk/LayoutTests

Add layout tests for test cases in Bug 5206
<​http://webkit.org/b/5206>

Reviewed by Eric Seidel.

These issues were likely fixed in r89257 for Bug 62613.

• fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• fast/js/parse-error-external-script-in-eval.html: Added.
• fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.

• fast/js/parse-error-external-script-in-new-Function.html: Added.
• fast/js/resources/parse-error-external-script-in-eval.js: Added.
• fast/js/resources/parse-error-external-script-in-new-Function.js: Added.

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

9:17 AM Changeset in webkit [149742] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove HashMap::deleteAllKeys
​https://bugs.webkit.org/show_bug.cgi?id=115806

Reviewed by Brent Fulgham.

This function was not used anywhere so let's get rid of it.

• wtf/HashMap.h:

9:06 AM Changeset in webkit [149741] by eric.carlson@apple.com

• 17 edits in trunk

[Mac] Inband text tracks are not in track menu on Lion
​https://bugs.webkit.org/show_bug.cgi?id=115740

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible

to false immediately, it will be reset to the appropriate value if necessary.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.

• html/HTMLMediaElement.h:

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove

HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Ditto.
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,

a legacy CC track is always Captions.

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks

only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP

Source/WTF:

• wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

LayoutTests:

• platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:

8:19 AM Changeset in webkit [149740] by sergio@webkit.org

• 3 edits
  2 adds in trunk

Allow blank spaces before colon (:) on CSS variable definition
​https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

• css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

• css3/css-variable-definition-expected.html: Added.
• css3/css-variable-definition.html: Added.

8:08 AM Changeset in webkit [149739] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

HashTraits<RefPtr<P> >::peek should consider empty value
​https://bugs.webkit.org/show_bug.cgi?id=115799

Reviewed by Darin Adler.

HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().

• wtf/HashTraits.h:

8:07 AM Changeset in webkit [149738] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Avoid unnecessary arguments copying inside GenericHashTraits methods
​https://bugs.webkit.org/show_bug.cgi?id=115733

Reviewed by Darin Adler.

Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.

The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.

The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.

• wtf/HashTraits.h:

(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):

7:36 AM Changeset in webkit [149737] by zarvai@inf.u-szeged.hu

• 1 edit
  16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.

7:28 AM WebKitGTK/2.0.x edited by kov@webkit.org

Adding a couple reasonably simple GStreamer backend fixes (diff)

6:44 AM Changeset in webkit [149736] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=115791

Unreviewed EFL gardening

Skip fast/regions/ test cases which are failing after r149668.

Patch by Rijubrata Bhaumik <​rijubrata.bhaumik@intel.com> on 2013-05-08

• platform/efl/TestExpectations:

6:41 AM Changeset in webkit [149735] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Does memory buffering even with preload set to none
​https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

6:07 AM Changeset in webkit [149734] by akling@apple.com

• 2 edits in trunk/Source/WebCore

SVGStyledElement::getPresentationAttribute() does not need to be virtual.

From Blink r149888 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149888>

• svg/SVGStyledElement.h:

6:00 AM Changeset in webkit [149733] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Crash when loading link to audio file
​https://bugs.webkit.org/show_bug.cgi?id=115794

Reviewed by Jocelyn Turcotte.

Do not access a null pointer frame.

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

5:56 AM Changeset in webkit [149732] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
​https://bugs.webkit.org/show_bug.cgi?id=115785

• platform/qt/TestExpectations:

5:20 AM Changeset in webkit [149731] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt][WTR] Fix the build on Mac after r149692

Unreviewed build fix.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

4:54 AM Changeset in webkit [149730] by g.czajkowski@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip two spelling tests as they started passing after r149366.

• platform/efl-wk2/TestExpectations:

Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html

• platform/efl/TestExpectations:

Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.

3:59 AM Changeset in webkit [149729] by Christophe Dumez

• 20 edits in trunk/Source/WebCore

Remove unused [TransferList] extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115788

Reviewed by Kentaro Hara.

Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.

No new tests, no behavior change.

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

• bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
• bindings/scripts/test/CPP/WebDOMTestTypedefs.h:

(WebDOMTestTypedefs):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestTypedefs.idl:

3:38 AM Changeset in webkit [149728] by mario@webkit.org

• 3 edits in trunk/Tools

Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.

• Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
• Scripts/webkitpy/common/config/watchlist: Added myself.

3:37 AM WebKitIDL edited by Christophe Dumez

Remove [TransferList] (diff)

3:16 AM Changeset in webkit [149727] by sudarsana.nagineni@linux.intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip remaining Shadow DOM tests on the EFL port.

• platform/efl/TestExpectations:

2:50 AM Changeset in webkit [149726] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt] Build fails with clang
​https://bugs.webkit.org/show_bug.cgi?id=115741

Reviewed by Benjamin Poulain.

Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.

• qmake/mkspecs/features/unix/default_pre.prf:

2:41 AM Changeset in webkit [149725] by Darin Adler

• 3 edits in trunk/Tools

Fix one more place that needed to use adoptCF/NS
​https://bugs.webkit.org/show_bug.cgi?id=115778

Reviewed by Benjamin Poulain.

Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.

• WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.

• WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.

2:23 AM Changeset in webkit [149724] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests

that regressed when converted into reftests in r149668.

1:55 AM Changeset in webkit [149723] by commit-queue@webkit.org

• 7 edits in trunk

Make optional arguments in CanvasRenderingContext2D match the spec.
​https://bugs.webkit.org/show_bug.cgi?id=115723

Patch by Dongseong Hwang <​dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.

Source/WebCore:

WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.

[1] ​http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Covered by existing tests:

canvas/philip/tests/2d.missingargs.html
fast/canvas/canvas-overloads-strokeRect.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.

• fast/canvas/canvas-overloads-strokeRect-expected.txt:
• fast/canvas/script-tests/canvas-overloads-strokeRect.js:
• platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

1:54 AM WebKitIDL edited by Christophe Dumez

Rename JSCustomIsReachable to CustomIsReachable and … (diff)

1:50 AM WebKitIDL edited by Christophe Dumez

Remove JSCustomHeader (diff)

1:48 AM WebKitIDL edited by Christophe Dumez

Remove remaining mentions of V8 (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8DoNotCheckSignature (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIsReachable (diff)

1:43 AM WebKitIDL edited by Christophe Dumez

Remove [URL] (diff)

1:42 AM WebKitIDL edited by Christophe Dumez

Remove V8GenerateIsReachable and JSGenerateIsReachable (diff)

1:40 AM WebKitIDL edited by Christophe Dumez

Remove V8DependentLifeTime (diff)

1:39 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIndexedGetter (diff)

1:38 AM WebKitIDL edited by Christophe Dumez

Remove dead section from TOC (diff)

1:36 AM WebKitIDL edited by Christophe Dumez

Remove V8EnabledAtRuntime, V8EnabledPerContext from TOC (diff)

1:35 AM WebKitIDL edited by Christophe Dumez

Remove V8Unforgeable and V8OnProto (diff)

1:33 AM WebKitIDL edited by Christophe Dumez

Remove V8ReadOnly (diff)

1:29 AM WebKitIDL edited by Christophe Dumez

Remove mentions of JSCustom and V8Custom (diff)

1:28 AM Changeset in webkit [149722] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed, rolling out r149271.
​http://trac.webkit.org/changeset/149271
​https://bugs.webkit.org/show_bug.cgi?id=115780

The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-05-08

• BuildSlaveSupport/gtk/daemontools-buildbot.conf:

1:19 AM WebKitIDL edited by Christophe Dumez

Rename V8SkipVTableValidation to SkipVTableValidation (diff)

1:16 AM WebKitIDL edited by Christophe Dumez

Remove mentions of toV8() (diff)

1:14 AM Changeset in webkit [149721] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
​https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.

1:14 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

1:06 AM Changeset in webkit [149720] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115716

Reviewed by Andreas Kling.

WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.

• WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/NetworkInfo/WebNetworkInfoManager.h:

(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:

(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_networkInfoManager member variable and its getter method.

1:02 AM Changeset in webkit [149719] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Correct documentation for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=115507

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.

Corrected documentation for ewk_settings APIs.

• ewk/ewk_settings.h:

1:01 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:58 AM Changeset in webkit [149718] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove unused method and de-virtualize others in Element.h
​https://bugs.webkit.org/show_bug.cgi?id=115770

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49

The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.

• WebCore.exp.in:
• dom/Element.h:

(WebCore::Element::hasAuthorShadowRoot):

12:52 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:51 AM Changeset in webkit [149717] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebBatteryManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115715

Reviewed by Andreas Kling.

WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.

• WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/Battery/WebBatteryManager.h:

(WebBatteryManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebBatteryClient.cpp:

(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_batteryManager member variable and its getter method.

12:44 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:40 AM Changeset in webkit [149716] by Darin Adler

• 94 edits in trunk

Source/WebCore: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• platform/cf/win/CertificateCFWin.cpp:

(WebCore::copyCertificateToData):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):

• platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):

• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):

• platform/graphics/gstreamer/PlatformVideoWindowMac.mm:

(PlatformVideoWindow::PlatformVideoWindow):

• platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

• platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):

• platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawWindowsBitmap):

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):

• platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):

• platform/graphics/win/WKCAImageQueue.cpp:

(WebCore::WKCAImageQueue::WKCAImageQueue):

• platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile):

• platform/network/cf/AuthenticationCF.cpp:

(WebCore::core):

• platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath):

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::urlFromPath):
(WebCore::getURL):

• platform/win/LocalizedStringsWin.cpp:

(WebCore::createWebKitBundle):
(WebCore::localizedString):

• platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):

• plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

• plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

• rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.

Source/WebKit/win: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::Write):

• WebCache.cpp:

(WebCache::statistics):

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):

• WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

• WebDownloadCFNet.cpp:

(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):

• WebError.cpp:

(WebError::sslPeerCertificate):

• WebHistory.cpp:

(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):

• WebIconDatabase.cpp:

(postDidAddIconNotification):

• WebLocalizableStrings.cpp:

(cfBundleForStringsBundle):

• WebMutableURLRequest.cpp:

(WebMutableURLRequest::mutableCopy):

• WebPreferences.cpp:

(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):

• WebView.cpp:

(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.

Source/WebKit2: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

• Shared/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.

Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):

• DumpRenderTree/cg/ImageDiffCG.cpp:

(createImageFromStdin):
(createDifferenceImage):
(main):

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(printPNG):
(dumpBitmap):

• DumpRenderTree/cg/PixelDumpSupportCG.h:

(BitmapContext::BitmapContext):

• DumpRenderTree/mac/MockWebNotificationProvider.mm:

(-[MockWebNotificationProvider init]):

• DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createBitmapContext):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):

• DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData):

• DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

• DumpRenderTree/win/DumpRenderTree.cpp:

(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):

• DumpRenderTree/win/ImageDiffCairo.cpp:

(createImageFromStdin):
(main):

• DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):

• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

• TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:

(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

• TestWebKitAPI/Tests/mac/AttributedString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/BackForwardList.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):

• TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):

• TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

• TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetDocumentURI.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

• TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):

• WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:

(WTR::testPathFromURL):

• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

• WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollBy):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage):

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.

12:36 AM WebKitIDL edited by Christophe Dumez

Start using monospace for IDL extended attributes (diff)

12:24 AM WebKitIDL edited by Christophe Dumez

Remove deprecated "in" keyword from IDL examples (diff)

12:05 AM Changeset in webkit [149715] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.

• TestExpectations:

12:04 AM WebKitIDL edited by Christophe Dumez

Update documentation for optional and [Default] (diff)

12:03 AM Changeset in webkit [149714] by zandobersek@gmail.com

• 2 edits in trunk

[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
​https://bugs.webkit.org/show_bug.cgi?id=115732

Reviewed by Gustavo Noronha Silva.

• GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending

the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.

12:00 AM Changeset in webkit [149713] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/mac

<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency

Reviewed by Sam Weinig.

• Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.

May 7, 2013:

11:24 PM Changeset in webkit [149712] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
​https://bugs.webkit.org/show_bug.cgi?id=115771

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Gyuyoung Kim.

Unit test is failing since r149702. Remove the test case related to shadow dom.

• tests/test_ewk_setting.cpp:

10:08 PM Changeset in webkit [149711] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

Clean up load interface in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=115622
Patch by Xuefei Ren <​xren@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internal PR:315535
Internal reviewed by Mary Wu

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):

• Api/WebPage.h:
• Api/WebPage_p.h:

(WebPagePrivate):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:18 PM Changeset in webkit [149710] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
​https://bugs.webkit.org/show_bug.cgi?id=115764

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

CMYKA input is uncommon enough that we should not pay the price for
every CanvasStyle.
Make those values heap allocated and put the pointer in the union. Since
the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::isEquivalentCMYKA):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

• html/canvas/CanvasStyle.h:

(CanvasStyle):
(CMYKAValues):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
(WebCore::CanvasStyle::color):
(WebCore):

7:41 PM Changeset in webkit [149709] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues for requests in PluginView
​https://bugs.webkit.org/show_bug.cgi?id=115731

Reviewed by Sam Weinig.

• plugins/PluginView.cpp:

(WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
(WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
from m_requests rather than an explicit delete. Also use !isEmpty instead
of size > 0.
(WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
(WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.

• plugins/PluginView.h: Changed argument type of scheduleRequest to

PassOwnPtr, and m_requests to a Vector<OwnPtr>.

7:03 PM Changeset in webkit [149708] by Antti Koivisto

• 18 edits
  2 deletes in trunk/Source

Remove SelectRuleFeatureSet
​https://bugs.webkit.org/show_bug.cgi?id=115757

Reviewed by Benjamin Poulain.

This is dead code.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.exp.in:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore):
(WebCore::Element::didAffectSelector):

• dom/Element.h:

(Element):

• dom/ElementShadow.h:

(WebCore::ElementShadow::invalidateDistribution):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ContentDistributor):
(WebCore):

• html/shadow/ContentDistributor.h:

(ContentDistributor):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):

• html/shadow/InsertionPoint.h:

(InsertionPoint):

• html/shadow/SelectRuleFeatureSet.cpp: Removed.
• html/shadow/SelectRuleFeatureSet.h: Removed.
• testing/Internals.cpp:

(WebCore):

• testing/Internals.idl:

6:47 PM Changeset in webkit [149707] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Store the quotes in the same allocation as the QuotesData object
​https://bugs.webkit.org/show_bug.cgi?id=115768

Reviewed by Andreas Kling.

Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
they can just be stored after the class data.

• rendering/style/QuotesData.cpp:

(WebCore::sizeForQuotesDataWithQuoteCount):
Helper function for computing the allocation size.

(WebCore::QuotesData::create):
Use fastMalloc + placement new.

(WebCore::QuotesData::QuotesData):
Use placement new to allocate the quote pairs.

(WebCore::QuotesData::~QuotesData):
Destroy the quote pairs.

(WebCore::QuotesData::openQuote):
Stop using Vector.

(WebCore::QuotesData::closeQuote):
Ditto.

(WebCore::operator==):
Ditto.

• rendering/style/QuotesData.h:

6:42 PM Changeset in webkit [149706] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

We should not ref() the RefPtr twice in CanvasStyle

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Darin Adler.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.

6:41 PM Changeset in webkit [149705] by rniwa@webkit.org

• 14 edits in trunk/Source/WebCore

Devirtualize Document class type checking
​https://bugs.webkit.org/show_bug.cgi?id=115755

Reviewed by Benjamin Poulain.

Merge ​https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950

Document has a bunch of virtual bool is*Document() methods on it, but it also has
two bools for XHTML and HTML documents which is silly. We can merge them all
together into an enum of values and devirtualize the type checking methods.

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createElement):

• dom/Document.h:

(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::isHTMLDocument):
(WebCore::Document::isXHTMLDocument):
(WebCore::Document::isImageDocument):
(WebCore::Document::isSVGDocument):
(WebCore::Document::isPluginDocument):
(WebCore::Document::isMediaDocument):
(WebCore::Document):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::HTMLDocument):

• html/HTMLDocument.h:

(WebCore::HTMLDocument):

• html/ImageDocument.cpp:

(WebCore::ImageDocument::ImageDocument):

• html/ImageDocument.h:

(WebCore::ImageDocument):

• html/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):

• html/MediaDocument.h:

(WebCore::MediaDocument):

• html/PluginDocument.cpp:

(WebCore::PluginDocument::PluginDocument):

• html/PluginDocument.h:

(WebCore::PluginDocument):

• loader/PlaceholderDocument.h:

(WebCore::PlaceholderDocument::PlaceholderDocument):

• svg/SVGDocument.cpp:

(WebCore::SVGDocument::SVGDocument):

• svg/SVGDocument.h:

(WebCore::SVGDocument):

6:35 PM Changeset in webkit [149704] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix a memory leak introduced in r149692
​https://bugs.webkit.org/show_bug.cgi?id=115766

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Mark Rowe.

In r149692, the fix for <​http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.

6:26 PM Changeset in webkit [149703] by Darin Adler

• 2 edits in trunk/Tools

[Win] Fix storage leak in Windows DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=115651

Reviewed by Sam Weinig.

• DumpRenderTree/win/DumpRenderTree.cpp:

(lastPathComponent): Added a missing call to adoptCF.

6:13 PM Changeset in webkit [149702] by gyuyoung.kim@samsung.com

• 3 edits in trunk

[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
​https://bugs.webkit.org/show_bug.cgi?id=115712

Reviewed by Andreas Kling.

Nobody uses SHADOW_DOM in cmake.

• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

5:11 PM Changeset in webkit [149701] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

Add SPI to get an array of all the installed plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=115688

Reviewed by Anders Carlsson.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(createInfoDictionary):
Extract creation of info dictionary into helper.
(WKContextCopyPlugInInfoForBundleIdentifier):
Modified to use the new helper.
(WKContextGetInfoForInstalledPlugIns):
Added.

4:07 PM Changeset in webkit [149700] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Begin unraveling the mess that is QuotesData
​https://bugs.webkit.org/show_bug.cgi?id=115765

Reviewed by Andreas Kling.

Change QuotesData to be an immutable object and fix other things that are broken.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):
Update for renames.

• rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):
Remove the create overload that wasn't used. Add a new create overload that takes a Vector.

(WebCore::QuotesData::openQuote):
Rename this from getOpenQuote and clean it up.

(WebCore::QuotesData::closeQuote):
Rename this from getCloseQuote and clean it up.

(WebCore::operator==):
Replace the equals member function with a proper equality operator.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
Stop calling QuotesData::equals. Use the same idiom as used for other properties.

(WebCore::RenderStyle::setQuotes):

• rendering/style/StyleRareInheritedData.cpp:

Use operator==.

(WebCore::quotesDataEquivalent):
Add helper function.

(WebCore::StyleRareInheritedData::operator==):
Call quotesDataEquivalent.

3:54 PM Changeset in webkit [149699] by hmuller@adobe.com

• 3 edits
  1 add
  1 delete in trunk/LayoutTests

[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115649

Reviewed by Dirk Schulze.

Another correction of a padded shape test that failed when subpixel layout was disabled.
This test puts a cross pattern made of five Ahem characters on three lines, within a padded
diamond polygon. The left edges of each line depend on the intersection of the padded polygon's
edges with the top of each line, which makes predicting the exact values unreliable. So we
just verify that the left edges of each line are within a pixel of the ideal value. This
change is very similar to the one made for bug 115490.

• fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Removed.
• fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
• fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html:
• platform/mac/TestExpectations:

3:41 PM Changeset in webkit [149698] by enrica@apple.com

• 3 edits
  3 adds in trunk

Support -webkit-system-font on OS X.
​https://bugs.webkit.org/show_bug.cgi?id=115758
<rdar://problem/13433854>

3:26 PM Changeset in webkit [149697] by commit-queue@webkit.org

• 2 edits in trunk/Tools

fixed a memory leak introduced by bug 42324 by using a RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=115760

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros

3:14 PM Changeset in webkit [149696] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Move CanvasGradient and CanvasPattern in the union of CanvasStyle
​https://bugs.webkit.org/show_bug.cgi?id=115759

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

The Gradient and Pattern are exclusive with the other values, but they
were left out of the union because they are ref-counted.

This patch moves them in the union, and simply does the ref-counting manually.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):

• html/canvas/CanvasStyle.h:

(CanvasStyle):
(WebCore::CanvasStyle::canvasGradient):
(WebCore::CanvasStyle::canvasPattern):

3:06 PM Changeset in webkit [149695] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Remove custom allocator support from PODArena
​https://bugs.webkit.org/show_bug.cgi?id=115762

Reviewed by Andreas Kling.

Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.

• platform/PODArena.h:

(WebCore::PODArena::PODArena):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(Chunk):

• platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::allocate):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):

3:04 PM Changeset in webkit [149694] by andersca@apple.com

• 12 edits in trunk/Source

Clean up KeyframeValueList and related classes
​https://bugs.webkit.org/show_bug.cgi?id=115738

Reviewed by Simon Fraser.

Source/WebCore:

Add static create() functions to the AnimationValue subclasses, and change a bunch of parameters
and return values that can never be null from pointer types to reference types to better indicate this.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
(WebCore::operationsAt):
(WebCore::GraphicsLayer::validateTransformOperations):

• platform/graphics/GraphicsLayer.h:

(AnimationValue):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(FloatAnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(TransformAnimationValue):
(WebCore::TransformAnimationValue::value):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::value):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(FilterAnimationValue):
(WebCore::KeyframeValueList::~KeyframeValueList):
(KeyframeValueList):
(WebCore::KeyframeValueList::at):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):

• platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

Source/WebKit2:

Update for WebCore changes.

• Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):

2:52 PM Changeset in webkit [149693] by andersca@apple.com

• 7 edits in trunk/Source

Add and remove databases and origins from the database tracker
​https://bugs.webkit.org/show_bug.cgi?id=115752

Reviewed by Andreas Kling.

Source/WebCore:

Add symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Rename m_databaseFilename to m_databasePath.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Rename m_databaseFilename to m_databasePath.

• UIProcess/Storage/LocalStorageDatabase.h:

Rename m_databaseFilename to m_databasePath.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databasePath):
Rename databaseFilename to databasePath.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
Call addDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Call removeDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
Call databasePath instead of databaseFile.

(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Bail if the database is already open.

(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Call addDatabaseWithOriginIdentifier if this is an origin we don't know about.

(WebKit::LocalStorageDatabaseTracker::addDatabaseWithOriginIdentifier):
Add the database to the Origins table.

(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
remove the database from the Origins table and delete it.

(WebKit::LocalStorageDatabaseTracker::pathForDatabaseWithOriginIdentifier):
Helper function that looks up a database path given its identifier.

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

Rename databaseFile to databasePath.

2:26 PM Changeset in webkit [149692] by commit-queue@webkit.org

• 6 edits
  4 adds in trunk/Tools

WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
​https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Added dumpDOMAsWebArchive JavaScript function to be called by test cases.

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.

• Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.

• Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.

• Tools/WebKitTestRunner/cf: Added.
• Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.

Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):

• Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.

Copied from Tools/DumpRenderTree/cf for used symbol declarations.

• Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.

Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):

2:12 PM Changeset in webkit [149691] by Beth Dakin

• 3 edits in trunk/Source/WebCore

Still possible to fire paint-related LayoutMilestones before CA has committed the
changes
​https://bugs.webkit.org/show_bug.cgi?id=115753
-and corresponding-
<rdar://problem/13822315>

Reviewed by Simon Fraser.

To ensure we wait for the CA commit, we should wait until the end of the runloop
with a zero-delay timer.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
(WebCore):

• rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

2:09 PM Changeset in webkit [149690] by Chris Fleizach

• 2 edits in trunk/Source/WebCore

Bug 115694 - Fix bad cast to RenderHTMLCanvas
​https://bugs.webkit.org/show_bug.cgi?id=115694

Reviewed by Ryosuke Niwa.

Don't cast to RenderHTML until we check what kind of object it is.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

1:30 PM Changeset in webkit [149689] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase the padding size for caret based scrolling.
​https://bugs.webkit.org/show_bug.cgi?id=115749

Reviewed by Rob Buis.

PR 322670.

Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1:07 PM Performance Tests edited by rwlbuis@webkit.org

(diff)

12:42 PM Changeset in webkit [149688] by andersca@apple.com

• 7 edits in trunk/Source

The storage database tracker should know when databases come and go
​https://bugs.webkit.org/show_bug.cgi?id=115748

Reviewed by Andreas Kling.

Source/WebCore:

Export symbol needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::openDatabase):
If we've opened the database successfully, call LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Remove a FIXME; we run all storage related things on the same thread.

(WebKit::LocalStorageDatabase::close):
Close the database. If it's empty, call LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::databaseIsEmpty):
Helper function for determining whether a database is empty.

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Add ".localstorage" to the filename.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Add empty stubs.

12:11 PM Changeset in webkit [149687] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Add JoinExistingSession to the Networking XPC.
<rdar://problem/12902288> and ​https://bugs.webkit.org/show_bug.cgi?id=114991

Reviewed by Sam Weinig.

• NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:

12:08 PM Changeset in webkit [149686] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=115745

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(compareResourceURLs):
Updated style.

11:52 AM Changeset in webkit [149685] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Maintain touch event state throughout processing
​https://bugs.webkit.org/show_bug.cgi?id=115663

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Otto Cheung and Genevieve Mak.

PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):

• Api/WebPage_p.h:

(WebPagePrivate):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:42 AM Changeset in webkit [149684] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SVGResourcesCache
​https://bugs.webkit.org/show_bug.cgi?id=115729

Reviewed by Benjamin Poulain.

• rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::~SVGResourcesCache): Removed call to deleteAllValues.
(WebCore::SVGResourcesCache::addResourcesFromRenderObject): Use adoptPtr and release
to create new SVGResources object.
(WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Use take to remove
the SVGResources from the map rather than a get combined with delete/take.
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Removed unneeded
call to contains, since get already returns 0 if there is no item in the map.
(WebCore::SVGResourcesCache::resourceDestroyed): Use typedef for the map type so
we don't have to repeat the type.

• rendering/svg/SVGResourcesCache.h: Added typedef CacheMap, and changed value

type to OwnPtr.

11:30 AM Changeset in webkit [149683] by andersca@apple.com

• 4 edits in trunk/Source

REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
​https://bugs.webkit.org/show_bug.cgi?id=115711

Reviewed by Andreas Kling.

Source/WebCore:

Export SQLiteDatabase::close.

• WebCore.exp.in:

Source/WebKit2:

Handle setting the local storage directory more than once.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Close the database (if necessary) and clear the origins map before importing the origin identifiers.

11:12 AM Changeset in webkit [149682] by Antoine Quint

• 4 edits in trunk/Source/WebKit2

Re-establish autostart timeout extension on user interaction
​https://bugs.webkit.org/show_bug.cgi?id=113232

Change WebProcess::pluginDidReceiveUserInteraction to use a tuple of
(pluginOrigin, pageOrigin, mimeType) arguments like the other similar
WebProcess methods and gather these arguments from the PlugInView's
plug-in element.

Reviewed by Dean Jackson.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginDidReceiveUserInteraction):
Cast the m_pluginElement to a HTMLPlugInImageElement so we can obtain the
tuple of (pluginOrigin, pageOrigin, mimeType) to pass to pluginDidReceiveUserInteraction().

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::plugInDidReceiveUserInteraction):

• WebProcess/WebProcess.h:

(WebProcess):
Update method signature to a tuple of (pluginOrigin, pageOrigin, mimeType)
and obtain the plug-in origin hash from that.

10:58 AM Changeset in webkit [149681] by ap@apple.com

• 26 edits
  1 delete in trunk/LayoutTests

Combine html and js parts fast/url script-tests
​https://bugs.webkit.org/show_bug.cgi?id=115739

Rubber-stamped by Brady Eidson.

• fast/url/anchor.html:
• fast/url/file-http-base.html:
• fast/url/file.html:
• fast/url/host-lowercase-per-scheme.html:
• fast/url/host.html:
• fast/url/idna2003.html:
• fast/url/idna2008.html:
• fast/url/invalid-urls-utf8.html:
• fast/url/ipv4.html:
• fast/url/ipv6.html:
• fast/url/mailto.html:
• fast/url/path-url.html:
• fast/url/path.html:
• fast/url/port.html:
• fast/url/query.html:
• fast/url/relative-unix.html:
• fast/url/relative-win.html:
• fast/url/relative.html:
• fast/url/safari-extension.html:
• fast/url/scheme.html:
• fast/url/script-tests: Removed.
• fast/url/script-tests/TEMPLATE.html: Removed.
• fast/url/script-tests/anchor.js: Removed.
• fast/url/script-tests/file-http-base.js: Removed.
• fast/url/script-tests/file.js: Removed.
• fast/url/script-tests/host.js: Removed.
• fast/url/script-tests/idna2003.js: Removed.
• fast/url/script-tests/idna2008.js: Removed.
• fast/url/script-tests/ipv4.js: Removed.
• fast/url/script-tests/ipv6.js: Removed.
• fast/url/script-tests/mailto.js: Removed.
• fast/url/script-tests/path-url.js: Removed.
• fast/url/script-tests/path.js: Removed.
• fast/url/script-tests/port.js: Removed.
• fast/url/script-tests/query.js: Removed.
• fast/url/script-tests/relative-unix.js: Removed.
• fast/url/script-tests/relative-win.js: Removed.
• fast/url/script-tests/relative.js: Removed.
• fast/url/script-tests/scheme.js: Removed.
• fast/url/script-tests/segments-from-data-url.js: Removed.
• fast/url/script-tests/segments.js: Removed.
• fast/url/script-tests/standard-url.js: Removed.
• fast/url/script-tests/trivial-segments.js: Removed.
• fast/url/script-tests/trivial.js: Removed.
• fast/url/segments-from-data-url.html:
• fast/url/segments.html:
• fast/url/standard-url.html:
• fast/url/trivial-segments.html:
• fast/url/trivial.html:

10:45 AM Changeset in webkit [149680] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Each local storage database should know its origin
​https://bugs.webkit.org/show_bug.cgi?id=115737

Reviewed by Andreas Kling.

Store the security origin in a member variable. It'll be used to communicate database state changes to the tracker.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:

(LocalStorageDatabase):

10:42 AM Changeset in webkit [149679] by rniwa@webkit.org

• 8 edits in trunk

Add an 'isReadOnly' member to IDL parse tree structure
​https://bugs.webkit.org/show_bug.cgi?id=115704

Reviewed by Kentaro Hara.

Source/WebCore:

Add an 'isReadOnly' member to IDL parse tree structure by merging
​https://chromium.googlesource.com/chromium/blink/+/d6add80ecd08bcd88a6ae0e1698d929830b3bd8b
and update Objective-C, C++, and GObject binding generators to use isReadOnly.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorGObject.pm:

(GetWriteableProperties):
(GenerateProperty):
(GenerateFunctions):

• bindings/scripts/CodeGeneratorJS.pm:

(IsReadonly):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/IDLParser.pm:

(parseAttributeRest):
(parseExceptionField):
(parseAttributeRestOld):

Tools:

Use newly added isReadOnly attribute.

• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):

10:10 AM Changeset in webkit [149678] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Remove some unnecessary soft linking in NetworkProcess. (Take 2)
<rdar://problem/13821779> and ​https://bugs.webkit.org/show_bug.cgi?id=115683

Reviewed by Dean Jackson and owned by Andreas Kling.

As a followup to r149651, include the private headers conditionally.
Also, fix a bug introduced with r149651 (bool vs CFBooleanRef).

• NetworkProcess/mac/DiskCacheMonitor.mm:
• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

9:54 AM Changeset in webkit [149677] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SMILTimeContainer
​https://bugs.webkit.org/show_bug.cgi?id=115730

Reviewed by Geoffrey Garen.

• svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::~SMILTimeContainer): Removed call to deleteAllValues.
(WebCore::SMILTimeContainer::schedule): Use add instead of get/set to put a new
AnimationsVector into the map as needed.
(WebCore::SMILTimeContainer::setElapsed): Added get since values are OwnPtr now.
(WebCore::SMILTimeContainer::updateAnimations): Ditto.

• svg/animation/SMILTimeContainer.h: Changed value type of GroupedAnimationsMap

to OwnPtr instead of raw pointer.

9:53 AM Changeset in webkit [149676] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Take advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
​https://bugs.webkit.org/show_bug.cgi?id=115722

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-07
Reviewed by Oliver Hunt.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8PostInc):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load16PostInc):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::movwMemRegIn):
(SH4Assembler):
(JSC::SH4Assembler::movbMemRegIn):
(JSC::SH4Assembler::printInstr):

9:24 AM Changeset in webkit [149675] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Read-only fields should not get keyboard focus
​https://bugs.webkit.org/show_bug.cgi?id=115725

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):

• WebKitSupport/DOMSupport.h:
• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):

• WebKitSupport/InputHandler.h:

9:18 AM Changeset in webkit [149674] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Expand spellcheck logging
​https://bugs.webkit.org/show_bug.cgi?id=115482

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

9:01 AM Changeset in webkit [149673] by andersca@apple.com

• 30 edits
  1 delete in trunk

Remove AlwaysInline.h from WTF
​https://bugs.webkit.org/show_bug.cgi?id=115727

Reviewed by Brent Fulgham.

The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
to keep AlwaysInline.h around anymore.

Source/JavaScriptCore:

• jit/JSInterfaceJIT.h:
• parser/Lexer.h:
• runtime/JSCJSValue.h:
• runtime/SymbolTable.h:

Source/WebCore:

• WebCore.vcproj/WebCore.vcproj:
• bindings/js/JSDOMWindowCustom.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• platform/graphics/filters/FEConvolveMatrix.h:
• rendering/InlineIterator.h:
• rendering/InlineTextBox.cpp:
• rendering/RenderBlockLineLayout.cpp:
• rendering/RenderText.cpp:

Source/WTF:

• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/AlwaysInline.h: Removed.
• wtf/BloomFilter.h:
• wtf/FastMalloc.cpp:
• wtf/PassRefPtr.h:
• wtf/dtoa.cpp:
• wtf/gobject/GRefPtr.h:

Tools:

• DumpRenderTree/qt/DumpRenderTreeMain.cpp:
• WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

8:53 AM Changeset in webkit [149672] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Curl] POST requests sometimes fail.
​https://bugs.webkit.org/show_bug.cgi?id=111844

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-07
Reviewed by Brent Fulgham.

Curl adds the header 'Expect: 100-Continue' when sending a POST request.
When we receive the header 'HTTP/1.1 100 Continue', we should not call
ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
because the MIME type is empty in this case, causing the POST request to fail.
This header is only sent as an info header, or provisional response.

In addition, this patch changes the classification of http code 304 (Not modified).
It is not reported as a redirect anymore, but as a response
(ResourceHandleClient::didReceiveResponse() is called.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::isHttpInfo): Added helper method to determine if http code is http info.
(WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
(WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.

8:33 AM Changeset in webkit [149671] by allan.jensen@digia.com

• 3 edits in trunk/Source/WebKit/qt

Crash when calling QWebFrame::evaluateJavaScript
​https://bugs.webkit.org/show_bug.cgi?id=113434

Reviewed by Simon Hausmann.

Ensure we hold the JSLock when converting JSValue to JSValueRef.

• Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):

• WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::evaluateJavaScript):

8:13 AM Changeset in webkit [149670] by ryuan.choi@samsung.com

• 6 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk APIs for setting and getting user agent
​https://bugs.webkit.org/show_bug.cgi?id=114429

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Andreas Kling.

Provide ewk_view_user_agent_get/set APIs which wraps WK APIs.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::setUserAgent):

• UIProcess/API/efl/EwkView.h:

(EwkView::userAgent):
(EwkView):

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_user_agent_get):
(ewk_view_user_agent_set):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

8:07 AM Changeset in webkit [149669] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[X11][BlackBerry] Check if MOZ_X11 is defined instead of XP_UNIX npruntime_internal.h
​https://bugs.webkit.org/show_bug.cgi?id=113687

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-05-07
Reviewed by Anders Carlsson.

It's assumed that all UNIX platforms use X11 for plugins, which is
not the case of BlackBerry.

• bridge/npruntime_internal.h: Use MOZ_X11 instead of XP_UNIX.

7:41 AM Changeset in webkit [149668] by commit-queue@webkit.org

• 3 edits
  4 adds
  32 deletes in trunk/LayoutTests

[CSS Regions] Convert remaining fast/regions/webkit-flow* pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=115422

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-07
Reviewed by Andreas Kling.

Converted following tests from pixel tests to ref tests:

• webkit-flow-double-pagination-float-push
• webkit-flow-float-pushed-to-last-region
• webkit-flow-float-unable-to-push
• webkit-flow-floats-inside-regions-bounds

• fast/regions/webkit-flow-double-pagination-float-push-expected.html: Added.
• fast/regions/webkit-flow-float-pushed-to-last-region-expected.html: Added.
• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• fast/regions/webkit-flow-float-unable-to-push-expected.html: Added.
• fast/regions/webkit-flow-float-unable-to-push.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html: Added.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.

4:01 AM Changeset in webkit [149667] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=114808

Reviewed by Jocelyn Turcotte.

QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
(​https://codereview.qt-project.org/#change,54234)

• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

12:42 AM Changeset in webkit [149666] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/gtk

[GTK] Initialize WebKitWebPlugin path to prevent double-free
​https://bugs.webkit.org/show_bug.cgi?id=115624

Patch by Tomas Popela <​tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.

Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.

• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):

• webkit/webkitwebpluginprivate.h:

12:23 AM Changeset in webkit [149665] by mikhail.pozdnyakov@intel.com

• 41 edits in trunk/Source

HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance
​https://bugs.webkit.org/show_bug.cgi?id=115646

Reviewed by Darin Adler.

Source/JavaScriptCore:

• bytecompiler/StaticPropertyAnalyzer.h:

(JSC::StaticPropertyAnalyzer::putById):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebCore:

No new tests, no new functionality.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::remove):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::objectFromAXID):

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::getImage):

• css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elementForAlias):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::findInsertionPointFor):

• loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForURL):

• loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::archiveResourceForURL):

• page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateMaskLayer):

• platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::getBlobDataFromURL):

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):

• rendering/RenderCounter.cpp:

(WebCore::makeCounterNode):
(showCounterRendererTree):

• svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::getEffectById):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebKit/mac:

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginInstance):

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebKit2:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):

• NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::hostForURL):

• Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
(WebKit::StorageManager::findStorageArea):

• UIProcess/WebContext.h:

(WebKit::WebContext::supplement):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::webBackForwardItem):
(WebKit::WebProcessProxy::webFrame):

• UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::ewkDownloadJob):

• WebProcess/Network/WebResourceLoadScheduler.h:

(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamFromID):

• WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelStreamLoad):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::itemForID):
(WebKit::WebBackForwardListProxy::itemAtIndex):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::webUndoStep):
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPage):
(WebKit::WebProcess::webPageGroup):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WTF:

HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we
can obviate multiple RefPtr copying when invoking HashMap<.., RefPtr>::get()
method.

• wtf/HashTraits.h:

May 6, 2013:

11:31 PM Changeset in webkit [149664] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149637.

• Target.pri:

11:13 PM Changeset in webkit [149663] by Christophe Dumez

• 2 edits in trunk/Tools

Unreviewed. Add my email to EFL and BindingsScripts watchlists.

• Scripts/webkitpy/common/config/watchlist:

10:20 PM Changeset in webkit [149662] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
​https://bugs.webkit.org/show_bug.cgi?id=115711

Rubber-stamped by Anders Carlsson.

Temporarily removed the assertion. Andres is going to investigate it tomorrow.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):

9:31 PM Changeset in webkit [149661] by Darin Adler

• 6 edits in trunk/Source

Use OwnPtr instead of deleteAllValues in KeyframeValueList
​https://bugs.webkit.org/show_bug.cgi?id=115652

Reviewed by Simon Fraser.

Source/WebCore:

Also made a few related style fixes in the functions touched.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::KeyframeValueList::insert): Change argument type to PassOwnPtr
and update use of m_values since it has OwnPtr now instead of raw pointer.

• platform/graphics/GraphicsLayer.h: Move conditional includes to a

separate paragraph, removed an unneeded forward class declaration.
(WebCore::AnimationValue::AnimationValue): Marked this constructor explicit
and removed an unneeded if statement.
(WebCore::AnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::FloatAnimationValue::clone): Changed this to return a PassOwnPtr.
(WebCore::TransformAnimationValue::TransformAnimationValue): Marked explicit.
(WebCore::TransformAnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::FilterAnimationValue::FilterAnimationValue): Marked explicit.
(WebCore::FilterAnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::KeyframeValueList::KeyframeValueList): Marked explicit.
(WebCore::KeyframeValueList::~KeyframeValueList): Removed, since the default
destructor works without an explicit deleteAllValues call.
(WebCore::KeyframeValueList::at): Added call to get needed since the vector
contains OwnPtr now.
(WebCore::KeyframeValueList::insert): Changed to take PassOwnPtr and then
removed now-redundant comment saying "takes ownership of the pointer".
(WebCore::KeyframeValueList::m_values): Changed type to Vector<OwnPtr>.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation): Added adoptPtr next to the
all the places new was done before calling KeyframeValueList::insert. Also
simplified the booleans and #if in this function.
(WebCore::RenderLayerBacking::startTransition): Ditto.

Source/WebKit2:

• Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::ArgumentCoder<GraphicsLayerAnimation>::decode): Added adoptPtr
next to new when calling KeyframeValueList::insert.

9:15 PM Changeset in webkit [149660] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

[Replaceable] attributes must be readonly
​https://bugs.webkit.org/show_bug.cgi?id=115692

Reviewed by Kentaro Hara.

Merge ​https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.

Web IDL specification says [Replaceable] attributes are readonly:
​http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable

Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
already assumed [Replaceable] attributes are readonly.

• html/HTMLDocument.idl:
• page/DOMWindow.idl:

9:05 PM Changeset in webkit [149659] by kangil.han@samsung.com

• 4 edits in trunk/Tools

[EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=115645

Reviewed by Gyuyoung Kim.

To run performance tests in wk1, we need --no-timeout option implementation.
So adopt it from gtk+ port.

• DumpRenderTree/efl/DumpRenderTree.cpp:

(shouldSetWaitToDumpWatchdog):
(parseCommandLineOptions):

• DumpRenderTree/efl/DumpRenderTreeEfl.h:
• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setWaitToDump):

8:13 PM Changeset in webkit [149658] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed, build fix on EFL port

• CMakeLists.txt: Add LocalStorageDatabaseTracker.cpp

7:18 PM Changeset in webkit [149657] by Philippe Normand

• 2 edits in trunk/Source/WebKit2

Unreviewed, GTK build fix after r149637.

• GNUmakefile.list.am: Add LocalStorageDatabaseTracker sources to

the build.

6:36 PM Changeset in webkit [149656] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit/win

Unreviewed. AppleWin build fix.

• WebKit.vcproj/WebKitExports.def.in:

5:46 PM Changeset in webkit [149655] by mark.lam@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix broken 32-bit build + some clean up in JITStubs.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=115684.

Reviewed by Geoffrey Garen.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/JITStubs.cpp:
• removed unneeded stubs for CPU(X86_64) && USE(JSVALUE32_64).
• added some line breaks to more clearly delineate between ports/configurations of stub code.

5:45 PM Changeset in webkit [149654] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in DocumentMarkerController
​https://bugs.webkit.org/show_bug.cgi?id=115655

Reviewed by Andreas Kling.

• dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::~DocumentMarkerController): Added here
so the destructor isn't implicitly inline.
(WebCore::DocumentMarkerController::detach): Removed now-unneeded code to
call deleteAllValues. Also moved code to set m_possiblyExistingMarkerTypes
to after clearing m_markers to be consistent with how other functions do it.
(WebCore::DocumentMarkerController::addMarker): Changed code to use the
add idiom to avoid double hash table lookup. Changed to use adoptPtr since
the map now contains OwnPtr.
(WebCore::DocumentMarkerController::removeMarkers): Removed explicit calls
to delete list since removing the entry from the map now deletes the list.
Moved the code to check if m_markers has become empty so it's only called
when we actually remove something from m_markers.
(WebCore::DocumentMarkerController::markerContainingPoint): Added get().
(WebCore::DocumentMarkerController::renderedRectsForMarkers): Added get().
(WebCore::DocumentMarkerController::removeMarkers): Changed to use a new
interface to removeMarkersFromList. This eliminated the need to copy the
entire map when removing markers; instead we can just copy the keys.
(WebCore::DocumentMarkerController::removeMarkersFromList): Changed to use
an iterator instead of being passed the key/value pair from the map. Also
rearranged the logic so there is less repeated code and removed some now-
unneeded comments.
(WebCore::DocumentMarkerController::repaintMarkers): Added get().
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
Added get().
(WebCore::DocumentMarkerController::showMarkers): Added get().

• dom/DocumentMarkerController.h: Removed implementation of the destructor

that called the detach function; that was just sharing the now-unneeded
call to deleteAllValues. Changed the type of the map to use an OwnPtr for
the value. Changed the interface of removeMarkersFromList to take a map
iterator instead of a key/value pair.

5:33 PM Changeset in webkit [149653] by Beth Dakin

• 5 edits in trunk/Source/WebCore

Reproducible crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent()
​https://bugs.webkit.org/show_bug.cgi?id=115685
-and corresponding-
<rdar://problem/13700734>

Reviewed by Sam Weinig.

This fix here is just to rollout the change that caused this regression, which is
​http://trac.webkit.org/changeset/147395 . That change was not intended to cause any
behavioral differences. The change made it so RenderObject::offsetParent() returned
an Element* instead of a RenderBoxModelObject*. However, can muddle things when the
object we are returning is a continuation. Multiple RenderObjects have the same
Element in a continuation, so this new code can lead to a crash in
adjustedPositionRelativeToOffsetParent() when we expect to walk the RenderObject
chain and find the offsetParent in the Element’s parent chain. But we might crash in
some complicated continuation scenarios because we lost this disambiguation of which
RenderObject to start with.

Roll out.

• dom/Element.cpp:

(WebCore::Element::offsetParent):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

• rendering/RenderObject.h:

(RenderObject):

5:20 PM Changeset in webkit [149652] by rniwa@webkit.org

• 25 edits in trunk/Source/WebCore

Unify ways to cache named item in HTMLCollections
​https://bugs.webkit.org/show_bug.cgi?id=115584

Reviewed by Antti Koivisto.

Refactor the code to share the same infrastructure for both id and name attributes maps.

Also get rid of shouldRegisterAsNamedItem and shouldRegisterAsExtraNamedItem from various Element subclasses
as these member functions were duplicating the information in HTMLNameCollection.cpp. Nevertheless, HTMLImageElement
and HTMLObjectElement still update HTMLDocument's window and document name getter maps when their presence as named
item changes due to an attribute change and children changes respectively.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter): Use windowNamedItemMap().containsSingle() instead of collection->hasExactlyOneItem() to
avoid instantiating HTMLCollection until we know for sure we're returning multiple items.
(WebCore::JSDOMWindow::getOwnPropertySlot): Call windowNamedItemMap().contains() instead of document->hasNamedItem()
since the latter has been removed.
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): Ditto.
(WebCore::JSDOMWindow::getOwnPropertyDescriptor): Ditto.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName): Call documentNamedItemMap().contains() instead of
document->hasExtraNamedItem() since the latter has been removed.
(WebCore::JSHTMLDocument::nameGetter): Use documentNamedItemMap().containsSingle() instead of
collection->hasExactlyOneItem() to avoid instantiating HTMLCollection when we're returning the first item.

• dom/Document.cpp:

(WebCore::Document::windowNamedItems): Instantiate WindowNameCollection, which is a subclass of HTMLNameCollection,
instead of HTMLNameCollection since the latter class no longer has a public constructor.
(WebCore::Document::documentNamedItems): Ditto; instantiate DocumentNameCollection.

• dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesName): Added for name attribute.
(WebCore::keyMatchesWindowNamedItem): Added for window name getter.
(WebCore::keyMatchesDocumentNamedItem): Added for document name getter.
(WebCore::DocumentOrderedMap::getElementByName): Added for name attribute.
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem): Added for window name getter.
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem): Added for document name getter.

• dom/DocumentOrderedMap.h:

(WebCore::DocumentOrderedMap::containsSingle): Added.
(WebCore::DocumentOrderedMap::containsMultiple): Fixed the bug that containsMultiple returns true even when
the duplicate count has been reduced to 1. Unfortunately this behavior change is not testable because the old code
worked properly (though less efficient) even if this function returned a wrong value.

• dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName): Added. Updates TreeScope's name attribute map as well as HTMLDocument's window name
and document name maps.
(WebCore::Element::updateId): Added the code to update HTMLDocument's window name and document name maps.

• dom/Element.h:

(Element): Removed shouldRegisterAsNamedItem, shouldRegisterAsExtraNamedItem, updateNamedItemRegistration, and
updateExtraNamedItemRegistration as they're no longer used.

• dom/TreeScope.cpp:

(SameSizeAsTreeScope):
(WebCore::TreeScope::getElementByName): Added.
(WebCore::TreeScope::addElementByName): Added.
(WebCore::TreeScope::removeElementByName): Added.

• dom/TreeScope.h:

(WebCore::TreeScope::hasElementWithName): Added.
(WebCore::TreeScope::containsMultipleElementsWithName): Added.

• html/HTMLAppletElement.h:

(HTMLAppletElement):

• html/HTMLCollection.cpp:

(WebCore::isMatchingElement): Use HTMLNameCollection subclasses' nodeMatches.
(WebCore::HTMLCollection::namedItem): Added a fast path for named item.
(WebCore::HTMLCollection::hasNamedItem): Use namedItem to avoid the work in the fast path.

• html/HTMLCollection.h:

(HTMLCollection): Removed checkForNameMatch.

• html/HTMLDocument.cpp:

(WebCore): Removed various member functions related to m_namedItemCounts and m_extraNamedItemCounts.

• html/HTMLDocument.h:

(WebCore::HTMLDocument::documentNamedItemMap): Added.
(WebCore::HTMLDocument::windowNamedItemMap): Added.
(HTMLDocument): Replaced m_namedItemCounts and m_extraNamedItemCounts by m_documentNamedItem and m_windowNamedItem.
Note that they're not one to one.

• html/HTMLEmbedElement.h:

(HTMLEmbedElement):

• html/HTMLFormElement.h:

(HTMLFormElement):

• html/HTMLIFrameElement.cpp: Removed the code to track the element's name since we already do this in Element.

(WebCore::HTMLIFrameElement::parseAttribute):

• html/HTMLIFrameElement.h:

(HTMLIFrameElement):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Update the HTMLDocument's maps when the name attribute's existence
changes its presence on window and document name getters in turn. This behavior change, again, appears to be
untestable due to the old being more graceful when DocumentOrderedMap returned a wrong value.

• html/HTMLImageElement.h:

• html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection): No longer overrides itemAfter. This enables backwards traversals
of the tree along with other optimizations in HTMLCollection.

(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch): Added. Used in Element::updateName to determine
whether add() or remove() should be called on HTMLDocument's maps.
(WebCore::WindowNameCollection::nodeMatches): Added.

(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch): Added. Used in Element::updateName to determine
whether add() or remove() should be called on HTMLDocument's maps.
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch): Ditto.
(WebCore::DocumentNameCollection::nodeMatches): Added.

• html/HTMLNameCollection.h:

(HTMLNameCollection): Removed create since this class shouldn't be instantiated on its own.

(WebCore::WindowNameCollection): Added.
(WebCore::WindowNameCollection::create): Added.
(WebCore::WindowNameCollection::nodeMatches): Added.
(WebCore::WindowNameCollection::nodeMatchesIfIdAttributeMatch): Added.
(WebCore::WindowNameCollection::WindowNameCollection): Added.
(WebCore::DocumentNameCollection): Added.
(WebCore::DocumentNameCollection::create): Added.
(WebCore::DocumentNameCollection::nodeMatches): Added.
(WebCore::DocumentNameCollection::DocumentNameCollection): Added.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem): Update both window and document getter maps of HTMLDocument when
the visibility of this element changes due to the DOM mutations in the subtree.

• html/HTMLObjectElement.h:

(WebCore::HTMLObjectElement):
(WebCore::toHTMLObjectElement): Added.

5:05 PM Changeset in webkit [149651] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Remove some unnecessary soft linking in NetworkProcess.
<rdar://problem/13821779> and ​https://bugs.webkit.org/show_bug.cgi?id=115683

Reviewed by Sam Weinig.

Replace some unneeded soft linking with forward declarations.

• NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor):

• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

4:55 PM Changeset in webkit [149650] by commit-queue@webkit.org

• 1 edit
  8 deletes in trunk/Tools

Unreviewed, rolling out r149547.
​http://trac.webkit.org/changeset/149547
​https://bugs.webkit.org/show_bug.cgi?id=115682

Added unittests that fail on bots and spits out text into
stdout (Requested by rniwa on #webkit).

• Scripts/import-w3c-tests: Removed.
• Scripts/webkitpy/w3c/init.py: Removed.
• Scripts/webkitpy/w3c/test_converter.py: Removed.
• Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
• Scripts/webkitpy/w3c/test_importer.py: Removed.
• Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
• Scripts/webkitpy/w3c/test_parser.py: Removed.
• Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.

4:38 PM Changeset in webkit [149649] by ggaren@apple.com

• 64 edits
  2 adds in branches/dfgFourthTier

Cherry-pick merged some patches to the FTL branch.

Unreviewed.

Source/JavaScriptCore:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

Source/WebCore:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

Source/WTF:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

LayoutTests:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

4:21 PM Changeset in webkit [149648] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Flaky Test: fast/frames/crash-remove-iframe-during-object-beforeload.html
<​http://webkit.org/b/115674>

Reviewed by Alexey Proskuryakov.

Don't cache the Document::renderer() in a local since layout may blow it away.

• dom/Document.cpp:

(WebCore::Document::implicitClose):

4:06 PM Changeset in webkit [149647] by andersca@apple.com

• 5 edits in trunk/Source

More work on LocalStorageDatabaseTracker
​https://bugs.webkit.org/show_bug.cgi?id=115680

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Call the new databaseFilename that takes a string.

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Assert that we don't call this more than once. Dispatch a call to import origin identifiers.

(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
New helper function that returns the tracker database path.

(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Open the database and create the Origins table if needed.

(WebKit::LocalStorageDatabaseTracker::importOriginIdentifiers):
Open the database and import the origin identifiers from it, then synchronize it with whatever files are on disk.

(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Bring the tracker database up to date from the database files on disk.

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

(LocalStorageDatabaseTracker):

3:49 PM Changeset in webkit [149646] by ap@apple.com

• 5 edits in trunk/Source/WebKit2

<rdar://problem/13479806> [Mac] Pass information about open pages to LaunchServices
​https://bugs.webkit.org/show_bug.cgi?id=115665

Reviewed by Darin Adler.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): Moved repeated check for frame->isMainFrame() to the top, matching oter similar functions. Call updateActivePages().

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::networkProcessConnectionClosed): Removed an obsolete FIXME. (WebKit::WebProcess::updateActivePages): Empty implementation for platforms that don't need to do anything here.

• WebProcess/WebProcess.h: Added updateActivePages().

• WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::updateActivePages): Collect user visible origins of pages in the process and pass them to LS.

3:47 PM Changeset in webkit [149645] by kov@webkit.org

• 2 edits in trunk/Tools

[jhbuild] bump jhbuild version to take advantage of new improvements
​https://bugs.webkit.org/show_bug.cgi?id=115558

Reviewed by Martin Robinson.

One of the important improvements is jhbuild no longer fetches git
repositories if they are already at the expected revision, which should
make the EWS bots more robust to git servers unavailability.

• jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.

3:33 PM Changeset in webkit [149644] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13775921> Switch off a deprecated API.

Reviewed by Oliver Hunt.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setProcessSuppressionEnabled): When disabling process suppression,
begin an activity that doesn't disable idle sleep, sudden termination or automatic termination.
When enabling process suppression, end the activity.

2:43 PM Changeset in webkit [149643] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Move local storage directory handling to LocalStorageDatabaseTracker
​https://bugs.webkit.org/show_bug.cgi?id=115676

Reviewed by Andreas Kling.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:

(WebCore):
(LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectory):
(WebKit):
(WebKit::LocalStorageDatabaseTracker::databaseFilename):
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

(WebCore):
(LocalStorageDatabaseTracker):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::setLocalStorageDirectory):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

2:20 PM Changeset in webkit [149642] by commit-queue@webkit.org

• 19 edits in trunk

[GTK] Add webkit_uri_scheme_request_finish_error
​https://bugs.webkit.org/show_bug.cgi?id=94316

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-06
Reviewed by Anders Carlsson.

Source/WebCore:

No behaviour change, covered by existing tests.

• platform/network/soup/ResourceError.h:

(ResourceError): Rename genericIOError() to genericGError().

• platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::httpError): Use genercicGError() instead of
genericIOError().
(WebCore::ResourceError::genericGError): Use error domain instead of
always return a G_IO_ERROR.

• platform/network/soup/ResourceHandleSoup.cpp: Use genericGError()

instead of genericIOError().
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

Source/WebKit2:

This new method will allow to finish WebKitURISchemeRequest with a
GError that will be passed to the WebKitWebView through the
"load-failed" signal.

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_finish_error): Implement new method using
WebSoupRequestManagerProxy::didFailURIRequest().

• UIProcess/API/gtk/WebKitURISchemeRequest.h: Add new method header.
• UIProcess/API/gtk/WebKitWebContext.cpp: Include the usage of the new

method in the code example at webkit_web_context_register_uri_scheme()
documentation.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the new

method.

• UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(loadFailedCallback): Set m_error to monitor it from the tests.
(LoadTrackingTest::loadURI): Clear m_error before each load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
(LoadTrackingTest::reload): Ditto.
(LoadTrackingTest::goBack): Ditto.
(LoadTrackingTest::goForward): Ditto.

• UIProcess/API/gtk/tests/LoadTrackingTest.h: Add new member m_error.
• UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextURIScheme): Modify test to check the behavior of the new
method.

• UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didFailURIRequest):
(WebKit): Implement new method using
WebSoupRequestManager::DidFailURIRequest().

• UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy): Add new method header.

• WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit):
(WebKit::WebSoupRequestManager::didFailURIRequest): Implement new method
setting the error and completing the request.

• WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager): Add new method header.

• WebProcess/soup/WebSoupRequestManager.messages.in: Add new method

signature.

Tools:

• MiniBrowser/gtk/main.c:

(miniBrowserErrorQuark): Add function to create a global quark for
MiniBrowser.
(aboutURISchemeRequestCallback): Update MiniBrowser to use the new
function webkit_uri_scheme_request_finish_error().

2:18 PM Changeset in webkit [149641] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Heap-use-after-free in WebCore::InlineFlowBox::deleteLine
​https://bugs.webkit.org/show_bug.cgi?id=114772

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-06
Reviewed by David Hyatt.

Source/WebCore:

Fix the new use after free issues in Ruby.

Test: fast/ruby/ruby-svg-crash.html

• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests:

Test case generated by the fuzzer. Will only crash when run in a
vulnerable configuration with a memory checking lib enabled.

• fast/ruby/ruby-svg-crash-expected.txt: Added.
• fast/ruby/ruby-svg-crash.html: Added.

2:16 PM Changeset in webkit [149640] by robert@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r140024): child of fixed div inside of absolute div does not get resized when window is resized
​https://bugs.webkit.org/show_bug.cgi?id=115379

Reviewed by David Hyatt.

Source/WebCore:

When detecting whether a fixed pos object needed to move with an absolute ancestor we checked
whether the logical width of the fixed pos object had changed. This check prevented the fixed pos
object from detecting later on that it needed to relayout its children in layoutBlock(). So recompute the width
for our check instead of updating it.

Test: fast/block/positioning/child-of-fixed-pos-after-movement.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):

LayoutTests:

• fast/block/positioning/child-of-fixed-pos-after-movement-expected.txt: Added.
• fast/block/positioning/child-of-fixed-pos-after-movement.html: Added.

2:07 PM Changeset in webkit [149639] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Every LocalStorageDatabase should know about its tracker
​https://bugs.webkit.org/show_bug.cgi?id=115673

Reviewed by Andreas Kling.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):

1:56 PM Changeset in webkit [149638] by commit-queue@webkit.org

• 10 edits in trunk

[BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=113808

Patch by Mike Lattanzio <​mlattanzio@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

.:

Set the ENABLE_TEXT_AUTOSIZING default to ON for BlackBerry.

• Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

Added TextAutosizer.cpp to the BlackBerry build.

• PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Create a WebSetting for text autosizing. The default is off.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

• Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
(BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):

• Api/WebSettings.h:

Tools:

Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
to true for BlackBerry.

• Scripts/webkitperl/FeatureList.pm:

1:48 PM Changeset in webkit [149637] by andersca@apple.com

• 4 edits
  2 adds in trunk/Source/WebKit2

Add LocalStorageDatabaseTracker class
​https://bugs.webkit.org/show_bug.cgi?id=115671

Reviewed by Andreas Kling.

Somewhat unsurprisingly, this class will be used for tracking local storage databases.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp: Added.

(WebKit::LocalStorageDatabaseTracker::create):
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
(WebKit::LocalStorageDatabaseTracker::~LocalStorageDatabaseTracker):

• UIProcess/Storage/LocalStorageDatabaseTracker.h: Added.

(LocalStorageDatabaseTracker):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageManager):
Create a local storage database tracker.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:48 PM Changeset in webkit [149636] by ggaren@apple.com

• 89 edits in branches/dfgFourthTier

Rolled back in r149527 with crash fixed.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

This fixes a bunch of Sputnik tests, and some bad pointer access.

The new model is that the callee always performs 'this' value conversion.

My ultimate goal is to break up resolve_with_this into single-result
opcodes. This step avoids having to add a special form of convert_this
that distinguishes callers vs callees.

Only the callee knows whether it uses 'this' and/or whether 'this'
conversion should use StrictMode, so it's most natural to perform
convert_this in the callee.

• API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call): Perform 'this' value conversion for our callee, since it may observe 'this'.

• API/JSCallbackObjectFunctions.h: (JSC::::call): Ditto.

• API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): Use a proxy 'this' object in global scope even when we're not in the browser. This eliminates some odd cases where API clients used to be able to get a direct reference to an environment record. Now, any reference to an environment record unambiguously means that the VM resolved that record in the scope chain.

(JSContextGetGlobalObject): Removed an incorrect comment. Now that JSC
participates in the proxy 'this' object scheme, the behavior is not
WebCore-only.

• API/JSObjectRef.cpp: (JSObjectSetPrototype): (JSObjectCallAsFunction): Don't perform 'this' value conversion in the caller; the callee will do it if needed.

• JavaScriptCore.order: Order!

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: What are the chances that this will work?

• bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock): Renamed convert_this to to_this, to match our other conversion opcodes.

• bytecode/CodeOrigin.h: (CodeOrigin): (InlineCallFrame): (JSC::CodeOrigin::codeOriginOwner): Use the more precise type for our executable, so compilation can discover where we're in strict mode.

• bytecode/Opcode.h: (JSC::padOpcodeName): Updated for rename.

• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Always emit to_this when 'this' is in use -- strict mode still needs to convert environment records to 'undefined'.

• dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::executeEffects):
• dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
• dfg/DFGCapabilities.h: (JSC::DFG::canCompileOpcode): Updated for renames.

• dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): Tightened up this code to consider strict mode (a new requirement) and to consider the global object (which was always a requirement).

• dfg/DFGGraph.h: (JSC::DFG::Graph::globalThisObjectFor): (JSC::DFG::Graph::executableFor):
• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
• dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
• dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): Ditto.

• interpreter/Interpreter.cpp: (JSC::eval): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall):
• interpreter/Interpreter.h: Don't ASSERT about 'this' -- it's our job to fix it up if needed.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
• jit/JIT.h: (JIT):
• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_this): (JSC::JIT::emitSlow_op_to_this):
• jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_to_this): (JSC::JIT::emitSlow_op_to_this):
• jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
• jit/JITStubs.h: Removed special-case code for various kinds of conversions. The baseline fast path is now final objects only. It hurt my brain to think through how to keep the other fast paths working, and our benchmarks do not object.

• llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
• llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):
• llint/LLIntSlowPaths.h: (LLInt):
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm: Updated for renames. Removed some special case code, as in the JIT above.

• profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
• runtime/CallData.cpp: (JSC::call):
• runtime/ClassInfo.h: (MethodTable):
• runtime/Completion.cpp: (JSC::evaluate):
• runtime/DatePrototype.cpp: (JSC::dateProtoFuncToJSON): The callee performs 'this' conversion, not the caller.

• runtime/GetterSetter.cpp: (JSC::callGetter): (JSC::callSetter):
• runtime/GetterSetter.h: Added helper functions for invoking getters and setters from C++ code, since this was duplicated in a bunch of places.

• runtime/JSActivation.cpp: (JSC::JSActivation::toThis):
• runtime/JSActivation.h: (JSActivation):
• runtime/JSCJSValue.cpp: (JSC::JSValue::toThisSlowCase): (JSC::JSValue::putToPrimitive):
• runtime/JSCJSValue.h: (JSValue):
• runtime/JSCJSValueInlines.h: (JSC::JSValue::toThis):
• runtime/JSCell.cpp: (JSC::JSCell::toThis):
• runtime/JSCell.h: (JSCell):
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::toThis):
• runtime/JSGlobalObject.h: (JSGlobalObject): Filled out runtime support for converting 'this' values as needed, according to the appropriate strictness, using helper functions where getter/setter code was duplicated.

• runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncProtoGetter): (JSC::globalFuncProtoSetter): Perform 'this' value conversion, since we observe 'this'.

• runtime/JSNameScope.cpp: (JSC::JSNameScope::toThis):
• runtime/JSNameScope.h: (JSNameScope): Same as JSActivation.

• runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::setPrototypeWithCycleCheck): Bug fix. Don't peform 'this' value conversion in this helper function. The proto setter does this for us, since it's the function that logically observes 'this' -- and we can ASSERT so. Also, the previous code used "globalExec()->thisValue()", which is a read past the beginning of a buffer! I don't think this ever worked on purpose.

(JSC::JSObject::toThis):
(JSC::JSObject::fillGetterPropertySlot):

• runtime/JSObject.h: (JSC::JSObject::inlineGetOwnPropertySlot):
• runtime/JSScope.cpp: (JSC::JSScope::resolveWithThis):
• runtime/JSString.cpp: (JSC::JSString::toThis):
• runtime/JSString.h: (JSString):
• runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
• runtime/PropertySlot.h: (JSC): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot):
• runtime/SparseArrayValueMap.cpp: (JSC::SparseArrayEntry::get): (JSC::SparseArrayEntry::put):
• runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::toThis):
• runtime/StrictEvalActivation.h: (StrictEvalActivation): Ditto.

Source/WebCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit/mac:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit2:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

LayoutTests:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

1:32 PM Changeset in webkit [149635] by jberlin@webkit.org

• 3 edits in trunk/Tools

check-webkit-style should complain about a layering violation if platform-specific guards are
used in WebCore outside of the platform directory
​https://bugs.webkit.org/show_bug.cgi?id=115567

Reviewed by Benjamin Poulain.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_for_webcore_platform_layering_violation):
If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
(process_line):
Add the check_for_webcore_platform_layering_violation.
(CppChecker):
List the new check.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_webcore_platform_layering_violation):
Add tests.

1:28 PM Changeset in webkit [149634] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Misc bugfix and cleaning in sh4 base JIT.
​https://bugs.webkit.org/show_bug.cgi?id=115627

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-06
Reviewed by Oliver Hunt.

Get rid of loadX(RegisterID r0, RegisterID src, RegisterID dest) functions.
Remove misplaced extuw() implementation from MacroAssemblerSH4.
Add movbRegMemr0 and movwRegMemr0 functions in SH4Assembler.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::add32): Skip operation when first operand is a zero immediate.
(JSC::MacroAssemblerSH4::sub32): Skip operation when first operand is a zero immediate.
(JSC::MacroAssemblerSH4::load32): Fix wrong usage of r0 register.
(JSC::MacroAssemblerSH4::load8Signed): Handle "base == r0" case.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16): Handle "base == r0" case.
(JSC::MacroAssemblerSH4::load16Unaligned): Use extuw() implementation from SH4Assembler.
(JSC::MacroAssemblerSH4::load16Signed): Cosmetic change.
(JSC::MacroAssemblerSH4::store8): Fix unhandled BaseIndex offset and handle (base == r0) case.
(JSC::MacroAssemblerSH4::store16): Fix unhandled BaseIndex offset and handle (base == r0) case.
(JSC::MacroAssemblerSH4::store32):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::movwRegMemr0):
(SH4Assembler):
(JSC::SH4Assembler::movbRegMemr0):
(JSC::SH4Assembler::placeConstantPoolBarrier): Cosmetic change.
(JSC::SH4Assembler::maxJumpReplacementSize):
(JSC::SH4Assembler::replaceWithJump): Correct branch range and save an opcode.
(JSC::SH4Assembler::printInstr):

1:17 PM Changeset in webkit [149633] by andersca@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Stop using WTF::deleteAllValues in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=115670

Reviewed by Oliver Hunt.

Change the Vectors used to Vectors of OwnPtrs instead.

• heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

1:15 PM Changeset in webkit [149632] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SVGAttributeToPropertyMap
​https://bugs.webkit.org/show_bug.cgi?id=115653

Reviewed by Andreas Kling.

Also made a few style fixes to the code at the same time.

• svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties): Changed argument to
const because there was no reason for it to be non-const. Added calls to
get() since the items in the map are now OwnPtr. Added a couple FIXMEs
about performance mistakes.
(WebCore::SVGAttributeToPropertyMap::addProperty): Added a FIXME about
a small performance mistake, and updated to use OwnPtr instead of raw
pointers.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties): Added a call
to get().

• svg/properties/SVGAttributeToPropertyMap.h: Removed now-unneeded

constructor and destructor definitions. Changed the type for the
addProperties to be const&. Added a comment about incorrect function
naming. Changed the type of the map data member to use OwnPtr.

1:13 PM Changeset in webkit [149631] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Handle closing the local storage database
​https://bugs.webkit.org/show_bug.cgi?id=115669

Reviewed by Beth Dakin.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Initialize m_isClosed.

(WebKit::LocalStorageDatabase::~LocalStorageDatabase):
Assert that m_isClosed is false.

(WebKit::LocalStorageDatabase::close):
Set m_isClosed to true and write any pending changes to disk.

(WebKit::LocalStorageDatabase::updateDatabase):
Compute the changed items and pass them to updateDatabaseWithChangedItems.

(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Split out the code that actually writes to the database from updateDatabase and into this function.

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::~StorageArea):
Call close().

12:49 PM Changeset in webkit [149630] by ddkilzer@apple.com

• 3 edits in trunk/Tools

webkit-patch: fix 'upload' command with Bugzilla 4.2.5
<​http://webkit.org/b/115667>

Reviewed by Dirk Pranke.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._check_create_bug_response): Update regex to work with
Bugzilla 3.2.3 and 4.2.5.

• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(testcheck_create_bug_response): Add new test that covers both
old and new <title> variations.

12:38 PM Changeset in webkit [149629] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Ensure document is attached before accessing its FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=115565

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR 312101
We need to make sure that the node and document
are attached before accessing the FrameSelection. This was
handled earlier but not all call paths were covered.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):

• WebKitSupport/InputHandler.h:

12:37 PM Changeset in webkit [149628] by Antti Koivisto

• 12 edits in trunk/Source

Remove more code that was only needed for younger/older shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=115662

Reviewed by Andreas Kling.

This is dead code.

• WebCore.exp.in:
• dom/ComposedShadowTreeWalker.cpp:

(WebCore::nodeCanBeDistributed):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):

• dom/EventPathWalker.cpp:

(WebCore::EventPathWalker::moveToParent):

• html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::ScopeContentDistribution):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
(WebCore):
(WebCore::ScopeContentDistribution::hasInsertionPoint):
(WebCore::ContentDistributor::invalidate):

• html/shadow/ContentDistributor.h:

(ScopeContentDistribution):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::contains):
(WebCore::resolveReprojection):
(WebCore::collectInsertionPointsWhereNodeIsDistributed):

• html/shadow/InsertionPoint.h:
• testing/Internals.cpp:

(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

12:36 PM Changeset in webkit [149627] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not spellcheck when composition is active.
​https://bugs.webkit.org/show_bug.cgi?id=115562

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR331344
Typing can trigger rechecking since layout changes. Ensure
extra work is only done when we need it, and that it won't
be triggered when composition is active. If the user hasn't
finished a word yet, it is likely future key events will be
arriving, so checking the string at this point is extraneous.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

12:31 PM Changeset in webkit [149626] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reduce the spellcheck checking range
​https://bugs.webkit.org/show_bug.cgi?id=115479

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR332773
Previously we were spellchecking the entire field on focus. If relayouting
occurred we rechecked this region, which is very costly. Switch to check
only a small region around the caret in both cases, which should alleviate
much of the delays experienced in very large contenteditable fields. This
allows for faster key input response and less time processing these requests
on the WebKit thread.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.cpp:

(WebKit):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.h:

(SpellingHandler):

12:29 PM Changeset in webkit [149625] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use a more descriptive timer name
​https://bugs.webkit.org/show_bug.cgi?id=115481

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

Changing m_timer to m_iterationDelayTimer.

• WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::SpellingHandler):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

• WebKitSupport/SpellingHandler.h:

(SpellingHandler):

12:13 PM Changeset in webkit [149624] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Update HTML5 progress bar UX.
​https://bugs.webkit.org/show_bug.cgi?id=115284.

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-06
Reviewed by Rob Buis.

BlackBerry PR 331729.
Internally Reviewed by Jeff Rogers.

Use GL render to paint progress bar to meet UX specs.
Also change the slider range to GL render.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintProgressTrackRect):
(WebCore::drawProgressTexture):
(WebCore::RenderThemeBlackBerry::paintProgressBar):

• platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

12:11 PM Changeset in webkit [149623] by commit-queue@webkit.org

• 12 edits
  5 deletes in trunk

[CSS Exclusions] remove unused -webkit-wrap property
​https://bugs.webkit.org/show_bug.cgi?id=102105

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-06
Reviewed by Darin Adler.

Source/WebCore:

Remove -webkit-wrap property and all mentions. This property doesn't
exist in the spec anymore, and was never implemented more than just
parsing the property.

• WebCore.order:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

• css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

• css/StylePropertyShorthand.h:

(WebCore):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Delete tests for the -webkit-wrap property.

• fast/exclusions/css-exclusions-disabled.html: Remove use of -webkit-wrap.
• fast/exclusions/script-tests/wrap-parsing.js: Removed.
• fast/exclusions/wrap-parsing-expected.txt: Removed.
• fast/exclusions/wrap-parsing.html: Removed.
• svg/css/style-change-crash-expected.txt: Removed.
• svg/css/style-change-crash.html: Removed.

11:49 AM Changeset in webkit [149622] by abecsi@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Build with GCC 4.8 fails because of -Wmaybe-uninitialized
​https://bugs.webkit.org/show_bug.cgi?id=115648

Reviewed by Michael Saboff.

Initialize values in Options::setOption since from
there we end up calling OptionRange::init with
uninitialized members.

• runtime/Options.cpp:

11:46 AM Changeset in webkit [149621] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed. AppleWin VS2010 build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

11:44 AM Changeset in webkit [149620] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebNetworkInfoManagerProxy a supplement to the WebContext
​https://bugs.webkit.org/show_bug.cgi?id=115654

Reviewed by Andreas Kling.

Rather than holding a RefPtr to the WebNetworkInfoManagerProxy object in WebContext, change the WebNetworkInfoManagerProxy
to implement the WebContextSupplement interface and handle the object as such in WebContext, simplifying its
construction and cleanup, removing the specific RefPtr member variable and its correlating getter method.

• UIProcess/API/C/WKContext.cpp:

(WKContextGetNetworkInfoManager): Retrieve the WebNetworkInfoManagerProxy object from the suppplements of the WebContext.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Add the WebNetworkInfoManagerProxy object as a supplement instead of assigning it to
the now-removed member variable.
(WebKit::WebContext::~WebContext): No need for the specific cleanup, the equivalent is achieved when iterating through the
supplements vector.
(WebKit::WebContext::disconnectProcess): Ditto.

• UIProcess/WebContext.h:

(WebContext): Remove the WebNetworkInfoManagerProxy RefPtr member variable and its getter method.

• UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::supplementName): Specift the supplement's name.
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy): Initialize as a WebContextSupplement.
(WebKit::WebNetworkInfoManagerProxy::providerDidChangeNetworkInformation): Adjust to use the context() method instead of
accessing the private m_context directly.
(WebKit::WebNetworkInfoManagerProxy::contextDestroyed): Stop updating when invoked.
(WebKit::WebNetworkInfoManagerProxy::processDidClose): Ditto.
(WebKit::WebNetworkInfoManagerProxy::refWebContextSupplement): Call APIObject::ref.
(WebKit::WebNetworkInfoManagerProxy::derefWebContextSupplement): Call APIObject::deref.

• UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy): Inherit from WebContextSupplement, declare the newly-inherited methods.

11:40 AM Changeset in webkit [149619] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/13479806> [Mac] Pass plug-in bundle ID to LaunchServices
​https://bugs.webkit.org/show_bug.cgi?id=115483

Reviewed by Darin Adler.

• PluginProcess/PluginProcess.h: Added m_pluginBundleIdentifier. We now need it in multiple places, so it's easier to pre-compute it.

• PluginProcess/mac/PluginProcessMac.mm: (WebKit::loadSandboxProfileForDirectory): Changed to use precomputed bundle ID. (WebKit::loadSandboxProfile): Ditto. (WebKit::PluginProcess::platformInitializeProcess): Pre-compute bundle ID. (WebKit::PluginProcess::initializeProcessName): Pass it to LaunchServices. (WebKit::PluginProcess::initializeSandbox): Pass precomputed bundle ID instead of a path.

11:38 AM Changeset in webkit [149618] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Handle removeItem and clear in LocalStorageDatabase
​https://bugs.webkit.org/show_bug.cgi?id=115664

Reviewed by Darin Adler.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::removeItem):
Call itemDidChange with a null value, indicating that we want to remove this item.

(WebKit::LocalStorageDatabase::clear):
Clear items, set m_shouldClearItems and schedule a database update.

(WebKit::LocalStorageDatabase::updateDatabase):
If m_shouldClearItems is true, clear all items.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::removeItem):
Call through to the local storage database.

(WebKit::StorageManager::StorageArea::clear):
Ditto.

11:13 AM Changeset in webkit [149617] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
​https://bugs.webkit.org/show_bug.cgi?id=115661

Reviewed by Ryosuke Niwa.

The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.

• TestResultServer/static-dashboards/flakiness_dashboard.js:
• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

11:12 AM Changeset in webkit [149616] by Christophe Dumez

• 1 edit
  1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Add EFL-specific result for fast/events/event-attribute.html as global expectation
was changed in r149088.

• platform/efl/fast/events/event-attribute-expected.txt: Added.

11:10 AM Changeset in webkit [149615] by andersca@apple.com

• 6 edits in trunk/Source

Write storage changes to disk
​https://bugs.webkit.org/show_bug.cgi?id=115660

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Initialize new member variables.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Disable database threading checks.

(WebKit::LocalStorageDatabase::importItems):
Only import the items once.

(WebKit::LocalStorageDatabase::setItem):
Call itemDidChange.

(WebKit::LocalStorageDatabase::itemDidChange):
Record the change and schedule a database update.

(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
Use WorkQueue::dispatchAfterDelay to schedule a datbase update.

(WebKit::LocalStorageDatabase::updateDatabase):
Write changes to disk. If there are more than 100 pending items, only write the first 100 and then schedule
another database update for the remaining items.

• UIProcess/Storage/LocalStorageDatabase.h:

Add new member variables.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::setItem):
Call LocalStorageDatabase::setItem.

11:05 AM Changeset in webkit [149614] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Update HTML5 progress bar UX.
​https://bugs.webkit.org/show_bug.cgi?id=115284.

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-06
Reviewed by Rob Buis.

BlackBerry PR 331729.
Internally Reviewed by Jeff Rogers.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::createLinearGradient):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintProgressBar):

• platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

11:03 AM Changeset in webkit [149613] by Christophe Dumez

• 3 edits
  3 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases for EFL port.

• platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
• platform/efl/editing/selection/extend-inside-transforms-backward-expected.png: Added.
• platform/efl/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
• platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.png:
• platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

10:56 AM Changeset in webkit [149612] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several test cases as failing after r149292 due to missing repaint rect
dumping.

• platform/efl/TestExpectations:

10:55 AM Changeset in webkit [149611] by zandobersek@gmail.com

• 4 edits in trunk/Tools

[Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
​https://bugs.webkit.org/show_bug.cgi?id=114603

Reviewed by Ryosuke Niwa.

• TestResultServer/generate_builders_json.py:

(insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
to represent these to be 'layout-test', for backwards compatibility.
(main): Remove all the build.chromium.org masters.

• TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.

(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):

• TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the

test-running builders from the webkit.org master.

10:49 AM Changeset in webkit [149610] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
​https://bugs.webkit.org/show_bug.cgi?id=114988

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium

and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.

• TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,

mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.

10:49 AM Changeset in webkit [149609] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Cherry-pick fixes to bignum from upstream
​https://bugs.webkit.org/show_bug.cgi?id=115658

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-05-06
Reviewed by Darin Adler.

Cherry-picked the following change lists:

Fix bug in bignum implementation
​http://codereview.chromium.org/13454019

Make VS2005 project files compile without errors
​http://codereview.chromium.org/6286135

• wtf/dtoa/bignum.cc:

10:48 AM Changeset in webkit [149608] by Christophe Dumez

• 17 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip repaint test that regressed after r149292.

• platform/efl/TestExpectations:

10:46 AM Changeset in webkit [149607] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip repaint test that regressed after r149292.

• platform/efl/TestExpectations:

10:44 AM Changeset in webkit [149606] by Christophe Dumez

• 17 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several repaint test cases after r149292.

• fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
• fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
• fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
• fast/repaint/layer-full-repaint-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/reflection-table-layout-expected.txt:
• fast/repaint/selection-gap-absolute-child-expected.txt:
• fast/repaint/selection-gap-fixed-child-expected.txt:
• fast/repaint/selection-gap-flipped-absolute-child-expected.txt:
• fast/repaint/selection-gap-flipped-fixed-child-expected.txt:
• fast/repaint/selection-gap-transformed-absolute-child-expected.txt:
• fast/repaint/selection-gap-transformed-fixed-child-expected.txt:
• fast/repaint/transform-table-layout-expected.txt:
• platform/efl/fast/images/repaint-subrect-grid-expected.txt:
• svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:

10:44 AM Changeset in webkit [149605] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Remove the remaining traces of platform modifier unions
​https://bugs.webkit.org/show_bug.cgi?id=114954

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
modifier unions in the list of modifiers.
(generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.

10:32 AM Changeset in webkit [149604] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Simplify builder-name-based platform recognition
​https://bugs.webkit.org/show_bug.cgi?id=114957

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(determineBuilderPlatform): Renamed from nonChromiumPlatform.
(chromiumPlatform): Removed, unnecessary.
(platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
the builder operates with debug builds, no webkit.org builders are named this way.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.

10:15 AM Changeset in webkit [149603] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip remaining Shadow DOM test and new accessibility test introduced in
r115659.

• platform/efl/TestExpectations:

9:41 AM Changeset in webkit [149602] by mikhail.pozdnyakov@intel.com

• 3 edits in trunk/Source/WTF

Change HashTraits<RefPtr<P> >::PassOutType to PassRefPtr for better performance
​https://bugs.webkit.org/show_bug.cgi?id=115410

Reviewed by Darin Adler.

The type HashTraits<RefPtr<P> >::PassOutType is PassRefPtr now to
avoid extra ref/unrefing on return from HashMap methods that transfer
ownership, such as take.

• wtf/HashTable.h:

(WTF::IdentityHashTranslator::equal):

• wtf/HashTraits.h:

9:37 AM Changeset in webkit [149601] by rgabor@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

JSC ARM traditional failing on Octane NavierStokes test
​https://bugs.webkit.org/show_bug.cgi?id=115626

Reviewed by Zoltan Herczeg.

Change the ARM traditional assembler to use double precision on value
conversions.

• assembler/ARMAssembler.h:

9:17 AM Changeset in webkit [149600] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebBatteryManagerProxy a supplement to the WebContext
​https://bugs.webkit.org/show_bug.cgi?id=115625

Reviewed by Andreas Kling.

Rather than holding a RefPtr to the WebBatteryManagerProxy object in WebContext, change the WebBatteryManagerProxy
to implement the WebContextSupplement interface and handle the object as such in WebContext, simplifying its
construction and cleanup, removing the specific RefPtr member variable and its correlating getter method.

• UIProcess/API/C/WKContext.cpp:

(WKContextGetBatteryManager): Retrieve the WebBatteryManagerProxy object from the supplements of the WebContext.

• UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::supplementName): Specify the supplement's name.
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy): Initialize as a WebContextSupplementable.
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus): Adjust to use the context() method instead of accessing
the private m_context directly.
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus): Ditto.
(WebKit::WebBatteryManagerProxy::contextDestroyed): Stop updating when invoked.
(WebKit::WebBatteryManagerProxy::processDidClose): Ditto.
(WebKit::WebBatteryManagerProxy::refWebContextSupplement): Call APIObject::ref.
(WebKit::WebBatteryManagerProxy::derefWebContextSupplement): Call APIObject::deref.
(WebKit::WebBatteryManagerProxy::startUpdating): Fire up the provider if not yet updating.
(WebKit::WebBatteryManagerProxy::stopUpdating): Wind down the provider if updating.

• UIProcess/WebBatteryManagerProxy.h:

(WebBatteryManagerProxy): Inherit from WebContextSupplement, declare the newly-inherited methods.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Add the WebBatteryManagerProxy object as a supplement instead of assigning it to
the now-removed member variable.
(WebKit::WebContext::~WebContext): No need for the specific cleanup, the equivalent is achieved when iterating through the
supplements vector.
(WebKit::WebContext::disconnectProcess): Ditto.

• UIProcess/WebContext.h:

(WebContext): Remove the WebBatteryManagerProxy RefPtr member variable and its getter method.

8:43 AM Changeset in webkit [149599] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[texmap] draw content if graphics layer displays a video
​https://bugs.webkit.org/show_bug.cgi?id=114742

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-05-06
Reviewed by Noam Rosenthal.

Bug #86410 focuses on having composited/accelerated video using the
TextureMapper. But the video is not rendered fast by using the
repaint() method. In the case of the TextureMapper it is required to
call a content display as fast as possible.

This patch adds the class TextureMapperPlatformLayer::Client with the
method setLayerNeedsDisplay(). The GraphicsLayerTextureMapper
implements this new class and the new method calls
setContentsNeedsDisplay(), causing a faster content display when
requested.

No new tests. Covered by existing tests.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToMedia): sets itself
as the TextureMapperPlatformLayer's client

• platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::setLayerNeedsDisplay):
TextureMapperPlatformLayer::Client::setLayerNeedsDisplay implementation
(GraphicsLayerTextureMapper):

• platform/graphics/texmap/TextureMapperPlatformLayer.h:

(Client): New class
(WebCore::TextureMapperPlatformLayer::TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::setClient): client setter
(WebCore::TextureMapperPlatformLayer::setLayerNeedsDisplay): facade
for client's method

8:28 AM Changeset in webkit [149598] by hmuller@adobe.com

• 7 edits in trunk/LayoutTests

[CSS Exclusions] shape-inside rounded rectangle tests fail when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115490

Second round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off. This set of changes just restores four ref-tests that place
a single square Ahem character cell within a circle or an ellipse. When subpixel layout isn't
enabled the expected origin of the character is adjusted.

Reviewed by Dirk Schulze.

• fast/exclusions/shape-inside/shape-inside-circle-expected.html:
• fast/exclusions/shape-inside/shape-inside-circle-padding-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse-padding-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse.html:
• platform/mac/TestExpectations:

8:23 AM Changeset in webkit [149597] by hyatt@apple.com

• 3 edits in trunk/Source/WebCore

Improve the performance of RenderDeprecatedFlexibleBox.
​https://bugs.webkit.org/show_bug.cgi?id=115543.

Optimize deprecated flexible box layout to be much faster. This patch implements
the following optimizations in the deprecated flexible box:

(1) Defer repainting of children until they have been placed into their final
positions. This is done by collecting all of the old frame rects into a Vector
and then doing a walk after layout is finished to repaint any of the children if
they moved from that position. This code matches the new RenderFlexibleBox's system
for repainting moved children.

(2) Implement support for layout deltas. We keep a Vector of layout deltas for each
child as we shift them around, and every time we lay a child out again, we apply that
child's current layout delta to avoid repainting at the new position. RenderFlexibleBox
does not have support for layout deltas yet, so we'll need to implement this in the
new flexbox code as well.

(3) Optimize flexible objects to avoid laying them out unflexed. When laying out
horizontal and vertical boxes now, we lay out the inflexible items first. We then
check to see if the inflexible extent of all those children has changed.

If this extent didn't change, and the flexible items either don't need layout or there
is only one flexing item, then we avoid laying out the item in an unflexed state
and simply lay out one time with the flex applied instead. The new RenderFlexibleBox
does not have these optimizations and would benefit from them in the block-direction box
case (it uses preferred logical widths in the inline-direction box case, and so avoided
layouts in that direction already).

Reviewed by Beth Dakin.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::appendChildFrameRects):
Cache all of the old child frame rects so that we can compare them with the final
positions for repaintDuringLayoutIfMoved. This collection is identical to what the
new flexbox code does.

(WebCore::appendChildLayoutDeltas):
Build up a vector that tracks layout deltas. We apply these layout deltas every
time we lay out a child so that any repainting done during layout ignores our shifted
position and just keeps using the old position. The new flexbox does not have this
code yet.

(WebCore::repaintChildrenDuringLayoutIfMoved):
After final placement of children, we do a single pass over all of the children and
repaint them if they shifted their positions. This matches how the new flexbox works.

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Collect the frame rects and layout deltas, and defer repainting of children to the
end of layout.

(WebCore::gatherFlexChildrenInfo):
Don't clear flex overrides when gathering flex information. Add additional information
such as the number of flexing items so that we can use it to optimize flex layout.

(WebCore::layoutChildIfNeededApplyingDelta):
A helper for applying your current layout delta for a child when laying that child out.

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Both methods are patched to aggregate layout deltas as children move around during
the multiple passes. In addition we now optimize layout in a couple of cases, such
as when the inflexible space stays the same (thus giving a flexible object the
same amount of available space, avoiding a need to lay out unflexed first).

(WebCore::RenderDeprecatedFlexibleBox::placeChild):
Patched to add to our cached layout delta for that child when we do a movement.

• rendering/RenderDeprecatedFlexibleBox.h:

Changes to method signatures.

6:54 AM Changeset in webkit [149596] by Christophe Dumez

• 2 edits in trunk

[EFL] Shadow DOM should be disabled at compile time
​https://bugs.webkit.org/show_bug.cgi?id=115635

Reviewed by Andreas Kling.

Disable Shadow DOM at compile time for EFL port. Shadow DOM code
is being removed from the tree.

• Source/cmake/OptionsEfl.cmake:

6:27 AM Changeset in webkit [149595] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Remove duplicate Shadow DOM test cases from TestExpectation files.

• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

5:50 AM Changeset in webkit [149594] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed. Remove duplicate tests from EFL TestExpectation files.

• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

5:40 AM Changeset in webkit [149593] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip Shadow DOM tests for EFL port as the feature is being removed.

• platform/efl/TestExpectations:

4:14 AM Changeset in webkit [149592] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding new failure expectations and adjusting an old one.

3:45 AM Changeset in webkit [149591] by zandobersek@gmail.com

• 3 edits
  2 adds in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148720, r149088 and r149407.

• platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
• platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
• platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.
• platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

3:32 AM Changeset in webkit [149590] by aestes@apple.com

• 1 edit
  2 adds in trunk/Tools

Added two files I neglected to commit in r149589.

• TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
• TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.

3:29 AM Changeset in webkit [149589] by aestes@apple.com

• 8 edits in trunk

REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=115609

Reviewed by Oliver Hunt.

Source/WebCore:

When a window created by window.open() is navigated, the embedder might
close it in decidePolicyForNavigationAction. If this happens, we end up
with a pointer to a deleted Frame.

Fix this by keeping a strong reference to the Frame created by
createWindow(). We can later determine if the window was closed by
checking if the new Frame has a detached Page.

Added an API test: WebKit1.CloseNewWindowInNavigationPolicyDelegate.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

Tools:

Added an API test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.

(+[TestDelegate shared]):
(-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[TestDelegate webView:createWebViewWithRequest:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.

2:46 AM Changeset in webkit [149588] by zandobersek@gmail.com

• 7 edits in trunk/Source

[GTK] Move GeolocationProviderGeoclue into libPlatform
​https://bugs.webkit.org/show_bug.cgi?id=115591

Reviewed by Martin Robinson.

Source/Platform:

• GNUmakefile.am: List the Source/WebCore/platform/geoclue directory under platform_webcore_cppflags.

Add Geoclue dependency CPPFLAGS to the list of libPlatform's CPPFLAGS.

Source/WebCore:

No new tests - no new functionality.

• GNUmakefile.am: Remove the Source/WebCore/platform/geoclue directory from the webkitgtk_cppflags list.
• GNUmakefile.list.am: Move the GeolocationProviderGeoclue(Client) sources under platform_sources.

Source/WebKit/gtk:

• GNUmakefile.am: Add platform_webcore_cppflags to the list of libwebkitgtk's CPPFLAGS.

1:41 AM Changeset in webkit [149587] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebCore

[Qt][Win] Unreviewed buildfix after r149579.

• plugins/win/PluginDatabaseWin.cpp:

(WebCore::addQtWebKitPluginPath):

1:31 AM WebKit Team edited by yuqiang.xian@intel.com

(diff)

1:24 AM Changeset in webkit [149586] by Antoine Quint

• 18 edits in trunk

Manage the presentation of the snapshotted plug-in using JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=115548

Reviewed by Dean Jackson.

Source/WebCore:

• Resources/plugIns.js:

(createOverlay):
Implement the createOverlay(shadowRoot, titleText, subtitleText) method
that is called from WebCore (HTMLPlugInImageElement::didAddUserAgentShadowRoot)
to allow the injected script to customize the shadow root for a snapshotted
plug-in. This is a default implementation, clients are expected to customize
this by providing their own JS file with enhanced behavior.

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
Since we no longer have a default shadow tree generated in C++, it makes little
sense for clients to extend the default snapshotted plug-in stylesheet, so we
only insert it if no custom one is provided by the chrome client.

• css/plugIns.css:

Better styling of the default snapshotted plug-in overlay look by using CSS
flex boxes. Also using more explicit selector as an optimization.

• dom/Document.cpp:

(WebCore::Document::ensurePlugInsInjectedScript):
Expose a new method to allow HTMLPlugInImageElement instances to ensure that
the JavaScript code required to customize the snapshotted plug-in's shadow root
is indeed injected in the current document. The actual injection would only
happen once per document so all snapshotted plug-ins share the same scripting
context.

• dom/Document.h:

Expose the new ensurePlugInsInjectedScript method and the m_hasInjectedPlugInsScript
property used to ensure injection happens only once per document.

• html/HTMLPlugInImageElement.cpp:

(WebCore::titleText):
(WebCore::subtitleText):
Store the localized strings for each mime-type in a static hash map as it can be
costly to retrieve them each time from the client. It is expected the chrome client
will want to provide localized strings taking into account the snapshotted plug-in's
mime-type, so we're adding this as a parameter.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus):
Dispatch a "resize" event to the shadow root to notify the injected script that the
snapshotted plug-in's metrics have changed and to allow the overlay to update itself
as a result.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Remove all the DOM generation code in favor of an approach where we create a shared
DOM scripting world in which we inject JavaScript code that will perform the same
task but will additionally be provided by the client in order to provide a completely
custom overlay for the snapshotted plug-in. The sole contract is for the JavaScript
to implement a createOverlay(shadowRoot, titleText, subtitleText) method.
(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay):
Renamed method to be generic to the overlay as opposed to text labels and use the
element with CSS class name "snapshot-overlay" as the comparison node.

• html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):
Removing a couple of unused members since we no longer generate the shadow DOM from C++
and rename the partOfSnapshotLabel method to partOfSnapshotOverlay.

• page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelTitle):
(WebCore::ChromeClient::plugInStartLabelSubtitle):
(WebCore::ChromeClient::plugInExtraScript):
Pass in the mime-type to plugInStartLabelTitle and plugInStartLabelSubtitle and expose
a new plugInExtraScript method to allow the chrome client to provide a custom JS file
for the management of the shadow root.

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent):
Update the terminology from "label" to "overlay" per the changes made in HTMLPlugInImageElement.

Source/WebKit2:

Expose a new plugInExtraScript method to support the injection of
a JS file from the chrome client to customize the rendering of a
snapshotted plug-in's shadow tree. Additionally, it is expected
the chrome client will want to provide localized strings taking
into account the snapshotted plug-in's mime-type, so we're adding
this as a parameter to both plugInStartLabelTitle and
plugInStartLabelSubtitle methods.

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
(WebKit::InjectedBundlePageUIClient::plugInExtraScript):

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelTitle):
(WebKit::WebChromeClient::plugInStartLabelSubtitle):
(WebKit::WebChromeClient::plugInExtraScript):

• WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Tools:

Take into account the new plugInExtraScript method added to support
the injection of a JS file from the chrome client to customize the
rendering of a snapshotted plug-in's shadow tree.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

12:32 AM Changeset in webkit [149585] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r140907) - Backport blink r149612 to fix vertical-align and rowspan issue
​https://bugs.webkit.org/show_bug.cgi?id=115611

Source/WebCore:

Patch by Julien Chaffraix.
Patch by Robert Hogan <​robert@webkit.org> on 2013-05-06
Reviewed by Benjamin Poulain.

Backport phttps://src.chromium.org/viewvc/blink?view=rev&revision=149612 from
​https://chromiumcodereview.appspot.com/14105010

Fix the rows' height computation with vertical-align: baseline and rowspan.
r140907 was careful in avoiding updating the baseline descent for
spanning cells. However it still added the non-spanning cells baseline
descent to the spanning cells' row height computation.
This change avoids the previous issue by not adding the baseline
descent in this case.

Test: fast/table/baseline-align-rowspan.html

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Patch by Robert Hogan <​robert@webkit.org> on 2013-05-06
Reviewed by Benjamin Poulain.

• fast/table/baseline-align-rowspan-expected.txt: Added.
• fast/table/baseline-align-rowspan.html: Added.

May 5, 2013:

10:43 PM Changeset in webkit [149584] by Chris Fleizach

• 2 edits in trunk/Source/WebKit2

WEB SPEECH: deny file-read-data /Library/Speech/Synthesizers
​https://bugs.webkit.org/show_bug.cgi?id=115621

Reviewed by Alexey Proskuryakov.

Allow access to the location where 3rd party speech synthesizers are stored.

• WebProcess/com.apple.WebProcess.sb.in:

9:10 PM Changeset in webkit [149583] by andersca@apple.com

• 13 edits in trunk/Source

Remove Vector::prepend
​https://bugs.webkit.org/show_bug.cgi?id=115618

Reviewed by Geoffrey Garen.

Source/WebCore:

Replace calls to Vector::prepend with either Vector::insert,
or a combination of Vector::append and Vector::reverse.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToGlobalPoint):

• css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):

• css/CSSValueList.h:

(WebCore::CSSValueList::prepend):

• dom/Document.cpp:

(WebCore::Document::iconURLs):

• editing/TextIterator.cpp:

(WebCore::SearchBuffer::prependContext):

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

• history/HistoryItem.cpp:

(WebCore::HistoryItem::padDailyCountsForNewVisit):
(WebCore::HistoryItem::collapseDailyVisitsToWeekly):

• inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::addInspectedObject):

• platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

Source/WTF:

Given the performance characteristics of prepending something to a Vector, not having prepend
will hopefully make developers think about whether prepending is necessary at all. For example,
the functions in HexNumber.h were easily converted to using Vector::append and then Vector::reverse.

• wtf/HexNumber.h:

(WTF::appendUnsignedAsHex):
(WTF::appendUnsignedAsHexFixedSize):

• wtf/Vector.h:

(Vector):

5:22 PM Changeset in webkit [149582] by weinig@apple.com

• 5 edits in trunk/Source/WebCore

Remove empty function SQLiteFileSystem::registerSQLiteVFS() and its callers
​https://bugs.webkit.org/show_bug.cgi?id=115619

Reviewed by Dan Bernstein.

• Modules/webdatabase/DatabaseTracker.cpp:
• platform/sql/SQLiteFileSystem.cpp:
• platform/sql/SQLiteFileSystem.h:
• storage/StorageTracker.cpp:

4:25 PM Changeset in webkit [149581] by Chris Fleizach

• 4 edits
  2 adds in trunk

AX: aria-checked not exposed correctly on menuitemcheckbox or menuitemradio roles
​https://bugs.webkit.org/show_bug.cgi?id=115499

Reviewed by Tim Horton.

Source/WebCore:

Expose isChecked() for menu item objects.
Return the Mac-platform specific value that you find on menu items for "checked" menu items.

Test: platform/mac/accessibility/aria-menuitem-checked-value.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isChecked):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

• platform/mac/accessibility/aria-menuitem-checked-value-expected.txt: Added.
• platform/mac/accessibility/aria-menuitem-checked-value.html: Added.

3:11 PM Changeset in webkit [149580] by timothy_horton@apple.com

• 4 edits in trunk/Source

[wk2] Page Overlays: deviceScaleFactor doesn't update when the display changes
​https://bugs.webkit.org/show_bug.cgi?id=115577
<rdar://problem/13762583>

Reviewed by Darin Adler.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Invalidate the page overlay layers' device scale factor when
TiledCoreAnimationDrawingArea is notified that it has changed.

• WebCore.exp.in:

Export GraphicsLayer::noteDeviceOrPageScaleFactorChangedIncludingDescendants

12:03 PM Changeset in webkit [149579] by andersca@apple.com

• 42 edits in trunk

Remove the Vector::append overload that takes a Vector
​https://bugs.webkit.org/show_bug.cgi?id=115535

Reviewed by Andreas Kling.

Source/WebCore:

Use Vector::appendVector instead.

• Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::putIndexDataForRecord):

• Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::clear):
(WebCore::AudioContext::scheduleNodeDeletion):

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cells):

• css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::add):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

• dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

• html/FormController.cpp:

(WebCore::FormController::getReferencedFilePaths):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineDash):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):

• html/track/WebVTTToken.h:

(WebCore::WebVTTToken::addNewClass):
(WebCore::WebVTTToken::addNewAnnotation):

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::preferredLanguages):

• platform/FileChooser.cpp:

(WebCore::FileChooserSettings::acceptTypes):

• platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunk):

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getSitesInMediaCache):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):

• platform/mac/PasteboardMac.mm:

(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::writeSelectionForTypes):

• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::generateUniqueBoundaryString):

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):

• svg/SVGGlyphMap.h:

(WebCore::SVGGlyphMap::collectGlyphsForString):

• xml/XPathNodeSet.h:

(WebCore::XPath::NodeSet::append):

Source/WebKit2:

Use Vector::appendVector instead.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):

• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::dispatchMessages):

• UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::pluginsDirectories):

Source/WTF:

The Vector::append overload that takes a Vector conflicts with rvalues in C++11, so remove it and
replace calls to it with calls to appendVector.

• wtf/Vector.h:

(Vector):

Tools:

Use Vector::appendVector instead.

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(concatenateAttributeAndValue):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::concatenateAttributeAndValue):

10:48 AM Changeset in webkit [149578] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

Make plugIns.js have a non-zero length.

• Resources/plugIns.js:

May 4, 2013:

10:20 PM Changeset in webkit [149577] by dino@apple.com

• 3 edits in trunk

Fix incorrect ChangeLog dates on previous commit.

9:43 PM Changeset in webkit [149576] by dino@apple.com

• 26 edits
  4 adds in trunk

Animations and Transitions should not start when globally suspended
​https://bugs.webkit.org/show_bug.cgi?id=114915

Reviewed by Sam Weinig.

.:

Export AnimationController::isSuspended().

• Source/autotools/symbols.filter:

Source/WebCore:

When the Document's AnimationController was suspended, we still
started new transitions and animations. Change this so that
animations enter a paused-but-new state, where they are frozen
until the AnimationController resumes. At that time, it is as
if they had just appeared: any delay counts down before
the animation starts.

For transitions, the change in value must still happen, but
it does so immediately. No transitionend event should be fired.
This produces a slightly confusing behaviour, because any
in-progress transitions are suspended, but any new style changes
happen instantly. This might sound contradictory, but in general
suspending the document is a rare (and dangerous) thing to do.

Previously, the Document would call resumeAnimations as it loaded,
effectively starting all the animations. This meant if you suspended
animations before loading a document, it was ignored as soon as the
load finished. Now there is a separate method startAnimationsIfNotSuspended
which checks to see if the document is suspended as it loads.

In order to handle this case, I added a new state to the Animation
machinery: AnimationStatePausedNew. This is an animation that was created
in the suspended state.

Tests: animations/added-while-suspended.html

transitions/started-while-suspended.html

• WebCore.exp.in: Export AnimationController::isSuspended().

• dom/Document.cpp:

(WebCore::Document::implicitClose):

resumeAnimationsForDocument() -> startAnimationsIfNotSuspended()

• page/animation/AnimationBase.cpp:

(WebCore::nameForState): New name for AnimationStatePausedNew.
(WebCore::AnimationBase::updateStateMachine): Handle new state AnimationStatePausedNew. The

most important change is that when go from PausedNew to Running, we jump back into
the New state and continue from there.

(WebCore::AnimationBase::updatePlayState): suspended -> isSuspended

• page/animation/AnimationBase.h: New state: AnimationStatePausedNew

(WebCore::AnimationBase::waitingToStart): Add AnimationStatePausedNew.
(WebCore::AnimationBase::paused): Add AnimationStatePausedNew.
(WebCore::AnimationBase::isNew): Add AnimationStatePausedNew.

• page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Initialise m_suspended.
(WebCore::AnimationControllerPrivate::clear): suspended -> isSuspended
(WebCore::AnimationControllerPrivate::updateAnimations): Ditto.
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer): Ditto.
(WebCore::AnimationControllerPrivate::suspendAnimations): Update m_suspended.
(WebCore::AnimationControllerPrivate::resumeAnimations): Ditto.
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): New method that will

only resume animations if we were not globally suspended.

(WebCore::AnimationController::isSuspended): New method.
(WebCore::AnimationController::suspendAnimations): Add logging.
(WebCore::AnimationController::resumeAnimations): Add logging.
(WebCore::AnimationController::suspendAnimationsForDocument): Add logging.
(WebCore::AnimationController::resumeAnimationsForDocument): Add logging.
(WebCore::AnimationController::startAnimationsIfNotSuspended): Calls private method.

• page/animation/AnimationController.h:

(AnimationController): Add isSuspended() and animationsForDocumentMayStart().

• page/animation/AnimationControllerPrivate.h:

(WebCore::AnimationControllerPrivate::isSuspended): New method.
(AnimationControllerPrivate): Add m_isSuspended member.

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::CompositeAnimation): Moved from header - initialise m_isSuspended.
(WebCore::CompositeAnimation::updateTransitions): Do not create ImplicitAnimation if suspended.
(WebCore::CompositeAnimation::updateKeyframeAnimations): Move to AnimationStatePausedNew if suspended.
(WebCore::CompositeAnimation::suspendAnimations): m_suspended -> m_isSuspended
(WebCore::CompositeAnimation::resumeAnimations): Ditto.

• page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::isSuspended): Renamed from suspended()

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate): If we're in the AnimationStatePausedNew state, then

we need to go to the first frame (to handle fill mode).

• testing/Internals.cpp:

(WebCore::Internals::animationsAreSuspended): New exposed method to reflect AnimationController.

• testing/Internals.h: Add animationsAreSuspended.
• testing/Internals.idl: Ditto.

Source/WebKit:

Export AnimationController::isSuspended

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

The WebView private API cssAnimationsSuspended did not necessarily
reflect the reality of the Frame's AnimationController value because it
was caching rather than asking directly. While the WebCore part of this
patch ensured loading the Document wouldn't resume all animations, it
is still better to ask directly.

• WebView/WebView.mm:

(-[WebView cssAnimationsSuspended]): Call into AnimationController.
(-[WebView setCSSAnimationsSuspended:]): Ditto.

• WebView/WebViewData.h: Remove cssAnimationsSuspended boolean.
• WebView/WebViewData.mm: Ditto.

(-[WebViewPrivate init]):

Source/WebKit/win:

Export AnimationController::isSuspended

• WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

Two new tests. Add an animation or transition to
the document when the global animation controller is suspended.
In the animation case, nothing should happen until the
animations are resumed. In the transition case, the style
change should happen immediately and not fire any events.

• animations/added-while-suspended-expected.txt: Added.
• animations/added-while-suspended.html: Added.
• animations/suspend-transform-animation.html: Make sure to resume suspended animations

before quitting the test.

• transitions/started-while-suspended-expected.txt: Added.
• transitions/started-while-suspended.html: Added.
• transitions/suspend-transform-transition.html: Make sure to resume suspended animations

before quitting the test.

7:39 PM Changeset in webkit [149575] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

Fix * placement in a few functions as noticed by Mark Rowe.

Rubber-stamped by Dan Bernstein.

• WebProcess/WebPage/PageBanner.h:

(PageBanner):

• WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::create):
(WebKit::PageBanner::PageBanner):

7:35 PM Changeset in webkit [149574] by weinig@apple.com

• 7 edits
  4 moves in trunk/Source

Move PopupMenuMac and SearchPopupMenuMac to Source/WebKit/mac
matching where they are in WebKit2.

Reviewed by Anders Carlsson.

Source/WebCore:

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• platform/mac/PopupMenuMac.h: Removed.
• platform/mac/PopupMenuMac.mm: Removed.
• platform/mac/SearchPopupMenuMac.h: Removed.
• platform/mac/SearchPopupMenuMac.mm: Removed.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

• WebCoreSupport/PopupMenuMac.h: Copied from WebCore/platform/mac/PopupMenuMac.h.
• WebCoreSupport/PopupMenuMac.mm: Copied from WebCore/platform/mac/PopupMenuMac.mm.
• WebCoreSupport/SearchPopupMenuMac.h: Copied from WebCore/platform/mac/SearchPopupMenuMac.h.
• WebCoreSupport/SearchPopupMenuMac.mm: Copied from WebCore/platform/mac/SearchPopupMenuMac.mm.
• WebCoreSupport/WebChromeClient.mm:

7:32 PM Changeset in webkit [149573] by weinig@apple.com

• 4 edits
  1 add in trunk

REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
<rdar://problem/13702008>
​https://bugs.webkit.org/show_bug.cgi?id=115607

Reviewed by Benjamin Poulain.

Source/WebKit2:

API Test: WebKit2.CloseThenTerminate

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Don't try to reset the state if the page is closed, it won't work and its not worth it.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.

6:53 PM Changeset in webkit [149572] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Get rid of special cases in AddIncludesForTypeInImpl
​https://bugs.webkit.org/show_bug.cgi?id=115602

Reviewed by Benjamin Poulain.

Get rid of the special cases in AddIncludesForTypeInImpl subroutine in the
JS bindings generator. Those are no longer needed and special cases should
be avoided in the generator.

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):

6:47 PM Changeset in webkit [149571] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Clean up unused spellcheck code
​https://bugs.webkit.org/show_bug.cgi?id=115560

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-04
Reviewed by Benjamin Poulain.
Internally reviewed by Mike Lattanzio

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):

• Api/WebPage.h:
• WebKitSupport/InputHandler.cpp:
• WebKitSupport/InputHandler.h:

(InputHandler):

6:34 PM Changeset in webkit [149570] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Get rid of AddIncludesForSVGAnimatedType in bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115603

Reviewed by Benjamin Poulain.

Remove AddIncludesForSVGAnimatedType subroutine from the bindings generator
as it is a special case which is no longer needed.

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

2:44 PM Changeset in webkit [149569] by Antoine Quint

• 11 edits
  1 add in trunk/Source/WebCore

Update code generators to handle a new JavaScript file for snapshotted plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=115596

Reviewed by Dean Jackson.

In preparation for ​https://webkit.org/b/115548, adding a new JS file at
Resources/plugIns.js that we will use to provide presentation for the
snapshotted plug-ins overlay.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Resources/plugIns.js: Added.
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

1:29 PM Changeset in webkit [149568] by akling@apple.com

• 2 edits in trunk/Source/WTF

Unreviewed, rolling out r149563.
​http://trac.webkit.org/changeset/149563
​https://bugs.webkit.org/show_bug.cgi?id=115587

Broke LLInt build.

• wtf/text/StringImpl.h:

(StringImpl):

1:25 PM Changeset in webkit [149567] by akling@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r142647): Flaky Test: fast/frames/crash-remove-iframe-during-object-beforeload.html
<​http://webkit.org/b/115322>
<rdar://problem/13810719>

Reviewed by Anders Carlsson.

Don't cache the FrameView::renderView() in a local since updating Widgets may blow it away.

• page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

1:22 PM Changeset in webkit [149566] by akling@apple.com

• 6 edits in trunk/Source/WebCore

Remove GraphicsContext::strokeArc(), which is unused.

From Blink r149608 by <​jbroman@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149608>

This is no longer used since almost a year ago, when HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) was inlined.

• platform/graphics/GraphicsContext.h:
• platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
• platform/graphics/cairo/GraphicsContextCairo.cpp:
• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/graphics/wince/GraphicsContextWinCE.cpp:

1:10 PM Changeset in webkit [149565] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove unused CSSSelector::isCustomPseudoType().

From Blink r149574 by <​dominicc@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149574>

• css/CSSSelector.h:
• css/CSSSelector.cpp:

12:42 PM Changeset in webkit [149564] by fpizlo@apple.com

• 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG::ByteCodeParser doesn't need ExecState*
​https://bugs.webkit.org/show_bug.cgi?id=115582

Reviewed by Geoffrey Garen.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::parse):

• dfg/DFGByteCodeParser.h:

(DFG):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

12:36 PM Changeset in webkit [149563] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

No need to declare JSC::LLInt::Data as friend class of WTF::StringImpl
​https://bugs.webkit.org/show_bug.cgi?id=115587

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-05-04
Reviewed by Andreas Kling.

No need to declare LLInt::Data as friend class of WTF::StringImpl,
it does not use any private method/data member of the latter.

• wtf/text/StringImpl.h:

(StringImpl):

12:04 PM Changeset in webkit [149562] by andersca@apple.com

• 7 edits in trunk/Source/WebKit/mac

Get rid of -[NSMutableDictionary _webkit_setObject:forUncopiedKey:]
​https://bugs.webkit.org/show_bug.cgi?id=115592

Reviewed by Beth Dakin.

Using CFDictionarySetValue to set a key without having to copy it is not supported. Use NSMapTable with strong pointers instead.

• Misc/WebNSDictionaryExtras.h:
• Misc/WebNSDictionaryExtras.m:
• Panels/WebPanelAuthenticationHandler.h:

(NSURLAuthenticationChallenge):

• Panels/WebPanelAuthenticationHandler.m:

(-[WebPanelAuthenticationHandler init]):
(-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]):
(-[WebPanelAuthenticationHandler tryNextChallengeForWindow:]):
(-[WebPanelAuthenticationHandler startAuthentication:window:]):
(-[WebPanelAuthenticationHandler cancelAuthentication:]):

• Plugins/WebNetscapePluginView.h:
• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView destroyPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView loadPluginRequest:]):

11:46 AM Changeset in webkit [149561] by Beth Dakin

• 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=115574
Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null

Reviewed by Darin Adler.

Don't call addToPage() on a null banner.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setHeaderPageBanner):
(WebKit::WebPage::setFooterPageBanner):

9:29 AM Changeset in webkit [149560] by akling@apple.com

• 4 edits in trunk/Source/WebCore

Remove ShadowRoot's previous/next ShadowRoot pointers.
<​http://webkit.org/b/115588>

Reviewed by Anders Carlsson.

ShadowRoot no longer inherits from DoublyLinkedListNode<ShadowRoot> because that code wasn't
doing anything anymore. Shrinks ShadowRoot by two pointers.

• dom/ElementShadow.h:
• dom/ShadowRoot.cpp:

(SameSizeAsShadowRoot):
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):

• dom/ShadowRoot.h:

8:27 AM Changeset in webkit [149559] by akling@apple.com

• 2 edits in trunk/Source/WebCore

RenderObject: don't change GraphicsContext state when not drawing dashed/dotted lines.

From Blink r149546 by <​jbroman@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149546>

Previously, there was asymmetry between changing and restoring state (certain state
would be restored only if thickness was positive, i.e. a line was actually drawn.)

• rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

8:18 AM Changeset in webkit [149558] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed.

• Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.

8:03 AM Changeset in webkit [149557] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove CSS selector profiler branches from ElementRuleCollector loop.
<​http://webkit.org/b/115581>

Reviewed by Antti Koivisto.

Templatize the method so we don't have to check for active inspector frontends on every
pass through the loop.

Time spent in this loop goes down from 0.5% to 0.2% on iTunes Store, WebCore binary size
goes up 480 bytes (sorry Benjamin, I'll make it up to you.)

• css/ElementRuleCollector.h:
• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

7:16 AM May 2013 Meeting edited by mhahnenberg@apple.com

Added transcript for the Status of JSC session. (diff)

7:00 AM Changeset in webkit [149556] by mihnea@adobe.com

• 2 edits in trunk/Tools

Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.

4:17 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

4:15 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

3:55 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

3:52 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

3:47 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

3:44 AM WebKitGTK/TrackingMemoryErrors edited by elima@igalia.com

(diff)

3:26 AM WebKitGTK/TrackingMemoryErrors created by elima@igalia.com

3:19 AM WebKitGTK edited by elima@igalia.com

(diff)

2:22 AM May 2013 Meeting edited by Joseph Pecoraro

Added Profiling in JavaScriptCore notes (diff)

12:54 AM Changeset in webkit [149555] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Catch select.error exceptions in parse_output_lines
​https://bugs.webkit.org/show_bug.cgi?id=115253

Reviewed by Gustavo Noronha Silva.

Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
error code and the error message) and the loop is re-entered.

• gtk/common.py:

(parse_output_lines):

12:50 AM Changeset in webkit [149554] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Set up the TestWebCore in TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=115237

Reviewed by Gustavo Noronha Silva.

Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
a workaround for the layer violations and circular dependencies between various static libraries. Linking against
either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).

• TestWebKitAPI/GNUmakefile.am:

12:44 AM Changeset in webkit [149553] by robert@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align
​https://bugs.webkit.org/show_bug.cgi?id=115432

Reviewed by Julien Chaffraix.

Source/WebCore:

If a cell changes vertical-align any intrinsic padding it has is now redundant. It
needs to calculate its new height from RenderTableRow::layout() and then find its
new intrinsic padding in RenderTableSection::layoutRows().

Test: fast/table/correct-baseline-after-style-change.html

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

LayoutTests:

• fast/table/correct-baseline-after-style-change-expected.html: Added.
• fast/table/correct-baseline-after-style-change.html: Added.

12:30 AM Changeset in webkit [149552] by msaboff@apple.com

• 4 edits in trunk/Source/JavaScriptCore

There should be a runtime option to constrain what functions get DFG compiled
​https://bugs.webkit.org/show_bug.cgi?id=115576

Reviewed by Mark Hahnenberg.

Added OptionRange to Options to allow checking that something is within an option
or not. The new OptionClass supports range strings in the form of [!]<low>[:<high>].
If only one value is given, then it will be used for both low and high. A leading
'!' inverts the check. If no range is given, then checking for a value within a range
will always return true. Added the option "bytecodeRangeToDFGCompile" that takes an
OptionRange string to select the bytecode range of code blocks to DFG compile.

• dfg/DFGDriver.cpp:

(JSC::DFG::compile): Added new check for bytecode count within bytecodeRangeToDFGCompile
range.

• runtime/Options.cpp:

(JSC::parse): Added overloaded parse() for OptionRange.
(JSC::OptionRange::init): Parse range string and then initialize the range.
(JSC::OptionRange::isInRange): Function used by consumer to check if a value is within
the specified range.
(JSC::Options::dumpOption): Added code to dump OptionRange options.

• runtime/Options.h:

(OptionRange): New class.
(JSC::OptionRange::operator= ): This is really used as a default ctor for use within
the Option static array initialization.
(JSC::OptionRange::rangeString): This is used for debug. It assumes that the char*
passed into OptionRange::init is valid when this function is called.

12:23 AM Changeset in webkit [149551] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13806836> Tweak sandbox profile.

Reviewed by Dan Bernstein.

• WebProcess/com.apple.WebProcess.sb.in:

May 3, 2013:

8:49 PM Changeset in webkit [149550] by commit-queue@webkit.org

• 5 edits
  4 adds in trunk

incorrect repainting when a table has a transform
​https://bugs.webkit.org/show_bug.cgi?id=109867

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-03
Reviewed by Simon Fraser.

Source/WebCore:

Disable LayoutState when table, tableRow or tableSection render
objects have transforms or reflections.

Tests: fast/repaint/reflection-table-layout.html

fast/repaint/transform-table-layout.html

• rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

Create tests that resize an element inside a display: table element.
Compare to a reference html file where the element has a static size.
In the first test, the table like element has a transform. In the
second, it has a reflection.

• fast/repaint/reflection-table-layout-expected.html: Added.
• fast/repaint/reflection-table-layout.html: Added.
• fast/repaint/transform-table-layout-expected.html: Added.
• fast/repaint/transform-table-layout.html: Added.

8:43 PM Changeset in webkit [149549] by Antti Koivisto

• 30 edits in trunk

Remove concept of younger and older shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=115570

Reviewed by Andreas Kling.

Source/WebCore:

Younger and older shadow trees are an obscure corner of the Shadow DOM spec.

Support only one shadow tree per element. This simplifies many things.

• dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):

• dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(ComposedShadowTreeWalker):

• dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
(WebCore::ChildFrameDisconnector::collectFrameOwners):
(WebCore::assertConnectedSubrameCountIsConsistent):

• dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

• dom/Element.cpp:

(WebCore::Element::authorShadowRoot):
(WebCore::Element::userAgentShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot):

• dom/Element.h:

(Element):
(WebCore::Element::hasAuthorShadowRoot):

• dom/Element.idl:
• dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):

Allow only one ShadowRoot per ElementShadow. Remove linked list handling.

(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::removeAllEventListeners):

• dom/ElementShadow.h:

(WebCore::ElementShadow::shadowRoot):
(ElementShadow):
(WebCore::ElementShadow::host):
(WebCore::Node::shadowRoot):
(WebCore):

• dom/Node.cpp:

(WebCore):
(WebCore::Node::showNodePathForThis):
(WebCore::traverseTreeAndMark):
(WebCore::showSubTreeAcrossFrame):

• dom/Node.h:

(Node):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto):

• dom/ShadowRoot.h:

(ShadowRoot):

Remove LinkedList base.

• dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::ensureSelectFeatureSet):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):

• page/FocusController.cpp:

(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):

• rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildShadowTree):

• testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

LayoutTests:

• editing/text-iterator/basic-iteration-expected.txt:
• editing/text-iterator/script-tests/basic-iteration.js:

(addShadowTreeWithDivElement):

• fast/forms/resources/common-spinbutton-change-and-input-events.js:

(testSpinButtonChangeAndInputEvents):

• fast/forms/resources/common-spinbutton-click-in-iframe.js:

(getSpinButton):

7:11 PM Changeset in webkit [149548] by commit-queue@webkit.org

• 2 edits in trunk/PerformanceTests/SunSpider

SunSpider 1.0: 3d-morph: use epsilon to check result
​https://bugs.webkit.org/show_bug.cgi?id=115553

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-05-03
Reviewed by George Staikos.

SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.

• tests/sunspider-1.0/3d-morph.js:

7:07 PM Changeset in webkit [149547] by commit-queue@webkit.org

• 1 edit
  9 adds in trunk/Tools

Create a script to import W3C tests
​https://bugs.webkit.org/show_bug.cgi?id=111513

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2013-05-03
Reviewed by Dirk Pranke.

Script to automate the import of W3C tests into WebKit.
For the full description of how it works, see the comments
at the top of test_importer.py.

• Scripts/import-w3c-tests: Added.
• Scripts/webkitpy/w3c/init.py: Added.
• Scripts/webkitpy/w3c/test_converter.py: Added.

(TestConverter):
(TestConverter.init):
(TestConverter.load_prefixed_prop_list):
(TestConverter.load_file):
(TestConverter.convert_for_webkit):
(TestConverter.convert_testharness_paths):
(TestConverter.convert_prefixed_properties):
(TestConverter.scrub_unprefixed_props):
(TestConverter.replace_tag):

• Scripts/webkitpy/w3c/test_converter_unittest.py: Added.

(TestConverterTest):
(TestConverterTest.testLoadPrefixedPropList):
(TestConverterTest.test_convertForWebkitNothingToConvert):
(test_convertForWebkitHarnessOnly):
(test_convertForWebkitPropsOnly):
(test_convertForWebkitHarnessAndProps):
(test_convertTestHarnessPaths):
(test_convertPrefixedProperties):
(verifyTestHarnessPaths):
(verifyPrefixedProperties):
(generateTestContent):

• Scripts/webkitpy/w3c/test_importer.py: Added.

(main):
(parse_args):
(validate_import_directory):
(TestImporter):
(TestImporter.init):
(TestImporter.do_import):
(TestImporter.get_changeset):
(TestImporter.scan_source_directory):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.get_test_status):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):

• Scripts/webkitpy/w3c/test_importer_unittest.py: Added.

(TestImporterTest):
(TestImporterTest.test_ImportDirWithNoTests):

• Scripts/webkitpy/w3c/test_parser.py: Added.

(TestParser):
(TestParser.init):
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.get_reftests):
(TestParser.is_jstest):
(TestParser.get_support_files):

• Scripts/webkitpy/w3c/test_parser_unittest.py: Added.

(TestParserTest):
(TestParserTest.test_analyzeTestReftestOneMatch):
(test_analyzeTestReftestMultipleMatches):
(test_analyzeTestReftestMatchAndMismatch):
(test_analyzeTestReftestWithRefSupportFiles):
(test_analyzeJSTest):
(test_analyzePixelTestAllTrue):
(test_analyzePixelTestAllFalse):
(test_analyzeNonHTMLFile):

5:40 PM May 2013 Meeting edited by rniwa@webkit.org

Add a link to binding generators script (diff)

5:08 PM May 2013 Meeting edited by betravis@adobe.com

(diff)

5:03 PM Changeset in webkit [149546] by Martin Robinson

• 5 edits in trunk/Source/WebCore

Simplify the #ifdefs in GraphicsContext3D.h
​https://bugs.webkit.org/show_bug.cgi?id=115568

Reviewed by Daniel Bates.

• platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D): Combine #ifdefs paths that have a common
implementation. This reduces the #ifdef paths from many to just three.

• platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::platformTexture): Move the implementation
here to simplify the header.

• platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::platformTexture): Ditto.
(WebCore):

4:50 PM Changeset in webkit [149545] by Christophe Dumez

• 2 edits in trunk/Tools

Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.

• Scripts/webkitpy/common/config/contributors.json:

4:44 PM Changeset in webkit [149544] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
​https://bugs.webkit.org/show_bug.cgi?id=115551

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-05-03
Reviewed by Benjamin Poulain.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup):
Change String(textTrack->kind()) to textTrack->kind().string(), and same thing with language.

4:41 PM Improving the DOM now that we only have 1 JS engine / the removal of ScriptState! created by jonlee@apple.com

4:40 PM May 2013 Meeting edited by jonlee@apple.com

(diff)

4:12 PM Changeset in webkit [149543] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
​https://bugs.webkit.org/show_bug.cgi?id=115575

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-05-03
Reviewed by Philippe Normand.

No new tests needed.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Using extern debug category.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Declaring debug category as not static.

3:19 PM Changeset in webkit [149542] by zhajiang@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page rendering scale is changed after go back and forward
​https://bugs.webkit.org/show_bug.cgi?id=115573

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-03.
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers.

PR: 326886
When navigating back from page A with viewport to page B without
viewport, we didn't call setViewMode(); therefore, we didn't change
the fixed layout size which was set by page A. In that case, WebCore
would just pick up page A's fixed layout size to layout page B which
caused this issue.
Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
later is not a good way, because zoomToInitialScaleOnLoad() has never
been called in this case. So we should always call setViewMode() to set
fixed layout size when a new page is committed.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

3:14 PM Changeset in webkit [149541] by bfulgham@webkit.org

• 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed VS2010 Build Correction.

• WebCore.vcxproj/WebCore.vcxproj: Exclude CG-only

SubimageCacheWithTimer.cpp from WinCairo build.

3:12 PM Changeset in webkit [149540] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

[Cairo] Anti-aliasing should not be always disabled for lines
​https://bugs.webkit.org/show_bug.cgi?id=109535

Patch by Viatcheslav Ostapenko <​viatchslav.o@samsung.com> on 2013-05-03
Reviewed by Martin Robinson.

Source/WebCore:

Don't disable antialiasing for text lines because it produces ugly picture if
page is scaled.

Test: fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::drawLineOnCairoContext):

LayoutTests:

Add pixel test with scaled text lines.

• fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html: Added.
• platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.png: Added.
• platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.

2:41 PM Changeset in webkit [149539] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unnecessary include HTMLNames.h from RenderThemeGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115571

Reviewed by Martin Robinson.

• platform/gtk/RenderThemeGtk.cpp:

2:18 PM Changeset in webkit [149538] by ggaren@apple.com

• 81 edits in branches/dfgFourthTier

Rolled out r149527 because it caused a crash.

Source/JavaScriptCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit/mac:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit2:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

LayoutTests:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

2:06 PM May 2013 Meeting edited by betravis@adobe.com

(diff)

1:56 PM Changeset in webkit [149537] by ap@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] setMetadataURL incorrectly treats path bytes as Latin-1
​https://bugs.webkit.org/show_bug.cgi?id=115557

Reviewed by Sam Weinig.

• platform/mac/FileSystemMac.mm: (WebCore::setMetaData): Use the correct constructor.

1:56 PM Changeset in webkit [149536] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

PDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported
​https://bugs.webkit.org/show_bug.cgi?id=115544
<rdar://problem/13801789>

Reviewed by Alexey Proskuryakov.

Commit changes to the active annotation (if there is one) before
returning the live PDF data, so that said changes are represented
in the exported or printed output.

• WebProcess/Plugins/PDF/PDFPlugin.h: Override liveData.
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::liveData): Commit the active annotation if there is one.

• WebProcess/Plugins/PDF/SimplePDFPlugin.h:

(SimplePDFPlugin): Make liveData virtual.

1:56 PM Changeset in webkit [149535] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
​https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>

Reviewed by Simon Fraser.

Null-check m_page. In theory, we shouldn't get here, because we stop
the timer at the only point where m_page is cleared, but crash logs say
we're still crashing here.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):

1:55 PM Changeset in webkit [149534] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Remove some "what" comments from FindController
​https://bugs.webkit.org/show_bug.cgi?id=115546

Reviewed by Andreas Kling.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::willMoveToWebPage):
(WebKit::FindController::mouseEvent):
Remove or reword some comments.

1:48 PM Changeset in webkit [149533] by abucur@adobe.com

• 4 edits in trunk/Source/WebCore

Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
​https://bugs.webkit.org/show_bug.cgi?id=115550

Reviewed by Simon Fraser.

The patch moves pixelSnappedLayoutOverflowRect and maxLayoutOverflow out
of RenderBox somewhere logically closer to their usage place.

pixelSnappedLayoutOverflowRect - moved to RenderView because it's called only
for RenderView at this moment.
There are other places when the overflow rect is pixel snapped but only after
the rect is adjusted for writing modes or inflated.

maxLayoutOverflow - moved to RenderTreeAsText.cpp as a static function because
it's used only there.

Tests: no new functional change.

• rendering/RenderBox.h: The functions declarations are removed.
• rendering/RenderTreeAsText.cpp:

(WebCore::maxLayoutOverflow):

• rendering/RenderView.h:

(WebCore::RenderView::pixelSnappedLayoutOverflowRect):

1:43 PM Changeset in webkit [149532] by akling@apple.com

• 11 edits in trunk/Source

StyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM wrappers.
<​http://webkit.org/b/115563>

Reviewed by Antti Koivisto.

Source/WebCore:

Change styleRulesForElement() and pseudoStyleRulesForElement() to return Vectors of StyleRuleBase
instead of CSSRuleLists. This defers instantiating CSSOM wrappers until they're actually needed
for exposure to web API.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

Create a StaticCSSRuleList and populate it with CSSOM wrappers for the matched rules.
This is the one place where we expose this functionality to the web.

• css/ElementRuleCollector.h:
• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

Collect internal StyleRuleBase pointers here instead of creating wrappers.

• css/StyleResolver.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):

Vend said pointers.

• editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

Dodge CSSOM wrapper instantiation (Woop woop!)

• inspector/InspectorCSSAgent.h:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForRule):

Split buildObjectForRule() into two versions, one for CSSStyleRule and one for StyleRule.
The CSSStyleRule one doesn't need a special path for parent-less rules, since those always
come in through the StyleRule interface instead. This factoring can be improved further
after this change.

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

Tweaked for changes in StyleResolver API.

Source/WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

Tweaked for changes in StyleResolver API.

1:29 PM Changeset in webkit [149531] by ap@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r145042): Downloading a file sometimes results in could not create
a sandbox extension Console message and file stays as a .download file
​https://bugs.webkit.org/show_bug.cgi?id=115559
<rdar://problem/13785101>

Reviewed by Sam Weinig.

CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
creates a string with maximum possible buffer size. This was confusing resolveSymlinksInPath().

• platform/cf/FileSystemCF.cpp: (WebCore::fileSystemRepresentation): Change fileSystemRepresentation to be less surprising. Really, we should rip apart CString and update callers to use better defined semantics, but this is the one function that repeatedly causes problems in practice.

1:27 PM Changeset in webkit [149530] by akling@apple.com

• 13 edits in trunk/Source/WebCore

CSSRule style declarations getters shouldn't be const.
<​http://webkit.org/b/115572>

Reviewed by Antti Koivisto.

Accessing the CSSStyleDeclaration for a CSSRule is a potentially mutating operation,
and should not be const.

• css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):

• css/CSSFontFaceRule.h:
• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):

• css/CSSPageRule.h:
• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):

• css/CSSStyleRule.h:

(CSSStyleRule):

• css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::style):

• css/WebKitCSSFilterRule.h:
• css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::style):

• css/WebKitCSSKeyframeRule.h:

(WebKitCSSKeyframeRule):

• css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::style):

• css/WebKitCSSViewportRule.h:

12:31 PM Changeset in webkit [149529] by akling@apple.com

• 7 edits in trunk/Source/WebCore

Use NotNull tag for placement new in WebCore.
<​http://webkit.org/b/115569>

Reviewed by Antti Koivisto.

Avoid emitting null checks where we use placement new to construct objects into safe locations.

• css/StylePropertySet.cpp:

(WebCore::ImmutableStylePropertySet::create):

• dom/Element.cpp:

(WebCore::ShareableElementData::createWithAttributes):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):

• dom/QualifiedName.cpp:

(WebCore::QualifiedName::init):
(WebCore::createQualifiedName):

• dom/make_names.pl:

(printNamesCppFile):

• platform/ThreadGlobalData.h:

(WebCore::threadGlobalData):

• platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createForMixedFontData):

12:11 PM Changeset in webkit [149528] by akling@apple.com

• 4 edits in trunk/Source/WebCore

Simplify CSSSelectorList creation/adoption.
<​http://webkit.org/b/106649>

Reviewed by Antti Koivisto.

Remove the optimization that special-cased construction of CSSSelectorLists with a single entry.
This is in preparation for changing the way we store the selector lists on style rules.

• css/CSSParser.h:
• css/CSSSelector.h:

Remove move(PassOwnPtr<CSSSelector> from, CSSSelector* to), inlining it into
CSSSelectorList::adoptSelectorVector instead.

• css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::deleteSelectors):

Handle all selector list lengths the same way.

(WebCore::CSSSelectorList::adoptSelectorVector):

Merge move() from CSSSelector.h into this code since it was the only call site.
Also some minor readability cleanups.

11:46 AM Changeset in webkit [149527] by ggaren@apple.com

• 81 edits in branches/dfgFourthTier

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This fixes a bunch of Sputnik tests.

The new model is that the callee always performs 'this' value conversion.

My ultimate goal is to break up resolve_with_this into single-result
opcodes. This step avoids having to add a new kind of convert_this for
call sites.

• API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call): Perform 'this' value conversion for
our callee, since it may observe 'this'.

• API/JSCallbackObjectFunctions.h:

(JSC::::call): Ditto.

• API/JSContextRef.cpp:

(JSGlobalContextCreateInGroup): Use a proxy 'this' object in global scope
even when we're not in the browser. This eliminates some odd cases where
API clients used to be able to get a direct reference to an environment
record. Now, any reference to an environment record unambiguously means
that the VM resolved that record in the scope chain.

(JSContextGetGlobalObject): Removed an incorrect comment. Now that JSC
participates in the proxy 'this' object scheme, the behavior is not
WebCore-only.

• JavaScriptCore.order: Order!

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

What are the chances that this will work?

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock): Renamed convert_this to to_this, to match our
other conversion opcodes.

• bytecode/CodeOrigin.h:

(CodeOrigin):
(InlineCallFrame):
(JSC::CodeOrigin::codeOriginOwner): Use the more precise type for our
executable, so compilation can discover where we're in strict mode.

• bytecode/Opcode.h:

(JSC::padOpcodeName): Updated for rename.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Always emit to_this when
'this' is in use -- strict mode still needs to convert environment
records to 'undefined'.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode): Updated for renames.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Tightened up this code to consider
strict mode (a new requirement) and to consider the global object (which
was always a requirement).

• dfg/DFGGraph.h:

(JSC::DFG::Graph::globalThisObjectFor):
(JSC::DFG::Graph::executableFor):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Ditto.

• interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):

• interpreter/Interpreter.h: Don't ASSERT about 'this' -- it's our job

to fix it up if needed.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:

(JIT):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• jit/JITStubs.h: Removed special case code for various kinds of

conversions. The baseline fast path is now only final objects. It hurt
my brain to think through how to keep the other fast paths working, and
our benchmarks do not object.

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

• runtime/CallData.cpp:

(JSC::call):

• runtime/ClassInfo.h:

(MethodTable):
(JSC):

• runtime/Completion.cpp:

(JSC::evaluate):

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToJSON):

• runtime/JSActivation.cpp:

(JSC::JSActivation::toThis):

• runtime/JSActivation.h:

(JSActivation):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::toThisSlowCase):

• runtime/JSCJSValue.h:

(JSValue):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::toThis):

• runtime/JSCell.cpp:

(JSC::JSCell::toThis):

• runtime/JSCell.h:

(JSCell):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::toThis):

• runtime/JSGlobalObject.h:

(JSGlobalObject):

• runtime/JSNameScope.cpp:

(JSC::JSNameScope::toThis):

• runtime/JSNameScope.h:

(JSNameScope):

• runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::toThis):

• runtime/JSObject.h:

(JSObject):

• runtime/JSScope.cpp:

(JSC::JSScope::resolveWithThis):

• runtime/JSString.cpp:

(JSC::JSString::toThis):

• runtime/JSString.h:

(JSString):

• runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

• runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::toThis):

• runtime/StrictEvalActivation.h:

(StrictEvalActivation): Filled out runtime support for converting 'this'
values as needed, according to the strictness of the caller.

Source/WebCore:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

• WebCore.order:
• bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

• bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::internalConstructorName):

• bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bridge/NP_jsobject.cpp:

(_NPN_Invoke):

Source/WebKit/mac:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

LayoutTests:

We pass these tests now:

• sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:

11:26 AM Changeset in webkit [149526] by Stephanie Lewis

• 1 edit
  1 add in trunk/LayoutTests

Revert to old results on Lion.

Unreviewed.

Results were updated in (​http://trac.webkit.org/changeset/149503) but that is compiled
out on Lion (​http://trac.webkit.org/changeset/149510).

• platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.

11:08 AM Changeset in webkit [149525] by Antti Koivisto

• 18 edits
  3 deletes in trunk/Source/WebCore

Remove HTMLShadowElement
​https://bugs.webkit.org/show_bug.cgi?id=115555

Reviewed by Andreas Kling.

This is not used internally.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• dom/ComposedShadowTreeWalker.cpp:
• dom/NodeRenderingContext.cpp:
• html/HTMLElementsAllInOne.cpp:
• html/HTMLTagNames.in:
• html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

• html/shadow/HTMLShadowElement.cpp: Removed.
• html/shadow/HTMLShadowElement.h: Removed.
• html/shadow/HTMLShadowElement.idl: Removed.
• page/DOMWindow.idl:

11:08 AM Changeset in webkit [149524] by bfulgham@webkit.org

• 2 edits in trunk/Source/WTF

Make ThreadFunctionInvocation fast allocated.
​https://bugs.webkit.org/show_bug.cgi?id=115552

Reviewed by Benjamin Poulain.

• wtf/ThreadFunctionInvocation.h:

(ThreadFunctionInvocation): Make Fast-allocated.

10:12 AM Changeset in webkit [149523] by mikhail.pozdnyakov@intel.com

• 12 edits
  1 delete in trunk/Source

Remove WTF::ListRefPtr class
​https://bugs.webkit.org/show_bug.cgi?id=115516

Reviewed by Anders Carlsson.

ListRefPtr was used only by FontFamily class, besides it strongly depended
on FontFamily class semantics which made it non-generic and inappropriate
for being present inside WTF.

This patch removes WTF::ListRefPtr class and moves its the functionality
into FontFamily class.

Source/WebCore:

No new tests, no change in the behavior.

• page/FrameTree.h:

(FrameTree):

• platform/graphics/FontFamily.h:

(FontFamily):
(WebCore::FontFamily::~FontFamily):
(WebCore):

Source/WTF:

• GNUmakefile.list.am:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Forward.h:

(WTF):

• wtf/ListRefPtr.h: Removed.

9:58 AM Changeset in webkit [149522] by joone.hur@intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip some failing tests after r149504.

• platform/efl/TestExpectations:

3:35 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

Adding r149486 as a proposed merge. (diff)

3:02 AM WebKitGTK/2.0.x edited by agarcia@igalia.com

(diff)

2:34 AM Changeset in webkit [149521] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Crash when calling QWebFrame::evaluateJavaScript
​https://bugs.webkit.org/show_bug.cgi?id=113434

Reviewed by Simon Hausmann.

We must take the JS API lock before accessing internal JS methods.

• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::unwrapBoxedPrimitive):
(JSC::Bindings::getGregorianDateTimeUTC):
(JSC::Bindings::convertQVariantToValue):

12:45 AM May 2013 Meeting edited by Joseph Pecoraro

Added Merging iOS WebKit notes (diff)

12:10 AM Changeset in webkit [149520] by aestes@apple.com

• 2 edits in trunk/Source/WebKit2

[WK2][CustomProtocols] NSURLProtocolClient methods should be dispatched on NSURLConnection's resource loader run loop
​https://bugs.webkit.org/show_bug.cgi?id=115539

Reviewed by Alexey Proskuryakov.

It turns out that calling NSURLProtocolClient methods from a different
thread than the one running the NSURLConnection run loop is unsafe.
Although I can't capture it reliably in a test case, doing so can
sometimes result in a load timing out because the call to
-[NSURLProtocolClient URLProtocolDidFinishLoading:] was ignored by
NSURLConnection.

Fix this by dispatching these methods on the NSURLConnection resource
load run loop. This matches where NSURLProtocolClient methods are
dispatched by typical NSURLProtocol implementations, and in my testing
this solves the timeout issue.

• Shared/Network/CustomProtocols/CustomProtocolManager.h: Declare

dispatchOnResourceLoaderRunLoop().

• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

Declare +[NSURLConnection resourceLoaderRunLoop] on a category of
NSURLConnection. Also include the header that declares it if it's present.
(WebKit::CustomProtocolManager::didFailWithError): Call the
NSURLProtocolClient method via dispatchOnResourceLoaderRunLoop().
(WebKit::CustomProtocolManager::didLoadData): Ditto.
(WebKit::CustomProtocolManager::didReceiveResponse): Ditto.
(WebKit::CustomProtocolManager::didFinishLoading): Ditto.
(WebKit::CustomProtocolManager::dispatchOnResourceLoaderRunLoop):
Dispatch a block on the NSURLConnection resource loader run loop and
then wake up the run loop.

12:05 AM May 2013 Meeting edited by Joseph Pecoraro

Added Web Inspector talk notes (diff)

May 2, 2013:

11:47 PM Changeset in webkit [149519] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Fine tune dependencies for glslang generated files
​https://bugs.webkit.org/show_bug.cgi?id=115537

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-05-02
Reviewed by Martin Robinson.

Make glslang.* explictly depend on glslang_tab.*, since the
dependency does exist. Otherwise Make might decide to compile
things ahead of time and fail.

• GNUmakefile.am:

11:46 PM Changeset in webkit [149518] by fpizlo@apple.com

• 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Profiler should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115445

Reviewed by Geoffrey Garen.

Change the Profiler::Database API for Compilation creation so that we don't add
it to the Database until it's completely constructed. This prevents the Database
from seeing Compilations that are being concurrently constructed.

Change the Profiler::Database itself to do locking for creation of Bytecodes and
for modifying the map. This map may be consulted by both the main thread and the
concurrent thread.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• profiler/ProfilerBytecodes.h:
• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::addCompilation):

• profiler/ProfilerDatabase.h:

(Database):

10:20 PM May 2013 Meeting - Unifying Build Systems - Notes edited by mark.salisbury@hp.com

minor edits; fixed referenced bug # (diff)

10:01 PM Changeset in webkit [149517] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix build warnings on ResourceHandleClient.h
​https://bugs.webkit.org/show_bug.cgi?id=115540

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-05-02
Reviewed by Alexey Proskuryakov.

Comment out the parameter names for 'getOrCreateReadBuffer' to fix -Wunused-parameter build warnings.

• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::getOrCreateReadBuffer):

8:29 PM May 2013 Meeting - Unifying Build Systems - Notes created by jmason@blackberry.com

8:17 PM May 2013 Meeting edited by jmason@blackberry.com

link to Unifying Build Systems notes (diff)

7:57 PM Changeset in webkit [149516] by fpizlo@apple.com

• 41 edits
  3 adds in branches/dfgFourthTier/Source

fourthTier: DFG tries to ref/deref StringImpls in a ton of places
​https://bugs.webkit.org/show_bug.cgi?id=115300

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Change any code transitively called from DFG compilation to use StringImpl*
directly instead of String, Identifier, or PropertyName. I use the convention
of passing "StringImpl* uid" instead of an Identifier or PropertyName.

Switch over any code transitively called from DFG compilation to use CStrings
whenever possible for all of its debug dumping.

This makes it possible to compile things without hitting the ref/deref
assertion in StringImpl.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
(JSC::pointerToSourceString):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dumpBytecode):

• bytecode/CodeBlock.h:

(CodeBlock):

• bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

• bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::inferredName):

• bytecode/CodeOrigin.h:

(InlineCallFrame):

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

• bytecode/GetByIdStatus.h:

(JSC):
(GetByIdStatus):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

• bytecode/PutByIdStatus.h:

(JSC):
(PutByIdStatus):

• bytecode/ReduceWhitespace.cpp:

(JSC::reduceWhitespace):

• bytecode/ReduceWhitespace.h:

(JSC):

• bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

• bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDesiredIdentifiers.cpp: Added.

(DFG):
(JSC::DFG::DesiredIdentifiers::DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::~DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::reallyAdd):

• dfg/DFGDesiredIdentifiers.h: Added.

(DFG):
(DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::numberOfIdentifiers):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::operator[]):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

• parser/SourceCode.cpp: Added.

(JSC):
(JSC::SourceCode::toUTF8):

• parser/SourceCode.h:

(SourceCode):

• profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::toJS):

• profiler/ProfilerBytecodes.h:

(JSC::Profiler::Bytecodes::inferredName):
(JSC::Profiler::Bytecodes::sourceCode):
(Bytecodes):

• runtime/Identifier.h:

(JSC::Identifier::utf8):
(JSC):

• runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

Source/WTF:

Reviewed by Geoffrey Garen.

Make it possible to do more things directly to StringImpl*'s, including being
able to directly do utf8 conversion on a substring without creating the
substring first.

Add assertions to StringImpl that it isn't being ref/deref'd from the
compilation thread.

• wtf/PrintStream.cpp:

(WTF::printInternal):
(WTF):

• wtf/PrintStream.h:

(WTF):
(WTF::printInternal):

• wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8ForRange):
(WTF::StringImpl::utf8):
(WTF):

• wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::hasAtLeastOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):

6:06 PM Changeset in webkit [149515] by roger_fong@apple.com

• 4 edits in trunk/Source

Following r149463, set Path for WebCore and WebKit makefile as well.

• WebKit.vcxproj/WebKit.make:

6:02 PM May 2013 Meeting edited by kov@webkit.org

(diff)

5:38 PM Changeset in webkit [149514] by joone.hur@intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip html5lib test cases that were skipped due to failure after r143804.

• platform/efl/TestExpectations:

5:25 PM Changeset in webkit [149513] by bfulgham@webkit.org

• 3 edits
  2 adds in trunk/Source/WTF

[WinCairo] Unreviewed build fix.

• WTF.vcxproj/WTF.vcxproj: Use WinCairo FeatureDefines
• WTF.vcxproj/WTF.vcxproj.filters: Use WinCairo FeatureDefines
• WTF.vcxproj/WTFDebugWinCairo.props: Added.
• WTF.vcxproj/WTFReleaseWinCairo.props: Added.

5:09 PM Changeset in webkit [149512] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure transition table keys don't have to ref their StringImpl's
​https://bugs.webkit.org/show_bug.cgi?id=115525

Reviewed by Geoffrey Garen.

The structure transition table basically maps string to structure. The string is
always also stored, and ref'd, in the structure in Structure::m_nameInPrevious.
m_nameInPrevious is never mutated, and never cleared. The string cannot die unless
the structure dies. If the structure dies, then that entry in the transition map
becomes a zombie anyway and we will detect this separately.

So, we don't need to use RefPtr<StringImpl>. We can just use StringImpl*.

This also fixes a goof where we were getting the StringImpl's hash rather than
using a pointer hash. Not only is the latter faster, but it prevents my change
from leading to crashes: with my change we can have zombie keys, not just zombie
values. They will exist only until the next map mutation, which will clear them.
Lookups will work fine because the lookup routine will reject zombies. But it
does mean that the HashMap will have to deal with dangling StringImpl*'s; all it
takes to make this work is to ensure that the HashMap itself never dereferences
them. Using a pointer hash rather than StringImpl::existingHash() accomplishes
this.

This also ensures that we don't accidentally call ref() or deref() from the
compilation thread, if the compilation thread inspects the transition table.

And no, we wouldn't have been able to use the HashMap<RefPtr<...>, ...>
specialization, because the transition table is actually
HashMap<pair<RefPtr<StringImpl>, unsigned>, ...>: hence that specialization
doesn't kick in. We could have written a new specialization or something, but
that seemed like a lot of work given that we don't need the table to be ref'ing
the strings anyways.

• runtime/Structure.cpp:

(JSC::StructureTransitionTable::add):

• runtime/StructureTransitionTable.h:

(StructureTransitionTable):
(Hash):
(JSC::StructureTransitionTable::Hash::hash):

5:04 PM Changeset in webkit [149511] by roger_fong@apple.com

• 2 edits in trunk/WebKitLibraries

Unreviewed Windows build fix.

• win/lib/WebKitSystemInterface.lib:

5:04 PM Changeset in webkit [149510] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

Unreviewed fix for Mac Lion build after r149503.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

5:01 PM Changeset in webkit [149509] by bfulgham@webkit.org

• 2 edits in trunk/Source/WTF

[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=115130

Reviewed by Tim Horton.

Windows is suffering from mismatched allocation/deallocation
between the system allocator and fastMalloc/fastFree. By turning
off the global switch to fastMalloc, only classes specified to
honor fastMalloc/fastFree are affected, and other memory allocation
and freeing is done with consistent library calls.

• wtf/Platform.h: Deactivate ENABLE_GLOBAL_FASTMALLOC_NEW for

the Windows build.

5:00 PM Changeset in webkit [149508] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX: Move Mac-only symbols into the shared symbol list

• WebCore.exp.in: Move symbols.

4:56 PM Changeset in webkit [149507] by Antti Koivisto

• 10 edits
  2 deletes in trunk/Source/WebCore

Shadow DOM removal: Get rid of ContentSelectorQuery
​https://bugs.webkit.org/show_bug.cgi?id=115533

Reviewed by Anders Carlsson.

This is only used for Shadow DOM distribution. <details> element works fine without it.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distributeSelectionsTo):

• html/shadow/ContentSelectorQuery.cpp: Removed.
• html/shadow/ContentSelectorQuery.h: Removed.
• html/shadow/HTMLContentElement.cpp:

4:49 PM May 2013 Meeting edited by Bem Jones-Bey

(diff)

4:39 PM Changeset in webkit [149506] by ryuan.choi@samsung.com

• 1 edit
  2 moves
  2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Moved XFrameOptions results from efl-wk2 to efl and rebased source-list-parsing-nonascii.html

• platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
• platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
• platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.

4:34 PM Changeset in webkit [149505] by joone.hur@intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip WebAudio test cases on EFL WK2.

• platform/efl-wk2/TestExpectations:

4:33 PM Changeset in webkit [149504] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

border-radius clipping a canvas does not always clip
​https://bugs.webkit.org/show_bug.cgi?id=113343

Source/WebCore:

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

clipToRect method clip context to clipRect, and then clip to rounded
rect if clipRect has a radius. But currently, clipToRect exit early if
clipToRect is equal to paintDirtyRect.

This patch allows clipping to rounded corner ever if clipToRect is
equal to paintDirtyRect.

Test: fast/overflow/border-radius-clipping-2.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

LayoutTests:

Create a test that draws a canvas into a clipped overflown div with
radius corner. Then redraw that same thing a moment later. The canvas
should stay correctly clipped the second time.

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

• fast/overflow/border-radius-clipping-2-expected.html: Added.
• fast/overflow/border-radius-clipping-2.html: Added.

4:07 PM May 2013 Meeting edited by betravis@adobe.com

(diff)

4:06 PM Changeset in webkit [149503] by eric.carlson@apple.com

• 18 edits
  2 copies in trunk

Caption menu does not include in-band captions
​https://bugs.webkit.org/show_bug.cgi?id=111934

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, upated existing tests for these changes.

• WebCore.xcodeproj/project.pbxproj: Add new files.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal): Clear the LoadMediaResource from m_pendingActionFlags

in case there is a pending async load.

(WebCore::HTMLMediaElement::configureTextTrackGroup): Always log the track score.
(WebCore::HTMLMediaElement::configureTextTracks): Call configureTextTrackDisplay so

m_legacyWebKitClosedCaptionsVisible is always updated immediately.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Use m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Ditto.

• html/HTMLMediaElement.h:

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::CaptionUserPreferences): Initialize m_displayMode to ForcedOnly

because it is no longer used for testing only.

(WebCore::CaptionUserPreferences::notify): Post notifications when not in testing-only mode.

• page/CaptionUserPreferencesMac.h:
• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate a track score when

webkitClosedCaptionsVisible has been set.

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Don't filter track list when we

don't have the media accessibility framework. Make logging more informative.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:

(WebCore::InbandTextTrackPrivateAVFObjC::create): Take a AVFInbandTrackParent instead of a

MediaPlayerPrivateAVFoundationObjC.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Added.
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm: Added.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): We only have legible output when

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT is defined.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create a legacy CC track if

there are no media selection options and there is a CC AVAssetTrack.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyCCTracks): New, process CC tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processNewAndRemovedTextTracks): New, refactored

common setup/cleanup code from processMediaSelectionOptions.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Renamed from

processTextTracks. Move common setup/cleanup code to processNewAndRemovedTextTracks.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Deal with legacy CC tracks.

Source/WTF:

• wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT on 10.8 and higher. Added

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT.

LayoutTests:

• platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
• platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

3:57 PM Changeset in webkit [149502] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] caption track menu includes "easy to read" in-band tracks twice
​https://bugs.webkit.org/show_bug.cgi?id=115529

Reviewed by Dean Jackson.

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Check to see if a track is

easy-to-read after checking if it is forced only.

3:41 PM Changeset in webkit [149501] by Antti Koivisto

• 7 edits
  1 delete in trunk/Source/WebCore

Remove SiblingTraversalStrategies.h
​https://bugs.webkit.org/show_bug.cgi?id=115532

Reviewed by Andreas Kling.

• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/SiblingTraversalStrategies.h: Removed.

3:39 PM Changeset in webkit [149500] by Lucas Forschler

• 4 edits in tags/Safari-537.40/Source/WebKit2

Merged r149499. <rdar://problem/13795795>

3:23 PM Changeset in webkit [149499] by beidson@apple.com

• 4 edits in trunk/Source/WebKit2

REGRESSION (149389) Main resources converted to downloads are immediately cancelled.
<rdar://problem/13795795> and ​https://bugs.webkit.org/show_bug.cgi?id=115530

Reviewed by Alexey Proskuryakov.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Call didConvertHandleToDownload

on the NetworkResourceLoader.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload): Set m_handleConvertedToDownload to true.
(WebKit::NetworkResourceLoader::abort): Only cancel the handle if m_handleConvertedToDownload is false.

• NetworkProcess/NetworkResourceLoader.h:

3:13 PM Changeset in webkit [149498] by Antti Koivisto

• 8 edits in trunk/Source/WebCore

Shadow DOM removal: Make SelectorChecker non-generic
​https://bugs.webkit.org/show_bug.cgi?id=115526

Reviewed by Andreas Kling.

Without Shadow DOM distribution we don't need SiblingTraversalStrategies anymore.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

• css/SelectorChecker.cpp:

(WebCore):
(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::countElementsAfter):
(WebCore::countElementsOfTypeAfter):
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

• css/SelectorChecker.h:

(SelectorChecker):

• css/SiblingTraversalStrategies.h:
• css/StyleResolver.h:

(WebCore::checkRegionSelector):

• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

• html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorDataList::checkContentSelector):

3:10 PM May 2013 Meeting edited by msaboff@apple.com

(diff)

3:09 PM May 2013 Meeting edited by msaboff@apple.com

(diff)

2:33 PM Changeset in webkit [149497] by joone.hur@intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

• platform/efl-wk2/TestExpectations:

1:59 PM Changeset in webkit [149496] by oliver@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Fix potential bug in lookup logic
​https://bugs.webkit.org/show_bug.cgi?id=115522

Reviewed by Mark Hahnenberg.

Though not a problem in practise, it is technically possible
to inject an un-proxied global object into the scope chain
via the C API. This change makes sure that the scope walk
in BytecodeGenerator actually limits itself to scopes that
are statically bindable.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

• runtime/JSObject.h:

(JSObject):
(JSC):
(JSC::JSObject::isStaticScopeObject):

1:56 PM Changeset in webkit [149495] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Simplify WebCoreObjCExtras by using WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=115524

Reviewed by Andreas Kling.

• platform/mac/WebCoreObjCExtras.mm:

(deallocCallback):
(WebCoreObjCScheduleDeallocateOnMainThread):

1:49 PM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

1:43 PM Changeset in webkit [149494] by kov@webkit.org

• 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated WebKitGTK+ Translation for Odia [or] language.
​https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

• or.po: updated translation.

1:42 PM Changeset in webkit [149493] by bfulgham@webkit.org

• 2 edits in trunk/Source/WTF

Make BloomFilter fast allocated.
​https://bugs.webkit.org/show_bug.cgi?id=115519

Reviewed by Benjamin Poulain.

• wtf/BloomFilter.h:

(BloomFilter): Make BloomFilter Fast-allocated.

1:17 PM May 2013 Meeting edited by timothy_horton@apple.com

Make the schedule words bigger! (diff)

1:00 PM Changeset in webkit [149492] by thakis@chromium.org

• 1 edit
  1 delete in trunk/Tools

Remove a stale script file.
​https://bugs.webkit.org/show_bug.cgi?id=115521

Reviewed by Anders Carlsson.

This script was added in
​https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
Bakefile system that was removed in
​https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
script just asserts when it's run and is useless.

• Scripts/update-sources-list.py: Removed.

12:27 PM May 2013 Meeting edited by cavalcantii@gmail.com

(diff)

12:26 PM Changeset in webkit [149491] by ap@apple.com

• 6 edits in trunk/Source

<rdar://problem/13740375> Non-ASCII downloaded file names are garbled when using NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=115520

Reviewed by Darin Adler.

• Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::::encodePlatformData): (CoreIPC::::decodePlatformData): Send the encoding fallback array over IPC, so that it's present when NetworkProcess does its loading.

12:17 PM May 2013 Meeting edited by cavalcantii@gmail.com

(diff)

11:33 AM May 2013 Meeting edited by rniwa@webkit.org

Remove "proposed" from both sections since they have been voted on (diff)

11:33 AM Changeset in webkit [149490] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cannot touch scroll readonly text input.
​https://bugs.webkit.org/show_bug.cgi?id=115378

Patch by Genevieve Mak <​gmak@rim.com> on 2013-05-02
Reviewed by Rob Buis.

PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

11:32 AM May 2013 Meeting edited by rniwa@webkit.org

More prune & merge (diff)

11:30 AM May 2013 Meeting edited by rniwa@webkit.org

Prune & merge (diff)

11:28 AM May 2013 Meeting edited by rniwa@webkit.org

Add back the location info. (diff)

11:25 AM May 2013 Meeting edited by Beth Dakin

(diff)

10:45 AM Changeset in webkit [149489] by Lucas Forschler

• 2 edits in tags/Safari-537.40/Source/WebKit2

Merged r149488. <rdar://problem/13787297>

9:56 AM Changeset in webkit [149488] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]
broken when second argument is nil
​https://bugs.webkit.org/show_bug.cgi?id=115505
<rdar://problem/13787297>

Reviewed by Darin Adler.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile): Pass a URL string to assumeReadAccessToBaseURL, as this is what it takes.

8:52 AM Changeset in webkit [149487] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
​https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-05-02
Reviewed by Rob Buis.

PR 308796
Debug build fix.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):

7:22 AM Changeset in webkit [149486] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit/gtk

Segmentation Fault with Romanian locale. Evolution not starting.
​https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

• webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

7:06 AM WebKit Team edited by Alexandru Chiculita

(diff)

5:49 AM Changeset in webkit [149485] by zarvai@inf.u-szeged.hu

• 14 edits
  5 adds in trunk/LayoutTests

[Qt] Unreviewed. Some more gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.png:
• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.png:
• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
• platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
• platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
• platform/qt-5.0-wk2/css3/filters/filtered-compositing-descendant-expected.txt: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.txt:
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt:
• platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt:
• platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt:
• platform/qt-5.0-wk2/svg/custom/glyph-selection-bidi-mirror-expected.txt:
• platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:

5:13 AM Changeset in webkit [149484] by zarvai@inf.u-szeged.hu

• 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r149457 and r149388.

• platform/qt/TestExpectations:
• platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

12:06 AM May 2013 Meeting edited by rniwa@webkit.org

Add myself to various talks (diff)

May 1, 2013:

11:30 PM Changeset in webkit [149483] by ryuan.choi@samsung.com

• 1 edit
  6 adds in trunk/LayoutTests

Unreviewed EFL gardening.

• platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
• platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
• platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
• platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
• platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
• platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

8:45 PM Changeset in webkit [149482] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

7:38 PM Changeset in webkit [149481] by Stephanie Lewis

• 1 edit
  1 add in trunk/LayoutTests

Update Lion results after ​http://trac.webkit.org/projects/webkit/changeset/149474

Unreviewed.

• platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.

7:10 PM Changeset in webkit [149480] by glenn@skynav.com

• 2 edits in trunk/Tools

[webkitpy] Need abstract base class for commands that analyze commit logs
​https://bugs.webkit.org/show_bug.cgi?id=115391

Reviewed by Benjamin Poulain.

Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
in preparation for adding two new commands that will reuse this functionality along with
suggest-nominations. See ​https://bugs.webkit.org/show_bug.cgi?id=115387 and
​https://bugs.webkit.org/show_bug.cgi?id=115388.

No new tests as this patch does not change existing functionality or behavior.

• Scripts/webkitpy/tool/commands/suggestnominations.py:

(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
(AbstractCommitLogCommand.init):
(AbstractCommitLogCommand._init_options):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
(SuggestNominations.init):
(SuggestNominations._init_options):

7:01 PM Changeset in webkit [149479] by Lucas Forschler

• 5 edits in tags/Safari-537.39.4/Source

Merge fix for <rdar://problem/13784241>

7:01 PM Changeset in webkit [149478] by Lucas Forschler

• 4 edits in tags/Safari-537.39.4/Source

Versioning.

6:59 PM Changeset in webkit [149477] by Lucas Forschler

• 1 copy in tags/Safari-537.39.4

New Tag.

6:54 PM Changeset in webkit [149476] by rniwa@webkit.org

• 7 edits in trunk/Source

[Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed
​https://bugs.webkit.org/show_bug.cgi?id=115463

Reviewed by Darin Adler.

Source/WebKit/mac:

Observe the default notification center for changes to autocorrection preferences.
Note system preferences may also update WebAutomatic* defaults.

• WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _shouldAutomaticTextReplacementBeEnabled]):
(+[WebView _didChangeAutomaticTextReplacementEnabled:]):
(+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]):
(+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]):
(+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
(+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
(+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]):
(+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):

Source/WebKit2:

Observe the default notification center and propagate the changes to TextCheckerState and
to all WebProcesses when system preferences are updated.

• UIProcess/TextChecker.h:
• UIProcess/WebContext.h:
• UIProcess/mac/TextCheckerMac.mm:

(WebKit::shouldAutomaticTextReplacementBeEnabled):
(WebKit::shouldAutomaticSpellingCorrectionBeEnabled):
(WebKit::shouldAutomaticQuoteSubstitutionBeEnabled):
(WebKit::shouldAutomaticDashSubstitutionBeEnabled):
(WebKit::initializeState):
(WebKit::TextChecker::didChangeAutomaticTextReplacementEnabled):
(WebKit::TextChecker::didChangeAutomaticSpellingCorrectionEnabled):
(WebKit::TextChecker::didChangeAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::didChangeAutomaticDashSubstitutionEnabled):

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::registerNotificationObservers):
(WebKit::WebContext::unregisterNotificationObservers):

6:53 PM Changeset in webkit [149475] by Lucas Forschler

• 1 copy in tags/Safari-537.40

New Tag.

6:48 PM Changeset in webkit [149474] by enrica@apple.com

• 3 edits
  3 adds in trunk

text-combine: horizontal does not work properly for some fonts.
​https://bugs.webkit.org/show_bug.cgi?id=115503.

Reviewed by Dave Hyatt.

Source/WebCore:

For some fonts that don't have width variants, we fail to combine glyphs
because we believe they don't fit. That decision is made comparing the run width
with the font computed size multiplied by a margin factor.
I've increased the margin from 10% to 15%.

Test: fast/text/text-combine-different-fonts.html

• rendering/RenderCombineText.cpp:

LayoutTests:

• fast/text/text-combine-different-fonts.html: Added.
• platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
• platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.

6:30 PM Changeset in webkit [149473] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[GTK] Fix build break after r149449
​https://bugs.webkit.org/show_bug.cgi?id=115500

Reviewed by Gustavo Noronha Silva.

Unreviewed GTK build fix

• GNUmakefile.list.am: Added LocalStorageDatabase.[cpp|h] to the list of

sources.

6:22 PM Changeset in webkit [149472] by msaboff@apple.com

• 2 edits in trunk/Source/WTF

FastMalloc.cpp should use system defined page size instead of literal constant
​https://bugs.webkit.org/show_bug.cgi?id=115502

Reviewed by Geoffrey Garen.

Updated kPageShift to be PAGE_SHIFT for Mac. Changed kMaxSize to be fixed at 32K.
Updated kNumClasses for 4K and 16K page sizes.

• wtf/FastMalloc.cpp:

kPageShift: Changed this to be PAGE_SHIFT on mac.

6:09 PM Changeset in webkit [149471] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream smart selection
​https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-05-01
Reviewed by Rob Buis.

Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
caused crash.
But viewport from webkitThreadViewportAccessor uses unadjusted size which is
wrong for email.
The solution here is to get actual viewport size on UI thread and then pass it
to WebKit::SelectionHandler.

PR 333763
Reviewed Internally By Jakob Petsovits.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
(WebKit):

• Api/WebPage.h:
• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):

• WebKitSupport/SelectionHandler.h:

(BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
(BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
(SelectionHandler):

6:07 PM Changeset in webkit [149470] by Stephanie Lewis

• 1 edit
  3 adds in trunk/LayoutTests

Update Lion results after ​http://trac.webkit.org/projects/webkit/changeset/149450

Unreviewed.

• platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.png: Added.
• platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.

5:40 PM Changeset in webkit [149469] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Null check plugInClient earlier in snapshotting path
​https://bugs.webkit.org/show_bug.cgi?id=115498

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-01
Reviewed by Darin Adler.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

5:39 PM Changeset in webkit [149468] by commit-queue@webkit.org

• 4 edits in trunk

Web Inspector: Fix check-inspector-strings script and fix localized strings
​https://bugs.webkit.org/show_bug.cgi?id=115495

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, because there is no change in behavior.

• English.lproj/localizedStrings.js:

Tools:

• Scripts/check-inspector-strings:

5:38 PM Changeset in webkit [149467] by Martin Robinson

• 2 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate what happens when JavaScript is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115492

Reviewed by Xan Lopez.

• UIProcess/API/gtk/WebKitWebView.cpp: Clarify the documentation.

5:15 PM Changeset in webkit [149466] by timothy_horton@apple.com

• 3 edits
  2 adds in trunk

<object data="<some data URL>"> MIME types aren't case-insensitive
​https://bugs.webkit.org/show_bug.cgi?id=115494

Reviewed by Darin Adler.

Test: fast/images/object-data-url-case-insensitivity.html

MIME types are defined to be case-insensitive, but many places in WebCore
only compare them against lower-case strings. Most entry points for MIME
types lower-case them, but mimeTypeFromDataURL doesn't, causing, for example,
data:image/png;... to work, but data:iMaGe/PNG;... to fail.

To fix this, lower-case the string returned from mimeTypeFromDataURL.

• platform/KURL.cpp:

(WebCore::mimeTypeFromDataURL):

Add a testcase that ensures that iMaGe/PNG == image/png when it comes to
the MIME type specified in a data URL provided to <object> via its
'data' attribute.

• fast/images/object-data-url-case-insensitivity-expected.html: Added.
• fast/images/object-data-url-case-insensitivity.html: Added.

5:02 PM Changeset in webkit [149465] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

[Mac] Text replacement should use correction indicator
​https://bugs.webkit.org/show_bug.cgi?id=115471

Reviewed by Darin Adler.

Support autocorrection panel for text replacements by making AlternativeTextTypeCorrection
handle text replacements as well as automatic spelling correction.

No new tests. Unfortunately this feature is not testable as is. We need to provide some
internals or testRunner methods to make this feature testable in the long term.

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired): Trigger both TextCheckingTypeReplacement
and TextCheckingTypeShowCorrectionPanel.

• editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor): Autocorrection panel maybe used for both
TextCheckingTypeReplacement and TextCheckingTypeShowCorrectionPanel.

4:46 PM Changeset in webkit [149464] by timothy_horton@apple.com

• 14 edits in trunk/Source

Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=115487

Reviewed by Darin Adler.

No new tests, just a refactoring.

• UIProcess/WebContext.cpp:
• UIProcess/WebContext.h:

Remove pdfAndPostScriptMIMETypes.

• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType): Move PDF bits to WebPageProxy.
(WebKit::WebFrameProxy::isDisplayingPDFDocument):
Make use of WebCore's newfound knowledge of PDF and PostScript MIME types,
so we don't have to duplicate it unnecessarily in WebKit2.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):
Add code which used to be in WebFrameProxy::canShowMIMEType, and adapt it
to use WebCore's knowledge of PDF and PostScript MIME types.

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(WebKit::SimplePDFPlugin::pluginInfo):
We previously supported the "text/pdf" MIME type for PDFViewController,
so SimplePDFPlugin and PDFPlugin should support it as well.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType.

• WebProcess/WebPage/WebPage.h:

(WebPage):
Remove pdfAndPostScriptMIMETypes.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange):
Adopt getPDFAndPostScriptMIMETypes instead of duplicating the list in WebKit2.

• WebCore.exp.in:

Export newly-added isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType instead of duplicating
the list of MIME types. The previous list did not include PostScript, but
it seems reasonable to put plugins ahead of built-in support for it in addition to PDF.

• platform/MIMETypeRegistry.cpp:

(WebCore::initializePDFAndPostScriptMIMETypes): Added.
(WebCore::initializeMIMETypeRegistry): Call initializePDFAndPostScriptMIMETypes.
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):
Consult our new HashSet to see if the given MIME type is one of those used for PDF or PS.

(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Added.

• platform/MIMETypeRegistry.h:

(MIMETypeRegistry): Add isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

4:28 PM Changeset in webkit [149463] by roger_fong@apple.com

• 4 edits in trunk/Source

Set Path in makefile for AppleWin.

• JavaScriptCore.vcxproj/JavaScriptCore.make:

4:20 PM Changeset in webkit [149462] by Lucas Forschler

• 4 edits in tags/Safari-537.39.3/Source

Versioning.

4:17 PM Changeset in webkit [149461] by Lucas Forschler

• 1 copy in tags/Safari-537.39.3

New Tag.

4:17 PM Changeset in webkit [149460] by andersca@apple.com

• 4 edits in trunk/Source

Implement LocalStorageDatabase::importItems
​https://bugs.webkit.org/show_bug.cgi?id=115493

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

Fetch items and insert them in the storage map.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::importItems):

4:01 PM Changeset in webkit [149459] by fpizlo@apple.com

• 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115468

Reviewed by Geoffrey Garen.

This makes the main thread modify the transition table while holding a lock. Note
that the GC might modify its weak pointers without locking, but the GC will lock out
the compilation thread anyway. The map will then only reshape in response to add()
and set(), which happen while holding a lock.

This allows the compilation thread to now query transition tables safely, provided it
holds a lock when doing so.

Also changed LLVM asm printer initialization to just initialize the X86 one. It makes
sense for us to just initialize the asm printer(s) that we actually use; you could
imagine us being linked to a system LLVM that has cross-compilation support; there is
no point in the WebKit or JSC process doing work to initialize all of those targets.
That part was rubber stamped by Mark Hahnenberg.

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

• runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):

• runtime/Structure.h:

(Structure):

3:38 PM Changeset in webkit [149458] by andersca@apple.com

• 7 edits in trunk/Source

Begin work on loading items from the local storage database
​https://bugs.webkit.org/show_bug.cgi?id=115489

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols and SQLite headers needed.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Some of the LocalStorageDatabase code is originally from WebCore,
but has been simplified due to the fact that we don't need to load
database data asynchronously since we're already running on a non-main thread.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
(WebKit::LocalStorageDatabase::openDatabase):
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
(WebKit::LocalStorageDatabase::migrateItemTableIfNeeded):
(WebKit::LocalStorageDatabase::importItems):

• UIProcess/Storage/LocalStorageDatabase.h:

(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::items):
Call importItemsFromDatabase().

(WebKit::StorageManager::StorageArea::importItemsFromDatabase):
Ask the database to import the items.

3:01 PM Changeset in webkit [149457] by hmuller@adobe.com

• 19 edits in trunk

[CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115455

Source/WebCore:

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off.

Reviewed by Dirk Schulze.

• rendering/ExclusionPolygon.cpp:

(WebCore::appendArc): Ensure that the 3rd of 5 added vertices is in the center of the arc.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Use ceiledLayoutUnit() for downwards-snapping first fit location.

• rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): Ditto.

LayoutTests:

Reviewed by Dirk Schulze.

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off. This set of changes just restores four tests. It also revises
the subpixel-utils code to bring it into line with the most recent LayoutUnit et al changes
and to simplify its use a little.

• fast/exclusions/resources/rounded-rectangle.js:

(simulateShape): Revised dependencies on subpixel-utils.

• fast/exclusions/resources/simple-polygon.js:

(polygonXIntercepts): Ditto.

• fast/exclusions/resources/subpixel-utils.js:

(SubPixelLayout.): Substantially revised, see description.

• fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt:
• fast/exclusions/shape-inside/shape-inside-polygon-layout.html:
• fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.txt:
• fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html:
• fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt:
• fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
• fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
• fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
• fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
• platform/mac/TestExpectations:

2:50 PM Changeset in webkit [149456] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed buildfix after r149449.

• CMakeLists.txt:

2:36 PM Changeset in webkit [149455] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure::getConcurrently() may be called from for uncacheable dictionaries, and this is safe
​https://bugs.webkit.org/show_bug.cgi?id=115464

Reviewed by Oliver Hunt and Geoffrey Garen.

This can happen for example transitively from JSObject::put(). getCurrently() does
work for uncacheable dictionaries; it just has the obvious race that right after it
returns, the result it returned may no longer be right. This isn't an issue if it was
called on the main thread, and may not be an issue in some other situations.

So, we should just remove the assertion, since the only thing it buys us is crashes.

• runtime/Structure.cpp:

(JSC::Structure::getConcurrently):

2:22 PM Changeset in webkit [149454] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit/mac

Fix the function names of r149453

Unreviewed.

I forgot to follow one of Darin's review comment. This patch
fixes the function names to follow CF naming conventions.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-01

• WebView/WebHTMLRepresentation.mm:

(newArrayWithStrings):
(newArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

2:02 PM Changeset in webkit [149453] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit/mac

Simplify WebHTMLRepresentation supportedMIMETypes methods
​https://bugs.webkit.org/show_bug.cgi?id=115314

Reviewed by Darin Adler.

The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL.
First, a new pointer was allocated on the heap with fast malloc (for RetainPtr<NSArray>).
Then a new NSMutableArray was allocated but immediately put on the autorelease pool.
Finally, that array was retained by the RetainPtr.

This patch changes the code to only leak the NSMutableArray memory. There
is no fastMalloc, nor any use of the autorelease pool.

• WebView/WebHTMLRepresentation.mm:

(createArrayWithStrings):
(createArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

1:58 PM Changeset in webkit [149452] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149449.

• Target.pri:

1:52 PM Changeset in webkit [149451] by benjamin@webkit.org

• 2 edits
  2 deletes in trunk

Remove the remaining wscript
​https://bugs.webkit.org/show_bug.cgi?id=115459

Reviewed by Andreas Kling.

.:

• wscript: Removed.

Source/JavaScriptCore:

• wscript: Removed.

1:37 PM Changeset in webkit [149450] by enrica@apple.com

• 3 edits
  3 adds in trunk

Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box.
​https://bugs.webkit.org/show_bug.cgi?id=115478.

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/block/lineboxcontain/block-with-ideographs.xhtml

When computing ascent and descent we need to take into account
the baseline type. RootInlineBox::ascentAndDescentForBox failed
to do that in few cases.

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

LayoutTests:

• fast/block/lineboxcontain/block-with-ideographs.xhtml: Added.
• platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
• platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png : Added.

1:28 PM Changeset in webkit [149449] by andersca@apple.com

• 5 edits
  2 adds in trunk/Source

Add LocalStorageDatabase class
​https://bugs.webkit.org/show_bug.cgi?id=115486

Reviewed by Sam Weinig.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

The LocalStorageDatabase class will persist local storage data to disk.

• UIProcess/Storage/LocalStorageDatabase.cpp:
• UIProcess/Storage/LocalStorageDatabase.h: Added.

• UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::LocalStorageNamespace::storageManager):
Add getter.

(StorageManager::LocalStorageNamespace):
(WebKit::StorageManager::StorageArea::StorageArea):
If this is a local storage area, create a LocalStorageDatabase.

(WebKit::StorageManager::LocalStorageNamespace::databaseFilename):
Helper function for getting the name of the database for the given origin.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

12:57 PM Changeset in webkit [149448] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
​https://bugs.webkit.org/show_bug.cgi?id=115289

Reviewed by Jer Noble.

No new tests, this is a speculative fix for an infrequent assertion.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackRemoveCue): Mark the cue as inactive when it is removed

from the active set.

12:55 PM Changeset in webkit [149447] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

TextTrackMenu crashes in ports where MediaElement players are lazily created
​https://bugs.webkit.org/show_bug.cgi?id=115485

Null check the player for ports, like iOS, that lazily create the player.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-01
Reviewed by Eric Carlson.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::platformTextTrackMenu):
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):

12:10 PM Changeset in webkit [149446] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
​https://bugs.webkit.org/show_bug.cgi?id=115470

Reviewed by Martin Robinson.

In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
not building either of the IOS, Windows or GTK-WK1 platforms.

Up until now the header was included for everything but the IOS and Windows platforms due to
an incorrectly stated condition regarding the GTK platform.

• TestWebKitAPI/config.h:

12:09 PM Changeset in webkit [149445] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=115469

Reviewed by Martin Robinson.

Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
for the WebKit2 tests and the injected bundle required by them.

This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
under the WebKit2 code).

The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.

• TestWebKitAPI/GNUmakefile.am:

11:59 AM Changeset in webkit [149444] by andersca@apple.com

• 9 edits
  2 adds in trunk/Source

Add FunctionDispatcher class and make RunLoop derive from it
​https://bugs.webkit.org/show_bug.cgi?id=115480

Reviewed by Sam Weinig.

Source/WebCore:

Change RunLoop to be a subclass of FunctionDispatcher.

• platform/RunLoop.h:

(RunLoop):

Source/WTF:

Add FunctionDispatcher files.

• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.xcodeproj/project.pbxproj:
• wtf/FunctionDispatcher.cpp: Added.

(WTF::FunctionDispatcher::FunctionDispatcher):
(WTF::FunctionDispatcher::~FunctionDispatcher):

• wtf/FunctionDispatcher.h: Added.

11:55 AM Changeset in webkit [149443] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
​https://bugs.webkit.org/show_bug.cgi?id=81856

Reviewed by Jer Noble.

No new tests, covered by existing tests.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there

is obviously no work to be done.

11:32 AM Writing Layout Tests for DumpRenderTree edited by achristensen@apple.com

made example test pass (diff)

11:26 AM Changeset in webkit [149442] by ap@apple.com

• 4 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

11:14 AM Changeset in webkit [149441] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13781156> Launching NetworkProcess broken on some OS versions.

Reviewed by Anders Carlsson.

Adapt to LaunchServices changes.

• Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::setApplicationIsDaemon):

11:10 AM Changeset in webkit [149440] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
​https://bugs.webkit.org/show_bug.cgi?id=114394

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-05-01
Reviewed by Anders Carlsson.

Add a setting to control accelerated 2D canvas, which determines whether
or not to consider rendering HTML canvas with hardware acceleration.

• UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added support for enable-accelerated-2d-canvas property.
(webKitSettingsGetProperty): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_class_init): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_get_enable_accelerated_2d_canvas): Added.
(webkit_settings_set_enable_accelerated_2d_canvas): Added.

• UIProcess/API/gtk/WebKitSettings.h: New methods.
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to the documentation.
• UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Added a simple test for the setting.

10:45 AM Changeset in webkit [149439] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Entering full screen mode shows desktop linen instead of WKView the first time.
​https://bugs.webkit.org/show_bug.cgi?id=115433
<rdar://problem/13774540>

Reviewed by Eric Carlson.

For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.

• UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

10:38 AM Changeset in webkit [149438] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Closed caption lines overlap
​https://bugs.webkit.org/show_bug.cgi?id=115438
<rdar://problem/13351747>

Reviewed by Eric Carlson.

Take the line-box padding into account when determining line hight by setting
the -webkit-line-box-contain property to include 'inline-box'.

• css/mediaControls.css:

(video::-webkit-media-text-track-container):

10:29 AM Changeset in webkit [149437] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr<CFRunLoopRef>

Fixes the following build failure:

WebCore/platform/cf/RunLoopCF.cpp:82:5: error: no matching function for call to 'CFRunLoopStop'

CFRunLoopStop(m_runLoop);

• platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::stop): Call RetainPtr::get().

10:15 AM Changeset in webkit [149436] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

EventSource: Loss of reconnect time precision due to integer division
​https://bugs.webkit.org/show_bug.cgi?id=115358

Source/WebCore:

Make sure precision is not lost when converting the reconnect time from milliseconds to seconds.

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-retry-precision.html

• page/EventSource.cpp:

(WebCore::EventSource::scheduleReconnect):

LayoutTests:

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

• http/tests/eventsource/eventsource-retry-precision-expected.txt: Added.
• http/tests/eventsource/eventsource-retry-precision.html: Added.
• http/tests/eventsource/resources/precise-retry.asis: Added.

9:55 AM Changeset in webkit [149435] by akling@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
<​http://webkit.org/b/115386>
<rdar://problem/13769995>

Reviewed by Antti Koivisto.

Only send synchronous resize events for the main frame. Subframes change size during layout,
so it never really makes sense for them to use synchronous dispatch anyway.

• page/FrameView.cpp:

(WebCore::FrameView::dispatchResizeEvent):

8:47 AM Changeset in webkit [149434] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed trivial buildfix after r149432.

• testing/Internals.cpp:

(WebCore):

7:25 AM Changeset in webkit [149433] by zarvai@inf.u-szeged.hu

• 6 edits in trunk/Source

[Qt][Win] Fix build after r149416.
​https://bugs.webkit.org/show_bug.cgi?id=115474

Reviewed by Anders Carlsson.

Source/WebKit2:

• Platform/CoreIPC/Connection.h:

(Connection):

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::dispatchSentMessagesUntil):

Source/WTF:

• WTF.pro:
• wtf/threads/BinarySemaphore.h:

(BinarySemaphore):

7:17 AM Changeset in webkit [149432] by sergio@webkit.org

• 17 edits
  2 adds in trunk

Show a block cursor in overtype mode
​https://bugs.webkit.org/show_bug.cgi?id=114819

Reviewed by Ryosuke Niwa.

.:

• Source/autotools/symbols.filter: export some extra symbols for

testing purposes.

Source/WebCore:

Test: editing/selection/block-cursor-overtype-mode.html

Overtype mode will use block cursor instead of a caret to
highlight the next character to be replaced. It will fully cover
the next character to be replaced (except at the end of a line
where the usual blinking caret will be shown).

This new block cursor is internally implemented as a selection
(not exposed to JavaScript) because the selection code knows how
to deal with bidi text.

• WebCore.exp.in: Export symbols for testing purposes.
• WebCore.order: Ditto.
• editing/Editor.cpp:

(WebCore::Editor::toggleOverwriteModeEnabled): Added a call to
FrameLoader::setShouldShowBlockCursor.
(WebCore):

• editing/Editor.h:

(Editor):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::updateAppearance): Use a 1-character
long selection to paint the cursor in overtype mode.
(WebCore::FrameSelection::setShouldShowBlockCursor):
(WebCore):

• editing/FrameSelection.h:

(WebCore::FrameSelection::shouldShowBlockCursor):
(FrameSelection):

• testing/Internals.cpp:

(WebCore):
(WebCore::Internals::selectionBounds): Added a new method which
returns the IntRect issued by FrameSelection::bounds().

• testing/Internals.h: Ditto.
• testing/Internals.idl: Ditto.

Source/WebKit:

Export three more WebCore symbols.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Export three more WebCore symbols.

• WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

New test case for the new block cursor to be used in overtype
mode. The test verifies that the 1-pixel long caret is replaced by
a selection like 1-character long block cursor when in overtype
mode. This test covers LTR and RTL text in LTR and RTL blocks and
bidi text.

• editing/selection/block-cursor-overtype-mode-expected.txt: Added.
• editing/selection/block-cursor-overtype-mode.html: Added.

4:22 AM Changeset in webkit [149431] by sergio@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r149417.

• GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of

sources.

3:14 AM Changeset in webkit [149430] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed buildfix after r149416 and r149417.

Unreviewed build fix.

• CMakeLists.txt:

1:43 AM Changeset in webkit [149429] by zarvai@inf.u-szeged.hu

• 4 edits in trunk/Source

Source/WebKit2: [Qt] Unreviewed buildfix after r149416 and r149417.

• Target.pri:

Source/WTF: [Qt] Unreviewed buildfix after r149416.

• WTF.pro:

Apr 30, 2013:

11:59 PM Changeset in webkit [149428] by dw.im@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed, EFL build fix after r149416
​https://bugs.webkit.org/show_bug.cgi?id=115467

Unreviewed build fix.

• CMakeLists.txt: Remove non-existing file, BinarySemaphore.cpp, from the list.

11:08 PM Changeset in webkit [149427] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

ipc-posix-shm backwards compatibility
​https://bugs.webkit.org/show_bug.cgi?id=115448
<rdar://problem/13743037>

Patch by Simon Cooper <​scooper@apple.com> on 2013-04-30
Reviewed by Alexey Proskuryakov.

Add compatibility for older ipc-posix-shm operations, but prefer the
newer names when writing profiles.

• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

10:49 PM Changeset in webkit [149426] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Tools

fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no

Rubber stamped by Mark Rowe.

• Scripts/copy-webkitlibraries-to-product-directory:

10:48 PM Changeset in webkit [149425] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Don't link gtest into JavaScriptCore

Rubber stamped by Mark Rowe.

• Configurations/JavaScriptCore.xcconfig:

10:42 PM Changeset in webkit [149424] by Philippe Normand

• 2 edits in trunk/Source/WebKit2

Unreviewed, GTK build fix after r149416.

• GNUmakefile.list.am: Remove references to non-existant

BinarySemaphore module.

10:19 PM Changeset in webkit [149423] by Darin Adler

• 6 edits in trunk/Source

[Mac] Remove adoptNS/retain pairs, since the two cancel each other out
​https://bugs.webkit.org/show_bug.cgi?id=115426

Reviewed by Anders Carlsson.

Source/WebCore:

• platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::PlatformCAAnimation):

• platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::filterValueForOperation):

• platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::nsURLResponse):
Remove adoptNS and release from code that is doing both.

Source/WebKit/mac:

• Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::deliverDataToFile): Remove adoptNS and release.

10:16 PM Changeset in webkit [149422] by ap@apple.com

• 7 edits in trunk/Source/WebKit2

<rdar://problem/13574729> Implement file path restrictions in WebKit Objective C API
​https://bugs.webkit.org/show_bug.cgi?id=115321

Reviewed by Darin Adler.

• UIProcess/API/C/WKPage.cpp:
• UIProcess/API/C/WKPage.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile):
• UIProcess/WebPageProxy.h: Added and implemented a C API to load a file while only opening sandbox for a specific directory.

• UIProcess/API/mac/WKBrowsingContextController.h: Fixed a typo in a comment.

• UIProcess/API/mac/WKBrowsingContextController.mm: (-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]): Respect allowedDirectory argument. Updated the function to raise an exception for incorrect input, as decribed in header file.

9:58 PM Changeset in webkit [149421] by glenn@skynav.com

• 2 edits in trunk/Tools

Unreviewed. Add myself to watchlist entries.

• Scripts/webkitpy/common/config/watchlist:

7:38 PM Changeset in webkit [149420] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
VM watchdog if its client did not pass one in.
​https://bugs.webkit.org/show_bug.cgi?id=115461.

Reviewed by Geoffrey Garen.

• API/JSContextRef.cpp:

(internalScriptTimeoutCallback):
(JSContextGroupSetExecutionTimeLimit):

• API/tests/testapi.c:

(main):

• Added test case when the time limit callback is 0.
• Also updated a check to verify that a TerminatedExecutionException is thrown when the time out is cancelled.
• Also fixed some cosmetic typos.

7:29 PM Changeset in webkit [149419] by glenn@skynav.com

• 3 edits in trunk/Tools

[webkitpy] suggest-nominations doesn't count all qualified patches
​https://bugs.webkit.org/show_bug.cgi?id=115285

Reviewed by Benjamin Poulain.

Fix commit analysis so that patches made by an existing committer are counted towards reviewer
nomination. Improve commit log parsing.

• Scripts/webkitpy/tool/commands/suggestnominations.py:

(CommitLogError):
(CommitLogError.init):
(CommitLogMissingReviewer):
(CommitLogMissingReviewer.init):
(SuggestNominations):
(SuggestNominations.init):
(SuggestNominations._recent_commit_messages):
(SuggestNominations._author_name_from_email):
(SuggestNominations._contributor_from_email):
(SuggestNominations._parse_commit_message):
(SuggestNominations._count_commit):
(SuggestNominations._count_recent_patches):
(SuggestNominations._collect_nominations):
(SuggestNominations._print_nominations):
(SuggestNominations.execute):

• Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:

(_make_options):
(test_recent_commit_messages):
(test_basic):

6:58 PM Changeset in webkit [149418] by ggaren@apple.com

• 13 edits in trunk/Source/JavaScriptCore

Removed op_ensure_property_exists
​https://bugs.webkit.org/show_bug.cgi?id=115460

Reviewed by Mark Hahnenberg.

It was unused, and whatever it was once used for was not optimized.

• JavaScriptCore.order:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JIT.h:
• jit/JITOpcodes.cpp:
• jit/JITOpcodes32_64.cpp:
• jit/JITStubs.cpp:
• jit/JITStubs.h:
• llint/LLIntSlowPaths.cpp:
• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:

6:48 PM May 2013 Meeting edited by timothy@apple.com

(diff)

6:24 PM Changeset in webkit [149417] by weinig@apple.com

• 14 edits
  7 adds in trunk/Source

Add API to allow WebKit2 banners to get mouse events
​https://bugs.webkit.org/show_bug.cgi?id=115395

Reviewed by Beth Dakin.

Source/WebCore:

• WebCore.exp.in:
• platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToTotalContents):

• platform/ScrollView.h:

Add and expose rootViewToTotalContents().

Source/WebKit2:

• Shared/API/c/WKBase.h:
• Shared/APIObject.h:

Add banner type.

• WebKit2.xcodeproj/project.pbxproj:

Add files.

• WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Add conversion.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetTopOverhangImage):
(WKBundlePageSetBottomOverhangImage):
Fix parameter names to be consistent.

(WKBundlePageSetHeaderBanner):
(WKBundlePageSetFooterBanner):

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageBanner.cpp: Added.

(WKBundlePageBannerGetTypeID):

• WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h: Added.
• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.h: Added.
• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm: Added.

(PageBannerClientImpl):
(PageBannerClientImpl::create):
(PageBannerClientImpl::PageBannerClientImpl):
(PageBannerClientImpl::pageBannerDestroyed):
(PageBannerClientImpl::mouseEvent):
(WKBundlePageBannerCreateBannerWithCALayer):
(WKBundlePageBannerGetLayer):
Add banner API.

• WebProcess/WebPage/PageBanner.h: Added.
• WebProcess/WebPage/PageBanner.cpp: Added.

(WebKit::PageBanner::~PageBanner):
(WebKit::PageBanner::addToPage):
(WebKit::PageBanner::detachFromPage):
(WebKit::PageBanner::didChangeDeviceScaleFactor):
(WebKit::PageBanner::mouseEvent):
Add non-mac implementations.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::WebPage::setHeaderPageBanner):
(WebKit::WebPage::headerPageBanner):
(WebKit::WebPage::setFooterPageBanner):
(WebKit::WebPage::footerPageBanner):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

• WebProcess/WebPage/WebPage.h:

Add banner setter/getters and give the banners a chance to handle mouse events.

• WebProcess/WebPage/mac/PageBannerMac.mm: Added.

(WebKit::PageBanner::create):
(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::addToPage):
(WebKit::PageBanner::detachFromPage):
(WebKit::PageBanner::didChangeDeviceScaleFactor):
(WebKit::PageBanner::mouseEvent):
(WebKit::PageBanner::layer):
Add Mac implementation.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):
Notify banners when the device scale changes.

5:41 PM May 2013 Meeting edited by Brian Burg

add record/replay session (diff)

5:27 PM Changeset in webkit [149416] by andersca@apple.com

• 7 edits
  2 deletes in trunk/Source

Remove the WebKit2 BinarySemaphore class
​https://bugs.webkit.org/show_bug.cgi?id=115458

Reviewed by Benjamin Poulain.

Source/WebKit2:

Remove the WK2 specific BinarySemaphore class and use the one from WTF.

• Platform/CoreIPC/BinarySemaphore.cpp: Removed.
• Platform/CoreIPC/BinarySemaphore.h: Removed.
• Platform/CoreIPC/Connection.cpp:
• Platform/CoreIPC/Connection.h:
• WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

• wtf/Forward.h:

Add BinarySemaphore forward declaration.

• wtf/threads/BinarySemaphore.h:

Add WTF_EXPORT_PRIVATE to declarations.

5:02 PM Changeset in webkit [149415] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Make RunLoop ref-counted
​https://bugs.webkit.org/show_bug.cgi?id=115384

Reviewed by Benjamin Poulain.

Add a RunLoop::Holder class which creates and holds the ref-counted RunLoop object.

• platform/RunLoop.cpp:

(RunLoop::Holder):
(WebCore::RunLoop::Holder::Holder):
(WebCore::RunLoop::Holder::runLoop):
(WebCore::RunLoop::current):

• platform/RunLoop.h:

5:00 PM Changeset in webkit [149414] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13757475> WebProcess deny ipc-posix-shm-read-data CFPBS:A2:

Reviewed by Anders Carlsson.

• WebProcess/com.apple.WebProcess.sb.in: Allow pbs shared memory.

4:58 PM Changeset in webkit [149413] by ap@apple.com

• 13 edits in trunk/Source/WebKit2

[Mac] Don't open window server connection in network process
​https://bugs.webkit.org/show_bug.cgi?id=115446

Reviewed by Anders Carlsson.

• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeProcess):
• NetworkProcess/NetworkProcess.h:
• NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeProcess): (WebKit::NetworkProcess::initializeProcessName): Instead of shutting down a connection after setting process name, just prevent it from being created.

• Shared/ChildProcess.h:
• Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::setApplicationIsDaemon): Expose a function for client processes to call if they don't run an NSApplication run loop.

• OfflineStorageProcess/OfflineStorageProcess.cpp: (WebKit::OfflineStorageProcess::initializeProcess):
• OfflineStorageProcess/OfflineStorageProcess.h:
• OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: (WebKit::OfflineStorageProcess::initializeProcess): (WebKit::OfflineStorageProcess::initializeProcessName):
• SharedWorkerProcess/SharedWorkerProcess.cpp: (WebKit::SharedWorkerProcess::initializeProcess): (WebKit::SharedWorkerProcess::initializeProcessName):
• SharedWorkerProcess/SharedWorkerProcess.h:
• SharedWorkerProcess/mac/SharedWorkerProcessMac.mm: (WebKit::SharedWorkerProcess::initializeProcess): (WebKit::SharedWorkerProcess::initializeProcessName): Match NetworkProcess for consistency.

• WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::initializeProcessName): Don't null check UI process name. First, it can't be null, and second, some other processes already don't have this check.

4:40 PM Changeset in webkit [149412] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cannot touch scroll readonly text input.
​https://bugs.webkit.org/show_bug.cgi?id=115378

Patch by Genevieve Mak <​gmak@rim.com> on 2013-04-30
Reviewed by Rob Buis.

PR #332902
Reviewed Internally by Mike Fenton.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
(DOMSupport):

• WebKitSupport/DOMSupport.h:
• WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

4:35 PM Changeset in webkit [149411] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/WebKitLibraries

Updated LLVM drops to include MCJIT fixes and newly exposed API.

Rubber stamped by Mark Hahnenberg.

• LLVMIncludesMountainLion.tar.bz2:
• LLVMLibrariesMountainLion.tar.bz2:

4:34 PM Changeset in webkit [149410] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Clean up RunLoop code
​https://bugs.webkit.org/show_bug.cgi?id=115454

Reviewed by Andreas Kling.

Delete a couple of functions from RunLoopCF.cpp and just use the generic ones in RunLoop.cpp,
use RetainPtr instead of manual retain/release. Always use an AutoreleasePool when calling performWork or timers.

• platform/RunLoop.cpp:

(WebCore::RunLoop::setUseApplicationRunLoopOnMainRunLoop):
(WebCore):

• platform/RunLoop.h:

(TimerBase):
(RunLoop):

• platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::performWork):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::TimerBase):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):
(WebCore::RunLoop::TimerBase::isActive):

• platform/mac/RunLoopMac.mm:

(WebCore::RunLoop::run):
(WebCore::RunLoop::stop):

3:53 PM Changeset in webkit [149409] by rniwa@webkit.org

• 2 edits in trunk/Source/WTF

Unreviewed, rolling out r149408.
​http://trac.webkit.org/changeset/149408
​https://bugs.webkit.org/show_bug.cgi?id=115453

Broke Windows Build (Requested by bfulgham on #webkit).

• wtf/Platform.h:

3:44 PM Changeset in webkit [149408] by bfulgham@webkit.org

• 2 edits in trunk/Source/WTF

[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=115130

Reviewed by Tim Horton.

Windows is suffering from mismatched allocation/deallocation
between the system allocator and fastMalloc/fastFree. By turning
off the global switch to fastMalloc, only classes specified to
honor fastMalloc/fastFree are affected, and other memory allocation
and freeing is done with consistent library calls.

• wtf/Platform.h: Deactivate ENABLE_GLOBAL_FASTMALLOC_NEW for

the Windows build.

3:39 PM Changeset in webkit [149407] by hyatt@apple.com

• 5 edits
  2 adds in trunk

<button> ignores margin-bottom.
​https://bugs.webkit.org/show_bug.cgi?id=114940

Reviewed by Beth Dakin.

Source/WebCore:

Make sure that the inner block inside the <button> (flexbox) acts like it
establishes a block formatting context, i.e., it should refuse to collapse
its margins with its children. This causes margins to stay inside the <button>
and be honored, adding to the button's overall height.

Basically we have to remove the restriction that anonymous blocks can't be
BFCs on the bottom margin.

Added fast/forms/content-with-margins-inside-button.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleAfterSideOfBlock):

LayoutTests:

• fast/forms/content-with-margins-inside-button-expected.html: Added.
• fast/forms/content-with-margins-inside-button.html: Added.

3:29 PM Changeset in webkit [149406] by fpizlo@apple.com

• 2 edits
  12 adds in trunk/Websites/webkit.org

Release SunSpider 1.0

Rubber stamped by Maciej Stachowiak.

• perf/sunspider-1.0: Added.
• perf/sunspider-1.0/json2.js: Added.

(.):

• perf/sunspider-1.0/sunspider-1.0: Added.
• perf/sunspider-1.0/sunspider-1.0/driver.html: Added.
• perf/sunspider-1.0/sunspider-1.0/results.html: Added.
• perf/sunspider-1.0/sunspider-1.0/sunspider-test-contents.js: Added.
• perf/sunspider-1.0/sunspider-1.0/sunspider-test-prefix.js: Added.
• perf/sunspider-1.0/sunspider-analyze-results.js: Added.

(computeItemTotals):
(computeTotals):
(computeMeans):
(standardDeviation):
(computeStdDevs):
(computeStdErrors):
(tDist):
(formatResult):
(computeLabelWidth):
(computeMeanWidth):
(resultLine):
(printOutput):

• perf/sunspider-1.0/sunspider-compare-results.js: Added.

(.computeItemTotals):
(.computeTotals):
(.computeMeans):
(.standardDeviation):
(.computeStdDevs):
(.computeStdErrors):
(.tDist):
(.formatMean):
(.computeLabelWidth):
(.computeMeanWidth):
(.pad):
(.resultLine):
(.printOutput):
(sunspiderCompareResults):

• perf/sunspider-1.0/sunspider.css: Added.

(body):
(h2):
(dt):
(dd):
(:link):
(:visited):
(#testframe):
(#logo):

• perf/sunspider-1.0/sunspider.html: Added.
• perf/sunspider/sunspider.html:
• perf/sunspider/versions.html: Added.

3:23 PM Changeset in webkit [149405] by abucur@adobe.com

• 4 edits in trunk/Source/WebCore

Cleanup HTMLOListElement<->RenderListItem bridge
​https://bugs.webkit.org/show_bug.cgi?id=115434

Reviewed by Darin Adler.

Refactor the way HTMLOListElement is accessing its list items. Instead
of exposing the nextListItem function, wrap the desiredfunctionality
in static methods on RenderListItem. This should make the code more readable.
I've also added more constness to some functions in RenderListItem.

Tests: No new tests, just refactoring.

• html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues): Use updateItemValuesForOrderedList.
(WebCore::HTMLOListElement::recalculateItemCount): Use itemCountForOrderedList.

• rendering/RenderListItem.cpp:

(WebCore::isList): Add more constness.
(WebCore::nextListItem): Make local to the CPP and add constness.
(WebCore::previousListItem): Add constness.
(WebCore::RenderListItem::updateItemValuesForOrderedList): Called by OL elements.
(WebCore::RenderListItem::itemCountForOrderedList): Called by OL elements.
(WebCore::previousOrNextItem):

• rendering/RenderListItem.h: Add updateItemValuesForOrderedList and itemCountForOrderedList.

3:15 PM Changeset in webkit [149404] by oliver@apple.com

• 7 edits in trunk

JSC Stack walking logic craches in the face of inlined functions triggering VM re-entry
​https://bugs.webkit.org/show_bug.cgi?id=115449

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rename callframeishost to something that makes sense, and fix
getCallerInfo to correctly handle inline functions calling into
the VM.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::codeOriginForReturn):

Make this more robust in the face of incorrect stack walking

• interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

Everyone has to perform a codeblock() check before calling this
so we might as well just do it here.

• interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

LayoutTests:

Add tests

• fast/js/script-tests/stack-trace.js:

(dfgTest):
(inlineableThrow):
(dfgThing.get willThrow):
(dfgThing.get willThrowEventually):
(dfgThing.willThrowFunc):
(dfgThing.willThrowEventuallyFunc):
(dfg1):
(dfg2):
(dfg3):
(dfg4):
(dfg5):
(dfg6):
(dfg7):
(dfg8):
(dfg9):
(dfga):
(dfgb):
(dfgc):

• fast/js/stack-trace-expected.txt:

3:10 PM Changeset in webkit [149403] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Bug fixing in sh4 base JIT and LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=115420

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-30
Reviewed by Oliver Hunt.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::branchMul32):
(JSC::MacroAssemblerSH4::urshift32):
(JSC::MacroAssemblerSH4::replaceWithJump):
(JSC::MacroAssemblerSH4::maxJumpReplacementSize):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::shldRegReg):
(JSC::SH4Assembler::shadRegReg):
(JSC::SH4Assembler::shalImm8r):
(SH4Assembler):
(JSC::SH4Assembler::sharImm8r):
(JSC::SH4Assembler::maxJumpReplacementSize):
(JSC::SH4Assembler::replaceWithJump):

• offlineasm/sh4.rb:

3:05 PM Changeset in webkit [149402] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

More StorageTracker cleanup
​https://bugs.webkit.org/show_bug.cgi?id=115435

Reviewed by Andreas Kling.

Use bind instead of "onMainThread" helper functions.

• storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase):

• storage/StorageTracker.cpp:

(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::deleteOriginWithIdentifier):

• storage/StorageTracker.h:

(StorageTracker):

2:55 PM Changeset in webkit [149401] by ggaren@apple.com

• 18 edits in trunk/Source

Objective-C JavaScriptCore API should publicly support bridging to C
​https://bugs.webkit.org/show_bug.cgi?id=115447

Reviewed by Mark Hahnenberg.

../JavaScriptCore:

For consistency, I renamed

+[JSValue valueWithValue:] => +[JSValue valueWithJSValueRef]
+[JSContext contextWithGlobalContextRef] => +[JSContext contextWithJSGlobalContextRef]
-[JSContext globalContext] => -[JSContext JSGlobalContextRef]

I searched svn to verify that these functions don't have clients yet,
so we won't break anything.

I also exported as public API

+[JSValue valueWithJSValueRef:]
+[JSContext contextWithJSGlobalContextRef:]

It's hard to integrate with the C API without these.

../WebCore:

• bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::javaScriptContext):

• bindings/objc/WebScriptObject.mm:

(-[WebScriptObject JSValue]):

../WebKit/mac:

• WebView/WebFrame.mm:

(-[WebFrame _javaScriptContextForScriptWorld:]):

• WebView/WebScriptWorld.mm:

(+[WebScriptWorld scriptWorldForJavaScriptContext:]):

2:48 PM Changeset in webkit [149400] by roger_fong@apple.com

• 8 edits
  2 adds in trunk/LayoutTests

Unreviewed. Rebaseline some tests on AppleWin port after disabling subpixel layout.

• platform/win/css1/font_properties/font-expected.txt:
• platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
• platform/win/fast/lists/003-vertical-expected.txt:
• platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
• platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
• platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
• platform/win/svg/batik/paints: Added.
• platform/win/svg/batik/paints/gradientLimit-expected.txt: Added.
• platform/win/transforms/2d/hindi-rotated-expected.txt:

2:44 PM Changeset in webkit [149399] by zarvai@inf.u-szeged.hu

• 345 edits
  503 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Massive rebaselining after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

• platform/qt-5.0-wk2/animations/3d/replace-filling-transform-expected.png: Added.
• platform/qt-5.0-wk2/compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
• platform/qt-5.0-wk2/compositing/contents-opaque/background-clip-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/background-color-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/control-layer-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/filter-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/layer-opacity-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/layer-transform-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/contents-opaque/visibility-hidden-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
• platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/clip-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/clip-inside-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/flipped-writing-mode-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.png:
• platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/animation-overlap-with-children-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-animation-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-clipping-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/overlap-transforms-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/layer-creation/translatez-overlap-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/masks/mask-layer-size-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/overflow-trumps-transform-style-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
• platform/qt-5.0-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
• platform/qt-5.0-wk2/compositing/overflow/resize-painting-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-contain-expected.png: Added.
• platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-cover-expected.png: Added.
• platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-position-expected.png: Added.
• platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-size-expected.png: Added.
• platform/qt-5.0-wk2/compositing/repaint/page-scale-repaint-expected.png: Added.
• platform/qt-5.0-wk2/compositing/repaint/requires-backing-repaint-expected.png:
• platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
• platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
• platform/qt-5.0-wk2/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
• platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
• platform/qt-5.0-wk2/compositing/tiling/huge-layer-img-expected.txt: Added.
• platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
• platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
• platform/qt-5.0-wk2/compositing/tiling/tiled-layer-resize-expected.txt: Added.
• platform/qt-5.0-wk2/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
• platform/qt-5.0-wk2/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
• platform/qt-5.0-wk2/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
• platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt: Added.
• platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
• platform/qt-5.0-wk2/css3/filters/composited-during-transition-layertree-expected.txt: Added.
• platform/qt-5.0-wk2/css3/filters/filter-repaint-blur-expected.png: Added.
• platform/qt-5.0-wk2/css3/filters/filter-repaint-child-layers-expected.png: Added.
• platform/qt-5.0-wk2/css3/filters/filter-repaint-shadow-clipped-expected.png: Added.
• platform/qt-5.0-wk2/css3/filters/filter-repaint-shadow-expected.png: Added.
• platform/qt-5.0-wk2/css3/filters/filter-repaint-shadow-rotated-expected.png: Added.
• platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png:
• platform/qt-5.0-wk2/css3/flexbox/repaint-during-resize-no-flex-expected.png:
• platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png:
• platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png:
• platform/qt-5.0-wk2/css3/images/cross-fade-background-size-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-3608462-fix-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-002-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-003-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
• platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.txt: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-002-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-003-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-004-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-005-expected.png: Added.
• platform/qt-5.0-wk2/editing/style/unbold-in-bold-expected.png: Added.
• platform/qt-5.0-wk2/fast/backgrounds/background-clip-text-on-body-expected.png: Added.
• platform/qt-5.0-wk2/fast/backgrounds/solid-color-context-restore-expected.png:
• platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png:
• platform/qt-5.0-wk2/fast/canvas/canvas-as-image-incremental-repaint-expected.png:
• platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png:
• platform/qt-5.0-wk2/fast/canvas/canvas-incremental-repaint-2-expected.png:
• platform/qt-5.0-wk2/fast/canvas/canvas-incremental-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png:
• platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png:
• platform/qt-5.0-wk2/fast/css/first-line-text-decoration-expected.png: Added.
• platform/qt-5.0-wk2/fast/css/sticky/sticky-left-expected.png: Added.
• platform/qt-5.0-wk2/fast/css/sticky/sticky-side-margins-expected.png: Added.
• platform/qt-5.0-wk2/fast/css/sticky/sticky-top-expected.png: Added.
• platform/qt-5.0-wk2/fast/css/sticky/sticky-top-margins-expected.png: Added.
• platform/qt-5.0-wk2/fast/css/sticky/sticky-writing-mode-horizontal-bt-expected.png: Added.
• platform/qt-5.0-wk2/fast/events/event-attribute-expected.txt: Added.
• platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png:
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt: Added.
• platform/qt-5.0-wk2/fast/forms/hidden-listbox-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
• platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
• platform/qt-5.0-wk2/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
• platform/qt-5.0-wk2/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
• platform/qt-5.0-wk2/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
• platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png:
• platform/qt-5.0-wk2/fast/overflow/hidden-scrollbar-resize-expected.png: Added.
• platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
• platform/qt-5.0-wk2/fast/reflections/inline-crash-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/autosize-region-window-resize-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/render-region-custom-style-mark-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/4774354-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/4776765-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/background-generated-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/background-misaligned-expected.png:
• platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/qt-5.0-wk2/fast/repaint/block-no-inflow-children-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/border-radius-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/border-repaint-glitch-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/box-shadow-dynamic-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-3509-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-5699-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-6388-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-6473-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/bugzilla-7235-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/button-spurious-layout-hint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/caret-with-transformation-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/clip-with-layout-delta-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/clipped-relative-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/containing-block-position-change-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/content-into-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/continuation-after-outline-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/control-clip-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/create-layer-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/delete-into-nested-block-expected.png:
• platform/qt-5.0-wk2/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/erase-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-after-scroll-expected.png:
• platform/qt-5.0-wk2/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-in-page-scale-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-move-after-scroll-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
• platform/qt-5.0-wk2/fast/repaint/fixed-table-cell-expected.png:
• platform/qt-5.0-wk2/fast/repaint/fixed-table-overflow-expected.png:
• platform/qt-5.0-wk2/fast/repaint/fixed-table-overflow-zindex-expected.png:
• platform/qt-5.0-wk2/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/fixed-tranformed-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/float-move-during-layout-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/float-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/float-overflow-right-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/inline-color-change-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/intermediate-layout-position-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layer-visibility-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layout-state-relative-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layout-state-scrolloffset-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/line-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/lines-with-layout-delta-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/list-marker-2-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/make-children-non-inline-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/multicol-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png:
• platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png:
• platform/qt-5.0-wk2/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/outline-child-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/outline-inset-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/outline-shrinking-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-delete-line-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-scroll-delete-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png:
• platform/qt-5.0-wk2/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/positioned-document-element-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/reflection-redraw-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png:
• platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png:
• platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png:
• platform/qt-5.0-wk2/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/repaint-during-scroll-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/repaint-resized-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/scale-page-shrink-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png:
• platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png:
• platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png:
• platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png:
• platform/qt-5.0-wk2/fast/repaint/select-option-background-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/selected-replaced-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-after-delete-expected.png:
• platform/qt-5.0-wk2/fast/repaint/selection-after-remove-expected.png:
• platform/qt-5.0-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
• platform/qt-5.0-wk2/fast/repaint/selection-rl-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/subtree-root-clip-2-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/subtree-root-clip-3-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/subtree-root-clip-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-cell-collapsed-border-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-cell-move-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-col-background-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-collapsed-border-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-extra-bottom-grow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-outer-border-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-section-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-section-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/text-in-relative-positioned-inline-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-absolute-child-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-disable-layoutstate-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-layout-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-relative-position-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-repaint-descendants-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-replaced-shadows-expected.png:
• platform/qt-5.0-wk2/fast/repaint/transform-translate-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/view-background-from-body-1-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/view-background-from-body-2-expected.png: Added.
• platform/qt-5.0-wk2/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-69296-expected.png:
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-cell-append-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
• platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
• platform/qt-5.0-wk2/fast/table/simple_paint-expected.png: Added.
• platform/qt-5.0-wk2/fast/text/font-initial-expected.png: Added.
• platform/qt-5.0-wk2/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-background-image/animated-svg-as-background-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-background-image/svg-background-partial-redraw-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png:
• platform/qt-5.0-wk2/svg/as-image/svg-image-change-content-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
• platform/qt-5.0-wk2/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
• platform/qt-5.0-wk2/svg/carto.net/window-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/animate-path-discrete-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/animate-path-morphing-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/animate-target-id-changed-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/animate-target-removed-from-document-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/circle-move-invalidation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/clip-path-child-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/clip-path-href-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/clip-path-id-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/clip-path-units-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/deep-dynamic-updates-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/fill-opacity-update-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
• platform/qt-5.0-wk2/svg/custom/gradient-add-stops-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/gradient-stop-style-change-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/hit-test-unclosed-subpaths-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/hit-test-with-br-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-clipPath-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-gradient-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-marker-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-mask-and-object-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-mask-creation-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/qt-5.0-wk2/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-bounce-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-container-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-container2-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-gradient-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
• platform/qt-5.0-wk2/svg/custom/js-update-path-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-path-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-pattern-child-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-pattern-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-polygon-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-polygon-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-stop-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-stop-linked-gradient-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-style-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-transform-addition-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/js-update-transform-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/marker-child-changes-css-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/marker-child-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/marker-strokeWidth-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/marker-viewBox-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/mask-child-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/mask-invalidation-expected.png:
• platform/qt-5.0-wk2/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/pending-resource-after-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/prevent-default-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-content-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-content-with-resources-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-image-expected.png:
• platform/qt-5.0-wk2/svg/custom/relative-sized-inner-svg-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-shadow-tree-content-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-use-on-symbol-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-shadow-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-stroke-width-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/resource-client-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/scroll-hit-test-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/stroke-opacity-update-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/svg-absolute-children-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/text-dom-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/text-repaint-including-stroke-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-clipped-hit-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-detach-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-elementInstance-event-target-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-elementInstance-methods-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-event-handler-on-referenced-element-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-event-handler-on-use-element-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-inherit-style-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/use-setAttribute-crash-expected.png: Added.
• platform/qt-5.0-wk2/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
• platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
• platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/animate-fill-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/feImage-change-target-id-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/feImage-remove-target-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/filter-refresh-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/filter-width-update-expected.png: Added.
• platform/qt-5.0-wk2/svg/filters/invalidate-on-child-layout-expected.png: Added.
• platform/qt-5.0-wk2/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/001-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/002-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/003-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/004-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/005-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/006-expected.png: Added.
• platform/qt-5.0-wk2/svg/hixie/perf/007-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/container-repaint-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/filter-child-repaint-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png:
• platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
• platform/qt-5.0-wk2/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/inner-svg-change-viewBox-expected.png:
• platform/qt-5.0-wk2/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/mask-clip-target-transform-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/text-mask-update-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/append-text-node-to-tspan-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/ems-display-none-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/exs-display-none-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/modify-text-node-in-tspan-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/remove-text-node-from-tspan-expected.png:
• platform/qt-5.0-wk2/svg/text/remove-tspan-from-text-expected.png:
• platform/qt-5.0-wk2/svg/text/text-rescale-expected.png:
• platform/qt-5.0-wk2/svg/text/text-text-05-t-expected.png: Added.
• platform/qt-5.0-wk2/svg/text/text-viewbox-rescale-expected.png: Added.
• platform/qt-5.0-wk2/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
• platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-background-images-expected.png:
• platform/qt-5.0-wk2/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-foreign-content-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-foreignObject-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-percentage-warning: inexact rename detection was skipped due to too many files.:
• platform/qt-5.0-wk2/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
• platform/qt-5.0-wk2/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
• platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png: Added.
• platform/qt-5.0-wk2/tables/mozilla/core/row_span-expected.png: Added.
• platform/qt-5.0-wk2/transforms/2d/transform-fixed-container-expected.png: Added.
• platform/qt-5.0-wk2/transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
• platform/qt-5.0-wk2/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
• platform/qt-5.0-wk2/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
• platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
• platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png:
• platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:

2:23 PM Changeset in webkit [149398] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Disable deprecation warnings around some NSProcessInfo API.

Rubber-stamped by Brady Eidson.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setProcessSuppressionEnabled):

2:01 PM Changeset in webkit [149397] by roger_fong@apple.com

• 1 edit
  14 adds in trunk/LayoutTests

Unreviewed gardening of AppleWin port after r148944.

• platform/win/fast/table: Added.
• platform/win/fast/table/giantRowspan-expected.txt: Added.
• platform/win/fast/table/giantRowspan2-expected.txt: Added.
• platform/win/tables/mozilla/bugs: Added.
• platform/win/tables/mozilla/bugs/bug133756-1-expected.txt: Added.
• platform/win/tables/mozilla/bugs/bug133756-2-expected.txt: Added.
• platform/win/tables/mozilla/bugs/bug220536-expected.txt: Added.
• platform/win/tables/mozilla/bugs/bug8858-expected.txt: Added.
• platform/win/tables/mozilla/core: Added.
• platform/win/tables/mozilla/core/row_span-expected.txt: Added.
• platform/win/tables/mozilla_expected_failures/bugs: Added.
• platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
• platform/win/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Added.
• platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Added.

1:36 PM Changeset in webkit [149396] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

• platform/win/TestExpectations:

1:18 PM Changeset in webkit [149395] by rniwa@webkit.org

• 15 edits
  1 delete in trunk/Source

Unreviewed, rolling out r149349 and r149354.
​http://trac.webkit.org/changeset/149349
​http://trac.webkit.org/changeset/149354
​https://bugs.webkit.org/show_bug.cgi?id=115444

The Thumb version of compileSoftModulo make invalid use of

registers (Requested by benjaminp on #webkit).

Source/JavaScriptCore:

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/ARMv7Assembler.h:

(ARMv7Assembler):

• assembler/AbstractMacroAssembler.h:

(JSC::isARMv7s):
(JSC):

• assembler/MacroAssemblerARMv7.cpp: Removed.
• assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(DFG):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/WTF:

• wtf/Platform.h:

1:12 PM Changeset in webkit [149394] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Fix an issue with JSPerformance.cpp in the WebCore.xcodeproj where
it was being recognized as a diretory rather than a file, introduced
in r149359.

• WebCore.xcodeproj/project.pbxproj:

12:55 PM May 2013 Meeting edited by Simon Fraser

(diff)

12:54 PM Changeset in webkit [149393] by Beth Dakin

• 2 edits in trunk/Source/WebCore

Page::pageCount() is inaccurate when we allow the first paint in App Mode
​https://bugs.webkit.org/show_bug.cgi?id=115442
-and corresponding-
<rdar://problem/13758445>

Reviewed by Dave Hyatt.

We should set the height here all the time, even if it is the first layout.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):

12:42 PM Changeset in webkit [149392] by akling@apple.com

• 34 edits in trunk/Source

Don't create StyleResolvers just to invalidate them.
<​http://webkit.org/b/115436>

Reviewed by Geoffrey Garen.

Source/WebCore:

Renamed Document::styleResolver() to ensureStyleResolver() so it's clear that it never returns null.
Removed a bunch of unnecessary null-checks I spotted while doing this.

Also fixed Element::willModifyAttribute() and FrameView::setFrameRect() to not create a StyleResolver
and immediately invalidate it in some cases.

• css/FontLoader.cpp:

(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):

• css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):

• css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

• dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::styleForPage):

• dom/Document.h:

(WebCore::Document::ensureStyleResolver):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

• dom/Element.cpp:

(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willModifyAttribute):

• dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):
(WebCore::ShadowRoot::attach):

• dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

• editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

• html/HTMLCanvasElement.cpp:
• html/HTMLCanvasElement.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::customStyleForRenderer):

• html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::updateNonRenderStyle):

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::updateNonRenderStyle):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::customStyleForRenderer):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::customStyleForRenderer):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::fontSelector):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::getUncachedPseudoStyle):

• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::checkRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):

• rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::fontSelector):

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

• svg/SVGElement.cpp:

(WebCore::SVGElement::customStyleForRenderer):

• svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::overrideComputedStyle):

Source/WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

12:32 PM Changeset in webkit [149391] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Removing failure expectations for tests that are

constantly passing on the builders.

12:27 PM Changeset in webkit [149390] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for

the current reftest failures on the builders.

12:21 PM Changeset in webkit [149389] by beidson@apple.com

• 9 edits in trunk/Source/WebKit2

[WK2] Threads get stuck in NetworkProcess when canceling loads in WebProcess.
<rdar://problem/13757687> and ​https://bugs.webkit.org/show_bug.cgi?id=115319

Written and reviewed by both Alexey Proskuryakov and Brady Eidson.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose): Call abort() on all loaders

instead of connectionToWebProcessDidClose()

(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier): Instead of removing

the loader from the scheduler, call abort() which will also end up removing it.

• NetworkProcess/SchedulableLoader.h: Add a virtual abort() call.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Added a messageFlags argument so

callers can pass DispatchMessageEvenWhenWaitingForSyncReply.

(WebKit::NetworkResourceLoader::abort): Combined "abortInProgressLoad" and "cleanup" to

be a general purpose "cancel"

(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

• NetworkProcess/NetworkResourceLoader.h:

• NetworkProcess/SyncNetworkResourceLoader.cpp:

(WebKit::SyncNetworkResourceLoader::abort):

• NetworkProcess/SyncNetworkResourceLoader.h:

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Remove an obsolete/incorrect comment.

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo): Add comment stressing

the importance of this null check so it's not removed again.

12:04 PM Changeset in webkit [149388] by Simon Fraser

• 4 edits
  2 adds in trunk

Cap max CALayer tree depth to avoid crashes
​https://bugs.webkit.org/show_bug.cgi?id=115431
<rdar://problem/13401861>

Source/WebCore:

Reviewed by Tim Horton.

Core Animation can crash if fed deeply nested layer trees.
Avoid this by capping CALayer tree depth at some empirically-determined
level.

Test: compositing/layer-creation/deep-tree.html

• platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::CommitState::CommitState): Add treeDepth to the CommitState.

• platform/graphics/ca/GraphicsLayerCA.cpp: Set cMaxLayerTreeDepth to 250

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): We need a dummy CommitState
here. It is not expected that flushCompositingStateForThisLayerOnly() will be called for
a layer in the middle of the hierarchy, only for custom-managed leaf layers, so we don't try
to compute the correct tree depth.
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Pass in the commitState. Since this is
copied for each frame, no need to decrement commitState.treeDepth.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Increment treeDepth once or
twice. If we've reached max, be sure to set the ChildrenChanged flag. We delay tree truncation
until commitLayerChangesAfterSublayers() since ChildrenChanged can be set again when children
are being processed.
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList): If we've hit max depth, just set
empty sublayers.

LayoutTests:

Reviewed by Tim Horton.

Test that makes a very deep tree. Should note crash, and should match
the reference.

• compositing/layer-creation/deep-tree-expected.html: Added.
• compositing/layer-creation/deep-tree.html: Added.

11:50 AM Changeset in webkit [149387] by Darin Adler

• 4 edits in trunk/Source/WebCore

Formatting tweaks
​https://bugs.webkit.org/show_bug.cgi?id=115427

Reviewed by Andreas Kling.

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Fixed indenting to match
normal WebKit style.

• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection): Removed an excess "+" that is harmless
but strange.

• platform/mac/SharedBufferMac.mm: Tweaked blank lines for better paragraphing.

11:44 AM Changeset in webkit [149386] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Simplify ContainerNode::removeChildren
​https://bugs.webkit.org/show_bug.cgi?id=115398

Reviewed by Andreas Kling.

Back port ​https://chromium.googlesource.com/chromium/blink/+/b981f01cd065236b5ff7e3a8446d15b384c1b557
by Andrei Bucur, which includes both this and his r148754.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

11:38 AM Changeset in webkit [149385] by bfulgham@webkit.org

• 6 edits in trunk/Source/WebKit

[Windows, WinCairo] Remove pthread paths for WebKit build.
​https://bugs.webkit.org/show_bug.cgi?id=115390

Reviewed by Tim Horton.

Update Visual Studio property sheets to remove include paths and
link references for the pthreadsVC2.dll, which is no longer used.

../WebKit:

• WebKit.vcxproj/WebKit/WebKitCommon.props:
• WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:

../WebKit/win:

• WebKit.vcproj/WebKitExportGeneratorCommon.vsprops:
• WebKit.vcproj/WebKitLibCommon.vsprops:

11:35 AM May 2013 Meeting edited by jmason@blackberry.com

typo fix (diff)

11:34 AM May 2013 Meeting edited by jmason@blackberry.com

binding generator proposal (diff)

11:25 AM Changeset in webkit [149384] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[WK2][GTK] MiniBrowser won't play video in <embed> tag
​https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Anders Carlsson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

11:20 AM Changeset in webkit [149383] by Carlos Garcia Campos

• 7 edits in trunk/Source/WebCore

[SOUP] Move default buffer handling from ResourceHandleClient to ResourceHandlesoup
​https://bugs.webkit.org/show_bug.cgi?id=115364

Reviewed by Martin Robinson.

ResourceHandleClient that is cross-platform file is not the right
place for the default ResourceHandle read buffer. We can make
getBuffer return 0 by default and handle it in ResourceHandleSoup,
creating a default buffer when the client doesn't provide one.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::getOrCreateReadBuffer): Adapt to API change.

• platform/network/ResourceHandle.h:

(ResourceHandle): Add ensureReadBuffer().

• platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::~ResourceHandleClient): Remove
soup specific code.

• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::getOrCreateReadBuffer): Rename
getBuffer() as getOrCreateReadBuffer() and use a reference for the
out parameter instead of a pointer.
(ResourceHandleClient): Remove soup specific code.

• platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): Rename
m_buffer and m_bufferSize as m_readBufferPtr and m_readBufferSize
and add m_readBuffer to be used as default read buffer.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer): Helper function to
make usre we have a read buffer before a read operation. It first
checks if the client provides a buffer and if it doesn't it
creates or reuses the default buffer.
(WebCore::redirectSkipCallback): Call ensureReadBuffer() and adapt
to variable name changes.
(WebCore::cleanupSoupRequestOperation): Adapt to variable name
changes.
(WebCore::nextMultipartResponsePartCallback): Call
ensureReadBuffer() and adapt to variable name changes.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

11:09 AM Changeset in webkit [149382] by akling@apple.com

• 6 edits in trunk

REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
<​http://webkit.org/b/115386>
<rdar://problem/13769995>

Reviewed by Darin Adler.

Source/WebCore:

Put the resize event on the Document's event queue if it happens while layout is in progress.
This avoids re-entering layout while laying out flattened subframes.

Also move the little logic for the resize event from EventHandler to FrameView (the only client.)

• page/EventHandler.cpp:
• page/EventHandler.h:
• page/FrameView.cpp:

(WebCore::FrameView::dispatchResizeEvent):

LayoutTests:

• platform/mac/TestExpectations:

11:07 AM Changeset in webkit [149381] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed, rolling out r149309.
​http://trac.webkit.org/changeset/149309
​https://bugs.webkit.org/show_bug.cgi?id=115430

The patch does not build on WK1-only builds of the GTK port
(Requested by zdobersek on #webkit).

Patch by Commit Queue <​rniwa@webkit.org> on 2013-04-30

• TestWebKitAPI/GNUmakefile.am:

11:03 AM Changeset in webkit [149380] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Fix build.

• WebCore.exp.in:
• storage/StorageTracker.h:

(StorageTracker):

10:58 AM Changeset in webkit [149379] by timothy@apple.com

• 2 edits in trunk/Source/WebKit2

Make the Inspector dock to right button work in the WebKit nightlies on Safari 6.0.4.

​https://webkit.org/b/115428

Reviewed by Joseph Pecoraro.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Reduce the required Safari version.
(WebKit::WebInspectorProxy::platformDetach): Simplify the frame restoring code so it
works on Safari 6.0.4.

10:49 AM Changeset in webkit [149378] by andersca@apple.com

• 6 edits in trunk/Source

More StorageTracker cleanup
​https://bugs.webkit.org/show_bug.cgi?id=115429

Reviewed by Andreas Kling.

Source/WebCore:

Make a bunch of member functions private, and remove StorageTracker::syncLocalStorage.

• WebCore.exp.in:
• storage/StorageTracker.cpp:
• storage/StorageTracker.h:

(StorageTracker):

Source/WebKit/mac:

Call PageGroup::syncLocalStorage directly.

• Storage/WebStorageManager.mm:

(-[WebStorageManager syncLocalStorage]):

10:35 AM Changeset in webkit [149377] by akling@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r149313) Crash at WebCore::FrameView::setFrameRect() when navigating back to previous page while find banner is displayed.
<​http://webkit.org/b/115421>
<rdar://problem/13765739>

Reviewed by Antti Koivisto.

Add missing null-checks for Document and StyleResolver when re-evaluating media queries due to viewport changes.

No layout test, since we can't show the find banner from WebCore, and I can't think of another way to
trigger a back navigation to a Document-less Frame that would also change the FrameView's size.

• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

10:18 AM Changeset in webkit [149376] by glenn@skynav.com

• 3 edits
  2 adds in trunk

The bison grammar for @supports should return 0 in case of an error
​https://bugs.webkit.org/show_bug.cgi?id=115402

Reviewed by Darin Adler.

Back ported from ​https://chromium.googlesource.com/chromium/blink/+/74399c27c8b93286bae03a1d6371735935b34d85.

Source/WebCore:

Test: css3/supports-crash.html

• css/CSSGrammar.y.in:

LayoutTests:

• css3/supports-crash-expected.txt: Added.
• css3/supports-crash.html: Added.

10:05 AM Changeset in webkit [149375] by Darin Adler

• 2 edits in trunk/Source/WebCore

[CG] Over-release in MIME type registry code
​https://bugs.webkit.org/show_bug.cgi?id=115423

Reviewed by Eric Carlson.

Sam Weinig spotted these by code inspection. I don't know how to make a test demonstrating
the problem, but this is clearly an over-release.

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Removed incorrect adoptCF call on a string we
are getting from a CFArray.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Ditto.

9:57 AM Changeset in webkit [149374] by commit-queue@webkit.org

• 1 edit
  2 adds
  16 deletes in trunk/LayoutTests

[CSS Regions] Convert some fast/regions pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=80712

Patch by Radu Stavila <​stavila@adobe.com> on 2013-04-30
Reviewed by Alexandru Chiculita.

Converted webkit-flow-inlines-inside-regions-bounds and webkit-flow-inlines-inside-regions-bounds-vertical to reftest

• fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html: Added.
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html: Added.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.

9:51 AM Changeset in webkit [149373] by Darin Adler

• 2 edits in trunk/Source/WTF

[Mac] Make adoptNS faster on platforms without garbage collection by skipping a CFRetain/NSRelease pair
​https://bugs.webkit.org/show_bug.cgi?id=115424

Reviewed by Eric Carlson.

• wtf/RetainPtr.h:

(WTF::adoptNSReference): When OBJC_NO_GC is set, make this an empty function, because in that case
CFRetain and -[NSObject retain] are the same thing and there is no need to call CFRetain and
-[NSObject release] to adopt an Objective-C object.

9:31 AM Changeset in webkit [149372] by andersca@apple.com

• 4 edits in trunk/Source/WTF

String::isolatedCopy() can avoid a copy if the original is a temporary
​https://bugs.webkit.org/show_bug.cgi?id=115425

Reviewed by Darin Adler.

• wtf/Compiler.h:

Add WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS define.

• wtf/text/WTFString.cpp:

(WTF::String::isolatedCopy):

• wtf/text/WTFString.h:

If COMPILER_SUPPORTS(CXX_REFERENCE_QUALIFIED_FUNCTIONS) is true, add two overloads of String::isolatedCopy().
One is used if *this is an lvalue, and one is used if *this is an rvalue. In the latter case, we know that the original
String object is a temporary and will be going away, so if it's safe to send it to another thread (if it's not an AtomicString,
and if it's refcount is 1), then we can just steal the StringImpl from the original and avoid a copy altogether.

8:58 AM Changeset in webkit [149371] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

[GTK] --minimal build fails with error: class WebCore::EventHandler' has no member named 'dragSourceEndedAt
​https://bugs.webkit.org/show_bug.cgi?id=114299

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-30
Reviewed by Martin Robinson.

Wrapped code, related to drag&drop in #if ENABLE(DRAG_SUPPORT)

• webkit/webkitwebview.cpp:

(webkit_web_view_class_init):
(webkit_web_view_init):

8:00 AM Changeset in webkit [149370] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] ImageBuffer::copyImage leaking memory
​https://bugs.webkit.org/show_bug.cgi?id=115359

Patch by Mike Lattanzio <​mlattanzio@blackberry.com> on 2013-04-30
Reviewed by George Staikos.

Use a WebCore::Vector to ensure the temporary data is destroyed.
The TiledImage does not take ownership of the data.

• platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::ImageBuffer::copyImage):

7:39 AM Changeset in webkit [149369] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Texmap] Avoid using overlap/non-overlap region in cases where the overhead is bigger than the gain
​https://bugs.webkit.org/show_bug.cgi?id=115226

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-30
Reviewed by Allan Sandfeld Jensen.

When there are several fragmeneted overlap regions, or when the overlap region is bigger than the
non-overlap region, it's more efficient to have a single intermediate surface rather than split
the rendering to overlap/non-overlap.

Covered by tests in compositing/overlap-blending.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::shouldBlend):

Readability fix.

(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

Consolidate to one overlap rect when one of the following occurs:

• The overlap region's area is larger than the non-overlap region area.
• There are many fragmented overlap regions and no non-overlap regions.

7:37 AM Changeset in webkit [149368] by Christophe Dumez

• 299 edits in trunk

Stop using "in" keyword in IDL files
​https://bugs.webkit.org/show_bug.cgi?id=115418

Reviewed by Kentaro Hara.

Source/WebCore:

Stop using "in" keyword in IDL files as this is no longer part of the
Web IDL specification and it brings no additional information.

For now, the IDL parser will still accept the "in" keyword for operation
argument to not break anything. However, we should remove support for it
later on.

No new tests, no behavior change.

• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/filesystem/DOMWindowFileSystem.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryEntrySync.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/EntriesCallback.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/EntryArray.idl:
• Modules/filesystem/EntryArraySync.idl:
• Modules/filesystem/EntryCallback.idl:
• Modules/filesystem/EntrySync.idl:
• Modules/filesystem/ErrorCallback.idl:
• Modules/filesystem/FileCallback.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/FileSystemCallback.idl:
• Modules/filesystem/FileWriter.idl:
• Modules/filesystem/FileWriterCallback.idl:
• Modules/filesystem/FileWriterSync.idl:
• Modules/filesystem/MetadataCallback.idl:
• Modules/filesystem/WorkerContextFileSystem.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/geolocation/PositionCallback.idl:
• Modules/geolocation/PositionErrorCallback.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBDatabase.idl:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/IDBIndex.idl:
• Modules/indexeddb/IDBKeyRange.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/indexeddb/IDBRequest.idl:
• Modules/indexeddb/IDBTransaction.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/NavigatorMediaStream.idl:
• Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
• Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCErrorCallback.idl:
• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCSessionDescription.idl:
• Modules/mediastream/RTCSessionDescriptionCallback.idl:
• Modules/mediastream/RTCStatsCallback.idl:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/navigatorcontentutils/NavigatorContentUtils.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/Notification.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/notifications/NotificationPermissionCallback.idl:
• Modules/quota/StorageErrorCallback.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/quota/StorageQuotaCallback.idl:
• Modules/quota/StorageUsageCallback.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechRecognitionResult.idl:
• Modules/speech/SpeechRecognitionResultList.idl:
• Modules/speech/SpeechSynthesisUtterance.idl:
• Modules/vibration/NavigatorVibration.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferCallback.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseCallback.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLStatementCallback.idl:
• Modules/webdatabase/SQLStatementErrorCallback.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionCallback.idl:
• Modules/webdatabase/SQLTransactionErrorCallback.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/webdatabase/SQLTransactionSyncCallback.idl:
• Modules/webdatabase/WorkerContextWebDatabase.idl:
• Modules/websockets/WebSocket.idl:
• bindings/scripts/test/TestCallback.idl:
• bindings/scripts/test/TestCustomNamedGetter.idl:
• bindings/scripts/test/TestDomainSecurity.idl:
• bindings/scripts/test/TestEventTarget.idl:
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestMediaQueryListListener.idl:
• bindings/scripts/test/TestNamedConstructor.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestOverloadedConstructors.idl:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestSupplemental.idl:
• bindings/scripts/test/TestTypedArray.idl:
• bindings/scripts/test/TestTypedefs.idl:
• css/CSSHostRule.idl:
• css/CSSMediaRule.idl:
• css/CSSPrimitiveValue.idl:
• css/CSSRuleList.idl:
• css/CSSStyleDeclaration.idl:
• css/CSSStyleSheet.idl:
• css/CSSSupportsRule.idl:
• css/CSSValueList.idl:
• css/FontLoader.idl:
• css/MediaList.idl:
• css/MediaQueryList.idl:
• css/MediaQueryListListener.idl:
• css/StyleMedia.idl:
• css/StyleSheetList.idl:
• css/WebKitCSSKeyframesRule.idl:
• css/WebKitCSSMatrix.idl:
• dom/CharacterData.idl:
• dom/ClientRectList.idl:
• dom/Clipboard.idl:
• dom/CompositionEvent.idl:
• dom/CustomEvent.idl:
• dom/DOMImplementation.idl:
• dom/DOMNamedFlowCollection.idl:
• dom/DOMStringList.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/DeviceMotionEvent.idl:
• dom/DeviceOrientationEvent.idl:
• dom/Document.idl:
• dom/DocumentFragment.idl:
• dom/Element.idl:
• dom/Event.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/HashChangeEvent.idl:
• dom/KeyboardEvent.idl:
• dom/MessageEvent.idl:
• dom/MessagePort.idl:
• dom/MouseEvent.idl:
• dom/MutationEvent.idl:
• dom/MutationObserver.idl:
• dom/NamedNodeMap.idl:
• dom/Node.idl:
• dom/NodeFilter.idl:
• dom/NodeList.idl:
• dom/OverflowEvent.idl:
• dom/PropertyNodeList.idl:
• dom/Range.idl:
• dom/RequestAnimationFrameCallback.idl:
• dom/ShadowRoot.idl:
• dom/StringCallback.idl:
• dom/Text.idl:
• dom/TextEvent.idl:
• dom/TouchEvent.idl:
• dom/TouchList.idl:
• dom/UIEvent.idl:
• dom/WebKitNamedFlow.idl:
• dom/WheelEvent.idl:
• fileapi/Blob.idl:
• fileapi/FileList.idl:
• fileapi/FileReader.idl:
• fileapi/FileReaderSync.idl:
• html/DOMFormData.idl:
• html/DOMTokenList.idl:
• html/DOMURL.idl:
• html/HTMLAllCollection.idl:
• html/HTMLAudioElement.idl:
• html/HTMLButtonElement.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLCollection.idl:
• html/HTMLDocument.idl:
• html/HTMLElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormControlsCollection.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLMediaElement.idl:
• html/HTMLObjectElement.idl:
• html/HTMLOptionElement.idl:
• html/HTMLOptionsCollection.idl:
• html/HTMLOutputElement.idl:
• html/HTMLPropertiesCollection.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTableElement.idl:
• html/HTMLTableRowElement.idl:
• html/HTMLTableSectionElement.idl:
• html/HTMLTextAreaElement.idl:
• html/MediaController.idl:
• html/TimeRanges.idl:
• html/canvas/ArrayBuffer.idl:
• html/canvas/CanvasGradient.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/DOMPath.idl:
• html/canvas/DataView.idl:
• html/canvas/EXTDrawBuffers.idl:
• html/canvas/Float32Array.idl:
• html/canvas/Float64Array.idl:
• html/canvas/Int16Array.idl:
• html/canvas/Int32Array.idl:
• html/canvas/Int8Array.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/Uint16Array.idl:
• html/canvas/Uint32Array.idl:
• html/canvas/Uint8Array.idl:
• html/canvas/Uint8ClampedArray.idl:
• html/canvas/WebGLDebugShaders.idl:
• html/canvas/WebGLRenderingContext.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrack.idl:
• html/track/TextTrackCue.idl:
• html/track/TextTrackCueList.idl:
• html/track/TextTrackList.idl:
• html/track/TextTrackRegionList.idl:
• html/track/VideoTrackList.idl:
• inspector/InjectedScriptHost.idl:
• inspector/InspectorFrontendHost.idl:
• inspector/JavaScriptCallFrame.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/Console.idl:
• page/Crypto.idl:
• page/DOMSecurityPolicy.idl:
• page/DOMSelection.idl:
• page/DOMWindow.idl:
• page/EventSource.idl:
• page/History.idl:
• page/Location.idl:
• page/PagePopupController.idl:
• page/Performance.idl:
• page/PerformanceEntryList.idl:
• page/SpeechInputResultList.idl:
• plugins/DOMMimeTypeArray.idl:
• plugins/DOMPlugin.idl:
• plugins/DOMPluginArray.idl:
• storage/Storage.idl:
• storage/StorageEvent.idl:
• svg/ElementTimeControl.idl:
• svg/SVGAngle.idl:
• svg/SVGColor.idl:
• svg/SVGDocument.idl:
• svg/SVGElementInstanceList.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGFilterElement.idl:
• svg/SVGLength.idl:
• svg/SVGLengthList.idl:
• svg/SVGLocatable.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGMatrix.idl:
• svg/SVGNumberList.idl:
• svg/SVGPaint.idl:
• svg/SVGPathElement.idl:
• svg/SVGPathSegList.idl:
• svg/SVGPoint.idl:
• svg/SVGPointList.idl:
• svg/SVGSVGElement.idl:
• svg/SVGStringList.idl:
• svg/SVGStyledElement.idl:
• svg/SVGTests.idl:
• svg/SVGTextContentElement.idl:
• svg/SVGTransform.idl:
• svg/SVGTransformList.idl:
• testing/InternalSettings.idl:
• testing/Internals.idl:
• workers/AbstractWorker.idl:
• workers/DedicatedWorkerContext.idl:
• workers/SharedWorker.idl:
• workers/Worker.idl:
• workers/WorkerContext.idl:
• xml/DOMParser.idl:
• xml/XMLHttpRequest.idl:
• xml/XMLHttpRequestUpload.idl:
• xml/XMLSerializer.idl:
• xml/XPathEvaluator.idl:
• xml/XPathExpression.idl:
• xml/XPathNSResolver.idl:
• xml/XPathResult.idl:
• xml/XSLTProcessor.idl:

Source/WebKit/win:

Remove "in" keyword from IDL files as this is no longer part of the Web
IDL specification.

• Interfaces/DOMEvents.idl:
• Interfaces/DOMPrivate.idl:
• Interfaces/DOMWindow.idl:

Tools:

Remove "in" keyword from IDL files as this is no longer part of the Web
IDL specification.

• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:

6:54 AM Changeset in webkit [149367] by zandobersek@gmail.com

• 8 edits
  4 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining tests that are possible to and required to be rebaselined

• platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
• platform/gtk/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
• platform/gtk/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
• platform/gtk/fast/dom/Range/getClientRects-expected.txt:
• platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt:
• platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt:
• platform/gtk/fast/js/function-length-expected.txt: Added.
• platform/gtk/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt:
• platform/gtk/media/media-can-play-ogg-expected.txt: Added.
• platform/gtk/media/video-played-collapse-expected.txt:
• platform/gtk/media/video-volume-slider-expected.txt:

6:49 AM Changeset in webkit [149366] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2][EFL] Spelling marker disappears while selection is being changed
​https://bugs.webkit.org/show_bug.cgi?id=115165

Patch by Artur Moryc <​a.moryc@samsung.com> on 2013-04-30
Reviewed by Anders Carlsson.

The marker for a misspelled word disappears while the cursor is being navigated along the word.

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):

6:47 AM Changeset in webkit [149365] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[Texmap] Use fewer intermediate surfaces when compositing filters
​https://bugs.webkit.org/show_bug.cgi?id=115224

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-30
Reviewed by Allan Sandfeld Jensen.

Until now, when rendering CSS filters, the filters were applied to the texture
and then the resulting texture would be composited to the target surface with
its transform/opacity.
This requires at least two intermediate surface passes for every filtered layer.

This patch makes it so that the last filter pass is applied together with the
resulting surface's opacity and transform, during composition.

Tested by css3/filters tests, whichn now scroll/zoom a lot faster.

• platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::applyFilters):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore):
(WebCore::optionsForFilterType):
(WebCore::getPassesRequiredForFilter):
(WebCore::gauss):
(WebCore::gaussianKernel):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::isCustomFilter):

• platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL):
(BitmapTextureGL):
(FilterInfo):

• platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

• platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):
(WebCore::BitmapTextureGL::FilterInfo::FilterInfo):
(WebCore::BitmapTextureGL::filterInfo):
(WebCore::BitmapTextureGL::applyFilters):

Modify TextureMapperGL to remember the last filter operation applied
to a BitmapTexture and apply it when the texture is composited.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintIntoSurface):

Simplify the call to applyFilters, since now TextureMapperGL is responsible
for maintaining the content texture.

6:47 AM Changeset in webkit [149364] by kbalazs@webkit.org

• 2 edits in trunk/LayoutTests

[EFL][GStreamer] failing media tests
​https://bugs.webkit.org/show_bug.cgi?id=115419

Unreviewed gardening.

• platform/efl/TestExpectations: Track failing tests.

6:23 AM Changeset in webkit [149363] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for additional failing tests

after the Shadow DOM feature was disabled for the GTK port in r149352.

6:17 AM Changeset in webkit [149362] by Christophe Dumez

• 9 edits in trunk

[EFL] Enable scaled cursors
​https://bugs.webkit.org/show_bug.cgi?id=106242

Reviewed by Gyuyoung Kim.

.:

Enable MOUSE_CURSOR_SCALE flag for EFL port.

• Source/cmake/OptionsEfl.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Correctly copy WebCore::Cursor's m_imageScaleFactor
member in CursorEfl.cpp when MOUSE_CURSOR_SCALE is
enabled.

No new tests, already covered by existing tests.

• platform/efl/CursorEfl.cpp:

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):

Tools:

Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip fast/css/cursor-parsing-image-set.html for EFL port
now that scaled cursors are enabled. Update expectation for
fast/events/mouse-cursor-image-set.html to explain the
reason why it is failing and set its bug URL.

• platform/efl/TestExpectations:

5:41 AM Changeset in webkit [149361] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skipping tests using unimplemented feature.

• platform/qt-5.0-wk1/TestExpectations:

4:00 AM Changeset in webkit [149360] by thiago.santos@intel.com

• 3 edits
  2 adds in trunk

CSSParser::parseFontFamily should allow the keyword "default" as part of a font name
​https://bugs.webkit.org/show_bug.cgi?id=107231

Reviewed by Ryosuke Niwa.

Source/WebCore:

Make sure that using the keyword "default" as font family doesn't
invalidate the whole declaration. It is also OK to use a font that
has "default" as part of a composite name (i.e. "default foo").
This matches the behavior of Firefox and IE.

Test: fast/css/font-family-parse-keyword.html

• css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFamily):

LayoutTests:

• fast/css/font-family-parse-keyword-expected.html: Added.
• fast/css/font-family-parse-keyword.html: Added.

3:54 AM Changeset in webkit [149359] by commit-queue@webkit.org

• 19 edits
  2 adds in trunk

Animations fail to start on ​http://www.google.com/insidesearch/howsearchworks/thestory/
​https://bugs.webkit.org/show_bug.cgi?id=111244

Source/JavaScriptCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

Test: fast/dom/Window/web-timing-minimal-performance-now.html

• Configurations/FeatureDefines.xcconfig:
• WebCore.xcodeproj/project.pbxproj:
• dom/EventTargetFactory.in:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore):

• page/DOMWindow.h:

(DOMWindow):

• page/DOMWindow.idl:
• page/Performance.cpp:

(WebCore):

• page/Performance.h:

(Performance):

• page/Performance.idl:

Source/WebKit/mac:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

• wtf/FeatureDefines.h:

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-30
Reviewed by David Kilzer.

Enable performance.now() as a minimal subset of Web Timing API.
It returns DOMHighResTimeStamp, a monotonically increasing value representing the
number of milliseconds from the start of the navigation of the current document.
JS libraries use this API to check against the requestAnimationFrame() timestamp.

We can test the monotonical behaviour of this API only. Checking whether the value
actually represents the navigation start requires PerformanceTiming enabled.

• fast/dom/Window/web-timing-minimal-performance-now-expected.txt: Added.
• fast/dom/Window/web-timing-minimal-performance-now.html: Added.

3:43 AM Changeset in webkit [149358] by rniwa@webkit.org

• 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r149338.
​http://trac.webkit.org/changeset/149338
​https://bugs.webkit.org/show_bug.cgi?id=115409

Broke layout/perf/API tests on non-Mac:
ThreadSpecific<RefPtr<RunLoop>> does not initialize RunLoop
(Requested by rakuco on #webkit).

• platform/RunLoop.cpp:

(WebCore::RunLoop::current):

• platform/RunLoop.h:

(RunLoop):

• platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::initializeMainRunLoop):
(WebCore::RunLoop::current):
(WebCore::RunLoop::~RunLoop):

• platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::~RunLoop):

• platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::~RunLoop):

• platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::~RunLoop):

3:16 AM Changeset in webkit [149357] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ImageBufferData: add BlackBerry header
​https://bugs.webkit.org/show_bug.cgi?id=115408

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-30
Reviewed by Carlos Garcia Campos.

• platform/graphics/ImageBufferData.h:

1:32 AM Changeset in webkit [149356] by Christophe Dumez

• 192 edits in trunk

Replace "Optional" extended attribute by proper Web IDL "optional" keyword
​https://bugs.webkit.org/show_bug.cgi?id=115380

Reviewed by Kentaro Hara.

Source/WebCore:

Replace [Optional] with standard WebIDL optional type prefix:
​http://dev.w3.org/2006/webapi/WebIDL/#dfn-optional-argument

The default behavior now matches WebIDL: [Optional] => optional

Two cases where WebKit has extended bindings behavior still
require a non-standard IDL attribute:
[Optional=DefaultIsNullString] => [Default=NullString] optional
[Optional=DefaultIsUndefined] => [Default=Undefined] optional

Based on corresponding Blink patch from Joshua Bell for compatibility.

No new tests, no behavior change.

• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/filesystem/DOMWindowFileSystem.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/FileWriter.idl:
• Modules/filesystem/WorkerContextFileSystem.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBDatabase.idl:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/IDBIndex.idl:
• Modules/indexeddb/IDBKeyRange.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/indexeddb/IDBRequest.idl:
• Modules/indexeddb/IDBTransaction.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/NavigatorMediaStream.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/Notification.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechSynthesisUtterance.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/WorkerContextWebDatabase.idl:
• Modules/websockets/WebSocket.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionLength):
(GenerateFunctionParametersCheck):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorDefinition):

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parseOptionalOrRequiredArgument):

• bindings/scripts/test/TestEventTarget.idl:
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestNamedConstructor.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestTypedefs.idl: optional cannot be used in a typedef.
• css/CSSHostRule.idl:
• css/CSSMediaRule.idl:
• css/CSSPrimitiveValue.idl:
• css/CSSRuleList.idl:
• css/CSSStyleDeclaration.idl:
• css/CSSStyleSheet.idl:
• css/CSSSupportsRule.idl:
• css/CSSValueList.idl:
• css/FontLoader.idl:
• css/MediaList.idl:
• css/MediaQueryList.idl:
• css/MediaQueryListListener.idl:
• css/StyleMedia.idl:
• css/StyleSheetList.idl:
• css/WebKitCSSKeyframesRule.idl:
• css/WebKitCSSMatrix.idl:
• dom/CharacterData.idl:
• dom/ClientRectList.idl:
• dom/Clipboard.idl:
• dom/CompositionEvent.idl:
• dom/CustomEvent.idl:
• dom/DOMImplementation.idl:
• dom/DOMStringList.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/DeviceMotionEvent.idl:
• dom/DeviceOrientationEvent.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/Event.idl:
• dom/EventTarget.idl:
• dom/HashChangeEvent.idl:
• dom/KeyboardEvent.idl:
• dom/MessageEvent.idl:
• dom/MessagePort.idl:
• dom/MouseEvent.idl:
• dom/MutationEvent.idl:
• dom/NamedNodeMap.idl:
• dom/Node.idl:
• dom/NodeFilter.idl:
• dom/NodeList.idl:
• dom/OverflowEvent.idl:
• dom/Range.idl:
• dom/ShadowRoot.idl:
• dom/Text.idl:
• dom/TextEvent.idl:
• dom/TouchEvent.idl:
• dom/UIEvent.idl:
• dom/WebKitNamedFlow.idl:
• dom/WheelEvent.idl:
• fileapi/Blob.idl:
• fileapi/FileReader.idl:
• fileapi/FileReaderSync.idl:
• html/DOMFormData.idl:
• html/DOMTokenList.idl:
• html/HTMLAllCollection.idl:
• html/HTMLAudioElement.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLCollection.idl:
• html/HTMLDocument.idl:
• html/HTMLElement.idl:
• html/HTMLFormControlsCollection.idl:
• html/HTMLInputElement.idl:
• html/HTMLMediaElement.idl:
• html/HTMLOptionElement.idl:
• html/HTMLOptionsCollection.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTableElement.idl:
• html/HTMLTableRowElement.idl:
• html/HTMLTableSectionElement.idl:
• html/HTMLTextAreaElement.idl:
• html/MediaController.idl:
• html/canvas/ArrayBuffer.idl:
• html/canvas/CanvasGradient.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/DOMPath.idl:
• html/canvas/DataView.idl:
• html/canvas/Float32Array.idl:
• html/canvas/Float64Array.idl:
• html/canvas/Int16Array.idl:
• html/canvas/Int32Array.idl:
• html/canvas/Int8Array.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/Uint16Array.idl:
• html/canvas/Uint32Array.idl:
• html/canvas/Uint8Array.idl:
• html/canvas/Uint8ClampedArray.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrack.idl:
• html/track/TextTrackCue.idl:
• html/track/TextTrackList.idl:
• html/track/VideoTrackList.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/DOMSelection.idl:
• page/DOMWindow.idl:
• page/EventSource.idl:
• page/History.idl:
• page/Location.idl:
• page/Performance.idl:
• plugins/DOMMimeTypeArray.idl:
• plugins/DOMPlugin.idl:
• plugins/DOMPluginArray.idl:
• storage/StorageEvent.idl:
• svg/ElementTimeControl.idl:
• svg/SVGDocument.idl:
• svg/SVGElementInstanceList.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGFilterElement.idl:
• svg/SVGLocatable.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGPathElement.idl:
• svg/SVGSVGElement.idl:
• svg/SVGStyledElement.idl:
• svg/SVGTests.idl:
• svg/SVGTextContentElement.idl:
• testing/Internals.idl:
• workers/AbstractWorker.idl:
• workers/DedicatedWorkerContext.idl:
• workers/SharedWorker.idl:
• workers/Worker.idl:
• workers/WorkerContext.idl:
• xml/DOMParser.idl:
• xml/XMLHttpRequest.idl:
• xml/XMLHttpRequestUpload.idl:
• xml/XMLSerializer.idl:
• xml/XPathEvaluator.idl:
• xml/XPathExpression.idl:
• xml/XPathNSResolver.idl:
• xml/XPathResult.idl:
• xml/XSLTProcessor.idl:

Source/WebKit/win:

Replace [Optional] by optional.

• Interfaces/DOMWindow.idl:

Tools:

Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
keyword.

• WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

1:23 AM Changeset in webkit [149355] by jocelyn.turcotte@digia.com

• 5 edits in trunk

Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
​https://bugs.webkit.org/show_bug.cgi?id=114684

Reviewed by Simon Hausmann.

Source/WebCore:

Currently USE(3D_GRAPHICS) is only supported with OpenGLES through ANGLE
on Windows. Allow building with the stock opengl32.lib on Windows by adding
missing glCompressedTex* entries in OpenGLShims.
Those are used in Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
and will be substituted by the preprocessor.

• platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

• platform/graphics/OpenGLShims.h:

(_OpenGLFunctionTable):

Tools:

Remove the ANGLE requirement for USE(3D_GRAPHICS).
This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.

• qmake/mkspecs/features/features.prf:

1:10 AM WebKitIDL edited by Christophe Dumez

Remove Callback section as this extended attribute is no longer needed … (diff)

12:40 AM Changeset in webkit [149354] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Speculative build fix on Qt Arm and Mips after r149349.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):

Apr 29, 2013:

11:39 PM Changeset in webkit [149353] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Skipping the Shadow DOM layout tests after the feature was disabled in r149352.

11:33 PM Changeset in webkit [149352] by zandobersek@gmail.com

• 4 edits in trunk

[GTK] Disable Shadow DOM feature
​https://bugs.webkit.org/show_bug.cgi?id=115374

Reviewed by Martin Robinson.

Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.

.:

• Source/autotools/SetupWebKitFeatures.m4:

Tools:

• Scripts/webkitperl/FeatureList.pm:

9:50 PM Changeset in webkit [149351] by fpizlo@apple.com

• 12 edits
  1 add in branches/dfgFourthTier/Source

fourthTier: String::utf8() should also be available as StringImpl::utf8() so that you don't have to ref() a StringImpl just to get its utf8()
​https://bugs.webkit.org/show_bug.cgi?id=115393

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):

Source/WebCore:

No new tests because no new behavior.

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::close):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

• html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/text/ConversionMode.h: Added.

(WTF):

• wtf/text/StringImpl.cpp:

(WTF):
(WTF::putUTF8Triple):
(WTF::StringImpl::utf8):

• wtf/text/StringImpl.h:

(StringImpl):

• wtf/text/WTFString.cpp:

(WTF):
(WTF::String::utf8):

• wtf/text/WTFString.h:

(String):

8:20 PM Changeset in webkit [149350] by glenn@skynav.com

• 2 edits in trunk/Tools

[webkitpy] Add missing contributor email addresses
​https://bugs.webkit.org/show_bug.cgi?id=115394

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/common/config/contributors.json:

7:55 PM Changeset in webkit [149349] by commit-queue@webkit.org

• 15 edits
  1 add in trunk/Source

[ARM] Expand the use of integer division
​https://bugs.webkit.org/show_bug.cgi?id=115138

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-04-29
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

If availability of hardware integer division isn't known at compile
time, check the CPU flags and decide at runtime whether to fall back
to software. Currently, this OS-specific check is implemented on QNX.

Moreover, use operator % instead of fmod() in the calculation of the
software modulo. Even when it's software-emulated, operator % is faster
than fmod(): on ARM v7 QNX, without hardware division, we noticed

3% speedup on SunSpider.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::sdiv): Did not compile conditionally.
(JSC::ARMv7Assembler::udiv): Ditto.

• assembler/AbstractMacroAssembler.h:

(JSC::isARMv7s): Removed.

• assembler/MacroAssemblerARMv7.cpp: Added.

(JSC::isIntegerDivSupported): Added.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsIntegerDiv): Added.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Checked MacroAssembler::supportsIntegerDiv() in ArithDiv case.

• dfg/DFGOperations.cpp:

(JSC::DFG::operationModOnInts): Added.

• dfg/DFGOperations.h:

(JSC::DFG::Z_DFGOperation_ZZ): Added.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo): Separated the X86-specific and ARM-specific codegen
from the common implementation; used operationModOnInts on ARM.
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARM): Renamed from compileIntegerArithDivForARMv7.
(JSC::DFG::SpeculativeJIT::compileArithMod): Allowed run-time detection of integer div on ARM.

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation): Added overloads with Z_DFGOperation_ZZ arguments.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Used compileIntegerArithDivForARM.

Source/WTF:

• wtf/Platform.h: Added ENABLE_ARM_INTEGER_DIV.

7:04 PM Changeset in webkit [149348] by roger_fong@apple.com

• 22 edits
  3 adds in trunk/LayoutTests

Unreviewed gardening. Rebaseline some Windows tests after disabling subpixel layout.

• platform/win/editing/selection/caret-ltr-right-expected.txt:
• platform/win/editing/selection/caret-rtl-2-left-expected.txt:
• platform/win/editing/selection/caret-rtl-right-expected.txt:
• platform/win/editing/selection/extend-selection-word-expected.txt: Added.
• platform/win/editing/selection/mixed-editability-10-expected.txt:
• platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
• platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
• platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
• platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
• platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
• platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
• platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
• platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
• platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
• platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
• platform/win/fast/borders/bidi-012-expected.txt:
• platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
• platform/win/fast/forms/file/file-input-disabled-expected.txt:
• platform/win/fast/forms/range: Added.
• platform/win/fast/forms/range/slider-mouse-events-expected.txt: Added.
• platform/win/fast/inline/inline-box-background-expected.txt:
• platform/win/fast/inline/inline-box-background-long-image-expected.txt:
• platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
• platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:

6:59 PM Changeset in webkit [149347] by commit-queue@webkit.org

• 6 edits
  4 deletes in trunk

Remove all remaining Skia code
​https://bugs.webkit.org/show_bug.cgi?id=115263

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-29
Reviewed by Benjamin Poulain.

Source/WebCore:

• html/HTMLCanvasElement.cpp:

(WebCore): Remove the MaxSkiaDim constant, which was a leftover
from r149193.

• platform/graphics/harfbuzz/FontHarfBuzz.cpp: Removed.
• platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Removed.
• platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Removed.
• platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp: Removed.

Tools:

Remove all remaining references to Skia.

• Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

• Scripts/webkitpy/common/config/contributionareas.py:
• Scripts/webkitpy/common/config/watchlist:

6:47 PM Changeset in webkit [149346] by roger_fong@apple.com

• 1 edit
  22 adds in trunk/LayoutTests

Unreviewed. Windows gardening after r148987.

• platform/win/editing/deleting/delete-by-word-002-expected.txt: Added.
• platform/win/editing/deleting/delete-cell-contents-expected.txt: Added.
• platform/win/editing/execCommand: Added.
• platform/win/editing/execCommand/button-expected.txt: Added.
• platform/win/editing/execCommand/createLink-expected.txt: Added.
• platform/win/editing/execCommand/indent-pre-expected.txt: Added.
• platform/win/editing/execCommand/unlink-expected.txt: Added.
• platform/win/editing/inserting/insert-before-link-1-expected.txt: Added.
• platform/win/editing/pasteboard/display-block-on-spans-expected.txt: Added.
• platform/win/editing/pasteboard/merge-end-list-2-expected.txt: Added.
• platform/win/editing/pasteboard/merge-end-table-2-expected.txt: Added.
• platform/win/editing/pasteboard/page-zoom-expected.txt: Added.
• platform/win/editing/style: Added.
• platform/win/editing/style/apply-through-end-of-document-expected.txt: Added.
• platform/win/editing/style/remove-underline-across-paragraph-expected.txt: Added.
• platform/win/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
• platform/win/editing/style/remove-underline-expected.txt: Added.
• platform/win/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
• platform/win/editing/style/remove-underline-in-bold-expected.txt: Added.
• platform/win/editing/style/unbold-in-bold-expected.txt: Added.
• platform/win/editing/undo: Added.
• platform/win/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Added.

6:44 PM Changeset in webkit [149345] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Fix build.

• platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):

6:22 PM Changeset in webkit [149344] by benjamin@webkit.org

• 6 edits in trunk/Source/JavaScriptCore

Unify the data access of StringImpl members from JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=115320

Reviewed by Andreas Kling.

DFG accesses the member infos by directly calling the methods on StringImpl,
while the baseline JIT was using helper methods on ThunkHelpers.

Cut the middle man, and use StringImpl directly everywhere.

• jit/JITInlines.h:

(JSC::JIT::emitLoadCharacterString):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

• jit/JSInterfaceJIT.h:
• jit/ThunkGenerators.cpp:

(JSC::stringCharLoad):

6:03 PM Changeset in webkit [149343] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Don't do CGContext flipping when painting subframes in WebKit1 on post-MountainLion OSes
​https://bugs.webkit.org/show_bug.cgi?id=115392
<rdar://problem/13421519>

Reviewed by Beth Dakin.

Sync up with AppKit behavior changes that could cause subviews to be flipped when
painted.

• platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

5:46 PM Changeset in webkit [149342] by Chris Fleizach

• 9 edits in trunk/Source

WEB SPEECH: need to identify the default voice per language
​https://bugs.webkit.org/show_bug.cgi?id=115366

Reviewed by Tim Horton.

Source/WebCore:

Use a WKSystemInterface method to determine which voice per language is the default voice.

When looking for a voice, there may not be a default at all, so we need to search until we
find a default.

• WebCore.exp.in:
• platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

5:46 PM Changeset in webkit [149341] by andersca@apple.com

• 2 edits in trunk/Source/WTF

It should be an error to use adoptPtr with RefCounted subclasses
​https://bugs.webkit.org/show_bug.cgi?id=115389

Reviewed by Benjamin Poulain.

• wtf/PassOwnPtr.h:

(WTF::adoptPtr):
Add COMPILE_ASSERTs.

5:34 PM Changeset in webkit [149340] by commit-queue@webkit.org

• 4 edits in trunk

Settings.in selectionIncludesAltImageText should default to true, due to update in HTML spec.
​https://bugs.webkit.org/show_bug.cgi?id=115283

Patch by James Craig <​james@cookiecrook.com> on 2013-04-29
Reviewed by Chris Fleizach.

Source/WebCore:

Config change due to this spec update:
​https://www.w3.org/Bugs/Public/show_bug.cgi?id=21403
​http://html5.org/tools/web-apps-tracker?from=7854&to=7855

Updated existing test coverage.

• page/Settings.in:

LayoutTests:

Update test to account for the initial setting change.

• editing/pasteboard/copy-image-with-alt-text.html:

5:29 PM Changeset in webkit [149339] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Get rid of unused options in Tools/Scripts/webkit-build-directory
​https://bugs.webkit.org/show_bug.cgi?id=115383

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-29
Reviewed by Darin Adler.

• Scripts/webkit-build-directory:

5:24 PM Changeset in webkit [149338] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Make RunLoop ref-counted
​https://bugs.webkit.org/show_bug.cgi?id=115384

Reviewed by Sam Weinig.

This is a step towards creating a shared base class that both RunLoop and WorkQueue will derive from.

• platform/RunLoop.cpp:

(WebCore::RunLoop::current):
(WebCore::RunLoop::~RunLoop):
(WebCore):

• platform/RunLoop.h:

(RunLoop):

• platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::initializeMainRunLoop):
(WebCore::RunLoop::current):
(WebCore::RunLoop::~RunLoop):

5:14 PM Changeset in webkit [149337] by bfulgham@webkit.org

• 13 edits
  2 deletes in trunk/Source/WebCore

[Windows, WinCairo] Remove link and include directives for pthread.
​https://bugs.webkit.org/show_bug.cgi?id=115381

Reviewed by Benjamin Poulain.

Update various VS2005 and VS2010 property sheets to remove
reference to the pthreads Include path and instructions to
link to the pthreads library.

• WebCore.vcproj/QTMovieWinCommon.vsprops:
• WebCore.vcproj/WebCoreCommon.vsprops:
• WebCore.vcproj/WebCoreDebug.vsprops:
• WebCore.vcproj/WebCoreDebugAll.vsprops:
• WebCore.vcproj/WebCoreProduction.vsprops:
• WebCore.vcproj/WebCorePthreads.vsprops: Removed.
• WebCore.vcproj/WebCoreRelease.vsprops:
• WebCore.vcxproj/WebCoreCommon.props:
• WebCore.vcxproj/WebCoreDebug.props:
• WebCore.vcxproj/WebCoreDebugWinCairo.props:
• WebCore.vcxproj/WebCoreProduction.props:
• WebCore.vcxproj/WebCorePthreads.props: Removed.
• WebCore.vcxproj/WebCoreRelease.props:
• WebCore.vcxproj/WebCoreReleaseWinCairo.props:

5:12 PM Changeset in webkit [149336] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
​https://bugs.webkit.org/show_bug.cgi?id=115360
Internal PR 303048.

Patch by Jakob Petsovits <​jpetsovits@blackberry.com> on 2013-04-29
Reviewed by Rob Buis.

Instead of using fillBuffer() to draw directly to the
target buffer, we now lock a Drawable on it and fill it
with PlatformGraphicsContext::addPredefinedPattern().

As a bonus, this also includes related clean-ups -
simpler checkerboard painting code, removal of
fillWindow(), clearWindow() and paintDefaultBackground(),
as well as getting rid of the DEBUG_CHECKERBOARD define
which has been useless for performance tracing purposes
for a while now.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

• Api/BackingStore_p.h:

5:02 PM Changeset in webkit [149335] by ap@apple.com

• 2 edits in trunk/Tools

[WK2][Mac] Test with NetworkProcess enabled.

Fix the build for non-Mac.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):

4:59 PM Changeset in webkit [149334] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Do not allocate Static Strings for Notification::permissionString
​https://bugs.webkit.org/show_bug.cgi?id=115316

Reviewed by Geoffrey Garen.

The code is not nearly hot enough to justify keeping this memory around.

• Modules/notifications/Notification.cpp:

(WebCore::Notification::permission):
(WebCore::Notification::permissionString):

• Modules/notifications/Notification.h:

(Notification):

4:58 PM Changeset in webkit [149333] by ap@apple.com

• 3 edits in trunk/LayoutTests

REGRESSION (r149287?): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=115386

• platform/mac/TestExpectations: Skipping the test.
• platform/mac-wk2/TestExpectations: Removed it from here, as the assertion failure is not limited to wk2.

4:56 PM Changeset in webkit [149332] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] Streamline the use of strings in WebProcess::getWebCoreStatistics
​https://bugs.webkit.org/show_bug.cgi?id=115315

Reviewed by Geoffrey Garen.

Remove a couple of unjustified DEFINE_STATIC_LOCAL.
Use ASCIILiteral when allocating new String.

• WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

4:54 PM Changeset in webkit [149331] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Use push and pop for iOS math function thunks
​https://bugs.webkit.org/show_bug.cgi?id=115215

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-29
Reviewed by Filip Pizlo.

The iOS ABI is a little different than regular ARM ABI regarding stack alignment.
The requirement is 4 bytes:
"The ARM environment uses a stack that—at the point of function calls—is 4-byte aligned,

grows downward, and contains local variables and a function’s parameters."

Subsequently, we can just use push and pop to preserve the link register.

• jit/ThunkGenerators.cpp:

4:52 PM Changeset in webkit [149330] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r149287?): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=115386

• platform/mac-wk2/TestExpectations: Marked the test as crashing in debug.

4:26 PM Changeset in webkit [149329] by andersca@apple.com

• 6 edits in trunk/Source

Remove StorageTracker::originsLoaded
​https://bugs.webkit.org/show_bug.cgi?id=115382

Reviewed by Sam Weinig.

Source/WebCore:

Remove m_finishedImportingOriginIdentifiers.

• storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):

• storage/StorageTracker.h:

(StorageTracker):

Source/WebKit2:

Add m_didFinishLoadingOrigins.

• WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::didFinishLoadingOrigins):

• WebProcess/Storage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):

4:03 PM Changeset in webkit [149328] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Get rid of StorageTracker::setClient
​https://bugs.webkit.org/show_bug.cgi?id=115376

Reviewed by Sam Weinig.

• WebCore.exp.in:
• storage/StorageTracker.cpp:
• storage/StorageTracker.h:

(StorageTracker):

3:54 PM Changeset in webkit [149327] by Chris Fleizach

• 2 edits in trunk/Source/WebKit2

WEB SPEECH Update seatbelt profile to work with speech synthesis
​https://bugs.webkit.org/show_bug.cgi?id=115368

Reviewed by Alexey Proskuryakov.

• WebProcess/com.apple.WebProcess.sb.in:

3:44 PM Changeset in webkit [149326] by jpfau@apple.com

• 15 edits
  1 add in trunk

Change approach to third-party blocking for LocalStorage
​https://bugs.webkit.org/show_bug.cgi?id=115004

Reviewed by Maciej Stachowiak.

Source/WebCore:

Instead of outright blocking LocalStorage that's used in a third-party
context, silently partition it based on the origin of the top context.
These partitions are then discarded when the page group is unloaded.

No new tests; modified existing tests to account for changes.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::localStorage):

• page/PageGroup.cpp:

(WebCore::PageGroup::localStorage):
(WebCore):
(WebCore::PageGroup::transientLocalStorage):

• page/PageGroup.h:

(PageGroup):

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccessStorage):

LayoutTests:

• http/tests/security/cross-origin-local-storage-allowed-expected.txt:
• http/tests/security/cross-origin-local-storage-allowed.html:
• http/tests/security/cross-origin-local-storage-expected.txt:
• http/tests/security/cross-origin-local-storage-wk1.html:
• http/tests/security/cross-origin-local-storage-wk1-expected.txt:
• http/tests/security/cross-origin-local-storage.html:
• http/tests/security/resources/cross-origin-iframe-for-local-storage.html:
• http/tests/security/resources/load-local-storage.html: Added.
• platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt:
• platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt:

3:40 PM Changeset in webkit [149325] by Chris Fleizach

• 4 edits in trunk/WebKitLibraries

WEB SPEECH: need to identify the default voice per language
​https://bugs.webkit.org/show_bug.cgi?id=115366

Reviewed by Simon Fraser.

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

3:31 PM Changeset in webkit [149324] by mrowe@apple.com

• 2 edits in tags/Safari-537.39.2/Source/WebKit2

Merge r149302.

3:31 PM Changeset in webkit [149323] by mrowe@apple.com

• 4 edits in tags/Safari-537.39.2/Source

Versioning.

3:25 PM Changeset in webkit [149322] by commit-queue@webkit.org

• 5 edits in trunk

HTML Editing: Insertion point jumps when using link detection
​https://bugs.webkit.org/show_bug.cgi?id=82198

Source/WebCore:

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-04-29
Reviewed by Ryosuke Niwa.

Add links should be done only when typing a word separator (e.g. space or dot) which
breaks the text into two parts - the link and the rest of the text. Reflected in
code, we should only add link when the caret position is at the right end location of
TextChecking result. Otherwise, the text on the right of a word separator could be
highlighted as a link and the insertion point jumps unexpectedly.

Tests: update editing/inserting/typing-space-to-trigger-smart-link.html

• editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-04-29
Reviewed by Ryosuke Niwa.

Update typing-space-to-trigger-smart-link.html to verify link detection behavior
when typing a link before existing text.

• editing/inserting/typing-space-to-trigger-smart-link-expected.txt:
• editing/inserting/typing-space-to-trigger-smart-link.html:

3:19 PM Changeset in webkit [149321] by mrowe@apple.com

• 1 copy in tags/Safari-537.39.2

New tag.

3:06 PM Changeset in webkit [149320] by bfulgham@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

[Windows, WinCairo] Get rid of last few pthread include/link references.
​https://bugs.webkit.org/show_bug.cgi?id=115375

Reviewed by Tim Horton.

• JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
• JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
• JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
• JavaScriptCore.vcxproj/jsc/jscCommon.props:
• JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
• JavaScriptCore.vcxproj/testapi/testapiCommon.props:

3:05 PM Changeset in webkit [149319] by roger_fong@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin VS2010 build fix.

• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

2:53 PM Changeset in webkit [149318] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed. Tests mistakenly added to general TestExpectations file moved to mac TestExpectations file.

• TestExpectations:
• platform/mac/TestExpectations:

2:53 PM Changeset in webkit [149317] by Beth Dakin

• 11 edits in trunk/Source

Need a LayoutMilestone to fire when we have done our first paint after suppressing
incremental layout
​https://bugs.webkit.org/show_bug.cgi?id=115330
-and corresponding-
<rdar://problem/12722365>

Reviewed by Simon Fraser.

Source/WebCore:

To meet the needs of all of our clients, we really need two milestones. One
indicating that a layout has happened after setVisualUpdatesAllowed(true), and
another indicating that painting has happened.

If layout is needed when setVisualUpdatesAllowed(true) is called, we need to
update it so that we can guarantee the first paint is really happening at this
time. Also fire the DidFirstLayoutAfterSuppressedIncrementalRendering milestone,
and call add DidFirstPaintAfterSuppressedIncrementalRendering to the FrameView's
pending paint milestones.
up the painting milestone.

• dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):

FrameView now stores m_milestonesPendingPaint. We'll send and clear them once we
have painted.

• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::addPaintPendingMilestones):
(WebCore::FrameView::firePaintRelatedMilestones):

• page/FrameView.h:

(WebCore::FrameView::milestonesPendingPaint):

Two new milestones.

• page/LayoutMilestones.h:

(WebCore):

We don't need m_headerLayerAwaitingFirstFlush anymore since we can use FrameView's
pending paint milestones instead.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateLayerForHeader):

• rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

Source/WebKit2:

Two new millstones.

• Shared/API/c/WKPageLoadTypes.h:
• Shared/API/c/WKSharedAPICast.h:

(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):

This null-check is necessary now since this code ends up running at
WebFrame::init() time while we're setting up the Document.
setVisualUpdatesAllowed(true) has always been called as a part of that process,
and now the updateLayout(), ends up calling this code too, but we don't actually
have a mainFrame yet since it's still being created.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::findLargestFrameInFrameSet):

2:40 PM Changeset in webkit [149316] by jpfau@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed, added missing new line in baseline.

• fast/canvas/2d.imageDataHD-expected.txt:

2:36 PM Changeset in webkit [149315] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] Links can't be hovered or clicked with overlay scrollbars hidden.
​https://bugs.webkit.org/show_bug.cgi?id=99379

This is also <rdar://problem/10929565> Overlay scrollbars prevent hit-testing on
content underneath them, even when hidden

Reviewed by Beth Dakin.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

2:07 PM Changeset in webkit [149314] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Begin cleaning up StorageTracker
​https://bugs.webkit.org/show_bug.cgi?id=115373

Reviewed by Andreas Kling.

Rename Mutexes to use "Mutex" and not "Guard".
Don't use static locals for ".localstorage" and "*.localstorage" strings.
Put end iterator declarations together with begin declarations.

• storage/StorageTracker.cpp:

(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::databasePathForOrigin):
(WebCore::StorageTracker::diskUsageForOrigin):

• storage/StorageTracker.h:

(StorageTracker):

2:06 PM Changeset in webkit [149313] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Don't check for @media rules affected by viewport changes in every layout.
<​http://webkit.org/b/115370>
<rdar://problem/13765739>

Reviewed by Antti Koivisto.

Move the logic that checks if any @media rules are affected by a change in the viewport
size to FrameView::setFrameRect(). This way it's no longer necessary to do the style
recalc synchronously, which allows us to coalesce multiple updates in some cases.

• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::layout):

2:00 PM Changeset in webkit [149312] by roger_fong@apple.com

• 1 edit
  1 copy in trunk/WebKitLibraries

Need a tools32 folder for VS2010 builds.
tools folder will be nuked when we nuke VS2005.

• win/tools32: Copied from WebKitLibraries/win/tools.

1:55 PM Changeset in webkit [149311] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Remove the last StorageSyncManager function
​https://bugs.webkit.org/show_bug.cgi?id=115371

Reviewed by Sam Weinig.

Move the import scheduling to the StorageAreaSync constructor. Remove code to set m_importComplete to true
since that could only happen if the StorageSyncManager's thread is null which doesn't make any sense.

• storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::create):

• storage/StorageSyncManager.cpp:
• storage/StorageSyncManager.h:

(StorageSyncManager):

1:28 PM Changeset in webkit [149310] by ap@apple.com

• 2 edits in trunk/Tools

[WK2][Mac] Test with NetworkProcess enabled.

Reviewed by Sam Weinig.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):

1:17 PM Changeset in webkit [149309] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Set up the TestWebCore in TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=115237

Reviewed by Gustavo Noronha Silva.

Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
a workaround for the layer violations and circular dependencies between various static libraries. Linking against
either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).

• TestWebKitAPI/GNUmakefile.am:

1:16 PM Changeset in webkit [149308] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Remove unused method RenderMeter::valueRatio()
​https://bugs.webkit.org/show_bug.cgi?id=115266

Patch by Daker Fernandes Pinheiro <​daker.pinheiro@openbossa.org> on 2013-04-29
Reviewed by Darin Adler.

The removed method is not used anywhere.
No new tests are required.

• rendering/RenderMeter.cpp:
• rendering/RenderMeter.h:

(RenderMeter):

1:10 PM Changeset in webkit [149307] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Remove two more StorageSyncManager wrapper functions
​https://bugs.webkit.org/show_bug.cgi?id=115367

Reviewed by Andreas Kling.

• storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):

• storage/StorageSyncManager.cpp:
• storage/StorageSyncManager.h:

12:56 PM Changeset in webkit [149306] by schenney@chromium.org

• 3 edits
  2 adds in trunk

SVGElement destructor can use invalid iterator
​https://bugs.webkit.org/show_bug.cgi?id=115361

Reviewed by Philip Rogers.

Source/WebCore:

When an SVGElement object has rare data, its destructor gets a
hash map iterator for the rare data, uses it to clear resources,
then uses the iterator to delete the rare data. However, the resource
cleanup can delete other SVG elements, thus modifying the hash map
from which the iterator came and hence invalidating the iterator
itself.

The fix is to re-get the iterator before deleting the rare data.

Test: svg/custom/svg-element-destructor-iteration-crash.html

• svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement): Get a new iterator after clearing rare data.

LayoutTests:

Test asserts in Debug and should also crash in memory checking builds.

• svg/custom/svg-element-destructor-iteration-crash-expected.txt: Added.
• svg/custom/svg-element-destructor-iteration-crash.html: Added.

12:52 PM Changeset in webkit [149305] by mhahnenberg@apple.com

• 3 edits in trunk/Source/JavaScriptCore

~BlockAllocator should ASSERT that it has no more Regions left
​https://bugs.webkit.org/show_bug.cgi?id=115287

Reviewed by Andreas Kling.

• heap/BlockAllocator.cpp:

(JSC::BlockAllocator::~BlockAllocator):
(JSC::BlockAllocator::allRegionSetsAreEmpty):

• heap/BlockAllocator.h:

(RegionSet):
(JSC::BlockAllocator::RegionSet::isEmpty):
(BlockAllocator):

12:08 PM Changeset in webkit [149304] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

IndexingTypes should use hex
​https://bugs.webkit.org/show_bug.cgi?id=115286

Decimal is kind of confusing/hard to read because they're used as bit masks. Hex seems more appropriate.

Reviewed by Geoffrey Garen.

• runtime/IndexingType.h:

12:07 PM Changeset in webkit [149303] by beidson@apple.com

• 30 edits in trunk/Source

REGRESSION: We see authentication challenge sheets for favicon requests.
<rdar://problem/13753470> and ​https://bugs.webkit.org/show_bug.cgi?id=115288

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (Not in a tested config, might fix existing test).

Rename ClientCrossOriginCredentialPolicy to ClientCredentialPolicy, make it be three options.
and move it to ResourceHandleTypes where it belongs:

• loader/ResourceLoaderOptions.h:
• platform/network/ResourceHandleTypes.h:

Expose the ClientCredentialPolicy the ResourceLoader was created with:

• loader/ResourceLoader.h:

(WebCore::ResourceLoader::clientCredentialPolicy):

Rework the “should ask client” clause for the new values of ClientCredentialPolicy:

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

Rework loadResourceSynchronously() to include a ClientCredentialPolicy argument:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

• loader/FrameLoader.h:
• loader/LoaderStrategy.cpp:

(WebCore::LoaderStrategy::loadResourceSynchronously):

• loader/LoaderStrategy.h:

Never ask the client for credentials for icon loads:

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

Update all other users of ClientCredentialPolicy to the appropriate new value,
and update all users of loadResourceSynchronously to the new function signature:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::loadResourceSynchronously):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

• loader/FrameLoader.h:

(FrameLoader):

• loader/LoaderStrategy.cpp:

(WebCore::LoaderStrategy::loadResourceSynchronously):

• loader/LoaderStrategy.h:

(LoaderStrategy):

• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):

• WebCore.exp.in:

Source/WebKit2:

Have NetworkResourceLoadParameters remember the ClientCredentialPolicy:

• Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

• Shared/Network/NetworkResourceLoadParameters.h:

Pass along the ClientCredentialPolicy to the NetworkProcess:

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Have the SchedulableLoader remember the ClientCredentialPolicy:

• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• NetworkProcess/SchedulableLoader.h:

(WebKit::SchedulableLoader::clientCredentialPolicy):

Don’t message for credentials if the ClientCredentialPolicy forbids it:

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):

• NetworkProcess/NetworkResourceLoader.h:

Update for the new loadResourceSynchronously signature (which is still a no-op on the NetworkProcess side):

• NetworkProcess/NetworkProcessPlatformStrategies.cpp:

(WebKit::NetworkProcessPlatformStrategies::loadResourceSynchronously):

• NetworkProcess/NetworkProcessPlatformStrategies.h:

11:53 AM Changeset in webkit [149302] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix. Point the Network process towards its own version of SecItemShim.dyld.

• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:

11:31 AM Changeset in webkit [149301] by fpizlo@apple.com

• 16 edits
  4 adds in branches/dfgFourthTier/Source

fourthTier: ASSERT that commonly used not-thread-safe methods in the runtime are not being called during compilation
​https://bugs.webkit.org/show_bug.cgi?id=115297

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Put in assertions that we're not doing bad things in compilation threads. Also
factored compilation into compile+link so that even though we don't yet have
concurrent compilation, we can be explicit about which parts of DFG work are
meant to be concurrent, and which aren't.

Also fix a handful of bugs found by these assertions.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):

• bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::add):
(JSC::InlineWatchpointSet::inflateSlow):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::~JITCompiler):
(DFG):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):

• dfg/DFGJITCompiler.h:

(JITCompiler):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLCompile.h:

(FTL):

• ftl/FTLLink.cpp: Added.

(FTL):
(JSC::FTL::compileEntry):
(JSC::FTL::link):

• ftl/FTLLink.h: Added.

(FTL):

• ftl/FTLState.cpp:

(JSC::FTL::State::State):

• ftl/FTLState.h:

(FTL):
(State):

• runtime/Structure.cpp:

(JSC::Structure::get):
(JSC::Structure::prototypeChainMayInterceptStoreTo):

• runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessary):

• runtime/StructureInlines.h:

(JSC::Structure::get):

Source/WTF:

Reviewed by Geoffrey Garen.

Taught WTF the notion of compilation threads. This allows all parts of our stack
to assert that we're not being called from a JSC compilation thread. This is in
WTF because it will probably end up being used in StringImpl and WTFString.

• WTF.xcodeproj/project.pbxproj:
• wtf/CompilationThread.cpp: Added.

(WTF):
(WTF::initializeCompilationThreadsOnce):
(WTF::initializeCompilationThreads):
(WTF::isCompilationThread):
(WTF::exchangeIsCompilationThread):

• wtf/CompilationThread.h: Added.

(WTF):
(CompilationScope):
(WTF::CompilationScope::CompilationScope):
(WTF::CompilationScope::~CompilationScope):
(WTF::CompilationScope::leaveEarly):

11:26 AM Changeset in webkit [149300] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Add a StorageSyncManager::dispatch helper function
​https://bugs.webkit.org/show_bug.cgi?id=115365

Reviewed by Andreas Kling.

• storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::dispatch):
(WebCore):
(WebCore::StorageSyncManager::close):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

• storage/StorageSyncManager.h:

(StorageSyncManager):

11:19 AM Changeset in webkit [149299] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Re-indent StorageSyncManager and remove SecurityOrigin forward declaration.

Rubber-stamped by Andreas Kling.

• storage/StorageSyncManager.h:

11:08 AM Changeset in webkit [149298] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Threads get stuck in NetworkProcess when canceling loads
​https://bugs.webkit.org/show_bug.cgi?id=115319

Backing out part of the fix, as it's causing crashes.

• WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

11:06 AM Changeset in webkit [149297] by andersca@apple.com

• 12 edits
  2 deletes in trunk/Source/WebCore

Get rid of StorageTask
​https://bugs.webkit.org/show_bug.cgi?id=115313

Reviewed by Andreas Kling.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• storage/StorageSyncManager.cpp:
• storage/StorageTask.cpp: Removed.
• storage/StorageTask.h: Removed.
• storage/StorageThread.cpp:

(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):

• storage/StorageThread.h:

(StorageThread):

• storage/StorageTracker.cpp:

10:38 AM Changeset in webkit [149296] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=115236

Reviewed by Gustavo Noronha Silva.

Set up the TestJavaScriptCore unit test program, consisting of the unit tests
under the TestWebKitAPI/Tests/JavaScriptCore directory.

• TestWebKitAPI/GNUmakefile.am:

10:30 AM May 2013 Meeting edited by Simon Fraser

(diff)

10:13 AM Changeset in webkit [149295] by Patrick Gansterer

• 2 edits in trunk/Source/WTF

[WIN] Add workaround for UNUSED_PARAM()
​https://bugs.webkit.org/show_bug.cgi?id=115350

Reviewed by Andreas Kling.

r147882 added an workaround for the MSVC compiler on Windows CE.
Extend this workaround to whole MSVC compiler, since the same
problem occurs with the Visual Studio 10 compiler too.

• wtf/UnusedParam.h:

10:12 AM Changeset in webkit [149294] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Add branch-prediction hint to FAST_RETURN_IF_NO_FRONTENDS.
<​http://webkit.org/b/115357>

Reviewed by Anders Carlsson.

Since this macro is used in some very hot code paths, give the compiler an extra hint
to try and minimize the impact it has when the inspector is not active.

• inspector/InspectorInstrumentation.h:

9:33 AM Changeset in webkit [149293] by Patrick Gansterer

• 6 edits in trunk/Source

[WIN] Add WTF_USE_IMLANG_FONT_LINK2
​https://bugs.webkit.org/show_bug.cgi?id=115198

Reviewed by Andreas Kling.

Source/WebCore:

Add this new define to have a central place for switching
the IMLangFontLinkType and adop all usages of the type.
This makes the usage of the code easier on desktop pcs.

• platform/graphics/FontCache.h:

(WebCore):

• platform/graphics/wince/FontCacheWinCE.cpp:

(WebCore::currentFontContainsCharacter):
(WebCore::createMLangFont):
(WebCore::FontCache::getFontDataForCharacters):

• platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::containsCharacters):

Source/WTF:

• wtf/Platform.h:

9:24 AM Changeset in webkit [149292] by commit-queue@webkit.org

• 7 edits in trunk/Source

Get rid of "non-composited contents" in CoordinatedLayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=110355

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-29
Reviewed by Jocelyn Turcotte.

Source/WebCore:

When in force compositing mode, always assume that the main layer needs
a backing store. Make setVisibleContentRectTrajectoryVector and accumulatedCoverRect
recursive so that they don't rely on a specialized layer.

No new testable behavior, changes to coverRect and trajectory vector only
affect tiling latency in rare cases that are not trivial to test.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer:setVisibleContentRectTrajectoryVector):

Make the trajectory vector recursive, though limited only to layers with
translate/identity. This allows us to keep the trajectory vector while removing
the non-composited contents specialization.

(WebCore::CoordinatedGraphicsLayer::accumulatedCoverRect):

Added accumulatedCoverRect, so that the coverRect calculations for the UI process
are not bound to the non-composited contents layer.

(WebCore::CoordinatedGraphicsLayer::findDescendantWithContentsRecursively):

Instead of saving a reference to the non-composited contents layer, we assume that
the first layer we found recursively which has contents is the one to be used for
coverRect/trajectory calculations.

(WebCore):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsIntoWindow):

Always create a layer for the non-composited contents when in forceCompositing mode.

Source/WebKit2:

Instead of using a special non-composited contents layer, we let RenderLayerCompositor create
a proper GraphicsLayer for that content.
CoordinatedLayerTreeHost now needs to find the main contents layer for the purpose of setting
the trajectory vector and applying the cover rect.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):

Don't create the non-composited layer, instead keep a raw pointer to the root
compositing layer created by the WebCore compositor.

(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::paintContents):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):

Remove non-composited layer specialization.

9:07 AM Changeset in webkit [149291] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt] Build fix. Enabling c++11 for Qt WK2 after r149259.
​https://bugs.webkit.org/show_bug.cgi?id=115345

Reviewed by Anders Carlsson.

• WebKit2.pri:

8:59 AM Changeset in webkit [149290] by Patrick Gansterer

• 2 edits in trunk/Source/WTF

Define USE(ICU_UNICODE) if USE(WCHAR_UNICODE) is false
​https://bugs.webkit.org/show_bug.cgi?id=115349

Reviewed by Andreas Kling.

Since we support only ICU and WCHAR as Unicode backend (ICU is the default)
automatically use ICU if WCHAR was not selected via compiler defines.

• wtf/Platform.h:

8:57 AM Changeset in webkit [149289] by Bruno de Oliveira Abinader

• 10 edits in trunk/Source/WebKit2

[WK2][EFL] Skip cancel fullscreen request if not made from FullScreen API
​https://bugs.webkit.org/show_bug.cgi?id=108201

Reviewed by Andreas Kling.

Adds a check on WebFullScreenManagerProxyEfl whether fullscreen mode was
set from FullScreen API or not, so it can skip cancelling fullscreen
request if fullscreen mode was set by application, preventing
WebProcess' FullScreenManager from crashing.

EFL unit test available: ewk_view_cancel_full_screen_request.

• UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewExitFullScreen):

• UIProcess/API/C/CoordinatedGraphics/WKView.h:

WKViewExitFullScreen now returns a bool, indicating whether the
operation has succeeded or not.

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_fullscreen_exit):
Skip request if not in fullscreen mode.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Added ewk_view_cancel_full_screen_request unit test.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::exitFullScreen):

• UIProcess/CoordinatedGraphics/WebView.h:

(WebView):
exitFullScreen now returns a bool, indicating whether the operation has
succeeded or not.

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):

• UIProcess/WebFullScreenManagerProxy.h:

(WebFullScreenManagerProxy):

• UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
Added m_hasRequestedFullScreen boolean flag to EFL port. Used to
indicate if fullscreen mode is enabled, as well as sanity checks on both
{enter,exit}FullScreen functions.

8:46 AM Changeset in webkit [149288] by krit@webkit.org

• 4 edits in trunk

Animate clip rect() between different Length types
​https://bugs.webkit.org/show_bug.cgi?id=115336

Reviewed by Andreas Kling.

Source/WebCore:

At the moment the animation for the 'clip' property
has an early return if the type of two Length values
does not match. This patch removes this early return.

Modified existing tests to cover the changes.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

LayoutTests:

Modify test for clip animation to cover animations between
different Length types.

• transitions/clip-transition.html:

8:33 AM Changeset in webkit [149287] by akling@apple.com

• 5 edits in trunk/Source/WebCore

When updating geometry, send JavaScript resize before before layout/paint.
<​http://webkit.org/b/115199>
<rdar://problem/13735535>

Reviewed by Geoffrey Garen.

Make the "resize" event synchronous and dispatch it before doing any automatic
resize-induced layout. This avoids unnecessary work in cases where an event handler
does something that dirties style.

It also avoids a kind of JS-side FOUC that happens if we drop out to the runloop
and paint before the resize event handler runs; for example, when viewing a popup
on <​http://lokeshdhakar.com/projects/lightbox2/> and resizing the window, the dark
overlay sometimes resizes out of sync with the web view, since a paint may happen
between automatic layout and the resize event.

• page/EventHandler.h:
• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchResizeEvent):

• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::dispatchResizeEvent):

Renamed sendResizeEvent() to dispatchResizeEvent() and made it dispatch the event
synchronously instead of adding it to the DocumentEventQueue.

(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::setFrameRect):

Dispatch the "resize" event right when the new frame rect is set.

8:30 AM Changeset in webkit [149286] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Stop using range-based for syntax
​https://bugs.webkit.org/show_bug.cgi?id=115356

Reviewed by Andreas Kling.

• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didClose):

8:22 AM Changeset in webkit [149285] by Patrick Gansterer

• 2 edits in trunk/Source/WTF

Build fix for WinCE after r148888 and r149097
​https://bugs.webkit.org/show_bug.cgi?id=115168

Reviewed by Anders Carlsson.

When using compiler intrinsics on Windows CE the compiler complains
about wrong linkage specification of replaced CRT functions defined
in math.h. This is because the compiler has intrinsics for this
functions defined, and requires them to have extern "C" linkage.

• wtf/MathExtras.h:

(wtf_atan2): Added extern "C" to function signature.
(wtf_fmod): Ditto.
(wtf_pow): Ditto.

8:04 AM Changeset in webkit [149284] by Patrick Gansterer

• 5 edits in trunk/Source/WebCore

Remove OS(WINCE) from (Render|Scrollbar)ThemeWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115348

Reviewed by Andreas Kling.

Compile DIBPixelData.cpp on Windows CE too, which allows us
to get rid of a few #if OS(WINCE) in other code parts.

• PlatformWinCE.cmake:
• platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::setRGBABitmapAlpha):

• platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

• rendering/RenderThemeWin.cpp:

(WebCore::drawControl):

7:55 AM Changeset in webkit [149283] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2]: WebProcessMain: hide call to ecore_x_shutdown() under guard
​https://bugs.webkit.org/show_bug.cgi?id=115295

Patch by Sergio Correia <Sergio Correia> on 2013-04-29
Reviewed by Andreas Kling.

Since the mentioned function is declared in a header that is included
conditionally depending on HAVE_ECORE_X being defined.

• WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

7:46 AM Changeset in webkit [149282] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[BlackBerry] Fake-bold monospace fonts need to use non-fake-bold advances
​https://bugs.webkit.org/show_bug.cgi?id=115280

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-04-29
Reviewed by George Staikos.

BlackBerry PR 330864

Tested by fast/css/css3-ch-unit.html

• platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:

(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::isFixedPitch):

• platform/graphics/blackberry/ITypeUtils.h:
• platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph):

7:36 AM Changeset in webkit [149281] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[GTK][AC] Clean up code related with the children management stuff for clutter based AC
​https://bugs.webkit.org/show_bug.cgi?id=114260

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-29
Reviewed by Gustavo Noronha Silva.

Remove unused or usless code for children management stuff.

No new tests since no functionality changed.

• platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphics_layer_actor_class_init):
(graphicsLayerActorAllocate):
(graphicsLayerActorDraw):
(graphicsLayerActorNew):
(graphicsLayerActorSetSublayers):

• platform/graphics/clutter/GraphicsLayerActor.h:
• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::updateLayerDrawsContent):

7:26 AM Changeset in webkit [149280] by Patrick Gansterer

• 3 edits in trunk/Source/WebCore

[WIN] Guard cfHDropFormat() with USE(CF) instead of OS(WINCE)
​https://bugs.webkit.org/show_bug.cgi?id=115195

Reviewed by Andreas Kling.

USE(CF) is the correct guard, which works on desktop pcs too.

• platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

• platform/win/DragDataWin.cpp:

(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):

7:16 AM Changeset in webkit [149279] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[WK2] Remove build warnings by -Wunused-parameter
​https://bugs.webkit.org/show_bug.cgi?id=115344

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-04-29
Reviewed by Noam Rosenthal.

Fix build warnigs -Wunused-parameter.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createContextMenuProxy):

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::connectionWillClose):

7:06 AM Changeset in webkit [149278] by zarvai@inf.u-szeged.hu

• 1 edit
  67 moves
  37 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Move Qt Mac specific results to qt-mac after r149210.

• platform/qt-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/qt-5.0/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
• platform/qt-mac/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/qt-5.0/editing/selection/collapse-selection-in-bidi-expected.txt.
• platform/qt-mac/editing/selection/drag-start-event-client-x-y-expected.txt: Renamed from LayoutTests/platform/qt-5.0/editing/selection/drag-start-event-client-x-y-expected.txt.
• platform/qt-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
• platform/qt-mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/block/basic/fieldset-stretch-to-legend-expected.txt.
• platform/qt-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
• platform/qt-mac/fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/borders/fieldsetBorderRadius-expected.txt.
• platform/qt-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt.
• platform/qt-mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt.
• platform/qt-mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt.
• platform/qt-mac/fast/events/document-elementFromPoint-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/events/document-elementFromPoint-expected.txt.
• platform/qt-mac/fast/flexbox/flex-hang-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/flexbox/flex-hang-expected.txt.
• platform/qt-mac/fast/images/repaint-subrect-grid-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/images/repaint-subrect-grid-expected.txt.
• platform/qt-mac/fast/images/zoomed-img-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/images/zoomed-img-size-expected.txt.
• platform/qt-mac/fast/multicol/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/break-properties-expected.txt.
• platform/qt-mac/fast/multicol/vertical-lr/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/vertical-lr/break-properties-expected.txt.
• platform/qt-mac/fast/multicol/vertical-rl/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/vertical-rl/break-properties-expected.txt.
• platform/qt-mac/fast/overflow/infiniteRecursionGuard-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/overflow/infiniteRecursionGuard-expected.txt.
• platform/qt-mac/fast/parser/style-script-head-test-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/parser/style-script-head-test-expected.txt.
• platform/qt-mac/fast/reflections/reflection-with-zoom-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/reflections/reflection-with-zoom-expected.txt.
• platform/qt-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt.
• platform/qt-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt.
• platform/qt-mac/http/tests/misc/acid3-expected.txt: Renamed from LayoutTests/platform/qt-5.0/http/tests/misc/acid3-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt.
• platform/qt-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt.
• platform/qt-mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/svg-non-integer-scaled-image-expected.txt.
• platform/qt-mac/svg/custom/fractional-rects-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/fractional-rects-expected.txt.
• platform/qt-mac/svg/custom/js-update-container-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/js-update-container-expected.txt.
• platform/qt-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt.
• platform/qt-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt.
• platform/qt-mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt.
• platform/qt-mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
• platform/qt-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt.
• platform/qt-mac/svg/custom/viewBox-hit-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/viewBox-hit-expected.txt.
• platform/qt-mac/svg/hixie/text/001-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/hixie/text/001-expected.txt.
• platform/qt-mac/svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/hixie/text/003a-expected.txt.
• platform/qt-mac/svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/small-fonts-2-expected.txt.
• platform/qt-mac/svg/text/text-hkern-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/text-hkern-expected.txt.
• platform/qt-mac/svg/text/text-viewbox-rescale-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/text-viewbox-rescale-expected.txt.
• platform/qt-mac/svg/wicd/sizing-flakiness-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/wicd/sizing-flakiness-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-background-image-tiled-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-image-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-object-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-relative-image-expected.txt.
• platform/qt-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt.
• platform/qt-mac/tables/mozilla/bugs/bug83786-expected.txt: Renamed from LayoutTests/platform/qt-5.0/tables/mozilla/bugs/bug83786-expected.txt.

4:28 AM Changeset in webkit [149277] by Carlos Garcia Campos

• 9 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

• GNUmakefile.list.am: Add missing headers files to compilation

and offlineasm/sh4.rb script.

Source/WebCore:

• GNUmakefile.am: Add missing scripts to EXTRA_DIST.
• GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

• GNUmakefile.list.am: Add missing header files to compilation.

Source/WTF:

• GNUmakefile.list.am: Add missing header file to compilation.

2:52 AM Changeset in webkit [149276] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[Qt] fast/canvas/webgl/webgl-composite-modes.html broken after r148433.
​https://bugs.webkit.org/show_bug.cgi?id=115243

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-29
Reviewed by Jocelyn Turcotte.

When compositing a layer with a canvas or directly composited image, it is
wrong to use TextureMapperLayer::setBackingStore. Instead, setContentsLayer
should be used, which allows for the layer to have both a backing store and
a contents layer.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):

• platform/graphics/texmap/TextureMapperLayer.h:

(State):
(WebCore::TextureMapperLayer::State::State):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):

2:44 AM Changeset in webkit [149275] by Patrick Gansterer

• 3 edits in trunk/Source/WebKit/wince

Unreviewed build fix.

• WebCoreSupport/FrameLoaderClientWinCE.cpp: Added missing header.
• WebView.h: Ditto.

2:03 AM Changeset in webkit [149274] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• bindings/js/WorkerScriptDebugServer.cpp: Added missing header.

1:56 AM Changeset in webkit [149273] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

1:47 AM Changeset in webkit [149272] by Patrick Gansterer

• 3 edits in trunk/Source/WebCore

Remove OS(WINCE) from HTMLSelectElement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115194

Reviewed by Andreas Kling.

Use the same files like the the other PLATFORM(WIN) ports use.

• PlatformWinCE.cmake:
• html/HTMLSelectElement.cpp:

(WebCore):

1:05 AM Changeset in webkit [149271] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
​https://bugs.webkit.org/show_bug.cgi?id=115323

Reviewed by Philippe Normand.

Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
Its presence enforces linkers to output mangled symbols when reporting linking failures
due to unresolved references. People trying to fix the build can then simply copy
the printed mangled symbol into the symbols.filter file instead of doing a manual build
or connecting to the builders to discover the mangled version of the missing symbol.

• BuildSlaveSupport/gtk/daemontools-buildbot.conf:

Apr 28, 2013:

11:51 PM Changeset in webkit [149270] by zandobersek@gmail.com

• 3 edits
  1 delete in trunk/Tools

Remove Chromium code from Tools/BuildSlaveSupport
​https://bugs.webkit.org/show_bug.cgi?id=115325

Reviewed by Benjamin Poulain.

Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
covering archiving test results and built products.

• BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

• BuildSlaveSupport/chromium/output-android-device-status: Removed.
• BuildSlaveSupport/chromium/remove-crash-logs: Removed.
• BuildSlaveSupport/test-result-archive:

(archiveTestResults):

11:43 PM Changeset in webkit [149269] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove support for Chromium from webkitdirs.pm
​https://bugs.webkit.org/show_bug.cgi?id=115338

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-28
Reviewed by Darin Adler.

• Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):

11:17 PM Changeset in webkit [149268] by zandobersek@gmail.com

• 11 edits in trunk

Rename TestRunner's setAudioData to setAudioResult
​https://bugs.webkit.org/show_bug.cgi?id=115326

Reviewed by Darin Adler.

Tools:

Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
than the previous one. The change is a simple rename, there's no change in the method's functionality. The
affected tests are adjusted accordingly.

• DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::setAudioResult):

• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioResult):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Adjust the testRunner.setAudioData references/callsites, the method is now named setAudioResult.

• platform/efl-wk1/TestExpectations:
• webaudio/resources/audio-codec-test.js:

(finishedLoading):

• webaudio/resources/audio-testing.js:

(finishAudioTest):

• webaudio/test-basic.html:

10:04 PM Changeset in webkit [149267] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed fix build break on EFL port since r149259.

In EFL port, there is a non-compatible code when compiling based on C++11. This is a trivial build fix.

I got a confirm from Sam about landing a trivial build fix patch without sign-off from
WK2 owner.

• UIProcess/API/efl/EwkViewCallbacks.h:

9:13 PM Changeset in webkit [149266] by ryuan.choi@samsung.com

• 2 edits in trunk

[EFL][CMAKE] Build break after r149259
​https://bugs.webkit.org/show_bug.cgi?id=115339

Reviewed by Gyuyoung Kim.

r149259 used c++11 features(Right angle bracket, Range-based for-loop).
This patch enforces c++0x when cmake based ports build WebKit2 using gcc.

• Source/cmake/WebKitHelpers.cmake:

5:57 PM Changeset in webkit [149265] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Get rid of a duplicate file from LayoutTests/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=115337

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-28

• TestExpectations: Remove one of two svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm.

5:40 PM Changeset in webkit [149264] by fpizlo@apple.com

• 8 edits in branches/dfgFourthTier/Source/JavaScriptCore

FTL should support double variables
​https://bugs.webkit.org/show_bug.cgi?id=113624

Reviewed by Geoffrey Garen.

Made all of the operations that the FTL already supports, also support doubles.
OSR exit already basically had everything it needed, so no changes there. This
mostly just glues together bits of DFG IR to LLVM IR, in a straight-forward way.

• ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::doubleType):
(JSC::FTL::constReal):
(JSC::FTL::buildPhi):
(JSC::FTL::addIncoming):
(JSC::FTL::buildFAdd):
(JSC::FTL::buildFSub):
(JSC::FTL::buildFMul):
(JSC::FTL::buildFNeg):
(JSC::FTL::buildSIToFP):
(JSC::FTL::buildUIToFP):
(JSC::FTL::buildBitCast):
(JSC::FTL::buildFCmp):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

• ftl/FTLCommonValues.h:

(CommonValues):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::isCellOrMisc):
(JSC::FTL::LowerDFGToLLVM::unboxDouble):
(JSC::FTL::LowerDFGToLLVM::boxDouble):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateNumber):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

• ftl/FTLOutput.h:

(JSC::FTL::Output::constDouble):
(Output):
(JSC::FTL::Output::phi):
(JSC::FTL::Output::doubleAdd):
(JSC::FTL::Output::doubleSub):
(JSC::FTL::Output::doubleMul):
(JSC::FTL::Output::doubleNeg):
(JSC::FTL::Output::intToFP):
(JSC::FTL::Output::intToDouble):
(JSC::FTL::Output::unsignedToFP):
(JSC::FTL::Output::unsignedToDouble):
(JSC::FTL::Output::bitCast):
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqual):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):
(JSC::FTL::Output::testIsZero64):

3:45 PM Changeset in webkit [149263] by rniwa@webkit.org

• 4 edits in trunk/Source/WebKit

Windows build fix.

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

• WebKit.vcproj/WebKitExports.def.in:

3:21 PM Changeset in webkit [149262] by rniwa@webkit.org

• 18 edits
  2 deletes in trunk/Source

StaticHashSetNodeList is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=115219

Reviewed by Antonio Gomes.

Source/WebCore:

Moved Document::nodesFromRect into Internals::nodesFromRect per
​https://chromium.googlesource.com/chromium/blink/+/78207c5c34383fbb807bb9347deb67168f09bb04.

Also made TouchAdjustment functions use HashListSet directly instead of wrapping it inside
a StaticHashSetNodeList since there was no need to use the latter.

With these two changes, I deleted StaticHashSetNodeList.

• GNUmakefile.list.am:
• Target.pri:
• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp:

(WebCore):

• dom/Document.h:

(Document):

• dom/StaticHashSetNodeList.cpp: Removed.
• dom/StaticHashSetNodeList.h: Removed.
• page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

• page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
(WebCore::findBestZoomableArea):

• page/TouchAdjustment.h:

(WebCore):

• testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

• WebKit.vcproj/WebKitExports.def.in:

2:52 PM Changeset in webkit [149261] by dino@apple.com

• 12 edits
  2 deletes in trunk

[Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
​https://bugs.webkit.org/show_bug.cgi?id=115310

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Disable the automatic pixel doubling in canvas backing stores on high
dpi devices. This will potentially make canvases look worse of high dpi
displays, but only if they were ignoring devicePixelRatio. Since the
majority of high dpi displays *do not* auto-double (including mobile
devices and other desktop browsers), this provides consistency and less
chance of unnecessary memory use.

• Configurations/FeatureDefines.xcconfig: Remove ENABLE_HIGH_DPI_CANVAS_macosx.

Source/WebKit/mac:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

• Configurations/FeatureDefines.xcconfig:

LayoutTests:

No need for platform-specific results any more.

• fast/canvas/2d.backingStorePixelRatio-expected.txt:
• fast/canvas/2d.imageDataHD-expected.txt:
• fast/canvas/canvas-resize-reset-pixelRatio-expected.txt:
• platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Removed.
• platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Removed.

1:31 PM Changeset in webkit [149260] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

[WebKit2] Adopt new API for detecting window occlusion
​https://bugs.webkit.org/show_bug.cgi?id=115334

Reviewed by Simon Fraser.

Switch off of WKSI for window occlusion and use the new NSWindowDidChangeOcclusionState notification
instead.

• UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView viewWillMoveToWindow:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView _setIsWindowOccluded:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
Only compile occlusion detection code where supported and remove calls to register/deregister
for detection callbacks, now that NSWindow will handle that for us. We also no longer need to
track all the WKViews, as that was only required to lookup the view that matched the window number
returned from the occlusion callback.

11:17 AM Changeset in webkit [149259] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Use OwnPtr<PluginControllerProxy> for storing plug-in controllers in WebProcessConnection
​https://bugs.webkit.org/show_bug.cgi?id=115259

Reviewed by Andreas Kling.

• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::didClose):

• PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

5:39 AM Changeset in webkit [149258] by zandobersek@gmail.com

• 3 edits
  17 deletes in trunk

[WKTR] Tests dumping audio data shouldn't dump pixels
​https://bugs.webkit.org/show_bug.cgi?id=115270

Reviewed by Benjamin Poulain.

Tools:

Prevent dumping the pixel output when Web Audio tests are dumping output data
as the testing output. Pixel output in these tests has no real meaning and is
as such unnecessary.

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioData):

LayoutTests:

Remove the now-unnecessary pixel baselines for audio tests that were used on the EFL WK2 platform.

• platform/efl-wk2/webaudio/audiobuffersource-expected.png: Removed.
• platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png: Removed.
• platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png: Removed.
• platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png: Removed.
• platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png: Removed.
• platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Removed.
• platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png: Removed.
• platform/efl-wk2/webaudio/gain-expected.png: Removed.
• platform/efl-wk2/webaudio/mixing-expected.png: Removed.
• platform/efl-wk2/webaudio/oscillator-custom-expected.png: Removed.
• platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png: Removed.
• platform/efl-wk2/webaudio/oscillator-sine-expected.png: Removed.
• platform/efl-wk2/webaudio/oscillator-square-expected.png: Removed.
• platform/efl-wk2/webaudio/oscillator-triangle-expected.png: Removed.
• platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png: Removed.
• platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png: Removed.
• platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png: Removed.

2:38 AM Changeset in webkit [149257] by Christophe Dumez

• 61 edits in trunk/Source/WebCore

Get rid of [Callback] IDL extended attribute for parameters
​https://bugs.webkit.org/show_bug.cgi?id=115250

Reviewed by Kentaro Hara.

Remove the WebKit-specific [Callback] extended attribute and make the bindings
generator smart enough to know when a parameter is of callback type on its
own.

No new tests, no behavior change.

• DerivedSources.make: Use WebCore/Modules as IDL include path instead of using

subdirs. The generator will search recursively anyway and the list of subdirs was
incomplete.

• Modules/filesystem/DOMWindowFileSystem.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/WorkerContextFileSystem.idl:
• Modules/mediastream/NavigatorMediaStream.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/notifications/Notification.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/WorkerContextWebDatabase.idl:
• bindings/gobject/GNUmakefile.am: Add missing IDL include dirs.
• bindings/scripts/CodeGenerator.pm:

(IsWrapperType):
(IsCallbackInterface):

• bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):
(GenerateParametersCheck):

• bindings/scripts/IDLAttributes.txt: Remove "Callback" extended attribute.
• bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::callbackWithArrayParam):
(WebDOMTestCallback::callbackWithSerializedScriptValueParam):
(WebDOMTestCallback::callbackWithNonBoolReturnType):
(WebDOMTestCallback::callbackRequiresThisToPass):

• bindings/scripts/test/CPP/WebDOMTestCallback.h:

(WebDOMTestCallback):

• bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):

• bindings/scripts/test/CPP/WebDOMTestObj.h:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::acceptTransferList):
(WebDOMTestSerializedScriptValueInterface::multiTransferList):

• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

• bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:

(WebDOMTestTypedefs::multiTransferList):

• bindings/scripts/test/CPP/WebDOMTestTypedefs.h:

(WebDOMTestTypedefs):

• bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(webkit_dom_test_callback_callback_with_array_param):
(webkit_dom_test_callback_callback_with_serialized_script_value_param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_requires_this_to_pass):

• bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):

• bindings/scripts/test/GObject/WebKitDOMTestObj.h:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:

(webkit_dom_test_typedefs_multi_transfer_list):

• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
• bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithArrayParam):
(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallback::callbackRequiresThisToPass):

• bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):

• bindings/scripts/test/ObjC/DOMTestCallback.h:
• bindings/scripts/test/ObjC/DOMTestCallback.mm:

(-[DOMTestCallback callbackWithArrayParam:]):
(-[DOMTestCallback callbackWithSerializedScriptValueParam:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback callbackRequiresThisToPass:testNodeParam:]):

• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):
(-[DOMTestSerializedScriptValueInterface multiTransferList:tx:second:txx:]):

• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:

(-[DOMTestTypedefs multiTransferList:tx:second:txx:]):

• bindings/scripts/test/TestCallback.idl: Use valid types instead of Class1, Class2, ...

so that the bindings generator does not complain about not being able to resolve
them.

• bindings/scripts/test/TestObj.idl: Use valid parameter types instead of 'a', 'b', 'd', 'e'

so that the bindings generator does not complain about them.

• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestTypedefs.idl:
• css/FontLoader.idl:
• dom/DataTransferItem.idl:
• page/DOMWindow.idl:

Apr 27, 2013:

9:53 PM Changeset in webkit [149256] by jberlin@webkit.org

• 2 edits in trunk/Source/WebKit2

Build fix.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Do not declare another variable with the same name.

8:51 PM Changeset in webkit [149255] by Darin Adler

• 171 edits in trunk/Source

Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
​https://bugs.webkit.org/show_bug.cgi?id=115307

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• heap/HeapTimer.cpp:

(JSC::HeapTimer::HeapTimer):

• runtime/VM.cpp:

(JSC::enableAssembler):
Use adoptCF free function.

Source/WebCore:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::attachWrapper):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

• bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::ObjcField):

• editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart):

• history/cf/HistoryPropertyList.cpp:

(WebCore::HistoryPropertyListWriter::releaseData):

• html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):

• loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):

• loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions):
(WebCore::CaptionUserPreferencesMac::userPrefersSubtitles):
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS):
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS):
(WebCore::CaptionUserPreferencesMac::captionsTextColor):
(WebCore::CaptionUserPreferencesMac::captionsDefaultFontCSS):
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
(WebCore::trackDisplayName):

• platform/Language.cpp:

(WebCore::displayNameForLanguageLocale):

• platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSearchWeb):
(WebCore::imageTitle):

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader):

• platform/cf/KURLCFNet.cpp:

(WebCore::KURL::fileSystemPath):

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToImage):

• platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::schedule):

• platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::PlatformCAAnimation):

• platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::filterValueForOperation):

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

• platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::getCGImageArray):

• platform/graphics/cg/ColorCG.cpp:

(WebCore::cachedCGColor):

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setURLForRect):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::CGImageEncodeToData):
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

• platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::imageWithColorSpace):
(WebCore::Image::drawPattern):

• platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dataChanged):

• platform/graphics/cg/PathCG.cpp:

(WebCore::createScratchContext):
(WebCore::Path::contains):

• platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
(WebCore::createFeatureSettingDictionary):
(WebCore::cascadeToLastResortFontDescriptor):
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::description):

• platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

• platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

• platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::linearRGBColorSpaceRef):

• platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::getTIFFRepresentation):
(WebCore::BitmapImage::getNSImage):

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::addFileTypesToCache):

• platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

• platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer copyImageSnapshotWithColorSpace:]):

• platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::ContentFilter):

• platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::ContextMenuItem):

• platform/mac/CursorMac.mm:

(WebCore::createCustomCursor):
(WebCore::createNamedCursor):

• platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

• platform/mac/DragImageMac.mm:

(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):

• platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

• platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):

• platform/mac/LocalizedStringsMac.cpp:

(WebCore::localizedString):

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getDataSelection):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::fragmentFromWebArchive):

• platform/mac/PlatformClockCM.mm:

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setPathnamesForType):

• platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::speak):

• platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):

• platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

• platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

• platform/mac/WebCoreNSStringExtras.mm:

(stringEncodingForResource):

• platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::receivesCredentialSecurely):

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::platformBadResponseError):

• platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage):

• platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):

• platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::overrideCookieStorage):

• platform/network/cf/ProxyServerCFNet.cpp:

(WebCore::proxyAutoConfigurationResultCallback):
(WebCore::processProxyServers):
(WebCore::addProxyServersForURL):

• platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::cfError):

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::handleDataArray):

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

• platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):

• platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::AuthenticationChallenge::setAuthenticationClient):

• platform/network/mac/CookieJarMac.mm:

(WebCore::filterCookies):

• platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::nsError):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

• platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

• platform/network/mac/UTIUtilities.mm:

(WebCore::mimeTypeFromUTITree):

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

• platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey):
(WebCore::lastHyphenLocation):

• platform/text/mac/HyphenationMac.mm:

(WebCore::::createValueForKey):
(WebCore::lastHyphenLocation):

• platform/text/mac/LocaleMac.mm:

(WebCore::determineLocale):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::initializeLocaleData):

• platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::textBreakLocalePreference):
(WebCore::canonicalLanguageIdentifier):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
Use adoptNS and adoptCF free functions.

Source/WebKit/cf:

• WebCoreSupport/WebInspectorClientCF.cpp:

(populateSetting): Use adoptCF.

Source/WebKit/mac:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

• Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]):

• Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

• Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::beginModal):
(WKPCBooleanAndDataReply):

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::status):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

• Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView createPlugin]):

• Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView cacheSnapshot]):
(WebKit::getAuthenticationInfo):

• Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage initWithPath:]):

• Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(WebNetscapePluginEventHandlerCarbon::startTimers):

• Plugins/WebNetscapePluginEventHandlerCocoa.mm:

(WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):

• Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):

• Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverData):
(WebNetscapePluginStream::deliverDataToFile):
(WebNetscapePluginStream::didReceiveData):

• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):

• Storage/WebDatabaseManagerClient.mm:

(WebDatabaseManagerClient::dispatchDidModifyOrigin):
(WebDatabaseManagerClient::dispatchDidModifyDatabase):

• Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

• WebCoreSupport/CorrectionPanel.mm:

(CorrectionPanel::handleAcceptedReplacement):

• WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didRunInsecureContent):

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):

• WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):

• WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument):

• WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):

• WebView/WebScriptDebugger.mm:

(WebScriptDebugger::initGlobalCallFrame):
(WebScriptDebugger::callEvent):

• WebView/WebView.mm:

(-[WebView previousValidKeyView]):
Use adoptNS and adoptCF free functions.

Source/WebKit2:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• Platform/cg/CGUtilities.cpp:

(WebKit::paintBitmapContext):

• Platform/mac/ModuleMac.mm:

(WebKit::Module::load):
(WebKit::Module::platformFunctionPointer):

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):

• Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCreateWithNSURLResponse):

• Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):

• Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:

(WebKit::ChildProcessMain):

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginArchitecture):
(WebKit::contentsOfPropertyListAtURL):
(WebKit::getMIMETypesFromPluginBundle):
(WebKit::getStringListResource):
(WebKit::NetscapePluginModule::getPluginInfo):

• Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):

• Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
(CoreIPC::encode):

• Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createCGImage):

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

• Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::dump):

• Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

• UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):

• UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView initWithFrame:PDFViewController:]):
(WebKit::PDFViewController::PDFViewController):
(WebKit::convertPostScriptDataSourceToPDF):
(WebKit::PDFViewController::setPDFDocumentData):

• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):

• UIProcess/API/mac/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):

• UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

• UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView browsingContextController]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView fullScreenWindowController]):
(-[WKView _executeSavedCommandBySelector:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

• UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::beginModal):

• UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

• UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

• UIProcess/cf/WebPreferencesCF.cpp:

(WebKit::cfStringFromWebCoreString):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):

• UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::backingStoreContext):

• UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::handleAcceptedReplacement):

• UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDiskCacheDirectory):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):

• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

• WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::updatePluginLayer):

• WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::createScrollbar):
(WebKit::PDFPlugin::pdfDocumentDidLoad):
(WebKit::PDFPlugin::writeItemsToPasteboard):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::pdfDocumentDidLoad):
(WebKit::SimplePDFPlugin::streamDidReceiveData):
(WebKit::SimplePDFPlugin::manualStreamDidReceiveData):

• WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

• WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):

• WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPagesToPDF):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::cachedResponseForURL):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Use adoptCF and adoptNS free functions.

Source/WTF:

• wtf/RunLoopTimerCF.cpp:

(WTF::RunLoopTimerBase::start):

• wtf/SchedulePair.h:

(WTF::SchedulePair::SchedulePair):

• wtf/SchedulePairMac.mm:

(WTF::SchedulePair::SchedulePair):

• wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):
Use adoptCF free function.

8:43 PM Changeset in webkit [149254] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Pressing mouse button inside a dragstart event causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=115296

Reviewed by Darin Adler.

Source/WebCore:

Add a missing null pointer check. We should better encapsulate the states in DragState in the long term
but this is good enough for now.

Test: fast/events/mousedown-inside-dragstart-should-not-cause-crash.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

LayoutTests:

Added a regression test. While the bug report involves opening inspector and setting a breakpoint,
a simpler reduction that uses eventSender significantly reduces the complexity.

• fast/events/mousedown-inside-dragstart-should-not-cause-crash-expected.txt: Added.
• fast/events/mousedown-inside-dragstart-should-not-cause-crash.html: Added.

8:38 PM Changeset in webkit [149253] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13757007> Crashes in NetworkResourceLoader::didReceiveResponseAsync
​https://bugs.webkit.org/show_bug.cgi?id=115318

Reviewed by Darin Adler.

sendAbortingOnFailure may actually fail, and abort the request, making m_handle null.

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didReceiveResponseAsync): Null check m_handle after sending a message, because the request will cancelled when connection is invalid. (WebKit::NetworkResourceLoader::didReceiveBuffer): Assert that m_handle matches the handle that we are called with. (WebKit::NetworkResourceLoader::didFinishLoading): Ditto. (WebKit::NetworkResourceLoader::didFail): Ditto. (WebKit::NetworkResourceLoader::willSendRequestAsync): Ditto. (WebKit::NetworkResourceLoader::didSendData): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Ditto. (WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): Ditto.

8:37 PM Changeset in webkit [149252] by andersca@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

8:22 PM Changeset in webkit [149251] by ap@apple.com

• 5 edits in trunk/Source/WebKit2

<rdar://problem/13757687> Threads get stuck in NetworkProcess when canceling loads
​https://bugs.webkit.org/show_bug.cgi?id=115319

Reviewed by Darin Adler.

WebResourceLoader was second-guessing NetworkProcess as to whether it needs a response
to DidReceiveResponseWithCertificateInfo, and it was guessing wrong if the load was
alrady canceled on WebProcess side.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Network/WebResourceLoader.messages.in:

6:17 PM Changeset in webkit [149250] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix when disabling video and video-track.

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

5:09 PM Changeset in webkit [149249] by ggaren@apple.com

• 3 edits in trunk/Source/WebCore

WebGL shouldn't allocate a "length" Identifier just to move some numbers around
​https://bugs.webkit.org/show_bug.cgi?id=115317

Reviewed by Dean Jackson.

Saw this while debugging an ammo.js bug.

• bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toVector): Use the pre-computed "length" identifier instead of
allocating a new one for each vector operation. There are lots more
optimizations we could do here. This is a start.

4:14 PM Changeset in webkit [149248] by fpizlo@apple.com

• 9 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: SymbolTable should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115301

Reviewed by Geoffrey Garen.

Makes SymbolTable thread-safe. Relies on SymbolTableEntry already being immutable,
other than the WatchpointSet; but the WatchpointSet already has a righteous
concurrency protocol. So, this patch just protects the SymbolTable's HashMap.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):

• runtime/Executable.cpp:

(JSC::ProgramExecutable::addGlobalVar):

• runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

• runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

• runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::~SymbolTable):

• runtime/SymbolTable.h:

(JSC::SymbolTable::find):
(JSC::SymbolTable::get):
(JSC::SymbolTable::inlineGet):
(JSC::SymbolTable::begin):
(JSC::SymbolTable::end):
(JSC::SymbolTable::size):
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
(JSC::SymbolTable::contains):

4:14 PM Changeset in webkit [149247] by ggaren@apple.com

• 26 edits in trunk

Cleaned up pre/post inc/dec in bytecode
​https://bugs.webkit.org/show_bug.cgi?id=115222

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

A few related changes here:

(*) Removed post_inc and post_dec. The two-result form was awkward to
reason about. Being explicit about the intermediate mov and to_number
reduces DFG overhead, removes some fragile ASSERTs from the DFG, and
fixes a const bug. Plus, we get to blow away 262 lines of code.

(*) Renamed pre_inc and pre_dec to inc and dec, since there's only one
version now.

(*) Renamed to_jsnumber to to_number, to match the ECMA name.

(*) Tightened up the codegen and runtime support for to_number.

• JavaScriptCore.order: Order!

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInc):
(JSC::BytecodeGenerator::emitDec):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):
(BytecodeGenerator): Removed post_inc and post_dec.

• bytecompiler/NodesCodegen.cpp:

(JSC::emitPreIncOrDec): Updated for rename.

(JSC::emitPostIncOrDec): Issue an explicit mov and to_number when needed.
These are rare, and they boil away in the DFG.

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve): For const, use an explicit mov instead
of any special forms. This fixes a bug where we would do string
add/subtract instead of number.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec): Removed post_inc/dec, and updated for renames.

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):
(JSC::JIT::emitSlow_op_to_number): Removed a test for number cells. There's
no such thing!

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number): Use LowestTag to avoid making assumptions
about the lowest valued tag.

(JSC::JIT::emitSlow_op_to_number): Updated for renames.

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• jit/JITStubs.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• parser/NodeConstructors.h:

(JSC::UnaryPlusNode::UnaryPlusNode): Removed post_inc/dec, and updated for renames.

• runtime/Operations.cpp:

(JSC::jsIsObjectType): Removed a test for number cells. There's
no such thing!

LayoutTests:

• fast/js/const-expected.txt:
• fast/js/resources/const.js: Added tests for some const cases we used

to get wrong.

4:02 PM Changeset in webkit [149246] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Regression tests that reference a non-local resource crash with NetworkProcess enabled
​https://bugs.webkit.org/show_bug.cgi?id=115290

Reviewed by Sam Weinig.

Covered by fast/dom/icon-url-change.html and many other existing tests.

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Handle this case. Architecturally, it
would be better if SubresourceLoad::create just created an object an didn't do
further checks before returning a pointer, but changing that is beyond the scope
of the fix.

1:55 PM Changeset in webkit [149245] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Remove two more StorageTask types
​https://bugs.webkit.org/show_bug.cgi?id=115312

Reviewed by Dean Jackson.

• storage/StorageTask.cpp:

(WebCore::StorageTask::performTask):

• storage/StorageTask.h:
• storage/StorageTracker.cpp:

(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::deleteOrigin):

• storage/StorageTracker.h:

1:44 PM Changeset in webkit [149244] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Get rid of more uses of StorageTask
​https://bugs.webkit.org/show_bug.cgi?id=115311

Reviewed by Dean Jackson.

Make StorageAreaSync derive from ThreadSafeRefCounted as well, since it's passed between threads.

• storage/StorageAreaSync.h:
• storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:

(StorageTask):

1:32 PM Changeset in webkit [149243] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Indent StorageAreaSync to match the style guidelines.

Rubber-stamped by Andreas Kling.

• storage/StorageAreaSync.h:

1:28 PM Changeset in webkit [149242] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=115309

Reviewed by Andreas Kling.

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:
• storage/StorageThread.cpp:

(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

• storage/StorageThread.h:
• storage/StorageTracker.cpp:

(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::deleteAllOrigins):

12:59 PM Changeset in webkit [149241] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Add StorageThread::dispatch
​https://bugs.webkit.org/show_bug.cgi?id=115308

Reviewed by Andreas Kling.

StorageThread::dispatch takes a Function<void ()> and runs it on the storage thread. This will be used to eventually get rid of StorageTask.

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:

(WebCore::StorageTask::createDispatch):

• storage/StorageThread.cpp:

(WebCore::StorageThread::dispatch):

• storage/StorageThread.h:

(StorageThread):

11:25 AM Changeset in webkit [149240] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
​https://bugs.webkit.org/show_bug.cgi?id=115305

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-27
Reviewed by Andreas Kling.

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::cacheFlush):

11:23 AM Changeset in webkit [149239] by fpizlo@apple.com

• 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: WatchpointSet should make racy uses easier to reason about
​https://bugs.webkit.org/show_bug.cgi?id=115299

Reviewed by Anders Carlsson.

The compiler often does things like:

1c) Observe something that would imply that a WatchpointSet ought to be invalid

2c) Check that it is invalid

The main thread often does things like:

1m) Fire the watchpoint set

2m) Do some other thing that would cause the compiler to assume that the WatchpointSet
ought to be invalid

An example is structure transitions, where (1c) is the compiler noticing that a
put_by_id inline cache is in a transition state, with the source structure being S;
(2c) is the compiler asserting that S's watchpoint set is invalid; (1m) is the main
thread firing S's watchpoint set before it does the first transition away from S; and
(2m) is the main thread caching the put_by_id transition away from S.

This is totally fine, except that (1c) and (2c), and (1m) and (2m) could be reordered.
Probably, in most cases, this ought to do enough things that the main thread probably
already has some fencing. But the compiler thread definitely doesn't have fencing. In
any case, we should play it safe and just have additional fencing in all of the
relevant places.

We already have some idioms to put load-load and store-store fences in the right
places. But this change just makes WatchpointSet take care of this for us, thus
reducing the chances of us getting this wrong.

• bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::notifyWriteSlow):

• bytecode/Watchpoint.h:

(WatchpointSet):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::notifyWrite):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):

11:18 AM Changeset in webkit [149238] by rakuco@webkit.org

• 2 edits in trunk/Tools

[EFL] Unreviewed Intel bots fix after r149231.

• efl/jhbuild.modules: Disable the libxml Python bindings since the

bots don't have Python's development files installed. libxml should
detect this kind of thing better.

10:08 AM Changeset in webkit [149237] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r147261): Audio controls background not displayed after loading audio file
​https://bugs.webkit.org/show_bug.cgi?id=115221

Reviewed by Darin Adler.

As in r147261, set a flex-shrink: 0 to avoid shrinking the media controls panel
below the specified height.

No new tests; fixes the media/media-document-audio-repaint.html test.

• css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

9:51 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

Adding a merge proposal for 2.0.2. (diff)

Apr 26, 2013:

11:43 PM Changeset in webkit [149236] by ggaren@apple.com

• 16 edits
  2 adds in trunk

Source/JavaScriptCore: Re-landing <​http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

We can't fold the number == 1 case to boolean because all non-zero numbers
down-cast to true, but only 1 is == to true.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

• wtf/TriState.h:

(WTF::triState):
(WTF):

LayoutTests: Re-landing <​http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

Added a more exhaustive correctness test.

• fast/js/branch-fold-correctness-expected.txt: Added.
• fast/js/branch-fold-correctness.html: Added.

11:33 PM Changeset in webkit [149235] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

• runtime/SymbolTable.h:

11:28 PM Changeset in webkit [149234] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Correct indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

• runtime/SymbolTable.h:

10:44 PM Changeset in webkit [149233] by fpizlo@apple.com

• 16 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CFA should defend against results seeming inconsistent due to a watchpoint firing during compilation
​https://bugs.webkit.org/show_bug.cgi?id=115083

Reviewed by Geoffrey Garen.

This ruggedizes our racyness with respect to watchpoints. We want to be able to assert,
in some places, that a watchpoint-based optimization has only occurred if the
watchpoint set was still valid. But currently we *can* soundly do watchpoint-based
optimizations even for invalid watchpoints, so long as we recorded in the IR that we
had done so; this will then lead to the code being insta-jettisoned after compilation
completes. Obviously, we don't want this to happen often - but we do want to allow it
precisely in the case of watchpoint races.

This adds the ability to assert that we hadn't over-watchpointed ourselves, with and
exemption for races.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

• dfg/DFGDesiredWatchpoints.h:

(GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::isStillValid):
(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::GenericDesiredWatchpoints::isValidOrMixed):
(JSC::DFG::DesiredWatchpoints::isStillValid):
(JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::DesiredWatchpoints::isValidOrMixed):
(DesiredWatchpoints):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::masqueradesAsUndefinedWatchpointIsStillValid):
(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addLazily):
(JITCompiler):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

• dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::speculationWatchpointForMasqueradesAsUndefined):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLState.h:

(State):

10:30 PM Changeset in webkit [149232] by jer.noble@apple.com

• 5 edits
  3 adds in trunk

Video playback has corruption on the edges of the video
​https://bugs.webkit.org/show_bug.cgi?id=115216

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-poster-background.html

RenderImage correctly answers foregroundIsKnownToBeOpaqueInRect() method
when a poster image is displayed, but once the video begins playing and
the poster image is no longer displayed, RenderImage will continue to
answer 'true' even when the video does not occupy the entire render box.
Override foregroundIsKnownToBeOpaqueInRect() in order to more correctly
answer the question for the video layer.

• rendering/RenderImage.h: Make foregroundIsKnownToBeOpaqueInRect() protected

(vs. private).

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): Added. Return

true if the rect parameter is entirely contained by the video box.

• rendering/RenderVideo.h:

LayoutTests:

• media/content/test.jpg: Added.
• media/video-poster-background-expected.html: Added.
• media/video-poster-background.html: Added.

9:41 PM Changeset in webkit [149231] by ryuan.choi@samsung.com

• 2 edits in trunk/Tools

[EFL] Build break using jhbuild on ubuntu 13.04
​https://bugs.webkit.org/show_bug.cgi?id=115225

Reviewed by Gyuyoung Kim.

libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
libxml 2.9.0 has a bug to make regression which r138422 mentioned.
So this patch bumped libxml version to 2.9.1.

• efl/jhbuild.modules:

6:31 PM Changeset in webkit [149230] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[WK2][EFL] Build break after r149212
​https://bugs.webkit.org/show_bug.cgi?id=115294

Patch by Yael Aharon <​yael.aharon@intel.com> on 2013-04-26
Reviewed by Simon Fraser.
r144672 bumped up the revision of WKContextClient API, and introduced a version array
APIClientTraits<WKContextClient>::interfaceSizesByVersion .
In r149212, the version was bumped back down and the version array was emptied but not removed.
This causes a warning "array subscript is below array bounds", and in EFL the warning is
treated as error.

• Shared/APIClientTraits.cpp:

(WebKit):

• Shared/APIClientTraits.h:

5:51 PM Changeset in webkit [149229] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skipping some more tests that still need rebaselining after disabling subpixel layout on mac.
​http://bugs.webkit.org/show_bug.cgi?id=115292

• TestExpectations:

5:51 PM Changeset in webkit [149228] by jpfau@apple.com

• 2 edits in trunk/Tools

delete-stale-build-files does not clear .d files
​http://bugs.webkit.org/show_bug.cgi?id=115293

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/delete-stale-build-files:

(main): Add .d to the file type list

5:38 PM Changeset in webkit [149227] by roger_fong@apple.com

• 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port, VS2005 edition.

• win/tools/vsprops/FeatureDefines.vsprops:

5:35 PM Changeset in webkit [149226] by hmuller@adobe.com

• 12 edits in trunk/Source/WebCore

[CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects
​https://bugs.webkit.org/show_bug.cgi?id=115117

Reviewed by Dirk Schulze.

Redefined the ExclusionShape API in terms of LayoutUnits, instead of floats: all of the
ExclusionShape methods now have LayoutUnit parameters and return LayoutUnit values.
This is more natural, since the callers work exclusively in LayoutUnits.

This is strictly a refactoring, no new tests were needed.

• rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop):

• rendering/ExclusionPolygon.h:
• rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop):

• rendering/ExclusionRectangle.h:
• rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

• rendering/ExclusionShape.h:

(LineSegment):
(ExclusionShape):

• rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::computedShape):

• rendering/ExclusionShapeInfo.h:

(WebCore):
(WebCore::ExclusionShapeInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInfo::shapeLogicalBottom):
(ExclusionShapeInfo):

• rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop):

• rendering/ExclusionShapeInsideInfo.h:
• rendering/ExclusionShapeOutsideInfo.h:

5:17 PM Changeset in webkit [149225] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Nil-check the results of -[AVPlayerItemVideoOutput copyPixelBufferForItemTime:itemTimeForDisplay:].
​https://bugs.webkit.org/show_bug.cgi?id=115265

Reviewed by Eric Carlson.

copyPixelBufferForItemTime:itemTimeForDisplay: can return nil, even
when hasNewPixelBufferForItemTime: returns YES. Check the results
before passing the buffer on to VTPixelTransferSessionTransferImage()
which does not NULL-check its parameters.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):

5:09 PM Changeset in webkit [149224] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skipping some tests that still need rebaselining after disabling subpixel layout on mac.
​http://bugs.webkit.org/show_bug.cgi?id=115292

• TestExpectations:

4:45 PM Changeset in webkit [149223] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Uninflate caret rect.
​http://bugs.webkit.org/show_bug.cgi?id=114997.
<rdar://problem/12629007>.

Reviewed by Timothy Horton.

Inflation was causing painting errors with focus rings.
It is no longer needed after disabling subpixel layout.

• editing/FrameSelection.cpp:

(WebCore::repaintCaretForLocalRect):

4:40 PM Changeset in webkit [149222] by roger_fong@apple.com

• 3 edits
  66 adds in trunk/LayoutTests

Unreviewed. More rebaselines for mac after disabling sub-pixel layout.

4:40 PM Changeset in webkit [149221] by roger_fong@apple.com

• 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port.

• win/tools/vsprops/FeatureDefines.props:

4:17 PM Changeset in webkit [149220] by roger_fong@apple.com

• 216 edits
  1 delete in trunk

Make Apple Windows VS2010 build results into and get dependencies from 32 suffixed folders.
Make the DebugSuffix configuration use _debug dependencies.

4:06 PM Changeset in webkit [149219] by Martin Robinson

• 5 edits in trunk/Source/WebKit2

[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=99081

Reviewed by Carlos Garcia Campos, Gustavo Noronha Silva, and Benjamin Poulain.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

• UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.

• UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
• UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.

(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

3:29 PM Changeset in webkit [149218] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):

3:22 PM Changeset in webkit [149217] by ap@apple.com

• 8 edits in trunk/Source/WebKit2

2013-04-26 Simon Cooper <​scooper@apple.com>

Permit ~/Library or ~/Library/Preferences to be symlinks
​https://bugs.webkit.org/show_bug.cgi?id=115142
<rdar://problem/12953603>

Reviewed by Alexey Proskuryakov.

Pass in two new parameters which are the resolved paths to ~/Library
and ~/Library/Preferences. Added new expansion functions and
substituted the new functions for home-regex, home-subpath and
home-literal for places referencing resources in "~/Library" or
"~/Library/Preferences".

• Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
• Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
• Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
• Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
• Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
• Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox):

3:20 PM Changeset in webkit [149216] by msaboff@apple.com

• 4 edits in trunk/Source/WebCore

WebCore ObjC bridge is missing support for bool type
​https://bugs.webkit.org/show_bug.cgi?id=115276

Reviewed by Geoffrey Garen.

Added code to handle conversion between ObjC and JS booleans.

• bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

• bridge/objc/objc_utility.h:
• bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):
(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

3:15 PM Changeset in webkit [149215] by mrowe@apple.com

• 1 edit in tags/Safari-537.39.1/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

Build fix.

3:15 PM Changeset in webkit [149214] by mrowe@apple.com

• 4 edits in tags/Safari-537.39.1/Source

Versioning.

3:09 PM Changeset in webkit [149213] by mrowe@apple.com

• 1 copy in tags/Safari-537.39.1

New tag.

2:54 PM Changeset in webkit [149212] by ap@apple.com

• 4 edits in trunk/Source/WebKit2

[WK2] WKContextClient doesn't need to be versioned yet
​https://bugs.webkit.org/show_bug.cgi?id=115279

Reviewed by Anders Carlsson.

• Shared/APIClientTraits.cpp:
• Shared/APIClientTraits.h:
• UIProcess/API/C/WKContext.h:

2:39 PM Changeset in webkit [149211] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

Downloads need to be converted from the NSURLConnection, not canceled and restarted, when using the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=115277
<rdar://problem/12890184>

Reviewed by Sam Weinig.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Ask the download manager to convert the main resource load to a download.

• NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add new message.

• NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::handle):
Add getter.

• Shared/Downloads/mac/DownloadMac.mm:

(dispatchOnMainThread):
Helper function that ensures that a given block is called on the main thread.

(-[WKDownloadAsDelegate downloadDidBegin:]):
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate download:didReceiveResponse:]):
(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
(-[WKDownloadAsDelegate download:didCreateDestination:]):
(-[WKDownloadAsDelegate downloadDidFinish:]):
(-[WKDownloadAsDelegate download:didFailWithError:]):
Use dispatchOnMainThread.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Remove code that cancels the current load and starts a new download.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):
Send the ConvertMainResourceLoadToDownload message to the network process.

2:25 PM Changeset in webkit [149210] by roger_fong@apple.com

• 865 edits
  359 adds
  262 deletes in trunk/LayoutTests

Unreviewed. Rebaseline a bunch of tests and run optimize-baselines after disabling sub-pixel layout on mac.
​https://bugs.webkit.org/show_bug.cgi?id=114999.

2:19 PM Changeset in webkit [149209] by roger_fong@apple.com

• 9 edits in trunk/Source

Disable sub-pixel layout on mac.
​https://bugs.webkit.org/show_bug.cgi?id=114999.

Reviewed by Simon Fraser.

• Configurations/FeatureDefines.xcconfig:
• WebCore.exp.in:

Export symbol needed to be added for IntRect(const LayoutRect&) constructor,
which is now being used in pixelSnappedIntRect(const LayoutRect&) in LayoutRect.h after disabling sub-pixel layout.

2:13 PM Changeset in webkit [149208] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Inspector window is often blank when opened
​https://bugs.webkit.org/show_bug.cgi?id=115220
<rdar://problem/13735496>

Reviewed by Tim Horton.

After disabling tiled scrolling and accelerated drawing in r149006, the
Inspector window was often missing its content after opening. This only
happened when the user has a preference on disk to use accelerated drawing
in the Inspector.

The missing content was caused by a failure to connect the correct contextID
for remote layer hosting. On window creation, we hook up a context using
WindowServer layer hosting (the default), but then switch back to app-hosted
layers for the Inspector window. This switching happens in didUpdateBackingStoreState(),
but that can be re-entered via its call to sendUpdateBackingStoreState(). In
that cause, on unwinding the stack it would call enterAcceleratedCompositingMode()
with a stale layerTreeContext.

Fix by moving the code that exits/enters accelerated compositing mode to before
the call to sendUpdateBackingStoreState() that can cause re-entrancy. That avoids
use of a possibly stale layerTreeContext.

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):

2:13 PM Changeset in webkit [149207] by Simon Fraser

• 4 edits in trunk/Source

Layer-backed WebViews don't repaint content outside the visible area
​https://bugs.webkit.org/show_bug.cgi?id=115275

Reviewed by Beth Dakin.

Source/WebCore:

Export ScrollView::setPaintsEntireContents(bool).

• WebCore.exp.in:

Source/WebKit/mac:

When a client of WebView makes the WebView be layer-backed, then
AppKit propagaes the layer-backing down to the WebHTMLView (but
no further).

In this situation, we had a bug where content that was not
in the visible content rect would not get repainted, because
WebCore clips repaints to the visible rect.

Fix by calling ScrollView::setPaintsEntireContents(bool) from
-[WebHTMLView setLayer:], saying that we need
to paint the entire contents if we have a layer.

• WebView/WebHTMLView.mm:

(-[WebHTMLView setLayer:]):

1:34 PM Changeset in webkit [149206] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for valid element in elementTouched
​https://bugs.webkit.org/show_bug.cgi?id=115205

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-04-26
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR 331546
We might receive a null ptr from nodeAsElementIfApplicable which
is passed in here. Check to make sure it's valid before using.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::elementTouched):

1:12 PM Changeset in webkit [149205] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make stack tracing more robust
​https://bugs.webkit.org/show_bug.cgi?id=115272

Reviewed by Geoffrey Garen.

CallFrame already handles stack walking confusion robustly,
so we should make sure that the actual walk handles that as well.

• interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

12:42 PM Changeset in webkit [149204] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Crashes under ResourceHandle::continueDidReceiveResponse when loading blobs
​https://bugs.webkit.org/show_bug.cgi?id=115273

Reviewed by Anders Carlsson.

Covered by multiple existing tests (when using NetworkProcess), including:

• http/tests/fileapi/blob-url-in-subframe.html
• http/tests/fileapi/create-blob-url-from-data-url.html

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::continueDidReceiveResponse): Work around BlobResourceHandle badness.

12:09 PM Changeset in webkit [149203] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Change RenderMeter::valueRatio() visibility to public
​https://bugs.webkit.org/show_bug.cgi?id=115266

This function is currently unused.
However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

Patch by Daker Fernandes Pinheiro <​daker.pinheiro@openbossa.org> on 2013-04-26
Reviewed by Alexis Menard.

No new tests, because no behaviour is changed.

• rendering/RenderMeter.h:

(RenderMeter):

12:08 PM Changeset in webkit [149202] by timothy@apple.com

• 6 edits
  1 add in trunk/Source

Add Runtime.parse to the Inspector protocol.

This will be used to parse console expressions for errors
before evaluating them fully.

​https://webkit.org/b/115242

Reviewed by Oliver Hunt.

• ForwardingHeaders/parser/ParserError.h: Added.
• inspector/Inspector.json:
• inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::parse):

• inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

12:04 PM Changeset in webkit [149201] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the copyright years after r149057

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-26

• page/DiagnosticLoggingKeys.cpp: I accidentally removed a year from

the copyright in r149057.

11:57 AM Changeset in webkit [149200] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Web Inspector: Crash due to null items from getDOMStorageItems
​https://bugs.webkit.org/show_bug.cgi?id=115176

Patch by Konrad Piascik <​kpiascik@blackberry.com> on 2013-04-26
Reviewed by Joseph Pecoraro.

Source/WebCore:

findStorageArea was returning a null storageArea causing the items
input paramater to not be set. This was happening without any error
being set at all. Set an error to prevent a crash when we try to
convert the result to a JSON string.

Added tests to check if session and local storage are empty that
they are still functional.

• inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

LayoutTests:

Tests to check that if local and session storage are empty
that they still work corerctly.

• inspector/storage-panel-dom-storage-empty-expected.txt: Added.
• inspector/storage-panel-dom-storage-empty.html: Added.

11:40 AM Changeset in webkit [149199] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

[WK2] Remove NetworkResourceLoader::cleanupOnMainThread
​https://bugs.webkit.org/show_bug.cgi?id=115268

Reviewed by Brady Eidson.

All cleanup() callers are now on main thread, and this indirection only complicates debugging.

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose): (WebKit::NetworkResourceLoader::abortInProgressLoad): (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::didFail):
• NetworkProcess/NetworkResourceLoader.h:

11:24 AM Changeset in webkit [149198] by aestes@apple.com

• 3 edits in trunk/Source/WebKit2

[WebKit2] CustomProtocolManager's m_registeredSchemes HashSet can be accessed by multiple threads
​https://bugs.webkit.org/show_bug.cgi?id=115267

Reviewed by Alexey Proskuryakov.

• Shared/Network/CustomProtocols/CustomProtocolManager.h: Added a Mutex to protect m_registeredSchemes.
• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Acquired the mutex before accessing m_registeredSchemes.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): Ditto.

11:10 AM Changeset in webkit [149197] by eric.carlson@apple.com

• 2 edits in trunk/LayoutTests

[Mac] media/track/track-mode.html sometimes trigger InvalidStateError
​https://bugs.webkit.org/show_bug.cgi?id=115045

Reviewed by Alexey Proskuryakov.

• media/track/track-mode.html: Don't assume that the video element is ready for seeking

after a 100ms timeout.

10:51 AM Changeset in webkit [149196] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Blobs are not associated with connection when there are no sandbox extensions
​https://bugs.webkit.org/show_bug.cgi?id=115264

Reviewed by Brady Eidson.

Covered by multiple fast/files tests when using NetworkProcess.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): Fixed a logic error.

10:41 AM Changeset in webkit [149195] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Clean up the TestWebKitAPI GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=115233

Reviewed by Martin Robinson.

Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.

• TestWebKitAPI/GNUmakefile.am:

9:55 AM Changeset in webkit [149194] by aestes@apple.com

• 11 edits
  3 copies
  2 adds in trunk

[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
​https://bugs.webkit.org/show_bug.cgi?id=115223

Reviewed by Darin Adler.

Source/WebKit2:

When WebKit performs a synchronous load on the Mac, it spins a nested
run loop in a mode that only accepts input from the NSURLConnection
performing the load. When the load is for a custom protocol in WebKit2,
we proxy it to the UI process via CoreIPC messages, but the response
messages from the UI process are never processed as long as the run
loop is in a non-common mode (and we wouldn't want to process messages
that could re-enter WebCore in the middle of loading, anyway). Since
these messages never make it back to the NSURLConnection handling the
request, the connection eventually times out.

Fix this by using a work queue to handle custom protocol messages in
the networking process. The work queue can process incoming custom
protocol messages while the main thread is blocked.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection): Called
initializeConnection() on all the NetworkProcess's supplements.

• Shared/ChildProcessSupplement.h: Added a base class for

NetworkProcessSupplement and WebProcessSupplement which defines
initializeConnection and provides an empty default implementation.
(WebKit::ChildProcessSupplement::~ChildProcessSupplement):
(WebKit::ChildProcessSupplement::initializeConnection):

• Shared/Network/CustomProtocols/CustomProtocolManager.h:
• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::CustomProtocolManager): Instantiated a
work queue for message processing.
(WebKit::CustomProtocolManager::initializeConnection): Added the work
queue as a message receiver on the CoreIPC connection.
(WebKit::CustomProtocolManager::initialize): If we're in the web
process and the network process is being used, unregister and destroy
the work queue we previously created. It'd be better to not create it
in the first place, but we have to register our work queue with the
CoreIPC connection before it is established, which is before the UI
process has told us whether the network process is in use.

• Shared/Network/NetworkProcessSupplement.h: Inherited from

ChildProcessSupplement.

• WebKit2.xcodeproj/project.pbxproj: Added ChildProcessSupplement.h.
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection): Called
initializeConnection() on all the WebProcess's supplements.

• WebProcess/WebProcessSupplement.h: Inherited from

ChildProcessSupplement.

Tools:

Added an API test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.

(TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
when it loads a request with a custom protocol.

• TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the

NSURLProtocol subclass to TestProtocol.{h, mm} and did some
miscellaneous cleanup.

• TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
• TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.

(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(+[TestProtocol scheme]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):

9:24 AM Changeset in webkit [149193] by Martin Robinson

• 49 edits in trunk

Remove the remaining Skia #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=114886

Reviewed by Benjamin Poulain.

Source/WebCore:

• html/HTMLCanvasElement.cpp: Remove Skia #ifdef references.
• platform/graphics/BitmapImage.cpp: Ditto.
• platform/graphics/FloatPoint.h: Ditto.
• platform/graphics/FloatRect.h: Ditto.
• platform/graphics/FontCache.h: Ditto.
• platform/graphics/Gradient.cpp: Ditto.
• platform/graphics/Gradient.h: Ditto.
• platform/graphics/GraphicsContext.cpp: Ditto.
• platform/graphics/GraphicsContext.h: Ditto.
• platform/graphics/GraphicsContext3D.h: Ditto.
• platform/graphics/ImageBuffer.cpp: Ditto.
• platform/graphics/ImageBuffer.h: Ditto.
• platform/graphics/ImageBufferData.h: Ditto.
• platform/graphics/IntPoint.h: Ditto.
• platform/graphics/IntRect.h: Ditto.
• platform/graphics/NativeImagePtr.h: Ditto.
• platform/graphics/Path.h: Ditto.
• platform/graphics/Pattern.cpp: Ditto.
• platform/graphics/Pattern.h: Ditto.
• platform/graphics/filters/FEBlend.h: Ditto.
• platform/graphics/filters/FEColorMatrix.h: Ditto.
• platform/graphics/filters/FEComponentTransfer.h: Ditto.
• platform/graphics/filters/FEComposite.h: Ditto.
• platform/graphics/filters/FEConvolveMatrix.h: Ditto.
• platform/graphics/filters/FEDisplacementMap.h: Ditto.
• platform/graphics/filters/FEGaussianBlur.h: Ditto.
• platform/graphics/filters/FELighting.h: Ditto.
• platform/graphics/filters/FEMorphology.h: Ditto.
• platform/graphics/filters/FEOffset.h: Ditto.
• platform/graphics/filters/FilterEffect.cpp: Ditto.
• platform/graphics/filters/FilterEffect.h: Ditto.
• platform/graphics/transforms/AffineTransform.h: Ditto.
• platform/graphics/transforms/TransformationMatrix.h: Ditto.
• platform/image-decoders/ImageDecoder.cpp: Ditto.
• platform/image-decoders/ImageDecoder.h: Ditto.
• platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
• platform/image-decoders/webp/WEBPImageDecoder.cpp: Ditto.
• platform/mac/LocalCurrentGraphicsContext.h: Ditto.
• platform/mac/LocalCurrentGraphicsContext.mm: Ditto.
• rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
• svg/graphics/SVGImage.cpp: Ditto.
• svg/graphics/SVGImage.h: Ditto.

Source/WebKit/blackberry:

• Api/WebPage.cpp: Remove Skia #ifdef references.
• WebCoreSupport/AboutDataUseFeatures.in: Ditto.

Source/WTF:

• wtf/Platform.h:

Tools:

• DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView): Remove Skia #ifdef references.

9:16 AM Changeset in webkit [149192] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
​https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux

9:15 AM Changeset in webkit [149191] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

Sort jsc-test-list

$ sort -f -o LayoutTests/fast/js/jsc-test-list LayoutTests/fast/js/jsc-test-list

• fast/js/jsc-test-list: Sort case-insensitively.

9:15 AM Changeset in webkit [149190] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

Upstream iOS changes to jsc-test-list

Reviewed by Michael Saboff.

• fast/js/jsc-test-list: Add tests.

9:12 AM Changeset in webkit [149189] by kadam@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip two failing tests.

• platform/qt/TestExpectations:

9:08 AM Changeset in webkit [149188] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Assert in JSC::Heap::unprotect when closing facebook.com web site
​https://bugs.webkit.org/show_bug.cgi?id=115058

Reviewed by Darin Adler.

Grab a JSLock before calling RootObject::invalidate().

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):

8:17 AM Changeset in webkit [149187] by eric.carlson@apple.com

• 6 edits in trunk/Source/WebCore

[Mac] in-band cues sometimes have incorrect duration
​https://bugs.webkit.org/show_bug.cgi?id=115200

Reviewed by Jer Noble.

No new tests, this is not possible to test in DRT.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addGenericCue): Don't add completed cues to the map.
(WebCore::InbandTextTrack::removeGenericCue): Log when a cue is removed from the track.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Initialize m_pendingCueStatus.
(WebCore::InbandTextTrackPrivateAVF::processCue): Never call update() on a cue that is delivered

while seeking.

(WebCore::InbandTextTrackPrivateAVF::beginSeeking): Flush all incomplete cues, remember that

we are seeking.

(WebCore::InbandTextTrackPrivateAVF::resetCueValues):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::seek): Call track->beginSeeking() instead of resetCueValues().
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Call track->endSeeking().

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind): Include class name in Kind enum values to

avoid compile error.

8:14 AM Changeset in webkit [149186] by akling@apple.com

• 21 edits in trunk/Source/WebCore

Remove wxWebKit from WebCore.
<​http://webkit.org/b/115255>

Reviewed by Anders Carlsson.

• DerivedSources.make:
• WebCorePrefix.h:
• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::port):

• config.h:
• html/HTMLFormElement.cpp:
• platform/ContextMenu.h:

(ContextMenu):

• platform/ContextMenuItem.h:
• platform/Cursor.h:
• platform/DragData.h:
• platform/DragImage.h:
• platform/FileSystem.h:
• platform/PlatformExportMacros.h:
• platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

• platform/PlatformMenuDescription.h:
• platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

• platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

• platform/ScrollView.cpp:
• platform/ScrollView.h:

(ScrollView):

• platform/Widget.h:
• platform/win/SharedTimerWin.cpp:

8:13 AM Changeset in webkit [149185] by commit-queue@webkit.org

• 6 edits
  3 adds in trunk

use-after-free removing a frame from its parent in a beforeload event of an OBJECT element
​https://bugs.webkit.org/show_bug.cgi?id=113964

Source/WebCore:

Object elements have the tendecny to modify or even fully remove
the containing Document inside beforeload callback. While Document is removed,
RenderArena gets destroyed. Retained RenderWidgets fails to function with NULL arena.

Protect RendereArena from getting wiped out, when Document is removed
during FrameView::updateWidget().

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

Test: fast/frames/crash-remove-iframe-during-object-beforeload.html

• dom/Document.cpp:

(WebCore::Document::attach):

• dom/Document.h:

(Document):

• page/FrameView.cpp:

(WebCore::FrameView::updateWidgets):

• rendering/RenderArena.h:

(RenderArena):
(WebCore::RenderArena::create):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

• fast/frames/crash-remove-iframe-during-object-beforeload-expected.txt: Added.
• fast/frames/crash-remove-iframe-during-object-beforeload.html: Added.
• fast/frames/resources/remove-this-during-object-beforeload.html: Added.

7:56 AM Changeset in webkit [149184] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Add move semantics to RefPtr
​https://bugs.webkit.org/show_bug.cgi?id=115033

Reviewed by Anders Carlsson.

Add move constructors and move assignment operators to RefPtr when
COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES).
This obviates unnecessary reffing/ureffing when RefPtr is created
or assigned from rvalue references.

• wtf/RefPtr.h:

(RefPtr):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::operator=):

7:32 AM Changeset in webkit [149183] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149165): It made many tests crash on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=115227

Reviewed by Csaba Osztrogonác.

m_reservation is uninitialized when ENABLE(SUPER_REGION) is false.

• heap/SuperRegion.cpp:

(JSC::SuperRegion::~SuperRegion):

6:59 AM Changeset in webkit [149182] by mary.wu@torchmobile.com.cn

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should check if it's cached resource before download
​https://bugs.webkit.org/show_bug.cgi?id=115101

Reviewed by Rob Buis.

Since main resource maybe cached, if user want to save the resource, we first check
if it's cached. If yes, don't need to initiate a fresh load again, but get the
cached resource data out to save.

RIM bug# 324003, internally reviewed by Charles Wei.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

6:20 AM Changeset in webkit [149181] by zandobersek@gmail.com

• 3 edits
  20 adds in trunk/LayoutTests

[GTK] Enable Web Audio layout tests on WK2, provide platform-specific expected output
​https://bugs.webkit.org/show_bug.cgi?id=114513

Reviewed by Philippe Normand.

Unskip the Web Audio layout tests for GTK WK2 and generate platform-specific baselines for the tests.
The audio baselines are not audibly different from the generic baselines, but it can be expected that
different backends won't produce the same binary output.

The remaining failures are marked as such in the TestExpectations, each failure having the appropriate
bug handle covering the issue. The tests are still skipped for GTK WK1 as DumpRenderTree is still missing
infrastructure support for running these tests.

• platform/gtk-wk1/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/webaudio/audiobuffersource-loop-points-expected.wav: Added.
• platform/gtk/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
• platform/gtk/webaudio/oscillator-custom-expected.wav: Added.
• platform/gtk/webaudio/oscillator-sawtooth-expected.wav: Added.
• platform/gtk/webaudio/oscillator-sine-expected.wav: Added.
• platform/gtk/webaudio/oscillator-square-expected.wav: Added.
• platform/gtk/webaudio/oscillator-triangle-expected.wav: Added.

6:16 AM Changeset in webkit [149180] by mary.wu@torchmobile.com.cn

• 5 edits in trunk

[BlackBerry] Clean up load interface in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=113267

Reviewed by Rob Buis.

Source/WebKit/blackberry:

Remove unused loadExtended(), combine load() and download() api in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::load):

• Api/WebPage.h:

Tools:

Update DumpRenderTree with change of load() interface in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::runTest):

6:09 AM Changeset in webkit [149179] by Claudio Saavedra

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardnering. Unskip passing test.

• platform/gtk/TestExpectations: Unskip http/tests/inspector/compiler-source-mapping-debug.html

6:07 AM Changeset in webkit [149178] by akling@apple.com

• 8 edits
  3 deletes in trunk/Source/WTF

Remove wxWebKit from WTF.
<​http://webkit.org/b/115249>

Reviewed by Antti Koivisto.

• wscript: Removed.
• wtf/ArrayBufferView.h:

(ArrayBufferView):

• wtf/CurrentTime.cpp:
• wtf/DisallowCType.h:
• wtf/ExportMacros.h:
• wtf/FeatureDefines.h:
• wtf/Platform.h:
• wtf/text/WTFString.h:

(String):

• wtf/wx/MainThreadWx.cpp: Removed.
• wtf/wx/StringWx.cpp: Removed.

6:03 AM Changeset in webkit [149177] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Optimize function and interface object length computation in bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115247

Reviewed by Kentaro Hara.

Introduce new GetFunctionLength() function that efficiently compute the length
of a function (i.e. its number of mandatory parameters).

We now call GetFunctionLength() instead of GenerateFunctionParametersCheck()
whenever we care only interested in the function length and not the actual
expression for checking the parameters. This is much more efficient as
GenerateFunctionParametersCheck() does a lot more processing than we need in
this case.

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionLength):
(GenerateImplementation):
(GenerateConstructorHelperMethods):

6:02 AM Changeset in webkit [149176] by zandobersek@gmail.com

• 1 edit
  1 delete in trunk/Tools

Remove the HeapGraphSerializer unit test
​https://bugs.webkit.org/show_bug.cgi?id=115231

Reviewed by Andreas Kling.

Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.

• TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.

5:09 AM FeatureFlags edited by akling@apple.com

(diff)

4:48 AM Changeset in webkit [149175] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Web Audio: Remove reduplicative addInput() in AnalyserNode.
<​http://webkit.org/b/115244>

From Blink r149155 by <​james.wei@intel.com>:

The parent class BasicInspectorNode already called addInput() and addOutput().
So it is reduplicative to call them in AnalyserNode.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

• Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

• Modules/webaudio/AudioBasicInspectorNode.h:

(AudioBasicInspectorNode):

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

3:30 AM Changeset in webkit [149174] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Add unit test cases for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-04-26
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

• tests/test_ewk_setting.cpp:

(TEST_F):

2:42 AM Changeset in webkit [149173] by allan.jensen@digia.com

• 20 edits
  4 adds in trunk

Mouseenter and mouseleave events not supported
​https://bugs.webkit.org/show_bug.cgi?id=18930

Reviewed by David Hyatt.

Source/WebCore:

Implements mouseenter and mouseleave events from W3C DOM Level 3 Events.
These event are already supported by all other major browsers.

To avoid performance regressions the new events are only dispatched when
there are event listeners for them.

Tests: fast/events/mouseenter-mouseleave-capture.html

fast/events/mouseenter-mouseleave.html

• bindings/scripts/CodeGenerator.pm:
• dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):
(WebCore::Document::updateHoverActiveState):

• dom/Document.h:

(Document):

• dom/Document.idl:
• dom/Element.h:

(Element):

• dom/Element.idl:
• dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsCapturing):

• dom/EventListenerMap.h:

(EventListenerMap):

• dom/EventNames.h:
• dom/EventTarget.h:

(EventTarget):
(WebCore::EventTarget::hasCapturingEventListeners):

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):

• html/HTMLAttributeNames.in:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName):

• page/DOMWindow.h:

(DOMWindow):

• page/DOMWindow.idl:
• svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute):

• svg/SVGElementInstance.h:

(SVGElementInstance):

• svg/SVGElementInstance.idl:

LayoutTests:

To new tests that mouseenter and mouseleave works in both bubbling and capture phase.

• fast/events/mouseenter-mouseleave-capture-expected.txt: Added.
• fast/events/mouseenter-mouseleave-capture.html: Added.
• fast/events/mouseenter-mouseleave-expected.txt: Added.
• fast/events/mouseenter-mouseleave.html: Added.

2:36 AM Changeset in webkit [149172] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix SH4 build broken since r149159.
​https://bugs.webkit.org/show_bug.cgi?id=115229

Add BranchTruncateType enum in SH4 port and handle it in branchTruncateDoubleToInt32.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-26
Reviewed by Allan Sandfeld Jensen.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

2:16 AM Changeset in webkit [149171] by Christophe Dumez

• 5 edits in trunk/LayoutTests

[Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
​https://bugs.webkit.org/show_bug.cgi?id=115235

Reviewed by Kentaro Hara.

Update window-property.html test cases for DeviceMotion and DeviceOrientation.
The global constructors are no longer enumerable after r149001.

• fast/dom/DeviceMotion/script-tests/window-property.js:
• fast/dom/DeviceMotion/window-property-expected.txt:
• fast/dom/DeviceOrientation/script-tests/window-property.js:
• fast/dom/DeviceOrientation/window-property-expected.txt:

12:38 AM WebKitIDL edited by Christophe Dumez

Drop Supplemental in favor of partial interfaces due to r149170 (diff)

12:35 AM WebKitIDL edited by Christophe Dumez

[Callback] only applies to parameters, not interfaces (diff)

12:29 AM Changeset in webkit [149170] by Christophe Dumez

• 33 edits in trunk/Source/WebCore

Add support for Web IDL partial interfaces to the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115228

Reviewed by Kentaro Hara.

Add support for Web IDL partial interfaces to the bindings generator:
​http://dev.w3.org/2006/webapi/WebIDL/#dfn-partial-interface

Also drop support for the the WebKit-specific [Supplemental] extended
attribute and use partial interfaces instead in existing IDL files.

No new tests, no behavior change.

• Modules/battery/NavigatorBattery.idl:
• Modules/filesystem/DOMWindowFileSystem.idl:
• Modules/filesystem/DataTransferItemFileSystem.idl:
• Modules/filesystem/HTMLInputElementFileSystem.idl:
• Modules/filesystem/WorkerContextFileSystem.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/geolocation/NavigatorGeolocation.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/WorkerContextIndexedDatabase.idl:
• Modules/mediastream/DOMWindowMediaStream.idl:
• Modules/mediastream/NavigatorMediaStream.idl:
• Modules/navigatorcontentutils/NavigatorContentUtils.idl:
• Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
• Modules/notifications/DOMWindowNotifications.idl:
• Modules/notifications/WorkerContextNotifications.idl:
• Modules/quota/DOMWindowQuota.idl:
• Modules/quota/NavigatorStorageQuota.idl:
• Modules/quota/WorkerNavigatorStorageQuota.idl:
• Modules/speech/DOMWindowSpeech.idl:
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/vibration/NavigatorVibration.idl:
• Modules/webaudio/DOMWindowWebAudio.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/WorkerContextWebDatabase.idl:
• Modules/websockets/DOMWindowWebSocket.idl:
• Modules/websockets/WorkerContextWebSocket.idl:
• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parsePartialDefinition):

• bindings/scripts/generate-bindings.pl:
• bindings/scripts/preprocess-idls.pl:

(getPartialInterfaceNameFromIDLFile):

• bindings/scripts/test/TestSupplemental.idl:
• page/DOMWindowPagePopup.idl:

Apr 25, 2013:

11:50 PM Changeset in webkit [149169] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebKit2

[GTK] Plugin process broken due to a missing symbol
​https://bugs.webkit.org/show_bug.cgi?id=114901

Reviewed by Gustavo Noronha Silva.

Work around the missing symbols in the WebKitPluginProcess by specifying the required libraries
multiple times in the program's LDADD list. Libtool fights fiercely to avoid duplicate static library
references among the linker arguments (even if using the --preserve-dup-deps flag) so the required libraries
are specified in various ways.

The unresolved symbols in object files are no longer ignored as this can lead to further trouble (for instance
this patch also adds a few missing source files to the list of WebKitPluginProcess sources). The Freetype and
gamepad dependencies' libraries are also added to the binary's LDADD list.

• GNUmakefile.am:
• GNUmakefile.list.am: Add a few missing files to the build.

11:23 PM Changeset in webkit [149168] by mihnea@adobe.com

• 4 edits
  2 adds in trunk

[CSS Regions] Hit testing is broken for absolutely positioned regions that have overflow: hidden
​https://bugs.webkit.org/show_bug.cgi?id=113874

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/hit-test-abspos-overflow-region.html

When a region is an out-of-flow positioned object with an overflow clip, we need
to make sure that hit testing works also for cases other than foreground (content)
hit testing. This patch moves the previous hit testing code, that delegated foreground
hit testing to the region's flow thread hit testing, into the hitTestContent method,
now that RenderRegion is RenderBlock based.

• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::hitTestContents):

• rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

Add test for hit-testing of border of an out-of-flow region with overflow: hidden.

• fast/regions/hit-test-abspos-overflow-region-expected.txt: Added.
• fast/regions/hit-test-abspos-overflow-region.html: Added.

9:51 PM Changeset in webkit [149167] by rniwa@webkit.org

• 4 edits
  2 adds in trunk

Copy and paste can strip !important CSS rules due to a bug in mergeStyleFromRules
​https://bugs.webkit.org/show_bug.cgi?id=115217

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by mergeStyleFromRules overriding "important" style rules with "unimportant" inline styles.
Fixed the bug by using addParsedProperty, which respects !important, in MutableStylePropertySet's
mergeAndOverrideOnConflict, which was only used in editing code. Now that we've fixed this function, we can use
it in ViewportStyleResolver::addViewportRule as well.

Test: editing/pasteboard/copy-paste-with-important-rules.html

• css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict): Fixed to respect !important.

• css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule): Use mergeAndOverrideOnConflict now that the code is identical.

LayoutTests:

Added a regression test.

• editing/pasteboard/copy-paste-with-important-rules-expected.txt: Added.
• editing/pasteboard/copy-paste-with-important-rules.html: Added.

9:50 PM Changeset in webkit [149166] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Remove support for Chromium from build/update scripts
​https://bugs.webkit.org/show_bug.cgi?id=115218

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Darin Adler.

• Scripts/build-webkit:

(writeCongrats):

• Scripts/update-webkit:

7:47 PM Changeset in webkit [149165] by mhahnenberg@apple.com

• 4 edits in trunk/Source/JavaScriptCore

SuperRegion doesn't call deallocate() on its PageReservation
​https://bugs.webkit.org/show_bug.cgi?id=115208

Reviewed by Geoffrey Garen.

It should. This doesn't cause us to leak physical memory, but it does cause us to leak virtual
address space (and probably mach ports), which is also bad :-( FixedVMPoolExecutableAllocator
also has this bug, but it doesn't matter much because there's only one instance of that class
throughout the entire lifetime of the process, whereas each VM has its own SuperRegion.

• heap/SuperRegion.cpp:

(JSC::SuperRegion::~SuperRegion):

• heap/SuperRegion.h:

(SuperRegion):

• jit/ExecutableAllocatorFixedVMPool.cpp:

(FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::~FixedVMPoolExecutableAllocator):

7:30 PM Changeset in webkit [149164] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Remove support for Chromium from api-test
​https://bugs.webkit.org/show_bug.cgi?id=115211

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Dirk Pranke.

• Scripts/build-api-tests:
• Scripts/run-api-tests:

(isSupportedPlatform):

6:38 PM Changeset in webkit [149163] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Get rid of Chromium in build-dumprendertree
​https://bugs.webkit.org/show_bug.cgi?id=115212

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Dirk Pranke.

• Scripts/build-dumprendertree:

6:18 PM Changeset in webkit [149162] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

DFG doesn't support to_jsnumber
​https://bugs.webkit.org/show_bug.cgi?id=115129

Reviewed by Geoffrey Garen.

Based on Oliver's patch. Implements to_jsnumber as Identity(Number:@thingy), and then does
an optimization in Fixup to turn Identity(Number:) into Identity(Int32:) if the predictions
tell us to. Identity is later turned into Phantom.

Also fixed BackPropMask, which appeared to have NodeDoesNotExit included in it. That's
wrong; NodeDoesNotExit is not a backward propagation property.

Also fixed Identity to be marked as CanExit (i.e. not NodeDoesNotExit).

This more than doubles the FPS on ammo.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::observeUseKindOnEdge):

• dfg/DFGNodeFlags.h:

(DFG):

• dfg/DFGNodeType.h:

(DFG):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

5:50 PM Changeset in webkit [149161] by mrowe@apple.com

• 4 edits in trunk/Source

Versioning.

5:49 PM Changeset in webkit [149160] by mrowe@apple.com

• 1 copy in tags/Safari-537.39

New tag.

5:41 PM Changeset in webkit [149159] by oliver@apple.com

• 21 edits
  12 adds in trunk

Add support for Math.imul
​https://bugs.webkit.org/show_bug.cgi?id=115143

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add support for Math.imul, a thunk generator for Math.imul,
and an intrinsic.

Fairly self explanatory set of changes, DFG intrinsics simply
leverages the existing ValueToInt32 nodes.

• create_hash_table:
• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:

(DFG):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithIMul):

• dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/ThunkGenerators.cpp:

(JSC::imulThunkGenerator):
(JSC):

• jit/ThunkGenerators.h:

(JSC):

• runtime/Intrinsic.h:
• runtime/MathObject.cpp:

(JSC):
(JSC::mathProtoFuncIMul):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

LayoutTests:

Add a bunch of tests for Math.imul

• fast/js/Object-getOwnPropertyNames-expected.txt:
• fast/js/imul-expected.txt: Added.
• fast/js/imul.html: Added.
• fast/js/regress/imul-double-only-expected.txt: Added.
• fast/js/regress/imul-double-only.html: Added.
• fast/js/regress/imul-int-only-expected.txt: Added.
• fast/js/regress/imul-int-only.html: Added.
• fast/js/regress/imul-mixed-expected.txt: Added.
• fast/js/regress/imul-mixed.html: Added.
• fast/js/regress/script-tests/imul-double-only.js: Added.

(f):

• fast/js/regress/script-tests/imul-int-only.js: Added.

(f):

• fast/js/regress/script-tests/imul-mixed.js: Added.

(f):

• fast/js/script-tests/Object-getOwnPropertyNames.js:
• fast/js/script-tests/imul.js: Added.

(testIMul):

5:40 PM Changeset in webkit [149158] by fpizlo@apple.com

• 15 edits in trunk/Source

Unreviewed, roll out ​http://trac.webkit.org/changeset/148999
It broke ​http://kripken.github.io/ammo.js/examples/new/ammo.html

Source/JavaScriptCore:

• JavaScriptCore.order:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldEmitProfileHooks):
(BytecodeGenerator):

• bytecompiler/NodesCodegen.cpp:

(JSC):
(JSC::NullNode::emitBytecode):
(JSC::BooleanNode::emitBytecode):
(JSC::NumberNode::emitBytecode):
(JSC::StringNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createIfStatement):
(ASTBuilder):

• parser/NodeConstructors.h:

(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):

• parser/Nodes.h:

(JSC::ExpressionNode::isPure):
(JSC::ExpressionNode::isSubtract):
(StatementNode):
(NullNode):
(JSC::NullNode::isNull):
(BooleanNode):
(JSC::BooleanNode::isPure):
(NumberNode):
(JSC::NumberNode::value):
(JSC::NumberNode::isPure):
(StringNode):
(JSC::StringNode::isPure):
(JSC::StringNode::isString):
(BinaryOpNode):
(IfNode):
(JSC):
(IfElseNode):
(ContinueNode):
(BreakNode):

• parser/Parser.cpp:

(JSC::::parseIfStatement):

• parser/ResultType.h:

(ResultType):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

• runtime/JSCell.h:

(JSCell):

• runtime/JSCellInlines.h:

(JSC):

Source/WTF:

• wtf/TriState.h:

5:33 PM Changeset in webkit [149157] by akling@apple.com

• 4 edits in trunk/Source/WebCore

StylePropertySet::getPropertyShorthand() should return a String.
<​http://webkit.org/b/115213>

Reviewed by Anders Carlsson.

Return a String directly from getPropertyShorthand() instead of forcing clients
to call getPropertyNameString().

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):

• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyShorthand):

• css/StylePropertySet.h:

(StylePropertySet):

5:27 PM Changeset in webkit [149156] by Chris Fleizach

• 13 edits in trunk

WEB SPEECH: language support does not work as expected
​https://bugs.webkit.org/show_bug.cgi?id=115119

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Make the Mac platform synthesizer have access to all the voices installed on the system.

• WebCore.exp.in:
• platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

• WebKitSystemInterface.h:

4:33 PM Changeset in webkit [149155] by Chris Fleizach

• 11 edits
  2 adds in trunk

Source/WebCore: <meter> element not exposed to accessibility
​https://bugs.webkit.org/show_bug.cgi?id=109023
rdar://problem/13658964

Reviewed by Tim Horton.

Makes the <meter> element appear in the AX tree by reusing the
AccessibilityProgressIndicator element to handle either progress or meter
elements.

Test: accessibility/meter-element.html

• accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):
(WebCore::AXObjectCache::getOrCreate):

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):

• accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::AccessibilityProgressIndicator):
(WebCore::AccessibilityProgressIndicator::create):
(WebCore::AccessibilityProgressIndicator::valueForRange):
(WebCore::AccessibilityProgressIndicator::maxValueForRange):
(WebCore::AccessibilityProgressIndicator::minValueForRange):
(WebCore::AccessibilityProgressIndicator::progressElement):
(WebCore::AccessibilityProgressIndicator::meterElement):

• accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::AccessibilityRenderObject::lastChild):

These methods are modified to handle when there is no rendered children, but there are Node
children. The node children are desired when calculating text within a node, for example.

LayoutTests: <meter> element not exposed to accessibility
​https://bugs.webkit.org/show_bug.cgi?id=109023

Reviewed by Tim Horton.

• accessibility/meter-element-expected.txt: Added.
• accessibility/meter-element.html: Added.
• platform/mac/accessibility/role-subrole-roledescription-expected.txt:
• platform/mac/accessibility/role-subrole-roledescription.html:

4:10 PM Changeset in webkit [149154] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

PreciseJumpTargets should treat loop_hint as a jump target
​https://bugs.webkit.org/show_bug.cgi?id=115209

Reviewed by Mark Hahnenberg.

I didn't add a test but I turned this into a release assertion. Running Octane is enough
to trigger it.

• bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

4:06 PM Changeset in webkit [149153] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[CSS Shaders] Remove the meshType from the CustomFilterOperation
​https://bugs.webkit.org/show_bug.cgi?id=102529

Patch by Qiankun Miao <​qiankun.miao@intel.com> on 2013-04-25
Reviewed by Dean Jackson.

No new tests, no new functionality.

MeshType can be accessed from program, so remove the m_meshType
related code in CustomFilterOperation.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

• platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):

• platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::meshType):
(CustomFilterOperation):
(WebCore::CustomFilterOperation::operator==):

• platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h:

(WebCore::CoordinatedCustomFilterOperation::CoordinatedCustomFilterOperation):

3:52 PM Changeset in webkit [149152] by commit-queue@webkit.org

• 10 edits
  9 adds in trunk

Source/JavaScriptCore: Fix problems with processing negative zero on DFG.
​https://bugs.webkit.org/show_bug.cgi?id=113862

Patch by Roman Zhuykov <​zhroma@ispras.ru> on 2013-04-25
Reviewed by Filip Pizlo.

Fix NodeNeedsNegZero flag propagation in BackwardPropagationPhase.
Function arithNodeFlags should not mask NodeNeedsNegZero flag for ArithNegate and DoubleAsInt32
nodes and this flag should be always used to decide where we need to generate nezative-zero checks.
Remove unnecessary negative-zero checks from integer ArithDiv on ARM.
Also remove such checks from integer ArithMod on ARM and X86, and make them always to
check not only "modulo_result == 0" but also "dividend < 0".
Generate faster code for case when ArithMod operation divisor is constant power of 2 on ARMv7
in the same way as on ARMv7s, and add negative-zero checks into this code when needed.
Change speculationCheck ExitKind from Overflow to NegativeZero where applicable.

This shows 30% speedup of math-spectral-norm, and 5% speedup
on SunSpider overall on ARMv7 Linux.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32):

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchConvertDoubleToInt32):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotPosZero):
(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGNode.h:

(JSC::DFG::Node::arithNodeFlags):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithNegate):

LayoutTests: Arithmetic operations with negative zero should be optimized correclty.
​https://bugs.webkit.org/show_bug.cgi?id=113862

Patch by Roman Zhuykov <​zhroma@ispras.ru> on 2013-04-25
Reviewed by Filip Pizlo.

• fast/js/regress/negative-zero-divide-expected.txt: Added.
• fast/js/regress/negative-zero-divide.html: Added.
• fast/js/regress/negative-zero-modulo-expected.txt: Added.
• fast/js/regress/negative-zero-modulo.html: Added.
• fast/js/regress/negative-zero-negate-expected.txt: Added.
• fast/js/regress/negative-zero-negate.html: Added.
• fast/js/regress/script-tests/negative-zero-divide.js: Added.

(foo):

• fast/js/regress/script-tests/negative-zero-modulo.js: Added.

(foo):

• fast/js/regress/script-tests/negative-zero-negate.js: Added.

(foo):

3:51 PM Changeset in webkit [149151] by tkent@chromium.org

• 7 edits in trunk

Ignore invalid regular expressions for input[pattern].
​https://bugs.webkit.org/show_bug.cgi?id=115204

Reviewed by Darin Adler.

Source/WebCore:

According to the specification, we should not proceed regular expression
matching if a pattern attribute value is an invalid regular
expression. We had a bug that invalid expressions such as
pattern=")foo(" made RegularExpression objects successfully.

​http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-pattern-attribute

If an input element has a pattern attribute specified, and the
attribute's value, when compiled as a JavaScript regular expression with
the global, ignoreCase, and multiline flags disabled (see ECMA262
Edition 5, sections 15.10.7.2 through 15.10.7.4), compiles successfully,
then the resulting regular expression is the element's compiled pattern
regular expression. If the element has no such attribute, or if the
value doesn't compile successfully, then the element has no compiled
pattern regular expression.

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):
Check correctness of pattern attribute value before wrapping with parentheses.

• platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::isValid): Added.

• platform/text/RegularExpression.h:

(RegularExpression): Declare isValid.

LayoutTests:

• fast/forms/ValidityState-patternMismatch-expected.txt:
• fast/forms/ValidityState-patternMismatch.html:

3:50 PM Changeset in webkit [149150] by oliver@apple.com

• 2 edits in trunk/Source/WTF

Fix 32bit build

3:37 PM Changeset in webkit [149149] by Simon Fraser

• 2 edits in trunk/Source/WebKit/mac

Build fix for smart compliers.

Reviewed by Tim Horton.

[NSDictionary dictionaryWithObjectsAndKeys:] returns an NSDictionary,
not a NSMutableDictionary.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::updateSpellingUIWithGrammarString):

3:25 PM Changeset in webkit [149148] by ap@apple.com

• 8 edits in trunk/Tools

Pass relatedPage when creating a page in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=115206

Reviewed by Geoffrey Garen.

To make sure that window.open() opens in the same process even when using multiple processes.

• WebKitTestRunner/PlatformWebView.h:
• WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
• WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView):
• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView):
• WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]): (WTR::PlatformWebView::PlatformWebView):
• WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
• WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::PlatformWebView):

3:23 PM Changeset in webkit [149147] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Rename DecidePolicyForResponse message to DecidePolicyForResponseSync
​https://bugs.webkit.org/show_bug.cgi?id=115207

Reviewed by Beth Dakin.

In preparation for adding a new async DecidePolicyForResponse message,
rename the current one to DecidePolicyForResponseSync. Also split out the async part
into a separate WebPageProxy::decidePolicyForResponse member function.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

3:17 PM Changeset in webkit [149146] by oliver@apple.com

• 4 edits in trunk/Source

Stack guards are too conservative
​https://bugs.webkit.org/show_bug.cgi?id=115147

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Increase stack guard to closer to old size.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

Source/WTF:

Use getrlimit on darwin to get the stack size for the main thread.

• wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

2:39 PM Changeset in webkit [149145] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
​https://bugs.webkit.org/show_bug.cgi?id=115197

Patch by Andrew Lo <​anlo@rim.com> on 2013-04-25
Reviewed by Rob Buis.

When drawing the selection overlay, the rects to
paint when selecting text on non-composited sub-frames
need to be adjusted by the frame position.

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

2:29 PM Changeset in webkit [149144] by Antoine Quint

• 2 edits in trunk/Source/WebCore

Glyphs may fail to render when using SVG font
​https://bugs.webkit.org/show_bug.cgi?id=115193

Reviewed by Simon Fraser.

Calling SimpleFontData::applyTransforms() when the font used is
an SVG font makes little sense since Core Text doesn’t know or
understand SVG fonts and would be passed some other, unrelated
platform font.

• platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::applyTransforms):

2:21 PM Changeset in webkit [149143] by rniwa@webkit.org

• 2 edits in trunk/Tools

Fix autocompletion for Benjamin. The Bugzilla email address must come first.

• Scripts/webkitpy/common/config/contributors.json:

2:02 PM Changeset in webkit [149142] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

Media elements shouldn't resume playback when a page is restored from the back/forward cache if the WKView isn't in a window
​https://bugs.webkit.org/show_bug.cgi?id=115191

Reviewed by Eric Carlson.

If a page is suspended, then resumed when its WebView or WKView has been removed from a window,
the page's media elements will unpause. Check whether media is allowed to start during resume()
via Page::canMediaStart() and if not, register for mediaCanStart notifications. Then, in
mediaCanStart() if the media is force-paused, unpause it.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::mediaCanStart):

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::pageConsentRequiredForResume):

2:01 PM Changeset in webkit [149141] by ap@apple.com

• 2 edits in trunk/LayoutTests

Update a comment, mentioning a newly filed bug.

• platform/wk2/TestExpectations:

1:37 PM Changeset in webkit [149140] by akling@apple.com

• 7 edits in trunk/Source

Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.

Rubber-stamped by Anders Koivisto.

Source/WebCore:

• PlatformWinCE.cmake:
• accessibility/AccessibilityObject.h:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Source/WebKit:

• PlatformWinCE.cmake:

Source/WebKit/blackberry:

• WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

• wtf/FeatureDefines.h:

1:26 PM Changeset in webkit [149139] by Patrick Gansterer

• 5 edits in trunk/Source

Remove OS(WINCE) from AccessibilityObject.h
​https://bugs.webkit.org/show_bug.cgi?id=115192

Reviewed by Andreas Kling.

Use the same files like the the other PLATFORM(WIN) ports use.

Source/WebCore:

• PlatformWinCE.cmake:
• accessibility/AccessibilityObject.h:

(AccessibilityObject):

Source/WebKit:

• PlatformWinCE.cmake:

1:11 PM Changeset in webkit [149138] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add definition of GlyphBufferGlyph for BlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=115183

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-25
Reviewed by Xan Lopez.

BlackBerry uses an unsigned int.

• platform/graphics/GlyphBuffer.h:

(WebCore):

1:02 PM Changeset in webkit [149137] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
​https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

PR 308796

Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
left point of the viewport.
On the page with fixed position elements, we want it to adjust the position beneath
the fixed elements so it can be always visible.

The basic idea is:

1. Detect if there are fixed position elements before going through ProximityDetector.
2. If the fixed element exists, calculate its the size and the actual visible position

beneath it.

3. Pass the position to ProximityDetector. Then according to the new position we get,

calculate the top left position of the viewport (final scroll position).

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
(WebKit):

• Api/WebPage.h:
• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
(WebKit):

• Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

1:00 PM Changeset in webkit [149136] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Stack guards are too conservative
​https://bugs.webkit.org/show_bug.cgi?id=115147

Reviewed by Geoffrey Garen.

Reduce the limits and simplify the decision making.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

12:56 PM Changeset in webkit [149135] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable balanced page group load deferrer behaviour.
​https://bugs.webkit.org/show_bug.cgi?id=115189

Patch by Mike Lattanzio <​mlattanzio@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

Prevent a possible deadlock by enabling balanced deferrers.
Internally reviewed by: Joe Mason
PR 329986

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

12:54 PM Changeset in webkit [149134] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

JSC: Fix interpreter misbehavior in builds with JIT disabled
​https://bugs.webkit.org/show_bug.cgi?id=115190

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-04-25
Reviewed by Oliver Hunt.

Commit ​http://trac.webkit.org/changeset/147858 modified
some details on how JS stack traces are built. The method
"getLineNumberForCallFrame", renamed in that changeset to
"getBytecodeOffsetForCallFrame" is always returning `0' when
JIT is disabled

How to reproduce:

• Build webkit with JIT disabled
• Open MiniBrowser, for example, with ​http://google.com
• In a debug build, WebProcess will hit the following ASSERT: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:279 ASSERT(low);

• interpreter/Interpreter.cpp:

(JSC::getBytecodeOffsetForCallFrame):

12:50 PM Changeset in webkit [149133] by rniwa@webkit.org

• 2 edits in trunk/Tools

Build fix. Forgot to merge args.

• Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

12:44 PM Changeset in webkit [149132] by rniwa@webkit.org

• 2 edits in trunk/Tools

webkitbot should recognize its own nickname in greetings.
​https://bugs.webkit.org/show_bug.cgi?id=115196

Reviewed by Andreas Kling.

Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.

• Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

12:31 PM Changeset in webkit [149131] by Joseph Pecoraro

• 21 edits
  2 adds
  2 deletes in trunk

ScriptExecutionContext log exception should include a column number
​https://bugs.webkit.org/show_bug.cgi?id=114315

Reviewed by Oliver Hunt.

Source/WebCore:

Test: inspector/console/console-exception-stack-traces.html

• bindings/js/ScriptCallStackFactory.h:
• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackFromException):
Generate a ScriptCallStack from an exception. Use the vm.exceptionStack
if available, and fallback to the exception object where needed.

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Always include a non-empty call stack with exceptions.
Where not provided, fallback to the exception object.

• dom/Document.h:
• dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

• dom/ScriptExecutionContext.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::PendingException::PendingException):
(ScriptExecutionContext::PendingException):
(WebCore::ScriptExecutionContext::reportException):

• workers/DefaultSharedWorkerRepository.cpp:
• workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

• workers/SharedWorkerContext.h:
• workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):

• workers/WorkerContext.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::performTask):
Plumb columnNumber through as needed.

LayoutTests:

• inspector/console/console-exception-stack-traces-expected.txt: Added.
• inspector/console/console-exception-stack-traces.html: Added.

Verifies that exceptions have stack traces and match a console.trace stack.

• http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Removed.
• http/tests/inspector-enabled/console-exception-while-no-inspector.html: Removed.

We now save exception backtraces even if the inspector is not open.

• fast/dom/javascript-url-exception-isolation-expected.txt
• fast/events/remove-target-with-shadow-in-drag-expected.txt
• fast/events/set-attribute-listener-window-onerror-crash-expected.txt
• inspector-protocol/media-query-listener-exception-expected.txt:
• inspector/console/console-uncaught-exception-expected.txt:
• inspector/console/console-uncaught-exception-in-eval-expected.txt:

Update results that now include backtraces or different data. Most better, some worse.

12:02 PM WebKitIDL edited by Christophe Dumez

[Callback] only applies to parameters, not interfaces (diff)

11:59 AM Changeset in webkit [149130] by oliver@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Make checkSyntax take a VM instead of an ExecState

RS=Tim

11:57 AM WebKitIDL edited by Christophe Dumez

Update [Callback] extended attribute doc due to r149113 (diff)

11:50 AM Changeset in webkit [149129] by Gregg Tavares

• 5 edits in trunk/Source/WebCore

Fix build files so WebGLDebugXXX extensions can be used if enabled.
​https://bugs.webkit.org/show_bug.cgi?id=113976

Reviewed by Dean Jackson.

No new tests as no new functionality.

• DerivedSources.make:
• GNUmakefile.list.am:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSWebGLRenderingContextCustom.cpp:

11:35 AM Changeset in webkit [149128] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

32 Bit: Crash due to RegExpTest nodes not setting result type to Boolean
​https://bugs.webkit.org/show_bug.cgi?id=115188

Reviewed by Geoffrey Garen.

Changed the RegExpTest node to set the AbstractValue to boolean, since that
what it is.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

11:33 AM Changeset in webkit [149127] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

cloneChildNodes looks for deleteButtonController in each level of recursion
​https://bugs.webkit.org/show_bug.cgi?id=115146

Reviewed by Andreas Kling.

Obtain the delete button controller upfront, and shallow copy descendents of each child
so that we don't look for the delete button controller inside cloneNode called on each child.

Performance Tests: DOM/CloneNodes.html

• dom/ContainerNode.cpp:

(WebCore::cloneChildNodesAvoidingDeleteButon): Extracted.
(WebCore::ContainerNode::cloneChildNodes):

11:32 AM Changeset in webkit [149126] by rniwa@webkit.org

• 8 edits in trunk

HTMLOptionsCollection's namedItem and name getter should return the first item
​https://bugs.webkit.org/show_bug.cgi?id=115150

Reviewed by Andreas Kling.

Source/WebCore:

Following the resolution in ​http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-December/038355.html,
the spefication has been updated to only return the first item when there are multiple items of the same name
in HTMLOptionsCollection; this new behavior matches that of Firefox and Opera (Presto).

Implement this new behavior to remove the custom binding code and use the fast path in namedItem and name
getter of HTMLOptionsCollection. (Obtaining all items for a given name is expensive!).

Tests: fast/dom/HTMLSelectElement/named-options.html

fast/dom/html-collections-named-getter.html

• bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore): Removed the custom bindings for name getter and namedItem.

• html/HTMLOptionsCollection.idl:

LayoutTests:

Changed the expectations of the tests.

• fast/dom/HTMLSelectElement/named-options-expected.txt:
• fast/dom/HTMLSelectElement/script-tests/named-options.js:
• fast/dom/html-collections-named-getter-expected.txt:
• fast/dom/html-collections-named-getter.html:

11:31 AM Changeset in webkit [149125] by Joseph Pecoraro

• 59 edits
  1 move
  3 adds
  1 delete in trunk

Web Inspector: ConsoleMessage should include line and column number where possible
​https://bugs.webkit.org/show_bug.cgi?id=114929

Source/WebCore:

• adds "m_column" to WebCore::ConsoleMessage
• adds "column" to Console.ConsoleMessage in the inspector protocol
• set the column number for console.* functions (Console.cpp)
• set the column number for XSLT errors (XSLTProcessor)
• plumb columnNumber everywhere else it is needed, set it to 0 and file bugs for all cases missing columnNumber that could provide it.

Reviewed by Timothy Hatcher.

Test: inspector/console/console-url-line-column.html

inspector/console/console-messages-stack-traces.html

• inspector/ConsoleMessage.h:
• inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::autogenerateMetadata):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::isEqual):
Add m_column and set it where appropriate.

• inspector/Inspector.json:

Add column property to Console.ConsoleMessage.

• page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
Set columnNumber like lineNumber from the last stack frame.
(WebCore::Console::groupEnd):
Line and column are unused in this message type, set both to 0.

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

• xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):
Add real column numbers, the XSLT handlers already had it available.

• bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

• css/CSSParser.cpp:

(WebCore::CSSParser::logError):

• dom/ScriptExecutionContext.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addConsoleMessage):

• dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):

• dom/Document.h:
• inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

• inspector/InspectorConsoleAgent.h:
• inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):

• inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):

• inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

• loader/EmptyClients.h:

(WebCore::EmptyChromeClient::addMessageToConsole):

• page/ChromeClient.h:

(WebCore::ChromeClient::addMessageToConsole):

• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::logToConsole):

• page/PageConsole.cpp:

(WebCore::PageConsole::addMessage):

• page/PageConsole.h:
• workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::postExceptionTask):
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):

• workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

• workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addConsoleMessage):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

• workers/WorkerContext.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::WorkerExceptionTask::performTask):
(WorkerExceptionTask):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):

• workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

• workers/WorkerReportingProxy.h:

(WorkerReportingProxy):
Plumb columnNumber through where appropriate. File bugs where missing.

Source/WebKit/blackberry:

Reviewed by Timothy Hatcher.

• Api/DumpRenderTreeClient.h:
• Api/WebPageClient.h:
• WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addMessageToConsole):

• WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/efl:

Reviewed by Timothy Hatcher.

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::addMessageToConsole):

• WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

Reviewed by Timothy Hatcher.

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::addMessageToConsole):

• WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

Reviewed by Timothy Hatcher.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::addMessageToConsole):

Source/WebKit/qt:

Reviewed by Timothy Hatcher.

• WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::addMessageToConsole):

• WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Reviewed by Timothy Hatcher.

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::addMessageToConsole):

• WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Reviewed by Timothy Hatcher.

• WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::addMessageToConsole):

• WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

Reviewed by Timothy Hatcher.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageToConsole):

• WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

Update a test that was outputting the url and line number of console
method calls, to output the column number as well. Added a test that
verifies that console API messages have stack traces if appropriate.

Reviewed by Timothy Hatcher.

• inspector/console/console-url-and-line-expected.txt: Removed.
• inspector/console/console-url-line-column-expected.txt: Added.
• inspector/console/console-url-line-column.html: Renamed from LayoutTests/inspector/console/console-url-and-line.html.
• inspector/console/console-messages-stack-traces-expected.txt: Added.
• inspector/console/console-messages-stack-traces.html: Added.

11:29 AM Changeset in webkit [149124] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Get rid of return in void method
​https://bugs.webkit.org/show_bug.cgi?id=115186

Patch by Konrad Piascik <​kpiascik@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setForcedTextEncoding):

11:19 AM Changeset in webkit [149123] by allan.jensen@digia.com

• 5 edits in trunk/Source

[Qt] Animated opacity does not trigger accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=115107

Reviewed by Simon Fraser.

Source/WebCore:

Add extra option to also trigger compositing on animated opacity.

• page/ChromeClient.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

Source/WebKit/qt:

We should trigger compositing on animated opacity as it is always faster on Qt.

• WebCoreSupport/ChromeClientQt.cpp:

VideoTrigger removed because we have already disabled AC for video in qwebsettings.

11:09 AM Changeset in webkit [149122] by Alexandru Chiculita

• 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed. Adding myself to the reviwers list.

10:59 AM Changeset in webkit [149121] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Thread safety issues in WKCustomProtocol.
<rdar://problem/13247304> and ​https://bugs.webkit.org/show_bug.cgi?id=115185

Reviewed by Alexey Proskuryakov.

• Shared/Network/CustomProtocols/CustomProtocolManager.h:

• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::addCustomProtocol): Protect m_customProtocolMap with its mutex.
(WebKit::CustomProtocolManager::removeCustomProtocol): Ditto.
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::protocolForID): Protect m_customProtocolMap with its mutex, and return

a RetainPtr instead of a raw pointer.

10:48 AM Changeset in webkit [149120] by commit-queue@webkit.org

• 4 edits
  3 adds in trunk

Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
​https://bugs.webkit.org/show_bug.cgi?id=115128

Patch by Lamarque V. Souza <​Lamarque.Souza@basyskom.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Source/WebCore:

According to WebSocket specification Sec-WebSocket-Extensions header field
must not appear more than once in an HTTP response. It is ok if it appears
more than once in client request. Also add a check for invalid UTF-8
characters when parsing Sec-WebSocket-Extensions quoted string.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html

• Modules/websockets/WebSocketExtensionParser.cpp:

(WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
invalid character in the quoted string being parsed.

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
appears more than once in header response. Abort handshake if it does.

LayoutTests:

• http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt: Added.
• http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html: Added.
• http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header_wsh.py: Added.

10:31 AM Changeset in webkit [149119] by jer.noble@apple.com

• 3 edits in trunk/Source/WebKit2

Further build fixes: correct two more misnames of WebProcessShim.dyld.

• WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):

• WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

10:12 AM Changeset in webkit [149118] by Martin Robinson

• 2 edits in trunk/Source/WebKit2

Make gobject-introspection warnings non-fatal
​https://bugs.webkit.org/show_bug.cgi?id=115184

Reviewed by Carlos Garcia Campos.

• GNUmakefile.am: Make it so that gobject-introspection errors do not fail the buld

until we get to a point where gobject-introspection gives consistent warnings.

9:46 AM Changeset in webkit [149117] by Carlos Garcia Campos

• 14 edits
  4 adds in trunk/Source/WebKit2

[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=111265

Reviewed by Anders Carlsson.

In the current API the settings are always shared by all web
views, because they are always created on the default page
group. This makes impossible to have different settings on
different web views. Expose the page group in the API,
so that users can create web views on a group different than the
default one to have their own settings.

• GNUmakefile.list.am: Add new files to compilation.
• UIProcess/API/gtk/WebKitSettings.cpp:

(webkitSettingsGetPreferences): Helper private method to get the
WebPreferences wrapped by a WebKitSettings object.

• UIProcess/API/gtk/WebKitSettingsPrivate.h:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate): Add a default WebKitWebViewGroup.
(webkitWebContextCreatePageForWebView): Create the WebPageProxy
with the WebPageGroup of the given WebKitWebViewGroup.
(webkitWebContextGetDefaultWebViewGroup): Helper private method to
get the default WebKitWebViewGroup.

• UIProcess/API/gtk/WebKitWebContextPrivate.h:
• UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate): Add a WebKitWebViewGroup in case the view
is created with a group.
(webkitWebViewUpdateSettings): Keep a reference of the group
settings to be able to disconnect the signals when the settings
object is replaced in the view group and connect to the signals
for the custom settings.
(webkitWebViewSettingsChanged): Disconnect the signals for the
previous settings and set the new settings.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Disconnect
notify::settings signal of WebKitWebViewGroup.
(webkitWebViewConstructed): Pass the current WebKitWebViewGroup to
webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty): Add setter for group property.
(webkitWebViewGetProperty): Add getter for group property.
(webkitWebViewDispose): Call
webkitWebViewDisconnectSettingsChangedSignalHandler().
(webkit_web_view_class_init): Add WebKitWebView:group property.
(webkitWebViewHandleAuthenticationChallenge): Use
webkit_web_view_get_settings().
(webkit_web_view_new_with_group): Create a new web view with the
given WebKitWebViewGroup.
(webkit_web_view_get_group): Return the current WebKitWebViewGroup
or the default one if the view was not created with
webkit_web_view_new_with_group().
(webkit_web_view_set_settings): Set the settings of the current
WebKitWebViewGroup.
(webkit_web_view_get_settings): Get the settings of the current
WebKitWebViewGroup.
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_settings().
(webkit_web_view_get_zoom_level): Ditto.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewGroup.cpp: Added.

(_WebKitWebViewGroupPrivate):
(webkitWebViewGroupSetProperty):
(webkitWebViewGroupGetProperty):
(webkitWebViewGroupConstructed):
(webkit_web_view_group_class_init):
(webkitWebViewGroupAttachSettingsToPageGroup): Set the
WebPreferences of the current WebKitSettings to the WebPageGroup.
(webkitWebViewGroupCreate): Create a new WebKitWebViewGroup for
the given WebPageGroup.
(webkitWebViewGroupGetPageGroup): Helper private method to get the
WebPageGroup wrapped by the WebKitWebViewGroup.
(webkit_web_view_group_new): Create a new WebKitWebViewGroup.
(webkit_web_view_group_get_name): Return the name of a
WebKitWebViewGroup.
(webkit_web_view_group_get_settings): Get the settings of a
WebKitWebViewGroup.
(webkit_web_view_group_set_settings): Set new settings of a
WebKitWebViewGroup.

• UIProcess/API/gtk/WebKitWebViewGroup.h: Added.

(_WebKitWebViewGroup):
(_WebKitWebViewGroupClass):

• UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Added.
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add

WebKitWebViewGroup section.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
• UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_web_view_group_get_type.

• UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to

compilation.

• UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSettings): We can't watch settings in the default view
group anymore, because they are not released with the web view but
with the web context that is freed after the Test destructor.

• UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added.

(testWebViewGroupDefault):
(testWebViewGroupNewGroup):
(testWebViewNewWithGroup):
(testWebViewGroupSettings):
(beforeAll):
(afterAll):

• UIProcess/API/gtk/webkit2.h: Include WebKitWebViewGroup.h.

9:39 AM Changeset in webkit [149116] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[Windows] Compile fix.
​https://bugs.webkit.org/show_bug.cgi?id=115170

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-04-25
Reviewed by Filip Pizlo.

Forward declare function, instead of including intrin.h.

• wtf/Atomics.h:

9:32 AM Changeset in webkit [149115] by rakuco@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
​https://bugs.webkit.org/show_bug.cgi?id=115182

Reviewed by Dan Bernstein.

The call added in r148758 was apparently a leftover from some debugging
session, and it makes the Interactive/window-resize.html performance
test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::notifyFinished):

9:18 AM Changeset in webkit [149114] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r137994): Random crashes occur with SH4 JSC.
​https://bugs.webkit.org/show_bug.cgi?id=115167.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-25
Reviewed by Oliver Hunt.

Since r137994, uncommited pages could be inside the area of memory in
parameter of the cacheFlush function. That's why we have to flush each
page separately to avoid a fail of the whole flush, if an uncommited page
is in the area.

This patch is very similar to changeset 145194 made for ARMv7 architecture,
see ​https://bugs.webkit.org/show_bug.cgi?id=111441 for further information.

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::cacheFlush):

8:55 AM Changeset in webkit [149113] by Christophe Dumez

• 32 edits in trunk/Source/WebCore

Add support for Web IDL callback interfaces to the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115179

Reviewed by Kentaro Hara.

Add support in the bindings generator for Web IDL callback interfaces:
​http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface

Drop support for the WebKit-specific [Callback] extended attributes
on Web IDL interfaces and update existing IDL files to use proper
callback interfaces instead.

No new tests, no behavior change.

• Modules/filesystem/EntriesCallback.idl:
• Modules/filesystem/EntryCallback.idl:
• Modules/filesystem/ErrorCallback.idl:
• Modules/filesystem/FileCallback.idl:
• Modules/filesystem/FileSystemCallback.idl:
• Modules/filesystem/FileWriterCallback.idl:
• Modules/filesystem/MetadataCallback.idl:
• Modules/geolocation/PositionCallback.idl:
• Modules/geolocation/PositionErrorCallback.idl:
• Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
• Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
• Modules/mediastream/RTCErrorCallback.idl:
• Modules/mediastream/RTCSessionDescriptionCallback.idl:
• Modules/mediastream/RTCStatsCallback.idl:
• Modules/notifications/NotificationPermissionCallback.idl:
• Modules/quota/StorageErrorCallback.idl:
• Modules/quota/StorageQuotaCallback.idl:
• Modules/quota/StorageUsageCallback.idl:
• Modules/webaudio/AudioBufferCallback.idl:
• Modules/webdatabase/DatabaseCallback.idl:
• Modules/webdatabase/SQLStatementCallback.idl:
• Modules/webdatabase/SQLStatementErrorCallback.idl:
• Modules/webdatabase/SQLTransactionCallback.idl:
• Modules/webdatabase/SQLTransactionErrorCallback.idl:
• Modules/webdatabase/SQLTransactionSyncCallback.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):

• bindings/scripts/IDLParser.pm:

(parseCallbackRestOrInterface):

• bindings/scripts/test/TestCallback.idl:
• dom/RequestAnimationFrameCallback.idl:
• dom/StringCallback.idl:
• html/VoidCallback.idl:

8:17 AM Changeset in webkit [149112] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Use std::move in AtomicString
​https://bugs.webkit.org/show_bug.cgi?id=115102

Reviewed by Anders Carlsson.

Use std::move in AtomicString instead of direct casting to rvalue references.

• wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):

7:52 AM Changeset in webkit [149111] by commit-queue@webkit.org

• 8 edits
  1 copy in trunk

[GStreamer] Add audio/speex MIME type as supported
​https://bugs.webkit.org/show_bug.cgi?id=115032

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-04-25
Reviewed by Philippe Normand.

Source/WebCore:

GStreamer has support for the Speex codec (​http://www.speex.org).
Speex streams may be embedded in a Ogg container, or standalone.
The case of the Ogg container is already covered by the "*/ogg"
MIME types declared as supported by the GStreamer media playing
code, but for standalone streams to work, "audio/speex" has to
be added.

With this, and the needed GStreamer plugin installed, the GTK+
launcher is able to correctly play Speex streams served with
"Content-type: audio/speex".

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

Speex (​http://www.speex.org) streams can be embedded into Ogg
Ogg containers, so add a check for it in the test case.

• media/media-can-play-ogg-expected.txt:
• media/media-can-play-ogg.html:
• platform/blackberry/media/media-can-play-ogg-expected.txt:
• platform/mac/media/media-can-play-ogg-expected.txt:
• platform/qt-linux/media/media-can-play-ogg-expected.txt:
• platform/win/media/media-can-play-ogg-expected.txt:

7:33 AM Changeset in webkit [149110] by akling@apple.com

• 9 edits in trunk/Source/WebCore

Add FINAL decorators to the InlineBox class hierarchy.
<​http://webkit.org/b/115177>

Reviewed by Antti Koivisto.

From Blink r148628 by <​cevans@chromium.org>:

FINAL is a macro in wtf/Compiler.h that does the correct thing if the compiler does not support "final")
The approach used is as simple as possible whilst being thorough.
So, leaf classes have FINAL applied to the whole class whereas intermediary classes have FINAL applied to relevant methods.

FINAL allows a compiler to devirtualize call sites and turn them into direct calls. As you might expect, this is perf positive:
(clang on Linux):

• line_layout.html goes from 120 runs/s -> 123 runs/2, +2.5%
• html5-full-render.html goes from 3176ms -> 3162ms, +0.4%

I have confidence that the former result is statistically significant (as the numbers are very very stable) but not the latter.

• rendering/EllipsisBox.h:
• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.h:
• rendering/RootInlineBox.h:
• rendering/TrailingFloatsRootInlineBox.h:
• rendering/svg/SVGInlineFlowBox.h:
• rendering/svg/SVGInlineTextBox.h:
• rendering/svg/SVGRootInlineBox.h:

7:19 AM Changeset in webkit [149109] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Tools/gtk/install-dependencies added ragel dependency
​https://bugs.webkit.org/show_bug.cgi?id=115163

Patch by Xavier Castano <​xcastanho@igalia.com> on 2013-04-25
Reviewed by Xan Lopez.

The install-dependencies script was missing a dependency on ragel
which is expected when building HarfBuzz.

• gtk/install-dependencies: Added a dependency on ragel for both

apt and yum.

7:05 AM Changeset in webkit [149108] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Remove pango from optional jhbuild dependencies
​https://bugs.webkit.org/show_bug.cgi?id=115162

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-04-25
Reviewed by Martin Robinson.

Pango is not needed since revision r148293 that lowers the pango
dependency to 1.30, which is available in most distributions.

• gtk/jhbuild-optional.modules: Removes description of pango module.

6:46 AM Changeset in webkit [149107] by jer.noble@apple.com

• 5 edits in trunk/Source/WebKit2

Unreviewed build fix: Fix the name of DyldInterpose.h in
SecItemShimLibrary.mm, fix the name of WebProcessShim.dyld in
WebContentServiceEntryPoint.mm, and stop linking against libWTF.a
directly (which means removing ASSERTs from
CookieStorageShimLibrary.cpp).

• Shared/mac/CookieStorageShimLibrary.cpp:

(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL):
(WebKit::WebKitCookieStorageShimInitialize):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

• WebProcess/mac/SecItemShimLibrary.mm:

6:43 AM Changeset in webkit [149106] by akling@apple.com

• 4 edits
  4 adds in trunk

CSS parser: Add error recovery while parsing @-webkit-keyframes key values.
<​http://webkit.org/b/115175>

Source/WebCore:

From Blink r148714 by <​apavlov@chromium.org>:

If not a percentage, "from", or "to" value is used in a key list, the rule is erroneous,
and due to the absense of recovery, the parser skips the following, valid CSS rule.

On a related note, keyframes, whose selectors contain invalid keys, should be discarded
altogether, according to <​http://www.w3.org/TR/css3-animations/#keyframes>

Tests: animations/keyframes-invalid-keys.html

fast/css/webkit-keyframes-errors.html

• css/CSSGrammar.y.in:
• css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiers):

LayoutTests:

From Blink r148714 by <​apavlov@chromium.org>.

• animations/keyframes-invalid-keys-expected.txt: Added.
• animations/keyframes-invalid-keys.html: Added.
• fast/css/webkit-keyframes-errors-expected.html: Added.
• fast/css/webkit-keyframes-errors.html: Added.

6:23 AM Changeset in webkit [149105] by Antti Koivisto

• 7 edits in trunk/Source/WebCore

REGRESSION (r147797): Animations slideshows of images on www.thesuperficial.com are slow
​https://bugs.webkit.org/show_bug.cgi?id=115172

Reviewed by Andreas Kling.

On this page ads dynamically loaded to subframes on slideshow navigation switch us to state where we throttle layer flushes.

Fix by ignoring any subframe-originated loads when determining throttling.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

• loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::isMainLoadProgressing):

Rename, ignore subframe originated loads. Subframe loads that are initiated during the main load still count.

• loader/ProgressTracker.h:

(ProgressTracker):

• page/FrameView.cpp:

(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):

• page/FrameView.h:

(FrameView):

• rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

6:10 AM Changeset in webkit [149104] by kadam@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests after r148996.

• platform/qt/TestExpectations:

6:04 AM Changeset in webkit [149103] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove Chromium-specific cases from FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=115169

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Andreas Kling.

• Scripts/webkitperl/FeatureList.pm:

5:56 AM Changeset in webkit [149102] by akling@apple.com

• 4 edits
  2 adds in trunk

SVG: Fix viewBox animations on shapes with non-scaling-stroke.
<​http://webkit.org/b/115173>

Source/WebCore:

From Blink r149058 by <​pdr@chromium.org>:

Previously hasAttribute() to determine if a viewBox was set in the transform
code for non-scaling-strokes. hasAttribute() should not be used in this case,
as it will return false if the attribute is not set but the value is animating.

This patch switches to checking if the viewBox is empty instead of checking for
the presence of the attribute.

Test: svg/stroke/animated-non-scaling-stroke.html

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

• svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::hasEmptyViewBox):

LayoutTests:

From Blink r149058 by <​pdr@chromium.org>.

• svg/stroke/animated-non-scaling-stroke-expected.html: Added.
• svg/stroke/animated-non-scaling-stroke.html: Added.

5:32 AM Changeset in webkit [149101] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove isPluginElement hack in Document::setFocusedNode()
<​http://webkit.org/b/115171>

From Blink r148800 by <​tkent@chromium.org>:

This hack is no longer necessary because r147591 made isFocusable for plugin
elements work correctly.

• dom/Document.cpp:

(WebCore::Document::setFocusedNode):

5:13 AM Changeset in webkit [149100] by kadam@inf.u-szeged.hu

• 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing tests.

• platform/qt-5.0-wk1/TestExpectations:
• platform/qt-5.0-wk2/TestExpectations:
• platform/qt/TestExpectations:

3:49 AM Changeset in webkit [149099] by kadam@inf.u-szeged.hu

• 23 edits
  22 copies
  8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Organize expected files after r149095.

• platform/qt-5.0-wk1/editing/deleting/delete-by-word-002-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-by-word-002-expected.txt.
• platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-cell-contents-expected.txt.
• platform/qt-5.0-wk1/editing/execCommand/button-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/button-expected.txt.
• platform/qt-5.0-wk1/editing/execCommand/createLink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/createLink-expected.txt.
• platform/qt-5.0-wk1/editing/execCommand/indent-pre-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/indent-pre-expected.txt.
• platform/qt-5.0-wk1/editing/execCommand/unlink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/unlink-expected.txt.
• platform/qt-5.0-wk1/editing/input/emacs-ctrl-o-expected.txt: Copied from LayoutTests/platform/qt/editing/input/emacs-ctrl-o-expected.txt.
• platform/qt-5.0-wk1/editing/inserting/insert-before-link-1-expected.txt: Copied from LayoutTests/platform/qt/editing/inserting/insert-before-link-1-expected.txt.
• platform/qt-5.0-wk1/editing/pasteboard/display-block-on-spans-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/display-block-on-spans-expected.txt.
• platform/qt-5.0-wk1/editing/pasteboard/emacs-cntl-y-001-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt.
• platform/qt-5.0-wk1/editing/pasteboard/merge-end-list-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-list-2-expected.txt.
• platform/qt-5.0-wk1/editing/pasteboard/merge-end-table-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-table-2-expected.txt.
• platform/qt-5.0-wk1/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/page-zoom-expected.txt.
• platform/qt-5.0-wk1/editing/selection/extend-selection-word-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/extend-selection-word-expected.txt.
• platform/qt-5.0-wk1/editing/style/apply-through-end-of-document-expected.txt: Copied from LayoutTests/platform/qt/editing/style/apply-through-end-of-document-expected.txt.
• platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-expected.txt.
• platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt.
• platform/qt-5.0-wk1/editing/style/remove-underline-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-expected.txt.
• platform/qt-5.0-wk1/editing/style/remove-underline-from-stylesheet-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt.
• platform/qt-5.0-wk1/editing/style/remove-underline-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-in-bold-expected.txt.
• platform/qt-5.0-wk1/editing/style/unbold-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/unbold-in-bold-expected.txt.
• platform/qt-5.0-wk1/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Copied from LayoutTests/platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt.
• platform/qt/editing/deleting/delete-by-word-002-expected.txt:
• platform/qt/editing/deleting/delete-cell-contents-expected.txt:
• platform/qt/editing/execCommand/button-expected.txt:
• platform/qt/editing/execCommand/createLink-expected.txt:
• platform/qt/editing/execCommand/indent-pre-expected.txt:
• platform/qt/editing/execCommand/unlink-expected.txt:
• platform/qt/editing/input/emacs-ctrl-o-expected.txt:
• platform/qt/editing/inserting/insert-before-link-1-expected.txt:
• platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
• platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
• platform/qt/editing/pasteboard/merge-end-list-2-expected.txt:
• platform/qt/editing/pasteboard/merge-end-table-2-expected.txt:
• platform/qt/editing/pasteboard/page-zoom-expected.txt:
• platform/qt/editing/selection/extend-selection-word-expected.txt:
• platform/qt/editing/style/apply-through-end-of-document-expected.txt:
• platform/qt/editing/style/remove-underline-across-paragraph-expected.txt:
• platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
• platform/qt/editing/style/remove-underline-expected.txt:
• platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
• platform/qt/editing/style/remove-underline-in-bold-expected.txt:
• platform/qt/editing/style/unbold-in-bold-expected.txt:
• platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:

2:51 AM Changeset in webkit [149098] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

EventSource: Synchronous loader callback not handled properly
​https://bugs.webkit.org/show_bug.cgi?id=115104

Source/WebCore:

When attempting a cross-origin request towards a non-HTTP URL, an early verification
of the protocol scheme will cause didFailAccessControlCheck to be called synchronously
before the loader has even finished being created. This special case was not handled
properly, since we tried to cancel a non-existing loader, which resulted in a crash.
In addition to checking whether a request is in flight before trying to cancel it,
this change also schedules the initial creation of the loader to happen asynchronously
when an EventSource is constructed, so that a script can register for the error event
before it is dispatched (as a result of passing a non-HTTP URL to the constructor).

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-cors-non-http.html

• page/EventSource.cpp:

(WebCore::EventSource::EventSource):
(WebCore::EventSource::create):
(WebCore::EventSource::scheduleInitialConnect):
(WebCore):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::connectTimerFired):
(WebCore::EventSource::close):
(WebCore::EventSource::abortConnectionAttempt):

• page/EventSource.h:

(EventSource):

LayoutTests:

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

• http/tests/eventsource/eventsource-cors-non-http-expected.txt: Added.
• http/tests/eventsource/eventsource-cors-non-http.html: Added.

2:43 AM Changeset in webkit [149097] by Patrick Gansterer

• 2 edits in trunk/Source/WTF

Unreviewed WinCE build fix after r148888.

• wtf/Atomics.h: WinCE version of intrin.h is called cmnintrin.h.

2:42 AM Changeset in webkit [149096] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Unreviewed WinCE build fix after r148545.

• page/wince/FrameWinCE.cpp:

1:01 AM Changeset in webkit [149095] by kadam@inf.u-szeged.hu

• 7 edits
  21 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after r148987.

• platform/qt/editing/deleting/delete-by-word-002-expected.txt: Added.
• platform/qt/editing/deleting/delete-cell-contents-expected.txt: Added.
• platform/qt/editing/execCommand/button-expected.txt: Added.
• platform/qt/editing/execCommand/createLink-expected.txt: Added.
• platform/qt/editing/execCommand/indent-pre-expected.txt: Added.
• platform/qt/editing/execCommand/unlink-expected.txt: Added.
• platform/qt/editing/input/emacs-ctrl-o-expected.png:
• platform/qt/editing/input/emacs-ctrl-o-expected.txt:
• platform/qt/editing/inserting/insert-before-link-1-expected.txt: Added.
• platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Added.
• platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png:
• platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
• platform/qt/editing/pasteboard/merge-end-list-2-expected.txt: Added.
• platform/qt/editing/pasteboard/merge-end-table-2-expected.txt: Added.
• platform/qt/editing/pasteboard/page-zoom-expected.txt: Added.
• platform/qt/editing/selection/extend-selection-word-expected.txt: Added.
• platform/qt/editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt: Added.
• platform/qt/editing/style/apply-through-end-of-document-expected.txt: Added.
• platform/qt/editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
• platform/qt/editing/style/remove-underline-across-paragraph-expected.txt: Added.
• platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
• platform/qt/editing/style/remove-underline-expected.txt: Added.
• platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
• platform/qt/editing/style/remove-underline-in-bold-expected.txt: Added.
• platform/qt/editing/style/unbold-in-bold-expected.png:
• platform/qt/editing/style/unbold-in-bold-expected.txt:
• platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Added.

12:50 AM Changeset in webkit [149094] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r149032.
​http://trac.webkit.org/changeset/149032
​https://bugs.webkit.org/show_bug.cgi?id=115151

EFL WK1 API test has been broken after r149032 (Requested by
gyuyoung on #webkit).

• tests/test_ewk_setting.cpp:

(TEST_F):

Apr 24, 2013:

11:42 PM Changeset in webkit [149093] by tkent@chromium.org

• 5 edits in trunk

Back references don't work in pattern attribute
​https://bugs.webkit.org/show_bug.cgi?id=105875

Reviewed by Geoffrey Garen.

Source/WebCore:

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):
Don't use capturing parentheses. They affected back references in
pattern attribute values.

LayoutTests:

• fast/forms/ValidityState-patternMismatch-expected.txt:
• fast/forms/ValidityState-patternMismatch.html:

10:41 PM Changeset in webkit [149092] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove checking chromium from run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=115139

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.

• Scripts/run-webkit-tests:

(useNewRunWebKitTests):

10:30 PM Changeset in webkit [149091] by timothy_horton@apple.com

• 5 edits in trunk/Source

PDFPlugin: Cursor should become an i-beam when over selectable text
​https://bugs.webkit.org/show_bug.cgi?id=115018
<rdar://problem/12645012>

Reviewed by Alexey Proskuryakov.

• WebProcess/Plugins/PDF/PDFPlugin.h:

Add updateCursor(), the UpdateCursorMode and HitTestResult enums, and
storage for the last PDF hit test result.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updateCursor):
Hit test the PDF. If there is a word under the cursor, use the I-beam cursor,
otherwise, use the default pointer cursor. This approximates PDFKit's behavior,
though does not match it precisely in the case of annotations.
Only send the cursor update to the UIProcess if it is a change, or if
we're explicitly asked to update.
(WebKit::PDFPlugin::handleMouseEvent):
If we're processing a mouse moved event, update the cursor if needed.
(WebKit::PDFPlugin::handleMouseEnterEvent):
If the cursor just moved over the PDFPlugin, force-update the cursor,
even if it matches the previously-set cursor (because something else
likely updated the cursor while it was not over the PDFPlugin).

• WebCore.exp.in: Export the I-beam and arrow cursors.

9:56 PM Changeset in webkit [149090] by roger_fong@apple.com

• 1 edit
  559 adds
  297 deletes in trunk/LayoutTests

Roll out AppleWin re-baselines from r149088.

7:59 PM Changeset in webkit [149089] by mark.lam@apple.com

• 11 edits in trunk/Source/JavaScriptCore

Add watchdog timer polling for the DFG.
​https://bugs.webkit.org/show_bug.cgi?id=115134.

Reviewed by Geoffrey Garen.

The strategy is to add a speculation check to the DFG generated code to
test if the watchdog timer has fired or not. If the watchdog timer has
fired, the generated code will do an OSR exit to the baseline JIT, and
let it handle servicing the watchdog timer.

If the watchdog is not enabled, this speculation check will not be
emitted.

• API/tests/testapi.c:

(currentCPUTime_callAsFunction):
(extendTerminateCallback):
(main):

• removed try/catch statements so that we can test the watchdog on the DFG.
• added JS bindings to a native currentCPUTime() function so that the timeout tests can be more accurate.
• also shortened the time values so that the tests can complete sooner.

• bytecode/ExitKind.h:
• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• runtime/Watchdog.cpp:

(JSC::Watchdog::setTimeLimit):

7:44 PM Changeset in webkit [149088] by roger_fong@apple.com

• 103 edits
  2046 adds
  1760 deletes in trunk/LayoutTests

Unreviewed optimize-baselines for mac and win.

7:09 PM Changeset in webkit [149087] by Simon Fraser

• 17 edits in trunk/Tools

Pixel tests in SVG are all broken in WK2
​https://bugs.webkit.org/show_bug.cgi?id=114218

Reviewed by Darin Adler.

Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.

Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.

Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.

• DumpRenderTree/TestRunner.cpp:

(TestRunner::setShouldPaintBrokenImage):

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/efl/DumpRenderTree.cpp:
• DumpRenderTree/gtk/DumpRenderTree.cpp:

(webInspectorShowWindow):

• DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):

• DumpRenderTree/mac/DumpRenderTreeMac.h:
• DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):

• DumpRenderTree/qt/TestRunnerQt.cpp:
• DumpRenderTree/qt/TestRunnerQt.h:
• DumpRenderTree/win/DumpRenderTree.cpp:

(sizeWebViewForCurrentTest):

• DumpRenderTree/wx/DumpRenderTreeWx.cpp:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::sizeWebViewForCurrentTest):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):

6:32 PM Changeset in webkit [149086] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Page Overlays shouldn't waste time flushing layers if we're not going to use it
​https://bugs.webkit.org/show_bug.cgi?id=115145

Reviewed by Simon Fraser.

Don't flush the page overlay layer when it's installed - it starts out
with paintContents=false, so we don't really need a CALayer yet. We'll
flush later if need be.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):

6:32 PM Changeset in webkit [149085] by fpizlo@apple.com

• 5 edits
  1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: AbstractValue methods that deal with watchpoints should have access to Graph, so that in debug mode, Graph can track the history of watchpoint states and detect races
​https://bugs.webkit.org/show_bug.cgi?id=115084

Reviewed by Geoffrey Garen.

The idea is that as part of ​https://bugs.webkit.org/show_bug.cgi?id=115083, I'll have
Graph record the initial state of a watchpoint at the time that we decide to take
advantage of it; then I will use this to disable any watchpoint-related assertions
in debug mode. Note that this "watchpoint cache" will only be maintained in debug
mode, so there will be no release performance implications. But to do this, I need to
ensure that all of the places that reason about watchpoints have access to Graph.
For example, I'll want AbstractValue::setFuturePossibleStructure to record the state
of the watchpoint in Graph so that subsequent assertions can check if the watchpoint's
state had changed since that decision was made.

• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):

• dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::trySetConstant):

• dfg/DFGAbstractValue.cpp: Added.

(DFG):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::dump):

• dfg/DFGAbstractValue.h:

(DFG):
(AbstractValue):
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::filterByValue):

6:27 PM Changeset in webkit [149084] by Simon Fraser

• 3 edits
  2 adds in trunk

Garbage at the top of ​http://www.technologyreview.com after scrolling
​https://bugs.webkit.org/show_bug.cgi?id=114825

Source/WebCore:

Reviewed by Tim Horton.

Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
but then not painting anything into it. On this page, the element is
toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
failed to consider that as something that can cause backgrounds not to be opaque.

For the bug to happen, some subtle interactions with r142012 come into play
for the layer to remain visible, hence the slightly complex testcase.

Test: compositing/contents-opaque/visibility-hidden.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

Test that sets visibility:hidden on an element with some complex
configuration of layer children, and dumps the layer tree to check
that the contents are not marked as opaque.

• compositing/contents-opaque/visibility-hidden-expected.txt: Added.
• compositing/contents-opaque/visibility-hidden.html: Added.

6:27 PM Changeset in webkit [149083] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Dump layer opaqueness in the Compositing log output
​https://bugs.webkit.org/show_bug.cgi?id=115132

Reviewed by Tim Horton.

It's useful to see whether we consider layers to be opaque in the Compositing
log channel output, so dump it.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

6:26 PM Changeset in webkit [149082] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Special thunks for math functions should work on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=115144

Reviewed by Gavin Barraclough and Oliver Hunt.

The only hard bit here was ensuring that we implemented the very special
"cheap C call" convention on ARMv7.

• assembler/AbstractMacroAssembler.h:

(JSC::isARMv7s):
(JSC):
(JSC::isX86):

• dfg/DFGCommon.h:
• jit/SpecializedThunkJIT.h:

(SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):

• jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):

5:51 PM Changeset in webkit [149081] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add efl to JSInspectorFrontendHost::port()
​https://bugs.webkit.org/show_bug.cgi?id=115137

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Timothy Hatcher.

No new tests, because there is no change in behavior.

• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::port):

5:44 PM Changeset in webkit [149080] by kangil.han@samsung.com

• 3 edits in trunk/Source/WebCore

Function parameter quotePair can be passed by reference
​https://bugs.webkit.org/show_bug.cgi?id=115089

Reviewed by Alexey Proskuryakov.

Minor performance patch.

• rendering/style/QuotesData.cpp:

(WebCore::QuotesData::addPair):

• rendering/style/QuotesData.h:

(QuotesData):

5:17 PM Changeset in webkit [149079] by beidson@apple.com

• 10 edits in trunk/Source/WebCore

Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
​https://bugs.webkit.org/show_bug.cgi?id=115140

Reviewed by Beth Dakin.

No new tests (No behavior change).

This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
in all CachedResource subclasses besides CachedFont (which already has an implementation).

• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedImage.h:
• loader/cache/CachedRawResource.h:
• loader/cache/CachedResource.h:
• loader/cache/CachedSVGDocument.h:
• loader/cache/CachedScript.h:
• loader/cache/CachedShader.h:
• loader/cache/CachedTextTrack.h:
• loader/cache/CachedXSLStyleSheet.h:

5:10 PM Changeset in webkit [149078] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Misc bugfix and cleaning in sh4 base JIT.
​https://bugs.webkit.org/show_bug.cgi?id=115022.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-24
Reviewed by Oliver Hunt.

Remove unused add32() and sub32() with scratchreg parameter to avoid
confusion as this function prototype means another behaviour.
Remove unused "void push(Address)" function which seems quite buggy.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::and32): Cosmetic change.
(JSC::MacroAssemblerSH4::lshift32): Cosmetic change.
(JSC::MacroAssemblerSH4::or32): Cosmetic change.
(JSC::MacroAssemblerSH4::xor32): Cosmetic change.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load32): Cosmetic change.
(JSC::MacroAssemblerSH4::load8Signed): Fix invalid offset upper limit
when using r0 register and cosmetic changes.
(JSC::MacroAssemblerSH4::load8): Reuse load8Signed to avoid duplication.
(JSC::MacroAssemblerSH4::load16): Fix invalid offset upper limit when
using r0 register, fix missing offset shift and cosmetic changes.
(JSC::MacroAssemblerSH4::store32): Cosmetic change.
(JSC::MacroAssemblerSH4::branchAdd32): Store result value before branch.

4:46 PM Changeset in webkit [149077] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Further unreviewed build fix; CFNetwork.framework is the one which Lion
refuses to link against.

• WebKit2.xcodeproj/project.pbxproj:

4:32 PM Changeset in webkit [149076] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix; link against CoreServices.framework instead of against
CoreFoundation.framework directly, to make the linker happy on Lion.

• WebKit2.xcodeproj/project.pbxproj:

4:31 PM Changeset in webkit [149075] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

Fix invalid test names in jsc-test-list
<​http://webkit.org/b/115136>

Reviewed by Geoffrey Garen.

This shell script finds all the invalid tests listed in
LayoutTests/fast/js/jsc-test-list:

$ for F in cat LayoutTests/fast/js/jsc-test-list; do if [ ! -f LayoutTests/$F.html ]; then echo $F; fi; done
fast/js/dfg-double-addition-simplify-to-int.html
fast/js/dfg-mul-big-integers-with-small-integer-and-bitor
fast/js/dfg-mul-big-integers-with-small-integer-and-detect-overflow
fast/js/dfg-mul-big-integers-with-small-integer
fast/js/dfg-value-to-int32-with-side-effects

• fast/js/jsc-test-list: Fix invalid test names by removing

*.html suffix or stray "s" characters.

4:20 PM Changeset in webkit [149074] by jer.noble@apple.com

• 9 edits
  3 copies
  2 adds in trunk/Source/WebKit2

WWDC session videos don’t play at developer.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=114858

Reviewed by Eric Carlson. Rubber stamped by Brady Eidson.

AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.

Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:

• Shared/mac/CookieStorageShimLibrary.h: Added

(CookieStorageShimCallbacks):

• Shared/mac/CookieStorageShimLibrary.cpp: Added.

(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose

the CFNetwork call, and pass to the registered callback.

(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.

Add a helper singleton class which will talk to the shim through the
registered callbacks:

• Shared/mac/CookieStorageShim.h: Added

(WebKit::CookieStorageShim::CookieStorageShim):

• Shared/mac/CookieStorageShim.cpp: Added.

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request

over to the NetworkProcess.

(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.

Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Rename the WebProcess's shim from SecItemShim -> WebProcessShim:

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):

• WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):

• WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
• WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:

• Shared/mac/DyldInterpose.h: Added.
• PluginProcess/mac/PluginProcessShim.mm:
• WebProcess/mac/SecItemShimLibrary.mm:

Add new files to the project:

• WebKit2.xcodeproj/project.pbxproj:

3:50 PM Changeset in webkit [149073] by bw80.lee@samsung.com

• 4 edits in trunk

[EFL] Fix build error after r148963.
​https://bugs.webkit.org/show_bug.cgi?id=115126

Reviewed by Laszlo Gombos.

Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h

Source/WebKit2:

• PlatformEfl.cmake:

Tools:

• TestWebKitAPI/PlatformEfl.cmake:

3:42 PM Changeset in webkit [149072] by Patrick Gansterer

• 13 edits in trunk/Source/JavaScriptCore

[WIN] Remove pthread from Visual Studio files in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=114864

Reviewed by Brent Fulgham.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops:
• JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
• JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops:
• JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
• JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
• JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
• JavaScriptCore.vcxproj/jsc/jscCommon.props:
• JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
• JavaScriptCore.vcxproj/testapi/testapiCommon.props:
• JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props:

3:39 PM Changeset in webkit [149071] by fpizlo@apple.com

• 4 edits
  3 adds in trunk

DFG should keep the operand to create_this alive if it's emitting code for create_this
​https://bugs.webkit.org/show_bug.cgi?id=115133

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The DFG must model bytecode liveness, or else OSR exit is going to have a really bad time.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test crashes prior to my change.

• fast/js/dfg-allocation-profile-watch-point-exit-expected.txt: Added.
• fast/js/dfg-allocation-profile-watch-point-exit.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js: Added.

(Foo):
(foo):

3:35 PM Changeset in webkit [149070] by beidson@apple.com

• 5 edits in trunk/Source/WebCore

Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
<rdar://problem/13622998> and ​https://bugs.webkit.org/show_bug.cgi?id=115131

Reviewed by Alexey Proskuryakov.

No new tests (Not a tested config, nor are disk cache issues currently testable).

• loader/cache/CachedResource.h:

(WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.

• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.

• loader/cache/CachedFont.h:

3:22 PM Changeset in webkit [149069] by jpfau@apple.com

• 2 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/12952167> 11G56: “AVF Info: …” logged to stdout

• platform/mac-lion/Skipped: Skipped all tests that were failing due to AVF info being printed.

3:05 PM Changeset in webkit [149068] by ap@apple.com

• 5 edits in trunk/LayoutTests

fast/js/global-constructors.html was deleted in r149001, removing it from
TextExpectations too.

• platform/mac/TestExpectations:
• platform/qt-arm/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:

2:43 PM Changeset in webkit [149067] by roger_fong@apple.com

• 13 edits in trunk

Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
• JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd:
• JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd:
• JavaScriptCore.vcxproj/jsc/jscPreLink.cmd:
• JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
• JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd:
• JavaScriptCore.vcxproj/testRegExp/testRegExpPreLink.cmd:
• JavaScriptCore.vcxproj/testapi/testapiPreLink.cmd:
• WTF.vcxproj/build-generated-files.sh:
• win/tools/vsprops/common.props:

2:37 PM Changeset in webkit [149066] by Beth Dakin

• 12 edits in trunk/Source/WebCore

Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
a circle
​https://bugs.webkit.org/show_bug.cgi?id=115124
-and corresponding-
<rdar://problem/13168957>

Reviewed by Anders Carlsson.

With ​http://trac.webkit.org/changeset/119834 we started calling
ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection
API on a zero-delay timer instead of calling it right away. This prevented some
crashes that we saw whenever this was called during a layout. However, that delay,
combined with the particulars of contentAreaScrolledInDirection cause this bug
where sometimes the scrollbars in an iframe will fade out very noticeably when
scrolling in a circle.

This change makes it so we will only use the zero-delay timer if the
ScrollableArea is not currently handling a wheel event. If it IS handling a wheel
event, then we will send the notifications to AppKit right away. I confirmed that
this change did not reintroduce the old crashes.

Keep track of whether we are currently handling a wheel event with the new member
variable m_isHandlingWheelEvent.

• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):

• page/EventHandler.h:

(WebCore::EventHandler::isHandlingWheelEvent):
(EventHandler):

To prevent layering violations, the ScrollableArea sub-classes will have to access
this information from the EventHandler.

• page/FrameView.cpp:

(WebCore::FrameView::isHandlingWheelEvent):

• page/FrameView.h:
• platform/ScrollableArea.h:

(WebCore::ScrollableArea::isHandlingWheelEvent):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isHandlingWheelEvent):

• rendering/RenderLayer.h:

(RenderLayer):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isHandlingWheelEvent):

• rendering/RenderListBox.h:

sendContentAreaScrolledSoon() can be private. Also add new function
sendContentAreaScrolled().

• platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

If the ScrollableArea is handling a wheel event, call
sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()

• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):

Re-factored to use sendContentAreaScrolled()
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

2:35 PM Changeset in webkit [149065] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Fix a merge error in r149007 (was missing a null check added in r148777).

• rendering/LogicalSelectionOffsetCaches.h:

(WebCore::containingBlockForAbsolutePosition):

2:33 PM Changeset in webkit [149064] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Crash when trying to determine the length of an invalid message
​https://bugs.webkit.org/show_bug.cgi?id=115127
<rdar://problem/13700736>

Reviewed by Beth Dakin.

Use message instead of incomingMessage since incomingMessage will always be null.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

1:38 PM Changeset in webkit [149063] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Battery API won't return updated battery status until client calls didChangeBatteryStatus
​https://bugs.webkit.org/show_bug.cgi?id=114891

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-04-24
Reviewed by Rob Buis.

The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
or other get functions will always return the default values until the next battery status
change object gets passed to the controller.

We need to update the manager when we attach it to the controller, and update all
existing managers when the controller receives it's first battery status object.

• Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::addListener):
(WebCore::BatteryController::updateBatteryStatus):

• Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
(WebCore):

• Modules/battery/BatteryManager.h:

(BatteryManager):

1:11 PM Changeset in webkit [149062] by zhajiang@rim.com

• 2 edits in trunk/Source/WebCore

Clean up unused code in ViewportArguments.h
​https://bugs.webkit.org/show_bug.cgi?id=115121

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-04-24.
Reviewed by Benjamin Poulain.

The target-densityDPI emulation implementation has been removed by
r147893, so clean up the remaining code as well.

• dom/ViewportArguments.h:

1:03 PM Changeset in webkit [149061] by akling@apple.com

• 5 edits in trunk/Source/WebCore

ElementData should use 'unsigned' attribute indices.
<​http://webkit.org/b/115103>

Reviewed by Antti Koivisto.

Switch to using 'unsigned' for attribute indices. This gives consistent behavior
on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.

Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.

• dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::getAttributeItemIndexSlowCase):

• dom/Element.h:

(ElementData):
(UniqueElementData):
(Element):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::attributeCount):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):

• dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::length):

• dom/NamedNodeMap.h:

(NamedNodeMap):

1:00 PM Changeset in webkit [149060] by akling@apple.com

• 2 edits in trunk/Source/WebCore

ElementData::attributeItem() should bounds-check the index.
<​http://webkit.org/b/115076>

Reviewed by Antti Koivisto.

Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.

• dom/Element.h:

(WebCore::ElementData::attributeItem):

12:59 PM Changeset in webkit [149059] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
<​http://webkit.org/b/115122>

Reviewed by Antti Koivisto.

StylePropertySet::setProperty() handles empty strings by removing the property entirely.
If there was no property to remove, it shouldn't claim that it changed something, as that
will cause the CSSOM wrapper to mark the element for style recalc.

A common idiom that triggers this is excessive use of { element.style.display = ; }

• css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::setProperty):

12:50 PM Changeset in webkit [149058] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Moving word boundaries backwards fails when there is a text node starting with an apostrophe
​https://bugs.webkit.org/show_bug.cgi?id=115070

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
"I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".

Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
languages like Hebrew and some of European languages, there could be many accents and combining characters
between split into multiple text nodes as one variant is seen in the newly added test case.

Test: editing/selection/previous-word-boundary-across-text-nodes.html

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary):

LayoutTests:

Added a test case for moving bacwkards with a word granurality across multiple text nodes.
Some test cases still fail since this patch only implements a work around.

• editing/selection/previous-word-boundary-across-text-nodes-expected.txt: Added.
• editing/selection/previous-word-boundary-across-text-nodes.html: Added.

12:46 PM Changeset in webkit [149057] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Do not use static string in DiagnosticLoggingKeys
​https://bugs.webkit.org/show_bug.cgi?id=115093

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-24
Reviewed by Andreas Kling.

The code is not hot enough to justify keeping the memory around.
This removes 3kb from the binary on x86_64.

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):

• page/DiagnosticLoggingKeys.h:

(DiagnosticLoggingKeys):

12:38 PM Changeset in webkit [149056] by benjamin@webkit.org

• 22 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/platform/graphics
​https://bugs.webkit.org/show_bug.cgi?id=115081

Reviewed by Geoffrey Garen.

• platform/graphics/BitmapImage.h:

(BitmapImage):

• platform/graphics/Color.h:

(Color):

• platform/graphics/FloatRect.h:

(FloatRect):

• platform/graphics/FloatSize.h:

(FloatSize):

• platform/graphics/FontPlatformData.h:
• platform/graphics/GlyphBuffer.h:

(WebCore):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):

• platform/graphics/Gradient.h:
• platform/graphics/GraphicsContext.h:

(GraphicsContext):

• platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

• platform/graphics/ImageBufferData.h:
• platform/graphics/IntPoint.h:

(IntPoint):

• platform/graphics/IntRect.h:
• platform/graphics/IntSize.h:

(IntSize):

• platform/graphics/NativeImagePtr.h:

(WebCore):

• platform/graphics/Path.h:
• platform/graphics/Pattern.h:
• platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns):

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

• platform/graphics/transforms/AffineTransform.h:

(AffineTransform):

• platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

12:36 PM Changeset in webkit [149055] by benjamin@webkit.org

• 4 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/plugins
​https://bugs.webkit.org/show_bug.cgi?id=115080

Reviewed by Geoffrey Garen.

• plugins/PluginView.h:

(PluginView):

• plugins/mac/PluginViewMac.mm:

(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::platformStart):

• plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):

12:35 PM Changeset in webkit [149054] by benjamin@webkit.org

• 4 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/page
​https://bugs.webkit.org/show_bug.cgi?id=115079

Reviewed by Geoffrey Garen.

• page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

• page/Settings.cpp:

(WebCore):

• page/Settings.h:

(Settings):

12:34 PM Changeset in webkit [149053] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Use post-branch store for RefCountedBase::derefBase
​https://bugs.webkit.org/show_bug.cgi?id=115078

Reviewed by Andreas Kling.

• wtf/RefCounted.h:

(WTF::RefCountedBase::derefBase): This makes the assembly easier to follow.

11:34 AM Changeset in webkit [149052] by Carlos Garcia Campos

• 5 edits in trunk

[GTK] Use stamp files for generate-forwarding-headers makefile rules
​https://bugs.webkit.org/show_bug.cgi?id=115118

Reviewed by Martin Robinson.

Source/WebKit2:

Use a stamp file for the WebKit2 forwarding generator rule. Also
fix the rule dependencies that pointed to a non existent variable.

• GNUmakefile.am:

Tools:

Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.

• TestWebKitAPI/GNUmakefile.am:
• WebKitTestRunner/GNUmakefile.am:

11:33 AM Changeset in webkit [149051] by Chris Fleizach

• 12 edits
  2 adds in trunk

AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
​https://bugs.webkit.org/show_bug.cgi?id=114547

Reviewed by David Kilzer.

Source/WebCore:

We want iOS to speak the landmark type.
I've moved the landmark role description to the base Mac class and exposed
these localized strings to iOS (the ones used to return landmark descriptions).

I've also updated the accessibilityLabel to account for landmark type, but also
handle multiple label sources more gracefully by appending commas, which changed a few
tests in minor ways.

Test: platform/iphone-simulator/accessibility/landmark-type.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityLabel]):

• accessibility/mac/WebAccessibilityObjectWrapperBase.h:
• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper roleDescription]):

• platform/LocalizedStrings.cpp:

(WebCore):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):

• platform/LocalizedStrings.h:

(WebCore):

LayoutTests:

• platform/iphone-simulator/accessibility/landmark-type-expected.txt: Added.
• platform/iphone-simulator/accessibility/landmark-type.html: Added.
• platform/iphone-simulator/accessibility/link-with-images-text-expected.txt:
• platform/iphone-simulator/accessibility/link-with-images-text.html:

Minor change to accomodate trimming of white space.

• platform/iphone-simulator/accessibility/math-expected.txt:
• platform/iphone-simulator/accessibility/math.html:

Math objects now include "math" as the landmark type.

11:16 AM Changeset in webkit [149050] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

32-bit build fix.

Unreviewed.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): Explicitly
truncate to 32-bit to avoid compiler warnings. It's safe to truncate
because the payload of a boolean is the low bits on both 64-bit and 32-bit.

11:06 AM Changeset in webkit [149049] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
​https://bugs.webkit.org/show_bug.cgi?id=115094

Reviewed by Tim Horton.

The method was introduced in r149004 (and a stub implementation for the GTK port added in r149017).
Implement the method for the GTK port in the same manner it is implemented under the Mac port,
calling setContentsOpaque on the non-composited content layer.

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):

10:50 AM Changeset in webkit [149048] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Update build dependencies
​https://bugs.webkit.org/show_bug.cgi?id=115111

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-04-24
Reviewed by Martin Robinson.

The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.

• gtk/install-dependencies: Added a dependency on libegl1-mesa

for both apt and yum.

10:43 AM Changeset in webkit [149047] by akling@apple.com

• 2 edits in trunk/Source/WebCore

CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
<​http://webkit.org/b/115116>
<rdar://problem/13727709>

Reviewed by Simon Fraser.

The logic that dirties the style if there's a relevant attribute selector in the document
shouldn't run if the attribute is being overwritten with an identical value.
Move this into willModifyAttribute() instead, since we need access to both the old and the new value.

This reduces unnecessary style recalculation in Mac App Store content.

• dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):

10:07 AM Changeset in webkit [149046] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove the Chromium-specific helper from run_webkit_tests.py
​https://bugs.webkit.org/show_bug.cgi?id=114996

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Dirk Pranke.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

9:12 AM Changeset in webkit [149045] by commit-queue@webkit.org

• 3 edits
  1 add in trunk/Tools

[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
​https://bugs.webkit.org/show_bug.cgi?id=114850

Patch by Sergio Correia <Sergio Correia> on 2013-04-24
Reviewed by Andreas Kling.

Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.

That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.

This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.

This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.

• TestWebKitAPI/PlatformEfl.cmake:
• TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.

(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):

9:08 AM Changeset in webkit [149044] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

2013-04-24 Simon Cooper <​scooper@apple.com>

<rdar://problem/13614117> Refine the Flash Player profile
​https://bugs.webkit.org/show_bug.cgi?id=115016

Reviewed by Alexey Proskuryakov.

Add some refinements to the Flash Player profile. Make a non-/ home
directory work. Fixes that allow file uploading via user selected files.

• Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

8:59 AM Changeset in webkit [149043] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not clear focus on a node when tapping on form controls
​https://bugs.webkit.org/show_bug.cgi?id=115055

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-04-24
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.

• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::doFatFingers):

8:49 AM Changeset in webkit [149042] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Fixes the San Angeles demo on khronos.org
​https://bugs.webkit.org/show_bug.cgi?id=115106

Patch by Jonathan Feldstein <​jfeldstein@blackberry.com> on 2013-04-24
Reviewed by Rob Buis
Internally Reviewed by Jeremy Nicholl and Arvid Nilsson

Fixes a bug in which the currently bound vertex array object's vertex array
state was being modified as opposed to the default vertex array state.

• platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(EGLImageLayerWebKitThread::blitToFrontBuffer):

8:48 AM Changeset in webkit [149041] by ggaren@apple.com

• 8 edits in trunk

Filled out more cases of branch folding in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=115088

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

No change on the benchmarks we track, but a 3X speedup on a
microbenchmark that uses these techniques.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): (!/=)= and (!/=)== can constant
fold all types, not just numbers, because true constants have no
side effects when type-converted at runtime.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean): Added support for fixing up
boolean uses, like we do for other types like number.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare): Peephole fuse
boolean compare and/or compare-branch, now that we have the types for
them.

• dfg/DFGSpeculativeJIT.h: Updated declarations.

LayoutTests:

• fast/js/regress/script-tests/branch-fold.js:

(g): Added some boolean and constant-folded cases.

8:44 AM Changeset in webkit [149040] by thakis@chromium.org

• 4 edits
  2 deletes in trunk/Source/WebCore

Fold RenderThemeMacShared into RenderThemeMac
​https://bugs.webkit.org/show_bug.cgi?id=115086

Reviewed by Anders Carlsson.

No intended functionality change.

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderThemeMac.h:

(RenderThemeMac):
(WebCore::RenderThemeMac::supportsControlTints):
(WebCore::RenderThemeMac::scrollbarControlSizeForPart):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors):
(WebCore::RenderThemeMac::supportsClosedCaptioning):
(WebCore::RenderThemeMac::updateActiveState):

• rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
(WebCore):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformFocusRingColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMac::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::systemColor):
(WebCore::RenderThemeMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::updateCheckedState):
(WebCore::RenderThemeMac::updateEnabledState):
(WebCore::RenderThemeMac::updateFocusedState):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintTextArea):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::popupButtonMargins):
(WebCore::RenderThemeMac::popupButtonSizes):
(WebCore::RenderThemeMac::popupButtonPadding):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
(WebCore::RenderThemeMac::levelIndicatorStyleFor):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::menuListSizes):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::searchFieldSizes):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::cancelButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
(WebCore::RenderThemeMac::fileListNameForWidth):

• rendering/RenderThemeMacShared.h: Removed.
• rendering/RenderThemeMacShared.mm: Removed.

8:38 AM CoordinatedGraphicsSystem edited by allan.jensen@digia.com

(diff)

8:36 AM Changeset in webkit [149039] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK][AC] Visible rect doesn't update after resizing a window.
​https://bugs.webkit.org/show_bug.cgi?id=115096

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

Once we set actor's a clip rect, we should update the rect when resizing the actor.

No new tests since no new functionality.

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::setSize):

8:34 AM Changeset in webkit [149038] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK][AC] Fix unexpected clear of ClutterContent.
​https://bugs.webkit.org/show_bug.cgi?id=115099

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
it would be cleared unexpectedly by smart pointer when escaping a function.

No new tests, no functionality changed.

• platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):

8:30 AM Changeset in webkit [149037] by akling@apple.com

• 2 edits in trunk/Source/WebKit/win

Wild build fix attempt.

• WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

8:26 AM Changeset in webkit [149036] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
​https://bugs.webkit.org/show_bug.cgi?id=115098

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-24
Reviewed by Martin Robinson.

r148963 introduced a new WKView.h header in a directory not listed
as a platform prefix in generate-forwarding-headers.pl.

• Scripts/generate-forwarding-headers.pl: Replace unused chromium

plaform prefix with CoordinatedGraphics that is used now.

8:15 AM Changeset in webkit [149035] by jberlin@webkit.org

• 7 edits
  1 delete in trunk/Source/WebKit

Assertion failure (crash in release) attempting to delete database storage in WK1 without
creating a WebView first
​https://bugs.webkit.org/show_bug.cgi?id=115065

Reviewed by Brady Eidson.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Remove WebDatabaseManagerInternal.h.

Source/WebKit/mac:

Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager.

• Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager init]):
Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to
WebPlatformStrategies::initializeIfNecessary.

• Storage/WebDatabaseManagerInternal.h: Removed.

• WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):
Change "initialize" to "initalizeIfNecessary".

• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::initializeIfNecessary):
Only call setPlatformStrategies once.

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Updated for the name change from initialize to initializeIfNecessary.
Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager
sharedWebDatabaseManager].
(+[WebView _setLoadResourcesSerially:]):
Updated for the name change from initialize to initializeIfNecessary.

7:27 AM Changeset in webkit [149034] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

DOMFileSystemBase: fix multiple definitions in the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=114950

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-24
Reviewed by Xan Lopez.

The following methods are already defined in DOMFileSystemBlackBerry.cpp:

crackFileSystemURL()
createFileSystemURL()
isValidType()
supportsToURL()

• Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore):

7:10 AM Changeset in webkit [149033] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Add support for JPEG image quality during encoding.
​https://bugs.webkit.org/show_bug.cgi?id=105773

Patch by George Staikos <​gstaikos@rim.com> on 2013-04-24
Reviewed by Xan Lopez.

PR 271611
Internally reviewed by Liam Quinn.

Pass the quality flag into the encoder, with a default of 65

Covered by existing tests.

• platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG):

• platform/image-encoders/JPEGImageEncoder.h:

(WebCore):

6:54 AM Changeset in webkit [149032] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Add unit test cases for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

• tests/test_ewk_setting.cpp:

(TEST_F):

6:11 AM Changeset in webkit [149031] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
​https://bugs.webkit.org/show_bug.cgi?id=115036

Reviewed by Benjamin Poulain.

• platform/graphics/GraphicsContext3D.cpp:

(WebCore):

6:03 AM Changeset in webkit [149030] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/constructor-length.html for EFL port after
r148997.

• platform/efl/fast/js/constructor-length-expected.txt:

5:33 AM Changeset in webkit [149029] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove unnecessary MutableStylePropertySet casts.
<​http://webkit.org/b/115075>

Reviewed by Geoffrey Garen.

Get rid of some now-unneeded static_casts that were left from the StylePropertySet
refactoring last weekend.

• css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::setProperty):

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

5:17 AM Changeset in webkit [149028] by kangil.han@samsung.com

• 2 edits in trunk/Source/WebCore

[Minor code cleanup] Remove duplicated condition check
​https://bugs.webkit.org/show_bug.cgi?id=115082

Reviewed by Andreas Kling.

areRectsPartiallyAligned() has duplicated condition check, so remove it.

• page/SpatialNavigation.cpp:

(WebCore::areRectsPartiallyAligned):

5:01 AM Changeset in webkit [149027] by Christophe Dumez

• 2 edits in trunk/Tools

[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
​https://bugs.webkit.org/show_bug.cgi?id=115095

Reviewed by Antonio Gomes.

Use different subfolders under DumpRenderTree Temp folder for every
functionality (icon database, cache, localstorage, ...). This makes
sure there is no conflict between the functionalities.

In EFL's case, libsoup cache was causing problems for the icon
database if sharing the same folder.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

4:21 AM Changeset in webkit [149026] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[EFL] Fix build warnings caused by missing images attributes for default buttons
​https://bugs.webkit.org/show_bug.cgi?id=114955

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added default image for each button from mediacontrol catalog.

No new tests, because there is no change in behavior.

• platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
• platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
• platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
• platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
• platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
• platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:

3:54 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

(diff)

3:53 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

(diff)

3:50 AM Changeset in webkit [149025] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Web Inspector: Add number to list from remote web inspector.
​https://bugs.webkit.org/show_bug.cgi?id=115014

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.

• UIProcess/InspectorServer/front-end/inspectorPageIndex.html:

3:48 AM Changeset in webkit [149024] by commit-queue@webkit.org

• 23 edits in trunk/LayoutTests

[EFL] Rebaselining after r148944
​https://bugs.webkit.org/show_bug.cgi?id=115085

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24

• platform/efl/TestExpectations:
• platform/efl/fast/table/giantRowspan-expected.txt:
• platform/efl/fast/table/giantRowspan2-expected.png:
• platform/efl/fast/table/giantRowspan2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug220536-expected.png:
• platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
• platform/efl/tables/mozilla/bugs/bug8858-expected.png:
• platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
• platform/efl/tables/mozilla/core/bloomberg-expected.png:
• platform/efl/tables/mozilla/core/bloomberg-expected.txt:
• platform/efl/tables/mozilla/core/row_span-expected.png:
• platform/efl/tables/mozilla/core/row_span-expected.txt:
• platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
• platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
• platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
• platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
• platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
• platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:

2:01 AM Changeset in webkit [149023] by abucur@adobe.com

• 3 edits in trunk/LayoutTests

Fix test style issues following the commit of
​https://bugs.webkit.org/show_bug.cgi?id=114412

Unreviewed gardening.

• css3/compositing/effect-background-blend-mode-color.html:
• css3/compositing/effect-background-blend-mode-color2.html:

1:44 AM Changeset in webkit [149022] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

--minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: decode is not a member of WebCore::TextCheckingResult
​https://bugs.webkit.org/show_bug.cgi?id=114367

Patch by Vlad Vasilyeu <​vasvlad@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

Include WebCoreArgumentCoders.h to WebEditorClientEfl.cpp from
WebKit2/Shared/ for successfully building with option --minimal

• WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

1:23 AM Changeset in webkit [149021] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed build fix with gstreamer 0.10.x after r147555.

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

1:11 AM Changeset in webkit [149020] by mrowe@apple.com

• 6 edits
  6 copies in trunk

Roll deps^HH^HHChangeLogs.

1:09 AM Changeset in webkit [149019] by anilsson@rim.com

• 5 edits in trunk/Source/WebCore

[BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
​https://bugs.webkit.org/show_bug.cgi?id=115092

Reviewed by Carlos Garcia Campos.

With the Skia backend, we had an optimization to detect solid color
layers. The Skia code has been purged, but these bits remained. With
BlackBerry::Platform::Graphics::PlatformGraphicsContext, only the solid
color will be drawn anyway, so we don't need to detect such layers at
the WebCore level. Fixed by removing the setContentsToColor flavor of
LayerTiler::TextureJob.

BlackBerry::WebKit::WebOverlay still uses
TextureCacheCompositingThread::textureForColor() so that one can stay
for now.

This was dead code so no new tests.

• platform/graphics/blackberry/LayerTile.cpp:
• platform/graphics/blackberry/LayerTile.h:

(LayerTile):

• platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::performTileJob):

• platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::setContents):
(TextureJob):

12:43 AM Changeset in webkit [149018] by zandobersek@gmail.com

• 4 edits in trunk/Source

[GTK] Move image decoders, some other GStreamer, Cairo and Soup sources to libPlatform
​https://bugs.webkit.org/show_bug.cgi?id=115050

Reviewed by Martin Robinson.

Source/Platform:

• GNUmakefile.am: Add the image-decoders directory and its subdirectories to the list of header inclusion directories.

List the Cairo, GStreamer and Libsoup cppflags under the cppflags libPlatform uses for compiling its sources.

Source/WebCore:

No new tests - no new functionality.

• GNUmakefile.list.am: Move the image decoders source files and a couple of GStreamer, Cairo and Libsoup source

files under the libPlatform's list of files to build. All of these are already free of platform layer violations.

12:25 AM Changeset in webkit [149017] by Claudio Saavedra

• 3 edits in trunk/Source/WebKit2

Build break after r149004
​https://bugs.webkit.org/show_bug.cgi?id=115091

Reviewed by Csaba Osztrogonác.

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):
(WebKit): Add dummy method for new virtual method.

• WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk): Ditto.

Apr 23, 2013:

8:18 PM Changeset in webkit [149016] by fpizlo@apple.com

• 5 edits
  3 adds in trunk

DFG CFA filters CheckFunction in a really weird way, and assumes that the function's structure won't change
​https://bugs.webkit.org/show_bug.cgi?id=115077

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The filtering did three things that are unusual:

1) AbstractValue::filterByValue() assumed that the passed value's structure wouldn't change, in

the sense that at it assumed it could use that value's *current* structure to do structure
filtering. Filtering by structure only makes sense if you can prove that the given value will
always have that structure (for example by either using a watchpoing or emitting code that
checks that structure at run-time).

2) AbstractValue::filterByValue() and the CheckFunction case in AbstractState::executeEffects()

tried to invalidate the CFA based on whether the filtration led to an empty value. This is
well-intentioned, but it's not how the CFA currently works. It's inconsistent with other
parts of the CFA. We shouldn't introduce this feature into just one kind of filtration and
not have it elsewhere.

3) The attempt to detect when the value was empty was actually implemented incorrectly. It

relied on AbstractValue::validate(). That method says that a concrete value does not belong
to the abstract value if it has a different structure. This makes sense for the other place
where AbstractValue::validate() is called: during OSR entry, where we are talking about a
JSValue that we see *right now*. It doesn't make sense in the CFA, since in the CFA any
value we observe in the code is a value whose structure may change when the code starts
running, and so we cannot use the value's current structure to infer things about the code
when it starts running.

I fixed the above problems by (1) changing filterByValue() to not filter the structure, (2)
changing filterByValue() and the CheckFunction case to not invalidate the CFA, and (3)
making sure that nobody else was misusing AbstractValue::validate() (they weren't).

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filterByValue):

LayoutTests:

Reviewed by Oliver Hunt.

This hilarious test fails prior to the rest of this patch.

• fast/js/dfg-check-function-change-structure-expected.txt: Added.
• fast/js/dfg-check-function-change-structure.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-check-function-change-structure.js: Added.

(foo):
(bar):

6:59 PM Changeset in webkit [149015] by tkent@chromium.org

• 5 edits
  2 deletes in trunk/Source/WebCore

Remove TextFieldDecoration feature
​https://bugs.webkit.org/show_bug.cgi?id=115068

Reviewed by Andreas Kling.

Only Chromium port used this feature.

• dom/Element.h: Remove isTextFieldDecoration.
• html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Update a comment.

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.

• html/shadow/TextFieldDecorationElement.cpp: Removed.
• html/shadow/TextFieldDecorationElement.h: Removed.
• page/ChromeClient.h:

(ChromeClient): Remove willAddTextFieldDecorationsTo and
addTextFieldDecorationsTo

6:23 PM Changeset in webkit [149014] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Default ParserError() initialiser doesn't initialise all fields
​https://bugs.webkit.org/show_bug.cgi?id=115074

Reviewed by Joseph Pecoraro.

Only the jsc command prompt depended on this, but we'll fix it to
be on the safe side.

• parser/ParserError.h:

(JSC::ParserError::ParserError):

6:10 PM Changeset in webkit [149013] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Micro-optimize Length::initFromLength().
<​http://webkit.org/b/115073>

From Blink r148621 by <​timloh@chromium.org>:

This appears to improve html5-full-render by 1-2% on my system (gcc 4.6.3) by using memcpy
instead of copying members (and branching to copy the union).

• platform/Length.h:

(WebCore::Length::initFromLength):

6:06 PM Changeset in webkit [149012] by tkent@chromium.org

• 2 edits in trunk/Source/WebCore

Add missing copyright header to ColorChooserClient.h
​https://bugs.webkit.org/show_bug.cgi?id=115067

Reviewed by Andreas Kling.

• platform/ColorChooserClient.h:

This was added in 2011 by a Google employee.
​http://trac.webkit.org/changeset/103168

5:55 PM Changeset in webkit [149011] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Call the correct superclass in RenderSlider::layout().
<​http://webkit.org/b/115071>

From Blink r147850 by <​cbiesinger@chromium.org>:

The superclass is RenderFlexibleBox, not RenderBlock.

• rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

5:53 PM Changeset in webkit [149010] by commit-queue@webkit.org

• 5 edits
  6 adds in trunk

Add platform support for -webkit-background-blend-mode to CG context with background color
​https://bugs.webkit.org/show_bug.cgi?id=114412

Patch by Mihai Tica <​mitica@adobe.com> on 2013-04-23
Reviewed by Darin Adler.

Source/WebCore:

Tests: css3/compositing/effect-background-blend-mode-color.html, css3/compositing/effect-background-blend-mode-color2.html

This patch adds support for blending on background colors to the Core Graphics port of WebKit.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):

• platform/graphics/GraphicsContext.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding pixel tests for -webkit-background-blend-mode with bg-color
effect-background-blend-mode-color.html uses accelerated compositing
effect-background-blend-mode-color2.html uses software rendering

• css3/compositing/effect-background-blend-mode-color-expected.txt: Added.
• css3/compositing/effect-background-blend-mode-color.html: Added.
• platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Added.
• css3/compositing/effect-background-blend-mode-color2-expected.txt: Added.
• css3/compositing/effect-background-blend-mode-color2.html: Added.
• platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Added.

5:33 PM Changeset in webkit [149009] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Remove an unused member variable erroneously added in r149007.

• rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(LogicalSelectionOffsetCaches):

5:20 PM Changeset in webkit [149008] by ryuan.choi@samsung.com

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] Build break after r149004
​https://bugs.webkit.org/show_bug.cgi?id=115066

Reviewed by Tim Horton.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged):
Added dummy method for new virtual method.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost): Ditto.

5:18 PM Changeset in webkit [149007] by rniwa@webkit.org

• 9 edits
  1 add in trunk/Source/WebCore

logicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth() multiple times
​https://bugs.webkit.org/show_bug.cgi?id=113479

Reviewed by David Hyatt.

Introduced LogicalSelectionOffsetCaches to cache the containing blocks and their logical left and right
selection offsets in computing selection gaps. An instance of this class stores the containing block for
each position type and caches their logical selection offsets when none of their block ancestors up until
its nearest selection root do no have any floating objects or regions and exclusions.

When blockSelectionGaps recurses to another level, it creates a new cache instance by "inheriting"
(like RenderStyle) from the old cache, overriding those containing blocks that are replaced by "this".

This eliminates the need to traverse containing block ancestors in RenderBlock::logicalLeftSelectionOffset
and RenderBlock::logicalRightSelectionOffset, and improves WebKit's performance by roughly 20%.

Performance Tests: Interactive/SelectAll.html

• GNUmakefile.list.am:
• Target.pri:
• WebCore.xcodeproj/project.pbxproj:

• rendering/LogicalSelectionOffsetCaches.h: Added.

(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Moved from RenderObject.h.
(WebCore::isNonRenderBlockInline): Ditto.
(WebCore::containingBlockForFixedPosition): Extracted from RenderObject::containingBlock.
(WebCore::containingBlockForAbsolutePosition): Ditto.
(WebCore::containingBlockForObjectInFlow): Ditto.

(WebCore::LogicalSelectionOffsetCaches): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock): Added. m_hasFloatsOrRegions is
or'ed with itself when ContainingBlockInfo is copy constructed since m_hasFloatsOrRegions needs be true
for a block when any of its containing block ancestors have floats or regions.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::block): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::cache): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset): Added. Caches
the logical selection offset if it hasn't.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset): Ditto.

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches): The first constructor is used
for a selection root. The second one is used for inheriting from another cache. In the latter case,
copy all containing block information except ones that need to be overridden by this block.
(WebCore::LogicalSelectionOffsetCaches::containingBlockInfo): Returns a ContainingBlockInfo based on
object's position value.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps): Exit before instantiating a new LogicalSelectionOffsetCaches
if there is no child to recurse.
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset): Use LogicalSelectionOffsetCaches to get its containing
block and its logical selection offset.
(WebCore::RenderBlock::logicalRightSelectionOffset): Ditto.

• rendering/RenderBlock.h:

(WebCore::RenderBlock):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Extracted code into LogicalSelectionOffsetCaches.h.

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSelectionGap):

• rendering/RootInlineBox.h:

(WebCore::RootInlineBox):

4:44 PM Changeset in webkit [149006] by Simon Fraser

• 3 edits in trunk/Source/WebKit2

Turn off tiled drawing in the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=115064

Reviewed by Tim Horton.

We get little benefit from making the Web Inspector use tiled drawing;
it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
Not using tiled drawing also means that we won't make compositing
layers for position: -webkit-sticky, which avoids a number of issues
with compositing layer proliferation in the inspector.

Also turn off accelerated drawing, since that pref will force a single
compositing layer.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup):

• UIProcess/mac/WebInspectorProxyMac.mm:

4:35 PM Changeset in webkit [149005] by eric.carlson@apple.com

• 5 edits in trunk/Source/WebCore

[Mac] forced subtitle track should change when audio track language changes
​https://bugs.webkit.org/show_bug.cgi?id=115043

Reviewed by Jer Noble.

No new tests, it isn't possible to test this automatically because there is currently no way
to enable/disable audio tracks.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Set m_forcedOrAutomaticSubtitleTrackLanguage.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Call markCaptionAndSubtitleTracksAsUnconfigured

after a delay if the language of the primary audio track changes.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): markCaptionAndSubtitleTracksAsUnconfigured API change.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Take parameter to allow

the reconfiguration to happen after a delay to avoid doing it during a callback from the
media engine. Clear the ConfigureTextTracks bit in m_pendingActionFlags to cancel any pending
asynch configuration.

• html/HTMLMediaElement.h:

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Clean up logic.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Call characteristicChanged when

the primary audio track language changes.

4:02 PM Changeset in webkit [149004] by Simon Fraser

• 6 edits in trunk/Source/WebKit2

When the web page transparency changes, DrawingAreaImpl needs to know about it
​https://bugs.webkit.org/show_bug.cgi?id=115062

Reviewed by Tim Horton.

The non-composited contents layer owned by LayerTreeHostMac needs to
be marked as opaque or not depending on whether the WebPage draws
a background (or transparent background). It computed this at creation,
but did not dynamically update the state. Fix it so it does.

This fixes cases of garbage pixels in the Web Inspector toolbar area
in some configurations.

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::pageBackgroundTransparencyChanged):

• WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

• WebProcess/WebPage/LayerTreeHost.h:
• WebProcess/WebPage/mac/LayerTreeHostMac.h:
• WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::pageBackgroundTransparencyChanged):

3:43 PM Changeset in webkit [149003] by hmuller@adobe.com

• 3 edits in trunk/Source/WebCore

[CSS Exclusions] Improve ExclusionPolygon smart pointer safety
​https://bugs.webkit.org/show_bug.cgi?id=114984

Reviewed by Dirk Schulze.

Assign newly allocated objects to PassOwnPtrs as early as possible to reduce the
chances of future leaks. No new tests were added, this change adds no new functionality.

• rendering/ExclusionPolygon.cpp:

(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
(WebCore::ExclusionPolygon::shapePaddingBounds):
(WebCore::ExclusionPolygon::shapeMarginBounds):

• rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

3:36 PM Changeset in webkit [149002] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Revert "Throttle resize events during live window resize."
<​http://webkit.org/b/114292>
<rdar://problem/13411454>
<rdar://problem/13694839>

Reviewed by Geoffrey Garen.

It appears that this caused more glitches than it helped resize performance.

• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEvent):

Turn the null-check of m_frame into an assertion since this method is
no longer called asynchronously.

(WebCore::FrameView::willEndLiveResize):

Ninja fix: call up to the closest superclass implementation.

3:34 PM Changeset in webkit [149001] by Christophe Dumez

• 10 edits
  1 copy
  1 move
  4 adds
  13 deletes in trunk

Global constructors should be configurable and not enumerable
​https://bugs.webkit.org/show_bug.cgi?id=110573

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update JSObject::deleteProperty() so that mark to set the property
value to undefined if it is in static hashtable of properties. The
previous code was not doing anything in this case and this meant
we could not remove builtin DOMWindow properties such as
"ProgressEvent" even if marked as Deletable.

• runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

• runtime/Lookup.h:

(JSC):
(JSC::putEntry):
(JSC::lookupPut):

Source/WebCore:

Update JSC Code generator so that global constructors now have the following
attributes:
{ Writable: true, Enumerable: false, Configurable: true }
instead of previously:
{ Writable: true, Enumerable: true, Configurable: false }

The new behavior is according to the Web IDL specification (section 4.4):
​http://dev.w3.org/cvsweb/~checkout~/2006/webapi/WebIDL/Overview.html?rev=1.617;content-type=text%2Fhtml#es-interfaces

This also matches the behavior of Firefox.

Tests: fast/js/global-constructors-attributes.html

fast/js/global-constructors-deletable.html

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

LayoutTests:

Add new tests to make sure that the global constructors have the
right attributes and to check that they are 'Deletable'.

• canvas/philip/tests/type.delete-expected.txt: Removed.
• canvas/philip/tests/type.delete.html: Removed. It was checking that global constructor

could NOT be deleted, which is no longer according to the Web IDL specification.

• fast/dom/constructed-objects-prototypes-expected.txt:
• fast/dom/script-tests/constructed-objects-prototypes.js: Update test to hardcode a few

global constructors as they are no longer enumerable.

• fast/js/getOwnPropertyDescriptor-expected.txt:
• fast/js/global-constructors.html: Removed. It was relying on the global constructors

to be 'Enumerable', which is not to the latest Web IDL specification.

• fast/js/global-constructors-attributes-expected.txt: Added.
• fast/js/global-constructors-attributes.html: Added.
• fast/js/global-constructors-deletable-expected.txt: Added.
• fast/js/global-constructors-deletable.html: Added.
• fast/js/global-constructors-expected.txt: Removed.
• fast/js/resources/getOwnPropertyDescriptor.js:
• fast/js/script-tests/global-constructors-attributes.js: Added.
• fast/js/script-tests/global-constructors-deletable.js: Added.
• fast/js/script-tests/global-constructors.js: Removed.
• platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
• platform/efl/fast/js/global-constructors-expected.txt: Removed.
• platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
• platform/gtk/fast/js/global-constructors-expected.txt: Removed.
• platform/mac/fast/js/global-constructors-expected.txt: Removed.
• platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
• platform/qt/fast/js/global-constructors-expected.txt: Removed.
• platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
• platform/win/fast/js/global-constructors-expected.txt: Removed.

3:23 PM Changeset in webkit [149000] by dgrogan@chromium.org

• 2 edits in trunk/Tools

Unreviewed. Remove myself from watchlist.

• Scripts/webkitpy/common/config/watchlist:

3:18 PM Changeset in webkit [148999] by ggaren@apple.com

• 16 edits
  3 adds in trunk

Source/JavaScriptCore: Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

This covers a few cases like:

• while (true) { }
• while (1) { }
• if (x) break;
• if (x) continue;
• if (boolean_expr == boolean_const) { }
• if (boolean_expr == 1_or_0) { }
• if (bitop == 1_or_0) { }

This also works, but will bring shame on your family:

• while ("hello world") { }

No change on the benchmarks we track, but a 2.5X speedup on a microbenchmark
that uses these techniques.

• JavaScriptCore.order: Order!

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldEmitDebugHooks): Updated ancillary code
for interface simplifications.

• bytecompiler/NodesCodegen.cpp:

(JSC::ConstantNode::emitBytecodeInConditionContext): Constants can
jump unconditionally when used within a condition context.

(JSC::ConstantNode::emitBytecode):
(JSC::StringNode::jsValue): Gave constants a common base class so I
could implement their codegen just once.

(JSC::BinaryOpNode::emitBytecodeInConditionContext):
(JSC::canFoldToBranch):
(JSC::BinaryOpNode::tryFoldToBranch): Fold (!/=)= and (!/=)== where
appropriate. A lot of cases are not appropriate because of the surprising
type conversion semantics of ==. For example, if (number == true) { } is
not the same as if (number) { } because the former will up-convert true
to number and then do numeric comparison.

(JSC::singleStatement):
(JSC::IfElseNode::tryFoldBreakAndContinue):
(JSC::IfElseNode::emitBytecode):
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget): Fold "if (expression) break" and
"if (expression) continue" into direct jumps from expression.

• parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::createIfStatement):

• parser/NodeConstructors.h:

(JSC::ConstantNode::ConstantNode):
(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfElseNode::IfElseNode):

• parser/Nodes.h:

(JSC::ExpressionNode::isConstant):
(JSC::ExpressionNode::isBoolean):
(JSC::StatementNode::isBreak):
(JSC::StatementNode::isContinue):
(ConstantNode):
(JSC::ConstantNode::isPure):
(JSC::ConstantNode::isConstant):
(NullNode):
(JSC::NullNode::jsValue):
(JSC::BooleanNode::value):
(JSC::BooleanNode::isBoolean):
(JSC::BooleanNode::jsValue):
(JSC::NumberNode::value):
(NumberNode):
(JSC::NumberNode::jsValue):
(StringNode):
(BinaryOpNode):
(IfElseNode):
(ContinueNode):
(JSC::ContinueNode::isContinue):
(BreakNode):
(JSC::BreakNode::isBreak):

• parser/Parser.cpp:

(JSC::::parseIfStatement):

• parser/ResultType.h:

(JSC::ResultType::definitelyIsBoolean):
(ResultType):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::pureToBoolean): Updated for interface changes above.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

• wtf/TriState.h:

(WTF::triState):
(WTF):

LayoutTests: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a performance test for interesting branch types.

• fast/js/regress/branch-fold-expected.txt: Added.
• fast/js/regress/branch-fold.html: Added.
• fast/js/regress/script-tests/branch-fold.js: Added.

3:01 PM Changeset in webkit [148998] by Simon Fraser

• 4 edits
  4 adds in trunk

Don't create compositing layers for sticky position unless using the ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=115060

Source/WebCore:

Reviewed by Tim Horton.

Creating compositing layers for sticky position elements is only useful
when we're using a ScrollingCoordinator, so don't create them if
we're not in a frame that uses a scrolling coordinator.

Tests: compositing/layer-creation/no-compositing-for-sticky.html

platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Tim Horton.

Tests that we create layers for sticky position when in tiled drawing mode,
and that we have no layers when not.

• compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
• compositing/layer-creation/no-compositing-for-sticky.html: Added.
• platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html: Added.

2:59 PM Changeset in webkit [148997] by Christophe Dumez

• 34 edits
  1 copy
  2 adds in trunk

'length' property of DOM bindings functions returns wrong value
​https://bugs.webkit.org/show_bug.cgi?id=110569

Reviewed by Geoffrey Garen.

Source/WebCore:

Make the 'length' property of Function objects and Interface
objects behave according to the latest Web IDL specification
editor draft:
​http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
​http://dev.w3.org/2006/webapi/WebIDL/#es-operations

As a result, only mandatory arguments are taken into account
when computing the value for the 'length' property. This
behavior is consistent with Firefox and Blink.

Tests: fast/js/constructor-length.html

fast/js/function-length.html

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateConstructorHelperMethods):
Update the JSC code generator to only account for mandatory parameters
when computing the value for the 'length' property of Function objects
and constructors.

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore):
Rebaseline bindings tests results.

• fileapi/Blob.idl:

Remove 'ConstructorParameters=2' extended attribute as the correct value
is 0, given that a Blob can be constructed without parameter.

• html/canvas/DataView.idl:

Update ConstructorParameters extended attribute value from 3 to 1 as only
one of the 3 parameters is mandatory.

• html/canvas/Float32Array.idl:
• html/canvas/Float64Array.idl:
• html/canvas/Int16Array.idl:
• html/canvas/Int32Array.idl:
• html/canvas/Int8Array.idl:
• html/canvas/Uint16Array.idl:
• html/canvas/Uint32Array.idl:
• html/canvas/Uint8Array.idl:
• html/canvas/Uint8ClampedArray.idl:

Remove 'ConstructorParameters=1' extended attribute from interfaces using
'ConstructorTemplate=TypedArray' as the bindings generator now properly
compute the number of constructor parameters for such interfaces.

• page/WebKitPoint.idl:

Remove 'ConstructorParameters=2' extended attribute as the correct value
should be 0, given that a WebKitPoint can be constructed without parameters.

LayoutTests:

Update fast/js/constructor-length.html test case now that only
mandatory arguments are considered for the constructor length.

Also add a new fast/js/function-length.html test to make sure
that the 'length' property of Function objects from DOM
bindings behaves according to the Web IDL specification as
this was not covered by existing tests.

• fast/files/blob-constructor-expected.txt: Rebaseline.
• fast/files/script-tests/blob-constructor.js: Update test now that Blob constructor

length is 0 instead of 2.

• fast/js/constructor-length.html:
• fast/js/function-length-expected.txt: Added.
• fast/js/function-length.html: Added.
• platform/blackberry/fast/js/constructor-length-expected.txt: Rebaseline.
• platform/efl/TestExpectations: Unskip fast/js/constructor-length.html for EFL port.
• platform/efl/fast/js/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/fast/js/constructor-length-expected.txt.
• platform/gtk/fast/js/constructor-length-expected.txt: Rebaseline.
• platform/mac/fast/js/constructor-length-expected.txt: Rebaseline.
• platform/qt/fast/js/constructor-length-expected.txt: Rebaseline.

2:58 PM Changeset in webkit [148996] by commit-queue@webkit.org

• 6 edits in trunk

NRWT: confusing warning about a line being in a Skipped file when it is really just listed
in _missing_symbol_to_skipped_tests in base.py
​https://bugs.webkit.org/show_bug.cgi?id=108884

Patch by Jessie Berlin <​jberlin@apple.com> on 2013-04-23
Reviewed by Tim Horton.

Tools:

Remove symbol-based skipped list detection.

• Scripts/webkitpy/port/base.py:

(Port._missing_feature_to_skipped_tests):
(Port._skipped_tests_for_unsupported_features):

• Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.test_path_to_test_expectations_file):

LayoutTests:

Explicitly skip the mhtml tests on the Mac and Win ports.

• platform/mac/TestExpectations:
• platform/win/TestExpectations:

2:56 PM Changeset in webkit [148995] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION(r148922): Crash opening web archives or loading web pages
​https://bugs.webkit.org/show_bug.cgi?id=115061
<rdar://problem/13714228>

Reviewed by Sam Weinig.

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
Calling ResourceLoader::didReceiveResponse can cause the WebResourceLoader object to go away,
so protect it here and guard against a null core loader.

2:35 PM Changeset in webkit [148994] by benjamin@webkit.org

• 1 edit
  1 delete in trunk/Source/WebKit

Remove the WebKit layer of wxWebKit
​https://bugs.webkit.org/show_bug.cgi?id=115006

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Anders Carlsson.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

• wx/WebBrowserShell.cpp: Removed.
• wx/WebBrowserShell.h: Removed.
• wx/WebDOMSelection.cpp: Removed.
• wx/WebDOMSelection.h: Removed.
• wx/WebEdit.cpp: Removed.
• wx/WebEdit.h: Removed.
• wx/WebFrame.cpp: Removed.
• wx/WebFrame.h: Removed.
• wx/WebFramePrivate.h: Removed.
• wx/WebKitDefines.h: Removed.
• wx/WebKitSupport/ChromeClientWx.cpp: Removed.
• wx/WebKitSupport/ChromeClientWx.h: Removed.
• wx/WebKitSupport/ContextMenuClientWx.cpp: Removed.
• wx/WebKitSupport/ContextMenuClientWx.h: Removed.
• wx/WebKitSupport/DragClientWx.cpp: Removed.
• wx/WebKitSupport/DragClientWx.h: Removed.
• wx/WebKitSupport/EditCommandWx.h: Removed.
• wx/WebKitSupport/EditorClientWx.cpp: Removed.
• wx/WebKitSupport/EditorClientWx.h: Removed.
• wx/WebKitSupport/FrameLoaderClientWx.cpp: Removed.
• wx/WebKitSupport/FrameLoaderClientWx.h: Removed.
• wx/WebKitSupport/FrameNetworkingContextWx.h: Removed.
• wx/WebKitSupport/InspectorClientWx.cpp: Removed.
• wx/WebKitSupport/InspectorClientWx.h: Removed.
• wx/WebSettings.cpp: Removed.
• wx/WebSettings.h: Removed.
• wx/WebView.cpp: Removed.
• wx/WebView.h: Removed.
• wx/WebViewPrivate.h: Removed.
• wx/bindings/python/samples/simple.py: Removed.
• wx/bindings/python/webview.i: Removed.
• wx/bindings/python/wscript: Removed.
• wx/wscript: Removed.

2:24 PM Changeset in webkit [148993] by benjamin@webkit.org

• 5 edits in trunk/Source/WebCore

Minor String usage fixes in WebCore/platform
​https://bugs.webkit.org/show_bug.cgi?id=115021

Reviewed by Andreas Kling.

Use ASCIILiteral when possible + minor fixes.

• platform/ContentType.cpp:

(WebCore::ContentType::codecs):

• platform/ContentType.h:

(ContentType):

• platform/Decimal.cpp:

(WebCore::Decimal::toString):

• platform/KURL.cpp:

(WebCore::KURL::setProtocol):

2:18 PM Changeset in webkit [148992] by krit@webkit.org

• 4 edits
  6 adds in trunk

Pick up color and mat values in custom shaders
​https://bugs.webkit.org/show_bug.cgi?id=115046

Reviewed by Dean Jackson.

Source/WebCore:

The custom filter functions accept color values and mat2-4 functions
as parameter types. These were implemented in CSS already.
This patch picks up the values and applies them as uniforms to the
custom shader program.

Tests: css3/filters/custom/custom-filter-color.html

css3/filters/custom/custom-filter-matN.html

• platform/graphics/filters/CustomFilterRenderer.cpp:

(WebCore::CustomFilterRenderer::bindProgramColorParameters): Set uniform for color values.
(WebCore):
(WebCore::CustomFilterRenderer::bindProgramMatrixParameters): Set uniform for mat2-4 values.
(WebCore::CustomFilterRenderer::bindProgramParameters): Call color and matrix functions.

• platform/graphics/filters/CustomFilterRenderer.h:

(WebCore):
(CustomFilterRenderer):

LayoutTests:

Test that the CSS defined color values and mat2-4 functions get
set as uniforms in shader programs.

• css3/filters/custom/custom-filter-color-expected.html: Added.
• css3/filters/custom/custom-filter-color.html: Added.
• css3/filters/custom/custom-filter-matN-expected.html: Added.
• css3/filters/custom/custom-filter-matN.html: Added.

2:04 PM Changeset in webkit [148991] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
​https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>

Reviewed by Simon Fraser.

Stop the primary plugin detection timer if the WebPage is torn down.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

1:58 PM Changeset in webkit [148990] by zhajiang@rim.com

• 2 edits in trunk/Source/WebCore

Remove redundant code in ViewportArguments::resolve
​https://bugs.webkit.org/show_bug.cgi?id=115054

Patch by Jacky Jiang <​zhajiang@blackberry.com>.
Reviewed by Kenneth Rohde Christiansen.

Remove redundant code "result.orientation = orientation;".

• dom/ViewportArguments.cpp:

(WebCore::ViewportArguments::resolve):

1:54 PM Changeset in webkit [148989] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Simplify the baseline JIT loop hint call site.
​https://bugs.webkit.org/show_bug.cgi?id=115052.

Reviewed by Geoffrey Garen.

Moved the watchdog timer check after the JIT optimization check. This
ensures that the JIT opimization counter is incremented on every loop
hint even if the watchdog timer fires.

Removed the code that allows the JIT OSR to happen if the watchdog
timer fires but does not result in a termination. It is extremely rare
that the JIT optimization counter would trigger an OSR on the same pass
as when the watchdog timer fire. If it does happen, we'll simply hold
off on servicing the watchdog timer until the next pass (because it's
not time critical).

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):

1:51 PM Changeset in webkit [148988] by Simon Fraser

• 3 edits
  2 adds in trunk

Tiled layers clipped inside nested transform/preserve-3d hierarchies
​https://bugs.webkit.org/show_bug.cgi?id=115044

Source/WebCore:

Reviewed by Dean Jackson.

The optimization added in r139479 to call move() for integral translation
transforms hit a bug in TransformState::move(). If m_accumulatedTransform is
not null, we have to apply it.

Test: compositing/visible-rect/flipped-preserve-3d.html

• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move):

LayoutTests:

Reviewed by Dean Jackson.

Testcase that dumps visible rects for tiled layers inside nested
transformed/preserve-3d hierarchies.

• compositing/visible-rect/flipped-preserve-3d-expected.txt: Added.
• compositing/visible-rect/flipped-preserve-3d.html: Added.

1:39 PM Changeset in webkit [148987] by Claudio Saavedra

• 8 edits
  22 adds in trunk

Ctrl+Shift+Right in Windows should select the spacing after the word
​https://bugs.webkit.org/show_bug.cgi?id=110487

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/deleting/smart-editing-disabled-win.html

editing/execCommand/remove-format-multiple-elements-win.html
editing/execCommand/toggle-link-win.html
editing/execCommand/toggle-unlink-win.html
editing/selection/extend-selection-enclosing-block-win.html
editing/style/make-text-writing-direction-inline-win.html
editing/style/push-down-font-styles-win.html
editing/style/push-down-implicit-styles-around-list-win.html

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::nextWordPositionForPlatform): New method
that takes platform-specific editing behaviour in order to decide
what the next word position is, that is, for Windows, skip
spacing, for all other platforms, behave as currently.
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft): Use the new method
in all of the above.

• editing/FrameSelection.h: Declare the new method.

LayoutTests:

• editing/deleting/smart-editing-disabled-win-expected.txt: Added.
• editing/deleting/smart-editing-disabled-win.html: Added.
• editing/execCommand/query-command-state-expected.txt:
• editing/execCommand/remove-format-multiple-elements-win-expected.txt: Added.
• editing/execCommand/remove-format-multiple-elements-win.html: Added.
• editing/execCommand/script-tests/query-command-state.js:

(runTests): Update to reflect new editing behavior in Windows.

• editing/execCommand/script-tests/remove-format-multiple-elements-win.js: Added.
• editing/execCommand/script-tests/toggle-link-win.js: Added.
• editing/execCommand/script-tests/toggle-unlink-win.js: Added.
• editing/execCommand/toggle-link-win-expected.txt: Added.
• editing/execCommand/toggle-link-win.html: Added.
• editing/execCommand/toggle-unlink-win-expected.txt: Added.
• editing/execCommand/toggle-unlink-win.html: Added.
• editing/selection/extend-selection-enclosing-block-win-expected.txt: Added.
• editing/selection/extend-selection-enclosing-block-win.html: Added.
• editing/selection/resources/extend-selection.js:

(extendSelectionWithinBlockWin): Method to test behavior in windows.
(extendAndLogSelectionWithinBlock): Add test support for Windows.

• editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:

Add test support for Windows editing behavior.

• editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
• editing/style/make-text-writing-direction-inline-win.html: Added.
• editing/style/push-down-font-styles-win-expected.txt: Added.
• editing/style/push-down-font-styles-win.html: Added.
• editing/style/push-down-implicit-styles-around-list-win-expected.txt: Added.
• editing/style/push-down-implicit-styles-around-list-win.html: Added.
• editing/style/script-tests/make-text-writing-direction-inline-win.js: Added.
• editing/style/script-tests/push-down-font-styles-win.js: Added.
• editing/style/script-tests/push-down-implicit-styles-around-list-win.js: Added.

1:24 PM Changeset in webkit [148986] by zoltan@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
​https://bugs.webkit.org/show_bug.cgi?id=115053

Unreviewed gardening.

• platform/qt/TestExpectations: Skip failing tests.

1:17 PM Changeset in webkit [148985] by roger_fong@apple.com

• 4 edits in trunk/Source

AppleWin build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• WTF.vcproj/WTF.vcproj:

12:59 PM Changeset in webkit [148984] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Inline SelectorQuery::matches, SelectorQuery::queryAll, SelectorQuery::queryFirst
​https://bugs.webkit.org/show_bug.cgi?id=115012

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

Each of these function has a single call site:
-SelectorQuery::matches from Element::webkitMatchesSelector.
-SelectorQuery::queryAll from Node::querySelectorAll.
-SelectorQuery::queryFirst from Node::querySelector.

Having a dedicated method to jump to was a little overkill.

• dom/SelectorQuery.cpp:
• dom/SelectorQuery.h:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

12:51 PM Changeset in webkit [148983] by benjamin@webkit.org

• 1 edit
  7 deletes in trunk/Source/WebCore

Remove wxWebKit's folders from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=115007

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

• accessibility/wx/AccessibilityObjectWx.cpp: Removed.
• editing/wx/EditorWx.cpp: Removed.
• page/wx/DragControllerWx.cpp: Removed.
• page/wx/EventHandlerWx.cpp: Removed.
• platform/graphics/wx/ColorWx.cpp: Removed.
• platform/graphics/wx/FloatRectWx.cpp: Removed.
• platform/graphics/wx/FontCacheWx.cpp: Removed.
• platform/graphics/wx/FontCustomPlatformData.cpp: Removed.
• platform/graphics/wx/FontCustomPlatformData.h: Removed.
• platform/graphics/wx/FontPlatformData.h: Removed.
• platform/graphics/wx/FontPlatformDataWx.cpp: Removed.
• platform/graphics/wx/FontPlatformDataWxMac.mm: Removed.
• platform/graphics/wx/FontWx.cpp: Removed.
• platform/graphics/wx/GlyphMapWx.cpp: Removed.
• platform/graphics/wx/GradientWx.cpp: Removed.
• platform/graphics/wx/GraphicsContextWx.cpp: Removed.
• platform/graphics/wx/IconWx.cpp: Removed.
• platform/graphics/wx/ImageBufferDataWx.h: Removed.
• platform/graphics/wx/ImageBufferWx.cpp: Removed.
• platform/graphics/wx/ImageWx.cpp: Removed.
• platform/graphics/wx/IntPointWx.cpp: Removed.
• platform/graphics/wx/IntRectWx.cpp: Removed.
• platform/graphics/wx/IntSizeWx.cpp: Removed.
• platform/graphics/wx/PathWx.cpp: Removed.
• platform/graphics/wx/SimpleFontDataWx.cpp: Removed.
• platform/graphics/wx/TransformationMatrixWx.cpp: Removed.
• platform/image-decoders/wx/ImageDecoderWx.cpp: Removed.
• platform/wx/ClipboardWx.cpp: Removed.
• platform/wx/ClipboardWx.h: Removed.
• platform/wx/ContextMenuItemWx.cpp: Removed.
• platform/wx/ContextMenuWx.cpp: Removed.
• platform/wx/CursorWx.cpp: Removed.
• platform/wx/DragDataWx.cpp: Removed.
• platform/wx/DragImageWx.cpp: Removed.
• platform/wx/EventLoopWx.cpp: Removed.
• platform/wx/FileSystemWx.cpp: Removed.
• platform/wx/KeyEventWin.cpp: Removed.
• platform/wx/KeyboardEventWx.cpp: Removed.
• platform/wx/LanguageWx.cpp: Removed.
• platform/wx/LocalDC.h: Removed.
• platform/wx/LocalizedStringsWx.cpp: Removed.
• platform/wx/LoggingWx.cpp: Removed.
• platform/wx/MimeTypeRegistryWx.cpp: Removed.
• platform/wx/MouseEventWx.cpp: Removed.
• platform/wx/MouseWheelEventWx.cpp: Removed.
• platform/wx/PasteboardWx.cpp: Removed.
• platform/wx/PopupMenuWx.cpp: Removed.
• platform/wx/PopupMenuWx.h: Removed.
• platform/wx/RenderThemeWx.cpp: Removed.
• platform/wx/RunLoopWx.cpp: Removed.
• platform/wx/SSLKeyGeneratorWx.cpp: Removed.
• platform/wx/ScreenWx.cpp: Removed.
• platform/wx/ScrollViewWx.cpp: Removed.
• platform/wx/ScrollbarThemeWx.cpp: Removed.
• platform/wx/ScrollbarThemeWx.h: Removed.
• platform/wx/SearchPopupMenuWx.cpp: Removed.
• platform/wx/SearchPopupMenuWx.h: Removed.
• platform/wx/SharedBufferWx.cpp: Removed.
• platform/wx/SharedTimerWx.cpp: Removed.
• platform/wx/SoundWx.cpp: Removed.
• platform/wx/SystemTimeWx.cpp: Removed.
• platform/wx/TemporaryLinkStubs.cpp: Removed.
• platform/wx/TextBreakIteratorInternalICUWx.cpp: Removed.
• platform/wx/WidgetWx.cpp: Removed.
• platform/wx/wxcode/cairo/non-kerned-drawing.cpp: Removed.
• platform/wx/wxcode/fontprops.cpp: Removed.
• platform/wx/wxcode/fontprops.h: Removed.
• platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp: Removed.
• platform/wx/wxcode/gtk/fontprops.cpp: Removed.
• platform/wx/wxcode/gtk/non-kerned-drawing.cpp: Removed.
• platform/wx/wxcode/gtk/scrollbar_render.cpp: Removed.
• platform/wx/wxcode/mac/carbon/fontprops.mm: Removed.
• platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp: Removed.
• platform/wx/wxcode/mac/carbon/scrollbar_render.cpp: Removed.
• platform/wx/wxcode/non-kerned-drawing.h: Removed.
• platform/wx/wxcode/scrollbar_render.h: Removed.
• platform/wx/wxcode/win/fontprops.cpp: Removed.
• platform/wx/wxcode/win/non-kerned-drawing.cpp: Removed.
• platform/wx/wxcode/win/scrollbar_render.cpp: Removed.
• plugins/wx/PluginDataWx.cpp: Removed.

12:44 PM Changeset in webkit [148982] by roger_fong@apple.com

• 3 edits in trunk/Source/WebCore

AppleWin VS2010 build fix.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

12:29 PM WebKitGTK/2.0.x edited by kov@webkit.org

gcc-related build fixes (diff)

12:28 PM Changeset in webkit [148981] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Remove unused code of RefCounted after chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115009

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Ryosuke Niwa.

• wtf/RefCounted.h:

(WTF::RefCountedBase::refCount):
(RefCountedBase):
It looks like addressOfCount() is no longer needed.
Also change the type back to unsigned as it make more sense.

12:21 PM Changeset in webkit [148980] by benjamin@webkit.org

• 10 edits
  4 deletes in trunk/Tools

Remove wxWebKit support from the Tools
​https://bugs.webkit.org/show_bug.cgi?id=115005

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/config.h:
• DumpRenderTree/wscript: Removed.
• DumpRenderTree/wx/DumpRenderTreeWx.cpp: Removed.
• DumpRenderTree/wx/DumpRenderTreeWx.h: Removed.
• DumpRenderTree/wx/GCControllerWx.cpp: Removed.
• DumpRenderTree/wx/TestRunnerWx.cpp: Removed.
• DumpRenderTree/wx/WorkQueueItemWx.cpp: Removed.
• Scripts/build-dumprendertree:
• Scripts/build-jsc:

(buildMyProject):

• Scripts/build-webkit:
• Scripts/old-run-webkit-tests:
• Scripts/run-launcher:
• Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(determineConfigurationProductDir):
(determinePassedArchitecture):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):

• Scripts/webkitpy/common/config/contributionareas.py:
• waf/build/build_utils.py: Removed.
• waf/build/settings.py: Removed.
• waf/build/waf_extensions.py: Removed.
• waf/build/wxpresets.py: Removed.
• wx/browser/browser.cpp: Removed.
• wx/browser/wscript: Removed.
• wx/install-unix-extras: Removed.
• wx/packaging/build-debian-installer.py: Removed.
• wx/packaging/build-mac-installer.py: Removed.
• wx/packaging/build-win-installer.py: Removed.
• wx/packaging/debian/changelog: Removed.
• wx/packaging/debian/compat: Removed.
• wx/packaging/debian/control: Removed.
• wx/packaging/debian/copyright: Removed.
• wx/packaging/debian/python-webkitwx.install: Removed.
• wx/packaging/debian/rules: Removed.
• wx/packaging/wxWebKitInstaller.iss.in: Removed.

12:15 PM Changeset in webkit [148979] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

RetainPtr.h should compile with -Wshorten-64-to-32
<​http://webkit.org/b/115047>

Reviewed by Anders Carlsson.

Fixes the following warning:

RetainPtr.h:318:20: error: implicit conversion loses integer precision: 'CFHashCode' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

return CFHash(o.get());

• wtf/RetainPtr.h:

(WTF::RetainPtrObjectHash::hash): Cast return value of CFHash()
to unsigned. This has no effect on 32-bit architectures, but
takes the lower 32-bits of the CFHashCode (unsigned long) on
64-bit architectures, which is what happens implicitly now.

12:12 PM Changeset in webkit [148978] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
​https://bugs.webkit.org/show_bug.cgi?id=114952

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-23
Reviewed by Rob Buis.

Do not assume that Batch requests are only created whe input field
is focused, the Editor can also create Batch requests when pasting
a selection.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Remove invalid assert.

12:09 PM Changeset in webkit [148977] by commit-queue@webkit.org

• 7 edits
  3 deletes in trunk/LayoutTests

Remove fast/js/i18n-bindings-locale.html
​https://bugs.webkit.org/show_bug.cgi?id=115024

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-23
Reviewed by Geoffrey Garen.

Remove V8-i18n-extension test(r78095) from all ports.

• fast/js/i18n-bindings-locale-expected.txt: Removed.
• fast/js/i18n-bindings-locale.html: Removed.
• fast/js/script-tests/i18n-bindings-locale.js: Removed.
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:

11:57 AM Changeset in webkit [148976] by roger_fong@apple.com

• 4 edits in trunk/Source/WebCore

AppleWin build fix.

• inspector/InspectorAllInOne.cpp:
• inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::create):
(WebCore):

• inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

11:23 AM Changeset in webkit [148975] by zoltan@webkit.org

• 17 edits
  2 adds in trunk

[CSS Exclusions] shape-inside overflow should be pushed to the outside of the content box
​https://bugs.webkit.org/show_bug.cgi?id=114526

Reviewed by David Hyatt.

Source/WebCore:

The specification has changed to define shape-outside as the inverse of an exclusion. Overflowing content
should not overlap the shape, and it should be pushed outside the content box. This change affects several
tests, but only one new has been added. In this change I'm not intended to include the behavior change for
shape-inside on CSS Regions, I'm going to fix that in a follow up patch.

Tests: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Modified.

fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified.
fast/exclusions/shape-inside/shape-inside-empty.html: Modified.
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
fast/exclusions/shape-inside/shape-inside-overflow.html: Modified.
fast/exclusions/shape-inside/shape-inside-percentage.html: Modified.
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Modified.

• rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::clearSegments): Shape-outside's code uses shape-inside codepaths, when that happens we need to provide a
way to reset the m_segments member.
(WebCore::ExclusionShapeInfo::shapeContainingBlockHeight): The containing block's height is stored in m_shapeLogicalHeight, I added a
function to get this value when we need it to calculate the content box's bottom position.
(ExclusionShapeInfo):
(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds):
(WebCore::ExclusionShapeInfo::lineWithinShapeBounds): Add function to test whether a whole line is within a shape or not.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Overflowing content should start under the content box.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Since we use shape-inside codepaths for shape-outside in layoutRunsAndFloatsInRange function
and for shape-outside is not a requirement to check the line's bottom position is within the shape we might end up with some extra segments here.
In this case we should clear segments, since we don't want to apply any horizontal offsets on the overflowing content.

LayoutTests:

Update and add tests for the new behavior.

• fast/exclusions/resources/rounded-rectangle.js:

(generateString): Modify the function to not generate overflow content.

• fast/exclusions/shape-inside/shape-inside-bottom-edge-expected.html:
• fast/exclusions/shape-inside/shape-inside-bottom-edge.html:
• fast/exclusions/shape-inside/shape-inside-empty-expected.html:
• fast/exclusions/shape-inside/shape-inside-empty.html:
• fast/exclusions/shape-inside/shape-inside-overflow-expected.html:
• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
• fast/exclusions/shape-inside/shape-inside-overflow.html:
• fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
• fast/exclusions/shape-inside/shape-inside-percentage.html:
• fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
• fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
• fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html:
• fast/regions/shape-inside/shape-inside-on-additional-regions.html: This test is not intented to test the overflow behavior from

shape-inside on regions, so I set the shape's height to the container's height.

11:00 AM Changeset in webkit [148974] by mhahnenberg@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Objective-C API: Update public header documentation
​https://bugs.webkit.org/show_bug.cgi?id=114841

Reviewed by Geoffrey Garen.

Added documentation for the newly added object lifetime-related stuff.

• API/JSManagedValue.h:
• API/JSVirtualMachine.h:

10:50 AM Changeset in webkit [148973] by robert@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

checkLayout() should error out if no data-expected* attributes were found
​https://bugs.webkit.org/show_bug.cgi?id=114900

Reviewed by Ojan Vafai.

If checkLayout() doesn't find any attributes checking the node's layout then error out
instead of assuming the test has passed. This will ensure data-* attributes containing
typos don't register as a pass.

• fast/check-layout-error-no-attributes-expected.txt: Added.
• fast/check-layout-error-no-attributes.html: Added.
• resources/check-layout.js:

(.):

10:08 AM Changeset in webkit [148972] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Simplify BackForwardListBlackBerry::clear
​https://bugs.webkit.org/show_bug.cgi?id=115029

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.

Simplify the implementation of the clear method. Instead of asking
the WebCore implementation to search each item and delete it, set
the capacity of the list to zero directly, which will do the same
thing but more efficiently.

No change in behavior, no new tests.

• WebCoreSupport/BackForwardListBlackBerry.cpp:

(WebCore::BackForwardListBlackBerry::clear):

9:20 AM Changeset in webkit [148971] by zeno.albisser@digia.com

• 2 edits in trunk/Tools

[Qt] Fix test_build_check for Qt on Mac after r148075.
​https://bugs.webkit.org/show_bug.cgi?id=115038

Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_build_check):

run-webkit-tests is supposed to fail, if it is run on a different
platform than specified on the command line.
However, Qt allows exactly this for Qt-platforms to allow comparing
of test results of different baselines.
Before r148075 "chromium-linux-x86" was used for testing.
This patch changes the port_name to gtk when running the test on mac.

9:13 AM Changeset in webkit [148970] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Avoid computing style twice when element has no existing style
​https://bugs.webkit.org/show_bug.cgi?id=115042

Reviewed by Andreas Kling.

We currently compute element style twice if we end up having to reattach, first in recalcStyle and then
again during attach(). We can easily avoid this in common case where the element has no existing style
(usually because it is display:none).

• dom/Element.cpp:

(WebCore::Element::recalcStyle):

Don't compute the style and diff if there is no existing style. There is nothing to diff against.
Instead just call reattach() directly, we ended up doing that anyway with the existing code.

9:03 AM Changeset in webkit [148969] by commit-queue@webkit.org

• 5 edits in trunk

[BlackBerry] Do not access BackForwardListImpl from DRT
​https://bugs.webkit.org/show_bug.cgi?id=115041

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.

Source/WebKit/blackberry:

Export the necessary functionality in our BackForwardList port
client in order for DRT to work.

• WebCoreSupport/BackForwardListBlackBerry.cpp:

(WebCore::BackForwardListBlackBerry::backListWithLimit):
(WebCore):
(WebCore::BackForwardListBlackBerry::forwardListWithLimit):
(WebCore::BackForwardListBlackBerry::capacity):

• WebCoreSupport/BackForwardListBlackBerry.h:

(BackForwardListBlackBerry):

Tools:

Use the right class to access the bflist functionality.

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::dumpBackForwardListForWebView):

8:53 AM Changeset in webkit [148968] by commit-queue@webkit.org

• 11 edits in trunk

WebSocket: Return type of send() should be void if hybi-10 protocol is chosen
​https://bugs.webkit.org/show_bug.cgi?id=65850

Patch by Lamarque V. Souza <​Lamarque.Souza@basyskom.com> on 2013-04-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

WebSocket API draft changed the return type of send() from boolean to void based on Simon
Pieters' post to WHATWG. Firefox 8 and IE 10 already follow the specification, hence it should
make sense for us to do the same when hybi protocol is used.

Original patch by Yuta Kitamura <​yutak@chromium.org>

Tests: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

http/tests/websocket/tests/hybi/send-after-close-on-unload.html (updated)

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

• Modules/websockets/WebSocket.h:
• Modules/websockets/WebSocket.idl:

LayoutTests:

Update tests and test results because WebSocket.send() now returns undefined when
the hybi WebSocket protocol is used.

• http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
• http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt:
• http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
• http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
• http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
• http/tests/websocket/tests/hybi/send-after-close-on-unload.html:

8:11 AM Changeset in webkit [148967] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

ScrollbarThemeComposite depends on Page/FrameView/ChromeClient
​https://bugs.webkit.org/show_bug.cgi?id=21361

Reviewed by Andreas Kling.

Remove unused header includes.

• platform/ScrollbarThemeComposite.cpp:

8:08 AM Changeset in webkit [148966] by Carlos Garcia Campos

• 16 edits in trunk

[GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=112160

Reviewed by Andreas Kling.

Source/WebCore:

• platform/network/soup/GOwnPtrSoup.cpp:

(WTF::SoupMessageHeaders): Add freeOwnedGPtr implementation for
SoupMessageHeaders.
(WTF):

• platform/network/soup/GOwnPtrSoup.h:

(WTF):

• platform/network/soup/ResourceRequest.h:

(ResourceRequest):

• platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageHeaders): New function
to update the given SoupMessageHeaders with the ResourceRequest
headers.
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): New
function to update the ResourceRequest headers with the given
SoupMessageHeaders.
(WebCore::ResourceRequest::updateSoupMessage): Use
updateSoupMessageHeaders() to update the headers.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage): Use
updateFromSoupMessageHeaders to update the headers.

Source/WebKit2:

It allows to load requests with custom headers, or to update the
headers of a request before being sent to the server in the
WebKitWebPage::send-request callback.

• UIProcess/API/gtk/WebKitURIRequest.cpp:

(_WebKitURIRequestPrivate): Add SoupMessageHeaders.
(webkit_uri_request_get_http_headers): Return the HTTP headers of
the request as a SoupMessageHeaders if the request is HTTP. A new
SoupMessageHeaders is created on demand using the existing headers
of the request.
(webkitURIRequestGetResourceRequest): Instead of returning a const
reference of the internal ResourceRequest, set a request passed as
a reference and update its HTTP headers using the
SoupMessageHeaders if present.

• UIProcess/API/gtk/WebKitURIRequest.h:
• UIProcess/API/gtk/WebKitURIRequestPrivate.h:
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Update to the new
webkitURIRequestGetResourceRequest API.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

webkit_uri_request_get_http_headers symbol.

• UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(testWebPageURI):
(testURIRequestHTTPHeaders):
(serverCallback):
(beforeAll):

• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Update to the new
webkitURIRequestGetResourceRequest API.

Tools:

• MiniBrowser/gtk/GNUmakefile.am: Add missing libsoup flags to

CPPFLAGS.

7:55 AM Changeset in webkit [148965] by akling@apple.com

• 3 edits
  2 adds in trunk

Clear StyleResolver state before returning from styleForElement().
<​http://webkit.org/b/115035>

Reviewed by Antti Koivisto.

From Blink r148687 by <​inferno@chromium.org>.

Source/WebCore:

A cached element pointer in the resolver state was causing confusion because
in some cases a subsequent call to styleForElement() would use a pointer to
a different object that is at the same memory address as the previous one.

Test: fast/css/reload-non-styled-element-crash.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):

LayoutTests:

• fast/css/reload-non-styled-element-crash-expected.txt: Added.
• fast/css/reload-non-styled-element-crash.html: Added.

7:54 AM Changeset in webkit [148964] by akling@apple.com

• 4 edits in trunk/Source/WebCore

XSSAuditor performance regression due to threaded parser changes.
<​http://webkit.org/b/115037>
<rdar://problem/13716069>

Reviewed by Anders Carlsson.

From Blink r148792 by <​abarth@chromium.org>:

The refactoring we did for the threaded parser introduced a performance
regression in innerHTML because we'd boot up the XSSAuditor for fragment
parsing. This CL returns to our earlier behavior of not booting up the
XSSAuditor when parsing fragments.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::initForFragment):

• html/parser/XSSAuditor.h:

(XSSAuditor):

7:45 AM Changeset in webkit [148963] by mikhail.pozdnyakov@intel.com

• 7 edits
  6 moves
  5 adds in trunk

[WK2] Make EFL WKView API shareable between ports
​https://bugs.webkit.org/show_bug.cgi?id=114734

Reviewed by Anders Carlsson.

Source/WebKit2:

EFL-independent part of WKView API (and its implementation) is now
shareable between ports that use Coordinated Graphics and put to
CoordinatedGraphics folders.

• PlatformEfl.cmake:
• UIProcess/API/C/CoordinatedGraphics/WKView.cpp: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.cpp.

(WKViewCreate):
(WKViewInitialize):
(WKViewGetSize):
(WKViewSetSize):
(WKViewSetViewClient):
(WKViewIsFocused):
(WKViewSetIsFocused):
(WKViewIsVisible):
(WKViewSetIsVisible):
(WKViewGetContentScaleFactor):
(WKViewSetContentScaleFactor):
(WKViewGetContentPosition):
(WKViewSetContentPosition):
(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewGetPage):
(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):
(WKViewExitFullScreen):

• UIProcess/API/C/CoordinatedGraphics/WKView.h: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.h.
• UIProcess/API/C/efl/WKViewEfl.cpp: Added.

(WKViewPaintToCairoSurface):
(WKViewCreateSnapshot):

• UIProcess/API/C/efl/WKViewEfl.h: Added.
• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

• UIProcess/API/efl/EwkView.h:
• UIProcess/CoordinatedGraphics/WebView.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebView.cpp.

(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setSize):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):
(WebKit::WebView::setUserViewportTranslation):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::setShowsAsSource):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
(WebKit::WebView::initializeClient):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::dipSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

• UIProcess/CoordinatedGraphics/WebView.h: Renamed from Source/WebKit2/UIProcess/efl/WebView.h.

(WebCore):
(WebKit):
(WebView):
(WebKit::WebView::size):
(WebKit::WebView::isFocused):
(WebKit::WebView::isVisible):
(WebKit::WebView::setContentScaleFactor):
(WebKit::WebView::contentScaleFactor):
(WebKit::WebView::setContentPosition):
(WebKit::WebView::contentPosition):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):

• UIProcess/CoordinatedGraphics/WebViewClient.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.cpp.

(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):
(WebKit::WebViewClient::webProcessCrashed):
(WebKit::WebViewClient::webProcessDidRelaunch):
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit::WebViewClient::didChangeTooltip):

• UIProcess/CoordinatedGraphics/WebViewClient.h: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.h.

(WebCore):
(WebKit):

• UIProcess/efl/WebViewEfl.cpp: Added.

(WebKit):
(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):
(WebKit::WebViewEfl::setEwkView):
(WebKit::WebViewEfl::paintToCairoSurface):
(WebKit::WebViewEfl::createPopupMenuProxy):
(WebKit::WebViewEfl::createContextMenuProxy):
(WebKit::WebViewEfl::setCursor):
(WebKit::WebViewEfl::updateTextInputState):
(WebKit::WebViewEfl::handleDownloadRequest):

• UIProcess/efl/WebViewEfl.h: Added.

(WebKit):
(WebViewEfl):
(WebKit::WebViewEfl::ewkView):

Tools:

• TestWebKitAPI/PlatformEfl.cmake:
• WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

Updated project files accordingly to updated WKView API files
structure.

7:23 AM Changeset in webkit [148962] by akling@apple.com

• 2 edits in trunk/Tools

Add Benjamin Poulain's @apple.com address to his entry. Unreviewed.

• Scripts/webkitpy/common/config/contributors.json:

7:21 AM Changeset in webkit [148961] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Speed up ElementData::getAttributeItem(), which is hot.
<​http://webkit.org/b/115031>

Reviewed by Antti Koivisto.

From Blink r148622 by <​cevans@chromium.org>.

The previous version had a couple of issues:

• Incurred new WTF::Vector::operator[] checks.
• Had a branch in _every_ loop iteration that checked whether the storage was Vector or array[] backed.

Both these issues are fixed, and CloneNodes.html seems reliably at +2%.
I also believe GetElement.html is maybe +1%.

For WebKit, also applied the same optimization to getAttributeItemIndex().

• dom/Element.h:

(WebCore::ElementData::attributeBase):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):

5:07 AM Changeset in webkit [148960] by allan.jensen@digia.com

• 1 edit
  4 adds in trunk/LayoutTests

Baselines for fast/css/image-rendering.html

Unreviewed gardening.

• fast/css/image-rendering-expected.png: Added.
• fast/css/image-rendering-expected.txt: Added.
• platform/gtk-wk1/fast/css/image-rendering-expected.txt: Added.

4:58 AM Changeset in webkit [148959] by charles.wei@torchmobile.com.cn

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need to send out change event for date/color picker
​https://bugs.webkit.org/show_bug.cgi?id=114942

Reviewed by Carlos Garcia Campos.

We need to instruct the FormControlElements to send out 'change' event
when the user makes the selection and closes the PagePopup for date/color.

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::setValueAndClosePopup):

• WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

3:29 AM Changeset in webkit [148958] by allan.jensen@digia.com

• 1 edit
  1 delete in trunk/LayoutTests

Remove the text expecation again to force the bots to fail and generate png expectations.

Unreviewed ungardening.

• fast/css/image-rendering-expected.txt: Removed.

3:00 AM Changeset in webkit [148957] by zandobersek@gmail.com

• 20 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148944.

• platform/gtk/TestExpectations:
• platform/gtk/fast/table/giantRowspan-expected.txt:
• platform/gtk/fast/table/giantRowspan2-expected.png:
• platform/gtk/fast/table/giantRowspan2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug133756-2-expected.png:
• platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
• platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
• platform/gtk/tables/mozilla/core/bloomberg-expected.png:
• platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
• platform/gtk/tables/mozilla/core/row_span-expected.png:
• platform/gtk/tables/mozilla/core/row_span-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:

2:50 AM Changeset in webkit [148956] by Antoine Quint

• 23 edits
  2 adds in trunk

Initial advance of text runs should be taken into account
​https://bugs.webkit.org/show_bug.cgi?id=114949

Reviewed by Darin Adler.

Source/WebCore:

Keep track of complex text runs' initial advance by adding a new
member to GlyphBuffer and adding the initial advance of any non-first
text run to the advance of the last glyph added for the previous text run.
Additionally, we now correctly handle advance values in the y-axis.

Test: fast/text/complex-initial-advance.html

• WebCore.exp.in:

Add support for new WebKitSystemInterface API.

• platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):
Take into account the buffer's initial advance in the y-axis to adjust
the point at which to draw the buffers. Additionally, keep track of advances
on the y-axis as well as the x-axis (which we already were doing) as we iterate
through glyphs and adjust the start point.
(WebCore::Font::drawEmphasisMarks):
Adopt change of GlyphBuffer::advanceAt() return type.

• platform/graphics/GlyphBuffer.h:

Removing the WINCE-specific GlyphBufferAdvance struct since heights are now necessary.
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
New default constructor for GlyphBufferAdvance to support the m_initialAdvance member.
(WebCore::GlyphBuffer::setInitialAdvance):
(WebCore::GlyphBuffer::initialAdvance):
New APIs to get and set the initial advance for a glyph buffer.
(WebCore::GlyphBuffer::advanceAt):
Return a GlyphBufferAdvance rather than a float which used to be only
the glyph buffer's x-axis advance. This is necessary to handle deltas
on the y-axis as well (see WebCore::Font::drawGlyphBuffer).

• platform/graphics/GlyphBuffer.h:

(GlyphBuffer):
(WebCore::GlyphBuffer::setInitialAdvance):

• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):
Adopt change of GlyphBuffer::advanceAt() return type.

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):
When processing the first text run, set that run's initial advance as
the glyph buffer's initial advance.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Represent the initial advance for a text run by adjusting the advance
of the last glyph of the previous text run in the glyph buffer.

• platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::initialAdvance):
(ComplexTextRun):
New API to read the inital advance of a complex text run.

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Obtain the text run's initial advance via the new wkCTRunGetInitialAdvance
WebKitSystemInterface API.

• platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

Add support for the new wkCTRunGetInitialAdvance WebKitSystemInterface API.

• platform/wx/wxcode/cairo/non-kerned-drawing.cpp:

(WebCore::drawTextWithSpacing):
Adopt change of GlyphBuffer::advanceAt() return type.

• rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

Source/WebKit/mac:

Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

LayoutTests:

• fast/text/complex-initial-advance-expected.html: Added.
• fast/text/complex-initial-advance.html: Added.

2:42 AM Changeset in webkit [148955] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for two DOM4 constructors tests

that started failing after enabling the subpixel layout due to LayoutUnit overflows.

2:05 AM Changeset in webkit [148954] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=115013

Remove editing/selection/doubleclick-whitespace-crash.html and
editing/selection/doubleclick-whitespace-img-crash.html from TestExpectations
after r144221.

Unreviewed, EFL gardening.

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-04-23

• platform/efl-wk2/TestExpectations:

2:02 AM Changeset in webkit [148953] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[Texmap] Don't paint to an intermediate surface when the result is going to be clipped out completely.
​https://bugs.webkit.org/show_bug.cgi?id=115015

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Allan Sandfeld Jensen.

Maintain a clipBounds rectangle in TextureMapper, and test it against the bounds of an intermediate
surface before it is painted.
This allows us to opt out completely of painting into the surface if the result is going to be optimized
out by the GPU clipping.

Covered by tests in compositing/overlap-blending.

• platform/graphics/texmap/TextureMapper.h:

(TextureMapper):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clipBounds):
(WebCore):

• platform/graphics/texmap/TextureMapperGL.h:
• platform/graphics/texmap/TextureMapperImageBuffer.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

1:58 AM Changeset in webkit [148952] by commit-queue@webkit.org

• 8 edits in trunk/Source

[Coordinated Graphics] Remove the lockAnimations code path
​https://bugs.webkit.org/show_bug.cgi?id=114899

Source/WebCore:

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.

Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.

No new tests, removing functionality that wasn't tested in the first place.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::commitSceneState):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.

• UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
• UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

1:33 AM Changeset in webkit [148951] by allan.jensen@digia.com

• 3 edits in trunk/Source/WebKit/qt

[Qt][WK1] MemoryCache is not cleaned by default
​https://bugs.webkit.org/show_bug.cgi?id=111443

Reviewed by Jocelyn Turcotte.

Enable deletion of dead resources in the memory cache as long as the MemoryCache is enabled.

This can be disabled or tuned using the dynamic property "_q_deadDecodedDataDeletionInterval".
The default is set to match that of most other ports and WK2 with cache in WebBrowsing mode.

• Api/qwebsettings.cpp:

(QWebSettings::setObjectCacheCapacities):

• WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

1:31 AM Changeset in webkit [148950] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Changing failure mark to skip after r148948.

• platform/qt/TestExpectations:

1:17 AM Changeset in webkit [148949] by allan.jensen@digia.com

• 11 edits
  3 moves
  7 adds
  3 deletes in trunk

Respect image-rendering setting for determing image-rendering quality
​https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the CSS4 values as they are not ready for implementation yet.
We still parse the -webkit-crisp-edges and SVG compatibility values to
be closer to the the partial support in Gecko and Presto.

Tests: fast/css/image-rendering-canvas.html

fast/css/image-rendering-parsing.html
fast/css/image-rendering.html
fast/css/optimize-contrast-image.html

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):

• css/CSSValueKeywords.in:
• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

• rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

• rendering/style/RenderStyleConstants.h:

Tools:

Remove CSS4 Images option. It is not ready for implementation.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Moved the two tests of image-rendering out of CSS3 since it was removed from the final recommendation.
Added tests of the supported values, and upgraded one test to a reference test so that it now tests
that -webkit-optimize-contrast gets converted to and treated as -webkit-crisp-edges.

Baselines for fast/css/image-rendering.html will be uploaded later when the bots have generated them.

• css3/images/optimize-contrast-image-expected.png: Removed.
• css3/images/optimize-contrast-image-expected.txt: Removed.
• fast/css/image-rendering-canvas-expected.png: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.png.
• fast/css/image-rendering-canvas-expected.txt: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.txt.
• fast/css/image-rendering-canvas.html: Renamed from LayoutTests/css3/images/optimize-contrast-canvas.html.
• fast/css/image-rendering-expected.txt: Added.
• fast/css/image-rendering-parsing-expected.txt: Added.
• fast/css/image-rendering-parsing.html: Renamed from LayoutTests/fast/css/image-set-parsing.html.
• fast/css/image-rendering.html: Added.
• fast/css/optimize-contrast-image-expected.html: Added.
• fast/css/optimize-contrast-image.html: Renamed from LayoutTests/css3/images/optimize-contrast-image.html.
• fast/css/script-tests/image-rendering-parsing.js: Added.

(testImageRendering):

1:07 AM Changeset in webkit [148948] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/TestExpectations:

12:48 AM Changeset in webkit [148947] by rniwa@webkit.org

• 3 edits
  3 deletes in trunk

Unreviewed, rolling out r148923.
​http://trac.webkit.org/changeset/148923
​https://bugs.webkit.org/show_bug.cgi?id=115020

The patch causes multiple failures in CSS, canvas tests
(Requested by zdobersek on #webkit).

Source/WebCore:

• platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

LayoutTests:

• fast/canvas/script-tests/shadow-image.js: Removed.
• fast/canvas/shadow-image-expected.txt: Removed.
• fast/canvas/shadow-image.html: Removed.

12:01 AM Changeset in webkit [148946] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several test cases that are no longer crashing after r148945.

• platform/efl/TestExpectations: