Timeline
Aug 23, 2009:
- 11:00 PM Changeset in webkit [47698] by
-
- 6 edits in trunk/WebCore
2009-08-23 Dirk Schulze <krit@webkit.org>
Reviewed by Mark Rowe.
Code clean-up and build fix for filters enabled builds. Moved SVGNames.h
into #if ENABLE(SVG) for Document.cpp and added SVGNames.h to the other
files. They are needed there after r47688.
- dom/Document.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- 8:44 PM Changeset in webkit [47697] by
-
- 8 edits in trunk
WebCore:
2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed, build fix for make distcheck on GTK+.
- GNUmakefile.am: Added files needed for the build.
- bindings/js/JSDOMWindowCustom.cpp: Protect SharedWorker include with #if clause.
- bindings/js/JSEventTarget.cpp: Dito.
- dom/Document.cpp: Dito.
- loader/FrameLoader.cpp: Dito.
2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed build fix for make distcheck.
- GNUmakefile.am: Added files required for the build.
- 2:42 PM Changeset in webkit [47696] by
-
- 3 edits in trunk/WebCore
2009-08-23 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: Throws an Error on "null"
https://bugs.webkit.org/show_bug.cgi?id=28665
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate):
- 12:49 PM Changeset in webkit [47695] by
-
- 2 edits in trunk/WebCore
2009-08-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often
- inspector/front-end/InjectedScript.js: (InjectedScript.getProperties): (InjectedScript.createProxyObject):
- 12:24 PM Changeset in webkit [47694] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update editing-behavior property here too.
- webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
- 10:04 AM Changeset in webkit [47693] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Gustavo Noronha.
Fix regressions introduced by http://trac.webkit.org/changeset/47690.
Update the setting whenever the property gets set.
- webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
- 3:08 AM Changeset in webkit [47692] by
-
- 2 edits in trunk/WebKitTools
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663
Enable this setting for DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 2:05 AM Changeset in webkit [47691] by
-
- 2 edits in trunk/LayoutTests
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip new tests from
http://trac.webkit.org/changeset/47678 and the appcache HTTP
authentication tests (https://bugs.webkit.org/show_bug.cgi?id=28668)
- platform/gtk/Skipped:
- 1:45 AM Changeset in webkit [47690] by
-
- 3 edits in trunk/WebKit/gtk
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663
Add a setting to enable or disable file access to web URLs. It's
disabled by default for security reasons.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 12:18 AM Changeset in webkit [47689] by
-
- 2 edits in trunk/WebCore
2009-08-22 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly
https://bugs.webkit.org/show_bug.cgi?id=28345
When doing the conversion between cairo_surface_t* and GdkPixbuf*
account for the differences in the respective formats' in-memory
image format.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel): (WebCore::BitmapImage::getGdkPixbuf):
Aug 22, 2009:
- 11:55 PM Changeset in webkit [47688] by
-
- 43 edits in trunk/WebCore
Make DOM classes start with a reference count of 1, like all other RefCounted
Patch by Darin Adler <Darin Adler> on 2009-08-22
Reviewed by Oliver Hunt.
Next step: Element, HTMLElement, HTMLAnchorElement, HTMLAppletElement,
HTMLAreaElement, HTMLEmbedElement, HTMLFrameElement, HTMLIFrameElement,
HTMLObjectElement, HTMLPlugInElement, HTMLPlugInImageElement.
- DerivedSources.make: Fix error seen every time we build by escaping the $
in the build rule, since you have to use $$ for that in make.
- WebCore.base.exp: Updated.
- bindings/objc/DOM.mm:
Added now-needed include of SVGNames.h.
- dom/Document.cpp: Added now-needed include of SVGNames.h.
(WebCore::Document::createElement): Use create instead of new.
- dom/Element.cpp:
(WebCore::Element::Element): Added ConstructionType argument so the caller
can determine whether this starts with a reference count of either 0 or 1.
Later we will remove this again once they are all 1.
(WebCore::Element::create): Added.
- dom/Element.h: Added create and made constructor protected.
- dom/StyledElement.cpp:
(WebCore::StyledElement::StyledElement): Added ConstructionType argument.
- dom/StyledElement.h: Made many functions protected or private, including
the constructor.
- dom/make_names.pl: Use create to create the base elements HTMLElement,
SVGElement, and WMLElement.
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply): Use create instead of new.
- editing/UnlinkCommand.cpp:
(WebCore::UnlinkCommand::doApply): Ditto.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::create): Added.
- html/HTMLAnchorElement.h: Made constructor protected and added create.
Also made m_rootEditableElementForSelectionOnMouseDown a RefPtr.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::create): Added.
- html/HTMLAppletElement.h: Made constructor private and added create.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::create): Added.
- html/HTMLAreaElement.h: Made constructor private and added create.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::create): Added.
- html/HTMLElement.h: Made constructor protected and added create.
Made other functions protected and private. Also added inline
definition of constructor.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::create): Added.
- html/HTMLEmbedElement.h: Made constructor private and added create.
Made other functions private.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::create): Added.
(WebCore::HTMLFrameElement::parseMappedAttribute):
- html/HTMLFrameElement.h: Made constructor private and added create.
Made other functions private.
- html/HTMLFrameElementBase.h: Made functions protected and private.
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Pass
CreateElement so reference count starts at 1.
- html/HTMLFrameOwnerElement.h: Made functions protected and private.
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::create): Added.
- html/HTMLIFrameElement.h: Made constructor private and added create.
Made other functions private.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::create): Added.
(WebCore::HTMLObjectElement::containsJavaApplet): Changed while loop
into a for loop and tweaked formatting.
- html/HTMLObjectElement.h: Made constructor private and added create.
Made other functions private.
- html/HTMLPlugInElement.h: Made constructor protected.
Made other functions protected and private.
- html/HTMLPlugInImageElement.h: Made constructor and another function
protected.
- html/HTMLTagNames.in: Removed createWithNew from all classes that
now have create functions. Moved conditional noscript to a separate
paragraph.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use create.
(WebCore::HTMLViewSourceDocument::addLink): Ditto.
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Ditto.
- svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::SVGElement::create): Added.
- svg/SVGElement.h: Added create, made constructor protected, and
made other functions protected and private. Removed unneeded
SVGNames.h include.
- svg/SVGExternalResourcesRequired.h: Added now-needed SVGNames.h
include.
- svg/SVGStopElement.h: Added now-needed SVGNames.h include.
Made functions private.
- wml/WMLElement.cpp:
(WebCore::WMLElement::WMLElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::WMLElement::create): Added.
- wml/WMLElement.h: Added create and made constructor protected.
- wml/WMLTagNames.in: Removed createWithNew from WMLElement.
- 11:36 PM Changeset in webkit [47687] by
-
- 6 edits in trunk/WebKit/gtk
2009-08-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=28154
clicking below end of text in a textarea moves cursor to wrong position
Expose the EditingBehavior setting and set it by default to Mac,
since that what matches the GTK+ default behavior.
- webkit/webkitprivate.cpp: (WebKit::core):
- webkit/webkitprivate.h:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebsettings.h:
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 10:04 PM Changeset in webkit [47686] by
-
- 2 edits in trunk/JavaScriptCore
REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=28655
Reviewed by Mark Rowe.
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction): Initialize properly with a VPtrHackExecutable.
- wtf/Platform.h:
- 9:43 PM Changeset in webkit [47685] by
-
- 11 edits in trunk
WebKit/mac: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.
Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
- Misc/WebKitVersionChecks.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
WebKit/qt: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.
Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
WebKit/win: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.
Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
WebKitTools: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.
Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- 9:24 PM Changeset in webkit [47684] by
-
- 11 edits in trunk
2009-08-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- Misc/WebKitVersionChecks.m:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
2009-08-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
2009-08-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
2009-08-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 5:48 PM Changeset in webkit [47683] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:47 PM Changeset in webkit [47682] by
-
- 1 copy in tags/Safari-6531.16
New tag.
- 5:47 PM Changeset in webkit [47681] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r47679.
- 5:47 PM Changeset in webkit [47680] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47663.
- 5:43 PM Changeset in webkit [47679] by
-
- 3 edits in trunk/WebCore
Fix for <rdar://problem/7161656> Crash in RenderObject::destroy when using custom scrollbars
Reviewed by Anders Carlsson.
Custom scrollbars normally get detached when a document gets detached. In this case, a crash was happening when the document had gone into the page cache
and then was getting destroyed without proper scrollbar teardown. This change makes custom scrollbars get detached when the document enters the cache.
I couldn't figure out a way to reliably cause this to happen in DRT, since the reproducible case relies on the cache being purged at a particular time.
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Detach custom scrollbars when the CachedFrame is created. They'll get reattached when the document comes out of the page cache.
- page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added some asserts to catch this problem earlier in debug builds.
- 4:26 PM Changeset in webkit [47678] by
-
- 4 edits74 adds in trunk
WebCore: Make sure self-collapsing blocks that clear floats are still able to collapse their bottom margins with
the bottom of their parent blocks. The old code prevented all collapsing, but all CSS2.1 states is that:
"An element that has had clearance applied to it never collapses its top margin with its parent block's bottom margin."
Reviewed by Dan Bernstein.
The implication is that the bottom margin can still collapse, and the block-inside-inline form of
fast/block/margin-collapse/025.html (added as fast/block/margin-collapse/block-inside-inline/025.html) depends
on it to get comparable results.
Added block-inside-inline tests (a whole slew of them) in fast/block/margin-collapse/block-inside-inline/
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::handleBottomOfBlock):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::canCollapseBottomWithChildren):
LayoutTests: Add a bunch of tests for the block-inside-inline cases of margin-collapsing. The same test
suite but converted to wrap all the blocks inside inlines to make sure they still collapse
the same way.
Reviewed by Dan Bernstein.
- fast/block/margin-collapse/block-inside-inline: Added.
- fast/block/margin-collapse/block-inside-inline/001.html: Added.
- fast/block/margin-collapse/block-inside-inline/002.html: Added.
- fast/block/margin-collapse/block-inside-inline/003.html: Added.
- fast/block/margin-collapse/block-inside-inline/004.html: Added.
- fast/block/margin-collapse/block-inside-inline/005.html: Added.
- fast/block/margin-collapse/block-inside-inline/006.html: Added.
- fast/block/margin-collapse/block-inside-inline/010.html: Added.
- fast/block/margin-collapse/block-inside-inline/011.html: Added.
- fast/block/margin-collapse/block-inside-inline/012.html: Added.
- fast/block/margin-collapse/block-inside-inline/015.html: Added.
- fast/block/margin-collapse/block-inside-inline/016.html: Added.
- fast/block/margin-collapse/block-inside-inline/017.html: Added.
- fast/block/margin-collapse/block-inside-inline/018.html: Added.
- fast/block/margin-collapse/block-inside-inline/019.html: Added.
- fast/block/margin-collapse/block-inside-inline/020.html: Added.
- fast/block/margin-collapse/block-inside-inline/021.html: Added.
- fast/block/margin-collapse/block-inside-inline/022.html: Added.
- fast/block/margin-collapse/block-inside-inline/025.html: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.checksum: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
- 3:56 PM Changeset in webkit [47677] by
-
- 4 edits1 add in trunk/WebKitTools
Bring signed updates to the Mac nightly builds.
Rubber-stamped by Anders Carlsson.
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
- WebKitLauncher/nightly.webkit.org.public.pem: Added.
- 10:54 AM Changeset in webkit [47676] by
-
- 1 edit1 copy1 move in trunk/LayoutTests
Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606
Fixing LayoutTest bustage.
The SnowLeopard results are the latest, so they need to move to platform/mac
The Tiger/Leopard results will default to the SnowLeopard results, so we need to move
the current test from platform/mac to platform/mac-leopard
- platform/mac-leopard/accessibility/aria-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-roles-expected.txt.
- platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Removed.
- platform/mac/accessibility/aria-roles-expected.txt: Replaced with LayoutTests/platform/mac-snowleopard/accessibility/aria-roles-expected.txt.
- 10:03 AM Changeset in webkit [47675] by
-
- 5 edits4 adds in trunk
WebCore: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606
Reviewed by Darin Adler.
Test: platform/mac-snowleopard/accessibility/aria-list-and-listitem.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isUnorderedList):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
LayoutTests: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606
Reviewed by Darin Adler.
Also added a SnowLeopard specific result for aria-roles-expected.
- platform/mac-snowleopard/accessibility: Added.
- platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt: Added.
- platform/mac-snowleopard/accessibility/aria-list-and-listitem.html: Added.
- platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Added.
- 9:32 AM Changeset in webkit [47674] by
-
- 3 edits in trunk/WebCore
Clean up fill image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=28652
Reviewed by Darin Adler.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Renamed
calculateBackgroundSize() to this. Replaced separate scaledWidth and
scaledHeight parameters with a single scaledSize parameter. Renamed
parameters and local variables.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Changed
to use CSS3 Backgrounds and Borders terminology in comments and
local variable names. Renamed, clarified and consolidated some local
variables.
- rendering/RenderBoxModelObject.h: Made calculateFillTileSize() private.
- 9:16 AM Changeset in webkit [47673] by
-
- 3 edits in trunk/WebCore
Backing out http://trac.webkit.org/changeset/47669
- 9:10 AM Changeset in webkit [47672] by
-
- 7 edits in trunk/WebCore
2009-08-22 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Backing out http://trac.webkit.org/changeset/47671 in preparation of
rolling out http://trac.webkit.org/changeset/47669.
- 8:13 AM Changeset in webkit [47671] by
-
- 7 edits in trunk/WebCore
2009-08-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Anders Carlsson.
Build fix, add CanvasRenderingContext to build systems.
https://bugs.webkit.org/show_bug.cgi?id=28018
- DerivedSources.make: Added CanvasRenderinContext.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- 6:11 AM Changeset in webkit [47670] by
-
- 6 edits18 adds1 delete in trunk/WebCore
New files implementing GL buffer wrappers, and support to make them platform independent
https://bugs.webkit.org/show_bug.cgi?id=28018
- 5:56 AM Changeset in webkit [47669] by
-
- 2 edits in trunk/WebCore/html/canvas
stash CanvasRenderingContext2D
- 2:02 AM Changeset in webkit [47668] by
-
- 2 edits in trunk/JavaScriptCore
Fix storage leak from syntax tree arena allocation patch.
Patch by Darin Adler <Darin Adler> on 2009-08-22
- parser/Nodes.h: CommaNode needs to inherit from ParserArenaDeletable
because it has a vector.
Aug 21, 2009:
- 11:54 PM Changeset in webkit [47667] by
-
- 2 edits in trunk/JavaScriptCore
Fix Qt build.
Patch by Darin Adler <Darin Adler> on 2009-08-21
- parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData): Made non-inline again.
This is used outside Nodes.cpp so can't be inline unless
it is in the header.
- 11:53 PM Changeset in webkit [47666] by
-
- 3 edits in trunk/WebCore
- WebCore.vcproj/build-generated-files.sh:
- make-generated-sources.sh:
Removed obsolete code to set up CREATE_HASH_TABLE.
- 11:52 PM Changeset in webkit [47665] by
-
- 3 edits in trunk/JavaScriptCore
Two loose ends from the last commit.
Patch by Darin Adler <Darin Adler> on 2009-08-21
- JavaScriptCore.xcodeproj/project.pbxproj: Made ParserArena.h
and create_hash_table project-internal instead of "private".
- runtime/Executable.h: Removed accidentally-added constructor.
- 11:40 PM Changeset in webkit [47664] by
-
- 19 edits in trunk/JavaScriptCore
Syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
Patch by Darin Adler <Darin Adler> on 2009-08-21
Reviewed by Gavin Barraclough.
Use an actual arena now. 0.6% speedup on SunSpider.
New and improved with 100% less leaking of the universe.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed all exports involving the class FunctionBodyNode, which no
longer needs to be used outside JavaScriptCore.
- JavaScriptCore.xcodeproj/project.pbxproj: Made Nodes.h and
Executable.h project-internal instead of "private".
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
contains const Identifier* now.
- parser/Grammar.y: Made identifiers from the lexer be const
Identifier* and updated since VarStack contains const Identifier* now.
- parser/Lexer.cpp:
(JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
(JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
and changed to call ParserArena.
(JSC::Lexer::clear): Removed the code to manage m_identifiers and
added code to set m_arena to 0.
- parser/Lexer.h: Updated for changes above.
- parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
on the arena.
(JSC::ParserArenaDeletable::operator new): Changed to call the
allocateDeletable function on the arena instead of deleteWithArena.
(JSC::PropertyNode::PropertyNode): Added new constructor that makes
numeric identifiers. Some day we might want to optimize this for
integers so it doesn't create a string for each one.
(JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
since it's now a const Identifier& so it can't be left uninitialized.
(JSC::BreakNode::BreakNode): Ditto.
(JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
to keep track of the statements rather than a separate statement vector.
(JSC::BlockNode::BlockNode): Ditto.
(JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
- parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
It seemed strangely out of place in the header.
(JSC::ThrowableExpressionData::emitThrowError): Added an overload for
UString as well as Identifier.
(JSC::SourceElements::singleStatement): Added.
(JSC::SourceElements::lastStatement): Added.
(JSC::RegExpNode::emitBytecode): Changed the throwError code to use
the substitution mechanism instead of doing a string append.
(JSC::SourceElements::emitBytecode): Added. Replaces the old
statementListEmitCode function, since we now keep the SourceElements
objects around.
(JSC::BlockNode::lastStatement): Added.
(JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
statementListEmitCode.
(JSC::CaseClauseNode::emitBytecode): Added.
(JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
instead of statementListEmitCode.
(JSC::ScopeNodeData::ScopeNodeData): Changed to store the
SourceElements* instead of using releaseContentsIntoVector.
(JSC::ScopeNode::emitStatementsBytecode): Added.
(JSC::ScopeNode::singleStatement): Added.
(JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
of statementListEmitCode.
(JSC::EvalNode::emitBytecode): Ditto.
(JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
insetad of statementListEmitCode and check for the return node using
the new functions.
- parser/Nodes.h: Changed VarStack to store const Identifier* instead
of Identifier and rely on the arena to control lifetime. Added a new
ParserArenaFreeable class. Made ParserArenaDeletable inherit from
FastAllocBase instead of having its own operator new. Base the Node
class on ParserArenaFreeable. Changed the various Node classes
to use const Identifier& instead of Identifier to avoid the need to
call their destructors and allow them to function as "freeable" in the
arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
as a base class since they do not descend from Node. Eliminated the
StatementVector type and instead have various classes use SourceElements*
instead of StatementVector. This prevents those classes from having to
use ParserArenaDeletable to make sure the vector destructor is called.
- parser/Parser.cpp:
(JSC::Parser::parse): Pass the arena to the lexer.
- parser/Parser.h: Added an include of ParserArena.h, which is no longer
included by Nodes.h.
(JSC::Parser::parseFunctionFromGlobalCode): Changed to use the
singleStatement function, since there is no longer any children function.
Removed some unneeded use of RefPtr.
- parser/ParserArena.cpp:
(JSC::ParserArena::ParserArena): Added. Initializes the new members,
m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
(JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
since we store only the current pointer and the end of pool pointer.
(JSC::ParserArena::deallocateObjects): Added. Contains the common
memory-deallocation logic used by both the destructor and the
reset function.
(JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
(JSC::ParserArena::reset): Ditto. Also added code to zero out the
new structures, and switched to use clear() instead of shrink(0) since
we don't really reuse arenas.
(JSC::ParserArena::makeNumericIdentifier): Added.
(JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
is empty.
(JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
since this is used only for assertions at the moment.
(JSC::ParserArena::derefWithArena): Make non-inline.
- parser/ParserArena.h: Added an actual arena of "freeable" objects,
ones that don't need destructors to be called. Also added a separate
IdentifierArena object, a segmented vector of identifiers that used
to be in the Lexer.
- runtime/Executable.h: Moved the definition of the
FunctionExecutable::make function here. It can't go in JSFunction.h
since that header has to be used outside JavaScriptCore and so can't
include this, which includes Nodes.h. The function could be moved
elswhere if we don't want to include JSFunction.h in this header, but
for now this seems to be the best place.
- runtime/JSFunction.h: Removed the include of Executable.h and
definition of the FunctionExecutable::make function.
- wtf/FastMalloc.cpp: Fixed an incorrect comment.
- 10:24 PM Changeset in webkit [47663] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7162322> Custom style sheet ignored if UAC is enabled
Reviewed by Mark Rowe.
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
No need to open the file with write access. Only read access is needed.
- 10:10 PM Changeset in webkit [47662] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/7161454> Leaks seen during http/tests/xmlhttprequest/cross-origin-no-authorization.html
Also fixes leaks seen on appcache tests.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::cancel): Work around something that's likely a CFNetwork issue. Note that on Windows, there is no matching API to call, and we do not think that the leak occurs there anyway.
- 8:51 PM Changeset in webkit [47661] by
-
- 2 edits in trunk
2009-08-22 Javier Jardón <javierjc1982@gmail.com>
[GTK] Not use deprecated symbols in WebKitWebView example code.
https://bugs.webkit.org/show_bug.cgi?id=28651
- WebKit/gtk/webkit/webkitwebview.cpp
- 7:31 PM Changeset in webkit [47660] by
-
- 3 edits in trunk/JavaScriptCore
Fix the non-JIT build.
- runtime/Executable.cpp:
- runtime/Executable.h:
- 7:06 PM Changeset in webkit [47659] by
-
- 3 edits in trunk/WebCore
Remove cross-thread code from CrossOriginPreflightResultCache.
Removed mutexes, atomic initializer and string copy.
https://bugs.webkit.org/show_bug.cgi?id=28650
Reviewed by David Levin.
No new tests, the worker tests cover this.
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::addToAccessControlAllowList):
(WebCore::CrossOriginPreflightResultCache::shared):
(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
(WebCore::CrossOriginPreflightResultCache::empty):
- loader/CrossOriginPreflightResultCache.h:
- 7:02 PM Changeset in webkit [47658] by
-
- 2 edits in trunk/WebCore
2009-08-21 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Jan Alonzo.
Buildfix after http://trac.webkit.org/changeset/47655.
- html/HTMLFormControlElement.h:
- 6:55 PM Changeset in webkit [47657] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7162480>
Sometimes WebKit does not layout correctly when a WebView is embedded in an HICocoaView
Reviewed by Darin Adler.
Add a null check for the current context when reflectScrolledClipView: is called from outside a
draw operation.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
- 6:53 PM Changeset in webkit [47656] by
-
- 18 edits in trunk/WebCore
2009-08-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: Improve Cookie DataGrid to Show Hidden Data
https://bugs.webkit.org/show_bug.cgi?id=28269
Removed Custom Bindings
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp:
- inspector/InspectorBackend.cpp:
Made Non-Custom Bindings in the Backend
(WebCore::InspectorBackend::getCookies):
(WebCore::InspectorBackend::deleteCookie):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
- inspector/InspectorController.h:
Build the Cookie ScriptObjects, handles using document.cookie in
case the platform hasn't implemented raw cookie access.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getCookies): (WebCore::InspectorDOMAgent::buildObjectForCookie): (WebCore::InspectorDOMAgent::buildArrayForCookies):
- inspector/InspectorDOMAgent.h:
Complete the Asynchronous Calls
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetCookies):
- inspector/InspectorFrontend.h:
Asynchronous Functions to get Cookie Data
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.buildCookiesFromString): fallback behavior
Refactor to use the Asynchronous Functions
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.simpleDataGridForCookies): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
Cleaned/Commented Related Code
(InspectorController.searchCanceled):
- inspector/front-end/InjectedScript.js:
- platform/Cookie.h:
- English.lproj/localizedStrings.js: the new strings that were supposed to have gone in last time
- 6:16 PM Changeset in webkit [47655] by
-
- 11 edits6 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28145
Add support for novalidate/formnovalidate attribute, from HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-novalidate
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-21
Reviewed by Adele Peterson.
Tests: fast/forms/formnovalidate-attribute.html
fast/forms/novalidate-attribute.html
- html/HTMLAttributeNames.in: added novalidate, formnovalidate
- html/HTMLButtonElement.idl: formnovalidate attribute exposed
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formNoValidate): attribute getter
(WebCore::HTMLFormControlElement::setFormNoValidate): attribute setter
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::novalidate): attribute getter
(WebCore::HTMLFormElement::setNovalidate): attribute setter
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl: novalidate attribute exposed
- html/HTMLInputElement.idl: formNoValidate attribute exposed
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28145
Tests for novalidate/formnovalidate attribute, from HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-novalidate
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-21
Reviewed by Adele Peterson.
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/resources/domListEnumeration.js:
- fast/forms/formnovalidate-attribute-expected.txt: Added.
- fast/forms/formnovalidate-attribute.html: Added.
- fast/forms/novalidate-attribute-expected.txt: Added.
- fast/forms/novalidate-attribute.html: Added.
- fast/forms/resources/formnovalidate-attribute.js: Added.
- fast/forms/resources/novalidate-attribute.js: Added.
- 6:13 PM Changeset in webkit [47654] by
-
- 2 edits in trunk/WebKitTools
2009-08-21 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Simon Fraser.
Remove GNOME keyring support in build-webkit. This dependency's
already been removed in the Gtk port.
- Scripts/build-webkit:
- 5:59 PM Changeset in webkit [47653] by
-
- 2 edits in trunk/JavaScriptCore
Speculative QuickTime build fix.
Reviewed by NOBODY (build fix).
- runtime/JSArray.cpp:
- 5:44 PM Changeset in webkit [47652] by
-
- 1 edit in trunk/LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png
Set the PNG's svn:mime-type property to image/png
- 5:41 PM Changeset in webkit [47651] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Tweaked the test to make everything fit in a 800-by-600 view.
- fast/backgrounds/size/contain-and-cover-expected.checksum:
- fast/backgrounds/size/contain-and-cover-expected.png:
- fast/backgrounds/size/contain-and-cover-expected.txt:
- fast/backgrounds/size/contain-and-cover.html:
- 5:33 PM Changeset in webkit [47650] by
-
- 4 edits5 adds in trunk
WebCore:
Rendering changes to complete
[CSS3 Backgrounds and Borders] Add support for the "contain" value for
background-size
https://bugs.webkit.org/show_bug.cgi?id=27573
and
[CSS3 Backgrounds and Borders] Add support for the "cover" value for
background-size
https://bugs.webkit.org/show_bug.cgi?id=27574
Reviewed by Beth Dakin.
Test: fast/backgrounds/size/contain-and-cover.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundSize):
- rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers):
LayoutTests:
Rendering tests for
[CSS3 Backgrounds and Borders] Add support for the "contain" value for
background-size
https://bugs.webkit.org/show_bug.cgi?id=27573
and
[CSS3 Backgrounds and Borders] Add support for the "cover" value for
background-size
https://bugs.webkit.org/show_bug.cgi?id=27574
Reviewed by Beth Dakin.
- fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
- fast/backgrounds/size/contain-and-cover-expected.png: Added.
- fast/backgrounds/size/contain-and-cover-expected.txt: Added.
- fast/backgrounds/size/contain-and-cover.html: Added.
- fast/backgrounds/size/resources/SquirrelFish.svg: Added!!!
- 4:55 PM Changeset in webkit [47649] by
-
- 25 edits18 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27452
Add support for checkValidity() method and invalid event, from HTML5
specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-form-checkvalidity
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-21
Reviewed by Adele Peterson.
Tests: fast/events/invalid-001.html
fast/events/invalid-002.html
fast/events/invalid-003.html
fast/events/invalid-004.html
fast/events/invalid-005.html
fast/forms/checkValidity-001.html
fast/forms/checkValidity-002.html
fast/forms/checkValidity-003.html
fast/forms/checkValidity-004.html
- dom/Document.idl: oninvalid event handler
- dom/Element.idl: ditto
- dom/EventNames.h: added invalid event
- dom/Node.cpp:
(WebCore::Node::oninvalid): ditto
(WebCore::Node::setOninvalid): ditto
- dom/Node.h: ditto
- html/HTMLAttributeNames.in: oninvalid attribute
- html/HTMLButtonElement.idl: added checkValidity() method
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute): parses oninvalid
- html/HTMLFieldSetElement.idl: added checkValidity() method
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::checkValidity): checkValidity()
implementation
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::checkValidity): checkValidity() implementation
for form elements
- html/HTMLFormElement.h: checkValidity() definition
- html/HTMLFormElement.idl: added checkValidity() method
- html/HTMLInputElement.idl: added checkValidity() method
- html/HTMLSelectElement.idl: added checkValidity() method
- html/HTMLTextAreaElement.idl: added checkValidity() method
- page/DOMWindow.cpp:
(WebCore::DOMWindow::oninvalid): oninvalid event handler
(WebCore::DOMWindow::setOninvalid): ditto
- page/DOMWindow.h: ditto
- page/DOMWindow.idl: ditto
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27452
Tests for checkValidity() method and invalid event, from HTML5
specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-form-checkvalidity
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-21
Reviewed by Adele Peterson.
- fast/events/invalid-001-expected.txt: Added.
- fast/events/invalid-001.html: Added.
- fast/events/invalid-002-expected.txt: Added.
- fast/events/invalid-002.html: Added.
- fast/events/invalid-003-expected.txt: Added.
- fast/events/invalid-003.html: Added.
- fast/events/invalid-004-expected.txt: Added.
- fast/events/invalid-004.html: Added.
- fast/events/invalid-005-expected.txt: Added.
- fast/events/invalid-005.html: Added.
- fast/forms/checkValidity-001-expected.txt: Added.
- fast/forms/checkValidity-001.html: Added.
- fast/forms/checkValidity-002-expected.txt: Added.
- fast/forms/checkValidity-002.html: Added.
- fast/forms/checkValidity-003-expected.txt: Added.
- fast/forms/checkValidity-003.html: Added.
- fast/forms/checkValidity-004-expected.txt: Added.
- fast/forms/checkValidity-004.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/resources/domListEnumeration.js:
- 4:30 PM Changeset in webkit [47648] by
-
- 7 edits3 adds in trunk
WebCore: The CSS part of https://bugs.webkit.org/show_bug.cgi?id=27571 [CSS3
Backgrounds and Borders] Add support for the "round" value for
background-repeat
-and-
https://bugs.webkit.org/show_bug.cgi?id=27570 [CSS3 Backgrounds and
Borders] Add support for the "space" value for background-repeat
Reviewed by Dan Bernstein.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
- css/CSSValueKeywords.in:
- rendering/style/FillLayer.h:
- rendering/style/RenderStyleConstants.h:
(WebCore::):
LayoutTests: Test for the CSS part of https://bugs.webkit.org/show_bug.cgi?id=27571 [CSS3 Backgrounds and Borders] Add support for the "round" value
for background-repeat
-and-
https://bugs.webkit.org/show_bug.cgi?id=27570 [CSS3 Backgrounds and
Borders] Add support for the "space" value for background-repeat
Reviewed by Dan Bernstein.
- fast/backgrounds/repeat/parsing-background-repeat-expected.txt: Added.
- fast/backgrounds/repeat/parsing-background-repeat.html: Added.
- fast/backgrounds/repeat/resources/parsing-background-repeat.js: Added.
(test):
- 3:57 PM Changeset in webkit [47647] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-08-21 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Eric Seidel.
Regression test for bug fixed in
http://codereview.chromium.org/171039. Regexps created in one
frame were not callable outside that frame.
https://bugs.webkit.org/show_bug.cgi?id=28387
- fast/regex/cross-frame-callable-expected.txt: Added.
- fast/regex/cross-frame-callable.html: Added.
- fast/regex/resources/cross-frame-callable.js: Added. (doTest):
- 3:46 PM Changeset in webkit [47646] by
-
- 2 edits in trunk/JavaScriptCore
Speculative QT build fix.
Reviewed by NOBODY (build fix).
- runtime/StringPrototype.cpp:
- 3:45 PM Changeset in webkit [47645] by
-
- 1 edit14 adds in trunk/WebCore
New files for Canvas 3D feature
https://bugs.webkit.org/show_bug.cgi?id=28018
This is all the new files for implementing Canvas 3D. None of them are hooked up and
are not even included in the build yet. This incorporates the reviews from Simon
and Ollie for these files.
- 3:28 PM Changeset in webkit [47644] by
-
- 2 edits in trunk/WebCore
No Review.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
Another Windows build fix.
- editing/ApplyStyleCommand.cpp:
(WebCore::diffTextDecorations):
- 3:19 PM Changeset in webkit [47643] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28625, focus rings don't respect the non-strict mode
line box shrinking quirk. Make sure outlines don't extend outside the lineTop and lineBottom
of the root line box.
Reviewed by Simon Fraser.
Covered by existing tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
- 3:08 PM Changeset in webkit [47642] by
-
- 2 edits in trunk/WebCore
No Review.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
Windows build fix.
- editing/ApplyStyleCommand.cpp:
(WebCore::setTextDecorationProperty): Made it static
(WebCore::diffTextDecorations): Made it static
- 2:54 PM Changeset in webkit [47641] by
-
- 15 edits in trunk/JavaScriptCore
Restructure Executable types so that host functions do not hold a FunctionExecutable.
https://bugs.webkit.org/show_bug.cgi?id=28621
Reviewed by Oliver Hunt.
All JSFunction objects have a pointer to an Executable*. This is currently always a
FunctionExecutable, however this has a couple of drawbacks. Host functions do not
store a range of information that the FunctionExecutable provides (source, name,
CodeBlock & information presently held on the FunctionBodyNode).
[ * nearly all... see below! ]
Instead, make JSFunctions hold a pointer to an ExecutableBase, move fields specific
to JS sourced executable types (source, node) into a new subclass (ScriptExecutable),
and create a new NativeExecutable type. We now provide a new method in JSFunction
to access & downcast to FunctionExecutable, but in doing so we can make an early
check (with an ASSERT) to ensure that the Executable read from a function will only
be treated as a FunctionExecutable (and thus the JS sepcific fields will only be
accessed) if the JSFunction is not a host function.
There is one JSFunction that currently does not have an Executable, which is the
object created to allow us to read out the vtable pointer. By making this change
we can also add a new Executable type fror this object (VPtrHackExecutable).
Since this means that really all JSFunctions have an Executable we no longer have
to null-check m_executable before us it - particularly in isHostFunction().
This patch removes CacheableEvalExecutable, since all subclasses of ExecutableBase
can now be ref-counted - since both JSFunction holds (and ref-counts) an ExecutableBase
that might be a FunctionExecutable or a NativeExecutable. This does now mean that all
ProgramExecutables and EvalExecutables (unnecessarily) provide an interface to be
ref-counted, however this seems less-bad than host functions unnecessarily providing
interface to access non-host specific information.
The class hierarcy has changed from this:
- ExecutableBase
- ProgramExecutable
- EvalExecutable
- CacheableEvalExecutable (also RefCounted by multiple-inheritance)
- FunctionExecutable (also RefCounted by multiple-inheritance, 'special' FunctionExecutable also used for host functions)
To this:
- RefCounted
- ExecutableBase
- NativeExecutable
- VPtrHackExecutable
- ScriptExecutable
- ProgramExecutable
- EvalExecutable
- FunctionExecutable
- ExecutableBase
This patch speeds up sunspidey by a couple of ms (presumably due to the changes to isHostFunction()).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::ownerExecutable):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- profiler/Profiler.cpp:
(JSC::createCallIdentifierFromFunctionImp):
- runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
- runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
(JSC::VPtrHackExecutable::~VPtrHackExecutable):
- runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::source):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
- runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::JSFunction::jsExecutable):
(JSC::JSFunction::isHostFunction):
- 2:51 PM Changeset in webkit [47640] by
-
- 21 edits in trunk
WebCore: execCommand("Underline") uses CSS even when styleWithCSS has been turned off
https://bugs.webkit.org/show_bug.cgi?id=23892
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
Reviewed by Eric Seidel.
This patch adds support for u and s in StyleChange and addInlineStyleIfNeeded so that
WebKit does not use CSS to decorate texts when styleWithCSS is set to false.
- css/CSSValueList.cpp:
(WebCore::CSSValueList::copy): Added.
- css/CSSValueList.h: Added copy.
- editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::applyUnderline):
(WebCore::StyleChange::applyLineThrough):
(WebCore::StyleChange::StyleChange): Added a boolean trimTextDecorations argument.
(WebCore::StyleChange::init): Ditto.
(WebCore::StyleChange::extractTextStyles): Handles text decorations.
(WebCore::getPropertiesNotInComputedStyle): Handles text decorations properly.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Adds u and s if needed.
LayoutTests: execCommand("Underline") uses CSS even when styleWithCSS has been turned off
https://bugs.webkit.org/show_bug.cgi?id=23892
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
Reviewed by Eric Seidel.
This patch rebaselines tests contained spans to decorate texts even though styleWithCSS is turned off.
It replaces those spans with either u or s accordingly.
It modifies the order in which tag appear in toggle-style-2 to match the actual result
since the original ordering was rather arbitrary.
This patch breaks /editing/style/font-family-with-space.html for Qt platform.
Manual rebaseline is required once the patch is landed.
- editing/execCommand/resources/toggle-style-2.js: Modified the order in which tag appear
- editing/execCommand/resources/toggle-text-decorations.js: execCommand('styleWithCSS') is called after selection is set
(testSingleToggle):
- editing/execCommand/strikethroughSelection-expected.txt: span with line-through was replaced by s
- editing/execCommand/toggle-style-2-expected.txt: Passes all but the last two tests.
- editing/style/remove-underline-across-paragraph-expected.txt: Underline is added by u instead of CSS.
- editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Ditto.
- editing/style/remove-underline-after-paragraph-expected.txt: Ditto.
- editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Ditto.
- editing/style/remove-underline-expected.txt: Ditto.
- editing/style/remove-underline-in-bold-expected.txt: Ditto.
- editing/style/underline-expected.txt: Ditto.
- platform/mac/editing/execCommand/5190926-expected.txt: Ditto.
- platform/mac/editing/pasteboard/5075944-expected.txt: Ditto.
- platform/mac/editing/style/font-family-with-space-expected.txt: Ditto.
- platform/qt/editing/execCommand/5190926-expected.txt: Ditto.
- platform/qt/editing/pasteboard/5075944-expected.txt: Ditto.
- 1:35 PM Changeset in webkit [47639] by
-
- 14 edits2 moves in trunk/WebCore
Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: Rename "Databases" Panel as "Storage"
https://bugs.webkit.org/show_bug.cgi?id=28620
Updated enum from "DatabasesPanel" to "StoragePanel" and wherever it was used.
- inspector/InspectorController.cpp: (WebCore::InspectorController::specialPanelForJSName): string to display StoragePanel can be either "databases" or "storage"
- inspector/InspectorController.h: (WebCore::InspectorController::):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
Updated All Direct Access from WebInspector.panels.databases to WebInspector.panels.storage,
any DatabasesPanel constructors and appropriate function names.
- inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
- inspector/front-end/inspector.js: (WebInspector._createPanels): updated string that comes from hiddenPanels to be "databases" or "storage" (WebInspector.showStoragePanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.addDatabase): (WebInspector.addDOMStorage):
Renamed some files and Updated Accordingly.
- inspector/front-end/StoragePanel.js: Renamed from WebCore/inspector/front-end/DatabasesPanel.js.
- inspector/front-end/Images/storageIcon.png: Renamed from WebCore/inspector/front-end/Images/databasesIcon.png.
- inspector/front-end/WebKit.qrc: use new file names
- inspector/front-end/inspector.css: use new images name and class names
- inspector/front-end/inspector.html: use new file name
- WebCore.gypi: use new file names
Miscellaneous Updates.
- English.lproj/localizedStrings.js: Updated Tooltip from "Databases" to "Storage"
- 12:57 PM Changeset in webkit [47638] by
-
- 2 edits in trunk/LayoutTests
2009-08-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skipping a new test, a test that requires geolocation support (we
do not enable it yet), and a test which needs font sizing to be
properly setup.
- platform/gtk/Skipped:
- 12:16 PM Changeset in webkit [47637] by
-
- 1 edit3 adds in trunk/WebCore
2009-08-21 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
[Haiku] Adding three font-specific files to WebCore:
FontCacheHaiku.cpp, FontHaiku.cpp, and SimpleFontDataHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28131
- platform/graphics/haiku/FontCacheHaiku.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::createFontPlatformData): (WebCore::FontCache::getTraitsInFamily):
- platform/graphics/haiku/FontHaiku.cpp: Added. (charUnicodeToUTF8HACK): (WebCore::Font::canReturnFallbackFontsForComplexText): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/haiku/SimpleFontDataHaiku.cpp: Added. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- 12:02 PM Changeset in webkit [47636] by
-
- 3 edits in trunk/WebCore
2009-08-21 Philippe Beauchamp <philippe.beauchamp@gmail.com>
Reviewed by Adam Roben.
Middle click panning icon is offset by 3 pixels
https://bugs.webkit.org/show_bug.cgi?id=28611
- platform/ScrollView.cpp: panIconSizeLength initialized to 20 instead of 16 to match icon dimension (2 pixels offset)
- platform/win/CursorWin.cpp: (WebCore::middlePanningCursor): Hotspot initialized to (8,8) instead of (7,7) (one pixel offset)
- 11:54 AM Changeset in webkit [47635] by
-
- 2 edits in trunk/WebCore
2009-08-21 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Remove inspector resources for Symbian
https://bugs.webkit.org/show_bug.cgi?id=28610
Based on an idea from Simon Hausmann.
- WebCore.pro:
- 11:54 AM Changeset in webkit [47634] by
-
- 3 edits in trunk/LayoutTests
Add test to ensure JSON parser does not accept comments.
Reviewed by Tim Hatcher.
- 11:20 AM Changeset in webkit [47633] by
-
- 2 edits in trunk/WebCore
2009-08-21 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Eric Seidel.
Inspector: Remove Unused Variable
https://bugs.webkit.org/show_bug.cgi?id=28616
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._checkWarning):
- 11:11 AM Changeset in webkit [47632] by
-
- 2 edits in trunk/WebCore
2009-08-21 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: Console Array Formatter Shows Extra Properties
https://bugs.webkit.org/show_bug.cgi?id=28615
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): do not ignore hasOwnProperties
- 11:10 AM Changeset in webkit [47631] by
-
- 2 edits in trunk/WebKitTools
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Based on original patch by Stephanie Lewis.
Added support of the Windows malloc history format to parse-malloc history, so we can
read and parse it.
- Scripts/parse-malloc-history:
- 7:43 AM Changeset in webkit [47630] by
-
- 13 edits6 adds in trunk
WebCore: The CSS part of https://bugs.webkit.org/show_bug.cgi?id=27574 [CSS3
Backgrounds and Borders] Add support for the "contain" value for
background-size
-and-
https://bugs.webkit.org/show_bug.cgi?id=27573 [CSS3 Backgrounds and
Borders] Add support for the "cover" value for background-size
Reviewed by Dan Bernstein.
Return contain or cover when appropriate, and otherwise do what we
used to do.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Accept contain and cover as valid values for background-size.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):
Handle setting the size and the sizeLength if appropriate.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapFillSize):
Added new keywords contain and cover.
- css/CSSValueKeywords.in:
Use just sizeLength instead of size to match old behavior.
- page/animation/AnimationBase.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundSize):
- rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers):
The variable m_sizeType is an EBackgroundSize, and m_sizeLength is
a LengthSize (the equivalent of what m_size used to be). I got rid
of m_sizeSet and made isSizeSet() dynamic. I also defined a new
struct, FillSize that can be used to set or get m_size and
m_sizeLength both at once.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
- rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize):
(WebCore::FillSize::operator==):
(WebCore::FillSize::operator!=):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::size):
(WebCore::FillLayer::isSizeSet):
(WebCore::FillLayer::setSizeType):
(WebCore::FillLayer::setSizeLength):
(WebCore::FillLayer::setSize):
(WebCore::FillLayer::clearSize):
(WebCore::FillLayer::initialFillSizeType):
(WebCore::FillLayer::initialFillSizeLength):
(WebCore::FillLayer::initialFillSize):
This is all boiler-plate stuff to adjust to the new size() vs.
sizeType() vs. sizeLength() distinction.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskSize):
(WebCore::InheritedFlags::setBackgroundSize):
(WebCore::InheritedFlags::setBackgroundSizeLength):
(WebCore::InheritedFlags::setMaskSize):
Definition for EBackgroundSizeType.
- rendering/style/RenderStyleConstants.h:
(WebCore::):
LayoutTests: Tests for the CSS part of https://bugs.webkit.org/show_bug.cgi?id=27574 [CSS3 Backgrounds and Borders] Add support for the "contain" value
for background-size
-and-
https://bugs.webkit.org/show_bug.cgi?id=27573 [CSS3 Backgrounds and
Borders] Add support for the "cover" value for background-size
Reviewed by Dan Bernstein.
- fast/backgrounds/size/parsing-background-size-values-expected.txt: Added.
- fast/backgrounds/size/parsing-background-size-values.html: Added.
- fast/backgrounds/size/parsing-inherit-expected.txt: Added.
- fast/backgrounds/size/parsing-inherit.html: Added.
- fast/backgrounds/size/resources/parsing-background-size-values.js: Added.
(test):
- fast/backgrounds/size/resources/parsing-inherit.js: Added.
(test):
- 6:32 AM Changeset in webkit [47629] by
-
- 1 edit1 add in trunk/LayoutTests
2009-08-21 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Check-in result for http://trac.webkit.org/changeset/47590.
- platform/gtk/fast/repaint/inline-block-resize-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/inline-block-resize-expected.txt.
- 3:07 AM Changeset in webkit [47628] by
-
- 2 edits in trunk/WebCore
2009-08-21 Ariya Hidayat <ariya.hidayat@nokia.com>
Not reviewed, build fix after r47580.
[Qt] Adjust the files.
- inspector/front-end/WebKit.qrc:
- 12:48 AM Changeset in webkit [47627] by
-
- 7 edits in trunk/JavaScriptCore
Browser hangs on opening Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28438
Reviewed by Maciej Stachowiak.
Code generation needs to be able to walk the entire scopechain in some
cases, however the symbol table used by activations was a member of the
codeblock. Following recompilation this may no longer exist, leading
to a crash or hang on lookup.
We fix this by introducing a refcounted SymbolTable subclass, SharedSymbolTable,
for the CodeBlocks used by function code. This allows activations to
maintain ownership of a copy of the symbol table even after recompilation so
they can continue to work.
- 12:01 AM Changeset in webkit [47626] by
-
- 18 edits2 adds in trunk
WebCore: Enable various "grouping" ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=28486
Reviewed by Darin Adler.
Test: platform/mac/accessibility/aria-grouping-roles.html
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/mac/AccessibilityObjectWrapper.mm:
- page/mac/WebCoreViewFactory.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm:
WebKit: Enable various "grouping" ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=28486
Reviewed by Darin Adler.
- English.lproj/Localizable.strings:
WebKit/mac: Enable various "grouping" ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=28486
Reviewed by Darin Adler.
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
WebKitTools: Enable various "grouping" ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=28486
Reviewed by Darin Adler.
Expose the ability to retrieve the subrole through accessibility for DRT.
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
LayoutTests: Enable various "grouping" ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=28486
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-grouping-roles-expected.txt: Added.
- platform/mac/accessibility/aria-grouping-roles.html: Added.
- 12:00 AM Changeset in webkit [47625] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-20 Xan Lopez <xlopez@igalia.com>
Add new file to GTK+ build.
- GNUmakefile.am:
Aug 20, 2009:
- 11:11 PM Changeset in webkit [47624] by
-
- 2 edits in trunk/WebCore
Unreviewed trivial comment fix.
Patch by David Levin <levin@chromium.org> on 2009-08-20
Update a bug link in a comment due to bugzilla amnesia.
- loader/CachedResource.cpp:
(WebCore::CachedResource::setResourceToRevalidate):
- 10:47 PM Changeset in webkit [47623] by
-
- 2 edits in trunk/WebKitTools
Added myself (Joseph Pecoraro) as commiter
- 10:41 PM Changeset in webkit [47622] by
-
- 10 edits1 copy in trunk/JavaScriptCore
Added a number => string cache.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-20
Reviewed by Maciej Stachowiak.
1.07x faster on v8 (1.7x faster on v8-splay).
1.004x faster on SunSpider.
- runtime/JSCell.h: Moved JSValue::toString to JSString.h.
- runtime/JSGlobalData.h: Holds the cache.
- runtime/JSNumberCell.cpp:
(JSC::JSNumberCell::toString):
(JSC::JSNumberCell::toThisString): Removed -0 special case.
UString handles this now, since too many clients were
special-casing it.
- runtime/JSString.h:
(JSC::JSValue::toString): Use the cache when converting
an int or double to string.
- runtime/Operations.h:
(JSC::concatenateStrings): Call toString to take advantage
of the cache.
- runtime/SmallStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookup): The cache.
- runtime/UString.cpp:
(JSC::UString::from): Added -0 special case mentioned above.
Removed appendNumeric because it's mutually exclusive with the
cache.
- 10:23 PM Changeset in webkit [47621] by
-
- 2 edits in trunk/WebKitTools
2009-08-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix memory leaks.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
- 9:21 PM Changeset in webkit [47620] by
-
- 6 edits1 move in trunk
REGRESSION: fast/profiler/call.html is crashing occasionally
https://bugs.webkit.org/show_bug.cgi?id=28476
Reviewed by Gavin Barraclough.
Using the codeblock for information about how many parameters and
locals a function has is unsafe in certain circumstances. The
basic scenario is all function code being cleared in response to
the debugger or profiler being enabled, and then an activation is
marked before its associated function is re-executed.
To deal with this scenario we store the variable count of a function
directly in the FunctionExecutable, and then use that information.
- 9:10 PM Changeset in webkit [47619] by
-
- 5 edits2 adds in trunk
WebCore: HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335
Patch by Albert J. Wong <ajwong@chromium.org> on 2009-08-20
Reviewed by David Levin.
Fire the waiting event before seeking, and fix a case where firing of
the seeked event is missed when the ready state is changed during
a seek.
Added video-waiting-seeking.html into manual tests because not
all platforms allow seeking into non-buffered ranges.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): add support for
waiting event when seeking.
(WebCore::HTMLMediaElement::finishSeek): send seeked event
whenever seeking finishes.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): dispatch to
new function.
- html/HTMLMediaElement.h:
- manual-tests/video-waiting-seeking.html: Added.
LayoutTests: HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335
Patch by Albert J. Wong <ajwong@chromium.org> on 2009-08-20
Reviewed by David Levin.
New manual test to check if waiting/seeking events are fired
when seeking into a non-buffered region.
- http/tests/media/video-throttled-load.cgi: Added.
- media/video-test.js:
(isInTimeRanges):
- 8:18 PM Changeset in webkit [47618] by
-
- 4 edits in trunk/WebCore
Fix more cases of
<rdar://problem/7154521> Lots of "<Error>: doClip: empty path." spew in
the console with certain content
Reviewed by John Sullivan.
If the border box is empty, simply avoid painting instead of trying to
clip to the empty path.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- 8:09 PM Changeset in webkit [47617] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 8:08 PM Changeset in webkit [47616] by
-
- 1 copy in tags/Safari-6531.15
New tag.
- 8:08 PM Changeset in webkit [47615] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47606.
- 7:57 PM Changeset in webkit [47614] by
-
- 6 edits in trunk/JavaScriptCore
Numbering of arguments to emitGetJITStubArg/emitPutJITStubArg incorrect
https://bugs.webkit.org/show_bug.cgi?id=28513
Reviewed by Oliver Hunt.
The argumentNumber argument to emitGetJITStubArg/emitPutJITStubArg should match
the argument number used within the stub functions in JITStubs.cpp, but it doesn't.
Firstly, all the numbers changed when we added a void* 'reserved' as the first slot
(rather than leaving argument 0 unused), and secondly in 32_64 builds the index to
peek/poke needs to be multiplies by 2 (since the argument to peek/poke is a number
of machine words, and on 32_64 build the argument slots to stub functions are two
words wide).
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 6:49 PM Changeset in webkit [47613] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-20 Jeremy Orlow <jorlow@chromium.org>
Build fix. Forgot a svn add for a patch I landed. :-(
- storage/SQLTransactionClient.cpp: Added. (WebCore::SQLTransactionClient::didCommitTransaction): (WebCore::SQLTransactionClient::didExecuteStatement): (WebCore::SQLTransactionClient::didExceedQuota):
- storage/SQLTransactionClient.h: Added.
- 6:43 PM Changeset in webkit [47612] by
-
- 12 edits in trunk/WebCore
2009-08-20 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Added a client to SQLTransaction. In addition to being a place to
get notifications about certain events in a transaction, it is
also an abstraction layer that allows us to plug in different
implementations for each port for how transactions interract with
the main DB. For example, WebCore's default implementation will
make direct calls to DatabaseTracker's methods. At the same time,
Chromium's implementation will send IPCs to the browser process
whenever a transaction needs something from the main DB.
All storage tests pass.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/Database.cpp: (WebCore::Database::transactionClient):
- storage/Database.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionClient):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runCurrentStatement): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransactionClient.cpp: Added.
- storage/SQLTransactionClient.h: Added.
- 5:27 PM Changeset in webkit [47611] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Mac Build Fix.
- 5:07 PM Changeset in webkit [47610] by
-
- 2 edits in trunk/WebCore
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=24793>
Auto scroll speed is faster than in IE, Firefox.
Changed pan scrolling speed to match Firefox's algorithm.
- rendering/RenderLayer.cpp: (WebCore::adjustedScrollDelta): (WebCore::RenderLayer::panScrollFromPoint):
- 4:49 PM Changeset in webkit [47609] by
-
- 3 edits in trunk/LayoutTests
underline tests in /editing/style/ need not to be pixel tests but need to print markup
https://bugs.webkit.org/show_bug.cgi?id=28471
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-20
Reviewed by Eric Seidel.
This patch modifies remove-underline-in-bold.html to use runDumpAsTextEditingTest.
- editing/style/remove-underline-in-bold-expected.txt:
- editing/style/remove-underline-in-bold.html:
- 4:37 PM Changeset in webkit [47608] by
-
- 5 edits3 adds8 deletes in trunk/LayoutTests
Some tests using editing.js in editing/execCommand should use runDumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=28494
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-20
Reviewed by Eric Seidel.
This patch modifies the following tests to use runDumpAsTextEditingTest
- editing/editing.js: Fixed typo and added foreColorCommand.
(execBackColorCommand):
- editing/execCommand/italicizeByCharacter-expected.txt: Added.
- editing/execCommand/italicizeByCharacter.html:
- editing/execCommand/modifyForeColorByCharacter-expected.txt: Added.
- editing/execCommand/modifyForeColorByCharacter.html:
- editing/execCommand/strikethroughSelection-expected.txt: Added.
- editing/execCommand/strikethroughSelection.html:
- 4:30 PM Changeset in webkit [47607] by
-
- 2 edits in trunk/WebCore
2009-08-20 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel.
Fix for assert in Chromium page cycler: drawRect() was re-using
an SkPaint, but not resetting it before calling
PlatformGraphicsSkia::setupPaintForFilling() a second time. This
CL fixes drawRect(), and re-enables the assert.
http://bugs.webkit.org/show_bug.cgi?id=28172
http://crbug.com/19797
Covered by Chromium page cycler tests.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintCommon):
- 4:17 PM Changeset in webkit [47606] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7159016> Popup menus don't disappear when you click outside the window.
Reviewed by Dan Bernstein.
Revert r47535 which introduced this.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupWndProc):
- 4:05 PM Changeset in webkit [47605] by
-
- 4 edits in trunk/JavaScriptCore
EGRESSION: significant slowdown on Celtic Kane "AJAX declaration" subtest
https://bugs.webkit.org/show_bug.cgi?id=28332
Reviewed by Geoff Garen
Follow up style fixes that were missed in review.
- 3:58 PM Changeset in webkit [47604] by
-
- 3 edits in trunk/JavaScriptCore
Add new exports to windows jsc build
- 3:37 PM Changeset in webkit [47603] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-08-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool post-diff can post partial diffs from SVN checkouts.
https://bugs.webkit.org/show_bug.cgi?id=28445
Pass the checkout root as the cwd. Also wrote a test to ensure this.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 3:37 PM Changeset in webkit [47602] by
-
- 4 edits in trunk/WebCore
Crashes on sites with lots of images
https://bugs.webkit.org/show_bug.cgi?id=28473
Patch by David Levin <levin@chromium.org> on 2009-08-20
Reviewed by Alexey Proskuryakov.
The problem is that m_resourceToRevalidate::m_isBeingRevalidated is false while
CachedResource is still referring to it, so it may get deleted before
Cache::revalidationSucceeded calls CachedResource::clearResourceToRevalidate.
- loader/Cache.cpp:
(WebCore::Cache::revalidateResource): Added assert to verify the resource
being revalidated is physically in the cache.
(WebCore::Cache::revalidationSucceeded): Changed to do one call to switch from the revalidating
resource to the revalidated resource. This allows for proper lifetime management of the
revalidated resource. Added assert to verify that the revalidatingResource is in the cache.
(WebCore::Cache::pruneDeadResources): Don't remove items from the cache that are in the
process of being validated (or else they can get added twice: Once through the normal mechanism
and then again during revalidateResource).
- loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::isSafeToMakePurgeable):
Changed m_isBeingRevalidated to m_proxyResource to allow finding out
who the validating resource (or proxy) is.
(WebCore::CachedResource::~CachedResource): Removed code to handle m_resourceToRevalidate
being non-zero because this shouldn't be possible due to checks in canDelete. Added asserts
as well.
(WebCore::CachedResource::setResourceToRevalidate): Adjusted for the change to m_proxyResource
and added a comment about the assert.
(WebCore::CachedResource::clearResourceToRevalidate):
Only clean up the resourceToRevalidate if it hasn't gotten a new proxy resource.
- loader/CachedResource.h:
(WebCore::CachedResource::setInCache): Don't clear m_proxyResource because the resource
is still being referred to by it and the code it robust to this being switched to a new proxy
resource without it being cleared first.
(WebCore::CachedResource::canDelete): Changed m_isBeingRevalidated to m_proxyResource.
- 3:36 PM Changeset in webkit [47601] by
-
- 6 edits in trunk/JavaScriptCore
REGRESSION: significant slowdown on Celtic Kane "AJAX declaration" subtest
https://bugs.webkit.org/show_bug.cgi?id=28332
Reviewed by Gavin Barraclough.
The method check optimisation made transitions aware of the value being
assigned when a transition was assigning a function. This had the side
effect of making every assignment of a function expression result in a
new transition, and thus a new Structure. The net result of this is that
the common JS idiom of
function MyObject() {
this.myFunction = function(...){...};
}
new MyObject();
Will produce a unique structure on every iteration, meaning that all
caching is defeated and there is a significant amount of structure churn.
The fix is to return the transition to its original form where it is
keyed off a property name + attributes tuple, but have each transition
support an optional transition on a specific value.
- 3:36 PM Changeset in webkit [47600] by
-
- 1 edit1 move in trunk/LayoutTests
2009-08-20 Eric Seidel <eric@webkit.org>
No review, just disabling a crashing test.
REGRESSION: fast/profiler/call.html is crashing occasionally
https://bugs.webkit.org/show_bug.cgi?id=28476
Disable this test until one of the JSC folks can find a fix.
This test will occasionally crash and cause patches to be rejected
from the commit-queue which are otherwise fine.
- fast/profiler/call.html-disabled: Renamed from LayoutTests/fast/profiler/call.html.
- 3:22 PM Changeset in webkit [47599] by
-
- 3 edits1 add in trunk/WebCore
2009-08-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Fix "Chromium RTL autocomplete popup is not layout correctly".
https://bugs.webkit.org/show_bug.cgi?id=27889
The complete fix of the issue consists 2 parts: the patch in webkit
and the patch in Chromium's own code.
This webkit patch only affects Chromium autofill. It
- introduces a new flag in WebCore::PopupContainerSettings to distinguish whether the width of the drop-down should be restricted or not. For autofill, the width of the drop-down is restricted to be the same as that of the input field (the new flag is set in Chromium's own code). But width is not restricted for <select> (same as before).
- introduce a new flag in WebCore::PopContainerSettings to indicate what heuristics to use when displaying text in drop-down menu. For autofill, use drop-down item's directionality to display drop-down items. Previously, drop-down item is displayed in the its first strong directional character's directionality. (drop-down item's directionality is set in Chromium's own code. It is set the same as the directionality of the element. For autofill, it is the same directionality as that of the input field.) For <select>, still use the text's first strong directional character's directionality to display the text.
Since the patch only affects the chromium client, not webcore part or
other clients. No automatic tests is possible.
- manual-tests/autofill-popup-width-and-item-direction.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::paintRow): If list box width is restricted and an item is longer to fit in a list box, truncate it and draw part of the text and append ellipses. (WebCore::PopupListBox::layout): Restrict width of list box if applicable.
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::PopupItem): style change. (WebCore::PopupContainerSettings::): Add 2 new flags in PopupContainerSetting to distinguish whether to restrict width of list box and in what directionality to display the text in drop-down.
- 3:02 PM Changeset in webkit [47598] by
-
- 3 edits in trunk/WebKitTools
2009-08-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool post-diff can post partial diffs from SVN checkouts.
https://bugs.webkit.org/show_bug.cgi?id=28445
Pass the checkout root as the cwd. Also wrote a test to ensure this.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 2:49 PM Changeset in webkit [47597] by
-
- 10 edits in trunk/JavaScriptCore
Remove FunctionCodeBlock.
https://bugs.webkit.org/show_bug.cgi?id=28502
Reviewed by Oliver Hunt.
These only exist to allow JIT code to dereference properties off the
CodeBlock for any callee, regardless of whether it is a host function.
Instead just use the FunctionExecutable. Copy the m_parameters field
from the CodeBlock into the Executable, and use this to distinguish
between host functions, functions that have been bytecompiled, and
functions that have not.
m_parameters is moved to ExecutableBase rather than FunctionExecutable
so that (as a separate change) we can move make a separate class of
executable for host code, which is not devived from FunctionExecutable
(host code does not feature any of the properties that normal executable
do and will provide, such as source, attributes, and a parsed name).
1% win on v8 tests, 0.5% on sunspider.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
(JSC::CodeBlock::functionRegisterForBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
- bytecode/CodeBlock.h:
(JSC::):
(JSC::CodeBlock::source):
(JSC::CodeBlock::sourceOffset):
(JSC::CodeBlock::evalCodeCache):
(JSC::CodeBlock::createRareDataIfNecessary):
remove NativeCodeBlocks and the NativeCode code type.
- jit/JIT.cpp:
(JSC::JIT::linkCall):
Revert to previous behaviour (as currently still commented!) that Hhost functions have a null codeblock.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
Bring the 32_64 & non-32_64 JITs into line with each other, callee in regT0.
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
Rewrite call trampolines to not use the CodeBlock.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Make call_JSFunction & call_arityCheck return the callee, don't expect to be passed the CodeBlock.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::generateBytecode):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::ExecutableBase::):
(JSC::ExecutableBase::ExecutableBase):
(JSC::FunctionExecutable::isHostFunction):
Add m_numParameters.
- runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
Only call generatedBytecode() on JSFunctions non-host FunctionExecutables.
- 2:26 PM Changeset in webkit [47596] by
-
- 2 edits in trunk/WebCore
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adele Peterson.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28504>.
Pan Scrolling can scroll while showing the middlePanScroll icon.
Fixed an off by one error between RenderLayer::panScrollFromPoint and EventHandler::updatePanScrollState.
In RenderLayer::panScrollFromPoint, we were setting the icon to be an arrow if the difference between the start
of the pan scroll and the current mouseposition is > 15. However, in EventHandler::updatePanScrollState, we would
set our amount to scroll to 0 only if the difference in mouse position is < 15. I made this check a <= 15, to fix
the off by one error.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint):
- 2:24 PM Changeset in webkit [47595] by
-
- 3 edits in trunk/WebCore
Pull the code in layoutBlockChildren for handling a normal flow block child into a helper method,
layoutBlockChild.
Reviewed by Dan Bernstein.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
- rendering/RenderBlock.h:
- 2:18 PM Changeset in webkit [47594] by
-
- 6 edits in trunk
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps.
Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel,
and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event.
One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but
this is tracked in <http://webkit.org/b/28237>.
- WebView.cpp: (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on. (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively.
- WebView.h:
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Made subframeForHitTargetNode a public static method, so WebView can call it
during hit testing.
- page/EventHandler.cpp: (WebCore::subframeForHitTestResult): (WebCore::EventHandler::subframeForTargetNode):
- page/EventHandler.h:
- 2:03 PM Changeset in webkit [47593] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Kevin Ollivier.
Check for null bundle before attempting to use it.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath): Add null check on return of
CFBundleGetBundleWithIdentifier.
- 1:12 PM Changeset in webkit [47592] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Use a helper function to work around winscw compiler forward declaration bug
regarding templated classes.
Add parenthesis around (PassRefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw
specific bool cast hack.
- wtf/PassRefPtr.h: (WTF::derefIfNotNull): (WTF::PassRefPtr::~PassRefPtr):
- 12:56 PM Changeset in webkit [47591] by
-
- 2 edits in trunk/WebKitTools
Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
Reviewed by Adele Peterson.
- DumpRenderTree/AccessibilityUIElement.cpp:
(attributeValueCallback):
- 12:52 PM Changeset in webkit [47590] by
-
- 7 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28497, images and inline replaced elements don't propagate overflow properly on a line.
Reviewed by Dan Bernstein.
Added fast/repaint/inline-block-overflow.html and updated another test.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeVerticalOverflow):
Make sure to still propagate the border box of the replaced element as layout overflow when overflow clip is set on the
replaced element. Make sure to use the InlineBox x/y positions instead of the RenderBox x/y, since the position of the
RenderBox has not been updated to the new values yet.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
Don't use the root line box's overflow. Use the actual line box overflow values instead. In the case of an inline
with a layer, our overflow didn't propagate to the root line, so we always need to use our values.
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
Make sure to clear shadow overflow when doing layout of replaced elements, so that we don't leave a stale overflow
value around if a box-shadow goes away.
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28497, images don't propagate overflow properly when they change
size on a line.
Reviewed by Dan Bernstein.
Add a new layout test and update an existing layout test.
- fast/repaint/inline-block-resize.html: Added.
- platform/mac/fast/repaint/inline-block-resize-expected.checksum: Added.
- platform/mac/fast/repaint/inline-block-resize-expected.png: Added.
- platform/mac/fast/repaint/inline-block-resize-expected.txt: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- 12:44 PM Changeset in webkit [47589] by
-
- 2 edits in trunk/WebCore
Another attempt to fix Chromium build.
- WebCore.gypi: now use the correct name of the image file.
- 12:38 PM Changeset in webkit [47588] by
-
- 2 edits in trunk/WebCore
Make the Windows build even fixeder
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::flush):
- 12:36 PM Changeset in webkit [47587] by
-
- 2 edits in trunk/WebCore
Not reviewed, Chromium build fix.
- WebCore.gypi: add new Webinspector image files (localStorage.png and sessionStorage.png)
- 12:34 PM Changeset in webkit [47586] by
-
- 2 edits in trunk/WebCore
Windows build fix after the last change
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::releaseWindowsContext):
(WebCore::GraphicsContext::drawWindowsBitmap):
- 12:24 PM Changeset in webkit [47585] by
-
- 17 edits in trunk/WebCore
Replace many manually-released CFTypeRefs with RetainPtrs
https://bugs.webkit.org/show_bug.cgi?id=28498
Reviewed by Geoffrey Garen.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::createCGColor):
- platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformGradient):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::dataChanged):
- platform/graphics/cg/PathCG.cpp:
(WebCore::createScratchContext):
(WebCore::Path::contains):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::getTIFFRepresentation):
- platform/mac/ClipboardMac.mm:
(WebCore::cocoaTypeFromMIMEType):
(WebCore::MIMETypeFromCocoaType):
- platform/mac/WebCoreNSStringExtras.mm:
(stringEncodingForResource):
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream):
(WebCore::setHTTPBody):
- platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::encode):
- 11:34 AM Changeset in webkit [47584] by
-
- 2 edits in trunk/WebKitSite
2009-08-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
major-objects.html should show direct Frame <-> Document pointers
https://bugs.webkit.org/show_bug.cgi?id=28479
- coding/major-objects.html: Added pointers to diagram.
- 11:27 AM Changeset in webkit [47583] by
-
- 2 edits in trunk/WebCore
2009-08-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Output actual values of counters in showTree
https://bugs.webkit.org/show_bug.cgi?id=28481
No new tests because this patch just improves debugging outputs.
- rendering/CounterNode.cpp: (WebCore::showTreeAndMark):
- 11:04 AM Changeset in webkit [47582] by
-
- 19 edits in trunk/JavaScriptCore
Roll out r47571 and related build fixes as it caused us to leak the world without warning.
- 10:53 AM Changeset in webkit [47581] by
-
- 2 edits in trunk/WebCore
2009-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (build fix).
Add file missed in last check-in.
- html/HTMLAttributeNames.in:
- 10:45 AM Changeset in webkit [47580] by
-
- 4 edits2 adds1 delete in trunk/WebCore
Adds new icons to the Web Inspector for Local Storage,
Session Storage and Cookies.
https://bugs.webkit.org/show_bug.cgi?id=28470
Reviewed by Eric Seidel.
- inspector/front-end/DatabasesPanel.js:
(WebInspector.DatabasesPanel.prototype.addDOMStorage):
(WebInspector.DOMStorageSidebarTreeElement):
- inspector/front-end/Images/cookie.png:
- inspector/front-end/Images/domStorage.png: Removed.
- inspector/front-end/Images/localStorage.png: Added.
- inspector/front-end/Images/sessionStorage.png: Added.
- inspector/front-end/inspector.css:
- 10:21 AM Changeset in webkit [47579] by
-
- 10 edits in trunk
2009-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Anders Carlsson.
HTML5 media elements must fire 'loadend' progress event
https://bugs.webkit.org/show_bug.cgi?id=28419
- dom/EventNames.h:
Define loadend.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute):
Deal with onloadend.
(WebCore::HTMLMediaElement::loadInternal):
Post 'loadend' immediately after 'abort'.
(WebCore::HTMLMediaElement::noneSupported):
Post 'loadend' immediately after 'error'.
(WebCore::HTMLMediaElement::mediaEngineError):
Ditto.
(WebCore::HTMLMediaElement::setNetworkState):
Post 'loadend' immediately after 'load'.
(WebCore::HTMLMediaElement::userCancelledLoad):
Post 'loadend' immediately after 'abort'.
2009-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Anders Carlsson.
HTML5 media elements must fire 'loadend' progress event
https://bugs.webkit.org/show_bug.cgi?id=28419
Add 'loadend' to existing tests.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- media/media-load-event-expected.txt:
- media/media-load-event.html:
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html:
- 10:18 AM Changeset in webkit [47578] by
-
- 3 edits2 adds in trunk
2009-08-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGESSION(r45316), Crash: WebKit crashes in Google Sites when indenting a table
https://bugs.webkit.org/show_bug.cgi?id=28474
This patch adds a test to make sure WebKit does not crash when indenting immediately right to a table.
- editing/execCommand/indent-right-after-table-expected.txt: Added.
- editing/execCommand/indent-right-after-table.html: Added.
2009-08-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGESSION(r45316), Crash: WebKit crashes in Google Sites when indenting a table
https://bugs.webkit.org/show_bug.cgi?id=28474
This patch fixes a crash when indenting at right after a table.
The bug was caused by Node* blockNode = enclosingBlock(endOfCurrentParagraph.deepEquivalent().node());
where node() is equal to blockNode. Because blockNode is the enclosing block node, this patch changes it to
enclosingBlock(endOfCurrentParagraph.deepEquivalent().node()->parentNode());
Test: editing/execCommand/indent-right-after-table.html
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Fixed so that blockNode != endOfCurrentParagraph.deepEquivalent().node()
- 10:11 AM Changeset in webkit [47577] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Use FrameLoader::load() for loading pages from a HTML page string to address
bugs with using begin/write/end loading.
https://bugs.webkit.org/show_bug.cgi?id=28488
- 10:10 AM Changeset in webkit [47576] by
-
- 2 edits in trunk/WebCore
2009-08-20 Andrew Scherkus <scherkus@chromium.org>
Reviewed by David Levin.
Render disabled mute button during an error or if no audio is present.
Covered by existing layout tests:
media/video-controls-visible-audio-only.html
media/video-no-audio.html
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
- 7:38 AM Changeset in webkit [47575] by
-
- 4 edits in trunk/JavaScriptCore
Try to fix Windows build.
Patch by Darin Adler <Darin Adler> on 2009-08-20
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed all exports involving the class FunctionBodyNode.
- 7:36 AM Changeset in webkit [47574] by
-
- 2 edits in trunk/WebKitTools
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed, build fix.
[Qt] The template-based qMax() compares two qreals.
- DumpRenderTree/qt/ImageDiff.cpp: (main):
- 7:32 AM Changeset in webkit [47573] by
-
- 3 edits in trunk/JavaScriptCore
Try to fix Windows build.
Patch by Darin Adler <Darin Adler> on 2009-08-20
- parser/ParserArena.cpp:
(JSC::ParserArena::derefWithArena): Make non-inline.
- parser/ParserArena.h: Ditto.
- 7:28 AM Changeset in webkit [47572] by
-
- 22 edits in trunk/LayoutTests
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Update the (outdated) metrics for css1 padding and margin tests. All tests pass.
- platform/qt/Skipped: Excluded passed tests.
- platform/qt/css1/box_properties/margin-expected.txt:
- platform/qt/css1/box_properties/margin_bottom-expected.txt:
- platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/margin_inline-expected.txt:
- platform/qt/css1/box_properties/margin_left-expected.txt:
- platform/qt/css1/box_properties/margin_left_inline-expected.txt:
- platform/qt/css1/box_properties/margin_right-expected.txt:
- platform/qt/css1/box_properties/margin_right_inline-expected.txt:
- platform/qt/css1/box_properties/margin_top-expected.txt:
- platform/qt/css1/box_properties/margin_top_inline-expected.txt:
- platform/qt/css1/box_properties/padding-expected.txt:
- platform/qt/css1/box_properties/padding_bottom-expected.txt:
- platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/padding_inline-expected.txt:
- platform/qt/css1/box_properties/padding_left-expected.txt:
- platform/qt/css1/box_properties/padding_left_inline-expected.txt:
- platform/qt/css1/box_properties/padding_right-expected.txt:
- platform/qt/css1/box_properties/padding_right_inline-expected.txt:
- platform/qt/css1/box_properties/padding_top-expected.txt:
- platform/qt/css1/box_properties/padding_top_inline-expected.txt:
- 7:24 AM Changeset in webkit [47571] by
-
- 17 edits in trunk/JavaScriptCore
Syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
Patch by Darin Adler <Darin Adler> on 2009-08-20
Reviewed by Gavin Barraclough.
Use an actual arena now. 0.7% speedup on SunSpider.
- JavaScriptCore.exp: Removed FunctionBodyNode::create, which no
longer needs to be used outside JavaScriptCore.
- JavaScriptCore.xcodeproj/project.pbxproj: Made Nodes.h and
Executable.h project-internal instead of "private".
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
contains const Identifier* now.
- parser/Grammar.y: Made identifiers from the lexer be const
Identifier* and updated since VarStack contains const Identifier* now.
- parser/Lexer.cpp:
(JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
(JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
and changed to call ParserArena.
(JSC::Lexer::clear): Removed the code to manage m_identifiers and
added code to set m_arena to 0.
- parser/Lexer.h: Updated for changes above.
- parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
on the arena.
(JSC::ParserArenaDeletable::operator new): Changed to call the
allocateDeletable function on the arena instead of deleteWithArena.
(JSC::PropertyNode::PropertyNode): Added new constructor that makes
numeric identifiers. Some day we might want to optimize this for
integers so it doesn't create a string for each one.
(JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
since it's now a const Identifier& so it can't be left uninitialized.
(JSC::BreakNode::BreakNode): Ditto.
(JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
to keep track of the statements rather than a separate statement vector.
(JSC::BlockNode::BlockNode): Ditto.
(JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
- parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
It seemed strangely out of place in the header.
(JSC::ThrowableExpressionData::emitThrowError): Added an overload for
UString as well as Identifier.
(JSC::SourceElements::singleStatement): Added.
(JSC::SourceElements::lastStatement): Added.
(JSC::RegExpNode::emitBytecode): Changed the throwError code to use
the substitution mechanism instead of doing a string append.
(JSC::SourceElements::emitBytecode): Added. Replaces the old
statementListEmitCode function, since we now keep the SourceElements
objects around.
(JSC::BlockNode::lastStatement): Added.
(JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
statementListEmitCode.
(JSC::CaseClauseNode::emitBytecode): Added.
(JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
instead of statementListEmitCode.
(JSC::ScopeNodeData::ScopeNodeData): Changed to store the
SourceElements* instead of using releaseContentsIntoVector.
(JSC::ScopeNode::emitStatementsBytecode): Added.
(JSC::ScopeNode::singleStatement): Added.
(JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
of statementListEmitCode.
(JSC::EvalNode::emitBytecode): Ditto.
(JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
insetad of statementListEmitCode and check for the return node using
the new functions.
- parser/Nodes.h: Changed VarStack to store const Identifier* instead
of Identifier and rely on the arena to control lifetime. Added a new
ParserArenaFreeable class. Made ParserArenaDeletable inherit from
FastAllocBase instead of having its own operator new. Base the Node
class on ParserArenaFreeable. Changed the various Node classes
to use const Identifier& instead of Identifier to avoid the need to
call their destructors and allow them to function as "freeable" in the
arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
as a base class since they do not descend from Node. Eliminated the
StatementVector type and instead have various classes use SourceElements*
instead of StatementVector. This prevents those classes from having to
use ParserArenaDeletable to make sure the vector destructor is called.
- parser/Parser.cpp:
(JSC::Parser::parse): Pass the arena to the lexer.
- parser/Parser.h: Added an include of ParserArena.h, which is no longer
included by Nodes.h.
(JSC::Parser::parseFunctionFromGlobalCode): Changed to use the
singleStatement function, since there is no longer any children function.
Removed some unneeded use of RefPtr.
- parser/ParserArena.cpp:
(JSC::ParserArena::ParserArena): Added. Initializes the new members,
m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
(JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
since we store only the current pointer and the end of pool pointer.
(JSC::ParserArena::deallocateObjects): Added. Contains the common
memory-deallocation logic used by both the destructor and the
reset function.
(JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
(JSC::ParserArena::reset): Ditto. Also added code to zero out the
new structures, and switched to use clear() instead of shrink(0) since
we don't really reuse arenas.
(JSC::ParserArena::makeNumericIdentifier): Added.
(JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
is empty.
(JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
since this is used only for assertions at the moment.
- parser/ParserArena.h: Added an actual arena of "freeable" objects,
ones that don't need destructors to be called. Also added a separate
IdentifierArena object, a segmented vector of identifiers that used
to be in the Lexer.
- runtime/Executable.h: Moved the definition of the
FunctionExecutable::make function here. It can't go in JSFunction.h
since that header has to be used outside JavaScriptCore and so can't
include this, which includes Nodes.h. The function could be moved
elswhere if we don't want to include JSFunction.h in this header, but
for now this seems to be the best place.
- runtime/JSFunction.h: Removed the include of Executable.h and
definition of the FunctionExecutable::make function.
- wtf/FastMalloc.cpp: Fixed an incorrect comment.
- 7:11 AM Changeset in webkit [47570] by
-
- 8 edits in trunk
WebCore: <rdar://problem/7154605> Loading page with 1px wide <select> makes the
toolbar go blank
and
<rdar://problem/7154521> Lots of "<Error>: doClip: empty path." spew in
the console with certain content
Reviewed by Darin Adler.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Return early
if the rectangle is empty. Use RenderStyle::getBorderRadiiForRect() to
adjust the radii in case the sides of the rectangle are smaller than sum
of the radii, so that the gradient background matches the border (which
already uses getBorderRadiiForRect()). Check if bottomGradient is empty
to avoid clipping to an empty path.
(WebCore::RenderThemeMac::paintMenuListButton): Moved a
GraphicContext::save() down to avoid a save/restore imbalance in the
early return case.
- rendering/RenderThemeSafari.cpp: Made the same changes.
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
LayoutTests: Updated results after fixing
<rdar://problem/7154605> Loading page with 1px wide <select> makes the
toolbar go blank
and
<rdar://problem/7154521> Lots of "<Error>: doClip: empty path." spew in
the console with certain content
Reviewed by Darin Adler.
- platform/mac/fast/forms/001-expected.checksum:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
- platform/mac/fast/forms/menulist-narrow-width-expected.png:
- 6:40 AM Changeset in webkit [47569] by
-
- 4 edits in trunk
2009-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143
http/tests/xmlhttprequest/small-chunks-response-text.html
- Enable test fixed by this patch.
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html
http/tests/xmlhttprequest/cache-override.html
- Enable tests already passing.
Updated patch originally by Gustavo Noronha.
- platform/gtk/Skipped:
Disable sniffing if it's explicitly requested. Updated patch
originally by Gustavo Noronha.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::statusWillBeHandledBySoup): (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::gotChunkCallback): (WebCore::startHttp):
- 6:20 AM Changeset in webkit [47568] by
-
- 2 edits in trunk/WebCore
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Swap the pixels since QImage expect ARGB while ImageData
stores them as RGBA.
This fixes the fast/canvas/canvas-copyPixels.html test.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::putImageData):
- 6:00 AM Changeset in webkit [47567] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-08-20 Dirk Schulze <krit@webkit.org>
Reviewed by Ariya Hidayat.
Check if the combination of getImageData and the afterward use of putImageData
still gives the right result.
- fast/canvas/canvas-copyPixels-expected.txt: Added.
- fast/canvas/canvas-copyPixels.html: Added.
- fast/canvas/resources/canvas-copyPixels.js: Added.
- 4:23 AM Changeset in webkit [47566] by
-
- 3 edits in trunk/LayoutTests
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Of course we pass ACID1 tests. Update the metrics.
- platform/qt/Skipped:
- platform/qt/css1/box_properties/acid_test-expected.txt:
- 4:19 AM Changeset in webkit [47565] by
-
- 26 edits in trunk/LayoutTests
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Update the (outdated) metrics for css1 borders tests. All tests pass.
- platform/qt/Skipped: Excluded passed tests.
- platform/qt/css1/box_properties/border-expected.txt:
- platform/qt/css1/box_properties/border_bottom-expected.txt:
- platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/border_bottom_width-expected.txt:
- platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_color-expected.txt:
- platform/qt/css1/box_properties/border_color_inline-expected.txt:
- platform/qt/css1/box_properties/border_inline-expected.txt:
- platform/qt/css1/box_properties/border_left-expected.txt:
- platform/qt/css1/box_properties/border_left_inline-expected.txt:
- platform/qt/css1/box_properties/border_left_width-expected.txt:
- platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_right-expected.txt:
- platform/qt/css1/box_properties/border_right_inline-expected.txt:
- platform/qt/css1/box_properties/border_right_width-expected.txt:
- platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_style-expected.txt:
- platform/qt/css1/box_properties/border_style_inline-expected.txt:
- platform/qt/css1/box_properties/border_top-expected.txt:
- platform/qt/css1/box_properties/border_top_inline-expected.txt:
- platform/qt/css1/box_properties/border_top_width-expected.txt:
- platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_width-expected.txt:
- platform/qt/css1/box_properties/border_width_inline-expected.txt:
- 3:55 AM Changeset in webkit [47564] by
-
- 9 edits in trunk/LayoutTests
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Update the (outdated) metrics for css1/basic tests. All tests pass.
- platform/qt/Skipped: Excluded passed tests.
- platform/qt/css1/basic/class_as_selector-expected.txt:
- platform/qt/css1/basic/comments-expected.txt:
- platform/qt/css1/basic/containment-expected.txt:
- platform/qt/css1/basic/contextual_selectors-expected.txt:
- platform/qt/css1/basic/grouping-expected.txt:
- platform/qt/css1/basic/id_as_selector-expected.txt:
- platform/qt/css1/basic/inheritance-expected.txt:
- 3:40 AM Changeset in webkit [47563] by
-
- 2 edits in trunk/WebKitTools
bugzilla-tool patch retrieval should handle 302 redirects.
https://bugs.webkit.org/show_bug.cgi?id=28485
Patch by David Levin <levin@chromium.org> on 2009-08-20
Reviewed by David Kilzer.
- Scripts/modules/scm.py: Pass the --location parameter to curl
so that 302's are followed.
- 3:13 AM Changeset in webkit [47562] by
-
- 5 edits in trunk/WebCore
[v8] Use atomic string caching for createElement
Extend atomic string caching to createElement. Fix a bug in idl
parser that caused incorrect parsing if a function argument
attribute list contained a comma.
https://bugs.webkit.org/show_bug.cgi?id=28449
Patch by Christian Plesner Hansen <christian.plesner.hansen@gmail.com> on 2009-08-20
Reviewed by David Levin.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLParser.pm:
- bindings/v8/V8Binding.h:
(WebCore::v8ValueToAtomicWebCoreStringWithNullCheck):
- dom/Document.idl:
- 3:06 AM Changeset in webkit [47561] by
-
- 8 edits in trunk/LayoutTests
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Update the metrics after recent refactoring. All tests pass.
- platform/qt/fast/box-shadow/basic-shadows-expected.txt:
- platform/qt/fast/box-shadow/transform-fringing-expected.txt:
- platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
- platform/qt/fast/images/image-in-map-expected.txt:
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 2:37 AM Changeset in webkit [47560] by
-
- 2 edits in trunk/WebCore
2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Not reviewed, build fix after r47515.
[Qt] There is no Phonon::MediaObject::hasAudio() function.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::hasAudio): Assume true.
- 1:22 AM Changeset in webkit [47559] by
-
- 2 edits in trunk/WebKitTools
One more speculative build for gtk.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-20
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- 1:12 AM Changeset in webkit [47558] by
-
- 5 edits in trunk
WebKit/gtk: Hopefully the last speculative build for gtk.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-20
- webkit/webkitprivate.cpp:
(webkit_white_list_access_from_origin):
- webkit/webkitprivate.h:
WebKitTools: Speculative build for gtk.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-20
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::whiteListAccessFromOrigin):
- 12:47 AM Changeset in webkit [47557] by
-
- 2 edits in trunk/WebKitTools
Ignore some leaks that are known to originate from ImageIO.
- Scripts/run-webkit-tests:
- 12:29 AM Changeset in webkit [47556] by
-
- 3 edits in trunk/WebCore
2009-08-20 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28483
The V8 ScriptController's cleanupScriptObjectsForPlugin should take a
Widget* instead of void* to avoid the need for manual casting to Widget*
at the callsite.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
- bindings/v8/ScriptController.h:
- 12:25 AM Changeset in webkit [47555] by
-
- 3 edits in trunk/WebKitTools
With David Levin.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-20
Speculative build fix for qt.
- DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::whiteListAccessFromOrigin):
- DumpRenderTree/qt/jsobjects.h:
- 12:14 AM Changeset in webkit [47554] by
-
- 2 edits in trunk/WebKit/gtk
Another speculative build for gtk.
Patch by David Levin <levin@chromium.org> on 2009-08-20
- webkit/webkitprivate.cpp:
(webkit_white_list_access_to_origin):
- 12:02 AM Changeset in webkit [47553] by
-
- 2 edits in trunk/WebKit/gtk
Speculative build for gtk.
Patch by David Levin <levin@chromium.org> on 2009-08-20
- webkit/webkitprivate.cpp:
(webkit_white_list_access_to_origin):
Aug 19, 2009:
- 11:57 PM Changeset in webkit [47552] by
-
- 3 edits in trunk/WebKit/qt
Speculative build break fix for qt.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
- Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::whiteListAccessFromOrigin):
- Api/qwebsecurityorigin.h:
- 11:54 PM Changeset in webkit [47551] by
-
- 6 edits in trunk
Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
Reviewed by Dan Bernstein.
WebKit/mac:
When the plug-in data is being loaded manually there is a reference cycle between the
NetscapePluginInstanceProxy and the HostedNetscapePluginStream. We need to explicitly
break the reference cycle in NetscapePluginInstanceProxy::cleanup so that both objects
will be destroyed.
Take the opportunity to add RefCountedLeakCounter support to HostedNetscapePluginStream
and NetscapePluginInstanceProxy to simplify tracking down leaks of these objects in the future.
- Plugins/Hosted/HostedNetscapePluginStream.h:
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
(WebKit::HostedNetscapePluginStream::~HostedNetscapePluginStream):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
(WebKit::NetscapePluginInstanceProxy::cleanup): Clear m_manualStream to break the reference
cycle.
WebKitTools:
Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
- Scripts/check-for-global-initializers:
- 11:49 PM Changeset in webkit [47550] by
-
- 2 edits in trunk/WebKit/gtk
Fix build break.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
- webkit/webkitprivate.h: "WEBKIT API" -> "WEBKIT_API"
- 11:42 PM Changeset in webkit [47549] by
-
- 2 edits in trunk/WebCore
Unreviewed speculative build fix for qt.
Patch by David Levin <levin@chromium.org> on 2009-08-19
- page/OriginAccessEntry.cpp:
- 11:28 PM Changeset in webkit [47548] by
-
- 31 edits15 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
Tests: http/tests/xmlhttprequest/origin-whitelisting-all.html
http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
http/tests/xmlhttprequest/origin-whitelisting-https.html
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
- WebCore.base.exp: Export methods to manipulate origin access whitelists to enable
testing via layout tests.
- WebCore.xcodeproj/project.pbxproj: Add OriginAccessEntry.*
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCoreSources.blk: Ditto.
- page/SecurityOrigin.h: Implement origin access whitelists.
(WebCore::originAccessMap): Static getter for access whitelists.
(WebCore::SecurityOrigin::canRequest): Modify request checking logic to check whitelists.
(WebCore::SecurityOrigin::whiteListAccessFromOrigin): Add an entry to a whitelist.
(WebCore::SecurityOrigin::resetOriginAccessWhiteLists): Clear all the whitelists.
- page/OriginAccessEntry.h: Added. An entry in an origin access whitelist.
- page/OriginAccessEntry.cpp: Ditto.
WebKit/gtk: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
- webkit/webkitprivate.cpp:
(webkit_white_list_access_to_origin): Add API to manipulate origin access whitelists.
(webkit_reset_origin_access_white_lists): Ditto.
- webkit/webkitprivate.h: Ditto.
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
- WebView/WebView.mm: Add SPI to manipulate origin access whitelists.
(+[WebView _whiteListAccessFromOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): Ditto.
(+[WebView _resetOriginAccessWhiteLists]): Ditto.
- WebView/WebViewPrivate.h: Ditto.
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
- Api/qwebsecurityorigin.cpp: Add API to manipulate origin access whitelists.
(QWebSecurityOrigin::whiteListAccessFromOrigin): Ditto.
(QWebSecurityOrigin::resetOriginAccessWhiteLists): Ditto.
- Api/qwebsecurityorigin.h: Ditto.
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
- DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
(whiteListAccessFromOriginCallback): Ditto.
(LayoutTestController::staticFunctions): Ditto.
- DumpRenderTree/LayoutTestController.h: Ditto.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
(LayoutTestController::whiteListAccessToOrigin): Ditto.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
(LayoutTestController::whiteListAccessFromOrigin): Ditto.
- DumpRenderTree/qt/jsobjects.cpp: Ditto.
(LayoutTestController::whiteListAccessFromOrigin): Ditto.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
(LayoutTestController::whiteListAccessFromOrigin): Ditto.
- DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
(resetWebViewToConsistentStateBeforeTesting): Ditto.
- DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
(resetWebViewToConsistentStateBeforeTesting): Ditto.
- DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
specify a more granular policy for cross-origin XHR access.
Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
Reviewed by David Levin.
- http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-all.html: Added.
- http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: Added.
- http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-https.html: Added.
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: Added.
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: Added.
- http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt: Added.
- http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Added.
- http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html: Added.
- 9:58 PM Changeset in webkit [47547] by
-
- 2 edits in trunk/WebCore
Non-precomp headers build fix.
- 8:51 PM Changeset in webkit [47546] by
-
- 2 edits in trunk/WebCore
2009-08-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Disable a bad SKIA assert
https://bugs.webkit.org/show_bug.cgi?id=28482
In http://trac.webkit.org/changeset/47386/ an assert was "fixed" in SKIA code.
When this was pulled into Chromium, it started breaking the page cycler.
Disable it again until we can figure out what's going on.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
- 8:23 PM Changeset in webkit [47545] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by Dan Bernstein.
Ignore some leaks that are known to originate from QTKit.
- Scripts/run-webkit-tests:
- 7:40 PM Changeset in webkit [47544] by
-
- 1 edit6 deletes in trunk/LayoutTests
No review.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Delete files that should have been deleted in http://trac.webkit.org/changeset/47542.
- platform/mac/editing/style/remove-underline-after-paragraph-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-expected.txt: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-after-paragraph-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Removed.
- 7:34 PM Changeset in webkit [47543] by
-
- 3 edits2 adds6 deletes in trunk/LayoutTests
underline tests in /editing/style/ need not to be pixel tests but need to print markup
https://bugs.webkit.org/show_bug.cgi?id=28471
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Reviewed by Eric Seidel.
- editing/style/remove-underline-across-paragraph-expected.txt: Added.
- editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
- editing/style/remove-underline-across-paragraph-in-bold.html:
- editing/style/remove-underline-across-paragraph.html:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-across-paragraph-expected.png: Removed.
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt: Removed.
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.png: Removed.
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-across-paragraph-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Removed.
- 7:24 PM Changeset in webkit [47542] by
-
- 9 edits2 adds in trunk/LayoutTests
underline tests in /editing/style/ need not to be pixel tests but need to print markup
https://bugs.webkit.org/show_bug.cgi?id=28471
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Reviewed by Eric Seidel.
This patch converts the following tests to dumpAsText tests using runDumpAsTextEditingTest
- editing/style/remove-underline-after-paragraph-expected.txt: Added.
- editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Added.
- editing/style/remove-underline-after-paragraph-in-bold.html:
- editing/style/remove-underline-after-paragraph.html:
- platform/mac/editing/style/remove-underline-after-paragraph-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-expected.png: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-expected.txt: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.png: Removed.
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-after-paragraph-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Removed.
- 7:14 PM Changeset in webkit [47541] by
-
- 3 edits5 adds in trunk
WebCore: queryCommandState('underline') returns false if the selected text is also bold and italic
https://bugs.webkit.org/show_bug.cgi?id=11022
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Reviewed by Darin Adler.
This patch modifies stateStrikethrough and stateUnderline to use the value -webkit-text-decorations-in-effect
instead of text-decoration. Because text-decoration only retrieves explicit styling at the node on which
the query was sent, we need to use -webkit-text-decorations-in-effect to include decorations added by ancestors
and also u, s, and strike tags.
Test: editing/style/text-decoration-state.html
- editing/EditorCommand.cpp:
(WebCore::stateStrikethrough): Use -webkit-test-decorations-in-effect instead of text-decoration.
(WebCore::stateUnderline): Ditto.
LayoutTests: queryCommandState('underline') returns false if the selected text is also bold and italic
https://bugs.webkit.org/show_bug.cgi?id=11022
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Reviewed by Darin Adler.
This patch adds a test to make sure queryCommandState returns correct boolean value for underline and strikethrough.
- editing/style/resources: Added.
- editing/style/resources/TEMPLATE.html: Added.
- editing/style/resources/text-decoration-state.js: Added.
(textdecorationState):
- editing/style/text-decoration-state-expected.txt: Added.
- editing/style/text-decoration-state.html: Added.
- 6:58 PM Changeset in webkit [47540] by
-
- 3 edits in trunk/WebKitTools
2009-08-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue/bugzilla-tool can get wedged if git is mid-rebase
https://bugs.webkit.org/show_bug.cgi?id=28436
Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
This code will only ever be run when --force-clean is passed.
I also added a new unit test to make sure this code actually works. :)
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 6:00 PM Changeset in webkit [47539] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:59 PM Changeset in webkit [47538] by
-
- 1 copy in tags/Safari-6531.14
New tag.
- 5:57 PM Changeset in webkit [47537] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47535.
- 5:57 PM Changeset in webkit [47536] by
-
- 6 edits in branches/safari-4-branch/WebCore
Merge r47531.
- 5:47 PM Changeset in webkit [47535] by
-
- 2 edits in trunk/WebCore
- Fix <rdar://problem/7155710>
HTML selects on windows cause containing window to become inactive when opened.
Patch by Anders Carlsson <andersca@apple.com> on 2009-08-19
Reviewed by Darin Adler.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
Pass SWP_NOACTIVATE to SetWindowPos, remove AW_ACTIVATE from AnimateWindow and pass
SW_SHOWNOACTIVATE to ShowWindow.
(WebCore::PopupWndProc):
Prevent mouse activation from activating the window.
- 5:45 PM Changeset in webkit [47534] by
-
- 2 edits in trunk/WebCore
2009-08-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Images flash as you hover them on http://www.atebits.com/scribbles/
<rdar://problem/7143958>
Tag images with the device colorspace with the colorspace of the main display, rather than
GenericRGB, so that composited images color-match those rendered via Core Graphics.
Covered by LayoutTests/compositing/color-matching/image-color-matching.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
- 5:14 PM Changeset in webkit [47533] by
-
- 4 edits2 adds8 deletes in trunk/LayoutTests
underline tests in /editing/style/ need not to be pixel tests but need to print markup
https://bugs.webkit.org/show_bug.cgi?id=28471
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-19
Reviewed by Eric Seidel.
This patch converts editing/style/underline.html and editing/style/remove-underline.html to a dumpAsText test.
It also adds runDumpAsTextEditingTest which invokes a new testing mode.
runDumpAsTextEditingTest calls user-defined editingTest just like runEditingTest but does not enable editing delegates by default.
It logs innerHTML of the node with id "root" whenever the DOM is changed by exec* functions with the name of function in front.
It should be used in tests where logging of selection and caret positions is not required but logging
of how DOM changed over editing operations is required.
- editing/editing.js:
(debugForDumpAsText): logs innerHTML of the node with id "root" when using runDumpAsTextEditingTest
(execBoldCommand): Calls debugForDumpAsText
(execUnderlineCommand): ditto
(execFontNameCommand): ditto
(execFontSizeCommand): ditto
(execFontSizeDeltaCommand): ditto
(execItalicCommand): ditto
(execJustifyCenterCommand): ditto
(execJustifyLeftCommand): ditto
(execJustifyRightCommand): ditto
(execInsertHTMLCommand): ditto
(execInsertImageCommand): ditto
(execInsertLineBreakCommand): ditto
(execInsertParagraphCommand): ditto
(execInsertNewlineInQuotedContentCommand): ditto
(execTypeCharacterCommand): ditto
(execStrikethroughCommand): ditto
(execUndoCommand): ditto
(execRedoCommand): ditto
(execCutCommand): ditto
(execPasteCommand): ditto
(execPasteAndMatchStyleCommand): ditto
(execCreateLinkCommand): ditto
(execUnlinkCommand): ditto
(execDeleteCommand): ditto
(execForwardDeleteCommand): ditto
(execBackColorCommand): ditto
(runDumpAsTextEditingTest): Added.
- editing/style/remove-underline-expected.txt: Added.
- editing/style/remove-underline.html:
- editing/style/underline-expected.txt: Added.
- editing/style/underline.html:
- 5:13 PM Changeset in webkit [47532] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-08-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
https://bugs.webkit.org/show_bug.cgi?id=28222
Basic support for now. This has been in testing for 24 hours now and worked great!
- Scripts/bugzilla-tool:
- Scripts/modules/buildbot.py: Added.
- Scripts/modules/buildbot_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 5:04 PM Changeset in webkit [47531] by
-
- 6 edits in trunk/WebCore
- Fix <rdar://problem/7152589> Stylable scrollbar corners aren't working.
Reviewed by David Hyatt and Dan Bernstein.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Initialize m_scrollCorner.
(WebCore::FrameView::~FrameView):
Assert that m_scrollCorner is null.
(WebCore::FrameView::detachCustomScrollbars):
Destroy m_scrollCorner.
(WebCore::FrameView::invalidateScrollCorner):
Invalidate the scroll corner.
(WebCore::FrameView::updateScrollCorner):
Create/destroy the scroll corner.
(WebCore::FrameView::paintScrollCorner):
Paint the scroll corner.
- page/FrameView.h:
(WebCore::FrameView::isFrameViewScrollCorner):
Return whether a RenderScrollbarPart is the frame view scroll corner.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Go ahead and update the scroll corner.
(WebCore::ScrollView::setScrollbarsSuppressed):
Pass the scroll corner rect to invalidateRect.
(WebCore::ScrollView::scrollCornerRect):
Return the scroll corner rect.
- platform/ScrollView.h:
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::imageChanged):
If this scrollbar part is the frame view scroll corner, invalidate it.
- 5:02 PM Changeset in webkit [47530] by
-
- 16 edits in trunk/JavaScriptCore
2009-08-19 Yong Li <yong.li@torchmobile.com>
Reviewed by Gavin Barraclough.
Change namespace ARM to ARMRegisters
X86 to X86Registers to avoid conflict with macros
https://bugs.webkit.org/show_bug.cgi?id=28428
- assembler/ARMAssembler.cpp:
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerX86Common.h:
- assembler/MacroAssemblerX86_64.h:
- assembler/X86Assembler.h:
- jit/JIT.h:
- jit/JITArithmetic.cpp:
- jit/JITInlineMethods.h:
- jit/JITOpcodes.cpp:
- wrec/WRECGenerator.cpp:
- wrec/WRECGenerator.h:
- yarr/RegexJIT.cpp:
- 3:33 PM Changeset in webkit [47529] by
-
- 2 edits in trunk/WebCore
2009-08-19 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG feComponentTransfer needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27768
Implementation of SVG Filter feComponentTransfer.
There is already a test case
Test: svg/W3C-SVG-1.1/filters-comptran-01-b.svg
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::identity): (WebCore::table): (WebCore::discrete): (WebCore::linear): (WebCore::gamma): (WebCore::FEComponentTransfer::apply):
- 2:44 PM Changeset in webkit [47528] by
-
- 5 edits4 adds in trunk
WebCore: <rdar://problem/7141522> Incorrect layout of product table at henry.com
Reviewed by Dave Hyatt.
Test: fast/block/basic/quirk-percent-height-table-cell.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcPercentageHeight): Tweak the quirk that allows
percentage-height children of auto-height blocks to look for an ancestor
with non-auto height and compute their height based on it. The change is
that if that ancestor is a table cell, it is ignored and the percent
height computes to zero (just like in strict mode). This matches Firefox
and IE.
LayoutTests: Test and updated results for
<rdar://problem/7141522> Incorrect layout of product table at henry.com
Patch by Dan Bernstein <mitz@apple.com> on 2009-08-19
Reviewed by Dave Hyatt.
- fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Added.
- fast/block/basic/quirk-percent-height-table-cell-expected.png: Added.
- fast/block/basic/quirk-percent-height-table-cell-expected.txt: Added.
- fast/block/basic/quirk-percent-height-table-cell.html: Added.
- fast/replaced/table-percent-height-text-controls-expected.txt:
- fast/replaced/table-percent-height-text-controls.html:
- 2:35 PM Changeset in webkit [47527] by
-
- 2 edits in trunk/WebCore
2009-08-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
Add 'icu::' qualifier when refering to ICU C++ names to the other
file with this issue missed in the previous check-in.
No change in the test result.
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::):
- 1:56 PM Changeset in webkit [47526] by
-
- 2 edits in trunk/WebCore
Unreviewed (build fix for Skia).
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLine):
- 1:30 PM Changeset in webkit [47525] by
-
- 11 edits in trunk/WebCore
2009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel.
[CAIRO] Remove setFont indirection
https://bugs.webkit.org/show_bug.cgi?id=28453
Remove the indirection and just set the font in Font::drawGlyphs.
- platform/graphics/SimpleFontData.h:
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/FontPlatformData.h: (WebCore::FontPlatformData::scaledFont):
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/gtk/FontPlatformDataPango.cpp:
- platform/graphics/gtk/SimpleFontDataGtk.cpp:
- platform/graphics/gtk/SimpleFontDataPango.cpp:
- platform/graphics/win/FontPlatformData.h:
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
- 1:29 PM Changeset in webkit [47524] by
-
- 2 edits in trunk/LayoutTests
2009-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (Build fix).
Disable new media tests.
- platform/gtk/Skipped:
- 1:10 PM Changeset in webkit [47523] by
-
- 2 edits in trunk/WebCore
2009-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: When adding style selector, generate default name based
on id / class / type.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode):
- 1:08 PM Changeset in webkit [47522] by
-
- 2 edits in trunk/JavaScriptCore
Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294
Reviewed by Gavin Barraclough
We actually need to mark the value in a number object if we're using the
32bit number representation.
- 1:07 PM Changeset in webkit [47521] by
-
- 4 edits in trunk/LayoutTests
2009-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (Build fix).
Generate new results for fast/layers/video-layer.html after r47515.
- platform/mac-leopard/fast/layers/video-layer-expected.txt:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/win/fast/layers/video-layer-expected.txt:
- 1:03 PM Changeset in webkit [47520] by
-
- 2 edits in trunk/LayoutTests
Skip a failing test on Windows
See <http://webkit.org/b/28467>.
- platform/win/Skipped: Added
http/tests/loading/preload-img-test.html.
- 12:54 PM Changeset in webkit [47519] by
-
- 7 edits in trunk/JavaScriptCore
We probably shouldn't be keeping the AST for eval nodes around forevar.
https://bugs.webkit.org/show_bug.cgi?id=28469
Reviewed by Darin Adler.
EvalNodes don't destroyData() (delete their parser data) since they need to hold onto
their varStack. Copy a list of variable onto EvalCodeBlock, and this can go away.
- bytecode/CodeBlock.h:
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::adoptVariables):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- parser/Nodes.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::generateBytecode):
- runtime/Executable.h:
- 12:31 PM Changeset in webkit [47518] by
-
- 3 edits in trunk/LayoutTests
2009-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Make media layout test video-source-add-src.html less timing dependent
https://bugs.webkit.org/show_bug.cgi?id=28465
Trigger test on 'canplaythrough' instead of 'loadstart' so it is less
likely to fail on a slow machine.
- media/video-source-add-src-expected.txt:
- media/video-source-add-src.html:
- 12:26 PM Changeset in webkit [47517] by
-
- 14 edits in trunk/WebCore
Rename combinedOverflow to visibleOverflow, since that's what it actually represents.
Reviewed by Dan Bernstein.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::topvisibleOverflow):
(WebCore::InlineFlowBox::bottomvisibleOverflow):
(WebCore::InlineFlowBox::leftvisibleOverflow):
(WebCore::InlineFlowBox::rightvisibleOverflow):
(WebCore::InlineFlowBox::visibleOverflowRect):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::floatRect):
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
- rendering/RenderBox.h:
(WebCore::RenderBox::visibleOverflowRect):
(WebCore::RenderBox::topvisibleOverflow):
(WebCore::RenderBox::bottomvisibleOverflow):
(WebCore::RenderBox::leftvisibleOverflow):
(WebCore::RenderBox::rightvisibleOverflow):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localBoundingBox):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderOverflow.h:
(WebCore::RenderOverflow::visibleOverflowRect):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- 11:39 AM CodePaths edited by
- works for both html and xml (diff)
- 11:36 AM Changeset in webkit [47516] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
Fix a build issue with ICU 4.2 or later on Windows with Visual C++.
Instead of defining all isXXX and toupper/tolower as
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h,
#define them to be different by prepending 'WTF_...ASCIIType_h' with
the originial names like 'toupper_WTF_...ASCIIType_h'.
- wtf/DisallowCType.h:
- 11:10 AM Changeset in webkit [47515] by
-
- 23 edits5 adds in trunk
2009-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
Sound button appears in controller with movies that have no audio
https://bugs.webkit.org/show_bug.cgi?id=28464
Test: media/video-no-audio.html
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::hasAudio):
Added hasAudio.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::hasAudio): (WebCore::MediaPlayer::hasVideo):
Make const.
(WebCore::MediaPlayer::hasAudio):
Added hasAudio.
- platform/graphics/MediaPlayerPrivate.h:
Add hasAudio.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::hasAudio):
Ditto.
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
Ditto.
- platform/graphics/win/QTMovieWin.h:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasAudio):
Ditto.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::disabled):
New, return true if media element doesn't have audio.
(WebCore::MediaControlMuteButtonElement::rendererIsNeeded):
Renderer is not needed if element has no audio.
- rendering/MediaControlElements.h: (WebCore::MediaControlInputElement::disabled):
- rendering/RenderThemeMac.mm: (WebCore::getMediaUIPartStateFlags):
Return MediaUIPartDisabledFlag if node is disabled.
2009-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
Sound button appears in controller with movies that have no audio
https://bugs.webkit.org/show_bug.cgi?id=28464
- media/video-controls-visible-audio-only.html:
- media/video-no-audio.html: Added.
- platform/mac-leopard/media/video-empty-source-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt: Added.
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-no-audio-expected.txt: Added.
- platform/win/media/video-empty-source-expected.txt: Added.
- platform/win/media/video-no-audio-expected.txt: Added.
- 10:57 AM Changeset in webkit [47514] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27357
Removed the two unnecessary overridden willValidate() methods introduced
in r47444.
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-19
Reviewed by Darin Adler.
- html/HTMLKeygenElement.h:
- html/HTMLObjectElement.h:
- 10:55 AM Changeset in webkit [47513] by
-
- 15 edits in trunk/WebCore
2009-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Allow dumping dangling nodes to the console.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp:
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::releaseDanglingNodes): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::bind): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::childNodeCountUpdated):
- inspector/InspectorFrontend.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatnode):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDetachedRoot): (WebInspector.DOMAgent.prototype._childNodeCountUpdated): (WebInspector.setDetachedRoot): (WebInspector.childNodeCountUpdated): (InspectorController.pushNodeToFrontend):
- inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeToFrontend): (InjectedScript.createProxyObject):
- 10:50 AM Changeset in webkit [47512] by
-
- 8 edits3 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=27464
Implement application cache online whitelist wildcard flag
Test: http/tests/appcache/whitelist-wildcard.html
A "*" in NETWORK section means that network loading needn't be blocked.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isURLInOnlineWhitelist):
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::setAllowsAllNetworkRequests): (WebCore::ApplicationCache::allowsAllNetworkRequests):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::openDatabase): (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::loadCache):
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest):
- loader/appcache/ManifestParser.h:
- 10:44 AM Changeset in webkit [47511] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Roll out accidental project change.
- 10:37 AM Changeset in webkit [47510] by
-
- 3 edits2 adds8 deletes in trunk/LayoutTests
2009-08-19 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Convert two layout tests so that they use dumpAsText().
These tests check if the renderer crashes or not. Hence, we do not need to
dump the entire render tree. I verified DumpRenderTree at r24513 still crashed
when it opened the updated test cases.
See bug 14714 for details about these test cases.
Two layout tests are convertible to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=28423
- fast/multicol/negativeColumnWidth-expected.txt: Added.
- fast/multicol/negativeColumnWidth.html:
- fast/multicol/zeroColumnCount-expected.txt: Added.
- fast/multicol/zeroColumnCount.html:
- platform/mac/fast/multicol/negativeColumnWidth-expected.checksum: Removed.
- platform/mac/fast/multicol/negativeColumnWidth-expected.png: Removed.
- platform/mac/fast/multicol/negativeColumnWidth-expected.txt: Removed.
- platform/mac/fast/multicol/zeroColumnCount-expected.checksum: Removed.
- platform/mac/fast/multicol/zeroColumnCount-expected.png: Removed.
- platform/mac/fast/multicol/zeroColumnCount-expected.txt: Removed.
- platform/qt/fast/multicol/negativeColumnWidth-expected.txt: Removed.
- platform/qt/fast/multicol/zeroColumnCount-expected.txt: Removed.
- 10:33 AM Changeset in webkit [47509] by
-
- 5 edits in trunk/WebCore
Reviewed by Kevin Decker.
<rdar://problem/7042555> Loading certain pages on Tiger will start a spurious download
Get rid of method swizzling entirely. This created problems when lower level
Foundation code would call into our own swizzled method.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- platform/network/mac/WebCoreURLResponse.h:
- platform/network/mac/WebCoreURLResponse.mm: (-[NSURLResponse adjustMIMETypeIfNecessary]):
- 10:21 AM CommitQueue edited by
- (diff)
- 10:20 AM CommitQueue edited by
- (diff)
- 10:15 AM Changeset in webkit [47508] by
-
- 2 edits in trunk/WebCore
Fix linker warnings on Windows
Reviewed by Anders Carlsson.
Fixes <http://webkit.org/b/28462> WebCore causes linker warnings on
Windows about multiply-defined JSHTMLDataListElement symbols
- WebCore.vcproj/WebCore.vcproj: Exclude JSHTMLDataListElement.cpp
from the build (just like we do for the other generated bindings
files) so that we don't get warnings about multiply-defined symbols in
JSHTMLDataListElement.cpp and DerivedSources.cpp. Also removed
duplicate versions of JSSVGElementWrapperFactory.cpp, and let VS
reorder a few files.
- 10:09 AM Changeset in webkit [47507] by
-
- 2 edits in trunk/LayoutTests
Land updated results after my last change.
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- 10:07 AM CodePaths edited by
- network thingie (diff)
- 9:44 AM CodePaths edited by
- image decoding (diff)
- 9:38 AM Changeset in webkit [47506] by
-
- 2 edits in trunk/WebCore
2009-08-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel
Add 'icu::' qualifier when refering to ICU C++ names.
No change in the test result.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
- 9:28 AM Changeset in webkit [47505] by
-
- 3 edits in trunk/WebCore
Cleanup from my patch thet rewrote overflow. Remove unused member variables from RenderTableSection and
move the addition of overflow from children into a separate pass after the height of the section has been
set. This prevents the RenderOverflow struct from being aggressively allocated for all table sections.
(Not a a correctness issue, just a memory issue.)
Reviewed by Dan Bernstein.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTableSection.h:
- 9:28 AM ImprovingLifeOnWindows edited by
- (diff)
- 9:27 AM Changeset in webkit [47504] by
-
- 1 edit in trunk/LayoutTests/fast/html/nav-element.html
Revert accidental commit.
- 9:22 AM MakingTheWindowsBuildSystemMoreMaintainable edited by
- (diff)
- 9:21 AM ImprovingLifeOnWindows edited by
- Moved some content to MakingTheWindowsBuildSystemMoreMaintainable (diff)
- 9:20 AM MakingTheWindowsBuildSystemMoreMaintainable created by
- Initial version (content came from ImprovingLifeOnWindows)
- 9:17 AM ImprovingLifeOnWindows edited by
- Added ideas from BuildingOnWindows (diff)
- 9:09 AM ImprovingLifeOnWindows edited by
- Added a page outline (diff)
- 9:09 AM ImprovingLifeOnWindows edited by
- Added ideas for improving the running/debugging/testing experience (diff)
- 9:04 AM ImprovingLifeOnWindows created by
- Initial version
- 9:03 AM BuildingOnWindows edited by
- (diff)
- 9:01 AM BuildingOnWindows edited by
- (diff)
- 8:54 AM Changeset in webkit [47503] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-19 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Add a new expected file to the Qt port since we pass it.
- platform/qt/fast/reflections: Added.
- platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt: Added.
- 8:40 AM BuildingOnWindows edited by
- Added a link to a page containing ideas about how to improve the … (diff)
- 8:01 AM CodePaths edited by
- about widget painting (diff)
- 6:50 AM CodePaths edited by
- (diff)
- 6:48 AM WikiStart edited by
- link to the code paths (diff)
- 6:47 AM CodePaths created by
- start to put some useful stack traces
- 6:09 AM Changeset in webkit [47502] by
-
- 2 edits in trunk/WebKitTools
2009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
default timeout used by run-webkit-tests. Mac and Win ports were
recently bumped in http://trac.webkit.org/changeset/r47465.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
- 6:09 AM Changeset in webkit [47501] by
-
- 2 edits in trunk/WebCore
2009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Remove bogus dependency rules for built sources that derive
from HTMLTagNames.in, HTMLAttributeNames.in and xmlattrs.in. The
header files should be generated regardless of whether the source
file changed or not. We should only rely on the *.in files being
changed.
- GNUmakefile.am:
- 5:40 AM WikiStart edited by
- new section: getting around the source code (diff)
- 5:37 AM Changeset in webkit [47500] by
-
- 3 edits1 add in trunk/WebKitTools
DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
Reviewed by Mark Rowe.
Provide pre-generated swig source files for Tiger so it may
benefit from the faster run-webkit-tests.
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Generated by swig.
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added. Generated by swig. (swig_type_info::SWIG_TypeNameComp): (swig_type_info::SWIG_TypeEquiv): (swig_type_info::SWIG_TypeRegisterTL): (swig_type_info::SWIG_TypeCheck): (swig_type_info::SWIG_TypeCast): (swig_type_info::SWIG_TypeDynamicCast): (swig_type_info::SWIG_TypeName): (swig_type_info::SWIG_TypePrettyName): (swig_type_info::SWIG_TypeQueryTL): (swig_type_info::SWIG_TypeClientDataTL): (swig_type_info::SWIG_PackData): (swig_type_info::SWIG_UnpackData): (swig_type_info::SWIG_PropagateClientDataTL): (swig_type_info::SWIG_PackVoidPtr): (swig_type_info::SWIG_UnpackVoidPtr): (swig_type_info::SWIG_PackDataName): (swig_type_info::SWIG_UnpackDataName):
- DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on Tiger using pre-generated files.
- 5:35 AM HighLevelOverview created by
- shameless stolen from Brent's email
- 1:11 AM Changeset in webkit [47499] by
-
- 4 edits in trunk
2009-08-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
convert FormatBlock candidate tag list from if chain to hash lookup
https://bugs.webkit.org/show_bug.cgi?id=28448
No behavior change, just cleanup.
- editing/htmlediting.cpp: (WebCore::validBlockTag):
- editing/htmlediting.h:
- 12:47 AM Changeset in webkit [47498] by
-
- 2 edits in trunk/WebCore
2009-08-19 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update GraphicsContextSkia's version of drawLine to make use of the shared
adjustLineToPixelBoundaries function and elimination overlapping code.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
- 12:01 AM Changeset in webkit [47497] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Holger Freyther.
Remove an unneeded include.
- WebCoreSupport/DragClientGtk.cpp:
Aug 18, 2009:
- 11:49 PM Changeset in webkit [47496] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28443
Fix build break with gtk older than 2.14.
WebKit gtk port requires gtk 2.10 or later, but DragClientGtk.cpp
uses gtk_widget_get_window that is introduced in 2.14.
- WebCoreSupport/DragClientGtk.cpp: define gtk_widget_get_window for gtk older than 2.14.
- 11:31 PM Changeset in webkit [47495] by
-
- 2 edits in trunk/WebCore
2009-08-18 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextSkia.cpp
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setPlatformShadow):
- 11:08 PM Changeset in webkit [47494] by
-
- 3 edits5 adds in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=28446
Custom request headers shouldn't be sent with cross-origin preflight request
Tests: http/tests/xmlhttprequest/access-control-preflight-headers-async.html
http/tests/xmlhttprequest/access-control-preflight-headers-sync.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Don't copy headers to OPTIONS request. The spec is vague about this, but the intention was that they shouldn't be sent, and Firefox doesn't send them.
- 10:57 PM Changeset in webkit [47493] by
-
- 3 edits in trunk/WebKit/gtk
2009-08-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
[Gtk] crash when closing page from javascript
https://bugs.webkit.org/show_bug.cgi?id=27439
Do not unref the WebView in ChromeClientGtk::closeWindowSoon
because (1) a create-web-view handler can return a NULL WebView,
(2) the created WebView is owned by its containing widget, and (3)
clients may not handle the close-web-view signal so this avoids
unreffing a WebView more than once.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 10:50 PM Changeset in webkit [47492] by
-
- 14 edits1 add in trunk/WebCore
2009-08-18 John Gregg <johnnyg@google.com>
Reviewed by Dimitri Glazkov.
V8 Bindings for Desktop Notifications feature.
https://bugs.webkit.org/show_bug.cgi?id=28271
- WebCore.gypi: added notification files to build (all still behind a flag that's not on)
- bindings/scripts/CodeGeneratorV8.pm: added special case in DOMWindow/AppCache style for named event handlers
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/V8Proxy.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertToV8Object):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8NotificationCenterCustom.cpp: Added.
- notifications/Notification.h: made event handler routines public (as they are in DOMWindow, eg) for binding access.
- notifications/NotificationCenter.idl: needed to make methods V8Custom to support different behaviors in worker/page context in chromium.
- workers/WorkerThread.h: (WebCore::WorkerThread::getNotificationPresenter): (WebCore::WorkerThread::setNotificationPresenter): needed to make these methods public as well so chromium can inject the notification presenter into the worker thread.
- 10:24 PM Changeset in webkit [47491] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
run-webkit-tests hangs when WebCore tries to log too much
https://bugs.webkit.org/show_bug.cgi?id=15743
Read stdout and stderr in parallel.
- Scripts/run-webkit-tests:
- 10:16 PM Changeset in webkit [47490] by
-
- 2 edits in trunk
2009-08-18 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Holger Freyther.
Require at least libsoup 2.27.91 for the new password
manager/authentication APIs.
- configure.ac:
- 10:09 PM Changeset in webkit [47489] by
-
- 7 edits2 adds in trunk
2009-08-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- Implement HTML5 nav element https://bugs.webkit.org/show_bug.cgi?id=27937
<nav> should behave essentially the same as <div> for parsing
etc. This is implemented by the changes below.
Tests: fast/html/nav-element.html
- css/html.css:
- editing/htmlediting.cpp: (WebCore::validBlockTag):
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): (WebCore::blockTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
- html/HTMLTagNames.in:
2009-08-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- Tests for: Implement HTML5 nav element https://bugs.webkit.org/show_bug.cgi?id=27937
Test aspects of <nav>, including residual style, <p> closing, and FormatBlock.
- fast/html/nav-element-expected.txt: Added.
- fast/html/nav-element.html: Added.
- 9:42 PM Changeset in webkit [47488] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 9:42 PM Changeset in webkit [47487] by
-
- 1 copy in tags/Safari-6531.13
New tag.
- 9:41 PM Changeset in webkit [47486] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r47482.
- 9:41 PM Changeset in webkit [47485] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 9:39 PM Changeset in webkit [47484] by
-
- 3 edits in trunk/LayoutTests/platform/win
Land updated Windows layout test results.
- 9:19 PM Changeset in webkit [47483] by
-
- 3 edits in trunk/WebKitTools
Add a new build configuration that checks for leaks during the layout tests,
and hook a new machine up to it.
Rubber-stamped by Oliver Hunt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 9:01 PM Changeset in webkit [47482] by
-
- 3 edits in trunk/WebCore
- Fix <rdar://problem/7152727>
Patch by Anders Carlsson <andersca@apple.com> on 2009-08-18
Reviewed by Adele Peterson, David Hyatt and Dan Bernstein.
If a page has custom scroll bars, they will not update correctly when the window is activated/deactivated.
- page/FrameView.cpp:
(WebCore::FrameView::hasCustomScrollbars):
Check if the frame view or any of its subviews have custom scroll bars.
(WebCore::FrameView::updateControlTints):
Go ahead and update control tints if the frame view has custom scroll bars.
- page/FrameView.h:
- 8:42 PM Changeset in webkit [47481] by
-
- 12 edits2 deletes in trunk/WebCore
Roll out r47477 as it introduced assertion failures and crashes on the build bots.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/Database.cpp:
- storage/Database.h:
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransactionClient.cpp: Removed.
- storage/SQLTransactionClient.h: Removed.
- 8:32 PM Changeset in webkit [47480] by
-
- 1 edit1 add in trunk/WebCore
2009-08-18 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding the SharedTimer file for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28126
- platform/haiku/SharedTimerHaiku.cpp: Added. (WebCore::): (WebCore::SharedTimerHaiku::SharedTimerHaiku): (WebCore::SharedTimerHaiku::~SharedTimerHaiku): (WebCore::SharedTimerHaiku::instance): (WebCore::SharedTimerHaiku::start): (WebCore::SharedTimerHaiku::stop): (WebCore::SharedTimerHaiku::Filter): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- 8:13 PM Changeset in webkit [47479] by
-
- 2 edits in trunk/WebCore
Release build fix.
- xml/XMLHttpRequest.cpp: Sprinkle some #ifndef NDEBUG around.
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::~XMLHttpRequest):
- 8:01 PM Changeset in webkit [47478] by
-
- 4 edits in trunk
Leak of WebCore::XMLHttpRequest object during layout tests (<https://bugs.webkit.org/show_bug.cgi?id=28412>).
2009-08-18 Aaron Boodman <aa@chromium.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
No new tests: Already covered by existing tests.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Add instrumentation for this kind of leak. (WebCore::XMLHttpRequest::~XMLHttpRequest): Ditto. (WebCore::XMLHttpRequest::createRequest): Only setPendingActivity() if we actually started a request. Also, restore a call to nonCacheRequestInFlight() that got lost in a recent refactor.
- Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
- 7:56 PM Changeset in webkit [47477] by
-
- 12 edits2 adds in trunk/WebCore
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Added a client to SQLTransaction. In addition to being a place to
get notifications about certain events in a transaction, it is
also an abstraction layer that allows us to plug in different
implementations for each port for how transactions interract with
the main DB. For example, WebCore's default implementation will
make direct calls to DatabaseTracker's methods. At the same time,
Chromium's implementation will send IPCs to the browser process
whenever a transaction needs something from the main DB.
All storage tests pass.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/Database.cpp: (WebCore::Database::transactionClient):
- storage/Database.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionClient):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runCurrentStatement): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransactionClient.cpp: Added.
- storage/SQLTransactionClient.h: Added.
- 7:44 PM Changeset in webkit [47476] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Final change for v8 corresponding to http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added missing using statment
- 7:32 PM Changeset in webkit [47475] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
More corresponding changes to V8 from http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.
- 7:19 PM Changeset in webkit [47474] by
-
- 2 edits in trunk/JavaScriptCore
Assigning a function to an object should always use the existing transition, even if the transition is not specialized
https://bugs.webkit.org/show_bug.cgi?id=28442
Reviewed by Gavin Barraclough.
Check for an unspecialized transition as an alternative to always failing if specialisation does not match.
- 7:18 PM Changeset in webkit [47473] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Make corresponding changes to V8 from http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.
- 7:15 PM Changeset in webkit [47472] by
-
- 2 edits in trunk/LayoutTests
Remove accidentally committed logging
- 7:12 PM BuildingGtk edited by
- Add a couple of packges that are needed to build (diff)
- 7:12 PM UsingGitWithWebKit edited by
- Make it better! (diff)
- 7:07 PM UsingGitWithWebKit edited by
- Clear up the section about git-svn (diff)
- 6:36 PM Changeset in webkit [47471] by
-
- 2 edits in trunk/LayoutTests
Make test faster so leaks bot won't time out.
Reviewed by Mark Rowe
- 5:26 PM Changeset in webkit [47470] by
-
- 2 edits in trunk/WebCore
Build fix.
- editing/ApplyStyleCommand.cpp:
(WebCore::getIdentifierValue):
- 5:17 PM Changeset in webkit [47469] by
-
- 28 edits in trunk/WebCore
More work on making DOM classes start with reference count of 1
https://bugs.webkit.org/show_bug.cgi?id=28068
Patch by Darin Adler <Darin Adler> on 2009-08-18
Reviewed by Sam Weinig.
Some related clean-up and preparation steps so the subsequent
patches will be as small as possible.
- WebCore.base.exp: Sorted this file.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
Use nameAttr instead of the name function.
- bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::JSHTMLFrameElement::setSrc):
Use srcAttr instead of the src function.
- bindings/js/JSHTMLIFrameElementCustom.cpp:
(WebCore::JSHTMLIFrameElement::setSrc):
Use srcAttr instead of the src function.
- bindings/objc/DOM.mm: Sorted includes.
- dom/Document.cpp: Ditto.
- dom/StyledElement.cpp: Made invalidateStyleAttribute inline.
- dom/StyledElement.h: Ditto.
- dom/make_names.pl: Changed default of createWithNew to 0.
Eventually all elements will be created with create instead of new.
- html/HTMLTagNames.in:
- svg/svgtags.in:
- wml/WMLTagNames.in:
Added createWithNew for every tag. We'll remove it as we convert
element classes to use create.
- html/HTMLAppletElement.h: Removed unneeded forward declarations.
- html/HTMLFrameElement.h: Ditto.
- html/HTMLEmbedElement.cpp: Removed many attribute get and
set functions.
- html/HTMLEmbedElement.h: Ditto.
- html/HTMLIFrameElement.cpp: Ditto.
- html/HTMLIFrameElement.h: Ditto.
- html/HTMLObjectElement.cpp: Ditto.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLPlugInElement.cpp: Ditto.
- html/HTMLPlugInElement.h: Ditto.
- html/HTMLFrameElementBase.cpp: Removed many attribute get and
set functions.
(WebCore::HTMLFrameElementBase::location): Changed to use
srcAttr instead of src.
- html/HTMLFrameElementBase.h: Removed many attribute get and set
functions.
- loader/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
Use srcAttr and typeAttr instead of setSrc and setType.
- loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure): Ditto.
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Use nameAttr instead
of name -- this avoids an extra AtomicString round trip and a little
ref count churn too.
- 5:05 PM Changeset in webkit [47468] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe
Update Windows and Qt results after r47462.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:04 PM Changeset in webkit [47467] by
-
- 14 edits1 copy19 adds in trunk
WebCore: SharedWorkers need to support loading.
https://bugs.webkit.org/show_bug.cgi?id=28342
Reviewed by David Levin.
Added loader support to shared workers, and refactored worker tests to also test SharedWorkers
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
Forwards load requests to an arbitrary document from the list of worker's documents.
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
Posts responses back to the shared worker thread.
LayoutTests: SharedWorkers need to support loading
https://bugs.webkit.org/show_bug.cgi?id=28342
Reviewed by David Levin.
Refactored worker network tests to also test SharedWorkers.
- http/tests/workers/resources/worker-importScripts.js:
Refactored to run in either a dedicated or shared worker.
(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.resetLoadFlags):
(runTests):
- http/tests/workers/resources/worker-redirect-target.js:
Refactored to run in either a dedicated or shared worker.
(else.self.onconnect):
- http/tests/workers/resources/worker-redirect.js: Added.
Moved test code out of worker-redirect.html so it can be shared with shared worker tests.
(log):
(runNextTest):
(testCrossOriginLoad.try.worker.onerror):
(testCrossOriginLoad.try.worker.onmessage):
(testCrossOriginLoad):
(testCrossOriginRedirectedLoad.try.worker.onerror):
(testCrossOriginRedirectedLoad.try.worker.onmessage):
(testCrossOriginRedirectedLoad):
- http/tests/workers/shared-worker-importScripts-expected.txt: Added.
- http/tests/workers/shared-worker-importScripts.html-disabled: Added.
- http/tests/workers/shared-worker-redirect-expected.txt: Added
- http/tests/workers/shared-worker-redirect.html-disabled: Added.
- http/tests/workers/worker-redirect.html:
Moved test code into worker-redirect.js.
- http/tests/xmlhttprequest/workers/close.html:
Moved test code into close-test.js.
- http/tests/xmlhttprequest/workers/methods-async.html:
Moved test code into methods-async-test.js.
- http/tests/xmlhttprequest/workers/methods.html:
Moved test code into methods.js.
- http/tests/xmlhttprequest/workers/resources/close-test.js: Added.
Contains test code moved from close.html, so tests can be shared with SharedWorkers.
(log):
(testAsync.worker.onmessage.else):
(testAsync.worker.onmessage):
(testAsync):
(testSync.worker.onmessage.else):
(testSync.worker.onmessage):
(testSync):
(done):
(handleException):
- http/tests/xmlhttprequest/workers/resources/close.js:
Modified worker code so it runs in shared workers also.
- http/tests/xmlhttprequest/workers/resources/file-not-found.js: Added.
Contains test code moved from xmlhttprequest-file-not-found.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods-async-test.js: Added.
Contains test code moved from methods-async.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods-async.js:
Changed code to run in shared workers also.
- http/tests/xmlhttprequest/workers/resources/methods-test.js: Added.
Contains test code moved from methods.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods.js:
Now can run in either dedicated or shared workers.
(init):
- http/tests/xmlhttprequest/workers/resources/shared-worker-create.js: Added.
Utility code to allow shared workers to look like dedicated workers to enable sharing test code.
(createWorker.worker.port.onmessage):
(createWorker.worker.postMessage):
(createWorker):
- http/tests/xmlhttprequest/workers/resources/worker-create.js: Added.
(createWorker):
- http/tests/xmlhttprequest/workers/resources/worker-pre.js: Added.
Utility code to make SharedWorkerGlobalScope look like DedicatedWorkerGlobalScope, to enable test code sharing.
(else.self.onconnect.self.postMessage):
(else.self.onconnect.event.messagePort.onmessage):
(else.self.onconnect):
- http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js:
(init):
Updated code so it runs in shared workers also.
- http/tests/xmlhttprequest/workers/shared-worker-close-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled: Added.
- http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html:
Moved test code into file-not-found.js.
- 5:01 PM Changeset in webkit [47466] by
-
- 2 edits in trunk/WebCore
2009-08-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749
This patch simplifies StyleChange::init by removing the iteration on CSS properties,
and adding functions reconcileTextDecorationProperties and extractTextStyle to handle the style.
Because there is a bug in how text decorations are processes in getPropertiesNotInComputedStyle,
this patch simplifies the treatment in order to preserve the original behavior of WebKit.
However, the current implementation is not best (adds redundant text-decorations) and we should fix it later.
No test is added since there is no change in behavior.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Uses getPropertiesNotInComputedStyle instead of iterating through the properties (WebCore::StyleChange::reconcileTextDecorationProperties): Removes -webkit-text-decorations-in-effects and redundant "none" (WebCore::getIdentifierValue): Obtains the identifier of a CSSPrimitiveValue (WebCore::StyleChange::extractTextStyles): Converts properties in style to m_apply* and removes the property (WebCore::getPropertiesNotInComputedStyle): Fixed a bug with how text decorations are treated
- 5:00 PM Changeset in webkit [47465] by
-
- 3 edits in trunk/WebKitTools
Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
Rubber-stamped by Geoff Garen.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- 4:54 PM Changeset in webkit [47464] by
-
- 2 edits in trunk/WebCore
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Fixing a DB file naming bug in Chromium. The origin should come
before the DB name in the file name.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase):
- 4:47 PM Changeset in webkit [47463] by
-
- 2 edits4 adds in trunk/WebCore
2009-08-18 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding four image-specific files to WebCore:
IconHaiku.cpp, ImageBufferData.h, ImageBufferHaiku.cpp, ImageHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28130
- platform/graphics/Icon.h:
- platform/graphics/haiku/IconHaiku.cpp: Added. (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
- platform/graphics/haiku/ImageBufferData.h: Added.
- platform/graphics/haiku/ImageBufferHaiku.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/haiku/ImageHaiku.cpp: Added. (WebCore::FrameData::clear): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::getBBitmap):
- 4:36 PM Changeset in webkit [47462] by
-
- 10 edits in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27575 [CSS3
Backgrounds and Borders] Drop the prefix from background-size
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::cssPropertyID):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ensurePropertyMap):
LayoutTests: Test result changes for https://bugs.webkit.org/show_bug.cgi?id=27575
[CSS3 Backgrounds and Borders] Drop the prefix from background-size
Reviewed by Dan Bernstein.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 4:21 PM WebCoreRendering edited by
- add class hierarchy (diff)
- 4:09 PM Changeset in webkit [47461] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
and removed include to fix building on VC++ Express.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota):
- 3:15 PM Changeset in webkit [47460] by
-
- 5 edits3 adds in trunk
2009-08-18 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers need to forward exceptions to parent documents
https://bugs.webkit.org/show_bug.cgi?id=28320
Wrote test to generate exception and make sure it gets logged to the console.
Started switching over to using the same test utilities that the tests under fast/js use.
- fast/workers/resources/shared-worker-common.js: (generateError): (handleMessage):
- fast/workers/resources/shared-worker-exception.js: Added. (worker.onmessage): (done):
- fast/workers/shared-worker-exception-expected.txt: Added.
- fast/workers/shared-worker-exception.html-disabled: Added.
2009-08-18 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers need to forward exceptions to parent documents
https://bugs.webkit.org/show_bug.cgi?id=28320
Changed SharedWorkerProxy to have individual mutexes (so workers can interact with their parent documents without contention).
Updated SharedWorkerProxy to forward exceptions/console messages to all parent documents.
- bindings/js/JSSharedWorkerConstructor.cpp: Cleaned up bitrot - added missing include.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask): Callback used to deliver exceptions to a document. (WebCore::SharedWorkerProxy::postExceptionToWorkerObject): Forwards exceptions to all parent documents for presentation to the user. (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject): Forwards console messages to all parent documents for presentation to the user. (WebCore::SharedWorkerProxy::addToWorkerDocuments): Grabs the mutex before accessing workerDocuments. (WebCore::SharedWorkerProxy::documentDetached): Grabs the mutex before accessing workerDocuments.
- 3:06 PM Changeset in webkit [47459] by
-
- 7 edits in trunk
WebCore: <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
Reviewed by Adele Peterson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
Call FrameLoaderClient::shouldLoadMediaElementURL.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::shouldLoadMediaElementURL):
Return true by default.
WebKit/mac: Mac specific part of
Reviewed by Adele Peterson.
<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Implement shouldLoadMediaElementURL by asking the policy delegate.
- WebView/WebPolicyDelegatePrivate.h:
Add new delegate method, remove some unused cruft.
- 2:58 PM Changeset in webkit [47458] by
-
- 3 edits2 adds in trunk
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a test to verify that openDatabase() does not execute
SQL statements on the database it's trying to open, unless we're
opening the first handle to that database.
- storage/open-database-while-transaction-in-progress-expected.txt: Added.
- storage/open-database-while-transaction-in-progress.html: Added.
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
openDatabase() should not execute any SQL statement on the
database it's trying to open, unless there are no other open
handles to the same database. Otherwise, we might run into a
deadlock.
Test: storage/open-database-while-transaction-in-progress.html
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
- 2:48 PM Changeset in webkit [47457] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=19360
Frags on current page don't generate "navigation-requested" events
Fix order of parameters for the creation of SubstituteData object,
so that normal data loads do not have an unreachable URL. Also
remove a confusion about the purpose of the last parameter.
- webkit/webkitwebframe.cpp: (webkit_web_frame_load_data):
- 2:37 PM Changeset in webkit [47456] by
-
- 8 edits in trunk
2009-08-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter feBlend implementation missing
https://bugs.webkit.org/show_bug.cgi?id=28133
Implementation of SVG Filter feBlend.
FilterEffect.cp needed changes to optimize the rendering. With the old code
we drew a subEffect on the current FilterEffect by drawImage, got the PixelArray,
cleared the drawing area, drew the next FilterEffect with drawImage and picked this
PixelArray again. This was unefficient and slow. Now we calculate the requested area
of the subEffect and ask the FilterEffect's ImageBuffer for the PixelArray directly,
without any drawing operations on GraphicsContext.
There is already a test case
Test: svg/W3C-SVG-1.1/filters-blend-01-b.svg
- html/canvas/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
- platform/graphics/filters/FEBlend.cpp: (WebCore::unknown): (WebCore::normal): (WebCore::multiply): (WebCore::screen): (WebCore::darken): (WebCore::lighten): (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingIntRect):
- platform/graphics/filters/FilterEffect.h:
2009-08-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Added additional getter to ByteArray with an unsigned char as return.
ByteArray can take unsigned char directly now.
- wtf/ByteArray.h: (WTF::ByteArray::set): (WTF::ByteArray::get):
- 2:09 PM Changeset in webkit [47455] by
-
- 2 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix array formatter followup: node formatter.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format):
- 2:05 PM Changeset in webkit [47454] by
-
- 4 edits in trunk/LayoutTests
Update SnowLeopard-specific layout test results after r47440.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- 1:44 PM Changeset in webkit [47453] by
-
- 2 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Metrics sidebar broken
- inspector/front-end/MetricsSidebarPane.js:
- 1:21 PM Changeset in webkit [47452] by
-
- 1 edit in trunk/WebCore/page/PrintContext.cpp
Fix GTK bustage.
- 1:20 PM Changeset in webkit [47451] by
-
- 1 edit in trunk/WebCore/page/chromium/FrameChromium.cpp
Fix Chromium bustage.
- 1:15 PM Changeset in webkit [47450] by
-
- 9 edits in trunk/LayoutTests
Land updated results after my last patch.
- platform/mac/compositing/geometry/clipping-foreground-expected.txt:
- platform/mac/compositing/masks/masked-ancestor-expected.txt:
- platform/mac/compositing/masks/multiple-masks-expected.txt:
- platform/mac/compositing/masks/simple-composited-mask-expected.txt:
- platform/mac/fast/clip/008-expected.txt:
- platform/mac/fast/clip/011-expected.txt:
- platform/mac/fast/clip/012-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- 1:01 PM Changeset in webkit [47449] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28432
String::createCFString() returns a non-retained empty string
No known change in functionality, so no test.
- platform/text/cf/StringCF.cpp: (WebCore::String::createCFString): Retain the CFSTR result.
- 12:58 PM Changeset in webkit [47448] by
-
- 1 edit in trunk/WebCore/page/win/FrameWin.cpp
Fix Windows build bustage.
- 12:53 PM Changeset in webkit [47447] by
-
- 11 edits in trunk
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setDatabaseQuota):
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota):
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Added a setQuota interface method to IWebDatabaseManager and implemented it.
- Interfaces/IWebDatabaseManager.idl:
- WebDatabaseManager.cpp: (WebDatabaseManager::setQuota):
- WebDatabaseManager.h:
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Removed now passing storage tests from the Skipped list, now we pass all storage tests on Windows.
- platform/win/Skipped:
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Removed an early return that can cause deleteOrigin or deleteAllDatabases to fail when
it doesn't have to.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteOrigin):
- 12:53 PM Changeset in webkit [47446] by
-
- 1 copy in tags/Safari-6531.12
New tag.
- 12:50 PM Changeset in webkit [47445] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r47438.
- 12:50 PM Changeset in webkit [47444] by
-
- 12 edits18 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27357
Support for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.
Tests: fast/css/pseudo-invalid-001.html
fast/css/pseudo-invalid-002.html
fast/css/pseudo-valid-001.html
fast/css/pseudo-valid-002.html
fast/css/pseudo-valid-003.html
fast/css/pseudo-valid-004.html
fast/css/pseudo-valid-005.html
fast/css/pseudo-valid-006.html
fast/css/pseudo-valid-007.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType): extracts new pseudo-classes
- css/CSSSelector.h:
(WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Make sure we don't share style between
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27357
Tests for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.
- fast/css/pseudo-invalid-001-expected.txt: Added.
- fast/css/pseudo-invalid-001.html: Added.
- fast/css/pseudo-invalid-002-expected.txt: Added.
- fast/css/pseudo-invalid-002.html: Added.
- fast/css/pseudo-valid-001-expected.txt: Added.
- fast/css/pseudo-valid-001.html: Added.
- fast/css/pseudo-valid-002-expected.txt: Added.
- fast/css/pseudo-valid-002.html: Added.
- fast/css/pseudo-valid-003-expected.txt: Added.
- fast/css/pseudo-valid-003.html: Added.
- fast/css/pseudo-valid-004-expected.txt: Added.
- fast/css/pseudo-valid-004.html: Added.
- fast/css/pseudo-valid-005-expected.txt: Added.
- fast/css/pseudo-valid-005.html: Added.
- fast/css/pseudo-valid-006-expected.txt: Added.
- fast/css/pseudo-valid-006.html: Added.
- fast/css/pseudo-valid-007-expected.txt: Added.
- fast/css/pseudo-valid-007.html: Added.
- fast/dom/plugin-attributes-enumeration-expected.txt:
- 12:47 PM Changeset in webkit [47443] by
-
- 3 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix array formatter.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray):
- 12:43 PM Changeset in webkit [47442] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 12:39 PM Changeset in webkit [47441] by
-
- 2 edits in trunk/WebCore
2009-08-17 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos
Replace repeated string of PLATFORM(FOO) with a single define
https://bugs.webkit.org/show_bug.cgi?id=27734
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
- 12:15 PM Changeset in webkit [47440] by
-
- 119 edits5 adds4 deletes in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly
considered part of scrollable overflow.
Reviewed by Dan Bernstein.
This patch takes the engine's concept of overflow and splits it into two types:
layout overflow and visual overflow.
Layout overflow is about other boxes that spill out of an enclosing box, For example,
in the inline flow case a tall image could spill out of a line box. Examples of
visual overflow are shadows, text stroke (and eventually outline and
border-image).
Three objects tracked overflow before this patch: RenderBlock had
m_overflowLeft/Top/Width/Height variables. RootInlineBox had an Overflow*
that also had four overflow values. Finally RenderReplaced elements tracked shadow/reflection
overflow using a map that cached four values.
This patch takes all of these different overflow models and unifies them into a single
new class called RenderOverflow. This class is now a member variable in RenderBox and
InlineFlowBoxes. It is only allocated if overflow actually exists. Instead of tracking
four values, it tracks eight: left/top/right/bottom for layout overflow and
left/top/right/bottom for visual overflow.
Overflow computation is now done after layout is finished rather than during layout
(when child objects can be churning and moving around). A number of layout tests progressed
by deferring overflow computation to a separate pass.
All inline flow boxes now track overflow (and not just the root line box). This allows
repainting of line boxes to actually be tight and bail early if the overflow rect of a box
doesn't intersect. The old code always visited all object on a line if the root line box
intersected at all.
Line box overflow no longer propagates across self-painting layers. This fixes a number of
issues with incorrect scrollbars appearing when relative positioned inlines were used in a page.
Layer bounds have been modified to exclude visual overflow. The width/height members only really
have one reason for continued existence, and that is that they happen to be used in repaint()
when an overflow clip object's height isn't accurate. In this case, the bounds should exclude
visual overflow anyway, so this change tightens that repaint up.
Root lines have renamed m_selectionTop/Bottom to m_lineTop/Bottom and positionForPoint methods have
been changed to use these instead of relying on overflow (which was totally wrong).
Significant changes have been made to the "almost strict mode" line box quirk where objects with no
text children have no effect on the height of a line. Instead of making the height() of the objects
variable and dependent on overflow, the objects now have their full height and get placed on
the baseline properly. They simply don't contribute to overflow above lineTop/Bottom.
Reflections are no longer considered overflow of any kind. Because reflections have their own layers,
it is not necessary to treat them as visual or layout overflow in the RenderObject tree. The end result
of not incorporating them into RenderOverflow is that they have no effect on scrolling. transparencyClipBox
has been extended to support fully reflecting the entire clip box when a reflection exists. This fixes
numerous repaint bugs in transparent objects with reflections when the transparent objects had self-painting
sublayers.
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::adjustPageHeight):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::height):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::topCombinedOverflow):
(WebCore::InlineFlowBox::bottomCombinedOverflow):
(WebCore::InlineFlowBox::leftCombinedOverflow):
(WebCore::InlineFlowBox::rightCombinedOverflow):
(WebCore::InlineFlowBox::combinedOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromBlockChildren):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::floatRect):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getHeightForLineCount):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowAndReflectionOverflow):
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::clearLayoutOverflow):
- rendering/RenderBox.h:
(WebCore::RenderBox::combinedOverflowRect):
(WebCore::RenderBox::topCombinedOverflow):
(WebCore::RenderBox::bottomCombinedOverflow):
(WebCore::RenderBox::leftCombinedOverflow):
(WebCore::RenderBox::rightCombinedOverflow):
(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
(WebCore::RenderBox::visualOverflowRect):
(WebCore::RenderBox::topVisualOverflow):
(WebCore::RenderBox::bottomVisualOverflow):
(WebCore::RenderBox::leftVisualOverflow):
(WebCore::RenderBox::rightVisualOverflow):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::localBoundingBox):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h:
- rendering/RenderOverflow.h: Added.
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::topLayoutOverflow):
(WebCore::RenderOverflow::bottomLayoutOverflow):
(WebCore::RenderOverflow::leftLayoutOverflow):
(WebCore::RenderOverflow::rightLayoutOverflow):
(WebCore::RenderOverflow::topVisualOverflow):
(WebCore::RenderOverflow::bottomVisualOverflow):
(WebCore::RenderOverflow::leftVisualOverflow):
(WebCore::RenderOverflow::rightVisualOverflow):
(WebCore::RenderOverflow::setTopLayoutOverflow):
(WebCore::RenderOverflow::setBottomLayoutOverflow):
(WebCore::RenderOverflow::setLeftLayoutOverflow):
(WebCore::RenderOverflow::setRightLayoutOverflow):
(WebCore::RenderOverflow::setTopVisualOverflow):
(WebCore::RenderOverflow::setBottomVisualOverflow):
(WebCore::RenderOverflow::setLeftVisualOverflow):
(WebCore::RenderOverflow::setRightVisualOverflow):
(WebCore::RenderOverflow::layoutOverflowRect):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::combinedOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::~RenderReplaced):
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
(WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::verticallyAlignBoxes):
(WebCore::RootInlineBox::selectionTop):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
(WebCore::RootInlineBox::lineTop):
(WebCore::RootInlineBox::lineBottom):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::floats):
(WebCore::RootInlineBox::floatsPtr):
(WebCore::RootInlineBox::setLineTopBottomPositions):
- rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutInlineBoxes):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly being included
as part of scrollable overflow.
Reviewed by Dan Bernstein.
Update layout tests to account for all of the changes made to overflow to split it into two types. Remove the layout
tests that were recently added that assumed that shadows and reflections should be part of scrollable overflow.
- fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Removed.
- fast/box-shadow/box-shadow-overflow-scroll.html: Removed.
- fast/reflections/reflection-overflow-scroll-expected.txt: Removed.
- fast/reflections/reflection-overflow-scroll.html: Removed.
- platform/mac/compositing/overflow/ancestor-overflow-expected.txt:
- platform/mac/compositing/reflections/reflection-on-composited-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-br-012-expected.txt:
- platform/mac/editing/pasteboard/select-element-1-expected.txt:
- platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
- platform/mac/fast/body-propagation/background-color/002-expected.txt:
- platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt:
- platform/mac/fast/body-propagation/background-image/002-expected.txt:
- platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt:
- platform/mac/fast/body-propagation/overflow/001-expected.txt:
- platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
- platform/mac/fast/box-shadow/transform-fringing-expected.txt:
- platform/mac/fast/clip/008-expected.txt:
- platform/mac/fast/clip/011-expected.txt:
- platform/mac/fast/clip/012-expected.txt:
- platform/mac/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/images/image-in-map-expected.txt:
- platform/mac/fast/inline-block/003-expected.txt:
- platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt:
- platform/mac/fast/invalid/012-expected.txt:
- platform/mac/fast/layers/normal-flow-hit-test-expected.txt:
- platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/reflections/reflection-direction-expected.txt:
- platform/mac/fast/reflections/reflection-masks-expected.checksum:
- platform/mac/fast/reflections/reflection-masks-expected.png:
- platform/mac/fast/reflections/reflection-masks-expected.txt:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.checksum:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.png:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.txt:
- platform/mac/fast/reflections/reflection-nesting-expected.txt:
- platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
- platform/mac/fast/reflections/reflection-overflow-hidden-expected.txt:
- platform/mac/fast/repaint/box-shadow-h-expected.txt:
- platform/mac/fast/repaint/box-shadow-v-expected.txt:
- platform/mac/fast/repaint/reflection-redraw-expected.txt:
- platform/mac/fast/repaint/reflection-repaint-test-expected.txt:
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.txt:
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- platform/mac/fast/transforms/shadows-expected.txt:
- platform/mac/fast/transforms/transforms-with-opacity-expected.txt:
- platform/mac/media/video-layer-crash-expected.txt:
- platform/mac/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10565-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22513-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/other/ms-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
- 12:03 PM Changeset in webkit [47439] by
-
- 3 edits7 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28431
<rdar://problem/7137610> Application Cache doesn't work with HTTP authentication
Test: http/tests/appcache/auth.html
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::shouldUseCredentialStorage): If appcache is enabled, always allow it to use stored credentials (we can't ask WebKit client, and maybe we shouldn't ask it, because it's not a document that's loading these resources).
- 11:56 AM Changeset in webkit [47438] by
-
- 3 edits in trunk/WebCore
Fix <rdar://problem/7147996>
Reviewed by John Sullivan and David Hyatt.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Update the style of the scroll bars.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
Calculate the size of the scrollbar and set it as the frame size.
- 11:54 AM Changeset in webkit [47437] by
-
- 1 edit2 adds in trunk/LayoutTests
Not reviewed. Forgot to add pixel test results for html-fieldset-crash.html some time ago.
- 11:44 AM Changeset in webkit [47436] by
-
- 3 edits in trunk/LayoutTests
Unreviewed (Updating skipped tests).
Re-enabled test on GTK platform (DRT supports layoutTestController.workerThreadCount on GTK).
Disabled test on QT platform (DRT does not support workerThreadCount on QT).
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 11:42 AM Changeset in webkit [47435] by
-
- 5 edits in trunk/LayoutTests
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (build fix).
Update results added for https://bugs.webkit.org/show_bug.cgi?id=28314 to
not log 'progress' event as the timing relative to other media events
isn't important and varies according to the behavior of the media engine.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html:
- 11:40 AM Changeset in webkit [47434] by
-
- 2 edits in trunk/WebKit/win
Unreviewed (build break).
Added missing include for WebWorkersPrivate.h.
- WebKitClassFactory.cpp:
- 11:35 AM Changeset in webkit [47433] by
-
- 2 edits in trunk/LayoutTests
Unreviewed - skipping test on GTK.
Added worker-lifecycle.html tests to skipped tests on GTK platform due to missing DRT functionality.
- platform/gtk/Skipped:
- 11:14 AM Changeset in webkit [47432] by
-
- 2 edits in trunk
Speculative fix for GTK DumpRenderTree.
Reviewed by NOBODY (Build Break).
- GNUmakefile.am:
- 10:46 AM Changeset in webkit [47431] by
-
- 4 edits2 adds in trunk
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement should fire 'progress' event before 'load'
https://bugs.webkit.org/show_bug.cgi?id=28314
Test: media/progress-event-at-least-one.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState):
Schedule 'progress' event before 'load'.
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement should fire 'progress' event before 'load'
https://bugs.webkit.org/show_bug.cgi?id=28314
- media/event-attributes-expected.txt:
Update results to include 'progress' event fired before 'load'.
- media/progress-event-at-least-one-expected.txt: Added.
- media/progress-event-at-least-one.html: Added.
- 10:44 AM Changeset in webkit [47430] by
-
- 14 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- WebKit.vcproj/InterfacesGenerated.vcproj:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- record-memory-win/record-memory-win.vcproj:
- WinLauncher/WinLauncher.vcproj:
- WebKitLauncherWin/WebKitLauncherWin.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- FindSafari/FindSafari.vcproj:
- 10:35 AM Changeset in webkit [47429] by
-
- 25 edits12 adds in trunk
WebCore: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Expose WorkerThread::workerThreadCount() for DumpRenderTree so we can write worker lifecycle tests.
Tests: fast/workers/shared-worker-lifecycle.html-disabled
fast/workers/worker-lifecycle.html
- WebCore.base.exp:
Exported WorkerThread::workerThreadCount().
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerThread.cpp:
Added tracking of the number of worker threads.
(WebCore::threadCountMutex):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
- workers/WorkerThread.h:
WebKit: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- WebKit.xcodeproj/project.pbxproj:
Added WebWorkersPrivate APIs to mac WebKit to expose workerThreadCount() for DumpRenderTree.
WebKit/gtk: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- webkit/webkitprivate.h:
- webkit/webkitworkers.cpp: Added.
(webkit_worker_thread_count):
Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree.
WebKit/mac: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- WebKit.exp:
Exported WebWorkersPrivate so DumpRenderTree can access it.
- Workers/WebWorkersPrivate.h: Added.
- Workers/WebWorkersPrivate.mm: Added.
(+[WebWorkersPrivate workerThreadCount]):
Added WebWorkersPrivate::workerThreadCount() API for DumpRenderTree.
WebKit/win: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
- ForEachCoClass.h:
Added WebWorkersPrivate.
- Interfaces/IWebWorkersPrivate.idl: Added.
- Interfaces/WebKit.idl:
Added WebWorkersPrivate.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebWorkersPrivate.cpp: Added.
Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
(WebWorkersPrivate::QueryInterface):
(WebWorkersPrivate::AddRef):
(WebWorkersPrivate::Release):
(WebWorkersPrivate::workerThreadCount):
(WebWorkersPrivate::createInstance):
(WebWorkersPrivate::WebWorkersPrivate):
(WebWorkersPrivate::~WebWorkersPrivate):
- WebWorkersPrivate.h: Added.
WebKitTools: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
- DumpRenderTree/LayoutTestController.cpp:
(getWorkerThreadCountCallback):
(LayoutTestController::staticValues):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::workerThreadCount):
LayoutTests: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Added simple layout tests that use the new layoutTestController.workerThreadCount() API
- fast/workers/resources/shared-worker-common.js:
Added support for "close" command to match worker-common.js.
- fast/workers/resources/worker-lifecycle.js: Added.
- fast/workers/shared-worker-lifecycle-expected.txt: Added.
- fast/workers/shared-worker-lifecycle.html-disabled: Added.
- fast/workers/worker-lifecycle-expected.txt: Added.
- fast/workers/worker-lifecycle.html: Added.
- 8:21 AM Changeset in webkit [47428] by
-
- 2 edits in trunk/WebKitSite
2009-08-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Mention handy --bug flag of prepare-ChangeLog script.
https://bugs.webkit.org/show_bug.cgi?id=28425
- coding/contributing.html: Add a reference for --bug flag
- 7:31 AM Changeset in webkit [47427] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix the ATK unit test.
We now support line boundaries in the get_text functions, so we
need to make sure the test has the layout we expect by giving it
enough space to fit in one line.
- tests/testatk.c: (test_webkit_atk_get_text_at_offset):
- 5:49 AM Changeset in webkit [47426] by
-
- 5 edits2 copies4 adds in trunk/LayoutTests
2009-08-18 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] These tests pass now. Fixed metrics related to default font size and added some expected files for new tests.
- platform/qt/Skipped:
- platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
- platform/qt/fast/images/animated-svg-as-image-expected.txt: Added.
- platform/qt/fast/images/embed-image-expected.txt: Added.
- platform/qt/fast/images/favicon-as-image-expected.txt: Added.
- platform/qt/fast/images/object-image-expected.txt: Added.
- platform/qt/fast/images/svg-as-background-expected.txt:
- platform/qt/fast/images/svg-as-image-expected.txt:
- platform/qt/fast/images/svg-as-relative-image-expected.txt: Added.
- platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Added.
- 5:44 AM Changeset in webkit [47425] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-18 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed, build fix.
[Qt] Add new files I forgot to add in r47424.
- 5:23 AM Changeset in webkit [47424] by
-
- 6 edits in trunk
WebCore/ChangeLog:
2009-08-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Implement prefetchDNS() function.
- WebCore.pro:
- platform/qt/TemporaryLinkStubs.cpp:
WebKit/qt/ChangeLog:
2009-08-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviwed by Ariya Hidayat.
[Qt] For prefecthDNS, the pre-fetching has to be enabled in the
WebSettings.
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- 5:02 AM Changeset in webkit [47423] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Initialize x and y in the GtkAllocation structure to shut up
valgrind.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
- 12:35 AM Changeset in webkit [47422] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-18 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
- GNUmakefile.am:
- 12:33 AM Changeset in webkit [47421] by
-
- 2 edits in trunk/LayoutTests
2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Remove string "foo" in <video> tag. This made Qt layout test fail.
Qt doesn't support video yet and the string will be rendered.
- fast/runin/nonblock-runin.html:
- 12:16 AM Changeset in webkit [47420] by
-
- 21 edits7 adds in trunk
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Add --enable-datalist option.
- configure.ac:
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for <datalist> element.
https://bugs.webkit.org/show_bug.cgi?id=26915
- fast/forms/datalist-expected.txt: Added.
- fast/forms/datalist-nonoption-child-expected.txt: Added.
- fast/forms/datalist-nonoption-child.html: Added.
- fast/forms/datalist.html: Added.
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Support for parsing <datalist> element and generating HTMLDataListElement nodes.
https://bugs.webkit.org/show_bug.cgi?id=26915
Tests: fast/forms/datalist-nonoption-child.html
fast/forms/datalist.html
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html.css:
- html/CollectionType.h: (WebCore::):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter):
- html/HTMLDataListElement.cpp: Added. (WebCore::HTMLDataListElement::HTMLDataListElement): (WebCore::HTMLDataListElement::~HTMLDataListElement): (WebCore::HTMLDataListElement::checkDTD): (WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h: Added.
- html/HTMLDataListElement.idl: Added.
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
- html/HTMLTagNames.in:
Aug 17, 2009:
- 11:35 PM Changeset in webkit [47419] by
-
- 8 edits in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Some HTMLs are modified by make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28213
Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .
- fast/dom/Geolocation/enabled.html:
- fast/dom/Geolocation/resources/TEMPLATE.html:
- http/tests/wml/access-target-domain-deny.html:
- http/tests/wml/access-target-path-deny.html:
- http/tests/wml/access-target.html:
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Some HTMLs are modified by make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28213
Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .
- Scripts/make-script-test-wrappers:
- 11:26 PM Changeset in webkit [47418] by
-
- 8 edits3 adds in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
- fast/flexbox/box-orient-button-expected.txt: Added.
- fast/flexbox/box-orient-button.html: Added.
- fast/flexbox/resources/box-orient-button.js: Added. (setBoxOrient): (gebi):
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
Test: fast/flexbox/box-orient-button.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
- rendering/RenderBlock.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::setupInnerStyle):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::renderName):
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
- Scripts/make-script-test-wrappers:
- 11:20 PM Changeset in webkit [47417] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri
add THE CORRECT new file to lunix builds (you idiot).
- 11:08 PM Changeset in webkit [47416] by
-
- 2 edits in trunk/JavaScriptCore
add new file to lunix builds.
- 10:56 PM Changeset in webkit [47415] by
-
- 1 edit in trunk/JavaScriptCore/runtime/Executable.cpp
speculative interpretoid build fixeration.
- 10:49 PM Changeset in webkit [47414] by
-
- 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore
speculative 'doze build fixeration II.
- 10:42 PM Changeset in webkit [47413] by
-
- 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp
speculative 'doze build fixeration.
- 10:34 PM Changeset in webkit [47412] by
-
- 41 edits1 add in trunk/JavaScriptCore
No, silly runtime, AST nodes are not for you.
Reviewed by Sam Weinig.
We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc. This is all a bit of a mess.
Move functionality into a new FunctionExecutable class.
- API/JSCallbackFunction.cpp:
- API/JSObjectRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
- bytecode/EvalCodeCache.h:
- bytecode/SamplingTool.cpp:
(JSC::SamplingTool::doRun):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
- bytecompiler/BytecodeGenerator.h:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::):
- parser/Nodes.cpp:
(JSC::FunctionBodyNode::reparseDataIfNecessary):
- parser/Nodes.h:
(JSC::EvalNode::partialDestroyData):
- parser/Parser.h:
- profiler/ProfileGenerator.cpp:
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
- runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/CallData.h:
(JSC::):
- runtime/Collector.cpp:
(JSC::Heap::collect):
- runtime/ConstructData.h:
(JSC::):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
- runtime/Executable.cpp: Added.
(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
- runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
- runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):
- runtime/JSGlobalData.h:
- 10:12 PM Changeset in webkit [47411] by
-
- 1 edit1 delete in trunk
Revert r47399 as Eric landed it in the wrong directory.
- 8:57 PM Changeset in webkit [47410] by
-
- 15 edits12 adds in trunk
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Render -webkit-mask via compositing layers when possible
https://bugs.webkit.org/show_bug.cgi?id=28414
Implement accelerated compositing of -webkit-mask, when combined
with already-composited content.
RenderLayerBacking now creates an additional GraphicsLayer for the mask contents,
and sets this as the mask on another GraphicsLayer via the setMaskLayer() method.
GraphicsLayerCA then applies the mask using -[CALayer setMask:].
The enum values for GraphicsLayerPaintingPhase were renamed to avoid the
confusion with "mask", and a new value, GraphicsLayerPaintMask, was added which
indicates that just the mask is painting.
When painting the composited mask, we need to paint with the normal compositing
mode rather than CompositeDestinationIn, so InlineFlowBox and RenderBox now consult
layer()->hasCompositedMask() to pick the mode. If the mask is composited, they no longer
need to make transparency layers.
We no longer have to throw video rendering into software because of masks.
When a masked element has composited descendants, that element needs to
become composited so that the mask can be applied via compositing.
Tests: compositing/masks/masked-ancestor.html
compositing/masks/simple-composited-mask.html
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::maskLayer): (WebCore::GraphicsLayer::setMaskLayer): (WebCore::GraphicsLayer::paintingPhase): (WebCore::GraphicsLayer::setPaintingPhase):
- platform/graphics/GraphicsLayerClient.h: (WebCore::):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setMaskLayer): (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateMaskLayer):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasCompositedMask):
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasCompositedMask):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::hasMaskLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
- rendering/RenderLayerCompositor.h:
- 8:31 PM Changeset in webkit [47409] by
-
- 5 edits4 adds in trunk
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Layer content misplaced with compositing, z-index and overflow
https://bugs.webkit.org/show_bug.cgi?id=28361
The foreground GraphicsLayer (used to render element foreground when the element has
negative z-order children) was misplaced when there is a clipping layer (which clips
children). The foreground layer is parented under the clipping layer so that the foreground
depth-sorts with the layer's children, so its geometry needs to be computed relative to
that clipping layer.
Also clarified some FIXME comments, and corrected a debug-only layer name.
Test: compositing/geometry/clipping-foreground.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateSublayerList):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- 7:58 PM Changeset in webkit [47408] by
-
- 3 edits in trunk/WebCore
Fix leaks of SVGElementInstance seen during regression tests.
Reviewed by Sam Weinig.
r47313 made TreeShared types start with a ref-count of 1, but SVGElementInstance was mistakenly
not updated to have a create method that adopted the initial reference. This lead to the instances
of SVGElementInstance allocated by SVGUseElement being leaked.
- svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::create):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::handleDeepUseReferencing):
- 6:37 PM Changeset in webkit [47407] by
-
- 6 edits in trunk/WebCore
Some cleanup towards https://bugs.webkit.org/show_bug.cgi?id=13631
Page Cache should support pages with frames.
Reviewed by Sam Weinig.
- Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads are solely the responsibility of FrameLoader.
- Enhance some page cache related Logging to help development.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::identifierForInitialRequest):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
- loader/FrameLoader.h:
(WebCore::FrameLoader::isLoadingFromCachedPage):
- 6:18 PM Changeset in webkit [47406] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adele Peterson.
http/tests/misc/favicon-loads-with-images-disabled.html was passing on my machine
(when I ran all http tests), but failed on the bot, so adding it back to the
Skipped list.
- platform/win/Skipped:
- 6:05 PM Changeset in webkit [47405] by
-
- 4 edits in trunk/JavaScriptCore
Fix 300,000+ leaks seen during the regression tests.
Reviewed by Darin Adler.
EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
- runtime/Executable.h:
(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):
- 6:00 PM Changeset in webkit [47404] by
-
- 10 edits in trunk
REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>
RS=Mark Rowe
Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.
- 5:58 PM Changeset in webkit [47403] by
-
- 5 edits in trunk/WebCore
2009-08-17 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Moved implementation of isAfterContent to RenderObject
(as inline method to avoid potential performance regressions).
BUG 28376 - [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
(https://bugs.webkit.org/show_bug.cgi?id=28376)
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
- rendering/RenderObject.h: (WebCore::RenderObject::isAfterContent):
- 5:49 PM Changeset in webkit [47402] by
-
- 2 edits in trunk/WebKitTools
2009-08-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Can no longer --reset-results of a layout test directory
https://bugs.webkit.org/show_bug.cgi?id=28336
--reset-results and --exit-after-n-failures are incompatible.
- Scripts/run-webkit-tests:
- 5:40 PM Changeset in webkit [47401] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adele Peterson.
http/tests/misc/favicon-loads-with-images-disabled.html is passing on my
machine, trying to remove it from the Skipped list on Windows.
- platform/win/Skipped:
- 5:24 PM Changeset in webkit [47400] by
-
- 3 edits2 adds in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Don't handle run-in if the element is not a block element.
- fast/runin/canvas-runin-expected.txt: Added.
- fast/runin/canvas-runin.html: Added.
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Don't handle run-in if the element is not a block element.
Test: fast/runin/nonblock-runin.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- 5:16 PM Changeset in webkit [47399] by
-
- 1 edit6 adds in trunk
2009-08-17 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Darin Adler.
Regression test for bug fixed in
http://codereview.chromium.org/171039. Regexps created in one
frame were not callable outside that frame.
https://bugs.webkit.org/show_bug.cgi?id=28387
- fast/regex/regexp-cross-frame-callable-expected.txt: Added.
- fast/regex/regexp-cross-frame-callable.html: Added.
- fast/regex/resources/regexp-cross-frame-callable-child.html: Added.
- 5:05 PM Changeset in webkit [47398] by
-
- 5 edits3 adds in trunk
2009-08-17 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Darin Adler.
Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.
According to
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."
Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html
- fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt: Added.
- fast/canvas/canvas-2d-imageData-create-nonfinite.html: Added.
- fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js: Added.
2009-08-17 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Darin Adler.
Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.
According to
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."
Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
- 4:28 PM Changeset in webkit [47397] by
-
- 11 edits in trunk
2009-08-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add a way to release the storage lock
https://bugs.webkit.org/show_bug.cgi?id=28411
Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex
Add this function to navigator and hook it up to DOM Storage.
- page/Navigator.cpp: (WebCore::Navigator::getStorageUpdates):
- page/Navigator.h:
- page/Navigator.idl:
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::unlock):
- storage/StorageNamespaceImpl.h:
2009-08-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add a way to release the storage lock
https://bugs.webkit.org/show_bug.cgi?id=28411
Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex
Update the test expectations to include this new element.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/navigator-detached-no-crash-expected.txt:
- platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
- 4:11 PM Changeset in webkit [47396] by
-
- 3 edits in trunk/WebCore
Build fix.
CFNetwork isn't present in the framework search path on Mac OS X so we can't directly include its headers.
We include CoreServices.h, the umbrella framework that contains CFNetwork, from the prefix header which
results in the CFNetwork headers being included on Mac OS X. CoreServices.h doesn't include CFNetwork.h on
Windows though so we explicitly include this header from the prefix header when on Windows.
- WebCorePrefix.h:
- platform/network/cf/DNSCFNet.cpp: Remove #include that is no longer needed.
- 3:48 PM Changeset in webkit [47395] by
-
- 2 edits in trunk/WebCore
Trying a better build fix (the previous one broke Leopard bots, although it did build for me).
- platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFNetwork.h instead.
- 3:30 PM Changeset in webkit [47394] by
-
- 2 edits in trunk/WebCore
Trying to fix Windows build.
- platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFHost.h.
- 3:17 PM Changeset in webkit [47393] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
Reviewed by Adam Roben.
New commit message:
Committed r12345: <http://trac.webkit.org/changeset/12345>
- Scripts/bugzilla-tool: (bug_comment_from_commit_text): Print out a compact, standardized commit message for both git and svn.
- 3:12 PM Changeset in webkit [47392] by
-
- 19 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 3:08 PM Changeset in webkit [47391] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=28401
Add support for DNS prefetching with CFNetwork
This is just an optimization, no behavior change, so no tests.
- platform/network/cf/DNSCFNet.cpp: (WebCore::clientCallback): (WebCore::prefetchDNS): Use async CFHostStartInfoResolution() for implementation.
- 2:48 PM Changeset in webkit [47390] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skip new tests.
- platform/gtk/Skipped:
- 2:14 PM Changeset in webkit [47389] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=28403
Update Apache2 module list from Leopard defaults
No change in functionality, only commented out modules needed an update.
- http/conf/apache2-httpd.conf:
- 1:54 PM WikiStart edited by
- Linked to Chromium port page (diff)
- 1:43 PM Changeset in webkit [47388] by
-
- 11 edits2 adds in trunk
2009-08-17 Aaron Boodman <aa@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.
Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented redirects
for access control, so we should never redirect across origins. But in two edge cases, we were:
- Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
- Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-and-redirects.html: Added.
2009-08-17 Aaron Boodman <aa@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.
Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented
redirects access control, so we should never redirect across origins. But in two edge cases, we were:
- Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
- Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
Test: http/tests/xmlhttprequest/access-control-and-redirects.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): Refactor redirect checking code into shared location. (WebCore::DocumentThreadableLoader::loadRequest): Ditto. (WebCore::DocumentThreadableLoader::isAllowedRedirect): Ditto.
- loader/DocumentThreadableLoader.h:
- loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Remove ThreadableLoaderOptions::crossOriginRedirectPolicy.
- page/EventSource.cpp: (WebCore::EventSource::connect): Ditto.
- workers/Worker.cpp: Ditto. (WebCore::Worker::Worker): Ditto.
- workers/WorkerContext.cpp: Ditto. (WebCore::WorkerContext::importScripts): Ditto.
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): Ditto. (WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- workers/WorkerScriptLoader.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Ditto.
- 1:41 PM Changeset in webkit [47387] by
-
- 2 edits in trunk/WebKit/qt
Try to fix Qt build again.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- WebCoreSupport/EditorClientQt.cpp: Move "using namespace".
- 1:36 PM Changeset in webkit [47386] by
-
- 2 edits in trunk/WebCore
2009-08-17 Adam Langley <agl@google.com>
Reviewed by Dan Bernstein (relanding of r47157).
Fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
This was originally fixed in r47157, however it triggered a bug in
Skia which caused Chromium Linux to fail layout tests in debug mode.
It was reverted in r47189 while we sorted it out.
The Skia bug was fixed in Skia's r321 [1] and rolled into Chromium in
Chromium's r23523. This is a reland of the original patch.
No new tests because it's a just typo fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
- 1:33 PM Changeset in webkit [47385] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
Reviewed by David Levin.
- Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. (check_max_min_macros): Added. Returns level 4 error when MAX() and MIN() macros are used in header files and C++ source files. (check_style): Added call to check_max_min_macros().
- Scripts/modules/cpp_style_unittest.py: Added unit tests. (test_max_macro): Added. (test_min_macro): Added.
- 1:29 PM Changeset in webkit [47384] by
-
- 2 edits in trunk/WebCore
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Protect ResourceHandle for g_file_query_info_async call, using the
same technique we already use for HTTP requests that take the soup
path.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::finishedCallback): (WebCore::):
- 1:21 PM Changeset in webkit [47383] by
-
- 2 edits in trunk/WebCore
REGRESSION (r47255): MediaWiki's (including Wikipedia) navigation pane
appears below the main content
https://bugs.webkit.org/show_bug.cgi?id=28350
Reviewed by Darin Adler.
A particular version of the MediaWiki software detects WebKit through
user agent sniffing and imports a style sheet called KHTMLFixes.css,
which contains a single rule that was meant to work around some KHTML
bug, but currently has the sole effect of causing the float containing
the main article content to extend all the way to the left and thus push
down the left navigation pane.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): If site specific hacks are
enabled, check if the imported style sheet is the MediaWiki
KHTMLFixes.css. If so, remove the offending rule.
- 1:20 PM Changeset in webkit [47382] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix build with FAST_MALLOC_MATCH_VALIDATION enabled.
- wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastRealloc):
- 1:11 PM Changeset in webkit [47381] by
-
- 5 edits1 add in trunk/WebCore/platform
2009-08-17 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
https://bugs.webkit.org/show_bug.cgi?id=28308
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Added.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 12:56 PM Changeset in webkit [47380] by
-
- 2 edits in trunk/WebKit/qt
Try to fix Qt build.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::shouldShowDeleteInterface):
Use getAttribute(classAttr) instead of className() function.
- 12:47 PM Changeset in webkit [47379] by
-
- 2 edits in trunk/WebCore
Correct crash when processing local cancelled requests.
Reviewed by Kevin Ollivier.
No new tests. Existing fast/images/favicon-as-image.html
displays the problem.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback): Add check for m_cancelled after
performing local-file processing.
(WebCore::ResourceHandleManager::downloadTimerCallback): Add
check for m_cancelled after performing local-file processing.
- 12:27 PM Changeset in webkit [47378] by
-
- 6 edits1 delete in trunk/WebCore
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Reverts 47371, since it breaks GTK+.
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Removed.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 12:07 PM Changeset in webkit [47377] by
-
- 1 copy in tags/Safari-6531.11
New tag.
- 12:04 PM Changeset in webkit [47376] by
-
- 2 edits in trunk/WebKit/win
2009-08-17 Simon Fraser <Simon Fraser>
Speculative fix for Windows build bustage.
- DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
- 12:00 PM Changeset in webkit [47375] by
-
- 11 edits in branches/safari-4-branch/WebKitTools
Merge r47320.
- 11:51 AM Changeset in webkit [47374] by
-
- 2 edits in trunk/WebCore
2009-08-17 Simon Fraser <Simon Fraser>
Build fix: fix float literals to avoid casting warnings.
- rendering/MediaControlElements.cpp:
- 11:50 AM Changeset in webkit [47373] by
-
- 7 edits2 copies in branches/safari-4-branch
Merge r47312.
- 11:43 AM Changeset in webkit [47372] by
-
- 9 edits in branches/safari-4-branch
Merge r47311.
- 11:37 AM Changeset in webkit [47371] by
-
- 6 edits1 add in trunk/WebCore
2009-08-17 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
https://bugs.webkit.org/show_bug.cgi?id=28308
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Added.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 11:29 AM Changeset in webkit [47370] by
-
- 7 edits in trunk/WebCore
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel.
Use OwnPtrs for GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=28399
Convert RenderLayerBacking and RenderLayerCompositor to use OwnPtrs
for their references to GraphicsLayers.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::create):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::graphicsLayer): (WebCore::RenderLayerBacking::clippingLayer): (WebCore::RenderLayerBacking::ancestorClippingLayer): (WebCore::RenderLayerBacking::foregroundLayer): (WebCore::RenderLayerBacking::parentForSublayers): (WebCore::RenderLayerBacking::childForSuperlayers):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::~RenderLayerCompositor): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
- rendering/RenderLayerCompositor.h:
- 10:44 AM Changeset in webkit [47369] by
-
- 6 edits in trunk/WebCore
2009-08-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Reset InjectedScript styles cache on document change.
- inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::resetInjectedScript):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/InjectedScript.js: (InjectedScript._reset):
- 10:41 AM Changeset in webkit [47368] by
-
- 2 edits in trunk/WebCore
- rendering/MediaControlElements.cpp: Removed unneeded include of CString.h,
resorted includes, renamed "doc" to "document" and fixed formatting.
Reviewed by Sam Weinig.
- 10:30 AM Changeset in webkit [47367] by
-
- 12 edits in trunk/WebCore
Removed functions now unneeded due to use of Reflect to create
language bindings.
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
Get at usemap attribute directly.
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
Get at id attribute directly.
- editing/EditorCommand.cpp:
(WebCore::executeInsertHorizontalRule): Ditto.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir): Get at dir attribute of body directly.
(WebCore::HTMLDocument::setDir): Ditto.
- html/HTMLElement.cpp: Deleted unused functions.
- html/HTMLElement.h: Ditto.
- html/HTMLImageElement.cpp: Deleted unused functions.
(WebCore::HTMLImageElement::alt): Changed to return const AtomicString&.
(WebCore::HTMLImageElement::addSubresourceAttributeURLs): Changed to
get at usemap attribute directly, but added a FIXME because although
it is what the old code did, it looks to not be entirely correct.
- html/HTMLImageElement.h: Deleted unused functions.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString): Get at alt attribute directly.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap): Get at usemap attribute directly.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer): Get at id attribute
directly.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Removed
explicit HTMLNames namespace qualification.
- 10:12 AM Changeset in webkit [47366] by
-
- 2 edits in trunk/WebKit/mac
Use a HashMap instead of a list of if statements for the command
name exception map.
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- WebView/WebHTMLView.mm:
(createSelectorExceptionMap): Added.
(commandNameForSelector): Use createSelectorExceptionMap.
- 10:03 AM Changeset in webkit [47365] by
-
- 2 edits in trunk/WebCore
- dom/Document.cpp:
(WebCore::Document::setFocusedNode): Removed unneeded calls
to RefPtr::get.
Reviewed by Sam Weinig.
- 9:24 AM Changeset in webkit [47364] by
-
- 2 edits in trunk/WebCore
2009-08-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Discard DOM Node bindings on any document change.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- 8:57 AM Changeset in webkit [47363] by
-
- 23 edits1 delete in trunk/WebCore
2009-08-13 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Improve Cookie DataGrid to Show Hidden Data
https://bugs.webkit.org/show_bug.cgi?id=28269
- English.lproj/localizedStrings.js: DataGrid Headers "Name", "Value", "Size", ...
- WebCore.gypi: added missing files
Implemented Bindings for InspectorController.deleteCookie(name)
- inspector/InspectorBackend.idl:
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies): (WebCore::JSInspectorBackend::deleteCookie):
v8 Bindings Stubs
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
Removed WebInspector.Cookie
- inspector/front-end/Cookie.js: Removed.
- inspector/front-end/inspector.html:
- inspector/front-end/WebKit.qrc:
Improved DataGrid and Kept Fallback Behavior for Platforms that don't
yet provide access to raw cookies.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype.fallbackUpdate.callback): (WebInspector.CookieItemsView.prototype.fallbackUpdate): (WebInspector.CookieItemsView.prototype.fallbackBuildCookiesFromString): (WebInspector.CookieItemsView.prototype.fallbackDataGridForCookies): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
Interaction with the page through Injected Script (for fallback behavior)
- inspector/front-end/DOMAgent.js: (InspectorController.getCookies):
- inspector/front-end/InjectedScript.js: (InjectedScript.setStyleProperty): style fix (InjectedScript.getCookies):
Allow alignment of text inside DataGrids.
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGridNode.prototype.createCell):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
- inspector/front-end/inspector.css:
Added deleteCookie(., ., String name)
Modified getRawCookies to return a bool to know if its implemented
- platform/CookieJar.h:
Implemented deleteCookie for Macs
- platform/mac/CookieJar.mm: (WebCore::getRawCookies): (WebCore::deleteCookie):
Stub Implementations for Other Platforms
- platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- 8:37 AM Changeset in webkit [47362] by
-
- 2 edits in trunk/WebCore
Blind build fix for Leopard.
Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-17
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::adjustLineToPixelBoundaries):
- 8:07 AM Changeset in webkit [47361] by
-
- 5 edits in trunk
Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::adjustLineToPixelBoundaries):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- 7:19 AM Changeset in webkit [47360] by
-
- 2 edits in trunk/WebCore
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextCG.cpp
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setCompositeOperation):
- 7:01 AM Changeset in webkit [47359] by
-
- 5 edits in trunk/WebCore
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContext.cpp/h, GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(GraphicsContext::drawText):
(GraphicsContext::initFocusRing):
(GraphicsContext::focusRingBoundingRect):
(GraphicsContext::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::toCairoOperator):
- platform/graphics/qt/GraphicsContextQt.cpp:
- 6:51 AM Changeset in webkit [47358] by
-
- 2 edits in trunk/WebKitTools
Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
WebKit style guide.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28161
- DumpRenderTree/qt/jsobjects.cpp:
(findFrameNamed):
(LoadItem::invoke):
(LayoutTestController::provisionalLoad):
(LayoutTestController::timerEvent):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
(EventSender::keyDown):
(EventSender::frameUnderMouse):
(TextInputController::doCommand):
- 3:38 AM Writing Layout Tests for DumpRenderTree edited by
- make-js-test-wrappers renamed to make-script-test-wrappers (diff)
- 12:43 AM Changeset in webkit [47357] by
-
- 3 edits in trunk/WebCore
Change HTMLAreaElement to use OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=28386
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement): Removed unneeded initializer.
(WebCore::HTMLAreaElement::~HTMLAreaElement): Removed unneeded delete call.
(WebCore::HTMLAreaElement::parseMappedAttribute): Use the set function
instead of deletion followed by assignment.
- html/HTMLAreaElement.h: Use OwnArrayPtr.
- 12:41 AM Changeset in webkit [47356] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- dom/make_names.pl: Add back cast to (void*) needed on Windows.
- 12:38 AM Changeset in webkit [47355] by
-
- 5 edits in trunk/WebCore
Move noResize from HTMLFrameElementBase to HTMLFrameElement
https://bugs.webkit.org/show_bug.cgi?id=28384
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement): Initialize m_noResize.
(WebCore::HTMLFrameElement::parseMappedAttribute): Set m_noResize to true
here if noresizeAttr is changed. This code was moved here from
HTMLFrameElementBase, but I added some FIXME comments.
(WebCore::HTMLFrameElement::setNoResize): Set the attribute based on
boolean argument. Moved here from HTMLFrameElementBase.
- html/HTMLFrameElement.h: Moved noResize, setNoResize, and m_noResize
here from HTMLFrameElementBase.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed m_noResize.
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Removed code to parse
noresizeAttr.
- html/HTMLFrameElementBase.h: Removed noResize, setNoResize, and m_noResize.
- 12:35 AM Changeset in webkit [47354] by
-
- 5 edits in trunk/WebCore
Tweak HTMLFrameElementBase so that m_URL can be private
https://bugs.webkit.org/show_bug.cgi?id=28385
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::rendererIsNeeded): Removed m_URL argument.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed): Use m_URL instead of
taking an argument.
(WebCore::HTMLFrameElementBase::openURL): Removed m_URL argument.
- html/HTMLFrameElementBase.h: Removed argument from isURLAllowed function.
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::rendererIsNeeded): Removed m_URL argument.
- 12:14 AM Changeset in webkit [47353] by
-
- 3 edits in trunk/WebCore
HTMLViewSourceDocument should use smart pointers
https://bugs.webkit.org/show_bug.cgi?id=28378
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): Don't initialize
pointers any more since RefPtr starts 0 by default.
(WebCore::HTMLViewSourceDocument::createContainingTable): Use more specific
types for local variables.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Return a PassRefPtr,
and use a RefPtr of a more specific type for a local variable.
(WebCore::HTMLViewSourceDocument::addLine): Use more specific types for local
variables, and use RefPtr as well.
(WebCore::HTMLViewSourceDocument::addLink): Return a PassRefPtr, and use a
RefPtr of a more specific type for a local variable.
- html/HTMLViewSourceDocument.h: Change return types to PassRefPtr and
data member types to RefPtr.
- 12:12 AM Changeset in webkit [47352] by
-
- 5 edits in trunk/WebCore
DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
Convert 4 more classes. These are classes I am going to make other changes
to soon, so it's good to have this use of Reflect in the IDL out of the way.
- html/HTMLEmbedElement.idl: Use Reflect for many attributes.
- html/HTMLFrameElement.idl: Ditto.
- html/HTMLIFrameElement.idl: Ditto.
- html/HTMLObjectElement.idl: Ditto.
- 12:09 AM Changeset in webkit [47351] by
-
- 2 edits in trunk/WebCore
Script to create element factory needs changes to accommodate calling create
https://bugs.webkit.org/show_bug.cgi?id=28379
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- dom/make_names.pl: Tweak formatting. Remove lots of unneeded quotes
around names used inside {}. Added new createWithNew property for tags
that makes the factory use a create function instead of calling new.
Renamed functions with initialize in their name to have default in their
name, since they return an array full of default values and don't themselves
initialize anything.
Aug 16, 2009:
- 10:26 PM Changeset in webkit [47350] by
-
- 2 edits in trunk/WebCore
StyledElement should use ASCIICType instead of having its own toHex function
https://bugs.webkit.org/show_bug.cgi?id=28377
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSColor): Use isASCIIHexDigit and toASCIIHexValue.
- 10:24 PM Changeset in webkit [47349] by
-
- 2 edits in trunk/WebKit/mac
<http://webkit.org/b/28366> WebHTMLViewInternal.h: add @class CALayer declaration
Reviewed by Simon Fraser.
Without WebKitPrefix.h, the missing @class CALayer declaration
causes a compile-time error.
- WebView/WebHTMLViewInternal.h: Added @class CALayer declaration with USE(ACCELERATED_COMPOSITING).
- 10:24 PM Changeset in webkit [47348] by
-
- 5 edits in trunk
WebCore: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- editing/EditorCommand.cpp:
(WebCore::executeInsertHorizontalRule): Create an HTMLHRElement
instead of just an HTMLElement.
LayoutTests: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- editing/execCommand/arguments-combinations-expected.txt: Updated.
- editing/execCommand/arguments-combinations.html: Updated to expect
the <hr> element to be self-closing rather than having a separate
</hr> in the markup.
- 5:45 PM Changeset in webkit [47347] by
-
- 7 edits4 adds in trunk
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371
After selecting an option element with an 'onpick' event associated with a 'go' task,
the navigation is executed. When going back in history, the same 'onpick' event is fired
again. Fix that problem, add wml/option-element-onpick-recursion.html covering the bug.
Test: wml/option-element-onpick-recursion.html
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::WMLSelectElement): (WebCore::WMLSelectElement::selectInitialOptions):
- wml/WMLSelectElement.h: (WebCore::WMLSelectElement::initialized):
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371
Add new test covering history navigation & 'onpick' event handling.
- wml/option-element-onpick-recursion-expected.txt: Added.
- wml/option-element-onpick-recursion.html: Added.
- wml/resources/WMLTestCase.js: (createStaticWMLTestCase): (createDynamicWMLTestCase):
- wml/resources/option-element-onpick-recursion.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/option-element-onpick-recursion.wml: Added.
- wml/resources/option-element-onpick.js: (prepareTest):
- 5:44 PM Changeset in webkit [47346] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
Reviewed by David Levin.
In <http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'using std::foo;' statements. This adds a level 4 check for
such statements.
- Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std().
- Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test.
- 5:32 PM Changeset in webkit [47345] by
-
- 3 edits in trunk/WebKitTools
Backed out r47343 which was mistakenly committed
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 5:30 PM Changeset in webkit [47344] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
Reviewed by David Levin.
The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:
NameError: global name 'ScriptError' is not defined
- Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto.
- 5:30 PM Changeset in webkit [47343] by
-
- 2 edits in trunk/WebKitTools/Scripts
WIP: bugzilla-tool: add land-commits command
- 4:24 PM Changeset in webkit [47342] by
-
- 2 edits in trunk/WebCore
Inspector Resource filtering: keyboard Navigation always uses ALL resources
https://bugs.webkit.org/show_bug.cgi?id=28231
Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-16
Reviewed by Timothy Hatcher.
Determine if a resource is selectable on user action.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable):
- 3:57 PM Changeset in webkit [47341] by
-
- 10 edits in trunk
<http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates
Reviewed by Dan Bernstein.
WebCore:
- accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling): Changed MIN() to min().
- platform/graphics/mac/FontMacATSUI.mm: (WebCore::Font::selectionRectForComplexText): Changed MAX() to max() and MIN() to min(). (WebCore::Font::floatWidthForComplexText): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm: Added using std::max statement. (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
- platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Changed MIN() to min().
WebKit/mac:
- Plugins/WebBaseNetscapePluginStream.mm: Added using std::min statement. (WebNetscapePluginStream::deliverData): Changed MIN() to min(). Changed C-style cast to a static_cast.
- Plugins/WebNetscapePluginView.mm: Added using std::min statement. (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): Changed MIN() to min(). Changed C-style cast to a static_cast.
- WebView/WebHTMLView.mm: Added using std::max statement. (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to max(). (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
- WebView/WebTextCompletionController.mm: Added using std::max and using std::min statements. (-[WebTextCompletionController _placePopupWindow:]): Changed type of maxWidth variable from float to CGFloat to prevent a type mismatch on x86_64. Changed MAX() to max() and MIN() to min(). Added static_cast for a constant value since CGFloat is defined as a float on i386 and as a double on x86_64.
- 12:27 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:24 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:23 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:22 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:21 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:20 PM Flow chart edited by
- (diff)
- 12:18 PM Flow chart edited by
- (diff)
- 12:16 PM Flow chart edited by
- adding picture (diff)
- 12:15 PM Flow chart created by
- initial creation
- 10:35 AM Changeset in webkit [47340] by
-
- 11 edits in trunk/WebCore
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Cleanup WMLIntrinsicEventHandling code
https://bugs.webkit.org/show_bug.cgi?id=28358
Remove superflous "Event* evt" parameter from executeTask() methods. It's a leftover from the initial WML merge.
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::defaultEventHandler):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
- wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
- wml/WMLGoElement.h:
- wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
- wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
- wml/WMLPrevElement.h:
- wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
- wml/WMLRefreshElement.h:
- wml/WMLTaskElement.h:
- 9:15 AM Changeset in webkit [47339] by
-
- 21 edits in trunk/WebCore
2009-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: A handful of DOMAgent-related fixes and cleanups.
- renamed elementId to nodeId in operations on nodes.
- added load listeners to frame owners in InspectorDOMAgent.
- removed InspectorController::inspectedWindowScriptObjectCleared event.
- preserved isViaInspector flag for 'via inspector' marker to survive styles update.
- removed contentDocument-related logic from ElementsPanel since it is handled in
the InspectorDOMAgent.
- removed DOM listeners unregistration and corresponding events from InspectorController.
- made this.styles 'private' in ElementsPanel.
- added TODO for the handleCopy processing.
- WebCore.order:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setTextNodeValue):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentNode):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument.prototype.addEventListener): (WebInspector.DOMDocument.prototype.removeEventListener): (WebInspector.DOMDocument.prototype._fireDomEvent): (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.childNodeInserted): (WebInspector.childNodeRemoved):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype._updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand):
- inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector): (InjectedScript._serializeRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
- inspector/front-end/inspector.js: (WebInspector.set hoveredDOMNode):
- inspector/front-end/treeoutline.js: (TreeOutline.prototype.findTreeElement):
- inspector/front-end/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): (Node.prototype.enclosingNodeOrSelfWithClass): (isAncestorNode): (firstCommonNodeAncestor): (traverseNextNode): (traversePreviousNode): ():
- loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
- page/android/InspectorControllerAndroid.cpp:
- 6:14 AM Changeset in webkit [47338] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix crash on ./ecma_2/RegExp/exec-002.js.
https://bugs.webkit.org/show_bug.cgi?id=28353
Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses):
- 6:14 AM Changeset in webkit [47337] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
- 5:33 AM Changeset in webkit [47336] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed. Add missing WML specific layout test result.
Aug 15, 2009:
- 11:49 PM Changeset in webkit [47335] by
-
- 2 edits in trunk/LayoutTests
Make Mark Rowe a bit less grumpy.
- http/tests/history/back-to-post.php:
- 11:43 PM Changeset in webkit [47334] by
-
- 3 edits in trunk/LayoutTests
Make http/tests/history/back-to-post.php's output a bit more reliable.
- http/tests/history/back-to-post-expected.txt:
- http/tests/history/back-to-post.php:
- 9:40 PM Changeset in webkit [47333] by
-
- 2 edits in trunk/WebCore
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Optimize updateFillImages() to not add/remove clients every time
https://bugs.webkit.org/show_bug.cgi?id=28334
Optimize the case where old and new just have a single layer pointing to the same (or no)
image.
- rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages):
- 6:32 PM Changeset in webkit [47332] by
-
- 4 edits2 adds in trunk
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Implement animations of multiple text-shadows and -webkit-box-shadows.
https://bugs.webkit.org/show_bug.cgi?id=28266
Test: transitions/multiple-shadow-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::equals): (WebCore::PropertyWrapperShadow::blend):
- 6:32 PM Changeset in webkit [47331] by
-
- 4 edits6 adds in trunk
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Make transitions work for position and size of multiple backgrounds and masks.
https://bugs.webkit.org/show_bug.cgi?id=28266
Make background-position, background-size, -webkit-mask-position and -webkit-mask-size
properties animatable with multiple backgrounds, rather than just animating the first one.
Tests: transitions/multiple-background-size-transitions.html
transitions/multiple-background-transitions.html
transitions/multiple-mask-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::FillLayerPropertyWrapperBase::FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperBase::~FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperGetter::FillLayerPropertyWrapperGetter): (WebCore::FillLayerPropertyWrapperGetter::equals): (WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper): (WebCore::FillLayerPropertyWrapper::blend): (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): (WebCore::FillLayersPropertyWrapper::equals): (WebCore::FillLayersPropertyWrapper::blend): (WebCore::ensurePropertyMap):
- rendering/style/FillLayer.h: (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setSize):
- 5:23 PM Changeset in webkit [47330] by
-
- 3 edits in trunk/JavaScriptCore
Fix the build with JIT disabled.
- runtime/Arguments.h: Only compile the jitCode method when the JIT is enabled.
- runtime/Executable.h: Include PrototypeFunction.h so the compiler knows what
NativeFunctionWrapper is when the JIT is disabled.
- 5:16 PM Changeset in webkit [47329] by
-
- 3 edits1 add in trunk
2009-08-15 George Staikos <george.staikos@torchmobile.com>
Reviewed by Jan Alonzo.
Don't crash in fieldset code when WML is enabled.
https://bugs.webkit.org/show_bug.cgi?id=28012
Test: fast/wml/html-fieldset-crash.html
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend): ++brackets
- 4:01 PM Changeset in webkit [47328] by
-
- 3 edits in trunk/WebCore
Try and enable EventSource on Windows.
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- 3:54 PM Changeset in webkit [47327] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove no longer correct and now failing test. document.body.onunload
has now been spec'ed in HTML5.
- fast/events/onunload-body-property-expected.txt: Removed.
- fast/events/onunload-body-property.html: Removed.
- 3:14 PM Changeset in webkit [47326] by
-
- 4 edits6 adds in trunk
WebCore: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343
Reviewed by Dan Bernstein.
Tests: fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::setOnblur): Use setWindowAttributeEventListener instead of setAttributeEventListener.
(WebCore::HTMLBodyElement::setOnerror): Ditto.
(WebCore::HTMLBodyElement::setOnfocus): Ditto.
(WebCore::HTMLBodyElement::setOnload): Ditto.
(WebCore::HTMLBodyElement::setOnbeforeunload): Ditto.
(WebCore::HTMLBodyElement::setOnmessage): Ditto.
(WebCore::HTMLBodyElement::setOnoffline): Ditto.
(WebCore::HTMLBodyElement::setOnonline): Ditto.
(WebCore::HTMLBodyElement::setOnresize): Ditto.
(WebCore::HTMLBodyElement::setOnstorage): Ditto.
(WebCore::HTMLBodyElement::setOnunload): Ditto.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::setOnblur): Ditto.
(WebCore::HTMLFrameSetElement::setOnerror): Ditto.
(WebCore::HTMLFrameSetElement::setOnfocus): Ditto.
(WebCore::HTMLFrameSetElement::setOnload): Ditto.
(WebCore::HTMLFrameSetElement::setOnbeforeunload): Ditto.
(WebCore::HTMLFrameSetElement::setOnmessage): Ditto.
(WebCore::HTMLFrameSetElement::setOnoffline): Ditto.
(WebCore::HTMLFrameSetElement::setOnonline): Ditto.
(WebCore::HTMLFrameSetElement::setOnresize): Ditto.
(WebCore::HTMLFrameSetElement::setOnstorage): Ditto.
(WebCore::HTMLFrameSetElement::setOnunload): Ditto.
LayoutTests: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343
Reviewed by Dan Bernstein.
- fast/dom/Window/HTMLBodyElement-window-eventListener-attributes-expected.txt: Added.
- fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html: Added.
- fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-expected.txt: Added.
- fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html: Added.
- fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js: Added.
- fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js: Added.
- 2:35 PM Changeset in webkit [47325] by
-
- 3 edits in trunk/WebCore
Fix up some IDL comments.
Reviewed by Dan Bernstein.
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.idl:
- 2:25 PM Changeset in webkit [47324] by
-
- 2 edits in trunk
[GTK] Added EventSource to the build (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- configure.ac:
- 2:04 PM Changeset in webkit [47323] by
-
- 27 edits31 adds in trunk
JavaScriptCore: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
- Configurations/FeatureDefines.xcconfig:
WebCore: Added implementation of the EventSource object that enables
server-sent events from HTML5.
http://dev.w3.org/html5/eventsource/
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
Tests: fast/eventsource/eventsource-attribute-listeners.html
fast/eventsource/eventsource-constructor.html
http/tests/eventsource/eventsource-bad-mime-type.html
http/tests/eventsource/eventsource-parse-event-stream.html
http/tests/eventsource/eventsource-reconnect.html
http/tests/eventsource/eventsource-status-code-states.html
http/tests/eventsource/workers/eventsource-simple.html
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::eventSource):
- bindings/js/JSEventSourceConstructor.cpp: Added.
(WebCore::):
(WebCore::JSEventSourceConstructor::JSEventSourceConstructor):
(WebCore::constructEventSource):
(WebCore::JSEventSourceConstructor::getConstructData):
- bindings/js/JSEventSourceConstructor.h: Added.
(WebCore::JSEventSourceConstructor::classInfo):
- bindings/js/JSEventSourceCustom.cpp: Added.
(WebCore::JSEventSource::markChildren):
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::eventSource):
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::toEventSource):
- dom/EventTarget.h:
- page/DOMWindow.idl:
- page/EventSource.cpp: Added.
(WebCore::EventSource::EventSource):
(WebCore::EventSource::~EventSource):
(WebCore::EventSource::connect):
(WebCore::EventSource::endRequest):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::reconnectTimerFired):
(WebCore::EventSource::url):
(WebCore::EventSource::readyState):
(WebCore::EventSource::close):
(WebCore::EventSource::scriptExecutionContext):
(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):
(WebCore::EventSource::dispatchEvent):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didReceiveData):
(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::didFail):
(WebCore::EventSource::didFailRedirectCheck):
(WebCore::EventSource::parseEventStream):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::dispatchGenericEvent):
(WebCore::EventSource::dispatchMessageEvent):
(WebCore::EventSource::stop):
- page/EventSource.h: Added.
(WebCore::EventSource::create):
(WebCore::EventSource::):
(WebCore::EventSource::setOnopen):
(WebCore::EventSource::onopen):
(WebCore::EventSource::setOnmessage):
(WebCore::EventSource::onmessage):
(WebCore::EventSource::setOnerror):
(WebCore::EventSource::onerror):
(WebCore::EventSource::toEventSource):
(WebCore::EventSource::eventListeners):
(WebCore::EventSource::refEventTarget):
(WebCore::EventSource::derefEventTarget):
- page/EventSource.idl: Added.
- workers/WorkerContext.idl:
WebKit/mac: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
- Configurations/FeatureDefines.xcconfig:
WebKitTools: Added EventSource to the build script (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- Scripts/build-webkit:
LayoutTests: Tests for EventSource.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- fast/eventsource: Added.
- fast/eventsource/eventsource-attribute-listeners-expected.txt: Added.
- fast/eventsource/eventsource-attribute-listeners.html: Added.
- fast/eventsource/eventsource-constructor-expected.txt: Added.
- fast/eventsource/eventsource-constructor.html: Added.
- http/tests/eventsource: Added.
- http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Added.
- http/tests/eventsource/eventsource-bad-mime-type.html: Added.
- http/tests/eventsource/eventsource-parse-event-stream-expected.txt: Added.
- http/tests/eventsource/eventsource-parse-event-stream.html: Added.
- http/tests/eventsource/eventsource-reconnect-expected.txt: Added.
- http/tests/eventsource/eventsource-reconnect.html: Added.
- http/tests/eventsource/eventsource-status-code-states-expected.txt: Added.
- http/tests/eventsource/eventsource-status-code-states.html: Added.
- http/tests/eventsource/resources: Added.
- http/tests/eventsource/resources/bad-mime-type.asis: Added.
- http/tests/eventsource/resources/event-stream.php: Added.
- http/tests/eventsource/resources/reconnect.php: Added.
- http/tests/eventsource/resources/simple-event-stream.asis: Added.
- http/tests/eventsource/resources/status-codes.php: Added.
- http/tests/eventsource/workers: Added.
- http/tests/eventsource/workers/eventsource-simple-expected.txt: Added.
- http/tests/eventsource/workers/eventsource-simple.html: Added.
- http/tests/eventsource/workers/resources: Added.
- http/tests/eventsource/workers/resources/simple-worker.js: Added.
(es.onmessage):
(es.onerror):
- 1:53 PM Changeset in webkit [47322] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Xan Lopez.
Fix compiler warnings.
- webkit/webkitwebview.cpp: (clipboard_contents_received): (webkit_web_view_drag_data_get):
- 11:30 AM Changeset in webkit [47321] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-15
Add myself to list of committers.
- Scripts/modules/committers.py:
- 4:25 AM Changeset in webkit [47320] by
-
- 12 edits in trunk/WebKitTools
WebKitTools: Fix layout test failures after r47312.
Reviewed by Cameron Zwarich.
- DumpRenderTree/AccessibilityController.h:
Replaced logFocusEvents() with setLogFocusEvents(), which takes a
boolean argument to turn logging of focus events on or off.
Added a function to reset the AccessibilityController to a consistent
state.
- DumpRenderTree/AccessibilityController.cpp:
(logFocusEventsCallback):
Call setLogFocusEvents() to enable logging.
(AccessibilityController::resetToConsistentState):
Call setLogFocusEvents() to disable logging.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogFocusEvents):
Update stub.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::setLogFocusEvents):
Update stub.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState method.
- DumpRenderTree/mac/FrameLoadDelegate.h:
Declare the resetToConsistentState method.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate resetToConsistentState]):
Call the AccessibilityController's resetToConsistentState() function.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::~AccessibilityController):
Turn off focus event logging when the controller is destroyed.
(AccessibilityController::setLogFocusEvents):
If the caller passes false, unhook the focus event, and clear
m_focusEventHook.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState function.
- DumpRenderTree/win/FrameLoadDelegate.h:
Declare the resetToConsistentState() function.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::resetToConsistentState):
Call the AccessibilityController's resetToConsistentState() function.
- 2:02 AM Changeset in webkit [47319] by
-
- 4 edits in trunk/WebCore
2009-08-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Minor DOMAgent bugfixes.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeForId):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
- 1:56 AM Changeset in webkit [47318] by
-
- 3 edits in trunk/WebCore
2009-08-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Evaluating objects while on a breakpoint dumps string
representation instead of live object.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.this._evalInInspectedWindow): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame.delayedEvaluation): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame):
- 12:31 AM Changeset in webkit [47317] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-15 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding two new files to WebCore/platform/haiku:
LocalizedStringsHaiku.cpp and LoggingHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28129
- platform/haiku/LocalizedStringsHaiku.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText):
- platform/haiku/LoggingHaiku.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
- 12:27 AM Changeset in webkit [47316] by
-
- 2 edits in trunk/WebCore
Fix GTK build.
Patch by Darin Adler <Darin Adler> on 2009-08-15
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(fallbackObject): Pass 0 for document. Should be OK at least for now.
- 12:09 AM Changeset in webkit [47315] by
-
- 2 edits in trunk/WebCore
Fix Qt build.
Patch by Darin Adler <Darin Adler> on 2009-08-15
- dom/XMLTokenizerQt.cpp: Use create functions instead of calling new
directly to make CDATASection and Comment nodes.
Aug 14, 2009:
- 11:29 PM Changeset in webkit [47314] by
-
- 2 edits in trunk/LayoutTests
Remove two tests from the skipped list that don't exist.
Rubber-stamped by Mark Rowe.
- platform/win/Skipped:
- 11:25 PM Changeset in webkit [47313] by
-
- 68 edits1 delete in trunk/WebCore
Make DOM classes start with a reference count of 1, like all other RefCounted
https://bugs.webkit.org/show_bug.cgi?id=28068
Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.
First half, everything except for element classes.
- GNUmakefile.am: Removed DocPtr.h.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Attr.cpp:
(WebCore::Attr::Attr): Added a call to createTextChild here so callers don't
have to call it explicitly.
(WebCore::Attr::create): Added.
(WebCore::Attr::setValue): Changed to take AtomicString.
(WebCore::Attr::cloneNode): Use create.
- dom/Attr.h: Added a create function. Made the constructor private,
and a lot of other functions private as well.
- dom/Attribute.cpp:
(WebCore::Attribute::createAttrIfNeeded): Use Attr::create.
- dom/CDATASection.cpp:
(WebCore::CDATASection::create): Added.
(WebCore::CDATASection::cloneNode): Use create.
(WebCore::CDATASection::virtualCreate): Ditto.
- dom/CDATASection.h: Added a create function. Made everything private.
Removed unneeded destructor declaration.
- dom/CharacterData.cpp:
(WebCore::CharacterData::CharacterData): Replaced the multiple constructors
with a single one that takes ConstructionType.
- dom/CharacterData.h: Made more functions be protected and private.
Made m_data be private.
- dom/Comment.cpp:
(WebCore::Comment::Comment): Got rid of an extra constructor.
(WebCore::Comment::create): Added.
(WebCore::Comment::cloneNode): Call create.
- dom/Comment.h: Added a create function. Made everything private.
- dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents): Use RefPtr instead of DocPtr.
(WebCore::dispatchChildRemovalEvents): Ditto.
- dom/ContainerNode.h: Made the constructor protected and passed
ConstructionType instead of an isElement boolean.
- dom/DocPtr.h: Removed.
- dom/Document.cpp:
(WebCore::Document::Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::removedLastRef): Use explicit calls to selfOnlyRef
and selfOnlyDeref instead of a DocPtr in here.
(WebCore::Document::~Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::createDocumentFragment): Call create.
(WebCore::Document::createTextNode): Ditto.
(WebCore::Document::createComment): Ditto.
(WebCore::Document::createCDATASection): Ditto.
(WebCore::Document::createProcessingInstruction): Ditto.
(WebCore::Document::createEntityReference): Ditto.
(WebCore::Document::createEditingTextNode): Ditto.
(WebCore::Document::importNode): Call Attr::create.
(WebCore::Document::createAttributeNS): Ditto.
- dom/Document.h: Call adoptRef. Made a lot of functions private and
protected and sorted them so public functions come first.
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::create): Added.
(WebCore::DocumentFragment::cloneNode): Call create.
- dom/DocumentFragment.h: Added create.
- dom/DocumentType.cpp:
(WebCore::DocumentType::DocumentType): Pass type to Node constructor.
(WebCore::DocumentType::cloneNode): Use create.
- dom/DocumentType.h:
(WebCore::DocumentType::create): Call adoptRef.
- dom/EditingText.cpp:
(WebCore::EditingText::create): Added.
- dom/EditingText.h: Added a create function. Made everything private.
- dom/Element.cpp:
(WebCore::Element::Element): Pass CreateElementZeroRefCount to preserve
the zero reference count behavior for classes derived from Element.
- dom/EntityReference.cpp:
(WebCore::EntityReference::create): Added.
(WebCore::EntityReference::cloneNode): Call create.
- dom/EntityReference.h: Added create. Made everything private.
- dom/Node.cpp:
(WebCore::Node::initialRefCount): Added. Inline helper function for
the constructor.
(WebCore::Node::isContainer): Ditto.
(WebCore::Node::isElement): Ditto.
(WebCore::Node::isText): Ditto.
(WebCore::Node::Node): Changed to take a construction type argument.
Since m_document is now a normal pointer, added a call to selfOnlyRef.
(WebCore::Node::~Node): Ditto, but selfOnlyDeref.
(WebCore::Node::setDocument): Added selfOnlyRef/Deref calls.
(WebCore::Node::appendTextContent): Use the data function instead of
calling nodeValue functions, which do the same thing in a roundabout way.
- dom/Node.h: Made the constructor protected and replaced the multiple
arguments iwth a single ConstructionType argument. Sorted the public
things first.
- dom/Notation.h: Made most things private.
- dom/Notation.cpp: Removed extra constructor.
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::create): Added.
(WebCore::ProcessingInstruction::cloneNode): Call create.
- dom/ProcessingInstruction.h: Added create function. Made many other
members private.
- dom/Range.cpp:
(WebCore::Range::processContents): Use DocumentFragment::create.
- dom/Text.cpp:
(WebCore::Text::Text): Updated for base class change.
(WebCore::Text::create): Added.
(WebCore::Text::splitText): Changed to not require access to m_data.
(WebCore::Text::cloneNode): Call create.
(WebCore::Text::createRenderer): Call dataImpl.
(WebCore::Text::attach): Call data.
(WebCore::Text::recalcStyle): Call dataImpl.
(WebCore::Text::virtualCreate): Call create.
(WebCore::Text::createWithLengthLimit): Call create.
(WebCore::Text::formatForDebugger): Call data.
- dom/Text.h: Added a create function. Made many other members private.
Renamed createNew to virtualCreate.
- dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::enterText): Call Text::create.
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::cdataBlock): Call CDATASection::create.
(WebCore::XMLTokenizer::comment): Call Comment::create.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
Call data instead of string.
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply): Call Text::create.
- editing/EditorCommand.cpp:
(WebCore::executeInsertNode): Call DocumentFragment::create.
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply): Call Text::create.
- editing/markup.cpp:
(WebCore::appendStartMarkup): Call data instead of nodeValue.
- html/HTMLDocument.h:
(WebCore::HTMLDocument::create): Call adoptRef.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment): Call DocumentFragment::create.
(WebCore::replaceChildrenWithFragment): Call data instead of string.
(WebCore::replaceChildrenWithText): Call Text::create.
(WebCore::HTMLElement::setInnerText): Call DocumentFragment::create and
Text::create.
(WebCore::HTMLElement::setOuterText): Call Text::create.
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): Call Text::create.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText): Call Text::create.
- html/HTMLParser.cpp:
(WebCore::HTMLParser::textCreateErrorCheck): Call Text::create.
(WebCore::HTMLParser::commentCreateErrorCheck): Call Comment::create.
(WebCore::HTMLParser::handleIsindex): Call Text::create.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addText): Call Text::create.
- html/HTMLViewSourceDocument.h:
(WebCore::HTMLViewSourceDocument::create): Call adoptRef.
- loader/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryTokenizer::appendEntry): Call Text::create.
(WebCore::FTPDirectoryTokenizer::createTDForFilename): Call Text::create.
- loader/FTPDirectoryDocument.h:
(WebCore::FTPDirectoryDocument::create): Call adoptRef.
- loader/ImageDocument.h:
(WebCore::ImageDocument::create): Ditto.
- loader/MediaDocument.h:
(WebCore::MediaDocument::create): Ditto.
- loader/PlaceholderDocument.h:
(WebCore::PlaceholderDocument::create): Ditto.
- loader/PluginDocument.h:
(WebCore::PluginDocument::create): Ditto.
- loader/TextDocument.h:
(WebCore::TextDocument::create): Ditto.
- loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading): Use RefPtr instead of DocPtr.
(WebCore::Loader::Host::didFail): Ditto.
- platform/TreeShared.h:
(WebCore::TreeShared::TreeShared): Added an initialRefCount argument,
defaulting to 1. Node still sometimes initializes it to 0 instead for now.
- rendering/RenderText.cpp:
(WebCore::RenderText::originalText): Use dataImpl instead of string.
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::originalText): Use dataImpl instead of string.
(WebCore::RenderTextFragment::previousCharacter): Ditto.
- svg/SVGDocument.h:
(WebCore::SVGDocument::create): Use adoptRef.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance): Updated to take a
PassRefPtr.
- svg/SVGElementInstance.h: Made everything private.
- wml/WMLDocument.h:
(WebCore::WMLDocument::create): Called adoptRef.
- xml/XPathNamespace.cpp:
(WebCore::XPathNamespace::XPathNamespace): Take AtomicString arguments.
- xml/XPathNamespace.h: Made everything private.
- xml/XSLTProcessor.cpp:
(WebCore::createFragmentFromSource): Use DocumentFragment::create and
Text::create.
- 11:15 PM Changeset in webkit [47312] by
-
- 8 edits2 adds in trunk
WebKitTools: Add a mechanism for logging MSAA focus events.
Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)
https://bugs.webkit.org/show_bug.cgi?id=20866
Reviewed by Oliver Hunt.
- DumpRenderTree/AccessibilityController.cpp:
(logFocusEventsCallback):
Call the AccessibilityController's logFocusEvents() function.
(AccessibilityController::getJSClass):
Add a "logFocusEvents" function to the AccessibilityController's JS
class definition.
- DumpRenderTree/AccessibilityController.h:
On Windows, include windows.h, and add a member variable to hold the
handle to the event hook for focus events. Add a declaration for a
function that enables logging of focus events.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::logFocusEvents):
Stubbed.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::logFocusEvents):
Stubbed.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
If we hooked the focus event, unhook it.
(logFocusEventProc):
When we receive a focus event, get the accessible object for the event,
and log its name to stdout.
(AccessibilityController::logFocusEvents):
Setup the focus event hook to listen for events in the current process.
LayoutTests: Add a layout test for <rdar://problem/6218721> No MSAA focus events
fired for Webkit nightly (20866)
https://bugs.webkit.org/show_bug.cgi?id=20866
Reviewed by Oliver Hunt.
- platform/win/Skipped:
Remove the blanket skipping of accessibility/, and add the individual
tests.
- platform/win/accessibility/focus-events-expected.txt: Added.
- platform/win/accessibility/focus-events.html: Added.
- 11:14 PM Changeset in webkit [47311] by
-
- 9 edits in trunk
WebCore:
2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)
Reviewed by Oliver Hunt.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner document. This is used by AXObjectCache::handleFocusedUIElementChanged(). (WebCore::AXObjectCache::focusedUIElementForPage): Code moved from AccessibilityRenderObject::focusedUIElement(). Modified to be a static function and to take a pointer to a Page. (WebCore::AXObjectCache::platformGenerateAXID): Moved the code to generate the next AXID from getAXID() to here. Added a #if to make this non-WIN only, because Windows has its own implementation. (WebCore::AXObjectCache::getAXID): Ensure that we generate a positive AXID, ranging from 1 to LONG_MAX.
- accessibility/AXObjectCache.h: Add a declaration for Document and Page. Removed the declaration of AccessibilityObject, because we include the header. Reordered the declaration of Node alphabetically. Moved the typedef for AXID to AccessibilityObject. Removed some trailing whitespace. Added a member variable to hold a pointer to the owner Document. (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner Document. (WebCore::AXObjectCache::focusedUIElementForPage): Added; code moved from AccessiblityRenderObject::focusedUIElement(). Returns the focused element with respect to accessibility. (WebCore::AXObjectCache::platformGenerateAXID): Declare a function to generate an AXID. (WebCore::AXObjectCache::objectFromAXID): Return the AccessibilityObject with the given AXID.
- accessibility/AccessibilityObject.h: Moved the typedef for AXID from AXObjectCache to here. Made the m_id member use the typedef. (WebCore::AccessibilityObject::axObjectID): Changed the return type to use the typedef. (WebCore::AccessibilityObject::setAXObjectID): Changed the argument type to use the typedef.
- accessibility/AccessibilityRenderObject.cpp: Removed some unneeded #includes. (WebCore::AccessibilityRenderObject::focusedUIElement): Moved the code to AXObjectCache::focusedUIElementForPage(), which we now call.
- accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::platformGenerateAXID): Ensure that we generate an AXID that is in the range 1 to LONG_MAX. (WebCore::AXObjectCache::handleFocusedUIElementChanged): If the Document has no Page, return. If the Page has not focused element (respecting accessibility), return. Assert that the accessibility of the focused element is not ignored, and that the object's AXID will be negative and fit into a LONG when negated. Broadcast a focus event for the object.
- dom/Document.cpp: (WebCore::Document::axObjectCache): Pass this when creating the AXObjectCache. (WebCore::Document::setFocusedNode): Call AXObjectCache::handleFocusedUIElementChanged() on Windows.
WebKit/win:
2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)
Reviewed by Oliver Hunt.
- AccessibleBase.cpp: (AccessibleBase::getAccessibilityObjectForChild): If the child ID is negative, negate it and treat it as an AXID.
- 11:08 PM Changeset in webkit [47310] by
-
- 7 edits1 add in trunk
2009-08-14 Jiahua Huang <jhuangjiahua@gmail.com>
Reviewed by Jan Alonzo.
[gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028
Remove the improper set of enum WebKitWebViewTargetInfo
by grabbing the target infos via m_helper.
- manual-tests/gtk/copy-htmltext.html: Added.
- platform/Pasteboard.h:
- platform/gtk/PasteboardGtk.cpp: (WebCore::clipboard_get_contents_cb):
- platform/gtk/PasteboardHelper.h:
Add a function in WebKit::PasteboardHelperGtk that will return the
value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
and WebCore::clipboard_get_contents_cb will use that.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
- WebCoreSupport/PasteboardHelperGtk.h:
- 10:19 PM Changeset in webkit [47309] by
-
- 2 edits in trunk
2009-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Initialize CFLAGS and CXXFLAGS before the main body of the
WEBKIT_INIT macro so C files don't get built with "-g -O2".
- autotools/webkit.m4:
- 7:53 PM Changeset in webkit [47308] by
-
- 3 edits in trunk/LayoutTests
Not reviewed, adding new test to Skipped on gtk and Qt.
DRT on these ports does not yet support layoutTestController.overridePreference.
- platform/gtk/Skipped: skip LayoutTests/fast/harness/use-page-cache.html
- platform/qt/Skipped: ditto.
- 6:36 PM Changeset in webkit [47307] by
-
- 3 edits in trunk/JavaScriptCore
- parser/Parser.h:
(JSC::EvalExecutable::parse):
(JSC::ProgramExecutable::parse):
- runtime/Executable.h:
Reviewed by NOBODY (build fix).
- 6:20 PM Changeset in webkit [47306] by
-
- 1 edit5 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=28324
First ever test using page cache!
The test verifies that override setting that enables page cache works correctly.
It navigates forward and then back and checks that onload is not fired again
but the timer continues firing.
Reviewed by Eric Seidel.
- fast/harness/resources/cached-page-1.html: Added.
- fast/harness/resources/cached-page-2.html: Added.
- fast/harness/use-page-cache-expected.txt: Added.
- fast/harness/use-page-cache.html: Added.
- 6:14 PM Changeset in webkit [47305] by
-
- 4 edits in trunk/WebCore
2009-08-14 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Fix an assertion when bringing up the Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28318
The fix for bug 28295 assumed that image clients count the number of times
addClient/removeClient is called. That was true for CachedResource clients,
but not StyleGeneratedImage clients, which pass the call onto CSSImageGeneratorValue.
Fix by making CSSImageGeneratorValue count the number of times a client is
added/removed.
- css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized):
- css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage):
- css/CSSImageGeneratorValue.h:
- 6:14 PM Changeset in webkit [47304] by
-
- 19 edits1 add in trunk/JavaScriptCore
Remove AST nodes from use within the Runtime (outside of parsing), stage 1
https://bugs.webkit.org/show_bug.cgi?id=28330
Reviewed by Oliver Hunt.
Remove the EvalNode and ProgramNode from use in the runtime. They still exist
after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
and are also still reachable behind CodeBlock::m_ownerNode.
The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on
demand during bytecode generation.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::GlobalCodeBlock::~GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
- interpreter/Interpreter.h:
- parser/Nodes.cpp:
(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
- parser/Parser.h:
(JSC::Parser::parse):
(JSC::Parser::reparse):
(JSC::Parser::parseFunctionFromGlobalCode):
(JSC::::parse):
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/Error.cpp:
(JSC::throwError):
- runtime/Error.h:
- runtime/Executable.h: Added.
(JSC::TemplateExecutable::TemplateExecutable):
(JSC::TemplateExecutable::markAggregate):
(JSC::TemplateExecutable::sourceURL):
(JSC::TemplateExecutable::lineNo):
(JSC::TemplateExecutable::bytecode):
(JSC::TemplateExecutable::jitCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/FunctionConstructor.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::markChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::codeBlocks):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- 4:25 PM Changeset in webkit [47303] by
-
- 2 edits in trunk/WebKit/mac
Build fix.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate): Add the necessary .get() calls.
- 4:21 PM Changeset in webkit [47302] by
-
- 4 edits in trunk
WebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
on 64-bit SnowLeopard
Reviewed by Anders Carlsson.
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::cancelLoad): Since this might be called while the FrameLoader is switching DocumentLoaders
during the brief moment where there is no activeDocumentLoader(), accept and handle a validly null DocumentLoader.
LayoutTests: <rdar://problem/7091546> - Re-enable 3 plugins tests that now won't crash
Reviewed by Anders Carlsson.
- platform/mac-snowleopard/Skipped:
- 4:18 PM Changeset in webkit [47301] by
-
- 2 edits in trunk/WebKit/mac
Fix leaks of NSNumber and NSMutableArray objects seen during layout tests.
Reviewed by Brady Eidson.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate): Don't leak an NSMutableArray that we allocate.
- 4:18 PM Changeset in webkit [47300] by
-
- 2 edits in trunk/WebKit/mac
Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen during layout tests.
Reviewed by Anders Carlsson.
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::didFail): Disconnect the stream from the plug-in instance proxy
when the load fails.
- 3:06 PM Changeset in webkit [47299] by
-
- 2 edits in trunk/WebCore
Correct libcurl crash when downloading local files.
https://bugs.webkit.org/show_bug.cgi?id=28312
Reviewed by Kevin Ollivier.
No new tests. Test is covered by fast/encoding/char-encoding-mac.html.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::handleLocalReceiveResponse): New static function that
performs the local setting of valid URL and firing didReceiveResponse.
This code was moved from writeCallback.
(WebCore::writeCallback): Move local file handling to static function
(above) and use the function instead.
(WebCore::readCallback): Add check
for responseFired, and handle as a local file if it was not.
- 2:54 PM Changeset in webkit [47298] by
-
- 2 edits in trunk/LayoutTests
Adding two more to the skipped list.
Radars 7144571 and 7144583 track exploring them.
- platform/mac-snowleopard/Skipped:
- 1:54 PM Changeset in webkit [47297] by
-
- 2 edits in trunk/LayoutTests
Disable media/controls-drag-timebar.html on SnowLeopard.
<rdar://problem/7144385> tracks exploring the failure.
- platform/mac-snowleopard/Skipped:
- 1:52 PM Changeset in webkit [47296] by
-
- 3 edits in trunk/WebCore
2009-08-14 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
[Haiku] Fix RenderThemeHaiku build.
https://bugs.webkit.org/show_bug.cgi?id=28307
- platform/haiku/RenderThemeHaiku.cpp: Included RenderThemeHaiku.h instead of RenderTheme.h. (WebCore::RenderThemeHaiku::paintCheckbox): Removed the wrong 'virtual' before the function. (WebCore::RenderThemeHaiku::paintRadio): Removed the wrong 'virtual' before the function.
- platform/haiku/RenderThemeHaiku.h: Corrected wrong function definitions.
- 1:35 PM Changeset in webkit [47295] by
-
- 2 edits1 add in trunk/WebCore
2009-08-14 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
[Haiku] Adding SharedBufferHaiku to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28309
- platform/haiku/SharedBufferHaiku.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
- platform/haiku/TemporaryLinkStubs.cpp: Removed unnecessary headers and functions. (WebCore::signedPublicKeyAndChallengeString): (WebCore::getSupportedKeySizes):
- 1:29 PM Changeset in webkit [47294] by
-
- 2 edits in trunk/WebKitTools
2009-08-14 Eric Seidel <eric@webkit.org>
No review. Fix 5-space indent to be 4-spaces.
- Scripts/bugzilla-tool:
- 1:20 PM Changeset in webkit [47293] by
-
- 2 edits in trunk/WebCore
2009-08-14 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Ensure we're getting the right v8 context in the V8 DOMWindowEvent custom getter.
This should fix Chromium failing LayoutTests/fast/events/set-event-in-another-frame.html.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER):
- 1:18 PM Changeset in webkit [47292] by
-
- 10 edits in trunk
[ES5] Arguments object should inherit from Array
https://bugs.webkit.org/show_bug.cgi?id=28298
Reviewed by Gavin Barraclough
Make the Arguments object conform to the behaviour specified in ES5.
The simple portion of this is to make Arguments use Array.prototype
as its prototype rather than Object.prototype.
The spec then requires us to set instance.constructor to the pristine
Object constructor, and instance.toString and instance.toLocaleString
to the pristine versions from Object.prototype. To do this we now
make the ObjectPrototype constructor return its toString and
toLocaleString functions (similar to the call and apply functions
from FunctionPrototype).
Oddly enough this reports itself as a slight win, but given the code
isn't hit in the tests that claim to have improved I put this down to
code motion.
- 12:25 PM Changeset in webkit [47291] by
-
- 11 edits in trunk/WebCore
2009-08-14 Aaron Boodman <aa@chromium.org>
Reviewed by Alexey Proskuryakov.
BUG 28134: Move the remaining parts of Access Control from XMLHttpRequest to ThreadableDocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=28134
No new tests added since Access Control was already well tested and this is a pure refactor.
- loader/DocumentThreadableLoader.cpp: Move a lot of the access control code from XHR in, preserving its basic strategy. Also, modify the synchronous path to not be a special case, but reuse more of the async path.
(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Go through the async path and pass additional flags.
(WebCore::DocumentThreadableLoader::create): Group enum params into an options struct.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Brought mostly from XHR.
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Ditto.
(WebCore::DocumentThreadableLoader::willSendRequest): Handle preflight case.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
(WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Ditto.
(WebCore::DocumentThreadableLoader::preflightSuccess): Preflight handling.
(WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Common request function that handles async/sync.
- loader/DocumentThreadableLoader.h: Group enum params into an options struct.
- loader/ThreadableLoader.cpp: Ditto. (WebCore::ThreadableLoader::create): Ditto. (WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
- loader/ThreadableLoader.h: Ditto. (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Ditto.
- loader/WorkerThreadableLoader.cpp: Ditto. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):Ditto. (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Ditto.
- loader/WorkerThreadableLoader.h: Ditto. (WebCore::WorkerThreadableLoader::create): Ditto.
- platform/CrossThreadCopier.h: Allow ThreadableLoaderOptions to be copied across threads. (WebCore::):
- workers/WorkerScriptLoader.cpp: More enum->struct grouping. (WebCore::WorkerScriptLoader::loadSynchronously): More enum->struct grouping. (WebCore::WorkerScriptLoader::loadAsynchronously): More enum->struct grouping.
- xml/XMLHttpRequest.cpp: Remove all the access control code and some supporting state. (WebCore::XMLHttpRequest::XMLHttpRequest): Ditto. (WebCore::XMLHttpRequest::createRequest): Ditto. (WebCore::XMLHttpRequest::didFinishLoading): Ditto. (WebCore::XMLHttpRequest::didReceiveResponse): Ditto. (WebCore::XMLHttpRequest::didReceiveData): Ditto.
- xml/XMLHttpRequest.h: Ditto.
- 11:49 AM Changeset in webkit [47290] by
-
- 2 edits in trunk/JavaScriptGlue
Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.
Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.
- JSUtils.cpp:
(KJSValueToJSObject):
(KJSValueToCFTypeInternal):
Changed from isObject to inherits.
- 11:25 AM Changeset in webkit [47289] by
-
- 2 edits in trunk/LayoutTests
2009-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Remove media/video-played.html from the Windows skipped list, fixed
as part of https://bugs.webkit.org/show_bug.cgi?id=28275. Add
media/video-played-collapse.html for now.
- platform/win/Skipped:
- 11:12 AM Changeset in webkit [47288] by
-
- 26 edits in trunk
JavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.
Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.
- runtime/ArrayConstructor.cpp:
(JSC::arrayConstructorIsArray): Removed unneeded isObject call
and updated remaining isObject call to new name, inherits.
- runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)
but more importantly, made it non-virtual (it was already inline)
so it is now as fast as JSObject::inherits was.
- runtime/JSObject.h: Removed inherits function since the one
in the base class is fine as-is. Also made various JSCell functions
that should not be called on JSObject uncallable by making them
both private and not implemented.
(JSC::JSCell::inherits): Updated name.
(JSC::JSValue::inherits): Ditto.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncConcat):
- runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
- runtime/JSValue.h:
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
- runtime/ScopeChain.cpp:
(JSC::ScopeChain::localDepth):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
Updated to new name, inherits, from old name, isObject.
WebCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.
Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.
- bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
Updated to new name, inherits, from old name, isObject.
- 10:58 AM Changeset in webkit [47287] by
-
- 4 edits2 moves in trunk/LayoutTests
2009-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
media/video-played.html always times out on Windows
https://bugs.webkit.org/show_bug.cgi?id=28275
- media/video-played-collapse.html:
Make sub-test assumptions obvious for someone reading this later.
- media/video-played.html: Removed.
- media/video-played-expected.txt: Removed.
- media/video-played-ranges-1-expected.txt: Copied from LayoutTests/media/video-played-expected.txt.
- media/video-played-ranges-1.html: Copied from LayoutTests/media/video-played.html.
Split video-played.html into video-played-ranges-1.html and video-played-ranges-2.html.
- media/video-played-reset.html:
Make sub-test assumptions obvious for someone reading this later.
- media/video-played.js: (logRanges):
New but not currently called. Allows all ranges to be logged for debugging.
(testRanges):
Log ranges and the amount of time each test takes when logTestTiming != 0.
(nextTest):
Record test start time when logTestTiming is true;
(startPlaying):
Run each sub-test for 100ms instead of 250ms to decrease overall test time.
(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):
Make error conditions trigger immediate failure instead of just logging.
- 8:51 AM Changeset in webkit [47286] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-14 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Fix webkit_web_view_set_highlight_text_matches() so that highlighting
works properly in documents with frames.
- webkit/webkitwebview.cpp: (webkit_web_view_set_highlight_text_matches):
- 7:50 AM Changeset in webkit [47285] by
-
- 2 edits in trunk/WebKit/qt
RVCT elftran fails to resolve QPainter::staticMetaObject coming with
QWebView::RenderHints property.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.
This is a temporary fix and will be revereted when the right symbols
exported from Qt lib in S60.
https://bugs.webkit.org/show_bug.cgi?id=28181
- Api/qwebview.h:
- 7:44 AM Changeset in webkit [47284] by
-
- 4 edits in trunk
Adding QNX as a platform. Currently only tested with Qt.
Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-07-31
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=27885
- JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base since QNX doesn't have the pthread _nt functions
- JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding defines
- WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX
- 7:21 AM Changeset in webkit [47283] by
-
- 8 edits in trunk
WebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036
Patch by Laszlo Gombos <Laszlo Gombos> on 2009-08-14
Reviewed by Simon Hausmann.
Disables LocalStorage for QtWebKit by default by setting
QWebSettings::LocalStorageEnabled to false.
Sets up a default for the LocalStorage path so that clients would only
need to enable the LocalStorageEnabled setting to turn on LocalStoragre
support.
Turn on LocalStorage support for QtLauncher and the relevant test
since LocalStorage is now disabled by default for QtWebkit.
- Api/qwebpage.cpp:
(defaultCachePath):
(initializeApplicationCachePathIfNecessary):
(QWebPagePrivate::QWebPagePrivate):
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
(QWebSettings::setLocalStoragePath):
(QWebSettings::localStoragePath):
- Api/qwebsettings.h:
- QtLauncher/main.cpp:
(main):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::multiplePageGroupsAndLocalStorage):
WebKitTools: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036
Patch by Laszlo Gombos <Laszlo Gombos> on 2009-08-14
Reviewed by Simon Hausmann.
Turn on LocalStorage support for Qt DumpRenderTree since
LocalStorage is now disabled by defult for QtWebkit.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
- 7:19 AM Changeset in webkit [47282] by
-
- 7 edits in trunk
WebCore: Allow Qt API to list and to remove URL schemes that were registered as
local URL schemes.
[Qt] Allow applications to register their own local URL scheme.
https://bugs.webkit.org/show_bug.cgi?id=28240
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.
- 5:54 AM Changeset in webkit [47281] by
-
- 2 edits in trunk/PlanetWebKit
Add the blog of University of Szeged.
https://bugs.webkit.org/show_bug.cgi?id=28301
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.
- config.ini:
- 5:05 AM Changeset in webkit [47280] by
-
- 2 edits in trunk/WebKitTools
2009-08-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Do not unref the main webview, it's owned by its parent
container. Instead destroy the container, which should take care
of everything (not terribly important since we exit right after
that, but still).
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
- 5:01 AM Changeset in webkit [47279] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
[Qt] Add test result after r47255.
- platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
- platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
- 4:49 AM Changeset in webkit [47278] by
-
- 2 edits in trunk/JavaScriptCore
Currently generic ARM and ARMv7 platforms work only with JSVALUE32
https://bugs.webkit.org/show_bug.cgi?id=28300
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.
- wtf/Platform.h:
- 4:39 AM Changeset in webkit [47277] by
-
- 7 edits in trunk/WebCore
2009-08-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Wrap console objects late (in the frontend) so that injected
script was already in place.
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::setFrontendProxyObject):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::addMessageToConsole):
- inspector/InspectorFrontend.h:
- 3:56 AM Changeset in webkit [47276] by
-
- 1 edit in trunk/JavaScriptCore/runtime/ArrayConstructor.cpp
Try to fix the build when !JIT_OPTIMIZE_NATIVE_CALL
- 3:12 AM Changeset in webkit [47275] by
-
- 2 edits2 adds in trunk/LayoutTests
2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Update test result after r47255.
Also while I am at it, add pixel test result.
- platform/qt/fast/block/float/035-expected.checksum: Added.
- platform/qt/fast/block/float/035-expected.png: Added.
- platform/qt/fast/block/float/035-expected.txt: Adjusted.
- 2:17 AM Changeset in webkit [47274] by
-
- 2 edits in trunk/JavaScriptCore
Enable JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.
- wtf/Platform.h:
- 2:17 AM Changeset in webkit [47273] by
-
- 2 edits in trunk/JavaScriptCore
Enable YARR_JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.
- wtf/Platform.h:
- 12:09 AM Changeset in webkit [47272] by
-
- 2 edits in trunk/JavaScriptCore
Remove MarkStack::drain from the JSC exports file
MarkStack::drain is now marked inline, the including it in the exports file
produces an ld warning
- 12:00 AM Changeset in webkit [47271] by
-
- 6 edits3 adds in trunk
[ES5] Implement Array.isArray
https://bugs.webkit.org/show_bug.cgi?id=28296
Reviewed by Maciej Stachowiak
Add support for Array.isArray to the Array constructor
Aug 13, 2009:
- 11:22 PM Changeset in webkit [47270] by
-
- 3 edits2 adds in trunk
2009-08-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix logic in RenderObject::updateFillImages() that led to incorrect client
counts if an image was used twice in the background-image property.
https://bugs.webkit.org/show_bug.cgi?id=28295
Test: fast/backgrounds/multiple-backgrounds-assert.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages): Simplify the logic to call addClient()/removeClient() for every background image, but go through the new layers first to avoid removing all the clients of an image.
- 11:11 PM Changeset in webkit [47269] by
-
- 2 edits in trunk/JavaScriptCore
Remove accidentally left in debugging statement.
Reviewed by Oliver Hunt.
- runtime/JSArray.h:
(JSC::MarkStack::drain):
- 10:41 PM Changeset in webkit [47268] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix windows build
- 10:35 PM Changeset in webkit [47267] by
-
- 31 edits in trunk
Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294
Reviewed by Maciej Stachowiak.
Add a bit to TypeInfo to indicate that an object uses the standard
JSObject::markChildren method. This allows us to devirtualise marking
of most objects (though a branch is still needed). We also add a branch
to identify arrays thus devirtualising marking in that case as well.
In order to make the best use of this devirtualisation I've also reworked
the MarkStack::drain() logic to make the iteration more efficient.
- 9:31 PM Changeset in webkit [47266] by
-
- 4 edits in trunk
Revert "2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>"
Revert http://trac.webkit.org/changeset/47203 as it makes the http/XHR tests fail.
- 6:15 PM Changeset in webkit [47265] by
-
- 8 edits1 delete in trunk
JavaScriptCore: Some small bits of housekeeping.
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by Mark Rowe.
- JavaScriptCore.xcodeproj/project.pbxproj: Make Parser.h
project instead of private. Remove JSONObject.lut.h.
- assembler/ARMAssembler.h: Remove unneeded WTF prefix.
- assembler/AssemblerBufferWithConstantPool.h: Ditto.
- bytecompiler/BytecodeGenerator.h: Ditto.
- wtf/SegmentedVector.h: Add a "using" statement as we do
with the other WTF headers.
WebCore: Follow-up to earlier work to remove dependencies on JavaScriptCore.
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by Mark Rowe.
- ForwardingHeaders/parser/Parser.h: Removed.
- inspector/JavaScriptDebugServer.cpp: Removed now-unneeded includes
of Parser.h.
- 6:11 PM Changeset in webkit [47264] by
-
- 2 edits in trunk/JavaScriptCore
Fix Tiger build.
Patch by Darin Adler <Darin Adler> on 2009-08-13
- parser/Grammar.y: Use a template function so we can compile
setStatementLocation even if it comes before YYLTYPE is defined.
- 5:58 PM Changeset in webkit [47263] by
-
- 2 edits in trunk/JavaScriptCore
Too much use of void* in Grammar.y
https://bugs.webkit.org/show_bug.cgi?id=28287
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Changed all the helper functions to
take a JSGlobalData* instead of a void*. A couple formatting
tweaks that I missed when breaking this into pieces.
- 5:56 PM Changeset in webkit [47262] by
-
- 2 edits in trunk/JavaScriptCore
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Reduced and sorted includes. Tweaked comment
format. Marked a few more functions inline.
- 5:52 PM Changeset in webkit [47261] by
-
- 3 edits4 adds in trunk
WebCore: 'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279
Reviewed by Eric Seidel.
Test: fast/flexbox/block-axis.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EBoxOrient): Map block-axis to
vertical.
LayoutTests: 2009-08-13 Dan Bernstein <mitz@apple.com>
Reviewed by Eric Seidel.
'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279
- fast/flexbox/block-axis-expected.checksum: Added.
- fast/flexbox/block-axis-expected.png: Added.
- fast/flexbox/block-axis-expected.txt: Added.
- fast/flexbox/block-axis.html: Added.
- 5:51 PM Changeset in webkit [47260] by
-
- 4 edits2 adds in trunk
2009-08-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix crash when removing reflection on an absolutely-positioned image.
https://bugs.webkit.org/show_bug.cgi?id=28289
Make sure we clean up the reflection layer when removing the reflection,
so that the RenderLayer tree does not contain pointers to deleted layers.
Test: fast/reflections/reflected-img-crash.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::removeReflection):
- rendering/RenderLayer.h:
- 5:49 PM Changeset in webkit [47259] by
-
- 4 edits in trunk/JavaScriptCore
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Pass the number to the PropertyNode instead of
first turning it into an Identifier.
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode): Add an overload that takes a double
so the code to convert to a string can be here instead of Grammar.y.
- parser/Nodes.h: Ditto.
- 5:47 PM Changeset in webkit [47258] by
-
- 2 edits in trunk/JavaScriptCore
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Eliminate the DBG macro.
- 5:46 PM Changeset in webkit [47257] by
-
- 2 edits in trunk/JavaScriptCore
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Eliminate the SET_EXCEPTION_LOCATION macro.
- 5:44 PM Changeset in webkit [47256] by
-
- 2 edits in trunk/JavaScriptCore
George asked me to break the patch from
https://bugs.webkit.org/show_bug.cgi?id=28287
into smaller pieces and land it in stages.
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.
- parser/Grammar.y: Eliminate the LEXER macro.
- 5:40 PM Changeset in webkit [47255] by
-
- 18 edits8 adds in trunk
WebCore: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869
Reviewed by Simon Fraser.
One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>
Tests: fast/block/float/avoidance-percent-width-compat.html
fast/block/float/avoidance-percent-width-strict.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Changed to apply the same float
avoidance logic in strict mode and in compatibility mode, which
matches Firefox and IE. Changed to compute and use the computed
width of the child, instead of ignoring non-fixed widths.
LayoutTests: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869
Reviewed by Simon Fraser.
One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>
- fast/block/float/avoidance-percent-width-compat.html: Added.
- fast/block/float/avoidance-percent-width-strict.html: Added.
- platform/mac/fast/block/float/035-expected.checksum:
- platform/mac/fast/block/float/035-expected.png:
- platform/mac/fast/block/float/035-expected.txt:
- platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum: Added.
- platform/mac/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
- platform/mac/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
- platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
- platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
- platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
- platform/mac/fast/block/float/float-avoidance-expected.checksum:
- platform/mac/fast/block/float/float-avoidance-expected.png:
- platform/mac/fast/block/float/float-avoidance-expected.txt:
- platform/mac/fast/overflow/004-expected.checksum:
- platform/mac/fast/overflow/004-expected.png:
- platform/mac/fast/overflow/004-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug106158-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug106158-2-expected.txt:
- 5:14 PM Changeset in webkit [47254] by
-
- 2 edits in trunk/LayoutTests
2009-08-13 Eric Seidel <eric@webkit.org>
No review, only skipping tests.
Qt: Font Sizes are wrong for font families including monospace
https://bugs.webkit.org/show_bug.cgi?id=28288
- platform/qt/Skipped:
- 4:34 PM Changeset in webkit [47253] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Eric Seidel <eric@webkit.org>
No review, correcting obvious python error seen in the commit queue.
args can be a string or an array. Assuming args is always an array results in
double-spaced text in error logs.
- Scripts/bugzilla-tool:
- 4:34 PM Changeset in webkit [47252] by
-
- 5 edits3 adds in trunk
WebCore: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254
Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.
Sets the correct default values for the properties of the PositionOptions object
passed to Geolocation methods. See http://www.w3.org/TR/geolocation-API/.
Also adds checking to throw an exception if arguments of the incorrect type are
passed to Geolocation methods. Adds a layout test to test this. This test should
pass on all platforms where Geolocation is implemented.
Test: fast/dom/Geolocation/argument-types.html
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionCallback): Added. Creates the callback.
(WebCore::createPositionErrorCallback): Added. Creates the calback.
(WebCore::createPositionOptions): Added. Creates the PositionOptions object, setting defaults where required.
(WebCore::JSGeolocation::getCurrentPosition): Modified. Now uses above helper functions.
(WebCore::JSGeolocation::watchPosition): Modified. Now uses above helper functions.
- page/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Asserts that PositionOptions object is present.
(WebCore::Geolocation::GeoNotifier::startTimer): Modified. Only starts timer if timeout has been set.
- page/PositionOptions.h:
(WebCore::PositionOptions::create): Modified. Creates object with default values.
(WebCore::PositionOptions::timeout): Modified. Uses correct type.
(WebCore::PositionOptions::hasTimeout): Added. Determines whether a timeout has been set.
(WebCore::PositionOptions::setTimeout): Modified. Uses correct type.
(WebCore::PositionOptions::maximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::setMaximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::PositionOptions): Modified. Creates object with default values.
LayoutTests: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254
Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.
Adds a layout test to check the acceptable types for arguments to Geolocation methods.
- fast/dom/Geolocation/resources/argument-types.js: Added. Tests the types of the arguments that can be passed to Geolocation methods.
- fast/dom/Geolocation/argument-types.html: Added. HTML wrapper for above JS test.
- fast/dom/Geolocation/argument-types-expected.txt: Added. Expected output for above test.
- 4:31 PM Changeset in webkit [47251] by
-
- 1 edit3 deletes in trunk/LayoutTests
2009-08-13 Eric Seidel <eric@webkit.org>
Rubber-stamped by Mark Rowe.
wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161
Removing results which are expected to change, but that I have no way to update.
- platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Removed.
- platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Removed.
- platform/qt/fast/text/monospace-width-cache-expected.txt: Removed.
- 4:28 PM Changeset in webkit [47250] by
-
- 2 edits in trunk/LayoutTests
2009-08-13 Eric Seidel <eric@webkit.org>
No review, it is expected that this would change.
wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161
Update Tiger results from the bot. I have no way to update the pixel results.
- platform/mac-tiger/fast/text/monospace-width-cache-expected.txt:
- 4:24 PM Changeset in webkit [47249] by
-
- 2 edits in trunk/WebCore
2009-08-13 David Levin <levin@chromium.org>
Unreviewed chromium build fix.
[Chromium] Let CodeGeneratorV8.pm know that RGBColor is ref-counted.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- 4:23 PM CommitQueue edited by
- (diff)
- 4:18 PM CommitQueue edited by
- (diff)
- 4:08 PM CommitQueue edited by
- (diff)
- 4:05 PM CommitQueue edited by
- (diff)
- 4:04 PM CommitQueue edited by
- (diff)
- 4:01 PM CommitQueue edited by
- (diff)
- 3:59 PM CommitQueue created by
- 3:55 PM Changeset in webkit [47248] by
-
- 2 edits in trunk/WebCore
2009-08-13 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Merge error in SharedWorker code
https://bugs.webkit.org/show_bug.cgi?id=28277
Fixed merge error that prevents WebKit from compiling with SHARED_WORKERS enabled.
No new tests needed.
- workers/DefaultSharedWorkerRepository.cpp: Removed duplicated functions.
- 3:54 PM WikiStart edited by
- Add a link to the new commit queue page. (diff)
- 3:48 PM Changeset in webkit [47247] by
-
- 2 edits in trunk/WebCore
Chromium: Show a "Playback Disabled" button on media error.
https://bugs.webkit.org/show_bug.cgi?id=28196
Use a disabled play button when the media file cannot be played.
Patch by Kyle Prete <kylep@chromium.org> on 2009-08-13
Reviewed by Dave Levin.
No new tests needed. Covered by LayoutTests/media/video-empty-source.html
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
- 3:46 PM Changeset in webkit [47246] by
-
- 3 edits in trunk/JavaScriptCore
Try some more to fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
- 3:45 PM Changeset in webkit [47245] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Include stdio.h for using stdout, stderr,
and fprintf.
- DumpRenderTree/LayoutTestController.cpp:
- 3:42 PM Changeset in webkit [47244] by
-
- 4 edits in trunk
Try and fix the Qt build.
- 3:38 PM Changeset in webkit [47243] by
-
- 5 edits in trunk/WebKit/gtk
2009-08-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642
Adds support for drag actions in WebKitWebView and DragClient.
Defines a support structure that can hold additional drag and drop data,
such as selection data or target IDs (infos) and can be passed through
clipboard requests.
Implements DragClient functions that gather start position of the drag
and start the GTK drag.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::startDrag): (WebKit::DragClient::createDragImageForLink): A small style fix.
- WebCoreSupport/DragClientGtk.h:
- webkit/webkitwebview.cpp: (webkit_web_view_drag_end): (clipboard_contents_received): GtkClipboard callback. (webkit_web_view_drag_data_get): (webkit_web_view_class_init): (webkit_web_view_init):
- webkit/webkitwebview.h: Add GTK selection targets.
- 3:38 PM Changeset in webkit [47242] by
-
- 3 edits in trunk/JavaScriptCore
Try and fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
- 3:31 PM Changeset in webkit [47241] by
-
- 3 edits in trunk/WebCore
2009-08-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642
Utilizes functions that are being called upon drag and drop actions.
Uses different GTK clipboards that hold different types
of drag data - images, HTML markup, text, URL, URL label.
Also clears each clipboard before setting new data to it.
No new tests - despite some implementations, no new functionality
is added until implementations of the GTK drag and drop protocol
in WebKit part.
- platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::ClipboardGtk::~ClipboardGtk): (WebCore::getCachedImage): (WebCore::ClipboardGtk::declareAndWriteDragImage): (WebCore::ClipboardGtk::writeURL): (WebCore::ClipboardGtk::writeRange):
- platform/gtk/ClipboardGtk.h: ClipboardGdk -> ClipboardGtk
- 3:27 PM Changeset in webkit [47240] by
-
- 9 edits in trunk
Roll out r47237 as it was mistakenly landed.
- 3:22 PM Changeset in webkit [47239] by
-
- 9 edits in trunk/JavaScriptCore
Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added includes and removed a missing function from JavaScriptCore_debug.def and JavascriptCore.def.
- 3:22 PM Changeset in webkit [47238] by
-
- 1 edit1 move in trunk/WebKitTools
2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
rename make-js-test-wrappers to make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28212
- Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
- 3:17 PM Changeset in webkit [47237] by
-
- 9 edits in trunk
DRT improvements for Database stuff.
- 2:51 PM Changeset in webkit [47236] by
-
- 43 edits1 delete in trunk
JavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by David Levin.
Eliminate dependencies on Nodes.h outside JavaScriptCore,
and cut down on them inside JavaScriptCore.
Change regular expression parsing to use identifiers as
with other strings we parse.
Fix a couple things that are needed to use const Identifier
more, which will be part of the parser arena work.
- JavaScriptCore.exp: Resorted and updated.
- JavaScriptCore.xcodeproj/project.pbxproj: Changed
CollectorHeapIterator.h to be project-internal.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushNewScope): Added const.
- bytecompiler/BytecodeGenerator.h: Ditto.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Moved this function
here from WebCore. Here is better since it uses so many internals.
Removed unimportant optimization for the no listener case.
- debugger/Debugger.h: Ditto. Also removed unneeded include
and tweaked formatting and comments.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName): Call asFunction instead
of doing the unchecked static_cast.
(JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.
- jit/JITStubs.cpp:
(JSC::op_call_JSFunction): Call isHostFunction on the body rather
than on the JSFunction.
(JSC::vm_lazyLinkCall): Ditto.
(JSC::op_construct_JSConstruct): Ditto.
- parser/Grammar.y: Changed callers to use new scanRegExp with
out arguments instead of relying on state in the Lexer. And
callers that just want to skip a regular expression to use
skipRegExp.
- parser/Lexer.cpp:
(JSC::Lexer::scanRegExp): Changed to use out arguments, and to
add a prefix argument so we can add in the "=" character as needed.
Also rewrote to streamline the logic a bit inspired by suggestions
by David Levin.
(JSC::Lexer::skipRegExp): Added. Version of the function above that
does not actually put the regular expression into a string.
(JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.
- parser/Lexer.h: Changed scanRegExp to have out arguments. Added
skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.
- parser/NodeConstructors.h:
(JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.
- parser/Nodes.cpp:
(JSC::RegExpNode::emitBytecode): Changed since m_pattern and
m_flags are now Identifier instead of UString.
(JSC::FunctionBodyNode::make): Moved this function here instead
of putting it in the JSFunction.h header.
- parser/Nodes.h: Changed RegExpNode to use Identifier.
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
on the body instead of on the JSFunction object.
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString): Ditto.
- runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction): Moved here from header.
(JSC::JSFunction::isHostFunctionNonInline): Added.
(JSC::JSFunction::JSFunction): Removed unneeded initialization of
m_body to 0.
(JSC::JSFunction::setBody): Moved here from header.
- runtime/JSFunction.h: Removed unneeded includes. Moved private
constructor down to the private section. Made virtual functions
private. Removed unneeded overload of setBody and moved the body
of the function into the .cpp file. Changed assertions to use
the non-inline version of isHostFunction.
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter): Use asFunction instead
of doing the unchecked static_cast.
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::isEmpty): Added.
WebCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243
Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by David Levin.
- ForwardingHeaders/runtime/CollectorHeapIterator.h: Removed.
- WebCore.xcodeproj/project.pbxproj: Exposed a couple header
files as Private that are now needed to compile Mac WebKit.
- bindings/js/JSAudioConstructor.cpp:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSHTMLInputElementCustom.cpp:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSLazyEventListener.cpp:
- bindings/js/JSLocationCustom.cpp:
- bindings/js/JSMessageChannelConstructor.cpp:
- bindings/js/JSOptionConstructor.cpp:
- bindings/js/JSWebSocketConstructor.cpp:
- bindings/js/JSWebSocketCustom.cpp:
- bindings/js/JSWorkerConstructor.cpp:
- bindings/js/JSXMLHttpRequestConstructor.cpp:
- bridge/jni/jni_jsobject.mm:
Updated includes.
- inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::sourceParsed):
Change to not assert if this is called with no listeners.
I don't think this was guaranteed before, and we now use
this code path when recompiling. Slightly less efficient,
but this is a one-time cost when turning on the debugger.
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
Change to call Debugger::recompileAllJSFunctions.
WebKit/mac: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.
- WebView/WebScriptDebugger.mm: Ditto.
- 2:38 PM Changeset in webkit [47235] by
-
- 2 edits in trunk/LayoutTests
2009-08-13 Eric Seidel <eric@webkit.org>
Rubber-stamped by Adam Roben.
REGRESSION: 6 media tests regressed while the windows bot was broken
https://bugs.webkit.org/show_bug.cgi?id=28281
- platform/win/Skipped:
- 2:36 PM Changeset in webkit [47234] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Drew Wilson <atwilson@chromium.org> on 2009-08-13
Add myself to list of committers.
- Scripts/modules/committers.py:
- 2:35 PM Changeset in webkit [47233] by
-
- 12 edits2 adds in trunk
WebCore: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.
Reviewed by Eric Seidel.
Test: fast/loader/onhashchange-attribute-listeners.html
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::onhashchange):
(WebCore::HTMLBodyElement::setOnhashchange):
- html/HTMLBodyElement.h:
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::onhashchange):
(WebCore::HTMLFrameSetElement::setOnhashchange):
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.idl:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::onhashchange):
(WebCore::DOMWindow::setOnhashchange):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.
Reviewed by Eric Seidel.
- fast/dom/Window/window-properties-expected.txt:
- fast/loader/onhashchange-attribute-listeners-expected.txt: Added.
- fast/loader/onhashchange-attribute-listeners.html: Added.
- 2:27 PM Changeset in webkit [47232] by
-
- 3 edits in trunk/WebCore
Fix leaks of RGBColor instances from below SVGColor::rgbColor.
Reviewed by Geoff Garen.
- svg/SVGColor.cpp:
(WebCore::SVGColor::rgbColor): Return a PassRefPtr to ensure that the newly-allocated
RGBColor is cleaned up by the caller.
- svg/SVGColor.h:
- 2:12 PM Changeset in webkit [47231] by
-
- 35 edits in trunk/WebCore
2009-08-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Migrate to DOMAgent (serialized access to DOM).
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::nodeForId): (WebCore::JSInspectorBackend::idForNode): (WebCore::JSInspectorBackend::wrapObject): (WebCore::JSInspectorBackend::unwrapObject): (WebCore::JSInspectorBackend::pushNodePathToFrontend): (WebCore::JSInspectorBackend::selectDatabase): (WebCore::JSInspectorBackend::selectDOMStorage):
- bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptObjectQuarantine.h:
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isObject):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/ScriptObjectQuarantine.h:
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isObject):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearMessages): (WebCore::InspectorBackend::loaded): (WebCore::InspectorBackend::highlight): (WebCore::InspectorBackend::nodeForId): (WebCore::InspectorBackend::idForNode): (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::unwrapObject): (WebCore::InspectorBackend::pushNodePathToFrontend): (WebCore::InspectorBackend::addNodesToSearchResult): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::selectDOMStorage):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentElement):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::clearConsoleMessages): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult):
- inspector/InspectorFrontend.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions): (WebInspector.ConsoleView.prototype._messagesClicked): (WebInspector.ConsoleView.prototype.doEvalInWindow.evalCallback): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatfunction): (WebInspector.ConsoleView.prototype._formatdate): (WebInspector.ConsoleView.prototype._formatregexp): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatobject):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.setDocument): (InspectorController.getStyles): (InspectorController.getComputedStyle): (InspectorController.getInlineStyle): (InspectorController.applyStyleText): (InspectorController.setStyleText): (InspectorController.toggleStyleEnabled): (InspectorController.applyStyleRuleText): (InspectorController.addStyleSelector): (InspectorController.setStyleProperty): (InspectorController.getPrototypes): (InspectorController.getProperties): (InspectorController.setPropertyValue): (InspectorController.evaluate): (InspectorController.addInspectedNode): (InspectorController.performSearch): (InspectorController.searchCanceled):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._updateMatchesCount): (WebInspector.ElementsPanel.prototype._updateMatchesCountSoon): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleRuleText): (InjectedScript.addStyleSelector): (InjectedScript._doesSelectorAffectNode): (InjectedScript._serializeRule): (InjectedScript._serializeStyle): (InjectedScript.getProperties): (InjectedScript.evaluate): (InjectedScript.addInspectedNode): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.performSearch.matchExactItems): (InjectedScript.performSearch.matchExactId.addNodesToResults.call): (InjectedScript.performSearch.matchExactId): (InjectedScript.performSearch): (InjectedScript.performSearch.matchExactTagNames): (InjectedScript.performSearch.matchExactAttributeNames): (InjectedScript.performSearch.matchPartialTagNames): (InjectedScript.performSearch.matchStartOfTagNames): (InjectedScript.performSearch.matchPartialTagNamesAndAttributeValues): (InjectedScript.performSearch.matchPartialAttributeValues): (InjectedScript.performSearch.matchStyleSelector): (InjectedScript.performSearch.matchPlainText): (InjectedScript.performSearch.matchXPathQuery): (InjectedScript.performSearch.finishedSearching): (InjectedScript.performSearch.processChunk): (InjectedScript.searchCanceled): (InjectedScript._ensureCommandLineAPIInstalled.inspectObject): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._resolveObject): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript._createProxyObject):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy): (WebInspector.ObjectPropertyProxy):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.js: (WebInspector._updateHoverHighlight): (WebInspector.loaded): (WebInspector.clearConsoleMessages): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.updateFocusedNode): (WebInspector.addNodesToSearchResult):
- inspector/front-end/utilities.js: (Object.proxyType):
- storage/Storage.h: (WebCore::Storage::frame):
- 1:57 PM Changeset in webkit [47230] by
-
- 3 edits in trunk/WebCore
Fix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue.
Reviewed by Geoff Garen.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getRGBColorValue): Return a PassRefPtr to ensure that the
newly-allocated RGBColor is cleaned up by the caller.
- css/CSSPrimitiveValue.h:
- 1:56 PM Changeset in webkit [47229] by
-
- 8 edits6 adds in trunk
2009-08-13 Eric Seidel <eric@webkit.org>
Reviewed by David Hyatt.
wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161
Update test results now that only "font-family: monospace" is 13px.
All other combinations of font-family are 16px default size.
Add two tests:
font-family-fallback-reset: catches a bug in inheriting font-family fallback.
computed-style-font-family-monospace: tests this bug, that only "font-family: monospace" is 13px.
- fast/css/getComputedStyle/computed-style-font-family-expected.txt:
- fast/css/getComputedStyle/computed-style-font-family-monospace-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-font-family-monospace.html: Added.
- fast/css/getComputedStyle/font-family-fallback-reset-expected.txt: Added.
- fast/css/getComputedStyle/font-family-fallback-reset.html: Added.
- fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Added. (fontSizeForFamilies):
- fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Added.
- fast/js/method-check.html:
- platform/mac/css1/font_properties/font_family-expected.txt:
- platform/mac/css2.1/t1503-c522-font-family-00-b-expected.txt:
- platform/mac/fast/text/monospace-width-cache-expected.txt:
2009-08-13 Eric Seidel <eric@webkit.org>
Reviewed by David Hyatt.
wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161
Firefox only uses fixed-width default size for exactly "font-family: monospace;".
WebKit has historically used fixed-width default size any time a
font-family includes monospace in the fallback list.
This patch corrects WebKit's behavior to match Firefox.
I also had to fix a bug in WebKit's font-family fallback behavior where
child elements would inherit parts of their parents fallback lists.
This patch is mostly just replacing all cases where we used to check for:
fontDescription.genericFontFamily() == MonospaceFamily
with:
fontDescription.useFixedDefaultSize()
Tests: fast/css/getComputedStyle/computed-style-font-family-monospace.html
fast/css/getComputedStyle/font-family-fallback-reset.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
Deploy useFixedDefaultSize(). Also fix the bug where child
FontDescriptions would carry part of the parent font-family fallback list.
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
It's no longer alright to just check genericFontFamily(),
we have to check to make sure the changed style has a matching useFixedDefaultSize().
- platform/graphics/FontDescription.h: (WebCore::FontDescription::useFixedDefaultSize):
Only use the fixed default size if we have one font family and it is "monospace".
"-webkit-monospace" is the internal representation of the CSS identifier "monospace".
- 1:48 PM Changeset in webkit [47228] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Add myself to list of committers.
- Scripts/modules/committers.py:
- 1:18 PM Changeset in webkit [47227] by
-
- 2 edits in trunk/WebCore
2009-08-13 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Dimitri Glazkov.
[v8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.
This bug causes loads of test crashes, no need to add new tests
specifically for this.
- bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
- 12:49 PM Changeset in webkit [47226] by
-
- 2 edits in trunk/WebKit/qt
Doc - Some cleanup on the documentation of QWebElement
Patch by Kavindra Devi Palaraja <kavindra.palaraja@nokia.com> on 2009-08-13
Reviewed by Simon Hausmann.
- Api/qwebelement.cpp:
- 12:39 PM Changeset in webkit [47225] by
-
- 2 edits in trunk/JavaScriptCore
Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
from within the grammar to prevent these nodes from being leaked.
Rubber-stamped by Darin Adler.
- parser/Grammar.y:
- 12:01 PM Changeset in webkit [47224] by
-
- 2 edits1 move in trunk/WebKitTools
2009-08-13 Eric Seidel <eric@webkit.org>
Correct spelling error in file name. No review.
- Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
- Scripts/run-webkit-unittests:
- 11:34 AM Changeset in webkit [47223] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION(r47175): error running run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=28261
Fix "Use of uninitialized value in concatenation (.) or string at
WebKitTools/Scripts/run-webkit-tests line 191." by setting
$testsPerDumpTool to 1000 by default.
- Scripts/run-webkit-tests:
- 11:32 AM UsingGitWithWebKit edited by
- (diff)
- 11:32 AM Changeset in webkit [47222] by
-
- 3 edits in trunk/WebCore
2009-08-13 George Staikos <george.staikos@torchmobile.com>
Rubberstamped by Darin Adler.
Use ASSERT_UNUSED instead of UNUSED_PARAM
- 11:21 AM Changeset in webkit [47221] by
-
- 2 edits in trunk/WebCore
2009-08-13 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Fixes a couple of bugs in SecurityOrigin::createFromDatabaseIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=28262
No new tests possible.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
- 11:19 AM WebKit Team edited by
- Added myself to the wiki. (diff)
- 11:11 AM Changeset in webkit [47220] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Nate Chapin <Nate Chapin>
Unreviewed.
Add myself to list of committers.
- Scripts/modules/committers.py:
- 11:09 AM Changeset in webkit [47219] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
2009-08-13 Daniel Bates <dbates@webkit.org>
Unreviewed.
Added 'Daniel Bates' (myself) to the list of committers.
- Scripts/modules/committers.py:
- 11:07 AM WebKit Team edited by
- (diff)
- 11:06 AM Changeset in webkit [47218] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Add 'Brent Fulgham' to the committers list.
- Scripts/modules/committers.py:
- 11:04 AM Changeset in webkit [47217] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
2009-08-13 Yong Li <yong.li@torchmobile.com>
Unreviewed.
Added 'Yong Li' to the committers list.
- Scripts/modules/committers.py
- 11:03 AM Changeset in webkit [47216] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Adam Langley <agl@chromium.org>
Review not required.
- Scripts/modules/committers.py: Adding myself to this list because Eric told me to.
- 11:01 AM Changeset in webkit [47215] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Add 'Greg Bolsinga' to the committers list.
- Scripts/modules/committers.py:
- 10:59 AM Changeset in webkit [47214] by
-
- 2 edits in trunk/LayoutTests
Remove media/video-test.js's redundant hang timer
DRT already has a timer that does the same thing.
Reviewed by Mark Rowe.
- media/video-test.js: Remove the hang timer, since DRT does the same
thing.
- 10:58 AM Changeset in webkit [47213] by
-
- 6 edits in trunk/WebKitTools
Fix off-by-one result comparisons in media tests on Windows Debug builds
media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.
The fix is to make the watchdog timer got through the same code path
as calling notifyDone manually, so that the results will only get
printed once. A subsequent patch will remove video-test.js's hang
timer entirely, since it is redundant.
Fixes <http://webkit.org/b/28265>.
Reviewed by Mark Rowe.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
from Gtk/Mac/Win's watchdog timer handlers, but we now call
notifyDone() instead of dump() so that a subsequent call to
notifyDone() won't print the results out again.
- DumpRenderTree/LayoutTestController.h: Added
waitToDumpWatchdogTimerFired.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(waitToDumpWatchdogFired):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(waitUntilDoneWatchdogFired):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(waitUntilDoneWatchdogFired):
Changed to call waitToDumpWatchdogTimerFired.
- 10:55 AM Changeset in webkit [47212] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Added 'Eric Carlson' to the committers list.
- 10:52 AM Changeset in webkit [47211] by
-
- 2 edits in trunk/WebCore
2009-08-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
[CAIRO] getImageData fails on a given rect bigger than the image rect
The destination image and the source image was mixed up on creating the
imageData.
This is just a clean up and doesn't affect the current behavior. It's not
possible to test this failure in a LayoutTest. Only canvas uses getImageData
at the moment and returns before calling getImageData, if the image rect does
not contain the requested rect.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData):
- 10:43 AM WebKit Team edited by
- (diff)
- 10:42 AM WebKit Team edited by
- (diff)
- 10:40 AM WebKit Team edited by
- (diff)
- 10:38 AM Changeset in webkit [47210] by
-
- 2 edits in trunk/WebKitTools
2009-08-13 Dirk Schulze <krit@webkit.org>
Unreviewed.
Added 'Dirk Schulze' to the committers list.
- Scripts/modules/committers.py
- 10:37 AM WebKit Team edited by
- (diff)
- 10:34 AM WebKit Team edited by
- (diff)
- 10:18 AM Changeset in webkit [47209] by
-
- 2 edits in trunk/LayoutTests
2009-08-13 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Due to fixes in http://trac.webkit.org/changeset/47038 and http://trac.webkit.org/changeset/47163,
fast/events/mouse-click-events.html now passes, removing it from Skipped List.
- platform/win/Skipped:
- 10:14 AM Changeset in webkit [47208] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-13 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding RenderTheme to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28258
- platform/haiku/RenderThemeHaiku.cpp: Added. (WebCore::RenderThemeHaiku::create): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeHaiku::RenderThemeHaiku): (WebCore::RenderThemeHaiku::~RenderThemeHaiku): (WebCore::supportsFocus): (WebCore::RenderThemeHaiku::supportsFocusRing): (WebCore::RenderThemeHaiku::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformActiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformTextSearchHighlightColor): (WebCore::RenderThemeHaiku::systemFont): (WebCore::RenderThemeHaiku::paintCheckbox): (WebCore::RenderThemeHaiku::setCheckboxSize): (WebCore::RenderThemeHaiku::paintRadio): (WebCore::RenderThemeHaiku::setRadioSize): (WebCore::RenderThemeHaiku::adjustMenuListStyle): (WebCore::RenderThemeHaiku::paintMenuList):
- platform/haiku/RenderThemeHaiku.h: Added. (WebCore::RenderThemeHaiku::supportsHover):
- 10:13 AM Changeset in webkit [47207] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore or jscore libs change.
- 10:08 AM Changeset in webkit [47206] by
-
- 2 edits in trunk/WebCore
2009-08-13 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28256
- platform/haiku/ContextMenuHaiku.cpp: (WebCore::ContextMenuReceiver::ContextMenuReceiver): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::insertItem):
- 9:51 AM Changeset in webkit [47205] by
-
- 13 edits1 copy in trunk/WebCore
2009-08-13 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Darin Adler.
Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185
Added new file Cookie.h to the WebCore XCode
- WebCore.xcodeproj/project.pbxproj:
InspectorController.cookies() binding
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
- inspector/InspectorBackend.idl:
Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)
- platform/Cookie.h: Added. (WebCore::Cookie::Cookie):
Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)
- platform/CookieJar.h:
Implementation of getRawCookies for the mac platform.
- platform/mac/CookieJar.mm: (WebCore::getRawCookies):
Stub other CookieJar implementations to satisfy the interface.
- platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
- platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
- platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
- 9:43 AM Changeset in webkit [47204] by
-
- 2 edits in trunk/LayoutTests
2009-08-13 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Disables Geolocation 'enabled' test for GTK port, as the GTK Geolocation implementation is incomplete.
https://bugs.webkit.org/show_bug.cgi?id=27716
- platform/gtk/Skipped: Modified. Disables Geolocation 'enabled' test.
- 9:36 AM Changeset in webkit [47203] by
-
- 4 edits in trunk
2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143
Reenable the test that is fixed by this changeset.
- platform/gtk/Skipped:
2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143
Fix one of the regressions caused by the new sniffing code -
disable sniffing when that behavior is explicitly requested.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
- 9:29 AM Changeset in webkit [47202] by
-
- 2 edits in trunk/WebCore
2009-08-13 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Add a new gesture in Web Inspector to remove breakpoints
https://bugs.webkit.org/show_bug.cgi?id=19131
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
- 9:23 AM Changeset in webkit [47201] by
-
- 10 edits in trunk
2009-08-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
file, conditionally for "symbian" platform.
- WebCore.pro:
2009-08-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
files, conditionally for "symbian" platform.
- QtLauncher/QtLauncher.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebview/qwebview.pro:
- 9:16 AM Changeset in webkit [47200] by
-
- 9 edits in trunk
2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
wrong calculation of overflow size for flexbox and table
https://bugs.webkit.org/show_bug.cgi?id=28064
RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.
- fast/reflections/reflection-overflow-scroll-expected.txt:
- fast/reflections/reflection-overflow-scroll.html:
- fast/reflections/resources/reflection-overflow-scroll.js:
2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
wrong calculation of overflow size for flexbox and table
https://bugs.webkit.org/show_bug.cgi?id=28064
RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateOverflowWithShadowAndReflection): created from code of layoutBlock (WebCore::RenderBlock::layoutBlock):
- rendering/RenderBlock.h:
- rendering/RenderFlexibleBox.cpp: use updateOverflowWithShadowAndReflection (WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout): use updateOverflowWithShadowAndReflection
- 9:01 AM Changeset in webkit [47199] by
-
- 2 edits in trunk/WebKitTools
Enable running testapi in run-javascriptcore-tests on Windows
Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
testapi on Windows
Reviewed by Mark Rowe.
- Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
the AppleWinWebKit configuration.
- 9:00 AM Changeset in webkit [47198] by
-
- 2 edits in trunk/WebKitTools
Re-enable testapi in run-javascriptcore-tests on Mac
This seems to have been mistakenly disabled in r47089.
Rubber-stamped by Mark Rowe.
- Scripts/run-javascriptcore-tests: Removed comment markers that were
preventing running testapi.
- 8:25 AM UsingGitWithWebKit edited by
- (diff)
- 8:18 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 7:54 AM Changeset in webkit [47197] by
-
- 2 edits in trunk/JavaScriptCore
Remove the special-case for Qt wrt JSVALUE_32 introduced in
r46709. It must've been a dependency issue on the bot, as
after a manual build all the tests pass on amd64 and ia32.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-13
Reviewed by Ariya Hidayat.
- wtf/Platform.h:
- 7:29 AM Changeset in webkit [47196] by
-
- 9 edits in trunk/LayoutTests
2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by George Staikos.
[Qt] These tests pass, update the metrics and exclude from Skipped.
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
- platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
- platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
- platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
- platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
- platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
- platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
- 5:53 AM Changeset in webkit [47195] by
-
- 13 edits1 delete in trunk/WebCore
Revert r47185, the fix for <https://bugs.webkit.org/show_bug.cgi?id=28185>, as it broke the
Windows build in a non-obvious manner.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInspectorBackendCustom.cpp:
- inspector/InspectorBackend.idl:
- platform/Cookie.h: Removed.
- platform/CookieJar.h:
- platform/haiku/CookieJarHaiku.cpp:
(WebCore::setCookies):
(WebCore::cookies):
- platform/mac/CookieJar.mm:
- platform/network/chromium/CookieJarChromium.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/win/CookieJarCFNetWin.cpp:
- platform/network/win/CookieJarWin.cpp:
- platform/qt/CookieJarQt.cpp:
- 5:44 AM Changeset in webkit [47194] by
-
- 1 edit1 add in trunk/WebCore
2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Not reviewed: build fix (for r47192), adding new file from
https://bugs.webkit.org/show_bug.cgi?id=28174
- inspector/front-end/StatusBarButton.js: Added.
- 5:36 AM Changeset in webkit [47193] by
-
- 3 edits2 adds in trunk/LayoutTests
2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Test result for quadraticCurveTo.
- platform/qt/Skipped: Exclude quadraticCurveTo test.
- platform/qt/fast/canvas/quadraticCurveTo-expected.checksum: Added.
- platform/qt/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Added.
- 5:16 AM Changeset in webkit [47192] by
-
- 14 edits in trunk/WebCore
2009-08-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Introduced StatusBarButton class that encapsulates glyphs support.
Views updated accordingly.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): Updated to retrieve DOM element from StatusBarButton instance (here and in similar getters below.) (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update):
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
- inspector/front-end/Panel.js:
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.get statusBarItems): (WebInspector.ProfileView.prototype._updatePercentButton): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.setRecordingProfile): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
- inspector/front-end/StatusBarButton.js: Added. (WebInspector.StatusBarButton): (WebInspector.StatusBarButton.prototype._clicked): (WebInspector.StatusBarButton.prototype.get disabled): (WebInspector.StatusBarButton.prototype.set disabled): (WebInspector.StatusBarButton.prototype.get title): (WebInspector.StatusBarButton.prototype.set title): (WebInspector.StatusBarButton.prototype.get toggled): (WebInspector.StatusBarButton.prototype.set toggled): (WebInspector.StatusBarButton.prototype.get visible): (WebInspector.StatusBarButton.prototype.set visible):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: For uniformity, class names are always used to identify status bar buttons. Also, fixed "Reload" button style to use glyphs.
- inspector/front-end/inspector.html:
- 5:15 AM Changeset in webkit [47191] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Fix test result and add pixel test.
- platform/qt/fast/canvas/canvas-zoom-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-zoom-expected.png: Added.
- platform/qt/fast/canvas/canvas-zoom-expected.txt: Added.
- 4:45 AM Changeset in webkit [47190] by
-
- 4 edits21 adds in trunk
WebCore/ChangeLog
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add shadow support in GraphicsContext::fillRect().
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect): Paint shadow if necessary. (WebCore::GraphicsContext::setPlatformShadow): Inverse y offset.
LayoutTests/ChangeLog
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add pixel tests result for canvas shadow support.
- platform/qt/Skipped: Exclude new passing tests.
- platform/qt/fast/canvas/shadow-offset-1-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-1-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-1-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-2-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-2-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-2-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-3-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-3-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-3-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-4-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-4-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-4-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-5-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-5-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-5-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-6-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-6-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-6-expected.txt: Added.
- platform/qt/fast/canvas/shadow-offset-7-expected.checksum: Added.
- platform/qt/fast/canvas/shadow-offset-7-expected.png: Added.
- platform/qt/fast/canvas/shadow-offset-7-expected.txt: Added.
- 3:17 AM Changeset in webkit [47189] by
-
- 2 edits in trunk/WebCore
2009-08-13 David Levin <levin@chromium.org>
Unreviewed build fix for Chromium Linux.
Rollback r47157 as this broke debug tests of Chromium Linux.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
- 2:59 AM Changeset in webkit [47188] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix for chromium.
Patch by David Levin <levin@chromium.org> on 2009-08-13
The chromium build broke due to r47185 which added
a cookies array to inspector/InspectorBackend.idl.
- bindings/v8/custom/V8CustomBinding.h: Added the declaration for the cookies callback.
- bindings/v8/custom/V8InspectorBackendCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL(InspectorBackendCookies)): Stubbed out an implementation
for the cookies callback.
- 12:33 AM Changeset in webkit [47187] by
-
- 1 edit in trunk/LayoutTests/platform/win/media/controls-drag-timebar-expected.txt
Fix for media timebar test on windows.
Aug 12, 2009:
- 10:58 PM Changeset in webkit [47186] by
-
- 12 edits in trunk/JavaScriptCore
Add optimize call and property access support for ARM JIT.
https://bugs.webkit.org/show_bug.cgi?id=24986
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-12
Reviewed by Gavin Barraclough.
For tightly coupled sequences the BEGIN_UNINTERRUPTED_SEQUENCE and
END_UNINTERRUPTED_SEQUENCE macros have been introduced which ensure
space for instructions and constants of the named sequence. This
method is vital for those architecture which are using constant pool.
The 'latePatch' method - which was linked to JmpSrc - is replaced with
a port specific solution (each calls are marked to place their address
on the constant pool).
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::executableCopy): Add extra align for constant pool.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::sizeOfConstantPool):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkCall):
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h:
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushIfNoSpaceFor): Fix the
computation of the remaining space.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ensureSpace):
(JSC::MacroAssemblerARM::sizeOfConstantPool):
(JSC::MacroAssemblerARM::prepareCall):
- assembler/X86Assembler.h:
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
- 10:58 PM Changeset in webkit [47185] by
-
- 13 edits1 copy in trunk/WebCore
2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185
Added new file Cookie.h to the WebCore XCode
- WebCore.xcodeproj/project.pbxproj:
InspectorController.cookies() binding
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
- inspector/InspectorBackend.idl:
Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)
- platform/Cookie.h: Added. (WebCore::Cookie::Cookie):
Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)
- platform/CookieJar.h:
Implementation of getRawCookies for the mac platform.
- platform/mac/CookieJar.mm: (WebCore::getRawCookies):
Stub other CookieJar implementations to satisfy the interface.
- platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
- platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
- platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
- 10:26 PM Changeset in webkit [47184] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Dave Kilzer.
Disable WTF_USE_JSVALUE32_64 on iPhone for now (support not yet added for ARMv7).
- wtf/Platform.h:
- 10:21 PM Changeset in webkit [47183] by
-
- 2 edits in trunk/JavaScriptCore
Ooops - moved code that had been accidentally added to op_new_func instead of
op_new_func_exp, to where it shoulds be.
Reviewed by Maciej Stachoviak.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- wtf/Platform.h:
- 10:00 PM Changeset in webkit [47182] by
-
- 2 edits in trunk/WebKitSite
2009-08-12 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Barth.
Better explanation of "Null after navigation" in object diagram
https://bugs.webkit.org/show_bug.cgi?id=28232
- coding/major-objects.html:
- 9:51 PM Changeset in webkit [47181] by
-
- 5 edits3 adds in trunk/WebCore
2009-08-08 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Cookies in Storage Panel
https://bugs.webkit.org/show_bug.cgi?id=27202
Data Structure for a Cookie. Just Key/Value for Now:
- inspector/front-end/Cookie.js: Added. (WebInspector.Cookie): (WebInspector.Cookie.prototype.get key): (WebInspector.Cookie.prototype.set key): (WebInspector.Cookie.prototype.get value): (WebInspector.Cookie.prototype.set value):
A Storage View for Cookies. Allows for Refresh/Delete:
- inspector/front-end/CookieItemsView.js: Added. (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): refresh and delete buttons (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): parses the inspected window's document.cookie string (WebInspector.CookieItemsView.prototype.dataGridForCookies): creates a datagrid for cookies (WebInspector.CookieItemsView.prototype._deleteButtonClicked): attempt at deleting the cookie (not flawless) (WebInspector.CookieItemsView.prototype._refreshButtonClicked): rebuild the datagrid
Include a SidebarSection Section in the Databases Panel:
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.show): calls populateInterface (WebInspector.DatabasesPanel.prototype.populateInterface): adds cookies if they don't exist (WebInspector.DatabasesPanel.prototype.reset): remove cookie specific parts (WebInspector.DatabasesPanel.prototype.addCookies): add cookies sidebar tree element (WebInspector.DatabasesPanel.prototype.showCookies): sets the visible view to a CookiesItemView (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get mainTitle): just "Cookies" at the moment (WebInspector.CookieSidebarTreeElement.prototype.set mainTitle): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): no subtitle yet (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
New "Cookies" Image for the Sidebar:
- inspector/front-end/Images/cookie.png: Added.
- inspector/front-end/inspector.css:
Include the Added Files where appropriate:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 9:46 PM Changeset in webkit [47180] by
-
- 2 edits in trunk/WebCore
2009-08-12 George Wright <george.wright@torchmobile.com>
Reviewed by George Staikos.
Add SQLTransactionCoordinator.[h,cpp] to WebCore.pro.
- WebCore.pro:
- 9:38 PM Changeset in webkit [47179] by
-
- 2 edits in trunk
Fix double-fail of bug url. Not reviewed.
- 7:55 PM Changeset in webkit [47178] by
-
- 2 edits in trunk/WebKitTools
2009-08-12 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
Enable WCSS and XHTML-MP flags for build-webkit.
- Scripts/build-webkit:
- 7:48 PM Changeset in webkit [47177] by
-
- 3 edits in trunk/WebCore
2009-08-12 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
Mark unused variables to avoid compile failures in -Werror.
- 7:47 PM Changeset in webkit [47176] by
-
- 9 edits2 adds in trunk/WebCore
2009-08-12 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by Niko Zimmermann.
This is to add WCSS marquee support , which is defined by OMA and is an extension for CSS2,
It extends CSS display with "display:-wap-marquee;-wap-marquee-dir:xxx;-wap-marquee-speed:xxx;-wap-marquee-style:xxx"
Minor fixes by Eric Seidel and George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23727
No new tests, the tests have already been landed at LayoutTests/fast/wcss/
- 7:18 PM Changeset in webkit [47175] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests: document --nthly flag in help message
Reviewed by Simon Fraser.
- Scripts/run-webkit-tests: Added --nthly flag to $usage string.
Also noted that -1singly implies --nthly 1. - 6:37 PM Changeset in webkit [47174] by
-
- 1 edit1 copy1 move in trunk/LayoutTests
2009-08-12 Alpha Lam < hclam@chromium.org>
Not reviewed, Windows test fix after http://trac.webkit.org/changeset/47171.
This splits the expected result file into mac and Windows
versions since the result is different on Windows.
- platform/mac/media/controls-drag-timebar-expected.txt: Renamed from LayoutTests/media/controls-drag-timebar-expected.txt.
- platform/win/media/controls-drag-timebar-expected.txt: Added.
- 6:31 PM Changeset in webkit [47173] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-08-12 Eric Seidel <eric@webkit.org>
No review, just adding missing results.
<canvas> without CSS width/height is unaffected by full page zoom
https://bugs.webkit.org/show_bug.cgi?id=26908
Adding missing test results. Unsure why run-webkit-tests didn't fail.
- fast/canvas/canvas-zoom-expected.checksum: Added.
- fast/canvas/canvas-zoom-expected.png: Added.
- fast/canvas/canvas-zoom-expected.txt: Added.
- 6:07 PM Changeset in webkit [47172] by
-
- 4 edits1 add in trunk
2009-08-12 George Wright <george.wright@torchmobile.com>
Reviewed by David Hyatt.
Test the four cases of width and height being declared or not for a
canvas element with CSS zooming enabled.
- fast/canvas/canvas-zoom.html: Added.
2009-08-12 George Wright <george.wright@torchmobile.com>
Reviewed by David Hyatt.
Update the canvas renderer's intrinsic size with the zoomed
lengths and ensure the intrinsic size is correct when setting
an initial style.
Test: fast/canvas/canvas-zoom.html
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
- 6:00 PM Changeset in webkit [47171] by
-
- 3 edits2 adds in trunk
2009-08-12 Alpha Lam <hclam@chromium.org>
Reviewed by Simon Fraser.
Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211
Add a layout test to make sure dragging the timebar thumb of media
controls causes seeks.
- media/controls-drag-timebar-expected.txt: Added.
- media/controls-drag-timebar.html: Added.
2009-08-12 Alpha Lam <hclam@chromium.org>
Reviewed by Simon Fraser.
Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211
Modified the conditions for rejecting events on the media controller
to only rejecting mouse events not from the left button.
Test: media/controls-drag-timebar.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- 5:52 PM Changeset in webkit [47170] by
-
- 12 edits4 adds in trunk
2009-08-12 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Regression test. Tests that two transactions that run on two
different handles for the same DB do not cause a deadlock.
- storage/multiple-transactions-on-different-handles-expected.txt: Added.
- storage/multiple-transactions-on-different-handles.html: Added.
2009-08-12 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Fixing a deadlock caused by two transactions that run on two
different database handles for the same DB. Adding a per-DB thread
transaction coordinator that allows the DB thread to run only one
transaction per DB file at any given time.
Adding a regression test for this bug.
Test: storage/multiple-transactions-on-different-handles.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/Database.cpp: (WebCore::Database::transactionCoordinator):
- storage/Database.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionCoordinator):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::aquireLock): (WebCore::SQLTransaction::lockAquired): (WebCore::SQLTransaction::cleanupAfterSuccessCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- storage/SQLTransaction.h:
- storage/SQLTransactionCoordinator.cpp: Added.
- storage/SQLTransactionCoordinator.h: Added.
- 5:40 PM Changeset in webkit [47169] by
-
- 4 edits in trunk/LayoutTests
2009-08-12 Eric Seidel <eric@webkit.org>
No review, finishing previous commit.
Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716
Add changes missed in http://trac.webkit.org/changeset/47168
- platform/qt/Skipped:
- platform/win/Skipped:
- 5:23 PM Changeset in webkit [47168] by
-
- 2 edits6 adds in trunk/LayoutTests
2009-08-12 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716
Adds the first, basic Geolocation layout test. This simply tests that
navigator.geolocation is present when it should be.
- fast/dom/Geolocation: Added. Directory for Geolocation layout tests.
- fast/dom/Geolocation/enabled.html: Added. HTML wrapper for enabled.js test.
- fast/dom/Geolocation/resources: Added. Directory for Geolocation layout tests JS source.
- fast/dom/Geolocation/resources/enabled.js: Added. Tests that navigator.geolocation is present.
- fast/dom/Geolocation/resources/TEMPLATE.html: Added. Template for creating HTML wrapper files for JS tests with make-js-test-wrappers.
- fast/dom/Geolocation/enabled-expected.txt: Added. Expected result for above test.
- platform/mac/Skipped: Modified. Skip Geolocation tests.
- platform/qt/Skipped: Modified. Skip Geolocation tests.
- platform/win/Skipped: Modified. Skip Geolocation tests.
- 5:07 PM Changeset in webkit [47167] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2009-08-12 Eric Seidel <eric@webkit.org>
No review, just fixing mismerged ChangeLogs.
- 5:03 PM Changeset in webkit [47166] by
-
- 3 edits in trunk/WebKitTools
2009-08-11 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199
Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
<<<<<<< HEAD:WebKitTools/ChangeLog
- 4:40 PM Changeset in webkit [47165] by
-
- 24 edits2 adds in trunk
WebCore: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194
Patch by Darin Adler <Darin Adler> on 2009-08-12
Reviewed by Geoff Garen.
- GNUmakefile.am: Added the two new source files.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSCSSRuleListCustom.cpp: Added.
(WebCore::JSCSSRuleList::markChildren): Call markDOMObjectWrapper
on rules in the list.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::markChildren): Added. Call
markDOMObjectWrapper on the CSSValue objects that are owned by the
declaration as values of the properties.
- bindings/js/JSDOMBinding.cpp:
(WebCore::isObservableThroughDOM): Added code to handle some
cases where nodes are observable because they own objects that
in turn have custom properties.
- bindings/js/JSDOMBinding.h: Fix a typo in the header.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren): Added call to markDOMObjectWrapper
for implementation and styleSheets.
- bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren): Added. Calls markDOMObjectWrapper
for attributes and style.
- bindings/js/JSHTMLCanvasElementCustom.cpp: Added.
(WebCore::JSHTMLCanvasElement::markChildren): Call markDOMObjectWrapper
on the rendering context.
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::markChildren): Call markDOMObjectWrapper on
items in the stylesheet.
- bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::markChildren): Added. Calls
markDOMObjectWrapper on stylesheets in the list.
- css/CSSRuleList.idl: Added CustomMarkFunction.
- css/CSSStyleDeclaration.idl: Ditto.
- css/StyleSheetList.idl: Ditto.
- dom/Element.idl: Ditto.
- html/HTMLCanvasElement.idl: Ditto.
- dom/Element.h: Made everything private that could be.
Added access to the attributeMap that does returns
the existing map without doing any of the lazy-updating work. This
is needed to get at the existing attributes during garbage collection
without having side effects.
- html/HTMLCanvasElement.h: Cleaned up the header a bit, making
members private. Added renderingContext2D function for use in
JSHTMLCanvasElement::markChildren.
LayoutTests: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194
Patch by Darin Adler <Darin Adler> on 2009-08-12
Reviewed by Geoff Garen.
- fast/dom/gc-9-expected.txt: Regenerated.
- fast/dom/gc-9.html: Updated to expect correct behavior instead of failures.
- 4:35 PM Changeset in webkit [47164] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Build fix for Windows Debug.
- 4:24 PM Changeset in webkit [47163] by
-
- 6 edits2 adds in trunk
2009-08-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Eric Seidel.
Fixes two bugs about Pan Scrolling - Scrolling with middle mouse button doesn't
work in Expanded view on reader.google.com, and Can enter auto scroll from a non-scrollable area.
https://bugs.webkit.org/show_bug.cgi?id=28023
https://bugs.webkit.org/show_bug.cgi?id=24794
Added a new method to RenderBox seeing if the Box can be scrolled and actually has something to
scroll, and use that for pan scrolling.
Test: platform/win/fast/events/panScroll-nested-divs.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::handleMousePressEvent):
- rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):
2009-08-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Eric Seidel.
Added a Windows test for https://bugs.webkit.org/show_bug.cgi?id=28023.
- platform/win/fast/events/panScroll-nested-divs-expected.txt: Added.
- platform/win/fast/events/panScroll-nested-divs.html: Added.
- 4:19 PM Changeset in webkit [47162] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/6017913> Replace use of HISearchWindowShow in -[WebView _searchWithSpotlightFromMenu].
Reviewed by Kevin Decker.
- WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]): Use -[NSWorkspace showSearchResultsForQueryString:] post-Leopard.
- 4:12 PM Changeset in webkit [47161] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fix missing "by" in ChangeLog.
- 4:10 PM Changeset in webkit [47160] by
-
- 5 edits in trunk
2009-08-12 Brian Weinstein <bweinstein@apple.com>
Reviewed Adam Roben.
Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.
Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
the popup (matches other browser behavior).
- WebView.cpp: (WebView::mouseWheel):
2009-08-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.
Added a function for Windows PopupMenu's to return their class name.
- platform/PopupMenu.h:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::popupClassName):
- 4:07 PM Changeset in webkit [47159] by
-
- 3 edits in trunk/JavaScriptCore
Added workaround for the limitation that VirtualFree with MEM_RELEASE
can only accept the base address returned by VirtualAlloc when the region
was reserved and it can only free the entire region, and not a part of it.
Reviewed by Oliver Hunt.
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackWin.cpp: (JSC::MarkStack::releaseStack):
- 4:03 PM Changeset in webkit [47158] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
WINCE PORT: Color and Gradient
https://bugs.webkit.org/show_bug.cgi?id=27511
- platform/graphics/wince/ColorWince.cpp: Added.
- platform/graphics/wince/GradientWince.cpp: Added.
- 3:55 PM Changeset in webkit [47157] by
-
- 2 edits in trunk/WebCore
2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=28172
No new tests because it's a just typo fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
- 3:49 PM Changeset in webkit [47156] by
-
- 2 edits in trunk/WebKit/qt
2009-08-12 George Wright <george.wright@torchmobile.com>
Reviewed by Adam Treat.
Initialise zoom levels independent of whether a URL is valid or not to
fix https://bugs.webkit.org/show_bug.cgi?id=28162
- QtLauncher/main.cpp: (MainWindow::MainWindow):
- 3:21 PM Changeset in webkit [47155] by
-
- 10 edits8 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27458
Support for the :default CSS pseudoclass, as per HTML5 spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#selector-default
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.
Tests: fast/css/pseudo-default-001.html
fast/css/pseudo-default-002.html
fast/css/pseudo-default-003.html
fast/css/pseudo-default-004.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType): pseudoDefault
- css/CSSSelector.h:
(WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): sharing stuff is
aware that only one default button can be present in a form
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): applies
the :default CSS pseudoclass
- dom/Element.h:
(WebCore::Element::isDefaultButtonForForm): new method to determine
whether a FormControl is a default button for a given form
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isDefaultButtonForForm): ditto
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::defaultButton): extracts the default button
from the form
- html/HTMLFormElement.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27458
Test suite for the :default CSS pseudoclass.
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.
- fast/css/pseudo-default-001-expected.txt: Added.
- fast/css/pseudo-default-001.html: Added.
- fast/css/pseudo-default-002-expected.txt: Added.
- fast/css/pseudo-default-002.html: Added.
- fast/css/pseudo-default-003-expected.txt: Added.
- fast/css/pseudo-default-003.html: Added.
- fast/css/pseudo-default-004-expected.txt: Added.
- fast/css/pseudo-default-004.html: Added.
- 3:15 PM Changeset in webkit [47154] by
-
- 7 edits in trunk
WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.
Reviewed by Darin Adler.
- win/tools/scripts/auto-version.sh:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.
Reviewed by Darin Adler.
- Scripts/prepare-ChangeLog:
- Scripts/resolve-ChangeLogs:
- Scripts/svn-create-patch:
- Scripts/update-webkit:
- 3:10 PM Changeset in webkit [47153] by
-
- 2 edits in trunk/WebCore
2009-08-12 David Levin <levin@chromium.org>
No review, rolling out r47106.
https://bugs.webkit.org/show_bug.cgi?id=28215
This patch relied on a new version of v8 which is not available
in chromium yet.
- bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
- 3:08 PM Changeset in webkit [47152] by
-
- 3 edits in trunk/WebCore
2009-08-12 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Bug 26993 : Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993
Second patch to allow the Geolocation permission request to chrome to be asynchronous
or synchronous. Fixes a bug where callbacks were called twice when permissions
are granted synchronously.
No new tests required.
- page/Geolocation.cpp: (WebCore::Geolocation::setIsAllowed): Modified. Calls makeSuccessCallbacks() rather than geolocationServicePositionChanged(). (WebCore::Geolocation::geolocationServicePositionChanged): Modified. Updated logic to avoid repeated callbacks when permissions are granted synchronously. (WebCore::Geolocation::makeSuccessCallbacks): Added. Calls success callbacks.
- page/Geolocation.h: Modified. Adds makeSuccessCallbacks().
- 3:03 PM Changeset in webkit [47151] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6952336>
CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27
Reviewed by Sam Weinig.
Make sure to set the security origin before calling dispatchWindowObjectAvailable.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
- 2:49 PM Changeset in webkit [47150] by
-
- 2 edits1 add in trunk/WebCore
2009-08-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Fix [Chromium] drop down menu letter selection, skip selections
https://bugs.webkit.org/show_bug.cgi?id=28205
Not auto-testable since it is chromim platform specific code, and it involves sending a keyboard
event to the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).
- manual-tests/keyboard_select_elements_with_same_beginning.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): style change. (WebCore::PopupListBox::handleKeyEvent): typeAheadFind should be called only when the event is a character type event to avoid calling twice for English. (WebCore::PopupListBox::typeAheadFind): remove unnecessary checking of isCharacterTypeEvent() since the whole function is only called under that condition.
- 2:22 PM Changeset in webkit [47149] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix.
Last-minute change on the new soup API to use the keyring was not
reflected in our usage - the documentation says we should use
g_slist_free, and soup_auth_free_saved_users doesn't exist.
- webkit/webkitsoupauthdialog.c: (session_authenticate):
- 2:08 PM Changeset in webkit [47148] by
-
- 3 edits in trunk/WebKit/win
Make WebPreferenceKeysPrivate.h available for client use
Reviewed by Dave Hyatt.
Fixes <http://webkit.org/b/28227>.
- WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
$WebKitOutputDir, just like we do for a few other headers. Also let VS
reorder some XML attributes.
- WebPreferenceKeysPrivate.h: Touched this file to force a build.
- 2:02 PM Changeset in webkit [47147] by
-
- 1 edit1 add in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding GraphicsContext to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28130
- platform/graphics/haiku/GraphicsContextHaiku.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::getHaikuStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::setPlatformShadow):
- 1:55 PM Changeset in webkit [47146] by
-
- 15 edits in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Modifying WebCore/platform/graphics files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128
- platform/graphics/BitmapImage.h: Adding getBBitmap() function.
- platform/graphics/Color.h: rgb_color is the Color struct in Haiku.
- platform/graphics/FloatPoint.h: BPoint is the Point class in Haiku.
- platform/graphics/FloatRect.h: BRect is the Rect class in Haiku.
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h: BView is the PlatformGraphicsContext class for Haiku. Adding getHaikuStrokeStyle() function.
- platform/graphics/Icon.h: Adding an empty Icon() constructor because this class isn't implemented for the moment.
- platform/graphics/ImageSource.h: BBitmap is the native bitmap class for Haiku.
- platform/graphics/IntPoint.h: BPoint is the Point class in Haiku.
- platform/graphics/IntRect.h: BRect is the Rect class in Haiku.
- platform/graphics/IntSize.h: BSize is the Size class in Haiku.
- platform/graphics/Path.h: BRegion is the Path class in Haiku.
- platform/graphics/Pattern.h: Adding the GraphicsDef.h header and the native pattern type.
- platform/graphics/SimpleFontData.h: Adding Haiku's Font.h header.
- 1:44 PM Changeset in webkit [47145] by
-
- 11 edits in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding modification to the WebCore/platform/ files to allow
the Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128
- platform/ContextMenuItem.h: BMenu is the PlatformMenuItemDescription class of Haiku.
- platform/Cursor.h: BCursor is the Cursor class of Haiku.
- platform/DragData.h: Use a BMessage as DragDataRef.
- platform/DragImage.h: Use a BBitmap as DragImageRef.
- platform/PlatformKeyboardEvent.h: Use BMessage as event vehicle.
- platform/PlatformMenuDescription.h: BMenu is the PlatformMenuDescription class of Haiku.
- platform/PlatformMouseEvent.h: Use BMessage as event vehicle.
- platform/PlatformWheelEvent.h: Use BMessage as event vehicle.
- platform/PopupMenu.h: Adding a m_menu attribute for Haiku.
- platform/Widget.h: BView is the PlatformWidget class of Haiku.
- 1:35 PM Changeset in webkit [47144] by
-
- 9 edits in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Tiny modifications on WebCore files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128
- bindings/js/ScriptControllerHaiku.cpp: Style cleanup.
- loader/CachedFont.cpp: Haiku behaves like Qt, Gtk, or Chromium, so many PLATFORM(HAIKU) were added to these functions. (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
- page/EventHandler.cpp: Like the mac and Qt port, Haiku doesn't need the invertSenseOfTabsToLinks() function.
- page/haiku/DragControllerHaiku.cpp: Style cleanup.
- platform/image-decoders/ImageDecoder.h: For image decoding Haiku behaves like Cairo or Wx, (not like Skia). (WebCore::RGBA32Buffer::getAddr):
- platform/text/PlatformString.h: Adding the String(BString&) and BString() methods specific to Haiku.
- platform/text/UnicodeRange.h: Haiku needs to include stdint.h.
- platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: (WebCore::currentSearchLocaleID): Missing function.
- 1:23 PM Changeset in webkit [47143] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding the ScrollbarTheme files.
https://bugs.webkit.org/show_bug.cgi?id=28125
- platform/haiku/ScrollbarThemeHaiku.cpp: Added. (buttonWidth): (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeHaiku::ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::~ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::scrollbarThickness): (WebCore::ScrollbarThemeHaiku::hasButtons): (WebCore::ScrollbarThemeHaiku::hasThumb): (WebCore::ScrollbarThemeHaiku::backButtonRect): (WebCore::ScrollbarThemeHaiku::forwardButtonRect): (WebCore::ScrollbarThemeHaiku::trackRect): (WebCore::ScrollbarThemeHaiku::paintScrollbarBackground): (WebCore::ScrollbarThemeHaiku::paintButton): (WebCore::ScrollbarThemeHaiku::paintThumb):
- platform/haiku/ScrollbarThemeHaiku.h: Added.
- 1:16 PM Changeset in webkit [47142] by
-
- 1 edit9 adds in trunk/WebCore
2009-08-12 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding eight simple files to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28122
- platform/graphics/haiku/ColorHaiku.cpp: Added. (WebCore::Color::Color): (WebCore::Color::operator rgb_color): (WebCore::focusRingColor):
- platform/graphics/haiku/FloatPointHaiku.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator BPoint):
- platform/graphics/haiku/FloatRectHaiku.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator BRect):
- platform/graphics/haiku/GradientHaiku.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient): (WebCore::Gradient::fill):
- platform/graphics/haiku/IntPointHaiku.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator BPoint):
- platform/graphics/haiku/IntRectHaiku.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator BRect):
- platform/graphics/haiku/IntSizeHaiku.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator BSize):
- platform/graphics/haiku/PathHaiku.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::hasCurrentPoint): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::strokeBoundingRect):
- 1:03 PM Changeset in webkit [47141] by
-
- 3 edits in trunk/LayoutTests
2009-08-12 Eric Seidel <eric@webkit.org>
No review, just fixing line-endings.
Change from DOS to unix line endings on tests from
http://trac.webkit.org/changeset/47130
- fast/events/set-event-in-another-frame-expected.txt:
- fast/events/set-event-to-null-expected.txt:
- 12:51 PM Changeset in webkit [47140] by
-
- 41 edits6 deletes in trunk
As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.
- 12:45 PM Changeset in webkit [47139] by
-
- 1 edit1 add in trunk/WebCore
WINCE PORT: Implement Keygen for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Lyon Chen <lyon.chen@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.
- platform/wince/KeygenWince.cpp: Added.
- 12:41 PM Changeset in webkit [47138] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Kevin Ollivier.
Handle crash in wx due to null value passed to strlen in
the CString constructor.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath): Check for null return from getenv
and use default CString constructor instead.
- 12:41 PM Changeset in webkit [47137] by
-
- 1 edit4 adds in trunk/WebCore
WINCE PORT: simple stubs to make it build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.
- platform/wince/DragDataWince.cpp: Added.
- platform/wince/DragImageWince.cpp: Added.
- platform/wince/EditorWince.cpp: Added.
- platform/wince/KURLWince.cpp: Added.
- 12:38 PM Changeset in webkit [47136] by
-
- 1 edit2 adds in trunk/WebCore
WINCEPORT: FileSystem and FileChooser
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.
- platform/wince/FileChooserWince.cpp: Added.
- platform/wince/FileSystemWince.cpp: Added.
- 12:35 PM Changeset in webkit [47135] by
-
- 1 edit1 add in trunk/WebCore
WINCE PORT: implement Cursor for WINCE. There's no real cursor on most
WinMob devices. We pass the cursor info to application, which so that
can determine what to do.
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.
- platform/wince/CursorWince.cpp: Added.
- 12:32 PM Changeset in webkit [47134] by
-
- 1 edit1 add in trunk/WebCore
WINCE PORT: MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.
- platform/wince/MIMETypeRegistryWince.cpp: Added.
- 12:28 PM Changeset in webkit [47133] by
-
- 1 edit2 adds in trunk/WebCore
WINCE PORT: Pasteboard and SearchPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Joe Mason <joe.mason@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.
- platform/wince/PasteboardWince.cpp: Added.
- platform/wince/SearchPopupMenuWince.cpp: Added.
- 12:24 PM Changeset in webkit [47132] by
-
- 1 edit3 adds in trunk/WebCore
WINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27543
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.
- platform/wince/SharedTimerWince.cpp: Added.
- platform/wince/SystemTimeWince.cpp: Added.
- 12:18 PM CreatingLayoutTests edited by
- Add link to writing a good test case. (diff)
- 12:11 PM CreatingLayoutTests edited by
- Re-Organization and update. (diff)
- 12:05 PM Changeset in webkit [47131] by
-
- 2 edits in trunk/WebCore
2009-08-12 Mark Mentovai <mark@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28204
Allow C++ exceptions to be disabled in WebCore's V8 Mac build.
- WebCorePrefix.h: Only undefine |try| and |catch| when building Objective-C[++], leaving the C++ library definitions intact for C++.
- 11:43 AM Changeset in webkit [47130] by
-
- 6 edits4 adds in trunk
2009-08-12 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add a Custom Setter for DOMWindowEvent in the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27719
Tests: fast/events/set-event-in-another-frame.html
fast/events/set-event-to-null.html
- 11:37 AM Changeset in webkit [47129] by
-
- 5 edits in trunk
2009-08-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173
Remove keyring support, we now do authentication storage through
libsoup. We depend on libsoup master now, will bump the dependency
when there's a new release.
- GNUmakefile.am:
- configure.ac:
WebKit/gtk:
2009-08-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173
Remove keyring support from our code and rely on libsoup to store
the authentication data if the user requests that support in their
application/library.
- webkit/webkitsoupauthdialog.c: (response_callback): (show_auth_dialog): (session_authenticate):
- 11:33 AM Changeset in webkit [47128] by
-
- 2 edits in trunk/LayoutTests
2009-08-12 Eric Seidel <eric@webkit.org>
No review, just skipping tests to make the bots green.
REGRESSION (r47110): 4 media regressions on the bots
https://bugs.webkit.org/show_bug.cgi?id=28221
Skipping these until Eric Carlson has a fix.
- platform/mac/Skipped:
- 11:27 AM Changeset in webkit [47127] by
-
- 4 edits1 delete in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27965
Merge wx/ImageSourceWx.cpp into ImageSource.cpp. No changes to
ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.
Reviewed by Adam Treat.
- WebCore.gypi:
- WebCoreSources.bkl:
- platform/graphics/wx/ImageSourceWx.cpp: Removed.
- webcore-wx.bkl:
- 11:23 AM Changeset in webkit [47126] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27933
Build fix after r47099.
Reviewed by Dave Levin.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
- 11:18 AM Changeset in webkit [47125] by
-
- 2 edits in trunk/WebKitTools
wx waf build fix, add new directories to the build.
- 11:11 AM Changeset in webkit [47124] by
-
- 2 edits in trunk/WebKit/wx
wxPython build fix, the SWIG defines must also be available when compiling.
- 10:56 AM Changeset in webkit [47123] by
-
- 3 edits in trunk/LayoutTests
Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=28219
Reviewed by Eric Seidel.
- platform/mac-snowleopard/Skipped:
- platform/mac/accessibility/string-range-contains-listmarker.html:
- 10:23 AM Changeset in webkit [47122] by
-
- 7 edits in trunk
Remove support for a window resizer within the WebView
WebKit/win:
Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.
Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView
Reviewed by Dave Hyatt.
- Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::windowResizerRect): Now always returns an empty
rect.
- WebView.cpp:
(WebView::paint):
(WebView::handleMouseEvent):
- WebView.h:
Removed window-resizer-related code.
WebKitTools:
Update DumpRenderTree for IWebUIDelegatePrivate changes
Reviewed by Dave Hyatt.
- DumpRenderTree/win/UIDelegate.h: Updated to match
IWebUIDelegatePrivate.
- 10:18 AM Changeset in webkit [47121] by
-
- 2 edits in trunk/WebKitTools
Don't try to seek to the end of stdin on Cygwin
Doing so seems to always cause an exception (for unknown reasons).
Fixes <http://webkit.org/b/28159> create-bug throws an exception in
Cygwin
Reviewed by Dave Kilzer.
- Scripts/bugzilla-tool:
(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.
- 10:17 AM Changeset in webkit [47120] by
-
- 2 edits in trunk/WebKitTools
Don't raise an exception when --cc is not passed to create-bug
Fixes <http://webkit.org/b/28158> create-bug throws an exception if
--cc is not specified
Reviewed by Dave Kilzer.
- Scripts/modules/bugzilla.py:
(Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
string was specified. Otherwise we'll generate an exception about the
"cc" variable not being a string.
- 9:55 AM Changeset in webkit [47119] by
-
- 3 edits in trunk/WebKit/mac
Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153
Reviewed by Eric Seidel.
Have ObjC delegate methods match C++ method names in the ChromeClient.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::formDidFocus):
(WebChromeClient::formDidBlur):
- WebView/WebUIDelegatePrivate.h:
- 9:50 AM Changeset in webkit [47118] by
-
- 1 edit4 adds in trunk/WebCore
WINCE PORT: Implement Path for WINCE. Most code can be
reused for other ports that don't have native path support
https://bugs.webkit.org/show_bug.cgi?id=28188
Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
Reviewed by Adam Treat.
Written also by George Staikos (including quadCurve() and bezier())
- platform/graphics/wince/PathWince.cpp: Added.
- platform/graphics/wince/PlatformPathWince.cpp: Added.
- platform/graphics/wince/PlatformPathWince.h: Added.
- platform/graphics/wince/WinceGraphicsExtras.h: Added.
- 9:49 AM Changeset in webkit [47117] by
-
- 2 edits in trunk/WebKit/win
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Windows build fix.
- WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
- 9:43 AM Changeset in webkit [47116] by
-
- 2 edits in trunk/WebCore
2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>
"Double-click to add" new style button does not always show up [quick fix]
https://bugs.webkit.org/show_bug.cgi?id=28187
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
- 9:42 AM Changeset in webkit [47115] by
-
- 1 edit3 adds in trunk/WebCore
2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=28178
- platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
- platform/graphics/wince/MediaPlayerProxy.cpp: Added.
- platform/graphics/wince/MediaPlayerProxy.h: Added.
- 9:41 AM Changeset in webkit [47114] by
-
- 2 edits in trunk/WebCore
2009-08-12 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=28175
Call QDir::toNativeSeparators() before the path is passed to the OS.
Based on work by David Leong.
- platform/qt/FileSystemQt.cpp: (WebCore::pathByAppendingComponent):
- 9:41 AM Changeset in webkit [47113] by
-
- 2 edits in trunk/WebCore
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Tiger build fix.
- accessibility/mac/AccessibilityObjectWrapper.mm:
Define NSAccessibilityTimelineSubrole for Tiger.
- 9:35 AM Changeset in webkit [47112] by
-
- 2 edits in trunk/WebCore
2009-08-12 Dirk Schulze <krit@webkit.org>
Reviewed by Ariya Hidayat.
Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
of getImageData. This changed since r47099.
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- 9:26 AM Changeset in webkit [47111] by
-
- 4 edits in trunk/WebKitTools
2009-08-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199
Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 9:20 AM Changeset in webkit [47110] by
-
- 41 edits6 adds in trunk
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
Test: accessibility/media-element.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
Add AccessibilityMediaControls.cpp/.h
- accessibility/AXObjectCache.cpp:
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):
Create AccessibilityMediaControl. Update Copyright
- accessibility/AccessibilityMediaControls.cpp:
- accessibility/AccessibilityMediaControls.h:
Added.
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityObject.h:
Add isMediaTimeline. Update Copyright.
- accessibility/AccessibilitySlider.h:
Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
Add NSAccessibilityValueDescriptionAttribute to range attributes.
(-[AccessibilityObjectWrapper subrole]):
Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
- dom/Node.h:
add isMediaControlElement.
- page/mac/WebCoreViewFactory.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
New, return localized media controller strings.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):
Initialize m_displayType.
(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Fix style.
(WebCore::MediaControlInputElement::MediaControlInputElement):
Set m_displayType based on pseudo style ID.
(WebCore::MediaControlInputElement::MediaControlInputElement):
rename local "o" to "object".
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
Update for MediaControlInputElement constructor change.
(WebCore::MediaControlTimeDisplayElement::formatTime):
New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
(WebCore::MediaControlTimeDisplayElement::setCurrentValue):
New, set text to current time.
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
Create controls in tab order.
(WebCore::RenderMedia::formatTime):
Moved to MediaControlTimeDisplayElement::formatTime.
(WebCore::RenderMedia::updateTimeDisplay):
Call MediaControlTimeDisplayElement::setCurrentValue.
- rendering/RenderMedia.h:
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
Add localized strings for media controller accessiblility.
- English.lproj/Localizable.strings:
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):
New.
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
New.
2009-08-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- accessibility/media-element.html: Added.
- platform/mac-leopard/accessibility/media-element-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-empty-source-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- media/video-controls-visible-audio-only.html:
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
Update for controller element tab order change.
- 9:17 AM Changeset in webkit [47109] by
-
- 2 edits in trunk/WebKitTools
2009-08-11 Eric Seidel <eric@webkit.org>
No review, script regression fix only.
run-webkit-tests --quiet hangs
https://bugs.webkit.org/show_bug.cgi?id=28202
Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
This was what I came up with after discussions in #perl.
- Scripts/run-webkit-tests:
- 9:00 AM Changeset in webkit [47108] by
-
- 3 edits in trunk/WebCore
2009-08-12 Viet-Trung Luu <viettrungluu@gmail.com>
Reviewed by Dimitri Glazkov.
Explicitly set control tints for Chromium/Mac, since the controls'
NSCell(s) lack an NSView and hence their tint isn't updated
automatically when the application is activated/deactivated.
https://bugs.webkit.org/show_bug.cgi?id=28108
http://crbug.com/18199
- rendering/RenderThemeChromiumMac.mm: (WebCore::updateNSCellControlTint): (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintButton): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
- 8:59 AM Changeset in webkit [47107] by
-
- 2 edits in trunk/LayoutTests
(no review) Disabling a failing test.
<rdar://problem/7136851> platform/mac/accessibility/string-range-contains-listmarker.html fails.
- platform/mac-snowleopard/Skipped:
- 8:53 AM Changeset in webkit [47106] by
-
- 2 edits in trunk/WebCore
2009-08-12 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Dimitri Glazkov.
[V8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.
This bug causes loads of test crashes, no need to add new tests
specifically for this.
- bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
- 7:16 AM QtWebKitJournal edited by
- (diff)
- 6:55 AM Changeset in webkit [47105] by
-
- 5 edits in trunk
WebCore/ChangeLog:
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
Also optimize by not having to save and restore painter state.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
LayoutTests/ChangeLog:
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Hans Peter Freyther.
[Qt] Update the pixel tests for shadow edge fix.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- 6:02 AM Changeset in webkit [47104] by
-
- 2 edits in trunk/WebCore
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Adam Treat.
[Qt] Fix coding style in GraphicsContextQt.cpp
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
- 5:19 AM Changeset in webkit [47103] by
-
- 5 edits2 adds in trunk
WebCore/ChangeLog:
2009-08-12 Szabo Carol <carol.szabo@nokia.com>
Reviewed by Simon Hausmann and Ariya Hidayat.
[Qt] Partial support for -webkit-box-shadow. Blur is not support and
the shadow still does not go well with border radius.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
LayoutTests/ChangeLog:
2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Pixel tests for (partial) -webkit-box-shadow support.
- platform/qt/Skipped: Include basic-shadows.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
- platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
- platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.
- 4:42 AM Changeset in webkit [47102] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-12 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
since LLONG_MIN is not defined in standard c++.
- runtime/UString.cpp: (JSC::UString::from):
- 4:30 AM Changeset in webkit [47101] by
-
- 2 edits in trunk/WebKit/qt
QtWebKit compile fix for Windows CE
Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-08-12
Reviewed by Simon Hausmann.
There's no getenv on Windows CE, use qgetenv instead.
- Api/qwebpage.cpp:
(qt_drt_overwritePluginDirectories):
- 3:12 AM Changeset in webkit [47100] by
-
- 2 edits in trunk/WebCore
2009-08-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Use AM_V_GEN in a few more places, for less noisy builds.
- GNUmakefile.am:
- 3:11 AM Changeset in webkit [47099] by
-
- 9 edits in trunk/WebCore
2009-08-12 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter premultiplied color support for getImageDate/putImageData
https://bugs.webkit.org/show_bug.cgi?id=27933
Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
and putImageData of ImageBuffer need support for premultiplied colors.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
- platform/graphics/ImageBuffer.h: (WebCore::):
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- 2:58 AM Changeset in webkit [47098] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-12 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
Buildfix for Gtk platforms debug builds.
- GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp depending on platform.
- 2:13 AM Changeset in webkit [47097] by
-
- 2 edits in trunk/JavaScriptCore
Prospective build fix for Mac and 32-bit Windows.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-12
- runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.
(JSC::UString::from): Use %lld instead of %I64d for snprintf
on non-windows platforms.
- 1:58 AM Changeset in webkit [47096] by
-
- 3 edits in trunk/JavaScriptCore
Fix compile error on 64Bit Windows, when UString::from
is called with an intptr_t.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.
Added new UString::From overload with long long parameter.
Thanks to Holger for the long long idea.
- runtime/UString.cpp:
(JSC::UString::from):
- runtime/UString.h:
- 1:18 AM QtWebKitJournal edited by
- (diff)
- 1:04 AM QtWebKitFeatures46 edited by
- (diff)
- 12:59 AM Changeset in webkit [47095] by
-
- 2 edits in trunk/WebCore
2009-08-12 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Changed Number.bytesToString to support low-resolution output.
- inspector/front-end/utilities.js: (Number.bytesToString):
- 12:53 AM Changeset in webkit [47094] by
-
- 3 edits1 add in trunk/WebCore
Add support for hooking BeginPaint/EndPaint on 64Bit Windows
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.
Webkit uses the runtime patching trick explained by "Feng Yuan" for
hooking these paint functions. It currently supports only 32bit assembly
code. This patch adds support for 64Bit version. Since inline-assemblies
are not supported for 64Bit, we have use a seperate .asm file.
- WebCore.pro:
- plugins/win/PaintHooks.asm: Added.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):
Aug 11, 2009:
- 11:50 PM Changeset in webkit [47093] by
-
- 3 edits in trunk/JavaScriptCore
Minor style fixes in previous patch and changelog correction.
Reviewed by Mark Rowe
- 11:22 PM Changeset in webkit [47092] by
-
- 13 edits2 adds in trunk
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469
Reviewed by Gavin Barraclough
Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.
- 10:59 PM Changeset in webkit [47091] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Reviewed by NOBODY (build fix part deux).
- 10:29 PM Changeset in webkit [47090] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Reviewed by NOBODY (build fix).
- 10:22 PM Changeset in webkit [47089] by
-
- 18 edits in trunk
JavaScriptCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209
Reviewed by Oliver Hunt.
These objects were also being referenced from the CodeBlock. By changing this
to just retain pointers to FunctionBodyNodes these classes can be restricted to
use during parsing.
No performance impact (or sub-percent progression).
- JavaScriptCore.exp:
Update symbols.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::mark):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunction):
(JSC::CodeBlock::function):
Unify m_functions & m_functionExpressions into a single Vector<RefPtr<FuncExprNode> >.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
- bytecompiler/BytecodeGenerator.h:
FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
Update to reflect chnages in CodeBlock.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func_exp):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::):
Update to reflect chnages in CodeBlock.
- parser/Grammar.y:
FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.
- parser/NodeConstructors.h:
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
- parser/Nodes.cpp:
(JSC::ScopeNodeData::mark):
(JSC::FunctionBodyNode::finishParsing):
- parser/Nodes.h:
(JSC::FunctionBodyNode::ident):
Move m_ident & make methods from FuncDeclNode & FuncExprNode to FunctionBodyNode.
- runtime/JSFunction.h:
(JSC::FunctionBodyNode::make):
Make this method inline (was FuncDeclNode::makeFunction).
WebCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209
Reviewed by Oliver Hunt.
- inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
Function signature change.
- 10:05 PM Changeset in webkit [47088] by
-
- 1 edit in trunk/WebKitSite/coding/major-objects.html
Hopefully the last tweak to major-objects.html
- 10:01 PM Changeset in webkit [47087] by
-
- 2 edits in trunk/WebKitSite
Unreviewed.
Patch by Adam Barth <abarth@webkit.org> on 2009-08-11
Remove a few characters from the ASCII art to make it fit better in the
template.
- coding/major-objects.html:
- 9:56 PM Changeset in webkit [47086] by
-
- 7 edits in trunk
Native JSON.stringify does not omit functions
https://bugs.webkit.org/show_bug.cgi?id=28117
Reviewed by Gavin Barraclough
Objects that are callable should be treated as undefined when
serialising to JSON.
- 9:55 PM Changeset in webkit [47085] by
-
- 1 edit1 add in trunk/WebKitSite
2009-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Document relation between major objects in WebCore
https://bugs.webkit.org/show_bug.cgi?id=28210
Added a diagram showing the relation between major objects.
- coding/major-objects.html: Added.
- 8:30 PM Changeset in webkit [47084] by
-
- 7 edits1 copy in trunk
2009-08-11 John Gregg <johnnyg@google.com>
Reviewed by Maciej Stachowiak.
WebCore:
Move the accessor for notifications presenter from WebUIDelegate
to WebUIDelegate2 which extends it. When making this call from
WebCoreSupport, check using QueryInterface before calling.
https://bugs.webkit.org/show_bug.cgi?id=28198
- Interfaces/IWebUIDelegate.idl:
- Interfaces/IWebUIDelegate2.idl: Added.
- Interfaces/WebKit.idl:
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
DumpRenderTree:
Switch DumpRenderTree to contain a WebUIDelegate2, which extends
WebUIDelegate, so that the notifications tests will still work.
https://bugs.webkit.org/show_bug.cgi?id=28198
- DumpRenderTree/win/UIDelegate.h:
- 8:12 PM Changeset in webkit [47083] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Mark Rowe.
<rdar://problem/7135864> fast/dom/frame-loading-via-document-write.html fails intermittently.
- platform/mac-snowleopard/Skipped: Skip for now.
- 7:18 PM Changeset in webkit [47082] by
-
- 1 edit in trunk/WebCore/ChangeLog
Not reviewed: repair email address
- 6:30 PM Changeset in webkit [47081] by
-
- 3 edits1 delete in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27965
Merge skia/ImageSourceSkia.cpp into ImageSource.cpp.
Reviewed by Adam Treat.
- WebCore.gypi: Remove deleted file, plus a file that was deleted a while back.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::setData): Use slightly shorter syntax.
(WebCore::ImageSource::filenameExtension): Use shorter syntax.
(WebCore::ImageSource::createFrameAtIndex): Remove redundant call, clarify comments, reject all empty images.
(WebCore::ImageSource::frameHasAlphaAtIndex): Clarify comments, use shorter syntax.
- platform/graphics/skia/ImageSourceSkia.cpp: Removed.
- 6:15 PM Changeset in webkit [47080] by
-
- 2 edits in trunk/WebKitTools
Try to fix GTK build.
Patch by Darin Adler <Darin Adler> on 2009-08-11
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::stringForRange): Added.
- 6:09 PM Changeset in webkit [47079] by
-
- 2 edits in trunk/LayoutTests
Remove tests from Skipped that now pass correctly after the addition
of keyDown named event handling to Qt's DumpRenderTree.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-11
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28161
- platform/qt/Skipped:
- 6:05 PM Changeset in webkit [47078] by
-
- 11 edits in trunk
WebCore: SharedWorkers do not exit when the last parent document exits
https://bugs.webkit.org/show_bug.cgi?id=28170
Reviewed by David Levin.
Prevents Documents from being suspended/placed in the page cache if they are associated with shared workers.
Added vector cache instead of nested hash tables for SharedWorker repository.
Added SharedWorkerRepository::documentDetached API.
- dom/Document.cpp:
(WebCore::Document::detach):
Notifies SharedWorkerRepository when the document is closing.
- loader/FrameLoader.cpp:
Updated FrameLoader to not cache the Document if it is associated with a SharedWorker (since we can't suspend workers yet, we need to shut them down).
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::create):
(WebCore::SharedWorkerProxy::isClosing):
Renamed from closing().
(WebCore::SharedWorkerProxy::matches):
Added manual equality function to replace old hash lookup.
(WebCore::SharedWorkerProxy::isDocumentInWorkerDocuments):
Checks to see if a document is in the worker's list of documents. Used to determine if page is suspendable.
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
Added tracking of the worker's list of documents for lifecycle purposes.
(WebCore::SharedWorkerProxy::documentDetached):
Shuts down the proxy when the last associated document is detached.
(WebCore::SharedWorkerProxy::close):
Marks the proxy as closed so it is no longer shared with new instances.
(WebCore::SharedWorkerProxy::workerContextDestroyed):
Removes the proxy from the repository/frees the proxy when the associated SharedWorkerContext is destroyed.
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
closing()->isClosing()
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):
Used by FrameLoader to determine if a page has shared workers and so cannot be suspended/cached.
(WebCore::DefaultSharedWorkerRepository::hasSharedWorkers):
(WebCore::DefaultSharedWorkerRepository::removeProxy):
Invoked by workerContextDestroyed() to remove a SharedWorkerProxy from the repository.
(WebCore::DefaultSharedWorkerRepository::documentDetached):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
(WebCore::DefaultSharedWorkerRepository::getProxy):
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorkerRepository.h:
LayoutTests: SharedWorkers do not exit when the last parent document exits.
https://bugs.webkit.org/show_bug.cgi?id=28170
Reviewed by David Levin.
Added more tests to check that previous incarnations of the SharedWorker "name" are shut down.
- fast/workers/shared-worker-replace-global-constructor.html-disabled:
Fixed incorrect path to common script.
- fast/workers/shared-worker-shared-expected.txt:
- fast/workers/shared-worker-shared.html-disabled:
Added more tests for sharing, including initial test to make sure previous incarnations of shared worker were closed.
- fast/workers/worker-replace-global-constructor.html:
Removed extraneous closing HTML tag.
- 6:04 PM Changeset in webkit [47077] by
-
- 2 edits in trunk/WebKitTools
Add processing for string constants used by the tests to trigger
common actions like up, down, left, right, etc. for the Qt
implementation of DumpRenderTree.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.
Note this allows fast/forms/textarea-arrow-navigation.html to pass
correctly.
https://bugs.webkit.org/show_bug.cgi?id=28161
- DumpRenderTree/qt/jsobjects.cpp:
(EventSender::keyDown):
- 5:58 PM Changeset in webkit [47076] by
-
- 12 edits2 adds in trunk
WebCore: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200
Reviewed by Darin Adler.
When returning text through the marker range attributes, the list marker text should
also be included. It isn't included by default because a TextIterator is used which
only looks at Nodes for text. A list marker does not have a corresponding node,
so its text is not returned through accessibility. That is, until now.
Test: platform/mac/accessibility/string-range-contains-listmarker.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForRange):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- rendering/RenderListItem.h:
Make markerText() public so that accessibility code can access it.
WebKitTools: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200
Reviewed by Darin Adler.
Add the ability to retrieve a string given a plain NSRange.
- DumpRenderTree/AccessibilityUIElement.cpp:
(stringForRangeCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::stringForRange):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::stringForRange):
LayoutTests: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200
Reviewed by Darin Adler.
Tests for checking that the list marker text is included when asking for text
through accessibility.
- platform/mac/accessibility/bounds-for-range-expected.txt.
- platform/mac/accessibility/string-range-contains-listmarker-expected.txt: Added.
- platform/mac/accessibility/string-range-contains-listmarker.html: Added.
- 5:35 PM Changeset in webkit [47075] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Mark Rowe.
<rdar://problem/7135553> plugins/root-object-premature-delete-crash.html crashes intermittently.
- platform/mac-snowleopard/Skipped: Skip for now.
- 5:08 PM Changeset in webkit [47074] by
-
- 2 edits in trunk/WebKitTools
Fix fast/dom/prototype-inheritance.html
and fast/dom/prototype-inheritance-2.html
broken on Windows by http://trac.webkit.org/changeset/47018
Reviewed by NOBODY (Speculative fix for the layout test failure).
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): enable app cache in Windows DRT.
- 4:20 PM Changeset in webkit [47073] by
-
- 4 edits1 move in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27965
Move cairo/ImageSourceCairo.cpp to ImageSource.cpp in preparation for
merging most of the other ImageSource*.cpp files with it.
Reviewed by Adam Treat.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/ImageSource.cpp: Copied from WebCore/platform/graphics/cairo/ImageSourceCairo.cpp.
- platform/graphics/cairo/ImageSourceCairo.cpp: Removed.
- 4:12 PM Changeset in webkit [47072] by
-
- 2 edits in trunk/BugsSite
Updated data/params parameter
- data/params: Updated 'loginnetmask' parameter to allow users to choose whether their cookies are restricted to a single IP address or not.
- 4:09 PM Changeset in webkit [47071] by
-
- 4 edits in trunk/WebCore
Cairo-based Windows port does not handle the https protocol.
https://bugs.webkit.org/show_bug.cgi?id=28171.
Reviewed by Adam Roben.
No new tests needed. Existing https tests show this failure
for WinCairo builds.
- WebCore.vcproj/WebCoreCURL.vsprops: Add a few preprocessor definitions for SSL support in cURL.
- platform/network/curl/ResourceHandleManager.h: Add new certificate path member variable.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificateBundlePath): New method to retrieve the
proper certificate resource bundle path.
(WebCore::ResourceHandleManager::initializeHandle): Check for
the resource bundle and use if available to activate SSL
support.
- 3:44 PM Changeset in webkit [47070] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-08-11 Eric Seidel <eric@webkit.org>
No review, just adding results.
Cross-platform ICO decoder gets wrong bit depth for icons w/o color count
https://bugs.webkit.org/show_bug.cgi?id=28073
Land test results (as pkasting asked me to do hours ago, sorry).
- fast/images/icon-0colors-expected.checksum: Added.
- fast/images/icon-0colors-expected.png: Added.
- fast/images/icon-0colors-expected.txt: Added.
- 3:33 PM Changeset in webkit [47069] by
-
- 2 edits in trunk/WebKitTools
2009-08-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool: Re-factor shared landing logic into helper class to share more code
https://bugs.webkit.org/show_bug.cgi?id=28193
Added new WebKitLandingScripts class to hold this shared logic.
Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.
- Scripts/bugzilla-tool:
- 3:25 PM Changeset in webkit [47068] by
-
- 5 edits in trunk/WebCore
2009-08-11 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Use Clipboard::create() instead of the constructor of Clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28127
- editing/haiku/EditorHaiku.cpp: (WebCore::Editor::newGeneralClipboard):
- page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
- platform/haiku/ClipboardHaiku.cpp: Style cleanup. There were many whitespace end of lines. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
- platform/haiku/DragDataHaiku.cpp: (WebCore::DragData::createClipboard):
- 3:15 PM Changeset in webkit [47067] by
-
- 2 edits in trunk/WebCore
Speculative fix for GTK build break.
Reviewed by NOBODY (Build break).
- WebKit.pro:
- 3:05 PM Changeset in webkit [47066] by
-
- 2 edits in trunk/WebKitTools
2009-08-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Fix the current failures on the buildbot.
As Qt hooks up the maybeDump to loadFinished, we need to make
sure that calling dump() will not call maybeDump on loadFinished.
As dump is called my emitting done() which calls dump() and then
setting m_isLoading to false. So in the case m_isLoading is false,
do not dump again.
The current code is confusing, and should be made more clear
in another commit.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump): (LayoutTestController::notifyDone):
- 2:35 PM Changeset in webkit [47065] by
-
- 2 edits in trunk/WebKitTools
Fix the current failures on the buildbot.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-11
Reviewed by Adam Treat.
As Qt hooks up the maybeDump to loadFinished, we need to make
sure that calling dump() will not call maybeDump on loadFinished.
As dump is called my emitting done() which calls dump() and then
setting m_isLoading to false. So in the case m_isLoading is false,
do not dump again.
The current code is confusing, and should be made more clear
in another commit.
- DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::maybeDump):
(LayoutTestController::notifyDone):
- 2:31 PM Changeset in webkit [47064] by
-
- 2 edits in trunk
WebCore: Speculative Windows build fix
Reviewed by NOBODY (build break).
- WebCore.vcproj/WebCore.vcproj:
Added missing build steps for non-debug targets.
WebKit/win: Speculative Windows build fix - undo previous unnecessary change.
Reviewed by NOBODY (build break).
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 2:31 PM Changeset in webkit [47063] by
-
- 2 edits in trunk
Speculative build fix for Qt build.
Reviewed by NOBODY (build break)
- WebCore.pro: Added /notifications to include path
- 2:30 PM Changeset in webkit [47062] by
-
- 7 edits in trunk
REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page
https://bugs.webkit.org/show_bug.cgi?id=28169
Reviewed by Geoff Garen.
Handle the case where someone has attempted to shadow a property
on the global object with a constant.
- 2:13 PM Changeset in webkit [47061] by
-
- 2 edits in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=27323
Handle arbitrary line endings when manufacturing patches for additions
with history.
Reviewed by Darin Adler.
- Scripts/svn-create-patch:
- 2:04 PM Changeset in webkit [47060] by
-
- 5 edits in trunk/WebKit/win
2009-08-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Refactored MIMETypeforExtension to be a member of IWebViewPrivate
instead of IWebView.
- Interfaces/IWebView.idl:
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::MIMETypeForExtension):
- WebView.h:
- 2:01 PM Changeset in webkit [47059] by
-
- 2 edits in trunk/WebCore
Speculative build fix for Qt build.
Reviewed by NOBODY (build break)
- WebCore.pro: Added /notifications to include path
- 1:45 PM Changeset in webkit [47058] by
-
- 2 edits in trunk/WebKit/win
Speculative fix for windows build break.
Reviewed by NOBODY (build break)
- WebKitSupport/WebDesktopNotificationsDelegate.h:
WebCore/Notification*.h => WebCore/notifications/Notification*.h
- 1:37 PM Changeset in webkit [47057] by
-
- 2 edits in trunk
Speculative fix for GTK build break.
Reviewed by NOBODY (Build break).
- WebKit.pro:
- 1:21 PM Changeset in webkit [47056] by
-
- 45 edits32 adds in trunk
JavaScriptCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
Adds ENABLE_NOTIFICATION flag.
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
WebCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
Adds an implementation of desktop notifications, behind the compile-time
flag ENABLE(NOTIFICATIONS). This code simply relays calls on the JavaScript
API through a NotificationProvider interface, which must provide the services
to actually notify the user and manage the desktop. This provider is injected
into WebKit through the ChromeClient for normal page contexts and through the
WorkerThread for worker contexts.
A permissions API is defined on a per-origin basis, which allows a web page
to check if its origin is allowed to show desktop notifications, and to request
permission for its origin.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDesktopNotificationsCustom.cpp: Added.
(WebCore::JSNotificationCenter::requestPermission):
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- dom/EventTarget.cpp:
(WebCore::EventTarget::toNotification):
- dom/EventTarget.h:
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::notificationPresenter):
- notifications: Added.
- notifications/Notification.cpp: Added.
(WebCore::Notification::Notification):
(WebCore::Notification::~Notification):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::ondisplay):
(WebCore::Notification::setOndisplay):
(WebCore::Notification::onerror):
(WebCore::Notification::setOnerror):
(WebCore::Notification::onclose):
(WebCore::Notification::setOnclose):
(WebCore::Notification::getAttributeEventListener):
(WebCore::Notification::setAttributeEventListener):
(WebCore::Notification::clearAttributeEventListener):
(WebCore::Notification::dispatchDisplayEvent):
(WebCore::Notification::dispatchErrorEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::addEventListener):
(WebCore::Notification::removeEventListener):
(WebCore::Notification::handleEvent):
(WebCore::Notification::dispatchEvent):
- notifications/Notification.h: Added.
(WebCore::Notification::create):
(WebCore::Notification::isHTML):
(WebCore::Notification::url):
(WebCore::Notification::contents):
(WebCore::Notification::scriptExecutionContext):
(WebCore::Notification::toNotification):
(WebCore::Notification::refEventTarget):
(WebCore::Notification::derefEventTarget):
- notifications/Notification.idl: Added.
- notifications/NotificationCenter.cpp: Added.
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
- notifications/NotificationCenter.h: Added.
(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
(WebCore::NotificationCenter::context):
(WebCore::NotificationCenter::presenter):
- notifications/NotificationCenter.idl: Added.
- notifications/NotificationContents.h: Added.
(WebCore::NotificationContents::NotificationContents):
(WebCore::NotificationContents::icon):
(WebCore::NotificationContents::title):
(WebCore::NotificationContents::body):
- notifications/NotificationPresenter.h: Added.
(WebCore::NotificationPresenter::):
(WebCore::NotificationPresenter::~NotificationPresenter):
- page/Chrome.cpp:
(WebCore::Chrome::notificationPresenter):
- page/Chrome.h:
- page/ChromeClient.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::webkitNotifications):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/Page.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
(WebCore::WorkerContext::webkitNotifications):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- workers/WorkerThread.h:
(WebCore::WorkerThread::getNotificationPresenter):
(WebCore::WorkerThread::setNotificationPresenter):
WebKit/mac: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
Adds ENABLE_NOTIFICATION flag.
- Configurations/FeatureDefines.xcconfig:
WebKit/win: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
Adds test hooks for notification features to WebCoreSupport for
use in DumpRenderTree.
- Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
- Interfaces/IWebUIDelegate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::notificationPresenter):
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
(NotificationCOMWrapper::create):
(NotificationCOMWrapper::NotificationCOMWrapper):
(NotificationCOMWrapper::QueryInterface):
(NotificationCOMWrapper::AddRef):
(NotificationCOMWrapper::Release):
(NotificationCOMWrapper::isHTML):
(NotificationCOMWrapper::contentsURL):
(NotificationCOMWrapper::iconURL):
(NotificationCOMWrapper::title):
(NotificationCOMWrapper::text):
(NotificationCOMWrapper::notifyDisplay):
(NotificationCOMWrapper::notifyError):
(NotificationCOMWrapper::notifyClose):
(WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::notificationDelegate):
- WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
- WebCoreSupport/WebInspectorDelegate.h:
(WebInspectorDelegate::desktopNotificationsDelegate):
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
WebKitTools: Add support for desktop notifications API to DumpRenderTree,
and support for ENABLE_NOTIFICATIONS flag to build-webkit.
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
- DumpRenderTree/LayoutTestController.cpp:
(grantDesktopNotificationPermissionCallback):
(LayoutTestController::staticFunctions):
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::checkDesktopNotificationPermission):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
(DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
(DRTDesktopNotificationPresenter::QueryInterface):
(DRTDesktopNotificationPresenter::AddRef):
(DRTDesktopNotificationPresenter::Release):
(DRTDesktopNotificationPresenter::showDesktopNotification):
(DRTDesktopNotificationPresenter::cancelDesktopNotification):
(DRTDesktopNotificationPresenter::notificationDestroyed):
(DRTDesktopNotificationPresenter::checkNotificationPermission):
(DRTDesktopNotificationPresenter::requestNotificationPermission):
- DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::UIDelegate):
(UIDelegate::desktopNotificationsDelegate):
- DumpRenderTree/win/UIDelegate.h:
- Scripts/build-webkit:
LayoutTests: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463
Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.
Adding layout tests for desktop notifications. Currently these
are all disabled because the flag for this feature is set to 0.
- fast/notifications: Added.
- fast/notifications/notifications-check-permission-expected.txt: Added.
- fast/notifications/notifications-check-permission.html-disabled: Added.
- Validates that checking permission for notifications works correctly.
- fast/notifications/notifications-display-close-events-expected.txt: Added.
- fast/notifications/notifications-display-close-events.html-disabled: Added.
- Validates that the display and close events are fired correctly.
- fast/notifications/notifications-double-show-expected.txt: Added.
- fast/notifications/notifications-double-show.html-disabled: Added.
- Validates that the same notification object cannot be shown twice.
- fast/notifications/notifications-request-permission-expected.txt: Added.
- fast/notifications/notifications-request-permission.html-disabled: Added.
- Validates that requesting permission works correctly.
- fast/notifications/notifications-with-permission-expected.txt: Added.
- fast/notifications/notifications-with-permission.html-disabled: Added.
- Validates that, with permission, showing a notification works correctly.
- fast/notifications/notifications-without-permission-expected.txt: Added.
- fast/notifications/notifications-without-permission.html-disabled: Added.
- Validates that, without permission, showing a notification fails.
- 1:19 PM Changeset in webkit [47055] by
-
- 4 copies1 add in releases/Apple/Safari 4.0.3
Tag the Safari 4.0.3 release.
This release consists of JavaScriptCore-x531.5, JavaScriptGlue-x531.5, WebCore-x531.9 and WebKit-x531.9.
- 1:19 PM Changeset in webkit [47054] by
-
- 2 edits in trunk/WebKit/mac
Remove dead declarations.
Reviewed by Sam Weinig.
- WebView/WebViewInternal.h:
- 1:17 PM Changeset in webkit [47053] by
-
- 4 copies1 add in releases/Apple/Safari 4.0.2
Tag the Safari 4.0.2 release.
This release consists of JavaScriptCore-x530.19, WebCore-x530.19 and WebKit-x530.19.2. JavaScriptGlue remains unchanged from Safari 4.0.1.
- 1:14 PM Changeset in webkit [47052] by
-
- 2 edits3 copies3 adds in trunk/LayoutTests
Rubberstamped by Mark Rowe.
-Stop skipping platform/mac/fast/text/myanmar-shaping.html on SnowLeopard.
-Move the previous results aside for Tiger and Leopard only.
-Generate new results for SnowLeopard.
- platform/mac-snowleopard/Skipped: Remove platform/mac/fast/text/myanmar-shaping.html
- platform/mac-leopard/fast/text/myanmar-shaping-expected.checksum: Copied from platform/mac/fast/text/myanmar-shaping-expected.checksum.
- platform/mac-leopard/fast/text/myanmar-shaping-expected.png: Copied from platform/mac/fast/text/myanmar-shaping-expected.png.
- platform/mac-leopard/fast/text/myanmar-shaping-expected.txt: Copied from platform/mac/fast/text/myanmar-shaping-expected.txt.
- platform/mac/fast/text/myanmar-shaping-expected.checksum: Replaced.
- platform/mac/fast/text/myanmar-shaping-expected.png: Replaced.
- platform/mac/fast/text/myanmar-shaping-expected.txt: Replaced.
- 12:52 PM Changeset in webkit [47051] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Resolve <rdar://problem/6733642>.
- platform/mac-snowleopard/Skipped: Re-enable plugins/netscape-plugin-setwindow-size.html and plugins/netscape-plugin-setwindow-size-2.html, as they now reliably pass.
- 12:51 PM Changeset in webkit [47050] by
-
- 4 edits in trunk/JavaScriptCore
2009-08-11 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Modifications on JavaScriptCore to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28121
- runtime/Collector.cpp: Haiku doesn't have sys/mman.h, using OS.h instead. (JSC::currentThreadStackBase): Haiku uses its own threading system.
- wtf/Platform.h: Defining all Haiku platform values.
- wtf/haiku/MainThreadHaiku.cpp: Adding a missing header (NotImplemented.h).
- 12:37 PM Changeset in webkit [47049] by
-
- 3 edits in trunk/WebCore
2009-08-11 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Console Drawer is Toggling instead of Staying Open
https://bugs.webkit.org/show_bug.cgi?id=28115
- inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.showView): ensures the drawer will be open and showing the provided view
- inspector/front-end/inspector.js: (WebInspector.showConsole): usees the new showView to guarantee the Drawer will be open (WebInspector.showChanges): uses the new showView guarantee the Drawer will be open
- 12:29 PM Changeset in webkit [47048] by
-
- 10 edits1 add in trunk/WebCore
2009-08-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] WMLPageState is not allowed to store the active card, it needs to be done per document
https://bugs.webkit.org/show_bug.cgi?id=28180
Don't store the active WMLCardElement in WMLPageState, but in WMLDocument.
Otherwhise this may lead to crashes related to intrinsic event exeuction.
Unfortunately select elements aren't testable by the layout tests, so adding
a new manual test reproducing the crash.
- manual-tests/wml/select-onpick-event-crash.wml: Added.
- wml/WMLCardElement.cpp: (WebCore::WMLCardElement::determineActiveCard):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
- wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
- wml/WMLDocument.h: (WebCore::WMLDocument::activeCard):
- wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
- wml/WMLPageState.cpp: (WebCore::WMLPageState::WMLPageState):
- wml/WMLPageState.h:
- wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
- wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
- 12:28 PM Changeset in webkit [47047] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
Resolve <rdar://problem/6877291>.
- platform/mac-snowleopard/Skipped: media/video-size-intrinsic-scale.html no longer fails - stop skipping it!
- 12:19 PM Changeset in webkit [47046] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Mark Rowe.
- platform/mac-snowleopard/Skipped: Remove http/tests/navigation/post-goback-repost-policy.html, as it has already been disabled globally, and re-enabling is tracked by <rdar://problem/6778137>
- 12:13 PM Changeset in webkit [47045] by
-
- 3 edits in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=28183
Support VS2008 as well as VS2005 in a few scripts.
Reviewed by Darin Adler.
- Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
- Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.
- 12:10 PM Changeset in webkit [47044] by
-
- 4 edits in trunk/WebKit/win
2009-08-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://5016504> SVG file cannot be dragged to webview,
but can be opened via Open File.
Added a new function to IWebView that gets the MIME type for a given
extension from the MIMETypeRegistry.
- Interfaces/IWebView.idl:
- WebView.cpp: (WebView::MIMETypeForExtension):
- WebView.h:
- 12:09 PM Changeset in webkit [47043] by
-
- 2 edits in trunk/WebKitTools
Fix for layout tests failures. Need to initialize some preferences early
because WebView on Windows uses them during create time.
Reviewed by NOBODY (Windows layout tests fix).
- DumpRenderTree/win/DumpRenderTree.cpp:
(main):
- 12:00 PM Changeset in webkit [47042] by
-
- 3 edits2 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking. Also fix a couple cases of a style
violation.
Reviewed by Eric Seidel.
Test: fast/images/icon-0colors.html
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::readDirectoryEntry):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking.
Reviewed by Eric Seidel.
- fast/images/icon-0colors.html: Added.
- fast/images/resources/0colors.ico: Added.
- 11:29 AM Changeset in webkit [47041] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-11 Benjamin Otte <otte@gnome.org>
Reviewed by Xan Lopez.
When instructed to print an out-of-range page, print an empty page
instead of crashing.
- webkit/webkitwebframe.cpp: (draw_page_callback):
- 11:27 AM Changeset in webkit [47040] by
-
- 3 edits1 copy in trunk/WebKitTools
2009-08-11 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Exception in land-patches
https://bugs.webkit.org/show_bug.cgi?id=27962
Use ("%s" % object) instead of ("" + object).
Added unit tests for logging.py.
- Scripts/modules/logging.py:
- Scripts/modules/logging_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 10:42 AM Changeset in webkit [47039] by
-
- 19 edits6 adds in trunk
Re-land the patch for https://bugs.webkit.org/show_bug.cgi?id=20534.
Previously reverted since incorrect merge on landing has caused Layout Tests failures on Windows.
WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
See https://bugs.webkit.org/show_bug.cgi?id=20534
- WebView/WebPreferences.mm:
(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.
- WebView/WebPreferencesPrivate.h: same.
WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534
- Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
- WebPreferences.cpp: same.
- WebPreferences.h: same.
WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534
- DumpRenderTree/LayoutTestController.cpp:
(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.
- DumpRenderTree/LayoutTestController.h: same.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): added empty overridePreference method.
- DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::overridePreference):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::overridePreference):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::overridePreference):
LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
See https://bugs.webkit.org/show_bug.cgi?id=20534
- fast/harness/override-preferences-2-expected.txt: Added.
- fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
- fast/harness/override-preferences-expected.txt: Added.
- fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
- fast/harness/override-zzz-reset-expected.txt: Added.
- fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and
verify that override of preferences does not 'spill' to the subsequent tests in a batch.
- platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.
- 10:26 AM QtWebKitJournal edited by
- (diff)
- 9:58 AM Changeset in webkit [47038] by
-
- 2 edits in trunk/WebKitTools
2009-08-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Sam Weinig.
Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
https://bugs.webkit.org/show_bug.cgi?id=28166.
This is a step towards fixing fast/events/mouse-click-events.html on Windows.
- DumpRenderTree/win/EventSender.cpp: (mouseDownCallback): (mouseUpCallback): (replaySavedEvents):
- 9:48 AM SuccessfulPortHowTo edited by
- Added some recommended porting steps. (diff)
- 9:39 AM Changeset in webkit [47037] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-11 Jessie Berlin <jberlin@apple.com>
Fix windows build.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:33 AM Changeset in webkit [47036] by
-
- 18 edits1 copy in trunk/WebCore
Need to refactor WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=28136
Reviewed by David Levin.
Added WorkerReportingProxy for reporting worker state (exceptions, console messages, thread exited) to the parent.
Existing tests are sufficient, as this is only a refactoring.
- GNUmakefile.am:
Added WorkerReportingProxy.h to build.
- WebCore.gypi:
Added WorkerReportingProxy.h to build.
- WebCore.vcproj/WebCore.vcproj:
Added WorkerReportingProxy.h to build.
- WebCore.xcodeproj/project.pbxproj:
Added WorkerReportingProxy.h to build.
- workers/DedicatedWorkerContext.cpp:
- workers/DedicatedWorkerContext.h:
Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
Changed constructor to pass WorkerReportingProxy to base class.
- workers/DefaultSharedWorkerRepository.cpp:
Updated SharedWorkerProxy to implement WorkerReportingProxy interface.
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerProxy::workerContextClosed):
(WebCore::SharedWorkerProxy::workerContextDestroyed):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
Now passes in WorkerReportingProxy when creating SharedWorkerThread.
- workers/SharedWorkerContext.cpp:
- workers/SharedWorkerContext.h:
Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
Passes WorkerReportingProxy to base class constructor.
- workers/SharedWorkerThread.h:
Constructor now takes a WorkerReportingProxy.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
Moved code that calls workerContextDestroyed() into base class so shared workers share this functionality.
(WebCore::WorkerContext::close):
Now notifies WorkerReportingProxy when the thread is closing.
(WebCore::WorkerContext::reportException):
Reports exceptions via WorkerReportingProxy.
(WebCore::WorkerContext::addMessage):
Reports console messages via WorkerReportingProxy.
- workers/WorkerContext.h:
- workers/WorkerObjectProxy.h:
(WebCore::WorkerObjectProxy::workerContextClosed):
Default empty implementation for dedicated workers.
- workers/WorkerReportingProxy.h: Added.
Base interface that contains APIs moved from WorkerObjectProxy.
(WebCore::WorkerReportingProxy::~WorkerReportingProxy):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
Updated constructor to accept a WorkerReportingProxy.
- workers/WorkerThread.h:
(WebCore::WorkerThread::workerReportingProxy):
- 8:39 AM Changeset in webkit [47035] by
-
- 2 edits in trunk/JavaScriptCore
Buildfix for Qt-win platforms.
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-11
Reviewed by Tor Arne Vestbø.
- JavaScriptCore.pri: Choose MarkStackPosix.cpp or MarkStackWin.cpp depend on platform.
- 8:16 AM Changeset in webkit [47034] by
-
- 2 edits1 add in trunk/LayoutTests
2009-08-11 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add results for fast/borders/border-radius-split-inline and remove from platform/qt/Skipped
Note: Results will wrap to 4 lines even though it indicates 3 lines. This is due to font
size differences in Qt, and matches the output of FireFox.
- platform/qt/Skipped:
- platform/qt/fast/borders/border-radius-split-inline-expected.txt: Added.
- 7:56 AM Changeset in webkit [47033] by
-
- 4 edits in trunk
Build the TestNetscapePlugin on Qt/Mac
Reviewed by Simon Hausmann.
- WebKit.pro:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 7:56 AM Changeset in webkit [47032] by
-
- 3 edits in trunk/WebKitTools
Fix a bunch of build warnings in TestNetscapePlugin
Reviewed by Simon Hausmann.
- DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
- 3:37 AM Changeset in webkit [47031] by
-
- 2 edits in trunk
2009-08-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Prefix lengthy commands with AM_V_GEN so that they produce an
output like 'GEN <filename>' when in silent mode.
- GNUmakefile.am:
- 2:40 AM Changeset in webkit [47030] by
-
- 5 edits in trunk/WebCore
Fix the Qt build after r47022.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by NOBODY (build fix).
Use the new markChildren() pattern for marking aggregate/child objects.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::markChildren):
(JSC::Bindings::QtInstance::markAggregate):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
- bridge/qt/qt_runtime.h:
- 1:14 AM Changeset in webkit [47029] by
-
- 2 edits in trunk/WebKitTools
2009-08-11 Dmitry Titov <dimich@chromium.org>
Reviewed by NOBODY (build fix).
Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
preferences permanently. Since these preferences are not initialized explicitly in DRT,
almost all Layout tests are failing. Attempt to fix by explicit
initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.
- DumpRenderTree/win/DumpRenderTree.cpp: (main): see above.
- 12:26 AM Changeset in webkit [47028] by
-
- 2 edits in trunk/WebCore
Fix the build on the Qt build bot by making the generated JS bindings
files depend on the code generator itself.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by Holger Freyther.
- WebCore.pro:
Aug 10, 2009:
- 10:43 PM Changeset in webkit [47027] by
-
- 3 edits in trunk/JavaScriptCore
Add new exports for MSVC
- 10:27 PM Changeset in webkit [47026] by
-
- 3 edits in trunk/JavaScriptCore
Remove obsolete entries from MSVC exports file
- 10:18 PM Changeset in webkit [47025] by
-
- 3 edits in trunk/JavaScriptCore
Add includes needed for non-allinonefile builds
- 10:15 PM Changeset in webkit [47024] by
-
- 2 edits in trunk/JavaScriptCore
Fix export file for last build fix
- 10:07 PM Changeset in webkit [47023] by
-
- 4 edits in trunk/JavaScriptCore
Build fix
Hoist page size initialization into platform specific code.
- 9:35 PM Changeset in webkit [47022] by
-
- 103 edits3 copies4 adds in trunk
Stack overflow crash in JavaScript garbage collector mark pass
https://bugs.webkit.org/show_bug.cgi?id=12216
Reviewed by Gavin Barraclough and Sam Weinig
Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages
- The object is appended to the MarkStack, this sets the marked bit for the object using the new markDirect() function, and then returns
- When the MarkStack is drain()ed the object is popped off the stack and markChildren(MarkStack&) is called on the object to collect all of its children. drain() then repeats until the stack is empty.
Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.
- 9:17 PM Changeset in webkit [47021] by
-
- 7 edits in trunk/WebCore
2009-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Eric Seidel.
Renamed all V8 NPN_ functions to _NPN_ to match JSC and make them "private".
https://bugs.webkit.org/show_bug.cgi?id=28089
Rename all the NPN_foo functions to _NPN_foo so that they can't directly be
called by mistake. This roughly matches the way JSC does it, which is an
additional advantage.
- bindings/v8/NPV8Object.cpp: (npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearScriptObjects): (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
- bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectGetProperty): (npObjectIndexedPropertyGetter): (npObjectGetIndexedProperty): (npObjectSetProperty): (npObjectIndexedPropertySetter): (npObjectSetIndexedProperty): (weakNPObjectCallback): (createV8ObjectForNPObject): (forgetV8ObjectForNPObject):
- bindings/v8/V8NPUtils.cpp: (getStringIdentifier):
- bindings/v8/npruntime.cpp:
- bindings/v8/npruntime_impl.h:
- 9:02 PM Changeset in webkit [47020] by
-
- 16 edits in trunk
2009-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Brady Eidson.
Change _Storage.key() to match current spec behavior.
https://bugs.webkit.org/show_bug.cgi?id=28112
The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. A bunch of logic can be
simplified after this change.
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
- bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator):
- storage/Storage.cpp: (WebCore::Storage::key):
- storage/Storage.h:
- storage/Storage.idl:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::key):
- storage/StorageAreaImpl.h:
- storage/StorageMap.cpp: (WebCore::StorageMap::key):
- storage/StorageMap.h:
2009-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Brady Eidson.
_Storage.key() changed to match new spec behavior; update layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28112
The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. Change the one layout
test that verified this behavior.
- storage/domstorage/localstorage/simple-usage-expected.txt:
- storage/domstorage/localstorage/simple-usage.html:
- storage/domstorage/sessionstorage/simple-usage-expected.txt:
- storage/domstorage/sessionstorage/simple-usage.html:
- 8:59 PM Changeset in webkit [47019] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix silly change log bustage.
- 8:49 PM Changeset in webkit [47018] by
-
- 4 edits in trunk/WebCore
2009-08-07 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Mods for a chrome specific impl of ApplicationCacheHost.
- The public section of the interface is the same, but we use PLATFORM(CHROMIUM) to identify which parts of the private section are shared. The chrome specific internals are encapsulated in a seperate ApplicationCacheHostInternal class. WebCore common code only contains a forward reference to this class.
- Cleanup a couple of stale comments.
- Have window.applicationCache return null to script when the feature is disabled in the preferences.
No new tests.
- loader/appcache/ApplicationCacheHost.cpp:
- loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::documentLoader):
- page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):
<<<<<<< .mine
- 7:55 PM Changeset in webkit [47017] by
-
- 19 edits6 deletes in trunk
Revert r47015 "Added support for overriding default preferences per-test."
https://bugs.webkit.org/show_bug.cgi?id=20534
Ir broke too many Windows tests and I don't have a simple fix right now.
- 7:53 PM Changeset in webkit [47016] by
-
- 3 edits in trunk/WebCore
2009-08-10 Crystal Zhang <crystal.zhang@staikos.net>
Reviewed by George Staikos.
Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842
- platform/graphics/GraphicsContext.h:
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::rectCenterPoint): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner):
- 7:18 PM Changeset in webkit [47015] by
-
- 19 edits7 adds in trunk
WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
https://bugs.webkit.org/show_bug.cgi?id=20534
- WebView/WebPreferences.mm:
(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.
- WebView/WebPreferencesPrivate.h: same.
WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534
- Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
- WebPreferences.cpp: same.
- WebPreferences.h: same.
WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534
- DumpRenderTree/LayoutTestController.cpp:
(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.
- DumpRenderTree/LayoutTestController.h: same.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): added empty overridePreference method.
- DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::overridePreference):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::overridePreference):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::overridePreference):
LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
https://bugs.webkit.org/show_bug.cgi?id=20534
- fast/harness/override-preferences-2-expected.txt: Added.
- fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
- fast/harness/override-preferences-expected.txt: Added.
- fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
- fast/harness/override-zzz-reset-expected.txt: Added.
- fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and
verify that override of preferences does not 'spill' to the subsequent tests in a batch.
- platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.
- platform/qt/Skipped: same for QT.
- 6:11 PM Coding Style Guidelines edited by
- (diff)
- 5:34 PM Changeset in webkit [47014] by
-
- 2 edits in trunk/WebKit/win
Link drag images specify Lucida Grande on Windows and end up using Times
New Roman
<rdar://problem/7117835>
Reviewed by Darin Adler.
- WebCoreSupport/WebDragClient.cpp:
(dragLabelFont): Added a RenderingMode parameter and changed to use the
same typeface as the Windows small caption font.
(WebDragClient::createDragImageForLink): Changed to respect the
page’s rendering mode.
- 5:15 PM Changeset in webkit [47013] by
-
- 2 edits in trunk/WebKitTools
Windows nightly fix.
Reviewed by Ada Chan.
- FindSafari/FindSafari.cpp:
(_tmain): Copy Safari.dll if it exists.
- 4:47 PM Changeset in webkit [47012] by
-
- 2 edits in trunk/WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=27323
Even more line ending-stripping for auto-version.sh, based on output
provided by Jessie Berlin.
Reviewed by George Staikos.
- win/tools/scripts/auto-version.sh:
- 4:29 PM Changeset in webkit [47011] by
-
- 5 edits in trunk/WebCore
Inspector Resources / Graphs should support filtering
https://bugs.webkit.org/show_bug.cgi?id=20629
Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-10
Reviewed by Timothy Hatcher.
Introduces a filter bar for resources.
Thanks to Matt Lilek for the CSS scope bar.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.createFilterElement):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.toolbarItemClass.categoryOrder.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
(WebInspector.ResourcesPanel.prototype._updateSummaryGraph):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js:
(WebInspector.loaded):
- 4:17 PM Changeset in webkit [47010] by
-
- 2 edits in trunk/JavaScriptCore
Fix hundreds of "pointer being freed was not allocated" errors seen on the build bot.
Reviewed by Darin Adler.
- wtf/FastMalloc.h: Implement nothrow variants of the delete and delete[] operators since
we implement the nothrow variants of new and new[]. The nothrow variant of delete is called
explicitly in the implementation of std::sort which was resulting in FastMalloc-allocated
memory being passed to the system allocator to free.
- 3:37 PM Changeset in webkit [47009] by
-
- 2 edits in trunk/WebCore
Unreviewed build correction after http://trac.webkit.org/changeset/46978
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle): Correct
deprecated removeRef to new removeFragmentIdentifier.
- 3:27 PM Changeset in webkit [47008] by
-
- 5 edits2 adds in trunk
WebCore: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch makes background color be preserved during editing.
In particular, editingStyleAtPosition would include the background color when obtaining styles.
- editing/ApplyStyleCommand.cpp:
(WebCore::): Added CSSPropertyBackgroundColor to editingStyleProperties
LayoutTests: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch adds a test to make sure WebKit preserves background color when inserting a new paragraph.
- editing/inserting/5994480-2-expected.txt: Because input element has explicit white background and the enclosing div has
transparent background, WebKit adds white background color in DeleteSelectionCommand::calculateTypingStyleAfterDelete upon deletion.
- editing/style/highlight-insert-paragraph-expected.txt: Added.
- editing/style/highlight-insert-paragraph.html: Added.
- platform/mac/editing/pasteboard/select-element-1-expected.txt: Because select element has explicit white background color
and div has transparent background, WebKit adds white background color in calculateTypingStyleAfterDelete upon cut.
- 3:14 PM Changeset in webkit [47007] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by George Staikos.
Forgot to update pixel test result in my last commit.
- 3:13 PM Changeset in webkit [47006] by
-
- 3 edits in trunk/WebKitTools
2009-08-10 David Levin <levin@chromium.org>
Reviewed by David Kilzer.
check-webkit-style doesn't catch braces around single line statements when followed by else.
https://bugs.webkit.org/show_bug.cgi?id=28164
- Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when checking the no braces for "single lines" rule.
- Scripts/modules/cpp_style_unittest.py: Added test case.
- 2:53 PM Changeset in webkit [47005] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module
Reviewed by David Levin.
- Scripts/bugzilla-tool: (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() in scm module.
- Scripts/modules/scm.py: Removed import of bugzilla module. (CommitMessage.parse_bug_id): Deleted.
- 2:17 PM Changeset in webkit [47004] by
-
- 2 edits in trunk/WebCore
Stop sending QEvent::CursorChange to Qt for mouse move.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-10
Reviewed by Simon Hausmann.
Verify if the cursor didn't change in WidgetQt::setCursor,
just like the mac port does.
Thanks to Adriano Rezendo for spotting and debugging the
issue.
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::setCursor):
- 2:04 PM Changeset in webkit [47003] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Unreviewed build fix. Move JSAPIValueWrapper.cpp/.h in the debug
section. This file is already part of AllInOneFile in Release builds.
- GNUmakefile.am:
- 1:58 PM BuildingOnWindows edited by
- Add information about not being able to find debugging symbols (diff)
- 1:51 PM Changeset in webkit [47002] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=28165
Application cache maximum size cannot be set before the database is opened
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::vacuumDatabaseFile): Open appcache database if it isn't open yet.
- 1:37 PM Changeset in webkit [47001] by
-
- 11 edits in trunk/WebCore
2009-08-10 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>
Reviewed by Dimitri Glazkov.
[V8] Fix memory leak in node event listeners. See http://crbug.com/17400.
https://bugs.webkit.org/show_bug.cgi?id=28156
- bindings/scripts/CodeGeneratorV8.pm: Custom event handler accessors now apply to all Node descendants.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::isObjectListener): Added virtual method to detect listeners that have weak references to JS objects.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/V8ObjectEventListener.cpp:
- bindings/v8/V8ObjectEventListener.h: (WebCore::V8ObjectEventListener::isObjectListener):
- bindings/v8/V8Utilities.cpp: (WebCore::removeHiddenDependency):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8NodeCustom.cpp: Moved custom accessors from V8ElementCustom.cpp. (WebCore::toEventType): (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Made static.
- 12:46 PM Changeset in webkit [47000] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/FastMalloc.h: Fix build.
- 12:42 PM Changeset in webkit [46999] by
-
- 3 edits in trunk/JavaScriptCore
FastMalloc.h has cross-platform code but marked as WinCE-only
https://bugs.webkit.org/show_bug.cgi?id=28160
Patch by Darin Adler <Darin Adler> on 2009-08-10
Reviewed by Mark Rowe.
1) The support for nothrow was inside #if PLATFORM(WINCE) even though it is
not platform-specific.
2) The code tried to override operator delete nothrow, which does not exist.
3) The code in the header checks the value of USE_SYSTEM_MALLOC, but the code
in FastMalloc.cpp checks only if the macro is defined.
- wtf/FastMalloc.h: See above.
- wtf/FastMalloc.cpp: Ditto.
- 12:37 PM Changeset in webkit [46998] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix date in ChangeLog
- 12:34 PM Changeset in webkit [46997] by
-
- 5 edits in trunk/WebCore
2009-08-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Cleanup DOM Storage namespace shutdown code + usage of security origin.
https://bugs.webkit.org/show_bug.cgi?id=28094
If a storage namespace is not explicitly closed, be sure to do so on
destruction of the object. In addition, the close call should wait
on the background thread finishing its syncing. (Not doing so is actually
a regression from the original LocalStorage code.)
There's no point to passing in the SecurityOrigin when copying a storage
area since what was passed in is exactly what is stored within each
storage area. In addition, the non-copy constructor should take in a
PassRefPtr rather than a pointer since that pointer was only passed into
the constuctor for RefPtr's anyway.
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy):
- storage/StorageAreaImpl.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::close):
- storage/StorageNamespaceImpl.h:
- 12:30 PM Changeset in webkit [46996] by
-
- 4 edits in trunk/WebCore
Not reviewed, build fix.
Rename ref() to fragmentIdentifier() in the wml/ subdirectory.
- 12:15 PM Changeset in webkit [46995] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Exclude JSMedia.cpp from build since it is included in DerivedSources.cpp.
Fixes linker warnings.
Corrected spelling of JSInspectorBackend.cpp.
Other changes related to actually using a Visual Studio to open/save the vcproj file.
- WebCore.vcproj/WebCore.vcproj:
- 11:39 AM Changeset in webkit [46994] by
-
- 2 edits in trunk/WebCore
Remove a dead #define.
Reviewed by Anders Carlsson.
- bindings/js/JSDOMBinding.cpp:
- 11:36 AM Changeset in webkit [46993] by
-
- 3 edits in trunk/WebCore
2009-08-10 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Update KURLGoogle for ref* method renames in
http://trac.webkit.org/changeset/46978.
https://bugs.webkit.org/show_bug.cgi?id=28084
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): Renamed ref and setRef to fragmentIdentifier and
setFragmentIdentifier, respectively.
- platform/KURLGoogle.cpp: Ditto, plus all other ref* method names.
- 11:30 AM Changeset in webkit [46992] by
-
- 2 edits in trunk/JavaScriptCore
Fix an annoying indentation issue.
Reviewed by Anders Carlsson.
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- 11:26 AM Changeset in webkit [46991] by
-
- 2 edits in trunk/WebCore
[Gtk] Unreviewed. Fix the nit as suggested by Darin in bug #28144 for r46989.
- 11:22 AM Changeset in webkit [46990] by
-
- 4 edits1 add in trunk
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.
Reviewed by Adam Roben.
- WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet (which contains link settings for cURL and its dependencies), and remove the corresponding entries from the vcproj file. Remove png, jpeg, cairo library linking flags from vcproj, now that they are in the WinCairo.vsprops file.
WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.
Reviewed by Adam Roben.
- win/tools/vsprops/cURL.vsprops: Added.
- 11:20 AM Changeset in webkit [46989] by
-
- 2 edits in trunk/WebCore
2009-08-10 John Kjellberg <john.kjellberg@power.alstom.com>
Reviewed by Darin Adler.
Memory leak in error handling code for SOUP interface
https://bugs.webkit.org/show_bug.cgi?id=28144
Freed memory leaked in error handling code for soup requests.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::):
- 11:18 AM Changeset in webkit [46988] by
-
- 2 edits in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=18599
Work around apparent bug in abs2rel() with symlinked directories.
Reviewed by David Kilzer.
- Scripts/resolve-ChangeLogs:
- 11:10 AM Changeset in webkit [46987] by
-
- 2 edits in trunk/WebCore
2009-08-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Provide graceful handling of the situation when an embedder invokes
visited link update methods before a Page constructor has been called.
https://bugs.webkit.org/show_bug.cgi?id=28149
- page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added a null-check for allPages. (WebCore::Page::visitedStateChanged): Ditto.
- 11:03 AM Changeset in webkit [46986] by
-
- 2 edits in trunk/WebCore
2009-08-10 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- 10:56 AM Changeset in webkit [46985] by
-
- 3 edits in trunk/WebCore
Remove the redundant, Windows CE-only GlyphBuffer::advnaceData()
Reviewed by Anders Carlsson.
- platform/graphics/GlyphBuffer.h: Removed advanceData().
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawText): Changed to use advances(from)
instead of advanceData() + from.
- 10:37 AM Changeset in webkit [46984] by
-
- 2 edits in trunk/WebCore
2009-08-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove workaround for older libsoup versions.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 10:37 AM Changeset in webkit [46983] by
-
- 2 edits in trunk/WebCore
2009-08-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Let startHttp validate the URI instead of doing it, with potential
crashes, in ::start.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
- 10:28 AM Changeset in webkit [46982] by
-
- 6 edits3 adds in trunk
WebCore: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903
Patch by Darin Adler <Darin Adler> on 2009-08-10
Reviewed by Dan Bernstein.
Test: fast/forms/shadow-tree-exposure.html
- page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor): Added.
(WebCore::DOMSelection::anchorNode): Return the parent of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::anchorOffset): Return the index of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::focusNode): Ditto.
(WebCore::DOMSelection::focusOffset): Ditto.
(WebCore::DOMSelection::baseNode): More of the same, but since this
is a WebKit-invented property, it does not match Firefox.
(WebCore::DOMSelection::baseOffset): Ditto.
(WebCore::DOMSelection::extentNode): Ditto.
(WebCore::DOMSelection::extentOffset): Ditto.
(WebCore::DOMSelection::isCollapsed): Return true even when the
selection is a range, if the selection is in the shadow tree.
Matches Firefox. Also changed behavior when called and the frame
is gone to return true instead of false which makes more sense.
(WebCore::DOMSelection::empty): Use clear() just like the other
selection-clearing function in this file does.
(WebCore::DOMSelection::getRangeAt): Return a range that starts
and ends before the shadow ancestor. Matches Firefox.
LayoutTests: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903
Patch by Darin Adler <Darin Adler> on 2009-08-07
Reviewed by Dan Bernstein.
Also updated a recently introduced non-standard test to work in a more
standard way.
- fast/forms/resources/shadow-tree-exposure.js: Added.
- fast/forms/shadow-tree-exposure-expected.txt: Added.
- fast/forms/shadow-tree-exposure.html: Added.
- fast/js/method-check-expected.txt: Updated.
- fast/js/method-check.html: Regenerated using the make-js-test-wrappers script.
- fast/js/resources/method-check.js: Replaced a comment talking about the lack
of a gc() function with a call to GCController.collect(). Also removed the
shouldBeTrue call at the end of the fiel that wasn't needed.
- 10:25 AM Changeset in webkit [46981] by
-
- 2 edits in trunk/WebKitTools
Build fix
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
- 10:07 AM Changeset in webkit [46980] by
-
- 2 edits in trunk/WebKit/gtk
GTK build fix.
- webkit/webkitdownload.cpp:
(webkit_download_get_suggested_filename):
- 9:53 AM Changeset in webkit [46979] by
-
- 10 edits15 adds12 deletes in trunk/WebCore
2009-08-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make all status bar button images glyph-based.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
- inspector/front-end/Images/clearConsoleButtonGlyph.png: Added.
- inspector/front-end/Images/clearConsoleButtons.png: Removed.
- inspector/front-end/Images/consoleButtonGlyph.png: Added.
- inspector/front-end/Images/consoleButtons.png: Removed.
- inspector/front-end/Images/dockButtonGlyph.png: Added.
- inspector/front-end/Images/dockButtons.png: Removed.
- inspector/front-end/Images/enableButtons.png: Removed.
- inspector/front-end/Images/enableOutlineButtonGlyph.png: Added.
- inspector/front-end/Images/enableSolidButtonGlyph.png: Added.
- inspector/front-end/Images/excludeButtonGlyph.png: Added.
- inspector/front-end/Images/excludeButtons.png: Removed.
- inspector/front-end/Images/focusButtonGlyph.png: Added.
- inspector/front-end/Images/focusButtons.png: Removed.
- inspector/front-end/Images/largerResourcesButtonGlyph.png: Added.
- inspector/front-end/Images/largerResourcesButtons.png: Removed.
- inspector/front-end/Images/nodeSearchButtonGlyph.png: Added.
- inspector/front-end/Images/nodeSearchButtons.png: Removed.
- inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Added.
- inspector/front-end/Images/pauseOnExceptionButtons.png: Removed.
- inspector/front-end/Images/percentButtonGlyph.png: Added.
- inspector/front-end/Images/percentButtons.png: Removed.
- inspector/front-end/Images/recordButtonGlyph.png: Added.
- inspector/front-end/Images/recordButtons.png: Removed.
- inspector/front-end/Images/recordToggledButtonGlyph.png: Added.
- inspector/front-end/Images/reloadButtonGlyph.png: Added.
- inspector/front-end/Images/reloadButtons.png: Removed.
- inspector/front-end/Images/undockButtonGlyph.png: Added.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createStatusBarButton):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 9:49 AM QtWebKitFeatures46 edited by
- (diff)
- 9:35 AM Changeset in webkit [46978] by
-
- 19 edits in trunk/WebCore
KURL ref() methods should be fragmentIdentifier() methods
https://bugs.webkit.org/show_bug.cgi?id=28084
Reviewed by Darin Adler.
In addition to the renames, also took the chance to replace all use of:
setRef(String());
with:
removeFragmentIdentifier();
- platform/KURL.cpp:
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::KURL::prettyURL):
(WebCore::equalIgnoringFragmentIdentifier):
- platform/KURL.h:
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHash): Rework with new names, and to use the new equalIgnoringNullity() method.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::internalLinkElement):
- css/CSSCursorImageValue.cpp:
(WebCore::isSVGCursorIdentifier):
- history/HistoryItem.cpp:
(WebCore::HistoryItem::isCurrentDocument):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::hash):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::gotoAnchor):
(WebCore::FrameLoader::scheduleLocationChange):
(WebCore::FrameLoader::scrollToAnchor):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::urlsMatchItem):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::resourceForURL):
(WebCore::ApplicationCache::resourceForRequest):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::addEntry):
- loader/appcache/ApplicationCacheResource.h:
(WebCore::ApplicationCacheResource::create):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
- page/Location.cpp:
(WebCore::Location::hash):
- page/Page.cpp:
(WebCore::Page::goToItem):
- rendering/RenderPartObject.cpp:
(WebCore::isURLAllowed):
- workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::hash):
- 9:19 AM Changeset in webkit [46977] by
-
- 2 edits in trunk/WebKitTools
2009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Adam Roben.
Allow TestNetscapePlugIn to fall back to the Carbon event model
Previously the plugin would fail, even though the Carbon event
model was available. The only way to get the Carbon event model
was to pass the "forcecarbon" argument in the test markup, but no
tests were using this.
Now the plugin uses carbon either if it's forced, or if the Cocoa
event model is not supported.
This helps us run most of the plugin tests on Qt/Mac, which still
does not support the Cocoa event model.
- 8:45 AM QtWebKitFeatures46 edited by
- (diff)
- 8:27 AM QtWebKitJournal edited by
- (diff)
- 8:26 AM QtWebKitFeatures46 created by
- 8:22 AM QtWebKitJournal edited by
- (diff)
- 8:07 AM QtWebKitJournal edited by
- (diff)
- 7:51 AM QtWebKitJournal edited by
- (diff)
- 7:47 AM Changeset in webkit [46976] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-10 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add new files to makefile.
- GNUmakefile.am:
- 7:29 AM QtWebKitJournal edited by
- (diff)
- 7:10 AM QtWebKitJournal edited by
- (diff)
- 7:05 AM QtWebKitJournal edited by
- (diff)
- 6:39 AM Changeset in webkit [46975] by
-
- 3 edits in trunk/WebKit/qt
Various fixes and improvements to the QWebPluginInfo, QWebPluginDatabase and QWebSettings documentation.
Patch by Kavindra Palaraja <kavindra.palaraja@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.
- Api/qwebplugindatabase.cpp:
- Api/qwebsettings.cpp:
- 5:49 AM QtWebKit edited by
- (diff)
- 5:46 AM Changeset in webkit [46974] by
-
- 12 edits1 add in trunk/LayoutTests
[Qt] After ChangeSet https://bugs.webkit.org/show_bug.cgi?id=26896, the
DefaultFontSize was changed in Qt DumpRenderTree from 14 to 13. But
any expected file works with the original value. The expected values
should follow this change. This patch contains the new expected
files.
Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-10
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- platform/qt/editing/pasteboard/5780697-2-expected.txt: Add.
- platform/qt/fast/block/float/009-expected.txt:
- platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/qt/fast/images/image-in-map-expected.txt:
- platform/qt/fast/inline-block/004-expected.txt:
- platform/qt/fast/inline-block/005-expected.txt:
- platform/qt/fast/table/giantRowspan-expected.txt:
- platform/qt/fast/table/height-percent-test-expected.txt:
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 5:36 AM Changeset in webkit [46973] by
-
- 2 edits in trunk/WebCore
Fix endless loop when the application is quit by a secondary thread during a sync xml http request.
Patch by Andy Shaw <andy.shaw@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.
Replace the m_finished state variable and the call to QCoreApplication::processEvents() with
a dedicated QEventLoop, that can be terminated from within WebCoreSynchronousLoader as well
as from Qt through its knowledge of globally registered eventloops.
There is no unit test for this bug as it would require exporting additional symbols and
introduce the synchronous loader as global variable just for the test.
- platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):
- 3:02 AM Changeset in webkit [46972] by
-
- 10 edits1 add in trunk/WebCore
2009-08-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Make properties inspection serialized.
- inspector/front-end/DOMAgent.js: (InspectorController.getPrototypes): (InspectorController.getProperties):
- inspector/front-end/InjectedScript.js: (InjectedScript.getPrototypes): (InjectedScript.getProperties): (InjectedScript.setPropertyValue):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectRef): (WebInspector.ObjectPropertyRef): (WebInspector.ObjectPropertiesSection.prototype.onpopulate): (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype._update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.onattach): (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
- 1:16 AM Changeset in webkit [46971] by
-
- 2 edits in trunk/LayoutTests
Rebase Qt letter spacing DRT result after r46936
Reviewed by Ariya Hidayat.
- platform/qt/fast/text/text-letter-spacing-expected.txt:
- 1:01 AM Changeset in webkit [46970] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation with the interpreter instead of the JIT by including
PrototypeFunction.h as forward-declared through NativeFunctionWrapper.h.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-10
- runtime/ObjectConstructor.cpp:
Aug 9, 2009:
- 5:47 PM Changeset in webkit [46969] by
-
- 5 edits in trunk
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135
Add <pre> support for WML.
Extended fast/wml/text-emphasis.wml to cover <pre> support.
- css/wml.css: <pre> section copied from html.css
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135
Extend fast/wml/text-emphasis.wml test, to cover <pre> formatting.
- fast/wml/text-emphasis.wml:
- platform/mac/fast/wml/text-emphasis-expected.txt:
- 5:01 PM Changeset in webkit [46968] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
Fix non-WML enabled builds. Remove ENABLE(WML) guards around the switch cases 'FrameLoadTypeBackWMLDeckNotAccessible'.
- 4:55 PM Changeset in webkit [46967] by
-
- 4 edits3 adds in trunk
JSON.stringify replacer returning undefined does not omit object properties
https://bugs.webkit.org/show_bug.cgi?id=28118
Reviewed by George Staikos
Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.
In addition I've made the cyclic object exception have a more useful error
message.
- 4:33 PM Changeset in webkit [46966] by
-
- 21 edits24 adds in trunk
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721
Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
- WebView/WebFramePrivate.h:
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721
Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
- Interfaces/IWebFramePrivate.idl:
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721
Rewrite WML deck access control, actually works now standalone and within LayoutTests.
Added several new layout tests covering local & remote access support.
In order to detect WML task execution failures from within the WML layout tests a new
method Console::lastWMLErrorMessage() has been added, returning the last recorded WML
error message. Change WML log messages to dump to InspectorClient, just like it's done
for HTML - we used to behave like JSMessageSource, which is wrong.
Tests: http/tests/wml/access-target-domain-deny.html
http/tests/wml/access-target-path-deny.html
http/tests/wml/access-target.html
wml/access-target-deny.html
wml/access-target.html
- inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::source): Added public method to fetch the message source type. (WebCore::ConsoleMessage::message): Added public method to access the error message.
- inspector/InspectorController.h: (WebCore::InspectorController::consoleMessages): Added for Console::lastWMLErrorMessage(), to be able to crawl through the list of dumped messages.
- loader/FrameLoader.cpp: Recognize 'FrameLoadTypeBackWMLDeckNotAccessible', all guarded by ENABLE(WML). (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::loadItem):
- loader/FrameLoaderTypes.h: (WebCore::): Add new load type 'FrameLoadTypeBackWMLDeckNotAccessible', behaving like FrameLoadTypeBack plus WML specific information.
- page/Console.cpp: (WebCore::Console::addMessage): Don't dump WML messages using ChromeClient (as it's done for JSMessageSource), but go through InspectorController. (WebCore::Console::lastWMLErrorMessage): Crawl InspectorController::consoleMssages() to look up the last WML error message, if present.
- page/Console.h:
- page/Console.idl: Add "[DontEnum] DOMString lastWMLErrorMessage()".
- wml/WMLAccessElement.cpp: Store path/domain as member variables and pass them to WMLPageState once in insertedIntoDocument(). (WebCore::WMLAccessElement::parseMappedAttribute): (WebCore::WMLAccessElement::insertedIntoDocument):
- wml/WMLAccessElement.h:
- wml/WMLCardElement.cpp: Handle 'FrameLoadTypeBackWMLDeckNotAccessible' as deck-entry method. Report WML error in current deck. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- wml/WMLDocument.cpp: Enable deck-access control in finishedParsing. Take care of method name changes in WMLPageState. (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
- wml/WMLErrorHandling.cpp: Never report 'WMLErrorDeckNotAccessible' messages through the tokenizer, that would alter the page into error state. (WebCore::reportWMLError):
- wml/WMLPageState.cpp: Completly rewrote access path/domain parsing & deck-access control, strictly following the WML spec. All covered by tests. (WebCore::WMLPageState::WMLPageState): (WebCore::normalizedHostName): (WebCore::hostFromURL): (WebCore::urlForHistoryItem): (WebCore::tryAccessHistoryURLs): (WebCore::WMLPageState::processAccessControlData): (WebCore::WMLPageState::resetAccessControlData): (WebCore::WMLPageState::canAccessDeck): (WebCore::WMLPageState::hostIsAllowedToAccess): (WebCore::WMLPageState::pathIsAllowedToAccess):
- wml/WMLPageState.h:
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721
Add several new tests covering WML deck-access control.
Update variable-reference-invalid-character.html result, as console messages aren't dump to the results anymore.
- http/tests/wml/access-target-domain-deny-expected.txt: Added.
- http/tests/wml/access-target-domain-deny.html: Added.
- http/tests/wml/access-target-expected.txt: Added.
- http/tests/wml/access-target-path-deny-expected.txt: Added.
- http/tests/wml/access-target-path-deny.html: Added.
- http/tests/wml/access-target.html: Added.
- http/tests/wml/resources/access-target-domain-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- http/tests/wml/resources/access-target-domain-deny.wml: Added.
- http/tests/wml/resources/access-target-path-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- http/tests/wml/resources/access-target-path-deny.wml: Added.
- http/tests/wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- http/tests/wml/resources/access-target.wml: Added.
- http/tests/wml/resources/locked-deck.wml: Added.
- http/tests/wml/resources/unreachable-domain.wml: Added.
- http/tests/wml/resources/unreachable-path.wml: Added.
- wml/access-target-deny-expected.txt: Added.
- wml/access-target-deny.html: Added.
- wml/access-target-expected.txt: Added.
- wml/access-target.html: Added.
- wml/resources/access-target-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/access-target-deny.wml: Added.
- wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/access-target.wml: Added.
- wml/resources/locked-deck.wml: Added.
- wml/variable-reference-invalid-character-expected.txt:
- 3:04 PM Changeset in webkit [46965] by
-
- 4 edits in trunk
Reviewed by Maciej Stachowiak.
FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132
Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl.
The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between
'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'.
Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl.
- 8:41 AM Changeset in webkit [46964] by
-
- 25 edits in trunk
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722
Fix intrinsic event execution, leading to crashes.
First finish parsing the document, then execute the events. Not the other way round.
-> exposes bugs all over the WML layout tests, which relied on that quirk.
Fixes manual-tests/wml/onevent-prev.wml.
- wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
- wml/WMLDocument.h:
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722
Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.
- http/tests/wml/resources/go-task-get-method-accept-charset.js:
- http/tests/wml/resources/go-task-get-method.js:
- http/tests/wml/resources/go-task-post-method-accept-charset.js:
- http/tests/wml/resources/go-task-post-method.js:
- http/tests/wml/resources/post-data-to-server.js:
- wml/resources/WMLTestCase.js: (onloadHandler): (createStaticWMLTestCase): (createDynamicWMLTestCase): (createWMLTestCase.iframeElement.onload): (createWMLTestCase):
- wml/resources/enter-card-with-events.js: (executeTest):
- wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/go-task-get-method-external-deck-with-href.js:
- wml/resources/go-task-get-method-external-deck.js:
- wml/resources/go-task-get-method-same-deck.js:
- wml/resources/input-format.js:
- wml/resources/newcontext-same-deck.js: (setupTestDocument): (executeTest):
- wml/resources/onenterforward-event.js: (executeTest):
- wml/resources/onenterforward-inline-event.js:
- wml/resources/ontimer-event.js: (executeTest):
- wml/resources/ontimer-inline-event.js: (executeTest):
- wml/resources/option-element-onpick.js:
- wml/resources/select-element-variables.js:
- wml/resources/variable-reference-invalid-character.js:
- wml/resources/variable-reference-valid.js:
- 3:33 AM Changeset in webkit [46963] by
-
- 8 edits in trunk
[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114
Reviewed by Eric Seidel and Sam Weinig.
Implement getPrototypeOf
Aug 8, 2009:
- 6:36 PM Changeset in webkit [46962] by
-
- 1 edit in trunk/WebCore/ChangeLog
Updated ChangeLog with bug URLs.
- 6:31 PM Changeset in webkit [46961] by
-
- 2 edits in trunk/WebCore
2009-08-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Update WebCore.gyp to add ImageBuffer.cpp,
introduced by http://trac.webkit.org/changeset/46956.
- WebCore.gypi: Added ImageBuffer.cpp.
- 4:28 PM Changeset in webkit [46960] by
-
- 2 edits in trunk/LayoutTests
2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip media/controls-right-click-on-timebar.html as it needs
eventSender which we don't have at the moment.
- platform/gtk/Skipped:
- 3:39 PM Changeset in webkit [46959] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Jan Michael Alonzo.
Add [DontEnum] to WML specific initializeWMLPageState/resetWMLPageState methods, to assure
fast/dom/Window/window-properties.html doesn't show any differences when WML is enabled.
- 1:34 PM Changeset in webkit [46958] by
-
- 2 edits in trunk/WebCore
2009-08-08 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711
Adds the filter effect feColorMatrix to SVG filters.
There is already a test in the w3c directory.
Test: svg/W3C-SVG-1.1/filters-color-01-b.svg
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix): (WebCore::saturate): (WebCore::huerotate): (WebCore::luminance): (WebCore::FEColorMatrix::apply):
- 12:32 PM Changeset in webkit [46957] by
-
- 2 edits in trunk/WebCore
2009-08-08 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Build fix for Tiger.
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
- 12:11 PM Changeset in webkit [46956] by
-
- 27 edits1 add in trunk/WebCore
2009-08-08 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
This is an initial implementation for linearRGB and sRGB support for all
platforms. Some platforms like Cg support different color spaces
natively, others like Qt, Cairo and Skia do not. This patch uses the
native implementation of platforms if possible and offers a common version
if not.
Different color spaces are used in SVG Filters. Nearly every Filter test
case is a test for this patch and will be enabled, once Filters are enabled.
- GNUmakefile.am:
- WebCore.pro:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/ImageBuffer.cpp: Added. (WebCore::ImageBuffer::transformColorSpace):
- platform/graphics/ImageBuffer.h: (WebCore::): (WebCore::ImageBuffer::create):
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::getEffectContext):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::scratchContext):
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- 10:13 AM Changeset in webkit [46955] by
-
- 2 edits3 deletes in trunk
WebCore:
2009-08-08 Xan Lopez <xlopez@igalia.com>
Roll out r46928, since it wasn't done in accordance with the
agreed naming.
- bindings/gdom/GdomDOMObject.cpp: Removed.
WebKit/gtk:
2009-08-08 Xan Lopez <xlopez@igalia.com>
Roll out r46928, since it wasn't done in accordance with the
agreed naming.
- ChangeLog:
Remove the ChangeLog entry, since it was added at the bottom of
the file.
- gdom/GdomDOMObject.h: Removed.
- gdom/GdomDOMObjectPrivate.h: Removed.
- 9:01 AM Changeset in webkit [46954] by
-
- 2 edits in trunk/WebKitTools
2009-08-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060
A first pass at a --quiet option. This doesn't do all the excting
things we might want, but it addresses 80% of the use case.
- Scripts/bugzilla-tool:
- 2:29 AM Changeset in webkit [46953] by
-
- 2 edits in trunk/WebKit/qt
Doc: there is no group of explicitly shared classes, only one class uses this.
Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-08-08
Reviewed by Simon Hausmann.
Explain the implications in the QWebHistoryItem documentation, and get rid
of the "group".
- Api/qwebhistory.cpp:
- 12:39 AM Changeset in webkit [46952] by
-
- 12 edits2 adds in trunk
2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989
Add SPI to get the focused accessible element to be used by DRT.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_focused_element):
- accessibility/gtk/AccessibilityObjectWrapperAtk.h:
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_focused_accessible_element):
Remove passing accessibility tests from the Skipped list
- platform/gtk/Skipped:
Add Accessibility support to the GTK DRT.
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::childrenCount): (AccessibilityUIElement::elementAtPoint): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfDocumentLinks): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::parameterizedAttributeNames): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::language): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::attributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
- GNUmakefile.am:
Aug 7, 2009:
- 11:08 PM Changeset in webkit [46951] by
-
- 2 edits in trunk/WebCore
Gtk build fix - add html/canvas to the binding generator's include path
- 10:17 PM Changeset in webkit [46950] by
-
- 1 edit3 adds in trunk/LayoutTests
Test function declaration parsing
Reviewed by Cameron Zwarich
- 9:42 PM Changeset in webkit [46949] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Fix the build on 10.6.
- WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]):
- 9:14 PM Changeset in webkit [46948] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Fix a stylistic nit related to the location of the *, which, for some
ridiculous reason, WebKit style dictates to be different between Objective-C and C++.
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
- 9:08 PM Changeset in webkit [46947] by
-
- 4 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Work around an issue on Leopard where composited layers are misplaced and squished when the page
gets over 4096px tall.
https://bugs.webkit.org/show_bug.cgi?id=27272
<rdar://problem/7067892> [Leopard] Composisted layers are misplaced and squished on on long pages
<rdar://problem/7068252> [Leopard] When switching to a tab with HW layers, they fade in
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Call -_updateLayerHostingViewPosition after scrolling.
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Call -_updateLayerHostingViewPosition after the view changes size.
(-[WebHTMLView attachRootLayer:]):
Turn off default animations, to avoid animations of sublayer transform, and fading-in
when tab switching.
- WebView/WebHTMLViewInternal.h: (-[WebHTMLView _updateLayerHostingViewPosition]): New method that constrains the height of the layer-hosting view to a max height of 4096px, and compensates for the height restriction by placing the layer-hosting view at the top of the visible part of the WebHTMLView, and adjusting the position of the hosted layers via sublayer transform.
- 8:31 PM Changeset in webkit [46946] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip two new tests (from r46896) needing gtk-specific results.
- platform/gtk/Skipped:
- 8:06 PM Changeset in webkit [46945] by
-
- 2 edits in trunk/WebKitSite
2009-08-07 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Oliver Hunt.
Fix webkit-jobs link
- contact.html:
- 7:33 PM Changeset in webkit [46944] by
-
- 2 edits in trunk/WebKitTools
Unreviewed Gtk build fix
- 7:22 PM Changeset in webkit [46943] by
-
- 3 edits in trunk/WebCore
Another windows build fix attempt
- 7:11 PM Changeset in webkit [46942] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 6:57 PM Changeset in webkit [46941] by
-
- 2 edits in trunk/WebCore
2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix - add html/canvas to the include path.
- GNUmakefile.am:
- 6:43 PM Changeset in webkit [46940] by
-
- 2 edits in trunk/WebCore
Prospective build fix for Qt following r46937.
Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-07
- WebCore.pro:
- 6:25 PM Changeset in webkit [46939] by
-
- 2 edits in trunk/WebCore
2009-08-07 Yong Li <yong.li@torchmobile.com>
WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
https://bugs.webkit.org/show_bug.cgi?id=27734
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::advanceData): (WebCore::GlyphBuffer::add):
- 6:24 PM Changeset in webkit [46938] by
-
- 2 edits in trunk/WebCore
2009-08-07 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
WINCE PORT: pass unrecognized glyphs to GDI to handle
https://bugs.webkit.org/show_bug.cgi?id=27734
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 6:01 PM Changeset in webkit [46937] by
-
- 8 edits14 moves1 add in trunk/WebCore
Move Canvas related file to a subdirectories
https://bugs.webkit.org/show_bug.cgi?id=28026
- 5:54 PM Changeset in webkit [46936] by
-
- 2 edits in trunk/WebCore
2009-08-07 Szabo Carol <carol.szabo@nokia.com>
Reviewed by David Hyatt.
QtWebkit ignores letter-spacing and word-spacing styles.
QtWebkit handles custom letter-spacing and word-spacing in the native QFont
class, but the values for these options are not not passed on from
the platform independent part of the Font class.
Fixed QtWebkit behavior by applying the options to QFont when it is
returned via Font::font()
LayoutTests:
fast/css/word-space-extra.html
css2.1/t1604-c542-letter-sp-00-b-a.html
css2.1/t1604-c541-word-sp-01-b-a.html
css1/text_properties/word_spacing.html
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
- 5:52 PM Changeset in webkit [46935] by
-
- 3 edits in trunk/WebCore
2009-08-07 Nicolas Weber <thakis@chromium.org>
Reviewed by Darin Adler.
Use correct highlight color for listboxes and completion popups.
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: Rename activeListBoxSelectionBackgroundColor to platformActiveListBoxSelectionBackgroundColor, so that it actually overrides a virtual method.
- 5:48 PM Changeset in webkit [46934] by
-
- 1 edit4 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added a fourth bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988
- platform/haiku/PasteboardHaiku.cpp: Added. (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear):
- platform/haiku/PlatformKeyboardEventHaiku.cpp: Added. (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- platform/haiku/PlatformMouseEventHaiku.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/haiku/PlatformWheelEventHaiku.cpp: Added. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 5:41 PM Changeset in webkit [46933] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which are inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
- wtf/Noncopyable.h:
2009-08-07 George Staikos <george.staikos@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>
- wtf/Platform.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 5:06 PM Changeset in webkit [46932] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.
- 5:03 PM Changeset in webkit [46931] by
-
- 2 edits in trunk/WebCore
2009-08-07 Nicolas Weber <thakis@chromium.org>
Teach WebKit how to decode jpegs in cmyk and ycck color spaces.
Heavily inspired by Firefox's take on this issue.
Reviewed by Eric Seidel.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): Tell jpeglib to convert ycck to cmyk and keep cmyk. (WebCore::convertCMYKToRGBA): Added function to convert cmyk to rgb. (WebCore::convertRGBToRGBA): Extracted existing conversion logic into its own function. (WebCore::JPEGImageDecoder::outputScanlines): Call convertCMYKToRGBA for cmyk images, convertRGBToRGBA for rgb images.
- 5:03 PM Changeset in webkit [46930] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.
- 5:02 PM Changeset in webkit [46929] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Mark Rowe.
Add http/tests/misc/favicon-loads-with-images-disabled.html to get the
Windows Debug bot back green.
- platform/win/Skipped:
- 4:51 PM Changeset in webkit [46928] by
-
- 1 edit4 adds in trunk
2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792
Add frameName property to the WebKitWebNavigation object.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
- webkit/webkitwebnavigationaction.h:
- 4:34 PM Changeset in webkit [46927] by
-
- 2 edits in trunk/WebKitTools
- Scripts/commit-log-editor: Fix unchecked access to environment
variable that may not be there.
- 4:25 PM Changeset in webkit [46926] by
-
- 16 edits2 moves1 add5 deletes in trunk/LayoutTests
"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=28086
Patch by Darin Adler <Darin Adler> on 2009-08-07
Reviewed by Adele Peterson.
Rewrite tests that depend on selection inside <input> and <textarea> elements
from showing up with getSelection(), since does not match Firefox and needs to
change soon.
- editing/deleting/delete-ligature-002-expected.txt: Updated.
- editing/deleting/delete-ligature-002.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/deleting/delete-ligature-003-expected.txt: Updated.
- editing/deleting/delete-ligature-003.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/deleting/skip-virama-001-expected.txt: Updated.
- editing/deleting/skip-virama-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/input/textarea-arrow-navigation-expected.txt: Moved to fast/forms.
- editing/input/textarea-arrow-navigation.html: Ditto.
- editing/inserting/insert-thai-characters-001-expected.txt: Updated.
- editing/inserting/insert-thai-characters-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/selection/5213963-expected.txt: Added. This is now a text-only test.
- editing/selection/5213963.html: Added a call to dumpAsText(). Changed selection
testing to use selectionEnd instead of getSelection().type.
- editing/selection/find-in-text-control-expected.txt: Updated.
- editing/selection/find-in-text-control.html: Changed test to distinguish the
different text controls. Made it use activeElement to find out if the selection
is inside a control.
- editing/selection/move-begin-end-expected.txt: Updated.
- editing/selection/move-begin-end.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/text-iterator/thai-cursor-movement-expected.txt: Updated.
- editing/text-iterator/thai-cursor-movement.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- fast/forms/textarea-arrow-navigation-expected.txt: Moved from editing/input since
this is a <textarea> test, not a general editing test.
- fast/forms/textarea-arrow-navigation.html: Ditto.
Changed to use eventSender instead of the editing machinery to test the down arrow.
- platform/mac/editing/selection/5213963-expected.checksum: Removed.
This is now a text-only test.
- platform/mac/editing/selection/5213963-expected.png: Ditto.
- platform/mac/editing/selection/5213963-expected.txt: Ditto.
- platform/qt/editing/selection/5213963-expected.txt: Ditto.
- platform/win/editing/selection/5213963-expected.txt: Ditto.
- 4:24 PM Changeset in webkit [46925] by
-
- 6 edits2 adds in trunk
WebCore:
2009-08-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058
Added tracking of shared workers to the SharedWorkerRepository.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::create): Changed SharedWorkerProxy to derive from ThreadSafeShared, as it needs to outlive the repository (if closed while some documents are still loading). (WebCore::SharedWorkerProxy::thread): (WebCore::SharedWorkerProxy::closing): Added flag used to determine whether the worker has closed itself while loading. (WebCore::SharedWorkerProxy::url): (WebCore::SharedWorkerProxy::name): Proxy now tracks worker URL and name to allow validity checks per section 4.8.3 of the WebWorkers spec. (WebCore::SharedWorkerProxy::SharedWorkerProxy): (WebCore::SharedWorkerProxy::addToDocumentSet): Added API to track the document set for a worker to allow worker shutdown. Currently does nothing. (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Renamed SharedWorkerLoader to be SharedWorkerScriptLoader for clarity. (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerScriptLoader::notifyFinished): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Now handles "worker already loaded" case. (WebCore::SharedWorkerRepository::connect): Delegates to DefaultSharedWorkerRepository::connectToWorker (WebCore::DefaultSharedWorkerRepository::connectToWorker): Added code to track the SharedWorkerProxy in a map, and to handle the "worker already loaded" case. (WebCore::DefaultSharedWorkerRepository::getProxy): Atomic get-or-create operation on the internal tracking HashMap.
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/SharedWorkerRepository.h: Removed instance() API and made constructor private to prevent instantiation. (WebCore::SharedWorkerRepository::SharedWorkerRepository):
LayoutTests:
2009-08-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058
Added tracking to the SharedWorkerRepository so instances of SharedWorkers are shared across pages.
- fast/workers/shared-worker-shared-expected.txt: Added.
- fast/workers/shared-worker-shared.html-disabled: Added sharing test.
- 4:14 PM Changeset in webkit [46924] by
-
- 1 edit4 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added four Haiku-specific files for WebCore:
PopupMenuHaiku.cpp, ScreenHaiku.cpp,
SearchPopupMenuHaiku.cpp and SoundHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080
- platform/haiku/PopupMenuHaiku.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/haiku/ScreenHaiku.cpp: Added. (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
- platform/haiku/SearchPopupMenuHaiku.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/haiku/SoundHaiku.cpp: Added. (WebCore::systemBeep):
- 4:14 PM Changeset in webkit [46923] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added two Haiku-specific files to WebCore:
TemporaryLinkStubs.cpp and WidgetHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080
- platform/haiku/TemporaryLinkStubs.cpp: Added. (loadResourceIntoArray): (WebCore::historyContains): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::callOnMainThread): (WebCore::SharedBuffer::createWithContentsOfFile): (WebCore::KURL::fileSystemPath): (WebCore::getSupportedKeySizes):
- platform/haiku/WidgetHaiku.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
- 4:12 PM Changeset in webkit [46922] by
-
- 4 edits in trunk/WebCore
2009-08-07 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix the problem that isAttribute is set to false for onerror and
onmessage in worker custom code.
https://bugs.webkit.org/show_bug.cgi?id=28083
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER):
- 4:11 PM Changeset in webkit [46921] by
-
- 3 edits in trunk/WebCore
2009-08-07 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>
Reviewed by Dimitri Glazkov.
V8 bindings: speed up lookupDOMWrapper by using new V8 API function.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
- 4:05 PM Changeset in webkit [46920] by
-
- 5 edits8 adds in trunk
WebCore: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch modifies selectionHasStyle so that it returns TrueTriState when text styles
(text-decoration, font-style, font-weight, & color) are present in all text nodes,
regardless of whether the style is also present in their ancestor nodes or not.
e.g. New behavior concludes that <b><i>hello</i><i>world</i></b> has italic style.
WebKit now applies the text styles (bold, italic, etc) if the specified style was not present on
at least one text node, rather than at the beginning of selection except on Mac.
On Mac, WebKit applies the text style if the style was not present at the beginning of style.
Test: editing/execCommand/toggle-compound-styles.html
- editing/ApplyStyleCommand.cpp:
(WebCore::getPropertiesNotInComputedStyle): bug fix, must use copy instead of makeMutable for a mutable style.
- editing/Editor.cpp:
(WebCore::):
(WebCore::triStateOfStyleInComputedStyle): Added a boolean type to ignore text-specific styles
(WebCore::Editor::selectionHasStyle): Ignores text-specific styles for all but text nodes
- editing/EditorCommand.cpp:
(WebCore::executeToggleStyle): Uses selectionHasStyle instead of selectionStartHasStyle
LayoutTests: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch adds toggle-compound-styles to make sure WebKit can handle nested text styles
such as <b><i>hello</i>world</b> (italicized) and <b><i>hello</i>world</b> (not italicized)
on all platforms except on Mac (to match TextEdit's behavior).
- editing/execCommand/resources/toggle-compound-styles.js: Added.
(testSingleToggle):
- editing/execCommand/toggle-compound-styles.html: Added.
- platform/gtk/editing/execCommand: Added.
- platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/win/editing/execCommand: Added.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- 3:36 PM Changeset in webkit [46919] by
-
- 2 edits in trunk/WebCore
2009-08-07 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=28082
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- 3:25 PM Changeset in webkit [46918] by
-
- 2 edits in trunk/WebCore
2009-08-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Cairo-based Windows port does not handle cookies properly
https://bugs.webkit.org/show_bug.cgi?id=27414
curl handles cookies by itself, so using WinINet functions
to get and set cookies is wrong.
Replace CookieJarWin.cpp with CookieJarCurl.cpp so that
cookies can be implemented later once curl provides an API to
get and set cookies.
- WebCore.vcproj/WebCore.vcproj:
- 3:09 PM Changeset in webkit [46917] by
-
- 9 edits1 add in trunk/WebCore
2009-08-07 Michael Nordman <Michael Nordman>
Reviewed by Dimitri Glazkov.
V8 bindings for the window.applicationCache attribute.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Added.
- 2:41 PM Changeset in webkit [46916] by
-
- 4 edits in trunk/LayoutTests
2009-08-07 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Fix three tests so they are not dependent on the getSelection() result
reflecting selections inside <input> and <textarea> elements.
- fast/events/right-click-focus.html: Removed unneeded check of anchorNode. The test works fine by just testing the actual result of typing.
- fast/forms/focus-style-pending.html: Detect focus with an onfocus attribute rather than by looking at getSelection().focusNode.
- fast/forms/search-click-in-placeholder.html: Detect focus with an onfocus attribute rather than by looking at getSelection().baseNode.
- 2:39 PM Changeset in webkit [46915] by
-
- 3 edits2 adds in trunk
WebCore: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920
Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.
Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.
- media/controls-right-click-on-timebar-expected.txt: Added.
- media/controls-right-click-on-timebar.html: Added.
LayoutTests: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920
Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.
Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.
- media/controls-right-click-on-timebar-expected.txt: Added.
- media/controls-right-click-on-timebar.html: Added.
- 2:36 PM Changeset in webkit [46914] by
-
- 13 edits in trunk/WebCore
deprecatedCopyInheritableProperties must be replaced by two different functions
https://bugs.webkit.org/show_bug.cgi?id=28057
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch deletes deprecatedInheritableProperties and modifies call callees to call either editingStyleAtPosition
or prepareEditingStyleToApplyAt. The concept of editing style is introduced in this patch,
which consists of all CSS properties need to be preserved under editing operations.
No test is added since this patch does not change any behavior.
- css/CSSComputedStyleDeclaration.cpp: Removed deprecatedCopyInheritableProperties
- css/CSSComputedStyleDeclaration.h: Removed deprecatedCopyInheritableProperties
- editing/ApplyStyleCommand.cpp:
(WebCore::):
(WebCore::editingStyleAtPosition): Obtains the editing-specific computed style at the position
(WebCore::prepareEditingStyleToApplyAt): Removes redundant editing styles at the specified position
(WebCore::removeStylesAddedByNode): Removes the style derived from the specified node
- editing/ApplyStyleCommand.h:
(WebCore::):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Uses editingStyleAtPosition
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses editingStyleAtPosition
- editing/DeleteSelectionCommand.cpp:
(WebCore::removeEnclosingAnchorStyle): Uses removeStyleOfNode
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Uses editingStyleAtPosition
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Uses prepareEditingStyleToApplyAt
- editing/EditCommand.cpp:
- editing/EditCommand.h:
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Uses editingStyleAtPosition
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Uses prepareEditingStyleToApplyAt
- editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply): Uses editingStyleAtPosition
- editing/ReplaceSelectionCommand.cpp:
(WebCore::handleStyleSpansBeforeInsertion): Uses editingStyleAtPosition
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Uses editingStyleAtPosition and prepareEditingStyleToApplyAt
(WebCore::ReplaceSelectionCommand::doApply): Uses prepareEditingStyleToApplyAt
- editing/markup.cpp:
(WebCore::removeEnclosingMailBlockquoteStyle): Uses removeStyleOfNode
(WebCore::removeDefaultStyles): Uses prepareEditingStyleToApplyAt
(WebCore::createMarkup): Uses editingStyleAtPosition
- 2:36 PM Changeset in webkit [46913] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Another try at making the gc-9.html test less prone to intermittent failure.
- fast/dom/gc-9.html: Changed this to do the "before garbage collection" test right after setting the properties. This practically eliminates the possibility that we will get unlucky and get a garbage collection between when theproperty is set and tested, which seems to have happened at least once on the buildbot.
- 2:10 PM Changeset in webkit [46912] by
-
- 2 edits in trunk/WebKitTools
Handle the case where only a single test is missing results.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2:07 PM Changeset in webkit [46911] by
-
- 3 edits3 adds in trunk/JavaScriptCore
2009-08-07 George Staikos <george.staikos@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>
- wtf/Platform.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 1:19 PM CreatingLayoutTests created by
- Initial Version
- 1:15 PM Changeset in webkit [46910] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Add inline to help winscw compiler resolve specialized argument in
templated functions.
- runtime/LiteralParser.cpp: (JSC::LiteralParser::Lexer::lexString):
- 1:09 PM Changeset in webkit [46909] by
-
- 3 edits in trunk/LayoutTests
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Move fast/forms/menulist-style-color.html to Skipped list for mac/win.
Bug filed - https://bugs.webkit.org/show_bug.cgi?id=28079
- platform/mac/Skipped:
- platform/win/Skipped:
- 12:52 PM Changeset in webkit [46908] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Anders Carlsson <andersca@apple.com>
Fix Tiger build.
- WebView/WebRenderNode.mm: (-[WebRenderNode _initWithCoreFrame:]):
- 12:51 PM Changeset in webkit [46907] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for RegExpObjectData struct
http://bugs.webkit.org/show_bug.cgi?id=26750
Inherits RegExpObjectData struct from FastAllocBase because
it has been instantiated by 'new' in JavaScriptCore/runtime/RegExpObject.cpp:62
- runtime/RegExpObject.h:
- 12:28 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:27 PM Changeset in webkit [46906] by
-
- 4 edits2 deletes in trunk/WebCore
2009-08-07 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Bug 27250: Geolocation callback function IDL files are superfluous
https://bugs.webkit.org/show_bug.cgi?id=27250
The objects for the Geolocation success and error callbacks are created 'manually' in
WebCore/bindings/js/JSGeolocationCustom.cpp. Furthermore, the callback interfaces are
marked 'NoInterfaceObject' in the W3C spec, so the prototype should not
appear on the window object. Hence IDL files for these callbacks are not required.
See http://www.w3.org/TR/geolocation-API/#geolocation_interface and
http://www.w3.org/TR/WebIDL/#NoInterfaceObject.
No new tests required.
- DerivedSources.make: Modified. Removed reference to IDL files.
- WebCore.gypi: Modified. Removed reference to IDL files.
- WebCore.xcodeproj/project.pbxproj: Modified. Removed reference to IDL files.
- page/PositionCallback.idl: Removed.
- page/PositionErrorCallback.idl: Removed.
- 12:17 PM Changeset in webkit [46905] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 George Wright <george.wright@torchmobile.com>
Reviewed by Adam Treat.
Fix DumpRenderTree for the Qt port to always dump the
PNG data unless the expected and actual hashes match.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dump):
- 11:51 AM Changeset in webkit [46904] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add Test results for mac and windows for new tests.
- platform/mac/fast/forms/text-style-color-expected.txt: Added.
- platform/win/fast/forms/text-style-color-expected.txt: Added.
- 11:51 AM Changeset in webkit [46903] by
-
- 1 edit2 adds in trunk
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.
- html/TimeRanges.idl:
- 11:38 AM Changeset in webkit [46902] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=28076
Add fast/images/icon-decoding.html to Qt skip list until it has
results.
Reviewed by Adam Treat.
- platform/qt/Skipped:
- 11:36 AM Changeset in webkit [46901] by
-
- 3 edits in trunk/WebKit/mac
2009-08-07 Anders Carlsson <andersca@apple.com>
Reviewed by Timothy Hatcher and Sam Weinig.
Change WebRenderNode to take a WebFrame instead of a WebFrameView.
- WebView/WebRenderNode.h:
- WebView/WebRenderNode.mm: (-[WebRenderNode _initWithName:position:rect:coreFrame:children:]): (copyRenderNode): (-[WebRenderNode _initWithCoreFrame:]): (-[WebRenderNode initWithWebFrame:]):
- 11:17 AM Changeset in webkit [46900] by
-
- 2 edits in trunk/WebCore
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.
- html/TimeRanges.idl:
- 11:14 AM Changeset in webkit [46899] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
commit-log-editor does not produce a git commit log that is git friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754
We make sure we end up with:
- A first paragraph describing the bug. It is eventually prefixed by "WebKit: <line>" or "WebCore: <line>". This used to be "WebCore:\n\n<line>".
- The Reviewed By line.
- An eventual Patch By line if author and committer doesn't match.
- The rest of the commit.
- Scripts/commit-log-editor:
- 10:56 AM Changeset in webkit [46898] by
-
- 1 edit in trunk/WebKitTools/Scripts/run-webkit-unittests
Make run-webkit-unittests executable.
- 10:37 AM Changeset in webkit [46897] by
-
- 2 edits in trunk/WebCore
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by George Staikos.
Coding style patches for RenderThemeQt.cpp based on results from cpp_style.py.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::baselinePosition): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::applyTheme):
- 10:37 AM Changeset in webkit [46896] by
-
- 4 edits4 adds in trunk
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.
Add new tests and remove tests from platform/qt/Skipped that now pass.
- fast/forms/menulist-style-color.html: Added.
- fast/forms/text-style-color.html: Added.
- platform/qt/Skipped:
- platform/qt/fast/forms/menulist-style-color-expected.txt: Added.
- platform/qt/fast/forms/text-style-color-expected.txt: Added.
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.
Add tests and remove tests from platform/qt/Skipped that now pass.
Tests: fast/forms/menulist-style-color.html
fast/forms/text-style-color.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::adjustMenuListStyle): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
- 10:22 AM Changeset in webkit [46895] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 Adam Barth <abarth@webkit.org>
Unreviewed. (Darin Adler indicated he'd prefer if we landed these
kinds of changes unreviewed, like editing the WebKit Team wiki page.)
Added Pierre d'Herbemont to list of committers.
- Scripts/modules/committers.py:
- 9:15 AM QtWebKitTodo edited by
- (diff)
- 8:57 AM Changeset in webkit [46894] by
-
- 5 edits in trunk/WebCore
2009-08-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=22495
[V8] Re-land http://trac.webkit.org/changeset/46821, now that
http://trac.webkit.org/changeset/46874 re-landed
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:52 AM Changeset in webkit [46893] by
-
- 3 edits in trunk/WebCore
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler and George Staikos.
Add rectToRect convenience function which returns the TransformationMatrix
which maps the 'from' rectangle to the 'to' rectangle.
No tests as this would require binding the method to js and since it is static
that doesn't seem possible. Please check the math.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rectToRect):
- platform/graphics/transforms/TransformationMatrix.h:
- 8:35 AM Changeset in webkit [46892] by
-
- 10 edits2 adds in trunk
WebCore:
2009-08-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605
Test: fast/loader/hashchange-event.html
- dom/EventNames.h: Add "hashchange"
- html/HTMLAttributeNames.in: Add "onhashchange"
- loader/FrameLoader.cpp: (WebCore::HashChangeEventTask::create): (WebCore::HashChangeEventTask::performTask): (WebCore::HashChangeEventTask::HashChangeEventTask): (WebCore::FrameLoader::scrollToAnchor): When an anchor navigation is completed and the new fragment identifier is different from the old one, queue a hash change event on the Document.
Add a window event listener for the hashchange event if onhashchange is encountered:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
Add a new string utility method that gives "null and empty are equivalent" behavior:
- platform/text/PlatformString.h: (WebCore::equalIgnoringNullity):
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringNullity):
- platform/text/StringImpl.h:
LayoutTests:
2009-08-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605
- fast/loader/hashchange-event-expected.txt: Added.
- fast/loader/hashchange-event.html: Added.
- 7:57 AM Changeset in webkit [46891] by
-
- 7 edits in trunk/WebCore
2009-08-07 Jessie Berlin <jberlin@apple.com>
Add the initial implementation of the ability to resize the columns in
a DataGrid in the Web Inspector. Enables that functionality in both the
Profile View and in the Local Storage View.
Reviewed by Timothy Hatcher.
In this version, resizing a column can change the width of at most two
columns (the columns to the left and right of the resizer being dragged).
Possible changes in future patches:
1) Be able to specify the minimum size of a column and the maximum size
of a column. If the minimum size is equal to the maximum size, the
column can't be resized.
2) Make the behavior more in line with the following description:
Everything before the column that is resized stays fixed size. The
resized column changes sizes. The other columns except the last stay
the same size. And the last column adjusts to fit with a minimum size.
If the last column is already the minimum, the next to last column
shrinks, etc.
3) Make it possible to scale the column sizes appropriately when the
Web Inspector window gets resized.
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): Once the DataGrid is added to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.DOMStorageItemsView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): Store column groups whose widths can later be changed when the columns are resized by the user. Also, keep track of whether the widths of the columns have been initialized. (WebInspector.DataGrid.prototype.updateWidths): Create the resizers for the columns. (WebInspector.DataGrid.prototype._clickInDataTable): Didn't actually change anything in this method, just added a comma to the end of the function. (WebInspector.DataGrid.prototype._startResizerDragging): Store the resizer that is currently dragging. (WebInspector.DataGrid.prototype._resizerDragging): Constrain the area that the resizer can be dragged to the column to it's left and right, with some padding added to make sure that the neighboring columns don't disappear. (WebInspector.DataGrid.prototype._endResizerDragging):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.resize): Resize the view. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): ditto.
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.show): Now that the DataGrid is actually attached to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.ProfileView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.resize): Resize the view. (WebInspector.ProfilesPanel.prototype._updateSidebarWidth): ditto.
- inspector/front-end/inspector.css: Add in a style rule for a resizer in the Data Grid.
- 3:56 AM UsingGitWithWebKit edited by
- (diff)
- 3:22 AM WebKit Team edited by
- Fix my entry (diff)
- 2:55 AM Changeset in webkit [46890] by
-
- 5 edits in trunk/WebCore
2009-08-07 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Back out r46847 and fix the Qt build system to always generate
all the JS binding files from IDL files. The generated files
have #if feature guards, so the #ifs are not needed in the
files using them.
- WebCore.pro:
- bindings/js/JSEventTarget.cpp:
- bindings/js/JSWorkerContextBase.cpp:
- bindings/js/WorkerScriptController.cpp:
- 2:44 AM WebKit Team edited by
- Add my entry. (diff)
- 1:21 AM WebKit Team edited by
- Add my entry. (diff)
- 12:32 AM Changeset in webkit [46889] by
-
- 7 edits3 adds in trunk
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
- fast/reflections/reflection-overflow-scroll-expected.txt: Added.
- fast/reflections/reflection-overflow-scroll.html: Added.
- fast/reflections/resources/reflection-overflow-scroll.js: Added.
- platform/mac/fast/reflections/reflection-nesting-expected.txt:
- platform/mac/fast/repaint/reflection-redraw-expected.txt:
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
Test: fast/reflections/reflection-overflow-scroll.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
- Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo
w-scroll.js
Aug 6, 2009:
- 11:53 PM WebKit Team edited by
- add janm to the team! (diff)
- 11:53 PM Changeset in webkit [46888] by
-
- 5 edits4 adds in trunk
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
- fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
- fast/box-shadow/box-shadow-overflow-scroll.html: Added.
- fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
Test: fast/box-shadow/box-shadow-overflow-scroll.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
- Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
- 11:44 PM HackingGtk edited by
- Add l10n, docs and tests folder; Removed unused backends and … (diff)
- 11:14 PM Changeset in webkit [46887] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Copy expected (txt only) result from Mac for
fast/images/icon-decoding.html from r46871 since we seem to pass this
test as well.
- platform/gtk/fast/images/icon-decoding-expected.txt: Copied from LayoutTests/platform/mac/fast/images/icon-decoding-expected.txt.
- 10:51 PM Changeset in webkit [46886] by
-
- 2 edits in trunk/WebCore
2009-08-06 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"
- 10:39 PM Changeset in webkit [46885] by
-
- 4 edits in trunk/WebCore
2009-08-06 Yusuke Sato <yusukes@chromium.org>
Reviewed by David Levin.
Chromium Linux: add support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=28015
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
Modified #ifdefs so that chromium linux can load remote fonts.
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
Create SkTypeface for a web font by calling SkTypeface::CreateFromStream function.
(WebCore::RemoteFontStream::RemoteFontStream):
(WebCore::RemoteFontStream::~RemoteFontStream):
(WebCore::RemoteFontStream::rewind):
(WebCore::RemoteFontStream::read):
New class that implements SkStream interface and wraps wtf's SharedBuffer.
- platform/graphics/chromium/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):
Added member variables for Linux.
- 10:09 PM Changeset in webkit [46884] by
-
- 2 edits in trunk/WebCore
2009-08-06 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Fix JPEGImageDecoder.cpp compile error on WinCE
https://bugs.webkit.org/show_bug.cgi?id=28051
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 9:45 PM Changeset in webkit [46883] by
-
- 1 edit1 add in trunk/WebKit/wx
Reviewed by Eric Seidel.
Adding support for building wx Python bindings using the waf build system.
https://bugs.webkit.org/show_bug.cgi?id=27619
- 9:24 PM Changeset in webkit [46882] by
-
- 1 edit1 add in trunk/WebCore
Reviewed by Eric Seidel.
Adding WebCore support for the waf build system for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
- 9:11 PM Changeset in webkit [46881] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-06 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Updated patch for bug #27059:
Symbian platform always uses little endian encoding,
regardless of compiler.
We need to make sure that we correctly detect EABI architecture
for armv5 targets on Symbian,
where EABI is set but not ARM_EABI
- wtf/Platform.h:
- 8:30 PM Changeset in webkit [46880] by
-
- 7 edits in trunk
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- wtf/Noncopyable.h:
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- platform/graphics/wince/GraphicsContextWince.cpp:
WebKit/win:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- COMPropertyBag.h:
- 8:05 PM Changeset in webkit [46879] by
-
- 14 edits in trunk/JavaScriptCore
2009-08-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )
This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
- bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/CodeBlock.h:
(JSC::):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::seenOnce):
(JSC::StructureStubInfo::setSeen):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::unlinkCall):
- Remove the "don't lazy link" stage of calls.
- jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- Remove the "don't lazy link" stage of calls.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- Remove the "don't lazy link" stage of calls.
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITStubs::):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
(WTF::PtrAndFlags::operator!):
(WTF::PtrAndFlags::operator->):
- Add ! and -> operators, add constuctor with pointer argument.
- 6:56 PM Changeset in webkit [46878] by
-
- 7 edits in trunk/WebCore
2009-08-06 Chris Fleizach <Chris Fleizach>
Reviewed by Eric Seidel.
Bug 27956 - AX: roleValue should be cached for performance
https://bugs.webkit.org/show_bug.cgi?id=27956
Caches the role value of an accessibility object instead of calculating it everytime.
The changes gained a 5% speedup using VoiceOver to navigate a webpage.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAriaRoleChanged):
Use generic role setter instead of specific ARIA role setter.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::AccessibilityObject):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::headingLevel):
Make headingLevel into instance method so that it can *safely* be called in the constructor.
(WebCore::AccessibilityObject::setRoleValue):
(WebCore::AccessibilityObject::roleValue):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): (WebCore::AccessibilityRenderObject::headingLevel): (WebCore::AccessibilityRenderObject::intValue): (WebCore::AccessibilityRenderObject::updateAccessibilityRole): (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetHeadingLevel):
- 6:09 PM Changeset in webkit [46877] by
-
- 6 edits in trunk
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
- wtf/Noncopyable.h:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879
Since Noncopyable is inherited from FastAllocBase, Noncopyable's
inheriting has been changed to public.
- platform/graphics/wince/GraphicsContextWince.cpp:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879
Since Noncopyable is inherited from FastAllocBase,
Noncopyable's inheriting has been changed to public.
- COMPropertyBag.h:
- 5:59 PM Changeset in webkit [46876] by
-
- 8 edits in trunk
Add explicit dependencies for our build verification scripts to ensure that they always run after linking has completed.
Rubber-stamped by Sam Weinig.
- 5:59 PM Changeset in webkit [46875] by
-
- 2 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Make the test a little more sloppy to try to fix sporadic failures on Windows.
- animations/play-state.html:
- 5:32 PM Changeset in webkit [46874] by
-
- 17 edits2 copies3 adds in trunk
2009-08-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495
Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.
Test: fast/media/matchmedium-query-api.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Add Media.* files to the build.
- css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
- css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
- css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::media):
- page/DOMWindow.h:
- page/DOMWindow.idl: Add a readonly attribute for Media.
- 5:28 PM Changeset in webkit [46873] by
-
- 3 edits in trunk/LayoutTests
2009-08-06 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- fast/dom/gc-9-expected.txt: Generated new results.
- fast/dom/gc-9.html: Turned off tests that are unpredictable based on what happens during garbage collection. These do represent bugs, so we want to turn them back on again once the bugs are fixed.
- 5:27 PM Changeset in webkit [46872] by
-
- 2 edits in trunk/WebKitLibraries
2009-08-06 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27323
Strip line endings at all points auto-version.sh reads data, not just
the one I happened to run into.
- win/tools/scripts/auto-version.sh:
- 5:25 PM Changeset in webkit [46871] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-08-06 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28025
Add a test for .ico decoding.
- fast/images/icon-decoding.html: Added.
- fast/images/resources/1bit.ico: Added.
- fast/images/resources/2entries.ico: Added.
- fast/images/resources/32bit.ico: Added.
- fast/images/resources/8bit.ico: Added.
- platform/mac/fast/images/icon-decoding-expected.checksum: Added.
- platform/mac/fast/images/icon-decoding-expected.png: Added.
- platform/mac/fast/images/icon-decoding-expected.txt: Added.
- 4:46 PM Changeset in webkit [46870] by
-
- 2 edits in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::hasHTMLView): Always return true when we're in viewless mode.
- 4:45 PM Changeset in webkit [46869] by
-
- 12 edits8 adds in trunk
2009-08-06 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27455
Test suite for form controls' custom validation message.
- fast/dom/domListEnumeration-expected.txt: Corrected
- fast/dom/resources/domListEnumeration.js: Corrected
- fast/forms/ValidityState-customError-001-expected.txt: Added.
- fast/forms/ValidityState-customError-001.html: Added.
- fast/forms/ValidityState-customError-002-expected.txt: Added.
- fast/forms/ValidityState-customError-002.html: Added.
- fast/forms/ValidityState-customError-003-expected.txt: Added.
- fast/forms/ValidityState-customError-003.html: Added.
- fast/forms/ValidityState-customError-004-expected.txt: Added.
- fast/forms/ValidityState-customError-004.html: Added.
2009-08-06 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27455
Support for a custom validation message in ValidityState and related
form controls.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-cva-setcustomvalidity
Tests: fast/forms/ValidityState-customError-001.html
fast/forms/ValidityState-customError-002.html
fast/forms/ValidityState-customError-003.html
fast/forms/ValidityState-customError-004.html
- html/HTMLButtonElement.idl: setCustomValidity DOM method
- html/HTMLFieldSetElement.idl: ditto
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setCustomValidity): ditto
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): moved down
- html/HTMLInputElement.idl: ditto
- html/HTMLSelectElement.idl: ditto
- html/HTMLTextAreaElement.idl:
- html/ValidityState.h: (WebCore::ValidityState::setCustomErrorMessage): method to set custom validation message (WebCore::ValidityState::customError): validation flag
- 4:00 PM Changeset in webkit [46868] by
-
- 6 edits in trunk
Bring a little order to our otherwise out of control lives.
- 3:56 PM Changeset in webkit [46867] by
-
- 2 edits in trunk/WebCore
Stop copying .idl files in to the framework resources directory.
- WebCore.xcodeproj/project.pbxproj:
- 3:51 PM Changeset in webkit [46866] by
-
- 2 edits in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Remove WebGraphicsExtras.h include.
- Plugins/WebNetscapePluginView.mm:
- 3:51 PM Changeset in webkit [46865] by
-
- 2 edits in trunk/WebCore
Fix the build some more.
Add JSWebSocket.cpp and JSWebSocket.h to the Xcode project, and move the WebSocket-related
files and groups in to the appropriate locations.
- WebCore.xcodeproj/project.pbxproj:
- 3:38 PM Changeset in webkit [46864] by
-
- 2 edits in trunk/WebKit
Build fix.
Don't attempt to build a file that Anders just deleted.
- WebKit.xcodeproj/project.pbxproj:
- 3:30 PM Changeset in webkit [46863] by
-
- 4 edits7 adds in trunk/WebCore
2009-08-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209
Add WebSocket.idl in WebCore/websockets/.
Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebSocketConstructor.cpp: Added.
- bindings/js/JSWebSocketConstructor.h: Added.
- bindings/js/JSWebSocketCustom.cpp: Added.
- websockets/WebSocket.cpp: Added.
- websockets/WebSocket.h: Added.
- websockets/WebSocket.idl: Added.
- 3:08 PM Changeset in webkit [46862] by
-
- 1 edit2 deletes in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove WebGraphicsExtras, it is no longer used.
- Misc/WebGraphicsExtras.c: Removed.
- Misc/WebGraphicsExtras.h: Removed.
- 2:57 PM Changeset in webkit [46861] by
-
- 2 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Fix a test in http/tests/media that was missed in the earlier 'media' rename.
- http/tests/media/video-play-stall.html:
- 2:41 PM Changeset in webkit [46860] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-08-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=28055
This patch converts boldSelection.html to a dumpAsText and adds description on what it tests.
Namely, it tests bolding the first 21 letters of a sentence.
Since bolding must be done by adding b tag instead of a style span, we print innerHTML of the result.
- editing/execCommand/boldSelection-expected.txt: Added.
- editing/execCommand/boldSelection.html:
- platform/mac/editing/execCommand/boldSelection-expected.checksum: Removed.
- platform/mac/editing/execCommand/boldSelection-expected.png: Removed.
- platform/mac/editing/execCommand/boldSelection-expected.txt: Removed.
- platform/qt/editing/execCommand/boldSelection-expected.txt: Removed.
- 2:38 PM BuildingQtOnWindows edited by
- (diff)
- 2:29 PM Changeset in webkit [46859] by
-
- 10 edits in trunk/WebCore
2009-08-06 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Style cleaning for WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=27997
Cleanup WorkerContextExecutioonProxy related files to follow
WebKit coding styles after all V8 binding codes are upstreamed.
1) Lower-case the first letter of remaining functins in class
WorkerContextExecutionProxy. Update the V8 code generator
and all other references accordingly.
2) Integrate getConstructor from WorkerContextExecutionProxy
to V8DOMWrapper.
3) Other misc changes, like removing trailing whitespaces and
sorting the include files.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::convertToV8Object):
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::~V8WorkerContextEventListener): (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/V8WorkerContextObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object): (WebCore::WorkerContextExecutionProxy::convertWorkerContextToV8Object): (WebCore::WorkerContextExecutionProxy::toV8): (WebCore::WorkerContextExecutionProxy::forgetV8EventObject): (WebCore::WorkerContextExecutionProxy::removeEventListener):
- bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionProxy::context): (WebCore::WorkerContextExecutionProxy::convertToV8Object):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- 2:21 PM BuildingQtOnWindows edited by
- (diff)
- 2:15 PM Changeset in webkit [46858] by
-
- 1 edit2 moves in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Move a video test from fast/media to media/, since fast/media is all about
CSS media queries.
- media/video-controls-with-mutation-event-handler-expected.txt: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler-expected.txt.
- media/video-controls-with-mutation-event-handler.html: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler.html.
- 2:09 PM Changeset in webkit [46857] by
-
- 29 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=28056
Change media tests to not use a variable in global scope with the name
'media', to avoid conflict with window.media.
- media/audio-constructor-autobuffer-expected.txt:
- media/audio-constructor-autobuffer.html:
- media/audio-constructor-src.html:
- media/audio-constructor.html:
- media/audio-data-url-expected.txt:
- media/audio-data-url.html:
- media/audio-mpeg-supported-expected.txt:
- media/audio-mpeg-supported.html:
- media/media-load-event-expected.txt:
- media/media-load-event.html:
- media/video-can-play-type.html:
- media/video-loop-expected.txt:
- media/video-loop.html:
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seek-past-end-playing.html:
- media/video-source-media.html:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-invalid-remove.html:
- media/video-src-plus-source-expected.txt:
- media/video-src-plus-source.html:
- media/video-src-source.html:
- media/video-src.html:
- media/video-test.js: (findMediaElement): (waitForEvent): (waitForEventAndTest): (relativeURL):
- media/video-timeupdate-during-playback.html:
- 1:50 PM Changeset in webkit [46856] by
-
- 3 edits in trunk/WebKitTools
2009-08-06 Eric Seidel <eric@webkit.org>
No review, only changing make-js-test-wrappers.
Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.
- Scripts/make-js-test-wrappers:
- 1:20 PM Changeset in webkit [46855] by
-
- 2 edits in trunk/WebKitTools
2009-08-06 Eric Seidel <eric@webkit.org>
No review, only changing make-js-test-wrappers.
Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.
- Scripts/make-js-test-wrappers:
- 12:17 PM Changeset in webkit [46854] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877
Inherits PolymorphicAccessStructureList struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/jit/JITStubs.cpp:1229.
- bytecode/Instruction.h:
- 11:49 AM Changeset in webkit [46853] by
-
- 2 edits in trunk/PlanetWebKit
2009-08-06 Brent Fulgham <bfulgham@webkit.org>
Rubber-stamped by Adam Barth.
Update my blog's address.
- config.ini: Update Blog address.
- 11:25 AM Changeset in webkit [46852] by
-
- 9 edits5 copies9 adds in trunk/LayoutTests
2009-08-06 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Refactored worker tests to share code with shared worker versions. Shared worker tests are currently disabled by default.
Worker layout tests should be refactored to enable testing SharedWorkers also.
https://bugs.webkit.org/show_bug.cgi?id=27963
- fast/workers/resources/shared-worker-common.js: (onconnect): (gc): (handleMessage):
- fast/workers/resources/shared-worker-create-common.js: Added. (createWorker.worker.port.onmessage): (createWorker.worker.postMessage): (createWorker):
- fast/workers/resources/worker-context-gc.js: Added. (log): (worker.onmessage):
- fast/workers/resources/worker-create-common.js: Added. (createWorker):
- fast/workers/resources/worker-location.js: Added. (log): (gc): (worker.onmessage):
- fast/workers/resources/worker-navigator.js: Added. (log): (worker.onmessage):
- fast/workers/resources/worker-replace-global-constructor.js:
- fast/workers/resources/worker-replace-self.js: Added. (log): (worker.onmessage):
- fast/workers/shared-worker-context-gc-expected.txt: Added.
- fast/workers/shared-worker-context-gc.html-disabled: Added.
- fast/workers/shared-worker-location-expected.txt: Added.
- fast/workers/shared-worker-location.html-disabled: Added.
- fast/workers/shared-worker-navigator-expected.txt: Added.
- fast/workers/shared-worker-navigator.html-disabled: Added.
- fast/workers/shared-worker-replace-global-constructor.html-disabled:
- fast/workers/shared-worker-replace-self-expected.txt: Added.
- fast/workers/shared-worker-replace-self.html-disabled: Added.
- fast/workers/worker-context-gc.html:
- fast/workers/worker-location.html:
- fast/workers/worker-navigator.html:
- fast/workers/worker-replace-global-constructor.html:
- fast/workers/worker-replace-self.html:
- 11:02 AM Changeset in webkit [46851] by
-
- 2 edits in trunk/WebCore
2009-08-06 Darin Adler <Darin Adler>
Fix Mac Leopard debug build.
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase): Removed meaningless assertion; an unsigned is always >= 0 and checking causes a warning in the newer versions of gcc.
- 9:43 AM Changeset in webkit [46850] by
-
- 10 edits4 deletes in trunk
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreview rollout.
Revert 46840 because it broke the reliability tests.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
LayoutTests:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed rollout.
Revert 46840 because it broke the reliability tests.
- http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-function.html: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-string.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:43 AM Changeset in webkit [46849] by
-
- 3 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed rollout.
Revert 46840 in preparation to revert 46838, which broke the reliability tests.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::context):
- 9:37 AM Changeset in webkit [46848] by
-
- 5 edits in trunk/WebCore
2009-08-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: move style-related utilities into InjectedScript.
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
- inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript._serializeStyle): (InjectedScript._getUniqueStyleProperties): (InjectedScript._getLonghandProperties): (InjectedScript._getShorthandPriority):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/utilities.js:
- 8:58 AM Changeset in webkit [46847] by
-
- 4 edits in trunk/WebCore
2009-08-06 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix, add #ifdef guards around
inclusions of shared worker specific files.
- bindings/js/JSEventTarget.cpp:
- bindings/js/JSWorkerContextBase.cpp:
- bindings/js/WorkerScriptController.cpp:
- 8:57 AM Changeset in webkit [46846] by
-
- 4 edits in trunk/WebCore
2009-08-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
cssgrammar.cpp fails to compile with RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=27952
- css/CSSGrammar.y: Do not convert to String to get rid of the stray memory allocation
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase):
- platform/text/StringImpl.h: (WebCore::equalIgnoringCase): Add charactersEqualIgnoringCase function that works with a character pointer and length
- 8:30 AM Changeset in webkit [46845] by
-
- 30 edits9 copies13 adds in trunk
WebCore:
2009-08-01 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (OOPS!).
Created first working implementation of SharedWorkers (execution only, no sharing).
https://bugs.webkit.org/show_bug.cgi?id=27927
Added initial implementations of SharedWorkerThread and SharedWorkerContext.
No v8 bindings yet.
- DerivedSources.cpp: Added shared worker files.
- DerivedSources.make: Added shared worker files.
- GNUmakefile.am: Added shared worker files.
- WebCore.gypi: Added shared worker files.
- WebCore.pro: Added shared worker files.
- WebCore.vcproj/WebCore.vcproj: Added shared worker files.
- WebCore.xcodeproj/project.pbxproj: Added shared worker files.
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added code to convert from EventTarget to correct JS class. (WebCore::toEventTarget): Added code to cast from JS object to appropriate EventTarget impl class.
- bindings/js/JSSharedWorkerConstructor.cpp: (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): Tweaked the constructor code to pass in the lexical global object like normal workers.
- bindings/js/JSSharedWorkerContextCustom.cpp: Added. (WebCore::JSSharedWorkerContext::mark): Custom marking of the onconnect handler.
- bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSSharedWorkerContext): (WebCore::toJSWorkerContext): Added proper conversion to the correct WorkerContext derived class.
- bindings/js/JSWorkerContextBase.h:
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Updated WorkerScriptController to create the correct type of binding object (JSSharedWorkerContext vs JSDedicatedWorkerContext)
- bindings/scripts/CodeGeneratorV8.pm: Added support for SharedWorkerContext.
- bindings/v8/DOMObjectsInclude.h: Added shared worker bindings files.
- dom/EventNames.h: Added connect event.
- dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorkerContext): Added API for casting to new derived class (SharedWorkerContext).
- dom/EventTarget.h:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): Moved code that resolves/validates URLs to base class so it can be shared between dedicated/shared workers.
- workers/AbstractWorker.h:
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::logException): Refactored exception handling code - moved onerror handling to base class.
- workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::isDedicatedWorkerContext):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker): Changed constructor to fire up worker thread.
- workers/SharedWorker.h:
- workers/SharedWorkerContext.cpp: Added. (WebCore::SharedWorkerContext::SharedWorkerContext): (WebCore::SharedWorkerContext::~SharedWorkerContext): (WebCore::SharedWorkerContext::logException): (WebCore::SharedWorkerContext::addMessage): Placeholder methods until we add support for sending exceptions/messages to console. (WebCore::SharedWorkerContext::dispatchConnect): (WebCore::SharedWorkerContext::thread):
- workers/SharedWorkerContext.h: Added. (WebCore::SharedWorkerContext::create): (WebCore::SharedWorkerContext::isSharedWorkerContext): (WebCore::SharedWorkerContext::toSharedWorkerContext): (WebCore::SharedWorkerContext::setOnconnect): (WebCore::SharedWorkerContext::onconnect): (WebCore::SharedWorkerContext::name):
- workers/SharedWorkerContext.idl: Added.
- workers/SharedWorkerRepository.h: Added. (WebCore::SharedWorkerRepository::~SharedWorkerRepository):
- workers/DefaultSharedWorkerRepository.cpp: Added. Implementation of core singleton class that will be used to implement sharing. (WebCore::SharedWorkerProxy::setThread): Proxy object used to handle resource loading for a given shared worker. (WebCore::SharedWorkerProxy::postTaskToLoader): (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext): Placeholder routines until we implement loading. (WebCore::SharedWorkerConnectTask::create): Creates a task to fire off a connect event on the worker thread. (WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask): (WebCore::SharedWorkerConnectTask::performTask): (WebCore::SharedWorkerLoader::SharedWorkerLoader): Added helper object to load the initial script for the worker. (WebCore::SharedWorkerLoader::load): (WebCore::SharedWorkerLoader::notifyFinished): (WebCore::SharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Fires off the worker thread once the script is loaded. (WebCore::SharedWorkerRepository::connect): (WebCore::DefaultSharedWorkerRepository::DefaultSharedWorkerRepository): (WebCore::DefaultSharedWorkerRepository::~DefaultSharedWorkerRepository):
- workers/DefaultSharedWorkerRepository.h: Added.
- workers/SharedWorkerThread.cpp: Added. (WebCore::SharedWorkerThread::create): (WebCore::SharedWorkerThread::SharedWorkerThread): (WebCore::SharedWorkerThread::~SharedWorkerThread): (WebCore::SharedWorkerThread::createWorkerContext):
- workers/SharedWorkerThread.h: Added.
- workers/Worker.cpp: (WebCore::Worker::Worker):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- workers/WorkerContext.h: (WebCore::WorkerContext::isSharedWorkerContext): (WebCore::WorkerContext::isDedicatedWorkerContext): Added APIs to determine the type of a given context.
LayoutTests:
2009-08-05 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (OOPS!).
SharedWorkers should instantiate a thread and a SharedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27927
Added disabled tests for SharedWorker minimal functionality.
Began refactoring of dedicated worker tests to allow sharing test cases between shared and dedicated worker (will continue in another patch).
- fast/workers/resources/shared-worker-common.js: Added.
- fast/workers/resources/shared-worker-script-error.js: Added.
- fast/workers/resources/worker-replace-global-constructor.js: Moved common code into shared .js file.
- fast/workers/shared-worker-constructor.html-disabled:
- fast/workers/shared-worker-gc-expected.txt: Added.
- fast/workers/shared-worker-gc.html-disabled: Added.
- fast/workers/shared-worker-load-error-expected.txt: Added.
- fast/workers/shared-worker-load-error.html-disabled: Added.
- fast/workers/shared-worker-replace-global-constructor-expected.txt: Added.
- fast/workers/shared-worker-replace-global-constructor.html-disabled: Added.
- fast/workers/shared-worker-script-error-expected.txt: Added.
- fast/workers/shared-worker-script-error.html-disabled: Added.
- fast/workers/shared-worker-simple-expected.txt: Added.
- fast/workers/shared-worker-simple.html-disabled: Added.
- fast/workers/worker-replace-global-constructor.html:
- 8:12 AM Changeset in webkit [46844] by
-
- 6 edits in trunk
Added ENABLE_3D_CANVAS flag to build, default to off
- 7:59 AM BuildingGtk edited by
- (diff)
- 7:26 AM Changeset in webkit [46843] by
-
- 2 edits in trunk/WebCore
2009-08-06 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] windowsKeyCodeForKeyEvent fix
Fix windowsKeyCodeForKeyEvent to determine wheter the event comes from the keypad.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 7:12 AM Changeset in webkit [46842] by
-
- 1 edit1 delete in trunk/WebCore
2009-08-06 George Staikos <george.staikos@torchmobile.com>
Rubber-stamped by Ariya Hidayat.
Remove the dead wince/ directory that should never have gone in.
- svg/graphics/wince: Removed.
- svg/graphics/wince/SVGResourceFilterWince.cpp: Removed.
- 2:52 AM Changeset in webkit [46841] by
-
- 6 edits1 add in trunk/WebCore
2009-08-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Extract style editing into a separate file that is
going to be loaded in page context.
- inspector/front-end/InjectedScript.js: Added. (InjectedScript.applyStyleText): (InjectedScript.setStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript.setStyleRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:27 AM Changeset in webkit [46840] by
-
- 3 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
- bindings/v8/V8Proxy.h:
- 1:17 AM Changeset in webkit [46839] by
-
- 2 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium Linux build. This function is
not used.
- bindings/v8/OwnHandle.h:
- 12:42 AM Changeset in webkit [46838] by
-
- 10 edits4 adds in trunk
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
We now save a weak handle to the original context. We use that handle
to call the timeout in the right context / world.
Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html
http/tests/security/isolatedWorld/window-setTimeout-string.html
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
LayoutTests:
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Add test coverage for the interaction between setTimeout and isolated
worlds.
- http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.
Aug 5, 2009:
- 11:57 PM Changeset in webkit [46837] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875
Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.
- parser/Nodes.h:
- 11:53 PM Changeset in webkit [46836] by
-
- 2 edits in trunk/LayoutTests
2009-08-05 Xan Lopez <xlopez@igalia.com>
Skip new test using eventSender, since the GTK+ port does not have
it yet.
- platform/gtk/Skipped:
- 11:10 PM Changeset in webkit [46835] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 11:10 PM Changeset in webkit [46834] by
-
- 1 copy in tags/Safari-6531.10
New tag.
- 11:08 PM Changeset in webkit [46833] by
-
- 3 edits in branches/safari-4-branch/WebKit/win
Merge r46638.
- 10:33 PM Changeset in webkit [46832] by
-
- 5 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add floating point support for generic ARM port.
https://bugs.webkit.org/show_bug.cgi?id=24986
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::doubleTransfer):
- assembler/ARMAssembler.h: (JSC::ARM::): (JSC::ARMAssembler::): (JSC::ARMAssembler::faddd_r): (JSC::ARMAssembler::fsubd_r): (JSC::ARMAssembler::fmuld_r): (JSC::ARMAssembler::fcmpd_r): (JSC::ARMAssembler::fdtr_u): (JSC::ARMAssembler::fdtr_d): (JSC::ARMAssembler::fmsr_r): (JSC::ARMAssembler::fsitod_r): (JSC::ARMAssembler::fmstat):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble):
- jit/JIT.h:
- 10:22 PM Changeset in webkit [46831] by
-
- 11 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add JIT support for generic ARM port without optimizations.
https://bugs.webkit.org/show_bug.cgi?id=24986
All JIT optimizations are disabled.
Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::baseIndexTransfer32):
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::load32):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITOpcodes.cpp:
- jit/JITStubs.cpp:
- jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
- wtf/Platform.h:
- 10:19 PM Changeset in webkit [46830] by
-
- 4 edits in trunk/LayoutTests
2009-08-05 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Need to test throwing exceptions from Workers after calling close().
https://bugs.webkit.org/show_bug.cgi?id=27924
- fast/workers/resources/worker-close.js:
- fast/workers/worker-close-expected.txt:
- fast/workers/worker-close.html:
- 8:50 PM Changeset in webkit [46829] by
-
- 5 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Revert http://trac.webkit.org/changeset/46821, which was
landed to supplement http://trac.webkit.org/changeset/46816, but
now that the latter is reverted, the former needs the same.
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:27 PM Changeset in webkit [46828] by
-
- 4 edits1 add in trunk/WebCore
2009-08-05 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Color is only reported in rgb() format; should toggle between rgb() and hex
https://bugs.webkit.org/show_bug.cgi?id=13516
New Class to Parse and Change Between Color Representations:
- inspector/front-end/Color.js: Added. (WebInspector.Color):
Representations of Colors in Raw Form. (May be Lazy Loaded):
(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.set hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.set rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.set hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.set nickname):
(WebInspector.Color.prototype.get rgba):
(WebInspector.Color.prototype.set rgba):
(WebInspector.Color.prototype.get hsla):
(WebInspector.Color.prototype.set hsla):
Helpers and Standard String Representations:
(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype.toRgb):
(WebInspector.Color.prototype.toHsl):
(WebInspector.Color.prototype.toShortHex):
(WebInspector.Color.prototype.toHex):
(WebInspector.Color.prototype.toRgba):
(WebInspector.Color.prototype.toHsla):
(WebInspector.Color.prototype.toNickname):
Conversion Functions to Determine Other Representations:
My Sources for all algorithms and sample data:
Wikipedia: http://en.wikipedia.org/wiki/HSV_color_space
CSS Specification: http://www.w3.org/TR/css3-color/#hsla-color
(WebInspector.Color.prototype.rgbToHex):
(WebInspector.Color.prototype.hexToRgb):
(WebInspector.Color.prototype.rgbToHsl):
(WebInspector.Color.prototype.hslToRgb.hueToRgb):
(WebInspector.Color.prototype.hslToRgb):
(WebInspector.Color.prototype.rgbaToHsla):
(WebInspector.Color.prototype.hslaToRgba):
Called from the constructor, attempts to parse and will throw an error
if it cannot parse. If simple then the "hex" value is guarenteed.
If advanced then both the "rgba" and "hsla" are guarenteed. If it is
a nickname in any way (e.g. "transparent", "black") then this is
guarenteed to be set as well.
(WebInspector.Color.prototype.parse):
Clicking on the swatch will rotate through Color Representations.
Simple: rgb -> hsl -> nickname? -> shorthex? -> hex -> (loop around)
Advanced: rgba -> hsla -> nickname? -> (loop around)
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.value.): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
Load Color.js:
- inspector/front-end/inspector.html:
- 8:05 PM Changeset in webkit [46827] by
-
- 4 edits in trunk/WebCore
2009-08-05 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Support setting event listeners for message ports in the worker process.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 7:39 PM Changeset in webkit [46826] by
-
- 2 edits in trunk/WebCore
2009-08-05 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Minor fix for media code on chromium/skia.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
- 6:37 PM Changeset in webkit [46825] by
-
- 3 edits2 adds in trunk
WebCore:
2009-08-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.
Test: fast/images/image-map-zoom.html
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Compute the values to pass in to the map element using the content box and the effective zoom.
LayoutTests:
2009-08-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.
- fast/images/image-map-zoom-expected.txt: Added.
- fast/images/image-map-zoom.html: Added.
- 6:30 PM Changeset in webkit [46824] by
-
- 5 edits in trunk
Add more missing ResourceLoadDelegate methods for WinDRT, and remove another test from the skipped list.
- 5:52 PM WebKit Team edited by
- (diff)
- 5:12 PM Changeset in webkit [46823] by
-
- 14 edits5 deletes in trunk
Roll out r46816 as it broke many tests.
- 5:11 PM Changeset in webkit [46822] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28027
<rdar://7064428> Files with accents in names are submitted incorrectly due to use of
precomposed Unicode
- platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): Use getFileSize() from FileSystem.h instead of custom code for getting file size. This adds path normalization necessary with some file systems on Mac. This also loses a S_IFMT check, which didn't seem important anyway.
- 4:47 PM Changeset in webkit [46821] by
-
- 5 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Include Media into V8 bindings.
- bindings/v8/DOMObjectsInclude.h: Added Media include.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added V8Media include.
- bindings/v8/V8Index.cpp: Added decl for V8Media.
- bindings/v8/V8Index.h: Added V8Media include.
- 4:41 PM Changeset in webkit [46820] by
-
- 5 edits1 delete in trunk
WebKitTools:
2009-08-05 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveResponse):
- DumpRenderTree/win/ResourceLoadDelegate.h:
LayoutTests:
2009-08-05 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033
- platform/win/Skipped: Remove a test that now passes
Remove platform specific results for the XFrameOptions suite which now matches cross platform results:
- platform/win/http/tests/security: Removed.
- platform/win/http/tests/security/XFrameOptions: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
- 4:18 PM Changeset in webkit [46819] by
-
- 4 edits in trunk/WebCore
2009-08-04 Jon Honeycutt <jhoneycutt@apple.com>
Fix Windows layout test crashes.
PluginView::removeFromUnstartedListIfNecessary() would try to remove
any unstarted PluginView from the Page's set of unstarted plug-ins,
regardless of why the PluginView wasn't started. If we tried to start a
plug-in, but it failed to start, we would hit an assertion in
Page::removeUnstartedPlugin() that asserts that we would only modify the
unstarted plug-ins set if we were not currently starting plug-ins.
Fix this by having PluginView track whether it's waiting to be started,
and to check this before trying to remove itself from the Page's
unstarted plug-ins set.
Reviewed by Darin Adler.
- page/Page.cpp: (WebCore::Page::removeUnstartedPlugin): Assert that the passed PluginView is in the unstarted set.
- plugins/PluginView.cpp: (WebCore::PluginView::start): Set that we are not waiting to be started. (WebCore::PluginView::startOrAddtoUnstartedList): Set that we are waiting to be started. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Check not whether we are started, but whether we are waiting to be started. (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- 3:48 PM Changeset in webkit [46818] by
-
- 2 edits in trunk/WebCore
2009-08-05 Jeremy Orlow <jorlow@chromium.org>
Fix DOM Storage memory leak
https://bugs.webkit.org/show_bug.cgi?id=28029
Forgot to use adoptRef in one place. This caused the = operator to
increment the ref count when it shouldn't have, so StorageAreaImpl's were
never freed.
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
- 2:51 PM Changeset in webkit [46817] by
-
- 2 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Let CodeGeneratorV8.pm know that Media is ref-counted.
- bindings/scripts/CodeGeneratorV8.pm: Added Media check to IsRefPtrType.
- 2:26 PM Changeset in webkit [46816] by
-
- 14 edits2 copies3 adds in trunk
2009-08-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495
Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.
Test: fast/media/matchmedium-query-api.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Add Media.* files to the build.
- css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
- css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
- css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::media):
- page/DOMWindow.h:
- page/DOMWindow.idl: Add a readonly attribute for Media.
- 2:25 PM Changeset in webkit [46815] by
-
- 96 edits in trunk/WebCore
2009-08-05 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Last patch. Makes all the casts of RenderObject use checked
casts instead of using static_cast directly.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect):
- dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
- dom/SelectElement.cpp: (WebCore::SelectElement::scrollToSelection): (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler):
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::addSearchResult): (WebCore::HTMLInputElement::onSearch):
- html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer): (WebCore::HTMLMediaElement::defaultEventHandler): (WebCore::HTMLMediaElement::finishParsingChildren):
- html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
- page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::capsLockStateMayHaveChanged):
- page/Frame.cpp: (WebCore::Frame::ownerRenderer):
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
- page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderCounter.cpp: (WebCore::planCounter):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::setIsResizing):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentsBox):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
- rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers):
- rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::invalidateCountersInContainer):
- rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler):
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineSliderThumbState):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
- rendering/SVGRootInlineBox.cpp: (WebCore::findSVGRootObject):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/SVGTextContentElement.cpp: (WebCore::rootInlineBoxForTextContentElement):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): Use checked casts.
- rendering/RenderApplet.h:
- rendering/RenderCounter.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderPart.h:
- rendering/RenderPartObject.h:
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTextPath.h:
- rendering/RenderSVGViewportContainer.h:
- rendering/RenderScrollbar.h:
- rendering/RenderSlider.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderVideo.h: Added a checked cast. Also made most members protected or private.
- rendering/RenderBlock.h:
- rendering/RenderInline.h:
- rendering/RenderReplaced.h:
- rendering/RenderSVGBlock.h:
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGText.h:
- rendering/RenderTextControl.h: Made most members protected or private.
- rendering/RenderInline.cpp:
- rendering/RenderSVGContainer.cpp:
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGImage.cpp:
- rendering/RenderSVGRoot.cpp: Removed unneeded destructor.
- rendering/RenderSVGHiddenContainer.h: Removed unneeded virtual function overrides that did the same as the default and base class.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport directly instead of using a function call. (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto. (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto. (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
- rendering/RenderScrollbar.cpp: (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for all values instead of using a default case.
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Removed dependency on casting to types that don't have any public members we need to get at. Instead, use function names to identify the type rather than doing so much overloading. Changed to use checked casts. (WebCore::write): Ditto.
- rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Changed to use a checked cast and also added a comment about the fact that the code does not do sufficient type checking before doing the cast.
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderSVGTextBox): Renamed this from operator<<. (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText. (WebCore::writeSVGText): Renamed this from write. (WebCore::writeSVGInlineText): Ditto. (WebCore::writeSVGImage): Ditto.
- rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed unneeded default arguments.
- 2:14 PM Changeset in webkit [46814] by
-
- 3 edits in trunk/WebCore
2009-08-05 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27851
Fix a pair of compiler warnings on the GTK Linux buildbot.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
- 2:00 PM Changeset in webkit [46813] by
-
- 1 edit4 copies in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
- 1:46 PM Changeset in webkit [46812] by
-
- 1 edit6 deletes in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.
- platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
- platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 1:31 PM Changeset in webkit [46811] by
-
- 1 edit4 deletes in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results,
so I'm removing them.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 1:26 PM Changeset in webkit [46810] by
-
- 3 edits in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.
- platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
- platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
- 1:16 PM Changeset in webkit [46809] by
-
- 12 edits in trunk
2009-08-05 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add layoutTestController.dumpWillCacheResponse
https://bugs.webkit.org/show_bug.cgi?id=28010
willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
Splitting off a new dumpWillCacheResponse allows a number of existings tests
to run across platforms.
The test that was specifically verifying willCacheResponse now calls
dumpWillCacheResponse.
- DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse (LayoutTestController::LayoutTestController): (dumpWillCacheResponseCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse instead of dumpResourceLoadCallbacks. (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
- 12:56 PM Changeset in webkit [46808] by
-
- 4 edits in trunk/LayoutTests
Fix two tests to not load a resource that takes five seconds to load.
Reviewed by Brady Eidson.
We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
This drops the run time of each of the tests from over five seconds to less than a third
of a second.
- http/tests/misc/DOMContentLoaded-event.html:
- http/tests/navigation/multiple-back-forward-entries.html:
- http/tests/navigation/resources/slow-resource.pl:
- 12:36 PM Changeset in webkit [46807] by
-
- 7 edits1 delete in trunk/WebCore
2009-08-05 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460
Return multiple icon entries from the ICO decoder as separate frames,
sorted by decreasing quality (much like the CG ICO decoder does).
As a result of this change, we can eliminate the Skia-specific setData()
hack that the Chromium port used to select the desired icon size -- now
callers can just enumerate the frames and ask for the data from the one
they like.
Under the hood, the ICO decoder now keeps vectors for a number of things
(including directory entries and image decoders) where it used to have
single members. However, callers (that I have seen) will only request
one frame from the icon, so practically there aren't going to be lots of
instantiated image decoders.
- platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation. (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
- platform/graphics/skia/ImageSourceSkia.h: Removed.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders. (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders. (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames. (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling. Otherwise, use size from icon directory instead of PNG decoder (if applicable). (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement. (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling. (WebCore::ICOImageDecoder::frameCount): Implement. (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames. (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries. (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder. (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces. (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode(). (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested. (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents. (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality. (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
- platform/image-decoders/ico/ICOImageDecoder.h:
- 11:38 AM Changeset in webkit [46806] by
-
- 3 edits2 adds in trunk
2009-08-05 Szabo Carol <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=27942
Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.
- fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
- fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.
2009-08-05 Szabo Carol <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Test: fast/forms/select-reset-multiple-selections-4-single-selection.html
- dom/SelectElement.cpp: (WebCore::SelectElement::reset):
Added HTML 4.01 compliant handling of broken webpages that
specify more than one selected option for single selection SELECT
element, in a manner that emulates Firefox and is similar to IE 7
- 11:22 AM Changeset in webkit [46805] by
-
- 2 edits in trunk/WebKitTools
2009-08-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add my name to committers.py
https://bugs.webkit.org/show_bug.cgi?id=28013
Add my name to committers.py.
- Scripts/modules/committers.py:
- 8:17 AM Changeset in webkit [46804] by
-
- 2 edits in trunk/WebCore
2009-08-05 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
WebCore.pro bugfix
Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.
- WebCore.pro:
- 8:14 AM Changeset in webkit [46803] by
-
- 2 edits in trunk/WebKit/qt
2009-08-05 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix build error caused by http://trac.webkit.org/changeset/46763
- Api/qwebpluginfactory.h: Export macro added.
- 7:56 AM Changeset in webkit [46802] by
-
- 3 edits in trunk/WebKitTools
2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
A minor refactoring of the Qt DRT to be a bit more similar to
the other DRTs, as well as more understandable.
Splitting up resetJSObjects into a LayoutTestController->reset()
plus a new closeRemainingWindows() method.
Added a resetToConsistentStateBeforeTesting() method to keep
the code in one place, making it easier to verify that we are
doing things properly.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows):
- DumpRenderTree/qt/DumpRenderTree.h:
- 7:51 AM Changeset in webkit [46801] by
-
- 5 edits in trunk/WebKitTools
2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Make the Qt DRT WorkQueue work similarily to the cross platform
one. This means that all items return true if they started
loading.
This change paves the way for unforking the WorkQueue, if we [Qt]
would like that.
- DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::processWork):
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/jsobjects.cpp: (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::processWork): (LayoutTestController::maybeDump):
- 7:48 AM Changeset in webkit [46800] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
If load of a test fails, don't dump as it will be dumped
in the preceding test, resulting in a invalid incorrect layout.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump):
- 7:46 AM Changeset in webkit [46799] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Make the Qt DumpRenderTree more similar to the mac one.
Changes include:
1) Reset zoom factor before each test
2) Only dump the backforward list when we got other dump result
3) When we dump the render tree, and got zero result print out:
[mainFrame renderTreeAsExternalRepresentation]
and not:
[frame renderTreeAsExternalRepresentation]
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): (WebCore::methodNameStringForFailedTest): (WebCore::DumpRenderTree::dump):
- 7:39 AM Changeset in webkit [46798] by
-
- 4 edits in trunk
WebCore:
2009-08-05 Chris Fleizach <Chris Fleizach>
Fix Tiger build breakage.
- accessibility/mac/AccessibilityObjectWrapper.mm:
WebKitTools:
2009-08-05 chris fleizach <Chris Fleizach>
Fix Tiger build breakage.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:40 AM EFLWebKit edited by
- (diff)
- 4:40 AM Changeset in webkit [46797] by
-
- 2 edits in trunk
2009-08-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929
The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.
Lastly, make sure CXXFLAGS and CFLAGS are defined before
AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.
- autotools/webkit.m4:
- 1:13 AM Changeset in webkit [46796] by
-
- 2 edits in trunk
2009-08-05 Xan Lopez <xlopez@igalia.com>
Revert r46714, it was making us build debug images by default.
- autotools/webkit.m4:
Aug 4, 2009:
- 10:50 PM Changeset in webkit [46795] by
-
- 2 edits in trunk/WebCore
2009-08-04 Simon Hausmann <Simon Hausmann>
Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
to both source files, HTMLTagNames.in and HTMLAttributeNames.in
- WebCore.pro:
- 10:40 PM Changeset in webkit [46794] by
-
- 18 edits in trunk/LayoutTests
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
because I've changed this API to be synchronous instead of asynchronous
to work around some strange behavior in the work_queue_. Turns out we
don't need the complexity of an asynchronous API to test this feature.
- http/tests/security/isolatedWorld/all-window-properties.html:
- http/tests/security/isolatedWorld/all-window-prototypes.html:
- http/tests/security/isolatedWorld/body-properties.html:
- http/tests/security/isolatedWorld/body-prototype.html:
- http/tests/security/isolatedWorld/click-event.html:
- http/tests/security/isolatedWorld/document-open.html:
- http/tests/security/isolatedWorld/document-properties.html:
- http/tests/security/isolatedWorld/document-prototype.html:
- http/tests/security/isolatedWorld/global-variables.html:
- http/tests/security/isolatedWorld/image-properties.html:
- http/tests/security/isolatedWorld/image-prototype.html:
- http/tests/security/isolatedWorld/location-properties.html:
- http/tests/security/isolatedWorld/location-prototype.html:
- http/tests/security/isolatedWorld/number-prototype.html:
- http/tests/security/isolatedWorld/object-prototype.html:
- http/tests/security/isolatedWorld/string-prototype.html:
- http/tests/security/isolatedWorld/window-properties.html:
- 10:20 PM Changeset in webkit [46793] by
-
- 2 edits in trunk/WebCore
2009-08-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adele Peterson.
Keypress should exit from pan scrolling mode.
https://bugs.webkit.org/show_bug.cgi?id=28005
Change the logic from only exiting pan scrolling on escape to exiting on any key press,
making it easier for users to back out of an accidental pan scroll.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
- 9:36 PM Changeset in webkit [46792] by
-
- 5 edits1 add in trunk
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Fix some bogus comments noticed during testing.
- fast/forms/drag-into-textarea.html:
- fast/forms/drag-out-of-textarea.html:
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Add back missing dragController()->clear() call.
- manual-tests/drag-caret.html: Added.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 7:22 PM Changeset in webkit [46791] by
-
- 2 edits in trunk/WebKit/win
2009-08-04 Alice Liu <alice.liu@apple.com>
"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows
Reviewed by Jon Honeycutt.
- WebView.cpp: Register shift+enter as InsertNewline command, similar to other modifier+Enter combinations.
- 6:34 PM Changeset in webkit [46790] by
-
- 2 edits1 add5 deletes in trunk/LayoutTests
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
- platform/mac/accessibility/aria-valuetext-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext.html: Added.
- 5:32 PM Changeset in webkit [46789] by
-
- 2 edits in trunk/WebCore
2009-08-04 Chris Fleizach <Chris Fleizach>
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Forgot to commit attribute names.
- html/HTMLAttributeNames.in:
- 5:29 PM Changeset in webkit [46788] by
-
- 11 edits2 adds in trunk
WebCore:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Test: platform/mac/accessibility/aria-valuetext.html
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::valueDescription):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::valueDescription):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
WebKitTools:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Expose valueDescription for accessibility.
- DumpRenderTree/AccessibilityUIElement.cpp: (getValueDescriptionCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::valueDescription):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::valueDescription):
LayoutTests:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
- platform/mac/accessibility/aria-valuetext-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext.html: Added.
- 5:21 PM Changeset in webkit [46787] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
https://bugs.webkit.org/show_bug.cgi?id=28006
Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig
- DumpRenderTree/mac/PerlSupport/Makefile:
- 5:18 PM Changeset in webkit [46786] by
-
- 19 edits in trunk
2009-08-04 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
No new features, no new tests. Existing layout tests pass.
- WebCore.base.exp:
Export AppliationCacheGroup::storeCopyOfCache
- WebCore.xcodeproj/project.pbxproj:
Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
instead of 'private' headers since they're no longer in the DocumentLoader.h
include graph.
- html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
Reinstate the test for manifest.isNull instead of .isEmtpty().
Added a FIXME to revisit once the spec gets clarified.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
for compile time friendliness, it results in a smaller include graph for files
dependent on DocumentLoader.h.
- loader/FrameLoader.cpp:
- loader/MainResourceLoader.cpp:
- loader/ResourceLoader.cpp:
Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
This was done for readability at the include site. The included files contain appropriate guards,
so they're not needed at the include site.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
- loader/appcache/ApplicationCacheGroup.h:
Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyEventListener): (WebCore::ApplicationCacheHost::status):
- loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/appcache/ApplicationCacheStorage.h:
Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventType): (WebCore::DOMApplicationCache::toEventID):
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):
Use ApplicationCachHost defined constants for Status and EventIDs.
- 4:31 PM Changeset in webkit [46785] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add pkasting to bugzilla-tool as a committer
https://bugs.webkit.org/show_bug.cgi?id=28002
- Scripts/modules/committers.py:
- 4:20 PM Changeset in webkit [46784] by
-
- 3 edits in trunk/WebCore
2009-08-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.
- 4:04 PM Changeset in webkit [46783] by
-
- 15 edits2 adds in trunk
WebCore:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Expose appropriate actions and attributes for sliders.
Test: platform/mac/accessibility/slider-supports-actions.html
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::orientation):
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
WebKitTools:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Add ability to check if any arbitrary action is supported.
- DumpRenderTree/AccessibilityUIElement.cpp: (isActionSupportedCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isActionSupported):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isActionSupported):
LayoutTests:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Update tests to use more generic isActionSupported.
- accessibility/aria-link-supports-press.html:
- accessibility/button-press-action.html:
- accessibility/onclick-handlers.html:
- platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
- platform/mac/accessibility/slider-supports-actions.html: Added.
- 3:52 PM Changeset in webkit [46782] by
-
- 2 edits in trunk/WebCore
2009-08-04 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
[V8] Fix an assert in WebCoreStringResource that causes worker script
evaluation failed.
https://bugs.webkit.org/show_bug.cgi?id=27996
The fix is to check for the same thread, instead of the main thread.
This is because Chromium's workers use v8 in a single thread that is
not the main thread.
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::atomicString):
- 3:46 PM Changeset in webkit [46781] by
-
- 1 edit1 add in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool unit tests need a test harness
https://bugs.webkit.org/show_bug.cgi?id=27977
- Scripts/run-webkit-unittests: Added.
- 3:19 PM Changeset in webkit [46780] by
-
- 3 edits in trunk/WebKit/wx
wx build fix after InspectorClient API change.
- 2:43 PM Changeset in webkit [46779] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
LayoutTests are too slow
https://bugs.webkit.org/show_bug.cgi?id=27995
Shave 5 seconds off of run-webkit-tests.
- fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
- 2:35 PM Changeset in webkit [46778] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-04 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oiver Hunt.
Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
https://bugs.webkit.org/show_bug.cgi?id=27874
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
- 1:59 PM BuildingOnWindows edited by
- Move the information about setting the WebKitLibrariesDir out of the … (diff)
- 1:54 PM Changeset in webkit [46777] by
-
- 2 edits in trunk/JavaScriptCore
PPC64 Build fix
- 12:57 PM Changeset in webkit [46776] by
-
- 3 edits2 adds in trunk
2009-08-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add support for transitions/animations of text-indent.
Test: transitions/text-indent-transition.html
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
- 12:52 PM Changeset in webkit [46775] by
-
- 2 edits in trunk/WebKitTools
Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.
Rubber-stamped by Gavin "Gavvy" Barraclough.
- DumpRenderTree/mac/PerlSupport/Makefile:
- 12:46 PM Changeset in webkit [46774] by
-
- 2 edits in trunk/LayoutTests
Update test results after addition of AXRequired in r46768.
- platform/mac/accessibility/lists-expected.txt:
- 12:38 PM Changeset in webkit [46773] by
-
- 3 edits2 adds in trunk
2009-08-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add support for transitions of min- and max-width, and min- and max-height.
https://bugs.webkit.org/show_bug.cgi?id=27990
Test: transitions/min-max-width-height-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
- 12:17 PM Changeset in webkit [46772] by
-
- 2 edits1 add in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=26916
Add some basic unit testing for scm.py.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py: Added.
- 12:06 PM Changeset in webkit [46771] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included
are (http, media, compositing, wml, wcss).
- Scripts/run-webkit-tests:
- 11:15 AM Changeset in webkit [46770] by
-
- 8 edits2 adds in trunk
Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=27964
- 10:28 AM Changeset in webkit [46769] by
-
- 2 edits in trunk/WebCore
2009-08-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Missed a place that expects window.event to be hidden when it shouldn't be.
- 9:15 AM Changeset in webkit [46768] by
-
- 16 edits2 adds in trunk
Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
https://bugs.webkit.org/show_bug.cgi?id=27958
- 8:20 AM Changeset in webkit [46767] by
-
- 3 edits in trunk/WebKit/qt
2009-08-04 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
https://bugs.webkit.org/show_bug.cgi?id=27804
- Api/qwebframe.cpp: (QWebFrame::requestedUrl):
- tests/qwebframe/tst_qwebframe.cpp:
- 7:58 AM Changeset in webkit [46766] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat
Explicitly include limits.h header when using INT_MAX and INT_MIN
- interpreter/Interpreter.cpp
- 7:51 AM Changeset in webkit [46765] by
-
- 2 edits8 adds in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Add passed test results, with pixel tests.
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-composite-expected.png: Added.
- platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
- platform/qt/fast/canvas/drawImage-expected.checksum: Added.
- platform/qt/fast/canvas/drawImage-expected.png: Added.
- platform/qt/fast/canvas/drawImage-expected.txt: Added.
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
- 7:50 AM Changeset in webkit [46764] by
-
- 5 edits in trunk/WebKit/qt
2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.
- Api/qwebplugindatabase.cpp: (QWebPluginInfoPrivate::QWebPluginInfoPrivate): (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::supportsMimeType): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::plugins): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h:
- Api/qwebplugindatabase_p.h:
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
- 7:50 AM Changeset in webkit [46763] by
-
- 5 edits in trunk/WebKit/qt
2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Replace QWebPlugin::MimeType with a typedef to
QWebPluginFactory::MimeType.
- Api/qwebplugindatabase.cpp:
- Api/qwebplugindatabase.h:
- Api/qwebpluginfactory.cpp: (QWebPluginFactory::MimeType::operator==):
- Api/qwebpluginfactory.h:
- 7:50 AM Changeset in webkit [46762] by
-
- 7 edits6 adds in trunk
WebCore:
2009-08-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Add QWebPluginDatabase API to the Qt API.
- WebCore.pro:
WebKit/qt:
2009-08-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Add QWebPluginDatabase API to the Qt API.
- Api/headers.pri:
- Api/qwebplugindatabase.cpp: Added. (QWebPluginPrivate::QWebPluginPrivate): (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate): (QWebPlugin::MimeType::operator==): (QWebPlugin::QWebPlugin): (QWebPlugin::~QWebPlugin): (QWebPlugin::name): (QWebPlugin::description): (QWebPlugin::mimeTypes): (QWebPlugin::supportsMimeType): (QWebPlugin::path): (QWebPlugin::isNull): (QWebPlugin::setEnabled): (QWebPlugin::isEnabled): (QWebPlugin::operator==): (QWebPlugin::operator!=): (QWebPlugin::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::defaultSearchPaths): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h: Added.
- Api/qwebplugindatabase_p.h: Added.
- Api/qwebsettings.cpp: (QWebSettings::pluginDatabase):
- Api/qwebsettings.h:
- tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added. (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
- tests/tests.pro:
- 7:34 AM Changeset in webkit [46761] by
-
- 2 edits in trunk/WebCore
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Adam Treat.
[Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
(as it is the closest match) instead of CompositionMode_SourceOver.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
- 7:24 AM Changeset in webkit [46760] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Adam Treat.
[Qt] Fix the metrics.
- platform/qt/fast/canvas/canvas-before-css-expected.txt:
- 6:30 AM Changeset in webkit [46759] by
-
- 3 edits14 adds in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add pixel tests result.
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
- platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.txt:
- platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-bg-expected.png: Added.
- platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.
- 6:26 AM Changeset in webkit [46758] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Adam Treat <adam.treat@torchmobile.com>
Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.
- platform/qt/fast/block/float/033-expected.txt:
- 5:45 AM EFLWebKit edited by
- (diff)
- 5:22 AM Changeset in webkit [46757] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list
The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.
- platform/qt/Skipped:
- platform/qt/fast/block/float/033-expected.txt:
- 2:28 AM Changeset in webkit [46756] by
-
- 2 edits in trunk/WebCore
2009-08-04 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Adam Barth.
[v8] Fix crash when converting empty v8 string to atomic webkit string.
https://bugs.webkit.org/show_bug.cgi?id=27975
collection-null-like-arguments.html tests for this.
- bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
- 2:26 AM Changeset in webkit [46755] by
-
- 3 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool --commit-queue should validate commit-queue setter is a committer
https://bugs.webkit.org/show_bug.cgi?id=27974
With a test!
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- 1:59 AM Changeset in webkit [46754] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=27973
The trailing comma (suppresses newlines) was lost in r46700.
- Scripts/bugzilla-tool:
- 1:54 AM Changeset in webkit [46753] by
-
- 4 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool has too many fatal errors
https://bugs.webkit.org/show_bug.cgi?id=27969
Replace several fatal errors with ScriptError exceptions.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 1:34 AM Changeset in webkit [46752] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2009-08-04 Eric Seidel <eric@webkit.org>
No review, ChangeLog fix only.
Fix a ChangeLog line-spacing disaster caused by:
https://bugs.webkit.org/show_bug.cgi?id=27973
Still unsure what the fix for bugzilla-tool will be.
- 1:18 AM Changeset in webkit [46751] by
-
- 3 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool --commit-queue should only land commit-queue+ patches
https://bugs.webkit.org/show_bug.cgi?id=27970
commit-queue mode for bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=27918
Make bugzilla tool smart enough to find the commit-queue+ flags and
land those patches.
When we call land-patches with --commit-queue, we should filter the
patches we land to only those that have the commit-queue+ flag set.
That way, when we call bugzilla-tool from a main commit queue process,
we won't land the wrong patches.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- 1:14 AM Changeset in webkit [46750] by
-
- 2 edits3 adds in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
committer logic should be split out of bugzilla.py into its own module
I also added unit tests for the functionality I added.
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py: Added.
- Scripts/modules/commiters_unittest.py: Added.
- Scripts/modules/committers.py: Added.
- 12:13 AM Changeset in webkit [46749] by
-
- 4 edits in trunk/WebCore
2009-08-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865
This patch cleans up selectionStartHasStyle and selectionHasStyle.
No test is added because the patch does not change any behavior.
- editing/ApplyStyleCommand.cpp: (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
- editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
- editing/Editor.cpp: (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style. (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState
- 12:06 AM Changeset in webkit [46748] by
-
- 4 edits in trunk/WebCore
2009-08-03 John Abd-El-Malek <jam@chromium.org>
Reviewed by David Levin.
Fix MessagePort construction in worker process. Also make the other object constructions match this.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToV8Object):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
Aug 3, 2009:
- 11:34 PM Changeset in webkit [46747] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixup ChangeLog
- 11:14 PM Changeset in webkit [46746] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>
Reviewed by NOBODY
Fix ambiguity in abs(long int) call by calling labs() instead
- wtf/DateMath.cpp: replace call to abs() with labs()
- 10:39 PM Changeset in webkit [46745] by
-
- 5 edits in trunk/WebCore
2009-08-03 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by David Levin.
[V8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
- bindings/v8/V8Binding.h: (WebCore::):
- dom/Document.idl:
- 7:24 PM UsingGitWithWebKit edited by
- Added Section on Ignores (diff)
- 7:21 PM Changeset in webkit [46744] by
-
- 3 edits in trunk/WebCore
2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: DOM Storage Live Updating Should Not Affect Tabbing
https://bugs.webkit.org/show_bug.cgi?id=27957
- inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
- 7:14 PM Changeset in webkit [46743] by
-
- 6 edits in trunk
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- JavaScriptCore.pro:
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- WebCore.pro:
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- WebKit.pri:
- 6:29 PM Changeset in webkit [46742] by
-
- 3 edits in trunk/WebKitTools
2009-08-03 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.
- Scripts/svn-apply:
- Scripts/svn-unapply:
- 6:08 PM Changeset in webkit [46741] by
-
- 7 edits in trunk/WebCore
2009-08-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Chromium code sometimes isn't sandboxed and needs to access the FS.
https://bugs.webkit.org/show_bug.cgi?id=27954
These changes are the WebKit side of http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.
This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.
It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.
- platform/chromium/ChromiumBridge.h:
- platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 5:43 PM Changeset in webkit [46740] by
-
- 5 edits in trunk/WebCore
2009-08-03 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859
Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.
No new tests because this is covered by existing tests.
- css/mediaControlsChromium.css:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp:
- 5:28 PM Changeset in webkit [46739] by
-
- 3 edits in trunk/WebKitTools
2009-08-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool land-patches needs --queue mode
https://bugs.webkit.org/show_bug.cgi?id=27961
Add a --commit-queue command line option to suppress user interaction.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 4:48 PM Changeset in webkit [46738] by
-
- 12 edits in trunk/WebCore
2009-07-27 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:
- Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
- Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
- platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
- platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
- platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
- 4:42 PM Changeset in webkit [46737] by
-
- 2 edits in trunk/WebKitTools
Build fix. Add installsrc, installhdrs and install targets.
- DumpRenderTree/mac/PerlSupport/Makefile:
- 3:59 PM Changeset in webkit [46736] by
-
- 2 edits in trunk/WebCore
2009-08-03 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Adler.
Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.
All tests in storage/ pass.
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
- 3:05 PM Changeset in webkit [46735] by
-
- 4 edits in trunk/WebKitSite
Update two WordPress plug-ins that we use.
- blog/wp-content/plugins/akismet/akismet.php:
- blog/wp-content/plugins/akismet/readme.txt:
- blog/wp-content/plugins/commentcontrol.php:
- 3:02 PM Changeset in webkit [46734] by
-
- 1 edit2 copies15 moves114 adds129 deletes in trunk/WebKitSite
Add some missing files and delete some obsolete files.
- blog:
- 2:55 PM Changeset in webkit [46733] by
-
- 2 edits in trunk/WebCore
2009-08-03 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Based on work by Yael Aharon.
Implement keyboard event forwarding for windowless plugins
for the Qt port.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
- xml/NativeXPathNSResolver.cpp:
- 2:28 PM Changeset in webkit [46732] by
-
- 8 edits1 move2 adds in trunk/WebCore
Make the bottom "drawer" of the Web Inspector more extensible to support other views.
2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
https://bugs.webkit.org/show_bug.cgi?id=27928
- English.lproj/localizedStrings.js:
"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"
- inspector/front-end/ChangesView.js: Added. (WebInspector.ChangesView): (WebInspector.ChangesView.prototype._clearButtonClicked): (WebInspector.ChangesView.prototype._toggleChangesButtonClicked): (WebInspector.ChangesView.prototype.attach): (WebInspector.ChangesView.prototype.show): (WebInspector.ChangesView.prototype.hide):
To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.
- inspector/front-end/Console.js: Removed.
Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js
- inspector/front-end/ConsoleView.js: Added.
Little has changed from its move from Console.js other then support for working with the Drawer.
- inspector/front-end/Drawer.js: Added. (WebInspector.Drawer): (WebInspector.Drawer.prototype.get visibleView): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype._safelyRemoveChildren): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
Allow for multiple views inside the Sliding Drawer.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.renameSelector): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype.generateStylesheet):
Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.
- inspector/front-end/Images/styleIcon.png: Added.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):
Interface with ElementsPanel for generating a Stylesheet of Changes.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
- inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.
- inspector/front-end/inspector.js: (WebInspector.get styleChanges): (WebInspector.set styleChanges): (WebInspector._updateChangesCount): (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.showConsole): (WebInspector.showChanges):
Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.
- 2:24 PM Changeset in webkit [46731] by
-
- 338 edits18 copies1 move133 adds14 deletes in trunk/WebKitSite
Update WordPress to the latest version.
- blog:
- 2:00 PM Changeset in webkit [46730] by
-
- 2 edits in trunk/WebCore
2009-08-03 Dean McNamee <deanm@chromium.org>
Reviewed by Adam Barth.
Correct an assert on a PassRefPtr in the v8 svg bindings.
https://bugs.webkit.org/show_bug.cgi?id=27951
- bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
- 1:23 PM Changeset in webkit [46729] by
-
- 2 edits in trunk/LayoutTests
2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.
- platform/gtk/Skipped:
- 1:00 PM Changeset in webkit [46728] by
-
- 3 edits3 adds in trunk
WebCore:
2009-08-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly
Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.
Test: fast/css/large-list-of-rules-crash.html
- css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):
LayoutTests:
2009-08-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Sam Weinig.
Test for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly
Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.
- fast/css/large-list-of-rules-crash-expected.txt: Added.
- fast/css/large-list-of-rules-crash.html: Added.
- fast/css/resources/large-list-of-rules-crash.css: Added.
- 12:40 PM Changeset in webkit [46727] by
-
- 20 edits in trunk
2009-08-03 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Make the DRT APIs to pause transitions and animations work for accelerated animations
<https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>
Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.
I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
- page/animation/AnimationBase.h:
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
- rendering/RenderLayerBacking.h:
- 11:47 AM Changeset in webkit [46726] by
-
- 2 edits in trunk/WebCore
2009-08-03 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
https://bugs.webkit.org/show_bug.cgi?id=27946
No new tests because this is a build fix.
- page/Page.cpp:
- 11:46 AM Changeset in webkit [46725] by
-
- 2 edits in trunk/JavaScriptCore
Fixed the Tiger build.
- wtf/FastMalloc.cpp:
- 11:34 AM Changeset in webkit [46724] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=27900
- wtf/FastMalloc.cpp:
- 11:00 AM Changeset in webkit [46723] by
-
- 2 edits in trunk/WebCore
2009-08-03 Eric Carlson <eric.carlson@apple.com>
One more build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.
Unreviewed.
- WebCoreSources.bkl:
- 10:34 AM Changeset in webkit [46722] by
-
- 5 edits in trunk/WebCore
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.
Unreviewed.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 10:13 AM Changeset in webkit [46721] by
-
- 6 edits2 adds in trunk
Bug 27943 - Need to implement ARIA role="radiogroup"
https://bugs.webkit.org/show_bug.cgi?id=27943
- 10:07 AM Changeset in webkit [46720] by
-
- 14 edits4 adds in trunk
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Test: accessibility/input-slider.html
- WebCore.xcodeproj/project.pbxproj:
Add AccessibilitySlider.cpp/.h
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):
Create AccessibilitySlider and AccessibilitySliderThumb.
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
Add default, do nothing, base class methods.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
Correct typo.
- accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
- accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
- accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):
SliderThumbRole -> NSAccessibilityValueIndicatorRole
(-[AccessibilityObjectWrapper roleDescription]):
Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
Minor coding style correction.
(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
If attachement view handles press action, don't also call object wrapper.
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
New, call object's increment() method.
(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
New, call object's decrement() method.
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):
Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.
(WebCore::RenderSlider::layout):
Move code to thumbRect().
- rendering/RenderSlider.h:
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.
- DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Add test for <input type=range> accessibility .
- accessibility/input-slider.html: Added.
- platform/mac/accessibility/input-slider-expected.txt: Added.
- 10:00 AM Changeset in webkit [46719] by
-
- 3 edits in trunk/WebCore
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=27940
- plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
- plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
- 9:12 AM Changeset in webkit [46718] by
-
- 2 edits in trunk/WebCore
2009-07-31 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
https://bugs.webkit.org/show_bug.cgi?id=27917
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
- 7:50 AM Changeset in webkit [46717] by
-
- 2 edits in trunk/WebKit/qt
2009-08-03 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Do memory cleanup when running robotized QtLauncher in debug as well.
- QtLauncher/main.cpp: (launcherMain): (main):
- 5:03 AM Changeset in webkit [46716] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Jan Alonzo.
Fix build break on Gtk/x86_64.
https://bugs.webkit.org/show_bug.cgi?id=27936
Use JSVALUE64 for X86_64 LINUX, except Qt.
- wtf/Platform.h:
- 3:27 AM Changeset in webkit [46715] by
-
- 1 edit in trunk/ChangeLog
Fix ChangeLog - r46714 was rubber-stamped by Eric
- 3:23 AM Changeset in webkit [46714] by
-
- 2 edits in trunk
2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel.
[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929
The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.
- autotools/webkit.m4:
- 2:14 AM Changeset in webkit [46713] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove extra linebreaks in WebCore/ChangeLog introduced in r46711
Aug 2, 2009:
- 11:33 PM Changeset in webkit [46712] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
- wtf/Platform.h:
- 9:12 PM Changeset in webkit [46711] by
-
- 2 edits in trunk/WebCore
2009-08-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
SVGElementInstance::scriptExecutionContext should call document() instead of scriptExecutionContext()
There's no reason to pay for a virtual function call in this case. We
can just call document() directly because we know that element is a
Node*.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::scriptExecutionContext):
- 8:49 PM Changeset in webkit [46710] by
-
- 4 edits in trunk/WebCore
2009-08-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
JSNodeCustom should call document() instead of scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=27931
We want to call document() because it's in inline function, instead of
scriptExecutionContext() because it's a virtual function. If we have a
Node*, then we know that the virtual function will always return the
document anyway.
There are more instance of this bug, but I'd like to start with a small
patch and work up.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- 4:10 PM Changeset in webkit [46709] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
crash with it enabled.
- wtf/Platform.h:
- 4:08 PM Changeset in webkit [46708] by
-
- 2 edits in trunk/LayoutTests
2009-08-02 Sam Weinig <sam@webkit.org>
Land updated expected result.
- fast/js/array-filter-expected.txt:
- 3:48 PM Changeset in webkit [46707] by
-
- 2 edits in trunk/LayoutTests
2009-08-02 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Speed up fast/js/array-filter.html by 10x in debug builds by not using an
unnecessarily large sparse array.
- fast/js/resources/array-filter.js:
- 3:10 PM Changeset in webkit [46706] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Qt build fix.
Added JSAPIValueWrapper.cpp to the build.
- JavaScriptCore.pri:
- 3:00 PM Changeset in webkit [46705] by
-
- 3 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
Exported symbols for JSAPIValueWrapper.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:56 PM Changeset in webkit [46704] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
GTK build fix.
- jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.
- 2:52 PM Changeset in webkit [46703] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Qt build fix.
- runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.
- 2:45 PM Changeset in webkit [46702] by
-
- 5 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
and JSImmediate::toThisObject, and removed their exported symbols.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- runtime/JSImmediate.cpp:
- runtime/JSImmediate.h:
- 2:33 PM Changeset in webkit [46701] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).
- wtf/Platform.h:
- 7:26 AM Changeset in webkit [46700] by
-
- 2 edits in trunk/WebKitTools
2009-08-02 David D. Kilzer <ddkilzer@webkit.org>
<http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø
Reviewed by Tor Arne Vestbø.
- Scripts/bugzilla-tool: (set_reviewer_in_changelog): Made sure reviewer is properly encoded when calling replace().
- 7:09 AM Changeset in webkit [46699] by
-
- 7 edits in trunk/WebCore
2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Anders Carlsson.
Share implementation of PluginView::userAgent() and userAgentStatic()
Differences to the original implementation are as follows:
- The Win port used to return 0 for userAgentStatic, but now returns the quirk mode MozillaUserAgent as the other ports.
- plugins/PluginView.cpp: (WebCore::PluginView::userAgent): (WebCore::PluginView::userAgentStatic):
- plugins/PluginViewNone.cpp:
- plugins/gtk/PluginViewGtk.cpp:
- plugins/mac/PluginViewMac.cpp:
- plugins/qt/PluginViewQt.cpp:
- plugins/win/PluginViewWin.cpp:
- 7:00 AM Changeset in webkit [46698] by
-
- 2 edits in trunk/WebCore
2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Anders Carlsson.
Unregister plugin from PluginMainThreadScheduler if NPP_New fails
Since the plugin has not been started yet (m_isStarted is not set),
calling stop() will not have any affect, so we manually unregister
in start() before returning.
- plugins/PluginView.cpp: (WebCore::PluginView::start):
- 6:47 AM Changeset in webkit [46697] by
-
- 7 edits in trunk/WebCore
2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Anders Calsson.
Join the various versions of PluginView::stop() into one shared implementation
The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h
Differences to the original implementation are as follows:
- The Qt port unregistered the plugin before calling NP_SetWindow with a 0 window handle. Now it's done after (similar to Win)
- The GTK and Qt ports unregistered the plugin before clearing the m_npWindow.ws_info struct. Now it's done after.
- The Win port constructed the DropAllLocks after unsubclassing the window. Now it's done before.
- The Mac, Qt, and GTK ports did not pass a NPSavedData struct to NP_Destroy (like the Win port). Now all ports do.
- The Win port did not call PluginView::setCurrentPluginView() before calling to NP-functions. Now it does.
- plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::~PluginView): (WebCore::PluginView::stop):
- plugins/PluginViewNone.cpp:
- plugins/gtk/PluginViewGtk.cpp:
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::getValueStatic):
- plugins/qt/PluginViewQt.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile):
- 1:54 AM Changeset in webkit [46696] by
-
- 1 edit1 add in trunk/WebKitTools
2009-08-02 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by David Levin.
Script for building the wxBrowser sample app for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
- wx/browser/wscript: Added.
- 1:54 AM Changeset in webkit [46695] by
-
- 1 edit1 add in trunk/WebKit/wx
2009-08-02 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Jan Alonzo.
Script for building the WebKit library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
- wscript: Added.
- 1:54 AM Changeset in webkit [46694] by
-
- 1 edit1 add in trunk/JavaScriptCore
2009-08-02 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Jan Alonzo.
Script for building the JavaScriptCore library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
- wscript: Added.
- 1:54 AM Changeset in webkit [46693] by
-
- 1 edit5 adds in trunk/WebKitTools
2009-08-02 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Jan Alonzo.
Scripts needed for the waf build.
https://bugs.webkit.org/show_bug.cgi?id=27619
- wx/build: Added.
- wx/build/build_utils.py: Added.
- wx/build/settings.py: Added.
- wx/build/waf_extensions.py: Added.
- wx/build/wxpresets.py: Added.
- 1:05 AM Changeset in webkit [46692] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-02 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
DateMath depends on strftime and localtime, which need to be imported manually on WinCE
https://bugs.webkit.org/show_bug.cgi?id=26558
- wtf/DateMath.cpp:
- 12:58 AM Changeset in webkit [46691] by
-
- 2 edits in trunk/WebKit/qt
2009-07-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
[Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default
https://bugs.webkit.org/show_bug.cgi?id=27866
- Api/qwebpage.cpp: (initializeApplicationCachePathIfNecessary): (QWebPagePrivate::QWebPagePrivate):
- 12:41 AM Changeset in webkit [46690] by
-
- 5 edits in trunk/WebCore
2009-07-30 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): added property stylesheet pointing to 1 stylesheet added to the page if needed
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): handle blank sections (WebInspector.StylesSidebarPane.prototype.addBlankSection): blank section in the correct position (WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): helper to get a nice selector for the selectd node (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.expand): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): easily create new properties (WebInspector.StylePropertiesSection.prototype._dblclickSelector): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): allow for editing selectors (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.StylePropertiesSection.prototype._doesSelectorAffectSelectedNode): helper to check if a selector applies to the selected node (WebInspector.BlankStylePropertiesSection.prototype._dblclick): (WebInspector.BlankStylePropertiesSection.prototype.startEditing): (WebInspector.BlankStylePropertiesSection.prototype.editingCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): morph into a StylePropertiesSection (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
- inspector/front-end/inspector.css:
- 12:33 AM Changeset in webkit [46689] by
-
- 2 edits in trunk/WebCore
2009-07-31 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883
Do not invoke handler function if proxy is null pointer (that would lead to access violation
anyway)
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
Aug 1, 2009:
- 11:05 PM Changeset in webkit [46688] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Darin Adler.
Make pixel test results more consistent across Mac OS X versions
- DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceImage): Avoid color correction when rendering the
images into graphics contexts, so that the actual color values are
compared, regardless of how the images are tagged.
- DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Set the window’s color space to the
main screen’s color space, even though the window is off-screen.
- 10:18 PM Changeset in webkit [46687] by
-
- 18 edits4 adds in trunk/WebCore
2009-08-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Reimplement Elements Panel so that its
interaction with DOM is serialized.
This is a first cut wuth read support for DOM elements
tree as well as some limited editing. No properties, no
styles, no search capabilities are implemented yet.
Set Preferences.useDOMAgent to true in order to try it
out, otherwise disabled by default.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setAttribute): (WebCore::InspectorBackend::removeAttribute): (WebCore::InspectorBackend::setTextNodeValue):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h: (WebCore::InspectorController::domAgent):
- inspector/InspectorDOMAgent.cpp: Added.
- inspector/InspectorDOMAgent.h: Added.
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/front-end/Callback.js: Added.
- inspector/front-end/DOMAgent.js: Added.
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 7:31 PM Changeset in webkit [46686] by
-
- 2 edits in trunk/WebKitTools
Try again to make the Qt build bot happy.
- BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created
directory to prevent 'zip' from failing due to the directory containing no files.
- 7:18 PM Changeset in webkit [46685] by
-
- 2 edits in trunk/WebKitTools
Try and make the Qt build bot happy.
- BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates
no output files at all and thus does not create the layout-test-results directory.
- 6:59 PM Changeset in webkit [46684] by
-
- 2 edits in trunk/WebKitTools
Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.
- Scripts/run-webkit-tests:
- 6:41 PM Changeset in webkit [46683] by
-
- 2 edits in trunk/JavaScriptCore
wtf/Threading.h: added include of Platform.h
Reviewed by Mark Rowe.
- wtf/Threading.h: Added #include "Platform.h" since this header uses PLATFORM() and other macros.
- 6:40 PM Changeset in webkit [46682] by
-
- 3 edits3 adds in trunk/WebKitTools
Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.
Reviewed by Sam Weinig and David D. Kilzer.
run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.
(processIsCrashing):
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool
that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.
- DumpRenderTree/mac/PerlSupport/Makefile: Added.
- Scripts/run-webkit-tests:
- 6:04 PM Changeset in webkit [46681] by
-
- 6 edits in trunk/WebCore
2009-08-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adele Peterson.
isContentEditable function in htmlediting.* must be removed
https://bugs.webkit.org/show_bug.cgi?id=27870
This patch removes isContentEditable function in htmlediting.cpp and
replaces all usage by calling Node::isContentEditable or its derivatives.
- editing/AppendNodeCommand.cpp: ditto (WebCore::AppendNodeCommand::AppendNodeCommand): ditto
- editing/IndentOutdentCommand.cpp: ditto (WebCore::IndentOutdentCommand::outdentParagraph): ditto
- editing/InsertNodeBeforeCommand.cpp: ditto (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): ditto
- editing/htmlediting.cpp: ditto (WebCore::enclosingNodeWithTag): ditto (WebCore::enclosingNodeOfType): ditto (WebCore::canMergeLists): ditto
- editing/htmlediting.h: Updated prototype
- 5:24 PM Changeset in webkit [46680] by
-
- 2 edits in trunk/WebKitTools
Display the reminder once rather than once per ChangeLog.
Reviewed by David D. Kilzer.
- Scripts/prepare-ChangeLog:
- 4:00 PM Changeset in webkit [46679] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r46668 as it was misinformed. ScopeChain is only used with placement new.
Rubber-stamped by Oliver Hunt.
- runtime/ScopeChain.h:
- 3:52 PM UpdatingBugzilla edited by
- (diff)
- 3:49 PM UpdatingBugzilla edited by
- (diff)
- 3:48 PM UpdatingBugzilla edited by
- (diff)
- 3:48 PM UpdatingBugzilla edited by
- (diff)
- 3:22 PM UpdatingBugzilla edited by
- (diff)
- 3:08 PM UpdatingBugzilla edited by
- (diff)
- 3:01 PM UpdatingBugzilla edited by
- (diff)
- 2:57 PM UpdatingBugzilla edited by
- (diff)
- 2:57 PM UpdatingBugzilla edited by
- (diff)
- 2:55 PM UpdatingBugzilla edited by
- (diff)
- 1:13 PM Changeset in webkit [46678] by
-
- 3 edits2 deletes in trunk/WebKitTools
Roll out r46676. Tiger is why we can't have nice things :-(
- 1:09 PM Changeset in webkit [46677] by
-
- 2 edits in trunk/LayoutTests
2009-08-01 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Mark Rowe.
Remove a non-existent test from the Windows Skipped List.
- platform/win/Skipped:
- 1:05 PM Changeset in webkit [46676] by
-
- 3 edits3 adds in trunk/WebKitTools
Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.
Reviewed by Sam Weinig.
run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.
(processIsCrashing):
- DumpRenderTree/mac/PerlSupport/Makefile: Added.
- Scripts/run-webkit-tests:
- 11:35 AM Changeset in webkit [46675] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Allow custom memory allocation control for JavaScriptCore's HashMap class
http://bugs.webkit.org/show_bug.cgi?id=27871
Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.
- wtf/RefPtrHashMap.h: (WTF::):
- 11:17 AM Changeset in webkit [46674] by
-
- 2 edits1 add in trunk/LayoutTests
2009-08-01 Brady Eidson <beidson@apple.com>
For my new test I landed last night, check in Tiger-specific results, and skip on Windows.
- platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
- platform/win/Skipped: Add to the skipped list because the failure needs exploration.
- 10:58 AM Changeset in webkit [46673] by
-
- 2 edits in trunk/LayoutTests
2009-08-01 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel.
Update test to work with multi-process message ports.
- fast/events/message-channel-gc.html:
- 7:29 AM Changeset in webkit [46672] by
-
- 2 edits in trunk/WebKitTools
resolve-ChangeLogs: add error checking to git ls-files command on close()
Reviewed by Eric Seidel.
Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.
- Scripts/resolve-ChangeLogs: Added error checking to close() after running git ls-files. Added error checking to all system() calls by checking for a non-zero WEXITSTATUS($?).
Changed " die;" expressions to "or die $!;". - 7:29 AM Changeset in webkit [46671] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
Reviewed by Eric Seidel.
- Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() and determineVCSRoot() to change directories to the root of the project before running the command and to provide a path for removeChangeLogArguments() to make sure any ChangeLog arguments on the command line are still found. (canonicalRelativePath): Added. Returns a canonical path (e.g., stripping 'dir/../' from the path) relative to the current directory. (removeChangeLogArguments): Added argument which contains a relative path that must be prepended to any ChangeLog arguments. Used canonicalRelativePath() and File::Spec->catfile() to construct a normalized, relative path to each file.
- 7:29 AM Changeset in webkit [46670] by
-
- 3 edits in trunk/WebKitTools
Implement VCSUtils::chdirReturningRelativePath()
Reviewed by Eric Seidel.
Step 2 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
- Scripts/VCSUtils.pm: (VCSUtils::chdirReturningRelativePath): Moved here from chdirAndGetDifference() in svn-create-patch.
- Scripts/svn-create-patch: Switched to use chdirReturningRelativePath() instead of chdirAndGetDifference(). (chdirAndGetDifference): Removed.
- 7:23 AM Changeset in webkit [46669] by
-
- 3 edits in trunk/WebKitTools
Implement VCSUtils::determineVCSRoot()
Reviewed by Eric Seidel.
Step 1 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
- Scripts/VCSUtils.pm: Removed reference to webkitdirs module. (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. (VCSUtils::determineGitRoot): Added. Based on code in commit-log-editor. (VCSUtils::determineVCSRoot): Implemented using determineGitRoot() and determineSVNRoot().
- Scripts/commit-log-editor: Replaced use of topLevelSourceDirectory() with determineVCSRoot(). Resorted use statements. (topLevelSourceDirectory): Removed.
- 1:19 AM Changeset in webkit [46668] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Allow custom memory allocation control for JavaScriptCore's ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834
Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.
- runtime/ScopeChain.h:
- 12:51 AM Changeset in webkit [46667] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833
Inherits RegExpConstructorPrivate class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/RegExpConstructor.cpp:152.
- runtime/RegExpConstructor.cpp:
- 12:37 AM Changeset in webkit [46666] by
-
- 2 edits in trunk/WebCore
2009-08-01 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix a message port handle always getting marked as reachable once it gets entangled.
No tests since this only arises with the Chromium multi-process message port implementation
which isn't in this repostiory.
- bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
- 12:23 AM Changeset in webkit [46665] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-01 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Add a regression test for a crash when a page has smart quotes in a
mime type.
- fast/parser/smart-quotes-in-tag-expected.txt: Added.
- fast/parser/smart-quotes-in-tag.html: Added.
Jul 31, 2009:
- 11:56 PM Changeset in webkit [46664] by
-
- 3 edits in trunk/WebKitTools
2009-07-31 Daniel Bates <dbates@intudata.com>
Reviewed by Eric Seidel.
Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are
defined in both File::Temp and POSIX.
This stops the warnings by preventing the "import" method of File::Temp from being called,
which would otherwise add these functions into the primary namespace. Note, "use POSIX"
will import these functions into the primary namespace anyway. We only need one instance
of these functions in our namespace (or we get redefinition warnings), so lets use the
one's in the POSIX package.
- Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
- Scripts/update-webkit-support-libs: ditto
- 11:43 PM Changeset in webkit [46663] by
-
- 2 edits in trunk/WebCore
2009-07-31 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Barth.
Fix Geolocation permission problem
https://bugs.webkit.org/show_bug.cgi?id=26993
- page/Geolocation.cpp: (WebCore::Geolocation::requestPermission):
- 11:29 PM Changeset in webkit [46662] by
-
- 2 edits in trunk/WebKitTools
2009-07-31 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915
- Scripts/build-webkit:
- 11:09 PM Changeset in webkit [46661] by
-
- 2 edits in trunk/WebCore
2009-07-31 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Eric Seidel.
Added project properties as needed by symbian platform
- WebCore.pro:
- 10:26 PM Changeset in webkit [46660] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-31 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
Resurrect the old GetTickCount implementation of currentTime, controlled by WTF_USE_QUERY_PERFORMANCE_COUNTER
currentSystemTime taken from older WebKit; currentTime written by Yong Li <yong.li@torchmobile.com>; cleanup by Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27848
- wtf/CurrentTime.cpp: (WTF::currentSystemTime): get current time with GetCurrentFT (WTF::currentTime): track msec elapsed since first currentSystemTime call using GetTickCount
- wtf/Platform.h:
- 9:07 PM Changeset in webkit [46659] by
-
- 2 edits in trunk/WebCore
2009-07-31 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
Fix compiler warning.
Initialize member variables in the correct order.
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- 9:07 PM Changeset in webkit [46658] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Holger Hans Peter Freyther.
The reason these four tests fail is a mystery to me right, but placing
them in the Skipped file and the Qt port is... for the first time ever,
finally green!
- platform/qt/Skipped:
- 8:43 PM Changeset in webkit [46657] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Eric Seidel.
Printing related test needs to go in Skipped for now so we can
get Qt buildbot green for first time.
- platform/qt/Skipped:
- 8:43 PM Changeset in webkit [46656] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Eric Seidel.
Sometimes they pass, sometimes they fail. In attempt to get Qt buildbot
completely green for first time I'm placing these two in the Skipped file.
- platform/qt/Skipped:
- 8:43 PM Changeset in webkit [46655] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos and Eric Seidel.
Place some audio related tests into the Skipped list in
attempt to get Qt buildbot finally green.
- platform/qt/Skipped:
- 7:58 PM Changeset in webkit [46654] by
-
- 2 edits in trunk/WebCore
2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix!
Unreviewed.
- page/win/PageWin.cpp:
- 7:38 PM Changeset in webkit [46653] by
-
- 3 edits in trunk/WebCore
2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>
Mac build fix.
Unreviewed.
- page/Page.cpp: Move setCanStartPlugins() from here...
- page/win/PageWin.cpp: (WebCore::Page::setCanStartPlugins): ... to here.
- 7:33 PM Changeset in webkit [46652] by
-
- 3 edits in trunk/WebKitTools
2009-07-31 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
check-webkit-style --git-commit has bugs if you select a commit in the past
https://bugs.webkit.org/show_bug.cgi?id=27908
- Scripts/check-webkit-style: (main): Made the git-commit command only select the first commit if a range is given (and print a warning).
- Scripts/modules/scm.py: (SCM::create_patch_from_local_commit): (SCM::create_patch_since_local_commit): (SCM::commit_locally_with_message): (SCM::discard_local_commits): Added an error messages in case these aren't overriden.
(Git::create_patch_since_local_commit):
Added this command to allow doing a diff of everything after a given commit.
- 6:40 PM Changeset in webkit [46651] by
-
- 2 edits in trunk/WebKitTools
2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>
Speculative Qt build fix. Not reviewed.
Add LayoutTestController::disableImageLoading() in jsobjects.h.
- DumpRenderTree/qt/jsobjects.h:
- 6:34 PM Changeset in webkit [46650] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip http/tests/misc/favicon-loads-with-images-disabled.html as
this requires resource load callbacks in Gtk DRT. I've raised bug
#27905 to track this.
- platform/gtk/Skipped:
- 6:13 PM Changeset in webkit [46649] by
-
- 16 edits in trunk
WebCore:
2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/5698113> Safari shouldn't auto-activate plug-ins in
background tabs (make Win consistent with Mac)
Reviewed by Anders Carlsson.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidFailToStartPlugin): Declare a new function to dispatch failures to start plug-ins.
- page/Page.cpp: (WebCore::Page::Page): Initialize new member variable. (WebCore::Page::addUnstartedPlugin): Add the PluginView to the set of unstarted plug-ins. (WebCore::Page::removeUnstartedPlugin): Remove the PluginView from the set of unstarted plug-ins. (WebCore::Page::setCanStartPlugins): If we can now start plug-ins, iterate the set of unstarted plug-ins, starting them. If a plug-in fails to start, dispatch a failed-to-start- plug-in error. Clear the list of unstarted plug-ins.
- page/Page.h: Added m_canStartPlugins to track whether we can currently start plug-ins. Added m_unstartedPlugins to keep track of plug-ins in the page that are waiting to be started. (WebCore::Page::canStartPlugins):
- plugins/PluginView.cpp: (WebCore::PluginView::start): m_mimeType is now a WebCore::String, so we call .utf8(). If NPP_New() fails, set m_status to reflect this; this used to be set by init(), but start() will not be called by init() if we are delaying start(). If NPP_New() succeeds, set m_status to reflect this, and call platformStart(). (WebCore::PluginView::startOrAddToUnstartedList): If we cannot start plug-ins, add this view to the Page's list of unstarted plug-ins and return true. Otherwise, call start() and return the result. (WebCore::PluginView::removeFromUnstartedListIfNecessary): If we've been started or we don't have a Page, return early. Remove ourselves from the Page's list of unstarted plug-ins. (WebCore::PluginView::bindingInstance): If we haven't been started yet, return 0. This matches the Mac behavior. (WebCore::PluginView::setParameters): If we find the "plug-ins page" parameter, record it; it may be used if we fail to start the plug-in. (WebCore::PluginView::PluginView): Initialize new members m_haveUpdatedPluginWidget. Initialize m_mimeType with mimeType directly; m_mimeType is now a WebCore::String.
- plugins/PluginView.h: Made start() public, so Page can call it when we start unstarted plug-ins. Changed m_mimeType from CString to String and added m_pluginsPage; these are needed by dispatchDidFailToStartPlugin(). (WebCore::PluginView::pluginsPage): Added for dispatchDidFailToStartPlugin(). (WebCore::PluginView::mimeType): Ditto. (WebCore::PluginView::url): Ditto.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Stubbed.
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): Stubbed.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart): Stubbed.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): Use m_haveUpdatedPluginWidget to ensure that we will call MoveWindow() and SetWindowRgn() to position the plug-in and set its clip rect if an earlier call to updatePluginWidget() was made before setPlatformPluginWidget() was called to set the plug-in's HWND. (WebCore::PluginView::~PluginView): Call removeFromUnstartedListIfNecessary() to remove the plug-in from the unstarted list if the plug-in is destroyed before it is started. (WebCore::PluginView::init): Call startOrAddtoUnstartedList to start the plug-in or, if plug-ins cannot be started, to add it to the list of plug-ins waiting to be started. Set m_status to indicate success; this is also set by start(), but that may be delayed, and we don't want the loader to dispatch a failed-to-start-plug-in error when we return from init(). (WebCore::PluginView::platformStart): Added; code moved from init(). This is now called by start() to perform any platform-specific tasks that need to take place after the plug-in has started. Added a call to updatePluginWidget() to ensure we position the plug-in and set its clip rect after the plug-in has started. Removed the setting of m_status; start() does this before calling this function (and we assert this at the head of the function).
WebKit/win:
2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
Part of <rdar://problem/5698113> Safari shouldn't auto-activate
plug-ins in background tabs (make Win consistent with Mac)
Reviewed by Adam Roben and Anders Carlsson.
- Interfaces/IWebViewPrivate.idl: Add setCanStartPlugins().
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Added; code moved from createPlugin(). Modified to obtain the plug-in's page URL, the plug-ins "plug-ins page" parameter value, and the plug-in's MIME type by calling getter functions on the passed PluginView. (WebFrameLoaderClient::createPlugin): If the plug-in status is not "success," call dispatchDidFailToStartPlugin().
- WebCoreSupport/WebFrameLoaderClient.h: Declare an override of dispatchDidFailToStartPlugin().
- WebView.cpp: (WebViewWndProc): Add a missing ) to a comment. (WebView::setCanStartPlugins): Call the Page's setCanStartPlugins() function.
- WebView.h:
- 5:50 PM Changeset in webkit [46648] by
-
- 3 edits in trunk/JavaScriptCore
Fixes the Windows release-PGO build.
Reviewed by Jon Honeycutt.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Suppresses the warning about unreachable code that we get by adding "return 0" to WTF::TCMalloc_PageHeap::runScavengerThread().
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::runScavengerThread): Fixes the error about the method not returning a value in the release-PGO build.
- 5:40 PM Changeset in webkit [46647] by
-
- 42 edits in trunk
WebCore:
2009-07-30 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Next step: Add casts for all the RenderTable classes and use them everywhere.
Also added a few uses in places that were still using static_cast.
Also made some virtual member functions private.
Also changed RenderTable::m_tableLayout to use OwnPtr.
- accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable): (WebCore::AccessibilityTableCell::rowIndexRange): (WebCore::AccessibilityTableCell::columnIndexRange): (WebCore::AccessibilityTableCell::titleUIElement):
- accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObject):
- accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::parentTable):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
- editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute):
- page/Frame.cpp: (WebCore::Frame::searchForLabelsAboveCell):
- page/mac/FrameMac.mm: (WebCore::Frame::searchForNSLabelsAboveCell):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::shouldScaleColumns):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
- rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): (WebCore::RenderObject::containingBlock):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedBottomBorder):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::table):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::paint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::recalcCells):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Use checked casts.
- rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr. (WebCore::RenderTable::addChild): Use checked cast. (WebCore::RenderTable::layout): Ditto. (WebCore::RenderTable::setCellWidths): Ditto. (WebCore::RenderTable::paintObject): Ditto. (WebCore::RenderTable::splitColumn): Ditto. (WebCore::RenderTable::appendColumn): Ditto. (WebCore::RenderTable::colElement): Ditto. (WebCore::RenderTable::recalcSections): Ditto. (WebCore::RenderTable::outerBorderBottom): Ditto. (WebCore::RenderTable::outerBorderLeft): Ditto. (WebCore::RenderTable::outerBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Ditto. (WebCore::RenderTable::sectionBelow): Ditto.
- rendering/RenderTable.h: Added checked cast. Made virtual functions private. Changed m_tableLayout to be a OwnPtr.
- rendering/RenderTableCell.h: Added checked cast.
- rendering/RenderTableCol.h: Ditto. Made virtual functions private.
- rendering/RenderTableRow.h: Ditto.
- rendering/RenderTableSection.h: Ditto.
WebKit/mac:
2009-07-30 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
- Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
- Misc/WebNSPasteboardExtras.mm: (imageFromElement): (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
- WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebFrame _accessibilityTree]):
- WebView/WebRenderNode.mm: (copyRenderNode): Use checked casts.
WebKit/win:
2009-07-30 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
- DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::isUserEdited): Use checked casts.
- 4:27 PM UpdatingBugzilla edited by
- (diff)
- 4:27 PM UpdatingBugzilla edited by
- (diff)
- 4:22 PM Changeset in webkit [46646] by
-
- 12 edits2 adds in trunk
WebCore:
2009-07-31 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.
People who want to avoid loading images generally want to avoid loading all images.
Test: http/tests/misc/favicon-loads-with-images-disabled.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): After committing the URL mapping, don't actually perform the load if images shouldn't be loading.
WebKitTools:
2009-07-31 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.
- DumpRenderTree/LayoutTestController.cpp: (disableImageLoadingCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::disableImageLoading):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::disableImageLoading):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::disableImageLoading): Stubbed for now.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::disableImageLoading): Ditto.
LayoutTests:
2009-07-31 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.
- http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
- http/tests/misc/favicon-loads-with-images-disabled.html: Added.
- 4:12 PM UpdatingBugzilla edited by
- (diff)
- 4:03 PM Changeset in webkit [46645] by
-
- 24 edits in trunk
2009-07-31 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Accelerated animations stutter on pages with lots of animations and 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=27884
This patch changes the strategy for synchronizing painting view the view,
and compositing layer updates. Previously the strategy was to disable screen
updates between the time we updated the layer tree, and painted the view. That
left screen updates disabled for too long (hundreds of milliseconds) in some
cases, causing animation stutter.
The new strategy is to batch up changes to the CA layer tree, and commit them
all at once just before painting happens (referred to as a "sync" in the code).
GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
the values stored in GraphicsLayer into the CA layer tree at commit time.
Compositing layers are then synced in FrameView::paintContents(). However, not
all style/layout changes will result in painting; to deal with style changes that
touch only compositing properties, we set up a runloop observer that takes care
of comitting layer changes when no painting happens.
- WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()
- loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
- page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not sync and returns false, since we only want to sync when layout is done.
(WebCore::FrameView::paintContents): syncCompositingState() before painting.
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): Call animationPaused() to notify the graphics layers about animation pausing.
- platform/graphics/FloatPoint3D.h: (WebCore::operator==): (WebCore::operator!=): Add missing comparison operators.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOpacity): (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.
(WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.
- platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue:): (WebCore::TransformAnimationValue:): (WebCore::KeyframeValueList:): (WebCore::KeyframeValueList::insert): Cleaned up versions of FloatValue and TransformValue, used to store information about keyframes values.
(WebCore::GraphicsLayer::contentsRect):
(WebCore::GraphicsLayer::setContentsRect):
ContentsRect is now a simple setter.
(WebCore::GraphicsLayer::addAnimation):
(WebCore::GraphicsLayer::removeAnimationsForProperty):
(WebCore::GraphicsLayer::removeAnimationsForKeyframes):
(WebCore::GraphicsLayer::pauseAnimation):
Simplified animation api.
(WebCore::GraphicsLayer::setGeometryOrientation):
(WebCore::GraphicsLayer::geometryOrientation):
setGeometryOrientation is now just a normal member variable.
(WebCore::GraphicsLayer::contentsOrientation): add a getter.
(WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.
- platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: Lots of cleanup and refactoring. Main points:
- Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
- Bitmask is used to store which properties have changed. More efficient than before.
- Simpler animation interface; simple setters are no longer confounded with animations.
- Refactored code that creates CA animations, and stores which animations are running.
- platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::size): (WebCore::TransformOperations::at): Useful accessors for size and indexed access.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerBacking.cpp: Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's contentsLayer. Adapt to GraphicsLayer's simpler animation API. Pass animation pausing through to the graphics layers. contentsBox() is no longer a callback via GraphicsLayerClient.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): (WebCore::RenderLayerCompositor::scheduleSync): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync" notifications, which travel up to WebKit and set up a runloop observer.
- 3:59 PM UpdatingBugzilla created by
- Initial contents
- 3:58 PM WikiStart edited by
- (diff)
- 3:46 PM Changeset in webkit [46644] by
-
- 3 edits in trunk/WebKitTools
2009-07-30 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847
Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
and make it handle the new arguments format proposed in the bug.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 3:29 PM Changeset in webkit [46643] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-31 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874
Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
- 2:57 PM Changeset in webkit [46642] by
-
- 2 edits in trunk/WebCore
2009-07-31 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Eric Seidel.
Geolocation clean up when no longer updating
https://bugs.webkit.org/show_bug.cgi?id=27888
When Geolocation::disconnectFrame() is called, need to call
Document::setUsingGeolocation(false) to mirror the true call
when it is set up.
When handling an error, and there are no more listeners, call
GeolocationService::stopUpdating().
- page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::handleError):
- 2:14 PM Changeset in webkit [46641] by
-
- 2 edits in trunk/WebKitTools
2009-07-30 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857
- Scripts/build-webkit:
- 2:02 PM Changeset in webkit [46640] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5
Reviewed by Eric Seidel.
- Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Specify which 'comment' form field to use when setting its value.
- 1:29 PM Changeset in webkit [46639] by
-
- 1 edit6 adds in trunk/LayoutTests
2009-07-31 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add new LocalStorage layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27778
These test behavior that I don't think was very well verified earlier.
- storage/domstorage/localstorage/complex-keys-expected.txt: Added.
- storage/domstorage/localstorage/complex-keys.html: Added.
A bunch of corner cases related to keys.
- storage/domstorage/localstorage/complex-values-expected.txt: Added.
- storage/domstorage/localstorage/complex-values.html: Added.
A bunch of corner cases related to values.
- storage/domstorage/localstorage/remove-item-expected.txt: Added.
- storage/domstorage/localstorage/remove-item.html: Added.
Test basic removeItem functionality.
- 1:21 PM Changeset in webkit [46638] by
-
- 3 edits in trunk/WebKit/win
2009-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
-Fix <rdar://problem/7104097>
Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create):
- WebCoreSupport/EmbeddedWidget.h:
- 1:12 PM Changeset in webkit [46637] by
-
- 2 edits in trunk/WebKitTools
2009-07-31 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849
Simple fix. Use .add() instead of .update()
- Scripts/bugzilla-tool:
- 11:40 AM Changeset in webkit [46636] by
-
- 2 edits in trunk/WebCore
2009-07-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Guard needs 's between #endif and ENABLE(DATAGRID)
https://bugs.webkit.org/show_bug.cgi?id=27862
Compiling this file causes a build break without this change.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp:
- 11:16 AM Changeset in webkit [46635] by
-
- 2 edits in trunk/LayoutTests
2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Re-Enable tests from Skipped that are passing correctly.
- platform/qt/Skipped:
- 10:07 AM Changeset in webkit [46634] by
-
- 1 edit45 adds in trunk/LayoutTests
2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add LayoutTest results from BuildBot output for tests that currently lack results under Qt.
- platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt.
- platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt.
- platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt.
- platform/qt/fast/borders/border-radius-constraints-expected.txt: Added.
- platform/qt/fast/box-shadow/inset-expected.txt: Added.
- platform/qt/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
- platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Added.
- platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
- platform/qt/fast/css/pseudo-cache-stale-expected.txt: Added.
- platform/qt/fast/css/rem-dynamic-scaling-expected.txt: Added.
- platform/qt/fast/css/rem-units-on-root-expected.txt: Added.
- platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
- platform/qt/fast/dynamic/window-scrollbars-test-expected.txt: Added.
- platform/qt/fast/forms/isindex-placeholder-expected.txt: Added.
- platform/qt/fast/forms/search-vertical-alignment-expected.txt: Added.
- platform/qt/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
- platform/qt/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
- platform/qt/fast/frames/frame-navigation-expected.txt: Added.
- platform/qt/fast/frames/frame-scrolling-attribute-expected.txt: Added.
- platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
- platform/qt/fast/gradients/crash-on-zero-radius-expected.txt: Added.
- platform/qt/fast/lists/ol-start-parsing-expected.txt: Added.
- platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
- platform/qt/fast/repaint/float-new-in-block-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/float-new-in-block-expected.txt.
- platform/qt/fast/text/international/khmer-selection-expected.txt: Added.
- platform/qt/fast/text/shadow-translucent-fill-expected.txt: Added.
- platform/qt/fast/text/text-letter-spacing-expected.txt: Added.
- platform/qt/plugins/netscape-dom-access-expected.txt: Added.
- platform/qt/svg/batik/filters/feTile-expected.txt: Added.
- platform/qt/svg/custom/createImageElement-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/createImageElement-expected.txt.
- platform/qt/svg/custom/createImageElement2-expected.txt: Added.
- platform/qt/svg/custom/js-update-image-and-display-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.txt.
- platform/qt/svg/custom/js-update-image-and-display2-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.txt.
- platform/qt/svg/custom/js-update-image-and-display3-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.txt.
- platform/qt/svg/custom/outer-svg-unknown-feature-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/outer-svg-unknown-feature-expected.txt.
- platform/qt/svg/filters/feMerge-expected.txt: Added.
- platform/qt/svg/filters/feOffset-expected.txt: Added.
- platform/qt/svg/filters/feTile-expected.txt: Added.
- platform/qt/svg/filters/subRegion-one-effect-expected.txt: Added.
- platform/qt/svg/filters/subRegion-two-effects-expected.txt: Added.
- 10:04 AM Changeset in webkit [46633] by
-
- 3 edits in trunk/WebCore
2009-07-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by George Staikos.
Consolidate GeoLocation code to send positions and errors
https://bugs.webkit.org/show_bug.cgi?id=27863
Create helper methods that will send positions and errors to either
one shots or watchers.
- page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPosition): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers):
- page/Geolocation.h:
- 9:52 AM Changeset in webkit [46632] by
-
- 2 edits in trunk/WebKit/qt
2009-07-31 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Build QtWebKit without benchmark tests for Qt < 4.5.
https://bugs.webkit.org/show_bug.cgi?id=27886
The QBENCHMARK macro is only available from 4.5 on,
so builds for Qt < 4.5 shouldn't try to build those.
- tests/tests.pro:
- 7:56 AM Changeset in webkit [46631] by
-
- 2 edits in trunk/WebKitTools
2009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Anders Carlsson.
Improve platform-detection in run-webkit-tests
This prevents miss-detection of mac-* over Qt/Mac.
- Scripts/run-webkit-tests:
- 7:37 AM Changeset in webkit [46630] by
-
- 2 edits in trunk/WebKit/qt
2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Fix warning by migrating use of QString.sprintf(...) to
QString.arg().arg()...
- WebCoreSupport/EditorClientQt.cpp: (dumpRange):
- 6:51 AM Changeset in webkit [46629] by
-
- 3 edits in trunk/LayoutTests
2009-07-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Tor Arne Vestbo.
Adding -webkit-animation-play-state back in following r46547.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 6:29 AM Changeset in webkit [46628] by
-
- 3 edits in trunk/WebKit/qt
2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Tor Arne Vestbø.
Expose the Offline Web Application Cache in the Qt API.
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setOfflineWebApplicationCachePath): (QWebSettings::offlineWebApplicationCachePath): (QWebSettings::setOfflineWebApplicationCacheQuota): (QWebSettings::offlineWebApplicationCacheQuota):
- Api/qwebsettings.h:
- 5:43 AM Changeset in webkit [46627] by
-
- 2 edits in trunk/WebCore
2009-07-31 Xan Lopez <xlopez@igalia.com>
Roll out previous change as it might be causing some weirdness in
the bots.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
- 5:06 AM Changeset in webkit [46626] by
-
- 2 edits in trunk/WebCore
2009-07-31 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix compiler warning.
https://bugs.webkit.org/show_bug.cgi?id=27851
GCC does not like multi-character character constants, so use the
explicit numerical value of 'BM' in the enum.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
- 12:21 AM Changeset in webkit [46625] by
-
- 2 edits in trunk/LayoutTests
Fix the test case that was landed in r46624.
- http/tests/misc/meta-refresh-stray-single-quote.html:
Jul 30, 2009:
- 11:54 PM Changeset in webkit [46624] by
-
- 3 edits3 adds in trunk
WebCore:
2009-07-30 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.
<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.
Test: http/tests/misc/meta-refresh-stray-single-quote.html
- platform/network/HTTPParsers.cpp: (WebCore::parseHTTPRefresh): Allow for a stray quote character at the start of the URL string.
LayoutTests:
2009-07-30 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.
<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.
- http/tests/misc/meta-refresh-stray-single-quote-expected.txt: Added.
- http/tests/misc/meta-refresh-stray-single-quote.html: Added.
- http/tests/misc/resources/success-notify-done.html: Added.
- 11:37 PM Changeset in webkit [46623] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Fix compiler warning.
GCC does not like C++-style comments in preprocessor directives.
- wtf/Platform.h:
- 11:15 PM Changeset in webkit [46622] by
-
- 4 edits in trunk/WebKit/gtk
2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792
Add frameName property to the WebKitWebNavigation object.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
- webkit/webkitwebnavigationaction.h:
- 10:38 PM Changeset in webkit [46621] by
-
- 5 edits in trunk/JavaScriptCore
2009-07-30 John McCall <rjmccall@apple.com>
Reviewed by Gavin Barraclough.
Optimize the X86_64 trampolines: avoid the need for filler arguments
and move the stub-args area closer to the stack pointer.
- jit/JIT.h: adjust patch offsets because of slight code-size change
- jit/JITCode.h: (JSC::JITCode::execute): don't pass filler args
- jit/JITStubs.cpp: (ctiTrampoline): (X86_64): push args onto stack, use args directly (ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement (ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
- jit/JITStubs.h: (JITStackFrame): (X86_64): move args area earlier (ctiTrampoline): remove filler args from prototype
- 7:57 PM Changeset in webkit [46620] by
-
- 13 edits in trunk/JavaScriptCore
2009-07-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Temporarily revert r46618 since this is b0rking on Linux.
- 7:29 PM Changeset in webkit [46619] by
-
- 2 edits in trunk/WebKitTools
Teach buildbot to detect test cases that are missing results.
Reviewed by Cameron Zwarich.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 7:20 PM Changeset in webkit [46618] by
-
- 13 edits in trunk/JavaScriptCore
2009-07-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )
This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
- bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/CodeBlock.h:
(JSC::):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::seenOnce):
(JSC::StructureStubInfo::setSeen):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::unlinkCall):
- Remove the "don't lazy link" stage of calls.
- jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- Remove the "don't lazy link" stage of calls.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- Remove the "don't lazy link" stage of calls.
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITStubs::):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
(WTF::PtrAndFlags::operator!):
(WTF::PtrAndFlags::operator->):
- Add ! and -> operators, add constuctor with pointer argument.
- 6:28 PM Changeset in webkit [46617] by
-
- 6 edits in trunk/WebCore
Bug 27828: Title attribute is not respected on option elements
Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.
Reviewed by Adele Peterson and Jon Honeycutt.
No tests added as it is not clear how to test a tool tip from DumpRenderTree.
- platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
the popup menu in RenderTextControlSingleLine.
- 5:52 PM Changeset in webkit [46616] by
-
- 2 edits in trunk/WebKitTools
Things work better when you create the correct directories.
- Scripts/run-webkit-tests:
- 5:22 PM Changeset in webkit [46615] by
-
- 2 edits in trunk/WebKitTools
Include some information about the error when we die.
- Scripts/run-webkit-tests:
- 4:51 PM Changeset in webkit [46614] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-30 Adam Treat <adam.treat@torchmobile.com>
Add expected results file for new test.
- platform/gtk/fast/forms/button-style-color-expected.txt: Added.
- 4:41 PM Changeset in webkit [46613] by
-
- 2 edits in trunk/WebKitTools
Ensure that the path exists before writing results to it.
Hopefully this will make the Windows build bot happy.
- Scripts/run-webkit-tests:
- 4:32 PM Changeset in webkit [46612] by
-
- 1 edit1 add in trunk/LayoutTests
2009-07-30 Adam Treat <adam.treat@torchmobile.com>
Add expected results file for new test.
- platform/mac/fast/forms/button-style-color-expected.txt: Added.
- 4:21 PM Changeset in webkit [46611] by
-
- 2 edits in trunk/WebCore
2009-07-30 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Remove ChromeClientChromium::setToolTip().
https://bugs.webkit.org/show_bug.cgi?id=27861
This patch is just to remove a temporarily introduced overloaded empty
virtual function. No test is needed.
- page/chromium/ChromeClientChromium.h:
- 4:11 PM Changeset in webkit [46610] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Fixed failing tests seen on Windows buildbot.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result, regardless of compiler. gcc on mac uses 32-bit values for bool, but gcc on linux and MSVC on Windows use 8-bit values.
- 4:08 PM Changeset in webkit [46609] by
-
- 25 edits2 adds in trunk
2009-07-30 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
ApplicationCacheHost refactoring.
1) Better encapsulate the interfaces between webcore common code
and the appcache system within a new class ApplicationCacheHost.
2) Use that interface throughout the loader system, replacing inline appcache logic.
3) Implement the interface in terms of webcore's appcache system.
4) Add the new files to various makefiles.
5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp
No new features, no new tests. The existing layout tests all pass.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::setPrimaryLoadComplete):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::load):
- loader/MainResourceLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didFail):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/ApplicationCacheHost.cpp: Added.
- loader/appcache/ApplicationCacheHost.h: Added.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::transferApplicationCache):
- loader/appcache/ApplicationCacheStorage.h:
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::disconnectFrame): (WebCore::DOMApplicationCache::applicationCacheHost): (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::update): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventName): (WebCore::DOMApplicationCache::toEventType):
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::): (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): (WebCore::DOMApplicationCache::~DOMApplicationCache):
- platform/KURLGoogle.cpp: (WebCore::protocolHostAndPortAreEqual):
- 4:05 PM Changeset in webkit [46608] by
-
- 4 edits in trunk/LayoutTests
2009-07-30 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Mark Rowe.
Revert previous commit to test out new functionality of buildbots and
run-webkit-tests made possible by r46607.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 3:54 PM Changeset in webkit [46607] by
-
- 2 edits in trunk/WebKitTools
Teach run-webkit-tests to always store the actual results in the results directory for new tests.
Reviewed by Adam Treat and Jon Honeycutt.
This allows us to give a working link to the results from the result summary page, even if we're
not generating new results in to the tree.
- Scripts/run-webkit-tests:
- 3:44 PM Changeset in webkit [46606] by
-
- 2 edits in trunk/WebCore
2009-07-30 Simon Fraser <Simon Fraser>
Minor change to earlier commit suggested by Darin Adler.
Use the variable rather than dereferencing 'it' again.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- 3:28 PM Changeset in webkit [46605] by
-
- 4 edits in trunk/LayoutTests
2009-07-30 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Add new test with platform specific results to the Skipped files of ports
that haven't generated them yet. This is to make the buildbot green again.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 2:50 PM Changeset in webkit [46604] by
-
- 3 edits in trunk/WebCore
Bug 27854 - crash at WebCore::AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=27854
- 2:47 PM Changeset in webkit [46603] by
-
- 3 edits in trunk/WebCore
2009-07-30 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Animation with a timing function property in a keyframe eats CPU
https://bugs.webkit.org/show_bug.cgi?id=27856
<rdar://problem/7104476> Animation demo uses lots of CPU
Don't include animation-timing-function in the list of properties to
animate in a keyframe animation, because this property is not animated;
instead, it describes the timing function to apply to this keyframe.
This prevents the animation code from thinking that there's a property
that it has to software-animate, and thus firing the animation timer frequently.
Not testable because there is no visible impact.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Don't add CSSPropertyWebkitAnimationTimingFunction to the list of properties to animate.
- page/animation/KeyframeAnimation.cpp (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): Add a comment
- 2:37 PM Changeset in webkit [46602] by
-
- 2 edits in trunk/WebKitTools
Add a Qt Linux build bot.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 2:18 PM Changeset in webkit [46601] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Windows build fix: added missing symbols on Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:16 PM Changeset in webkit [46600] by
-
- 5 edits2 adds in trunk
WebCore:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Apply colour style to buttons that use Theme settings in Qt.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):
LayoutTests:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add Button Colour style test and results for Qt based upon fix for bug.
Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
which also passes with the the bug fix.
- fast/forms/button-style-color.html: Added.
- platform/qt/Skipped:
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/qt/fast/forms/button-style-color-expected.txt: Added.
- 2:05 PM Changeset in webkit [46599] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Windows build fix: removed stale symbols on Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 1:57 PM Changeset in webkit [46598] by
-
- 63 edits3 adds in trunk
Merged nitro-extreme branch into trunk.
- 1:57 PM Changeset in webkit [46597] by
-
- 2 edits in trunk/WebKitTools
2009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Roben.
Add --minimal option to webkit-build.
https://bugs.webkit.org/show_bug.cgi?id=27852
This option disables all optional build features unless
they are explicitly enabled.
- Scripts/build-webkit:
- 12:31 PM Changeset in webkit [46596] by
-
- 3 edits in trunk/WebCore
2009-07-30 Dean McNamee <deanm@chromium.org>
Reviewed by Dimitri Glazkov.
Don't try to hash member function pointers, instead use a precomputed value based on the field.
https://bugs.webkit.org/show_bug.cgi?id=27843
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo): (WebCore::PODTypeWrapperCacheInfo::operator==): (WebCore::PODTypeWrapperCacheInfoHash::hash): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
- 12:30 PM Changeset in webkit [46595] by
-
- 2 edits in trunk/WebCore
2009-07-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Simon Fraser.
Fix compiler warning.
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
- 12:20 PM Changeset in webkit [46594] by
-
- 7 edits in trunk/WebCore
2009-07-29 Matt Perry <mpcomplete@chromium.org>
Reviewed by Adam Barth.
Add a way to register V8 extensions for Isolated Worlds only.
https://bugs.webkit.org/show_bug.cgi?id=27785
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld): (WebCore::ScriptController::evaluateInNewContext):
- bindings/v8/ScriptController.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
- bindings/v8/V8IsolatedWorld.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- 12:07 PM Changeset in webkit [46593] by
-
- 2 edits in trunk/WebCore
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add previously defined out support to PopupMenuQt for marking entries as
disabled and for selecting the desired item.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
- 11:44 AM Changeset in webkit [46592] by
-
- 34 edits in trunk/WebCore
2009-07-30 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Next step: Add new toRenderWidget cast and use it everywhere.
Use checked casts in all the places that were using static_cast
but there is a checked cast available.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::widget): (WebCore::AccessibilityRenderObject::widgetForAttachmentView): (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):
- dom/Document.cpp: (WebCore::widgetForNode): (WebCore::Document::setFocusedNode):
- html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::subframeForTargetNode): (WebCore::EventHandler::handleWheelEvent):
- page/Frame.cpp: (WebCore::isFrameElement):
- page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
- page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
- page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
- page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
- page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- platform/chromium/ClipboardChromium.cpp: (WebCore::getCachedImage):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
- platform/qt/ClipboardQt.cpp: (WebCore::getCachedImage):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
- platform/win/ClipboardWin.cpp: (WebCore::getCachedImage):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
- rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::addChildToContinuation):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): Use checked cast instead of static_cast.
- rendering/RenderWidget.h: Added toRenderWidget.
- 11:25 AM Changeset in webkit [46591] by
-
- 6 edits in trunk/WebCore
2009-07-30 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: some files modified to build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27816
- 11:08 AM Changeset in webkit [46590] by
-
- 13 edits in trunk/WebCore
2009-07-30 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779
- 10:52 AM Changeset in webkit [46589] by
-
- 2 edits in trunk/WebCore
2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Ariya Hidayat.
Improve efficiency by rewriting code doing three hash table
lookups, which can be replaced by just one as pointed out
by Darin Adler.
Though being slightly less clear, this should be considerable
faster.
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::remove):
- 10:50 AM Changeset in webkit [46588] by
-
- 3 edits in trunk/WebCore
2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Gustavo Noronha.
[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=27651
Removed unneeded includes (gdk.h and gtk.h) and added glib.h and cairo.h instead.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 10:38 AM Changeset in webkit [46587] by
-
- 5 edits in trunk/WebCore
2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Gustavo Noronha.
[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=27651
Fixed many code style issues pointed by WebKitTools/Scripts/modules/cpplint.py
No functionality change at all.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp:
- platform/graphics/gtk/VideoSinkGStreamer.h:
- 9:43 AM Changeset in webkit [46586] by
-
- 3 edits in trunk/WebCore
Allow to explicitly choose a preferred plugin for a mimetype.
https://bugs.webkit.org/show_bug.cgi?id=27651
When the preferred plugin is set for a specific MIME type, it will be
always picked up, regardless of its version, quirks etc.
Client applications may want to use that API to resolve mimetype
ambiguity in a custom way, rather than in the default way that is
currently used in WebKit.
- 9:32 AM Changeset in webkit [46585] by
-
- 2 edits in trunk/WebKitTools
[Qt] Fix build with GCC 4.4.
- 9:31 AM Changeset in webkit [46584] by
-
- 2 edits in trunk/WebCore
[Qt] Fix build with Qt 4.4 after r46535.
- 9:31 AM Changeset in webkit [46583] by
-
- 2 edits in trunk/WebKit/qt
2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Add missing Q_OBJECT to class inheriting from QObject.
- tests/qwebframe/tst_qwebframe.cpp:
- 9:31 AM Changeset in webkit [46582] by
-
- 2 edits in trunk/WebKit/qt
2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Fix indentation.
- tests/qwebframe/tst_qwebframe.cpp:
- 9:05 AM Changeset in webkit [46581] by
-
- 3 edits2 adds in trunk
2009-07-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623
Test: media/media-load-event.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument):
Only schedule load when element's network state is NETWORK_EMPTY.
2009-07-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623
- media/media-load-event-expected.txt: Added.
- media/media-load-event.html: Added.
- 7:41 AM SpecSupport edited by
- Added entries for XSLT 2.0 and XPath 2.0. Although each spec's v1.0 … (diff)
- 7:07 AM Changeset in webkit [46580] by
-
- 3 edits in trunk/WebCore
2009-07-30 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Cache v8 strings when converting from WebCore::String to v8 string.
https://bugs.webkit.org/show_bug.cgi?id=27655
- bindings/v8/V8Binding.cpp: (WebCore::v8String): now just immediately calls v8ExternalString (WebCore::enableStringImplCache): enables caching of conversions from WebCore::StringImpl to v8::String (WebCore::makeExternalString): utilty function to create external v8::String out of WebCore::String (WebCore::getStringCache): static function to access string cache (WebCore::cachedStringCallback): callback for weak handles of v8::Strings stored in the cache (WebCore::v8ExternalString): if caching enabled, checks if there is already v8::String for the given WebCore::StringImpl. If present, returns it, otherwise creates a new v8 external string.
- bindings/v8/V8Binding.h:
- 6:11 AM Changeset in webkit [46579] by
-
- 4 edits in trunk/WebKitTools
2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Support pixel tests in DumpRenderTree for the Qt port.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::setDumpPixels): (WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/main.cpp: (main):
- 6:01 AM Changeset in webkit [46578] by
-
- 2 edits in trunk/WebKit/qt
2009-07-30 Volker Hilsheimer <volker.hilsheimer@nokia.com>
Reviewed by Simon Hausmann.
Fix documentation links to examples.
- Api/qwebview.cpp:
- 5:59 AM Changeset in webkit [46577] by
-
- 3 edits2 adds in trunk
ChangeLog:
2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Adding ImageDiff project file.
- WebKit.pro: Added ImageDiff.pro.
WebKitTools/ChangeLog:
2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement ImageDiff.
- DumpRenderTree/qt/ImageDiff.cpp: Added.
- DumpRenderTree/qt/ImageDiff.pro: Added.
- 5:48 AM Changeset in webkit [46576] by
-
- 2 edits in trunk/WebKit/qt
2009-07-30 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Allocate MainWindow on heap in robotized QtLauncher as well.
- QtLauncher/main.cpp: (main):
- 4:24 AM Changeset in webkit [46575] by
-
- 2 edits in trunk/WebKitTools
2009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
build-webkit: Reorder logic for determining the baseProductDir
We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.
Then we add the git branch if the git branch build option is enabled.
Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.
Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
hence the normal if and not elsif in the last two blocks.
- Scripts/webkitdirs.pm:
- 12:52 AM Changeset in webkit [46574] by
-
- 3 edits in trunk/WebCore
2009-07-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=25535
[GTK] object:state-changed:checked events missing for radio buttons and checkboxes
Implement state-changed:checked for radio buttons and checkboxes.
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):
- 12:13 AM Changeset in webkit [46573] by
-
- 2 edits in trunk/WebCore
2009-07-30 Xan Lopez <xlopez@igalia.com>
Forgot the 'break'.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
- 12:06 AM Changeset in webkit [46572] by
-
- 2 edits in trunk/WebCore
2009-07-30 Xan Lopez <xlopez@igalia.com>
Try to fix Mac build.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
- 12:00 AM Changeset in webkit [46571] by
-
- 2 edits in trunk/WebCore
2009-07-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Adam Barth.
Add missing enumeration value to switch.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
Jul 29, 2009:
- 6:10 PM Changeset in webkit [46570] by
-
- 13 edits in trunk
WebCore:
2009-07-29 Jian Li <jianli@chromium.org>
Reviewed by Darin Adler.
Workers need to throw an exception when presented with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=27770
Tests covered by worker-constructor.html and worker-redirect.html.
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- workers/Worker.cpp: (WebCore::Worker::Worker):
- workers/Worker.h: (WebCore::Worker::create):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::createResourceRequest):
- workers/WorkerScriptLoader.h:
LayoutTests:
2009-07-29 Jian Li <jianli@chromium.org>
Reviewed by Darin Adler.
Workers need to throw an exception when presented with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=27770
Update worker-constructor.html and worker-redirect.html per the behavior change.
- fast/workers/worker-constructor-expected.txt:
- fast/workers/worker-constructor.html:
- http/tests/workers/worker-redirect-expected.txt:
- http/tests/workers/worker-redirect.html:
- 5:33 PM Changeset in webkit [46569] by
-
- 2 edits in trunk/WebCore
2009-07-29 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
(REGRESSION: r46039) Should restore previous connections-per-host limit for non-http(s) hosts
https://bugs.webkit.org/show_bug.cgi?id=27822 and <rdar://problem/7091659>
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): For non-http(s) hosts, restore the previous behavior of only limiting connections while parsing and still trying to figure out stylesheet urls.
- 5:17 PM Changeset in webkit [46568] by
-
- 1 edit2 adds in trunk/WebCore
2009-07-29 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: Add WebCore/page/wince/FrameWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27729
- 5:13 PM Changeset in webkit [46567] by
-
- 5 edits2 adds8 deletes in trunk
WebCore:
2009-07-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809
The patch primarily rebaselines the tests but also fixes the bug in currentlyHasStyle.
To determine that a particular text decoration is present, currentlyHasStyle should refer to
-webkit-text-decorations-in-effect to take care of styles set by u, s, strike tags and ancestors' CSS.
We also need to update layout to accommodate the changes made within ApplyStyleCommand.
- editing/ApplyStyleCommand.cpp: ditto (WebCore::StyleChange::currentlyHasStyle): ditto
LayoutTests:
2009-07-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809
Since new behavior is consistent with Firefox, we rebaseline the test cases.
The patch converts remove-underline-from-stylesheet and remove-underline-in-bold to dumpAsText tests
with markup printed explicitly because pixel tests did not detect the disappearance of underline.
- editing/style/remove-underline-from-stylesheet-expected.txt: Added.
- editing/style/remove-underline-from-stylesheet.html:
- editing/style/remove-underline-in-bold-expected.txt: Added.
- editing/style/remove-underline-in-bold.html:
- platform/mac/editing/style/remove-underline-from-stylesheet-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-from-stylesheet-expected.png: Removed.
- platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
- platform/mac/editing/style/remove-underline-in-bold-expected.checksum: Removed.
- platform/mac/editing/style/remove-underline-in-bold-expected.png: Removed.
- platform/mac/editing/style/remove-underline-in-bold-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
- platform/qt/editing/style/remove-underline-in-bold-expected.txt: Removed.
- 5:08 PM Changeset in webkit [46566] by
-
- 4 edits in trunk/WebCore
2009-07-29 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: changes to platform/text files
https://bugs.webkit.org/show_bug.cgi?id=27715
- 5:08 PM Changeset in webkit [46565] by
-
- 4 edits in trunk/WebKit
<http://webkit.org/b/27788> Don't export WebPluginController.h as a private header
Reviewed by Mark Rowe.
WebKit:
WebPluginController.h includes WebPluginContainerCheck.h, which
is not a private header. Since WebPluginController.h doesn't
appear to be used anywhere, remove its private header status.
- WebKit.xcodeproj/project.pbxproj: Remove private header attribute from WebPluginController.h.
WebKit/mac:
- Plugins/WebPluginController.h: Changed #import of WebPluginContainerCheck.h to use a framework-style include in case other platforms wish to export WebPluginController.h as a private header.
- 4:48 PM Changeset in webkit [46564] by
-
- 2 edits in trunk/WebCore
2009-07-29 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Roben.
FIX: HDC leaks in PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=27817
- 4:48 PM Changeset in webkit [46563] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches
Reviewed by David Levin.
- Scripts/bugzilla-tool: (LandPatchesFromBugs.init): Added --no-close switch. (LandPatchesFromBugs.land_patches): Don't close the bug if the --no-close switch was used. Always clear the review+ flag on every landed patch using the commit_text message when cleared. This prevents patches from showing up in the commit queue if reopened and provides consistency with all landed patches.
- Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Added.
- 4:42 PM Changeset in webkit [46562] by
-
- 2 edits in trunk/LayoutTests
2009-07-29 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Added ol-start-parsing.html since it has no result yet.
- 4:29 PM Changeset in webkit [46561] by
-
- 3 edits4 adds in trunk
2009-07-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810
Test: fast/lists/ol-start-parsing.html
- html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute): Check the result of toInt and use the value 1 if it failed to parse. Before we were getting toInt's default behavior, which is to return 0.
2009-07-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810
Couldn't make a text-only test because list numbers do not show up in
text dumps. This matches the other fast/lists tests.
- fast/lists/ol-start-parsing.html: Added.
- platform/mac/fast/lists/ol-start-parsing-expected.checksum: Added.
- platform/mac/fast/lists/ol-start-parsing-expected.png: Added.
- platform/mac/fast/lists/ol-start-parsing-expected.txt: Added.
- 3:49 PM Changeset in webkit [46560] by
-
- 2 edits in trunk/WebKit/win
Was doing the build fix wrong, NotImplemented.h is in WebCore.
- 3:32 PM Changeset in webkit [46559] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- 3:12 PM Changeset in webkit [46558] by
-
- 21 edits1 add in trunk
WebCore:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): Tell the testing harness that the window object is ready.
- loader/EmptyClients.h: Empty class support for SVG. (WebCore::EmptyInspectorClient::inspectorWindowObjectCleared):
WebKit/gtk:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::inspectorWindowObjectCleared):
- WebCoreSupport/InspectorClientGtk.h:
WebKit/mac:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::inspectorWindowObjectCleared): Send the delegate callback.
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]):
- WebView/WebViewPrivate.h: The delegate SPI.
WebKit/qt:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorWindowObjectCleared):
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::inspectorWindowObjectCleared): Empty definition to let Windows compile but we should implement this at some point so that the tests can be run on Windows too.
- WebCoreSupport/WebInspectorClient.h:
- 2:45 PM Changeset in webkit [46557] by
-
- 2 edits in trunk/WebCore
Fix Windows build breakage.
- 2:44 PM Changeset in webkit [46556] by
-
- 3 edits in trunk/LayoutTests
2009-07-29 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Update getComputedStyle expected results on Windows to match updated Mac results.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 2:35 PM Changeset in webkit [46555] by
-
- 6 edits in trunk/WebCore
Bug 27807 - AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807
- 1:53 PM Changeset in webkit [46554] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command
Reviewed by Eric Seidel.
- Scripts/bugzilla-tool: (PostDiffAsPatchToBug.execute): Changed default patch name from "patch" to "Patch v1". (PostCommitsAsPatchesToBug.init): Added -m/--description switch. (PostCommitsAsPatchesToBug.execute): Use description provided by -m/--description switch first, else fall back to the commit message.
- 1:35 PM Changeset in webkit [46553] by
-
- 9 edits in trunk/WebCore
Reviewed by Simon Fraser.
Inset box shadows are incorrectly accounted for in visual overflow
computations
https://bugs.webkit.org/show_bug.cgi?id=27811
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Use
getBoxShadowHorizontalExtent().
(WebCore::InlineFlowBox::placeBoxesVertically): Use
getBoxShadowVerticalExtent(). Removed duplicate code to get the
text-shadow overflow.
(WebCore::InlineFlowBox::paint): Use getBoxShadowHorizontalExtent().
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Use
getBoxShadowVerticalExtent().
(WebCore::RenderBlock::overflowWidth): Use
getBoxShadowHorizontalExtent().
(WebCore::RenderBlock::overflowLeft): Ditto.
(WebCore::RenderBlock::overflowTop): Use getBoxShadowVerticalExtent().
(WebCore::RenderBlock::overflowRect): Use getBoxShadowExtent().
(WebCore::RenderBlock::layoutBlock): Ditto.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Exclude inset shadows.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Use
getBoxShadowHorizontalExtent() and getBoxShadowVerticalExtent().
(WebCore::RenderObject::adjustRectForOutlineAndShadow): Exclude inset
shadows.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Also assert that text-shadows are
not inset.
(WebCore::RenderStyle::getBoxShadowExtent): Added. Excludes inset
shadows.
(WebCore::RenderStyle::getBoxShadowHorizontalExtent): Ditto.
(WebCore::RenderStyle::getBoxShadowVerticalExtent): Ditto.
- rendering/style/RenderStyle.h:
- 1:26 PM Changeset in webkit [46552] by
-
- 2 edits in trunk/LayoutTests
2009-07-29 Brady Eidson <beidson@apple.com>
Rubber-stamped by Mark Rowe
- platform/gtk/Skipped: Disable the new test on GTK, as they don't dump resource load callbacks in their DumpRenderTree.
- 1:13 PM Changeset in webkit [46551] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-29 Brady Eidson <beidson@apple.com>
Rubber-stamped by Jon Honeycutt
Check in Tiger-specific results for the new test, as it is known they send willCacheResponse
callbacks in a different order.
- platform/mac-tiger/http/tests/loading: Added.
- platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Added.
- 1:07 PM Changeset in webkit [46550] by
-
- 2 edits in trunk/LayoutTests
2009-07-29 Brady Eidson <beidson@apple.com>
Adding my new test to the Windows skipped list until I can figure out what's going on.
- platform/win/Skipped:
- 12:48 PM Changeset in webkit [46549] by
-
- 4 edits2 adds in trunk
2009-07-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix crash when an element with display: table-row is composited (e.g. via a 3d-transform)
https://bugs.webkit.org/show_bug.cgi?id=27796
Avoid repainting when a layer becomes composited if the renderer is not parented
yet, because it makes no sense to do so.
If the table row is a repaint container, default to the RenderBox implementation
of clippedOverflowRectForRepaint(), because we cannot hand off the repaint rect
computation to something that is above the repaint container.
Test: fast/table/table-row-compositing-repaint-crash.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- 11:22 AM Changeset in webkit [46548] by
-
- 4 edits4 adds in trunk
WebCore:
2009-07-29 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET
Test: http/tests/loading/redirect-methods.html
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
LayoutTests:
2009-07-29 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET
- http/tests/loading/redirect-methods-expected.txt: Added.
- http/tests/loading/redirect-methods.html: Added.
- http/tests/loading/resources/redirect-methods-form.html: Added.
- http/tests/loading/resources/redirect-methods-result.php: Added.
- 11:03 AM Changeset in webkit [46547] by
-
- 14 edits2 adds in trunk
Adding -webkit-animation-play-state back in
https://bugs.webkit.org/show_bug.cgi?id=26867
We've decided to keep -webkit-animation-play-state. So this
just adds back in the code from https://bugs.webkit.org/show_bug.cgi?id=22907.
- 10:02 AM Changeset in webkit [46546] by
-
- 2 edits in trunk/WebCore
2009-07-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Expose the default plugin directories and the current directory set of
the plugin database as public API.
- plugins/PluginDatabase.h: (WebCore::PluginDatabase::pluginDirectories):
- 9:30 AM Changeset in webkit [46545] by
-
- 2 edits in trunk/WebCore
2009-07-29 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[chromium] Font size for current time display in media controls panel
is affected by body font size.
https://bugs.webkit.org/show_bug.cgi?id=27799
Fixing the problem of rendering by explicitly setting the font size
for the time displays.
No new tests since this is covered by existing media tests.
- css/mediaControlsChromium.css:
- 9:30 AM Changeset in webkit [46544] by
-
- 2 edits in trunk/WebCore
2009-07-29 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by David Levin.
Update WebCore/page/ContextMenuController.cpp to conform to WebKit
Style Guidelines as identified by cpp_style.py.
https://bugs.webkit.org/show_bug.cgi?id=27613
- page/ContextMenuController.cpp: (WebCore::openNewWindow): (WebCore::ContextMenuController::contextMenuItemSelected):
- 9:17 AM Changeset in webkit [46543] by
-
- 2 edits in trunk/WebCore
2009-07-29 Dean McNamee <deanm@chromium.org>
Reviewed by Dimitri Glazkov.
Removed unused wrapCPointer/extractCPointer from the v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27805
- bindings/v8/V8DOMWrapper.h:
- 8:13 AM Changeset in webkit [46542] by
-
- 2 edits in trunk/WebKitTools
2009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Dave Levin.
Make check-webkit-style support files as arguments.
https://bugs.webkit.org/show_bug.cgi?id=27549
- Scripts/check-webkit-style: Support files as argument. Change documentation and use basename on the binary name when used in the documentation. Also do not die when printing something containing non-ASCII characters.
- 7:54 AM Changeset in webkit [46541] by
-
- 2 edits in trunk/WebCore
2009-07-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Expose the PluginDatabase::pluginForMIMEType() function as public API.
https://bugs.webkit.org/show_bug.cgi?id=27651
It can be used to determine the appropriate plugin for a mime type,
without guessing the mimetype from the extension.
- plugins/PluginDatabase.h:
- 7:36 AM Changeset in webkit [46540] by
-
- 4 edits in trunk/WebCore
2009-07-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
Allow to enable/disable particular plugin packages.
https://bugs.webkit.org/show_bug.cgi?id=27651
Disabled plugins will not be picked up when looking for a plugin
supporting the requested mimetypes.
Client applications may want to use that API to disable specific
plugins.
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::pluginForMIMEType): (WebCore::PluginDatabase::MIMETypeForExtension):
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::PluginPackage): (WebCore::PluginPackage::setEnabled):
- plugins/PluginPackage.h: (WebCore::PluginPackage::isEnabled):
- 6:18 AM Changeset in webkit [46539] by
-
- 12 edits in trunk
2009-07-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Adam Treat.
[WML] Running WML tests in random order multiple times exposes subtle bugs
https://bugs.webkit.org/show_bug.cgi?id=27801
Some changes to fix random order WML tests, simplilfy WMLTestCase.js and reset testDocument
properly in enter-first-card-with-events.js. fast/wml/err-multi-access.wml still creates a layout
test difference on consecutive runs, though that's related to bug 27721, which has to be fixed first.
- wml/resources/WMLTestCase.js:
- wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
2009-07-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Adam Treat.
[WML] Running WML tests in random order multiple times exposes subtle bugs
https://bugs.webkit.org/show_bug.cgi?id=27801
Remove superflous assertions regarding the parent node. Under certain circumstances
these can even fire (related to garbage collection while destructing). Fixes random order
WML tests (run-webkit-tests fast/wml wml http/tests/wml fast/wml ... --random)
The wml/enter-first-card-with-events.html test relied on a bug in our implementation of
WMLPageState::reset() - the history stack should still contain the current card afterwards.
Fix that bug by preserving the first item in BackForwardList::clearWMLPageHistory().
- history/BackForwardList.cpp: Preserve first item in history stack, as demanded by the spec. (WebCore::BackForwardList::clearWMLPageHistory):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
- wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
- wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent):
- wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
- wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
- wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
- wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
- 4:35 AM Changeset in webkit [46538] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
Reviewed by David Levin.
Implement "create-bug" command for bugzilla-tool.
- Scripts/bugzilla-tool: Added CreateBug class. (CreateBug.init): Added. (CreateBug.create_bug_from_commit): Added. (CreateBug.create_bug_from_patch): Added. (CreateBug.prompt_for_bug_title_and_comment): Added. (CreateBug.execute): Added. (BugzillaTool.init): Added create-bug command.
- Scripts/modules/bugzilla.py: (Bugzilla.prompt_for_component): Added. (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. (Bugzilla.create_bug_with_patch): Added.
- 4:18 AM Changeset in webkit [46537] by
-
- 12 edits1 add in trunk
2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel and Xan Lopez.
[Gtk] Enable http/tests/appcache tests
https://bugs.webkit.org/show_bug.cgi?id=27674
- GNUmakefile.am: Add webkit/webkitapplicationcache.cpp
Enable passing http/tests/appcache tests.
- platform/gtk/Skipped:
Add 'enable-offline-web-application-cache' WebSetting to enable
or disable the appcache. Also, Add appcache SPI for DRT to use.
- webkit/webkitapplicationcache.cpp: Added. (webkit_application_cache_set_maximum_size):
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
Add support for testing http/tests/appcache tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
- 3:50 AM Changeset in webkit [46536] by
-
- 3 edits in trunk/LayoutTests
2009-07-29 Simon Hausmann <simon.hausmann@nokia.com>
Update Qt-specific results for computed-style tests, like in r46512.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 3:33 AM Changeset in webkit [46535] by
-
- 8 edits in trunk/WebCore
2009-07-29 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=26848
[Qt] ResourceHandle::willLoadFromCache needs to be implemented QtWebKit.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::willLoadFromCache):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- 2:53 AM Changeset in webkit [46534] by
-
- 2 edits in trunk/WebCore
2009-07-29 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
Media control panel for <video> in MediaDocument is mis-placed
https://bugs.webkit.org/show_bug.cgi?id=27798
Fixing a rendering problem: When <video> is displayed in MediaDocument,
the media control panel overlaps with the video by 16 pixels.
No new tests as this is covered by existing media tests.
- css/mediaControlsChromium.css:
- 2:48 AM Changeset in webkit [46533] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm
Revert r46532 (build-webkit: Reorder logic for determining the baseProductDir)
Broke the Windows build.
- 2:37 AM Changeset in webkit [46532] by
-
- 2 edits in trunk/WebKitTools
2009-07-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
build-webkit: Reorder logic for determining the baseProductDir
We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.
Then we add the git branch if the git branch build option is enabled.
Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.
- Scripts/webkitdirs.pm:
- 1:36 AM Changeset in webkit [46531] by
-
- 2 edits in trunk/WebCore
2009-07-29 Adam Barth <abarth@webkit.org>
Unreviewed build fix for Chromium. Those last two patches weren't
independent despite the clean merge.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
- 1:34 AM Changeset in webkit [46530] by
-
- 2 edits in trunk/WebKit/qt
2009-07-29 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] In debug mode, this fix frees cached resources
and other unreferenced objects (by calling the
garbage collector) to remove the LEAK messages.
https://bugs.webkit.org/show_bug.cgi?id=27767
- Api/qwebframe.cpp: (qt_drt_cache_clear):
- QtLauncher/main.cpp: (main):
- 1:11 AM Changeset in webkit [46529] by
-
- 9 edits3 adds in trunk
2009-07-29 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
ImageSourceCG makes bad data refs (race condition causes blank images)
https://bugs.webkit.org/show_bug.cgi?id=27777
Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.
No new tests, as this fixes a bug with a race condition that is
difficult to trigger.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
2009-07-29 Kent Tamura <tkent@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
https://bugs.webkit.org/show_bug.cgi?id=27760
- fast/forms/option-value-and-label-expected.txt: Added.
- fast/forms/option-value-and-label.html: Added.
- 1:04 AM Changeset in webkit [46528] by
-
- 15 edits in trunk/JavaScriptCore
2009-07-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
Resolve class/struct mixup in forward declarations
https://bugs.webkit.org/show_bug.cgi?id=27708
- API/JSClassRef.h:
- bytecode/SamplingTool.h:
- interpreter/Interpreter.h:
- jit/JIT.h:
- profiler/ProfileGenerator.h:
- profiler/Profiler.h:
- runtime/ClassInfo.h:
- runtime/ExceptionHelpers.h:
- runtime/JSByteArray.h:
- runtime/JSCell.h:
- runtime/JSFunction.h:
- runtime/JSGlobalData.h:
- runtime/JSObject.h:
- runtime/JSString.h:
- 1:04 AM Changeset in webkit [46527] by
-
- 2 edits in trunk/WebCore
2009-07-29 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
ImageSourceCG makes bad data refs (race condition causes blank images)
https://bugs.webkit.org/show_bug.cgi?id=27777
Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.
No new tests, as this fixes a bug with a race condition that is
difficult to trigger.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
- 1:04 AM Changeset in webkit [46526] by
-
- 3 edits in trunk/WebCore
2009-07-29 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696
- inspector/front-end/Console.js: (WebInspector.Console.prototype._reportCompletions): Adds properties from _inspectorCommandLineAPI to completions when available.
- inspector/front-end/utilities.js: (Object.properties): Added. (Object.sortedProperties):
- 1:03 AM Changeset in webkit [46525] by
-
- 2 edits in trunk/WebCore
2009-07-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Refactor the first step of layout in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=27704
No new tests as this change is just a refactoring.
- rendering/RenderFlexibleBox.cpp: (WebCore::gatherFlexChildrenInfo): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- 1:03 AM Changeset in webkit [46524] by
-
- 6 edits2 adds in trunk
2009-07-29 Kent Tamura <tkent@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
https://bugs.webkit.org/show_bug.cgi?id=27760
WebCore:
Test: fast/forms/option-value-and-label.html
- dom/OptionElement.cpp: (WebCore::OptionElement::collectOptionLabelOrText): (WebCore::OptionElement::collectOptionInnerText): (WebCore::OptionElement::normalizeText): (WebCore::OptionElement::collectOptionTextRespectingGroupLabel): (WebCore::OptionElement::collectOptionValue):
- dom/OptionElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::text):
LayoutTests:
- fast/forms/option-value-and-label-expected.txt: Added.
- fast/forms/option-value-and-label.html: Added.
- 12:59 AM Changeset in webkit [46523] by
-
- 15 edits2 adds in trunk
2009-07-29 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701
Change V8Proxy::context(Frame*) to understand isolated worlds. Audit
all callers of this method to make sure they want isolated worlds. In
cases where we really want the main world, I've changed the call to
V8Proxy::mainWorldContext(Frame*).
The main visible change is to the document.open method when called with
more than two arguments. This design seems more likely to lead to
future correct code.
Test: http/tests/security/isolatedWorld/document-open.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::bindToWindowObject): (WebCore::ScriptController::collectGarbage): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
- bindings/v8/V8Helpers.cpp: (WebCore::toV8Context):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::bindJsObjectToWindow):
- bindings/v8/V8Proxy.h:
2009-07-29 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701
Test that calling document.open with more than two arguments calls the
window.open method from the correct world.
- http/tests/security/isolatedWorld/document-open-expected.txt: Added.
- http/tests/security/isolatedWorld/document-open.html: Added.
- 12:25 AM Changeset in webkit [46522] by
-
- 2 edits in trunk/WebCore
2009-07-29 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Fix the Qt build, add missing file.
- WebCore.pro:
- 12:13 AM Changeset in webkit [46521] by
-
- 2 edits in trunk/WebCore
2009-07-28 Jon Honeycutt <jhoneycutt@apple.com>
Speculative fix for <rdar://problem/7005077> WER: Crash in
WebCore::PluginStream::destroyStream+279 (1310510882)
Reviewed by Oliver Hunt.
- plugins/PluginStream.cpp: (WebCore::PluginStream::destroyStream): Move the "protector" RefPtr out of the block that dispatches notifications and into the function level; if NPN_DestroyStream were called from NPP_NewStream as the comment warns, we would be deleted at the end of the block.
Jul 28, 2009:
- 9:54 PM Changeset in webkit [46520] by
-
- 2 edits in trunk/WebCore
Allow tabbing through the Web Inspector DOM Storage grid cells when editing.
2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>
Inspector: Tab Through the DOM Storage DataGrid when Editing
Reviewed by Timothy Hatcher.
- inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): refactored to directly edit and select a column (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted.moveToNextIfNeeded): handles moveDirection on a commit (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): uses moveToNext to traverse appropriately
- 9:54 PM Changeset in webkit [46519] by
-
- 4 edits in trunk/WebCore
Allow creating new DOM Storage items in the Web Inspector.
2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>
Inspector: Create New DOM Storage Items via DataGrid
Reviewed by Timothy Hatcher.
- inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditing): click anyway means creationNode (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): fix unintended globals (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow): creationNode is special case
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.addCreationNode): maintain a quick ref to the single creationNode (WebInspector.CreationDataGridNode): new type of node (WebInspector.CreationDataGridNode.prototype.makeNormal): convert to a normal node
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): add a creationNode to the GridData
- 9:53 PM Changeset in webkit [46518] by
-
- 2 edits in trunk/WebCore
Automatically refresh DOM Storage grids in the Web Inspector.
2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>
Inspector: Automatically Refresh DOM Storage Grids on "storage" event
Reviewed by Timothy Hatcher.
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.show): trigger adding the listener (WebInspector.DatabasesPanel.prototype.reset): trigger removing the listener (WebInspector.DatabasesPanel.prototype._registerStorageEventListener): register the listener on the inspected window (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): unregister the listener on the inspected window (WebInspector.DatabasesPanel.prototype._storageEvent): handle the storage event
- 9:53 PM Changeset in webkit [46517] by
-
- 3 edits in trunk/WebCore
Added support for inspect() in the Web Inspector command line.
2009-07-28 Keishi Hattori <casey.hattori@gmail.com>
Inspector should support inspect() in the command line.
https://bugs.webkit.org/show_bug.cgi?id=19874
rdar://problem/6070225
Reviewed by Timothy Hatcher.
- inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled.inspectObject): (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.revealAndSelectDomStorage): Added. (WebInspector.DatabasesPanel.prototype.revealAndSelectDatabase): Added. (WebInspector.DatabasesPanel.prototype.showDatabase):
- 9:53 PM Changeset in webkit [46516] by
-
- 2 edits in trunk/WebCore
The rest of: Web Inspector: Add inspected node using public console API.
2009-07-28 Keishi Hattori <casey.hattori@gmail.com>
The rest of: Web Inspector: Add inspected node using public console API.
Reviewed by Timothy Hatcher.
- inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Removed _inspectorCommandLineAPI._addInspectedNode. (WebInspector.Console.prototype.addInspectedNode): Added.
- 9:40 PM Changeset in webkit [46515] by
-
- 2 edits in trunk/WebCore
2009-07-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Accept autocomplete on 'End' key pressed.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent):
- 7:27 PM Changeset in webkit [46514] by
-
- 2 edits in trunk/WebCore
2009-07-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
[Qt] Build fix after r46502
https://bugs.webkit.org/show_bug.cgi?id=27789
- WebCore.pro: Remove StorageArea.cpp
- 7:14 PM Applications using WebKit edited by
- Adding Cha-Ching. (diff)
- 6:42 PM Changeset in webkit [46513] by
-
- 2 edits in trunk/WebCore
Follow-on fix to r35582. Replace main thread assertions with WebCoreObjCScheduleDeallocateOnMainThread in -dealloc overrides in DOMObject subclasses.
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorObjC.pm:
- 6:23 PM Changeset in webkit [46512] by
-
- 3 edits in trunk/LayoutTests
Update Window-specific results with the non-prefixed border-radius
properties
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 6:09 PM Changeset in webkit [46511] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
- Implement TCMalloc_SystemRelease and TCMalloc_SystemCommit for Windows.
- Use a background thread to periodically scavenge memory to release back to the system.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): (WTF::TCMalloc_PageHeap::runScavengerThread): (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::shouldContinueScavenging): (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::GrowHeap): (WTF::sleep): (WTF::TCMalloc_PageHeap::scavengerThread):
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): (TCMalloc_SystemCommit):
- wtf/TCSystemAlloc.h:
- 5:49 PM Changeset in webkit [46510] by
-
- 22 edits in trunk/WebCore
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Adam Treat.
[WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
https://bugs.webkit.org/show_bug.cgi?id=27786
WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument().
The only case where this is relevant in WML is error handling. The parsed WML
tree fragment is inserted in an XHTML compound error document. This requires
removedFromDocument() to be correctly implemented otherwhise we run into
trouble (visible when using run-webkit-tests fast/wml --random).
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::registerTask): (WebCore::WMLAnchorElement::deregisterTask):
- wml/WMLAnchorElement.h:
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::removedFromDocument): (WebCore::WMLDoElement::registerTask): (WebCore::WMLDoElement::deregisterTask):
- wml/WMLDoElement.h:
- wml/WMLEventHandlingElement.cpp: (WebCore::WMLEventHandlingElement::registerDoElement): (WebCore::WMLEventHandlingElement::deregisterDoElement):
- wml/WMLEventHandlingElement.h:
- wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::removedFromDocument):
- wml/WMLGoElement.cpp: (WebCore::WMLGoElement::registerPostfieldElement): (WebCore::WMLGoElement::deregisterPostfieldElement):
- wml/WMLGoElement.h:
- wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::deregisterIntrinsicEvent):
- wml/WMLIntrinsicEventHandler.h:
- wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent): (WebCore::WMLOnEventElement::registerTask): (WebCore::WMLOnEventElement::deregisterTask):
- wml/WMLOnEventElement.h:
- wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::removedFromDocument):
- wml/WMLPostfieldElement.h:
- wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::removedFromDocument):
- wml/WMLSetvarElement.h:
- wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::removedFromDocument): (WebCore::WMLTaskElement::registerVariableSetter): (WebCore::WMLTaskElement::deregisterVariableSetter): (WebCore::WMLTaskElement::storeVariableState):
- wml/WMLTaskElement.h:
- wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::removedFromDocument):
- wml/WMLTimerElement.h:
- 5:33 PM Changeset in webkit [46509] by
-
- 2 edits in trunk/WebCore
2009-07-28 David Levin <levin@chromium.org>
Suggested by Drew Wilson.
Speculative gtk build fix, follow up to:
https://bugs.webkit.org/show_bug.cgi?id=27697
- GNUmakefile.am:
- 5:16 PM Changeset in webkit [46508] by
-
- 14 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578
[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584
Test: fast/borders/border-radius-parsing.html
Dropped the -webkit- prefix from the individual corner border-radius
properties. Added border-radius with the / and 4-value syntax, and
maintained -webkit-border-radius with legacy 2-value syntax.
- css/CSSComputedStyleDeclaration.cpp: (computedProperties): Removed Webkit prefix. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed Webkit prefix from the
single-corner properties. Call out to parseBorderRadius() to parse
border-radius and -webkit-border-radius.
(WebCore::completeBorderRadii): Added this helper function that
completes the values for all four corners when fewer than four are
specified.
(WebCore::CSSParser::parseBorderRadius): Added.
(WebCore::cssPropertyID): Map -webkit-border-*-*-radius to the
unprefixed property.
- css/CSSParser.h:
- css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap): Removed the Webkit prefix. Added an entry
for border-radius. Kept the entry for -webkit-border-radius.
- css/CSSPropertyNames.in: Removed the -webkit- prefix from the
single-corenr properties. Added border-radius. Kept
-webkit-border-radius because of its conflicting syntax.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Removed the Webkit prefix.
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap): Ditto.
LayoutTests:
Reviewed by Simon Fraser.
New test, updated test, and updated test results for:
[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578
[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584
- fast/borders/border-radius-parsing-expected.txt: Added.
- fast/borders/border-radius-parsing.html: Added.
- fast/css/remove-shorthand-expected.txt:
- fast/css/remove-shorthand.html: Added a test for border-radius.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 5:08 PM Changeset in webkit [46507] by
-
- 16 edits2 copies in trunk/WebCore
2009-07-28 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Refactored dedicated-worker-specific code from WorkerThread into DedicatedWorkerThread class.
WorkerThread needs to be refactored to separate out dedicated-worker functionality.
https://bugs.webkit.org/show_bug.cgi?id=27697
This is just a refactoring, so existing tests suffice.
- GNUmakefile.am: Added DedicatedWorkerThread.h/.cpp
- WebCore.gypi: Added DedicatedWorkerThread.h/.cpp
- WebCore.pro: Added DedicatedWorkerThread.h/.cpp
- WebCore.vcproj/WebCore.vcproj: Added DedicatedWorkerThread.h/.cpp
- WebCore.xcodeproj/project.pbxproj: Added DedicatedWorkerThread.h/.cpp
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::addMessage): Forwards console messages to parent document. (WebCore::DedicatedWorkerContext::importScripts): Now sends the updated pending activity status after importing scripts. (WebCore::DedicatedWorkerContext::thread): Helper routine that casts WorkerThread to DedicatedWorkerThread.
- workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::create):
- workers/DedicatedWorkerThread.cpp: Added. (WebCore::DedicatedWorkerThread::create): (WebCore::DedicatedWorkerThread::DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::~DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::createWorkerContext): Implementation of the base class factory method to create the appropriate worker context. (WebCore::DedicatedWorkerThread::runEventLoop): Reports pending activity before running the event loop.
- workers/DedicatedWorkerThread.h: Added. (WebCore::DedicatedWorkerThread::workerObjectProxy): Moved from base class.
- workers/WorkerContext.cpp:
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): Now creates DedicatedWorkerThread. (WebCore::WorkerMessagingProxy::workerThreadCreated): Now is passed a DedicatedWorkerThread.
- workers/WorkerMessagingProxy.h:
- workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): Moved workerObjectProxy param into derived class constructor. (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::runEventLoop): Moved the event loop execution into a virtual function so DedicatedWorkerThread could report pending activity first.
- workers/WorkerThread.h: (WebCore::WorkerThread::workerContext):
- 4:29 PM Changeset in webkit [46506] by
-
- 2 edits in trunk/LayoutTests
2009-07-28 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Add two tests that failed on release (not debug) back to skipped list.
- platform/win/Skipped:
- 4:15 PM Changeset in webkit [46505] by
-
- 2 edits in trunk/WebKitTools
Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.
Reviewed by Oliver Hunt.
- WebKitLauncher/main.m:
(checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows.
(main): If the minimum version requirement is not met, display an alert and bail out.
- 4:12 PM Changeset in webkit [46504] by
-
- 2 edits in trunk/WebCore
2009-07-28 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Fix V8NPUtils' handling of UTF8 identifiers.
- 3:38 PM Changeset in webkit [46503] by
-
- 2 edits in trunk/LayoutTests
2009-07-28 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Steve Falkenburg.
Remove a lot of tests from Windows Skip list which now pass. Will watch buildbot
to make sure there are no regressions/this commit doesn't cause failures.
- platform/win/Skipped:
- 3:26 PM Changeset in webkit [46502] by
-
- 3 edits1 delete in trunk/WebCore
2009-07-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Eric Seidel.
Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517
The StorageAreaImpl changes are all for Chromium. Because the DOM Storage implementation
runs in a different process from where the Frame object lives, Chromium passes in NULL
for the sourceFrame. This affects events and handling privateBrowsing. Chromium's
incognito mode does not use the private browsing setting, so that's not a concern. As for
events, I've decided to simply disable them for now.
The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed for thread-
safety) and to add an assert that .copy is only ever called on a SessionStorage namespace.
Also cleaned up tailing whitespace in several parts of StorageAreaImpl.cpp
- storage/StorageArea.cpp: Removed. (It was empty anyway.)
- storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): Factored out the check. (WebCore::StorageAreaImpl::setItem): Make frame optional. (WebCore::StorageAreaImpl::removeItem): ditto (WebCore::StorageAreaImpl::clear): ditto (WebCore::StorageAreaImpl::dispatchStorageEvent): Disable in Chromium for now.
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): Remove stale comment. (WebCore::StorageNamespaceImpl::copy): Add assert that it's SessionStorage.
- 2:57 PM Changeset in webkit [46501] by
-
- 2 edits in trunk/WebCore
2009-07-28 Alpha Lam <hclam@google.com>
Reviewed by David Levin.
[chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669
Fixes the bug that <video> in MediaDocument is 1 pixel tall if
it is playing an audio file by changing the style to be 32px
tall.
Also fixes a problem of default styled audio tag that hides the
all the time digits by expanding the width to 300px.
Changed the size and position of the current time and remaining
display to give enough space for the hour digit to be shown.
There are no new tests provided because this is already covered
by existing tests.
- css/mediaControlsChromium.css:
- 1:53 PM Changeset in webkit [46500] by
-
- 6 edits4 copies in trunk/LayoutTests
2009-07-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add some checks to existing SessionStorage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27776
This is a mixed bag of tweaks to existing tests. This is the sessionStorage
side of https://bugs.webkit.org/show_bug.cgi?id=27695
- storage/domstorage/sessionstorage/delete-removal-expected.txt:
- storage/domstorage/sessionstorage/delete-removal.html:
Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.
- storage/domstorage/sessionstorage/enumerate-storage.html:
Removed dead code.
- storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt.
- storage/domstorage/sessionstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage.html.
Test enumerating by hand (with length+key).
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
Test removeItem and clear in addition to setItem.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html.
Test using window.onstorage.
- 1:29 PM Changeset in webkit [46499] by
-
- 5 edits in trunk/WebCore
2009-07-28 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
Fix style in PluginPackage and PluginDatabase.
Part of https://bugs.webkit.org/show_bug.cgi?id=27651
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): (WebCore::PluginDatabase::findPlugin):
- plugins/PluginDatabase.h:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::~PluginPackage): (WebCore::PluginPackage::freeLibrarySoon): (WebCore::PluginPackage::freeLibraryTimerFired): (WebCore::PluginPackage::unloadWithoutShutdown): (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginPackage.h:
- 1:28 PM Changeset in webkit [46498] by
-
- 8 edits3 copies1 add in trunk/LayoutTests
2009-07-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add some checks to existing DOM Storage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27695
This is really a mixed bag of tweaks to existing tests.
- storage/domstorage/localstorage/delete-removal-expected.txt:
- storage/domstorage/localstorage/delete-removal.html:
Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.
- storage/domstorage/localstorage/enumerate-storage.html:
Removed dead code.
- storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
- storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.
Test enumerating by hand (with length+key).
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
Test removeItem and clear in addition to setItem.
- storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
- storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.
Test using window.onstorage.
- storage/domstorage/window-attributes-exist-expected.txt:
- storage/domstorage/window-attributes-exist.html:
Verify that two consecutive calls to window.Storage will equal each other.
- 12:46 PM Changeset in webkit [46497] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
Fix the Qt build by adapting to the changes of ScriptObject.
- Api/qwebelement.cpp: (setupScriptObject):
- 12:33 PM Changeset in webkit [46496] by
-
- 2 edits in trunk/WebCore
2009-07-28 Anantanarayanan Iyengar <ananta@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=27769
The V8 bindings function V8Proxy::createNewContext can be
called during frame shutdown where the activeDocumentLoader
function in FrameLoader can return NULL. Added a check for the
same.
No new tests added as this is an edge case where the V8
bindings code is reentered via NPAPI during shutdown. It is
difficult to write a consistently reproducible test for this.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext):
- 12:28 PM WebKit Team edited by
- (diff)
- 12:25 PM Changeset in webkit [46495] by
-
- 2 edits in trunk/WebCore
2009-07-28 Ivan Posva <iposva@chromium.org>
Reviewed by Dimitri Glazkov.
Associate the CanvasPixelData backing store with the
indexed properties of the wrapper object.
No new tests: Relying on existing Canvas tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
- 11:58 AM Changeset in webkit [46494] by
-
- 1 edit2 adds in trunk/WebKit
2009-07-28 Maxime Simon <Maxime Simon>
Reviewed by David Levin.
Added FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
- haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Added. (WebCore::FrameLoaderClientHaiku::FrameLoaderClientHaiku): (WebCore::FrameLoaderClientHaiku::setFrame): (WebCore::FrameLoaderClientHaiku::setWebView): (WebCore::FrameLoaderClientHaiku::detachFrameLoader): (WebCore::FrameLoaderClientHaiku::hasWebView): (WebCore::FrameLoaderClientHaiku::hasBackForwardList): (WebCore::FrameLoaderClientHaiku::resetBackForwardList): (WebCore::FrameLoaderClientHaiku::provisionalItemIsTarget): (WebCore::FrameLoaderClientHaiku::makeRepresentation): (WebCore::FrameLoaderClientHaiku::forceLayout): (WebCore::FrameLoaderClientHaiku::forceLayoutForNonHTML): (WebCore::FrameLoaderClientHaiku::updateHistoryForCommit): (WebCore::FrameLoaderClientHaiku::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientHaiku::updateHistoryForReload): (WebCore::FrameLoaderClientHaiku::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientHaiku::setCopiesOnScroll): (WebCore::FrameLoaderClientHaiku::tokenForLoadErrorReset): (WebCore::FrameLoaderClientHaiku::resetAfterLoadError): (WebCore::FrameLoaderClientHaiku::doNotResetAfterLoadError): (WebCore::FrameLoaderClientHaiku::willCloseDocument): (WebCore::FrameLoaderClientHaiku::detachedFromParent2): (WebCore::FrameLoaderClientHaiku::detachedFromParent3): (WebCore::FrameLoaderClientHaiku::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchWillClose): (WebCore::FrameLoaderClientHaiku::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientHaiku::dispatchDidCommitLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstLayout): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstVisuallyNonEmptyLayout): (WebCore::FrameLoaderClientHaiku::dispatchShow): (WebCore::FrameLoaderClientHaiku::cancelPolicyCheck): (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientHaiku::revertToProvisionalState): (WebCore::FrameLoaderClientHaiku::postProgressStartedNotification): (WebCore::FrameLoaderClientHaiku::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientHaiku::postProgressFinishedNotification): (WebCore::FrameLoaderClientHaiku::progressStarted): (WebCore::FrameLoaderClientHaiku::progressCompleted): (WebCore::FrameLoaderClientHaiku::setMainFrameDocumentReady): (WebCore::FrameLoaderClientHaiku::willChangeTitle): (WebCore::FrameLoaderClientHaiku::didChangeTitle): (WebCore::FrameLoaderClientHaiku::finishedLoading): (WebCore::FrameLoaderClientHaiku::canShowMIMEType): (WebCore::FrameLoaderClientHaiku::representationExistsForURLScheme): (WebCore::FrameLoaderClientHaiku::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientHaiku::frameLoadCompleted): (WebCore::FrameLoaderClientHaiku::saveViewStateToItem): (WebCore::FrameLoaderClientHaiku::restoreViewState): (WebCore::FrameLoaderClientHaiku::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientHaiku::provisionalLoadStarted): (WebCore::FrameLoaderClientHaiku::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientHaiku::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientHaiku::didFinishLoad): (WebCore::FrameLoaderClientHaiku::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientHaiku::setTitle): (WebCore::FrameLoaderClientHaiku::userAgent): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientHaiku::frameLoaderDestroyed): (WebCore::FrameLoaderClientHaiku::canHandleRequest): (WebCore::FrameLoaderClientHaiku::partClearedInBegin): (WebCore::FrameLoaderClientHaiku::updateGlobalHistory): (WebCore::FrameLoaderClientHaiku::updateGlobalHistoryRedirectLinks): (WebCore::FrameLoaderClientHaiku::shouldGoToHistoryItem): (WebCore::FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientHaiku::canCachePage): (WebCore::FrameLoaderClientHaiku::setMainDocumentError): (WebCore::FrameLoaderClientHaiku::committedLoad): (WebCore::FrameLoaderClientHaiku::cancelledError): (WebCore::FrameLoaderClientHaiku::blockedError): (WebCore::FrameLoaderClientHaiku::cannotShowURLError): (WebCore::FrameLoaderClientHaiku::interruptForPolicyChangeError): (WebCore::FrameLoaderClientHaiku::cannotShowMIMETypeError): (WebCore::FrameLoaderClientHaiku::fileDoesNotExistError): (WebCore::FrameLoaderClientHaiku::shouldFallBack): (WebCore::FrameLoaderClientHaiku::createDocumentLoader): (WebCore::FrameLoaderClientHaiku::download): (WebCore::FrameLoaderClientHaiku::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientHaiku::dispatchWillSendRequest): (WebCore::FrameLoaderClientHaiku::shouldUseCredentialStorage): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceByXMLHttpRequest): (WebCore::FrameLoaderClientHaiku::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoad): (WebCore::FrameLoaderClientHaiku::dispatchCreatePage): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientHaiku::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientHaiku::startDownload): (WebCore::FrameLoaderClientHaiku::createFrame): (WebCore::FrameLoaderClientHaiku::objectContentType): (WebCore::FrameLoaderClientHaiku::createPlugin): (WebCore::FrameLoaderClientHaiku::redirectDataToPlugin): (WebCore::FrameLoaderClientHaiku::pluginWillHandleLoadError): (WebCore::FrameLoaderClientHaiku::createJavaAppletWidget): (WebCore::FrameLoaderClientHaiku::overrideMediaType): (WebCore::FrameLoaderClientHaiku::windowObjectCleared): (WebCore::FrameLoaderClientHaiku::documentElementAvailable): (WebCore::FrameLoaderClientHaiku::didPerformFirstNavigation): (WebCore::FrameLoaderClientHaiku::registerForIconNotification): (WebCore::FrameLoaderClientHaiku::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedFromCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedForNewPage):
- haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Added. (WebCore::FrameLoaderClientHaiku::~FrameLoaderClientHaiku):
- 11:58 AM Changeset in webkit [46493] by
-
- 1 edit2 adds in trunk/WebKit
2009-07-28 Maxime Simon <Maxime Simon>
Reviewed by David Levin.
Added ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
- haiku/WebCoreSupport/ChromeClientHaiku.cpp: Added. (WebCore::ChromeClientHaiku::ChromeClientHaiku): (WebCore::ChromeClientHaiku::~ChromeClientHaiku): (WebCore::ChromeClientHaiku::chromeDestroyed): (WebCore::ChromeClientHaiku::setWindowRect): (WebCore::ChromeClientHaiku::windowRect): (WebCore::ChromeClientHaiku::pageRect): (WebCore::ChromeClientHaiku::scaleFactor): (WebCore::ChromeClientHaiku::focus): (WebCore::ChromeClientHaiku::unfocus): (WebCore::ChromeClientHaiku::canTakeFocus): (WebCore::ChromeClientHaiku::takeFocus): (WebCore::ChromeClientHaiku::createWindow): (WebCore::ChromeClientHaiku::createModalDialog): (WebCore::ChromeClientHaiku::show): (WebCore::ChromeClientHaiku::canRunModal): (WebCore::ChromeClientHaiku::runModal): (WebCore::ChromeClientHaiku::setToolbarsVisible): (WebCore::ChromeClientHaiku::toolbarsVisible): (WebCore::ChromeClientHaiku::setStatusbarVisible): (WebCore::ChromeClientHaiku::statusbarVisible): (WebCore::ChromeClientHaiku::setScrollbarsVisible): (WebCore::ChromeClientHaiku::scrollbarsVisible): (WebCore::ChromeClientHaiku::setMenubarVisible): (WebCore::ChromeClientHaiku::menubarVisible): (WebCore::ChromeClientHaiku::setResizable): (WebCore::ChromeClientHaiku::addMessageToConsole): (WebCore::ChromeClientHaiku::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::closeWindowSoon): (WebCore::ChromeClientHaiku::runJavaScriptAlert): (WebCore::ChromeClientHaiku::runJavaScriptConfirm): (WebCore::ChromeClientHaiku::runJavaScriptPrompt): (WebCore::ChromeClientHaiku::setStatusbarText): (WebCore::ChromeClientHaiku::shouldInterruptJavaScript): (WebCore::ChromeClientHaiku::tabsToLinks): (WebCore::ChromeClientHaiku::windowResizerRect): (WebCore::ChromeClientHaiku::repaint): (WebCore::ChromeClientHaiku::scroll): (WebCore::ChromeClientHaiku::screenToWindow): (WebCore::ChromeClientHaiku::windowToScreen): (WebCore::ChromeClientHaiku::platformWindow): (WebCore::ChromeClientHaiku::contentsSizeChanged): (WebCore::ChromeClientHaiku::scrollRectIntoView): (WebCore::ChromeClientHaiku::addToDirtyRegion): (WebCore::ChromeClientHaiku::scrollBackingStore): (WebCore::ChromeClientHaiku::updateBackingStore): (WebCore::ChromeClientHaiku::mouseDidMoveOverElement): (WebCore::ChromeClientHaiku::setToolTip): (WebCore::ChromeClientHaiku::print): (WebCore::ChromeClientHaiku::exceededDatabaseQuota): (WebCore::ChromeClientWx::reachedMaxAppCacheSize): (WebCore::ChromeClientHaiku::requestGeolocationPermissionForFrame): (WebCore::ChromeClientHaiku::runOpenPanel): (WebCore::ChromeClientHaiku::setCursor): (WebCore::ChromeClientHaiku::formStateDidChange): (WebCore::ChromeClientHaiku::createHTMLParserQuirks):
- haiku/WebCoreSupport/ChromeClientHaiku.h: Added.
- 10:34 AM Changeset in webkit [46492] by
-
- 2 edits in trunk/WebCore
2009-07-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Nuke all references to JSWorkerContextBase.lut.h, it was removed
back in April.
- GNUmakefile.am:
- 9:52 AM Changeset in webkit [46491] by
-
- 2 edits1 delete in trunk/WebCore
2009-07-28 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Fixed references to script generate-webkitversion.pl, and
removed duplicated generate-webkitversion.pl
- WebCore.pro:
- platform/generate-webkitversion.pl: Removed.
- 9:04 AM Changeset in webkit [46490] by
-
- 25 edits2 deletes in trunk/WebCore
2009-07-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dmitry Glazkov.
Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of
InspectorJSONObject.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
- bindings/js/ScriptArray.h:
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
- bindings/js/ScriptObject.h:
- bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
- bindings/v8/ScriptArray.h:
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
- bindings/v8/ScriptObject.h: (WebCore::ScriptObject::ScriptObject):
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
- inspector/InspectorFrontend.h:
- inspector/InspectorJSONObject.cpp: Removed.
- inspector/InspectorJSONObject.h: Removed.
- inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
- 8:41 AM Changeset in webkit [46489] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.12
Tagging 1.1.12.
- 8:35 AM Changeset in webkit [46488] by
-
- 2 edits2 moves in trunk/WebKitTools
2009-07-28 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752
The files were renamed. A few renames were done:
CppLint -> CppStyle
cpplint -> cpp_style
- Scripts/check-webkit-style:
- Scripts/modules/cpp_style.py: Copied from cpplint.py and did name fix ups.
- Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and did name fix ups.
- Scripts/modules/cpplint.py: Removed.
- Scripts/modules/cpplint_unittest.py: Removed.
- 8:34 AM Changeset in webkit [46487] by
-
- 5 edits in trunk
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726
Allow <setvar> elements to depend on the value specified by preceeding <setvar> elements.
Required by the specification - assure it only works in linear order. A setvar element may
not depend on the variable state of a following setvar element, only the previous ones.
Extend wml/variable-reference-valid.html layout test to cover these cases.
- wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::storeVariableState):
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726
Extend variable-reference-valid.html to test <setvar> attribute values depending on each other.
- wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
- wml/variable-reference-valid-expected.txt:
- 8:03 AM Changeset in webkit [46486] by
-
- 5 edits in trunk
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725
Fix bug in containsVariableReference() function, we we're decreasing the nameEndPosition
too much, leading to a bug with 1-char variable names, which were not detected properly.
Extend wml/variable-reference-valid.html layout test to cover 1-char variable names.
Also fixes manual-tests/wml/task-refresh-in-anchor.wml, which happened to use 1-char variable names.
- wml/WMLVariables.cpp: (WebCore::containsVariableReference):
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725
Extend variable-reference-valid.html test to include one-character variable tests.
- wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
- wml/variable-reference-valid-expected.txt:
- 7:58 AM Changeset in webkit [46485] by
-
- 7 edits5 adds in trunk
WebCore:
2009-07-28 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Add WebKit version API to Qt.
Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.
- WebCore.pro: Call generate-webkitversion.pl
WebKit:
2009-07-28 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Add WebKit version API to Qt.
Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.
- scripts/generate-webkitversion.pl: Added
WebKit/qt:
2009-07-28 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Add WebKit version API to Qt.
Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to Qt applications through
qWebKitVersion().
Also amend the User Agent string to place the Safari clause outside
the final bracket and to the end of the UA string.
Minor build tweak by Simon Hausmann (adding export macros to new functions).
- Api/headers.pri:
- Api/qwebkitversion.cpp: Added. (webKitVersion): (webKitMajorVersion): (webKitMinorVersion):
- Api/qwebkitversion.h: Added.
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::getWebKitVersion):
- 7:57 AM Changeset in webkit [46484] by
-
- 2 edits in trunk/WebCore
2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed make dist build fix.
- GNUmakefile.am:
- 7:41 AM Changeset in webkit [46483] by
-
- 2 edits in trunk/WebCore
2009-07-28 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Replace hardcoded separator text with proper separator.
Also adjusts include order as per style guidelines.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
- 7:26 AM Changeset in webkit [46482] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Fix compilation with the precompiled header.
- WebKit_pch.h: Don't include JSDOMBinding.h and MathObject.h, as they include AtomicString.h. AtomicString.cpp needs to enable a #define before including AtomicString.h, which breaks if the PCH forces the inclusion beforehand.
- 6:53 AM EFLWebKit edited by
- (diff)
- 6:34 AM Changeset in webkit [46481] by
-
- 3 edits in trunk
2009-07-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Use automake 1.11 SILENT_RULES when present, for cleaner build
output. You can disable it by passing --disable-silent-rules to
configure or V=1 to make.
- autotools/dolt.m4:
- configure.ac:
- 6:33 AM Changeset in webkit [46480] by
-
- 4 edits in trunk
2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Steve Falkenburg.
Add output directory for VS pre-build steps to enable out-of-tree builds
The tmp.obj file is now placed in the intermediate build directory.
- WebCore.vcproj/WebCoreCommon.vsprops:
2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Steve Falkenburg.
Add output directory for VS pre-build steps to enable out-of-tree builds
The tmp.obj file is now placed in the intermediate build directory.
- WebKit.vcproj/WebKit.vcproj:
- 6:30 AM Changeset in webkit [46479] by
-
- 3 edits in trunk/WebCore
2009-07-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add inspected node using public console API.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.addInspectedNode):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
- 6:26 AM Changeset in webkit [46478] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Added tests to ensure that scroll position can be changed
programmatically, even when the scroll bar policy is set to off.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:23 AM Changeset in webkit [46477] by
-
- 2 edits in trunk/WebKitTools
2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Holger Freyther.
Add Steve Falkenburg to bugzilla-tools' reviewers list
- Scripts/modules/bugzilla.py:
- 6:12 AM Changeset in webkit [46476] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix a few compilation warnings in the QWebFrame tests.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:04 AM Changeset in webkit [46475] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Simon Hausmann.
Fixed tst_QWebFrame::hasSetFocus test which was using
an undefined resource.
https://bugs.webkit.org/show_bug.cgi?id=27512
- tests/qwebframe/tst_qwebframe.cpp:
- 5:47 AM Changeset in webkit [46474] by
-
- 3 edits1 move3 adds in trunk
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724
Fix WMLNoopElement to disable it's parent WMLDoElement, as required by the spec.
Moved manual-tests/wml/task-noop-in-do.wml to LayoutTests/fast/wml/task-noop-in-do.wml.
- manual-tests/wml/task-noop-in-do.wml: Removed.
- wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724
Add new layout test covering noop elements in do elements.
- fast/wml/task-noop-in-do.wml: Copied from WebCore/manual-tests/wml/task-noop-in-do.wml.
- platform/mac/fast/wml/task-noop-in-do-expected.checksum: Added.
- platform/mac/fast/wml/task-noop-in-do-expected.png: Added.
- platform/mac/fast/wml/task-noop-in-do-expected.txt: Added.
- 5:40 AM Changeset in webkit [46473] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-28 Xan Lopez <xlopez@igalia.com>
Add new files, fixes distcheck.
- GNUmakefile.am:
- 5:35 AM Changeset in webkit [46472] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Determining whether to use JIT or interpreter
moved from JavaScriptCore.pri to Platform.h
- JavaScriptCore.pri:
- wtf/Platform.h:
- 5:27 AM Changeset in webkit [46471] by
-
- 4 edits in trunk
.:
2009-07-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709
- WebKit.pri:
WebCore:
2009-07-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709
- WebCore.pro: Move the msvc options to WebKit.pri
- 4:48 AM Changeset in webkit [46470] by
-
- 2 edits in trunk/WebKitTools
2009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Implement test result archive support for the Qt port.
- BuildSlaveSupport/test-result-archive:
- 4:12 AM Changeset in webkit [46469] by
-
- 4 edits in trunk
WebCore
2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Tor Arne Vestbø
Make equality checks for logging channel names ignore casing.
- platform/Logging.cpp: (WebCore::getChannelFromName):
WebKit/gtk
2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Add information about the regression fix for WEBKIT_DEBUG.
- NEWS:
- 4:02 AM Changeset in webkit [46468] by
-
- 3 edits in trunk/WebCore
2009-07-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Refactor ResourceHandleSoup - make start* functions static
https://bugs.webkit.org/show_bug.cgi?id=27687
- platform/network/ResourceHandle.h:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData): (WebCore::startHttp): (WebCore::):
- 3:58 AM Changeset in webkit [46467] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-28 Priit Laes <plaes@plaes.org>
Reviewed by Xan Lopez.
Fix mnemonics in the soup authentication dialog.
- webkit/webkitsoupauthdialog.c: (show_auth_dialog):
- 3:52 AM Changeset in webkit [46466] by
-
- 2 edits in trunk/WebCore
2009-07-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Do not cache the pango layout in the object, since the layout of
the page can change between calls.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- 3:39 AM Changeset in webkit [46465] by
-
- 4 edits in trunk
2009-07-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
- configure.ac: bump version for 1.1.12 release.
WebKit/gtk:
2009-07-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
- NEWS: update for 1.1.12 release.
- 2:20 AM Changeset in webkit [46464] by
-
- 2 edits in trunk/WebKit/qt
2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Make it possible to pass relative file names to QtLauncher.
- QtLauncher/main.cpp: (MainWindow::MainWindow):
- 2:00 AM Changeset in webkit [46463] by
-
- 3 edits in trunk/LayoutTests
2009-07-27 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Adam Treat.
update qt expefic expected files for fast/css/getComputedStyle/ tests after r46274
https://bugs.webkit.org/show_bug.cgi?id=27714
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 1:27 AM Changeset in webkit [46462] by
-
- 2 edits in trunk/WebCore
2009-07-23 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Simplify management of Nodes in weak handles callbacks.
https://bugs.webkit.org/show_bug.cgi?id=27628
- bindings/v8/V8DOMMap.cpp: (WebCore::weakNodeCallback):
- 1:14 AM Changeset in webkit [46461] by
-
- 2 edits in trunk/WebCore
2009-07-28 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by David Levin.
Fix error handling of GetIconInfo (returns a bool).
- platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):
- 12:11 AM Changeset in webkit [46460] by
-
- 2 edits in trunk/WebCore
2009-07-27 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
Fix of <rdar://5015949> Drag Icon is not produced for over sized images.
Implemented the createDragImageIconForCachedImage function by using the Windows
SHFILEINFO structure.
- platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):
Jul 27, 2009:
- 11:05 PM Changeset in webkit [46459] by
-
- 5 edits12 adds in trunk/WebCore
2009-07-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685
No behavior change. Just copy-and-paste.
- WebCore.gypi:
- bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
- bindings/v8/ChildThreadDOMData.h: Added.
- bindings/v8/DOMData.cpp: Added. (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMData.h: Added. (WebCore::):
- bindings/v8/DOMDataStore.cpp: Added. (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::forget): (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
- bindings/v8/DOMDataStore.h: Added. (WebCore::DOMDataStore::): (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::InternalDOMWrapperMap::forgetOnly): (WebCore::DOMDataStore::domData): (WebCore::DOMDataStore::domNodeMap): (WebCore::DOMDataStore::domObjectMap): (WebCore::DOMDataStore::activeDomObjectMap): (WebCore::DOMDataStore::domSvgElementInstanceMap): (WebCore::DOMDataStore::domSvgObjectWithContextMap):
- bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore):
- bindings/v8/MainThreadDOMData.h: Added.
- bindings/v8/ScopedDOMDataStore.cpp: Added. (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
- bindings/v8/ScopedDOMDataStore.h: Added.
- bindings/v8/StaticDOMDataStore.cpp: Added. (WebCore::StaticDOMDataStore::StaticDOMDataStore):
- bindings/v8/StaticDOMDataStore.h: Added.
- bindings/v8/V8DOMMap.cpp:
- 10:24 PM Changeset in webkit [46458] by
-
- 8 edits in trunk/LayoutTests
2009-07-27 Brady Eidson <beidson@apple.com>
Update Tiger specific results for these 7 tests.
- platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/mac-tiger/security/block-test-expected.txt:
- platform/mac-tiger/security/block-test-no-port-expected.txt:
- 9:53 PM Changeset in webkit [46457] by
-
- 6 edits in trunk/LayoutTests
2009-07-27 Brady Eidson <beidson@apple.com>
Update Windows specific results for these 5 tests.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
- 9:50 PM Changeset in webkit [46456] by
-
- 2 edits in trunk/LayoutTests
2009-07-27 Brady Eidson <beidson@apple.com>
Didn't mean to check this guy in.
- http/tests/appcache/max-size-expected.txt:
- 9:29 PM Changeset in webkit [46455] by
-
- 21 edits in trunk
WebKitTools:
2009-07-27 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLResponse _drt_descriptionSuitableForTestResult]): (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult):
LayoutTests:
2009-07-27 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.
Update test results for the new info.
- fast/loader/main-document-url-for-non-http-loads-expected.txt:
- http/tests/appcache/max-size-expected.txt:
- http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- http/tests/misc/window-dot-stop-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
- platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- platform/mac/security/block-test-expected.txt:
- platform/mac/security/block-test-no-port-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- webarchive/loading/test-loading-archive-expected.txt:
- 7:50 PM UsingGitWithWebKit edited by
- --regenerate-log (diff)
- 7:29 PM Changeset in webkit [46454] by
-
- 2 edits in trunk/WebKitTools
2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by David Levin.
"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747
modules.bugzilla is not found because not included.
- Scripts/modules/scm.py: Properly import modules.bugzilla.
- 7:28 PM Changeset in webkit [46453] by
-
- 2 edits in trunk/WebKitTools
2009-07-24 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by David Kilzer.
commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664
- Scripts/commit-log-editor: Add --regenerate-log option. The user is asked if he wants to suppress previous ChangeLog and regenerate it, if this option is enabled.
- 7:25 PM Changeset in webkit [46452] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 7:24 PM Changeset in webkit [46451] by
-
- 1 copy in tags/Safari-6531.9
New tag.
- 6:57 PM Changeset in webkit [46450] by
-
- 6 edits in branches/safari-4-branch
Merge r46449.
- 6:49 PM Changeset in webkit [46449] by
-
- 6 edits in trunk
<rdar://problem/7091036> REGRESSION: Microsoft Messenger crashes during file send/receive due to use of WebKit on non-main thread
Reviewed by Darin Adler.
In some situations Microsoft Messenger can attempt to manipulate the DOM from a secondary thread while
updating its file transfer progress bar. This results in corruption of WebCore data structures that is
quickly followed by a crash. We can work around this by having -[WebFrame DOMDocument] return nil when
called from a secondary thread by Microsoft Messenger, which has the effect of turning its attempts at
DOM manipulation in to no-ops.
- WebView/WebFrame.mm:
(needsMicrosoftMessengerDOMDocumentWorkaround):
(-[WebFrame DOMDocument]):
Add a method for detecting if we're being used within Microsoft Messenger.
- WebCore.base.exp: Export applicationIsMicrosoftMessenger and sort existing entries.
- platform/mac/RuntimeApplicationChecks.h:
- platform/mac/RuntimeApplicationChecks.mm:
(WebCore::applicationIsMicrosoftMessenger):
- 6:11 PM Changeset in webkit [46448] by
-
- 3 edits in trunk/WebCore
2009-07-27 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
[V8] Implement EventListener::reportError for V8 event listeners in worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError):
- bindings/v8/V8WorkerContextEventListener.h:
- 5:50 PM Changeset in webkit [46447] by
-
- 3 edits in trunk/WebCore
2009-07-27 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel and David Levin.
Re-apply chromium/skia border fix (originally landed in r46157,
reverted in r46363), since it was not the cause of the reliability
failures in Chromium.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
- 5:47 PM Changeset in webkit [46446] by
-
- 7 edits3 adds in trunk
WebCore:
2009-07-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660
This patch isolates code that creates markup for styles in addStyleMarkup
It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
so that we can assume no text decoration style is passed to addStyleMarkup.
- editing/markup.cpp: (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags (WebCore::addStyleMarkup): Adds markup for style span and div (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup
LayoutTests:
2009-07-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660
inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
immediately after indentation.
- editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
- editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
- editing/execCommand/inline-style-after-indentoutdent.html: Added.
- editing/execCommand/resources/inline-style-after-indentoutdent.js: Added. (testCreateMarkup): (shouldBeSameAfterCreateMarkup):
- platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
- platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
- platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
- 5:35 PM Changeset in webkit [46445] by
-
- 7 edits in trunk/LayoutTests
Rubber-stamped by George Staikos.
Forgot to update pixel test results a while ago.
- 5:21 PM Changeset in webkit [46444] by
-
- 13 edits in trunk/WebCore
2009-07-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745
No new tests for these changes. I believe in many cases
testing to be impossible. Lack of testing justification next to
each change below. The remaining pieces of bug 27634 will all
need tests.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument): not testable.
- bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter): no testing for this incomplete feature.
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): would require outer frame to trigger an event in the inner frame
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): covered by other tests, always correct to pass the globalObject through.
- bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): unclear when this could be triggered.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): toJS seems superfluous here to begin with.
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): would require outer frame to trigger inner frame event.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement): only used for NPAPI binding, unclear how to test.
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): unclear how to test.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): unclear how to test/inspector only.
- bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): unclear how to test.
- bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): unclear how to test.
- 5:16 PM Changeset in webkit [46443] by
-
- 9 edits in trunk/WebCore
2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] 'title' attribute handling not correct for <a> / <anchor> elements
https://bugs.webkit.org/show_bug.cgi?id=27720
Unify title() implementation in WMLElement instead of several copies of the same logic.
We forgot WMLAnchorElement/WMLAElement, that lead to bugs. Fixes hovering links in the
WML manual-test suite.
- wml/WMLCardElement.cpp:
- wml/WMLCardElement.h:
- wml/WMLElement.cpp: (WebCore::WMLElement::title):
- wml/WMLElement.h:
- wml/WMLOptGroupElement.cpp:
- wml/WMLOptGroupElement.h:
- wml/WMLSelectElement.cpp:
- wml/WMLSelectElement.h:
- 4:28 PM Changeset in webkit [46442] by
-
- 3 edits in trunk/JavaScriptCore
Build fix for Windows.
- 4:21 PM Changeset in webkit [46441] by
-
- 5 edits in trunk
Build fix for Windows for JSC recent breakage.
- 4:21 PM Changeset in webkit [46440] by
-
- 3 edits in trunk/LayoutTests
2009-07-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741
Now we evaluate the crawl targets lazily so as not to skew any JS binding caching with our test ordering.
We could get around all caching by always instantiating a new copy of the frame
but that would be super-slow. :)
We're now crawling a bunch more types, all of which we pass.
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/resources/prototype-inheritance-2.js: (evalToCrawlObject.LazyEvalCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
- 4:19 PM Changeset in webkit [46439] by
-
- 2 edits in trunk/WebCore
2009-07-27 Adam Treat <adam.treat@torchmobile.com>
Speculative build fix for Windows and WinCE.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- 3:56 PM Changeset in webkit [46438] by
-
- 5 edits in trunk/JavaScriptCore
2009-07-27 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- 3:45 PM Changeset in webkit [46437] by
-
- 8 edits2 adds in trunk
2009-07-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27474
Tests crashes when calling select, setSelectionRange or setting
selectionStart/selectionEnd on a textarea/input immediately after
setting display:none.
- fast/dom/text-control-crash-on-select-expected.txt: Added.
- fast/dom/text-control-crash-on-select.html: Added.
2009-07-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27474
Fixes crashes due to renderer getting destroyed in updateLayout.
We need to call updateLayout before we call into the renderer.
Removed the updateLayout call from RenderTextControl and moved it
into the calling sites.
Also changes updateLayout to updateLayoutIgnorePendingStylesheets so
this works with pending stylesheets. Unfortunately, this seems to be
untestable. Loading an external stylesheet and then having an inline
script hit this code did not result in an pending stylesheets.
The are other cases of this bug in the rendering code. I'll file a
followup bug to audit the calls to updateLayout.
Test: fast/dom/text-control-crash-on-select.html
- dom/Document.h: (WebCore::Document::inStyleRecalc): Added so the ASSERTs in updateFocusAppearance
and setSelectionRange could deal with cases of reentrancy into updateLayout
calls. This happens in a couple layout tests.
- dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
- html/HTMLInputElement.cpp: (WebCore::isTextFieldWithRendererAfterUpdateLayout): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select):
- html/HTMLTextAreaElement.cpp: (WebCore::rendererAfterUpdateLayout): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::updateFocusAppearance):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
- 3:43 PM Changeset in webkit [46436] by
-
- 2 edits in trunk/JavaScriptCore
Gtk build fix.
- runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
- 3:40 PM Changeset in webkit [46435] by
-
- 13 edits in trunk/WebCore
2009-07-27 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Levin.
[V8] Remove parameterless frame/window retrieval methods from V8Proxy.
https://bugs.webkit.org/show_bug.cgi?id=27737
Refactoring, no new behavior, covered by existing tests.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): Ditto.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Ditto. (WebCore::V8Proxy::canAccessPrivate): Ditto.
- bindings/v8/V8Proxy.h: Removed parameterless retrieveWindow/retrieveProxy decls.
- bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Changed to use V8Proxy::retrieveFrameForCurrentContext().
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
- 3:36 PM Changeset in webkit [46434] by
-
- 2 edits in trunk/WebKit/gtk
Gtk build fix.
- webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to SilenceAssertionsOnly.
- 3:26 PM Changeset in webkit [46433] by
-
- 2 edits in trunk/JavaScriptCore
Release build fix.
- runtime/JSLock.h: (JSC::JSLock::~JSLock):
- 3:18 PM Changeset in webkit [46432] by
-
- 3 edits3 adds in trunk
WebCore:
2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723
Trigger 'onpick' intrinsic events from WMLOptionElement::setSelectedState().
All was in place, just forgot to enable the relevant code.
Fixes manual-tests/wml/select-onpick-event.wml
Test: wml/option-element-onpick.html
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::setSelectedState):
LayoutTests:
2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723
Add a new WML layout test covering 'onpick' support.
- wml/option-element-onpick-expected.txt: Added.
- wml/option-element-onpick.html: Added.
- wml/resources/option-element-onpick.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- 3:07 PM Changeset in webkit [46431] by
-
- 84 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument
- 3:00 PM Changeset in webkit [46430] by
-
- 4 edits in trunk/WebCore
2009-07-27 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
WINCE PORT: Make plugin work for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27713
- plugins/win/PluginDatabaseWin.cpp: (SHGetValue): (PathRemoveFileSpec): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::init):
- 2:58 PM Changeset in webkit [46429] by
-
- 4 edits in trunk/WebCore
Adds support to the Web Inspector for tabbing through element attributes and CSS properties when editing.
2009-07-27 Joseph Pecoraro <joepeck02@gmail.com>
Inspector: Tab Through Element Attributes and CSS Properties When Editing
Reviewed by Timothy Hatcher.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._startEditing): refactored parameter (WebInspector.ElementsTreeElement.prototype._addNewAttribute): refactored to remove excess (WebInspector.ElementsTreeElement.prototype._triggerEditAttribute): provide an attribute name and this will start editing it (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): move between attributes (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.findTreeElementWithName): search through treeElements for a style property name (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): initialize a blank property for adding new properties (WebInspector.StylePropertyTreeElement.prototype.updateTitle): add references to the name and value elements (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted): include the move direction as a parameter to the commit callback (WebInspector.startEditing.element.handleKeyEvent): handle the tab key to specify the move direction (WebInspector.startEditing):
- 2:31 PM Changeset in webkit [46428] by
-
- 4 edits in trunk/WebCore
2009-07-27 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add mapping FontWeight to QFont::Weight values as requested via FIXME.
https://bugs.webkit.org/show_bug.cgi?id=27663
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
- platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::toQFontWeight):
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 2:21 PM WebKit Team edited by
- (diff)
- 2:21 PM Changeset in webkit [46427] by
-
- 2 edits in trunk/WebCore
2009-07-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
When clearing the plugin database, clear also the timestamp map.
Currently, if we clear the database, it will still think that it is up
to date with the plugin directories so refreshing the database again
after changing the search paths may not work.
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::clear):
- 2:17 PM Changeset in webkit [46426] by
-
- 3 edits in trunk/WebCore
2009-07-27 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
Add in trivial implementation of FontPlatformData::description() for
linux to fix build bustage in chromium.
Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732
Tested with a build of chromium on linux.
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::description):
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 12:45 PM QtWebKitTodo edited by
- (diff)
- 12:09 PM Changeset in webkit [46425] by
-
- 2 edits in trunk/WebCore
2009-07-27 Brent Fulgham <bfulgham@webkit.org>
Build correct, no review.
Final correction for WinCairo builds.
CoreServices only exists in Apple builds, but
some of its internal includes (e.g., <windows.h>) are needed
for other Windows targets.
- WebCorePrefix.h: When building for WinCairo, make sure to include <windows.h>, <stdio.h>, and <ConditionalMacros.h>
- 11:54 AM Changeset in webkit [46424] by
-
- 2 edits in trunk/WebKitLibraries
2009-07-27 Peter Kasting <pkasting@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27323
Correctly parse command output, even when the line endings are not LF,
so that we don't create an autoversion.h that MSVC chokes on.
- win/tools/scripts/auto-version.sh:
- 11:32 AM Changeset in webkit [46423] by
-
- 8 edits22 adds in trunk
WebCore:
2009-07-27 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25552
Added new "pattern" attribute to HTMLInputElement and validation code
(validity.patternMismatch) as per HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-pattern
Tests: fast/forms/ValidityState-002.html
fast/forms/ValidityState-patternMismatch-001.html
fast/forms/ValidityState-patternMismatch-002.html
fast/forms/ValidityState-patternMismatch-003.html
fast/forms/ValidityState-patternMismatch-004.html
fast/forms/ValidityState-patternMismatch-005.html
fast/forms/ValidityState-patternMismatch-006.html
fast/forms/ValidityState-patternMismatch-007.html
fast/forms/pattern-attribute-001.html
fast/forms/pattern-attribute-002.html
fast/forms/pattern-attribute-003.html
- html/HTMLAttributeNames.in: pattern attribute
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::patternMismatch): method definition
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::patternMismatch): validation method
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/ValidityState.h: (WebCore::ValidityState::patternMismatch): validation flag
LayoutTests:
2009-07-27 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25552
First series of tests for the "pattern" attribute and related validation
code
- fast/forms/ValidityState-002-expected.txt: Copied from LayoutTests/fast/forms/willvalidate-001-expected.txt.
- fast/forms/ValidityState-002.html: Added.
- fast/forms/ValidityState-patternMismatch-001-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-001.html: Added.
- fast/forms/ValidityState-patternMismatch-002-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-002.html: Added.
- fast/forms/ValidityState-patternMismatch-003-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-003.html: Added.
- fast/forms/ValidityState-patternMismatch-004-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-004.html: Added.
- fast/forms/ValidityState-patternMismatch-005-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-005.html: Added.
- fast/forms/ValidityState-patternMismatch-006-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-006.html: Added.
- fast/forms/ValidityState-patternMismatch-007-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-007.html: Added.
- fast/forms/pattern-attribute-001-expected.txt: Added.
- fast/forms/pattern-attribute-001.html: Added.
- fast/forms/pattern-attribute-002-expected.txt: Added.
- fast/forms/pattern-attribute-002.html: Added.
- fast/forms/pattern-attribute-003-expected.txt: Added.
- fast/forms/pattern-attribute-003.html: Added.
- 11:22 AM Changeset in webkit [46422] by
-
- 31 edits3 adds7 deletes in trunk/WebCore
Reviewed by George Staikos.
[WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718
Fix file paths in the manual WML layout tests, remove unneeded tests (already covered by DRT tests).
Add missing resources directory and test image. Reformat all testcases to a common style.
Add new StartTests.wml file, which should be used as starting point to crawl through the manual tests.
Filing bugs soon for all tests exposing bugs (7 in total).
- 11:17 AM Changeset in webkit [46421] by
-
- 2 edits in trunk/WebCore
2009-07-27 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).
- 11:08 AM Changeset in webkit [46420] by
-
- 2 edits in trunk/WebCore
2009-07-27 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Removing a no-op block of code in DatabaseTracker.cpp that
should've been removed in the patch for bug 26054.
All tests in WebCore/storage pass.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Removed a no-op block of code that was moved to SQLiteFileSystem.cpp and should have been removed from DatabaseTracker.cpp
- 10:45 AM Changeset in webkit [46419] by
-
- 13 edits7 adds in trunk
WebCore:
2009-07-27 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525
The following problems have been fixed:
1) The uncaught runtime script error is not reported using the
WorkerGlobalScope object's onerror attribute.
2) If the error is still not handled afterwards (onerror attribute
is not defined as a function or it returns true), the error should
be reported back to the associated Worker object by firing an
ErrorEvent.
3) If the error is still not handled by the associated Worker
object, the error should be reported to the user.
Test: fast/workers/worker-script-error.html
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::reportError):
- bindings/js/JSEventListener.h:
- dom/EventListener.h: (WebCore::EventListener::reportError): adds a function to call EventListener as a function with 3 arguments to report an error.
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
- workers/AbstractWorker.h:
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::reportException):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):
- workers/WorkerMessagingProxy.h:
LayoutTests:
2009-07-27 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Layout tests for fixing error handling in dedicated worker and worker
context.
https://bugs.webkit.org/show_bug.cgi?id=27525
- fast/workers/resources/worker-error-in-handling-script-error.js: Added
- fast/workers/resources/worker-invalid-syntax.js: Added.
- fast/workers/resources/worker-script-error-bubbled.js: Added.
- fast/workers/resources/worker-script-error-handled.js: Added.
- fast/workers/resources/worker-script-error-unhandled.js: Added.
- fast/workers/worker-constructor.html:
- fast/workers/worker-script-error-expected.txt: Added.
- fast/workers/worker-script-error.html: Added. Add test cases to cover different script error handling scenarios.
- 10:04 AM Changeset in webkit [46418] by
-
- 13 edits8 adds in trunk
[WML] History handling / page cache / loading is buggy and depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707
Redesign WML history/loading handling. See ChangeLog for details.
- 8:09 AM Changeset in webkit [46417] by
-
- 3 edits in trunk/WebCore
2009-07-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Roben.
Fix Chromium build breakage introduced in 46388.
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::description):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
- 6:41 AM Changeset in webkit [46416] by
-
- 2 edits in trunk/WebKitTools
2009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Generating remote links causes a lot of unnecessary spew on Qt build bot too
- Scripts/run-webkit-tests:
- 4:34 AM Changeset in webkit [46415] by
-
- 3 edits in trunk/WebKit/qt
2009-07-27 Volker Hilsheimer <volker.hilsheimer@nokia.com>
Reviewed by Simon Hausmann.
QWebView's "enabled" parameter should default to true, as with QGraphicsView and
QPainter.
- Api/qwebview.cpp: Add reference to QPainter::renderHints().
- Api/qwebview.h: Add default for enabled argument.
- 4:29 AM Changeset in webkit [46414] by
-
- 2 edits in trunk/WebCore
2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Add some more debug logging to PluginViewMac.
- plugins/mac/PluginViewMac.cpp:
- 4:27 AM Changeset in webkit [46413] by
-
- 2 edits in trunk/WebCore
2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Jan Michael Alonzo.
Remove dead code from the GTK NPAPI implementation.
- plugins/gtk/PluginViewGtk.cpp:
- 4:06 AM Changeset in webkit [46412] by
-
- 2 edits in trunk/LayoutTests
2009-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Add fast/canvas/image-pattern-rotate.html to Skipped as it needs
platform-specific expected results.
- platform/gtk/Skipped:
- 3:39 AM Changeset in webkit [46411] by
-
- 2 edits in trunk/WebCore
2009-07-27 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Buildfix on Windows.
https://bugs.webkit.org/show_bug.cgi?id=27702
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedEndPaint):
Constraint of (*endPaint) operand modified from "g" to "m" (memory) in inline
assembly, because with "g" constraint, wrong assembly code generated.
- 2:06 AM Changeset in webkit [46410] by
-
- 6 edits4 adds in trunk/WebCore
2009-07-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebCore bindings: Implement ScriptArray bindings.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::handleException): (WebCore::ScriptArray::set): (WebCore::length): (WebCore::ScriptArray::createNew):
- bindings/js/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
- bindings/v8/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
- bindings/v8/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
- 12:17 AM Changeset in webkit [46409] by
-
- 2 edits in trunk/WebCore
2009-07-27 Brent Fulgham <bfulgham@webkit.org>
Build correct, no review.
Change in r46407 broke Apple Windows build.
Switch to WinCairo-only test, to avoid any
other platform break.
- WebCorePrefix.h:
- 12:02 AM Changeset in webkit [46408] by
-
- 2 edits in trunk/WebCore
2009-07-26 Brent Fulgham <bfulgham@webkit.org>
Build correct, no review.
Change in r46407 broke Apple Windows build.
- WebCorePrefix.h: Use WTF_PLATFORM_CG to decide if CoreServices.h should be included.
Jul 26, 2009:
- 11:39 PM Changeset in webkit [46407] by
-
- 2 edits in trunk/WebCore
2009-07-26 Brent Fulgham <bfulgham@webkit.org>
Build correction, no review.
Change in r46195 broke WinCairo build.
- WebCorePrefix.h: CoreServices should be ignored for non-Apple build.
- 12:47 PM Changeset in webkit [46406] by
-
- 2 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
More documentation cleanups in the QWebElement class overview.
- Api/qwebelement.cpp:
- 12:47 PM Changeset in webkit [46405] by
-
- 3 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Clean up documentation of QWebElement's findFirst and findAll functions,
as well as their QWebFrame counterparts.
- Api/qwebelement.cpp:
- Api/qwebframe.cpp:
- 12:47 PM Changeset in webkit [46404] by
-
- 5 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Various documentation cleanups
- Fixed qdoc warnings
- Hide QWebNetworkInterface from the class overview
- Mention QWebElement in the module overview
- More cleanups
- Api/qwebframe.cpp:
- Api/qwebnetworkinterface.cpp:
- Api/qwebview.cpp:
- docs/qtwebkit.qdoc:
- 12:47 PM Changeset in webkit [46403] by
-
- 2 edits1 add in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Added missing class diagram referenced from the docs, taken from the Qt
documentation.
- docs/qtwebkit.qdocconf: Register the image directory with qdoc.
- docs/qwebview-diagram.png: Added.
- 8:36 AM Changeset in webkit [46402] by
-
- 6 edits in trunk/WebCore
2009-07-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement the breakpoints sidebar pane.
This change adds simple UI support into the existing
BreakpointSidebarPane.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get label): (WebInspector.Breakpoint.prototype.get id):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.labelClicked): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.scriptOrResourceForID):
- inspector/front-end/inspector.css:
Jul 25, 2009:
- 3:14 PM Changeset in webkit [46401] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-25 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
https://bugs.webkit.org/show_bug.cgi?id=27342
Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.
- API/JSObjectRef.cpp:
- 3:11 PM Changeset in webkit [46400] by
-
- 2 edits in trunk
Fixup ChangeLog.
- 3:00 PM Changeset in webkit [46399] by
-
- 5 edits4 adds in trunk
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749
Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.
Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.
- fast/canvas/image-pattern-rotate.html: Added.
- platform/mac/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/mac/fast/canvas/image-object-in-canvas-expected.png:
- platform/mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
- platform/mac/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/mac/fast/canvas/image-pattern-rotate-expected.txt: Added.
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749
Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.
Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.
Test: fast/canvas/image-pattern-rotate.html
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 2:36 PM Changeset in webkit [46398] by
-
- 7 edits in trunk
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCore.vcproj:
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- WebKit.vcproj/WebKit.vcproj:
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 2:34 PM Changeset in webkit [46397] by
-
- 2 edits in trunk/WebCore
2009-07-25 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Kevin McCullough.
Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286
- inspector/front-end/inspector.js: (WebInspector.loaded): save a list of the order of the panels (WebInspector.documentKeyDown): handle the keyboard shortcuts to traverse the panels
- 2:29 PM Changeset in webkit [46396] by
-
- 2 edits in trunk/WebCore
2009-07-25 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
[Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680
- WebCore.pro:
- 9:43 AM Changeset in webkit [46395] by
-
- 8 edits4 adds in trunk
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677
Substitute variables upon attach() time instead of insertedIntoDocument(). Otherwhise variable substitution
won't work during inter-deck jumps (same URL, different fragment). Covered by new test fast/wml/newcontext-same-deck.html.
- dom/Text.cpp: (WebCore::Text::attach):
- dom/Text.h:
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677
Always substitute variables regardless of their existance. If a variable doesn't exist, expand it to an empty string.
Correct several testcases, relying on the old buggy behaviour.
- wml/newcontext-same-deck-expected.txt: Added.
- wml/newcontext-same-deck.html: Added.
- wml/resources/WMLTestCase.js: (createWMLTestCase.iframeElement.onload): (createWMLTestCase): (assureLayout): (startTest): (triggerMouseEvent):
- wml/resources/newcontext-same-deck.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/newcontext-same-deck.wml: Added.
- wml/resources/select-element-variables.js: (prepareTest):
- wml/select-element-variables-expected.txt:
- wml/variable-reference-invalid-character-expected.txt:
- 9:35 AM Changeset in webkit [46394] by
-
- 10 edits in trunk
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676
WMLDoElement needs to implement attach() and call updateFromElement() on its associated RenderButton.
Mimics HTMLButtonElement/HTMLFormControlElement behaviour and fixes several painting/styling issues covered by existing tests in fast/wml.
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::attach):
- wml/WMLDoElement.h:
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676
Update layout test results after fixing WMLDoElement::attach() not calling updateFromElement().
- platform/mac/fast/wml/do-element-optional-attr-expected.txt:
- platform/mac/fast/wml/do-shadow-expected.txt:
- platform/mac/fast/wml/do-template-expected.txt:
- platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt:
- platform/mac/fast/wml/err-invalid-variable-name-expected.txt:
- platform/mac/fast/wml/err-samename-do-expected.txt:
- 9:23 AM Changeset in webkit [46393] by
-
- 3 edits in trunk/LayoutTests
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675
Slightly cleanup this patch so it's easier to figure out what the expected result for <select> element is.
- http/tests/wml/post-data-to-server-expected.txt:
- http/tests/wml/resources/post-data-to-server.js: (setupTestDocument): (prepareTest):
- 2:51 AM Changeset in webkit [46392] by
-
- 2 edits in trunk/WebCore
2009-07-25 Pavel Feldman <pfeldman@chromium.org>
Fix Windows build breakage introduced in 46390.
- WebCore.vcproj/WebCore.vcproj:
- 2:44 AM Changeset in webkit [46391] by
-
- 3 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Oliver Hunt.
Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): use the displaySort when showing properties (WebInspector.ObjectPropertiesSection.prototype._displaySort): alphaNumerical sort (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): use the displaySort when showing properties
- inspector/front-end/utilities.js: (Object.sortedProperties): allow for an optional sorting function in Object.sortedProperties
- 2:22 AM Changeset in webkit [46390] by
-
- 22 edits3 moves2 adds in trunk/WebCore
2009-07-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Split InspectorController into InspectorController
and InspectorBackend. Everything frontend needs from InspectorController
will slowly migrate into the InspectorBackend.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSInspectorBackendCustom.cpp: Added. (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::search): (WebCore::JSInspectorBackend::databaseTableNames): (WebCore::JSInspectorBackend::inspectedWindow): (WebCore::JSInspectorBackend::setting): (WebCore::JSInspectorBackend::setSetting): (WebCore::JSInspectorBackend::wrapCallback): (WebCore::JSInspectorBackend::currentCallFrame): (WebCore::JSInspectorBackend::profiles):
- bindings/v8/custom/V8InspectorBackendCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/js/JSInspectorControllerCustom.cpp: Removed.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/ScriptObject.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::windowScriptObjectAvailable):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackend):
- inspector/InspectorBackend.cpp: Added.
- inspector/InspectorBackend.h: Added. (WebCore::InspectorBackend::create): (WebCore::InspectorBackend::inspectorController):
- inspector/InspectorBackend.idl: Added.
- inspector/InspectorController.idl: Removed.
- inspector/front-end/Resource.js:
- page/Page.cpp: (WebCore::Page::Page):
- page/Page.h:
- 12:47 AM Changeset in webkit [46389] by
-
- 3 edits in trunk/WebCore
2009-07-25 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by George Staikos.
Update WebCore/page/Frame.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27654
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::firstRectForRange): (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::setZoomFactor): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::selectionBounds): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::documentAtPoint):
- page/Frame.h: (WebCore::Frame::create): (WebCore::Frame::displayStringModifiedByEncoding): (WebCore::Frame::pageZoomFactor): (WebCore::Frame::textZoomFactor):
Jul 24, 2009:
- 8:50 PM Changeset in webkit [46388] by
-
- 21 edits in trunk/WebCore
Reviewed by Darin Adler.
Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671
- platform/graphics/FontData.h: Defined a description() method.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::showSubtree): Added. Prints the node and
its descendants.
(showGlyphPageTrees): Added. Prints all glyph page trees.
(showGlyphPageTree): Added. Prints the glyph page tree for a given page.
- platform/graphics/GlyphPageTreeNode.h:
- platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::description): Added.
- platform/graphics/SegmentedFontData.h:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::description): Added. Uses the platform data
as the description for non-svg, non-custom fonts.
- platform/graphics/SimpleFontData.h:
- platform/graphics/gtk/FontPlatformData.h:
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description): Added. Returns the
description of the CGFont, the size and the synthetic style flags,
if set.
- platform/graphics/qt/FontPlatformData.h:
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- platform/graphics/win/FontPlatformData.h:
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- platform/graphics/wince/FontPlatformData.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- platform/graphics/wince/FontPlatformData.h:
- platform/graphics/wx/FontPlatformData.h:
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
- 6:49 PM Changeset in webkit [46387] by
-
- 2 edits in trunk/JavaScriptCore
In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.
Reviewed by Mark Rowe.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::propagateDecommittedState): (WTF::mergeDecommittedStates): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::IncrementalScavenge):
- 6:13 PM Changeset in webkit [46386] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py
- 5:57 PM Changeset in webkit [46385] by
-
- 1 edit in trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Dorument?
- 5:56 PM Changeset in webkit [46384] by
-
- 3 edits in trunk/WebKit/mac
2009-07-24 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
REGRESSION (r46298): Exception after clicking on Bookmarks button in the Bookmarks Bar
https://bugs.webkit.org/show_bug.cgi?id=27667
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved the code to set the title here. This is late enough that both the view and representation exist.
- WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Removed the code to set the title from here. It's a bit too early.
- 4:46 PM Changeset in webkit [46383] by
-
- 23 edits in trunk/WebCore
2009-07-24 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488
Add proper 'create' methods to SVGPodTypeWrappers and
XPathNSResolvers in the V8 bindings to avoid memory leaks.
Introduce convertToV8Object methods that accept PassRefPtrs and
clean up the use of get() and release() on RefPtrs.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object):
- bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeWrapperCreatorForList::create): (WebCore::V8SVGPODTypeWrapperCreatorForList::V8SVGPODTypeWrapperCreatorForList): (WebCore::V8SVGStaticPODTypeWrapper::create): (WebCore::V8SVGStaticPODTypeWrapper::V8SVGStaticPODTypeWrapper): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::V8SVGStaticPODTypeWrapperWithPODTypeParent): (WebCore::V8SVGStaticPODTypeWrapperWithParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithParent::V8SVGStaticPODTypeWrapperWithParent): (WebCore::V8SVGDynamicPODTypeWrapper::create): (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create):
- bindings/v8/custom/V8CustomXPathNSResolver.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::ACCESSOR_GETTER):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 4:35 PM Changeset in webkit [46382] by
-
- 2 edits in trunk/LayoutTests
Skip a test that is failing intermittently on the Windows build bot.
- platform/win/Skipped:
- 4:26 PM Changeset in webkit [46381] by
-
- 2 edits in trunk/LayoutTests
Skip a plug-in test that fails an assertion around 50% of the time.
- platform/mac-snowleopard/Skipped:
- 4:02 PM Changeset in webkit [46380] by
-
- 2 edits in trunk/LayoutTests
Skip two SVG tests that are giving unexpected results.
- platform/mac-snowleopard/Skipped:
- 3:45 PM UsingGitWithWebKit edited by
- (diff)
- 3:45 PM Changeset in webkit [46379] by
-
- 2 edits in trunk/LayoutTests
Skip two plug-in tests that are failing.
- platform/mac-snowleopard/Skipped:
- 3:31 PM BuildingQtOnWindows edited by
- Fix inconsistent instruction vs. corresponding explanation (paths were … (diff)
- 3:28 PM BuildingQtOnWindows edited by
- I followed the guidelines here, and it seems make isn't shipped by Qt … (diff)
- 3:20 PM Changeset in webkit [46378] by
-
- 2 edits in trunk/LayoutTests
Land correct results for a SnowLeopard-only accessibility test.
- platform/mac/accessibility/table-multi-bodies-expected.txt:
- 2:57 PM Changeset in webkit [46377] by
-
- 3 edits in trunk/WebCore
2009-07-24 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
Fix of <rdar://6310538> Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794
Create two new booleans to determine whether we have done a springloaded pan scroll, and update
the name of setPanScrollCursor to updatePanScrollState to more accurately describe what the function
does.
- page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Initialized two new booleans. (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updatePanScrollState): Renamed from setPanScrollCursor. (WebCore::EventHandler::stopAutoscrollTimer): Clear the pan scrolling in progress flag. (WebCore::EventHandler::handleMouseReleaseEvent): Clear the pan scrolling button pressed flag.
- page/EventHandler.h:
- 2:33 PM UsingGitWithWebKit edited by
- (diff)
- 2:31 PM Changeset in webkit [46376] by
-
- 3 edits in trunk/WebCore
2009-07-24 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Changed WorkerContext destructor to not access possibly-freed WorkerThread.
Failed assertion in WorkerContext::~WorkerContext().
https://bugs.webkit.org/show_bug.cgi?id=27665
- workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Removed assertion that relies on WorkerThread still being alive (moved to DedicatedWorkerContext destructor).
- 2:18 PM Changeset in webkit [46375] by
-
- 2 edits in trunk/WebKitTools
2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by Adam Treat.
Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605
If the user doesn't manually modify the ChangeLog files, use
prepare-ChangeLog to populate the git commit message. This behaviour
can be disabled by the 'webkitGenerateCommitMessage' git configuration option.
- Scripts/commit-log-editor:
- 2:13 PM Changeset in webkit [46374] by
-
- 1 edit11 adds in trunk/WebCore
2009-07-24 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27657
Add more wince port files to WebCore
Written by Yong Li <yong.li@torchmobile.com> and Lyon Chen <lyon.chen@torchmobile.com>
- loader/icon/wince/IconDatabaseWince.cpp: Added.
- rendering/RenderThemeWince.cpp: Added.
- rendering/RenderThemeWince.h: Added.
- storage/wince/DatabaseThreadWince.cpp: Added.
- storage/wince/DatabaseThreadWince.h: Added.
- storage/wince/LocalStorageThreadWince.cpp: Added.
- storage/wince/LocalStorageThreadWince.h: Added.
- svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
- 2:12 PM Changeset in webkit [46373] by
-
- 3 edits4 adds in trunk
WebCore:
2009-07-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333
highestAncestorWithTextDecoration stops at the closest unsplittable element so that if text-decoration is applied
outside of it, we don't accidently modify the style attribute.
Tests: editing/style/textdecoration-outside-of-rooteditable.html
editing/style/textdecoration-outside-of-unsplittable-element.html
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::highestAncestorWithTextDecoration):
LayoutTests:
2009-07-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333
Tests to make sure we are not removing underline applied outside of root editable node or unsplittable element.
- editing/style/textdecoration-outside-of-rooteditable-expected.txt: Added.
- editing/style/textdecoration-outside-of-rooteditable.html: Added.
- editing/style/textdecoration-outside-of-unsplittable-element-expected.txt: Added.
- editing/style/textdecoration-outside-of-unsplittable-element.html: Added.
- 1:59 PM Changeset in webkit [46372] by
-
- 3 edits2 adds in trunk
2009-07-24 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor does not prevent evaluation of scripts that only contain
non-canonical characters.
- http/tests/security/xssAuditor/script-tag-safe-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe.html: Added.
2009-07-24 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes false positives when evaluating certain strings that only contain
non-canonical characters.
Test: http/tests/security/xssAuditor/script-tag-safe.html
- page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::XSSAuditor::findInRequest):
- 12:54 PM Changeset in webkit [46371] by
-
- 5 edits3 adds in trunk
WebCore:
2009-07-24 Drew Wilson <atwilson@google.com>
Reviewed by Adam Barth.
Updated code generator to properly generate bindings for WorkerContext exposed functions.
Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419
Test: fast/workers/worker-call.html
- bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSDedicatedWorkerContext): (WebCore::toJSWorkerContext): Functions that convert from JSValue to the appropriate WorkerContext/DedicatedWorkerContext object.
- bindings/js/JSWorkerContextBase.h: Added toJS*WorkerContext APIs.
- bindings/scripts/CodeGeneratorJS.pm: Added code to appropriately check the passed-in this object when invoking functions at global scope.
LayoutTests:
2009-07-24 Drew Wilson <atwilson@google.com>
Reviewed by Adam Barth.
Added layout tests to exercise various use cases for calling functions defined on Worker global scope.
Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419
- fast/workers/resources/worker-call.js: Added.
- fast/workers/worker-call-expected.txt: Added.
- fast/workers/worker-call.html: Added.
- 12:28 PM Changeset in webkit [46370] by
-
- 9 edits in trunk/WebCore
2009-07-24 Drew Wilson <atwilson@google.com>
Reviewed by Adam Barth.
Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420
No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).
- DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
- DerivedSources.make: Added DerivedWorkerContext files
- GNUmakefile.am: Added DerivedWorkerContext files
- WebCore.gypi: Added DerivedWorkerContext files
- WebCore.pro: Added DerivedWorkerContext files
- WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
- WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
- bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
- bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
- bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
- bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
- bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
- bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
- bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
- bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
- bindings/v8/custom/V8AbstractWorkerCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
- dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
- dom/EventTarget.h:
- workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
- workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
- workers/DedicatedWorkerContext.idl: Added.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
- workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
- workers/WorkerContext.idl:
- workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
- workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
- 12:23 PM Changeset in webkit [46369] by
-
- 28 edits5 adds in trunk/WebCore
2009-07-24 Drew Wilson <atwilson@google.com>
Reviewed by Adam Barth.
Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420
No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).
- DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
- DerivedSources.make: Added DerivedWorkerContext files
- GNUmakefile.am: Added DerivedWorkerContext files
- WebCore.gypi: Added DerivedWorkerContext files
- WebCore.pro: Added DerivedWorkerContext files
- WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
- WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
- bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
- bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
- bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
- bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
- bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
- bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
- bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
- bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
- bindings/v8/custom/V8AbstractWorkerCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
- dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
- dom/EventTarget.h:
- workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
- workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
- workers/DedicatedWorkerContext.idl: Added.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
- workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
- workers/WorkerContext.idl:
- workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
- workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
- 12:01 PM Changeset in webkit [46368] by
-
- 10 edits in trunk
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645
I also had to add support for passing arguments to constructors
in order to test the Worker constructor.
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/resources/constructed-objects-prototypes.js:
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645
Fix the last few constructors to use their stored globalObject pointer when
constructing objects instead of the lexicalGlobalObject().
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
- bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- 11:05 AM Changeset in webkit [46367] by
-
- 4 edits in trunk/WebKit/qt
2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Adam Treat.
As per discussion on IRC, changed originalUrl by requestedUrl.
- Api/qwebframe.cpp: (QWebFrame::requestedUrl):
- Api/qwebframe.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 10:57 AM Changeset in webkit [46366] by
-
- 5 edits in trunk/WebKit/qt
2009-07-24 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Adam Treat.
Removed void QWebFrame::renderContents(...) and added the Q_PROPERTY
clipRenderToViewport to control whether QWebFrame::render would call
FrameView::paintContents rather than FrameView::paint and do not clip
the frame content to viewport.
https://bugs.webkit.org/show_bug.cgi?id=26352
- Api/qwebframe.cpp: (QWebFramePrivate::renderPrivate): (QWebFrame::clipRenderToViewport): (QWebFrame::setClipRenderToViewport):
- Api/qwebframe.h:
- Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
- tests/qwebframe/tst_qwebframe.cpp:
- 10:56 AM Changeset in webkit [46365] by
-
- 4 edits in trunk/WebCore
2009-07-24 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
[V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::setException):
- 10:55 AM Changeset in webkit [46364] by
-
- 5 edits2 adds in trunk/WebKit/qt
2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[QT] Implement originalUrl getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867
- Api/qwebframe.cpp: (QWebFrame::originalUrl):
- Api/qwebframe.h:
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/test1.html: Added.
- tests/qwebframe/test2.html: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 10:44 AM Changeset in webkit [46363] by
-
- 3 edits in trunk/WebCore
2009-07-24 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Reverting r46157, since it may be causing problems with Chromium
reliability (see http://crbug.com/17569).
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
- 10:39 AM Changeset in webkit [46362] by
-
- 2 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646
- inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
- 10:34 AM Changeset in webkit [46361] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
Add the shadow style member to the ShadowData constructor and ==
operator
- rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
- 10:30 AM Changeset in webkit [46360] by
-
- 6 edits in trunk/WebCore
2009-07-24 Jian Li <jianli@chromium.org>
Reviewed by Eric Seidel.
[V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 10:26 AM EFLWebKit edited by
- (diff)
- 9:53 AM Changeset in webkit [46359] by
-
- 6 edits in trunk
WebCore:
2009-07-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Hyatt.
Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.
- platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h
WebKit/win:
2009-07-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Hyatt.
Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.
- DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
- WebDownload.h: Conditionalize include of CFNetwork.h
- WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
- 9:28 AM Changeset in webkit [46358] by
-
- 2 edits in trunk/WebCore
Another attempted build fix
- bindings/js/JSAbstractWorkerCustom.cpp:
- 9:28 AM Changeset in webkit [46357] by
-
- 3 edits in trunk/WebKitTools
2009-07-24 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
cpplint crash when there is a duplicate header followed by another header.
https://bugs.webkit.org/show_bug.cgi?id=27625
- Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even there is a duplicate header, which resulted in some code rearrangement. Also, changed some if's in this function to return early. This avoids having nearly the whole function content being indented.
- Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
- 9:27 AM Changeset in webkit [46356] by
-
- 2 edits in trunk/WebCore
Build fix.
- bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::toJS):
- 8:37 AM Changeset in webkit [46355] by
-
- 4 edits in trunk/WebKitTools
2009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653
Introduce .c support for check_webkit_style, and remove support for
.cc files in favor of .cpp.
- Scripts/check-webkit-style:
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 7:26 AM Changeset in webkit [46354] by
-
- 2 edits in trunk
2009-07-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove unneeded commas from PKG_CHECK_MODULES.
- configure.ac:
- 6:44 AM Changeset in webkit [46353] by
-
- 2 edits in trunk/WebCore
2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>
Build fix for 64 bit Linux.
int64_t is long on Linux 64 bit and not long long, thus
getFileSize with a int64_t out value fails to build.
Use a temporary to work around the problem.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
- 6:44 AM Changeset in webkit [46352] by
-
- 2 edits in trunk/WebKit/qt
2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>
Build fix for Qt.
Fix build issue introduced in 46344
([Bug 22700] ApplicationCache should have size limit)
Remove method only added to the Qt ChromeClient.
- WebCoreSupport/ChromeClientQt.h:
- 5:55 AM Changeset in webkit [46351] by
-
- 2 edits in trunk/LayoutTests
2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648
Add http/tests/appcache/max-size.html to the Skipped file for now.
- platform/gtk/Skipped:
- 5:37 AM BuildingQtOnWindows edited by
- (diff)
- 5:31 AM Changeset in webkit [46350] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-24 Priit Laes <plaes@plaes.org>
Reviewed by Xan Lopez.
[Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560
Check authentication result and save password only when authentication
succeeds.
- webkit/webkitsoupauthdialog.c: (free_authData): (response_callback): (save_password_callback):
- 3:50 AM Changeset in webkit [46349] by
-
- 2 edits in trunk/WebKitTools
2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by David Levin.
Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605
add --[no-]write prepare-ChangeLog options to bash completion
- Scripts/webkit-tools-completion.sh:
- 3:03 AM Changeset in webkit [46348] by
-
- 21 edits in trunk
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644
Make a bunch more tests pass. Still not all of them.
The rest will pass when the last bits of bug 27634 land.
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644
This is another attempt at making the change for bug 27634 smaller.
I included the changes to make_names.pl as well as any file which
used CREATE_DOM_*_WRAPPER macros.
The changes to the construct* functions are what fix the cases in
fast/dom/constructed-objects-prototypes.html
The changes to passing globalObject through CREATE_* are what fix
fast/dom/prototype-inheritance-2.html
- bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value. (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value. (WebCore::toJSNewlyCreated): pass globalObject.
- bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): pass globalObject. (WebCore::toJS): pass globalObject.
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): use globalObject() for wrapping returned collection items. (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items. (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items. (WebCore::toJS): pass globalObject.
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject.
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): pass globalObject.
- bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
- dom/make_names.pl:
Pass globalObject through CREATE_* macros and various support functions.
- 2:50 AM Changeset in webkit [46347] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin Adler and Adam Barth.
Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602
- jit/JIT.cpp:
- 2:15 AM Changeset in webkit [46346] by
-
- 31 edits in trunk
2009-07-24 Andrei Popescu <andreip@google.com>
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.
- http/tests/appcache/max-size-expected.txt: Added.
- http/tests/appcache/max-size.html: Added.
- http/tests/appcache/resources/maxsize.manifest: Added.
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643
This is an attempt to make this change as small as possible.
I started by including all changes to CodeGeneratorJS.pm from bug 27634,
and then made the minimal amount of other changes needed to support that change.
Most toJS implementations ignore their passed JSDOMGlobalObject.
There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
All places where it is not clear what we should pass as the global object
(or where the global object is simply not available, like for some SVG bindings)
we pass deprecatedGlobalObjectForPrototype instead.
- bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): pass the wrong globalObject for now
- bindings/js/JSDOMBinding.h:
Pass the wrong global object to the CREATE_ macros for now.
In the next change we'll come back and pass the correct one.
That will require changes to make_names.pl.
(WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
(WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
(WebCore::toJSNewlyCreated):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::toJS): DOMWindow always uses its own prototype chain.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
- bindings/js/JSEventCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSEventTarget.h:
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject* (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::toJS): pass globalObject along
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now. (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGPathSegListCustom.cpp:
All of these methods need a globalObject, but most SVG binding don't have
space for one, so we just pass the lexicalGlobalObject for now.
(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
- bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
- bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
- bindings/js/JSWorkerContextBase.h:
- bindings/scripts/CodeGeneratorJS.pm:
All generated toJS calls now pass a globalObject.
All generated toJS implementations now expect a globalObject.
Simplified all the slot casts by using a "castedThis" local.
SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
Simplified printing of constructor objects using a $constructorClassName variable.
All generated constructor functions follow the construct$className form to match the custom constructors.
- 2:14 AM Changeset in webkit [46345] by
-
- 2 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
typing "document.proto" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169
- inspector/front-end/utilities.js: (Object.type):
- 2:12 AM Changeset in webkit [46344] by
-
- 40 edits5 adds in trunk
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
Adds the WebApplicationCache class that is
used by the DumpRenderTree test application to
configure the Application Cache maximum size.
- WebCoreSupport/WebApplicationCache.h: Added.
- WebCoreSupport/WebApplicationCache.mm: Added.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
- WebKit.exp:
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
- WebCoreSupport/ChromeClientQt.h:
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedMaxAppCacheSize): Adds empty implementation of reachedMaxAppCacheSize.
- WebCoreSupport/ChromeClientGtk.h:
2009-07-24 Andrei Popescu <andreip@google.com>
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
Updated the project after adding WebApplicationCache.h/mm
- WebKit.xcodeproj/project.pbxproj:
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
- WebCoreSupport/WebChromeClient.h:
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
- WebKitSupport/ChromeClientWx.h:
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html
This change implements a mechanism for limiting the maximum size of
the application cache file. When this size is reached, a ChromeClient
callback is invoked asynchronously and the saving of the last (failed)
cache is retried automatically.
This change also extends the ApplicationCacheStorage API by allowing
a client to query or modify the application cache without having to
load any resources into memory.
Test: http/tests/appcache/max-size.html
- WebCore.base.exp: Exports the symbols required by the DumpRenderTree test application.
- loader/EmptyClients.h: Adds empty implementation of the new ChromeClient methods.
- loader/appcache/ApplicationCache.cpp:
- loader/appcache/ApplicationCache.h: Adds the ability to calculate the approximate size of an ApplicationCache object.
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h: Invokes the ChromeClient callback when the storage layer runs out of space. After the callback is invoked, we re-attempt to store the newest cache, in case the ChromeClient has freed some space.
- loader/appcache/ApplicationCacheResource.cpp:
- loader/appcache/ApplicationCacheResource.h: Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
- loader/appcache/ApplicationCacheStorage.cpp:
- loader/appcache/ApplicationCacheStorage.h: Enforces a maximum size for the application cache file.
- page/ChromeClient.h: Adds a new callback, invoked when the ApplicationCacheStorage reports that it has reached the maximum size for its database file.
- platform/sql/SQLiteDatabase.cpp:
- platform/sql/SQLiteDatabase.h: Adds a new method that allows querying for the amount of unused space inside the application cache database file.
2009-07-24 Andrei Popescu <andreip@google.com>
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.
- http/tests/appcache/max-size-expected.txt: Added.
- http/tests/appcache/max-size.html: Added.
- http/tests/appcache/resources/maxsize.manifest: Added.
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
Adds a new method on the LayoutTestController that
allows a JS unit test to configure the maximum size
of the Application Cache.
- DumpRenderTree/LayoutTestController.cpp: (setAppCacheMaximumSizeCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAppCacheMaximumSize):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAppCacheMaximumSize):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAppCacheMaximumSize):
- 1:42 AM Changeset in webkit [46343] by
-
- 2 edits in trunk/WebCore
2009-07-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Use TextEncoding facilities to convert between UTF16 and UTF8
instead of rolling our own solution.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
- 1:42 AM Changeset in webkit [46342] by
-
- 2 edits in trunk/WebCore
2009-07-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Fix confusion in g_substr between length in bytes and length in
characters. Was causing crashes in some situations when dealing
with non-ASCII text encoded as UTF8.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (g_substr):
- 1:39 AM Changeset in webkit [46341] by
-
- 2 edits in trunk/WebKitTools
2009-07-24 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Added andersca to list of reviewers.
- Scripts/modules/bugzilla.py:
- 1:33 AM Changeset in webkit [46340] by
-
- 26 edits1 add in trunk/WebKitTools
Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.
Reviewed by Xan Lopez.
Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h. We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.
- DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
- DumpRenderTree/config.h:
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/mac/AppleScriptController.m:
- DumpRenderTree/mac/CheckedMalloc.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm:
- DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
- DumpRenderTree/mac/DumpRenderTreePasteboard.m:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- DumpRenderTree/mac/EditingDelegate.mm:
- DumpRenderTree/mac/EventSendingController.mm:
- DumpRenderTree/mac/FrameLoadDelegate.mm:
- DumpRenderTree/mac/GCControllerMac.mm:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/mac/NavigationController.m:
- DumpRenderTree/mac/ObjCController.m:
- DumpRenderTree/mac/ObjCPlugin.m:
- DumpRenderTree/mac/ObjCPluginFunction.m:
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- DumpRenderTree/mac/PlainTextController.mm:
- DumpRenderTree/mac/PolicyDelegate.mm:
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
- DumpRenderTree/mac/TextInputController.m:
- DumpRenderTree/mac/UIDelegate.mm:
- DumpRenderTree/mac/WorkQueueItemMac.mm:
- 1:33 AM Changeset in webkit [46339] by
-
- 3 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewButton): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- inspector/front-end/inspector.css:
- 1:31 AM Changeset in webkit [46338] by
-
- 3 edits in trunk/WebCore
2009-07-24 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907
- inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{
_inspectedNodes, _addInspectedNode, $0, $1, $n}
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history
in _inspectorCommandLineAPI._inspectedNodes
(WebInspector.ElementsPanel):
- 1:22 AM Changeset in webkit [46337] by
-
- 3 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
- 1:21 AM Changeset in webkit [46336] by
-
- 2 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Double click on a resource in the sidebar should open that resource in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url
- 1:05 AM Changeset in webkit [46335] by
-
- 2 edits in trunk/JavaScriptCore
Revert "2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>"
This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.
- 12:59 AM Changeset in webkit [46334] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602
- jit/JIT.cpp:
- 12:55 AM Changeset in webkit [46333] by
-
- 6 edits in trunk
2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
- platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/gtk/Language.cpp:
Bump pango version requirement to 1.12 which is the version that
came with Gtk 2.10.
- configure.ac:
- 12:52 AM Changeset in webkit [46332] by
-
- 2 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288
- English.lproj/localizedStrings.js:
- 12:51 AM Changeset in webkit [46331] by
-
- 2 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
- 12:44 AM Changeset in webkit [46330] by
-
- 2 edits in trunk/WebCore
2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27624
- page/DragController.cpp: (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::dragEnded): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::asFileInput): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::delegateDragSourceAction): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::getCachedImage): (WebCore::getImage): (WebCore::prepareClipboardForImageDrag): (WebCore::dragLocForDHTMLDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::placeDragCaret):
- 12:44 AM Changeset in webkit [46329] by
-
- 2 edits in trunk/WebCore
2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update WebCore/page/Chrome.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27608
- page/Chrome.cpp: (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::shouldInterruptJavaScript): (WebCore::Chrome::setToolTip): (WebCore::Chrome::requestGeolocationPermissionForFrame): (WebCore::ChromeClient::generateReplacementFile): (WebCore::ChromeClient::paintCustomScrollbar):
- 12:43 AM Changeset in webkit [46328] by
-
- 2 edits in trunk/WebCore
2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update WebCore/page/Coordinates.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614
- page/Coordinates.cpp: (WebCore::Coordinates::toString):
- 12:42 AM Changeset in webkit [46327] by
-
- 3 edits in trunk/WebCore
2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614
- page/DOMSelection.cpp: (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument):
- page/DOMSelection.h:
- 12:42 AM Changeset in webkit [46326] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
x-frame constructor calls are instantiated with the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27566
Add the test. Soon to be fixed by bug 27634.
- fast/dom/constructed-objects-prototypes-expected.txt: Added.
- fast/dom/constructed-objects-prototypes.html: Added.
- fast/dom/resources/constructed-objects-prototypes.js: Added. (classNameForObject): (constructorPropertiesOnWindow):
- 12:31 AM Changeset in webkit [46325] by
-
- 6 edits in trunk
Roll out r46321 as it broke the Windows build.
- 12:28 AM Changeset in webkit [46324] by
-
- 3 edits in trunk/WebCore
2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27618
- page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend):
- page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):
- 12:15 AM Changeset in webkit [46323] by
-
- 3 edits in trunk/WebKitTools
Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.
Reviewed by Simon Hausmann.
This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- Scripts/run-javascriptcore-tests:
- 12:14 AM Changeset in webkit [46322] by
-
- 11 edits in trunk/WebCore
2009-07-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641
Nothing uses globalObject() yet, but this was causing crashes
in the patch for bug 27634. This is covered by fast/dom/gc-6.html.
- I decided to change these to Base
- instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base
- to avoid bugs like these. Sadly C++ does not have a built-in super
- we could use.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::mark):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
- bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::mark):
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
- 12:04 AM Changeset in webkit [46321] by
-
- 6 edits in trunk
WebCore:
2009-07-23 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.
- platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h
WebKit/win:
2009-07-23 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.
- DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
- WebDownload.h: Conditionalize include of CFNetwork.h
- WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
