Timeline
Jan 25, 2010:
- 11:36 PM Changeset in webkit [53841] by
-
- 7 edits in trunk/WebKitTools
2010-01-25 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored check-webkit-style by removing the file path
parameter from the style error handler functions.
- Scripts/webkitpy/style/checker.py:
- Added _default_style_error_handler() to StyleChecker class.
- Moved handle_style_error() to inside _default_style_error_handler().
- Scripts/webkitpy/style/checker_unittest.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/cpp_style.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/text_style.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/text_style_unittest.py:
- Removed file path from calls to error handler.
- 10:23 PM Changeset in webkit [53840] by
-
- 17 edits1 copy21 adds23 deletes in trunk
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
Update the storageEvent algorithm to match the change in WebCore.
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.
Tests: storage/domstorage/events/basic-body-attribute.html
storage/domstorage/events/basic-setattribute.html
storage/domstorage/events/basic.html
storage/domstorage/events/case-sensitive.html
storage/domstorage/events/documentURI.html
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueStorageEvent): (WebCore::Document::storageEventTimerFired):
- dom/Document.h:
- storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent):
- storage/StorageEvent.idl:
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.
- storage/domstorage/complex-values-expected.txt:
- storage/domstorage/documentURI-expected.txt: Removed.
- storage/domstorage/documentURI.html: Removed.
- storage/domstorage/events: Added.
- storage/domstorage/events/basic-body-attribute-expected.txt: Added.
- storage/domstorage/events/basic-body-attribute.html: Added.
- storage/domstorage/events/basic-expected.txt: Added.
- storage/domstorage/events/basic-setattribute-expected.txt: Added.
- storage/domstorage/events/basic-setattribute.html: Added.
- storage/domstorage/events/basic.html: Added.
- storage/domstorage/events/case-sensitive-expected.txt: Added.
- storage/domstorage/events/case-sensitive.html: Added.
- storage/domstorage/events/documentURI-expected.txt: Added.
- storage/domstorage/events/documentURI.html: Added.
- storage/domstorage/events/resources: Added.
- storage/domstorage/events/resources/body-event-handler.html: Added.
- storage/domstorage/events/resources/eventTestHarness.js: Added.
- storage/domstorage/events/resources/setattribute-event-handler.html: Added.
- storage/domstorage/events/script-tests: Added.
- storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
- storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
- storage/domstorage/events/script-tests/basic-setattribute.js: Added.
- storage/domstorage/events/script-tests/basic.js: Added.
- storage/domstorage/events/script-tests/case-sensitive.js: Added.
- storage/domstorage/events/script-tests/documentURI.js: Added.
- storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
- storage/domstorage/localstorage/iframe-events.html: Removed.
- storage/domstorage/localstorage/index-get-and-set-expected.txt:
- storage/domstorage/localstorage/index-get-and-set.html:
- storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
- storage/domstorage/localstorage/simple-events-expected.txt: Removed.
- storage/domstorage/localstorage/simple-events.html: Removed.
- storage/domstorage/script-tests/complex-values.js:
- storage/domstorage/script-tests/documentURI.js: Removed.
- storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
- storage/domstorage/sessionstorage/iframe-events.html: Removed.
- storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
- storage/domstorage/sessionstorage/index-get-and-set.html:
- storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
- storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
- storage/domstorage/sessionstorage/simple-events.html: Removed.
- storage/domstorage/window-attributes-exist-expected.txt:
- storage/domstorage/window-attributes-exist.html:
- 10:00 PM Changeset in webkit [53839] by
-
- 6 edits3 adds in trunk
<rdar://problem/7573493> Error with line break inside ?» pair of characters.
https://bugs.webkit.org/show_bug.cgi?id=17475
Reviewed by Darin Adler.
WebCore:
Test: fast/text/line-break-after-question-mark.html
Instead of unconditionally allowing lines to break after a question mark, which was intended
to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
with one exception in the ASCII range to match IE, namely not allowing a line break between
a question mark and a vertical line.
- rendering/break_lines.cpp:
(WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
for the question mark case in order to keep it fast and not require a text break iterator in
the ASCII case.
(WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.
LayoutTests:
- fast/text/line-break-after-question-mark-expected.txt: Added.
- fast/text/line-break-after-question-mark.html: Added.
- fast/text/script-tests/line-break-after-question-mark.js: Added.
():
- platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
- platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
- platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
- 9:57 PM Changeset in webkit [53838] by
-
- 92 edits in trunk
WebCore: Mac scrollbar thumbs were drawn with the wrong size.
https://bugs.webkit.org/show_bug.cgi?id=34049
Reviewed by Dan Bernstein.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
https://bugs.webkit.org/show_bug.cgi?id=34049
Reviewed by Dan Bernstein.
- platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
- platform/mac/compositing/overflow/overflow-scroll-expected.png:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/mac/fast/body-propagation/overflow/002-expected.checksum:
- platform/mac/fast/body-propagation/overflow/002-expected.png:
- platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/003-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-expected.png:
- platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/004-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-expected.png:
- platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/007-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-expected.png:
- platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
- platform/mac/fast/clip/014-expected.checksum:
- platform/mac/fast/clip/014-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
- platform/mac/fast/inline-block/tricky-baseline-expected.png:
- platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
- platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
- platform/mac/fast/overflow/002-expected.checksum:
- platform/mac/fast/overflow/002-expected.png:
- platform/mac/fast/overflow/003-expected.checksum:
- platform/mac/fast/overflow/003-expected.png:
- platform/mac/fast/overflow/005-expected.checksum:
- platform/mac/fast/overflow/005-expected.png:
- platform/mac/fast/overflow/007-expected.checksum:
- platform/mac/fast/overflow/007-expected.png:
- platform/mac/fast/overflow/008-expected.checksum:
- platform/mac/fast/overflow/008-expected.png:
- platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
- platform/mac/fast/overflow/childFocusRingClip-expected.png:
- platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
- platform/mac/fast/overflow/float-in-relpositioned-expected.png:
- platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
- platform/mac/fast/overflow/image-selection-highlight-expected.png:
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
- platform/mac/fast/overflow/overflow-rtl-expected.checksum:
- platform/mac/fast/overflow/overflow-rtl-expected.png:
- platform/mac/fast/overflow/overflow-stacking-expected.checksum:
- platform/mac/fast/overflow/overflow-stacking-expected.png:
- platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
- platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
- platform/mac/fast/overflow/scrollbar-position-update-expected.png:
- platform/mac/fast/overflow/table-overflow-float-expected.checksum:
- platform/mac/fast/overflow/table-overflow-float-expected.png:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
- platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
- platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
- platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
- platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
- platform/mac/fast/table/edge-offsets-expected.checksum:
- platform/mac/fast/table/edge-offsets-expected.png:
- platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
- platform/mac/scrollbars/key-window-not-first-responder-expected.png:
- platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
- platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
- 9:38 PM WebKit Team edited by
- (diff)
- 9:15 PM Changeset in webkit [53837] by
-
- 2 edits in trunk/WebKitTools
Adding myself as reviewer. No review necessary.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25
- Scripts/webkitpy/committers.py:
- 6:17 PM Changeset in webkit [53836] by
-
- 8 edits in trunk/WebKit/mac
Featureless build fixes.
- Misc/WebCache.mm:
(+[WebCache empty]):
- WebCoreSupport/WebApplicationCache.mm:
- WebCoreSupport/WebChromeClient.h:
- WebView/WebDataSource.mm:
(-[WebDataSource _transferApplicationCache:]):
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
(-[WebView _close]):
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
(-[WebViewPrivate finalize]):
- 6:07 PM Changeset in webkit [53835] by
-
- 7 edits3 adds in trunk
WebCore: Cleanup unwanted tags after pasting.
https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Darin Adler.
Test: editing/pasteboard/paste-noscript-xhtml.xhtml
- dom/Element.cpp:
(WebCore::Element::setAttributeNS):
- dom/Element.h:
- dom/XMLTokenizer.h:
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::parseXMLDocumentFragment):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Darin Adler.
- editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
- editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
- editing/resources/htmlcontent.html: Added.
- 5:24 PM Changeset in webkit [53834] by
-
- 9 edits in trunk
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added.
- WebCoreSupport/WebGeolocationControllerClient.h:
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- WebCoreSupport/WebGeolocationControllerClient.h:
- WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed):
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
- page/GeolocationControllerClient.h:
- 5:07 PM Changeset in webkit [53833] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52527.
- 5:03 PM Changeset in webkit [53832] by
-
- 1 edit in branches/safari-4-branch/WebCore/plugins/PluginView.cpp
Merge r53581.
- 5:02 PM Changeset in webkit [53831] by
-
- 1 edit in branches/safari-4-branch/WebCore/ChangeLog
Merge r53581.
- 4:44 PM Changeset in webkit [53830] by
-
- 5 edits1 add in branches/safari-4-branch
Merge r46792.
- 4:36 PM Changeset in webkit [53829] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r50698.
- 4:33 PM Changeset in webkit [53828] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52073.
- 4:28 PM Changeset in webkit [53827] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r48810.
- 4:09 PM Changeset in webkit [53826] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r51877.
- 4:06 PM Changeset in webkit [53825] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r53520.
- 4:00 PM Changeset in webkit [53824] by
-
- 4 edits in branches/safari-4-branch/WebKit
Merge r53195.
- 3:55 PM Changeset in webkit [53823] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r51727.
- 3:53 PM Changeset in webkit [53822] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r53089.
- 3:53 PM Changeset in webkit [53821] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r51881.
- 3:52 PM Changeset in webkit [53820] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Improve portability of select-item-background-clip.html
https://bugs.webkit.org/show_bug.cgi?id=34072
- fast/forms/select-item-background-clip.html: Calculate the pixel height at runtime.
- 3:49 PM Changeset in webkit [53819] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r51616.
- 3:47 PM Changeset in webkit [53818] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r51205.
- 3:26 PM Changeset in webkit [53817] by
-
- 13 edits in branches/safari-4-branch
Merge r52749.
- 3:20 PM Changeset in webkit [53816] by
-
- 7 edits in trunk/LayoutTests
2010-01-25 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial baseline updates.
-webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650
Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/
landed.
- platform/mac/fast/gradients/border-image-gradient-expected.checksum:
- platform/mac/fast/gradients/border-image-gradient-expected.png:
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/mac/fast/gradients/simple-gradients-expected.checksum:
- platform/mac/fast/gradients/simple-gradients-expected.png:
- 3:12 PM Changeset in webkit [53815] by
-
- 2 edits in trunk/JavaScriptCore
Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.
Reviewed by David Levin.
- wtf/ThreadingPthreads.cpp:
(WTF::waitForThreadCompletion):
(WTF::detachThread):
- 3:07 PM Changeset in webkit [53814] by
-
- 2 edits in trunk/WebCore
Fixed bug in positioning of scroll layer within the
parent root layer.
https://bugs.webkit.org/show_bug.cgi?id=33847
- 1:55 PM WebKit Team edited by
- (diff)
- 1:47 PM WebKit Team edited by
- (diff)
- 12:54 PM WebKit Team edited by
- Added some (unsubstantiated) claims about what I know. (diff)
- 12:37 PM Changeset in webkit [53813] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.
Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect assertions added in the previous patch - it's mot true that m_for is always a parent; table parsing can reparent the image element, but m_form still needs to be set.
- 12:07 PM Changeset in webkit [53812] by
-
- 4 edits4 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.
Tests: fast/forms/removed-image-as-property.html
fast/forms/reparented-image-as-property.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time to make observable changes to DOM. (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, which happens during parsing. (WebCore::HTMLImageElement::removedFromTree): Ditto.
- html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument and insertedIntoDocument to private section, as they shouldn't be called directly.
- 12:03 PM Changeset in webkit [53811] by
-
- 3 edits in trunk/WebCore
2010-01-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes misspelled words in comments.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
- bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bridge/NP_jsobject.cpp: (_NPN_SetException):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
- bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
- dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- dom/MessagePortChannel.h:
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::upstream):
- dom/Position.h:
- dom/Range.cpp: (WebCore::Range::processContents):
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
- editing/Editor.cpp: (WebCore::Editor::learnSpelling):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
- loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
- loader/Cache.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
- loader/CachedResource.h:
- loader/CachedResourceHandle.h:
- loader/DocumentLoader.h:
- loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
- platform/LinkHash.cpp: (WebCore::cleanPath):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
- platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
- 11:34 AM WebKit Team edited by
- (diff)
- 11:32 AM WebKit Team edited by
- (diff)
- 11:26 AM Changeset in webkit [53810] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Add new inspector test added in r53807 to skip
list on qt platform.
- platform/qt/Skipped:
- 11:20 AM Changeset in webkit [53809] by
-
- 62 edits in trunk/WebCore
2010-01-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes misspelled words in comments.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
- bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bridge/NP_jsobject.cpp: (_NPN_SetException):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
- bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
- dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- dom/MessagePortChannel.h:
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::upstream):
- dom/Position.h:
- dom/Range.cpp: (WebCore::Range::processContents):
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
- editing/Editor.cpp: (WebCore::Editor::learnSpelling):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
- loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
- loader/Cache.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
- loader/CachedResource.h:
- loader/CachedResourceHandle.h:
- loader/DocumentLoader.h:
- loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
- platform/LinkHash.cpp: (WebCore::cleanPath):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
- platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
- 10:58 AM Changeset in webkit [53808] by
-
- 2 edits in trunk/WebCore
Suggested by Darin Adler.
Fixed a spelling error, tightened up some grammar.
- bindings/js/JSDOMBinding.cpp:
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
- 10:57 AM Changeset in webkit [53807] by
-
- 3 edits2 adds in trunk
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Test that Web Inspector doesn't change methods declared by the inspected
page.
https://bugs.webkit.org/show_bug.cgi?id=34089
- inspector/inspected-objects-not-overriden-expected.txt: Added.
- inspector/inspected-objects-not-overriden.html: Added.
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Instead of adding inspector methods to the inspected global objects
use private implementation visible from inspector code only.
https://bugs.webkit.org/show_bug.cgi?id=34089
Test: inspector/inspected-objects-not-overriden.html
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 8:37 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:06 AM Changeset in webkit [53806] by
-
- 5 edits in trunk/WebCore
2010-01-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: don't show headers/content tabs in scripts view.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.set headersVisible): (WebInspector.ResourceView.prototype._selectContentTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.css:
- 7:37 AM Changeset in webkit [53805] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
- platform/gtk/Skipped: Skipping the test, requires investigation on the failure.
- 7:24 AM Changeset in webkit [53804] by
-
- 2 edits in trunk/WebCore
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Reduce the size of the library when compiling for Maemo5
https://bugs.webkit.org/show_bug.cgi?id=34050
Exclude the Web Inspector's qrc file in the Maemo5 build, just
like we do for the Symbian build. Saves about ~900k.
- WebCore.pro:
- 7:08 AM Changeset in webkit [53803] by
-
- 5 edits in trunk/WebCore
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
https://bugs.webkit.org/show_bug.cgi?id=34054
Getting the style from the painter's paint device is a hack that breaks when
the paint device's style is different than the style that is used when
calculating the metries earlier when there is no painter available.
This change moves us closer to always using the same style.
- platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::init): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
- platform/qt/RenderThemeQt.h:
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint): (WebCore::ScrollbarThemeQt::hitTest): (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): (WebCore::ScrollbarThemeQt::scrollbarThickness): (WebCore::ScrollbarThemeQt::thumbLength): (WebCore::ScrollbarThemeQt::trackPosition): (WebCore::ScrollbarThemeQt::trackLength): (WebCore::ScrollbarThemeQt::paintScrollCorner): (WebCore::ScrollbarThemeQt::style):
- platform/qt/ScrollbarThemeQt.h:
- 6:42 AM Changeset in webkit [53802] by
-
- 6 edits in trunk
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053
- platform/qt/QWebPageClient.h: Add function to return the style.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics widget's style.
- Api/qwebpage.cpp: (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
- 6:20 AM Changeset in webkit [53801] by
-
- 3 edits in trunk/WebCore
[Qt] Clean up code to determine palette from page client in RenderThemeQt
https://bugs.webkit.org/show_bug.cgi?id=34052
Patch by Simon Hausmann <Simon Hausmann> on 2010-01-25
Reviewed by Kenneth Christiansen.
Use the RenderTheme's associated page instead of going through the
render tree and the document.
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
- platform/qt/RenderThemeQt.h:
- 5:56 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:53 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:18 AM Changeset in webkit [53800] by
-
- 2 edits in trunk
[Qt] Fix the build on Maemo5.
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=34051
- WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
- 5:14 AM Changeset in webkit [53799] by
-
- 3 edits1 add in trunk
2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077
- WebCore.pro:
2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077
- symbian/backup_registration.xml: Added.
- 5:13 AM Changeset in webkit [53798] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Update inspector test expectations. Line number and source
name are present only in Chromium when console message is
logged before document load is completed.
- platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
- platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- 4:57 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:37 AM Changeset in webkit [53797] by
-
- 6 edits in trunk/WebCore
2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antti Koivisto.
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
- page/FrameView.cpp: (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
- platform/ScrollView.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
- 4:20 AM WebKit Team edited by
- Fixed mangled special character and added missing quote. (diff)
- 4:16 AM WebKit Team edited by
- Added introduction and key. (diff)
- 3:43 AM WebKit Team edited by
- Restored page outline. (diff)
- 3:18 AM Changeset in webkit [53796] by
-
- 2 edits in trunk/WebKitTools
2010-01-25 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Improved prepare-ChangeLog so that it preserves the relative
indentation of a git commit message.
- Scripts/prepare-ChangeLog:
- Also adjusted the script so that it does not add white space characters to empty lines.
- 2:58 AM Changeset in webkit [53795] by
-
- 9 edits1 add in trunk/WebCore
2010-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.addMessage): (WebInspector.SourceFrame2.prototype.clearMessages): (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype.resize):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._mouseOut): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._replaceSelectionWith):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/textEditor.css: Added.
- 2:37 AM Changeset in webkit [53794] by
-
- 9 edits in trunk/WebCore
2010-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Replace split pane with tabbed pane in resource
contents view.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.attach): (WebInspector.ResourceView.prototype.show): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype._selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show):
- 1:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:45 AM WebKit Team edited by
- (diff)
- 12:02 AM WebKit Team edited by
- (diff)
Jan 24, 2010:
- 11:04 PM Changeset in webkit [53793] by
-
- 17 edits in trunk/LayoutTests
build fix: rubber-stamped by Eric Seidel.
Fix expected baselines for ruby layout tests on Windows.
- platform/win/fast/ruby/ruby-empty-rt-expected.txt:
- platform/win/fast/ruby/ruby-length-expected.txt:
- platform/win/fast/ruby/ruby-run-break-expected.txt:
- platform/win/fast/ruby/ruby-runs-expected.txt:
- platform/win/fast/ruby/ruby-runs-spans-expected.txt:
- platform/win/fast/ruby/ruby-simple-expected.txt:
- platform/win/fast/ruby/ruby-simple-rp-expected.txt:
- platform/win/fast/ruby/ruby-trailing-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
- 10:21 PM Changeset in webkit [53792] by
-
- 3 edits2 adds in trunk
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041
Test: media/video-reverse-play-duration.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when playing in reverse, so don't reset duration in that case.
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041
- media/video-reverse-play-duration-expected.txt: Added.
- media/video-reverse-play-duration.html: Added.
- 10:05 PM WebKit Team edited by
- (diff)
- 10:00 PM WebKit Team edited by
- (diff)
- 9:55 PM WebKit Team edited by
- (diff)
- 9:50 PM Changeset in webkit [53791] by
-
- 2 edits in trunk/LayoutTests
Bug 28420 - Re-enable ruby Windows layout tests
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)
Reviewed by Maciej Stachowiak.
After creating new Latin-character-only layout tests for ruby
(https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
that caused layout tests to fail then due to the addition of the ruby
layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
not actually caused by ruby), the ruby layout tests should als be
un-skipped for the Windows platform.
- platform/win/Skipped:
- 9:50 PM WebKit Team edited by
- (diff)
- 9:43 PM WebKit Team edited by
- (diff)
- 9:31 PM WebKit Team edited by
- (diff)
- 9:25 PM WebKit Team edited by
- (diff)
- 9:17 PM WebKit Team edited by
- (diff)
- 8:11 PM Changeset in webkit [53790] by
-
- 3 edits2 adds in trunk
2010-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>
Test cast: fast/parser/residual-style-hang.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Limit the number of iterations of the main loop to 5.
The reason this limit is necessary is that otherwise, N misnested open tags followed
by N misnested close tags will cause O(N2) of work due to cloning and attaching subtrees;
at a fixed limit, the cost is at worst O(N).
The code that was in the loop originally ran exactly once - the loop was added in
r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
with the iteration limit, the bug is still fixed, both with the original test case
and with the layout tests tht were added.
2010-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>
Test case for the above bug fix.
- fast/parser/residual-style-hang-expected.txt: Added.
- fast/parser/residual-style-hang.html: Added.
- 7:53 PM Changeset in webkit [53789] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
https://bugs.webkit.org/show_bug.cgi?id=33866
Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
macro for those functions that are always present.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- 7:26 PM Changeset in webkit [53788] by
-
- 2 edits2 adds3 deletes in trunk/LayoutTests
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Improve portability of listbox-selection-2.html
https://bugs.webkit.org/show_bug.cgi?id=33994
- Convert to dumpAsText().
- Determine the height of an item at runtime
- fast/forms/listbox-selection-2-expected.txt: Added.
- fast/forms/listbox-selection-2.html:
- fast/forms/script-tests/listbox-selection-2.js
- platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed.
- platform/mac/fast/forms/listbox-selection-2-expected.png: Removed.
- platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed.
- 6:15 PM Changeset in webkit [53787] by
-
- 7 edits in trunk
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986
Add setter tests to input-valueasdate-datetime.js, and update the
expectation.
- fast/forms/input-valueasdate-week-expected.txt:
- fast/forms/script-tests/input-valueasdate-week.js:
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986
Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
Week type support to ISODateTime::toString().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Avoid default:. (WebCore::HTMLInputElement::setValueAsDate): Add WEEK type handling and avoid default:.
- html/ISODateTime.cpp: (WebCore::offsetTo1stWeekStart): (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek): (WebCore::ISODateTime::millisecondsSinceEpoch): (WebCore::ISODateTime::toString): Add Week type support and avoid default:.
- html/ISODateTime.h:
- 4:41 PM WebKit Team edited by
- (diff)
- 4:15 PM WebKit Team edited by
- (diff)
- 2:54 PM Changeset in webkit [53786] by
-
- 2 edits in trunk/LayoutTests
2010-01-24 Eric Carlson <eric.carlson@apple.com>
No review, build fix.
Only log the first 'timeupdate' event from audio-delete-while-slider-thumb-clicked.html
as the number fired can vary according to how long it takes to run the test.
- media/audio-delete-while-slider-thumb-clicked.html:
- 2:54 PM Changeset in webkit [53785] by
-
- 6 edits in trunk/WebCore
2010-01-24 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Object Serialization assumes deserialization will always occur in the context of a webpage
https://bugs.webkit.org/show_bug.cgi?id=34056
rdar://7573833
Added ClassInfo to JSDOMGlobalObject and make the window and worker class info
inherit from it. With this in place we're able to determine whether a given
global object is a DOMGlobalObject, and then use that information to avoid
attempting to deserialize types that require the presence of the DOM.
No test as all global objects in webkit inherit from JSDOMGlobalObject.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::):
- bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::classInfo):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::):
- bindings/js/JSWorkerContextBase.cpp: (WebCore::):
- bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::convertIfTerminal):
- 2:30 PM Changeset in webkit [53784] by
-
- 2 edits in trunk/LayoutTests
2010-01-24 Eric Seidel <eric@webkit.org>
No review.
Middle clicking the primary scroll bars on Chromium Linux triggers a paste event
https://bugs.webkit.org/show_bug.cgi?id=33062
- platform/gtk/Skipped:
- This new test fails on Gtk for unknown reasons.
- Skipping for now to make the bots green, until a Gtk person can look.
- 2:15 PM Changeset in webkit [53783] by
-
- 3 edits in trunk/WebKitTools
2010-01-24 Eric Seidel <eric@webkit.org>
No review, rolling out r53763.
http://trac.webkit.org/changeset/53763
https://bugs.webkit.org/show_bug.cgi?id=33895
Broke 20+ tests on Windows.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:05 PM WebKit Team edited by
- (diff)
- 1:05 PM Changeset in webkit [53782] by
-
- 3 edits in trunk/WebKitSite
Added to contributing code page a pointer to the preferred
license text. Also added information about copyright lines.
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=34017
- coding/contributing.html:
- css/main.css:
- Added CSS class for books.
- 11:42 AM Changeset in webkit [53781] by
-
- 4 edits in trunk/LayoutTests
2010-01-24 Simon Fraser <Simon Fraser>
No review.
Fix incorrect layout test that I checked in earlier.
- platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
- 10:22 AM Changeset in webkit [53780] by
-
- 3 edits2 adds in trunk
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec
Test: media/video-timeupdate-reverse-play.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback rate is positive. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event if one hasn't already been posted for the current movie time. (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic.
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec
- media/video-timeupdate-reverse-play-expected.txt: Added.
- media/video-timeupdate-reverse-play.html: Added.
- 9:47 AM Changeset in webkit [53779] by
-
- 4 edits4 adds in trunk
2010-01-23 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Video that loads inside reflection doesn't get reflected
https://bugs.webkit.org/show_bug.cgi?id=34046
ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer
exists already, then the structural layer and content layer can just be returned.
However, this doesn't account for the situation where a content layer may have
been create after the clone tree was last updated.
Fix by always creating the structural and clone layers on demand.
Test: compositing/reflections/load-video-in-reflection.html
- platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone().
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds or creates a layer in a LayerMap. (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the structural and content layers, rather than relying on whether there's a primary layer clone already.
- 4:25 AM Changeset in webkit [53778] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/mock_bugzillatool.py:
- 4:16 AM Changeset in webkit [53777] by
-
- 3 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/executive.py:
- Scripts/webkitpy/grammar.py:
- 3:57 AM Changeset in webkit [53776] by
-
- 4 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/comments.py:
- Scripts/webkitpy/committers.py:
- Scripts/webkitpy/credentials.py:
- 3:48 AM Changeset in webkit [53775] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
Make changelogs.py pass pep8.
- Scripts/webkitpy/changelogs.py:
Jan 23, 2010:
- 11:44 PM Changeset in webkit [53774] by
-
- 6 edits in trunk
2010-01-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048
Add test for passing a FileList through postMessage, and
correct testing already present to test what it was meant
to be.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
2010-01-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048
Support passing FileList through postMessage APIs. Basically
mechanical task in line with other terminals in the object
graph.
- bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedFileList::create): (WebCore::SerializedFileList::length): (WebCore::SerializedFileList::item): (WebCore::SerializedFileList::SerializedFileList): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asFileList): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):
Rearrange these functions to not use 'default:' handling
so that the compiler will actually tell us when we're
not handling cases.
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asFileList):
- 5:50 PM Changeset in webkit [53773] by
-
- 3 edits1 delete in trunk
<rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=34006
Reviewed by Maciej Stachowiak.
WebKit/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
with a default value of true.
LayoutTests:
- platform/win/svg/custom/text-zoom-expected.txt: Removed.
- 1:53 PM Changeset in webkit [53772] by
-
- 3 edits in trunk/WebKitTools
[Qt] Unreviewed build fix
- QtLauncher/QtLauncher.pro:
- QtLauncher/webinspector.h:
- 1:40 PM Changeset in webkit [53771] by
-
- 2 edits1 add in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] Move the WebInspector class to it's own header file.
- QtLauncher/main.cpp:
- QtLauncher/webinspector.h: Added.
(WebInspector::WebInspector):
(WebInspector::showEvent):
(WebInspector::hideEvent):
- 8:54 AM Changeset in webkit [53770] by
-
- 6 edits in trunk
2010-01-23 Robert Hogan <robert@roberthogan.net>
Reviewed by Kenneth Rohde Christiansen.
Qt DRT: respect window.close() and window.closed()
Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().
This fixes the following tests:
plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html
- platform/qt/Skipped:
2010-01-23 Robert Hogan <robert@roberthogan.net>
Reviewed by Kenneth Rohde Christiansen.
Qt DRT: respect window.close() and window.closed()
Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().
This fixes the following tests:
plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
- 8:37 AM Changeset in webkit [53769] by
-
- 3 edits in trunk/WebKit/qt
2010-01-23 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix positioning of ComboBox popup in QGraphicsWebView.
Wrap the popup in a QGraphicsProxyWidget, so that the popup
transforms with the item.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show):
- WebCoreSupport/QtFallbackWebPopup.h:
- 8:08 AM Changeset in webkit [53768] by
-
- 3 edits in trunk/WebCore
2010-01-22 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Race condition in video setup can force videos into software mode
https://bugs.webkit.org/show_bug.cgi?id=34034
We used to call setUpVideoRendering() unconditionally from
acceleratedRenderingStateChanged(); this could happen before the movie had any
data, and thus force the movie into software rendering mode.
Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
which also allows us to remove some other checks for being ready to render.
Timing dependent, hard to make a test for.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return if passing in the same layer that is already being used.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything if not ready to render. (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering() any more, since setUpVideoRendering() does that. (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this is equivalent to the check inside of setUpVideoRendering().
- 3:43 AM Changeset in webkit [53767] by
-
- 2 edits in trunk/LayoutTests
2010-01-23 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Add new inspector test added in r53766 to skipi
list on qt platform.
- platform/qt/Skipped:
- 2:13 AM Changeset in webkit [53766] by
-
- 44 edits2 adds in trunk
2010-01-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
Test: inspector/console-log-before-inspector-open.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
- bindings/js/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
- bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/v8/ScriptValue.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- inspector/front-end/EventListenersSidebarPane.js: ():
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
- inspector/front-end/ObjectPropertiesSection.js:
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
2010-01-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
Test that web inspector doesn't crash when opening if there are messages in
the console. Refactor test case due to InjectedScriptAccess changes.
- inspector/console-log-before-inspector-open-expected.txt: Added.
- inspector/console-log-before-inspector-open.html: Added.
- inspector/styles-iframe.html:
- 1:51 AM Changeset in webkit [53765] by
-
- 2 edits in trunk/WebKitTools
Added a user default for specifying a fallback frameworks path in case
the bundle does not contain frameworks for the current Mac OS X version.
Reviewed by Mark Rowe.
- WebKitLauncher/main.m:
(fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
keyed by the FallbackSystemVersions user default and returns it.
(main): If a frameworks directory for the current system version is not found,
try the fallback.
Jan 22, 2010:
- 11:11 PM Changeset in webkit [53764] by
-
- 16 edits4 copies1 add in trunk
2010-01-22 Alex Milowski <alex@milowski.com>
Reviewed by David Hyatt.
Updated tests due to stylesheet changes.
- platform/mac/mathml/presentation/sub-expected.checksum:
- platform/mac/mathml/presentation/sub-expected.png:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/sup-expected.checksum:
- platform/mac/mathml/presentation/sup-expected.png:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
2010-01-22 Alex Milowski <alex@milowski.com>
Reviewed by David Hyatt.
Added support for RenderMathMLBlock base object and isRenderMathMLBlock()
method on RenderObject.
Added support for text elements and updated tag and attribute names
Also, updated the stylesheet added files to the project
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- css/mathml.css:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/MathMLTextElement.cpp: Added. (WebCore::MathMLTextElement::MathMLTextElement): (WebCore::MathMLTextElement::create): (WebCore::MathMLTextElement::createRenderer):
- mathml/MathMLTextElement.h: Added.
- mathml/RenderMathMLBlock.cpp: Added. (WebCore::RenderMathMLBlock::RenderMathMLBlock): (WebCore::RenderMathMLBlock::styleDidChange): (WebCore::RenderMathMLBlock::isChildAllowed): (WebCore::RenderMathMLBlock::makeBlockStyle): (WebCore::RenderMathMLBlock::nonOperatorHeight): (WebCore::RenderMathMLBlock::stretchToHeight):
- mathml/RenderMathMLBlock.h: Added. (WebCore::RenderMathMLBlock::isRenderMathMLBlock): (WebCore::RenderMathMLBlock::isRenderMathMLOperator): (WebCore::RenderMathMLBlock::isRenderMathMLRow): (WebCore::RenderMathMLBlock::isRenderMathMLMath): (WebCore::RenderMathMLBlock::hasBase): (WebCore::toRenderMathMLBlock):
- mathml/mathattrs.in: Added.
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderMathMLBlock):
- 10:51 PM Changeset in webkit [53763] by
-
- 3 edits in trunk/WebKitTools
2010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Make run-webkit-tests work under Cygwin for the Qt port
setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.
This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.
openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.
Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 10:35 PM Changeset in webkit [53762] by
-
- 6 edits in trunk/LayoutTests
2010-01-22 Garret Kelly <gdk@chromium.org>
Reviewed by David Levin.
Fixing svg/custom/stroke-width-click.svg to not cause the double-click
handler to fire on certain platforms (chromium, for one). Chromium,
Leopard, and GTK all agree on the calculated extents of the shape, so I'm
disabling this test on mac-tiger and re-enabling it on mac-leopard and
updating the expected file to reflect the current state of the test.
https://bugs.webkit.org/show_bug.cgi?id=33865
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- svg/custom/stroke-width-click-expected.txt:
- svg/custom/stroke-width-click.svg:
- 10:19 PM Changeset in webkit [53761] by
-
- 11 edits4 adds in trunk
2010-01-22 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
Adds tests for the 'selected' attribute of <option>s
https://bugs.webkit.org/show_bug.cgi?id=32641
HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.
Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.
- fast/forms/HTMLOptionElement_selected-expected.txt:
- fast/forms/HTMLOptionElement_selected.html:
- fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
- fast/forms/HTMLOptionElement_selected2.html: Added.
- fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
- fast/forms/HTMLOptionElement_selected3.html: Added.
- fast/forms/add-remove-option-modification-event-expected.txt:
2010-01-22 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
Ensures that the 'selected' attribute of an <option> is correct
https://bugs.webkit.org/show_bug.cgi?id=32641
Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.
Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.
Tests: fast/forms/HTMLOptionElement_selected2.html
fast/forms/HTMLOptionElement_selected3.html
- dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
- dom/SelectElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
- html/HTMLSelectElement.h:
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
- 9:43 PM Changeset in webkit [53760] by
-
- 2 edits in trunk/WebCore
2010-01-22 Chris Rogers <crogers@google.com>
Reviewed by Eric Seidel.
Need to handle WebGLUnsignedByteArray as method argument for V8 binding
https://bugs.webkit.org/show_bug.cgi?id=33929
V8 code generator does not have associated tests
- bindings/scripts/CodeGeneratorV8.pm:
- 9:27 PM Changeset in webkit [53759] by
-
- 7 edits in trunk
2010-01-22 Elliot Glaysher <erg@chromium.org>
Reviewed by David Levin.
Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.
Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::setSelectionColors):
- rendering/RenderThemeChromiumLinux.h: Adds static members.
2010-01-22 Elliot Glaysher <erg@chromium.org>
Reviewed by David Levin.
Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.
Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)
- public/WebView.h: Adds interface to change the selection colors
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setSelectionColors): Implements new interface.
- src/WebViewImpl.h:
- 9:11 PM Changeset in webkit [53758] by
-
- 3 edits2 adds in trunk
2010-01-22 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
A new test to check that middle clicking on the primary scroll bars
does not trigger a paste event.
https://bugs.webkit.org/show_bug.cgi?id=33062
- scrollbars/scrollbar-middleclick-nopaste-expected.txt: Added.
- scrollbars/scrollbar-middleclick-nopaste.html: Added.
2010-01-22 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Middle clicking the main scroll bars should not trigger a paste event
in Linux chromium.
https://bugs.webkit.org/show_bug.cgi?id=33062
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseUp):
- 9:09 PM UsingGitWithWebKit edited by
- Added note about "commit-log-editor" and dcommit. (diff)
- 8:59 PM UsingGitWithWebKit edited by
- Added note about squashing commits, if necessary, before dcommit. (diff)
- 8:42 PM Changeset in webkit [53757] by
-
- 17 edits in trunk
Reviewed by Kevin Ollivier.
[wx] Remove the Bakefile build system, which is no longer being used.
https://bugs.webkit.org/show_bug.cgi?id=34022
- 8:33 PM Changeset in webkit [53756] by
-
- 2 edits in trunk/WebKit/wx
Build fix after r53718.
- 8:18 PM Changeset in webkit [53755] by
-
- 2 edits in trunk/LayoutTests
Update platform-specific test results following r53722
- 8:06 PM Changeset in webkit [53754] by
-
- 3 edits2 adds in trunk
LayoutTests
2010-01-22 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Simon Fraser.
Checking in platform-specific results for test that is failing
because of an additional single pixel in size - the test passes,
when testing manually.
- platform/gtk/svg/custom/text-zoom-expected.txt: Added.
WebKitTools
2010-01-22 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Simon Fraser.
Reset zoom level to 1.0 when resetting view state. This is causing
many tests to fail after svg/custom/text-zoom.xhtml changes the
zoom level.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 8:00 PM Changeset in webkit [53753] by
-
- 3 edits in trunk/LayoutTests
Roll out r53752 to fix bots.
- 7:46 PM Changeset in webkit [53752] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Cameron Zwarich.
Re-enable Geolocation tests on Mac.
- platform/mac/Skipped:
- platform/win/Skipped:
- 7:06 PM Changeset in webkit [53751] by
-
- 1 edit in trunk/WebCore/platform/GeolocationService.cpp
Mac build fix.
- 6:53 PM Changeset in webkit [53750] by
-
- 1 edit in trunk/WebCore/platform/mac/GeolocationServiceMac.mm
Build fix. Don't include CoreLocation-based Geolocation if CLIENT_BASED_GEOLOCATION is set.
- 6:34 PM Changeset in webkit [53749] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Build fix. Touch exp file to force it to rebuild via DerivedSources.make.
- 6:18 PM WikiStart edited by
- Alphabetized Documentation pages to find them more easily (diff)
- 6:16 PM Changeset in webkit [53748] by
-
- 1 edit1 delete in trunk/WebCore
Remove unnecessary copy of zlib.
https://bugs.webkit.org/show_bug.cgi?id=34028
Reviewed by Darin Adler.
- platform/image-decoders/zlib: Removed.
- platform/image-decoders/zlib/adler32.c: Removed.
- platform/image-decoders/zlib/compress.c: Removed.
- platform/image-decoders/zlib/crc32.c: Removed.
- platform/image-decoders/zlib/crc32.h: Removed.
- platform/image-decoders/zlib/deflate.c: Removed.
- platform/image-decoders/zlib/deflate.h: Removed.
- platform/image-decoders/zlib/gzio.c: Removed.
- platform/image-decoders/zlib/infback.c: Removed.
- platform/image-decoders/zlib/inffast.c: Removed.
- platform/image-decoders/zlib/inffast.h: Removed.
- platform/image-decoders/zlib/inffixed.h: Removed.
- platform/image-decoders/zlib/inflate.c: Removed.
- platform/image-decoders/zlib/inflate.h: Removed.
- platform/image-decoders/zlib/inftrees.c: Removed.
- platform/image-decoders/zlib/inftrees.h: Removed.
- platform/image-decoders/zlib/mozzconf.h: Removed.
- platform/image-decoders/zlib/trees.c: Removed.
- platform/image-decoders/zlib/trees.h: Removed.
- platform/image-decoders/zlib/uncompr.c: Removed.
- platform/image-decoders/zlib/zconf.h: Removed.
- platform/image-decoders/zlib/zlib.h: Removed.
- platform/image-decoders/zlib/zutil.c: Removed.
- platform/image-decoders/zlib/zutil.h: Removed.
- 6:07 PM Changeset in webkit [53747] by
-
- 4 edits in trunk/WebKit/chromium
Not reviewed. backout.
Backout r53705. Causes ui_tests to timeout, and browser_tests to fail with
TestConnectToBadPort and WindowOpenInvalidExtension.
- 5:58 PM Changeset in webkit [53746] by
-
- 12 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=34025
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
Reviewed by Darin Adler.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 5:52 PM Changeset in webkit [53745] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-01-22 Simon Fraser <Simon Fraser>
No review.
Commit missing test result.
- fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
- 5:51 PM Changeset in webkit [53744] by
-
- 1 edit1 add in trunk/LayoutTests
Fix tests, unreviewed. Adding expectations file missing from r53739
- fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
- 5:33 PM Changeset in webkit [53743] by
-
- 2 edits in trunk/LayoutTests
Build fix. Add missing comma.
- fast/dom/Window/window-properties.html:
- 5:17 PM Changeset in webkit [53742] by
-
- 3 edits4 adds in trunk
2010-01-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus
https://bugs.webkit.org/show_bug.cgi?id=33821
Fix an issue with the geometry of fixed position, composited layers inside other
composited layers. If we called convertToLayerCoords() on a fixed layer with an ancestor
layer which is not the root, then we assumed that the fixed layer had a positioning root.
However, this is not always the case, since the fixed layer may have a compositing ancestor
which is not a fixed container.
Test: compositing/geometry/fixed-in-composited.html
- rendering/RenderLayer.cpp: (WebCore::isFixedPositionedContainer): Utility function to test whether a layer acts as a fixed position container.
(WebCore::RenderLayer::convertToLayerCoords): When called on a fixed position layer
for an ancestor layer that is not the root, compute the correct offsets by looking for
the fixed position container, and computing offsets relative to that. If the ancestorLayer
is the fixed position container, fall through to the existing code that is shared
with absolutely positioned layers.
- 5:14 PM Changeset in webkit [53741] by
-
- 3 edits in trunk/LayoutTests
Skip fast/dom/Window/window-properties-geolocation.html
until https://bugs.webkit.org/show_bug.cgi?id=34025 is landed.
- platform/mac/Skipped:
- platform/win/Skipped:
- 5:07 PM Changeset in webkit [53740] by
-
- 7 edits1 copy1 add1 delete in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=34024
Layout tests don't easily allow Geolocation to be on in only a subset of platforms
Reviewed by Darin Adler.
- fast/dom/Window/window-properties-geolocation-expected.txt: Added.
- fast/dom/Window/window-properties-geolocation.html: Copied from fast/dom/Window/window-properties.html.
Moved Geolocation property testing here.
- fast/dom/Window/window-properties.html: Exclude Geolocation from testing. Moved to window-properties-geolocation.html.
- fast/dom/navigator-detached-no-crash.html: Exclude Geolocation from output.
- fast/dom/script-tests/prototype-inheritance-2.js: Exclude Geolocation.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed Geolocation properties from expected results.
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Gtk results now match baseline.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed Geolocation properties from expected results.
- platform/qt/Skipped: Skip Geolocation tests. Not yet available in Qt.
- 4:46 PM Changeset in webkit [53739] by
-
- 3 edits1 add in trunk
2010-01-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
webkitConvertPointFromNodeToPage doesn't take into account most recent transform style
https://bugs.webkit.org/show_bug.cgi?id=34023
Be sure to call updateLayoutIgnorePendingStylesheets() before doing point mapping,
to apply any style changes since the last layout.
Test: fast/dom/Window/webkitConvertPointUpdateLayout.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): Call updateLayoutIgnorePendingStylesheets(). (WebCore::DOMWindow::webkitConvertPointFromPageToNode): Ditto.
- 4:46 PM Changeset in webkit [53738] by
-
- 2 edits in trunk/LayoutTests
Not reviewed, fixes one issue with window-property-descriptors test.
- fast/dom/Window/script-tests/window-property-descriptors.js: Don't dump the property that only appears in debug build, it will fail tests in debug.
- 4:43 PM Changeset in webkit [53737] by
-
- 4 edits in trunk/WebCore
2010-01-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Use stale cache data when going back and forward but not using WebCore’s page cache
https://bugs.webkit.org/show_bug.cgi?id=33993
<rdar://problem/7383392>
No tests since this is a performance change.
- loader/CachePolicy.h: (WebCore::): Add CachePolicyAllowStale.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Never reload in the case of CachePolicyAllowStale.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Return CachePolicyAllowStale if the main resource is being loaded to allow stale data. (WebCore::FrameLoader::addExtraFieldsToRequest): Use ReturnCacheDataElseLoad on back/forward loads - needed when going back of forward to a page with frames.
- 4:31 PM Changeset in webkit [53736] by
-
- 2 edits in trunk/WebCore
2010-01-22 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated)
https://bugs.webkit.org/show_bug.cgi?id=33915
Errors were caused by the fact that Element::attributes calls Element::setAttribute to
synchronized the styleAttr. The fix is to simply check the synchronizing style attribute
flag.
- dom/Element.cpp: (WebCore::Element::setAttribute): Checked for case where styleAttr is being synchronized.
- 4:27 PM Changeset in webkit [53735] by
-
- 2 edits in trunk/WebKitTools
2010-01-22 Adam Barth <abarth@webkit.org>
Unreviewed. Arg. Someone renamed limit to output_limit on me.
- Scripts/webkitpy/commands/queues.py:
- 4:21 PM Changeset in webkit [53734] by
-
- 3 edits in trunk/WebKitTools
2010-01-22 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Make init.py and buildbot.py pass pep8 style checker.
- Scripts/webkitpy/init.py:
- Scripts/webkitpy/buildbot.py:
- 4:12 PM Changeset in webkit [53733] by
-
- 2 edits in trunk/WebKitTools
2010-01-21 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
webkit-patch should retry on invalid password
https://bugs.webkit.org/show_bug.cgi?id=33955
Ask for bugs.webkit.org authentication in a loop.
- Scripts/webkitpy/bugzilla.py:
- 4:10 PM Changeset in webkit [53732] by
-
- 5 edits in trunk/LayoutTests
No review. Updated Qt layout tests due to r53722.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 4:06 PM Changeset in webkit [53731] by
-
- 2 edits in trunk/WebKitTools
2010-01-22 Adam Barth <abarth@webkit.org>
Unreviewed. Don't call seek on a NoneType.
- Scripts/webkitpy/statusserver.py:
- 3:58 PM Changeset in webkit [53730] by
-
- 2 edits in trunk/WebKitTools
2010-01-22 Petri Latvala <petri.latvala@nomovok.com>
Reviewed by David Levin.
check-webkit-style breaks on files with unknown types
https://bugs.webkit.org/show_bug.cgi?id=34001
For files with type FileType.NONE, dispatch_processor returns None.
- Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
- 3:58 PM Changeset in webkit [53729] by
-
- 3 edits in trunk/WebKitTools
2010-01-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make bugzilla.py and webkitport.py conform to pep8
https://bugs.webkit.org/show_bug.cgi?id=34015
This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
style as enforced by pep8.py. I wasn't able to get rid of all the
errors because I'm not sure how to wrap some lines properly. Also,
there are a few deprication errors that I couldn't resolve easily.
However, this is a massive improvement in compliance.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/webkitport.py:
- 3:57 PM Changeset in webkit [53728] by
-
- 3 edits in trunk/WebKitTools
2010-01-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Limit length of EWS results to 5MB
https://bugs.webkit.org/show_bug.cgi?id=34016
Hopefully this will fix the bug where the results link doesn't appear.
Our current theory is that the results blob is too big and the server
is rejecting the request with a 500 error. That causes us to re-try
the post, but when we re-try the StringIO buffer has its seek pointer
at the end.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/statusserver.py:
- 3:54 PM Changeset in webkit [53727] by
-
- 2 edits in trunk/LayoutTests
No review. Build fix.
Updated the newly added test to count the change from r53722.
- fast/dom/Window/window-property-descriptors-expected.txt:
- 3:50 PM Changeset in webkit [53726] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Platform dependent expected files added for tests introduced in r53656,
because these tests pass. Compared to png files.
Reviewed by Nikolas Zimmermann.
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
- 3:49 PM Changeset in webkit [53725] by
-
- 2 edits in trunk/WebCore
2010-01-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update r53711 for GraphicsLayer method rename.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie): Rename from change setContentsToVideo.
- 3:41 PM Changeset in webkit [53724] by
-
- 2 edits in trunk/LayoutTests
Not reviewed, test fix.
Update a layout test for change in page scroll size.
https://bugs.webkit.org/show_bug.cgi?id=32595
- fast/events/scrollbar-double-click-expected.txt:
- 3:36 PM Changeset in webkit [53723] by
-
- 5 edits in trunk/LayoutTests
2010-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix comment in the a SVG <use> testcase, it should say "green rectangles" instead of "blue rectangles", as noticed by Csaba Osztrogonac.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
- 3:03 PM Changeset in webkit [53722] by
-
- 7 edits in trunk
WebCore: Add BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982
Reviewed by Darin Adler.
- page/DOMWindow.idl:
LayoutTests: Updated the affected tests due to adding BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982
Reviewed by Darin Adler.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 3:03 PM Changeset in webkit [53721] by
-
- 2 edits in trunk/WebKit/mac
[WebFrame loadRequest:] does not null check the WebCore::Frame
<rdar://problem/7416286> and https://bugs.webkit.org/show_bug.cgi?id=34021
Reviewed by Adele Peterson.
- WebView/WebFrame.mm:
(-[WebFrame loadRequest:]): Null check the WebCore::Frame as it can disappear
out of underneath a WebFrame.
- 2:59 PM Changeset in webkit [53720] by
-
- 3 edits in trunk/LayoutTests
Add test for new attributes introduced in File and Blob interfaces.
https://bugs.webkit.org/show_bug.cgi?id=33980
Reviewed by Darin Adler.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/script-tests/file-input-files-access.js:
- 2:18 PM Changeset in webkit [53719] by
-
- 2 edits1 add in trunk/WebCore
Rubber-stamped by Adam Roben.
Commit files that were supposed to be part of r53696, but weren't
landed.
- English.lproj/localizedStrings.js:
- manual-tests/debugger-caught-uncaught-exceptions.html: Added.
- 2:17 PM Changeset in webkit [53718] by
-
- 8 edits in trunk
When scrolling by page, hold back 1/8th of the visible size instead of
40 px.
https://bugs.webkit.org/show_bug.cgi?id=32595
Reviewed by David Hyatt.
WebCore:
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/Scrollbar.h:
- platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
WebKit/mac:
- WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView initWithFrame:]):
(-[WebFrameView _horizontalPageScrollDistance]):
- 2:13 PM Changeset in webkit [53717] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, attempted Snow Leopard build fix.
- wtf/ThreadingPthreads.cpp: Add a forward declaration of a function which is not 'static'.
- 2:05 PM Changeset in webkit [53716] by
-
- 18 edits in trunk
Not reviewed, backout.
Back out r52673, which caused several regressions.
https://bugs.webkit.org/show_bug.cgi?id=32533
WebCore:
- platform/PopupMenuClient.h:
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::hidePopup):
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::menuUnmapped):
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
- platform/qt/QtAbstractWebPopup.cpp:
(WebCore::QtAbstractWebPopup::popupDidHide):
- platform/qt/QtAbstractWebPopup.h:
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::hide):
- platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::OnMenuItemSelected):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::popupDidHide):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::popupDidHide):
- rendering/RenderTextControlSingleLine.h:
WebKit/chromium:
- src/AutocompletePopupMenuClient.cpp:
(WebKit::AutocompletePopupMenuClient::initialize):
(WebKit::AutocompletePopupMenuClient::popupDidHide):
(WebKit::AutocompletePopupMenuClient::setTextFromItem):
- src/AutocompletePopupMenuClient.h:
WebKit/qt:
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopupCombo::hidePopup):
- 2:04 PM Changeset in webkit [53715] by
-
- 4 edits1 add in trunk/WebKitTools
33791: Proposed patch 1 (amended with preferred license)
- 2:00 PM Changeset in webkit [53714] by
-
- 16 edits2 adds in trunk
Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689
Reviewed by Maciej Stachowiak.
Test is added to DumpRenderTree.mm.
- Android.mk: Added file ThreadIdentifierDataPthreads.(h|cpp) to build.
- Android.v8.wtf.mk: Ditto.
- GNUmakefile.am: Ditto.
- JavaScriptCore.gyp/JavaScriptCore.gyp: Ditto.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- wtf/ThreadIdentifierDataPthreads.cpp: Added. Contains custom implementation of thread-specific data that uses custom destructor.
(WTF::ThreadIdentifierData::~ThreadIdentifierData): Removes the ThreadIdentifier from the threadMap.
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::destruct): Custom thread-specific destructor. Resets the value for the key again to cause second invoke.
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce): Need to use pthread_once since initialization may come on any thread(s).
- wtf/ThreadIdentifierDataPthreads.h: Added.
(WTF::ThreadIdentifierData::ThreadIdentifierData):
- wtf/Threading.cpp:
(WTF::threadEntryPoint): Move initializeCurrentThreadInternal to after the lock to make
sure it is invoked when ThreadIdentifier is already established.
- wtf/Threading.h: Rename setThreadNameInternal -> initializeCurrentThreadInternal since it does more then only set the name now.
- wtf/ThreadingNone.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
- wtf/ThreadingWin.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
(WTF::initializeThreading): Ditto.
- wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
- wtf/qt/ThreadingQt.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
- wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
(WTF::clearPthreadHandleForIdentifier): Make it not 'static' so the ~ThreadIdentifierData() in another file can call it.
(WTF::initializeCurrentThreadInternal): Set the thread-specific data. The ThreadIdentifier is already established by creating thread.
(WTF::waitForThreadCompletion): Remove call to clearPthreadHandleForIdentifier(threadID) since it is now done in ~ThreadIdentifierData().
(WTF::detachThread): Ditto.
(WTF::currentThread): Use the thread-specific data to get the ThreadIdentifier. It's many times faster then Mutex-protected iteration through the map.
Also, set the thread-specific data if called first time on the thread.
WebKitTools:
Add a new test to verify the ThreadIdentifiers are not reused across threads.
The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
waiting for the previous thread to terminate before starting the next.
The treads use WTF::currentThread() in their thread function. Without a fix, this
causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
The test practically does not affect the DRT run time because the threads end immediately.
- DumpRenderTree/mac/DumpRenderTree.mm:
(runThread): Test thread function.
(testThreadIdentifierMap):
(dumpRenderTree):
- 1:52 PM Changeset in webkit [53713] by
-
- 6 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Revert r53693 because it broke scrolling of pages with fixed elements on
Mac OS X.
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):
- 12:59 PM Changeset in webkit [53712] by
-
- 9 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34008
Assertion failure in KURL::setProtocol when running DOM Fuzzer
Test: fast/dom/Window/invalid-protocol.html
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setProtocol): Raise an exception if KURL::setProtocol fails.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setProtocol): Move argument tweaking logic into KURL. This way, the ':' trick applies to both JSLocation and HTMLAnchorElement, matching IE (but not Firefox). IE behavior is more permissive, and even more logical in my opinion.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Assert that setting protocol succeeded.
- platform/KURL.cpp: (WebCore::KURL::setProtocol): Remove everything past ':', if present. Return false if the protocol to set is not valid. (WebCore::isValidProtocol): Made this work correctly for empty strings.
- platform/KURL.h: isValidProtocol() is now static in KURL.cpp, it's only used in setProtocol().
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): Always return true. This should hopefully prevent Chromium build breakage, alhough tests will likely fail. (WebCore::isValidProtocol): Removed, as this isn't used at the moment.
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::httpURLForAuthenticationAndCookies): Assert that setting protocol succeeded.
- 12:40 PM Changeset in webkit [53711] by
-
- 5 edits in trunk/WebCore
2010-01-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
<rdar://problem/7373568>
https://bugs.webkit.org/show_bug.cgi?id=34007
Implement hardware acceleration of video compositing on Windows
Internally we still have QuickTime render to a bitmap, but frames are then composited
with the page using an accelerated renderer.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_newFrameAvailable. (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::cancelLoad): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::updateStates): Call setUpVideoRendering once the movie
is ready to draw.
(WebCore::MediaPlayerPrivate::isReadyForRendering): New, utility function returns true
only when movie is ready to render.
(WebCore::MediaPlayerPrivate::setSize): Remember the size as we need it when rendering
in accelerated mode.
(WebCore::MediaPlayerPrivate::setVisible): Call setUpVideoRendering when made visible.
(WebCore::MediaPlayerPrivate::paint): Do nothing when rendering to a layer. Move frame
rate drawing code to paintCompleted.
(WebCore::MediaPlayerPrivate::paintCompleted): New, clear m_newFrameAvailable and, when
built with DRAW_FRAME_RATE, draw framerate.
(WebCore::MediaPlayerPrivate::movieNewImageAvailable): Set m_newFrameAvailable, trigger
repaint differently when drawing to a layer.
(WebCore::MediaPlayerPrivate::currentRenderingMode): New, return the current rendering mode.
(WebCore::MediaPlayerPrivate::preferredRenderingMode): New, return preferred rendering mode
(render to a layer whenever possible).
(WebCore::MediaPlayerPrivate::setUpVideoRendering): New, tear down current rendering mode
and set up new mode when necessary.
(WebCore::MediaPlayerPrivate::tearDownVideoRendering): New, noop unless rendering to a layer.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering): New.
(WebCore::MediaPlayerPrivate::paintContents): New, callback from compositing layer when it
is time to draw the current frame.
(WebCore::MediaPlayerPrivate::createLayerForMovie): New, allocate a layer for the movie.
(WebCore::MediaPlayerPrivate::destroyLayerForMovie): New, delete movie layer.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the
movie is not ready to render.
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): New, deal with change in
accelerated rendering state.
(WebCore::MediaPlayerPrivate::notifySyncRequired): New, callback from compositing layer
when it wants to schedule a redraw.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::notifyAnimationStarted): (WebCore::MediaPlayerPrivate::showDebugBorders): (WebCore::MediaPlayerPrivate::showRepaintCounter):
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getCurrentFrameInfo):
New, return information about the offscreen render buffer.
(QTMovieWin::initializeQuickTime):
- platform/graphics/win/QTMovieWin.h:
- 12:33 PM Changeset in webkit [53710] by
-
- 12 edits in trunk
2010-01-21 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985
setItem and removeItem on WebStorageArea need to expose what the previous
value was for the key being modified. Clear needs to return whether it
actually cleared anything.
- public/WebStorageArea.h: (WebKit::WebStorageArea::setItem): (WebKit::WebStorageArea::removeItem): (WebKit::WebStorageArea::clear):
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::storageEvent):
- src/StorageAreaProxy.h:
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea):
- src/StorageNamespaceProxy.h:
- src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
- src/WebStorageAreaImpl.h:
2010-01-21 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985
This change is not visible to layoutTests/web pages.
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): return the old value (WebCore::StorageAreaImpl::removeItem): return the old value (WebCore::StorageAreaImpl::clear): return whether there was anything to clear
- storage/StorageAreaImpl.h:
- 12:06 PM Changeset in webkit [53709] by
-
- 3 edits2 adds in trunk
An element that doesn't validate and an invalid element shouldn't share style
https://bugs.webkit.org/show_bug.cgi?id=34010
Reviewed by Dan Bernstein.
Test: fast/css/pseudo-invalid-novalidate-001.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Separate the check for willValidate from the check for isValidFormControlElement.
- html/HTMLFormControlElement.h: The validity method doesn't need to be virtual.
- 11:49 AM Changeset in webkit [53708] by
-
- 2 edits in trunk/WebCore
Crash in fast/dom/Window/window-properties if Geolocation enabled
https://bugs.webkit.org/show_bug.cgi?id=34013
Reviewed by Dan Bernstein.
Add null check to fix Geolocation crash in fast/dom/Window/window-properties.
- page/Geolocation.cpp:
(WebCore::createGeoposition):
- 11:13 AM Changeset in webkit [53707] by
-
- 3 edits in trunk/LayoutTests
Fix for the failing test on qt buildbot.
This tests had been added as part of the patch for https://bugs.webkit.org/show_bug.cgi?id=33970
Reviewed by Adele Peterson.
- editing/pasteboard/paste-noscript-svg-expected.txt:
- editing/resources/svgcontent.xhtml:
- 11:09 AM Changeset in webkit [53706] by
-
- 2 edits5 adds in trunk
2010-01-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Object.getOwnPropertyDescriptor(window) returns descriptors for properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33948
Even though prototype properties are proxied by JSDOMWindow::getOwnPropertySlot(),
that proxying should not be performed by JSDOMWindow::getOwnPropertyDescriptor().
This makes getOwnPropertyDescriptor() consistent with getOwnPropertyNames().
Test: fast/dom/Window/window-property-descriptors.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- 10:44 AM Changeset in webkit [53705] by
-
- 4 edits in trunk/WebKit/chromium
2010-01-21 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading
This is a refinement of http://trac.webkit.org/changeset/51548
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::didStartLoading): (WebKit::WebViewImpl::didStopLoading):
- src/WebViewImpl.h:
- 10:31 AM Changeset in webkit [53704] by
-
- 1 edit1 add in trunk/LayoutTests
Check in expected failure results for text-zoom.xhtml on Windows
Fixing this test is covered by <http://webkit.org/b/34006>.
Rubber-stamped by Dan Bernstein.
- platform/win/svg/custom/text-zoom-expected.txt: Added.
- 9:01 AM Changeset in webkit [53703] by
-
- 6 edits in trunk
[Qt] Save the QWebPageClient instead of the ownerWidget in QtAbstractWebPopup
Reviewed by Simon Hausmann.
The QWebPageClient is required for the QtFallbackWebPopup. QtFallbackWebPopup will
need it to create a QGraphicsProxyWidget (in a future commit) for the
QGraphicsWebView's web popup.
- 8:11 AM Changeset in webkit [53702] by
-
- 2 edits in trunk/LayoutTests
[Qt] http/tests/misc/slow-loading-mask.html timed out.
https://bugs.webkit.org/show_bug.cgi?id=34004
- platform/qt/Skipped: http/tests/misc/slow-loading-mask.html skipped.
- 6:28 AM Changeset in webkit [53701] by
-
- 1 edit10 moves3 adds24 deletes in trunk/LayoutTests
2010-01-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
incorrect results for css2.1 layout tests that use setTimeout in body onload event
https://bugs.webkit.org/show_bug.cgi?id=17557
- css2.1/README.txt: Added.
- css2.1/t1204-increment-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html.
- css2.1/t1204-increment-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html.
- css2.1/t1204-increment-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html.
- css2.1/t1204-reset-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html.
- css2.1/t1204-reset-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html.
- css2.1/t1204-reset-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html.
- fast/css/counters/counter-increment-000-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o-expected.txt.
- fast/css/counters/counter-increment-000.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o.html.
- fast/css/counters/counter-increment-001-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o-expected.txt.
- fast/css/counters/counter-increment-001.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o.html.
- fast/css/counters/counter-reset-001-expected.txt: Added.
- fast/css/counters/counter-reset-001.html: Added.
- platform/mac/css2.1/t1204-increment-00-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-increment-00-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
- platform/mac/css2.1/t1204-increment-01-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-increment-01-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
- platform/mac/css2.1/t1204-increment-02-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-increment-02-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
- platform/mac/css2.1/t1204-reset-00-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-reset-00-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
- platform/mac/css2.1/t1204-reset-01-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-reset-01-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
- platform/mac/css2.1/t1204-reset-02-c-o-expected.checksum: Removed.
- platform/mac/css2.1/t1204-reset-02-c-o-expected.png: Removed.
- platform/mac/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
- platform/qt/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
- 6:13 AM Changeset in webkit [53700] by
-
- 2 edits in trunk/BugsSite
2010-01-22 Janusz Lewandowski <lew21@xtreeme.org>
Reviewed by Maciej Stachowiak.
run-webkit-tests fails on Ruby 1.9
https://bugs.webkit.org/show_bug.cgi?id=33554
inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.
- PrettyPatch/PrettyPatch.rb:
- 5:42 AM Changeset in webkit [53699] by
-
- 2 edits in trunk/WebCore
Unreviewed Qt "build" fix.
- WebCore.pro: Fix warning about missing header file that isn't present anymore.
- 5:34 AM Changeset in webkit [53698] by
-
- 2 edits in trunk/WebKit/qt
QState::polished() was renamed to QState::propertiesAssigned() when
Qt 4.6.0 was released.
Reviewed by Kenneth Rohde Christiansen.
- 4:56 AM Changeset in webkit [53697] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip test introduced in r53684 because of missing eventSender.textZoomIn()
- platform/qt/Skipped: svg/custom/text-zoom.xhtml skipped.
- 4:52 AM Changeset in webkit [53696] by
-
- 10 edits in trunk/WebCore
2010-01-22 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Web Inspector: Caught exceptions still pause the debugger.
<https://bugs.webkit.org/show_bug.cgi?id=28622>.
Turn the pauseOnExceptions variable from a bool to an int, because we now have
3 states, in an enum: DontPauseOnExceptions, PauseOnAllExceptions, and
PauseOnUncaughtExceptions. The status button for pausing on exceptions is now
a tri-state button, which cycles from Don't pause (no background) to Pause on All
(blue background) to Pause on Uncaught (purple background).
Also added the ability for a status button to have more than 2 states, and added
style rules for a CSS three state button.
Added a manual test, manual-tests/debugger-caught-uncaught-exceptions.html, that
generates caught and uncaught exceptions.
- English.lproj/localizedStrings.js: Added updated Action / Click to Action text.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pauseOnExceptions): Changed from a bool to an int. (WebCore::InspectorBackend::setPauseOnExceptions): Ditto.
- inspector/InspectorBackend.h: Ditto.
- inspector/InspectorBackend.idl: Ditto.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::setPauseOnExceptions): Ditto. (WebCore::JavaScriptDebugServer::exception): Updated logic to see if we are breaking
on uncaught exceptions, and check if we have a handler.
- inspector/JavaScriptDebugServer.h: (WebCore::JavaScriptDebugServer::): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::pauseOnExceptions): Ditto.
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptionsState): Changed from returning false to returning 0 (stub function).
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): Updated to new text/new cycling of variables. (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): Updated to new text/new cycling of variables.
- inspector/front-end/StatusBarButton.js: (WebInspector.StatusBarButton): Added the option for a different number of states. (WebInspector.StatusBarButton.prototype.set toggled): Added rules to toggle on/off with multiple states.
- inspector/front-end/inspector.css: Added rules for toggled-1 and toggled-2.
- manual-tests/debugger-caught-uncaught-exceptions.html: Added.
- 4:30 AM Changeset in webkit [53695] by
-
- 4 edits2 adds in trunk/WebCore
2010-01-22 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
[Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
https://bugs.webkit.org/show_bug.cgi?id=33719
Add the Android specific files and update the Android makefile.
No new tests as this is all Android-specific code.
- Android.mk: Add Touch event related files to the makefile.
- platform/PlatformTouchEvent.h: Add Android constructor.
- platform/PlatformTouchPoint.h: Ditto.
- platform/android/PlatformTouchEventAndroid.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): Android implementation.
- platform/android/PlatformTouchPointAndroid.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint): Android implementation.
- 4:23 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:04 AM Changeset in webkit [53694] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
[Qt] css1_forward_compatible_parsing.html moved from css2.1 to fast/css by r53664.
- platform/qt/Skipped: path fixed.
- 4:01 AM Changeset in webkit [53693] by
-
- 6 edits in trunk/WebCore
2010-01-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
The RenderObjects with fixed position register to the view
to be taken into account while scrolling.
The scrolling code update specifically those elements after blitting the pixels.
- page/FrameView.cpp: (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
- platform/ScrollView.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
- 3:57 AM Changeset in webkit [53692] by
-
- 1 edit2 copies1 move6 adds2 deletes in trunk/LayoutTests
2010-01-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Maciej Stachowiak.
Split websocket/tests/bad-sub-protocol.html
https://bugs.webkit.org/show_bug.cgi?id=33646
- websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
- websocket/tests/bad-sub-protocol-control-chars.html: Added.
- websocket/tests/bad-sub-protocol-empty-expected.txt: Added.
- websocket/tests/bad-sub-protocol-empty.html: Added.
- websocket/tests/bad-sub-protocol-expected.txt: Removed.
- websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.
- websocket/tests/bad-sub-protocol-non-ascii.html: Added.
- websocket/tests/bad-sub-protocol.html: Removed.
- websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Added.
- websocket/tests/script-tests/bad-sub-protocol-empty.js: Added.
- websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Added.
- websocket/tests/script-tests/bad-sub-protocol.js: Removed.
- 2:48 AM Changeset in webkit [53691] by
-
- 4 edits2 adds3 deletes in trunk
2010-01-22 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Improve portability of listbox-deselect-scroll.html
https://bugs.webkit.org/show_bug.cgi?id=33989
- Convert the test to dumpAsTest
- Use eventSender.mouseDown(0, addSelectionKey)
- Avoid hard-coded line-heights.
- fast/forms/listbox-deselect-scroll-expected.txt: Added.
- fast/forms/listbox-deselect-scroll.html:
- fast/forms/script-tests/listbox-deselect-scroll.js: Added.
- platform/mac/fast/forms/listbox-deselect-scroll-expected.checksum: Removed.
- platform/mac/fast/forms/listbox-deselect-scroll-expected.png: Removed.
- platform/mac/fast/forms/listbox-deselect-scroll-expected.txt: Removed.
2010-01-22 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Fix a bug that mouseDown:withModifiers: is never called.
https://bugs.webkit.org/show_bug.cgi?id=33989
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]):
- 2:26 AM Changeset in webkit [53690] by
-
- 6 edits2 adds in trunk/WebCore
2010-01-22 Anton Muhin <antonm@chromium.org>
Reviewed by Eric Seidel.
Adding ScriptWrappable into WebCore.
This allows to associate custom information when Node
gets wrapped into JavaScript wrapper.
[v8, dom] Add a pointer field to C++ Node class
https://bugs.webkit.org/show_bug.cgi?id=32430
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable):
- bindings/v8/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- dom/Node.h:
- 1:42 AM Changeset in webkit [53689] by
-
- 2 edits in trunk/WebCore
emikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add stub implementation of dispatchOnInjectedScript method so that
Chromium source can compile against it and the main fix for the bug
28622 can be landed without breaking Chromium build.
- inspector/InspectorBackend.h: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- 1:19 AM Changeset in webkit [53688] by
-
- 2 edits in trunk/WebCore
2010-01-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Dmitry Titov.
ENABLE(DATABASE) guard is missing in ScriptExecutionContext::~ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=33990
Add missing ENABLE(DATABASE) guard.
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
- 1:17 AM Changeset in webkit [53687] by
-
- 3 edits2 adds in trunk/WebKitTools
[Qt] Separate out the WebPage class into it's own
cpp/header files. Also, removed the assumption that
the view is a QWebView, in preparation of a merger
of the two Qt WebKit launchers.
Rubberstamped by Antti Koivisto.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(WebView::mousePressEvent):
- QtLauncher/webpage.cpp: Added.
(WebPage::supportsExtension):
(WebPage::extension):
(WebPage::acceptNavigationRequest):
(WebPage::openUrlInDefaultBrowser):
- QtLauncher/webpage.h: Added.
(WebPage::WebPage):
- 12:42 AM Changeset in webkit [53686] by
-
- 2 edits in trunk/WebCore
2010-01-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
- bindings/scripts/generate-bindings.pl:
- 12:42 AM Changeset in webkit [53685] by
-
- 2 edits in trunk/WebCore
2010-01-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Rename FEATURE_DEFINES_JAVASCRIPT to FEATURE_DEFINES and remove
the hardcoded LANGUAGE_JAVASCRIPT=1, in preparation for its use by
the GObject DOM bindings.
- GNUmakefile.am:
- 12:20 AM Changeset in webkit [53684] by
-
- 4 edits4 adds in trunk
<rdar://problem/7568696> Zoom applied to embedded SVG incorrectly
https://bugs.webkit.org/show_bug.cgi?id=33988
Reviewed by Darin Adler.
WebCore:
Test: svg/custom/text-zoom.xhtml
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement): Initialize m_scale.
(WebCore::SVGSVGElement::currentScale): If this is the document element,
return the frame’s zoom factor. Otherwise, return m_scale.
(WebCore::SVGSVGElement::setCurrentScale): If this is the document element,
set the frame’s zoom factor. Otherwise, set m_scale and mark for layout.
- svg/SVGSVGElement.h: Added m_scale member.
LayoutTests:
- svg/custom/text-zoom-expected.checksum: Added.
- svg/custom/text-zoom-expected.png: Added.
- svg/custom/text-zoom-expected.txt: Added.
- svg/custom/text-zoom.xhtml: Added.
Jan 21, 2010:
- 11:48 PM Changeset in webkit [53683] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-21 Adam Barth <abarth@webkit.org>
Unreviewed. Added a blank line requested by the great an powerful
fishd.
- public/WebFrameClient.h:
- 11:36 PM Changeset in webkit [53682] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Add ThreadSpecific for ENABLE(SINGLE_THREADED)
https://bugs.webkit.org/show_bug.cgi?id=33878
Implement ThreadSpecific with a simple getter/setter
when ENABLE(SINGLE_THREADED) is true.
Due to the change in https://bugs.webkit.org/show_bug.cgi?id=33236,
an implementation of ThreadSpecific must be available to build WebKit.
This causes a build failure for platforms without a proper
ThreadSpecific implementation.
- wtf/ThreadSpecific.h: (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy):
- 11:11 PM Changeset in webkit [53681] by
-
- 7 edits in trunk
2010-01-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[chromium] Add allowPlugins callback to allow per-site enabling of plugins
https://bugs.webkit.org/show_bug.cgi?id=33974
Add a callback into the FrameLoaderClient to let the embedder enable or
disable plugins on a per-site basis.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowPlugins):
2010-01-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[chromium] Add allowPlugins callback to allow per-site enabling of plugins
https://bugs.webkit.org/show_bug.cgi?id=33974
Forward the new allowPlugins callback to WebKitClient so that it can
make the policy decision.
- public/WebFrameClient.h: (WebKit::WebFrameClient::allowPlugins):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins):
- src/FrameLoaderClientImpl.h:
- 10:58 PM CommitterTips edited by
- Fixed manual numbering from previous change. (diff)
- 10:53 PM CommitterTips edited by
- Corrected information about username/password prompting. (diff)
- 10:53 PM Changeset in webkit [53680] by
-
- 3 edits2 adds in trunk
2010-01-21 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25501
Remove empty font tags when applying a style to a content editable
region.
- editing/execCommand/change-font.html: Added.
- editing/execCommand/change-font-expected.txt: Added.
2010-01-21 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25501
Remove empty font tags when applying a style to a content editable
region.
Test: editing/execCommand/change-font.html
- editing/ApplyStyleCommand.cpp: (WebCore::isEmptyFontTag):
- 10:37 PM Changeset in webkit [53679] by
-
- 2 edits3 adds in trunk/WebKitSite
Added screenshots and clearer instructions on how to submit
a patch for review.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32542
Also added that a bug report should be selected or created
prior to submitting a patch.
- coding/contributing.html:
- coding/images: Added.
- coding/images/contribute_add_attachment.png: Added.
- coding/images/contribute_mark_review.png: Added.
- 10:21 PM Changeset in webkit [53678] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-21 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Bumps the refcount when WebNode::toElement/toConstElement are called.
https://bugs.webkit.org/show_bug.cgi?id=33977
Ensures that when a wrapper around a WebNode is create via the
toElement() or toConstElement() calls that the refcount on the WebNode
is increased, by forcing a call to WebNode::assign(). This is needed
so that the following code:
{
WebNode n = someNode();
WebElement e = n.toElement<WebElement>();
}
does not decrease the overall refcount on the Node that someNode()
returns.
This caused crashes in the 'Save page as..' feature.
- public/WebNode.h: (WebKit::WebNode::toElement): (WebKit::WebNode::toConstElement):
- 10:05 PM Changeset in webkit [53677] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Maciej Stachowiak.
Add fastStrDup to FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=33937
The new string returned by fastStrDup is obtained with fastMalloc,
and can be freed with fastFree. This makes the memory management
more consistent because we don't need to keep strdup allocated pointers
and free them with free(). Instead we can use fastFree everywhere.
- wtf/FastMalloc.cpp: (WTF::fastStrDup):
- wtf/FastMalloc.h:
- 10:01 PM Changeset in webkit [53676] by
-
- 1 edit3 copies1 delete in trunk/LayoutTests
2010-01-21 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Shinichiro Hamaji.
Move fast/websockets into websocket/tests
https://bugs.webkit.org/show_bug.cgi?id=32258
- fast/websockets: Removed.
- websocket/tests/script-tests/websocket-event-target.js: Copied from LayoutTests/fast/websockets/script-tests/websocket-event-target.js.
- websocket/tests/websocket-event-target-expected.txt: Copied from LayoutTests/fast/websockets/websocket-event-target-expected.txt.
- websocket/tests/websocket-event-target.html: Copied from LayoutTests/fast/websockets/websocket-event-target.html.
- 9:39 PM Changeset in webkit [53675] by
-
- 8 edits in trunk/WebKitTools
2010-01-21 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored to move file name and file-reading related code
from cpp_style.py and text_style.py to checker.py.
- Scripts/check-webkit-style:
- Updates caused by changes to checker.py.
- Scripts/webkitpy/style/checker.py:
- Added SKIPPED_FILES_WITH_WARNING list.
- Added SKIPPED_FILES_WITHOUT_WARNING list.
- Added FileType class.
- Added ProcessorDispatcher class.
- In StyleChecker class:
- Renamed process_patch() to check_patch().
- Renamed process_file() to check_file().
- Added _process_file().
- Related refactoring.
- Addressed check_patch() FIXME to share code with process_file().
- Scripts/webkitpy/style/checker_unittest.py:
- Added ProcessorDispatcherSkipTest class.
- Added ProcessorDispatcherDispatchTest class.
- Added StyleCheckerCheckFileTest class.
- Scripts/webkitpy/style/cpp_style.py:
- Renamed process_file_data() to _process_lines.
- Removed process_file() (moved logic to checker.py).
- Removed can_handle() (moved logic to checker.py).
- Added CppProcessor class.
- Removed is_exempt() (moved logic to checker.py).
- Added process_file_data() back as a wrapper function.
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Removed test_can_handle().
- Removed test_is_exempt().
- Added CppProcessorTest class.
- Scripts/webkitpy/style/text_style.py:
- Added TextProcessor class.
- Removed process_file().
- Removed can_handle().
- Scripts/webkitpy/style/text_style_unittest.py:
- Removed test_can_handle().
- Added TextProcessorTest class.
- 9:27 PM WikiStart edited by
- Retitled committer tips section to make it easier to see (diff)
- 9:23 PM Changeset in webkit [53674] by
-
- 2 edits in trunk/WebCore
2010-01-21 Joe Mason <jmason@rim.com>
Reviewed by Darin Adler.
Promote pow argument to double to resolve ambiguous overload (compile fix for RVCT 4.0)
https://bugs.webkit.org/show_bug.cgi?id=33952
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::gamma):
- 9:11 PM CommitterTips edited by
- Added first draft of "Walking you through your first commit" (diff)
- 9:06 PM Changeset in webkit [53673] by
-
- 3 edits in trunk/WebCore
2010-01-21 Andrei Popescu <andreip@google.com>
Reviewed by David Levin.
[Android] bindings/v8/ScriptController.cpp needs to include
PlatformBridge.h instead of ChromiumBridge.h so that it can
be used on both Chromium and Android.
https://bugs.webkit.org/show_bug.cgi?id=33673
Add "static NPObject* pluginScriptableObject(Widget*);" method
to PlatformBridge.h
Include PlatformBridge.h from ScriptController.cpp.
No new tests, just platform code.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
- platform/android/PlatformBridge.h:
- 8:22 PM Changeset in webkit [53672] by
-
- 10 edits in trunk
history.back() for same-document history traversals isn't synchronous as the specification states.
<rdar://problem/7535011> and https://bugs.webkit.org/show_bug.cgi?id=33538
Reviewed by Maciej Stachowiak.
- wtf/Platform.h: Add a "HISTORY_ALWAYS_ASYNC" enable and turn it on for Chromium.
WebCore:
In resolving https://bugs.webkit.org/show_bug.cgi?id=25570, all history.back()/forward()/go() navigations
were made asynchronous. That doesn't agree with the HTML5 spec and might have been overreaching for fixing
that particular bug. In working with the new history state APIs I noticed some things that should've been
possible were not possible because of this change.
The change in loading behavior is well covered via modifications to previous tests.
- loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleHistoryNavigation): Determine beforehand if the traversal is
a same-document navigation. If it is, perform the load directly instead of scheduling it.
LayoutTests:
The change in loading behavior is well covered via modifications to these previous tests:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
- fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt:
- fast/loader/stateobjects/state-api-on-detached-frame-crash.html:
- 8:21 PM Changeset in webkit [53671] by
-
- 6 edits1 add in trunk/WebKit/chromium
2010-01-21 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Adds WebKit::WebDataSource::applicationCacheHost() to the API.
https://bugs.webkit.org/show_bug.cgi?id=33880
- WebKit.gyp:
- public/WebDataSource.h:
- src/ApplicationCacheHost.cpp:
- src/ApplicationCacheHostInternal.h: Copied from WebKit/chromium/src/ApplicationCacheHost.cpp. (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):
- src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost):
- src/WebDataSourceImpl.h:
- 8:04 PM Changeset in webkit [53670] by
-
- 2 edits in trunk/WebCore
2010-01-21 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Tor Arne Vestbø.
[Qt] Don't allow Phonon's invisible video widget to keep the app running.
https://bugs.webkit.org/show_bug.cgi?id=33842
The change made in r38223 should not be limited to Qt < 4.5 only.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- 7:29 PM Changeset in webkit [53669] by
-
- 7 edits in trunk
2010-01-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=datetime.
https://bugs.webkit.org/show_bug.cgi?id=33939
Add setter tests to input-valueasdate-datetime.js, and update the
expectation.
Note: the expectation file contains some FAIL lines. They are
intentional because they test a unimplemented feature.
- fast/forms/input-valueasdate-datetime-expected.txt:
- fast/forms/script-tests/input-valueasdate-datetime.js:
2010-01-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=datetime.
https://bugs.webkit.org/show_bug.cgi?id=33939
Introduce ISODateTime::setMillisecondsSinceEpochForDateTime() and add
DateTime type support to ISODateTime::toString().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueAsDate):
- html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDate): Set Invalid to m_type. (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTime): (WebCore::ISODateTime::setMillisecondsSinceEpochForMonth): Set Invalid to m_type. (WebCore::ISODateTime::setMillisecondsSinceMidnight): Set Invalid to m_type. (WebCore::ISODateTime::toString): Support DateTime type. This always produces UTC representation.
- html/ISODateTime.h:
- 7:25 PM Changeset in webkit [53668] by
-
- 2 edits in trunk/WebCore
2010-01-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed <rdar://problem/7562574> ASSERT in WebCore::removeWrapper() at the
end of run-webkit-tests
This was an ASSERT-only bug, introduced by isolated worlds, which
created the novelty of a wrapper that might outlive its wrapper cache.
When a wrapper outlived its wrapper cache, both the wrapper's destructor
and the wrapper cache's destructor would claim to have uncached the wrapper,
causing an ASSERT to fire.
The solution is to distinguish between operations that logically add and
remove cache entries, and operations that delete whole caches. We track
when a cache entry is logically added, and when it's logically removed,
independent of whether the actual cache still exists.
- bindings/js/JSDOMBinding.cpp: (WebCore::willCacheWrapper): (WebCore::didUncacheWrapper): New names for these functions to help explain what they track.
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Don't claim to uncache
all the wrappers in the world; we're deleting the cache, not managing its
entries.
(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument): Updated for renames.
- 6:48 PM QtWebKitGraphics edited by
- (diff)
- 6:35 PM Changeset in webkit [53667] by
-
- 3 edits2 adds in trunk/WebKitTools
Create a unit-tested subroutine to parse patch files created
by svn-create-patch.
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=33475
- Scripts/VCSUtils.pm:
- Added parseDiff().
- Added parsePatch().
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
- Added unit tests for parseDiff().
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Total number of tests now computed dynamically.
- Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
- Added unit tests for parsePatch().
- 6:23 PM Changeset in webkit [53666] by
-
- 17 edits1 add1 delete in trunk/WebCore
2010-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Sam Weinig.
SVG JS bindings "context" pointer needs to move onto binding impls
https://bugs.webkit.org/show_bug.cgi?id=27243
Rewrite SVG DOM JSC bindings to use a global DOMObject <-> SVGElement context map, similar to V8's approach.
This allows us to remove DOMObjectWithSVGContext and make all SVG JS objects use DOMObjectWithGlobalPointer.
We're fitting again in JS_CELL_SIZE, and there's no need to special case SVG anymore.
Not adding a new test, as we have yet to identify how to test that we're passing around correct global objects.
For now this is just a code cleanup which lets me continue making progress in that area of the code.
- GNUmakefile.am: Add new DOMObjectWithSVGContext.h to build.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/DOMObjectWithSVGContext.h: Removed.
- bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): Add comment, that passing 0 context is intentional.
- bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): Add to JSSVGContextCache, when creating wrappers. (WebCore::getDOMObjectWrapper): Add assertion guarding the JSSVGContextCache is in-sync with the passed context.
- bindings/js/JSSVGContextCache.h: Added. Maps DOMObjects to SVGElements - just like V8 approachs to this problem. (WebCore::JSSVGContextCache::wrapperMap): (WebCore::JSSVGContextCache::addWrapper): (WebCore::JSSVGContextCache::forgetWrapper): (WebCore::JSSVGContextCache::propagateSVGDOMChange): (WebCore::JSSVGContextCache::svgContextForDOMObject):
- bindings/js/JSSVGLengthCustom.cpp: Retrieve context from cache, instead of taking it from the JS* class. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp Ditto.: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPODListCustom.h: Ditto. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize):
- bindings/js/JSSVGPODTypeWrapper.h: Ditto. (WebCore::JSSVGDynamicPODTypeWrapper::commitChange): (WebCore::JSSVGStaticPODTypeWrapper::commitChange): (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange): (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::commitChange):
- bindings/js/JSSVGPathSegCustom.cpp: Ditto. (WebCore::toJS):
- bindings/js/JSSVGPathSegListCustom.cpp: Ditto. (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
- bindings/scripts/CodeGeneratorJS.pm:
- svg/SVGAngle.h: Remove unneeded associatedAttributeName() method.
- svg/SVGPreserveAspectRatio.h: Ditto.
- svg/SVGTransform.h: Ditto.
- 6:07 PM Changeset in webkit [53665] by
-
- 4 edits in trunk
wx build fixes, add a missing header and add a new dir to the build system.
- 5:40 PM Changeset in webkit [53664] by
-
- 1 edit12 moves in trunk/LayoutTests
2010-01-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
3 tests for CSS are misplaced
https://bugs.webkit.org/show_bug.cgi?id=33942
- css2.1/atrule_longest_match-expected.txt: Removed.
- css2.1/atrule_longest_match.html: Removed.
- css2.1/bogus-color-span.html: Removed.
- css2.1/css1_forward_compatible_parsing.html: Removed.
- fast/css/atrule_longest_match-expected.txt: Copied from LayoutTests/css2.1/atrule_longest_match-expected.txt.
- fast/css/atrule_longest_match.html: Copied from LayoutTests/css2.1/atrule_longest_match.html.
- fast/css/bogus-color-span.html: Copied from LayoutTests/css2.1/bogus-color-span.html.
- fast/css/css1_forward_compatible_parsing.html: Copied from LayoutTests/css2.1/css1_forward_compatible_parsing.html.
- platform/mac/css2.1/bogus-color-span-expected.checksum: Removed.
- platform/mac/css2.1/bogus-color-span-expected.png: Removed.
- platform/mac/css2.1/bogus-color-span-expected.txt: Removed.
- platform/mac/css2.1/css1_forward_compatible_parsing-expected.checksum: Removed.
- platform/mac/css2.1/css1_forward_compatible_parsing-expected.png: Removed.
- platform/mac/css2.1/css1_forward_compatible_parsing-expected.txt: Removed.
- platform/mac/fast/css/bogus-color-span-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.checksum.
- platform/mac/fast/css/bogus-color-span-expected.png: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.png.
- platform/mac/fast/css/bogus-color-span-expected.txt: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.txt.
- platform/mac/fast/css/css1_forward_compatible_parsing-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.checksum.
- platform/mac/fast/css/css1_forward_compatible_parsing-expected.png: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.png.
- platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.txt.
- platform/qt/css2.1/bogus-color-span-expected.txt: Removed.
- platform/qt/css2.1/css1_forward_compatible_parsing-expected.txt: Removed.
- platform/qt/fast/css/bogus-color-span-expected.txt: Copied from LayoutTests/platform/qt/css2.1/bogus-color-span-expected.txt.
- platform/qt/fast/css/css1_forward_compatible_parsing-expected.txt: Copied from LayoutTests/platform/qt/css2.1/css1_forward_compatible_parsing-expected.txt.
- 5:28 PM Changeset in webkit [53663] by
-
- 5 edits6 adds in trunk
2010-01-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
-webkit-mask-box-image draws a box while loading
https://bugs.webkit.org/show_bug.cgi?id=33979
<rdar://problem/7378662>
Don't render masked elements until the mask images are fully loaded.
Test: http/tests/misc/slow-loading-mask.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages): Check that all mask images (both the single mask-box-image, and the possibly multiple mask-image) are fully loaded before allowing the masked content to render. If they are not fully loaded, use a fully transparent transparency layer.
- rendering/style/FillLayer.h:
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::imagesAreLoaded): New utility function that returns true if the image in every FillLayer is loaded.
- 5:20 PM Changeset in webkit [53662] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Eric Seidel.
Skipping this until issues mentioned in https://bugs.webkit.org/show_bug.cgi?id=33923 are resolved.
- platform/mac/Skipped:
- 5:07 PM Changeset in webkit [53661] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-01-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make the EWS transactional
https://bugs.webkit.org/show_bug.cgi?id=33978
Now if the EWS gets interrupted in the middle of processing a patch,
the bots will re-process the patch.
- Scripts/test-webkitpy:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/patchcollection.py:
- Scripts/webkitpy/patchcollection_unittest.py: Added.
- 4:48 PM Changeset in webkit [53660] by
-
- 2 edits in trunk/WebCore
REGRESSION (r52795): New message created in response to mailto: URL has random character in message body
rdar://problem/7565902
Reviewed by Mark Rowe.
This regression affects the Mac OS X Mail application.
I was not able to find a simple way to create a regression test.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer): Initialize m_size to 0 as in the other constructors.
- 4:40 PM Changeset in webkit [53659] by
-
- 6 edits5 adds in trunk
Script tags are copied and pasted, making cross-domain attacks possible.
https://bugs.webkit.org/show_bug.cgi?id=33970
Reviewed by Darin Adler.
WebCore:
Tests: editing/pasteboard/paste-noscript-svg.html
editing/pasteboard/paste-visible-script.html
We remove the content and the attributes of every script tag before
pasting into the destination.
- dom/Element.cpp:
(WebCore::Element::setAttributeMap): Now we are removing xlink:href
if it contains javascript protocol.
- html/HTMLParser.cpp:
(WebCore::HTMLParser::parseToken): We strip all the script tag attributes
we are parsing to create a fragment to paste.
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::HTMLTokenizer::scriptHandler): Removes the script text after it was parsed.
- html/HTMLTokenizer.h:
LayoutTests:
- editing/pasteboard/paste-noscript-svg-expected.txt: Added.
- editing/pasteboard/paste-noscript-svg.html: Added.
- editing/pasteboard/paste-visible-script-expected.txt: Added.
- editing/pasteboard/paste-visible-script.html: Added.
- editing/resources/svgcontent.xhtml: Added.
- 4:34 PM Changeset in webkit [53658] by
-
- 2 edits in trunk/WebKitTools
2010-01-21 Adam Barth <abarth@webkit.org>
Unreviewed. Add missing "ago" for style in the status bubble.
- QueueStatusServer/templates/statusbubble.html:
- 4:06 PM Changeset in webkit [53657] by
-
- 4 edits in trunk/JavaScriptCore
2010-01-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Always create a prototype for automatically managed classes.
This fixes some errors where prototype chains were not correctly hooked
up, and also ensures that API classes work correctly with features like
instanceof.
- API/JSClassRef.cpp: (OpaqueJSClass::create): Cleaned up some of this code. Also changed it to always create a prototype class.
- API/tests/testapi.c: (Derived2_class): (main): Fixed a null value crash in the exception checking code.
- API/tests/testapi.js: Added some tests for the case where a prototype chain would not be hooked up correctly.
- 3:22 PM Changeset in webkit [53656] by
-
- 9 edits8 adds in trunk
2010-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
<use> with % lengths does not update on window resize
https://bugs.webkit.org/show_bug.cgi?id=14639
appendChild broken for symbol-use
https://bugs.webkit.org/show_bug.cgi?id=24802
Test: svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml
svg/custom/svg/custom/relative-sized-use-on-symbol.xhtml
Fix reaction on window size changes for relative sized elements within <symbol> elements.
Don't evaluate SVGUseElement width/height attributes in order to propagate them to the shadow tree,
instead just propagate the attribute values itself so "100%" remains "100%" instead of being evaluated
to an absolute pixel value in the parent <svg> user-space.
Needs another fix in SVGStyledElement::childrenChanged(), which is a regression from my last <use>
patch, that hasn't been detected, as the use-dynamic-append.svg testcase was broken.
The combination of all the last <use> patches finally fixes the peepo.co.uk website, which was broken by several bugs for years.
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged): Need to mark shadow trees needing recalcs, even when parsing.
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): Don't reclone for width/height attribute changes, just propagate them down the render tree (WebCore::updateContainerSize): Added helper function, updating the width/height attributes in the shadow tree. (WebCore::SVGUseElement::updateContainerSizes): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Update container width/height after shadow tree creation, instead of doing it inbetween. (WebCore::SVGUseElement::buildShadowTree): Don't alter width/height attributes here anymore. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto. (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
- svg/SVGUseElement.h:
- 3:19 PM Changeset in webkit [53655] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33972
Assertion failure in FrameLoader::checkLoadComplete()
I couldn't make a test for this, after trying rather hard. I'm not too worried, because such
a test has to depend on details of current implementation so intimately that it would become
ineffective very quickly anyway.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): Stop the check timer, we don't need it after aborting load.
- 3:06 PM Changeset in webkit [53654] by
-
- 2 edits3 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Added platform specific (incorrect) results for plugins/mouse-events* for Windows,
and removed mouse-events from the Windows Skipped list. The landing of correct results
for these tests is being tracked by <http://webkit.org/b/33973>.
- platform/win/Skipped: Removed plugins/mouse-events from the Skipped List.
- platform/win/plugins: Added.
- platform/win/plugins/mouse-events-expected.txt: Added.
- platform/win/plugins/mouse-events-fixedpos-expected.txt: Added.
- 3:04 PM Changeset in webkit [53653] by
-
- 2 edits in trunk/LayoutTests
2010-01-21 Simon Fraser <Simon Fraser>
No review
Skip plugins/mouse-events-fixedpos.html on gtk, since it requires a special test plugin.
- platform/gtk/Skipped:
- 2:53 PM Changeset in webkit [53652] by
-
- 2 edits in trunk/WebCore
Buildfix for r53646.
Reviewed by Dave Hyatt.
- bindings/js/SerializedScriptValue.cpp: path of JSLock.h fixed.
- 2:40 PM QtWebKitGraphics created by
- 2:31 PM Changeset in webkit [53651] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix after r53644.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::scroll): missing HAVE(ACCESSIBILITY) guard added.
- 2:24 PM Changeset in webkit [53650] by
-
- 2 edits in trunk/WebCore
2010-01-21 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
https://bugs.webkit.org/show_bug.cgi?id=33969
- loader/HistoryController.cpp: (WebCore::HistoryController::pushState): Remove unnecessary code.
- 2:17 PM Changeset in webkit [53649] by
-
- 2 edits in trunk/WebCore
Not reviewed, Chromium build fix. Add AccessibilityScrollbar.h and .cpp to WebCore.gypi
- WebCore.gypi:
- 2:10 PM Changeset in webkit [53648] by
-
- 2 edits in trunk/WebCore
[chromium] Unreviewed build fix.
Fix possible use of initialized variable warning in release mode.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Deserializer::doDeserialize):
- 2:02 PM Changeset in webkit [53647] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r53644.
- WebCore.pro: accessibility/AccessibilityScrollbar.cpp and accessibility/AccessibilityScrollbar.h added.
- 1:57 PM Changeset in webkit [53646] by
-
- 2 edits in trunk/WebCore
Make sure to do a JSLock before deserialization of script values, since they can heap allocate.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::deserialize):
- 1:54 PM Changeset in webkit [53645] by
-
- 1 edit in trunk/WebCore/accessibility/AccessibilityAllInOne.cpp
Build fix, add new file to AccessibilityAllInOne
- 1:31 PM Changeset in webkit [53644] by
-
- 9 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33923 REGRESSION
(Safari 4): AXValueChanged no longer sent for text area scrollbars
-and corresponding-
<rdar://problem/6942686>
Reviewed by Oliver Hunt.
New class AccessibilityScrollbar inherits directly from
AccessibilityObject.
- accessibility/AccessibilityScrollbar.cpp: Added.
(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::valueForRange):
- accessibility/AccessibilityScrollbar.h: Added.
(WebCore::AccessibilityScrollbar::setScrollbar):
(WebCore::AccessibilityScrollbar::roleValue):
(WebCore::AccessibilityScrollbar::accessibilityIsIgnored):
(WebCore::AccessibilityScrollbar::size):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::parentObject):
AXObjectCache::getOrCreate() now has a case for ScrollBarRole,
which will create a new AccessibilityScrollbar. I also added a new
version of postNotification() that does not require a renderer. The
old postNotification() calls the new one.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::postNotification):
- accessibility/AXObjectCache.h:
When AX is enabled, getOrCreate an AccessibilityScrollbar and send
a notification.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::scroll):
Fix project files.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33923 REGRESSION
(Safari 4): AXValueChanged no longer sent for text area scrollbars
-and corresponding-
<rdar://problem/6942686>
Reviewed by Oliver Hunt.
- platform/mac/accessibility/change-notification-on-scroll-expected.txt: Added.
- platform/mac/accessibility/change-notification-on-scroll.html: Added.
- 1:08 PM Changeset in webkit [53643] by
-
- 2 edits in trunk/LayoutTests
2010-01-21 Simon Fraser <Simon Fraser>
No review
Skip plugins/mouse-events-fixedpos.html on Qt, since it requires a special test plugin.
- platform/qt/Skipped:
- 1:04 PM Changeset in webkit [53642] by
-
- 2 edits in trunk/JavaScriptCore
Force JSC to create a prototype chain for API classes with a
parent class but no static functions.
Reviewed by Geoff Garen.
- 1:02 PM Changeset in webkit [53641] by
-
- 5 edits in trunk
Add changes missing from r53595, without which Chromium has no database.
Patch by Eric Uhrhane <ericu@chromium.org> on 2010-01-21
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=33966
No new tests - fixes database layout tests in Chromium.
WebCore:
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h:
WebKit/chromium:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):
- 1:01 PM Changeset in webkit [53640] by
-
- 3 edits2 adds in trunk
2010-01-21 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] Implement texSubImage2D taking WebGLArray
https://bugs.webkit.org/show_bug.cgi?id=33932
- fast/canvas/webgl/tex-sub-image-2d-expected.txt: Added.
- fast/canvas/webgl/tex-sub-image-2d.html: Added.
2010-01-21 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] Implement texSubImage2D taking WebGLArray
https://bugs.webkit.org/show_bug.cgi?id=33932
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texSubImage2D):
- 12:56 PM Changeset in webkit [53639] by
-
- 7 edits in trunk/WebCore
2010-01-21 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Treat.
Don't call vgGetError()/eglGetError() repeatedly
https://bugs.webkit.org/show_bug.cgi?id=33959
For vgGetError(), I missed the part of the spec where
it says that calling that function clears the error
and subsequent calls will return VG_NO_ERROR again.
For eglGetError(), the specification doesn't mention
that kind of behavior, and interpretations seem to
differ between EGL implementations (even within
Khronos: the OpenVG reference implementation doesn't
reset the error code - and even mentions the difference
to vgGetError() in a comment - whereas the online
OpenGL ES API document explicitly specifies clearing
the error code).
It thus makes sense not to call either of the two
error functions more than once for checking a single
EGL/OpenVG call. This patch adapts assertions to
accommodate for this behavior, and also needs to
change surface creation methods as they previously
relied on multiple calls of eglGetError().
- platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::sharedPlatformSurface): (WebCore::EGLDisplayOpenVG::createPbufferSurface):
- platform/graphics/openvg/EGLDisplayOpenVG.h:
- platform/graphics/openvg/EGLUtils.h:
- platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
- platform/graphics/openvg/SurfaceOpenVG.h:
- platform/graphics/openvg/VGUtils.h:
- 12:46 PM Changeset in webkit [53638] by
-
- 4 edits in trunk/JavaScriptCore
2010-01-21 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Object.getOwnPropertyDescriptor always returns undefined for JS API objects
https://bugs.webkit.org/show_bug.cgi?id=33946
Ideally the getOwnPropertyDescriptor() reimplementation should return an
access descriptor that wraps the property getter and setter callbacks, but
that approach is much more involved than returning a value descriptor.
Keep it simple for now.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyDescriptor):
- API/tests/testapi.js:
- 12:19 PM Changeset in webkit [53637] by
-
- 7 edits2 adds in trunk
2010-01-20 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Hit testing on composited plugins is broken
https://bugs.webkit.org/show_bug.cgi?id=33927
<rdar://problem/7559069>
RenderWidget::paint()'s strategy of moving widgets at paint time, using tx and ty, was flawed
because tx,ty are not always root-relative, especially when painting into compositing layers.
This would move widgets to the wrong location, which caused hit testing issues.
Widgets are usually positioned by layout. The one time this was not true was scrolling fixed-position
elements, so we now reposition widgets after scrolling too.
There was a related problem, which was that widgets expect the graphics context to be set up for
root-relative painting. To fix this, adjust the CTM and the paintRect when the widget's frameRect
is in a different coordinate system to the painting offset.
Test: plugins/mouse-events-fixedpos.html
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Update widget positions, to handle widgets in fixed position elements, but only if we're not already inside of layout.
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::translate): Add a translate() convenience method that takes a FloatSize.
- platform/graphics/IntSize.h: (WebCore::IntSize::isZero): Add a convenience method for testing for a zero size.
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Adjust a comment.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Detect when the widget's frame is in a different coordinate system to painting, and adjust the CTM and paintRect in that case.
- 11:54 AM Changeset in webkit [53636] by
-
- 3 edits in trunk/WebKitTools
2010-01-21 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
https://bugs.webkit.org/show_bug.cgi?id=33356
White list unix_hacker_style names in WebKit/gtk/webkit because these
are used in the GTK+ API.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 11:38 AM Changeset in webkit [53635] by
-
- 7 edits in trunk
2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945
- platform/qt/Skipped:
2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945
- Api/qwebsecurityorigin.cpp: (qt_drt_setDomainRelaxationForbiddenForURLScheme):
2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:36 AM Changeset in webkit [53634] by
-
- 4 edits in trunk/WebCore
[Android] bindings/v8/NPV8Object.cpp does not compile on Android
https://bugs.webkit.org/show_bug.cgi?id=33608
Patch by Andrei Popescu <andreip@google.com> on 2010-01-21
Reviewed by David Levin.
Use the standard WebKit header in bridge/npruntime.h.
Include PlatformBridge.h instead of ChroimiumBridge.h.
Add popupsAllowed() method to PlatformBridge.h on Android.
Add ARRAYSIZE_UNSAFE to PlatformBridge.h on Android.
No new tests, fixing the build.
- bindings/v8/NPV8Object.cpp:
(_NPN_Evaluate):
- bindings/v8/NPV8Object.h:
- platform/android/PlatformBridge.h:
- 11:01 AM Changeset in webkit [53633] by
-
- 1 edit1 add in trunk/WebCore
2010-01-21 Andrei Popescu <andreip@google.com>
Reviewed by David Levin.
Add PlatformBridge.h header and a typedef to give ChromiumBridge a new name: PlatformBridge.
https://bugs.webkit.org/show_bug.cgi?id=33917
No new tests needed, this is just to allow other methods to call ChromiumBridge
using the new 'PlatformBridge' name.
- platform/chromium/PlatformBridge.h: Added.
- 10:39 AM Changeset in webkit [53632] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r53625.
Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
https://bugs.webkit.org/show_bug.cgi?id=30106
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderTrack):
- 10:36 AM WebKit Team edited by
- I am no longer with Qt (diff)
- 10:24 AM Changeset in webkit [53631] by
-
- 3 edits in trunk/LayoutTests
2010-01-21 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Carlson.
Start the test when the video element loads, which is less prone
to occasional cases where document.load is fired after video.load.
- media/video-source-error-no-candidate.html:
- media/video-source-error-no-candidate-expected.txt:
- 10:07 AM Changeset in webkit [53630] by
-
- 3 edits in trunk/WebCore
[Android] bindings/v8/V8DOMWrapper.h[cpp] are missing guards for XPATH and XSLT features
https://bugs.webkit.org/show_bug.cgi?id=33944
Patch by Andrei Popescu <andreip@google.com> on 2010-01-21
Reviewed by David Levin.
Inside V8DOMWrapper.h[cpp], the code for XPATH and XSLT features is not guarded
by the appropriate #if ENABLE(feature) macros. Add the missing guards.
V8DOMWrapper.cpp includes ChromiumBridge.h for no reason. Remove the include.
No new tests needed, functionality not changed.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/V8DOMWrapper.h:
- 9:46 AM Changeset in webkit [53629] by
-
- 4 edits2 adds in trunk
2010-01-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Intermittent crash when media element is adopted by another document
https://bugs.webkit.org/show_bug.cgi?id=33919
rdar://problem/7557527
Test: media/adopt-node-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Unregister for document callbacks. (WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Register for document callbacks.
- html/HTMLMediaElement.h:
2010-01-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Intermittent crash when media element is adopted by another document
https://bugs.webkit.org/show_bug.cgi?id=33919
rdar://problem/7557527
This test does not always crash the un-patched version of WebKit because
the crash is so timing-dependant.
- media/adopt-node-crash-expected.txt: Added.
- media/adopt-node-crash.html: Added.
- 9:21 AM Changeset in webkit [53628] by
-
- 2 edits in trunk/WebCore
More Windows build fixing
- WebCore.vcproj/WebCore.vcproj: Copy bridge/jsc in the post-build
event of all configurations, not just Debug.
- 8:05 AM Changeset in webkit [53627] by
-
- 2 edits in trunk/WebCore
[Qt] Fix incorrect dependency to QtXmlPatterns in generated include/QtWebKit/QtWebKit header
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.
The generated file includes QtXmlPatterns/QtXmlPatterns, which is neither used/required by
the public QtWebKit API nor will it be available if Qt is configured with -no-xmlpatterns.
- WebCore.pro: Trick syncqt to believe that xmlpatterns is not a dependency, so that it's not
included in the generated file. It'll still be used and linked to with this trick.
- 7:42 AM Changeset in webkit [53626] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Copy BridgeJSC.h to generated headers on Windows
No new tests, build fix only.
- WebCore.vcproj/WebCore.vcproj:
- 7:01 AM Changeset in webkit [53625] by
-
- 13 edits in trunk/WebCore
2010-01-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
https://bugs.webkit.org/show_bug.cgi?id=30106
No new tests, only dead code was removed.
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::doSeek):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/wince/MediaPlayerPrivateWince.h:
- 6:54 AM Changeset in webkit [53624] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Oops, refix previous submit (patch conflict not resolved correctly)
- 6:52 AM Changeset in webkit [53623] by
-
- 2 edits in trunk/WebCore
[Qt] Simplify the qmake code for freezing QtWebKit on Symbian.
Patch by Iain Campbell <iain.campbell@accenture.com> on 2010-01-21
Reviewed by Simon Hausmann.
- WebCore.pro:
- 5:49 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:42 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:08 AM Changeset in webkit [53622] by
-
- 2 edits in trunk/WebCore
Unreviewed speculative build fix for Windows.
Adds missing include path for JSCBridge.h on Windows, added in http://trac.webkit.org/changeset/53620
No new tests, build fix only.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 4:30 AM Changeset in webkit [53621] by
-
- 5 edits in trunk/WebCore
Unreviewed build fix.
Adds missing include path for JSCBridge.h, added in http://trac.webkit.org/changeset/53620
No new tests, build fix only.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 3:52 AM Changeset in webkit [53620] by
-
- 7 edits1 copy1 move1 add in trunk/WebCore
Move bridge interfaces Field, Class, Instance and Array from Bridge to BridgeJSC
https://bugs.webkit.org/show_bug.cgi?id=33589
Reviewed by David Levin.
These interfaces use JSC-specific types, so are moved out of Bridge.h to allow the file to
be used with both JSC and V8.
No new tests, refactoring only.
- Android.jscbindings.mk: Modified. Removed Bridge.cpp and added BridgeJSC.cpp
- GNUmakefile.am: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
- WebCore.pro: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
- WebCore.xcodeproj/project.pbxproj: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
- WebCoreSources.bkl: Modified. Removed Bridge.cpp and added BridgeJSC.cpp
- bridge/Bridge.cpp: Removed.
- bridge/Bridge.h: Modfied. Moved Field, Class, Instance and Array interfaces to BridgeJSC.h
- bridge/jsc: Added.
- bridge/jsc/BridgeJSC.cpp: Copied from WebCore/bridge/Bridge.cpp.
- bridge/jsc/BridgeJSC.h: Copied from WebCore/bridge/Bridge.h.
- 2:25 AM Changeset in webkit [53619] by
-
- 3 edits in trunk/WebCore
Fixes style in WebCore/bridge/jni/JNIBridge
https://bugs.webkit.org/show_bug.cgi?id=33914
Reviewed by David Levin.
No new tests, style fixes only.
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIBridge.h:
- 1:49 AM Changeset in webkit [53618] by
-
- 15 edits2 adds in trunk
[Qt] Implement GraphicsLayer for accelerated layer compositing
https://bugs.webkit.org/show_bug.cgi?id=33514
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Antti Koivisto.
.:
- WebKit.pri: Addded compile flags to enable accelerated compositing
on versions higher than 4.5
WebCore:
No new tests: tests in LayoutTests/compositing are now relevant for
QtWebkit!
- WebCore.pro: added accelerated-compositing related files
- platform/graphics/GraphicsLayer.h: define Qt-specific implementation of GraphicsLayer
- platform/graphics/qt/GraphicsLayerQt.cpp: Added.
(WebCore::GraphicsLayerQtImpl::): Implementation of GraphicsLayer with
a QGraphicsItem
(WebCore::GraphicsLayerQtImpl::ContentData::ContentData): save
pixmap/color info for directly composited content
(WebCore::GraphicsLayerQtImpl::State::State): save info for syncing
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): ctor
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl): dtor
(WebCore::GraphicsLayerQtImpl::setBaseTransform): set Qt
transformation in the way WebCore wants it
(WebCore::GraphicsLayerQtImpl::opaqueArea): calculate opaque area
based on info we have
(WebCore::GraphicsLayerQtImpl::boundingRect): reimp QGraphicsItem
(WebCore::GraphicsLayerQtImpl::paint): reimp QGraphicsItem
(WebCore::GraphicsLayerQtImpl::drawContents): draw HTML/Pixmap/Color
(WebCore::GraphicsLayerQtImpl::notifyChange): let WebCore know
something has changed
(WebCore::GraphicsLayerQtImpl::flushChanges): Make the changes appear
on screen by setting them to QGraphicsItems
(WebCore::GraphicsLayerQtImpl::notifyAnimationStarted): let WebCore
know the QAnimation started
(WebCore::GraphicsLayerQt::GraphicsLayerQt): ctor
(WebCore::GraphicsLayerQt::~GraphicsLayerQt): dtor
(WebCore::GraphicsLayer::create): hook for WebCore to know we're
implementing compositing
(WebCore::GraphicsLayer::compositingCoordinatesOrientation): hook for
WebCore to know we use a top-down system
(WebCore::GraphicsLayerQt::setNeedsDisplay): update the display
(WebCore::GraphicsLayerQt::setNeedsDisplayInRect): udpate part of the
display
(WebCore::GraphicsLayerQt::setName): reimp
(WebCore::GraphicsLayerQt::setParent): reimp
(WebCore::GraphicsLayerQt::setChildren): reimp
(WebCore::GraphicsLayerQt::addChild): reimp
(WebCore::GraphicsLayerQt::addChildAtIndex): reimp
(WebCore::GraphicsLayerQt::addChildAbove): reimp
(WebCore::GraphicsLayerQt::addChildBelow): reimp
(WebCore::GraphicsLayerQt::replaceChild): reimp
(WebCore::GraphicsLayerQt::removeFromParent): reimp
(WebCore::GraphicsLayerQt::setMaskLayer): reimp
(WebCore::GraphicsLayerQt::setPosition): reimp
(WebCore::GraphicsLayerQt::setAnchorPoint): reimp
(WebCore::GraphicsLayerQt::setSize): reimp
(WebCore::GraphicsLayerQt::setTransform): reimp
(WebCore::GraphicsLayerQt::setChildrenTransform): reimp
(WebCore::GraphicsLayerQt::setPreserves3D): reimp
(WebCore::GraphicsLayerQt::setMasksToBounds): reimp
(WebCore::GraphicsLayerQt::setDrawsContent): reimp
(WebCore::GraphicsLayerQt::setBackgroundColor): reimp
(WebCore::GraphicsLayerQt::clearBackgroundColor): reimp
(WebCore::GraphicsLayerQt::setContentsOpaque): reimp
(WebCore::GraphicsLayerQt::setBackfaceVisibility): reimp
(WebCore::GraphicsLayerQt::setOpacity): reimp
(WebCore::GraphicsLayerQt::setContentsRect): reimp
(WebCore::GraphicsLayerQt::setContentsToImage): reimp
(WebCore::GraphicsLayerQt::setContentsBackgroundColor): reimp
(WebCore::GraphicsLayerQt::setGeometryOrientation): reimp
(WebCore::GraphicsLayerQt::setContentsOrientation): reimp
(WebCore::GraphicsLayerQt::distributeOpacity): reimp
(WebCore::GraphicsLayerQt::accumulatedOpacity): reimp
(WebCore::GraphicsLayerQt::syncCompositingState): reimp
(WebCore::GraphicsLayerQt::nativeLayer): reimp (QGraphicsItem*)
(WebCore::GraphicsLayerQt::platformLayer): reimp (QGraphicsItem*)
(WebCore::solveEpsilon): copy from AnimationBase.cpp
(WebCore::solveCubicBezierFunction): copy from AniamtionBase.cpp
(WebCore::applyTimingFunction): use WebCore's timing and not Qt's
(WebCore::webkitAnimationToQtAnimationValue): safely figure out
animation values
(WebCore::AnimationQtBase::AnimationQtBase): base class for Qt-based
Webcore-initiated animations
(WebCore::AnimationQtBase::updateState): notify when an animation
starts
(WebCore::AnimationQtBase::duration): reimp QAbstractAnimation
(WebCore::AnimationQt:::AnimationQtBase):
(WebCore::AnimationQt::updateCurrentTime): realize keyframes from
progress
(WebCore::TransformAnimationQt::TransformAnimationQt): ctor
(WebCore::TransformAnimationQt::~TransformAnimationQt): dtor
(WebCore::TransformAnimationQt::applyFrame): set the actual QTransform
based on WebCore TransformOperations
(WebCore::TransformAnimationQt::updateState): change cache mode
(WebCore::OpacityAnimationQt::OpacityAnimationQt):
(WebCore::OpacityAnimationQt::applyFrame): change item's opacity
(WebCore::OpacityAnimationQt::updateState):
(WebCore::GraphicsLayerQt::addAnimation): convert WebCore Animation to
Qt Animation
(WebCore::GraphicsLayerQt::removeAnimationsForProperty):
(WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
(WebCore::GraphicsLayerQt::pauseAnimation):
(WebCore::GraphicsLayerQt::suspendAnimations):
(WebCore::GraphicsLayerQt::resumeAnimations):
- platform/graphics/qt/GraphicsLayerQt.h: Added.
- platform/qt/QWebPageClient.h: virtual functions for QGraphicsWebView
compositing
(QWebPageClient::setRootGraphicsLayer): let QGraphicsWebView know that
compositing has started/ended
(QWebPageClient::markForSync): let QGraphicsWebView know the
compositing layers need to sync, either soon or with the next update
WebKit/qt:
Here we have the QGraphicsWebView support for accelerated compositing
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewOverlay::q): access to container object
(QGraphicsWebViewOverlay::boundingRect): overlay has same rect as the
webview
(QGraphicsWebViewOverlay::paint): paint everything but the contents
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): some vars needed
for accelerated compositing
(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebViewPrivate::setRootGraphicsLayer): make sure we have a
scrollbar overlay, and that the new graphics layer is parented by the
web-view
(QGraphicsWebViewPrivate::markForSync): flush changes at earliest
convenience or during the next draw
(QGraphicsWebViewPrivate::updateCompositingScrollPosition): sync the
position of the compositing layer with the scroll position
(QGraphicsWebViewPrivate::syncLayers): flush changes now
(QGraphicsWebViewPrivate::scroll): make sure we also move the
compositing layer
(QGraphicsWebViewPrivate::update): also update the overlay if needed
(QGraphicsWebView::QGraphicsWebView): initialize overlay with 0
(QGraphicsWebView::paint): paint only contents if we have an overlay,
sync the compositing layers now if needed
(QGraphicsWebView::setPage): also clean up the compositing
(QGraphicsWebView::updateGeometry): also update overlay geo
(QGraphicsWebView::setGeometry): also update overlay geo
- Api/qgraphicswebview.h: reimp compositing stuff from QWebPageClient
- Api/qwebsettings.cpp: init new settings flag for compositing as
false
(QWebSettingsPrivate::apply): apply new settings flag for compositing
(QWebSettings::QWebSettings):
- Api/qwebsettings.h: new settings flag for compositing
- Api/qwebview.cpp:
(QWebView::setPage): qwebview doesn't support compositing: always false
- QGVLauncher/main.cpp:
(WebView::WebView): some more cmdline arguments + compositing
(MainWindow::init): some more cmdline arguments
(main): ditto
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::attachRootGraphicsLayer): reimp for
accel-compositing
(WebCore::ChromeClientQt::setNeedsOneShotDrawingSynchronization):
reimp for accel compositing
(WebCore::ChromeClientQt::scheduleCompositingLayerSync): reimp for
accel compositing
- WebCoreSupport/ChromeClientQt.h: reimps for accel compositing
- 1:43 AM Changeset in webkit [53617] by
-
- 3 edits in trunk/WebCore
2010-01-13 Philippe Normand <pnormand@igalia.com>
Reviewed by Oliver Hunt.
[GTK] handle media redirections
https://bugs.webkit.org/show_bug.cgi?id=33539
Media redirections support.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mediaLocationChanged): (WebCore::MediaPlayerPrivate::loadNextLocation):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::pipelineReset):
- 1:27 AM Changeset in webkit [53616] by
-
- 6 edits in trunk
No review, rolling out 53615 as it causes two
crashes on the bot.
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::createWindow):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):
LayoutTests:
- platform/qt/Skipped:
- 1:12 AM Changeset in webkit [53615] by
-
- 6 edits in trunk
2010-01-21 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Qt DRT: respect window.close() and window.closed()
Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().
This fixes the following tests:
plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html
- platform/qt/Skipped:
2010-01-21 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Qt DRT: respect window.close() and window.closed()
Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().
This fixes the following tests:
plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
- 1:02 AM Changeset in webkit [53614] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.
Remove qWait() of the test when possible.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadFinished):
(tst_QWebPage::database):
(tst_QWebPage::testEnablePersistentStorage):
(tst_QWebPage::errorPageExtension):
(tst_QWebPage::screenshot):
- 12:42 AM Changeset in webkit [53613] by
-
- 3 edits in trunk/WebKit/qt
Prospective build fix for the Qt build.
Fix compilation against Qt without WebKit support by not including QtWebKit/QWebView
but widget.h instead and instantiating QWebView through a typedef, to ensure we're using
our locally built WebKit.
- tests/hybridPixmap/widget.h:
- tests/hybridPixmap/widget.ui:
- 12:37 AM Changeset in webkit [53612] by
-
- 4 edits in trunk/LayoutTests
2010-01-20 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[Gtk] media/video-currentTime-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33897
Refactored the test to use the "seeked" event.
- media/video-currentTime-set-expected.txt:
- media/video-currentTime-set.html:
- platform/gtk/Skipped:
- 12:25 AM Changeset in webkit [53611] by
-
- 5 edits10 adds in trunk
WebCore: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
Allows accesing QPixmap and QImage based arguments from Qt signals,
slots and properties
This is done by an intermediate object that can be turned into
web-based objects by calling either toHTMLImageElement() or
toDataURL()
https://bugs.webkit.org/show_bug.cgi?id=32461
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.
Tests are in WebKit/qt/tests/hybridPixmap
- WebCore.pro:
- bridge/qt/qt_pixmapruntime.cpp: Added.
(JSC::Bindings::QtPixmapWidthField::name): "width"
(JSC::Bindings::QtPixmapWidthField::valueFromInstance): width of
pixmap
(JSC::Bindings::QtPixmapWidthField::setValueToInstance): nothing
(JSC::Bindings::QtPixmapHeightField::name): "height"
(JSC::Bindings::QtPixmapHeightField::valueFromInstance): height of
pixmap
(JSC::Bindings::QtPixmapHeightField::setValueToInstance): nothing
(JSC::Bindings::QtPixmapRuntimeMethod::numParameters): 0
(JSC::Bindings::QtPixmapCreateElementMethod::name): toHTMLImageElement
(JSC::Bindings::QtPixmapCreateElementMethod::invoke): creates an HTML
element from the QPixmap
(JSC::Bindings::QtPixmapToDataUrlMethod::name): "toDataURL"
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke): encodes the image to
a base64 data url
(JSC::Bindings::QtPixmapToStringMethod::name): "toString"
(JSC::Bindings::QtPixmapToStringMethod::invoke): [Qt Native Pixmap
w,h]
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
runtime-object broilerplate
(JSC::Bindings::QtPixmapRuntimeObjectImp::classInfo): ditto
(JSC::Bindings::QtPixmapRuntimeObjectImp::QtPixmapRuntimeObjectImp):
ditto
(JSC::Bindings::): ditto
(JSC::Bindings::QtPixmapClass::QtPixmapClass): class for the
intermediate pixmap-holder
(JSC::Bindings::QtPixmapInstance::getClass): ditto
(JSC::Bindings::QtPixmapInstance::invokeMethod): ditto
(JSC::Bindings::QtPixmapClass::methodsNamed): toHTMLImageElement,
toDataURL
(JSC::Bindings::QtPixmapClass::fieldNamed): width, height
(JSC::Bindings::QtPixmapInstance::getPropertyNames):
toHTMLImageElement, toDataURL, width, height
(JSC::Bindings::QtPixmapInstance::defaultValue): nothing
(JSC::Bindings::QtPixmapInstance::valueOf): toString
(JSC::Bindings::data): holds a QVariant of type QImage/QPixmap
(JSC::Bindings::QtPixmapInstance::width): width of the image/pixmap
(JSC::Bindings::QtPixmapInstance::height): height of the image/pixmap
(JSC::Bindings::QtPixmapInstance::toPixmap): converts to a QPixmap
(JSC::Bindings::QtPixmapInstance::toImage): converts to a QImage
(JSC::Bindings::QtPixmapInstance::variantFromObject): makes sure this
is the right type of object, and creates a QVariant
(JSC::Bindings::QtPixmapInstance::createRuntimeObject): creates a new
intermediate pixmap holder from a QVariant
(JSC::Bindings::QtPixmapInstance::canHandle): returns true if a
QPixmap/QImage is required
- bridge/qt/qt_pixmapruntime.h: Added.
- bridge/qt/qt_runtime.cpp: hooks for the bridge
(JSC::Bindings::convertValueToQVariant): handle QPixmap/QImage if the
object is the intermediate pixmap holder or an HTMLImageElement
(JSC::Bindings::convertQVariantToValue): creates the intermediate
object from a QVariant of type QImage/QPixmap
WebKit/qt: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.
- tests/hybridPixmap: Added.
- tests/hybridPixmap/hybridPixmap.pro: Added.
- tests/hybridPixmap/resources.qrc: Added.
- tests/hybridPixmap/test.html: Added.
- tests/hybridPixmap/tst_hybridPixmap.cpp: Added.
(tst_hybridPixmap::tst_hybridPixmap): tests most of the use cases for
hybrid pixmap/image manipulation
(tst_hybridPixmap::init): QTestLib initialization
(tst_hybridPixmap::cleanup): QTestLib cleanup
(tst_hybridPixmap::hybridPixmap): run the html file
- tests/hybridPixmap/widget.cpp: Added.
(Widget::Widget):
(Widget::refreshJS):
(Widget::start):
(Widget::completeTest):
(Widget::setPixmap):
(Widget::pixmap):
(Widget::setImage):
(Widget::image):
(Widget::~Widget):
(Widget::changeEvent):
(Widget::compare):
(Widget::imageSlot):
(Widget::pixmapSlot):
(Widget::randomSlot):
- tests/hybridPixmap/widget.h: Added.
- tests/hybridPixmap/widget.ui: Added.
- tests/tests.pro:
- 12:10 AM Changeset in webkit [53610] by
-
- 9 edits in trunk
2010-01-21 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Custom select popups.
https://bugs.webkit.org/show_bug.cgi?id=33418
Optimization of the WebCore support to combobox popup delegate.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::itemType):
- platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::): (WebCore::QtAbstractWebPopup::itemText): (WebCore::QtAbstractWebPopup::itemToolTip): (WebCore::QtAbstractWebPopup::itemIsEnabled): (WebCore::QtAbstractWebPopup::itemCount): (WebCore::QtAbstractWebPopup::view): (WebCore::QtAbstractWebPopup::geometry): (WebCore::QtAbstractWebPopup::currentIndex): (WebCore::QtAbstractWebPopup::font):
2010-01-21 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Custom select popups.
https://bugs.webkit.org/show_bug.cgi?id=33418
Adjusting QtFallbackWebPopupCombo to the changes in WebCore layer.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo): (WebCore::QtFallbackWebPopupCombo::showPopup): (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::hide): (WebCore::QtFallbackWebPopup::populate):
- WebCoreSupport/QtFallbackWebPopup.h:
Jan 20, 2010:
- 11:50 PM Changeset in webkit [53609] by
-
- 6 edits in trunk/WebKitTools
2010-01-20 Eric Seidel <eric@webkit.org>
No review, rolling out r53593.
http://trac.webkit.org/changeset/53593
https://bugs.webkit.org/show_bug.cgi?id=33496
Re-rollout this patch, the commit-queue should not have landed
it again, but it did due to land-diff and rollout both not
clearing flags.
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/scm.py:
- Scripts/webkitpy/scm_unittest.py:
- 11:35 PM Changeset in webkit [53608] by
-
- 6 edits in trunk/LayoutTests
2010-01-21 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix incorrect close tags.
- fast/html/script-tests/article-element.js:
- fast/html/script-tests/aside-element.js:
- fast/html/script-tests/footer-element.js:
- fast/html/script-tests/header-element.js:
- fast/html/script-tests/section-element.js:
- 11:22 PM Changeset in webkit [53607] by
-
- 25 edits in trunk
2010-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Stylesheet href property shows redirected URL unlike other browsers
https://bugs.webkit.org/show_bug.cgi?id=33683
Test whether the href property of style sheets contains the original or
final URL of the redirect chain that lead to the style sheet.
I couldn't figure out how to test the XSLStyleSheet parts of this
change. There didn't seem to be DOM bindings for the href property
here. If I missed it, please let me know.
- http/tests/security/stylesheet-href-redirect-expected.txt: Added.
- http/tests/security/stylesheet-href-redirect.html: Added.
2010-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Stylesheet href property shows redirected URL unlike other browsers
https://bugs.webkit.org/show_bug.cgi?id=33683
Teach StyleSheet the difference between original and final URLs in
redirect chains. Unfortunately, StyleSheet needs to know both of these
URLs. The original URL is needed for the href property and the final
URL is needed as the baseURL.
This change required touching a lot of lines of code because we need to
plumb this information to the StyleSheet object. I audited all
existing clients of href() and setHref() to see whether they wanted the
original or final URLs. I then updated the clients (except the JS
bindings themselves) to use the correct accessor.
Test: http/tests/security/stylesheet-href-redirect.html
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent):
- css/CSSImportRule.h:
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::create): (WebCore::CSSStyleSheet::createInline): Added a new constructor to deal with "inline" style sheets that don't have a distinct original and final URL.
- css/StyleBase.cpp: (WebCore::StyleBase::baseURL): This code wants to use the final URL, not the original URL. Updated it to grab the baseURL directly.
- css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
- css/StyleSheet.h: (WebCore::StyleSheet::href): (WebCore::StyleSheet::setBaseURL): This function really just updates the base URL of the style sheet, so I made it more explicit. (WebCore::StyleSheet::putativeBaseURL): We need an accessor for the base URL, but baseURL is already taken.
- dom/Document.cpp: (WebCore::Document::updateBaseURL): (WebCore::Document::pageUserSheet): (WebCore::Document::pageGroupUserSheets): (WebCore::Document::elementSheet): (WebCore::Document::mappedElementSheet):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet):
- dom/ProcessingInstruction.h:
- dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/HTMLLinkElement.h:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::checkNotify): This code now passes both the original and final URL into setCSSStyleSheet so that the style sheet can have both.
- loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet): (WebCore::CachedResourceClient::setXSLStyleSheet):
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::checkNotify): I don't have any direct evidence that we need to change the XSLStyleSheet behavior, which is why I wasn't able to add a test for the behavior. However, the objects are parallel enough that it seemed like the right thing to do.
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): (WebCore::XSLImportRule::loadSheet):
- xml/XSLImportRule.h:
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createEmbedded):
- xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::parseString): (WebCore::XSLStyleSheet::loadChildSheets):
- xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
- xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltStylesheetPointer):
- xml/XSLTProcessorQt.cpp: (WebCore::XSLTProcessor::transformToString):
- 11:20 PM Changeset in webkit [53606] by
-
- 3 edits in trunk/LayoutTests
2010-01-21 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix a FAIL test by a wrong input.
- fast/forms/input-valueasdate-date-expected.txt:
- fast/forms/script-tests/input-valueasdate-date.js:
- 11:06 PM Changeset in webkit [53605] by
-
- 65 edits in trunk/LayoutTests
Bug 31865 - Re-do ruby layout tests to use only Latin characters
(https://bugs.webkit.org/show_bug.cgi?id=31865, first patch)
Reviewed by Eric Seidel.
Re-did pixel layout tests for ruby since non-Latin scripts apparently
cause issues on other platforms.
- fast/ruby/ruby-empty-rt.html:
- fast/ruby/ruby-length.html:
- fast/ruby/ruby-run-break.html:
- fast/ruby/ruby-runs-spans.html:
- fast/ruby/ruby-runs.html:
- fast/ruby/ruby-simple-rp.html:
- fast/ruby/ruby-simple.html:
- fast/ruby/ruby-trailing.html:
- fast/ruby/rubyDOM-insert-rt.html:
- fast/ruby/rubyDOM-insert-text1.html:
- fast/ruby/rubyDOM-insert-text2.html:
- fast/ruby/rubyDOM-insert-text3.html:
- fast/ruby/rubyDOM-remove-rt1.html:
- fast/ruby/rubyDOM-remove-rt2.html:
- fast/ruby/rubyDOM-remove-text1.html:
- fast/ruby/rubyDOM-remove-text2.html:
- platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
- platform/mac/fast/ruby/ruby-empty-rt-expected.png:
- platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
- platform/mac/fast/ruby/ruby-length-expected.checksum:
- platform/mac/fast/ruby/ruby-length-expected.png:
- platform/mac/fast/ruby/ruby-length-expected.txt:
- platform/mac/fast/ruby/ruby-run-break-expected.checksum:
- platform/mac/fast/ruby/ruby-run-break-expected.png:
- platform/mac/fast/ruby/ruby-run-break-expected.txt:
- platform/mac/fast/ruby/ruby-runs-expected.checksum:
- platform/mac/fast/ruby/ruby-runs-expected.png:
- platform/mac/fast/ruby/ruby-runs-expected.txt:
- platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
- platform/mac/fast/ruby/ruby-runs-spans-expected.png:
- platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
- platform/mac/fast/ruby/ruby-simple-expected.checksum:
- platform/mac/fast/ruby/ruby-simple-expected.png:
- platform/mac/fast/ruby/ruby-simple-expected.txt:
- platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
- platform/mac/fast/ruby/ruby-simple-rp-expected.png:
- platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
- platform/mac/fast/ruby/ruby-trailing-expected.checksum:
- platform/mac/fast/ruby/ruby-trailing-expected.png:
- platform/mac/fast/ruby/ruby-trailing-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
- 9:58 PM Changeset in webkit [53604] by
-
- 2 edits in trunk/WebCore
2010-01-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Use xmlStrdup instead of strdup for consistency in Libxml2.
https://bugs.webkit.org/show_bug.cgi?id=33935
Remove the direct use of strdup.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::): (WebCore::XMLTokenizer::error):
- 9:36 PM Changeset in webkit [53603] by
-
- 3 edits in trunk/WebCore
2010-01-20 Oliver Hunt <oliver@apple.com>
Reviewed by Dan Bernstein.
Insufficient repaint issues with html embedded in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16318
Final part of fix -- now we render the selection rect of list
markers in a transformed context.
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::localSelectionRect): (WebCore::RenderListMarker::paint):
- rendering/RenderListMarker.h:
- 9:26 PM Changeset in webkit [53602] by
-
- 2 edits in trunk/LayoutTests
2010-01-20 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
http/tests/xmlhttprequest/cross-origin-cookie-storage.html failed on Snow Leopard Intel Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33742
- platform/mac-snowleopard/Skipped: Skip this for now to keep the bots green.
- 9:05 PM Changeset in webkit [53601] by
-
- 3 edits2 deletes in trunk
2010-01-20 Daniel Bates <dbates@webkit.org>
No review, rolling out 53591.
http://trac.webkit.org/changeset/53591
https://bugs.webkit.org/show_bug.cgi?id=29564
Rolling out the change committed in change set 53591
<http://trac.webkit.org/changeset/53591> because it caused
a regression of test /fast/replaced/table-percent-height.html
on the Qt bot.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):
2010-01-20 Daniel Bates <dbates@webkit.org>
No review, rolling out 53591.
http://trac.webkit.org/changeset/53591
https://bugs.webkit.org/show_bug.cgi?id=29564
Rolling out the change committed in change set 53591
<http://trac.webkit.org/changeset/53591> because it caused
a regression of test /fast/replaced/table-percent-height.html
on the Qt bot.
- fast/css/button-height-expected.txt: Removed.
- fast/css/button-height.html: Removed.
- 8:54 PM Changeset in webkit [53600] by
-
- 2 edits in trunk/WebCore
2010-01-20 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Disable the "seatbelt" coordinate validation functions in the
Skia graphics layer. We believe all the underlying bugs have
been fixed, but just in case we're being overly optimistic, this
leaves in the code for an easy revert.
https://bugs.webkit.org/show_bug.cgi?id=33908
Exercised by many layout tests.
- platform/graphics/skia/GraphicsContextSkia.cpp:
- 8:46 PM Changeset in webkit [53599] by
-
- 2 edits in trunk/LayoutTests
2010-01-20 Daniel Bates <dbates@webkit.org>
No review, rolling out 53594.
http://trac.webkit.org/changeset/53594
https://bugs.webkit.org/show_bug.cgi?id=33936
Note, there still is an issue on GTK related to the rendering of
button heights. But we are rolling out this change since
we're going to rollout the change committed in change set 53591
<http://trac.webkit.org/changeset/53591> because r53591 caused a
regression.
- platform/gtk/Skipped:
- 8:39 PM Changeset in webkit [53598] by
-
- 7 edits in trunk
2010-01-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=date.
https://bugs.webkit.org/show_bug.cgi?id=33911
Add setter tests to input-valueasdate-date.js, and update the
expectation.
- fast/forms/input-valueasdate-date-expected.txt:
- fast/forms/script-tests/input-valueasdate-date.js:
2010-01-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=date.
https://bugs.webkit.org/show_bug.cgi?id=33911
Introduce ISODateTime::setMillisecondsSinceEpochForDate() and add Date
type support to ISODateTime::toString().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueAsDate):
- html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDate): (WebCore::ISODateTime::toString):
- html/ISODateTime.h:
- 8:23 PM Changeset in webkit [53597] by
-
- 3 edits4 adds in trunk
2010-01-20 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Touch Events are not sent to iframes
https://bugs.webkit.org/show_bug.cgi?id=33894
Testcase to verify that touch events are sent to iframes when the main frame document does not have any touch event listeners installed.
- fast/events/touch/resources: Added.
- fast/events/touch/resources/touch-inside-iframe2.html: Added.
- fast/events/touch/touch-inside-iframe-expected.txt: Added.
- fast/events/touch/touch-inside-iframe.html: Added.
2010-01-20 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Touch Events are not sent to iframes
https://bugs.webkit.org/show_bug.cgi?id=33894
Fix the touch event handler so it does not bail out early if the main frame document does not have any touch listeners registered, as there may be embedded iframes that have registered for touch events.
Test: fast/events/touch/touch-inside-iframe.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Instead of looking at the document of the main frame to see if touch event listeners are registered, look at the document of the target element to account for iframes.
- 8:07 PM Changeset in webkit [53596] by
-
- 3 edits2 adds in trunk
2010-01-20 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
Remove an assertion that is not valid in some detached iframes cases.
https://bugs.webkit.org/show_bug.cgi?id=33827
- http/tests/appcache/detached-iframe-expected.txt: Added.
- http/tests/appcache/detached-iframe.html: Added.
2010-01-20 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
Remove an assertion that is not valid in some detached iframes cases.
https://bugs.webkit.org/show_bug.cgi?id=33827
Test: http/tests/appcache/detached-iframe.html
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache):
- 7:49 PM Changeset in webkit [53595] by
-
- 22 edits in trunk/WebCore
2010-01-20 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
Refactoring and plumbing to get the HTML5 SQL Database API accessible to
web workers. No new functionality is exposed yet; this just gets the
infrastructure in place. It touches a lot of files in small ways; here
are the main changes:
1) Database members and methods move from Document up to
ScriptExecutionContext. Each of Document and WorkerContext must
implement a few virtual methods where the Database code requires
differentiation.
2) Worker thread shutdown got changed a bunch to handle Database cleanup
and thread synchronization issues. Database cleanup tasks need to post
some cleanup tasks to the JavaScript thread. However, since database
cleanup may happen due to the destruction of the WorkerThread, I added a
handshake [involving WorkerThreadShutdownStartTask,
WorkerThreadShutdownFinishTask, and a DatabaseTaskSynchronizer] between
the Database thread and WorkerThread that cleans up all the Database
stuff before the WorkerThread's runLoop can exit.
3) The runtime enabler for the Database moved to a static variable
accessible through Database::isAvailable, following the model used by
WebSocket.
4) Worker threads don't run their JavaScript on the Main thread, so
Database code that differentiated between the Main thread and the
Database thread now need to deal with a third possibility.
5) Most of the other changes have to do with having a
ScriptExecutionContext pointer instead of a Document pointer when
dealing with a Database. In many cases it's just a string replacement,
but in some it required the creation of a new virtual function [e.g.
databaseExceededQuota, isDatabaseReadOnly]
No new tests; in a future patch I'll add JSC and V8 bindings and new
layout tests to exercise them.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::OpenDatabaseEnabled):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::isDatabaseReadOnly): (WebCore::Document::databaseExceededQuota): (WebCore::Document::isContextThread):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::databaseThread): (WebCore::ScriptExecutionContext::addOpenDatabase): (WebCore::ScriptExecutionContext::removeOpenDatabase): (WebCore::ScriptExecutionContext::stopDatabases):
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::setHasOpenDatabases): (WebCore::ScriptExecutionContext::hasOpenDatabases): (WebCore::ScriptExecutionContext::Task::isCleanupTask):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- storage/Database.cpp: (WebCore::Database::setIsAvailable): (WebCore::Database::isAvailable): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::DerefContextTask::create): (WebCore::DerefContextTask::performTask): (WebCore::DerefContextTask::isCleanupTask): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::Database::markAsDeletedAndClose): (WebCore::ContextRemoveOpenDatabaseTask::create): (WebCore::ContextRemoveOpenDatabaseTask::performTask): (WebCore::ContextRemoveOpenDatabaseTask::isCleanupTask): (WebCore::ContextRemoveOpenDatabaseTask::ContextRemoveOpenDatabaseTask): (WebCore::Database::close): (WebCore::Database::performOpenAndVerify): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::DeliverPendingCallbackTask::create): (WebCore::DeliverPendingCallbackTask::performTask): (WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask): (WebCore::Database::scheduleTransactionCallback): (WebCore::Database::transactionClient): (WebCore::Database::transactionCoordinator): (WebCore::Database::tableNames): (WebCore::Database::securityOrigin):
- storage/Database.h: (WebCore::Database::scriptExecutionContext):
- storage/DatabaseTask.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::~DatabaseThread): (WebCore::DatabaseThread::requestTermination): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::unscheduleDatabaseTasks):
- storage/DatabaseThread.h:
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::getMaxSizeForDatabase):
- storage/DatabaseTracker.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
- storage/SQLTransactionClient.cpp: (WebCore::SQLTransactionClient::didCommitTransaction): (WebCore::SQLTransactionClient::didExecuteStatement): (WebCore::SQLTransactionClient::didExceedQuota):
- storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::TrackerRemoveOpenDatabaseTask::create): (WebCore::TrackerRemoveOpenDatabaseTask::performTask): (WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::getMaxSizeForDatabase):
- storage/chromium/SQLTransactionClientChromium.cpp: (WebCore::NotifyDatabaseChangedTask::create): (WebCore::NotifyDatabaseChangedTask::performTask): (WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask): (WebCore::SQLTransactionClient::didCommitTransaction): (WebCore::SQLTransactionClient::didExecuteStatement): (WebCore::SQLTransactionClient::didExceedQuota):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase): (WebCore::WorkerContext::isContextThread):
- workers/WorkerContext.h: (WebCore::WorkerContext::clearScript): (WebCore::WorkerContext::thread): (WebCore::WorkerContext::isDatabaseReadOnly): (WebCore::WorkerContext::databaseExceededQuota):
- workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::runInMode): (WebCore::WorkerRunLoop::Task::performTask):
- workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): (WebCore::WorkerThreadShutdownFinishTask::create): (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownFinishTask::isCleanupTask): (WebCore::WorkerThreadShutdownStartTask::create): (WebCore::WorkerThreadShutdownStartTask::performTask): (WebCore::WorkerThreadShutdownStartTask::isCleanupTask): (WebCore::WorkerThread::stop):
- 7:23 PM Changeset in webkit [53594] by
-
- 2 edits in trunk/LayoutTests
2010-01-20 Daniel Bates <dbates@webkit.org>
Unreviewed. Add failing test fast/css/button-height.html
to GTK Skipped file as we need to look into this.
See bug #33936 for more details.
- platform/gtk/Skipped:
- 7:09 PM Changeset in webkit [53593] by
-
- 6 edits in trunk/WebKitTools
2010-01-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-commit-queue status page is confusing
https://bugs.webkit.org/show_bug.cgi?id=33496
This should improve the status page by removing more Fail messages.
To do this, I re-factored the CommitQueue and the AbstractReviewQueues
to behave more like one another. This meant moving where the failure reporting was done.
Previously the AbstractReviewQueue always used the parent process to report the error,
while CommitQueue used the subprocess when possible, and the parent only reported errors
that we didn't know how to handle (bugs in the commit-queue itself).
Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block
in both implementations and required teaching handle_script_error in each to post Fail messages
to the status server instead of calling exit(1).
This will also make the style-queue share more bug posting logic with other queues:
https://bugs.webkit.org/show_bug.cgi?id=33871
- Scripts/webkitpy/commands/early_warning_system.py:
- Don't exit(1) as that will cause the calling queue to also report Fail to the status server. Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. _update_status_for_script_error knows how to post the Fail message to the status server.
- Teach _update_status_for_script_error how to post Fail messages to the status server.
- Scripts/webkitpy/commands/queues.py:
- Remove the try block from process_work_item since the caller already has one.
- Only CC watchers on failure to cut down on commit-queue generated mail.
- handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
- Abstract _format_script_error_output_for_bug to share code between all queues.
- The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
- Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
- Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
- handle_script_error now posts Fail instead of the try block in process_work_item handling it.
- Scripts/webkitpy/queueengine.py:
- QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
- Scripts/webkitpy/scm.py:
- Add new checkout_revision function.
- Scripts/webkitpy/scm_unittest.py:
- Test our new checkout_revision function.
- 6:41 PM Changeset in webkit [53592] by
-
- 12 edits4 adds in trunk
2010-01-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: Request-URI should not be empty when no tralling slash in host
https://bugs.webkit.org/show_bug.cgi?id=33689
- websocket/tests/handler_map.txt: Added. use websocket/tests/echo-location_wsh.py to handle request for ws://127.0.0.1:8880
- websocket/tests/script-tests/url-no-trailing-slash.js: Added.
- websocket/tests/url-no-trailing-slash-expected.txt: Added.
- websocket/tests/url-no-trailing-slash.html: Added.
2010-01-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: Request-URI should not be empty when no tralling slash in host
https://bugs.webkit.org/show_bug.cgi?id=33689
Test: websocket/tests/url-no-trailing-slash.html
- websockets/WebSocketHandshake.cpp: (WebCore::resourceName):
2010-01-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: Missing Request-URI, when no tralling slash in host
https://bugs.webkit.org/show_bug.cgi?id=33689
Update pywebsocket to 0.4.7.1, which supports alias for resource
name, so that we could test for ws://127.0.0.1:8880
- Scripts/run-webkit-tests:
- Scripts/run-webkit-websocketserver:
- pywebsocket/mod_pywebsocket/dispatch.py:
- pywebsocket/mod_pywebsocket/handshake.py:
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_dispatch.py:
- pywebsocket/test/test_handshake.py:
- 6:31 PM Changeset in webkit [53591] by
-
- 3 edits2 adds in trunk
2010-01-20 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Fixes an issue where the height of <button>- and
<input type="button">- elements are fixed to the height of the
button label font plus padding. That is, the CSS height property
is being ignored.
Instead, we should honor the user-specified height, if appropriate
for the platform and context. Notice, the Mac ports do not honor the
height for <input type="button"> elements unless a border and/or
background is also specified.
Test: fast/css/button-height.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::adjustButtonStyle):
2010-01-20 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
Tests that the user-specified height for <button>- and <input type="button">-
elements are honored, if appropriate for the platform and context.
- fast/css/button-height-expected.txt: Added.
- fast/css/button-height.html: Added.
- 6:23 PM Changeset in webkit [53590] by
-
- 3 edits2 adds in trunk
WebCore: Assertion failure calling history.pushState within popstate event handler.
https://bugs.webkit.org/show_bug.cgi?id=33830
Reviewed by Sam Weinig.
Test: fast/loader/stateobjects/pushstate-within-popstate-handler-assert.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::navigateWithinDocument): Remove the ASSERT and invalid part of the comment.
LayoutTests: Crash in Page::backForwardList when using History object from a detached window
<rdar://problem/7556252> and https://bugs.webkit.org/show_bug.cgi?id=33828
Reviewed by Sam Weinig.
- fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt: Added.
- fast/loader/stateobjects/state-api-on-detached-frame-crash.html: Added.
- 6:10 PM Changeset in webkit [53589] by
-
- 2 edits1 add in trunk/WebCore
2010-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
Crash on dispatching SVG mouse events
https://bugs.webkit.org/show_bug.cgi?id=33841
Return early SVGUseElement::instanceForShadowTreeElement if m_targetElementInstance is zero.
This only happens if the SVGUseElement has just been removed from the document and EventHandler
tries to dispatch a mouseout event to the corresponding SVGElementInstance. This is not testable
using DRT unfortunately, so we have to add another manual testcase for that.
Tests: manual-tests/use-crash-on-mouse-hover.svg
- manual-tests/svg-crash-hovering-use.svg: Added.
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::instanceForShadowTreeElement): Add ASSERT(!inDocument()) when returning 0 here if m_targetElementInstance is 0.
- 6:08 PM Changeset in webkit [53588] by
-
- 4 edits in trunk/WebCore
2010-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Timeline reset button doesn't clean timeline if the panel is scrolled down.
The overview pane also stay dirty after reset.
https://bugs.webkit.org/show_bug.cgi?id=33829
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.reset):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 5:46 PM Changeset in webkit [53587] by
-
- 3 edits2 adds in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33930
Crash in JSDOMWindowBase::crossDomainAccessErrorMessage when accessing a detached sandboxed frame
Test: http/tests/security/detached-sandboxed-frame-access.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Changed the way we discover the url to match what the actual check does. Both old and new code correctly fetch the URL of the current window displayed in frame, but going via DOMWindowShell avoids crashing on null DOMWindow::m_frame pointer.
- 5:35 PM Changeset in webkit [53586] by
-
- 16 edits1 add in trunk
2010-01-20 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Pavel Feldman.
[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620
Initial implementation of SerializedScriptValue which is used to
to create a serialized representation of JavaScript objects. This
representation is needed for structured clones and worker messages.
- WebCore.gypi: Added SerializedScriptValue.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Removed conversion to string before using SerializedScriptValue.
- bindings/v8/SerializedScriptValue.cpp: Added. (WebCore::): (WebCore::ZigZag::encode): (WebCore::ZigZag::decode): (WebCore::Writer::Writer): (WebCore::Writer::writeUndefined): (WebCore::Writer::writeNull): (WebCore::Writer::writeTrue): (WebCore::Writer::writeFalse): (WebCore::Writer::writeString): (WebCore::Writer::writeInt32): (WebCore::Writer::writeNumber): (WebCore::Writer::endComposite): (WebCore::Writer::data): (WebCore::Writer::doWriteUint32): (WebCore::Writer::append): (WebCore::Writer::ensureSpace): (WebCore::Writer::fillHole): (WebCore::Writer::charAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::StateBase::~StateBase): (WebCore::Serializer::StateBase::nextState): (WebCore::Serializer::StateBase::setNextState): (WebCore::Serializer::StateBase::composite): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::tag): (WebCore::Serializer::State::State): (WebCore::Serializer::StackCleaner::StackCleaner): (WebCore::Serializer::StackCleaner::~StackCleaner): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::done): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::done): (WebCore::Serializer::ObjectState::advance): (WebCore::Serializer::ObjectState::nextProperty): (WebCore::Serializer::doSerialize): (WebCore::Serializer::push): (WebCore::Serializer::top): (WebCore::Serializer::pop): (WebCore::Serializer::checkComposite): (WebCore::Reader::Reader): (WebCore::Reader::isEof): (WebCore::Reader::read): (WebCore::Reader::readTag): (WebCore::Reader::readString): (WebCore::Reader::readInt32): (WebCore::Reader::readNumber): (WebCore::Reader::doReadUint32): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::deserialize): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::push): (WebCore::Deserializer::pop): (WebCore::Deserializer::stackDepth): (WebCore::Deserializer::element): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::deserialize):
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::toWireString):
Updated uses of SerializedScriptValue:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
2010-01-20 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Pavel Feldman.
[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620
Updated uses of SerializedScriptValue:
- src/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject):
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask):
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
- 5:13 PM Changeset in webkit [53585] by
-
- 2 edits in trunk/LayoutTests
2010-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Re-skip svg/custom/use-instanceRoot-event-bubbling.xhtml on Gtk bot, still fails. Though the other platforms are fixed.
Reopened bug 33835.
- platform/gtk/Skipped:
- 5:11 PM Changeset in webkit [53584] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Remove unnecessary function call.
- 5:05 PM Changeset in webkit [53583] by
-
- 2 edits in trunk/WebKit/win
Add missing implementation for WebGeolocationPosition::initWithTimestamp.
Reviewed by Sam Weinig.
- WebGeolocationPosition.cpp:
(WebGeolocationPosition::initWithTimestamp): Implemented.
- 5:04 PM Changeset in webkit [53582] by
-
- 2 edits in trunk/WebCore
Fix crash in geolocation when observers change during iteration.
Reviewed by Sam Weinig.
- page/GeolocationController.cpp:
(WebCore::GeolocationController::positionChanged): Copy observers to vector while iterating.
(WebCore::GeolocationController::errorOccurred): Copy observers to vector while iterating.
- 5:03 PM Changeset in webkit [53581] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7086565> Crash in WebCore::PlugInView::dispatchNPEvent
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
Ref the PluginView to protect it from deletion while calling into the
plug-in.
- 5:01 PM Changeset in webkit [53580] by
-
- 2 edits in trunk/JavaScriptCore
Use the inline i386 assembly for x86_64 as well rather than falling back to using pthread mutexes.
Reviewed by Oliver Hunt.
- wtf/TCSpinLock.h:
(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SlowLock):
- 5:01 PM Changeset in webkit [53579] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/7215063> Use GCD instead of an extra thread for FastMalloc scavenging on platforms where it is supported
Reviewed by Oliver Hunt.
Abstract the background scavenging slightly so that an alternate implementation that uses GCD can be used on platforms
where it is supported.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::initializeScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::shouldContinueScavenging):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::periodicScavenge):
- wtf/Platform.h:
- 4:40 PM Changeset in webkit [53578] by
-
- 2 edits in trunk/LayoutTests
2010-01-20 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
REGRESSION(r53514?): fast/canvas/webgl/texImage2DImageDataTest.html fails on Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33893
- platform/mac-leopard/Skipped: Skip the test for now.
- 4:31 PM Changeset in webkit [53577] by
-
- 4 edits in trunk/WebCore
2010-01-19 Oliver Hunt <oliver@apple.com>
Reviewed by Dan Bernstein.
Insufficient repaint issues with html embedded in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16318
Partial fix for selection repaint in foreignObject, basically we
just need to make sure foreignObject correctly applies the svg
transform to the selection rect.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintSelection):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::mapLocalToContainer):
- rendering/RenderForeignObject.h:
- 4:21 PM Changeset in webkit [53576] by
-
- 5 edits18 adds in trunk/LayoutTests
2010-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Eric Seidel.
Add Leopard specific pixel test results where needed, most just show marginal 1px diffs, or even invisible changes,
only the filter test changed, but it visually looks the same - must be a Cg difference to the Snow Leopard baseline.
Now the pixel tests pass again with --tolerance 0 on my Leopard machine.
- platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
- platform/mac-leopard/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
- platform/mac-leopard/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
- platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png: Added.
- platform/mac-leopard/svg/css/css-box-min-width-expected.checksum: Added.
- platform/mac-leopard/svg/css/css-box-min-width-expected.png: Added.
- platform/mac-leopard/svg/css/mask-with-shadow-expected.checksum: Added.
- platform/mac-leopard/svg/css/mask-with-shadow-expected.png: Added.
- platform/mac-leopard/svg/custom/container-opacity-clip-viewBox-expected.checksum: Added.
- platform/mac-leopard/svg/custom/container-opacity-clip-viewBox-expected.png: Added.
- platform/mac-leopard/svg/custom/js-update-bounce-expected.checksum: Added.
- platform/mac-leopard/svg/custom/js-update-bounce-expected.png: Added.
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/mac-leopard/svg/filters: Added.
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- 4:15 PM Changeset in webkit [53575] by
-
- 5 edits in trunk/WebCore
<rdar://problem/7557695> REGRESSION(r53445-r53449): Many new memory leaks (33867)
Reviewed by NOBODY.
Revert r53447, since this caused leaks.
- WebCore.base.exp:
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::operator delete):
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::):
- storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):
- 3:53 PM Changeset in webkit [53574] by
-
- 32 edits3 adds in trunk
Implement File and Blob interfaces as defined in File API spec.
https://bugs.webkit.org/show_bug.cgi?id=32912
Reviewed by Dmitry Titov.
WebCore:
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/objc/DOMHTML.h:
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Binding.h:
(WebCore::toInt64):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
- html/File.cpp:
(WebCore::File::File):
- html/File.h:
(WebCore::File::create):
(WebCore::File::name):
(WebCore::File::fileName):
(WebCore::File::fileSize):
- html/File.idl:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
WebKit/mac:
- MigrateHeaders.make:
- 3:49 PM Changeset in webkit [53573] by
-
- 4 edits2 adds in trunk
WAI-ARIA popup buttons spoken as simply 'button'
https://bugs.webkit.org/show_bug.cgi?id=33922
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/aria-popup.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::actionElement):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
- html/HTMLAttributeNames.in:
LayoutTests:
- platform/mac/accessibility/aria-popup-expected.txt: Added.
- platform/mac/accessibility/aria-popup.html: Added.
- 3:30 PM Changeset in webkit [53572] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/7562708> REGRESSION(53460): Heap::destroy may not run
all destructors
Reviewed by Oliver Hunt.
- runtime/Collector.cpp:
(JSC::Heap::freeBlocks): Instead of fully marking protected objects,
just set their mark bits. This prevents protected objects from keeping
unprotected objects alive. Destructor order is not guaranteed, so it's
OK to destroy objects pointed to by protected objects before destroying
protected objects.
- 3:19 PM Changeset in webkit [53571] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Platform dependent expected files added for tests introduced in r53476,
because these tests pass. Compared to png files.
Reviewed by Nikolas Zimmermann.
- platform/qt/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
- platform/qt/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
- 3:01 PM Changeset in webkit [53570] by
-
- 6 edits in trunk/WebKitTools
2010-01-20 Eric Seidel <eric@webkit.org>
No review, rolling out r53537.
http://trac.webkit.org/changeset/53537
https://bugs.webkit.org/show_bug.cgi?id=33496
Added a failure condition to the commit-queue and looks to
have broken the EWS bots
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/scm.py:
- Scripts/webkitpy/scm_unittest.py:
- 2:43 PM Changeset in webkit [53569] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Platform dependent expected files added for tests introduced in r53446,
because these tests pass. Compared to png files.
Reviewed by Nikolas Zimmermann.
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
- 2:42 PM Changeset in webkit [53568] by
-
- 10 edits in trunk
CrossThreadCopier needs to support ThreadSafeShared better.
https://bugs.webkit.org/show_bug.cgi?id=33698
Reviewed by Oliver Hunt.
- wtf/TypeTraits.cpp: Added tests for the new type traits.
- wtf/TypeTraits.h:
(WTF::IsSubclass): Determines if a class is a derived from another class.
(WTF::IsSubclassOfTemplate): Determines if a class is a derived from a
template class (with one parameter that is unknown).
(WTF::RemoveTemplate): Reveals the type for a template parameter.
WebCore:
Now the copier is able to handle types that derive from ThreadSafeShared.
No change functionality so no new tests.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Remove unnecessary cast.
(WebCore::WorkerThreadableLoader::MainThreadBridge::clearClientWrapper): Ditto.
- loader/WorkerThreadableLoader.h:
Change to use the derived class instead of the ThreadSafeShared version.
- platform/CrossThreadCopier.cpp:
Add the new template parameter throughout the classes and adjust the class that
handles ThreadSafeShared to allow for derived types.
- platform/CrossThreadCopier.h:
Add another template parameter to be able to detect classes that derive
from ThreadSafeShared.
- websockets/WorkerThreadableWebSocketChannel.cpp:
Removed unnecessary casts and changed a type to use the derived class instead of
the ThreadSafeShared version.
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::workerContextDidSend):
(WebCore::workerContextDidGetBufferedAmount):
(WebCore::workerContextDidConnect):
(WebCore::workerContextDidReceiveMessage):
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::clearClientWrapper):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setMethodNotCompleted):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
- websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::Peer::create): Changed a type to use the
derived class instead of the ThreadSafeShared version.
- 2:31 PM Changeset in webkit [53567] by
-
- 11 edits2 adds in trunk
MSAA: accSelect() is not implemented
https://bugs.webkit.org/show_bug.cgi?id=33918
<rdar://problem/7436861>
Reviewed by Darin Adler.
WebCore:
Test: platform/win/accessibility/selection-and-focus.html
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setSelected):
Return early if the object is not selectable.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::accSelect):
If there is an invalid combination of state flags, return early. If the
caller passed the "take focus" flag, focus the object. If the "take
selection" flag was passed, check whether the parent object is an
AccessibilityListBox; if so, call the object's setSelectedChildren()
function. If the parent is an AccessibilityMenuListPopup, call the
child object's setSelected() function. Otherwise, if the parent is some
other, unsupported object, return early.
If the selection flags include "add", "remove", or "extend" selection,
and the parent object is not multi-selectable, return early. Otherwise,
set or unset the child's selected flag based on the passed flag.
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(takeFocusCallback):
Call the object's takeFocus() function.
(takeSelectionCallback):
Call its takeSelection() function.
(addSelectionCallback):
Call its addSelection() function.
(removeSelectionCallback):
Call its removeSelection() function.
(AccessibilityUIElement::getJSClass):
Add new functions to the JS class definition.
- DumpRenderTree/AccessibilityUIElement.h:
Declare new functions.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::takeFocus):
Stubbed.
(AccessibilityUIElement::takeSelection):
Stubbed.
(AccessibilityUIElement::addSelection):
Stubbed.
(AccessibilityUIElement::removeSelection):
Stubbed.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::takeFocus):
Stubbed.
(AccessibilityUIElement::takeSelection):
Stubbed.
(AccessibilityUIElement::addSelection):
Stubbed.
(AccessibilityUIElement::removeSelection):
Stubbed.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::takeFocus):
Call the object's accSelect() function, passing the appropriate flag.
(AccessibilityUIElement::takeSelection):
Ditto.
(AccessibilityUIElement::addSelection):
Ditto.
(AccessibilityUIElement::removeSelection):
Ditto.
LayoutTests:
- platform/win/accessibility/selection-and-focus-expected.txt: Added.
- platform/win/accessibility/selection-and-focus.html: Added.
- 2:23 PM Changeset in webkit [53566] by
-
- 2 edits in trunk/WebCore
2010-01-20 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix chromium build, introduced a copy&paste error.
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- 2:21 PM Changeset in webkit [53565] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6579204> Exception thrown when opening a <select> pop-up that
uses a web font
https://bugs.webkit.org/show_bug.cgi?id=23911
Reviewed by Darin Adler.
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate): Use the (bold) system font if an NSFont cannot
be obtained.
- 2:01 PM Changeset in webkit [53564] by
-
- 14 edits2 adds in trunk
2010-01-19 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Alexey Proskuryakov.
svg/custom/use-instanceRoot-event-bubbling.xhtml is flakey
https://bugs.webkit.org/show_bug.cgi?id=33835
mouseEvent fires mutiple times in svg/custom/use-instanceRoot-as-event-target.xhtml
https://bugs.webkit.org/show_bug.cgi?id=32519
Test: svg/custom/use-instanceRoot-event-listener-liveness.xhtml
Stabilize <use> scripting support - use tests are reliable now (tested using --repeach-each 50 --random -p)
Do not reclone trees anymore because of event listener changes, instead keep correspondingElement & shadowTreeElement
synchronized for each SVGElementInstance - any mutations on any event listeners are live, and take immediate effect,
w/o having to rely on a reclone - this was the root of several race conditions making the <use> tests flakey.
Fix SVGUseElement::instanceRoot() to force shadow tree creation, even if it was not attached so far - we can't wait
for finishedParsing() to be called which would recalculate the document style and attach the shadow tree as result.
This is now matching Operas behaviour.
Optimize createAttributeEventListener() to not create event listeners if the supplied Attribute isNull() - otherwhise
DOM calls like removeAttribute("onclick") cause a temporary JSEventListener to be created, added to the event listener
cache and removed afterwards.
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Return early if the supplied attribute is null as discussed with Geoffrey.
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Ditto.
- dom/Node.cpp: Synchronize event listeners with all element instances, instead of marking the use elements to reclone. (WebCore::instancesForSVGElement): (WebCore::tryAddEventListener): (WebCore::Node::addEventListener): When adding a listener, get a list of element instances and add it their as well. (WebCore::tryRemoveEventListener): (WebCore::Node::removeEventListener): Ditto for removals, but with special logic for listeners created from markup (see comments)
- svg/SVGElementInstance.cpp: Cleaned up, removing unncessary checks of correspondingElement() - there is an ASSERT in the ctor. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): (WebCore::SVGElementInstance::scriptExecutionContext): (WebCore::SVGElementInstance::addEventListener): (WebCore::SVGElementInstance::removeEventListener): (WebCore::SVGElementInstance::removeAllEventListeners): (WebCore::SVGElementInstance::eventTargetData): (WebCore::SVGElementInstance::ensureEventTargetData):
- svg/SVGUseElement.cpp: Call document()->updateLayoutIgnorePendingStylesheets() to force shadow tree creation, just like CSSStyleDecl works. (WebCore::SVGUseElement::instanceRoot):
- 1:56 PM Changeset in webkit [53563] by
-
- 3 edits in trunk/WebCore
Move local utility class DocumentWeakReference entirely from Document.h into Document.cpp
since it is only used there. It is a followup for http://trac.webkit.org/changeset/53345.
Reviewed by Darin Adler.
No new tests since no change in functionality.
- dom/Document.cpp: Move definitions of the methods into declaration of the class, remove 'inline'.
- dom/Document.h: Replace DocumentWeakReference declaration with a forward declaration.
- 1:50 PM Changeset in webkit [53562] by
-
- 4 edits in trunk/WebCore
2010-01-20 Oliver Hunt <oliver@apple.com>
No review, rolling out r53561.
http://trac.webkit.org/changeset/53561
https://bugs.webkit.org/show_bug.cgi?id=16318
broke selection repaint for transformed text in html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintSelection):
- rendering/RenderForeignObject.cpp:
- rendering/RenderForeignObject.h:
- 1:37 PM Changeset in webkit [53561] by
-
- 4 edits in trunk/WebCore
2010-01-19 Oliver Hunt <oliver@apple.com>
Reviewed by Beth Dakin.
Insufficient repaint issues with html embedded in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16318
Partial fix for selection repaint in foreignObject, basically we
just need to make sure foreignObject correctly applies the svg
transform to the selection rect.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintSelection):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::mapLocalToContainer):
- rendering/RenderForeignObject.h:
- 12:21 PM Changeset in webkit [53560] by
-
- 2 edits in trunk/WebCore
Build fix for !ENABLE(SVG).
- 12:05 PM Changeset in webkit [53559] by
-
- 4 edits1 add in trunk/WebKitTools
Extract Apache handling to httpd.pm module and use the provided functionality
in scripts where Apache is needed.
The module httpd.pm stores the PID of Apache in a variable and cleans up
the PID directory after Apache properly shut down. Catching INT and TERM
signals allows the scripts to close Apache and clean up its PID directory
even if the testing was interrupted.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-20
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=33153
- Scripts/webkitperl/httpd.pm: Added.
- Scripts/run-iexploder-tests:
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 11:26 AM Changeset in webkit [53558] by
-
- 43 edits2 deletes in trunk
Revert r53552 which caused lots of layout test failures.
- 11:13 AM Changeset in webkit [53557] by
-
- 9 edits2 moves in trunk/WebCore
Renames jni_runtime.[cpp|h] to JNIBridge.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=33899
Reviewed by David Levin.
No new tests, refactoring only.
- Android.jscbindings.mk: Modified. Removes jni_runtime.cpp and adds JNIBridge.cpp
- GNUmakefile.am: Modified. Removes jni_runtime.h and adds JNIBridge.h
- WebCore.xcodeproj/project.pbxproj: Modified. Removes jni_runtime.[cpp|h] and adds JNIBridge.[cpp|h]
- bridge/jni/JNIBridge.cpp: Copied from WebCore/bridge/jni/jni_runtime.cpp.
- bridge/jni/JNIBridge.h: Copied from WebCore/bridge/jni/jni_runtime.h.
- bridge/jni/jni_jsobject.mm: Modified. Updated to include JNIBridge.h
- bridge/jni/jni_runtime.cpp: Removed.
- bridge/jni/jni_runtime.h: Removed.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Updated to include JNIBridge.h
- bridge/jni/jsc/JavaClassJSC.cpp: Modified. Removed superfluous include
- bridge/jni/jsc/JavaClassJSC.h: Modified. Updated to include JNIBridge.h
- bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Updated to include JNIBridge.h
- 11:09 AM Changeset in webkit [53556] by
-
- 2 edits in trunk/WebKit/mac
Fix erroneous page scrolls when trying to select text or use form elements
with the Web Inspector docked.
http://webkit.org/b/24403
rdar://problem/6753925
Reviewed by John Sullivan and Darin Adler.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scrollRectIntoView): The scrollRect.move() call was
incorrectly converting the rect under the assumption that the frame view
is the same size as the WebView. Using convertRect:fromView: instead
is enough to fix the bug, but that code isn't needed since WebCore
already takes care of scrolling the main frame's document view, so it
was redundant to do it here too.
- 11:00 AM Changeset in webkit [53555] by
-
- 6 edits2 adds in trunk
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=33913
Crash under Media::matchMedium in detached frame
Also took the opportunity to fix JS bindings for the Media object.
Test: fast/media/lifetime.html
- css/Media.h: (WebCore::Media::create): Take and store a Frame pointer, like other similar objects do. (WebCore::Media::disconnectFrame): Zero out the frame pointer (this is called from DOMWindow::clear()).
- css/Media.cpp: (WebCore::Media::Media): Updated to storing Frame pointer. (WebCore::Media::type): Ditto. (WebCore::Media::matchMedium): Removed null check for document element - every document has one. Also, every Frame has a document, so we only need to check for m_frame being zero.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::markChildren):
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::media):
- page/DOMWindow.h: (WebCore::DOMWindow::optionalMedia): Make sure there's only one Media object per window, and keep its wrapper alive.
- 9:51 AM Changeset in webkit [53554] by
-
- 22 edits3 adds in trunk
JavaScriptCore: Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
Reviewed by Darin Adler and Adam Roben.
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
- Configurations/FeatureDefines.xcconfig: Add comments about keeping feature definitions in sync.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add FeatureDefines.vsprops inherited property sheet.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add FeatureDefines.vsprops inherited property sheet.
WebCore: Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
Reviewed by Darin Adler and Adam Roben.
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
- Configurations/FeatureDefines.xcconfig: Add comments about keeping feature definitions in sync.
- WebCore.vcproj/MigrateIDLAndScripts: Remove reference to file that no longer exists.
- WebCore.vcproj/QTMovieWin.vcproj: Add FeatureDefines.vsprops inherited property sheet.
- WebCore.vcproj/WebCore.vcproj: Add FeatureDefines.vsprops inherited property sheet.
- WebCore.vcproj/WebCoreCommon.vsprops: Remove ENABLE_ preprocessor definitions.
- WebCore.vcproj/WebCoreGenerated.vcproj: Added Cairo configuration for selecting proper features.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Remove ENABLE_VIDEO. This is picked up from FeatureDefines.vsprops.
- WebCore.vcproj/build-generated-files.sh: Pick up features from FeatureDefines.vsprops or FeatureDefinesCairo.vsprops.
WebKit/mac: Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
Reviewed by Darin Adler and Adam Roben.
- Configurations/FeatureDefines.xcconfig: Add comments about keeping feature definitions in sync.
WebKit/win: Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
Reviewed by Darin Adler and Adam Roben.
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
- WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet.
- WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated.
- WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions.
Add FeatureDefines.vsprops inherited property sheet.
- WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet.
WebKitLibraries: Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
Reviewed by Darin Adler and Adam Roben.
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
Keep this list of features (not enabled/disabled state) in sync with
FeatureDefines.xcconfig files in JavaScriptCore, WebCore, and WebKit.
Add new features to both PreprocessorDefinitions and UserMacro sections.
Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
- win/tools/scripts/feature-defines.sh: Added.
- win/tools/vsprops/FeatureDefines.vsprops: Added.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: Added.
- win/tools/vsprops/WinCairo.vsprops: Removed ENABLE_FILTERS. Now set in FeatureDefinesCairo.vsprops.
- 9:45 AM Changeset in webkit [53553] by
-
- 5 edits in trunk/WebKit/mac
<rdar://problem/7489504> Clicking on an overflow scrollbar when the window doesn't have
focus only focuses the window; it should start scrolling too
https://bugs.webkit.org/show_bug.cgi?id=33906
Reviewed by Simon Fraser.
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initializeLookupTable]): Initialize WebElementIsInScrollBarKey.
(-[WebElementDictionary _isInScrollBar]): Added. Returns whether the HitTestResult contains
a scroll bar.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _isScrollBarEvent:]): Added. Returns whether the event point is in a scroll
bar in this view.
(-[WebHTMLView acceptsFirstMouse:]): Accept scroll bar events.
- WebView/WebView.mm: Define WebElementIsInScrollBarKey.
- WebView/WebViewPrivate.h: Declare WebElementIsInScrollBarKey.
- 9:44 AM Changeset in webkit [53552] by
-
- 43 edits2 adds in trunk
2010-01-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
Test: inspector/console-log-before-inspector-open.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
- bindings/js/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/v8/ScriptValue.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- inspector/front-end/EventListenersSidebarPane.js: ():
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
- inspector/front-end/ObjectPropertiesSection.js:
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
2010-01-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
Test that web inspector doesn't crash when opening if there are messages in
the console. Refactor test case due to InjectedScriptAccess changes.
- inspector/console-log-before-inspector-open-expected.txt: Added.
- inspector/console-log-before-inspector-open.html: Added.
- inspector/styles-iframe.html:
- 9:38 AM Changeset in webkit [53551] by
-
- 7 edits in trunk
2010-01-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=time.
https://bugs.webkit.org/show_bug.cgi?id=33825
Add setter tests to input-valueasdate-time.js, and update the
expectation.
Note: the expectation file contains some FAIL lines. They are
intentional because they test a unimplemented feature.
- fast/forms/input-valueasdate-time-expected.txt:
- fast/forms/script-tests/input-valueasdate-time.js:
2010-01-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=time.
https://bugs.webkit.org/show_bug.cgi?id=33825
Introduce ISODateTime::setMillisecondsSinceMidnight() and add a
SecondFormat parameter to ISODateTime::toString(). The main code
logic for type=time is implemented in
setMillisecondsSinceMidnightInternal() and toStringForTime()
because the logic is going to be used for other types.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueAsDate):
- html/ISODateTime.cpp: (WebCore::positiveFmod): (WebCore::ISODateTime::setMillisecondsSinceMidnightInternal): (WebCore::ISODateTime::setMillisecondsSinceMidnight): (WebCore::ISODateTime::toStringForTime): (WebCore::ISODateTime::toString):
- html/ISODateTime.h: (WebCore::ISODateTime::):
- 9:22 AM Changeset in webkit [53550] by
-
- 3 edits in trunk/LayoutTests
2010-01-20 Philippe Normand <pnormand@igalia.com>
Reviewed by Darin Adler.
[Gtk] media/video-play-pause-exception.html is flacky
https://bugs.webkit.org/show_bug.cgi?id=33900
Refactored the test to use the pause event instead of a timer.
- media/video-play-pause-exception.html:
- platform/gtk/Skipped:
- 7:59 AM Changeset in webkit [53549] by
-
- 4 edits in trunk
[Qt] Unreviewed buildfix for r53547.
- DerivedSources.pro:
WebCore:
- WebCore.pri:
- 7:48 AM Changeset in webkit [53548] by
-
- 17 edits3 adds in trunk
The touchcancel event is not supported.
https://bugs.webkit.org/show_bug.cgi?id=33598
Reviewed by Simon Hausmann.
WebCore:
This change adds support for the touchcancel event in WebCore and adds a test.
Test: fast/events/touch/send-oncancel-event.html
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGestureEvent): Considers touchcancel with the other touch events when working out if the event is a user gesture.
- dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Adds a check to consider ontouchcancel a touch event listener.
- dom/Document.h: Add the touchcancel attribute event listener.
- dom/Document.idl: ditto.
- dom/Element.h: ditto.
- dom/Element.idl: ditto.
- dom/EventNames.h: Adds touchcancel as an event name.
- html/HTMLAttributeNames.in:Adds touchcancel as an HTML attribute name.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute): Parses the ontouchcancel attribute.
- page/DOMWindow.h: Adds the touchcancel attribute event listener.
- page/DOMWindow.idl: ditto.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Add code to detect and dispatch touchcancel events.
- platform/PlatformTouchEvent.h:
(WebCore::): Add TouchCancel as a touch event type.
- platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::): Add TouchCanceled as a touch point state.
LayoutTests:
Test for the oncancel event.
- fast/events/script-tests/send-oncancel-event.js: Added.
(touchcancelHandler):
- fast/events/touch/send-oncancel-event-expected.txt: Added.
- fast/events/touch/send-oncancel-event.html: Added.
- platform/qt/Skipped: Add send-oncancel-event to the Qt Skipped list as there is not support for that type of event on Qt yet.
- 6:27 AM Changeset in webkit [53547] by
-
- 5 edits in trunk
[Qt] Make extraCompilers for generated sources depend on their scripts
Reviewed by Simon Hausmann.
- DerivedSources.pro:
WebCore:
- DerivedSources.pro:
- WebCore.pri:
- 6:15 AM Changeset in webkit [53546] by
-
- 2 edits in trunk/WebCore
2010-01-20 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[Chromium][V8] Fix null pointer dereference in V8Proxy::retrieve().
https://bugs.webkit.org/show_bug.cgi?id=33886
This is equivalent to r53433, and fix a crash by
LayoutTests/http/tests/appcache/destroyed-iframe.html.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Check if context is null.
- 5:58 AM Changeset in webkit [53545] by
-
- 12 edits in trunk/WebCore
2010-01-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Optimize resize event handling for hidden views
https://bugs.webkit.org/show_bug.cgi?id=33803
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.updateSidebarWidth): (WebInspector.Panel.prototype.resize):
- inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype.show): (WebInspector.PanelEnablerView.prototype.resize):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype.closeVisibleView): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.get visibleView): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.updateMainViewWidth):
- inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView): (WebInspector.WelcomeView.prototype.show): (WebInspector.WelcomeView.prototype.resize):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.windowResize):
- 4:56 AM Changeset in webkit [53544] by
-
- 4 edits in trunk/BugsSite
Adjust height of status-bubbles to prevent them being cut.
Reviewed by Adam Barth.
BugSite:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 4:33 AM Changeset in webkit [53543] by
-
- 7 edits in trunk
[Qt] Make DumpRenderTree build on Windows
Reviewed by Simon Hausmann.
- WebKit.pro:
WebKitTools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/main.cpp:
- 4:12 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:57 AM Changeset in webkit [53542] by
-
- 2 edits in trunk/WebKitTools
Fix commit bot to land patches in order of the bug last modification date.
https://bugs.webkit.org/show_bug.cgi?id=33395
Reviewed by Eric Seidel.
- Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
- 3:37 AM Changeset in webkit [53541] by
-
- 8 edits in trunk/WebCore
Fixes style in WebCore/bridge/Bridge
https://bugs.webkit.org/show_bug.cgi?id=33839
Reviewed by David Levin.
No new tests, style fixes only.
- bridge/Bridge.cpp: Modified.
- bridge/Bridge.h: Modified.
- bridge/c/c_instance.cpp: Modified.
(JSC::Bindings::CInstance::invokeMethod): Modified. Use renamed m_rootObject member
(JSC::Bindings::CInstance::invokeDefaultMethod): Modified. Use renamed m_rootObject member
(JSC::Bindings::CInstance::invokeConstruct): Modified. Use renamed m_rootObject member
- bridge/jni/jni_runtime.cpp: Modified.
(JavaArray::JavaArray): Modified. Use renamed m_rootObject member
(JavaArray::rootObject): Modified. Use renamed m_rootObject member
- bridge/objc/objc_instance.mm: Modified.
(ObjcInstance::invokeMethod): Modified. Use renamed m_rootObject member
(ObjcInstance::invokeDefaultMethod): Modified. Use renamed m_rootObject member
(ObjcInstance::getValueOfUndefinedField): Modified. Use renamed m_rootObject member
- bridge/objc/objc_runtime.mm: Modified.
(JSC::Bindings::ObjcArray::valueAt): Modified. Use renamed m_rootObject member
- bridge/qt/qt_runtime.cpp: Modified.
(JSC::Bindings::::rootObject): Modified. Use renamed m_rootObject member
- 3:37 AM Changeset in webkit [53540] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33303
It caused by the previously test, so skipped it until fix.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html skipped.
- 3:28 AM Changeset in webkit [53539] by
-
- 3 edits in trunk/WebKitTools
2010-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach check-webkit-style about WebKit/gtk/tests
https://bugs.webkit.org/show_bug.cgi?id=33892
Removes false positives found in
https://bugs.webkit.org/show_bug.cgi?id=30883
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 3:26 AM Changeset in webkit [53538] by
-
- 3 edits in trunk/WebKitTools
2010-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach check-webkit-style about QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=33890
Remove false positives found in
https://bugs.webkit.org/show_bug.cgi?id=33708
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 3:20 AM Changeset in webkit [53537] by
-
- 6 edits in trunk/WebKitTools
2010-01-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-commit-queue status page is confusing
https://bugs.webkit.org/show_bug.cgi?id=33496
This should improve the status page by removing more Fail messages.
To do this, I re-factored the CommitQueue and the AbstractReviewQueues
to behave more like one another. This meant moving where the failure reporting was done.
Previously the AbstractReviewQueue always used the parent process to report the error,
while CommitQueue used the subprocess when possible, and the parent only reported errors
that we didn't know how to handle (bugs in the commit-queue itself).
Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block
in both implementations and required teaching handle_script_error in each to post Fail messages
to the status server instead of calling exit(1).
This will also make the style-queue share more bug posting logic with other queues:
https://bugs.webkit.org/show_bug.cgi?id=33871
- Scripts/webkitpy/commands/early_warning_system.py:
- Don't exit(1) as that will cause the calling queue to also report Fail to the status server. Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. _update_status_for_script_error knows how to post the Fail message to the status server.
- Teach _update_status_for_script_error how to post Fail messages to the status server.
- Scripts/webkitpy/commands/queues.py:
- Remove the try block from process_work_item since the caller already has one.
- Only CC watchers on failure to cut down on commit-queue generated mail.
- handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
- Abstract _format_script_error_output_for_bug to share code between all queues.
- The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
- Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
- Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
- handle_script_error now posts Fail instead of the try block in process_work_item handling it.
- Scripts/webkitpy/queueengine.py:
- QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
- Scripts/webkitpy/scm.py:
- Add new checkout_revision function.
- Scripts/webkitpy/scm_unittest.py:
- Test our new checkout_revision function.
- 2:23 AM Changeset in webkit [53536] by
-
- 2 edits in trunk/WebCore
2010-01-20 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Fixes style errors exposed by the style bot in the patch
for bug #33770. Moreover, fixes all style errors reported
by check-webkit-style.
No functionality was changed. So, no new tests.
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
- 2:15 AM Changeset in webkit [53535] by
-
- 2 edits in trunk
[Qt] Fix the recursive generated_files target to work with qmake -r -o
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-20
Reviewed by Simon Hausmann.
- DerivedSources.pro:
- 2:08 AM BuildingQtOnLinux edited by
- (diff)
- 2:06 AM Changeset in webkit [53534] by
-
- 3 edits in trunk/WebKitTools
2010-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Exempt JavaScriptCore/qt/api from style checks
https://bugs.webkit.org/show_bug.cgi?id=33879
Apparently there is a JavaScriptCore API for Qt as well as a WebKit
API.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 1:58 AM Changeset in webkit [53533] by
-
- 3 edits in trunk/WebCore
Fixes style in WebCore/bridge/JNIUtility
https://bugs.webkit.org/show_bug.cgi?id=33870
Reviewed by David Levin.
No new tests, style fixes only.
- bridge/jni/JNIUtility.cpp:
- bridge/jni/JNIUtility.h:
- 1:57 AM Changeset in webkit [53532] by
-
- 2 edits in trunk
[Qt] Make it possible (on *nix at least) to recursively call "make generated_files"
Reviewed by Tor Arne Vestbø.
- DerivedSources.pro:
- 1:29 AM Changeset in webkit [53531] by
-
- 2 edits in trunk/LayoutTests
Bug 28420 - Re-enable fast/ruby layout tests after the issue with mixedContent was fixed.
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5a)
Reviewed by Darin Adler.
cf. https://bugs.webkit.org/show_bug.cgi?id=31200
- platform/mac/Skipped:
- 1:27 AM QtWebKitPackaging edited by
- (diff)
- 1:06 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:54 AM Changeset in webkit [53530] by
-
- 2 edits in trunk/WebCore
On Linux link QtWebKit with -no-undefined to catch build breakages due to missing
files in the .pro file, resulting in unresolved symbols.
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 12:54 AM Changeset in webkit [53529] by
-
- 2 edits in trunk/WebCore
[Qt] Make it possible to link with -no-undefined.
Reviewed by Tor Arne Vestbø.
- WebCore.pro: Add missing explicit dependency to libXrender due to the
use of XRenderFindVisualFormat in the X11 plugin code.
- 12:43 AM Changeset in webkit [53528] by
-
- 2 edits in trunk/WebCore
Add missing files to the build.
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 12:26 AM Changeset in webkit [53527] by
-
- 5 edits1 delete in trunk
2010-01-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Fisher.
[Chromium] computePageRectsForFrame seems to be unnecessary
https://bugs.webkit.org/show_bug.cgi?id=33881
- WebCore.gypi: Removed FrameChromium.h
- page/chromium/FrameChromium.cpp: Removed computePageRectsForFrame.
- page/chromium/FrameChromium.h: Removed.
2010-01-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Fisher.
[Chromium] computePageRectsForFrame seems to be unnecessary
https://bugs.webkit.org/show_bug.cgi?id=33881
- src/WebFrameImpl.cpp: Stop including FrameChromium.h
- 12:22 AM QtWebKitPackaging created by
- 12:20 AM Changeset in webkit [53526] by
-
- 4 edits in trunk/WebKitTools
[Qt] Don't use QSocketNotifier in the DRT for reading stdin
Reviewed by Simon Hausmann.
QSocketNotifier is not available on Windows. Instead we read
stdin synchronously after each test using signals and slots.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/main.cpp:
Jan 19, 2010:
- 11:46 PM Changeset in webkit [53525] by
-
- 7 edits28 adds2 deletes in trunk
Bug 33266 - WebCore::InlineFlowBox::determineSpacingForFlowBoxes ReadAV@NULL (43c64e8abbda6766e5f5edbd254c2d57)
(https://bugs.webkit.org/show_bug.cgi?id=33266)
Reviewed by Dan Bernstein.
WebCore:
Ruby did not handle malformed cases correctly when the ruby base was in
block flow. Changed the code to handle all possible cases.
Also, added some simplification methods to RenderBlock.
Tests: fast/ruby/ruby-illegal-1.html
fast/ruby/ruby-illegal-2.html
fast/ruby/ruby-illegal-3.html
fast/ruby/ruby-illegal-4.html
fast/ruby/ruby-illegal-5.html
fast/ruby/ruby-illegal-6.html
fast/ruby/ruby-illegal-7.html
fast/ruby/ruby-illegal-combined.html
fast/ruby/rubyDOM-insert-rt-block-1.html
fast/ruby/rubyDOM-insert-rt-block-2.html
fast/ruby/rubyDOM-insert-rt-block-3.html
fast/ruby/rubyDOM-remove-rt-block-1.html
fast/ruby/rubyDOM-remove-rt-block-2.html
fast/ruby/rubyDOM-remove-rt-block-3.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenTo): useful for anonymous block manipulation
(WebCore::RenderBlock::removeChild): making use of moveAllChildrenTo
- rendering/RenderBlock.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::hasOnlyWrappedInlineChildren):
(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
LayoutTests:
Layout tests for ruby with malformed HTML.
Split up in individual tests, as well ass added a single combined test
(whose resulting render tree is probably completely different from what
you'd expect), since that combined test showed additional issues not
covered by the individual tests.
- fast/ruby/ruby-illegal-1-expected.txt: Added.
- fast/ruby/ruby-illegal-1.html: Added.
- fast/ruby/ruby-illegal-2-expected.txt: Added.
- fast/ruby/ruby-illegal-2.html: Added.
- fast/ruby/ruby-illegal-3-expected.txt: Added.
- fast/ruby/ruby-illegal-3.html: Added.
- fast/ruby/ruby-illegal-4-expected.txt: Added.
- fast/ruby/ruby-illegal-4.html: Added.
- fast/ruby/ruby-illegal-5-expected.txt: Added.
- fast/ruby/ruby-illegal-5.html: Added.
- fast/ruby/ruby-illegal-6-expected.txt: Added.
- fast/ruby/ruby-illegal-6.html: Added.
- fast/ruby/ruby-illegal-7-expected.txt: Added.
- fast/ruby/ruby-illegal-7.html: Added.
- fast/ruby/ruby-illegal-combined-expected.txt: Added.
- fast/ruby/ruby-illegal-combined.html: Added.
- fast/ruby/ruby-illegal-expected.txt: Removed.
- fast/ruby/ruby-illegal.html: Removed.
- fast/ruby/rubyDOM-insert-rt-block-1-expected.txt: Added.
- fast/ruby/rubyDOM-insert-rt-block-1.html: Added.
- fast/ruby/rubyDOM-insert-rt-block-2-expected.txt: Added.
- fast/ruby/rubyDOM-insert-rt-block-2.html: Added.
- fast/ruby/rubyDOM-insert-rt-block-3-expected.txt: Added.
- fast/ruby/rubyDOM-insert-rt-block-3.html: Added.
- fast/ruby/rubyDOM-remove-rt-block-1-expected.txt: Added.
- fast/ruby/rubyDOM-remove-rt-block-1.html: Added.
- fast/ruby/rubyDOM-remove-rt-block-2-expected.txt: Added.
- fast/ruby/rubyDOM-remove-rt-block-2.html: Added.
- fast/ruby/rubyDOM-remove-rt-block-3-expected.txt: Added.
- fast/ruby/rubyDOM-remove-rt-block-3.html: Added.
- 9:57 PM Changeset in webkit [53524] by
-
- 2 edits in trunk/WebCore
Build fix after r53514
- WebCore.base.exp: Removed threadGlobalData(), which was inlined in r53514.
- 9:45 PM Changeset in webkit [53523] by
-
- 2 edits in trunk/WebCore
2010-01-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Avoid calling NSEqualRects() on the garbage rect obtained
by calling -frame on a null view.
- platform/mac/WidgetMac.mm: (WebCore::Widget::setFrameRect):
- 9:34 PM Changeset in webkit [53522] by
-
- 5 edits in trunk/WebKit
WebKit: Redo DumpRenderTree build fix without making WebTypesInternal.h a private header
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac: Redo Tiger build fix without making WebTypesInternal.h a private header
- WebView/WebHTMLRepresentation.h: Define and use WebNSUInteger.
- WebView/WebHTMLRepresentation.mm: Import WebTypesInternal.h.
- 9:18 PM Changeset in webkit [53521] by
-
- 2 edits in trunk/WebKit
2010-01-19 Simon Fraser <Simon Fraser>
Build fix, no review.
Fix build of DumpRenderTree by making the header WebTypesInternal.h Private
in WebKit.
- WebKit.xcodeproj/project.pbxproj:
- 9:08 PM Changeset in webkit [53520] by
-
- 5 edits in trunk/WebKit/mac
<rdar://problem/7068584> Crash at NetscapePluginHostProxy::processRequests
Patch by Anders Carlsson <andersca@apple.com> on 2009-12-18
Reviewed by Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::waitForReply): Wrapped with calls
to willCallPluginFunction/didCallPluginFunction. This prevents the plug-in
from being stopped while waiting for reply.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Protect the
instance proxy in case the plug-in host crashes while waiting for reply.
- Plugins/Hosted/ProxyInstance.h:
(WebKit::ProxyInstance::waitForReply): Added. Calls through to
NetscapePluginInstanceProxy::waitForReply(), but returns a null reply if the
proxy gets invalidated while waiting for the reply.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke): Use ProxyInstance::waitForReply().
(WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
(WebKit::ProxyInstance::supportsConstruct): Ditto.
(WebKit::ProxyInstance::getPropertyNames): Ditto.
(WebKit::ProxyInstance::methodsNamed): Ditto.
(WebKit::ProxyInstance::fieldNamed): Ditto.
(WebKit::ProxyInstance::fieldValue): Ditto.
(WebKit::ProxyInstance::setFieldValue): Ditto.
- 8:09 PM Changeset in webkit [53519] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix.
- WebView/WebHTMLRepresentation.h:
Added #import for WebTypesInternal.h so NSUInteger will be defined on Tiger.
- 7:43 PM Changeset in webkit [53518] by
-
- 2 edits in trunk/WebKitTools
2010-01-19 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Move chromium-ews back to building release only to make the EWS faster.
- Scripts/webkitpy/commands/early_warning_system.py:
- 7:24 PM Changeset in webkit [53517] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Remove currentWorld from the exports file again, since it is now inline.
- WebCore.base.exp:
- 7:05 PM Changeset in webkit [53516] by
-
- 9 edits in trunk
JavaScriptCore: When JavaScriptCore calls Debugger::Exception, have it pass a
hasHandler variable that represents if exception is being handled
in the same function (not in a parent on the call stack).
Reviewed by Tim Hatcher.
This just adds a new parameter, no behavior is changed.
- debugger/Debugger.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
WebCore: Part of <http://webkit.org/b/28622>.
Caught exceptions still pause the debugger.
Reviewed by Tim Hatcher.
Update JavaScriptDebugServer::exception to take a hasHandler parameter,
so later we can differentiate between a caught and an uncaught exception.
This just adds a new parameter, no behavior is changed.
No change in functionality, so no tests.
- inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::exception):
- inspector/JavaScriptDebugServer.h:
WebKit/mac: Part of <http://webkit.org/b/28622>.
Caught exceptions still pause the debugger.
Reviewed by Tim Hatcher.
Update WebScriptDebugger::exception to have the hasHandler parameter.
This just adds a new parameter, no behavior is changed.
- WebView/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
- 6:30 PM Writing Layout Tests for DumpRenderTree edited by
- Add description of parameters of eventSender.mouseDown(), and add … (diff)
- 6:27 PM Changeset in webkit [53515] by
-
- 3 edits in trunk/WebKit/chromium
Chromium build fix.
- public/WebAccessibilityRole.h:
(WebKit::):
Correct enum names.
- src/LocalizedStrings.cpp:
(WebCore::AXMenuListPopupActionVerb):
Stubbed.
(WebCore::AXMenuListActionVerb):
Stubbed.
- 6:25 PM Changeset in webkit [53514] by
-
- 23 edits in trunk
2010-01-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Inline functions that are hot in DOM manipulation
https://bugs.webkit.org/show_bug.cgi?id=33820
(3% speedup on Dromaeo DOM Core tests)
- runtime/WeakGCMap.h: (JSC::::get): inline
2010-01-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Inline functions that are hot in DOM manipulation
https://bugs.webkit.org/show_bug.cgi?id=33820
(3% speedup on Dromaeo DOM Core tests)
- bindings/js/JSDOMBinding.h: (WebCore::currentWorld): Inlined. (WebCore::jsString): Inlined String& overload and split off slow case.
- bindings/js/JSDOMBinding.cpp: (WebCore::jsStringSlowCase): Slow case for the above.
- dom/Document.h: (WebCore::Document::isHTMLDocument): Use a bit and an inline method instead of a virtual method, since this is so hot and size of Document is not a prime concern. (WebCore::Document::create): Adapt for above. (WebCore::Document::createXHTML): ditto
- dom/Document.cpp: (WebCore::Document::Document): ditto
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): ditto
- html/HTMLDocument.h: ditto
- loader/PlaceholderDocument.h: (WebCore::PlaceholderDocument::PlaceholderDocument): ditto
- svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): ditto
- dom/Element.h: (WebCore::Element::attributes): Inlined. (WebCore::Element::updateId): Inlined.
- dom/Element.cpp: (Remove inlined methods.)
- dom/NamedAttrMap.h: (WebCore::NamedNodeMap::getAttributeItem): Inlined and split off slow case.
- dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::getAttributeItemSlowCase): Slow case for the above.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h: (WebCore::InspectorController::didInsertDOMNode): Inlined so the fast case early exit doesn't incur a function call. (WebCore::InspectorController::didRemoveDOMNode): ditto (WebCore::InspectorController::didModifyDOMAttr): ditto
- platform/ThreadGlobalData.h: (WebCore::threadGlobalData): Inlined.
- platform/ThreadGlobalData.cpp: (Removed inline methods).
- platform/Timer.h: (WebCore::TimerBase::isActive): Inlined.
- platform/Timer.cpp: (Removed inline methods).
- WebCore.xcodeproj/project.pbxproj: Install new heares.
- WebCore.base.exp: Add appropriate exports.
- 6:03 PM Changeset in webkit [53513] by
-
- 5 edits in trunk
Chromium build fix.
WebCore:
- accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Call correct function.
WebKit/chromium:
- public/WebAccessibilityRole.h:
(WebKit::):
- src/AssertMatchingEnums.cpp:
- 5:43 PM Changeset in webkit [53512] by
-
- 37 edits2 copies6 adds in trunk
MSAA: The child <option> elements of a non-multiple <select> are not
exposed
https://bugs.webkit.org/show_bug.cgi?id=33773
<rdar://problem/7550556>
WebCore:
Reviewed by Alice Liu.
This exposes the child <option> elements in a format similar to
Firefox's: the <select> element has one child, a hidden list object,
and this list has as its children the <option> elements.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add new files to project.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
If the element is a RenderMenuList, create an AccessibilityMenuList.
(WebCore::AXObjectCache::getOrCreate):
Add new types to create by role value.
- accessibility/AccessibilityMenuList.cpp: Added.
(WebCore::AccessibilityMenuList::AccessibilityMenuList):
Call the base class constructor. Assert that the RenderObject passed
is a RenderMenuList.
(WebCore::AccessibilityMenuList::press):
Show or hide the popup menu.
(WebCore::AccessibilityMenuList::addChildren):
Create an AccessibilityMenuListPopup. If the platform ignores its
accessibility, remove it from the object cache and return early.
Otherwise, set its parent object to this object, add it to our list of
children, and tell it to add its children.
(WebCore::AccessibilityMenuList::childrenChanged):
Tell our child hidden list that its children changed.
(WebCore::AccessibilityMenuList::isCollapsed):
Return whether the popup menu is visible.
- accessibility/AccessibilityMenuList.h: Added.
(WebCore::AccessibilityMenuList::create):
Adopt and return a new RenderMenuList.
(WebCore::AccessibilityMenuList::isMenuList):
(WebCore::AccessibilityMenuList::roleValue):
(WebCore::AccessibilityMenuList::accessibilityIsIgnored):
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
- accessibility/AccessibilityMenuListOption.cpp: Added.
(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
Initialize the pointer to our parent popup menu.
(WebCore::AccessibilityMenuListOption::setElement):
Assert that the element is an <option> element.
(WebCore::AccessibilityMenuListOption::actionElement):
Return our element.
(WebCore::AccessibilityMenuListOption::parentObject):
Return our parent popup menu.
(WebCore::AccessibilityMenuListOption::isEnabled):
Return true if the element itself is enabled.
(WebCore::AccessibilityMenuListOption::isVisible):
Return true if the popup is visible, or return true if the popup is
collapsed but the element is selected.
(WebCore::AccessibilityMenuListOption::isOffScreen):
Return true if the object is invisible.
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::nameForMSAA):
Return the <option> element's text.
(WebCore::AccessibilityMenuListOption::canSetSelectedAttribute):
Return true if enabled.
(WebCore::AccessibilityMenuListOption::elementRect):
Return the AccessibilityMenuList's rect.
- accessibility/AccessibilityMenuListOption.h: Added.
(WebCore::AccessibilityMenuListOption::create):
Adopt and return a new AccessibilityMenuListOption.
(WebCore::AccessibilityMenuListOption::setParent):
(WebCore::AccessibilityMenuListOption::isMenuListOption):
(WebCore::AccessibilityMenuListOption::roleValue):
(WebCore::AccessibilityMenuListOption::canHaveChildren):
(WebCore::AccessibilityMenuListOption::size):
- accessibility/AccessibilityMenuListPopup.cpp: Added.
(WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
Initialize the pointer to our parent list.
(WebCore::AccessibilityMenuListPopup::isVisible):
Return false; we're never considered visible.
(WebCore::AccessibilityMenuListPopup::isOffScreen):
Return true if the popup is collapsed.
(WebCore::AccessibilityMenuListPopup::parentObject):
Return our parent AccessibilityMenuList.
(WebCore::AccessibilityMenuListPopup::isEnabled):
Return true if our parent is enabled.
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
If the element is an <option> element, create a list item for it, and
set the object's element to this element.
(WebCore::AccessibilityMenuListPopup::press):
Call our parent's press() function to show or hide the popup menu.
(WebCore::AccessibilityMenuListPopup::addChildren):
Walk the select element's children, and create list items for them. Add
them to our list of children.
(WebCore::AccessibilityMenuListPopup::childrenChanged):
If any of our children have been detached from the document, remove
them from the AXObjectCache and from our child list.
(WebCore::AccessibilityMenuListPopup::setMenuList):
- accessibility/AccessibilityMenuListPopup.h: Added.
(WebCore::AccessibilityMenuListPopup::create):
Adopt and return an AccessibilityMenuListPopup.
(WebCore::AccessibilityMenuListPopup::isMenuListPopup):
(WebCore::AccessibilityMenuListPopup::elementRect):
(WebCore::AccessibilityMenuListPopup::size):
(WebCore::AccessibilityMenuListPopup::roleValue):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::actionVerb):
Add the menuListAction and menuListPopupAction verbs.
- accessibility/AccessibilityObject.h:
(WebCore::):
Add new roles.
(WebCore::AccessibilityObject::isMenuList):
Stubbed.
(WebCore::AccessibilityObject::isMenuListHiddenList):
Stubbed.
(WebCore::AccessibilityObject::isMenuListOption):
Stubbed.
(WebCore::AccessibilityObject::isVisible):
Stubbed.
- accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ignore the new object type.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ditto.
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ditto.
- accessibility/qt/AccessibilityObjectQt.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ditto.
- accessibility/win/AccessibilityObjectWin.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Allow the new object types.
- accessibility/wx/AccessibilityObjectWx.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ignore the new object type.
- accessibility/win/AccessibilityObjectWin.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
If the object is an AccessibilityMenuListHiddenList or
AccessibilityMenuListOption, include it.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::disabled):
Call ownElementDisabled().
- html/HTMLOptionElement.h:
(WebCore::HTMLOptionElement::ownElementDisabled):
Return the base class implementation of disabled, which returns
whether this <option> itself is disabled.
- platform/LocalizedStrings.h:
Declare new localized string functions.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXMenuListPopupActionVerb):
Stubbed.
(WebCore::AXMenuListActionVerb):
Stubbed.
- platform/haiku/LocalizedStringsHaiku.cpp:
(WebCore::AXMenuListPopupActionVerb):
Stubbed.
(WebCore::AXMenuListActionVerb):
Stubbed.
- platform/mac/LocalizedStringsMac.mm:
(WebCore::AXMenuListPopupActionVerb):
Call the view factory's method.
(WebCore::AXMenuListActionVerb):
Ditto.
- platform/qt/Localizations.cpp:
(WebCore::AXMenuListPopupActionVerb):
Stubbed.
(WebCore::AXMenuListActionVerb):
Stubbed.
- platform/wx/LocalizedStringsWx.cpp:
(WebCore::AXMenuListPopupActionVerb):
Stubbed.
(WebCore::AXMenuListActionVerb):
Stubbed.
WebKit:
Reviewed by Alice Liu.
- English.lproj/Localizable.strings:
Add new localized strings.
WebKit/mac:
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXMenuListPopupActionVerb]):
Stubbed.
(-[WebViewFactory AXMenuListActionVerb]):
Stubbed.
WebKit/win:
Reviewed by Alice Liu.
- AccessibleBase.cpp:
(AccessibleBase::get_accState):
If the object is invisible, set the invisible state flag. If the object
is collapsed, set the collapsed state. If the object is a combo box,
set the has popup flag, and if it's not collapsed, set the expanded
flag.
(MSAARole):
Add new WebCore to MSAA role mappings.
- WebCoreLocalizedStrings.cpp:
(WebCore::AXMenuListActionVerb):
Return the action verb that Firefox uses for <select> elements with
popups.
(WebCore::AXMenuListPopupActionVerb):
Return the verb that Firefox uses for a popup list.
WebKitTools:
Reviewed by Alice Liu.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getIsVisibleCallback):
Call the object's isVisible() function.
(getIsOffScreenCallback):
Ditto, for isOffScreen().
(getIsCollapsedCallback):
Ditto, for isCollapsed().
(getHasPopupCallback):
Ditto, for hasPopup().
(AccessibilityUIElement::getJSClass):
Add isVisible and isOffScreen attributes.
- DumpRenderTree/AccessibilityUIElement.h:
Declare new functions.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isVisible):
Stubbed.
(AccessibilityUIElement::isOffScreen):
Stubbed.
(AccessibilityUIElement::isCollapsed):
Stubbed.
(AccessibilityUIElement::hasPopup):
Stubbed.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isVisible):
Stubbed.
(AccessibilityUIElement::isOffScreen):
Stubbed.
(AccessibilityUIElement::isCollapsed):
Stubbed.
(AccessibilityUIElement::hasPopup):
Stubbed.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::showMenu):
Call the object's accDoDefaultAction() to show its popup menu.
(AccessibilityUIElement::isEnabled):
Check that the object does not have the "unavailable" state.
(AccessibilityUIElement::isVisible):
Check that the object does not have the "invisible" state.
(AccessibilityUIElement::isOffScreen):
Check whether the object has the "offscreen" state.
(AccessibilityUIElement::isCollapsed):
Check whether the object has the "collapsed" state.
(AccessibilityUIElement::hasPopup):
Check whether the object has the "has popup" state.
LayoutTests:
Reviewed by Alice Liu.
- platform/win/accessibility/single-select-children-expected.txt: Added.
- platform/win/accessibility/single-select-children.html: Added.
- 5:16 PM Changeset in webkit [53511] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.19
Tagging 1.1.19.
- 5:10 PM Changeset in webkit [53510] by
-
- 8 edits4 adds in trunk
2010-01-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Support reflections on WebGL
https://bugs.webkit.org/show_bug.cgi?id=33754
Support reflections of WebGL content, by ensuring that when the Canvas3DLayer containing the
WebGL content gets displayed, we correctly copy its content to the clone layers.
Test: compositing/webgl/webgl-reflection.html
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::didDisplay): Give the didDisplay() client method a parameter which is the layer that displayed.
- platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer display]): Override -[CALayer display], and call the client didDisplay().
- platform/graphics/mac/GraphicsLayerCA.h: didDisplay() takes a PlatformLayer parameter.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::~GraphicsLayerCA): We need to clear the layer owner on the content layer, since we're setting it for WebGL layers now.
(WebCore::GraphicsLayerCA::didDisplay): Handle didDisplay() calls for the content layer,
as well as the main layer now, getting the correct layer to copy contents from, and using
the correct clone map.
(WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D): Set the layer owner for WebGL
layers, because we need the didDisplay() callback.
- platform/graphics/mac/WebLayer.mm: (-[WebLayer display]): didDisplay() takes a layer argument.
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer display]): ditto.
- 4:58 PM Changeset in webkit [53509] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7555330> <http://webkit.org/b/33770> dataFunctionMatrix leaks the array allocated by toArray
Reviewed by Oliver Hunt.
Rework toArray to extract elements in to a vector rather than handing out raw pointers. This prevents
callers from forgetting to free the memory, and gives them the option of using stack buffers for
sufficiently small allocations.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::texSubImage2D):
(WebCore::toVector):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
- 4:57 PM Changeset in webkit [53508] by
-
- 2 edits in trunk/WebKitTools
2010-01-19 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel.
Correct committer name.
https://bugs.webkit.org/show_bug.cgi?id=33868
- Scripts/webkitpy/committers.py:
- 4:37 PM Changeset in webkit [53507] by
-
- 3 edits in trunk/WebCore
2010-01-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Occasional crash when interacting with page with reflected WebGL
https://bugs.webkit.org/show_bug.cgi?id=33863
If updateCompositingLayers() was called with an updateRoot that was a reflection layer,
then we would determine that the layer does not require compositing, and tear down its
backing (without clearing replicaLayer() on the source layer's GraphicsLayer).
Fix by changing requiresCompositingLayer() on a reflection layer to always give the
same answer for a reflection and its original.
Also add various belt-and-brances code and null checks to ensure that if we ever end up
with a non-composited reflection layer, we won't crash.
No new tests, because the crash depends on timing issues that are hard to reproduce in a test.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::replicaLayer): Make this public so we can use it in an assertion.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): Clear the source layer's replica layer pointer if tearing down backing store of a reflection.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Null-check reflection->backing().
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Null-check reflection->backing().
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): reflection->backing().
(WebCore::RenderLayerCompositor::requiresCompositingLayer): If being called for a reflection layer,
use the source layer to answer the question.
- 4:09 PM Changeset in webkit [53506] by
-
- 5 edits6 adds in trunk
2010-01-19 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Another crazy counters bug
https://bugs.webkit.org/show_bug.cgi?id=11031
Added tests for dynamic DOM changes affecting counters.
- fast/css/counters/counter-increment-002.html: Added.
- fast/css/counters/counter-reset-000.html: Added.
- fast/css/counters/counter-reset-002.html: Added.
- fast/css/counters/counter-increment-002-expected.txt: Added.
- fast/css/counters/counter-reset-000-expected.txt: Added.
- fast/css/counters/counter-reset-002-expected.txt: Added.
2010-01-19 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Another crazy counters bug
https://bugs.webkit.org/show_bug.cgi?id=11031
This patch actually provides for counter updating when the style
of a renderer changes.
Tests: fast/css/counters/counter-increment-002.html
fast/css/counters/counter-reset-000.html
fast/css/counters/counter-reset-002.html
- rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererStyleChanged): This function is added to update the counter hierarchy in response to changes to the style of a renderer.
- rendering/RenderCounter.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange): For changes that may include the counter directives added a call to RenderCounter::rendererStyleChanged.
- 3:59 PM Changeset in webkit [53505] by
-
- 2 edits in trunk
Unreviewed. Shared library versioning bump for 1.1.19.
- 3:53 PM Changeset in webkit [53504] by
-
- 2 edits in trunk/LayoutTests
Land correct expected results - forgot to update them after changing test output.
- fast/dom/Attr/child-nodes-cache-expected.txt:
- 3:51 PM Changeset in webkit [53503] by
-
- 4 edits in trunk
Unreviewed. Build fixes for make distcheck.
- 3:49 PM Changeset in webkit [53502] by
-
- 6 edits in trunk/LayoutTests
2010-01-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
More flaky animation/transitions tests
https://bugs.webkit.org/show_bug.cgi?id=33872
Undo my previous changes decreasing test times. This ended up
increasing flakiness.
- animations/change-one-anim-expected.txt:
- animations/change-one-anim.html:
- animations/combo-transform-translate+scale.html:
- transitions/shorthand-border-transitions-expected.txt:
- transitions/shorthand-border-transitions.html:
- 3:32 PM Changeset in webkit [53501] by
-
- 3 edits2 adds in trunk
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33850
Attr.childNodes does not get updated after DOM mutations
Test: fast/dom/Attr/child-nodes-cache.html
- dom/Node.cpp: (WebCore::Node::notifyLocalNodeListsAttributeChanged): If the node is an attribute, then changing it shouldn't take the shortcut that only resets a subset of caches.
- 3:22 PM Changeset in webkit [53500] by
-
- 15 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=33854
Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns
more info about where the result was found
WebCore:
Reviewed by Darin Adler.
No new tests. This just adds a couple of out parameters for the benefit of WebKit clients.
- WebCore.base.exp:
Updated mangled signature for export.
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsAboveCell):
Now fills in an out parameter with the number of characters from the start of the cell.
(WebCore::Frame::searchForLabelsBeforeElement):
Now fills in an out parameter with the distance as a number of characters, and another
with a bool for whether the result was in a table cell above the current cell (otherwise
it was found in the text before this element and after the previous element or start of form).
- page/Frame.h:
Updated signatures.
- page/mac/FrameMac.mm:
(WebCore::Frame::searchForNSLabelsAboveCell):
Same as above. This is a parallel copy of the function using Mac-specific data structures.
(WebCore::Frame::searchForLabelsBeforeElement):
Ditto
WebKit/mac:
Reviewed by Darin Adler
- WebView/WebHTMLRepresentation.h:
Declare -searchForLabels:beforeElement:resultDistance:resultIsInCellAbove.
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation searchForLabels:beforeElement:]):
Now calls through to searchForLabels:beforeElement:resultDistance:resultIsInCellAbove.
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
New method, calls through to WebCore.
WebKit/win:
Reviewed by Darin Adler
- Interfaces/IWebHTMLRepresentation.idl:
Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
- Interfaces/WebKit.idl:
Touched in order to get other idl change to propagate correctly.
- WebHTMLRepresentation.cpp:
(WebHTMLRepresentation::deprecatedSearchForLabels):
Renamed since iDL doesn't support two functions with the same name but different signatures.
(WebHTMLRepresentation::searchForLabels):
Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
- WebHTMLRepresentation.h:
Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
- 3:09 PM Changeset in webkit [53499] by
-
- 1 edit7 adds in trunk/WebCore
2010-01-19 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Add (EGL) surface/context management
https://bugs.webkit.org/show_bug.cgi?id=33403
The foundations for a new OpenVG port.
OpenVG is not tied to EGL per se, EGL just happens to be
the only usable backend for OpenVG state and painting
at the time of writing.
The purpose of the SurfaceOpenVG class is to provide
an EGL-independent interface for OpenVG-specific code.
The EGLDisplayOpenVG class takes care of keeping track
of EGL displays, surfaces and contexts. It also makes
sure that all created contexts are interoperable, and
that different surfaces use a single context if possible.
- platform/graphics/openvg/EGLDisplayOpenVG.cpp: Added. (WebCore::displayManagers): (WebCore::EGLDisplayOpenVG::currentSurface): (WebCore::EGLDisplayOpenVG::registerPlatformSurface): (WebCore::EGLDisplayOpenVG::unregisterPlatformSurface): (WebCore::EGLDisplayOpenVG::setCurrentDisplay): (WebCore::EGLDisplayOpenVG::current): (WebCore::EGLDisplayOpenVG::forDisplay): (WebCore::EGLDisplayOpenVG::EGLDisplayOpenVG): (WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG): (WebCore::EGLDisplayOpenVG::setDefaultPbufferConfig): (WebCore::EGLDisplayOpenVG::defaultPbufferConfig): (WebCore::EGLDisplayOpenVG::setDefaultWindowConfig): (WebCore::EGLDisplayOpenVG::defaultWindowConfig): (WebCore::EGLDisplayOpenVG::sharedPlatformSurface): (WebCore::EGLDisplayOpenVG::createPbufferSurface): (WebCore::EGLDisplayOpenVG::surfaceForWindow): (WebCore::EGLDisplayOpenVG::surfacesCompatible): (WebCore::EGLDisplayOpenVG::destroySurface): (WebCore::EGLDisplayOpenVG::contextForSurface):
- platform/graphics/openvg/EGLDisplayOpenVG.h: Added. (WebCore::EGLDisplayOpenVG::display):
- platform/graphics/openvg/EGLUtils.h: Added. (toEGLErrorConstant):
- platform/graphics/openvg/SurfaceOpenVG.cpp: Added. (WebCore::SurfaceOpenVG::currentSurface): (WebCore::SurfaceOpenVG::SurfaceOpenVG): (WebCore::SurfaceOpenVG::~SurfaceOpenVG): (WebCore::SurfaceOpenVG::isValid): (WebCore::SurfaceOpenVG::width): (WebCore::SurfaceOpenVG::height): (WebCore::SurfaceOpenVG::sharedSurface): (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent): (WebCore::SurfaceOpenVG::flush):
- platform/graphics/openvg/SurfaceOpenVG.h: Added. (WebCore::SurfaceOpenVG::eglDisplay): (WebCore::SurfaceOpenVG::eglSurface): (WebCore::SurfaceOpenVG::eglContext):
- platform/graphics/openvg/VGUtils.h: Added. (toVGErrorConstant):
- 2:50 PM Changeset in webkit [53498] by
-
- 2 edits in trunk/WebKitTools
2010-01-19 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
[DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
https://bugs.webkit.org/show_bug.cgi?id=33783
Some listbox tests check selection behavior by click events with
"meta" or "shift" keys. Behaviors for such modifier keys are
platform-dependent. The new parameter of mouseDown() and mouseUp()
allows to specify not only concrete modifier keys such as
"shiftKey" "metaKey", but also functional names like
"addSelectionKey" "rangeSelectionKey".
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (buildModifierFlags): (-[EventSendingController mouseDown:withModifiers:]): (-[EventSendingController mouseDown:]): (-[EventSendingController mouseUp:withModifiers:]): (-[EventSendingController mouseUp:]): (-[EventSendingController keyDown:withModifiers:withLocation:]):
- 2:36 PM Changeset in webkit [53497] by
-
- 15 edits4 moves in trunk/WebCore
Renames jni_utility and jni_utility_private to JNIUtility and JNIUtilityPrivate
https://bugs.webkit.org/show_bug.cgi?id=33843
Reviewed by David Levin.
No new tests, refactoring only.
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bridge/jni/JNIUtility.cpp: Copied from WebCore/bridge/jni/jni_utility.cpp.
- bridge/jni/JNIUtility.h: Copied from WebCore/bridge/jni/jni_utility.h.
- bridge/jni/jni_jsobject.mm:
- bridge/jni/jni_objc.mm:
- bridge/jni/jni_runtime.cpp:
- bridge/jni/jni_runtime.h:
- bridge/jni/jni_utility.cpp: Removed.
- bridge/jni/jni_utility.h: Removed.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Copied from WebCore/bridge/jni/jsc/jni_utility_private.cpp.
(JSC::Bindings::convertValueToJValue):
- bridge/jni/jsc/JNIUtilityPrivate.h: Copied from WebCore/bridge/jni/jsc/jni_utility_private.h.
- bridge/jni/jsc/JavaClassJSC.cpp:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
- bridge/jni/jsc/JavaStringJSC.h:
- bridge/jni/jsc/jni_utility_private.cpp: Removed.
- bridge/jni/jsc/jni_utility_private.h: Removed.
- platform/android/GeolocationServiceBridge.cpp:
- platform/android/GeolocationServiceBridge.h:
- platform/android/TemporaryLinkStubs.cpp:
- 2:30 PM Changeset in webkit [53496] by
-
- 2 edits in trunk/WebKitTools
2010-01-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unbreak --request-commit
https://bugs.webkit.org/show_bug.cgi?id=33832
- Scripts/webkitpy/bugzilla.py:
- 2:18 PM Changeset in webkit [53495] by
-
- 3 edits8 adds in trunk
2010-01-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Some composited reflections incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=33856
When setting the position of the replicated layer inside the reflection, we need to take
into account the bounds of the original layer, and the replica layer to get the
reflection in the right place.
Tests: compositing/reflections/nested-reflection-transformed2.html
compositing/reflections/reflection-positioning2.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 2:17 PM Changeset in webkit [53494] by
-
- 3 edits2 adds in trunk
WebCore: REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=33864
<rdar://problem/7552959>
Reviewed by Simon Fraser.
Regression has been introduced by changeset 53085.
The original fix had to be limited to editable content.
Test: editing/selection/selection-applet.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
LayoutTests: REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=33864
<rdar://problem/7552959>
Reviewed by Simon Fraser.
- editing/selection/selection-applet-expected.txt: Added.
- editing/selection/selection-applet.html: Added.
- 2:14 PM Changeset in webkit [53493] by
-
- 2 edits in trunk/WebCore
2010-01-19 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix qmake warning with qmake in Qt for Symbian
https://bugs.webkit.org/show_bug.cgi?id=33786
- WebCore.pro: Use QMAKE_LFLAGS instead of MMP_RULES.
- 2:14 PM Changeset in webkit [53492] by
-
- 4 edits in trunk/LayoutTests
2010-01-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
LayoutTests/animations/play-state.html and LayoutTests/transitions/cancel-transition.html are still flaky
https://bugs.webkit.org/show_bug.cgi?id=33748
- animations/play-state-expected.txt:
- animations/play-state.html: Undo my previous change of decreasing the length of the test. I think that made it more flaky. Also increase the tolerance.
- transitions/cancel-transition.html: Undo my previous change of moving the setTimeout. It was correct where it was. Added a comment to make it more clear. The tolerances were increased since then though, so this test should no longer be flaky after this.
- 2:10 PM Changeset in webkit [53491] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/committers.py
Adding myself to committers.py.
- 1:53 PM Changeset in webkit [53490] by
-
- 2 edits in trunk/WebCore
2010-01-19 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Fixes an issue in the Apple Mac port where ScrollView::platformVisibleContentRect
returns the rectangle of the document within the content view of
the scroll view (i.e. the rectangle not including scrollbars) when
the parameter includeScrollbars == true
Currently, this behavior contradicts both the comment in ScrollView.h
for method visibleContentRect as well as the behavior in
ScrollView::visibleContentRect() for a platform-independent scroll view.
Instead, it should return the rectangle whose dimensions include
the scrollbars.
Also, removes some extra whitespace at the end of the lines.
No tests included because we cannot test this using either DRT
or a manual test.
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformVisibleContentRect): If includeScrollbars == true then return the rectangle whose dimensions are that of the frame (i.e. -[NSScrollView frame]).
- 1:51 PM Changeset in webkit [53489] by
-
- 3 edits in trunk/WebCore
Fixes style in WebCore/bridge/jni/jsc/JavaClassJSC
https://bugs.webkit.org/show_bug.cgi?id=33819
Reviewed by David Levin.
No new tests, style fixes only.
- bridge/jni/jsc/JavaClassJSC.cpp: Modified.
- bridge/jni/jsc/JavaClassJSC.h: Modified.
- 1:49 PM Changeset in webkit [53488] by
-
- 10 edits in trunk
2010-01-19 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Test changes to accomodate refactor of TimelineRecordFactory and InspectorTimelineAgent to
support reporting data when closing a record.
- inspector/timeline-layout-expected.txt:
- inspector/timeline-parse-html-expected.txt:
- inspector/timeline-recalculate-styles-expected.txt:
2010-01-19 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Refactors the TimelineRecordFactory and InspectorTimelineAgent to support reporting data
when closing a record. Also includes grabbing the start and end line number for parse HTML
records as a reference use case for the above refactor
Tests updated:
inspector/timeline-parse-html-expected.txt
inspector/timeline-layout-expected.txt
inspector/timeline-recalculate-styles-expected.txt
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchData): (WebCore::TimelineRecordFactory::createGenericTimerData): (WebCore::TimelineRecordFactory::createTimerInstallData): (WebCore::TimelineRecordFactory::createXHRReadyStateChangeData): (WebCore::TimelineRecordFactory::createXHRLoadData): (WebCore::TimelineRecordFactory::createEvaluateScriptData): (WebCore::TimelineRecordFactory::createMarkTimelineData): (WebCore::TimelineRecordFactory::createResourceSendRequestData): (WebCore::TimelineRecordFactory::createResourceReceiveResponseData): (WebCore::TimelineRecordFactory::createResourceFinishData): (WebCore::TimelineRecordFactory::createPaintData): (WebCore::TimelineRecordFactory::createParseHTMLData):
- inspector/TimelineRecordFactory.h:
- 1:31 PM Changeset in webkit [53487] by
-
- 4 edits in trunk
2010-01-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
Moves the text assembling functionality from getPangoLayoutForAtk to
textForObject, which webkit_accessible_text_get_text now falls back on
when it comes up empty.
Adds a check in textForObject so that we don't double-add newlines
when we have a BR.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): (getPangoLayoutForAtk): (webkit_accessible_text_get_text):
2010-01-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
Adds two news tests.
- tests/testatk.c (testWebkitAtkGetTextInParagraphAndBodySimple): (testWebkitAtkGetTextInParagraphAndBodyModerate): (main):
- 1:07 PM Changeset in webkit [53486] by
-
- 3 edits2 adds in trunk
2010-01-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
error events don't fire if no <source> elements passed to media engine
https://bugs.webkit.org/show_bug.cgi?id=33855
Test: media/video-source-error-no-candidate.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Only bail early if there is no 'src' attribute and no <source> child elements at all.
2010-01-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
error events don't fire if no <source> elements passed to media engine
https://bugs.webkit.org/show_bug.cgi?id=33855
- media/video-source-error-no-candidate-expected.txt: Added.
- media/video-source-error-no-candidate.html: Added.
- 1:04 PM Changeset in webkit [53485] by
-
- 2 edits in trunk/WebCore
2010-01-19 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
REGRESSION(r53273): Fixes redefinition of XFORM error when building
WebKit using Qt Windows with the MinGW compiler.
Note, MinGW has a slightly different declaration of the struct XFORM
from that in the Microsoft SDK. So, we need to substitute an alternative
typedef for XFORM when compiling with MinGW.
No functionality was changed. So, no new tests.
- platform/graphics/transforms/TransformationMatrix.h:
- 12:53 PM Changeset in webkit [53484] by
-
- 3 edits in trunk/WebKitTools
2010-01-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
validate-committer-lists throws exception and committers.py needs a refresh
https://bugs.webkit.org/show_bug.cgi?id=33831
- Scripts/validate-committer-lists: use webkit_logging
- Scripts/webkitpy/committers.py: Add recently minted committers. Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
- 12:40 PM Changeset in webkit [53483] by
-
- 4 edits in trunk
Versioning.
- 12:39 PM Changeset in webkit [53482] by
-
- 1 copy in tags/Safari-532.8
New tag.
- 12:22 PM Changeset in webkit [53481] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
News items for 1.1.19.
- NEWS:
- 12:19 PM Changeset in webkit [53480] by
-
- 2 edits in trunk/WebCore
Fix for crash on large TransparencyWin allocation. The fix is
to leave m_layerValid false when the allocPixels of
OwnedBuffers::m_referenceBitmap fails. Then TransparencyWin won't
attempt to use it.
Reviewed by Dimitri Glazkov.
Will be covered by a new unit test in Chromium's test_shell_tests (when
this is rolled into Chromium).
https://bugs.webkit.org/show_bug.cgi?id=33844
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::initializeNewContext):
Early return when m_referenceBitmap or its pixels is NULL, leaving
m_layerValid false.
- 11:48 AM Changeset in webkit [53479] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-19 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix for JIT with RVCT.
Remove IMPORT statement; cti_vm_throw is already defined in JITStubs.h.
Remove extra ')'.
- jit/JITStubs.cpp: (JSC::ctiVMThrowTrampoline):
- 11:31 AM Changeset in webkit [53478] by
-
- 4 edits2 adds in trunk
2010-01-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
video.networkState remains NETWORK_LOADING indefinitely when no <source> element was able to be loaded
https://bugs.webkit.org/show_bug.cgi?id=33744
Test: media/video-source-none-supported.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadNextSourceChild): Call waitForSourceChange if
there are no valid source elements.
(WebCore::HTMLMediaElement::waitForSourceChange): New, set networkState to NETWORK_NO_SOURCE.
(WebCore::HTMLMediaElement::setNetworkState): Call waitForSourceChange if the movie
hasn't reached HAVE_METADATA and there are no more <source> elements to try.
- html/HTMLMediaElement.h: Declare waitForSourceChange.
2010-01-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
video.networkState remains NETWORK_LOADING indefinitely when no <source> element was able to be loaded
https://bugs.webkit.org/show_bug.cgi?id=33744
- media/video-source-none-supported-expected.txt: Added.
- media/video-source-none-supported.html: Added.
- 11:11 AM Changeset in webkit [53477] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
[GTK] More crashes related to the clipboard management
https://bugs.webkit.org/show_bug.cgi?id=33746
Pass the WebKitWebView object (which is a GObject, thus
ref-counted) to the clipboard functions instead of passing the
Page - this allows us to explicitely protect the object inbetween
the clipboard call and its callbacks, which fixes the crash.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::getClipboardContentsCallback): (WebKit::clearClipboardContentsCallback): (WebKit::PasteboardHelperGtk::writeClipboardContents):
- 10:48 AM Changeset in webkit [53476] by
-
- 4 edits10 adds in trunk
2010-01-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Treat.
Implements an optimization to ignore fixed background images
(i.e. background-attachment: fixed) when a page does not contain
any fixed position elements so as to allow fast repaints (via bit
blit) when scrolling a page.
Currently, if a page has elements that specify either a fixed
background or a fixed position then we perform a slow repaint
(i.e disable blitting) so as to avoid rendering artifacts.
However, on low-powered/mobile devices slow repaints can cause
noticeable delays when scrolling a page with a fixed background
image. By sacrificing support for fixed background images when
there are no fixed elements on the page and with come care, we
don't need to force slow repaints and can avoid rendering artifacts.
Hence, on such devices we can improve the responsiveness of
scrolling a page with a fixed background image.
Note, this optimization is only enabled if the WebKit is built
with FAST_MOBILE_SCROLLING enabled.
Tests: fast/fast-mobile-scrolling/fixed-position-element.html
fast/fast-mobile-scrolling/no-fixed-position-elements.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Disable fixed background attachment if we can blit on scroll.
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
2010-01-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Treat.
Tests that fixed background images are ignored when there are no
fixed elements on a page and honored otherwise.
Note, includes expected failure results for the test
fast/fast-mobile-scrolling/no-fixed-position-elements.html, since
the Mac and Windows ports do not support FAST_MOBILE_SCROLLING.
- fast/fast-mobile-scrolling: Added.
- fast/fast-mobile-scrolling/fixed-position-element.html: Added.
- fast/fast-mobile-scrolling/no-fixed-position-elements.html: Added.
- platform/mac/fast/fast-mobile-scrolling: Added.
- platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
- platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
- platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
- platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
- platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added. Expected failure result since the Mac port does not enable FAST_MOBILE_SCROLLING.
- platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added. Expected failure result since the Mac port does not enable FAST_MOBILE_SCROLLING.
- 10:29 AM Changeset in webkit [53475] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebScriptWorld.cpp: Added missing #include.
- 10:26 AM Changeset in webkit [53474] by
-
- 2 edits in trunk/WebCore
Build bustage fix. Land modified WebCore.base.exp file that includes export of currentWorld().
- WebCore.base.exp:
- 10:24 AM Changeset in webkit [53473] by
-
- 2 edits in trunk/WebKit/win
Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.
- Interfaces/IWebScriptWorld.idl:
- 10:17 AM Changeset in webkit [53472] by
-
- 3 edits2 adds in trunk
Crash in Page::backForwardList when using History object from a detached window
<rdar://problem/7556252> and https://bugs.webkit.org/show_bug.cgi?id=33828
Reviewed by Alexey Proskuryakov.
WebCore:
Test: fast/loader/stateobjects/state-api-on-detached-frame-crash.html
- page/History.cpp:
(WebCore::History::stateObjectAdded): Do an early return when detached. The spec
doesn't really cover expected behavior and we already do something similar in
other places, such as in History::length().
LayoutTests:
- fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt: Added.
- fast/loader/stateobjects/state-api-on-detached-frame-crash.html: Added.
- 10:11 AM Changeset in webkit [53471] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix build.
- 9:53 AM Changeset in webkit [53470] by
-
- 7 edits in trunk/WebKit
WebKit/mac: Add an API to obtain the WebScriptWorld for a given JSGlobalContextRef.
Reviewed by Adam Roben.
- WebView/WebScriptWorld.h:
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld scriptWorldForGlobalContext:]):
WebKit/win: Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.
Reviewed by Adam Roben.
- Interfaces/IWebScriptWorld.idl:
- WebScriptWorld.cpp:
(WebScriptWorld::scriptWorldForGlobalContext):
- WebScriptWorld.h:
- 9:00 AM Changeset in webkit [53469] by
-
- 42 edits in trunk
2010-01-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by NOBODY (build fix).
Revert r53467. Browser crashes on opening inspector if there
are messages in console.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::inspectedWindow): (WebCore::JSInjectedScriptHost::wrapCallback): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::wrapObject): (WebCore::JSInjectedScriptHost::unwrapObject): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptObject.h:
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptObject.h:
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectedWindowCallback): (WebCore::V8InjectedScriptHost::wrapCallbackCallback): (WebCore::V8InjectedScriptHost::wrapObjectCallback): (WebCore::V8InjectedScriptHost::unwrapObjectCallback):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::wrapObject): (WebCore::InjectedScriptHost::unwrapObject):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject): (WebCore::InspectorController::releaseWrapperObjectGroup): (WebCore::InspectorController::resetInjectedScript):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- inspector/front-end/EventListenersSidebarPane.js: ():
- inspector/front-end/InjectedScript.js: (InjectedScript.dispatch): (InjectedScript.toggleStyleEnabled): (InjectedScript._serializeRule): (InjectedScript._serializeStyle): (InjectedScript.getProperties): (InjectedScript.setPropertyValue): (InjectedScript._evaluateAndWrap): (InjectedScript.getCallFrames): (InjectedScript._inspectObject): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._resolveObject): (InjectedScript._window): (InjectedScript._objectForId): (InjectedScript.createProxyObject): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction): (Object.type): (String.prototype.escapeCharacters):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback): (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy): (WebInspector.ObjectProxy.getPropertiesAsync):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
2010-01-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by NOBODY (build fix).
Revert r53467. Browser crashes on opening inspector if there
are messages in console.
- inspector/styles-iframe.html:
- 7:48 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 6:50 AM Changeset in webkit [53468] by
-
- 2 edits in trunk/WebKit/mac
Unreviewed build fix.
Fixes Snow Leopard build due to http://trac.webkit.org/changeset/53464
- Plugins/Hosted/WebHostedNetscapePluginView.mm: Modified. Import <WebCore/Bridge.h>
- 6:27 AM Changeset in webkit [53467] by
-
- 42 edits in trunk
2010-01-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
- bindings/v8/ScriptValue.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- inspector/front-end/EventListenersSidebarPane.js: ():
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
- inspector/front-end/ObjectPropertiesSection.js:
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
2010-01-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.
Refactor test case due to InjectedScriptAccess changes.
- inspector/styles-iframe.html:
- 6:04 AM Changeset in webkit [53466] by
-
- 2 edits in trunk/LayoutTests
2010-01-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Shinichiro Hamaji.
[Chromium] layout_test on linux fails on doubleclick-beside-cr-span.html
Place larger margins before clicking position to grab certain words
instead of clicking blank, whitespaces or tabs before that words.
Note that widths of rendered tab characters are hard to predict,
So such margins are particularly helpful with them.
- editing/selection/doubleclick-beside-cr-span.html: Fix to compute click position using actual character width.
- 4:30 AM Changeset in webkit [53465] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Fixes Windows build due to http://trac.webkit.org/changeset/53464
Updates WebCore.vcproj to reflect renaming of runtime.[cpp|h] to Bridge.[cpp|h]
No new tests, build fix only.
- WebCore.vcproj/WebCore.vcproj:
- 3:51 AM Changeset in webkit [53464] by
-
- 43 edits2 moves in trunk
Renames WebCore/bridge/runtime.[cpp|h] to WebCore/bridge/Bridge.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=33801
Reviewed by Adam Barth.
- 3:04 AM Changeset in webkit [53463] by
-
- 3 edits in trunk/LayoutTests
[Qt] REGRESSION (r53450): 3 tests fail on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=33834
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/Skipped:
- css1/box_properties/acid_test.html skipped.
- fast/forms/textarea-scrollbar-height.html skipped.
- platform/qt/css1/font_properties/font-expected.txt: updated.
- 2:50 AM WebKit Team edited by
- typo fix (diff)
- 1:06 AM Changeset in webkit [53462] by
-
- 2 edits in trunk/LayoutTests
2010-01-19 Xan Lopez <xlopez@igalia.com>
svg/custom/use-instanceRoot-event-bubbling.xhtml is flakey
https://bugs.webkit.org/show_bug.cgi?id=33835
Skip flakey test.
- platform/gtk/Skipped:
- 12:56 AM Changeset in webkit [53461] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-01-19 Xan Lopez <xlopez@igalia.com>
New baseline for failing test.
- platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Copied from LayoutTests/platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt.
- 12:39 AM Changeset in webkit [53460] by
-
- 7 edits2 adds in trunk
JavaScriptCore: REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
Reviewed by Oliver Hunt.
This bug was caused by a GC-protected object being destroyed early by
Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
to GC-protected memory to be valid.
The solution is to do two passes of tear-down in Heap::destroy. The first
pass tears down all unprotected objects. The second pass ASSERTs that all
previously protected objects are now unprotected, and then tears down
all perviously protected objects. These two passes simulate the two passes
that would have been required to free a protected object during normal GC.
- API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.
- runtime/Collector.cpp:
(JSC::Heap::destroy): Moved ASSERTs to here.
(JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its
setter to the function that does the shrinking.
(JSC::Heap::freeBlocks): Implemented above algorithm.
(JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.
WebCore: REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
Reviewed by Oliver Hunt.
Test: fast/workers/worker-gc2.html
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController): Removed some
ASSERTs that have moved to JavaScriptCore.
LayoutTests: REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
Reviewed by Oliver Hunt.
Added a test for this edge case.
- fast/workers/resources/worker-gc2.js: Added.
(Dummy):
- fast/workers/worker-gc2.html: Added.
- 12:25 AM Changeset in webkit [53459] by
-
- 6 edits2 deletes in trunk
Reverting r53455, breaks 2 javascriptcore tests.
Reviewed by NOBODY (build fix).
- API/JSContextRef.cpp:
- runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrinkBlocks):
WebCore:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
LayoutTests:
- fast/workers/resources/worker-gc2.js: Removed.
- fast/workers/worker-gc2.html: Removed.
- 12:25 AM WebKit Team edited by
- (diff)
- 12:20 AM WebKit Team edited by
- (diff)
- 12:19 AM WebKit Team edited by
- (diff)
- 12:14 AM Changeset in webkit [53458] by
-
- 1 edit1 add in trunk/LayoutTests
Forgot to add this test result.
- fast/workers/worker-gc2-expected.txt: Added.
- 12:05 AM Changeset in webkit [53457] by
-
- 2 edits in trunk/LayoutTests
2010-01-19 Xan Lopez <xlopez@igalia.com>
Skip tests generating new results.
- platform/gtk/Skipped:
Jan 18, 2010:
- 11:58 PM WebKit Team edited by
- (diff)
- 11:22 PM Changeset in webkit [53456] by
-
- 5 edits in trunk/JavaScriptCore
Revert r53454, since it causes much sadness in this world.
Patch by Gavin Barraclough <barraclough@apple.com> on 2010-01-18
Reviewed by NOBODY (build fix).
- runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- 11:00 PM Changeset in webkit [53455] by
-
- 6 edits2 adds in trunk
2010-01-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
This bug was caused by a GC-protected object being destroyed early by
Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
to GC-protected memory to be valid.
The solution is to do two passes of tear-down in Heap::destroy. The first
pass tears down all unprotected objects. The second pass ASSERTs that all
previously protected objects are now unprotected, and then tears down
all perviously protected objects. These two passes simulate the two passes
that would have been required to free a protected object during normal GC.
- API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.
- runtime/Collector.cpp: (JSC::Heap::destroy): Moved ASSERTs to here. (JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its setter to the function that does the shrinking. (JSC::Heap::freeBlocks): Implemented above algorithm. (JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.
2010-01-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
Test: fast/workers/worker-gc2.html
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController): Removed some ASSERTs that have moved to JavaScriptCore.
2010-01-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
Added a test for this edge case.
- fast/workers/resources/worker-gc2.js: Added. (Dummy):
- fast/workers/worker-gc2.html: Added.
- 9:51 PM Changeset in webkit [53454] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).
Patch by Gavin Barraclough <barraclough@apple.com> on 2010-01-18
Reviewed by Oliver Hunt.
This break the OS X Leaks tool. Instead, free up some more bits from the refCount.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- 8:32 PM Changeset in webkit [53453] by
-
- 1 edit1 add in trunk/LayoutTests
2010-01-18 Daniel Bates <dbates@webkit.org>
Unreviewed. Add expected results for Windows.
- platform/win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
- 7:10 PM Changeset in webkit [53452] by
-
- 10 edits2 adds in trunk
2010-01-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Implements all of the alphabetic CSS3 list-style-types as per
section 4.4 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#alphabetic>.
Test: fast/lists/w3-css3-list-styles-alphabetic.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated comment to include added list-style-types.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added new list style types, alphabetized enums, and removed indent to conform to the WebKit Code Style Guidelines.
- css/CSSValueKeywords.in:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: (WebInspector.CSSSourceSyntaxHighlighter): Added new list style types and alphabetized array valueKeywords.
- platform/text/CharacterNames.h: Added constant ethiopicPrefaceColon.
- rendering/RenderListMarker.cpp: (WebCore::toAlphabetic): (WebCore::listMarkerSuffix): Added. (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): Modified to call WebCore::listMarkerSuffix. (WebCore::RenderListMarker::calcPrefWidths): Ditto. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: (WebCore::):
2010-01-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that all of the alphabetic CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-alphabetic.html: Added.
- platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
- 7:08 PM Changeset in webkit [53451] by
-
- 2 edits in trunk/WebCore
2010-01-18 Daniel Bates <dbates@webkit.org>
Unreviewed, fix misspelling of the word maximum in comment.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::maximum):
- 6:59 PM Changeset in webkit [53450] by
-
- 17 edits in trunk
Rubber-stamped by Sam Weinig.
<rdar://problem/7476957> REGRESSION (r49567): Business widget list does not line up: too tall due to line height rounding change
WebCore:
Reverted r49567.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::computedLineHeight):
LayoutTests:
Reverted r49567, but left in the test added in that revision, now with a failing result.
- css1/font_properties/font.html:
- fast/css/line-height-rounding-expected.txt:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-ln-03-d-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
- 6:56 PM Changeset in webkit [53449] by
-
- 4 edits1 add in trunk/WebCore
Moves JSC-specific implementation of JavaString to a private implementation class.
https://bugs.webkit.org/show_bug.cgi?id=33558
Reviewed by Adam Barth.
Also modifies JavaField::name and JavaMethod::name to return const JavaString&, rather than UString::Rep*,
which is JSC-specific. This allows this code to be used with both JSC and V8, as required by Android.
No new tests, refactoring only.
- WebCore.xcodeproj/project.pbxproj: Modified. Added JavaStringJSC.h
- bridge/jni/jni_class.cpp: Modified.
(JavaClass::JavaClass): Modified. Updates call sites of JavaField::name and JavaMethod::name.
- bridge/jni/jni_runtime.h: Modified.
(JSC::Bindings::JavaString::JavaString): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::UTF8String): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::uchars): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::length): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::operator UString): Modified. Pass through to implementation.
(JSC::Bindings::JavaField::name): Modified. Pass through to implementation.
(JSC::Bindings::JavaMethod::name): Modified. Pass through to implementation.
- bridge/jni/jsc/JavaStringJSC.h: Added.
(JSC::Bindings::JavaStringImpl::~JavaStringImpl):
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
(JSC::Bindings::JavaStringImpl::uString):
- 6:53 PM Changeset in webkit [53448] by
-
- 4 edits in trunk
2010-01-18 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Skip an error after invalid blocks in a CSS expression.
https://bugs.webkit.org/show_bug.cgi?id=33650
- fast/css/parsing-error-recovery.html:
2010-01-18 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Skip an error after invalid blocks in a CSS expression.
https://bugs.webkit.org/show_bug.cgi?id=33650
- css/CSSGrammar.y:
- 6:22 PM Changeset in webkit [53447] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.
Reviewed by Darin Adler & Oliver Hunt.
These break the OS X Leaks tool. Move the management of null-terminated copies
out from StringImpl to String, and use a bit stolen from the refCount to hold the
'InTable' flag.
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
- platform/sql/SQLiteStatement.h:
- platform/text/PlatformString.h:
- platform/text/String.cpp:
(WebCore::String::copyWithNullTermination):
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
- 6:20 PM WikiStart edited by
- (diff)
- 6:17 PM Changeset in webkit [53446] by
-
- 32 edits12 adds in trunk
2010-01-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Rewrite SVG <use> support in a modern-fashion
https://bugs.webkit.org/show_bug.cgi?id=33776
Tests: svg/custom/relative-sized-deep-shadow-tree-content.xhtml
svg/custom/relative-sized-shadow-tree-content.xhtml
Fixes: svg/W3C-SVG-1.1/animate-elem-30-t.svg (animated circle sometimes takes wrong path)
Rewrite <use> support in less intrusive way. Try hard to avoid recloning where possible, and do it lazily.
Introduce RenderSVGShadowTreeRootContainer as special renderer for SVGUseElement, that now manages the
render tree, instead of SVGUseElement manually hacking around it's own renderer from the DOM side.
Instead of recloning the whole shadow tree for every attribute change (DOM setAttribute / SVG DOM changes / CSS changes / childrenChanged()...)
just notify the RenderSVGShadowTreeRootContainer that it's supposed to reclone the tree upon the next updateFromElement() call.
updateFromElement() is fired from SVGUseElement::attach() / recalcStyle(), as it's done for HTMLFormControlElement/HTMLMediaElement, thus
lazily recloning the shadow tree if necessary.
Animations for <use> elements was a real performance bottlenck as the tree got recloned on every attribute change. Reclones are _completly_
avoided for animations now - the SVGAnim*Element classes already updated the instances of an element manually, though that resulted in a reclone
nontheless, and thus killing performance. <use> elements can only be recloned through mutations of the elements that they reference to.
For example referencing a <rect> element from a <use> element and scripting the <rect> element (setAttribute, or child tree mutations etc.).
We reclone instead of trying to synchronize trees - as it's currenty implemented - because it's very hard to do it right.
Any DOM / SVG DOM / CSS change on the <use> element don't reclone the tree anymore, this is a huge speed benefit.
x/y attribute changes are correctly handled in the render tree now (by an additional local transformation), now percentual values work
as expected, and resize on window changes - affecting lots of testcases.
The <use> implementation is much safer now, not doing any mutations synchronously from svgAttributeChanged etc.
Remove hack to force garbage collection on SVGElementInstance destruction - can't reproduce it anymore.
- Android.mk: Add new files to build.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderSVGShadowTreeRootContainer.cpp: Added. This is the rendered now created by SVGUseElement. (WebCore::RenderSVGShadowTreeRootContainer::RenderSVGShadowTreeRootContainer): (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer): (WebCore::RenderSVGShadowTreeRootContainer::updateStyle): Used form SVGUseElement to request style recalculations for the shadow tree renderers (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement): Used from SVGUseElement attach/recalcStyle to eventually request shadow tree updates. (WebCore::RenderSVGShadowTreeRootContainer::styleDidChange): Used to propage style updates across shadow tree boundaries.
- rendering/RenderSVGShadowTreeRootContainer.h: Added. (WebCore::RenderSVGShadowTreeRootContainer::markShadowTreeForRecreation): Marks the shadow tree for a reclone, next time updateFromElement is used.
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Take containerTranslation() into account, supplied by RenderSVGSDhadowTreeContainer.
- rendering/SVGShadowTreeElements.cpp: Added. This is the root element of the SVG shadow tree residing as (hidden) child of SVGUseElement (DOM wise). (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement): (WebCore::SVGShadowTreeContainerElement::~SVGShadowTreeContainerElement): (WebCore::SVGShadowTreeContainerElement::containerTranslation): Used from calculateLocalTransform() to take x/y translation into account for shadow tree container elements. (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): (WebCore::SVGShadowTreeRootElement::~SVGShadowTreeRootElement): (WebCore::SVGShadowTreeRootElement::attachElement): Used by RenderSVGShadowTreeRootContainer, instead of attach(), as we're a shadow tree root node.
- rendering/SVGShadowTreeElements.h: Added. This is the root element of each SVG shadow sub-tree (whenever a <use> element is expanded in the shadow tree). (WebCore::SVGShadowTreeContainerElement::isShadowTreeContainerElement): Return true here. (WebCore::SVGShadowTreeContainerElement::setContainerOffset): Used from SVGUseElement to propagate x/y translation values set on <use> elements in the shadow tree. (WebCore::SVGShadowTreeRootElement::isShadowNode): Identify us as shadow node. (WebCore::SVGShadowTreeRootElement::shadowParentNode): Ditto. Return actual shadow parent node (== corresponding use element).
- svg/SVGElement.cpp: Shrink size of all SVG*Elements, by removing the m_shadowParent parent. SVGShadowTreeRootElement is the new base class for shadow tree. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::eventParentNode): Call virtual shadowParentNode() method, instead of accessing m_shadowParent.
- svg/SVGElement.h: Remove isShadowNode() / shadowParentNode() / setShadowParentNode().
- svg/SVGElementInstance.cpp: Remove the hack, calling garbage collection before destruction. Can't reproduce this anymore, let's see what the bots say. (WebCore::SVGElementInstance::SVGElementInstance): Remove now unnecessary m_needsUpdate flag. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Don't invalidate if instance updates are blocked (see SVGStyledElement changes)
- svg/SVGElementInstance.h: Remove m_needsUpdate, and forgetWrapper() method.
- svg/SVGGElement.h: (WebCore::SVGGElement::isShadowTreeContainerElement): Add new virtual method here returning false by default, SVGShadowTreeContainerElement will override it.
- svg/SVGStyledElement.cpp: Remove gElementsWithInstanceUpdatesBlocked HashSet tracking the state of instancesUpdatesBlocked() per SVGStyledElement - make it a member variable.
- svg/SVGStyledElement.h: Add inline getter/setters around m_instanceUpdatesBlocked. (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
- svg/SVGUseElement.cpp: Full rewrite of <use> support, a detailed discussion would blow the ChangeLog - see short version above. (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::instanceRoot): (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::removedFromDocument): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::updateContainerOffset): (WebCore::SVGUseElement::updateContainerOffsets): (WebCore::SVGUseElement::recalcStyle): (WebCore::dumpInstanceTree): (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::createRenderer): (WebCore::updateFromElementCallback): (WebCore::SVGUseElement::attach): (WebCore::SVGUseElement::detach): (WebCore::SVGUseElement::toClipPath): (WebCore::SVGUseElement::buildInstanceTree): (WebCore::SVGUseElement::handleDeepUseReferencing): (WebCore::SVGUseElement::buildShadowTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree): (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): (WebCore::SVGUseElement::instanceForShadowTreeElement): (WebCore::SVGUseElement::invalidateShadowTree): (WebCore::SVGUseElement::transferUseAttributesToReplacedElement):
- svg/SVGUseElement.h: (WebCore::SVGUseElement::isPendingResource):
2010-01-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Rewrite SVG <use> support in a modern-fashion
https://bugs.webkit.org/show_bug.cgi?id=33776
Update some test results, after rewriting <use> support.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.checksum: Added.
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Added.
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.checksum: Added.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png: Added.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
- platform/mac/svg/custom/use-events-crash-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
- platform/mac/svg/custom/use-recursion-1-expected.txt:
- platform/mac/svg/custom/use-recursion-2-expected.txt:
- platform/mac/svg/custom/use-recursion-3-expected.txt:
- platform/mac/svg/custom/use-recursion-4-expected.txt:
- platform/mac/svg/hixie/error/017-expected.txt:
- platform/mac/svg/text/text-text-05-t-expected.checksum:
- platform/mac/svg/text/text-text-05-t-expected.png:
- svg/custom/relative-sized-deep-shadow-tree-content.xhtml: Added.
- svg/custom/relative-sized-shadow-tree-content.xhtml: Added.
- svg/text/text-text-05-t.svg: Remove possible race-condition, between selecting & dumping.
- 5:49 PM Changeset in webkit [53445] by
-
- 14 edits in trunk
2010-01-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=month.
https://bugs.webkit.org/show_bug.cgi?id=33021
Expose the following functions to be used by WebCore:
- WTF::msToyear()
- WTF::dayInYear()
- WTF::monthFromDayInYear()
- WTF::dayInMonthFromDayInYear()
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/DateMath.cpp: (WTF::msToYear): Remove "static inline". (WTF::dayInYear): Remove "static inline". (WTF::monthFromDayInYear): Remove "static inline". (WTF::dayInMonthFromDayInYear): Remove "static inline".
- wtf/DateMath.h: Declare the above functions.
2010-01-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=month.
https://bugs.webkit.org/show_bug.cgi?id=33021
Add setter tests to input-valueasdate-month.js, and update the
expectation.
- fast/forms/input-valueasdate-expected.txt:
- fast/forms/input-valueasdate-month-expected.txt:
- fast/forms/script-tests/input-valueasdate-month.js:
- fast/forms/script-tests/input-valueasdate.js:
2010-01-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=month.
https://bugs.webkit.org/show_bug.cgi?id=33021
Introduce ISODateTime::setMillisecondsSinceEpochForMonth() and
toString() for the Month type, and HTMLInputElement::setValueAsDate()
calls them.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueAsDate):
- html/ISODateTime.cpp: (WebCore::beforeGregorianStartDate): (WebCore::ISODateTime::addDay): Use beforeGregorianStartDate(). (WebCore::ISODateTime::parseMonth): Use beforeGregorianStartDate(). (WebCore::ISODateTime::setMillisecondsSinceEpochForDateInternal): (WebCore::ISODateTime::setMillisecondsSinceEpochForMonth): (WebCore::ISODateTime::toString): Implement only for the Month type.
- html/ISODateTime.h:
- 5:19 PM Changeset in webkit [53444] by
-
- 2 edits in trunk/JavaScriptCore
Fix build by reverting the previous change.
- runtime/UString.h: Rolled out the FastAllocBase base class.
It was making UString larger, and therefore JSString larger,
and too big for a garbage collection cell.
This raises the unpleasant possibility that many classes became
larger because we added the FastAllocBase base class. I am
worried about this, and it needs to be investigated.
- 5:12 PM Changeset in webkit [53443] by
-
- 5 edits2 moves in trunk/WebCore
Script attributes are copied and pasted, making cross-domain attacks possible (30019)
<rdar://problem/6008809>
https://bugs.webkit.org/show_bug.cgi?id=30019
Patch by Enrica Casucci <enrica@apple.com> on 2010-01-18
Reviewed by Darin Adler.
When we create the document fragment from a markup string,
either to perform a paste operation or a drag and drop, we
want to remove all the event handlers and any attribute that contain
a value that leads to code execution.
The HTMLParser class is now aware of the needs of stripping these attributes.
I've modified the call to createMarkupString for every platform.
Test: editing/pasteboard/paste-noscript.html
- WebCore.base.exp:
- dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::setAttributeMap):
- dom/Element.h:
- dom/MappedAttributeEntry.h:
(WebCore::):
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
- editing/markup.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
- html/HTMLElement.h:
- html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::parseToken):
- html/HTMLParser.h:
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::parseHTMLDocumentFragment):
- html/HTMLTokenizer.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCF_HTML):
(WebCore::fragmentFromHTML):
- 5:07 PM Changeset in webkit [53442] by
-
- 23 edits2 adds in trunk
Script attributes are copied and pasted, making cross-domain attacks possible (30019)
<rdar://problem/6008809>
https://bugs.webkit.org/show_bug.cgi?id=30019
Reviewed by Darin Adler.
WebCore:
When we create the document fragment from a markup string,
either to perform a paste operation or a drag and drop, we
want to remove all the event handlers and any attribute that contain
a value that leads to code execution.
The HTMLParser class is now aware of the needs of stripping these attributes.
I've modified the call to createMarkupString for every platform.
Test: editing/pasteboard/paste-noscript.html
- WebCore.base.exp:
- dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::setAttributeMap):
- dom/Element.h:
- dom/MappedAttributeEntry.h:
(WebCore::):
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
- editing/markup.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
- html/HTMLElement.h:
- html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::parseToken):
- html/HTMLParser.h:
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::parseHTMLDocumentFragment):
- html/HTMLTokenizer.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCF_HTML):
(WebCore::fragmentFromHTML):
WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Modified the call to createMarkupString.
LayoutTests:
- editing/pasteboard/paste-noscript-expected.txt: Added.
- editing/pasteboard/paste-noscript.html: Added.
- 5:05 PM Changeset in webkit [53441] by
-
- 3 edits in trunk/WebCore
<https://bugs.webkit.org/show_bug.cgi?id=33816>
Crashes in Geolocation code due to refcounting, observer balance issues.
Reviewed by Sam Weinig.
Hold a ref to the GeoNotifier while dispatching a callback. The code was
copying a data member to avoid accessing a freed this ptr, but was still
using the this ptr.
Geolocation::removeObserver calls are not always balanced with addObserver.
Instead of asserting and continuing, don't try to remove non-existant
observers.
- page/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::timerFired): Protect notifier.
- page/GeolocationController.cpp:
(WebCore::GeolocationController::removeObserver): Change ASSERT into an if with early return.
- 5:03 PM Changeset in webkit [53440] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Sam Weinig.
Add missing export for Geolocation.
- WebKit.exp:
- 4:53 PM Changeset in webkit [53439] by
-
- 5 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33815
Crash when using DOMTimer from a detached frame
Test: fast/dom/Window/timer-null-script-execution-context.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- page/DOMWindow.h:
- page/DOMWindow.idl: Make setTimer and setInterval raise an exception. It is not specified in HTML5, but both IE and Firefox do raise an exception in this situation, although different ones.
- page/DOMWindow.cpp: (WebCore::DOMWindow::setTimeout): Raise INVALID_ACCESS_ERR if script execution context is null (meaning that the window is detached). (WebCore::DOMWindow::setInterval): Ditto. (WebCore::DOMWindow::clearTimeout): Silently return early if there is no script execution context. (WebCore::DOMWindow::clearInterval): Ditto. Raise INVALID_ACCESS_ERR if script execution context is null (meaning .
- 4:50 PM Changeset in webkit [53438] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-18 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for UString class
https://bugs.webkit.org/show_bug.cgi?id=27831
Inherits the following class from FastAllocBase because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at:
classs UString - JavaScriptCore/runtime/UString.cpp:160
- runtime/UString.h:
- 4:02 PM Changeset in webkit [53437] by
-
- 4 edits in trunk/JavaScriptCore
Add some ALWAYS_INLINE for key functions not inlined by some versions of GCC.
rdar://problem/7553780
Patch by Evan Cheng <evan.cheng@apple.com> on 2010-01-18
Reviewed by Darin Adler.
- runtime/JSObject.h:
(JSC::JSObject::getPropertySlot): ALWAYS_INLINE both overloads.
- runtime/JSString.h:
(JSC::JSString::JSString): ALWAYS_INLINE the version that takes a UString.
- runtime/UString.h:
(JSC::operator==): ALWAYS_INLINE the version that compares two UString objects.
- 3:49 PM Changeset in webkit [53436] by
-
- 5 edits in trunk/WebCore
2010-01-18 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Fix style in WebCore/bridge/jni/jsc/JavaInstanceJSC.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=33792
No new tests, style fixes only.
- bridge/jni/jni_runtime.cpp: Modified. (JavaField::dispatchValueFromInstance): Modified. Updated to use renamed JavaInstance::m_instance (JavaField::dispatchSetValueToInstance): Modified. Updated to use renamed JavaInstance::m_instance (JavaArray::JavaArray): Modified. Updated to use renamed JavaInstance::m_instance
- bridge/jni/jni_runtime.h: Modified. (JSC::Bindings::JavaArray::javaArray): Modified. Updated to use renamed JavaInstance::m_instance
- bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Fixed style
- bridge/jni/jsc/JavaInstanceJSC.h: Modified. Fixed style
- 3:14 PM Changeset in webkit [53435] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Tim Hatcher.
Updated Windows results after r53424.
- platform/win/fast/css/zoom-body-scroll-expected.txt: Added.
- 3:09 PM Changeset in webkit [53434] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=30073
Moved reshape to HTMLCanvasElement::reset and have it always
set the size to the canvas width and height attrs.
This is not testable with LayoutTests, so I instead added logic
to the demo at:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/webkit/SpinningBox.html
- 2:51 PM Changeset in webkit [53433] by
-
- 3 edits2 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=33813
<rdar://problem/7545104> Crash when using DOMApplicationCache from a destroyed frame
Test: http/tests/appcache/destroyed-frame.html
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext): Return null when there is no frame.
- 2:20 PM Changeset in webkit [53432] by
-
- 3 edits4 adds in trunk
REGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
https://bugs.webkit.org/show_bug.cgi?id=33809
Reviewed by Darin Adler.
WebCore:
Test: fast/repaint/trailing-floats-root-line-box-overflow.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Copy bottom overflow from the last
root box to the trailing floats box, which is becoming the last root box. This is
needed because painting code assumes that the last line in a block is the one with the
lowest overflow bottom.
LayoutTests:
- fast/repaint/trailing-floats-root-line-box-overflow-expected.checksum: Added.
- fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
- fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
- fast/repaint/trailing-floats-root-line-box-overflow.html: Added.
- 2:14 PM Changeset in webkit [53431] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed trivial buildfix. (r53429)
- WebCore.pri: missing XMLNS_NAMES added.
- 2:12 PM Changeset in webkit [53430] by
-
- 5 edits in trunk/WebCore
2010-01-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Removed unnecessary use of scriptExecutionContext() when creating a JS event listener.
https://bugs.webkit.org/show_bug.cgi?id=33811
This change simplifies a bunch of code, and also reduces
the number of places that use the difficult-to-understand and possibly
crashy-null scriptExecutionContext() idiom.
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSEventListener.h: (WebCore::createJSAttributeEventListener):
- bindings/scripts/CodeGeneratorJS.pm:
- 2:05 PM Changeset in webkit [53429] by
-
- 18 edits1 add in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33787
Add constants for more XML strings
No change in functionality, so no tests.
- WebCore/xml/xmlnsattrs.in: Added a new file for xmlns namespace and attribute - XMLNames.{h,cpp} are auto-generated, and I dodn't see a reasonable way to extend it.
- platform/text/AtomicString.cpp: (WebCore::AtomicString::init):
- platform/text/AtomicString.h: Added atomic strings for "xml" and "xmlns".
- page/Frame.cpp: (WebCore::Frame::Frame): Call XMLNSNames::init().
- dom/Attr.cpp: (WebCore::Attr::setPrefix):
- dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): (WebCore::Document::createAttributeNS):
- dom/Node.cpp: (WebCore::Node::checkSetPrefix): (WebCore::Node::isDefaultNamespace): (WebCore::Node::lookupNamespaceURI): (WebCore::Node::lookupNamespacePrefix):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::handleElementNamespaces):
- editing/markup.cpp: (WebCore::shouldAddNamespaceAttr): (WebCore::appendNamespace):
- xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): (WebCore::XPath::Step::nodesInAxis): Use the new constants.
- Android.derived.mk:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Added the new files to projects.
- 2:04 PM Changeset in webkit [53428] by
-
- 2 edits in trunk/WebCore
Fix !ENABLE(3D_CANVAS) build.
- rendering/RenderLayerBacking.cpp:
(WebCore::is3DCanvas):
- 1:58 PM Changeset in webkit [53427] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Change a newly added WebSocket test to work on Windows.
- websocket/tests/multiple-connections.html: Decrease the number of simultaneous connections from 100 to 50. On Windows buildbot, only ~70 connections are allowed for some reason - but we only need much fewer to compare to HTTP simultaneous connection limit anyway.
- 1:54 PM Changeset in webkit [53426] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip test introduced in r53423 because of missing layoutTestController.setDomainRelaxationForbiddenForURLScheme()
- platform/qt/Skipped: http/tests/security/setDomainRelaxationForbiddenForURLScheme.html added.
- 1:47 PM Changeset in webkit [53425] by
-
- 1 edit1 copy in trunk/LayoutTests
[Qt] Add platform dependent expected file because of different font size.
Reviewed by Ariya Hidayat.
- platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Copied from LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt.
- 1:36 PM Porting Macros plan edited by
- Changed OS(WIN) to OS(WINDOWS) since there is no such macro definition … (diff)
- 1:30 PM Changeset in webkit [53424] by
-
- 4 edits in trunk
Adjust the scroll position when doing a full page zoom, so the content
stays in relatively the same position.
<rdar://problem/6150099> Zooming should keep the page content in the same place
Reviewed by Oliver Hunt.
- page/Frame.cpp:
(WebCore::Frame::setZoomFactor): Apply the zoom percent difference to
the scroll position, only when doing a full page zoom.
- 1:26 PM Changeset in webkit [53423] by
-
- 22 edits2 adds in trunk
Add WebKit SPI to disallow setting document.domain from certain URL schemes
Fixes <http://webkit.org/b/33806> <rdar://problem/7552837> Would like
API to disallow setting of document.domain for pages with certain URL
schemes
Reviewed by Sam Weinig.
WebCore:
Add SecurityOrigin::{set,is}DomainRelaxationForbiddenForURLScheme and
respect it
Test: http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
- WebCore.base.exp: Export
SecurityOrigin::setDomainRelaxationForbiddenForURLScheme.
- dom/Document.cpp:
(WebCore::Document::setDomain): If domain relaxation is forbidden for
our security origin's scheme, throw an exception and don't allow
the domain to be set.
- page/SecurityOrigin.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation): Added. Returns a
global set of schemes.
(WebCore::SecurityOrigin::setDomainRelaxationForbiddenForURLScheme):
Add or remove the scheme to schemesForbiddenFromDomainRelaxation, as
appropriate.
(WebCore::SecurityOrigin::isDomainRelaxationForbiddenForURLScheme):
Returns true if the scheme is in schemesForbiddenFromDomainRelaxation.
- page/SecurityOrigin.h: Added
{set,is}DomainRelaxationForbiddenForURLScheme.
WebKit/mac:
Add +[WebView _setDomainRelaxationForbidden:forURLScheme:]
- WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
- WebView/WebViewPrivate.h:
Added. Calls through to SecurityOrigin.
WebKit/win:
Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme
- Interfaces/IWebViewPrivate.idl: Added
setDomainRelaxationForbiddenForURLScheme.
- Interfaces/WebKit.idl: Touched to force a build.
- WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
- WebView.h:
Added. Calls through to SecurityOrigin.
WebKitTools:
Add LayoutTestController support for calling new WebKit SPI to
disallow setting document.domain
- DumpRenderTree/LayoutTestController.cpp:
(setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
through to LayoutTestController.
(LayoutTestController::staticFunctions): Added
setDomainRelaxationForbiddenForURLScheme.
- DumpRenderTree/LayoutTestController.h: Added
setDomainRelaxationForbiddenForURLScheme.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
Added. Calls through to WebKit.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
Stubbed out.
LayoutTests:
Add tests for new WebKit SPI to disallow setting document.domain
- http/tests/security/setDomainRelaxationForbiddenForURLScheme-expected.txt: Added.
- http/tests/security/setDomainRelaxationForbiddenForURLScheme.html: Added.
- platform/gtk/Skipped: Skip the new test since WebKitGtk doesn't have
this API.
- 1:18 PM Changeset in webkit [53422] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-18 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Darin Adler.
Delete dftables-xxxxxxxx.in files automatically.
https://bugs.webkit.org/show_bug.cgi?id=33796
- pcre/dftables: unlink unnecessary temporary file.
- 12:57 PM Changeset in webkit [53421] by
-
- 2 edits in trunk/WebCore
Address review comments on the last change
- rendering/TrailingFloatsRootInlineBox.h:
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
- 12:55 PM Changeset in webkit [53420] by
-
- 7 edits5 adds in trunk
<rdar://problem/6892207> REGRESSION (Safari 4): Menus at sciencedirect.com push the main article context down the page
<rdar://problem/7546035> Second right floated image misplacment
https://bugs.webkit.org/show_bug.cgi?id=33245
Reviewed by Darin Adler.
WebCore:
Test: fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2.html
When the last line of a block contains a line break and there are floats
after the line break, it is incorrect to put those floats in the last line's
floats vector (along with floats from before the break). Instead, create
an additional line box (a TrailingFloatsRootInlineBox) and put those floats
in its floats vector.
- WebCore.vcproj/WebCore.vcproj: Added TrailingFloatsRootInlineBox.h
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markLinesDirtyInVerticalRange): Added an optional
parameter, which is the highest line to dirty.
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Create a TrailingFloatsRootInlineBox
for the floats occurring after the line break on the last line.
(WebCore::RenderBlock::determineStartPosition): Prevent dirtying of lines
above the first dirty line.
- rendering/TrailingFloatsRootInlineBox.h: Added.
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox): Call
setHasVirtualHeight().
(WebCore::TrailingFloatsRootInlineBox::virtualHeight): Return 0.
LayoutTests:
- fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2.html: Added.
- fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.checksum: Added.
- fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Added.
- fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Added.
- 11:56 AM Changeset in webkit [53419] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33804
Test that WebSocket is not subject to HTTP connection limit
- websocket/tests/multiple-connections-expected.txt: Added.
- websocket/tests/multiple-connections.html: Added.
- 11:56 AM QtWebKitBackportingFixes edited by
- (diff)
- 11:44 AM Changeset in webkit [53418] by
-
- 12 edits in trunk/WebCore
Eeeep! reverting r53416 & r53417, more to be done to fix windows.
Reviewed by NOBODY (build fix).
- WebCore.base.exp:
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
- platform/sql/SQLiteStatement.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/text/PlatformString.h:
- platform/text/String.cpp:
(WebCore::String::charactersWithNullTermination):
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::operator delete):
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::createGlobalData):
- storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):
- 11:40 AM Changeset in webkit [53417] by
-
- 2 edits in trunk/WebCore
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::createGlobalData):
Reviewed by NOBODY (windows build fix).
- 11:27 AM Changeset in webkit [53416] by
-
- 11 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.
Reviewed by Darin Adler.
These break the OS X Leaks tool. Move the management of null-terminated copies
out from StringImpl to String, and use a bit stolen from the refCount to hold the
'InTable' flag.
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
- platform/sql/SQLiteStatement.h:
- platform/text/PlatformString.h:
- platform/text/String.cpp:
(WebCore::String::copyWithNullTermination):
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
- 10:48 AM Changeset in webkit [53415] by
-
- 5 edits in trunk
Made root compositing layer scroll rather than scroll parent.
https://bugs.webkit.org/show_bug.cgi?id=32279
There's some general cleanup here so the frames, bounds and
positions of all the associated layers are correct.
I also changed API of setScrollFrame to use an IntRect.
- 10:36 AM Changeset in webkit [53414] by
-
- 3 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Reviewed by Adam Roben.
Rename patches-to-commit to patches-in-commit-queue
https://bugs.webkit.org/show_bug.cgi?id=33789
The command really lists the patches in the commit-queue not all the
patches that are pending-commit (as the FIXME commands).
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/queries_unittest.py:
- 10:31 AM Changeset in webkit [53413] by
-
- 2 edits in trunk/WebCore
2010-01-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Timeline panel scrolling speed can be 2 times faster.
https://bugs.webkit.org/show_bug.cgi?id=33794
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.calculateWindow): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineRecordGraphRow.prototype.update):
- 10:15 AM Changeset in webkit [53412] by
-
- 6 edits2 moves in trunk/WebCore
2010-01-18 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Moves JSC-specific version of JavaInstance from bridge/jni/jni_instance to bridge/jni/jsc/JavaInstanceJSC
https://bugs.webkit.org/show_bug.cgi?id=33672
No new tests, refactoring only.
- Android.jscbindings.mk: Modified. Removed jni_instance.cpp and added JavaInstanceJSC.cpp
- GNUmakefile.am: Modified. Removed jni_instance.h and added JavaInstanceJSC.h
- WebCore.xcodeproj/project.pbxproj: Modified. Removed jni_instance.[cpp|h] and added JavaInstanceJSC.[cpp|h]
- bindings/js/ScriptControllerMac.mm: Modified. Includes JavaInstanceJSC.h
- bridge/jni/jni_instance.cpp: Removed.
- bridge/jni/jni_instance.h: Removed.
- bridge/jni/jni_runtime.h: Modified. Includes JavaInstanceJSC.h
- bridge/jni/jsc/JavaInstanceJSC.cpp: Copied from WebCore/bridge/jni/jni_instance.cpp.
- bridge/jni/jsc/JavaInstanceJSC.h: Copied from WebCore/bridge/jni/jni_instance.h.
- 9:46 AM Changeset in webkit [53411] by
-
- 9 edits in trunk/WebCore
Simplify image decoders slightly by using OwnPtr instead of raw pointers
and eliminating a basically-useless wrapper class in the GIF decoder.
https://bugs.webkit.org/show_bug.cgi?id=28751
Reviewed by Adam Barth.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::~ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::failRead):
- platform/graphics/qt/ImageDecoderQt.h:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::~GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
(WebCore::JPEGImageDecoder::~JPEGImageDecoder):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::~PNGImageDecoder):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::decode):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/png/PNGImageDecoder.h:
- 9:20 AM Changeset in webkit [53410] by
-
- 6 edits in trunk
DataTransfer interface broken on Windows--types member is always undefined, and getData() does not work.
https://bugs.webkit.org/show_bug.cgi?id=30527
Patch by Daniel Cheng <dcheng@google.com> on 2010-01-18
Reviewed by Adam Roben.
WebCore:
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat): pass FORMATETC as a const ref.
(WebCore::ClipboardWin::types): fix calls to IEnumFORMATETC.
(WebCore::ClipboardWin::hasData): fix calls to IEnumFORMATETC.
LayoutTests:
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Updated test expectations.
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added test cases.
- platform/win/Skipped: Re-enabled fast/events/drag-and-drop-dataTransfer-types-nocrash.html
- 8:58 AM Changeset in webkit [53409] by
-
- 2 edits in trunk/WebCore
2010-01-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Don't show Profiles welcome screen on panel switch,
if a profile view is shown.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show):
- 7:11 AM Changeset in webkit [53408] by
-
- 6 edits in trunk
[Qt] Force qmake to generate a single makefile for DerivedSources.pro
Reviewed by Simon Hausmann.
- DerivedSources.pro:
WebCore:
- DerivedSources.pro:
WebKitTools:
- Scripts/webkitdirs.pm:
- 7:05 AM Changeset in webkit [53407] by
-
- 3 edits in trunk/WebKitTools
Clean up use of /useenv when invoking Visual C++
This change reverts things to their pre-r49485 state. That revision
(and, subsequently, r49664 and r51788) started passing /useenv to
Visual C++, even in cases where we don't want to do so (such as when
invoking Visual C++ Express), in the name of making the Chromium build
work. Now that Chromium isn't using buildVisualStudioProject or
pdevenv, we can put things back they way they were.
Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
(due to /useenv flag)
Reviewed by Sam Weinig.
- Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
script anymore.
- Scripts/webkitdirs.pm:
(buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
care of this itself, and we don't want to pass /useenv when not using
pdevenv (e.g., when using VC++ Express, because that will cause it to
ignore the Platform SDK).
- 6:37 AM Changeset in webkit [53406] by
-
- 8 edits1 copy in trunk
2010-01-18 Jonathan Dixon <joth@chromium.org>
Reviewed by Adam Barth.
Add support for enabling navigator.geolocation at runtime in the V8 bindings.
Adds the [EnabledAtRuntime] modifier to the navigator IDL.
https://bugs.webkit.org/show_bug.cgi?id=33467
- WebCore.gypi:
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setGeolocationEnabled): (WebCore::RuntimeEnabledFeatures::geolocationEnabled):
- bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::V8Navigator::GeolocationEnabled):
- page/Navigator.cpp: (WebCore::Navigator::geolocation):
- page/Navigator.idl:
2010-01-18 Jonathan Dixon <joth@chromium.org>
Reviewed by Adam Barth.
Add support for enabling navigator.geolocation at runtime in the V8 bindings.
Adds the [EnabledAtRuntime] modifier to the navigator IDL.
https://bugs.webkit.org/show_bug.cgi?id=33467
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableGeolocation): (WebKit::WebRuntimeFeatures::isGeolocationEnabled):
- 6:20 AM Changeset in webkit [53405] by
-
- 4 edits in trunk/WebCore
2010-01-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Improve Resources panel performance for lots of resources
DOM properties are extracted into const's, comparisons are faster.
https://bugs.webkit.org/show_bug.cgi?id=33790
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
- inspector/front-end/Resource.js: (WebInspector.Resource.CompareByStartTime): (WebInspector.Resource.CompareByResponseReceivedTime): (WebInspector.Resource.CompareByEndTime): (WebInspector.Resource.CompareByDuration): (WebInspector.Resource.CompareByLatency): (WebInspector.Resource.CompareBySize):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceGraph.prototype.refreshLabelPositions):
- 6:05 AM Changeset in webkit [53404] by
-
- 3 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch land-safely should obsolete old patches
https://bugs.webkit.org/show_bug.cgi?id=33788
When posting a commit-queue+ patch with land-safely, we should
obsolete the old patches on the bug. They're really confusing
because the main use case is to address reviewer feedback on a
previous patch.
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- 5:49 AM Changeset in webkit [53403] by
-
- 2 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
webkit-patch should authenticate more often
https://bugs.webkit.org/show_bug.cgi?id=33701
This makes it easier to work with security patches.
- Scripts/webkitpy/bugzilla.py:
- 5:33 AM Changeset in webkit [53402] by
-
- 2 edits in trunk/WebCore
2010-01-18 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Following up on changes made with respect to bug #33498, we should
fix the the style errors found by the style bot.
Moreover, this fixes all the style errors found by check-webkit-style
except the use of an underline in the variable name _niflags. We should
fix this in a second run through for all the other variables names that
contain an underline because there are many.
No functionality was changed. So, no new tests.
- rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::create): (WebCore::SVGRenderStyle::copy): (WebCore::SVGRenderStyle::operator!=): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill): (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::InheritedFlags::operator!=): (WebCore::SVGRenderStyle::NonInheritedFlags::operator==): (WebCore::SVGRenderStyle::NonInheritedFlags::operator!=): (WebCore::SVGRenderStyle::NonInheritedFlags::): (WebCore::SVGRenderStyle::): (WebCore::SVGRenderStyle::setBitDefaults):
- 4:54 AM Changeset in webkit [53401] by
-
- 2 edits in trunk/WebCore
[Android] DOMWrapperMap::Visitor needs virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=33675
Patch by Andrei Popescu <andreip@google.com> on 2010-01-18
Reviewed by Adam Barth.
Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.
No new tests needed, functionality not changed.
- bindings/v8/V8DOMMap.h:
(WebCore::DOMWrapperMap::Visitor::~Visitor): Added.
- 4:14 AM Changeset in webkit [53400] by
-
- 9 edits in trunk/JavaScriptCore
Rubber-stamped by Gustavo Noronha Silva.
Rolling out r53391 and r53392 because of random crashes on buildbots.
https://bugs.webkit.org/show_bug.cgi?id=33731
- bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- jit/JIT.cpp:
(JSC::JIT::unlinkCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
- runtime/UString.h:
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- 2:13 AM Changeset in webkit [53399] by
-
- 3 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
style checker needs to know about GObject-specific requirements
inside WebCore/bindings/gobject/
https://bugs.webkit.org/show_bug.cgi?id=33606
Add an exception to the underscore rule for certain
GObject-specific names.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 2:13 AM Changeset in webkit [53398] by
-
- 3 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Reviewed by Shinichiro Hamaji.
[check-webkit-style] does understand ResourceHandleWin.h
https://bugs.webkit.org/show_bug.cgi?id=32975
I'm not 100% convinced this fix is correct, but without more examples,
it's hard to generalize. We can always generalize the fix in the
future.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 1:54 AM Changeset in webkit [53397] by
-
- 2 edits in trunk/JavaScriptCore
Fix the build with strict gcc and RVCT versions: It's not legal to cast a
pointer to a function to a void* without an intermediate cast to a non-pointer
type. A cast to a ptrdiff_t inbetween fixes it.
Reviewed by Kenneth Rohde Christiansen.
- runtime/JSString.h:
(JSC::Fiber::JSString):
- 1:29 AM Changeset in webkit [53396] by
-
- 2 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix.
- Scripts/webkitpy/bugzilla.py:
- 1:15 AM Changeset in webkit [53395] by
-
- 3 edits in trunk/WebKitTools
2010-01-18 Adam Barth <abarth@webkit.org>
Unreviewed. Actually make land-safely mark commit-queue+ as
discussed with Eric.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/steps/postdiffforcommit.py:
- 1:02 AM Changeset in webkit [53394] by
-
- 2 edits in trunk/WebCore
Unreviewed Symbian build fix.
If we don't link with def files, then we have to pass EXPORTUNFROZEN,
so that the build system still creates the .dso files in
release/armv5/lib and we can actually link against the created QtWebKit
dlls.
Thanks Iain for the help!
- WebCore.pro:
Jan 17, 2010:
- 11:47 PM Changeset in webkit [53393] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Eric Seidel.
[Qt] Platform dependent expected file added for r53388. (similar to original one, only styles differ)
https://bugs.webkit.org/show_bug.cgi?id=33784 (need to unify path dumping)
- platform/qt/svg/custom/transformedMaskFails-expected.txt: Added.
- 11:36 PM Changeset in webkit [53392] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).
Reviewed by Oliver Hunt.
This break the OS X Leaks tool. Instead, free up some more bits from the refCount.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- 11:28 PM Changeset in webkit [53391] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.
Reviewed by Oliver Hunt.
These break the OS X Leaks tool. Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.
- bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- jit/JIT.cpp:
(JSC::JIT::unlinkCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- runtime/UString.h:
- 9:41 PM Changeset in webkit [53390] by
-
- 2 edits in trunk/WebCore
2010-01-17 Srinidhi Shreedhara <srinidhi.shreedhara@nokia.com>
Reviewed by Simon Hausmann.
[Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative
https://bugs.webkit.org/show_bug.cgi?id=33573
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative coordinates for early return.
- 8:53 PM Changeset in webkit [53389] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-17 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[Chromium] Remove an old runFileChooser() method.
https://bugs.webkit.org/show_bug.cgi?id=33778
Chromium code switched to new runFileChooser() introduced by
r53269. The old one is not needed anymore.
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel):
- 7:59 PM Changeset in webkit [53388] by
-
- 3 edits3 adds in trunk
2010-01-17 Oliver Hunt <oliver@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r52449): SVG mask wrongly clipped when not at origin for recent nightly build
https://bugs.webkit.org/show_bug.cgi?id=33782
Testcase for a mask containing transformed elements
- platform/mac/svg/custom/transformedMaskFails-expected.png: Added.
- svg/custom/transformedMaskFails-expected.txt: Added.
- svg/custom/transformedMaskFails.svg: Added.
2010-01-17 Oliver Hunt <oliver@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r52449): SVG mask wrongly clipped when not at origin for recent nightly build
https://bugs.webkit.org/show_bug.cgi?id=33782
Test: svg/custom/transformedMaskFails.svg
When computing the bounds for elements in a mask, we iterate through
all of our children requesting their repaint bounds using
repaintRectInLocalCoordinates(), but we were not converting that
rect into our own coordinate system, thus leading to an incorrect
repaint rect. This patch simply adds the missing localToParent
transform.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 7:28 PM Changeset in webkit [53387] by
-
- 3 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
style-queue complains about one-line macros that include multiple statements
https://bugs.webkit.org/show_bug.cgi?id=33173
Add an exception for multiple statements on a line that starts a macro.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 7:11 PM Changeset in webkit [53386] by
-
- 3 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[check-webkit-style] qt unit testing false positives
https://bugs.webkit.org/show_bug.cgi?id=32833
Exempt the Qt API and unit tests from the style checker.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 6:58 PM Changeset in webkit [53385] by
-
- 91 edits in trunk/LayoutTests/platform
Set the svn:mime-type property of recently-added PNG files to image/png.
- 6:47 PM Changeset in webkit [53384] by
-
- 2 edits in trunk/WebCore
2010-01-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Avoid slow access to AX objects on attribute access when AX is off
https://bugs.webkit.org/show_bug.cgi?id=33779
~4% Dromaeo attributes test speedup
- dom/Element.cpp: (WebCore::Element::updateAfterAttributeChanged): Don't do expensive lookup of AX object cache unless accessibility is on and an AX-related attribute is changed.
- 6:39 PM Changeset in webkit [53383] by
-
- 3 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
style-check script reports loads of errors on gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=33771
Exempt WebCore/platform/gtk/gtk2drawing.c and
WebCore/platform/gtk/gtk2drawing.h from style checks.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 6:22 PM Changeset in webkit [53382] by
-
- 4 edits in trunk/WebKitTools
2010-01-17 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Finished eliminating _cpp_style_state global state variable from
check-webkit-style code and eliminating _CppStyleState class.
- Scripts/webkitpy/style/checker.py:
- Minor updates caused by changes to cpp_style.py.
- Scripts/webkitpy/style/cpp_style.py:
- Removed _CppStyleState class.
- Removed verbose_level functions.
- Added verbosity as a parameter to _FunctionState constructor.
- Added verbosity as a parameter to process_file().
- Added verbosity as a parameter to process_file_data().
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Added helper functions to set verbosity while running tests.
- 6:06 PM Changeset in webkit [53381] by
-
- 3 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style underscore check should be disabled for Qt methods starting with qt_
https://bugs.webkit.org/show_bug.cgi?id=33663
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 5:49 PM Changeset in webkit [53380] by
-
- 3 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-queue complains about missing #include of config.h for non-WebCore projects
https://bugs.webkit.org/show_bug.cgi?id=33170
WebKitAPITests are consumers of the WebKit API and therefore do not
need to follow the same include discipline as the rest of WebKit. This
patch exempts them from the include checks.
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 5:33 PM Changeset in webkit [53379] by
-
- 2 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
EWS (Early Warning Systems) should build both debug and release
https://bugs.webkit.org/show_bug.cgi?id=33681
Build both debug and release for chromium-ews.
- Scripts/webkitpy/commands/early_warning_system.py:
- 4:36 PM Changeset in webkit [53378] by
-
- 2 edits in trunk/WebKitTools
2010-01-17 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
style-queue should include instructions for how to file bugs against check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=32345
Added some text to the error message asking folks to file bugs against
false positives.
- Scripts/webkitpy/commands/queues.py:
- 4:31 PM Changeset in webkit [53377] by
-
- 4 edits in tags/Safari-6531.21.11/WebKit
Merge r53195.
- 4:31 PM Changeset in webkit [53376] by
-
- 4 edits in tags/Safari-6531.21.11
Versioning.
- 4:29 PM Changeset in webkit [53375] by
-
- 1 copy in tags/Safari-6531.21.11
New tag.
- 4:04 PM Changeset in webkit [53374] by
-
- 6 edits in trunk/WebKitTools
2010-01-17 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Eliminated the error_count global variable and related
check-webkit-style refactoring.
- Scripts/check-webkit-style:
- Updated to use webkit_argument_defaults().
- Renamed styleChecker to style_checker.
- Scripts/webkitpy/style/checker.py:
- Prefixed the three default arguments with WEBKIT_DEFAULT.
- Added webkit_argument_defaults().
- Added default filter_rules parameter to CategoryFilter constructor.
- Added ne() to CategoryFilter class.
- Added eq() and ne() to ProcessorOptions class.
- Added error_count and _write_error attributes to StyleChecker class.
- Made StyleChecker._handle_error() increment the error count.
- Scripts/webkitpy/style/checker_unittest.py:
- Improved CategoryFilterTest.test_eq().
- Added CategoryFilterTest.test_ne().
- Added test_eq() and test_ne() to ProcessorOptionsTest class.
- Updated unit tests to use webkit_argument_defaults().
- Added StyleCheckerTest class.
- Scripts/webkitpy/style/cpp_style.py:
- Removed references to global error_count.
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Removed CppStyleStateTest class.
- 3:39 PM Changeset in webkit [53373] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
[wx] On Win and GTK, we need to manually apply the transforms when falling back
to GDI / GDK drawing, but this is not needed on Mac since we always use CG there.
https://bugs.webkit.org/show_bug.cgi?id=33730
- 9:54 AM Changeset in webkit [53372] by
-
- 5 edits in trunk/WebCore
2010-01-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] GtkWebKit incompatible with rgba colormaps
https://bugs.webkit.org/show_bug.cgi?id=20736
Fix GTK theme rendering onto drawables with RGBA colormaps. Now
each type of colormap has its own collection of GtkWidgets.
This fix does not introduce any functionality changes, so does not
includes new tests.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::~RenderThemeGtk): (WebCore::RenderThemeGtk::partsForDrawable): (WebCore::adjustMozillaStyle): (WebCore::setMozillaState): (WebCore::paintMozillaGtkWidget): (WebCore::setToggleSize): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/gtk2drawing.c: (moz_gtk_use_theme_parts): (ensure_window_widget): (setup_widget_prototype): (ensure_button_widget): (ensure_hpaned_widget): (ensure_vpaned_widget): (ensure_toggle_button_widget): (ensure_button_arrow_widget): (ensure_checkbox_widget): (ensure_radiobutton_widget): (ensure_scrollbar_widget): (ensure_spin_widget): (ensure_scale_widget): (ensure_entry_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_handlebox_widget): (ensure_toolbar_widget): (ensure_toolbar_separator_widget): (ensure_tooltip_widget): (ensure_tab_widget): (ensure_progress_widget): (ensure_statusbar_widget): (ensure_frame_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_view_widget): (ensure_tree_header_cell_widget): (ensure_expander_widget): (ensure_scrolled_window_widget): (moz_gtk_checkbox_get_metrics): (moz_gtk_radio_get_metrics): (moz_gtk_splitter_get_metrics): (moz_gtk_toggle_paint): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_trough_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_spin_paint): (moz_gtk_spin_updown_paint): (moz_gtk_scale_paint): (moz_gtk_scale_thumb_paint): (moz_gtk_gripper_paint): (moz_gtk_hpaned_paint): (moz_gtk_vpaned_paint): (moz_gtk_caret_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_tree_header_sort_arrow_paint): (moz_gtk_treeview_expander_paint): (moz_gtk_expander_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_container_paint): (moz_gtk_toggle_label_paint): (moz_gtk_toolbar_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_tooltip_paint): (moz_gtk_resizer_paint): (moz_gtk_frame_paint): (moz_gtk_progressbar_paint): (moz_gtk_progress_chunk_paint): (moz_gtk_get_tab_thickness): (moz_gtk_tab_paint): (moz_gtk_tabpanels_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_popup_paint): (moz_gtk_menu_separator_paint): (moz_gtk_menu_item_paint): (moz_gtk_menu_arrow_paint): (moz_gtk_check_menu_item_paint): (moz_gtk_window_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_get_toolbar_separator_width): (moz_gtk_get_expander_size): (moz_gtk_get_treeview_expander_size): (moz_gtk_get_menu_separator_height): (moz_gtk_get_scalethumb_metrics): (moz_gtk_get_scrollbar_metrics): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_get_scrollbar_widget): (moz_gtk_shutdown): (moz_gtk_destroy_theme_parts_widgets):
- platform/gtk/gtkdrawing.h:
Jan 16, 2010:
- 11:18 PM Changeset in webkit [53371] by
-
- 12 edits in trunk
2010-01-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JS string values made from DOM strings (Dromaeo speedup)
https://bugs.webkit.org/show_bug.cgi?id=33768
<rdar://problem/7353576>
- runtime/JSString.h: (JSC::jsStringWithFinalizer): Added new mechanism for a string to have an optional finalizer callback, for the benefit of weak-referencing caches. (JSC::): (JSC::Fiber::JSString): (JSC::Fiber::~JSString):
- runtime/JSString.cpp: (JSC::JSString::resolveRope): Clear fibers so this doesn't look like a string with a finalizer.
- runtime/WeakGCMap.h: Include "Collector.h" to make this header includable by itself.
2010-01-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JS string values made from DOM strings (Dromaeo speedup)
https://bugs.webkit.org/show_bug.cgi?id=33768
<rdar://problem/7353576>
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::stringValue): Explicitly make a String, since char* is now ambiguous.
2010-01-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JS string values made from DOM strings (Dromaeo speedup)
https://bugs.webkit.org/show_bug.cgi?id=33768
<rdar://problem/7353576>
Added a new cache for JSString values that are created from Strings or AtomicStrings
in the DOM. It's common for the same string to be retrieved from the DOM repeatedly,
and it is wasteful to make a new JS-level string value every time.
The string cache is per-world, and thus thread-safe and not a
vector for accidental information exchange.
~30% speedup on Dromaeo Attributes test, also substantially helps other Dromaeo DOM tests.
- bindings/js/JSDOMBinding.cpp: (WebCore::jsStringCache): Helper function to get the string cache for the current world. (WebCore::jsString): Some new overloads including the caching version. (WebCore::stringWrapperDestroyed): Finalizer callback - remove from relevant caches.
- bindings/js/JSDOMBinding.h: (WebCore::jsString): Prototype new overloads (and define a few inline).
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::type): Explicitly make a UString.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Ditto.
- WebCore.base.exp: Add new JSString overloads that WebCore gets to see.
- 6:31 PM Changeset in webkit [53370] by
-
- 2 edits in trunk/WebCore
2010-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Nikolas Zimmermann.
SVG Markers are getting culled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=33767
Use applyTransformToPaintInfo to transform the paintInfo, otherwise
the paint rect is not updated leading to incorrect culling.
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw):
- 5:42 PM Changeset in webkit [53369] by
-
- 3 edits2 adds in trunk
MSAA: Screen rect for <option> elements is always the zero rect
https://bugs.webkit.org/show_bug.cgi?id=33758
Reviewed by Oliver Hunt.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::accLocation):
Use elementRect() rather than boundingBoxRect(), which
AccessibilityListBoxOption overrides.
LayoutTests:
- platform/win/accessibility/option-element-position-and-size-expected.txt: Added.
- platform/win/accessibility/option-element-position-and-size.html: Added.
- 5:42 PM Changeset in webkit [53368] by
-
- 5 edits2 adds in trunk
get_accParent should try to retrieve parent AccessibilityObject, before
calling upon window
https://bugs.webkit.org/show_bug.cgi?id=22893
Reviewed by Darin Adler.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::get_accParent):
If the object has a parent object, return it. If not, return the
accessible for the WebView window.
WebKitTools:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::parentElement):
Get the object's parent. Query it for IAccessible, and return it.
LayoutTests:
- platform/win/accessibility/parent-element-expected.txt: Added.
- platform/win/accessibility/parent-element.html: Added.
- 5:03 PM Changeset in webkit [53367] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=33751 and <rdar://problem/7538330>
Zip code field is misidentified as street address because id attribute isn't checked.
Reviewed by Darin Adler
No new tests. I believe this code is used only by Safari AutoFill, but in any case
it does not affect page rendering or anything else at the WebCore/WebKit level.
- page/Frame.cpp:
(WebCore::matchLabelsAgainstString):
New function, split out from matchLabelsAgainstElement.
(WebCore::Frame::matchLabelsAgainstElement):
Now calls matchLabelsAgainstString for the id attribute if no match is found for the name attribute.
- page/mac/FrameMac.mm:
(WebCore::matchLabelsAgainstString):
Same as above. This is a parallel copy of the function using Mac-specific data structures.
(WebCore::Frame::matchLabelsAgainstElement):
Ditto.
- 3:30 PM Changeset in webkit [53366] by
-
- 8 edits in trunk/WebCore
Use String.trim() instead of a regex in the Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=33765
Reviewed by George Staikos.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.performSearch): Use .trim().
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Ditto.
- inspector/front-end/ProfileView.js:
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._evalSelectionInCallFrame): Ditto.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype): Ditto.
- inspector/front-end/utilities.js:
(String.prototype.trimLeadingWhitespace): Removed.
(String.prototype.trimTrailingWhitespace): Removed.
(String.prototype.trimWhitespace): Removed.
- 3:04 PM Changeset in webkit [53365] by
-
- 15 edits in trunk/WebCore
2010-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Nikolas Zimmermann.
Copying TransformationMatrix consumed a lot of cpu time while scroll with cursor over content
https://bugs.webkit.org/show_bug.cgi?id=33766
Make localToParentTransform return by reference to avid copy overhead.
This is a little gnarly in places as it means we need to be able to
return temporary values in a few implementations, so we have to add
class fields to hold them, heppily the classes that these effect are
sufficiently uncommon for this to be okay.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::localTransform): (WebCore::RenderObject::localToParentTransform):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::nodeAtFloatPoint):
- rendering/RenderPath.h:
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToParentTransform):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/RenderSVGViewportContainer.h:
- 1:36 PM Changeset in webkit [53364] by
-
- 5 edits2 adds in trunk
ValidityState can hold a stale pointer to control
https://bugs.webkit.org/show_bug.cgi?id=33729
rdar://problem/7545114
Reviewed by Oliver Hunt and Alexey Proskuryakov.
WebCore:
Test: fast/forms/ValidityState-removed-control.html
- html/HTMLFormControlElement.h: Use OwnPtr instead of
RefPtr to point to the ValidityState object.
- html/ValidityState.cpp: Use a constant instead of a
macro for the email validation regular expression.
(WebCore::ValidityState::validationMessage): Use
m_control instead of control function; we don't need
a function for this. Also marked const.
(WebCore::ValidityState::typeMismatch): Ditto.
Fixed some minor style problems.
(WebCore::ValidityState::rangeUnderflow): Ditto.
(WebCore::ValidityState::rangeOverflow): Ditto.
(WebCore::ValidityState::stepMismatch): Ditto.
(WebCore::ValidityState::valid): Ditto.
(WebCore::ValidityState::isValidEmailAddress):
Changed local variable names for clarity. Got rid of
an unneeded global variable.
- html/ValidityState.h: Removed RefCounted as a base
class, deriving from Noncopyable instead. Changed
creation to use PassOwnPtr instead of PassRefPtr.
Eliminated unneeded control function. Added ref and
deref functions that forward the reference counting
to the control. Moved constructor here and made it
inline.
LayoutTests:
- fast/forms/ValidityState-removed-control-expected.txt: Added.
- fast/forms/ValidityState-removed-control.html: Added.
- 12:53 PM Changeset in webkit [53363] by
-
- 5 edits5 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33752
Assertion failure when getting a href attribute with prefix
This was due to a temporary change made in 2005 (r9639) - checks in checkSetPrefix were
disabled during introduction of QualifiedName, but never re-enabled.
Tests: fast/dom/bad-href-attribute.html
fast/dom/node-prefix-setter-namespace-exception.html
- dom/Attr.cpp: (WebCore::Attr::setPrefix):
- dom/Element.cpp: (WebCore::Element::setPrefix):
- dom/Node.cpp: (WebCore::Node::checkSetPrefix): Re-enabled the checks. Also, changed the prefix setter to treat "" as null, matching Firefox (DOM 3 Core spec says this behavior is implementation defined).
- 11:29 AM Changeset in webkit [53362] by
-
- 2 edits in trunk/WebKitTools
<rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
Reviewed by Mark Rowe.
- DumpRenderTree/mac/CheckedMalloc.cpp:
(makeLargeMallocFailSilently): Temporarily allow writing to the default
malloc zone structure while modifying it.
- 11:18 AM Changeset in webkit [53361] by
-
- 10 edits in trunk
<rdar://problem/7536748> and https://bugs.webkit.org/show_bug.cgi?id=33571
History traversals to a new document do not get the popstate event
Reviewed by Darin Adler.
WebCore:
State objects now live-on in their HistoryItem indefinitely.
This means any back/forward navigation might result in a popstate event, not just to
pre-existing documents as was previously the case.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::documentDetached): State objects are held beyond Document lifetime.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin): If there is a pending state object for this Frame load, pass it
on to the Document after the Document is created.
(WebCore::FrameLoader::transitionToCommitted): If the current history item has a state object,
set it as the FrameLoad's pending state object.
- loader/FrameLoader.h:
- page/Page.cpp:
(WebCore::Page::goToItem): Remove a now-invalid ASSERT.
LayoutTests:
Updated existing tests to match new correct behavior.
- fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- 7:20 AM Changeset in webkit [53360] by
-
- 3 edits in trunk/WebKitTools
Added back removed properties to iExploder input files
While the update-iexploder-cssproperties script works great to
add new properties, it has the side-effect of removing old
properties that once were parsed.
- iExploder/htdocs/cssproperties.in: Added back removed
properties into their own section.
- iExploder/htdocs/htmlattrs.in: Ditto.
- 6:58 AM Changeset in webkit [53359] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Added bug url to ChangeLog for r53358.
- 6:44 AM Changeset in webkit [53358] by
-
- 4 edits in trunk/WebKitTools
2010-01-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by David Kilzer.
Update iExploder/htdocs/*.in by running update-iexploder-cssproperties
- iExploder/htdocs/cssproperties.in: New CSS attributes
- iExploder/htdocs/htmlattrs.in: New HTML attributes
- iExploder/htdocs/htmltags.in: New HTML tags
- 12:51 AM QtWebKitMirrorGuide edited by
- Mention the manipulate-content.py script for post-processing. (diff)
- 12:48 AM QtWebKitPerformanceUtilities edited by
- Add an example to post-process the db. (diff)
- 12:40 AM QtWebKitPerformanceToolBackLog: edited by
- Add some new commits (diff)
- 12:35 AM QtWebKitReleases edited by
- (diff)
Jan 15, 2010:
- 11:38 PM QtWebKitReleases edited by
- add some ideas on release engineering (diff)
- 9:07 PM Changeset in webkit [53357] by
-
- 13 edits72 adds in trunk
2010-01-15 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein and Adele Peterson.
Support reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=31885
Implement reflections (via -webkit-box-reflect:) on compositing layers.
We add to the GraphicsLayer the notion of having a replica, and being a replicated layer.
The replica layer is not parented in the tree, but referenced by another layer.
RenderLayerBacking sets this up when it finds RenderLayers for reflections.
GraphicsLayerCA implements rendering of replica layers by cloning CA layers,
and copying their properties, including animations and contents. Deep reflections
are supported by a hash of clone layers on each GraphicsLayerCA, indexed by
the path down the tree to each replica instance.
When GraphicsLayerCA properties are changed, in most cases the clones must also
be updated.
Tests: compositing/masks/direct-image-mask.html
compositing/reflections/animation-inside-reflection.html
compositing/reflections/compositing-change-inside-reflection.html
compositing/reflections/deeply-nested-reflections.html
compositing/reflections/masked-reflection-on-composited.html
compositing/reflections/nested-reflection-anchor-point.html
compositing/reflections/nested-reflection-animated.html
compositing/reflections/nested-reflection-mask-change.html
compositing/reflections/nested-reflection-on-overflow.html
compositing/reflections/nested-reflection-opacity.html
compositing/reflections/nested-reflection-size-change.html
compositing/reflections/nested-reflection-transformed.html
compositing/reflections/nested-reflection-transition.html
compositing/reflections/nested-reflection.html
compositing/reflections/reflection-opacity.html
compositing/reflections/reflection-ordering.html
compositing/reflections/reflection-positioning.html
compositing/reflections/transform-inside-reflection.html
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::isReplicated): Returns true when this layer has a replicated layer. (WebCore::GraphicsLayer::replicatedLayerPosition): (WebCore::GraphicsLayer::setReplicatedLayerPosition): The position of the replica layer must be special-cased; we cannot just copy the position of the original. (WebCore::GraphicsLayer::didDisplay): Method that indicates that the contents of the layer changed, which gives us a chance to update clone layers. (WebCore::GraphicsLayer::replicaLayer): reference to the replica layer. (WebCore::GraphicsLayer::replicatedLayer): reference to the layer that this (replica) layer is replicating. (WebCore::GraphicsLayer::setReplicatedLayer):
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setReplicatedByLayer): Hook up a replica with its replicated layer. (WebCore::GraphicsLayer::dumpProperties):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::primaryLayer): Returns a CALayer, since structural layers may not be WebLayers. (WebCore::GraphicsLayerCA::isReplicatedRootClone): Given a cloneID (string representation of the path to a clone down the tree, which is a bitstring of 1 (replica), or 0 (non-replica)), returns true if this ID represents the root of a replica tree. (WebCore::GraphicsLayerCA::primaryLayerClones): Returns a pointer to the hash map of clones of the primary layers.
(WebCore::GraphicsLayerCA::ReplicaState::ReplicaState): Small struct used to track original/clone branching
down the tree during recursion, to build cloneID paths.
(WebCore::GraphicsLayerCA::hasCloneLayers): returns true if this layer has clone layers.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::~GraphicsLayerCA): remove the clone layers. (WebCore::GraphicsLayerCA::setChildren): call noteSublayersChanged() since we may have to update replicas too. (WebCore::GraphicsLayerCA::addChild): ditto (WebCore::GraphicsLayerCA::addChildAtIndex): ditto (WebCore::GraphicsLayerCA::addChildBelow): ditto (WebCore::GraphicsLayerCA::addChildAbove): ditto (WebCore::GraphicsLayerCA::replaceChild): ditto (WebCore::GraphicsLayerCA::removeFromParent): ditto (WebCore::GraphicsLayerCA::setMaskLayer): call propagateLayerChangeToReplicas() (WebCore::GraphicsLayerCA::setReplicatedLayer): note replica changed. (WebCore::GraphicsLayerCA::setReplicatedByLayer): ditto (WebCore::GraphicsLayerCA::moveOrCopyAllAnimationsForProperty): Enhanced to allow moving or copying animations. (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): Ditto. (WebCore::GraphicsLayerCA::setContentsToImage): call noteSublayersChanged() (WebCore::GraphicsLayerCA::setContentsToVideo): call noteSublayersChanged() (WebCore::GraphicsLayerCA::didDisplay): here is our chance to copy updated contents to clone layers. (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): pre-order commit, for things that need to be
committed before we recurse on children.
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers): post-order commit, for things that need to be
committed after we recurse on children, like clones.
(WebCore::GraphicsLayerCA::updateLayerNames): New method to match the other 'update' methods.
(WebCore::GraphicsLayerCA::updateSublayerList): Insert replica layers into the hierarchy.
(WebCore::GraphicsLayerCA::updateLayerPosition): update clones.
(WebCore::GraphicsLayerCA::updateLayerSize): ditto
(WebCore::GraphicsLayerCA::updateAnchorPoint): ditto
(WebCore::GraphicsLayerCA::updateTransform): ditto
(WebCore::GraphicsLayerCA::updateChildrenTransform): ditto
(WebCore::GraphicsLayerCA::updateMasksToBounds): ditto
(WebCore::GraphicsLayerCA::updateContentsOpaque): ditto
(WebCore::GraphicsLayerCA::updateBackfaceVisibility): ditto
(WebCore::GraphicsLayerCA::updateStructuralLayer): call ensureStructuralLayer()
(WebCore::moveAnimation): utility to move a CAAnimation from one layer to another.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): refactored code which creates enclosing CALayers for reflection
flattening, or CATransformLayers for preserve-3d.
(WebCore::GraphicsLayerCA::structuralLayerPurpose): indicates why we need a structural layer.
(WebCore::GraphicsLayerCA::updateLayerDrawsContent): update clones
(WebCore::GraphicsLayerCA::updateContentsImage): ditto
(WebCore::GraphicsLayerCA::updateContentsRect): ditto
(WebCore::GraphicsLayerCA::updateMaskLayer): ditto
(WebCore::GraphicsLayerCA::updateReplicatedLayers): This is where we ask for the tree of layers for the replica
and its children, and attach them as sublayers.
(WebCore::GraphicsLayerCA::ReplicaState::cloneID): Build a bitstring from the array of original/clone values; this
string serves to identify clones in the hash map.
(WebCore::GraphicsLayerCA::replicatedLayerRoot): Request the tree of clone layers, set its position and transform,
and return it.
(WebCore::GraphicsLayerCA::setAnimationOnLayer): update clones
(WebCore::GraphicsLayerCA::removeAnimationFromLayer): ditto
(WebCore::GraphicsLayerCA::pauseAnimationOnLayer): ditto
(WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D): udpate sublayers.
(WebCore::GraphicsLayerCA::suspendAnimations): update clones.
(WebCore::GraphicsLayerCA::resumeAnimations): ditto
(WebCore::GraphicsLayerCA::animatedLayerClones): return the hash map for clones of the appropriate layer for the given property.
(WebCore::GraphicsLayerCA::ensureCloneLayers): create and return clones for the CALayers for this layer.
(WebCore::GraphicsLayerCA::removeCloneLayers): clear out the clone layers.
(WebCore::GraphicsLayerCA::positionForCloneRootLayer): the root of a clonal subtree needs its position and transform to be special-cased,
since it doesn't just copy those properties from the original.
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas): push the change flags onto the replica.
(WebCore::GraphicsLayerCA::fetchCloneLayers): recurse down sublayers, creating clones of the CALayers along the way, and returning
the root of the clone tree.
(WebCore::copyAnimation): utility to copy an animation from one layer to another. Animations can be shared between layers.
(WebCore::GraphicsLayerCA::cloneLayer): utility to clone a CALayer, copying those properties which GraphicsLayerCA makes use of
(WebCore::GraphicsLayerCA::setOpacityInternal): push opacity changes to clones.
(WebCore::GraphicsLayerCA::updateOpacityOnLayer): ditto
(WebCore::GraphicsLayerCA::noteSublayersChanged): set the ChildrenChanged flag, and proprate changes to the replica, if any.
- platform/graphics/mac/WebLayer.mm: (-[WebLayer display]): override -display so we know when to update the contents of clone layers
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer display]): ditto.
- rendering/RenderLayer.h: (WebCore::RenderLayer::isReflection): New method that returns true if the renderer is a replica.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): initialize m_isReflection (WebCore::RenderLayer::updateReflectionStyle): call setIsReflection
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Put a name on the reflection layer. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Hook up the GraphicsLayers for the reflection. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Reflection overrides preserve-3d (you have to flatten to reflect). Also hook up updating the reflection layer geometry, and the relica position.
(WebCore::RenderLayerBacking::paintIntoLayer): We no longer paint the reflection in software.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): Hook reflection layers into the compositing logic. (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): No longer have to push video into software if it's reflected. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Update the bounds of the reflection layer. (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): ditto (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing): a compositing descendant forces a reflection ancestor to composite now. (WebCore::RenderLayerBacking::containsPaintedContent): Reflection layers don't paint anything. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): No need to fall out of direct compositing mode for masks or reflections any more. (WebCore::RenderLayerBacking::paintIntoLayer): No need to paint the reflection manually now.
- rendering/RenderObject.h: (WebCore::RenderObject::isReplica):
- rendering/RenderReplica.h: (WebCore::RenderReplica::isReplica): New method used to determine if a render is a replica.
- 9:05 PM Changeset in webkit [53356] by
-
- 4 edits in trunk/LayoutTests
2010-01-15 Doug Muir <dmuir@google.com>
Fix some Layout Test timeouts when run under valgrind.
- http/tests/history/redirect-js-form-submit-0-seconds.html:
- http/tests/history/redirect-js-form-submit-2-seconds.html:
- http/tests/misc/timer-vs-loading.html:
- 6:14 PM Changeset in webkit [53355] by
-
- 6 edits2 adds in trunk
2010-01-15 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
CSS2.1 Counters not updated when new elements are inserted in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=32884
- fast/css/counters/adding-nodes-expected.txt: Added.
- fast/css/counters/adding-nodes.html: Added.
2010-01-15 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
CSS2.1 Counters not updated when new elements are inserted in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=32884
Test: fast/css/counters/adding-nodes.html
- rendering/CounterNode.cpp: (WebCore::CounterNode::insertAfter): Modified to handle the addition of nodes with children. Needed when formerly root nodes become descendants of a new node.
- rendering/RenderCounter.cpp: (WebCore::makeCounterNode): Changed to handle the case when root counter nodes lose their root status as a result of a new root counter node creation. (WebCore::destroyCounterNodeWithoutMapRemoval): Refactored more code into destroyCounterNodeChildren and renamed the function according to its new action. (WebCore::RenderCounter::destroyCounterNodes): Simplified to share more code with the new destroyCounterNode. (WebCore::RenderCounter::destroyCounterNode): Added to allow for selective counterNode destruction. (WebCore::RenderCounter::rendererSubtreeAttached): Added to refresh counter values in response to DOM changes. For renderers with no attached counters the execution time of this function cannot be discerned in comparison with the time needed to add a node or change the style of a node. (WebCore::updateCounters): Helper function for rendererSubtreeAttached. Updates the counters attached to a Renderer in response to the renderer or its ancestors being attached to the renderer tree.
- rendering/RenderCounter.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Changed to update counter values if needed.
- 5:56 PM Changeset in webkit [53354] by
-
- 2 edits in trunk/JavaScriptCore
Fix for <rdar://problem/7548432>
Add ALWAYS_INLINE to jsLess for a 1% speedup on llvm-gcc.
Reviewed by Maciej Stachowiak.
- runtime/Operations.h:
(JSC::jsLess):
- 5:24 PM Changeset in webkit [53353] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Alexey Proskuryakov.
Move the code adding the child frame to the FrameTree into wxWebFrame constructor
so that it happens before we call init() on the new frame. Fixes asserts checking
frame count consistency.
- 5:18 PM Changeset in webkit [53352] by
-
- 2 edits in trunk/LayoutTests
2010-01-15 Darin Fisher <darin@chromium.org>
Fix flakey test.
Add a call to clearBackForwardList.
- fast/history/history-length.html:
- 5:13 PM Changeset in webkit [53351] by
-
- 7 edits in trunk
2010-01-15 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Original patch by David Ronis <david.ronis@mcgill.ca>
Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=33486
Deprecated symbols replaced for gtk+ versions over 2.18.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect):
2010-01-15 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Original patch by David Ronis <david.ronis@mcgill.ca>
Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=33486
Deprecated symbols replaced for gtk+ versions over 2.18.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect):
- webkit/webkitprivate.cpp: (currentToplevelCallback):
- webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event):
- 4:58 PM Changeset in webkit [53350] by
-
- 2 edits1 move in trunk/LayoutTests
2010-01-15 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Disable page cache and add diagnostic output in the failure case.
https://bugs.webkit.org/show_bug.cgi?id=33749
- fast/history/history-length-expected.txt:
- fast/history/history-length.html: Copied from fast/history/history-length.html-disabled.
- fast/history/history-length.html-disabled: Removed.
- 4:16 PM Changeset in webkit [53349] by
-
- 2 edits in trunk/WebCore
2010-01-15 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055
Improve the performance of the early culling check by avoiding save/restore
of graphics state in culled case.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 3:21 PM Changeset in webkit [53348] by
-
- 1 edit1 move in trunk/LayoutTests
2010-01-15 Darin Fisher <darin@chromium.org>
Disable this test temporarily since it is failing on all of the
builders.
- fast/history/history-length.html: Removed.
- fast/history/history-length.html-disabled: Copied from fast/history/history-length.html.
- 2:37 PM Changeset in webkit [53347] by
-
- 16 edits1 delete in trunk
2010-01-15 Eric Seidel <eric@webkit.org>
No review, rolling out r53344.
http://trac.webkit.org/changeset/53344
https://bugs.webkit.org/show_bug.cgi?id=32920
Broke the Chromium Mac builder.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/SerializedScriptValue.cpp: Removed.
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::toString): (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
2010-01-15 Eric Seidel <eric@webkit.org>
No review, rolling out r53344.
http://trac.webkit.org/changeset/53344
https://bugs.webkit.org/show_bug.cgi?id=32920
Broke the Chromium Mac builder.
- src/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject):
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask):
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
- 2:08 PM Changeset in webkit [53346] by
-
- 5 edits2 adds in trunk
2010-01-15 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
history.length does not return number of elements in history list
https://bugs.webkit.org/show_bug.cgi?id=24472
Test: fast/history/history-length.html
- page/Page.cpp: (WebCore::Page::getHistoryLength):
- 1:47 PM Changeset in webkit [53345] by
-
- 3 edits in trunk/WebCore
Need to ensure that Document::postTask does not provide the Task with a dangling pointer to destroyed Document
https://bugs.webkit.org/show_bug.cgi?id=31633
Reviewed by Darin Adler.
Don't see a way to add test for it, we don't have a way to reproduce the issue currently.
- dom/Document.cpp:
(WebCore::DocumentWeakReference::DocumentWeakReference):
(WebCore::DocumentWeakReference::document):
(WebCore::DocumentWeakReference::clear):
(WebCore::Document::Document): Create a weak reference to this Document.
(WebCore::Document::~Document): Clear the weak pointer, preventing further execution of tasks.
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask): Check if the documentWeakReference is cleared by Document destructor - in this case do not run the task.
(WebCore::Document::postTask):
- dom/Document.h:
(WebCore::DocumentWeakReference::create):
- 1:28 PM Changeset in webkit [53344] by
-
- 16 edits1 add in trunk
2010-01-15 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by David Levin.
[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620
Initial implementation of SerializedScriptValue which is used to
to create a serialized representation of JavaScript objects. This
representation is needed for structured clones and worker messages.
- WebCore.gypi: Added SerializedScriptValue.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Removed conversion to string before using SerializedScriptValue.
- bindings/v8/SerializedScriptValue.cpp: Added. (WebCore::): (WebCore::ZigZag::encode): (WebCore::ZigZag::decode): (WebCore::Writer::Writer): (WebCore::Writer::writeUndefined): (WebCore::Writer::writeNull): (WebCore::Writer::writeTrue): (WebCore::Writer::writeFalse): (WebCore::Writer::writeString): (WebCore::Writer::writeInt32): (WebCore::Writer::writeNumber): (WebCore::Writer::endComposite): (WebCore::Writer::data): (WebCore::Writer::doWriteUint32): (WebCore::Writer::append): (WebCore::Writer::ensureSpace): (WebCore::Writer::fillHole): (WebCore::Writer::charAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::StateBase::~StateBase): (WebCore::Serializer::StateBase::nextState): (WebCore::Serializer::StateBase::setNextState): (WebCore::Serializer::StateBase::composite): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::tag): (WebCore::Serializer::State::State): (WebCore::Serializer::StackCleaner::StackCleaner): (WebCore::Serializer::StackCleaner::~StackCleaner): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::done): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::done): (WebCore::Serializer::ObjectState::advance): (WebCore::Serializer::ObjectState::nextProperty): (WebCore::Serializer::doSerialize): (WebCore::Serializer::push): (WebCore::Serializer::top): (WebCore::Serializer::pop): (WebCore::Serializer::checkComposite): (WebCore::Reader::Reader): (WebCore::Reader::isEof): (WebCore::Reader::read): (WebCore::Reader::readTag): (WebCore::Reader::readString): (WebCore::Reader::readInt32): (WebCore::Reader::readNumber): (WebCore::Reader::doReadUint32): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::deserialize): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::push): (WebCore::Deserializer::pop): (WebCore::Deserializer::stackDepth): (WebCore::Deserializer::element): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::deserialize):
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::toWireString):
Updated uses of SerializedScriptValue:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
2010-01-15 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by David Levin.
[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620
Updated uses of SerializedScriptValue:
- src/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject):
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask):
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
- 1:12 PM WebKit Team edited by
- Added myself. (diff)
- 12:54 PM Changeset in webkit [53343] by
-
- 3 edits in trunk/WebCore
2010-01-15 Oliver Hunt <oliver@apple.com>
Reviewed by Dirk Schulze.
Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055
Add an early return when we go to paint a RenderPath that
isn't in the current clip.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
- 12:53 PM Changeset in webkit [53342] by
-
- 3 edits in trunk/WebCore
2010-01-15 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Make Geolocation::suspend/resume public.
https://bugs.webkit.org/show_bug.cgi?id=33679
These were made private in Bug 32499, but are required by Android to be public.
No new tests, build fix only.
- page/Geolocation.cpp: Modified (WebCore::Geolocation::suspend): Added back in (WebCore::Geolocation::resume): Added back in
- page/Geolocation.h: Modified. Make suspend and resume public
- 12:48 PM Changeset in webkit [53341] by
-
- 5 edits2 adds in trunk
2010-01-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESISON: Google maps buttons not working properly
https://bugs.webkit.org/show_bug.cgi?id=31871
REGRESSION(r52948): JavaScript exceptions thrown on Google Maps when
getting directions for a second time
https://bugs.webkit.org/show_bug.cgi?id=33446
SunSpider and v8 report no change.
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): Update our cached offset in case flattening the dictionary changed any of its offsets.
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- runtime/Operations.h: (JSC::normalizePrototypeChain): ditto
2010-01-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESISON: Google maps buttons not working properly
https://bugs.webkit.org/show_bug.cgi?id=31871
REGRESSION(r52948): JavaScript exceptions thrown on Google Maps when
getting directions for a second time
https://bugs.webkit.org/show_bug.cgi?id=33446
Added a test for these bugs.
- fast/js/pic/undictionary-expected.txt: Added.
- fast/js/pic/undictionary.html: Added.
- 12:36 PM Changeset in webkit [53340] by
-
- 3 edits in trunk/WebKitTools
2010-01-15 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Kilzer.
Altered parseDiffHeader() to skip unrecognized lines and
other minor clean-ups.
- Scripts/VCSUtils.pm:
- Changed parseDiffHeader() as follows:
- Skips over unrecognized lines.
- Addressed FIXME to remove substitution for "diff" line.
- Renamed "version" header hash key to "sourceRevision".
- Eliminated "copiedFromVersion" header hash key.
- Included "sourceRevision" also for copied files.
- Checks that copy revision number matches "sourceRevision".
- No longer returns $foundHeaderEnding.
- Dies if header ending not found.
- Diff header dividing line now always added.
- Changed parseDiffHeader() as follows:
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Made necessary changes in parseDiffHeader() unit tests.
- Shortened the file paths in some test cases.
- 12:26 PM Changeset in webkit [53339] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/index.html
2010-01-15 William Siegrist <wsiegrist@apple.com>
Cleanup buildbot main menu
- 12:20 PM Changeset in webkit [53338] by
-
- 2 edits in trunk/WebCore
2010-01-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Set pointer cursor when over a breakpoint in the BreakpointsSidebarPane
- inspector/front-end/inspector.css:
- 12:20 PM Changeset in webkit [53337] by
-
- 2 edits in trunk/LayoutTests
2010-01-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
svg/custom/marker-changes.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=33728
removing gratuitous setTimeout.
- svg/custom/marker-changes.svg:
- 10:56 AM Changeset in webkit [53336] by
-
- 2 edits in trunk/LayoutTests
2010-01-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
transitions/shorthand-border-transitions.html is still flaky on slower bots
https://bugs.webkit.org/show_bug.cgi?id=33721
Increase the tolerance. The test still tests what it was meant to.
- transitions/shorthand-border-transitions.html:
- 10:38 AM Changeset in webkit [53335] by
-
- 6 edits in trunk/WebCore
2010-01-15 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Generate more of the custom behaviors that the v8 bindings attach to v8 FunctionTemplates.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp: (WebCore::getToStringName): (WebCore::constructorToString): (WebCore::getToStringTemplate):
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- 9:46 AM Changeset in webkit [53334] by
-
- 2 edits in trunk/WebCore
2010-01-15 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r53331.
http://trac.webkit.org/changeset/53331
https://bugs.webkit.org/show_bug.cgi?id=30055
Broke fast/borders/svg-as-border-image-3.html. Don't give up,
Oliver! You are really, really close.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 9:46 AM Changeset in webkit [53333] by
-
- 3 edits in trunk/LayoutTests
2010-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33461
Make test half as long. Remove a setTimeout and tweak tolerances to
reduce flakiness.
- animations/combo-transform-translate+scale.html:
- 9:13 AM BuildingQtOnSymbian edited by
- (diff)
- 9:13 AM BuildingQtOnSymbian edited by
- (diff)
- 9:04 AM BuildingQtOnSymbian created by
- 8:46 AM Changeset in webkit [53332] by
-
- 2 edits in trunk
Rubber-stamped by Xan Lopez.
Bump version to 1.1.19.
- configure.ac:
- 8:43 AM QtWebKit edited by
- (diff)
- 4:25 AM Changeset in webkit [53331] by
-
- 2 edits in trunk/WebCore
2010-01-15 Oliver Hunt <oliver@apple.com>
Reviewed by Nikolas Zimmermann.
Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055
Add an early return when we go to paint a RenderPath that
isn't in the current clip.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 3:59 AM Changeset in webkit [53330] by
-
- 2 edits in trunk/WebCore
2010-01-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Antti Koivisto.
Use OS(MAC_OS_X) instead of PLATFORM(MAC) when determining navigator.platform
- page/NavigatorBase.cpp:
- 3:54 AM Changeset in webkit [53329] by
-
- 2 edits in trunk/WebCore
2010-01-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Compiler warning: comparisons like 'X<=Y<=Z' do not have their mathematical meaning
https://bugs.webkit.org/show_bug.cgi?id=33575
Patch from Magnus Boman <captain.magnus@gmail.com>
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): fix compiler warnings.
- 3:20 AM Changeset in webkit [53328] by
-
- 9 edits1 add in trunk/WebCore
2010-01-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Add welcome screen to Profiles pane to provide some instructions for novices.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.get welcomeMessage): (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.registerProfileType): (WebInspector.ProfilesPanel.prototype._addWelcomeMessage.messageButtonClicked): (WebInspector.ProfilesPanel.prototype._addWelcomeMessage): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.closeVisibleView): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WelcomeView.js: Added. (WebInspector.WelcomeView): (WebInspector.WelcomeView.prototype._windowResized): (WebInspector.WelcomeView.prototype.addMessage):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 2:00 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:54 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:45 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:43 AM Changeset in webkit [53327] by
-
- 2 edits in trunk/WebCore
[Qt/Win] Flash in QGraphicsWebView does not process hover correctly.
Reviewed by Simon Hausmann.
Mouse hover does not work as expected with the flash in some sites.
- http://www.bbc.co.uk/ Hover over the map
- http://www.barbie.com/ Hover over the menu items (Games, Videos)
The problem appears to be that Flash queries NPNVnetscapeWindow on every
mouse hover. I do not how flash uses this value but returning 0 when flash
is in windowless mode solves the problem (When using QGraphicsWebView we
inject wmode opaque, thereby putting the plugin in windowless mode).
- 12:30 AM Changeset in webkit [53326] by
-
- 2 edits in trunk/WebCore
2010-01-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for Peer class
https://bugs.webkit.org/show_bug.cgi?id=33670
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class Peer - websockets/WebSocketChannelClient.h:38
- websockets/WorkerThreadableWebSocketChannel.h:
- 12:23 AM Changeset in webkit [53325] by
-
- 2 edits in trunk/WebCore
2010-01-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Oliver Hunt.
[Qt] Allow custom memory allocation control for GraphicsContextPlatformPrivate class
https://bugs.webkit.org/show_bug.cgi?id=33669
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class GraphicsContextPlatformPrivate - platform/graphics/qt/GraphicsContextQt.cpp:254
- platform/graphics/qt/GraphicsContextQt.cpp:
- 12:20 AM Changeset in webkit [53324] by
-
- 4 edits2 adds in trunk
2010-01-14 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
history.pushState should clear the entire forward history
https://bugs.webkit.org/show_bug.cgi?id=33160
Test: fast/loader/stateobjects/pushstate-clears-forward-history.html
- history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::pushStateItem):
- history/BackForwardList.h:
Jan 14, 2010:
- 11:48 PM Changeset in webkit [53323] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33705
UStringImpl::create() should use internal storage
Reviewed by Oliver Hunt.
When creating a UStringImpl copying of a UChar*, we can use an internal buffer,
by calling UStringImpl::tryCreateUninitialized().
Also, remove duplicate of copyChars from JSString, call UStringImpl's version.
Small (max 0.5%) progression on Sunspidey.
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/UStringImpl.h:
(JSC::UStringImpl::create):
- 11:31 PM Changeset in webkit [53322] by
-
- 7 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
REGRESSION: svg/css/circle-in-mask-with-shadow.svg failing pixel tests
https://bugs.webkit.org/show_bug.cgi?id=33498
After http://trac.webkit.org/changeset/53300 Qt expected files should be updated.
- platform/qt/svg/css/arrow-with-shadow-expected.txt: updated.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: updated.
- platform/qt/svg/css/mask-with-shadow-expected.txt: updated.
- platform/qt/svg/css/path-with-shadow-expected.txt: updated.
- platform/qt/svg/css/stars-with-shadow-expected.txt: updated.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: updated.
- 10:55 PM Changeset in webkit [53321] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-14 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Oliver Hunt.
[Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy
https://bugs.webkit.org/show_bug.cgi?id=33704
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
- 10:43 PM Changeset in webkit [53320] by
-
- 20 edits in trunk
JavaScriptCore: Make naming & behaviour of UString[Impl] methods more consistent.
https://bugs.webkit.org/show_bug.cgi?id=33702
Reviewed by Sam Weinig.
UString::create() creates a copy of the UChar* passed, but UStringImpl::create() assumes
that it should assume ownership of the provided buffer (with UString::createNonCopying()
and UStringImpl::createCopying() providing the alternate behaviours). Unify on create()
taking a copy of the provided buffer. For non-copying cases, use the name 'adopt', and
make this method take a Vector<UChar>&. For cases where non-copying construction was being
used, other than from a Vector<UChar>, change the code to allocate the storage along with
the UStringImpl using UStringImpl::createUninitialized(). (The adopt() method also more
closely matches that of WebCore::StringImpl).
Also, UString::createUninitialized() and UStringImpl::createUninitialized() have incompatible
behaviours, in that the UString form sets the provided UChar* to a null or non-null value to
indicate success or failure, but UStringImpl uses the returned PassRefPtr<UStringImpl> to
indicate when allocation has failed (potentially leaving the output Char* uninitialized).
This is also incompatible with WebCore::StringImpl's behaviour, in that
StringImpl::createUninitialized() will CRASH() if unable to allocate. Some uses of
createUninitialized() in JSC are unsafe, since they do not test the result for null.
UStringImpl's indication is preferable, since we may want a successful call to set the result
buffer to 0 (specifically, StringImpl returns 0 for the buffer where createUninitialized()
returns the empty string, which seems reasonable to catch bugs early). UString's method
cannot support UStringImpl's behaviour directly, since it returns an object rather than a
pointer.
- remove UString::createUninitialized(), replace with calls to UStringImpl::createUninitialized()
- create a UStringImpl::tryCreateUninitialized() form UStringImpl::createUninitialized(), with current behaviour, make createUninitialized() crash on failure to allocate.
- make cases in JSC that do not check the result call createUninitialized(), and cases that do check call tryCreateUninitialized().
Rename computedHash() to existingHash(), to bring this in line wih WebCore::StringImpl.
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- JavaScriptCore.exp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
- runtime/Lookup.h:
(JSC::HashTable::entry):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
- runtime/Structure.cpp:
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::checkConsistency):
- runtime/Structure.h:
(JSC::Structure::get):
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTableHash::hash):
- runtime/UString.cpp:
(JSC::createRep):
(JSC::UString::UString):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::operator=):
- runtime/UString.h:
(JSC::UString::adopt):
(JSC::IdentifierRepHash::hash):
(JSC::makeString):
- runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::existingHash):
WebCore: Rubber stamped by Sam Weinig.
Make naming & behaviour of UString[Impl] methods more consistent.
https://bugs.webkit.org/show_bug.cgi?id=33702
WebCore change reflecting UString method name change computedHash() -> existingHash().
- platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
- 10:14 PM Changeset in webkit [53319] by
-
- 2 edits in trunk
[Qt] Defective dependencies caused build failing on QtBuildBot.
https://bugs.webkit.org/show_bug.cgi?id=33693
Reviewed by Eric Seidel.
- WebKit.pri: CONFIG += depend_includepath added.
- 9:10 PM Changeset in webkit [53318] by
-
- 5 edits in trunk/WebCore
<rdar://problem/6020083> -webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650
Reviewed by Simon Fraser.
- platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::drawPattern): Added call to adjustParametersForTiledDrawing(),
letting the generator substitute the parameters with visually-equivalent values that
are more efficient.
- platform/graphics/Generator.h:
(WebCore::Generator::adjustParametersForTiledDrawing): Added a base class implementation
that does nothing.
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::adjustParametersForTiledDrawing): Added. If the gradient is a horizontal
or vertical linear gradient, changes to use a 1-pixel tall (or wide) tile.
- platform/graphics/Gradient.h:
- 8:56 PM Changeset in webkit [53317] by
-
- 5 edits in trunk/WebKitTools
2010-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.6
https://bugs.webkit.org/show_bug.cgi?id=32299
The newer pywebsocket can handle more simultaneous connections.
- pywebsocket/mod_pywebsocket/handshake.py:
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_handshake.py:
- 8:42 PM Changeset in webkit [53316] by
-
- 49 edits in trunk/LayoutTests
Bug 31865 - Re-do ruby layout tests to use only Latin characters
(https://bugs.webkit.org/show_bug.cgi?id=31865)
Reviewed by David Levin.
New base-lines for the Windows platform.
- platform/win/fast/ruby/ruby-empty-rt-expected.checksum:
- platform/win/fast/ruby/ruby-empty-rt-expected.png:
- platform/win/fast/ruby/ruby-empty-rt-expected.txt:
- platform/win/fast/ruby/ruby-length-expected.checksum:
- platform/win/fast/ruby/ruby-length-expected.png:
- platform/win/fast/ruby/ruby-length-expected.txt:
- platform/win/fast/ruby/ruby-run-break-expected.checksum:
- platform/win/fast/ruby/ruby-run-break-expected.png:
- platform/win/fast/ruby/ruby-run-break-expected.txt:
- platform/win/fast/ruby/ruby-runs-expected.checksum:
- platform/win/fast/ruby/ruby-runs-expected.png:
- platform/win/fast/ruby/ruby-runs-expected.txt:
- platform/win/fast/ruby/ruby-runs-spans-expected.checksum:
- platform/win/fast/ruby/ruby-runs-spans-expected.png:
- platform/win/fast/ruby/ruby-runs-spans-expected.txt:
- platform/win/fast/ruby/ruby-simple-expected.checksum:
- platform/win/fast/ruby/ruby-simple-expected.png:
- platform/win/fast/ruby/ruby-simple-expected.txt:
- platform/win/fast/ruby/ruby-simple-rp-expected.checksum:
- platform/win/fast/ruby/ruby-simple-rp-expected.png:
- platform/win/fast/ruby/ruby-simple-rp-expected.txt:
- platform/win/fast/ruby/ruby-trailing-expected.checksum:
- platform/win/fast/ruby/ruby-trailing-expected.png:
- platform/win/fast/ruby/ruby-trailing-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum:
- platform/win/fast/ruby/rubyDOM-insert-rt-expected.png:
- platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum:
- platform/win/fast/ruby/rubyDOM-insert-text1-expected.png:
- platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum:
- platform/win/fast/ruby/rubyDOM-insert-text2-expected.png:
- platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum:
- platform/win/fast/ruby/rubyDOM-insert-text3-expected.png:
- platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
- platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png:
- platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
- platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png:
- platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum:
- platform/win/fast/ruby/rubyDOM-remove-text1-expected.png:
- platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum:
- platform/win/fast/ruby/rubyDOM-remove-text2-expected.png:
- platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
- 8:20 PM Changeset in webkit [53315] by
-
- 2 edits in trunk/WebCore
2010-01-14 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Laszlo Gombos.
Platform Symbian specific:
Added time-based optimization (-Otime) and increased optimization level to -O3,
conditionally for RVCT compiler (for ARM), for increasing performance
(primarily affecting JavaScript execution).
Default settings are -Ospace and -O2.
No new tests needed because no new funtionality is introduced,
only potential regression on existing tests needs to be evaluated.
- WebCore.pro:
- 8:08 PM QtWebKitBackportingFixes edited by
- (diff)
- 6:44 PM Changeset in webkit [53314] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-14 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=33648
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
- 6:42 PM Changeset in webkit [53313] by
-
- 2 edits in trunk/WebCore
2010-01-14 Jungshik Shin <jshin@chromium.org>
Unreviewed, attempted build fix on chromium.
Fix a Chromium build failure due to an unused variable in V8 binding.(part 2)
- bindings/v8/V8Collection.h: (WebCore::getNamedPropertyOfCollection):
- 6:35 PM Changeset in webkit [53312] by
-
- 2 edits in trunk/WebCore
2010-01-14 Jungshik Shin <jshin@chromium.org>
Unreviewed, attempted build fix on chromium.
Fix a Chromium build failure due to an unused variable in V8 binding.
- bindings/v8/V8Collection.h: (WebCore::getIndexedPropertyOfCollection):
- 6:04 PM Changeset in webkit [53311] by
-
- 2 edits in trunk/WebCore
Unreviewed, attempted build fix.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
- 5:52 PM Changeset in webkit [53310] by
-
- 3 edits in trunk/LayoutTests
2010-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
animations/change-keyframes.html failed on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33370
Increase tolerances. They're still testing the stated goal of the test.
- animations/change-keyframes.html:
- transitions/cancel-transition.html:
- 5:45 PM Changeset in webkit [53309] by
-
- 8 edits in trunk/WebCore
Simplify image decoders by making downsampling functions available at
all times, allowing much duplicated logic to be collapsed.
https://bugs.webkit.org/show_bug.cgi?id=28751
Reviewed by Adam Barth.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::prepareScaleDataIfNecessary):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::scaledSize):
(WebCore::ImageDecoder::setMaxNumPixels):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
- 5:34 PM Changeset in webkit [53308] by
-
- 2 edits in trunk/WebCore
[chromium] Remove obsolete CF related files from gyp build.
https://bugs.webkit.org/show_bug.cgi?id=33002
Reviewed by Eric Seidel.
- WebCore.gypi:
- 5:34 PM Changeset in webkit [53307] by
-
- 2 edits in trunk/LayoutTests
Skip new test that requires new functionality in
DRT (layoutTestController.setWillSendRequestReturnsNull).
- 5:31 PM Changeset in webkit [53306] by
-
- 2 edits in trunk/LayoutTests
Skipping test that fails intermitently - fix for the test being
worked on; see https://bugs.webkit.org/show_bug.cgi?id=33671.
- 5:30 PM Changeset in webkit [53305] by
-
- 3 edits in trunk/WebCore
Decoding images to scaled output buffers resulted in garbage for
no-alpha PNGs and CMYK JPEGs.
https://bugs.webkit.org/show_bug.cgi?id=33624
Reviewed by Adam Barth.
No layout test since I don't have access to a platform that scales the
output buffers.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::convertCMYKToRGBA):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
- 5:25 PM Changeset in webkit [53304] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Eric Seidel.
[GTK] Crashes cleaning clipboard contents, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=32900
Null-check the focus controller to avoid crashing. Could not find
a way to reproduce this consistently, thus no test.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback):
- 5:24 PM Changeset in webkit [53303] by
-
- 4 edits in trunk/LayoutTests
2010-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
LayoutTests/animations/play-state.html and LayoutTests/animations/3d/transform-origin-vs-functions.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33626
Speculative fixes.
- animations/3d/transform-origin-vs-functions.html: Remove timeout for notifyDone and start measurement at webkitAnimationStart instead of body onload.
- animations/play-state-expected.txt:
- animations/play-state.html: Reduce test time in half, but keep the same tolerance level.
- 5:22 PM Changeset in webkit [53302] by
-
- 7 edits in trunk/LayoutTests
2010-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
A few more flaky transitions/animations tests
https://bugs.webkit.org/show_bug.cgi?id=33642
Attempt to deflake a few more tests. Some of these are second
attempts. The first attempt made it less flaky, but not 100%.
Also, for a couple tests, make them shorter. They seemed
unnecessarily long.
- animations/change-one-anim-expected.txt:
- animations/change-one-anim.html:
- transitions/cancel-transition.html:
- transitions/mask-transitions.html:
- transitions/shorthand-border-transitions-expected.txt:
- transitions/shorthand-border-transitions.html:
- 5:17 PM Changeset in webkit [53301] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Oliver Hunt.
Fix an assertion that was causing test crashes. Filed a bug
about the weirdness that causes this assertion (inconsistencies
between DragOperationMove and DragOperationGeneric).
- dom/Clipboard.cpp:
(WebCore::dragOpFromIEOp):
(WebCore::Clipboard::setDestinationOperation):
- 5:13 PM Changeset in webkit [53300] by
-
- 43 edits in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>
Reviewed by Sam Weinig.
This change makes repaintRectInLocalCoordinates return a rect that
is -webkit-svg-shadow-aware.
- rendering/RenderPath.cpp:
(WebCore::RenderPath::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
- rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::inflateForShadow):
- rendering/style/SVGRenderStyle.h:
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>
Reviewed by Sam Weinig.
All of these tests just needed to be updated because of small
rounding differences.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum:
- platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/mac/svg/css/arrow-with-shadow-expected.png:
- platform/mac/svg/css/arrow-with-shadow-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.checksum:
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/css/css-box-min-width-expected.checksum:
- platform/mac/svg/css/css-box-min-width-expected.png:
- platform/mac/svg/css/group-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/css/path-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.txt:
- platform/mac/svg/css/shadow-and-opacity-expected.txt:
- platform/mac/svg/css/shadow-with-large-radius-expected.txt:
- platform/mac/svg/css/shadow-with-negative-offset-expected.txt:
- platform/mac/svg/css/stars-with-shadow-expected.checksum:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- 5:09 PM Changeset in webkit [53299] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:50 PM Changeset in webkit [53298] by
-
- 8 edits in trunk/WebKitTools
2010-01-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
https://bugs.webkit.org/show_bug.cgi?id=33638
- Scripts/webkitpy/bugzilla.py:
- Add Bug.id() to match Attachment.id()
- Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
- Add back a missing variable to _validate_setter_email found by the new unit tests!
- Scripts/webkitpy/commands/queries.py:
- Add FIXMEs about the commands being confusingly named.
- Scripts/webkitpy/commands/queries_unittest.py:
- Update results to reflect the newly restructured mock bug cache.
- Scripts/webkitpy/commands/queues.py:
- Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
- Add a FIXME about eventually sorting the patches into some order.
- Scripts/webkitpy/commands/queues_unittest.py:
- Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
- Scripts/webkitpy/commands/upload_unittest.py:
- Update results to match the newly restructured mock bug cache.
- Scripts/webkitpy/mock_bugzillatool.py:
- Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
- Add a few more attachments and bug dictionaries for use by the tests.
- 4:08 PM Changeset in webkit [53297] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Not reviewed. Fix reviewer.
- 4:06 PM Changeset in webkit [53296] by
-
- 9 edits in trunk
Drag and Drop source/destination code needs cleanup.
<https://bugs.webkit.org/show_bug.cgi?id=33691>.
Reviewed by Adam Roben.
WebCore:
Cleaned up some Drag and Drop code that deals with getting
source and destination operations, and added some ASSERTS to make
sure we don't get in bad states.
- dom/Clipboard.cpp:
(WebCore::Clipboard::sourceOperation): Make this return the operation itself.
(WebCore::Clipboard::destinationOperation): Ditto.
(WebCore::Clipboard::setSourceOperation): Add an assert to make sure we're valud.
(WebCore::Clipboard::setDestinationOperation): Ditto.
- dom/Clipboard.h:
- page/DragController.cpp:
(WebCore::DragController::tryDHTMLDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
WebKit/chromium:
Update to new way of calling sourceOperation.
- src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
WebKit/qt:
Update to new way of calling sourceOperation.
- WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):
- 3:38 PM Changeset in webkit [53295] by
-
- 4 edits in trunk/WebCore
Make the Web Inspector's JavaScript debugger work with isolated worlds.
Console evaluation is not performed in the correct world yet, tracked
by bug http://webkit.org/b/33692.
Reviewed by Adam Roben.
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore): Attach the debugger to
any window shell, not just for the debugger world.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Detach the debugger, and
reattach to all window shells, not just for the debugger world.
(WebCore::ScriptController::initScript): Attach the debugger to
any window shell, not just for the debugger world.
(WebCore::ScriptController::attachDebugger): Changed to loop through
all the window shells and call the new overloaded attachDebugger.
(WebCore::ScriptController::attachDebugger): Added. An overload that
takes a window shell to attach the debugger to. Has most of the
logic from the original attachDebugger.
- bindings/js/ScriptController.h: Added the new attachDebugger.
- 3:08 PM Changeset in webkit [53294] by
-
- 5 edits in trunk/WebKit/gtk
Reviewed by Oliver Hunter.
[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428
Do not emit signals and property notifications for error
pages. The notifications are not really useful for anything, you
can get them back by overriding the error pages, and it avoids a
number of hacks.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad): (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- WebCoreSupport/FrameLoaderClientGtk.h:
- tests/testloading.c: (load_error_status_changed_cb): (test_loading_error):
- 3:07 PM Changeset in webkit [53293] by
-
- 2 edits in trunk
Add missing Radar URLs
- 3:05 PM Changeset in webkit [53292] by
-
- 4 edits2 adds in trunk
2010-01-14 Adam Roben <Adam Roben>
Add a test that shows onload still fires if a load of a <script src>
is cancelled by the resource load delegate
Tests for <http://webkit.org/b/33687> window.onload never fires if
page contains a <script src=foo> whose load is cancelled by resource
load delegate returning null from willSendRequest
Reviewed by Dave Hyatt.
- fast/loader/onload-willSendRequest-null-for-script-expected.txt: Added.
- fast/loader/onload-willSendRequest-null-for-script.html: Added.
- platform/qt/Skipped: Added the new test since Qt doesn't have layoutTestController.setWillSendRequestReturnsNull.
2010-01-14 Adam Roben <Adam Roben>
Make Cache::requestResource return 0 if the resource's load fails
immediately
Fixes <http://webkit.org/b/33687> window.onload never fires if page
contains a <script src=foo> whose load is cancelled by resource load
delegate returning null from willSendRequest
Test: fast/loader/onload-willSendRequest-null-for-script.html
Reviewed by Dave Hyatt.
- loader/Cache.cpp: (WebCore::Cache::requestResource): Moved code to handle immediate load failure out of the "cache is disabled" block so that it will run even when the cache is enabled.
- 2:35 PM Changeset in webkit [53291] by
-
- 7 edits2 adds in trunk
WebCore: Fix for crash with gradient on table cell. Pass the correct
background object down to
RenderBoxModelObject::paintFillLayerExtended(). This also allowed a
rework of the fix to bug 18445 by passing the correct RenderObject
from RenderBox::paintRootBoxDecorations() down to
RenderBoxModelObject::paintFillLayerExtended().
https://bugs.webkit.org/show_bug.cgi?id=28426
Reviewed by mitz@webkit.org.
Covered by new layout test: LayoutTests/fast/gradients/crash-on-tr.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
Plumb through the correct background RenderObject.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the passed-in background RenderObject (if present) when painting background images. Remove the previous fix for bug 18445.
- rendering/RenderBoxModelObject.h:
Plumb through the correct background RenderObject.
- rendering/RenderTableCell.cpp:
Pass in the correct backgroundObject to paintFillLayers().
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
LayoutTests: New layout test added to exercise fix for bug
http://bugs.webkit.org/show_bug.cgi?id=28426
Reviewed by mitz@webkit.org.
- fast/gradients/crash-on-tr-expected.txt: Added.
- fast/gradients/crash-on-tr.html: Added.
- 2:07 PM Changeset in webkit [53290] by
-
- 15 edits in trunk
2010-01-14 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Standardize the rest of the v8 bindings on toNative() wherever possible.
- bindings/v8/NPV8Object.cpp: (v8ObjectToNPObject): Special case for converting NPObjects, since there aren't genereated bindings for them.
- bindings/v8/NPV8Object.h:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8Collection.cpp:
- bindings/v8/V8Collection.h: (WebCore::toNativeCollection): Special case for converting V8Collections, since there aren't genereated bindings for them.
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8SVGPODTypeWrapper.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- 1:21 PM Changeset in webkit [53289] by
-
- 6 edits4 adds in trunk
2010-01-14 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
Chromium Linux: don't stretch checkboxes
https://bugs.webkit.org/show_bug.cgi?id=28631
- fast/css/non-standard-checkbox-size.html: Added.
- platform/mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
- platform/mac/fast/css/non-standard-checkbox-size-expected.png: Added.
- platform/mac/fast/css/non-standard-checkbox-size-expected.txt: Added.
- platform/gtk/Skipped: Skipping this new test so I don't break this bot. Just needs new results.
- platform/qt/Skipped: ditto
- platform/win/Skipped: ditto
2010-01-14 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
Chromium Linux: don't stretch checkboxes
https://bugs.webkit.org/show_bug.cgi?id=28631
Make the default size for checkboxes/radio buttons also the maximum
size.
Based on patch by Adam Langley.
Test: fast/css/non-standard-checkbox-size.html
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::center): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio):
- 1:16 PM Changeset in webkit [53288] by
-
- 2 edits in trunk/WebCore
Follow up to <https://bugs.webkit.org/show_bug.cgi?id=33635>.
Reviewed by Adam Roben.
Now that dropEffect and effectAllowed are guaranteed to not be
null, change null checks into asserts to make sure we are returning
a proper DragOperation value.
- dom/Clipboard.cpp:
(WebCore::Clipboard::sourceOperation): Change null check to assert.
(WebCore::Clipboard::destinationOperation): Ditto.
- 12:47 PM Changeset in webkit [53287] by
-
- 10 edits4 adds in trunk
[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.
Reviewed by Oliver Hunt.
WebCore:
Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).
Also, drive by change to initialize dropEffect to none (as described in spec).
Test: fast/events/bogus-dropEffect-effectAllowed.html
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.
LayoutTests:
Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.
Also, fixed a few tests that broke when the default dropEffect was set to
none to match the spec.
- fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
- fast/events/bogus-dropEffect-effectAllowed.html: Added.
- platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
- platform/qt/fast/events/bogus-dropEffect-effectAllowed.html: Added.
- fast/events/drag-and-drop-expected.txt:
- fast/events/drag-and-drop.html:
- editing/pasteboard/script-tests/files-during-page-drags.js:
- editing/pasteboard/get-data-text-plain-drop.html:
- fast/events/resources/drag-in-frames-right.html:
- http/tests/local/resources/send-dragged-file.js:
- http/tests/misc/bubble-drag-events.html:
- 12:39 PM Changeset in webkit [53286] by
-
- 2 edits in trunk/LayoutTests
Add new test from r53277 to the GTK+ Skipped list
- platform/gtk/Skipped:
- 12:13 PM Changeset in webkit [53285] by
-
- 5 edits in trunk
2010-01-14 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=33371
Test that Object.keys works on a plugin object.
- plugins/netscape-enumerate.html:
2010-01-14 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=33371
RuntimeObjectImp should not reimplement getPropertyNames();
move the implementation to getOwnPropertyNames().
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertyNames):
- bridge/runtime_object.h:
- 11:57 AM Changeset in webkit [53284] by
-
- 2 edits in trunk/WebCore
2010-01-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Add ENABLE(XSLT) guard to TransformSourceLibxslt.cpp
https://bugs.webkit.org/show_bug.cgi?id=33665
TransformSource is available only when ENABLE(XSLT) guard is true.
- dom/TransformSourceLibxslt.cpp:
- 11:52 AM Changeset in webkit [53283] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix ChangeLog order from r53277
- 11:52 AM Changeset in webkit [53282] by
-
- 2 edits in trunk/LayoutTests
Add new tests from r53277 to the Qt Skipped list
- platform/qt/Skipped:
- 11:47 AM Changeset in webkit [53281] by
-
- 6 edits in trunk
[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-13
Reviewed by Kenneth Christiansen.
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setUserStyleSheetEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
- platform/qt/Skipped:
- 11:44 AM Changeset in webkit [53280] by
-
- 7 edits in tags/Safari-6531.22.1/WebCore
Merge r53273.
- 11:38 AM Changeset in webkit [53279] by
-
- 7 edits in branches/safari-4-branch/WebCore
Merge r53273.
- 11:32 AM Changeset in webkit [53278] by
-
- 1 copy in tags/Safari-6531.22.1
New tag.
- 11:29 AM Changeset in webkit [53277] by
-
- 9 edits6 adds in trunk
Treat all synchronous loads equally in FrameLoader::loadSubframe
Only loads of the empty URL or about:blank were being treated as
synchronous loads. But other loads can be synchronous (e.g., when we
receive a null ResourceRequest from requestFromDelegate or when a
policy decision of "ignore" is made). We now treat those loads the
same way we treated empty URLs and about:blank.
Fixes <rdar://problem/7533333> <http://webkit.org/b/33533>
window.onload never fires if page contains an <iframe> with a bad
scheme or whose load is cancelled by returning null from resource load
delegate's willSendRequest
Tests: fast/loader/onload-bad-scheme-for-frame.html
fast/loader/onload-policy-ignore-for-frame.html
fast/loader/onload-willSendRequest-null-for-frame.html
Reviewed by Brady Eidson.
WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadSubframe):
- Detect synchronous loads by checking the subframe's loader's state, rather than by checking its URL
- Removed unnecessary call to completed(), since checkCompleted() will call completed() if needed (the call to completed() was added first and wasn't removed when the call to checkCompleted() was added in r8316)
- Added more comments about the strange thing this function does with the subframe's loader
WebKitTools:
Add LayoutTestController API to force
-webView:resource:willSendRequest:: to return null
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Initialize new member.
(setWillSendRequestReturnsNullCallback): Call through to
LayoutTestController.
(LayoutTestController::staticFunctions): Added new function.
- DumpRenderTree/LayoutTestController.h: Added
m_willSendRequestReturnsNull.
(LayoutTestController::willSendRequestReturnsNull):
(LayoutTestController::setWillSendRequestReturnsNull):
Added standard accessors.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::willSendRequest):
Return null if LayoutTestController says to.
LayoutTests:
Add tests that show that onload still fires in various situations with
subframes
- fast/loader/onload-bad-scheme-for-frame-expected.txt: Added.
- fast/loader/onload-bad-scheme-for-frame.html: Added.
Tests that onload still fires when a subframe with an unrecognized
scheme is in the page.
- fast/loader/onload-policy-ignore-for-frame-expected.txt: Added.
- fast/loader/onload-policy-ignore-for-frame.html: Added.
Tests that onload still fires when the policy delegate says to ignore
the initial load of a subframe.
- fast/loader/onload-willSendRequest-null-for-frame-expected.txt: Added.
- fast/loader/onload-willSendRequest-null-for-frame.html: Added.
Tests that onload still fires when the resource load delegate returns
null from willSendRequest for the initial load of a subframe.
- http/tests/loading/bad-scheme-subframe-expected.txt: Updated result
to show that we now fire onload for the main frame in this case. (This
is essentially the same as onload-bad-scheme-for-frame.html, but it
still seems useful to have that new, more explicit, test.)
- 11:20 AM Changeset in webkit [53276] by
-
- 2 edits in trunk/WebCore
Missing fileSystemPath() method in Qt KURL implementation https://bugs.webkit.org/show_bug.cgi?id=33614
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-14
Reviewed by Kenneth Christiansen.
No new tests.
- platform/qt/KURLQt.cpp:
(WebCore::KURL::fileSystemPath):
- 11:10 AM Changeset in webkit [53275] by
-
- 4 edits in trunk
wx fixes after XBM removal and recent changes.
- 11:03 AM Changeset in webkit [53274] by
-
- 8 edits2 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=33652
REGRESSION: Frames stop appearing after browsing for a while
<rdar://problem/7308312> REGRESSION: iBench gets slower after several runs
I do not know how not creating renderers for frames could make iBench slower, but it did.
Test: fast/frames/cached-frame-counter.html
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): A frame that's cached is moved away from Page, so decrement frame count here. (WebCore::CachedFrame::open): Increase frame count when a frame is restored.
- history/CachedFrame.h: Remove unneeded forward declarations.
- history/CachedPage.h: Ditto.
- history/CachedPage.cpp: (WebCore::CachedPage::restore): Assert that page frame count is zero prior to restoring a page from b/f cache.
- page/Page.cpp: (WebCore::Page::checkFrameCountConsistency): A debug-only method to check that frame count stored in Page matches the number of frames in frame tree.
- page/Page.h: (WebCore::Page::decrementFrameCount): Assert that frame count is positive. (WebCore::Page::frameCount): Call checkFrameCountConsistency().
- 10:56 AM Changeset in webkit [53273] by
-
- 7 edits in trunk/WebCore
Windows build fixes.
Add forward declarations and additional includes of windows.h.
- platform/Cursor.h: Add forward declaration of HCURSOR. Move destructor implementation into cpp.
- platform/graphics/transforms/TransformationMatrix.h: Add forward declaration of XFORM. Remove windows.h include.
- platform/graphics/win/TransformationMatrixWin.cpp: Add include of windows.h.
- platform/win/CursorWin.cpp: Moved destructor of SharedCursor here.
(WebCore::SharedCursor::~SharedCursor): Moved here.
- platform/win/EventLoopWin.cpp: Add include of windows.h.
- platform/win/SystemInfo.cpp: Add include of windows.h.
- 10:47 AM Changeset in webkit [53272] by
-
- 5 edits2 deletes in trunk
Roll out r53270 because it broke 5 layout tests.
- 10:32 AM Changeset in webkit [53271] by
-
- 57 edits in trunk/WebCore
2010-01-14 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Switch the custom V8 bindings to use class toNative() functions.
Refactoring, so no new tests.
- bindings/v8/custom/V8AbstractWorkerCustom.cpp:
- bindings/v8/custom/V8AttrCustom.cpp:
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8ClipboardCustom.cpp:
- bindings/v8/custom/V8CoordinatesCustom.cpp:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DataGridColumnListCustom.cpp:
- bindings/v8/custom/V8DatabaseCustom.cpp:
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8GeolocationCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NodeCustom.cpp:
- bindings/v8/custom/V8NodeIteratorCustom.cpp:
- bindings/v8/custom/V8NodeListCustom.cpp:
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
- bindings/v8/custom/V8PopStateEventCustom.cpp:
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
- bindings/v8/custom/V8SVGLengthCustom.cpp:
- bindings/v8/custom/V8SVGMatrixCustom.cpp:
- bindings/v8/custom/V8StorageCustom.cpp:
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
- bindings/v8/custom/V8TreeWalkerCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8WebSocketCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/v8/custom/V8WorkerCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
- 10:23 AM Changeset in webkit [53270] by
-
- 5 edits2 adds in trunk
[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.
Reviewed by Oliver Hunt.
WebCore:
Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).
Also, drive by change to initialize dropEffect to none (as described in spec).
Test: fast/events/bogus-dropEffect-effectAllowed.html
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.
LayoutTests:
Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.
- fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
- fast/events/bogus-dropEffect-effectAllowed.html: Added.
- fast/events/drag-and-drop-expected.txt:
- fast/events/drag-and-drop.html:
- 9:38 AM Changeset in webkit [53269] by
-
- 4 edits1 add in trunk/WebKit/chromium
2010-01-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Introduce WebFileChooserParams to convey parameters for
WebViewClient::runFileChooser(), and add new parameters to it.
https://bugs.webkit.org/show_bug.cgi?id=32473
The new parameters are
- selected file names
- "accept" attribute value
- WebKit.gyp: Add WebFileChooserParams.h
- public/WebFileChooserParams.h: Added.
- public/WebViewClient.h: (WebKit::WebViewClient::runFileChooser): Add runFileChooser() with WebFileChooserParams, and mark the old one deprecated.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel): Call the new runFileChooser() first, then call the old runFileChooser() if the new one failed.
- 8:09 AM Changeset in webkit [53268] by
-
- 2 edits in trunk/LayoutTests
Fix a typo in editing/selection/inactive-selection.html
Fixes <http://webkit.org/b/33676> Exception when opening
editing/selection/inactive-selection.html in a browser
Reviewed by Dan Bernstein.
- editing/selection/inactive-selection.html: Remove a semicolon that
was making the if (window.layoutTestController) test ineffective.
- 7:54 AM Changeset in webkit [53267] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Symbian build fixes.
Reviewed by Tor Arne Vestbø.
- tests/qwebpage/tst_qwebpage.cpp: Include util.h
- tests/tests.pri: Don't define TESTS_SOURCE_DIR, it doesn't work.
- tests/util.h: Define TESTS_SOURCE_DIR here, just like it's done in Qt.
- 6:52 AM Changeset in webkit [53266] by
-
- 2 edits in trunk/WebKitTools
Add support for partial building on Symbian.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-14
Reviewed by Simon Hausmann.
The build happens in the source directory as out of source builds are
not supported by qmake for Symbian.
Also the actual build isn't started but it is left to the developer
to choose the architecture/configuration.
- Scripts/webkitdirs.pm:
- 6:44 AM Changeset in webkit [53265] by
-
- 2 edits in trunk/WebKitTools
Add support for "detecting" Symbian environments by either
looking for the EPOCROOT environment variable or via --symbian
being passed on the commandline.
Reviewed by Kenneth Rohde Christiansen.
- Scripts/webkitdirs.pm:
- 6:39 AM CommitterTips edited by
- Removed unnecessary brackets (diff)
- 6:21 AM Changeset in webkit [53264] by
-
- 7 edits2 adds in trunk
2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Add DataObjectGtk, a container for pasteboard and drag-and-drop data.
No new tests, because functionality has not changed.
- GNUmakefile.am:
- platform/gtk/DataObjectGtk.cpp: Added. (WebCore::DataObjectGtk::text): (WebCore::DataObjectGtk::markup): (WebCore::DataObjectGtk::setText): (WebCore::DataObjectGtk::setMarkup): (WebCore::DataObjectGtk::files): (WebCore::DataObjectGtk::url): (WebCore::DataObjectGtk::urlLabel): (WebCore::DataObjectGtk::hasURL): (WebCore::DataObjectGtk::clear): (WebCore::DataObjectGtk::forClipboard):
- platform/gtk/DataObjectGtk.h: Added. (WebCore::DataObjectGtk::create): (WebCore::DataObjectGtk::uriList): (WebCore::DataObjectGtk::image): (WebCore::DataObjectGtk::setRange): (WebCore::DataObjectGtk::setURIList): (WebCore::DataObjectGtk::setImage): (WebCore::DataObjectGtk::setDragContext): (WebCore::DataObjectGtk::hasText): (WebCore::DataObjectGtk::hasMarkup): (WebCore::DataObjectGtk::hasURIList): (WebCore::DataObjectGtk::hasImage): (WebCore::DataObjectGtk::dragContext):
2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Use DataObjectGtk when setting and clearing pasteboard data on
the GDK_SELECTION_PRIMARY clipboard.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::EditorClient):
- WebCoreSupport/EditorClientGtk.h:
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::fillSelectionData): (WebKit::targetListForDataObject): (WebKit::getClipboardContentsCallback): (WebKit::clearClipboardContentsCallback): (WebKit::PasteboardHelperGtk::writeClipboardContents):
- WebCoreSupport/PasteboardHelperGtk.h:
- 6:07 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 6:06 AM Changeset in webkit [53263] by
-
- 2 edits in trunk/WebCore
2010-01-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Scrolling of Timeline Page was broken by fix for bug 33470.
https://bugs.webkit.org/show_bug.cgi?id=33666
- inspector/front-end/inspector.css:
- 5:27 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 5:19 AM Changeset in webkit [53262] by
-
- 2 edits in trunk/WebKitTools
[Qt] Use a different Makefile names for sources generation and compilation.
This prevents Makefile overwriting when running build-webkit twice.
Unreviewed.
- Scripts/webkitdirs.pm:
- 5:19 AM Changeset in webkit [53261] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed fix of builds with the --no-svg switch.
- WebCore.pri:
- 5:18 AM Changeset in webkit [53260] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed build fix on Windows.
- platform/graphics/transforms/TransformationMatrix.h:
- 4:15 AM Changeset in webkit [53259] by
-
- 7 edits1 add in trunk
2010-01-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable scrolling optimization for pages with embedded widgets
Added a basic manual test for scrolling of embedded QWidgets.
- manual-tests/qt/qtplugin-scrolling.html: Added.
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::setParent):
- platform/ScrollView.h:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::invalidateRect):
2010-01-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
- QtLauncher/main.cpp: (WebPage::createPlugin):
- 4:11 AM Changeset in webkit [53258] by
-
- 3 edits in trunk/LayoutTests
2010-01-13 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015
- media/video-seek-past-end-playing.html: Removed the last timer of this test.
- platform/gtk/Skipped: Unskip test above.
- 4:11 AM Changeset in webkit [53257] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Update Symbian .def symbol export files after private API additions.
Reviewed by Kenneth Rohde Christiansen.
- symbian/bwins/QtWebKitu.def:
- symbian/eabi/QtWebKitu.def:
- 3:56 AM Changeset in webkit [53256] by
-
- 4 edits in trunk/WebKit/gtk
2010-01-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Review the tooltip implementation
https://bugs.webkit.org/show_bug.cgi?id=32819
Change the GTK tooltip implementation to avoid the workaround that
we are currently using. Now we use a new private API to set the
text and all the tooltip handling is done in the webview widget.
- WebCoreSupport/ChromeClientGtk.cpp:
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_set_tooltip_text): Added, new private API. (webkit_web_view_query_tooltip): Added
- 3:40 AM Changeset in webkit [53255] by
-
- 3 edits in trunk/WebCore
2009-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] Check return values of gst_element_set_state()
https://bugs.webkit.org/show_bug.cgi?id=30000
Check for state change failure when going from READY/NULL to
PAUSED or PLAYING. Also refactored the common code of play() and
pause() to a new private method of the player.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::changePipelineState): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 3:23 AM Changeset in webkit [53254] by
-
- 2 edits in trunk
Moves general includes before bindings includes in Android build system.
https://bugs.webkit.org/show_bug.cgi?id=33623
Reviewed by David Levin.
This avoids problems with collisions between WebCore/platform/text/StringBuilder.h
and the new JavaScriptCore/runtime/StringBuilder.h. This change puts
JavaScriptCore/runtime and other bindings includes after the WebCore and other
general includes, so that the WebCore StringBuilder.h is picked up when building
WebCore.
- Android.mk: Modified.
- 3:16 AM WikiStart edited by
- (diff)
- 2:47 AM Changeset in webkit [53253] by
-
- 6 edits in trunk
2010-01-14 Eric Seidel <eric@webkit.org>
No review, rolling out r53249.
http://trac.webkit.org/changeset/53249
https://bugs.webkit.org/show_bug.cgi?id=33617
This caused http/tests/security/local-user-CSS-from-
remote.html to fail on the Qt Release Build Bot.
- platform/qt/Skipped:
2010-01-14 Eric Seidel <eric@webkit.org>
No review, rolling out r53249.
http://trac.webkit.org/changeset/53249
https://bugs.webkit.org/show_bug.cgi?id=33617
This caused http/tests/security/local-user-CSS-from-
remote.html to fail on the Qt Release Build Bot.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 2:39 AM Changeset in webkit [53252] by
-
- 11 edits4 deletes in trunk
2010-01-14 Eric Seidel <eric@webkit.org>
No review, rolling out r53248.
http://trac.webkit.org/changeset/53248
https://bugs.webkit.org/show_bug.cgi?id=32641
Caused 2 tests to crash on various bots:
fast/dom/HTMLSelectElement/listbox-select-reset.html and
fast/forms/listbox-typeahead-scroll.html
- fast/forms/HTMLOptionElement_selected-expected.txt:
- fast/forms/HTMLOptionElement_selected.html:
- fast/forms/HTMLOptionElement_selected2-expected.txt: Removed.
- fast/forms/HTMLOptionElement_selected2.html: Removed.
- fast/forms/HTMLOptionElement_selected3-expected.txt: Removed.
- fast/forms/HTMLOptionElement_selected3.html: Removed.
- fast/forms/add-remove-option-modification-event-expected.txt:
2010-01-14 Eric Seidel <eric@webkit.org>
No review, rolling out r53248.
http://trac.webkit.org/changeset/53248
https://bugs.webkit.org/show_bug.cgi?id=32641
Caused 2 tests to crash on various bots:
fast/dom/HTMLSelectElement/listbox-select-reset.html and
fast/forms/listbox-typeahead-scroll.html
- dom/SelectElement.cpp: (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
- dom/SelectElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle):
- html/HTMLSelectElement.h:
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
- 2:19 AM Changeset in webkit [53251] by
-
- 7 edits in trunk/WebKitTools
2010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Shinichiro Hamaji.
Moved error() from cpp_style.py to checker.py.
- Scripts/check-webkit-style:
- Addressed FIXME to not set global state.
- Scripts/webkitpy/style/checker.py:
- Added argument validation to ProcessorOptions constructor.
- Added should_report_error() to ProcessorOptions class.
- Removed set_options().
- Added StyleChecker class.
- Scripts/webkitpy/style/checker_unittest.py:
- Added unit test class for ProcessorOptions class.
- Added unit test to check that parse() strips white space.
- Scripts/webkitpy/style/cpp_style.py:
- Removed "filter" and "output_format" methods.
- Removed should_print_error() and error() functions.
- Removed default parameter value from process_file().
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Removed call to cpp_style._should_print_error().
- Removed test_filter() and test_filter_appending().
- Scripts/webkitpy/style/text_style.py:
- Removed default parameter value from process_file().
- 2:03 AM Changeset in webkit [53250] by
-
- 3 edits3 adds in trunk
2010-01-14 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
[Android] [Qt] The document.createEvent API does not support touch events.
https://bugs.webkit.org/show_bug.cgi?id=33605
- fast/events/script-tests/create-touch-event.js: Added. Ensures that document.createEvent("TouchEvent") can create a TouchEvent.
- fast/events/touch/create-touch-event-expected.txt: Added.
- fast/events/touch/create-touch-event.html: Added.
2010-01-14 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
[Android] [Qt] The document.createEvent API does not support touch events.
https://bugs.webkit.org/show_bug.cgi?id=33605
Test: fast/events/touch/create-touch-event.html
- dom/Document.cpp: (WebCore::Document::createEvent): add creation of a TouchEvent when the "TouchEvent" argument is supplied.
- 1:47 AM Changeset in webkit [53249] by
-
- 6 edits in trunk
2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617
- platform/qt/Skipped:
2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 1:31 AM Changeset in webkit [53248] by
-
- 11 edits4 adds in trunk
2010-01-14 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
Adds tests for the 'selected' attribute of <option>s
https://bugs.webkit.org/show_bug.cgi?id=32641
HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.
Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.
- fast/forms/HTMLOptionElement_selected-expected.txt:
- fast/forms/HTMLOptionElement_selected.html:
- fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
- fast/forms/HTMLOptionElement_selected2.html: Added.
- fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
- fast/forms/HTMLOptionElement_selected3.html: Added.
- fast/forms/add-remove-option-modification-event-expected.txt:
2010-01-14 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
Ensures that the 'selected' attribute of an <option> is correct
https://bugs.webkit.org/show_bug.cgi?id=32641
Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.
Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.
Tests: fast/forms/HTMLOptionElement_selected2.html
fast/forms/HTMLOptionElement_selected3.html
- dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
- dom/SelectElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
- html/HTMLSelectElement.h:
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
- 1:01 AM Changeset in webkit [53247] by
-
- 1 edit9 adds in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] Add expected files for passing new tests.
Compared to the mac expected files and png files.
- platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
- platform/qt/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
- platform/qt/svg/custom/marker-opacity-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-content-expected.txt: Added.
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
- platform/qt/transforms/2d/transform-fixed-container-expected.txt: Added.
- 12:41 AM Changeset in webkit [53246] by
-
- 2 edits in trunk/WebCore
[Qt] Allow custom memory allocation control for TransparencyLayer class
https://bugs.webkit.org/show_bug.cgi?id=33585
Reviewed by Oliver Hunt.
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
class TransparencyLayer - platform/graphics/qt/GraphicsContextQt.cpp:906
- platform/graphics/qt/GraphicsContextQt.cpp:
- 12:34 AM Changeset in webkit [53245] by
-
- 2 edits in trunk/WebCore
2010-01-14 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Oliver Hunt.
[Qt] Allow custom memory allocation control for FontPlatformDataPrivate class
https://bugs.webkit.org/show_bug.cgi?id=
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class FontPlatformDataPrivate - platform/graphics/qt/FontPlatformData.h:70
- platform/graphics/qt/FontPlatformData.h:
- 12:33 AM Changeset in webkit [53244] by
-
- 3 edits in trunk/WebCore
Reviewed by Xan Lopez.
[GTK] un-needed seeks
https://bugs.webkit.org/show_bug.cgi?id=33532
Avoid un-needed seeks. Don't seek at current playback position and
don't update the rate if it is already set to target value.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setRate):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 12:21 AM Changeset in webkit [53243] by
-
- 2 edits in trunk/WebCore
2010-01-14 Eric Seidel <eric@webkit.org>
No review. Tiger build fix after http://trac.webkit.org/changeset/53238.
Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169
Fix a build break when ENABLE(3D_CANVAS) is disabled.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): UNUSED_PARAM(attrs) when 3D_CANVAS is disabled.
Jan 13, 2010:
- 11:42 PM Changeset in webkit [53242] by
-
- 3 edits in trunk/WebCore
2010-01-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: use hidden text area for clipboard in order to
workaround windows setData bug.
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._copy):
- inspector/front-end/inspector.css:
- 11:35 PM Changeset in webkit [53241] by
-
- 2 edits in trunk/WebCore
2010-01-13 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Slow named property lookup on DOMWindow because of missing fast case
https://bugs.webkit.org/show_bug.cgi?id=33584
Add fast case checks to V8 named property getter on DOMWindow
objects. If the property is not in the DOM there is no reason to
search the DOM for all occurrences.
Covered by layout tests.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::namedPropertyGetter):
- 10:45 PM Changeset in webkit [53240] by
-
- 6 edits in trunk/WebCore
<rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression
Reviewed by Oliver Hunt.
Adding isolated worlds support to the JSC bindings introduced a regression due to
additional map lookups. Add a mechanism to quickly detect that a lookup is for the
'normal' world, and add fast paths to a couple of methods to check the normal world
first.
- bindings/js/JSDOMBinding.cpp:
(WebCore::Document::getWrapperCache):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::forgetDOMObject):
- bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
- bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::IsolatedWorld):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createWrapperCache):
- dom/Document.h:
- 10:37 PM Changeset in webkit [53239] by
-
- 7 edits in trunk
2010-01-13 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Oliver Hunt.
JSON.stringify and JSON.parse needlessly process properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33053
- runtime/JSONObject.cpp: (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::walk):
2010-01-13 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Oliver Hunt.
JSON.stringify and JSON.parse needlessly process properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33053
Add tests that verify that properties in the prototype chain are ignored.
- fast/js/JSON-parse-expected.txt:
- fast/js/JSON-stringify-expected.txt:
- fast/js/resources/JSON-parse.js:
- fast/js/resources/JSON-stringify.js:
- 9:50 PM Changeset in webkit [53238] by
-
- 25 edits1 copy6 adds in trunk
2010-01-13 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169
Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.
- fast/canvas/webgl/context-attributes-expected.txt: Added.
- fast/canvas/webgl/context-attributes.html: Added.
- fast/canvas/webgl/resources/webgl-test.js: (create3DContext):
2010-01-13 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169
Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.
Test: fast/canvas/webgl/context-attributes.html
- DerivedSources.make:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLParser.pm:
- bindings/v8/DOMData.cpp:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
- html/HTMLCanvasElement.h:
- html/HTMLCanvasElement.idl:
- html/canvas/CanvasContextAttributes.cpp: Added. (WebCore::CanvasContextAttributes::CanvasContextAttributes): (WebCore::CanvasContextAttributes::~CanvasContextAttributes):
- html/canvas/CanvasContextAttributes.h: Added.
- html/canvas/WebGLContextAttributes.cpp: Added. (WebCore::WebGLContextAttributes::create): (WebCore::WebGLContextAttributes::WebGLContextAttributes): (WebCore::WebGLContextAttributes::~WebGLContextAttributes): (WebCore::WebGLContextAttributes::alpha): (WebCore::WebGLContextAttributes::setAlpha): (WebCore::WebGLContextAttributes::depth): (WebCore::WebGLContextAttributes::setDepth): (WebCore::WebGLContextAttributes::stencil): (WebCore::WebGLContextAttributes::setStencil): (WebCore::WebGLContextAttributes::antialias): (WebCore::WebGLContextAttributes::setAntialias): (WebCore::WebGLContextAttributes::premultipliedAlpha): (WebCore::WebGLContextAttributes::setPremultipliedAlpha): (WebCore::WebGLContextAttributes::attributes):
- html/canvas/WebGLContextAttributes.h: Added.
- html/canvas/WebGLContextAttributes.idl: Added.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::getContextAttributes):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):
2010-01-13 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169
Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):
- 9:00 PM Changeset in webkit [53237] by
-
- 2 edits in trunk/WebCore
2010-01-13 Simon Fraser <Simon Fraser>
Fix Windows build.
- platform/graphics/cg/GraphicsContextCG.cpp:
- 8:54 PM Changeset in webkit [53236] by
-
- 3 edits in trunk/WebCore
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Transition followed by animation fails to run the animation sometimes
https://bugs.webkit.org/show_bug.cgi?id=33563
If a transition was closely followed by an animation, it was possible for the cleanup
after the end of the transition to kill the animation.
Fix this by including the keyframes name (or empty string for transitions) in the labels
used to identify CAAnimations on layers.
No test because this was a subtle timing issue that is hard to reproduce in a layout test.
- platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signature changes.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): Pass the keyframes name, since this is included in the identifier string now. (WebCore::moveAllAnimationsForProperty): Pass the keyframes name. (WebCore::GraphicsLayerCA::moveAnimationsForProperty): Try to move both transition- and animation-related CAAnimations, using the list of running animations to get the keyframe names for the latter.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): moveAnimation renamed to moveAnimationsForProperty
and takes the keyframes name.
(WebCore::GraphicsLayerCA::updateLayerAnimations): Pass keyframes name down (or "" for transitions).
(WebCore::GraphicsLayerCA::setAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::removeAnimationFromLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::pauseAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Pass keyframes name down.
- 8:44 PM Changeset in webkit [53235] by
-
- 3 edits6 adds in trunk
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix shadow drawing to do the correct computations using the base coordinate space
https://bugs.webkit.org/show_bug.cgi?id=33629
Shadows draw using the CGContext base CTM, so we need to convert the shadow offet
and size from user CTM into into base CTM coordinates, via the matix obtained from wkGetUserToBaseCTM().
Test: compositing/shadows/shadow-drawing.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 8:32 PM Changeset in webkit [53234] by
-
- 2 edits in trunk/LayoutTests
2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update Qt slave result after last SVG commit.
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- 8:09 PM Changeset in webkit [53233] by
-
- 32 edits in trunk
2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
SVGClipPathElement shouldn't resolve style manually
https://bugs.webkit.org/show_bug.cgi?id=33647
Build renderers for SVGClipPathElement, so we can query the style from the renderer
instead of re-resolving style on every clip path resource invalidation.
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::createRenderer): (WebCore::SVGClipPathElement::canvasResource):
- svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
- 7:47 PM Changeset in webkit [53232] by
-
- 5 edits in trunk/WebCore
2010-01-13 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Web Inspector does not update the DOM tree when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=20162
- dom/Element.cpp: Moves callbacks to InspectorController directly into setAttribute and removeAttribute and removes the existing call sites. This makes it possible to see attribute modifications. (WebCore::Element::setAttribute): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::removeAttribute):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._setAttributesPayload): Clear existing attributes. (WebInspector.DOMAgent.prototype._didApplyDomChange): Updated call site and fixed style. (WebInspector.DOMAgent.prototype._attributesUpdated): Added.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._attributesUpdated): Added. (WebInspector.ElementsPanel.prototype.updateModifiedNodes): Updated call site.
- inspector/front-end/ElementsTreeOutline.js: Renamed _updateTitle to updateTitle. (WebInspector.ElementsTreeElement.prototype.onattach): Updated updateTitle call site. (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto. (WebInspector.ElementsTreeElement.prototype._editingCancelled): Ditto.
- 7:31 PM Changeset in webkit [53231] by
-
- 2 edits18 deletes in trunk/LayoutTests
2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Remove six old tiger specific results, that are equal to the SL baseline now. Update one result, showing a marginal difference between Tiger/SL.
This is a follow-up commit for Dirks strokeBoundingBox() fixes -> should turn Tiger slave green again.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Removed.
- platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
- platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
- platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.png: Removed.
- platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.txt: Removed.
- platform/mac-tiger/svg/text/text-path-01-b-expected.checksum: Removed.
- platform/mac-tiger/svg/text/text-path-01-b-expected.png: Removed.
- platform/mac-tiger/svg/text/text-path-01-b-expected.txt: Removed.
- 7:30 PM Changeset in webkit [53230] by
-
- 2 edits in trunk/WebCore
2010-01-13 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
https://bugs.webkit.org/show_bug.cgi?id=33625
No new tests because the fix should affect strictly performance.
- rendering/CounterNode.cpp: (WebCore::CounterNode::nextInPreOrderAfterChildren):
- 7:05 PM Changeset in webkit [53229] by
-
- 14 edits4 adds in trunk
2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
Window size changes are not propagated down the render tree
https://bugs.webkit.org/show_bug.cgi?id=33643
Test: svg/custom/relative-sized-content.xhtml
- rendering/RenderSVGContainer.cpp: Fix incorrect markParents=true usage, leading to unnecessary relayouts. (WebCore::RenderSVGContainer::layout): Use new layoutChildren() method. (WebCore::RenderSVGContainer::paint): Fix indention.
- rendering/RenderSVGHiddenContainer.cpp: Fix incorrect markParents=true usage. (WebCore::RenderSVGHiddenContainer::layout): Use new layoutChildren() helper.
- rendering/RenderSVGRoot.cpp: Refactor existing code to layout children in SVGRenderSupport::layoutChildren. (WebCore::RenderSVGRoot::layout): Make children relayouting depend on width/height changes, if the outermost svg uses relative viewport sizes.
- rendering/SVGRenderSupport.cpp: Add central place handling child layout, skips relayouting non-relative sized children as benefit. (WebCore::SVGRenderBase::layoutChildren): This methods contains the actual changes.
- rendering/SVGRenderSupport.h:
- svg/SVGGElement.h: Remove dead code.
- svg/SVGSVGElement.h: Make hasRelativeValues() public to remove the need for friendship declarations.
- svg/SVGStyledElement.h: Change default return value for hasRelativeValues() to false, as it was intended. (WebCore::SVGStyledElement::hasRelativeValues): Make it public, to be usable from SVGRenderSupport.
- svg/SVGSymbolElement.h: Remove dead code.
- svg/SVGUseElement.cpp: Implement hasRelativeValues() - it was simply missing here. (WebCore::SVGUseElement::hasRelativeValues):
- svg/SVGUseElement.h:
- 6:57 PM Changeset in webkit [53228] by
-
- 3 edits in trunk/WebKitTools
2010-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix CloseBugForLandDiff unittest to actually run
https://bugs.webkit.org/show_bug.cgi?id=33640
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
- 6:46 PM Changeset in webkit [53227] by
-
- 2 edits in trunk/LayoutTests
2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Enable websocket/tests/workers/worker-simple.html again.
- platform/mac/Skipped: rm websocket/tests/workers/worker-simple.html
- 6:23 PM Changeset in webkit [53226] by
-
- 2 edits in trunk/WebCore
2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Fix websocket/tests/worker/worker-simple.html crash on Leopard Intel Debug (Tests) builder
https://bugs.webkit.org/show_bug.cgi?id=33581
unref m_workerContext when websocket is disconnected, so that avoid
keeping reference to workerContext longer than worker thread runs.
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
- 5:56 PM Changeset in webkit [53225] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (buildfix).
- 5:36 PM Changeset in webkit [53224] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33641
Assertion failure in Lexer.cpp if input stream ends while in string escape
Test: fast/js/end-in-string-escape.html
- parser/Lexer.cpp: (JSC::Lexer::lex): Bail out quickly on end of stream, not giving the assertion a chance to fire.
- 5:29 PM Changeset in webkit [53223] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (buildfix).
- 5:28 PM Changeset in webkit [53222] by
-
- 6 edits in trunk
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7532544>
Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.
- 5:20 PM Changeset in webkit [53221] by
-
- 4 edits in trunk/JavaScriptCore
Rubber stamped by Sam Weinig & Darin Adler.
Three quick fixes to UStringImpl.
- The destroy() method can be switched back to a normal destructor; since we've switched the way we protect static strings to be using an odd ref-count the destroy() won't abort.
- The cost() calculation logic was wrong. If you have multiple JSStrings wrapping substrings of a base string, they would each report the full cost of the base string to the heap. Instead we should only be reporting once for the base string.
- Remove the overloaded new operator calling fastMalloc, replace this with a 'using' to pick up the implementation from the parent class.
- JavaScriptCore.exp:
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
- 5:16 PM Changeset in webkit [53220] by
-
- 17 edits2 adds in trunk
MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported
https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>
Reviewed by Darin Adler.
WebCore:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMultiSelectable):
Use the correct function name - the function name overriden by
and used in AccessiblityRenderObject.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
Update for function rename.
(webkit_accessible_selection_select_all_selection):
Ditto.
WebKit/chromium:
- public/WebAccessibilityObject.h:
Update for WebCore::AccessibilityObject function rename.
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isMultiSelectable):
Ditto.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::get_accState):
Remove the call to isMultiSelect(). Call the correctly-named
isMultiSelectable(), and if it returns true, set both the "extended
selectable" and "multiple selectable" states. Check whether the object
is selected or selectable, and report those states.
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getIsSelectableCallback):
Return the result of calling isSelectable().
(getIsMultiSelectableCallback):
Return the result of calling isMultiSelectable().
(AccessibilityUIElement::getJSClass):
Add isSelected and isMultiSelectable properties to the JSClass
definition.
- DumpRenderTree/AccessibilityUIElement.h:
Declare isSelectable() and isMultiSelectable().
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(accessibilityState):
Get the object's state, and return it.
(AccessibilityUIElement::isSelected):
Check the object's selected state.
(AccessibilityUIElement::isSelectable):
Check the object's selectable state.
(AccessibilityUIElement::isMultiSelectable):
Check the object's extended/multiple selectable state.
LayoutTests:
- accessibility/selection-states-expected.txt: Added.
- accessibility/selection-states.html: Added.
- platform/gtk/Skipped:
Add new test to skipped list due to stubbed AccessibilityUIElement
functions.
- platform/mac/Skipped:
Ditto.
- 5:14 PM Changeset in webkit [53219] by
-
- 4 edits in trunk/WebKitLibraries
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7532544>
Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix. Once more, with feeling. On Windows.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 5:01 PM Changeset in webkit [53218] by
-
- 9 edits in trunk
Move more of the selection and caret painting code from Frame to SelectionController.
https://bugs.webkit.org/show_bug.cgi?id=33619
Reviewed by Dan Bernstein.
WebCore:
Helpful preparation step for a bug fix I am working on.
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController): Initialize new data members.
Note that m_caretVisible starts as true for the drag caret controller to match the
old behavior for painting.
(WebCore::SelectionController::setSelection): Changed to call selectionLayoutChanged
in its new name and location.
(WebCore::SelectionController::paintCaret): Added checks that were formerly done
at the Frame level. Tweaked formatting and changed to use early return as well.
(WebCore::SelectionController::focusedOrActiveStateChanged): Updated for call
moved into this class.
(WebCore::SelectionController::updateAppearance): Moved the
Frame::selectionLayoutChanged function here. Had to rename it because the word
"layout" is usedfor other purposes in this function.
(WebCore::SelectionController::setCaretVisible): Moved here from Frame.
(WebCore::SelectionController::clearCaretRectIfNeeded): Ditto.
(WebCore::SelectionController::caretBlinkTimerFired): Ditto.
- editing/SelectionController.h: Added new functions. Moved conditional function
out of class definition for clarity. Removed unneeded == and != operators.
Removed unneeded use of bit fields.
- page/Frame.cpp: Moved functions to SelectionController.
(WebCore::Frame::Frame): Removed initialization of moved data members.
- page/Frame.h: Removed things moved to SelectionController as well as unneeded
forward declaration of Timer class template.
- page/FrameView.cpp:
(WebCore::FrameView::layout): Updated for new location of function.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret): Ditto.
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent): Seems possibly wrong to be directly invoking this
setCaretVisible here, but I updated it to call it in its new location.
- 4:55 PM Changeset in webkit [53217] by
-
- 3 edits1 copy in trunk/WebKitTools
2010-01-13 Adam Barth <abarth@webkit.org>
Unreviewed. Repeat the below for CloseBugForLandDiff.
- Scripts/test-webkitpy:
- Scripts/webkitpy/steps/closebugforlanddiff.py:
- Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
- 4:49 PM Changeset in webkit [53216] by
-
- 2 edits in trunk/WebKitTools
2010-01-13 Adam Barth <abarth@webkit.org>
Unreviewed. Turn the mac-ews status bubbles back on now that this bot
is running again.
- QueueStatusServer/templates/statusbubble.html:
- 4:49 PM Changeset in webkit [53215] by
-
- 3 edits in trunk/WebKitTools
2010-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
https://bugs.webkit.org/show_bug.cgi?id=33634
Deal with the case of no bug patch object in the state.
- Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
- Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
- 4:20 PM Changeset in webkit [53214] by
-
- 2 edits in trunk/LayoutTests
Cleaning up quota-tracking.html. Removing trailing whitespaces and
fixing the errorFunction() to work correctly with both
transaction() and executeSql().
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33628
- storage/quota-tracking.html:
- 4:13 PM Changeset in webkit [53213] by
-
- 3 edits in trunk/WebKitLibraries
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7532544>
Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 4:08 PM Changeset in webkit [53212] by
-
- 2 edits in trunk/WebKitTools
2010-01-13 Kenneth Russell <kbr@google.com>
Unreviewed; added myself to the committers list.
- Scripts/webkitpy/committers.py:
- 4:07 PM Changeset in webkit [53211] by
-
- 2 edits in trunk/WebCore
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix shadow drawing to do the correct computations using the base coordinate space
https://bugs.webkit.org/show_bug.cgi?id=33629
Step 1: do some renames in setPlatformShadow():
size -> offset
width -> xOffset
height -> yOffset
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 4:05 PM CommitterTips edited by
- (diff)
- 3:51 PM CommitterTips edited by
- (diff)
- 3:49 PM CommitterTips edited by
- Update bugzilla-tool to webkit-patch (diff)
- 3:38 PM Changeset in webkit [53210] by
-
- 8 edits in trunk
2010-01-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492
- public/WebKitClient.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
2010-01-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492
- page/Page.cpp: (WebCore::Page::sessionStorage):
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
- 3:33 PM Changeset in webkit [53209] by
-
- 5 edits in trunk/WebKitLibraries
2010-01-13 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7532544>
Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:31 PM Changeset in webkit [53208] by
-
- 4 edits in trunk/WebKitTools
Ignore compiled Python in more of webkitpy.
- Scripts/webkitpy/commands: Added property svn:ignore.
- Scripts/webkitpy/steps: Added property svn:ignore.
- Scripts/webkitpy/style: Added property svn:ignore.
- 2:42 PM Changeset in webkit [53207] by
-
- 29 edits4 adds in trunk
2010-01-13 Dirk Schulze <krit@webkit.org>
Reviewed by Beth Dakin.
Repaint bug dragging a star shape with a dash stroke
https://bugs.webkit.org/show_bug.cgi?id=33406
Calculation of repaint rects for RenderPath objects was wrong. We must take the
union of strokeBoundingBox and objectBoundingBox, since the strokeBoundingBox
must not contain the objectBoundingBox. This is mainly visible on dash-arrays for
strokes.
Test: svg/custom/js-repaint-rect-on-path-with-stroke.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox):
2010-01-13 Dirk Schulze <krit@webkit.org>
Reviewed by Beth Dakin.
Repaint bug dragging a star shape with a dash stroke
https://bugs.webkit.org/show_bug.cgi?id=33406
Calculation of repaint rects for RenderPath objects was fixed. We take the
union of strokeBoundingBox and objectBoundingBox. Since DRT results depend
on the repaint rect, many results needed an update.
Added a new test, that makes the wrong calculation visible.
- js-repaint-rect-on-path-with-stroke.svg
- platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt
- platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt
- platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/mac/svg/batik/text/textOnPath-expected.txt:
- platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/mac/svg/batik/text/verticalText-expected.txt:
- platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/custom/animate-path-morphing-expected.txt:
- platform/mac/svg/custom/control-points-for-S-and-T-expected.txt:
- platform/mac/svg/custom/dasharrayOrigin-expected.txt:
- platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Added.
- platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
- platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
- platform/mac/svg/custom/path-textPath-simulation-expected.txt:
- platform/mac/svg/text/text-path-01-b-expected.txt:
- svg/custom/js-repaint-rect-on-path-with-stroke.svg: Added.
- 2:28 PM Changeset in webkit [53206] by
-
- 3 edits in trunk/WebCore
[wx] Build fix. Make the XFORM operator work on wx port.
- 2:12 PM Changeset in webkit [53205] by
-
- 8 edits1 add in trunk/WebCore
2010-01-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line
rendering capabilities.
Contains a drive-by naming fix (lineNumberOffset and lineNumberToOffset were
too close to each other, but were unrelated).
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/SourceFrame2.js: Added. (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.set text): (WebInspector.SourceFrame2.prototype.get executionLine): (WebInspector.SourceFrame2.prototype.set executionLine): (WebInspector.SourceFrame2.prototype.revealLine): (WebInspector.SourceFrame2.prototype._toggleBreakpoint): (WebInspector.SourceFrame2.prototype.resize): (WebInspector.BreakpointLineNumberDecorator): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.ExecutionLineDecorator): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.get textModel): (WebInspector.TextEditor.prototype.set readOnly): (WebInspector.TextEditor.prototype.set lineNumberDecorator): (WebInspector.TextEditor.prototype.set lineDecorator): (WebInspector.TextEditor.prototype.selectionRange): (WebInspector.TextEditor.prototype._offsetToLine): (WebInspector.TextEditor.prototype._lineToOffset): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype.updateCanvasSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paintLines): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype.paintLineNumbers): (WebInspector.TextEditor.prototype._paintCurrentLine): (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._keyDown): (WebInspector.TextEditor.prototype._handleNavigationKey): (WebInspector.TextEditor.prototype._textInput): (WebInspector.TextEditor.prototype._updateCursor): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._initFont):
- 2:10 PM Changeset in webkit [53204] by
-
- 6 edits in trunk/WebCore
2010-01-13 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate a function in the V8 bindings to convert v8 objects
to native WebCore objects.
- bindings/scripts/CodeGeneratorV8.pm: Generate and use toNative().
- bindings/v8/V8Binding.cpp: Remove manually defined conversion helprs. (WebCore::getElementStringAttr): (WebCore::setElementStringAttr):
- bindings/v8/V8Binding.h: Remove manually defined conversion helprs.
- bindings/v8/V8SVGPODTypeWrapper.h: Still need a manually defined coversion helper for SVGPODTypes. (WebCore::V8SVGPODTypeWrapper::toNative):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::V8WebGLRenderingContext::getUniformCallback):
- 1:59 PM Changeset in webkit [53203] by
-
- 5 edits in trunk
WebCore: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.
Reviewed by Adam Roben.
If no effectAllowed is set in the dragStart operation, we should default to
uninitialized instead of none, so the user doesn't have to manually set the
effectAllowed to enable drag and drop.
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
LayoutTests: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.
Reviewed by Adam Roben.
Updated the drag and drop test to test if effectAllowed isn't set, in addition
to its other tests.
- fast/events/drag-and-drop-expected.txt:
- fast/events/drag-and-drop.html:
- 1:35 PM Changeset in webkit [53202] by
-
- 8 edits3 adds in trunk/WebKit/win
Add additional Geolocation interfaces in WebKit for Windows.
Reviewed by Adam Roben.
- Interfaces/IWebGeolocationPolicyListener.idl: Added.
- Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
Append since this version hasn't shipped.
- Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
- WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
- WebGeolocationPolicyListener.cpp: Added.
- WebGeolocationPolicyListener.h: Added.
- WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
- WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
- WebView.cpp:
(WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.
- 1:27 PM Changeset in webkit [53201] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-01-13 Dirk Schulze <krit@webkit.org>
Reviewed by Beth Dakin.
This tests don't pass on Leopard but on Snow Leopard with tolereance of 0.
Created Leopard specific pixel test results since they do not fail.
- platform/mac-leopard/svg/css: Added.
- platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum: Added.
- platform/mac-leopard/svg/css/composite-shadow-example-expected.png: Added.
- platform/mac-leopard/svg/css/group-with-shadow-expected.checksum: Added.
- platform/mac-leopard/svg/css/group-with-shadow-expected.png: Added.
- 1:23 PM Changeset in webkit [53200] by
-
- 2 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=32495
Reviewed by Dan Bernstein.
font-size:small with background-color causes text to get clipped. Make sure to only paint within the lineTop/lineBottom of
a line for quirky inline flow boxes that didn't contribute to the overall height of the line.
Added fast/backgrounds/quirks-mode-line-boxes-backgrounds.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
- 1:11 PM Changeset in webkit [53199] by
-
- 3 edits in trunk/LayoutTests
2010-01-13 Dirk Schulze <krit@webkit.org>
Reviewed by Beth Dakin.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
This is a follow up. The order of filter and clipping was changes in bug 14010
according to the Spec. Forgot to update this test.
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
- 1:09 PM Changeset in webkit [53198] by
-
- 3 edits in trunk/WebCore
Refactoring DatabaseAuthorizer to use a CaseFoldingHash function
for the set of whitelisted sqlite functions, and fixing some
indenting issues.
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33612
- storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::allowFunction):
- storage/DatabaseAuthorizer.h:
- 12:56 PM Changeset in webkit [53197] by
-
- 3 edits in trunk/LayoutTests
2010-01-13 Dirk Schulze <krit@webkit.org>
Reviewed by Beth Dakin.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This is a followup. The way how masks are created changed and caused
some results to update. Forgot to update this one.
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- 12:46 PM SVG TODO List - Short notes edited by
- (diff)
- 12:40 PM Changeset in webkit [53196] by
-
- 2 edits in trunk/WebCore
2010-01-13 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
RenderObject::nextInPreOrderAfterChildren(RenderObject* stayWithin) does not stay within
https://bugs.webkit.org/show_bug.cgi?id=33600
No new tests as this fix affects mainly performance.
No test has been found yet that could evidence the bug in the layout
of a page, but the fix to bug 32884 exposes this bug on some pages
such as http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/counters-scope-implied-001.htm
- rendering/RenderObject.cpp: (WebCore::RenderObject::nextInPreOrderAfterChildren):
- 12:34 PM Changeset in webkit [53195] by
-
- 4 edits in trunk/WebKit
https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _workaroundSilverlightFullScreenBug:]): Added. Work around Silverlight full screen performance issue by maintaining an accelerated GL pixel format. We can safely remove this at some point in the future when both Microsoft releases a genuine fix for 7288546 and enough Silverlight users update to the new Silverlight. For now, we'll distinguish older broken versions of Silverlight by asking the plug-in if it resolved its full screen badness. (-[WebNetscapePluginView _createPlugin]): Call _workaroundSilverlightFullScreenBug:YES if this is Silverlight. (-[WebNetscapePluginView _destroyPlugin]): Call _workaroundSilverlightFullScreenBug:NO if this is Silverlight.
https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.
- WebKit.xcodeproj/project.pbxproj: Link the project against OpenGL.
- 11:18 AM Changeset in webkit [53194] by
-
- 8 edits in trunk
WebCore: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
- page/Page.cpp:
(WebCore::Page::sessionStorage):
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h:
(WebCore::StorageNamespace::~StorageNamespace):
WebKit/chromium: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
- public/WebKitClient.h:
- public/WebViewClient.h:
- src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
- 10:30 AM Changeset in webkit [53193] by
-
- 2 edits in trunk/WebCore
2010-01-13 Steve Block <steveblock@google.com>
Update appendClassName in jni_runtime.cpp to use WebCore::StringBuilder, rather than JSC::StringBuilder.
https://bugs.webkit.org/show_bug.cgi?id=33586
Avoiding the JSC version of StringBuilder allows this file to be used with both JSC and V8 on Android.
No new tests, refactoring only.
- bridge/jni/jni_runtime.cpp: Modified. (JavaMethod::signature): Modified. Use WebCore::StringBuilder.
- 10:14 AM Changeset in webkit [53192] by
-
- 2 edits in trunk/WebCore
2010-01-13 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Timothy Hatcher.
Some objects in the global scope are not completed
https://bugs.webkit.org/show_bug.cgi?id=19119
Use Object.getOwnPropertyNames instead of for-in to provide completions, since
Object.getOwnPropertyNames reports both enumerable and non-enumerable properties.
- inspector/front-end/InjectedScript.js: (InjectedScript._getPropertyNames): (InjectedScript.getCompletions):
- 9:03 AM Changeset in webkit [53191] by
-
- 2 edits in trunk/WebCore
2010-01-13 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
[Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
https://bugs.webkit.org/show_bug.cgi?id=33597
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent): Add the touch event types (touchstart, touchmove and touchend) to the set of events that are considered user gestures.
- 8:49 AM Changeset in webkit [53190] by
-
- 2 edits in trunk/WebKitTools
[Qt] Fix build problem related to the pushd command
Reviewed by Simon Hausmann.
- Scripts/webkitdirs.pm:
- 8:46 AM Changeset in webkit [53189] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Tor Arne Vestbø.
[Qt] REGRESSION(53187) Touchevent related tests fail
https://bugs.webkit.org/show_bug.cgi?id=33602
Pass the ENABLE_TOUCH_EVENTS to the IDL generators.
- WebCore.pri:
- 8:31 AM Changeset in webkit [53188] by
-
- 2 edits in trunk/WebCore
2010-01-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Timeline panel scrolling speed can be increased.
https://bugs.webkit.org/show_bug.cgi?id=33579
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 8:06 AM Changeset in webkit [53187] by
-
- 9 edits4 adds in trunk
[Qt] Split the build process in two different .pro files.
This allows qmake to be run once all source files are available.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.
.:
- DerivedSources.pro: Added.
- WebKit.pri:
- DerivedSources.pro: Added.
- JavaScriptCore.pri: Moved source generation to DerivedSources.pro
- pcre/pcre.pri: Moved source generation to DerivedSources.pro
WebCore:
- DerivedSources.pro: Added.
- WebCore.pri: Added. Contains common logic between source generation and compilation.
- WebCore.pro: Moved source generation to DerivedSources.pro.
WebKitTools:
- Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
- 7:55 AM Changeset in webkit [53186] by
-
- 2 edits in trunk/WebKitTools
2010-01-13 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed tiny typo fix in docstrings.
- Scripts/webkitpy/style/checker_unittest.py:
- 7:52 AM Changeset in webkit [53185] by
-
- 5 edits in trunk/WebKitTools
2010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Shinichiro Hamaji.
Created a CategoryFilter class to encapsulate the logic of
filter rules.
- Scripts/webkitpy/style/checker.py:
- Added CategoryFilter class.
- Scripts/webkitpy/style/checker_unittest.py:
- Added CategoryFilter unit tests.
- Scripts/webkitpy/style/cpp_style.py:
- Updated filter methods to use CategoryFilter.
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Updated references to filters.
- 7:24 AM Changeset in webkit [53184] by
-
- 4 edits in trunk/WebCore
2010-01-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Scrolling editor to the 20Kth line is not smooth.
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype._paintLinesContinuation):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype._setLine): (WebInspector.TextEditorModel.prototype.setAttribute): (WebInspector.TextEditorModel.prototype.getAttribute): (WebInspector.TextEditorModel.prototype.removeAttribute):
- 5:49 AM Changeset in webkit [53183] by
-
- 3 edits in trunk/WebCore
[Qt] Fix the build on Windows.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.
PluginViewWin.cpp requires the conversion operator from TransformationMatrix to XFORM.
- WebCore.pro: Build TransformationMatrixWin.cpp.
- platform/graphics/transforms/TransformationMatrix.h: Enable the conversion operator to XFORM.
- 2:31 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:27 AM QtWebKitTableOfFeatures46 created by
- 2:12 AM QtWebKitFeatures46 edited by
- (diff)
- 1:23 AM Changeset in webkit [53182] by
-
- 2 edits in trunk/LayoutTests
2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Add websocket/tests/workers/worker-simple.html, because it starts
crash after r53174
- platform/mac/Skipped: Add websocket/tests/workers/worker-simple.html
- 1:18 AM Changeset in webkit [53181] by
-
- 2 edits in trunk/WebCore
[Qt/Symbian] Added missing vendor information to qtwebkit.sis
Patch by Miikka Heikkinen <miikka.heikkinen@digia.com> on 2010-01-13
Reviewed by Simon Hausmann.
This information is necessary to Symbian sign the package.
http://bugreports.qt.nokia.com/browse/QTBUG-7290
- WebCore.pro:
Jan 12, 2010:
- 10:51 PM Changeset in webkit [53180] by
-
- 8 edits in trunk
2010-01-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492
- public/WebKitClient.h:
- public/WebViewClient.h: (WebKit::WebViewClient::getSessionStorageNamespace):
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
2010-01-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492
- page/Page.cpp: (WebCore::Page::sessionStorage):
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
- 10:12 PM Changeset in webkit [53179] by
-
- 2 edits in trunk/WebKitTools
2010-01-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Now I can review :)
- Scripts/webkitpy/committers.py:
- 9:23 PM WebKit Team edited by
- (diff)
- 7:33 PM Changeset in webkit [53178] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10.1 beta
Reviewed by Darin Adler.
Explicitly track when the plug-in shows and hides a full-screen window to determine
whether a plug-in is currently full-screen, rather than relying on menu bar visibility.
This ensures that we activate the plug-in host process and client application as
appropriate when the plug-in enters or exits full-screen.
- Plugins/Hosted/NetscapePluginHostProxy.h:
(WebKit::NetscapePluginHostProxy::isFullScreenWindowShowing):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::setMenuBarVisible):
(WebKit::NetscapePluginHostProxy::didEnterFullScreen):
(WebKit::NetscapePluginHostProxy::didExitFullScreen):
(WebKit::NetscapePluginHostProxy::setFullScreenWindowIsShowing):
(WKPCSetMenuBarVisible):
(WKPCSetFullScreenWindowIsShowing):
- Plugins/Hosted/WebKitPluginClient.defs:
- 7:29 PM Changeset in webkit [53177] by
-
- 4 edits in trunk/WebCore
Adding a list of whitelisted sqlite functions that users are
allowed to use.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=33549
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::authorizerFunction):
- storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):
- storage/DatabaseAuthorizer.h:
- 6:48 PM Changeset in webkit [53176] by
-
- 2 edits1 move in trunk/WebCore
2010-01-12 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Simon Hausmann.
[Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
https://bugs.webkit.org/show_bug.cgi?id=33077
- WebCore.pro:
- platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
- platform/network/qt/SocketStreamHandleSoup.cpp: Removed.
- 6:33 PM Changeset in webkit [53175] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Build Fix.
- 6:09 PM Changeset in webkit [53174] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-01-12 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Add a test of WebSockets for shared workers
https://bugs.webkit.org/show_bug.cgi?id=33285
- websocket/tests/workers/resources/worker-simple.js:
- websocket/tests/workers/shared-worker-simple-expected.txt: Added.
- websocket/tests/workers/shared-worker-simple.html: Added.
- 6:08 PM Changeset in webkit [53173] by
-
- 4 edits4 adds in trunk
2010-01-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
position:fixed and transform on same element breaks fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=31283
Fix interactions of transforms and fixed positioning, namely that fixed position
elements with a transformed ancestor are positioned relative to that ancestor,
and an element with both a transform and fixed position respects that positioning.
Test: transforms/2d/transform-fixed-container.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors, but only if the transformed element is not itself fixed.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords): Fix this method to behave correctly for fixed position layers whose container is not the root, but some other (probably transformed) ancestor. In that case, we can fall into the "position: absolute" code path.
- 6:04 PM Changeset in webkit [53172] by
-
- 2 edits in trunk/LayoutTests
Replacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
disallowed by the authorizer.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=33396
- storage/quota-tracking.html:
- 5:29 PM Changeset in webkit [53171] by
-
- 2 edits in trunk/WebCore
2010-01-12 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
Fix an assert being triggered by how the Chromium port sets the
replacing flag for error pages. This was caused by r53143.
Covered by existing Chromium UI tests.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- 4:58 PM Changeset in webkit [53170] by
-
- 48 edits3 adds in trunk
2010-01-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242
Add an extra argument to getPropertyNames() and getOwnPropertyNames()
(and all reimplementations thereof) that indicates whether non-enumerable
properties should be added.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyNames):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyNames):
- debugger/DebuggerActivation.h:
- runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertyNames):
- runtime/Arguments.h:
- runtime/CommonIdentifiers.h:
- runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertyNames):
- runtime/JSArray.h:
- runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertyNames):
- runtime/JSByteArray.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertyNames):
- runtime/JSFunction.h:
- runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::getOwnPropertyNames):
- runtime/JSNotAnObject.h:
- runtime/JSObject.cpp: (JSC::getClassPropertyNames): (JSC::JSObject::getPropertyNames): (JSC::JSObject::getOwnPropertyNames):
- runtime/JSObject.h:
- runtime/JSVariableObject.cpp: (JSC::JSVariableObject::getOwnPropertyNames):
- runtime/JSVariableObject.h:
- runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyNames):
- runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertyNames):
- runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertyNames):
- runtime/StringObject.h:
- runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument. (JSC::Structure::getPropertyNames):
- runtime/Structure.h: (JSC::):
2010-01-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242
Add new argument to the reimplementation of getOwnPropertyNames().
- UserObjectImp.cpp: (UserObjectImp::getOwnPropertyNames):
- UserObjectImp.h:
2010-01-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242
Add tests for Object.getOwnPropertyNames(o), both standard usage and cross origin.
- fast/js/Object-getOwnPropertyNames-expected.txt: Added.
- fast/js/Object-getOwnPropertyNames.html: Added.
- fast/js/script-tests/Object-getOwnPropertyNames.js: Added.
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- http/tests/security/cross-frame-access-enumeration.html:
2010-01-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242
Add new argument to reimplementations of getPropertyNames()
and getOwnPropertyNames(), and update the JS bindings generator.
Test: fast/js/Object-getOwnPropertyNames.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames): (WebCore::JSDOMWindow::getOwnPropertyNames):
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::getPropertyNames): (WebCore::JSDOMWindowShell::getOwnPropertyNames):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertyNames):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertyNames):
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::getPropertyNames): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
- bindings/js/JSQuarantinedObjectWrapper.h:
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getOwnPropertyNames):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
- bridge/runtime_array.h:
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getPropertyNames): (JSC::RuntimeObjectImp::getOwnPropertyNames):
- bridge/runtime_object.h:
- 4:16 PM Changeset in webkit [53169] by
-
- 1 edit4 adds in trunk/LayoutTests
Add correct expected results after r53168 for GTK and Qt.
- platform/gtk/fast/block: Added.
- platform/gtk/fast/block/positioning: Added.
- platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
- platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
- 3:39 PM Changeset in webkit [53168] by
-
- 6 edits2 adds in trunk
Safari shows an unneeded horizontal scrollbar on many websites.
Fixes <rdar://6321041> and <http://webkit.org/b/33555>.
Reviewed by Dave Hyatt.
WebCore:
If a div has no children, and its height or width are 0, we can ignore
it in our calculation of lowest, rightmost, and leftmost positions. This
calculation was causing horizontal scrollbars to be drawn when they weren't needed.
Test: fast/block/positioning/absolute-positioning-no-scrollbar.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
(WebCore::RenderBlock::rightmostPosition): Ditto.
(WebCore::RenderBlock::leftmostPosition): Ditto.
LayoutTests:
Added a test that shows no scrollbar in the case where a div has no children
and either a width or height of 0. Also updated results for a few tests which
this patch causes progressions for.
- fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
- fast/block/positioning/absolute-positioning-no-scrollbar.html: Added.
- fast/block/positioning/fixed-positioning-scrollbar-bug.html:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
- 3:34 PM Changeset in webkit [53167] by
-
- 2 edits in trunk/WebCore
2010-01-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Optimize WebInspector.TimelineGrid.prototype.updateDividers()
DOM element property access and modification are slow and should be done as lazily as possible.
https://bugs.webkit.org/show_bug.cgi?id=33536
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):
- 3:10 PM Changeset in webkit [53166] by
-
- 3 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
webkit-svg-shadow with opacity still over-clipped
Reviewed by Sam Weinig.
We need to call inflateForShadow() on the repaintRect before we
clip for opacity or we will over-clip.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION:
-webkit-svg-shadow with opacity still over-clipped
Reviewed by Sam Weinig.
- platform/mac/svg/css/shadow-and-opacity-expected.checksum: Added.
- platform/mac/svg/css/shadow-and-opacity-expected.png: Added.
- platform/mac/svg/css/shadow-and-opacity-expected.txt: Added.
- svg/css/shadow-and-opacity.svg: Added.
- 2:48 PM Changeset in webkit [53165] by
-
- 12 edits6 adds in trunk
WebCore: Update all-in-one derived sources for Geolocation.
Reviewed by Sam Weinig.
- DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp
WebKit/win: Add Geolocation interfaces in WebKit for Windows.
Reviewed by Adam Roben, Sam Weinig.
- ForEachCoClass.h: Added WebGeolocationPosition.
- Interfaces/IWebError.idl:
- Interfaces/IWebGeolocationPosition.idl: Added.
- Interfaces/IWebGeolocationProvider.idl: Added.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
- WebCoreSupport/WebGeolocationControllerClient.h: Added.
- WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
- WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
- WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
- WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
- WebKitClassFactory.cpp: Add WebGeolocationPosition include.
- WebView.cpp:
(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.
- WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
- 2:12 PM Changeset in webkit [53164] by
-
- 31 edits in trunk/WebCore
2010-01-12 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Remove static const ints from V8CustomBinding.h
- bindings/scripts/CodeGeneratorV8.pm: Generate and use custom
internal field indices from lists of custom internal fields.
- bindings/v8/NPV8Object.cpp:
- bindings/v8/NPV8Object.h:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary
manually calls to setInternalFieldCount().
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Index.h:
- bindings/v8/V8IsolatedContext.cpp:
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/custom/V8AbstractWorkerCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp:
- bindings/v8/custom/V8NodeCustom.cpp:
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
- bindings/v8/custom/V8WebSocketCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- 2:07 PM Changeset in webkit [53163] by
-
- 3 edits2 adds in trunk
MSAA: Accessibility role of <select multiple> elements is wrong
https://bugs.webkit.org/show_bug.cgi?id=33522
Reviewed by Darin Adler.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.
LayoutTests:
- platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
- platform/win/accessibility/multiple-select-element-role.html: Added.
- 1:59 PM Changeset in webkit [53162] by
-
- 2 edits in trunk/WebCore
2010-01-12 Darin Fisher <darin@chromium.org>
Fixing chromium build bustage.
- bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.
- 1:28 PM Changeset in webkit [53161] by
-
- 7 edits1 add in trunk/WebCore
2010-01-12 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Add V8 bindings for PopStateEvent.
https://bugs.webkit.org/show_bug.cgi?id=33546
This is covered by existing tests for PopStateEvent.
- WebCore.gypi:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8PopStateEventCustom.cpp: Added. (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
- 1:25 PM Changeset in webkit [53160] by
-
- 7 edits in trunk
2010-01-12 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Adds source length to ParseHTMLRecords in the inspector timeline.
https://bugs.webkit.org/show_bug.cgi?id=33548
Test: inspector/timeline-parse-html.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willWriteHTML):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createParseHTMLRecord):
- inspector/TimelineRecordFactory.h:
- 1:15 PM Changeset in webkit [53159] by
-
- 2 edits in trunk/WebCore
2010-01-12 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler
Make ICU's text breakiterator and string search use Chrome's UI
language instead of 'en-US' or the OS UI language.
As long as the webkit layout tests are run in en-US locale, there'd be
no visible change.
- platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (UILanguage): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
- 1:05 PM Changeset in webkit [53158] by
-
- 5 edits in trunk/LayoutTests
Updated results for these tests which just have rounding errors.
Reviewed by Nikolas Zimmermann.
- platform/mac/svg/css/composite-shadow-example-expected.checksum:
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/mask-with-shadow-expected.checksum:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- 12:54 PM Changeset in webkit [53157] by
-
- 29 edits in trunk
WebCore: Rubber-stamped by Dave Hyatt.
This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
LayoutTests: This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>
- fast/repaint/moving-shadow-on-container.html:
- fast/repaint/moving-shadow-on-path.html:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/arrow-with-shadow.svg:
- svg/css/circle-in-mask-with-shadow.svg:
- svg/css/clippath-with-shadow.svg:
- svg/css/composite-shadow-example.html:
- svg/css/composite-shadow-with-opacity.html:
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/group-with-shadow.svg:
- svg/css/mask-with-shadow.svg:
- svg/css/path-with-shadow.svg:
- svg/css/shadow-with-large-radius.svg:
- svg/css/shadow-with-negative-offset.svg:
- svg/css/stars-with-shadow.html:
- svg/filters/shadow-on-filter.svg:
- svg/filters/shadow-on-rect-with-filter.svg:
- 12:49 PM Changeset in webkit [53156] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
- WebCore.vcproj/WebCore.vcproj:
- 12:44 PM Changeset in webkit [53155] by
-
- 2 edits in trunk/WebCore
2010-01-12 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Add a null check in case of an event handler with invalid syntax.
Should make fast/js/invalid-syntax--for-function.html not crash in
Chromium's test shell.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.
- 12:34 PM QtWebKitBackportingFixes edited by
- (diff)
- 12:32 PM Changeset in webkit [53154] by
-
- 4 edits in trunk/WebKitTools
Extend WinLauncher example with better printing features.
Reviewed by Darin Adler.
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
larger margins.
(PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
on text metrics.
(PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
on text metrics.
(PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
with separating line.
(PrintWebUIDelegate::drawFooterInRect):
- WinLauncher/PrintWebUIDelegate.h: Remove stubs.
- WinLauncher/WinLauncher.cpp:
(PrintView): Correct loop used to print individual pages.
Previously it started at 0, which is a wild-card to print all
pages at once.
- 11:59 AM Changeset in webkit [53153] by
-
- 4 edits in trunk/LayoutTests
2010-01-12 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Add media/video-poster-scale.html to GTK skipped list, it needs platform specific
results (https://bugs.webkit.org/show_bug.cgi?id=33541). Fix test results on
OSX and Windows.
- media/video-poster-scale-expected.txt:
- media/video-poster-scale.html:
- platform/gtk/Skipped:
- 11:52 AM Changeset in webkit [53152] by
-
- 6 edits1 delete in trunk/WebCore
Remove XBM support from the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=27823
Reviewed by Dimitri Glazkov.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
- platform/image-decoders/xbm: Removed.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
- platform/image-decoders/xbm/XBMImageDecoder.h: Removed.
- 11:42 AM Changeset in webkit [53151] by
-
- 14 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33540
Make it possible to build in debug mode with assertions disabled
- 11:41 AM Changeset in webkit [53150] by
-
- 3 edits in trunk/LayoutTests
2010-01-12 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update test and results after r53146.
- http/tests/security/local-video-poster-from-remote-expected.txt:
- http/tests/security/local-video-poster-from-remote.html:
- 11:33 AM Changeset in webkit [53149] by
-
- 2 edits in trunk/LayoutTests
2010-01-12 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015
- platform/gtk/Skipped: Skipping the test again, we need to kill its last timer.
- 10:50 AM Changeset in webkit [53148] by
-
- 4 edits in trunk
2009-11-23 Yong Li <yoli@rim.com>
Reviewed by Adam Treat.
Make GIF decoder support down-sampling
https://bugs.webkit.org/show_bug.cgi?id=31806
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::upperBoundScaledY): (WebCore::ImageDecoder::lowerBoundScaledY):
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::scaledRect): (WebCore::RGBA32Buffer::setScaledRect): (WebCore::ImageDecoder::scaledSize):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::copyOnePixel): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
- 10:33 AM Changeset in webkit [53147] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Eric Carlson.
[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015
Listen on timeupdate event instead of waiting a fixed amount of
time, which is prone to test flackyness.
- media/audio-mpeg-supported.html:
- media/video-seek-past-end-playing.html:
- platform/gtk/Skipped:
- 10:23 AM Changeset in webkit [53146] by
-
- 20 edits2 adds in trunk
2010-01-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler and Simon Fraser.
rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback
https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster. (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo. (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we
should display the poster image. renderer() is never a RenderImage, don't need to check.
m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since
it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state,
display the poster as long as the attribute is valid and the media engine says it hasn't
rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame
is available to render.
- html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::poster): (WebCore::HTMLVideoElement::shouldDisplayPoster):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.
- manual-tests/video-player.html: Remove bit-rot from manual test so it works again.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame
is available to render.
- platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
- platform/graphics/MediaPlayerPrivate.h: Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare
all bool variables to aid packing.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup
floating point initializers to match coding guidelines.
(WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
(WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.
(WebCore::RenderImage::paintReplaced): Split part out into paint method.
(WebCore::RenderImage::paint): New.
- rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected
instead of private so RenderVideo can use them.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced (WebCore::RenderMedia::destroy): Ditto. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::lowestPosition): Ditto. (WebCore::RenderMedia::rightmostPosition): Ditto. (WebCore::RenderMedia::leftmostPosition): Ditto.
- rendering/RenderMedia.h: Declare isImage and isRenderImage.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged
when displaying a poster so it is sized correctly.
(WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
use it when we also know the movie's intrinsic size but still need to draw the poster.
(WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
use the movie's intrinsic size when drawing frames.
(WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
(WebCore::RenderVideo::videoElement): New.
(WebCore::RenderVideo::updatePlayer):
- rendering/RenderVideo.h: (WebCore::RenderVideo::minimumReplacedHeight): Added.
2010-01-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler and Simon Fraser.
rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback
https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame
- media/video-poster-expected.txt: Remove blank line at beginning of test result present as a side effect of the media element using RenderImage to display the poster.
- media/video-poster-scale.html: New.
- media/video-poster-scale-expected.txt: New.
- 10:11 AM Changeset in webkit [53145] by
-
- 2 edits in trunk/WebKitTools
2010-01-11 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] "build-webkit --chromium" should run "make all" on Linux
https://bugs.webkit.org/show_bug.cgi?id=33500
- Scripts/webkitdirs.pm:
- 10:10 AM Changeset in webkit [53144] by
-
- 3 edits1 add1 delete in trunk/WebKit/chromium
2010-01-11 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
https://bugs.webkit.org/show_bug.cgi?id=33504
- WebKit.gyp:
- tests/KURLTest.cpp: (ComponentCase::TEST):
- tests/RunAllTests.cpp: Added. (main):
- tests/WebKitTest.h: Removed.
- 10:10 AM Changeset in webkit [53143] by
-
- 3 edits3 adds in trunk
2010-01-12 Tony Chang <tony@chromium.org>
Reviewed by Maciej Stachowiak.
Add a test for a Chromium crash when loading multipart/x-mixed-replace
data.
- http/tests/multipart/multipart-wait-before-boundary-expected.txt: Added.
- http/tests/multipart/multipart-wait-before-boundary.html: Added.
- http/tests/multipart/resources/multipart-wait-before-boundary.php: Added.
2010-01-12 Tony Chang <tony@chromium.org>
Reviewed by Maciej Stachowiak.
Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
If we stop a multipart load after ResourceLoader::didReceiveResponse
but before ResourceLoader::didReceiveData, we have a NULL document
loader because it has been moved back to the provisional state. New
loads that happen after this will dereference the NULL document
loader.
Work around this by moving the provisional document loader back as
the document loader when the request is stopped.
Test: http/tests/multipart/multipart-wait-before-boundary.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- 9:15 AM Changeset in webkit [53142] by
-
- 2 edits in trunk/WebCore
WebKit returns incorrect match count when first string match is on an element with user-select-none style
https://bugs.webkit.org/show_bug.cgi?id=33508
<rdar://problem/7482143>
Reviewed by Darin Adler.
If we use VisiblePosition to calculate the start of the new search range,
we skip all the nodes with user-select-none style, producing an incorrect
match count.
No new tests: there are no API's available to Javascript to verify the
number of matches found.
- page/Frame.cpp:
(WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
result range as the start of the new search range.
- 9:03 AM Changeset in webkit [53141] by
-
- 2 edits in trunk/WebCore
2010-01-12 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Changed ".sidebar" style to allow v-scroll to appear in
"Profiles" panel sidebar.
No new tests -- no code changed.
- inspector/front-end/inspector.css:
- 6:37 AM Changeset in webkit [53140] by
-
- 3 edits in trunk/LayoutTests
2010-01-12 Petri Latvala <petri.latvala@nomovok.com>
Reviewed by Antti Koivisto.
fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465
A touchmove event is not dispatched if none of the touch points actually moved.
Changed the test to use touchstart instead.
- fast/events/touch/touch-coords-in-zoom-and-scroll.html:
- platform/qt/Skipped:
- 5:55 AM Changeset in webkit [53139] by
-
- 2 edits in trunk/WebCore
Windows accelerated compositing build fix after r53110
- plugins/PluginWidget.h:
(WebCore::PluginWidget::platformLayer): Define platformLayer() for
non-Mac platforms that have accelerated compositing turned on. It
would probably be better to make PluginWidget not be used at all on
non-Mac platforms, but this fix is much simpler.
- 5:48 AM Changeset in webkit [53138] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428
Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
- tests/testloading.c: (load_error_status_changed_cb):
- 5:05 AM Changeset in webkit [53137] by
-
- 2 edits in trunk/LayoutTests
2010-01-12 Eric Seidel <eric@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814
Skip another test which is hitting the SQLiteDatabase::sqliteHandle() threading ASSERT.
- platform/gtk/Skipped:
- 4:59 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:45 AM Changeset in webkit [53136] by
-
- 3 edits in trunk/LayoutTests
Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526
Reviewed by Simon Hausmann.
Tests moved from fast/events to fast/events/touch by r53125,
relative resource paths should be adjuted to the new location.
- fast/events/touch/basic-touch-events.html: relative paths fixed.
- fast/events/touch/touch-coords-in-zoom-and-scroll.html: relative paths fixed.
- 4:41 AM Changeset in webkit [53135] by
-
- 2 edits in trunk/WebCore
2010-01-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Support injection of inspector scripts into the inspected context.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- 4:31 AM Changeset in webkit [53134] by
-
- 2 edits in trunk/WebKitTools
2010-01-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
AssignToCommitter does not need to fetch bugs twice
https://bugs.webkit.org/show_bug.cgi?id=33530
This is a no-brainer patch now that we've added Bug.reviewed_patches
- Scripts/webkitpy/commands/upload.py:
- 4:03 AM Changeset in webkit [53133] by
-
- 22 edits in trunk/WebKitTools
2010-01-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla.py should have an Attachment object instead of passing around dictionaries
https://bugs.webkit.org/show_bug.cgi?id=31594
- Scripts/webkitpy/bugzilla.py:
- Add a new Attachment class, with accessor methods for all the necessary properties.
- Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
- Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
- Move committer validation logic into its own class.
- Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle the case where we want to reject patches in bugzilla.
- Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
- Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
- Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
- Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
- Scripts/webkitpy/bugzilla_unittest.py:
- Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
- Scripts/webkitpy/commands/download.py:
- Store "bug_id" in state instead of making a fake patch object.
- Update to use Attachment and Bug objects.
- Scripts/webkitpy/commands/download_unittest.py:
- Update expected results now that our testing framework covers more code.
- Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
- Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
- Scripts/webkitpy/commands/queries_unittest.py: ditto.
- Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
- Scripts/webkitpy/commands/queuestest.py: ditto.
- Scripts/webkitpy/commands/upload.py: ditto.
- Scripts/webkitpy/mock_bugzillatool.py:
- Now that more logic has moved into Attachment and Bug, we have to actually provide real reviewer emails as well as real reviewer flags.
- Update mock methods to return Attachment objects.
- Scripts/webkitpy/scm.py: Update to use Attachment class.
- Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
- Scripts/webkitpy/statusserver.py: ditto.
- Scripts/webkitpy/steps/applypatch.py: ditto.
- Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
- Scripts/webkitpy/steps/closebug.py: ditto.
- Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either statebug_id or statepatch.bug_id()
- Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
- Scripts/webkitpy/steps/obsoletepatches.py: ditto.
- Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
- 3:48 AM Changeset in webkit [53132] by
-
- 2 edits2 adds in trunk/WebCore
2010-01-12 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
https://bugs.webkit.org/show_bug.cgi?id=31539
Added manual test: manual-tests/textarea-reset-default-value.html.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
- manual-tests/resources/textarea-form-back-on-submit.html: Added.
- manual-tests/textarea-reset-default-value.html: Added.
- 3:28 AM Changeset in webkit [53131] by
-
- 4 edits in trunk/WebCore
2010-01-12 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
[Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
https://bugs.webkit.org/show_bug.cgi?id=33466
WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
QPainterPath, which itself is a pointer to the elements (QVector).
That creates unecessary allocations in PathQt.cpp.
Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
is a plain QPainterPath.
- platform/graphics/Path.h: (WebCore::Path::platformPath):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform):
- 3:21 AM Changeset in webkit [53130] by
-
- 3 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Unreviewed typo fix. :(
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- 3:21 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:10 AM Changeset in webkit [53129] by
-
- 2 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Unreviewed. Add "error" to the right part of the message.
- Scripts/webkitpy/commands/queues.py:
- 3:06 AM Changeset in webkit [53128] by
-
- 2 edits in trunk/LayoutTests
2010-01-12 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
media/video-error-does-not-exist.html failed on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33434
Add another media test to the skipped list.
I expect these are all timing out for the same reason.
We just don't know the reason yet.
- platform/mac-snowleopard/Skipped:
- 2:42 AM Changeset in webkit [53127] by
-
- 3 edits3 adds in trunk
2010-01-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Barth.
[Qt] XSL stylesheets can load documents from a different origin
Add two expected results for Qt:
QXmlQuery has a different behaviour with regard to loading failures
comparing to libxslt.
- platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
- platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:
2010-01-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Barth.
[Qt] XSL stylesheets can load documents from a different origin
- xml/XSLTProcessorQt.cpp: (WebCore::XSLTUriResolver::XSLTUriResolver): (WebCore::XSLTUriResolver::resolve): (WebCore::XSLTProcessor::transformToString):
- 2:17 AM Changeset in webkit [53126] by
-
- 3 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
EWS should show purple when svn-apply fails
https://bugs.webkit.org/show_bug.cgi?id=33527
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- 2:17 AM Changeset in webkit [53125] by
-
- 5 edits4 moves1 add in trunk/LayoutTests
Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526
Reviewed by Adam Barth.
- fast/events/touch/basic-touch-events-expected.txt: Renamed from LayoutTests/fast/events/basic-touch-events-expected.txt.
- fast/events/touch/basic-touch-events.html: Renamed from LayoutTests/fast/events/basic-touch-events.html.
- fast/events/touch/touch-coords-in-zoom-and-scroll-expected.txt: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll-expected.txt.
- fast/events/touch/touch-coords-in-zoom-and-scroll.html: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll.html.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:09 AM Changeset in webkit [53124] by
-
- 2 edits in trunk/WebCore
2010-01-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
Tweak/correction: Eliminate a needless variable.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
- 1:50 AM Changeset in webkit [53123] by
-
- 3 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove copy/paste code from subclasses of AbstractReviewQueue
https://bugs.webkit.org/show_bug.cgi?id=33525
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- 1:42 AM Changeset in webkit [53122] by
-
- 2 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add Gustavo and Xan as gtk-ews watchers
https://bugs.webkit.org/show_bug.cgi?id=33519
- Scripts/webkitpy/commands/early_warning_system.py:
- 1:41 AM Changeset in webkit [53121] by
-
- 2 edits in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch shouldn't waste my time for with a component prompt
https://bugs.webkit.org/show_bug.cgi?id=33521
The component field isn't very useful for bugs created with
webkit-patch because they're likely to be resolved quickly. Instead of
always prompting for a component, we should just default to the "New
Bugs" component. If the bug stays around for more than five minutes,
we can assign it a proper component.
- Scripts/webkitpy/bugzilla.py:
- 1:40 AM Changeset in webkit [53120] by
-
- 5 edits1 add in trunk/WebKitTools
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add experimental "land-safely" command to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=33518
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/steps/init.py:
- Scripts/webkitpy/steps/postdiffforcommit.py: Added.
- 12:18 AM Changeset in webkit [53119] by
-
- 6 edits in trunk/WebCore
2010-01-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Geoffrey Garen.
Allow creating injected script for the inspected script state. The InjectedScript is
cached on the inspected ExecState global object and will be garbage collected when the
object is collected. Each InjectedScript object is assigned unique id.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
- bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a field that is not visible from the inspected code. This InjectedScript should be alive as long as the global object is alive and should be accessible from Web Inspector's native code. (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): Creates injected script using the lexical global object of the inspected ScriptState. Reference to the object is stored on the global DOM object. (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the the InjectedScript are no longer needed. In particular, this should be called before frame navigation.
- inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source. The source may be loaded in a platform specific way.
- 12:16 AM Changeset in webkit [53118] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ecma/Date/15.9.5.12-1.js fails every night at midnight
https://bugs.webkit.org/show_bug.cgi?id=28041
Change the test to use a concrete time instead of "now".
- tests/mozilla/ecma/Date/15.9.5.10-1.js:
- tests/mozilla/ecma/Date/15.9.5.12-1.js:
Jan 11, 2010:
- 11:25 PM Changeset in webkit [53117] by
-
- 2 edits in trunk/WebKitSite
Not reviewed; updated for truth (and readability).
Fixed some wrong listings and reorganized this page.
- security/security-group-members.html:
- 10:46 PM Changeset in webkit [53116] by
-
- 2 edits in trunk/LayoutTests
2010-01-11 Kent Tamura <tkent@chromium.org>
Unreviewd. Remove a duplicated line in an expectation file.
- platform/mac-leopard/fast/text/find-kana-expected.txt:
- 9:53 PM Changeset in webkit [53115] by
-
- 3 edits in trunk/LayoutTests
Try to get find-kana tests passing on Qt, Leopard, and Tiger.
- platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
- platform/qt/fast/text/find-kana-expected.txt: Ditto.
- 5:48 PM Changeset in webkit [53114] by
-
- 7 edits in trunk
Fix handling of unusual kana sequences in search
https://bugs.webkit.org/show_bug.cgi?id=33506
Reviewed by Dan Bernstein.
WebCore:
- editing/TextIterator.cpp:
(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.
LayoutTests:
- fast/text/find-kana-expected.txt: Updated.
- fast/text/script-tests/find-kana.js: Added new tests for sequences
that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.
- platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
- platform/qt/fast/text/find-kana-expected.txt: Updated.
- 5:22 PM Changeset in webkit [53113] by
-
- 2 edits in trunk/WebCore
2010-01-11 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.
TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
- 4:55 PM Changeset in webkit [53112] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after introduction of JS_NO_EXPORT
- 4:42 PM Changeset in webkit [53111] by
-
- 2 edits in trunk/WebCore
2010-01-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Eric Seidel.
[GTK] Debug bots crashing in plugins/iframe-shims.html
https://bugs.webkit.org/show_bug.cgi?id=33472
Call computeOffsetInContainerNode() instead of
offsetInContainerNode(), since we are not sure this is always
parent-anchored.
plugins/iframe-shims.html no longer ASSERTS
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- 4:15 PM Changeset in webkit [53110] by
-
- 17 edits in trunk
2010-01-11 Simon Fraser <Simon Fraser>
Reviewed by Kevin Decker.
https://bugs.webkit.org/show_bug.cgi?id=33455
Allows plugins to participate in accelerated compositing
For plugins using the CoreAnimation rendering mode, host their CALayers in the
accelerated compositing layer tree.
This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
a plugin using this mode.
- WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
- WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
- rendering/RenderEmbeddedObject.h:
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using accelerated compositing mode. (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has a layer, via PluginWidget.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer): RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode for the page.
- 4:09 PM Changeset in webkit [53109] by
-
- 2 edits in trunk/WebCore
2010-01-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Fixed an uninitialized PluginView member (m_mode) which wasn't
set when constructed with a null PluginPackage*
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- 4:02 PM Changeset in webkit [53108] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt
2010-01-11 William Siegrist <wsiegrist@apple.com>
Sync new Disallow rules from build.webkit.org.
- 3:58 PM Changeset in webkit [53107] by
-
- 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html
2010-01-11 William Siegrist <wsiegrist@apple.com>
Add Console and CQ Bot Status links to build.webkit.org. Sync CSS changes.
- 3:41 PM Changeset in webkit [53106] by
-
- 7 edits in trunk
2010-01-11 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
- platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
2010-01-11 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201
This patch moves every focalPoint that lies outside the circle defined by the radial
gradients central point and its radius to stay inside this circle, as demanded by the
SVG 1.1 specification.
We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
the focalPoint is lying, to achieve compatibility with Firefox.
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- 3:35 PM Changeset in webkit [53105] by
-
- 5 edits2 deletes in trunk/WebKitTools
2010-01-11 Eric Seidel <eric@webkit.org>
No review, rolling out r53079.
http://trac.webkit.org/changeset/53079
https://bugs.webkit.org/show_bug.cgi?id=33197
Adam doens't think this actually works, and believe it caused
a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
rolling this out.
- Scripts/test-webkitpy:
- Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
- Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- 3:00 PM Changeset in webkit [53104] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33493
Log redirect details to Network channel
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Log response code and Location header field value. Also, removed a redundant null check.
- 2:56 PM Changeset in webkit [53103] by
-
- 13 edits8 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION:
Many SVG -webkit-shadow tests are currently failing (in the pixel
tests)
-and-
<rdar://problem/7501200>
Reviewed by Oliver Hunt.
The real fix here is to call inflateForShadow() on the repaintRect
in prepareToRenderSVGContent(). But in order to do that, I had to
move inflateForShadow() to a different class since functions in
SVGRenderBase cannot call each other. inflateForShadow() now exists
in SVGRenderStyle which I think makes some sense because a similar
function that returns a box shadow's extent exists on RenderStyle.
Now call inflateForShadow() through the SVGRenderStyle.
- rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::computeRectForRepaint):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeRectForRepaint):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
No longer implement inflateForShadow() here.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new
inflateForShadow() through the SVGRenderStyle
- rendering/SVGRenderSupport.h:
Implementation of inflateForShadow() now lives here.
- rendering/style/SVGRenderStyle.cpp:
(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderStyle::inflateForShadow):
- rendering/style/SVGRenderStyle.h:
LayoutTests: New tests for https://bugs.webkit.org/show_bug.cgi?id=33491
REGRESSION: Many SVG -webkit-shadow tests are currently failing (in
the pixel tests)
-and-
<rdar://problem/7501200>
Reviewed by Oliver Hunt.
I would like to note that this change fixes some existing layout
tests as well.
- platform/mac/svg/css/shadow-with-large-radius-expected.checksum: Added.
- platform/mac/svg/css/shadow-with-large-radius-expected.png: Added.
- platform/mac/svg/css/shadow-with-large-radius-expected.txt: Added.
- platform/mac/svg/css/shadow-with-negative-offset-expected.checksum: Added.
- platform/mac/svg/css/shadow-with-negative-offset-expected.png: Added.
- platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Added.
- platform/mac/svg/css/stars-with-shadow-expected.checksum:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- svg/css/shadow-with-large-radius.svg: Added.
- svg/css/shadow-with-negative-offset.svg: Added.
- 2:52 PM Changeset in webkit [53102] by
-
- 2 edits in trunk/LayoutTests
2010-01-11 Eric Seidel <eric@webkit.org>
Rubber-stamped by Csaba Osztrogonac.
Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=33024
- platform/qt/Skipped: Skip this new test, Qt's DRT doesn't support evaluateInWebInspector()
- 2:46 PM Changeset in webkit [53101] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=33411
Reviewed by Eric Seidel.
Missing updated test result for gtk.
- platform/gtk/editing/deleting/5115601-expected.txt:
- 2:33 PM Changeset in webkit [53100] by
-
- 4 edits2 adds in trunk
2010-01-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Rewrite relative URLs in the ElementsTreeOutline to make them navigable
Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024
- inspector/elements-panel-rewrite-href-expected.txt: Added.
- inspector/elements-panel-rewrite-href.html: Added.
2010-01-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Rewrite relative URLs in the ElementsTreeOutline to make them navigable
Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024
Test: inspector/elements-panel-rewrite-href.html
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- inspector/front-end/inspector.js:
- 2:20 PM Changeset in webkit [53099] by
-
- 2 edits in trunk/SunSpider
2010-01-11 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Sunspider parse-only tests don't run
https://bugs.webkit.org/show_bug.cgi?id=33489
Fix parse-only test list
- tests/parse-only/LIST:
- 2:17 PM Changeset in webkit [53098] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
fast/text/international/japanese-kana-letters.html
removed by r53078, so it should be removed from skiplist.
- platform/qt/Skipped: fast/text/international/japanese-kana-letters.html removed.
- 1:54 PM Changeset in webkit [53097] by
-
- 17 edits in trunk/LayoutTests
2010-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Simon Fraser.
Deflake transitions and animations tests.
https://bugs.webkit.org/show_bug.cgi?id=30029
The transition-end-event tests all had arbitrary timeouts. Give a consistent
timeout to all of them. Give a generous 1 second of buffer to avoid any possibility
of flakiness. If all the transitionEnd events fire before then, the test still
completes without waiting for the timeout.
- animations/change-keyframes.html: Increase the wiggle room. It's infrequently flaky now, but it is still a tad bit flaky without this extra wiggle room.
- transitions/repeated-firing-background-color.html: Remove a gratuitous setTimeout.
- transitions/transition-end-event-all-properties.html:
- transitions/transition-end-event-attributes.html:
- transitions/transition-end-event-container.html:
- transitions/transition-end-event-helpers.js: (runTransitionTest.startTest): (runTransitionTest):
- transitions/transition-end-event-left.html:
- transitions/transition-end-event-multiple-01.html:
- transitions/transition-end-event-multiple-02.html:
- transitions/transition-end-event-multiple-03.html:
- transitions/transition-end-event-multiple-04.html:
- transitions/transition-end-event-nested.html:
- transitions/transition-end-event-set-none.html:
- transitions/transition-end-event-transform.html:
- transitions/transition-end-event-window.html:
- transitions/zero-duration-with-non-zero-delay-end.html:
- 1:46 PM Changeset in webkit [53096] by
-
- 1 edit2 copies in trunk/LayoutTests
Try to get find-kana and find-russian tests passing on Qt.
- platform/qt/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
- platform/qt/fast/text/find-russian-expected.txt: Copied from fast/text/find-russian-expected.txt.
Changed to expect failures because text searching does not use
ICU's usearch on this platform, and the non-usearch code is much
less capable.
- 1:31 PM Status created by
- 1:23 PM WebKit Team edited by
- Add areas of knowledge to my team member information. (diff)
- 1:04 PM MathML edited by
- (diff)
- 12:35 PM Changeset in webkit [53095] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33482
Add a test for Russian text search
- fast/text/find-russian-expected.txt: Added.
- fast/text/find-russian.html: Added.
- fast/text/script-tests/find-russian.js: Added.
- 12:33 PM Changeset in webkit [53094] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)
Reviewed by Ariya Hidayat.
- wtf/Platform.h:
- 12:19 PM Changeset in webkit [53093] by
-
- 1 edit1 copy in trunk/LayoutTests
Try to get find-kana test passing on Tiger and Leopard.
- platform/mac-leopard/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
Changed to expect failures due to an older version of ICU on those platforms.
- 12:14 PM Changeset in webkit [53092] by
-
- 2 edits in trunk/LayoutTests
Updated Windows expected results after r53085.
Reviewed by NOBODY.
- platform/win/editing/selection/mixed-editability-10-expected.txt:
- 11:55 AM Changeset in webkit [53091] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage
SunSpider reports no change.
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize missing data members in the two cases where we don't use fastZeroedMalloc, so it doesn't happen automatically.
- 11:53 AM Changeset in webkit [53090] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix ChangeLog
- 11:45 AM Changeset in webkit [53089] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33480
Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 11:42 AM Changeset in webkit [53088] by
-
- 2 edits in trunk/WebCore
2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.
- bindings/js/JSBindingsAllInOne.cpp:
- 11:34 AM Changeset in webkit [53087] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
Remove extraneous entries from def file causing build warning.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:23 AM Changeset in webkit [53086] by
-
- 13 edits1 move7 adds1 delete in trunk
2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben & Dirk Schulze.
svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384
Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
(Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)
Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
'rotate' & 'x'/'y' SVG DOM properties.
Tests: svg/custom/text-xy-updates-SVGList.xhtml
svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html
- Android.jscbindings.mk: Remove old files from build, add the new header.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize): (WebCore::JSSVGPODListCustom::getItem): (WebCore::JSSVGPODListCustom::insertItemBefore): (WebCore::JSSVGPODListCustom::replaceItem): (WebCore::JSSVGPODListCustom::removeItem): (WebCore::JSSVGPODListCustom::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: Removed.
- bindings/js/JSSVGTransformListCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
- svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work. (WebCore::SVGNumberList::SVGNumberList):
- svg/SVGNumberList.h:
- svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
- svg/SVGTransformList.idl: Ditto.
2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben & Dirk Schulze.
svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384
Add simple tests covering SVGLengthList & SVGNumberList updates.
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
- svg/custom/text-xy-updates-SVGList.xhtml: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGTextElement-svgdom-rotate-prop.js: Added. (executeTest):
- 10:04 AM Changeset in webkit [53085] by
-
- 10 edits in trunk
Cannot focus on an empty editable span in a non editable div.
https://bugs.webkit.org/show_bug.cgi?id=33411
<rdar://problem/5982901>
Reviewed by Darin Adler.
WebCore:
We now allow to set the focus inside an empty inline element if it is the only
editable element inside non-editable content.
- dom/Position.cpp:
(WebCore::Position::isCandidate): Extended to allow positions in inline elements when
at the border between editable and non editable content.
(WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
position inside an empty inline.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
element, since now an editable inline is a VisiblePosition if it is at editability boundary.
- editing/VisibleSelection.h: Updated comment on the use of Position member variables
instead of VisiblePosition.
- page/Frame.cpp:
(WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
downstream on the same position.
LayoutTests:
- editing/deleting/6026335-expected.txt: Updated to reflect the lack of extra break element.
- editing/selection/mixed-editability-10-expected.txt: Updated to cover the new case.
- editing/selection/mixed-editability-10.html: Updated to cover the new case.
- platform/mac/editing/deleting/5115601-expected.txt: Updated to reflect the lack of extra break element.
- 9:57 AM Changeset in webkit [53084] by
-
- 5 edits in trunk
Revert 53075 since it caused ASSERTS to be hit.
- 9:16 AM Changeset in webkit [53083] by
-
- 2 edits in trunk/WebCore
2010-01-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Nikolas Zimmermann.
[V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
https://bugs.webkit.org/show_bug.cgi?id=32994
Refactoring, covered by existings tests.
- bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,
since there's a much smaller (and more stable) set of non-ref-counted ones.
- 9:08 AM Changeset in webkit [53082] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=33472
[GTK] Debug bots crashing in plugins/iframe-shims.html
Skip test that fails on bots, but passes locally, so we can
investigate.
- 9:05 AM Changeset in webkit [53081] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-01-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Test that document.referrer is properly preserved through a redirect.
- http/tests/navigation/redirect-preserves-referrer-expected.txt: Added.
- http/tests/navigation/redirect-preserves-referrer.html: Added.
- http/tests/navigation/resources/redirect-to-referrer-check.pl: Added.
- http/tests/navigation/resources/referrer.html: Added.
- 9:02 AM Changeset in webkit [53080] by
-
- 7 edits in trunk/WebCore
2010-01-11 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
https://bugs.webkit.org/show_bug.cgi?id=32846
Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
directly when the DOM is mutated.
- dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed. (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/Element.cpp: Calls InspectorController directly when attributes are added/removed. (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
- inspector/InspectorDOMAgent.h:
- 8:50 AM Changeset in webkit [53079] by
-
- 5 edits1 copy1 add in trunk/WebKitTools
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by David Kilzer.
bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197
We should just search for bug numbers in the ChangeLogs instead of in
the whole diff.
- Scripts/test-webkitpy:
- Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
- Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- 8:30 AM Changeset in webkit [53078] by
-
- 3 edits3 adds2 deletes in trunk
REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
https://bugs.webkit.org/show_bug.cgi?id=30437
rdar://problem/7214058
Reviewed by Alexey Proskuryakov.
WebCore:
Test: fast/text/find-kana.html
- editing/TextIterator.cpp:
(WebCore::isKanaLetter): Added.
(WebCore::isSmallKanaLetter): Added.
(WebCore::composedVoicedSoundMark): Added.
(WebCore::isCombiningVoicedSoundMark): Added.
(WebCore::containsKanaLetters): Added.
(WebCore::normalizeCharacters): Added.
(WebCore::SearchBuffer::SearchBuffer): Initialize the data members
m_targetRequiresKanaWorkaround and m_normalizedTarget.
(WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
ICU's default collation considers correct, but we consider incorrect.
(WebCore::SearchBuffer::search): Added code to call isBadMatch and
move to the next match with usearch_next if the result is true.
LayoutTests:
- fast/text/international/japanese-kana-letters-expected.txt: Removed.
- fast/text/international/japanese-kana-letters.html: Removed.
- fast/text/find-kana-expected.txt: Added.
- fast/text/find-kana.html: Added.
- fast/text/script-tests/find-kana.js: Added.
This includes all the tests that were in the old test removed above, with three
differences:
1) Moved out of "international" directory because Mitz wants to phase that
directory out.
2) Added more tests to cover more cases involving things like decomposed
characters and different voice marks.
3) Used script-tests, so results list passing tests as well as failing tests.
We could still test even more, but this should at least cover all the lines of
code in the current bug fix patch.
- 8:15 AM Changeset in webkit [53077] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Add private API for QWebFrame scrolling, to maintain binary compatibility with Qt 4.6.
Reviewed by Holger Freyther.
This is just a temporary addition until we have introduced #ifdefs to allow
safely removing the private API again.
- Api/qwebframe.cpp:
(qtwebkit_webframe_scrollRecursively):
- 7:52 AM Changeset in webkit [53076] by
-
- 2 edits1 add in trunk/WebKitTools
Created a unit-tested function to parse the header block of
a Git or SVN diff -- for future refactoring of svn-apply and
svn-unapply.
Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-11
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=33447
- Scripts/VCSUtils.pm:
- Added parseDiffHeader().
- Removed irrelevant comment from gitdiff2svndiff().
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
- Added 48 unit tests for parseDiffHeader().
- 7:51 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:15 AM Changeset in webkit [53075] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428
Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
- tests/testloading.c: (load_error_status_changed_cb):
- 5:16 AM QtWebKitReleases edited by
- (diff)
- 4:23 AM Changeset in webkit [53074] by
-
- 1 edit6 adds in trunk/LayoutTests
Rubber-stamped by Holger Hans Peter Freyther.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.
- platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
- platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
- platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
- platform/qt/svg/text/selection-background-color-expected.txt: Added.
- 4:12 AM Changeset in webkit [53073] by
-
- 2 edits in trunk/LayoutTests
Unreviewed typo fix.
- platform/qt/Skipped:
- 4:03 AM Changeset in webkit [53072] by
-
- 4 edits in trunk/WebCore
2010-01-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
- accessibility/gtk/AccessibilityObjectWrapperAtk.h
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): (webkit_accessible_text_get_caret_offset):
- editing/gtk/SelectionControllerGtk.cpp: (SelectionController::notifyAccessibilityForSelectionChange)
Adjust the caret offset and object with focus to reflect the
unignored parent of the static text object which contains the
caret. This is necessary because the static text objects are
no longer being exposed to ATs.
- 3:48 AM Changeset in webkit [53071] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465
- platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.
- 3:35 AM Changeset in webkit [53070] by
-
- 45 edits in trunk/LayoutTests
2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Update SVG test baseline, after the SVG text painting changes, a while ago.
The differences are all below <0.1%, and only show up when running with --tolerance 0.
- 1:44 AM Changeset in webkit [53069] by
-
- 7 edits2 adds in trunk
2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899
- fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
- fast/events/touch-coords-in-zoom-and-scroll.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899
Test: fast/events/touch-coords-in-zoom-and-scroll.html
- dom/Touch.cpp: (WebCore::contentsX): (WebCore::contentsY):
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- 1:20 AM Changeset in webkit [53068] by
-
- 3 edits2 adds in trunk
2010-01-11 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639
- editing/execCommand/paste-and-match-style-event.html: Added.
2010-01-11 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639
Test: editing/execCommand/paste-and-match-style-event.html
- editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
Jan 10, 2010:
- 10:53 PM Changeset in webkit [53067] by
-
- 2 edits in trunk/WebCore
Rollout renderpath culling as it once again breaks pixel tests.
- 10:14 PM Changeset in webkit [53066] by
-
- 6 edits in trunk/WebKitTools
2010-01-10 Adam Barth <abarth@webkit.org>
Rubber stamped by David Kilzer.
bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197
Fix a typo: Commmand -> Command.
- Scripts/webkitpy/commands/abstractsequencedcommand.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/multicommandtool.py:
- 10:09 PM Changeset in webkit [53065] by
-
- 3 edits in trunk/LayoutTests
2010-01-10 Daniel Bates <dbates@webkit.org>
Unreviewed, fix typo.
Fixed typo in test LayoutTests/fast/events/frame-programmatic-focus.html.
The word "frame" should be "iframe" in the string "<input> in frame blurred"
based on the context of the test. In particular, the line "<input> in iframe focused"
and the use of an iframe in the test.
- fast/events/frame-programmatic-focus-expected.txt:
- fast/events/frame-programmatic-focus.html:
- 9:36 PM Changeset in webkit [53064] by
-
- 2 edits in trunk/LayoutTests
2010-01-10 Daniel Bates <dbates@webkit.org>
Rubber-stamped by Eric Seidel.
Adding XSSAuditor test http/tests/security/xssAuditor/malformed-HTML.html
to the Qt Skipped file as it times out. We need to look into test further.
See bug #33460 for more details.
- platform/qt/Skipped:
- 9:11 PM Changeset in webkit [53063] by
-
- 2 edits in trunk/WebKitTools
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Let webkit-patch work with options in $EDITOR
https://bugs.webkit.org/show_bug.cgi?id=33414
The $EDITOR evironment variable might have command line options like
bbedit -w. This patch lets us run those $EDITORs.
- Scripts/webkitpy/user.py:
- 8:55 PM Changeset in webkit [53062] by
-
- 10 edits in trunk
2010-01-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
- tests/mozilla/ecma_2/RegExp/properties-001.js: (AddRegExpCases):
- tests/mozilla/js1_2/regexp/toString.js: Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).
2010-01-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
Add new test cases and adapt existing ones.
- fast/js/kde/RegExp-expected.txt:
- fast/js/kde/script-tests/RegExp.js:
- fast/js/regexp-compile-expected.txt:
- fast/js/script-tests/regexp-compile.js:
- fast/regex/non-pattern-characters-expected.txt:
- 8:34 PM Changeset in webkit [53061] by
-
- 120 edits in trunk/JavaScriptCore
- tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
- tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
- tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
- tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
- tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
- tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
- tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
- tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
- tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
- tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
- tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
- tests/mozilla/ecma/shell.js: Modified property allow-tabs.
- tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
- tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
- tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
- tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
- tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
- tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
- tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
- tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
- tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
- tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
- tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
- tests/mozilla/importList.html: Added property allow-tabs.
- tests/mozilla/js1_1/shell.js: Added property allow-tabs.
- tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
- tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
- tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
- tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
- tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
- tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
- tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
- tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
- tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
- tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
- tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
- tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
- tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
- tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
- tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
- tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
- tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
- tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
- tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
- tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
- tests/mozilla/js1_2/shell.js: Added property allow-tabs.
- tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
- tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
- tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
- tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
- tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
- tests/mozilla/js1_3/shell.js: Added property allow-tabs.
- tests/mozilla/js1_4/shell.js: Added property allow-tabs.
- tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
- tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
- tests/mozilla/menuhead.html: Added property allow-tabs.
- tests/mozilla/mklistpage.pl: Added property allow-tabs.
- tests/mozilla/runtests.pl: Added property allow-tabs.
- 8:09 PM Changeset in webkit [53060] by
-
- 9 edits in trunk
2010-01-10 Robert Hogan <robert@roberthogan.net>
Reviewed by Adam Barth.
[Qt] Add enableXSSAuditor support to QWebSettings and DRT.
- platform/qt/Skipped:
2010-01-10 Robert Hogan <robert@roberthogan.net>
Reviewed by Adam Barth.
[Qt] Add enableXSSAuditor support to QWebSettings and DRT.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-01-10 Robert Hogan <robert@roberthogan.net>
Reviewed by Adam Barth.
[Qt] Add enableXSSAuditor support to QWebSettings and DRT.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::createWindow):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 7:47 PM Changeset in webkit [53059] by
-
- 5 edits in trunk/WebCore
2010-01-10 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Allows plugins to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=33455
Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
to make it more general. Rename associated enums and methods similarly.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToMedia):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
- 7:41 PM Changeset in webkit [53058] by
-
- 2 edits in trunk/LayoutTests
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33458
Fix flakey test. If the machine is very slow, then more than 10ms
might have elapsed between registering the timeout and calling
postMessage. We can't be sure which order they will be called in.
Re-ordering the call guarantees the arrival order, even if it reduces
our coverage slightly.
- http/tests/messaging/cross-domain-message-event-dispatch.html:
- 6:59 PM Changeset in webkit [53057] by
-
- 2 edits in trunk/WebCore
Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055
Reviewed by Nikolas Zimmerman
Cull RenderPaths before passing on to the underlying graphics system.
- 4:47 PM Changeset in webkit [53056] by
-
- 6 edits8 adds in trunk
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368
Test the mutating the allow-same-origin directive in the sandbox
attribute does not affect the current document (but does affect the
next document).
- http/tests/security/resources/sandboxed-iframe-origin-add-step1.html: Added.
- http/tests/security/resources/sandboxed-iframe-origin-add-step2.html: Added.
- http/tests/security/resources/sandboxed-iframe-origin-remove-step1.html: Added.
- http/tests/security/resources/sandboxed-iframe-origin-remove-step2.html: Added.
- http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
- http/tests/security/sandboxed-iframe-origin-add.html: Added.
- http/tests/security/sandboxed-iframe-origin-remove-expected.txt: Added.
- http/tests/security/sandboxed-iframe-origin-remove.html: Added.
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368
We now initialize the SecurityOrigin's sandbox state directly duing
construction. This lets us properly set the isUnique bit.
Tests: http/tests/security/sandboxed-iframe-origin-add.html
http/tests/security/sandboxed-iframe-origin-remove.html
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::setSandboxFlags):
- page/SecurityOrigin.h:
- 4:38 PM Changeset in webkit [53055] by
-
- 2 edits in trunk/LayoutTests
2010-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Nikolas Zimmermann.
http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349
Previously we were using JavaScript URLs to return to the main event
loop, but that is potentially unreliable because there can be only one
scheduled redirect in flight per frame. Let's try using setTimeout
instead. Notice that there isn't a race condition here because the
event loop will always dispatch the actions in the proper order.
- http/tests/security/xss-DENIED-window-open-javascript-url.html:
- 2:53 PM Changeset in webkit [53054] by
-
- 2 edits in trunk/WebKitTools
2010-01-10 Adam Barth <abarth@webkit.org>
Unreviewed cosmetic change. Remove the status bubble for mac-ews
because we don't have hardware for it at the moment.
- QueueStatusServer/templates/statusbubble.html:
- 1:30 PM Changeset in webkit [53053] by
-
- 3 edits in trunk/WebCore
2010-01-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Inspect Element selects the wrong element.
Drive-by fix that focuses dom tree upon settting focuesDOMNode.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
- inspector/front-end/treeoutline.js: (TreeElement.prototype.select):
- 1:04 PM QtWebKitJournal edited by
- (diff)
- 11:15 AM Changeset in webkit [53052] by
-
- 2 edits in trunk/WebCore
2010-01-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce support for flexible line height in the text editor.
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._offsetToLineNumber): (WebInspector.TextEditor.prototype._lineNumberToOffset): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._selectionChanged): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._paintLines): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLineNumbers): (WebInspector.TextEditor.prototype._paintCurrentLine): (WebInspector.TextEditor.prototype._scroll): (WebInspector.TextEditor.prototype._repaintOnScroll): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._handleNavigationKey): (WebInspector.TextEditor.prototype._updateCursor): (WebInspector.TextEditor.prototype._invalidateHighlight): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._initFont): (WebInspector.TextCursor.prototype.setTextLineHeight):
- 11:06 AM Changeset in webkit [53051] by
-
- 2 edits in trunk/WebCore
2010-01-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not repaint line numbers while editing within line.
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._selectionChanged): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paintLines): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLineNumbers): (WebInspector.TextEditor.prototype._updateCursor): (WebInspector.TextEditor.prototype._copy):
- 2:27 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:14 AM Changeset in webkit [53050] by
-
- 4 edits in trunk/WebCore
2010-01-10 Adam Barth <abarth@webkit.org>
Unreviewed whitespace fixes.
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags):
- loader/FrameLoader.h:
- 12:10 AM Changeset in webkit [53049] by
-
- 5 edits in trunk/WebCore
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Unify origin sandbox flag with m_noAccess in SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=32372
It turns out the SandboxOrigin bit is slightly different than the
unique origin concept because the sandbox bit is inherited by iframes.
These concepts are separate in the spec, so I think it's ok to keep
them separate in the implementation as well.
No new tests because there is no behavior change.
- dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::setCookie):
- loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
- page/SecurityOrigin.cpp: (WebCore::schemesWithUniqueOrigins): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::taintsCanvas): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::toString): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::canAccessCookies): (WebCore::SecurityOrigin::isUnique):
Jan 9, 2010:
- 7:12 PM Changeset in webkit [53048] by
-
- 9 edits in trunk
2010-01-09 Daniel Bates <dbates@webkit.org>
No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419
We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.
- Api/qwebsettings.cpp:
- Api/qwebsettings.h:
2010-01-09 Daniel Bates <dbates@webkit.org>
No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419
We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-01-09 Daniel Bates <dbates@webkit.org>
No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419
We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.
- platform/qt/Skipped:
- 6:52 PM Changeset in webkit [53047] by
-
- 2 edits in trunk/LayoutTests
2010-01-09 Daniel Bates <dbates@webkit.org>
No review, rolling out r53045.
http://trac.webkit.org/changeset/53045
https://bugs.webkit.org/show_bug.cgi?id=33440
This fix did not resolve the issue. That is, more XSSAuditor tests are
failing on the Qt bot. So, we're going ultimately going to rollout the
change committed in change set 53044 <http://trac.webkit.org/changeset/53044>,
but we need to first rollout the attempted fix committed in change
set 53045.
- platform/qt/Skipped:
- 6:36 PM Changeset in webkit [53046] by
-
- 28 edits in trunk
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063
Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts to reflect what the method actually
means. This is a trivial change, but it involved touching a lot of
call sites.
- WebCore.PluginHostProcess.exp:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): (WebCore::ScriptController::executeScript):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::jsObjectForPluginElement): (WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.h:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
- inspector/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063
Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::bindToWindowObject):
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063
Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063
Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.
- WebFrame.cpp: (wxWebFrame::RunScript):
- 6:00 PM Changeset in webkit [53045] by
-
- 2 edits in trunk/LayoutTests
2010-01-09 Daniel Bates <dbates@webkit.org>
Rubber-stamped by Adam Barth.
Adds failing XSSAuditor tests to the Qt Skipped file
while we come up with a fix for them. See bug #33440
for more details.
- platform/qt/Skipped:
- 4:40 PM Changeset in webkit [53044] by
-
- 9 edits in trunk
2010-01-09 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Adds support for the XSSAuditor to the Qt DRT.
- Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
- Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.
2010-01-09 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Removes the XSSAuditor tests from the Qt Skipped file since
we now can run these tests.
- platform/qt/Skipped:
2010-01-09 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Adds support for the XSSAuditor to the Qt DRT.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 4:20 PM Changeset in webkit [53043] by
-
- 3 edits1 copy1 add in trunk/WebKitTools
2010-01-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Retry writes to QueueStatusServer when we get 500 errors
https://bugs.webkit.org/show_bug.cgi?id=33412
This prevents the queues from failing to mark a patch as "pass" or
"fail" when AppEngine throws 500 errors.
- Scripts/test-webkitpy:
- Scripts/webkitpy/networktransaction.py: Added.
- Scripts/webkitpy/networktransaction_unittest.py: Added.
- Scripts/webkitpy/statusserver.py:
- Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
- Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
- Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
- 4:18 PM Changeset in webkit [53042] by
-
- 2 edits in trunk/WebCore
2010-01-09 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Inspector font for errors is ugly on non-OSX platforms
https://bugs.webkit.org/show_bug.cgi?id=33340
- css/view-source.css: Add a fallback to sans-serif on a CSS selector that previously only listed Lucida Grande.
- 4:01 PM Changeset in webkit [53041] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
Reviewed by Eric Seidel.
- QueueStatusServer/templates/statusbubble.html: Added
-moz-border-radius and -webkit-border-radius to provide rounded
borders in older Firefox and Safari browsers.
- 2:50 PM Changeset in webkit [53040] by
-
- 3 edits in trunk/WebKitTools
2010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Kilzer.
Modified VCSUtils::gitdiff2svndiff() to accept strings that
end in vertical white space.
- Scripts/VCSUtils.pm:
- Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
- 10:45 AM Changeset in webkit [53039] by
-
- 5 edits4 adds in trunk
<rdar://problem/7525778> Font fallback kills SVG kerning
https://bugs.webkit.org/show_bug.cgi?id=33400
Reviewed by Nikolas Zimmermann.
WebCore:
Test: platform/mac/fast/text/sticky-typesetting-features.html
Cache font attributes separately for different typesetting features.
- platform/graphics/SimpleFontData.h: Replaced single-element caches
with maps.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Added an ATSUStyle parameter.
(WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
initialize if necessary. Return the ATSUStyle.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use the ATSUStyle returned from initializeATSUStyle().
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
map.
(WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
dictionary in the map and initialize if necessary.
LayoutTests:
- platform/mac/fast/text/sticky-typesetting-features-expected.checksum: Added.
- platform/mac/fast/text/sticky-typesetting-features-expected.png: Added.
- platform/mac/fast/text/sticky-typesetting-features-expected.txt: Added.
- platform/mac/fast/text/sticky-typesetting-features.html: Added.
Jan 8, 2010:
- 11:49 PM Changeset in webkit [53038] by
-
- 2 edits in trunk/WebCore
2010-01-08 Adam Barth <abarth@webkit.org>
Unreviewed. Fix namespace indent for SecurityOrigin.h.
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::domain): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::canLoadLocalResources): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::):
- 11:40 PM Changeset in webkit [53037] by
-
- 3 edits in trunk/WebCore
2010-01-08 Adam Barth <abarth@webkit.org>
Reviewed by Dmitry Titov.
bindings/v8/DOMData is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=33390
DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:
"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"
We therefore need to add a virtual destructor to DOMData.
- bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
- bindings/v8/DOMData.h:
- 11:09 PM Changeset in webkit [53036] by
-
- 7 edits in trunk
2010-01-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.
No functionality was changed. So, no new tests.
- wtf/Platform.h:
2010-01-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up style errors exposed by the patch for bug #33198.
No functionality was changed. So, no new tests.
- src/GraphicsContext3D.cpp:
2010-01-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up style errors exposed by the patch for bug #33198.
No functionality was changed. So, no new tests.
- platform/graphics/SimpleFontData.h:
- plugins/PluginPackage.cpp:
- 8:48 PM Changeset in webkit [53035] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-01-08 Simon Fraser <Simon Fraser>
No review.
Remove layout test that was committed by mistake.
- compositing/webgl/webgl-blending.html: Removed.
- 8:07 PM Changeset in webkit [53034] by
-
- 4 edits26 adds in trunk
2010-01-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
WebGL canvas paints background color twice
https://bugs.webkit.org/show_bug.cgi?id=33361
Clean up some logic around "directly composited" content: some images, video, and WebGL.
We previously set the GraphicsLayer background color to the CSS background color
in some cases where the box has no other decorations. However, the content
layer's bounds do not correspond with the background box in many cases,
and we could end up both painting the background color, and setting it on the layer.
Simplify this logic to never use layer background colors, and thus skip allocating
backing store only when the element has no visible box decorations.
Tests: compositing/images/direct-image-background-color.html
compositing/reflections/simple-composited-reflections.html
compositing/video/video-background-color.html
compositing/webgl/webgl-background-color.html
compositing/webgl/webgl-blending.html
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerBacking.cpp: (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing() is renamed to isDirectlyCompositedImage() and only applies to images now. No longer set layer background color. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent() as the argument to setDrawsContent(). (WebCore::hasBoxDecorationsOrBackground): Renamed. (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations(). (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment. (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides if the layer (and its non-composited children) has any content that must be painted into backing store. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing() and reduced to only apply to images. (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the canUseDirectCompositing() scope.
- 6:16 PM Changeset in webkit [53033] by
-
- 2 edits in trunk/BugsSite
<http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
Reviewed by Adam Barth.
This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.
- template/en/custom/attachment/reviewform.html.tmpl: Changed
attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.
- 5:57 PM Changeset in webkit [53032] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Eric Seidel.
Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321
It's unused; the string representation is reconstructed from flags.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp):
- runtime/RegExp.h:
- 5:46 PM Changeset in webkit [53031] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:45 PM Changeset in webkit [53030] by
-
- 1 copy in tags/Safari-6531.22
New tag.
- 5:39 PM Changeset in webkit [53029] by
-
- 8 edits in branches/safari-4-branch
Merge r52141.
- 5:39 PM Changeset in webkit [53028] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:25 PM Changeset in webkit [53027] by
-
- 2 edits in trunk/WebCore
2010-01-08 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Use member initialization syntax instead of assignment for member variables of Document used
for determining minimum layout delay.
https://bugs.webkit.org/show_bug.cgi?id=33316
No new tests, style change only.
- dom/Document.cpp: Modified. (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
- 5:02 PM Changeset in webkit [53026] by
-
- 6 edits2 adds in trunk
2010-01-08 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352
Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.
- fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
- fast/canvas/webgl/array-set-out-of-bounds.html: Added.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
2010-01-08 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352
Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.
Test: fast/canvas/webgl/array-set-out-of-bounds.html
- bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayFromArray):
- 5:02 PM Changeset in webkit [53025] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Memory use grows grows possibly unbounded in this JavaScript Array test case
https://bugs.webkit.org/show_bug.cgi?id=31675
This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.
SunSpider reports a small speedup.
- runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): Report extra memory cost for the sparse value map.
- runtime/JSArray.h:
- 4:46 PM Changeset in webkit [53024] by
-
- 2 edits in trunk/LayoutTests
2010-01-08 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
http/tests/xmlhttprequest/logout.html failed on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=31412
- platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.
- 4:30 PM Changeset in webkit [53023] by
-
- 3 edits6 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=32962
HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element
Also fixed the same for STYLE elements.
Tests: fast/dom/css-innerHTML.html
fast/dom/script-innerHTML-x.xhtml
fast/dom/script-innerHTML.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML, matching Firefox.
- 4:20 PM Changeset in webkit [53022] by
-
- 3 edits in trunk/WebKit/win
Build fix, no review.
Protect video control logic inside ENABLE(VIDEO).
- WebView.cpp:
(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):
- WebView.h:
- 4:05 PM Changeset in webkit [53021] by
-
- 2 edits in trunk/LayoutTests
Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33396
- storage/open-database-while-transaction-in-progress.html:
- 3:59 PM Changeset in webkit [53020] by
-
- 2 edits in trunk/BugsSite
Included UNCONFIRMED bugs by default in advanced search query
Rubber-stamped by Alexey Proskuryakov.
- data/params: Prepended 'bug_status=UNCONFIRMED&' to
'defaultquery' parameter.
- 3:53 PM Changeset in webkit [53019] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33279
fast/websockets/websocket-event-target.html causes any test after it to fail
- fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server URL to create a WebSocket, so an error may be logged to console when detected (this is timing dependent).
- platform/mac/Skipped: Removed the test from Skipped list.
- 3:52 PM Changeset in webkit [53018] by
-
- 3 edits in trunk/WebKitTools
2010-01-08 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-javascriptcore-tests needs a --quiet flag
https://bugs.webkit.org/show_bug.cgi?id=33399
Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
- Scripts/webkitpy/steps/runtests.py:
- 3:35 PM Changeset in webkit [53017] by
-
- 9 edits8 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>
Reviewed by Oliver Hunt.
Inflate the repaintRect for the shadow using its extent.
- rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::computeRectForRepaint):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
- rendering/SVGRenderSupport.cpp:
(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):
- rendering/SVGRenderSupport.h:
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>
Reviewed by Oliver Hunt.
- fast/repaint/moving-shadow-on-container.html: Added.
- fast/repaint/moving-shadow-on-path.html: Added.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
- platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.
- 3:27 PM Changeset in webkit [53016] by
-
- 2 edits in trunk/BugsSite
FIX: Make patch status appear on reviewform.html.tmpl
- template/en/custom/attachment/reviewform.html.tmpl: Check
attachment.ispatch (not just ispatch) when deciding whether
to display patch status. Also update layout a bit.
- 3:22 PM Changeset in webkit [53015] by
-
- 2 edits in trunk/WebKitTools
Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.
To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.
- Scripts/run-webkit-tests:
- 3:22 PM Changeset in webkit [53014] by
-
- 2 edits in trunk/BugsSite
Update data/params parameters
- data/params: Updated 'timezone' to turn off DST. Updated
'usebugaliases' and 'usevotes' to turn them off.
- 3:01 PM Changeset in webkit [53013] by
-
- 2 edits in trunk/WebKitTools
2010-01-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't post style-queue pass messages to bugs
https://bugs.webkit.org/show_bug.cgi?id=33404
These messages aren't needed any more now that we have the status
bubble reporting pass events passively.
- Scripts/webkitpy/commands/queues.py:
- 2:51 PM Changeset in webkit [53012] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32294
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
problem with kerning.
- http/tests/uri/escaped-entity-expected.txt:
- http/tests/uri/escaped-entity.html:
- platform/mac/Skipped:
- 2:45 PM Changeset in webkit [53011] by
-
- 4 edits in trunk/WebKitTools
2010-01-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Optimize the number of CPUs used for building Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=33394
Instead of hardcoding the number 8, we should read the number of CPUs
from the environment.
- Scripts/webkitpy/executive.py:
- Scripts/webkitpy/webkitport.py:
- Scripts/webkitpy/webkitport_unittest.py:
- 2:31 PM Changeset in webkit [53010] by
-
- 15 edits in trunk/LayoutTests
2010-01-08 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
New baselines to reflect the smaller repaint areas caused by r52839
https://bugs.webkit.org/show_bug.cgi?id=33271
- platform/mac/fast/repaint/background-misaligned-expected.checksum:
- platform/mac/fast/repaint/background-misaligned-expected.png:
- platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
- platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
- platform/mac/fast/repaint/float-new-in-block-expected.checksum:
- platform/mac/fast/repaint/float-new-in-block-expected.png:
- platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
- platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
- platform/mac/fast/repaint/selected-replaced-expected.checksum:
- platform/mac/fast/repaint/selected-replaced-expected.png:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
- 2:29 PM Changeset in webkit [53009] by
-
- 6 edits2 adds in trunk
2010-01-08 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350
- fast/canvas/webgl/array-setters-expected.txt: Added.
- fast/canvas/webgl/array-setters.html: Added.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
2010-01-08 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350
Test: fast/canvas/webgl/array-setters.html
- bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
- bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
- 2:05 PM Changeset in webkit [53008] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-08 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Remove unnecessary #include from FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=33393
- wtf/FastMalloc.cpp:
- 2:05 PM Changeset in webkit [53007] by
-
- 4 edits in trunk/BugsSite
2010-01-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Show patch status in bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=33368
This patch adds an iframe to the show_bug page and the edit attachment
page that displays whether the attachment passed the various bots.
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 1:49 PM Changeset in webkit [53006] by
-
- 2 edits in trunk/LayoutTests
2010-01-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
transitions/cancel-transition.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33398
There's a race between the check() call and the final
setTimeout. Just remove the final setTimeout and put
its contents in the check call itself.
- transitions/cancel-transition.html:
- 1:48 PM Changeset in webkit [53005] by
-
- 8 edits2 moves in trunk
2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826
Factory related code removed from QtAbstractWebPopup. Popups are now created
by ChromeClientQt.
Popup content information struct added to class QtAbstractWebPopup.
PopupMenuClient is now hidden from higher layers.
QtAbstractWebPopup now receives content information and font as parameters
of method populate.
QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.
- WebCore.pro:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::getItems): (WebCore::PopupMenu::show):
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::popupDidHide): (WebCore::QtAbstractWebPopup::valueChanged):
- platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::Item::):
- platform/qt/QtFallbackWebPopup.cpp: Removed.
- platform/qt/QtFallbackWebPopup.h: Removed.
2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826
Added method createPopup to ChromeClientQt used to create popups.
QtFallbackWebPopup moved from WebCore/platform/qt to
WebKit/qt/WebCoreSupport.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createPopup):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::setParent):
- WebCoreSupport/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
- 1:31 PM Changeset in webkit [53004] by
-
- 3 edits2 adds in trunk
2010-01-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619
This patch makes the CSS parser skip property declarations containing invalid blocks.
- fast/css/parsing-error-recovery-expected.txt: Added.
- fast/css/parsing-error-recovery.html: Added.
2010-01-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619
This patch makes the CSS parser skip property declarations containing invalid blocks.
Test: fast/css/parsing-error-recovery.html
- css/CSSGrammar.y:
- 1:11 PM Changeset in webkit [53003] by
-
- 8 edits in trunk/LayoutTests
Fixed media test failures caused by http://trac.webkit.org/changeset/52998.
The media controller on Windows now has a full-screen button, which changes
the layout and therefore the test results. I regenerated them for
Windows.
- 1:07 PM Changeset in webkit [53002] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.
- platform/win/Skipped:
- 12:49 PM Changeset in webkit [53001] by
-
- 3 edits3 adds in trunk/WebKit/chromium
2010-01-08 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Upstream webkit unit tests from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=33351
This adds one such test (for KURL) and sets up the test framework.
Switch WebKit to build a static library on all platforms. Add a
webkit_unit_tests executable target that runs the unit tests and also
ensures that we don't have any missing symbols (a function that WebKit
as a shared library used to serve).
Changes chromium_src_dir to ../../WebKit/chromium to match how
WebCore.gyp defines that variable.
- WebKit.gyp:
- public/WebKitClient.h: (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon. (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon. (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
- tests: Added.
- tests/KURLTest.cpp: Added.
- tests/WebKitTest.h: Added.
- 12:31 PM Changeset in webkit [53000] by
-
- 3 edits2 adds in trunk
AX: CSS content not returned correctly in AX
https://bugs.webkit.org/show_bug.cgi?id=33308
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/css-content-attribute.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
LayoutTests:
- platform/mac/accessibility/css-content-attribute-expected.txt: Added.
- platform/mac/accessibility/css-content-attribute.html: Added.
- 11:58 AM Changeset in webkit [52999] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
transitions/shorthand-border-transitions.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33276
Yet another transitions test that doesn't give consistent
wiggle room. Make all the wiggle rooms account for >=200ms
instead of some that were only giving 100ms wiggle room.
- transitions/shorthand-border-transitions.html:
- 11:23 AM Changeset in webkit [52998] by
-
- 17 edits2 adds in trunk
Implement full-screen video for Windows
https://bugs.webkit.org/show_bug.cgi?id=31318
- 10:55 AM Changeset in webkit [52997] by
-
- 2 edits in trunk/WebKit/win
Unreviewed correction.
Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.
- WebFrame.cpp:
(hdcFromContext): Back out unneeded modification.
- 10:54 AM Changeset in webkit [52996] by
-
- 2 edits in trunk/WebCore
2010-01-08 Matt Perry <mpcomplete@chromium.org>
Reviewed by Adam Barth.
Fix a regression that removed a call to
FrameLoaderClient::didDestroyScriptContextForFrame.
https://bugs.webkit.org/show_bug.cgi?id=33347
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
- 10:16 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:30 AM Changeset in webkit [52995] by
-
- 5 edits in trunk
WebCore: WebKit plugins are not rendered during printing.
https://bugs.webkit.org/show_bug.cgi?id=33022.
Reviewed by Adam Roben.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Tell
cairo printing surface to flush so that blank regions do
not write over the plugin's paint operations.
- rendering/RenderLayer.cpp: Build fix.
(WebCore::RenderLayer::beginTransparencyLayers): Correct
method signature missing for ColorSpace.
WebKit/win: Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.
Reviewed by Adam Roben.
- WebFrame.cpp:
(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for
margin size in region passed to header/footer routines.
(WebFrame::spoolPages): Properly clean up Cairo surface.
- 9:24 AM Changeset in webkit [52994] by
-
- 7 edits in trunk
REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300
Reviewed by Eric Seidel.
WebCore:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
LayoutTests:
- platform/mac/Skipped:
- 6:27 AM Changeset in webkit [52993] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)
- 6:22 AM Changeset in webkit [52992] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
r52976 revealed this failure by re-ordering tests.
I do not have a Snow Leopard build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33372
- platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.
- 5:26 AM Changeset in webkit [52991] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.
- platform/win/Skipped:
- 5:08 AM Changeset in webkit [52990] by
-
- 2 edits in trunk/LayoutTests
r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.
Reviewed by Eric Seidel.
I do not have a windows build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33374
- platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.
- 4:59 AM Changeset in webkit [52989] by
-
- 3 edits in trunk/WebKitTools
2010-01-08 Eric Seidel <eric@webkit.org>
Reviewed by Simon Hausmann.
commit-queue should run run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=33376
I also made it run the python and perl unit tests.
- Scripts/webkitpy/steps/runtests.py:
- Scripts/webkitpy/webkitport.py:
- 4:46 AM Changeset in webkit [52988] by
-
- 2 edits in trunk/LayoutTests
2010-01-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814
We are going to skip all the storage tests until we find the issue
with the threading system in the gtk port.
- platform/gtk/Skipped:
- 4:09 AM Changeset in webkit [52987] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-08 Eric Seidel <eric@webkit.org>
No review, rolling out r52983.
http://trac.webkit.org/changeset/52983
https://bugs.webkit.org/show_bug.cgi?id=33321
Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp):
- runtime/RegExp.h: (JSC::RegExp::flags):
- 3:54 AM Changeset in webkit [52986] by
-
- 2 edits in trunk/WebKit/gtk
2010-01-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
[GTK] loading test should use SoupServer instead of actual sites
https://bugs.webkit.org/show_bug.cgi?id=33353
Make all the loading tests use SoupServer, instead of fetching
stuff from the Internet.
- tests/testloading.c: (server_callback): (get_uri_for_path): (test_loading_status): (test_loading_error): (test_loading_cancelled): (load_wentback_status_changed_cb): (load_error_test): (test_loading_goback): (main):
- 3:50 AM Changeset in webkit [52985] by
-
- 6 edits2 adds1 delete in trunk/WebCore
2010-01-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Regex-based syntax highlighting is slow.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
- inspector/front-end/JavaScriptTokenizer.js: Added. (WebInspector.JavaScriptTokenizer): (WebInspector.JavaScriptTokenizer.prototype.set line): (WebInspector.JavaScriptTokenizer.prototype.getCondition): (WebInspector.JavaScriptTokenizer.prototype.setCondition): (WebInspector.JavaScriptTokenizer.prototype._charAt): (WebInspector.JavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/JavaScriptTokenizer.re2js: Added.
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:44 AM Changeset in webkit [52984] by
-
- 8 edits in trunk
2010-01-08 Eric Seidel <eric@webkit.org>
No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319
Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
2010-01-08 Eric Seidel <eric@webkit.org>
No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319
Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js
- fast/js/kde/RegExp-expected.txt:
- fast/js/kde/script-tests/RegExp.js:
- fast/js/regexp-compile-expected.txt:
- fast/js/script-tests/regexp-compile.js:
- fast/regex/non-pattern-characters-expected.txt:
- 3:32 AM Changeset in webkit [52983] by
-
- 3 edits in trunk/JavaScriptCore
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321
It's unused; the string representation is reconstructed from flags.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp):
- runtime/RegExp.h:
- 3:23 AM Changeset in webkit [52982] by
-
- 2 edits in trunk/LayoutTests
2010-01-08 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339
- platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.
- 3:17 AM Changeset in webkit [52981] by
-
- 8 edits in trunk
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
Add new test cases and adapt existing ones.
- fast/js/kde/RegExp-expected.txt:
- fast/js/kde/script-tests/RegExp.js:
- fast/js/script-tests/regexp-compile.js:
- fast/regex/non-pattern-characters-expected.txt:
- 2:22 AM Changeset in webkit [52980] by
-
- 3 edits in trunk/LayoutTests
2010-01-08 Eric Seidel <eric@webkit.org>
Reviewed by Simon Hausmann.
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=32294
- platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.
- 2:12 AM Changeset in webkit [52979] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Darin Fisher.
REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300
Skipping platform/mac/accessibility/aria-liveregions-notifications.html
to make the bots green until Chris Fleizach can fix the AX Notification system
to correctly unregister logging callbacks.
- platform/mac/Skipped:
- 12:51 AM Changeset in webkit [52978] by
-
- 2 edits in trunk/JavaScriptCore
RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.
Patch by Norbert Leser <norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33084
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- 12:01 AM Changeset in webkit [52977] by
-
- 3 edits in trunk/JavaScriptCore
Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203
Reviewed by Gavin Barraclough.
- assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.
(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.
Jan 7, 2010:
- 11:56 PM Changeset in webkit [52976] by
-
- 2 edits in trunk/WebKitTools
Run the http and websocket tests after all other tests.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.
- Scripts/run-webkit-tests:
- 11:41 PM Changeset in webkit [52975] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311
Reviewed by Gavin Barraclough.
Move compileGetDirectOffset function to common part of JSVALUE32
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
- 11:08 PM Changeset in webkit [52974] by
-
- 5 edits in trunk
2010-01-07 Mike Belshe <mbelshe@chromium.org>
Reviewed by Darin Adler.
Fix Spdy casing to match style guide.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasFetchedViaSPDY): (WebCore::ResourceResponse::setWasFetchedViaSPDY):
2010-01-07 Mike Belshe <mbelshe@chromium.org>
Reviewed by Darin Adler.
Fix Spdy casing to match style guide.
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSPDY): (WebKit::WebURLResponse::setWasFetchedViaSPDY):
- 10:54 PM Changeset in webkit [52973] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020
- wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support variadic macros. Refactor for better readibility.
- 10:16 PM Changeset in webkit [52972] by
-
- 14 edits in trunk
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- features.gypi:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- config.h:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- configure.ac:
- 9:54 PM Changeset in webkit [52971] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
Reviewed by Darin Adler.
As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
the zoomOrNot argument is unnecessary.
- fast/dom/elementFromPoint-relative-to-viewport.html:
- 9:47 PM Changeset in webkit [52970] by
-
- 3 edits1 add in trunk/JavaScriptCore
2010-01-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Gavin Barraclough.
[Symbian] Port ARM traditional JIT Trampolines to RVCT
https://bugs.webkit.org/show_bug.cgi?id=30552
Take the GCC implementation and mechanically convert
it to RVCT syntax.
Use 'bx rX' instead of 'mov pc, rX' when it is available.
Developed in cooperation with Iain Campbell and Gabor Loki.
- JavaScriptCore.pri: Extra step to generate RVCT stubs. The script generation intentionally executed all the time not just for RVCT targets.
- create_rvct_stubs: Added. Perl script to expand precompiler macros for RVCT assembler - the template is defined in JITStubs.cpp.
- jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
- 9:12 PM Changeset in webkit [52969] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix some test-webkitpy expectations
https://bugs.webkit.org/show_bug.cgi?id=33345
I forgot to change these when I added the CheckStyle step.
- Scripts/webkitpy/commands/upload_unittest.py:
- 8:58 PM Changeset in webkit [52968] by
-
- 3 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
https://bugs.webkit.org/show_bug.cgi?id=33341
Fix this by moving to the root directory before editing ChangeLogs.
There is a related bug with CheckStyle.
- Scripts/webkitpy/steps/checkstyle.py:
- Scripts/webkitpy/steps/editchangelog.py:
- 7:06 PM Changeset in webkit [52967] by
-
- 6 edits in trunk/WebCore
Rolled out http://trac.webkit.org/changeset/52778 due to rolling
out http://trac.webkit.org/changeset/52756
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- editing/SelectionController.cpp:
(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::attach):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
- page/Frame.cpp:
(WebCore::Frame::revealSelection):
- 6:51 PM Changeset in webkit [52966] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339
This is a speculative fix. I do not have a Snow Leopard machine to test on
and I've not seen mention of someone being able to reproduce this locally.
Prevent watchdog timer from firing after a test completes but before
the next one starts, causing the error to appear in the next test.
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): Stop the watchdog before printing #EOF for the test content. We only need to care about the JavaScript of the test running too long or some hang in WebCore. Any other failures will be covered by the calling script's own watchdog timer.
- 6:22 PM Changeset in webkit [52965] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue is stuck spinning due to exception
https://bugs.webkit.org/show_bug.cgi?id=33358
- Scripts/webkitpy/commands/queues.py:
- Don't try to stringify the exception.
- 5:56 PM Changeset in webkit [52964] by
-
- 7 edits2 deletes in trunk
Rollout http://trac.webkit.org/changeset/52756 due to a large performance regression.
WebCore:
- dom/Document.cpp:
(WebCore::Document::updateLayout):
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):
- editing/SelectionController.h:
- page/Frame.cpp:
(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):
- page/FrameView.cpp:
(WebCore::FrameView::needsLayout):
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
- fast/forms/selection-layout-reentry-strange-case.html: Removed.
- 4:57 PM Changeset in webkit [52963] by
-
- 2 edits in trunk/WebKit/mac
More build fix.
- WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).
- 4:44 PM Changeset in webkit [52962] by
-
- 4 edits in trunk
Fix a crash seen on the buildbots.
Reviewed by Sam Weinig.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.
WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.
- 4:43 PM Changeset in webkit [52961] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix.
- JavaScriptCore.exp: Export new JSGlobalData static data members.
- 4:36 PM Changeset in webkit [52960] by
-
- 12 edits9 adds in trunk
2010-01-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGTextElement & friends need to implement svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=33284
Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
childrenChanged() has to be implemented as well for SVGTextElement.
Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
and on error case, after parsing - previously the calling site had to take care of that.
Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html
svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
- svg/SVGTRefElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::childrenChanged):
- svg/SVGTextElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):
- svg/SVGTextPositioningElement.h:
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
- svg/SVGTransformable.h:
- 4:28 PM Changeset in webkit [52959] by
-
- 2 edits in trunk/JavaScriptGlue
Mac build fix.
- config.h: Define JS_EXPORTCLASS for JavaScriptGlue.
- 4:28 PM Changeset in webkit [52958] by
-
- 3 edits1 add in trunk/WebCore
Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.
Reviewed by Adele Peterson.
[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.
- manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.
- 4:24 PM Changeset in webkit [52957] by
-
- 2 edits in trunk/WebKitLibraries
Not reviewed, build fix.
Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
clients of another class). WebCore doesn't use all methods of JSString, so
we don't export all classes clients could theoretically access via JSString.
- win/tools/vsprops/common.vsprops:
- 4:15 PM Changeset in webkit [52956] by
-
- 18 edits3 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows
<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark
Test: fast/js/webcore-string-comparison.html
In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.
- config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as JS_EXPORTDATA, but it clearly needed a new name.
- runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createNonDefault): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h: Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to assert vptr correctness in object destructors (which don't have access to JSGlobalData, and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
- runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be. It's important to assert in destructor, because MSVC changes the vptr after constructor is invoked.
- runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
- runtime/JSByteArray.h: Ditto.
- runtime/JSFunction.h: Ditto.
- runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
- runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another one.
- runtime/JSString.h: Export JSString class together with its vftable, and tell other libraries tp import it. This is needed on platforms that have a separate JavaScriptCore dynamic library - and on Mac, we already did the export via JavaScriptCore.exp. (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be. (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building JavaScriptCore itself). (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static JSGlobalData members that are used in WebCore via inline functions.
- 3:51 PM Changeset in webkit [52955] by
-
- 2 edits in trunk/WebCore
Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins. This is especially important for print surface DPI.
http://bugs.webkit.org/show_bug.cgi?id=32909.
Reviewed by Jon Honeycutt.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Revise
world context handling to include scaling and translation
already set for the CTM.
- 3:44 PM Changeset in webkit [52954] by
-
- 2 edits in trunk/WebKitTools
Don't leak a JSStringRef within _accessibilityNotificationCallback.
Reviewed by Jon Honeycutt.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.
- 3:33 PM Changeset in webkit [52953] by
-
- 2 edits in trunk/WebKit/mac
2010-01-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
https://bugs.webkit.org/show_bug.cgi?id=33348
<rdar://problem/7310616>
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): We only want to handle file: URLs for the user stylesheet now, so special-case the DashboardClient's funky user stylesheet URL by mapping it to the equivalent file URL.
- 2:55 PM Changeset in webkit [52952] by
-
- 24 edits in trunk/WebCore
2010-01-07 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate V8 bindings header declarations for named and indexed accessors.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NodeListCustom.cpp:
- bindings/v8/custom/V8StorageCustom.cpp:
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- 2:36 PM Changeset in webkit [52951] by
-
- 2 edits in trunk/WebCore
Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- 2:27 PM Changeset in webkit [52950] by
-
- 2 edits in trunk/WebCore
Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- 2:13 PM Changeset in webkit [52949] by
-
- 7 edits in trunk/WebCore
2010-01-07 Simon Fraser <Simon Fraser>
Build fix.
Add RenderEmbeddedObject.h/cpp to all the build systems.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 2:07 PM Changeset in webkit [52948] by
-
- 5 edits in trunk
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343
The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::addAnonymousSlotsTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::despecifyAllFunctions):
- runtime/Structure.h: (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count for specific functions. Disable specific function tracking once the thrash count has been hit.
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function tracking for the window object, since there's no way to do direct method calls on the window object; they all go through the window shell.
- 1:57 PM Changeset in webkit [52947] by
-
- 46 edits2 copies in trunk
2010-01-07 Simon Fraser <Simon Fraser>
Reviewed by Kevin Decker, Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>
Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
Instances of RenderPartObject are now only allocated for iframes.
Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.
- WebCore.xcodeproj/project.pbxproj: Add RenderEmbeddedObject.h/cpp
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject. (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case. (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::addWidgetToUpdate): (WebCore::FrameView::removeWidgetToUpdate): (WebCore::FrameView::updateWidgets): Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
- rendering/RenderEmbeddedObject.cpp: Added.
- rendering/RenderEmbeddedObject.h: Added. Most of the code moved from RenderPartObject.
- rendering/RenderObject.h: (WebCore::RenderObject::isEmbeddedObject): New method.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
- rendering/RenderPart.h: Comments.
- rendering/RenderPartObject.h:
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code. (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
- 1:47 PM Changeset in webkit [52946] by
-
- 3 edits in trunk/WebCore
2010-01-07 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>
First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
so we don't need to call it here, and can thus remove the attach() override entirely.
- html/HTMLIFrameElement.cpp:
- html/HTMLIFrameElement.h:
- 1:36 PM Changeset in webkit [52945] by
-
- 7 edits4 adds in trunk/WebCore
2009-01-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Migrate to canvas-based text viewer / editor that scales.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptHighlighterScheme.js: Added. (WebInspector.JavaScriptHighlighterScheme):
- inspector/front-end/KeyboardShortcut.js:
- inspector/front-end/TextEditor.js: Added. (WebInspector.TextEditor): (WebInspector.TextSelectionModel): (WebInspector.TextCursor):
- inspector/front-end/TextEditorHighlighter.js: Added. (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/TextEditorModel.js: Added. (WebInspector.TextRange): (WebInspector.TextRange.prototype.clone): (WebInspector.TextEditorModel):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 1:32 PM Changeset in webkit [52944] by
-
- 5 edits3 adds in trunk
2010-01-07 Christian Sejersen <Christian Sejersen>
Reviewed by Darin Adler.
document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032
- fast/dom/Document/document-title-get-expected.txt: Added.
- fast/dom/Document/document-title-get.html: Added.
- fast/dom/Document/script-tests/document-title-get.js: Added.
2010-01-07 Christian Sejersen <Christian Sejersen>
Reviewed by Darin Adler.
document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032
Test: fast/dom/Document/document-title-get.html
- dom/Document.cpp: (WebCore::Document::Document): Initialization of m_rawTitle (WebCore::canonicalizedTitle): Moved from DocumentLoader.cpp with minor edits (WebCore::Document::updateTitle): Ensures the title is canonicalized (WebCore::Document::setTitle): Uses m_rawTitle instaed of m_title (WebCore::Document::removeTitle): Uses m_rawTitle instead of m_title
- dom/Document.h: Added m_rawTitle that stores the passed in title, m_title now stores the canonicalized title
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle): The title passed in is now canonicalized in Document.cpp
- 12:58 PM Changeset in webkit [52943] by
-
- 3 edits2 adds in trunk
2010-01-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248
For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.
- fast/css/css3-space-in-nth-and-lang.html: Added.
- platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
2010-01-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248
For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.
- css/CSSGrammar.y:
- 12:26 PM Changeset in webkit [52942] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=33331
(WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)
- Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage
- 12:24 PM Changeset in webkit [52941] by
-
- 3 edits2 adds in trunk
AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325
Reviewed by Beth Dakin.
WebCore:
Test: accessibility/contenteditable-hidden-div.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
LayoutTests:
- accessibility/contenteditable-hidden-div-expected.txt: Added.
- accessibility/contenteditable-hidden-div.html: Added.
- 12:20 PM Changeset in webkit [52940] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Skip LayoutTests/http/tests/media/video-error-abort.html
- platform/gtk/Skipped:
- 12:18 PM Changeset in webkit [52939] by
-
- 2 edits in trunk/WebKitTools
- 12:08 PM Changeset in webkit [52938] by
-
- 2 edits in trunk/WebCore
2010-01-07 Adam Barth <abarth@webkit.org>
Unreviewed. Resolve merge conflict.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
- 12:00 PM Changeset in webkit [52937] by
-
- 12 edits in trunk
2010-01-07 Adam Barth <abarth@webkit.org>
No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232
Might have caused a perf regression. I'm rolling this out to see if it
heals the perf bot.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell):
- bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
2010-01-07 Adam Barth <abarth@webkit.org>
No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232
Might have caused a perf regression.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 11:45 AM Changeset in webkit [52936] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.
- platform/mac/Skipped:
- 11:41 AM Changeset in webkit [52935] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Add executable bit to video-throttled-load cgi.
- http/tests/media/video-throttled-load.cgi: Added property svn:executable.
- 11:25 AM Changeset in webkit [52934] by
-
- 2 edits in trunk/WebKitTools
Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
- Scripts/run-webkit-tests:
- 10:48 AM Changeset in webkit [52933] by
-
- 2 edits in trunk/WebCore
Build fix
- WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
- 10:33 AM Changeset in webkit [52932] by
-
- 2 edits in trunk/WebKitTools
Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.
- Scripts/run-webkit-tests:
- 10:28 AM Changeset in webkit [52931] by
-
- 9 edits1 add in trunk/WebCore
Added Font::typesettingFeatures() and deployed it
Reviewed by Sam Weinig.
No change in funcitonality
- WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures): Added. Determines the typesetting
features from the text redndering mode.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().
- platform/graphics/SimpleFontData.h:
- platform/graphics/TypesettingFeatures.h: Added.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Take TypesettingFeatures instead of
TextRenderingMode.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use typesettingFeatures().
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes): Take
TypesettingFeatures instead of TextRenderingMode.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().
- 10:08 AM Changeset in webkit [52930] by
-
- 2 edits in trunk/WebCore
2010-01-07 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r52900.
http://trac.webkit.org/changeset/52900
https://bugs.webkit.org/show_bug.cgi?id=30055
Broke over 30 SVG pixel tests.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 9:45 AM Changeset in webkit [52929] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] The library version number of the first package release is 4.7.0.
- WebCore.pro:
- 9:36 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:31 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:29 AM Changeset in webkit [52928] by
-
- 6 edits in trunk
[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684
Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Added API to NetworkStateNotifier for forcing network status.
- platform/network/NetworkStateNotifier.h:
- platform/network/qt/NetworkStateNotifierPrivate.h:
- platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):
WebKit/qt:
Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.
- Api/qwebsettings.cpp:
(qt_networkAccessAllowed):
- 9:26 AM Changeset in webkit [52927] by
-
- 2 edits in trunk/LayoutTests
Unreviewed typo fix.
- platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html
- 9:14 AM Changeset in webkit [52926] by
-
- 2 edits in trunk/WebCore
prospective bearer management build fix to get the include path correct
- 8:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:38 AM Changeset in webkit [52925] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=33323
Skip new test on Tiger for now.
- platform/mac-tiger/Skipped:
- 8:22 AM Changeset in webkit [52924] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 8:02 AM Changeset in webkit [52923] by
-
- 4 edits2 moves in trunk
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event
rdar://6710625
Test media/video-error-abort.html doesn't work
Test: http/tests/media/video-error-abort.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent. (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization to match spec wording.
- html/HTMLMediaElement.h: Remove enqueueEvent prototype.
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event
rdar://6710625
Test media/video-error-abort.html doesn't work
- http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
- http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.
Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
progress event.
- media/video-error-abort-expected.txt: Removed.
- media/video-error-abort.html: Removed.
- 7:48 AM QtWebKitBackportingFixes edited by
- (diff)
- 6:37 AM Changeset in webkit [52922] by
-
- 9 edits in trunk
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
Touch event tests changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence): (multiTouchSequence):
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
Touch events changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchStart): (EventSender::touchEnd): (EventSender::clearTouchPoints):
- DumpRenderTree/qt/EventSenderQt.h:
- 5:43 AM Changeset in webkit [52921] by
-
- 105 edits3 deletes in trunk
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Remove COM code generation stuff.
https://bugs.webkit.org/show_bug.cgi?id=32854
Remove the followings:
- CodeGeenratorCOM.pm, COM code generator,
"#if !defined(LANGUAGE_COM) !LANGUAGE_COM" in IDL files, and - UUID attributes in IDL files.
- bindings/scripts/CodeGeneratorCOM.pm: Removed.
- css/CSSCharsetRule.idl:
- css/CSSFontFaceRule.idl:
- css/CSSImportRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPageRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSStyleSheet.idl:
- css/CSSUnknownRule.idl:
- css/CSSValue.idl:
- css/CSSValueList.idl:
- css/Counter.idl:
- css/MediaList.idl:
- css/RGBColor.idl:
- css/Rect.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframeRule.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSTransformValue.idl:
- dom/Attr.idl:
- dom/CDATASection.idl:
- dom/CharacterData.idl:
- dom/Comment.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/EntityReference.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- dom/Text.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBRElement.idl:
- html/HTMLBaseElement.idl:
- html/HTMLBaseFontElement.idl:
- html/HTMLBlockquoteElement.idl:
- html/HTMLBodyElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDListElement.idl:
- html/HTMLDirectoryElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFontElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLHRElement.idl:
- html/HTMLHeadElement.idl:
- html/HTMLHeadingElement.idl:
- html/HTMLHtmlElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLIsIndexElement.idl:
- html/HTMLLIElement.idl:
- html/HTMLLabelElement.idl:
- html/HTMLLegendElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMapElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMenuElement.idl:
- html/HTMLMetaElement.idl:
- html/HTMLModElement.idl:
- html/HTMLOListElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptGroupElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLParagraphElement.idl:
- html/HTMLParamElement.idl:
- html/HTMLPreElement.idl:
- html/HTMLQuoteElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLStyleElement.idl:
- html/HTMLTableCaptionElement.idl:
- html/HTMLTableCellElement.idl:
- html/HTMLTableColElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/HTMLUListElement.idl:
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Remove COM code generation files.
https://bugs.webkit.org/show_bug.cgi?id=32854
- WebKit.vcproj/DerivedSources.make: Removed.
- WebKit.vcproj/build-generated-files.sh: Removed.
- 5:15 AM Changeset in webkit [52920] by
-
- 1 edit in trunk/JavaScriptCore/jit/JIT.cpp
Unreviewed build fix for Qt on Mac OS X
- 4:16 AM Changeset in webkit [52919] by
-
- 3 edits in trunk/WebCore
Android requires ability to increase layout delay
- 4:13 AM Changeset in webkit [52918] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
- 4:12 AM Changeset in webkit [52917] by
-
- 2 edits in trunk/WebKitTools
Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.
- Scripts/run-webkit-tests:
- 3:50 AM Changeset in webkit [52916] by
-
- 2 edits1 add in trunk/WebKitTools
2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Adam Barth.
Created a module that runs the style package unit tests.
- Scripts/test-webkitpy:
- Scripts/webkitpy/style/unittests.py: Added.
- 3:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:40 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:35 AM Changeset in webkit [52915] by
-
- 4 edits in trunk/WebCore
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Some IDL files lack "," separators for extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=33190
To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.
- bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
- css/WebKitCSSTransformValue.idl: Add missing ",".
- dom/EventTarget.idl: ditto.
- 3:29 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:26 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:24 AM Changeset in webkit [52914] by
-
- 2 edits in trunk/WebKit/qt
[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673
Patch by Yongjun Zhang <yongjun.zhang@nokia.com>, Laszlo Gombos <Laszlo Gombos> on 2010-01-07
Reviewed by Simon Hausmann.
Add suspend and resume DOM objects private API to QWebFrame.
- Api/qwebframe.cpp:
(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):
- 2:52 AM Changeset in webkit [52913] by
-
- 2 edits in trunk/WebCore
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
https://bugs.webkit.org/show_bug.cgi?id=33193
CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.
- bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.
- 2:22 AM Changeset in webkit [52912] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Don't print a redundant message when confirming a diff
https://bugs.webkit.org/show_bug.cgi?id=33315
Instead of saying "ERROR: User declined" we should just exit because
the use knows they just declined!
- Scripts/webkitpy/steps/confirmdiff.py:
- 2:19 AM Changeset in webkit [52911] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
- 2:12 AM Changeset in webkit [52910] by
-
- 4 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Check style before uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=33314
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/steps/checkstyle.py:
- Scripts/webkitpy/steps/options.py:
- 1:51 AM Changeset in webkit [52909] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Add prepare and post to webkit-patch main help
https://bugs.webkit.org/show_bug.cgi?id=33313
- Scripts/webkitpy/commands/upload.py:
- 12:57 AM Changeset in webkit [52908] by
-
- 3 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33290
Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/buildbot_unittest.py:
- 12:49 AM Changeset in webkit [52907] by
-
- 13 edits1 move in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool needs a new name
https://bugs.webkit.org/show_bug.cgi?id=28459
Rename bugzilla-tool to webkit-patch. Also, rename some commands to
make more sense with the new name.
- Scripts/bugzilla-tool: Removed.
- Scripts/webkit-patch: Added.
- Scripts/webkit-tools-completion.sh:
- Scripts/webkitpy/bugzilla_unittest.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/steps/completerollout.py:
- 12:36 AM Changeset in webkit [52906] by
-
- 3 edits6 moves1 add in trunk/WebKitTools
2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Moved style-related modules to webkitpy.style sub-package.
- Scripts/check-webkit-style:
- Updated import statement.
- Scripts/test-webkitpy:
- Updated import statements.
- Scripts/webkitpy/cpp_style.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/cpp_style_unittest.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/style.py: Removed.
- Moved to webkitpy/style/checker.py.
- Scripts/webkitpy/style/init.py: Added.
- Added containing webkitpy directory to package search path.
- Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
- Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
- Updated import statement.
- Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
- Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
- Update import statement.
- Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
- Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
- Scripts/webkitpy/style_unittest.py: Removed.
- Moved to webkitpy/style/checker_unittest.py.
- Scripts/webkitpy/text_style.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/text_style_unittest.py: Removed.
- Moved to webkitpy/style.
- 12:22 AM Changeset in webkit [52905] by
-
- 2 edits in trunk/WebCore
2010-01-07 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not return strings whose handles are in near death state (that means
they might be GCed) or just empty.
https://bugs.webkit.org/show_bug.cgi?id=31180
- bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
- 12:06 AM Changeset in webkit [52904] by
-
- 18 edits4 adds in trunk
2010-01-06 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069
Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.
- svg/text/selection-background-color.xhtml: Added.
- platform/mac/svg/text/selection-background-color-expected.checksum: Added.
- platform/mac/svg/text/selection-background-color-expected.png: Added.
- platform/mac/svg/text/selection-background-color-expected.txt: Added.
- platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
- platform/mac/svg/batik/text/textDecoration2-expected.checksum:
- platform/mac/svg/batik/text/textDecoration2-expected.png:
- platform/mac/svg/text/text-deco-01-b-expected.checksum:
- platform/mac/svg/text/text-deco-01-b-expected.png:
- platform/mac/svg/text/text-spacing-01-b-expected.checksum:
- platform/mac/svg/text/text-spacing-01-b-expected.png:
- platform/mac/svg/text/text-text-03-b-expected.checksum:
- platform/mac/svg/text/text-text-03-b-expected.png:
- platform/mac/svg/text/text-text-08-b-expected.checksum:
- platform/mac/svg/text/text-text-08-b-expected.png: Re-baselined due to painting algorithm change.
2010-01-06 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069
Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.
Test: svg/text/selection-background-color.xhtml
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Added m_setupBackgroundCallback, m_setupForegroundCallback (WebCore::SVGTextChunkWalker::setupBackground): (WebCore::SVGTextChunkWalker::setupForeground): Added.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): pass SVGTextPaintInfo instead of SVGPaintServer
- rendering/SVGInlineTextBox.h: (WebCore::SVGTextPaintSubphase): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): Added.
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::walkTextChunks): Invoke setupBackground() and setupForeground() (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): Added. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint):
Jan 6, 2010:
- 11:07 PM Changeset in webkit [52903] by
-
- 2 edits in trunk/WebKit/qt
2010-01-06 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- 10:12 PM Changeset in webkit [52902] by
-
- 7 edits in trunk
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Remove fast/events/keydown-numpad-key.html from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=33250
- platform/qt/Skipped:
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Make windowsKeyCodeForKeyEvent() return correct key code for
numeric-pad arrow keys.
https://bugs.webkit.org/show_bug.cgi?id=33250
Test: fast/events/keydown-numpad-keys.html
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
[Qt] Support the 3rd argument of EventSender.keyDown that
has been recently added to report keyLocation
(see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
https://bugs.webkit.org/show_bug.cgi?id=33250
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
- DumpRenderTree/qt/EventSenderQt.h:
- 10:00 PM Changeset in webkit [52901] by
-
- 3 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add long_help for all common commands.
https://bugs.webkit.org/show_bug.cgi?id=33261
For now these long_helps are pretty basic.
These were all written to just explain the steps
that each command runs. This style long_help could
be made easier by using:
https://bugs.webkit.org/show_bug.cgi?id=33257
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/queries.py:
- 9:30 PM Changeset in webkit [52900] by
-
- 2 edits in trunk/WebCore
2009-10-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Dirk Schulze.
Improve DOM performance in large SVG files.
Check the dirty area before painting a path, which prevents unnecessary
clipping and changes to the GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=30055
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 8:45 PM Changeset in webkit [52899] by
-
- 3 edits in trunk/WebCore
2010-01-06 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Use a static HashMap for HTMLElement::tagPriority().
https://bugs.webkit.org/show_bug.cgi?id=33269
The prior code compares AtomicStringImpl pointers 18 times at
worst. This change avoids it.
No new tests because this is just a refactoring.
- html/HTMLElement.cpp: (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value. (WebCore::initializeTagPriorityMap): Initialization of a static HashMap. (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
- html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().
- 8:06 PM Changeset in webkit [52898] by
-
- 5 edits in trunk
2010-01-06 Mike Belshe <mike@belshe.com>
Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaSpdy): (WebCore::ResourceResponse::setWasFetchedViaSpdy):
2010-01-06 Mike Belshe <mike@belshe.com>
Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSpdy): (WebKit::WebURLResponse::setWasFetchedViaSpdy):
- 8:01 PM Changeset in webkit [52897] by
-
- 5 edits in trunk
[Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898
Patch by Kim Grönholm <kim.gronholm@nomovok.com>,
Diego Gonzalez <diego.gonzalez@openbossa.org> and
Afonso Costa <afonso.costa@openbossa.org> on 2010-01-06
Reviewed by Kenneth Christiansen.
WebKitTools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::zoomPageIn):
(EventSender::zoomPageOut):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt/Skipped:
- 7:37 PM Changeset in webkit [52896] by
-
- 5 edits in trunk
2010-01-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
[Qt] RenderTheme: Missing support for native sliders
Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.
- platform/qt/Skipped:
2010-01-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
[Qt] RenderTheme: Missing support for native sliders
Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::adjustSliderThumbStyle): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::adjustSliderThumbSize):
- platform/qt/RenderThemeQt.h:
- 7:23 PM Changeset in webkit [52895] by
-
- 2 edits in trunk/WebCore
2010-01-06 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Darin Adler.
Adjust incorrect comments after r40534.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext):
- 6:57 PM Changeset in webkit [52894] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::WebSocketEnabled):
- 6:45 PM Changeset in webkit [52893] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
remove wrong assertion
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
- 6:33 PM Changeset in webkit [52892] by
-
- 20 edits2 copies9 adds in trunk
2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin
Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214
- websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
- websocket/tests/workers/resources/worker-simple.js: Added.
- websocket/tests/workers/worker-simple-expected.txt: Added.
- websocket/tests/workers/worker-simple.html: Added.
2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214
Introduce ThreadableWebSocketChannel interface and add
WorkerThreadableWebSocketChannel for Worker.
WorkerThreadableWebSocketChannel uses WebSocketChannel in the
main thread, which is managed by Peer and communicated via Bridge.
Test: websocket/tests/workers/worker-simple.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebSocketConstructor.h:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::webSocket):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
- bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8Custom::v8WebSocketConstructorCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- platform/CrossThreadCopier.cpp: (WebCore::::copy):
- platform/CrossThreadCopier.h: (WebCore::):
- websockets/ThreadableWebSocketChannel.cpp: Added.
- websockets/ThreadableWebSocketChannel.h: Added.
- websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect): (WebCore::WebSocket::didReceiveMessage):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.h: (WebCore::WebSocketChannel::refThreadableWebSocketChannel): (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
- websockets/WebSocketChannelClient.h:
- websockets/WebSocketHandshake.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: Added.
- websockets/WorkerThreadableWebSocketChannel.h: Added.
- workers/WorkerContext.idl:
- 6:20 PM Changeset in webkit [52891] by
-
- 7 edits in trunk
2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Darin Adler.
Modified EventSource event-stream parser to support a single CR as line ending.
Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33207
- http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
- http/tests/eventsource/eventsource-parse-event-stream.html:
- http/tests/eventsource/resources/event-stream.php:
2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Darin Adler.
Modified EventSource event-stream parser to support a single CR as line ending.
https://bugs.webkit.org/show_bug.cgi?id=33207
- page/EventSource.cpp: (WebCore::EventSource::EventSource): (WebCore::EventSource::parseEventStream):
- page/EventSource.h:
- 6:05 PM Changeset in webkit [52890] by
-
- 5 edits in trunk
2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): (getPangoLayoutForAtk): (webkit_accessible_text_get_text):
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
- tests/testatk.c (test_webkit_atk_get_text_at_offset): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset_newlines):
- 6:04 PM QtWebKitBackportingFixes edited by
- (diff)
- 5:41 PM Changeset in webkit [52889] by
-
- 3 edits4 adds in trunk
<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
https://bugs.webkit.org/show_bug.cgi?id=32794
Reviewed by Sam Weinig.
WebCore:
Test: platform/mac/fast/text/line-breaking-with-kerning.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.
LayoutTests:
- platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
- platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
- platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
- platform/mac/fast/text/line-breaking-with-kerning.html: Added.
- 5:33 PM Changeset in webkit [52888] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Eric Seidel <eric@webkit.org>
No review.
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html
- platform/mac/Skipped:
- 5:29 PM Changeset in webkit [52887] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
Third step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.
- 5:14 PM Changeset in webkit [52886] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
No review, just adding Mike Belshe's new bugzilla email at his request.
- Scripts/webkitpy/committers.py:
- 5:01 PM Changeset in webkit [52885] by
-
- 9 edits in trunk
Reviewed by Simon Fraser
Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
- Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added. Reviewed by Simon Fraser.
Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
- Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added.
- 4:50 PM Changeset in webkit [52884] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix screwed up ChangeLog about screwing up... Sigh.
- 4:48 PM Changeset in webkit [52883] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Eric Seidel <eric@webkit.org>
No review.
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html
- platform/mac/Skipped:
- 4:47 PM Changeset in webkit [52882] by
-
- 6 edits in trunk/WebCore
2010-01-06 Adam Barth <abarth@webkit.org>
No review, rolling out r52877.
http://trac.webkit.org/changeset/52877
https://bugs.webkit.org/show_bug.cgi?id=33243
I screwedd up landing this patch and only partially applied the patch I
was trying to land.
- bindings/ScriptControllerBase.cpp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::evaluateInWorld):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
- 4:30 PM Changeset in webkit [52881] by
-
- 3 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Carlson.
media/video-seeking.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33273
Removed setTimeouts from this test. It kind of looks
like they were intentional, but I don't see how they add
anything to this test (other than race conditions).
- media/video-seeking-expected.txt:
- media/video-seeking.html:
- 4:26 PM Changeset in webkit [52880] by
-
- 2 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed. Rolling back in a change I should not have rolled out.
The original commit http://trac.webkit.org/changeset/52862
was rolled out again in http://trac.webkit.org/changeset/52871
but I now believe that rollout to be in error.
My sincerest apologies for the churn.
Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 4:24 PM Changeset in webkit [52879] by
-
- 3 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33270
These both rely on setTimeouts where they should be using events.
- fast/css/transition-color-unspecified.html:
- fast/dom/HTMLObjectElement/object-as-frame.html:
- 4:21 PM Changeset in webkit [52878] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
platform/chromium/fast/dom/interval.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33274
We're seeing the debug bots take >100000 microseconds to stop
and Interval.
- platform/chromium/fast/dom/interval.html:
- 4:16 PM Changeset in webkit [52877] by
-
- 6 edits in trunk/WebCore
2010-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[v8] Let ScriptController have more than one windowShell
https://bugs.webkit.org/show_bug.cgi?id=33243
This patch lets ScriptController have more than one windowShell. We're
currently only using one of them (for the main world), but this patch
lets us use other ones for isolated worlds soon.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.cpp:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createWorld): (WebCore::ScriptController::initScript): (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::globalObject): (WebCore::ScriptController::proxy):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- 3:56 PM Changeset in webkit [52876] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed. Rolling out r52869 and r52853 due to bot
and local run-webkit-test failures
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
- Scripts/run-webkit-tests:
- 3:20 PM Changeset in webkit [52875] by
-
- 5 edits in trunk
Fix the Mac build.
- WebCore.base.exp: Export symbols WebKit would like to use.
- plugins/PluginWidget.h:
(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.
- 3:09 PM Changeset in webkit [52874] by
-
- 2 edits in trunk/WebKit/mac
Attempt to fix non-Snow Leopard Mac build.
- WebCoreSupport/WebFrameLoaderClient.mm:
- 2:25 PM Changeset in webkit [52873] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed "build" fix. Just adding missing include.
bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212
- Scripts/webkitpy/steps/completerollout.py:
- 2:23 PM Changeset in webkit [52872] by
-
- 5 edits2 adds in trunk
Reviewed by Eric Carlson.
First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
Small refactoring moving the PluginWidget class from WebKit to WebCore.
- WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
- platform/Widget.h: Added isPluginWidget(). (WebCore::Widget::isPluginWidget):
- plugins/PluginWidget.h: Added. (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
- plugins/mac/PluginWidgetMac.mm: Added. (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget
Reviewed by Eric Carlson.
First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
Small refactoring moving the PluginWidget class from WebKit to WebCore.
- WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.
- 2:20 PM Changeset in webkit [52871] by
-
- 2 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
No review, rolling out r52862.
http://trac.webkit.org/changeset/52862
https://bugs.webkit.org/show_bug.cgi?id=33258
Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
Leopard Release builder.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 2:14 PM Changeset in webkit [52870] by
-
- 4 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212
- Scripts/webkitpy/bugzilla.py:
- Make reopen_bug robust against the bug already being open.
- Scripts/webkitpy/commands/download.py:
- Remove dead code from Rollout.
- Scripts/webkitpy/steps/completerollout.py:
- Improve the rollout comment.
- 2:12 PM Changeset in webkit [52869] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Set isHttpdOpen to 0 if pidfile does not exist for some reason.
Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
- Scripts/run-webkit-tests:
- 2:04 PM Changeset in webkit [52868] by
-
- 2 edits in trunk/WebCore
2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.
- Configurations/Base.xcconfig:
- 2:02 PM WebKit Team edited by
- (diff)
- 1:37 PM Changeset in webkit [52867] by
-
- 12 edits1 delete in trunk/WebCore
2010-01-05 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate header declarations for V8 binding security checks
and delete V8CustomBinding.cpp
- Android.v8bindings.mk: Removed V8CustomBinding.cpp.
- WebCore.gypi: Removed V8CustomBinding.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp. (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp. (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8CustomBinding.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter): (WebCore::V8DOMWindow::namedSecurityCheck): (WebCore::V8DOMWindow::indexedSecurityCheck):
- bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorSetter):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::indexedSecurityCheck): (WebCore::V8History::namedSecurityCheck):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::indexedSecurityCheck): (WebCore::V8Location::namedSecurityCheck):
- 1:26 PM Changeset in webkit [52866] by
-
- 42 edits15 adds in trunk
2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012
Rewrite marker code, as it had many issues:
- Correct refX/refY handling (covered by new marker-referencePoint.svg test)
- Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
- Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
- Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)
Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.
Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg
svg/custom/marker-opacity.svg
svg/custom/marker-strokeWidth-changes.svg
- Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
- rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
- rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
- rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
- rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
- rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
- rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
- rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
- rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
- svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes. (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
- svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below. (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
- svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
- svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
- 1:10 PM Changeset in webkit [52865] by
-
- 26 edits in trunk
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
This implements the SVG Filter effect feImage with support of fragment urls.
It also includes a bug fix for feComposite. feComposite didn't cover values
bigger than 255 correctly on composite oeprator arithmetic.
Tests: There are already many feImage tests in trunk. They just needed updated
pixel test results.
The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
and depends on feImage.
- platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGImage.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
- svg/SVGPreserveAspectRatio.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create): (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
The implementation of feImage requires pixel test result updates of the already
available tests.
There is also an update for svg/filters/feComposite.svg, since the patch also
fixed a bug in feComposite.
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/mac/svg/custom/feDisplacementMap-01-expected.png:
- platform/mac/svg/filters/feComposite-expected.checksum:
- platform/mac/svg/filters/feComposite-expected.png:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
Update SVG status page. We support feDisplacementMap and feImage now.
- projects/svg/status.xml:
- 12:26 PM Changeset in webkit [52864] by
-
- 1 edit1 add in trunk/LayoutTests
Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295
- platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
- 12:24 PM Changeset in webkit [52863] by
-
- 5 edits in trunk/LayoutTests
Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239
Reviewed by Eric Seidel.
- fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use
a standard test wrapper instead of a custom one.
- fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:
Changed test to not depend on a non-standard wrapper.
- fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated
results since I changed the test around.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix
incorrect path in template that broke the test when we called
make-script-test-wrappers.
- 12:15 PM Changeset in webkit [52862] by
-
- 2 edits in trunk/WebCore
2010-01-06 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 11:59 AM Changeset in webkit [52861] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Should be last part of Windows Build fix.
- 11:58 AM Changeset in webkit [52860] by
-
- 5 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
No review, rolling out r52855.
http://trac.webkit.org/changeset/52855
https://bugs.webkit.org/show_bug.cgi?id=33222
Caused 6 layout tests to fail on Mac
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h:
- 11:51 AM Changeset in webkit [52859] by
-
- 2 edits in trunk/JavaScriptCore
QT build fix.
- runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):
- 11:45 AM Changeset in webkit [52858] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix part I.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:38 AM Changeset in webkit [52857] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):
- 11:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 11:33 AM Changeset in webkit [52856] by
-
- 20 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString
Reviewed by Sam Weinig.
Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table. By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- change the API shims to track the identifierTable of the current JSGlobalData.
- API/JSContextRef.cpp:
(JSContextGroupCreate):
- update creation of JSGlobalData for API usage to use new create method.
- fix shim instanciation bug in JSGlobalContextCreateInGroup.
- JavaScriptCore.exp:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- add asserts to check the identifierTable is being tracked correctly.
- runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):
- Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
- Define methods to access the thread specific identifier tables.
- runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
- Declare methods to access the thread specific identifier tables.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
- creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.
- runtime/JSGlobalData.h:
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):
- destroy() method should be using isIdentifier().
- runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
- replace m_identifierTable with a single m_isIdentifier bit.
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.
JavaScriptGlue:
Add API shims similar to those used in the JSC API to track the current identifierTable.
- JSBase.cpp:
(JSBase::Release):
- JSUtils.cpp:
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
- JSUtils.h:
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
- JavaScriptGlue.cpp:
(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
- JavaScriptGlue.xcodeproj/project.pbxproj:
- UserObjectImp.cpp:
(UserObjectImp::callAsFunction):
- 10:25 AM Changeset in webkit [52855] by
-
- 5 edits in trunk/WebCore
2010-01-06 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Let ReourceLoader deliver segmented data
when loading resource from a SharedBuffer object.
https://bugs.webkit.org/show_bug.cgi?id=33222
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
- loader/ResourceLoader.h:
- 3:14 AM Changeset in webkit [52854] by
-
- 2 edits in trunk/WebCore
Unreviewed trivial Qt build fix.
Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- 2:02 AM Changeset in webkit [52853] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
and remove the httpd's pidfile directory if httpd terminated.
- Scripts/run-webkit-tests:
- 12:24 AM Changeset in webkit [52852] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-06 Darin Fisher <darin@chromium.org>
Fix release build bustage.
- src/WebKit.cpp: Need to include Logging.h
Jan 5, 2010:
- 11:56 PM Changeset in webkit [52851] by
-
- 7 edits2 adds in trunk/WebKit/chromium
2010-01-05 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
[Chromium] Expose more APIs to eliminate WebCore usage in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=33249
- WebKit.gyp:
- public/WebFrame.h:
- public/WebGlyphCache.h: Added.
- public/WebKit.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrame::instanceCount): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
- src/WebFrameImpl.h:
- src/WebGlyphCache.cpp: Added. (WebKit::WebGlyphCache::pageCount):
- src/WebKit.cpp: (WebKit::enableLogChannel):
- 11:31 PM Changeset in webkit [52850] by
-
- 2 edits in trunk/WebCore
2010-01-05 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
Moving v8::HandleScope up above declaration of v8::Local to fix a
Chromium startup crash.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
- 10:37 PM Changeset in webkit [52849] by
-
- 6 edits in trunk/WebKitTools
2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Refactored check-webkit-style's argument parser to not rely
on global state, and improved its error handling and unit
test coverage.
- Scripts/check-webkit-style:
- Adjusted to use new argument parser.
- Scripts/webkitpy/cpp_style.py:
- Changed _CppStyleState to accept an array of filter rules instead of a comma-delimited string.
- Eliminated cpp_style._DEFAULT_FILTER_RULES.
- Eliminated cpp_style._USAGE.
- Scripts/webkitpy/cpp_style_unittest.py:
- Updated test_filter() and test_default_filter().
- Scripts/webkitpy/style.py:
- Converted style._USAGE to create_usage().
- Corrected usage instructions by removing 0 as a valid --verbose flag value.
- Removed use_webkit_styles().
- Added ProcessorOptions class.
- Added ArgumentDefaults class.
- Added ArgumentPrinter class.
- Removed parse_arguments and added ArgumentParser class.
- Moved exit_with_usage() and exit_with_categories() into ArgumentParser.
- Refactored parse_arguments() as ArgumentParser.parse().
- Improved parser error handling.
- Scripts/webkitpy/style_unittest.py:
- Added DefaultArgumentsTest class.
- Addressed FIXME to check style.WEBKIT_FILTER_RULES against style.STYLE_CATEGORIES.
- Added ArgumentPrinterTest class.
- Added ArgumentParserTest class and rewrote parser unit tests.
- 9:11 PM Changeset in webkit [52848] by
-
- 2 edits in trunk/WebKit/mac
Re-enable plug-in halting on Mac after r51953
Reviewed by Mark Rowe.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled): Test for the correct selector.
- 7:09 PM Changeset in webkit [52847] by
-
- 12 edits in trunk
2010-01-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[v8] Move V8DOMWindowShell to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=33232
This patch moves V8DOMWindow shell to ScriptController, where the
window shells live in JSC land. The next step will be to allow for
more than one window shell per script controller.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::~V8DOMWindowShell):
- bindings/v8/V8DOMWindowShell.h: (WebCore::V8DOMWindowShell::localHandleForContext):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h:
- bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
2010-01-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[v8] Move V8DOMWindowShell to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=33232
Update FrameLoaderClientImpl.cpp to call clearForClose on
ScriptController instead of on V8Proxy.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 6:57 PM Changeset in webkit [52846] by
-
- 8 edits6 adds in trunk
2010-01-05 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <header> and <footer> elements.
https://bugs.webkit.org/show_bug.cgi?id=32943
These test:
- <p> closing,
- No nesting restriction,
- Residual style, and
- FormatBlock.
- fast/html/footer-element-expected.txt: Added.
- fast/html/footer-element.html: Added.
- fast/html/header-element-expected.txt: Added.
- fast/html/header-element.html: Added.
- fast/html/script-tests/footer-element.js: Added.
- fast/html/script-tests/header-element.js: Added.
2010-01-05 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <header> and <footer> elements.
https://bugs.webkit.org/show_bug.cgi?id=32943
<header> and <footer> should behave the same as <nav>, <section>,
<article>, and <aside>. The HTML parser doesn't need to restrict
the nesting of header/footer elements.
Tests: fast/html/footer-element.html
fast/html/header-element.html
- css/html.css: Add header/footer as block elements.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add headerTag and footerTag.
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for headerTag and footerTag. (WebCore::blockTagList): Add headerTag and footerTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Rename isHeaderTag() to isHeadingTag() (WebCore::HTMLParser::getNode): Add headerTag and footerTag. (WebCore::HTMLParser::isHeadingTag): Renamed from isHeaderTag().
- html/HTMLParser.h:
- Rename isHeaderTag() to isHeadingTag()
- Remove non-existing popNestedHeaderTag().
- html/HTMLTagNames.in: Add header and footer.
- 6:46 PM Changeset in webkit [52845] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-05 Rachel Petterson <rlp@google.com>
Reviewed by Adam Barth.
Matches the texImage2D and texSubImage2D functions to their
declarations. Elminates uncessary versions of those functions.
https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- 6:07 PM Changeset in webkit [52844] by
-
- 2 edits in trunk/LayoutTests
2010-01-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191
- fast/dom/Node/normalize-with-cdata-expected.txt: Added.
- fast/dom/Node/normalize-with-cdata.html: Added.
- fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
- 6:06 PM Changeset in webkit [52843] by
-
- 2 edits in trunk/LayoutTests
2010-01-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191
- fast/dom/Node/normalize-with-cdata-expected.txt: Added.
- fast/dom/Node/normalize-with-cdata.html: Added.
- fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
- 6:05 PM Changeset in webkit [52842] by
-
- 3 edits in trunk/LayoutTests
2010-01-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191
- fast/dom/Node/normalize-with-cdata-expected.txt: Added.
- fast/dom/Node/normalize-with-cdata.html: Added.
- fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
- 6:03 PM Changeset in webkit [52841] by
-
- 3 edits in trunk/LayoutTests
2010-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
animations/animation-drt-api-multiple-keyframes.html and animations/animation-drt-api.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33244
Both these tests have a race condition. They start looking
for the animation start after the node is already rendered.
Instead, set the animation just before looking for the animation
start.
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- 5:35 PM Changeset in webkit [52840] by
-
- 3 edits3 adds in trunk
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dom/Node/normalize-with-cdata.html
- dom/Node.cpp:
(WebCore::Node::normalize): Use nodeType instead of isTextNode.
LayoutTests:
- fast/dom/Node/normalize-with-cdata-expected.txt: Added.
- fast/dom/Node/normalize-with-cdata.html: Added.
- fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
- 5:13 PM Changeset in webkit [52839] by
-
- 3 edits3 adds in trunk
2010-01-05 James Robinson <jamesr@google.com>
Reviewed by Eric Seidel.
Typing in Google Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295
Add a repaint test to make sure that when mutations happen in a grandchild of a block element that has no in-flow children
the entire block element is not unnecessarily repainted.
The bug only shows up when running pixel tests.
- fast/repaint/block-no-inflow-children.html: Added.
- platform/mac/fast/repaint/block-no-inflow-children-expected.checksum: Added.
- platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
- platform/mac/fast/repaint/block-no-inflow-children-expected.txt: Added.
2010-01-05 James Robinson <jamesr@google.com>
Reviewed by Eric Seidel.
Typing in Google Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295
Marks a RenderBlock without block children for layout and painting when it has no line boxes only if it has inline immediate children.
The existing logic uses the existence of line boxes as a dirty flag to indicate that line boxes need to be regenerated. This heuristic
fails when the RenderBlock does not have any in-flow children at all, causing the RenderBlock to get unnecessarily marked for layout and
painting. This is particularly bad for common scrollbar manipulation tricks like putting one positioned div inside another - this
structure caused the entire outer div's bounds to get scheduled for a paint whenever there was any mutation of any descendant.
Test: LayoutTests/fast/repaint/block-no-inline-children.html (only shows up in pixel tests)
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 4:07 PM Changeset in webkit [52838] by
-
- 3 edits in trunk/WebCore
2010-01-05 James Robinson <jamesr@chromium.org>
Reviewed by David Hyatt.
Cleans up line box clearing when a RenderBlock loses its last child.
https://bugs.webkit.org/show_bug.cgi?id=33228
The 'fullLayout' flag in RenderBlock::layoutInlineChildren() is pretty vague, hopefully this will be easier for the next person to figure out.
No new tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 3:57 PM Changeset in webkit [52837] by
-
- 2 edits in trunk/LayoutTests
2010-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
LayoutTests/animations/change-keyframes.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33233
The timing calculation was just off. It was starting the
second animation at 600ms and then checking to be half-way
done with the 1 second animation at 1000ms. Instead, just
modify the animation to run a bit earlier.
- animations/change-keyframes.html:
- 3:53 PM Changeset in webkit [52836] by
-
- 4 edits in trunk/WebCore
2010-01-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Provide the "documentURL" property for documents and frame owner elements
This is necessary to determine owner document URLs for nodes (all nodes have
the top-level document set as ownerDocument).
https://bugs.webkit.org/show_bug.cgi?id=33025
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- 3:51 PM Changeset in webkit [52835] by
-
- 3 edits in trunk/LayoutTests
Fixed a bug in testcase. Passing an empty array to texImage2D
now must be done with 'null' not '0'.
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/texImageTest-expected.txt:
- 3:42 PM Changeset in webkit [52834] by
-
- 1 edit5 adds in trunk/LayoutTests
New test for texImage2d and texSubImage2d cases
New test for texImage2d using ImageData which tests rendering.
https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493
- 3:22 PM Changeset in webkit [52833] by
-
- 5 edits in trunk/WebCore
Public GIF decoder should stop decoding when allocation fails
https://bugs.webkit.org/show_bug.cgi?id=33231
Reviewed by Adam Barth.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::output_row):
(GIFImageReader::do_lzw):
(GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h:
- 3:13 PM Changeset in webkit [52832] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Add missing Radar numbers
- 3:08 PM Changeset in webkit [52831] by
-
- 4 edits in trunk/WebCore
2010-01-05 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Make PNG image decoder work with segmented SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=33213
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::isAllDataReceived): (WebCore::ImageDecoder::setData):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): (WebCore::PNGImageReader::setComplete): (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::pngComplete):
- 3:07 PM Changeset in webkit [52830] by
-
- 2 edits in trunk/WebKit/win
Make IWebView::close and destroying a WebView's HWND optional for WebKit clients
WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.
IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).
Fixes <http://webkit.org/b/32827> Crash when calling IWebView::close,
then releasing the WebView, without calling DestroyWindow
Fixes a few WebViewDestruction tests, too.
Reviewed by Steve Falkenburg.
- WebView.cpp:
(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.
- 3:07 PM Changeset in webkit [52829] by
-
- 4 edits in trunk
Make it safe to call IWebView::close when IWebView::initWithFrame hasn't been called
Part of <http://webkit.org/b/32827> Crash when calling
IWebView::close, then releasing the WebView, without calling
DestroyWindow
Reviewed by Steve Falkenburg.
WebKit/win:
- WebView.cpp:
(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.
WebKitTools:
Test that it's safe to call IWebView::close when IWebView::initWithFrame
hasn't been called
- WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
without ever calling IWebView::initWithFrame and tests that we don't
crash or leak.
- 3:07 PM Changeset in webkit [52828] by
-
- 3 edits in trunk/WebKit/win
Add assertions to catch double-destruction of WebViews earlier
I basically copied the m_deletionHasBegun logic from WTF::RefCounted.
Fixes <http://webkit.org/b/33219>.
Reviewed by Darin Adler.
- WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.
- WebView.h: Added m_deletionHasBegun.
- 3:06 PM Changeset in webkit [52827] by
-
- 2 edits in trunk/WebKit/win
Remove dead code in WebViewWndProc
Fixes <http://webkit.org/b/33218>.
Reviewed by Darin Adler.
- WebView.cpp:
(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.
- 3:06 PM Changeset in webkit [52826] by
-
- 2 edits in trunk/WebKitTools
Add more WebViewDestruction tests
Fixes <http://webkit.org/b/33216>.
Reviewed by Eric Seidel.
- WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::NoInitWithFrame):
(WebKitAPITest::CloseThenDestroyViewWindow):
(WebKitAPITest::DestroyViewWindowThenClose):
(WebKitAPITest::DestroyHostWindow):
(WebKitAPITest::DestroyHostWindowThenClose):
(WebKitAPITest::CloseThenDestroyHostWindow):
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.
- 2:45 PM Changeset in webkit [52825] by
-
- 2 edits in trunk/WebKitTools
2010-01-05 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
If you're working from a --minimal or --no-svg build and make changes to the
DRT, then recompile, the build will fail.
This is because the current behavior at build time is to assume that the
previous Qt build supported SVG and consequently delete libQtWebKit.so.
Unfortunately, just deleting libQtWebKit.so will not cause the library to
re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
results in a link failure on the DRT.
Since re-linking libQtWebKit can take up to ten minutes and should be avoided
in cases where not actually required, remove the assumption that
the previous Qt build supported SVG, and amend the symbol detection to look for
a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
- Scripts/webkitdirs.pm:
- 2:30 PM Changeset in webkit [52824] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix for WinCE + style fixes.
https://bugs.webkit.org/show_bug.cgi?id=32939
- jsc.cpp: (functionPrint): (functionQuit): (parseArguments): (fillBufferWithContentsOfFile):
- 1:18 PM Changeset in webkit [52823] by
-
- 2 edits in trunk/WebCore
2010-01-05 Adam Barth <abarth@webkit.org>
Rubber stamped by Dimitri Glazkov.
Fix namespace indent for ScriptController.
- bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::xssAuditor): (WebCore::ScriptController::setProcessingTimerCallback): (WebCore::ScriptController::setPaused): (WebCore::ScriptController::isPaused): (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::evaluateInWorld):
- 12:48 PM Changeset in webkit [52822] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-05 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
https://bugs.webkit.org/show_bug.cgi?id=33205
- jit/ExecutableAllocator.h:
- 12:40 PM Changeset in webkit [52821] by
-
- 8 edits in trunk/WebCore
Implement most cases of texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=31562
- 12:37 PM Changeset in webkit [52820] by
-
- 3 edits in trunk/WebCore
Part of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
Web Inspector: Context Menus should be used in more places.
Reviewed by Tim Hatcher.
Add context menus to handle the interaction with breakpoints in the Source Frame. Currently
we use left click to add/disable/remove breakpoints, and left click to edit (for conditional
breakpoints), but this is hard to discover and behaves differently than Xcode.
Change the behavior to be more like Xcode, left click adds a breakpoint if there isn't one, and
removes it if there is one.
On the context menu, if there is no breakpoint there, we have Add Breakpoint, and Add Conditional
Breakpoint. If there is a breakpoint there, we add entries for Edit Breakpoint (edit
the condition), Remove Breakpoint, and Enable/Disable Breakpoint (based on the current state).
- English.lproj/localizedStrings.js: Added localized context menu entries.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._documentContextMenu.addAndEditBreakpoint):
(WebInspector.SourceFrame.prototype._documentContextMenu): Added context menu entries and handlers.
(WebInspector.SourceFrame.prototype._documentMouseDown): Changed left click behavior (Add -> Remove).
- 12:34 PM QtWebKitBackportingFixes edited by
- (diff)
- 12:33 PM QtWebKitBackportingFixes edited by
- (diff)
- 12:32 PM Changeset in webkit [52819] by
-
- 9 edits2 adds in trunk
AX: need a way to get the progress of a webpage load
https://bugs.webkit.org/show_bug.cgi?id=33221
Reviewed by Eric Seidel.
WebCore:
Test: platform/mac/accessibility/estimated-progress.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::estimatedLoadingProgress):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- platform/mac/accessibility/document-attributes-expected.txt:
- platform/mac/accessibility/estimated-progress-expected.txt: Added.
- platform/mac/accessibility/estimated-progress.html: Added.
- platform/mac/accessibility/frame-with-title-expected.txt:
- platform/mac/accessibility/frame-with-title.html:
- 12:17 PM Changeset in webkit [52818] by
-
- 2 edits in trunk/LayoutTests
Skipping three new tests.
- 11:51 AM Changeset in webkit [52817] by
-
- 2 edits in trunk/WebKitTools
2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Kilzer.
Switched to generating list of Perl unit test files dynamically,
instead of explicitly.
- Scripts/test-webkitperl:
- 11:44 AM Changeset in webkit [52816] by
-
- 4 edits in trunk/WebKitTools
2010-01-05 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Reimplement EventSender::leapForward
https://bugs.webkit.org/show_bug.cgi?id=33114
Follow Windows implementation of leapForward. When leapForward is called,
messages are queued and posted after the timeout. A new event loop is created to
handle those messages and the additional messages that are created as a result.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::sendOrQueueEvent): (EventSender::replaySavedEvents): (EventSender::eventFilter):
- DumpRenderTree/qt/EventSenderQt.h:
- 11:36 AM Changeset in webkit [52815] by
-
- 6 edits in trunk
2010-01-05 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Drag & drop layout tests fail even when run manually
https://bugs.webkit.org/show_bug.cgi?id=33055
No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.
- page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag): Cleanup the drag operation if it failed to complete, Otherwise, new drag operations will not be possible.
2010-01-05 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Drag & drop layout tests fail even when run manually
https://bugs.webkit.org/show_bug.cgi?id=33055
No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.
- Api/qwebpage.cpp: (dropActionToDragOp): (dragOpToDropAction): (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent): Accept drag events even if they are not over a drop target. This is to ensure that drag events will continue to be delivered.
- Api/qwebpage_p.h:
- WebCoreSupport/DragClientQt.cpp: (WebCore::dragOperationToDropActions): (WebCore::dropActionToDragOperation): (WebCore::DragClientQt::startDrag): Send dragEnd event.
- 11:28 AM Changeset in webkit [52814] by
-
- 2 edits in trunk/WebKitTools
2010-01-05 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix obscure queue crash in queueengine
https://bugs.webkit.org/show_bug.cgi?id=33196
Sometimes we get an exception that can't be stringified. For example:
AttributeError: 'ParseError' object has no attribute 'msg'
In these cases, the whole queue dies because we're in the global
exception handler. Instead of dieing here, we should just print a less
informative message to the console. We're already printing the whole
backtrace anyway, so there's not much point to stringifying the
exception anyway.
- Scripts/webkitpy/queueengine.py:
- 11:08 AM Changeset in webkit [52813] by
-
- 4 edits in trunk
Reviewed by Xan Lopez.
Based on idea and original patch by Evan Martin.
Remove libWebCore intermediate library, to improve link time.
[GTK] Build time must be reduced
https://bugs.webkit.org/show_bug.cgi?id=32921
- 11:06 AM Changeset in webkit [52812] by
-
- 8 edits in trunk/WebCore
2010-01-05 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Move allowSetting{Frame}SrcToJavascriptUrl from V8Custom to BindingSecurity and
remove the v8-specific pieces.
- bindings/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): Moved from V8CustomBinding.cpp. (WebCore::::allowSettingSrcToJavascriptURL): Moved from V8CustomBinding.cpp.
- bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::valueAccessorSetter):
- bindings/v8/custom/V8CustomBinding.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::V8HTMLFrameElement::srcAccessorSetter): (WebCore::V8HTMLFrameElement::locationAccessorSetter):
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::V8HTMLIFrameElement::srcAccessorSetter):
- 11:04 AM Changeset in webkit [52811] by
-
- 11 edits4 copies1 move1 add1 delete in trunk/WebCore
2010-01-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Separate DOMWrapperWorld from V8IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=33087
This change separate DOMWrapperWorld and IsolatedWorld from
V8IsolatedWorld. I've also renamed V8IsolatedWorld to
V8IsolatedContext in preparation for having more than one context in a
single isolated world.
This patch moves us closer to two goals:
1) Matching the structure of the JSC implementation of isolated worlds.
2) Letting scripts running in isolated contexts see into other iframes
(which requires having more than one context in an isolated world.)
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp: Added. (WebCore::DOMWrapperWorld::DOMWrapperWorld): (WebCore::mainThreadNormalWorld):
- bindings/v8/DOMWrapperWorld.h: Added. (WebCore::DOMWrapperWorld::create):
- bindings/v8/IsolatedWorld.cpp: Added. (WebCore::IsolatedWorld::IsolatedWorld): (WebCore::IsolatedWorld::~IsolatedWorld):
- bindings/v8/IsolatedWorld.h: Added. (WebCore::IsolatedWorld::create): (WebCore::IsolatedWorld::count): (WebCore::IsolatedWorld::domDataStore):
- bindings/v8/MainThreadDOMData.cpp: (WebCore::MainThreadDOMData::getMainThreadStore):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::currentScriptState):
- bindings/v8/ScriptState.cpp:
- bindings/v8/ScriptState.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8IsolatedContext.cpp: Copied from WebCore/bindings/v8/V8IsolatedWorld.cpp. (WebCore::V8IsolatedContext::contextWeakReferenceCallback): (WebCore::V8IsolatedContext::V8IsolatedContext): (WebCore::V8IsolatedContext::destroy): (WebCore::V8IsolatedContext::~V8IsolatedContext): (WebCore::V8IsolatedContext::scriptState):
- bindings/v8/V8IsolatedContext.h: Copied from WebCore/bindings/v8/V8IsolatedWorld.h. (WebCore::V8IsolatedContext::getEntered): (WebCore::V8IsolatedContext::world):
- bindings/v8/V8IsolatedWorld.cpp: Removed.
- bindings/v8/V8IsolatedWorld.h: Removed.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::context):
- bindings/v8/V8Proxy.h:
- bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::WorldContextHandle):
- 11:03 AM Changeset in webkit [52810] by
-
- 5 edits1 copy6 moves3 adds in trunk/WebCore
2010-01-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Move createWindow into generic bindings so it can be shared with JSC
https://bugs.webkit.org/show_bug.cgi?id=33201
This patch moves createWindow from V8-specific code into the generic
bindings so that is can be re-used by the JavaScriptCore bindings. I
haven't actually moved the JSC bindings over to using this yet.
Also, I organized the generic bindings a bit more as it's becoming
clearer how things are going to shape up. There are still some
question marks, but hopefully the answers will become clear as we
progress.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/generic/BindingDOMWindow.h: Added. (WebCore::::createWindow):
- bindings/generic/BindingSecurity.h: Renamed from WebCore/bindings/BindingSecurity.h. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
- bindings/generic/BindingSecurityBase.cpp: Renamed from WebCore/bindings/BindingSecurityBase.cpp. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccess):
- bindings/generic/BindingSecurityBase.h: Renamed from WebCore/bindings/BindingSecurityBase.h.
- bindings/generic/GenericBinding.h: Renamed from WebCore/bindings/GenericBinding.h. (WebCore::):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
- bindings/v8/specialization/V8BindingDOMWindow.h: Added. (WebCore::V8BindingDOMWindow::storeDialogArgs):
- bindings/v8/specialization/V8BindingState.cpp: Renamed from WebCore/bindings/v8/V8BindingState.cpp. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
- bindings/v8/specialization/V8BindingState.h: Renamed from WebCore/bindings/v8/V8BindingState.h. (WebCore::):
- 11:00 AM Changeset in webkit [52809] by
-
- 9 edits2 adds in trunk
2010-01-05 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Darin Adler.
Added a test to make sure that ARIA checkboxes correctly handle the aria-checked attribute.
- accessibility/aria-checkbox-checked-expected.txt: Added.
- accessibility/aria-checkbox-checked.html: Added.
2010-01-05 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Darin Adler.
For an object with an aria role of "checkbox" or "radiobutton",
Use the "aria-checked" attribute to determine if it's checked.
Test: accessibility/aria-checkbox-checked.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isChecked):
2010-01-05 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Darin Adler.
For an object with an aria role of "checkbox" or "radiobutton",
use the "aria-checked" attribute to determine if it's checked.
These changes add an isChecked() method to AccessibilityUIElement
so that we can check for this property from a layout test.
- DumpRenderTree/AccessibilityUIElement.cpp: (getIsCheckedCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isChecked):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isChecked):
- 10:43 AM Changeset in webkit [52808] by
-
- 3 edits in trunk/WebKitTools
Having a comment for the #endif for a header guard is not required WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=33214
Reviewed by Darin Adler.
- Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit early when it has all the needed information to continue.
- Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
- 10:40 AM Changeset in webkit [52807] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.18
Tagging 1.1.18.
- 10:36 AM Changeset in webkit [52806] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-05 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Added compiler error for unsupported platforms.
https://bugs.webkit.org/show_bug.cgi?id=33112
- jit/JITStubs.cpp:
- 10:14 AM Changeset in webkit [52805] by
-
- 2 edits in trunk/WebKitTools
Share more code in the WebViewDestruction tests
Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest
Reviewed by Sam Weinig.
- WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::createAndInitializeWebView): Renamed from
createWebView. Now initializes the HostWindow and returns the
WebView's HWND via an out-parameter.
(WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
the CloseWithoutDestroyWindow test.
(WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
CloseWithoutDestroyWindow and changed to use the new functions.
(WebKitAPITest::MainFrameAfterClose): Changed to use the new
functions.
(WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
NoCloseOrDestroyWindow and changed to use the new functions.
- 10:14 AM Changeset in webkit [52804] by
-
- 2 edits in trunk/WebKitTools
Don't show HostWindows by default
This was making WebKitAPITest very flashy as windows appeared and
disappeared.
Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest
Reviewed by Sam Weinig.
- WebKitAPITest/HostWindow.cpp:
(WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
from the window.
- 10:14 AM Changeset in webkit [52803] by
-
- 2 edits in trunk/WebKitTools
Don't hang in WebKitAPITest if no messages have been posted
Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest
Reviewed by Sam Weinig.
- WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.
- 10:14 AM Changeset in webkit [52802] by
-
- 2 edits in trunk/WebKitTools
Fix WebKitCreateInstance helper
Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest
Reviewed by Sam Weinig.
- WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
through, instead of taking its address.
- 9:54 AM Changeset in webkit [52801] by
-
- 3 edits in trunk/WebCore
2010-01-05 Yong Li <yoli@rim.com>
Reviewed by Adam Roben.
Fix build warnings blindly
https://bugs.webkit.org/show_bug.cgi?id=33178
- platform/SharedBuffer.cpp:
- platform/SharedBuffer.h: (WebCore::SharedBuffer::append):
- 9:45 AM Changeset in webkit [52800] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
- 8:24 AM Changeset in webkit [52799] by
-
- 4 edits in trunk/WebCore
2010-01-05 Yong Li <yong.li@torchmobile.com>
Reviewed by Darin Adler.
Fix an obvious bug and build errors in previous commit (r52795)
https://bugs.webkit.org/show_bug.cgi?id=33178
- platform/SharedBuffer.h: (WebCore::SharedBuffer::isEmpty):
- platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
- 8:09 AM Changeset in webkit [52798] by
-
- 3 edits in trunk/WebKit/gtk
2010-01-05 Gustavo Noronha Silva <Gustavo Noronha Silva>
Updated docs for 1.1.18 release.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 7:53 AM Changeset in webkit [52797] by
-
- 3 edits in trunk/JavaScriptCore
Follow r52729 in ARMAssembler.
https://bugs.webkit.org/show_bug.cgi?id=33208
Reviewed by Maciej Stachowiak.
Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):
- 7:53 AM Changeset in webkit [52796] by
-
- 4 edits in trunk
2010-01-05 Xan Lopez <xlopez@igalia.com>
Bump for 1.1.18 release.
- configure.ac:
WebKit/gtk:
2010-01-05 Xan Lopez <xlopez@igalia.com>
Update for 1.1.18 release.
- NEWS:
- 7:14 AM Changeset in webkit [52795] by
-
- 7 edits in trunk/WebCore
2010-01-04 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Let SharedBuffer use a group of memory segments internally.
It will merge the segments into a flat consecutive buffer only when
necessary.
https://bugs.webkit.org/show_bug.cgi?id=33178
- platform/SharedBuffer.cpp: (WebCore::allocateSegment): (WebCore::freeSegment): (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptVector): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::copy): (WebCore::SharedBuffer::buffer): (WebCore::SharedBuffer::getSomeData):
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
- platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 6:22 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:00 AM Changeset in webkit [52794] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed build fix for Gtk+
Don't use comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.
- wtf/Platform.h:
- 2:28 AM Changeset in webkit [52793] by
-
- 2 edits in trunk/WebCore
Unreviewed trivial Symbian build fix
- plugins/symbian/PluginViewSymbian.cpp: Add missing HostWindow.h inclusion
- 1:45 AM Changeset in webkit [52792] by
-
- 2 edits in trunk/WebCore
[Qt] Fix broken export macros in package builds.
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=33202
Always define QT_MAKEDLL unless we're doing a static
build or we're building inside of Qt. When building
inside of Qt the correct define is pulled from qbase.pri.
- WebCore.pro:
- 12:58 AM Changeset in webkit [52791] by
-
- 147 edits in trunk
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
- wtf/Platform.h: Rename, reorganize and document OS() macros.
Adapt to name changes. Also fixed a few incorrect OS checks.
- API/JSContextRef.cpp:
- assembler/MacroAssemblerARM.cpp: (JSC::isVFPPresent):
- assembler/MacroAssemblerX86Common.h:
- bytecode/SamplingTool.cpp:
- config.h:
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/ExecutableAllocatorPosix.cpp:
- jit/ExecutableAllocatorSymbian.cpp:
- jit/ExecutableAllocatorWin.cpp:
- jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
- jsc.cpp: (main):
- parser/Grammar.y:
- profiler/ProfileNode.cpp: (JSC::getCount):
- runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
- runtime/Collector.h:
- runtime/DateConstructor.cpp:
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
- runtime/InitializeThreading.cpp: (JSC::initializeThreading):
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackPosix.cpp:
- runtime/MarkStackSymbian.cpp:
- runtime/MarkStackWin.cpp:
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- runtime/UString.cpp: (JSC::UString::from):
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/CurrentTime.cpp: (WTF::lowResUTCTime):
- wtf/CurrentTime.h: (WTF::getLocalTime):
- wtf/DateMath.cpp:
- wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitModule): (WTF::TCMallocStats::):
- wtf/FastMalloc.h:
- wtf/MathExtras.h:
- wtf/RandomNumber.cpp: (WTF::randomNumber):
- wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
- wtf/StringExtras.h:
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
- wtf/TCSystemAlloc.cpp:
- wtf/ThreadSpecific.h: (WTF::::destroy):
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp: (WTF::initializeThreading): (WTF::isMainThread):
- wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): (WTF::createThreadInternal):
- wtf/VMTags.h:
- wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
- wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
Adapt to name changes.
- src/ChromiumBridge.cpp:
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): (WebKit::): (WebKit::EditorClientImpl::handleEditingKeyboardEvent):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionAsText): (WebKit::WebFrameImpl::printPage):
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseContextMenu): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent): (WebKit::WebViewImpl::setScrollbarColors): (WebKit::WebViewImpl::navigationPolicyFromMouseEvent):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
Adapt to name changes.
- webkit/webkitwebsettings.cpp: (webkit_get_user_agent):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
Adapt to name changes. Also fixed a few incorrect OS checks.
- accessibility/AccessibilityObject.h:
- config.h:
- dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
- loader/CachedFont.cpp:
- loader/FTPDirectoryDocument.cpp:
- loader/FTPDirectoryParser.cpp:
- page/EventHandler.cpp:
- page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntry):
- page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform):
- page/Page.h:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- page/chromium/DragControllerChromium.cpp: (WebCore::DragController::isCopyKeyDown):
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers):
- page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
- platform/FileSystem.h:
- platform/KeyboardCodes.h:
- platform/PurgeableBuffer.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
- platform/chromium/ClipboardUtilitiesChromium.cpp:
- platform/chromium/ClipboardUtilitiesChromium.h:
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::documentFragment):
- platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenu::show):
- platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
- platform/graphics/FontCache.h:
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntRect.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cg/ColorCG.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.h:
- platform/graphics/chromium/FontPlatformData.h:
- platform/graphics/opentype/OpenTypeUtilities.cpp:
- platform/graphics/opentype/OpenTypeUtilities.h:
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext):
- platform/graphics/qt/ImageQt.cpp:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipToImageBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::save): (PlatformContextSkia::restore):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
- platform/graphics/wx/GraphicsContextWx.cpp:
- platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): (WebCore::filenameFromString): (WebCore::filenameForDisplay):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- platform/network/curl/ResourceHandleManager.cpp:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- platform/text/String.cpp: (WebCore::String::format): (WebCore::String::number):
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
- platform/text/TextStream.cpp:
- platform/text/TextStream.h:
- platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
- platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/win/PlatformScreenWin.cpp: (WebCore::deviceInfoForWidget): (WebCore::screenIsMonochrome):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::paint): (WebCore::PopupMenu::registerClass): (WebCore::PopupMenu::PopupMenuWndProc): (WebCore::PopupMenu::wndProc):
- platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
- platform/wx/FileSystemWx.cpp: (WebCore::unloadModule):
- plugins/PluginDatabase.cpp:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion):
- plugins/PluginPackage.h:
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect): (WebCore::PluginView::stop): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::platformStart):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
Adapt to name changes.
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/config.h:
- 12:55 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:47 AM Changeset in webkit [52790] by
-
- 2 edits in trunk/WebKitTools
2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Minor improvements to test-webkit-scripts, as suggested
by an earlier review.
- Scripts/test-webkit-scripts:
- Used OptionParser class instead of getopt.getopt().
- Created main() method for main block.
- Enclosed functions in a class.
- 12:07 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:06 AM Changeset in webkit [52789] by
-
- 2 edits in trunk/WebKitTools
No review. Fix DRT breakage on Tiger/Leopard.
Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 12:00 AM Changeset in webkit [52788] by
-
- 8 edits in trunk/WebKit/chromium
2010-01-04 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Expose more DOM methods to support LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=33185
- public/WebDocument.h: Adds documentElement method.
- public/WebElement.h: Adds innerText method.
- public/WebFrame.h: Adds renderTreeAsText and counterValueForElementById methods, and fixes a few whitespace issues.
- src/WebDocument.cpp: (WebKit::WebDocument::documentElement):
- src/WebElement.cpp: (WebKit::WebElement::innerText):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearName): (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::counterValueForElementById):
- src/WebFrameImpl.h:
Jan 4, 2010:
- 11:54 PM Changeset in webkit [52787] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-04 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- src/WebAnimationControllerImpl.h:
- 11:46 PM Changeset in webkit [52786] by
-
- 23 edits4 adds in trunk
Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117
Reviewed by Darin Adler.
WebCore:
Tests: platform/mac/accessibility/aria-liveregions-attributes.html
platform/mac/accessibility/aria-liveregions-notifications.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::contentChanged):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isChildOfARIALiveRegion):
(WebCore::AccessibilityObject::supportsARIALiveRegion):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::contentChanged):
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityObject::ariaLiveRegionBusy):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):
- accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::areChildrenDirty):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/mac/AccessibilityObjectWrapper.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
- html/HTMLAttributeNames.in:
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(indexOfChildCallback):
(boolAttributeValueCallback):
(stringAttributeValueCallback):
(addNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):
LayoutTests:
- accessibility/aria-activedescendant-crash.html:
- platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-attributes.html: Added.
- platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-notifications.html: Added.
- platform/mac/accessibility/aria-menu-role-descriptions.html:
- platform/mac/accessibility/slider-supports-actions.html:
- 9:33 PM Changeset in webkit [52785] by
-
- 6 edits in trunk/WebKitTools
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool rollout should require a reason
https://bugs.webkit.org/show_bug.cgi?id=30810
- Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
- Scripts/webkitpy/changelogs_unittest.py: Test reason support.
- Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
- Scripts/webkitpy/commands/download_unittest.py: pass required reason
- Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
- 9:19 PM Changeset in webkit [52784] by
-
- 12 edits12 adds in trunk
2010-01-04 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Test for https://bugs.webkit.org/show_bug.cgi?id=29820
Adopt a more conservative approach for loading CSS cross-origin.
- http/tests/security/cross-origin-css.html: Added.
- http/tests/security/cross-origin-css-expected.txt: Added.
- http/tests/security/cross-origin-css-in-xml.xml: Added.
- http/tests/security/cross-origin-css-in-xml-expected.txt: Added.
- http/tests/security/resources/xorigincss1.css: Added.
- http/tests/security/resources/xorigincss2.css: Added.
- http/tests/security/resources/xorigincss1.html: Added.
- http/tests/security/resources/xorigincss2.html: Added.
- http/tests/security/resources/xorigincss3.html: Added.
- http/tests/security/resources/xorigincss4.html: Added.
- http/tests/security/resources/xorigincss5.html: Added.
- http/tests/security/resources/xorigincss6.html: Added.
2010-01-04 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Adopt a more conservative approach for loading CSS cross-origin. When
loading CSS cross-origin, it must be start with valid CSS if the MIME
type is broken.
Test: http/tests/security/cross-origin-css.html
Test: http/tests/security/cross-origin-css-in-xml.xml
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
- css/CSSStyleSheet.h:
- css/CSSStyleSheet.cpp:
- css/CSSParser.cpp:
- css/CSSGrammar.y:
- css/CSSParser.h: Add ability to tell whether the CSS parse started with a syntactically valid CSS rule.
- loader/CachedCSSStyleSheet.h:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): Add ability to return whether the MIME type was acceptable for CSS. (WebCore::CachedCSSStyleSheet::canUseSheet): If requested, return whether the MIME type was valid or not.
- dom/ProcessingInstruction.cpp (WebCore::ProcessingInstruction::setCSSStyleSheet): Make use of strict mode explicit and add comment.
- 8:45 PM Changeset in webkit [52783] by
-
- 5 edits2 adds in trunk
<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements correctly
<rdar://problem/7397558> REGRESSION: AXImages inside of AXLink cause AXLink to have wrong bounds
Reviewed by Simon Fraser.
WebCore:
Test: accessibility/dimensions-include-descendants.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect): Use absoluteFocusRingQuads()
for non-text renderers. The focus ring encompasses descendants, which is
what we want for the accessibility indicator.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteFocusRingQuads): Added.
- rendering/RenderObject.h:
LayoutTests:
- accessibility/dimensions-include-descendants-expected.txt: Added.
- accessibility/dimensions-include-descendants.html: Added.
- 7:53 PM Changeset in webkit [52782] by
-
- 2 edits in trunk/WebCore
2010-01-04 Ojan Vafai <ojan@ojanmacpro.sfo.corp.google.com>
Reviewed by Dan Bernstein.
Remove unnecessary division by a constant in SimpleFontDataMac.mm.
https://bugs.webkit.org/show_bug.cgi?id=33189
This was added in http://trac.webkit.org/changeset/8104 and seems like
it was just there to match the previously private function which we no
longer use.
No new tests. No change in behavior.
- platform/graphics/mac/SimpleFontDataMac.mm:
- 7:40 PM Changeset in webkit [52781] by
-
- 3 edits2 adds in trunk
MSAA: Accessibility role of <select> elements is wrong
https://bugs.webkit.org/show_bug.cgi?id=33192
Reviewed by Sam Weinig.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.
LayoutTests:
- platform/win/accessibility/select-element-role-expected.txt: Added.
- platform/win/accessibility/select-element-role.html: Added.
- 5:43 PM Changeset in webkit [52780] by
-
- 4 edits in trunk
Make distcheck build fixes.
- 5:38 PM Changeset in webkit [52779] by
-
- 2 edits in trunk/WebCore
Qt build fix. Unreviewed.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):
- 5:35 PM Changeset in webkit [52778] by
-
- 6 edits in trunk/WebCore
Selection-related code needs stricter rules about how it relates to layout
https://bugs.webkit.org/show_bug.cgi?id=32882
Reviewed by Maciej Stachowiak.
Covered by existing tests along with the new assertions.
- dom/Document.cpp:
(WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
already false by the time post-attach callbacks are done so that
layout triggered inside those callbacks can work properly.
- editing/SelectionController.cpp:
(WebCore::SelectionController::layout): Added code to trigger a
layout when it's needed.
(WebCore::SelectionController::recomputeCaretRect): Removed unneeded
code to do nothing when FrameView is 0. Added an assertion that layout
is not needed at the time the function is called.
(WebCore::SelectionController::invalidateCaretRect): Added code to
trigger a layout when it's needed.
(WebCore::SelectionController::paintCaret): Added an assertion that
layout is not needed at the time the function is called.
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus): Added. Helper function that expresses
the rule for which form control elements should auto-focus.
(WebCore::focusPostAttach): Added. Called post-attach to focus an
element if we discover it should be focused during attach.
(WebCore::HTMLFormControlElement::attach): Refactored code for
which elements need auto-focus into a separate function. Instead
of focusing right away, use the focusPostAttach function to focus
after attach is done. Also added calls to suspendPostAttachCallbacks
and resumePostAttachCallbacks so post-attach callbacks happen late
enough. Before, they could run inside the base attach function.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach): Added calls to
suspendPostAttachCallbacks and resumePostAttachCallbacks so
post-attach callbacks happen late enough
- page/Frame.cpp:
(WebCore::Frame::revealSelection): Added code to trigger a layout
when it's needed.
- 5:32 PM Changeset in webkit [52777] by
-
- 1 edit in trunk/WebCore/ChangeLog
erk, demangle the ChangeLog!
- 5:24 PM Changeset in webkit [52776] by
-
- 13 edits3 adds in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.
Reviewed by Sam Weinig, additional coding by Mark Rowe.
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/UStringImpl.cpp:
- runtime/UStringImpl.h:
(JSC::UStringImpl::computeHash):
- wtf/HashFunctions.h:
- wtf/StringHashFunctions.h: Added.
(WTF::stringHash):
JavaScriptGlue: Add a forwarding header so that StringHashFunctions.h can be found.
Reviewed by Sam Weinig.
- ForwardingHeaders/wtf/StringHashFunctions.h: Added.
WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.
Patch by Mark Rowe <mrowe@apple.com> on 2010-01-04
Reviewed by Sam Weinig.
- ForwardingHeaders/wtf/StringHashFunctions.h: Added.
- platform/text/StringHash.h:
- platform/text/StringImpl.h:
(WebCore::StringImpl::computeHash):
- 5:21 PM Changeset in webkit [52775] by
-
- 5 edits3 adds in trunk/WebKit/chromium
2010-01-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Adding WebAnimationController to chromium's WebKit API.
- WebKit.gyp:
- public/WebAnimationController.h: Added. (WebKit::WebAnimationController::~WebAnimationController):
- public/WebFrame.h:
- src/WebAnimationControllerImpl.cpp: Added. (WebKit::WebAnimationControllerImpl::WebAnimationControllerImpl): (WebKit::WebAnimationControllerImpl::pauseAnimationAtTime): (WebKit::WebAnimationControllerImpl::pauseTransitionAtTime): (WebKit::WebAnimationControllerImpl::numberOfActiveAnimations):
- src/WebAnimationControllerImpl.h: Added. (WebKit::WebAnimationControllerImpl::~WebAnimationControllerImpl):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::animationController): (WebKit::WebFrameImpl::WebFrameImpl):
- src/WebFrameImpl.h:
- 5:12 PM Changeset in webkit [52774] by
-
- 5 edits in trunk/WebKit/chromium
2010-01-04 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher
Adding more DOM API methods. They are needed for the upcoming
translate feature.
- public/WebElement.h:
- public/WebNode.h:
- src/WebElement.cpp: (WebKit::WebElement::tagName): (WebKit::WebElement::setAttribute):
- src/WebNode.cpp: (WebKit::WebNode::setNodeValue):
- 5:12 PM Changeset in webkit [52773] by
-
- 14 edits2 adds in trunk
MSAA: <select> elements should broadcast value change events
https://bugs.webkit.org/show_bug.cgi?id=33088
<rdar://problem/7332364>
Reviewed by Darin Adler.
WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postNotification):
If the post type is async, follow the old code path; otherwise, call
postPlatformNotification().
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
Added a new accessibility notification, AXMenuListValueChanged. Added
a new parameter to postNotification() to specify whether the post should
be synchronous or asynchronous.
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
If the WebCore notification is AXMenuListValueChanged, broadcast an
EVENT_OBJECT_VALUECHANGE event.
- dom/SelectElement.cpp:
(WebCore::SelectElement::setSelectedIndex):
When the selected index of a RenderMenuList is changed, call
RenderMenuList::didSetSelectedIndex().
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
Initialize new member
(WebCore::RenderMenuList::didSetSelectedIndex):
If the selected index has changed, post AXMenuListValueChanged to the
object synchronously.
- rendering/RenderMenuList.h:
Declare didSetSelectedIndex(), and add a member to hold the last
selected index.
WebKitTools:
- DumpRenderTree/AccessibilityController.cpp:
(logValueChangeEventsCallback):
Start logging value change events.
(AccessibilityController::getJSClass):
Add a "logValueChangeEvents" to the AccessibilityController's JS class
definition.
(AccessibilityController::resetToConsistentState):
Disable logging of value change events.
- DumpRenderTree/AccessibilityController.h:
Declare setLogValueChangeEvents(), and add a member variable for the
value change event hook.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogValueChangeEvents):
Stubbed.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::setLogValueChangeEvents):
Stubbed.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize new member var.
(AccessibilityController::~AccessibilityController):
Disable logging of value change events.
(logEventProc):
When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
and its value.
(AccessibilityController::setLogValueChangeEvents):
If disabling logging, unhook the event, and clear the event hook
member var. Otherwise, query for the root element to enable
accessibility, and hook EVENT_OBJECT_VALUECHANGE.
LayoutTests:
- platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
- platform/win/accessibility/select-element-valuechange-event.html: Added.
- 5:07 PM Changeset in webkit [52772] by
-
- 3 edits2 adds in trunk
WebCore: Added missing null check in BarInfo code.
Reviewed by Sam Weinig.
Test: fast/dom/Window/BarInfo-after-frame-removed.html
- page/BarInfo.cpp:
(WebCore::BarInfo::visible): Added null check. A few other
cleanups.
LayoutTests: Added test for use of BarInfo object after a frame is no longer
associated with a web page.
Reviewed by Sam Weinig.
- fast/dom/Window/BarInfo-after-frame-removed-expected.txt: Added.
- fast/dom/Window/BarInfo-after-frame-removed.html: Added.
- 5:04 PM Changeset in webkit [52771] by
-
- 2 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
long_help for submit-patch
https://bugs.webkit.org/show_bug.cgi?id=33184
- Scripts/webkitpy/commands/upload.py:
- 4:54 PM Changeset in webkit [52770] by
-
- 2 edits1 delete in trunk/WebCore
Rubber-stamped by Jon Honeycutt.
Delete an empty and unused JavaScript file.
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/InspectorControllerStub.js: Removed.
- 4:27 PM Changeset in webkit [52769] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, add a couple include dirs to the build.
- 4:13 PM Changeset in webkit [52768] by
-
- 9 edits in trunk
Roll out r52758 as it accidentally the whole build.
- 3:50 PM Changeset in webkit [52767] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33181
The first letter is not removed properly from inline input hole
- WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was confirmed, cancel it.
- 3:48 PM Changeset in webkit [52766] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Part of a build fix for Windows, this at least gets WTF to build.
- 3:18 PM Changeset in webkit [52765] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/unicode/Unicode.h:
Reviewed by NOBODY (more speculative build fix).
- 3:13 PM Changeset in webkit [52764] by
-
- 2 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue can wrongly reject patches if the buildbots are behind
https://bugs.webkit.org/show_bug.cgi?id=30098
Check to make sure we can currently build and test before trying to
land a patch.
- Scripts/webkitpy/commands/queues.py:
- 3:05 PM Changeset in webkit [52763] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, attempt to fix ARM bulid.
- wtf/Platform.h:
- 2:49 PM Changeset in webkit [52762] by
-
- 6 edits in trunk/JavaScriptCore
Rubber stamped by Geoff Garen.
Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).
- API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
- runtime/Identifier.h:
(JSC::Identifier::add):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
- 2:42 PM Changeset in webkit [52761] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/HashFunctions.h:
Reviewed by NOBODY build fix for DRT, fix incorrect style include.
- 2:30 PM Changeset in webkit [52760] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY Windows build fix.
- 2:09 PM Changeset in webkit [52759] by
-
- 2 edits in trunk/WebCore
Windows build fix
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 2:00 PM Changeset in webkit [52758] by
-
- 7 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- runtime/UStringImpl.cpp:
- runtime/UStringImpl.h:
(JSC::UStringImpl::computeHash):
- wtf/HashFunctions.h:
(WTF::stringHash):
WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.
Reviewed by Sam Weinig.
- platform/text/StringImpl.h:
(WebCore::StringImpl::computeHash):
- 1:50 PM Changeset in webkit [52757] by
-
- 5 edits4 adds in trunk
2010-01-04 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Repaint issues in text input under a scale transform
https://bugs.webkit.org/show_bug.cgi?id=32086
When doing a subtree layout we have to look up the container chain to see if there
are any properties, such as transforms or reflections, that mean that we are unable
to use layoutState.
Test: fast/repaint/subtree-layoutstate-transform.html
- page/FrameView.cpp: (WebCore::FrameView::layout): Call canUseLayoutStateForSubtree() to determine whether it's OK to use layoutState.
- rendering/RenderView.h:
- rendering/RenderView.cpp: (WebCore::RenderView::canUseLayoutStateForSubtree): New method that reports whether it's OK to use layoutState when doing a subtree layout from the given root.
- 1:49 PM Changeset in webkit [52756] by
-
- 8 edits2 adds in trunk
WebCore: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974
Reviewed by Dan Bernstein.
Test: fast/forms/selection-layout-reentry-strange-case.html
Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.
- dom/Document.cpp:
(WebCore::Document::updateLayout): Changed this to use the
definition of needsLayout from FrameView rather than rolling
its own.
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.
- editing/SelectionController.h: Added setNeedsDisplayUpdate,
needsDisplayUpdate, and m_needsDisplayUpdate.
- page/Frame.cpp:
(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function. Also added a global reentrancy check
since that's the easiest way I could think of to prevent infinite
recursion in the case where recomputeCaretRect ends up triggering
a layout. As a side effect, fixed theoretical problems in
TEXT_CARET builds by improving the ifdef.
(WebCore::Frame::caretBlinkTimerFired): Loosen assertions a
bit. Later we might want to decouple caret rect from caret state
a bit more and add these assertions back.
(WebCore::Frame::selectionBounds): Call Document::updateLayout.
This function is for external clients and they do not currently
do anything to make sure layout is up to date.
- page/FrameView.cpp:
(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.
LayoutTests: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974
Reviewed by Dan Bernstein.
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
- fast/forms/selection-layout-reentry-strange-case.html: Added.
- platform/mac/accessibility/frame-with-title-expected.txt: Updated since
the number of layouts is now different.
- 1:30 PM Changeset in webkit [52755] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33161
Assertion failure in WebView when using Chinese Simplified IME
- WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode check. We can't make assertions about arguments passed from outside WebKit.
- 1:27 PM Changeset in webkit [52754] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33157
Implement TextInput logging channel on Windows
- WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
- WebKitLogging.h: Added a TextInput channel in place of unused Network one.
- WebView.cpp: (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward it to DefWindowProc, so there is no need to return an unused boolean result for "handled". (WebView::onIMEStartComposition): Added logging. (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition. (imeNotificationName): A helper function for detailed logging in onIMENotify. (imeRequestName): A helper function for detailed logging in onIMERequest. (WebView::onIMEComposition): Added logging. (WebView::onIMEEndComposition): Ditto. (WebView::onIMEChar): Ditto. (WebView::onIMENotify): Ditto. (WebView::onIMERequestCharPosition): Changed to return result directly. (WebView::onIMERequestReconvertString): Ditto. (WebView::onIMERequest): Changed to return result directly. Added logging. (WebView::onIMESelect): Added logging. (WebView::onIMESetContext): Added logging.
- WebView.h: onIMERequest functions now return result directly.
- 1:19 PM Changeset in webkit [52753] by
-
- 3 edits11 adds in trunk
Add a test harness for the Windows WebKit API, and a few tests
We currently only have tests for a handful of bugs regarding WebView
destruction, but more tests can easily be added later. Eventually
we'll run these tests as part of run-webkit-tests.
Fixes <http://webkit.org/b/33167>.
Reviewed by Sam Weinig.
WebKit/win:
- WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
after DumpRenderTree.vcproj.
WebKitTools:
- WebKitAPITest/HostWindow.cpp: Added.
(WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
(WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
needed.
(WebKitAPITest::HostWindow::initialize): Create our window.
(WebKitAPITest::HostWindow::clientRect): Return our window's client
rect.
(WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
(WebKitAPITest::HostWindow::wndProc): Just call through to
DefWindowProcW.
- WebKitAPITest/HostWindow.h: Added.
(WebKitAPITest::HostWindow::window): Simple getter.
- WebKitAPITest/Test.h: Added. This file defines some macros useful
for writing tests.
- WebKitAPITest/TestsController.cpp: Added.
(WebKitAPITest::TestsController::TestsController): Initialize our
members.
(WebKitAPITest::TestsController::shared): Return the shared instance.
(WebKitAPITest::TestsController::runAllTests): Run a message pump
until a WM_QUIT message is received, then return whether all tests
succeeded.
(WebKitAPITest::TestsController::addTest): Add the test to m_tests and
start running tests soon.
(WebKitAPITest::TestsController::testFailed): Record the failure and
print a message about it to stdout.
(WebKitAPITest::TestsController::runNextTest): If we don't have any
tests to run, post a WM_QUIT message to stop the message pump.
Otherwise, run the test and print whether it passed, then schedule the
next test.
(WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
to run the next test.
(WebKitAPITest::TestsController::registerWindowClass): Does what it
says.
(WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
fired, call runNextTest(). Pass everything else through to
DefWindowProcW.
- WebKitAPITest/TestsController.h: Added.
- WebKitAPITest/WebKitAPITest.vcproj: Added.
- WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
- WebKitAPITest/main.cpp: Added.
(main): (Mostly) just calls TestsController::runAllTests.
- WebKitAPITest/tests/WebViewDestruction.cpp: Added.
(WebKitAPITest::WebKitCreateInstance): Helper function template to
call through to the real WebKitCreateInstance.
(WebKitAPITest::webViewCount): Helper function to call through to
IWebKitStatistics::webViewCount.
(WebKitAPITest::createWebView): Helper function to create a WebView
and put it inside a HostWindow.
(WebKitAPITest::runMessagePump): Helper function to run a message pump
for a specified number of milliseconds, or until a WM_QUIT message is
received.
(WebKitAPITest::CloseWithoutDestroyWindow): Test for
<http://webkit.org/b/32827>.
(WebKitAPITest::MainFrameAfterClose): Test for
<http://webkit.org/b/32868>.
(WebKitAPITest::NoCloseOrDestroyWindow): Test for
<http://webkit.org/b/33162>.
- 12:28 PM Changeset in webkit [52752] by
-
- 2 edits in trunk/WebCore
Correct debug assertion (and possible runtime errors) by
checking validity of bitmap settings used to create
the Windows Cairo contexts.
https://bugs.webkit.org/show_bug.cgi?id=33164.
Reviewed by Adam Roben.
- platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::createCairoContextWithHDC): Check validity of selected
OBJ_BITMAP retrieved, and only create 32-bit context when
a valid bitmap is provided.
- 12:12 PM BuildingQtOnWindows edited by
- --makeargs=j4 should be --makeargs=-j4 (note the dash that precedes … (diff)
- 11:18 AM Changeset in webkit [52751] by
-
- 9 edits1 add in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33158
Refactor JSC API entry/exit to use RAII instead of copy/pasting code.
Make it easier to change set of actions taken when passing across the API boundary.
Reviewed by Sam "Shimmey Shimmey" Weinig.
- API/APIShims.h: Added.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h:
(JSC::::init):
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):
- API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:06 AM Changeset in webkit [52750] by
-
- 39 edits11 deletes in trunk
Not reviewed, revert r52745 and r52746 on behalf of Nikolas Zimmermann, as discussed on IRC.
Patch produced by 'git revert' and then reverting back ChangeLog files.
- 10:55 AM Changeset in webkit [52749] by
-
- 13 edits in trunk
Updated copyright string
Reviewed by Ada Chan and Mark Rowe.
- Info.plist:
- JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
JavaScriptGlue:
- Info.plist:
WebCore:
- Info.plist:
- WebCore.vcproj/QTMovieWin.rc:
WebKit/mac:
- Info.plist:
WebKit/win:
- WebKit.vcproj/WebKit.rc:
- 10:54 AM Changeset in webkit [52748] by
-
- 3 edits2 adds in trunk
AX: any DIV with an aria role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=33090
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-divs-not-ignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
- platform/mac/accessibility/aria-divs-not-ignored-expected.txt: Added.
- platform/mac/accessibility/aria-divs-not-ignored.html: Added.
- 10:46 AM Changeset in webkit [52747] by
-
- 6 edits in trunk/WebCore
2010-01-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate declarations for V8 runtime enablers.
- bindings/scripts/CodeGeneratorV8.pm: Generate runtime enabler declarations.
- bindings/v8/custom/V8CustomBinding.h: Remove manual declarations of runtime enablers.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8WebSocketCustom.cpp: Remove closeCallback(), which isn't actually being used.
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- 9:46 AM Changeset in webkit [52746] by
-
- 2 edits in trunk/WebCore
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Forgot to add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to Chromium build.
- WebCore.gypi:
- 9:31 AM Changeset in webkit [52745] by
-
- 38 edits11 adds in trunk
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012
Rewrite marker code, as it had many issues:
- Correct refX/refY handling (covered by new marker-referencePoint.svg test)
- Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
- Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
- Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)
Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.
Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg
svg/custom/marker-opacity.svg
- Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
- GNUmakefile.am: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
- rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
- rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
- rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
- rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
- rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
- rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
- rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
- rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
- svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
- svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
- svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
- 9:29 AM Changeset in webkit [52744] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-04 Adam Roben <Adam Roben>
No review, rolling out r52741.
http://trac.webkit.org/changeset/52741
https://bugs.webkit.org/show_bug.cgi?id=33056
- wtf/AlwaysInline.h:
- 9:20 AM Changeset in webkit [52743] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-04 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Add cacheFlush support for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33110
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- 9:09 AM Changeset in webkit [52742] by
-
- 2 edits in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo in test name.
- platform/win/Skipped:
- 9:06 AM Changeset in webkit [52741] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-04 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056
- wtf/AlwaysInline.h:
- 8:50 AM Changeset in webkit [52740] by
-
- 3 edits1 add in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update two win-specific test results, that showed up on the Windows Release/Debug slave.
Skip fast/frames/iframe-onload-remove-self-no-crash.html as it crashes the debug slave, filed bug.
All bots except SnowLeopard Leaks & GTK Linux Debug (32-bit) should turn to green now!
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt:
- platform/win/fast/forms/basic-selects-expected.txt: Added.
- platform/win/Skipped:
- 8:12 AM Changeset in webkit [52739] by
-
- 7 edits1 add in trunk/WebKitTools
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=32820
- Scripts/VCSUtils.pm:
- Scripts/svn-apply:
- Scripts/svn-unapply:
- Scripts/test-webkitperl: Run gitdiff2svndiff test
- Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
- Scripts/webkitpy/diff_parser.py:
- Scripts/webkitpy/diff_parser_unittest.py:
- 8:01 AM Changeset in webkit [52738] by
-
- 3 edits in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Bring back Tiger bot to green: svg/custom/use-on-symbol-inside-pattern.svg exposes a bug on both Tiger & Win.
Reopened bug 17393 and skipping this test for now, as it requires a larger rework of Path::debugString().
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 7:54 AM Changeset in webkit [52737] by
-
- 2 edits in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to mark all Gtk bots green again, as discussed with Gustavo Noronha Silva.
- platform/gtk/Skipped:
- 7:48 AM Changeset in webkit [52736] by
-
- 2 edits in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skipping plugins/get-url-with-iframe-target.html, filed bug 33154, cc'ing the original author.
- platform/mac-tiger/Skipped:
- 7:42 AM Changeset in webkit [52735] by
-
- 2 edits in trunk/LayoutTests
2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skipping http/tests/navigation/*iframe* on Tiger, just like it has been done for win.
- platform/mac-tiger/Skipped:
- 7:37 AM Changeset in webkit [52734] by
-
- 5 edits in trunk
[Qt] Fix standalone package builds.
Reviewed by Tor Arne Vestbø.
.:
- WebKit.pri: Add logic for detecting standalone builds. Set OUTPUT_DIR to the top-level dir in that case.
- WebKit.pro: Don't build JSC and DRT for package builds.
WebCore:
- WebCore.pro: Moved logic for detecting standalone builds to WebKit.pri. Set DESTDIR for package builds.
- 7:33 AM Changeset in webkit [52733] by
-
- 2 edits in trunk/WebCore
2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=29048
[Qt] make RenderStyle.h compile in winscw compiler.
Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
error when compareEqual is defined as template.
The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447
- rendering/style/RenderStyle.h:
- 6:59 AM Changeset in webkit [52732] by
-
- 3 edits2 moves4 adds in trunk/WebKitTools
Divided the Perl unit tests into separate files and put
them in a separate directory, and renamed test-webkit-perl
to test-webkitperl.
Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-04
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=33124
- Scripts/VCSUtils.pm:
- Renamed generateRunPatchCommand() to generatePatchCommand().
- Scripts/VCSUtils_unittest.pl: Removed.
- Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
- Scripts/test-webkit-perl: Removed.
- Renamed to test-webkitperl.
- Scripts/test-webkit-scripts:
- Updated paths to test-webkitpy and test-webkitperl.
- Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
- Added paths to new test files.
- Scripts/webkitperl: Added.
- Scripts/webkitperl/VCSUtils_unittest: Added.
- Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
- Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
- Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
- 5:18 AM Changeset in webkit [52731] by
-
- 5 edits in trunk
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Hausmann.
Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148
- runtime/JSCell.cpp: (JSC::):
- runtime/JSValue.h: (JSC::JSValue::):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Hausmann.
Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel):
- 4:01 AM Changeset in webkit [52730] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Document CPU() macros in comments.
https://bugs.webkit.org/show_bug.cgi?id=33147
- wtf/Platform.h:
- 3:59 AM Porting Macros plan edited by
- (diff)
- 3:38 AM Changeset in webkit [52729] by
-
- 42 edits in trunk
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
ExecutableAllocatorSymbian appears to have buggy ARM version check
https://bugs.webkit.org/show_bug.cgi?id=33138
- wtf/Platform.h: Rename all macros related to detection of particular CPUs or classes of CPUs to CPU(), reorganize and document them.
All remaining changes are adapting to the renames, plus fixing the
second bug cited above.
- assembler/ARMAssembler.cpp:
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.cpp:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86Common.h:
- assembler/MacroAssemblerX86_64.h:
- assembler/X86Assembler.h: (JSC::X86Registers::): (JSC::X86Assembler::): (JSC::X86Assembler::movl_mEAX): (JSC::X86Assembler::movl_EAXm): (JSC::X86Assembler::repatchLoadPtrToLEA): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/ExecutableAllocatorPosix.cpp:
- jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::intializePageSize):
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITArithmetic.cpp:
- jit/JITInlineMethods.h: (JSC::JIT::beginUninterruptedSequence): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::emitCount):
- jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- jit/JITStubs.h:
- runtime/Collector.cpp: (JSC::currentThreadStackBase): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
- wrec/WREC.h:
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateReturnFailure):
- wrec/WRECGenerator.h:
- wtf/FastMalloc.cpp:
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
- wtf/Threading.h:
- wtf/dtoa.cpp:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- yarr/RegexJIT.h:
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
- webkit/webkitwebsettings.cpp: (webkit_get_user_agent):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
- page/NavigatorBase.cpp:
- platform/text/AtomicString.cpp: (WebCore::equal):
- platform/text/StringHash.h: (WebCore::StringHash::equal):
- 3:37 AM Changeset in webkit [52728] by
-
- 4 edits in trunk/WebKitTools
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make bugzilla-tool rollout include a bug link in the ChangeLog entry
https://bugs.webkit.org/show_bug.cgi?id=33146
One more step towards better rollouts.
- Scripts/webkitpy/changelogs.py:
- Scripts/webkitpy/changelogs_unittest.py:
- Scripts/webkitpy/steps/preparechangelogforrevert.py:
- 3:04 AM Changeset in webkit [52727] by
-
- 2 edits in trunk/WebCore
2009-12-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661
Reverted the SENTINEL / NULL crap :) Hopefully the style-bot won't
complain about NULL usage in g_object_{get,set} anymore.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- 3:04 AM Changeset in webkit [52726] by
-
- 2 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sort the step options
https://bugs.webkit.org/show_bug.cgi?id=33144
- Scripts/webkitpy/steps/options.py:
- 2:57 AM Changeset in webkit [52725] by
-
- 4 edits in trunk/WebKitTools
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Need support for longer text in per-command help
https://bugs.webkit.org/show_bug.cgi?id=33143
Add some minimal additional help to land-diff and
pave the way for adding better help to all commands.
- Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
- Scripts/webkitpy/multicommandtool.py: support long_help
- Scripts/webkitpy/multicommandtool_unittest.py: test long_help
- 2:46 AM Changeset in webkit [52724] by
-
- 4 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add unit test for MarkBugFixed
https://bugs.webkit.org/show_bug.cgi?id=33142
MarkBugFixed is way behind in command technology, but it still needs a
unit test, as the FIXME commands.
Also, remove mark-bug-fixed and create-bug from main help since we have
more modern commands to replace them.
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- 2:24 AM Changeset in webkit [52723] by
-
- 2 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- 2:05 AM Changeset in webkit [52722] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
[Qt] r52694 moved a test, but it isn't renamed in the skiplist.
- platform/qt/Skipped: animations/transform-origin-vs-functions.html renamed.
- 1:58 AM Changeset in webkit [52721] by
-
- 8 edits6 adds in trunk
2010-01-04 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Added expected outputs for pixel tests that were missing.
- platform/mac/mathml/presentation/sub-expected.checksum: Added.
- platform/mac/mathml/presentation/sub-expected.png: Added.
- platform/mac/mathml/presentation/sup-expected.checksum: Added.
- platform/mac/mathml/presentation/sup-expected.png: Added.
- platform/mac/mathml/presentation/tables-expected.checksum: Added.
- platform/mac/mathml/presentation/tables-expected.png: Added.
2010-01-04 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Updated license to match recommended header license.
- mathml/MathMLElement.cpp:
- mathml/MathMLElement.h:
- mathml/MathMLInlineContainerElement.cpp:
- mathml/MathMLInlineContainerElement.h:
- mathml/MathMLMathElement.cpp:
- mathml/MathMLMathElement.h:
- 1:49 AM Changeset in webkit [52720] by
-
- 3 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- 1:48 AM Changeset in webkit [52719] by
-
- 3 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove raw_input from queues in favor of user.prompt
https://bugs.webkit.org/show_bug.cgi?id=33140
This lets up properly mock out the user interaction instead of hacking
around it with the options.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queuestest.py:
- 1:42 AM Porting Macros plan edited by
- (diff)
- 1:42 AM Changeset in webkit [52718] by
-
- 6 edits1 add1 delete in trunk
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635
- .gitignore: Ignore autoinstall.cache.d directory created by autoinstall.py
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635
Use the nifty "autoinstall" module from Daniel Krech:
http://pypi.python.org/pypi/autoinstall/0.2
http://code.google.com/p/pyautoinstall/
It's available under a WebKit-compatible BSD license.
- Scripts/webkitpy/init.py:
- bind "mechanize" to an autoinstall importer which will auto-download mechanize if necessary.
- Scripts/webkitpy/autoinstall.py: Added.
- Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
- Scripts/webkitpy/statusbot.py: ditto.
- Scripts/webkitpy/webkit_mechanize.py: Removed.
- 1:33 AM Changeset in webkit [52717] by
-
- 3 edits1 add in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Move AbstractSequencedCommand to a more general location
https://bugs.webkit.org/show_bug.cgi?id=33137
I do what the FIXME tell me to do.
- Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/upload.py:
- 1:30 AM Changeset in webkit [52716] by
-
- 7 edits1 move in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename StatusBot to StatusServer
https://bugs.webkit.org/show_bug.cgi?id=33139
It's not a bot. It's a server.
- Scripts/bugzilla-tool:
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/statusbot.py: Removed.
- 1:05 AM Changeset in webkit [52715] by
-
- 5 edits in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] submit-pach should have a -o/--open option to open the bug after submit
https://bugs.webkit.org/show_bug.cgi?id=33136
Python makes this very easy.
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/steps/options.py:
- Scripts/webkitpy/steps/postdiff.py:
- Scripts/webkitpy/user.py:
- 12:50 AM Porting Macros plan edited by
- (diff)
- 12:47 AM Changeset in webkit [52714] by
-
- 5 edits23 copies1 move8 adds1 delete in trunk/WebKitTools
2010-01-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Move steps to a submodule
https://bugs.webkit.org/show_bug.cgi?id=33135
For great victory. This will probably introduce some regressions
because our test coverage isn't perfect, but I've tried to be careful.
- Scripts/test-webkitpy:
- Scripts/webkitpy/buildsteps.py: Removed.
- Scripts/webkitpy/buildsteps_unittest.py: Removed.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/steps/init.py: Added.
- Scripts/webkitpy/steps/abstractstep.py: Added.
- Scripts/webkitpy/steps/applypatch.py: Added.
- Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
- Scripts/webkitpy/steps/build.py: Added.
- Scripts/webkitpy/steps/checkstyle.py: Added.
- Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
- Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
- Scripts/webkitpy/steps/closebug.py: Added.
- Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
- Scripts/webkitpy/steps/closepatch.py: Added.
- Scripts/webkitpy/steps/commit.py: Added.
- Scripts/webkitpy/steps/completerollout.py: Added.
- Scripts/webkitpy/steps/confirmdiff.py: Added.
- Scripts/webkitpy/steps/createbug.py: Added.
- Scripts/webkitpy/steps/editchangelog.py: Added.
- Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
- Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
- Scripts/webkitpy/steps/metastep.py: Added.
- Scripts/webkitpy/steps/obsoletepatches.py: Added.
- Scripts/webkitpy/steps/options.py: Added.
- Scripts/webkitpy/steps/postdiff.py: Added.
- Scripts/webkitpy/steps/preparechangelog.py: Added.
- Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
- Scripts/webkitpy/steps/promptforbugortitle.py: Added.
- Scripts/webkitpy/steps/revertrevision.py: Added.
- Scripts/webkitpy/steps/runtests.py: Added.
- Scripts/webkitpy/steps/steps_unittest.py: Added.
- Scripts/webkitpy/steps/update.py: Added.
- Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
- Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
- Scripts/webkitpy/stepsequence.py:
- 12:43 AM Changeset in webkit [52713] by
-
- 4 edits in trunk
2010-01-04 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows.
- QGVLauncher/main.cpp: (MainWindow::buildUI):
2010-01-04 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows. Also, renames the Tools menu to
Develop.
- QtLauncher/main.cpp: (MainWindow::setupUI):
- 12:40 AM Changeset in webkit [52712] by
-
- 3 edits in trunk/WebKitTools
2010-01-04 Daniel Bates <dbates@webkit.org>
Unreviewed fix.
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/credentials_unittest.py:
- 12:35 AM Changeset in webkit [52711] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Clean up COMPILER macros and remove unused ones.
https://bugs.webkit.org/show_bug.cgi?id=33132
Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
not used anywhere.
- wtf/Platform.h:
- 12:30 AM Changeset in webkit [52710] by
-
- 2 edits in trunk/WebKitTools
2010-01-04 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/credentials_unittest.py:
- 12:21 AM Changeset in webkit [52709] by
-
- 4 edits4 adds in trunk
2010-01-03 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091
It's neccessary to invalidate all resources of an object, if the attributes of this
target change. Otherwise the saved resource data (like ImageBuffers) don't match
to the new object properties.
Test: svg/custom/resource-invalidate-on-target-update.svg
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::invalidateResources):
- svg/SVGStyledElement.h:
2010-01-03 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091
Check if SVG resources are invalidated, if target object changes
attributes.
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
- svg/custom/resource-invalidate-on-target-update.svg: Added.
- 12:20 AM Changeset in webkit [52708] by
-
- 3 edits in trunk/WebKitTools
2010-01-04 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/credentials_unittest.py:
- 12:13 AM Changeset in webkit [52707] by
-
- 5 edits in trunk/WebKitTools
2010-01-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
https://bugs.webkit.org/show_bug.cgi?id=33131
Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
but for now we just deploy it everywhere and don't try to fix up the few valid uses
of Command.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/multicommandtool.py:
Jan 3, 2010:
- 11:40 PM Changeset in webkit [52706] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Update wtf/Platform.h to document the new system for porting macros.
https://bugs.webkit.org/show_bug.cgi?id=33130
- wtf/Platform.h:
- 11:15 PM Changeset in webkit [52705] by
-
- 2 edits in trunk/WebKitTools
2010-01-03 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Need to import ScriptError.
- Scripts/webkitpy/buildsteps.py:
- 11:08 PM Porting Macros plan edited by
- (diff)
- 11:08 PM Changeset in webkit [52704] by
-
- 7 edits in trunk/WebKitTools
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make it easier to run submit-patch when previous run cancelled
https://bugs.webkit.org/show_bug.cgi?id=33070
This patch renames create-review to submit-patch (as requested by
Maciej).
This patch makes it easier to run submit-patch after the user has
already cancelled a previous run of submit-patch by detecting when we
already have ChangeLogs and reading the bug number from them (and not
attempting to recreate them). Aside from performance and the extra
edit step, this command should not subsume post-dif.
Also, added a --email command line argument so that the output of
prepare-ChangeLog makes sense when it can't find the user's email
address.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/buildsteps.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/user.py:
- 11:04 PM Changeset in webkit [52703] by
-
- 38 edits2 moves in trunk/WebKitTools
2010-01-03 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename Scripts/modules to Scripts/webkitpy
https://bugs.webkit.org/show_bug.cgi?id=33128
Just search-replace and svn mv commands.
- Scripts/bugzilla-tool:
- Scripts/check-webkit-style:
- Scripts/modules: Removed.
- Scripts/modules/BeautifulSoup.py: Removed.
- Scripts/modules/init.py: Removed.
- Scripts/modules/bugzilla.py: Removed.
- Scripts/modules/bugzilla_unittest.py: Removed.
- Scripts/modules/buildbot.py: Removed.
- Scripts/modules/buildbot_unittest.py: Removed.
- Scripts/modules/buildsteps.py: Removed.
- Scripts/modules/buildsteps_unittest.py: Removed.
- Scripts/modules/changelogs.py: Removed.
- Scripts/modules/changelogs_unittest.py: Removed.
- Scripts/modules/commands: Removed.
- Scripts/modules/commands/init.py: Removed.
- Scripts/modules/commands/commandtest.py: Removed.
- Scripts/modules/commands/download.py: Removed.
- Scripts/modules/commands/download_unittest.py: Removed.
- Scripts/modules/commands/early_warning_system.py: Removed.
- Scripts/modules/commands/early_warning_system_unittest.py: Removed.
- Scripts/modules/commands/queries.py: Removed.
- Scripts/modules/commands/queries_unittest.py: Removed.
- Scripts/modules/commands/queues.py: Removed.
- Scripts/modules/commands/queues_unittest.py: Removed.
- Scripts/modules/commands/queuestest.py: Removed.
- Scripts/modules/commands/upload.py: Removed.
- Scripts/modules/commands/upload_unittest.py: Removed.
- Scripts/modules/comments.py: Removed.
- Scripts/modules/committers.py: Removed.
- Scripts/modules/committers_unittest.py: Removed.
- Scripts/modules/cpp_style.py: Removed.
- Scripts/modules/cpp_style_unittest.py: Removed.
- Scripts/modules/credentials.py: Removed.
- Scripts/modules/credentials_unittest.py: Removed.
- Scripts/modules/diff_parser.py: Removed.
- Scripts/modules/diff_parser_unittest.py: Removed.
- Scripts/modules/executive.py: Removed.
- Scripts/modules/executive_unittest.py: Removed.
- Scripts/modules/grammar.py: Removed.
- Scripts/modules/mock.py: Removed.
- Scripts/modules/mock_bugzillatool.py: Removed.
- Scripts/modules/multicommandtool.py: Removed.
- Scripts/modules/multicommandtool_unittest.py: Removed.
- Scripts/modules/outputcapture.py: Removed.
- Scripts/modules/patchcollection.py: Removed.
- Scripts/modules/queueengine.py: Removed.
- Scripts/modules/queueengine_unittest.py: Removed.
- Scripts/modules/scm.py: Removed.
- Scripts/modules/scm_unittest.py: Removed.
- Scripts/modules/statusbot.py: Removed.
- Scripts/modules/stepsequence.py: Removed.
- Scripts/modules/style: Removed.
- Scripts/modules/style.py: Removed.
- Scripts/modules/style_unittest.py: Removed.
- Scripts/modules/text_style.py: Removed.
- Scripts/modules/text_style_unittest.py: Removed.
- Scripts/modules/user.py: Removed.
- Scripts/modules/webkit_logging.py: Removed.
- Scripts/modules/webkit_logging_unittest.py: Removed.
- Scripts/modules/webkit_mechanize.py: Removed.
- Scripts/modules/webkitport.py: Removed.
- Scripts/modules/webkitport_unittest.py: Removed.
- Scripts/test-webkit-python: Removed.
- Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
- Scripts/validate-committer-lists:
- Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/bugzilla_unittest.py:
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/buildbot_unittest.py:
- Scripts/webkitpy/buildsteps.py:
- Scripts/webkitpy/buildsteps_unittest.py:
- Scripts/webkitpy/commands/commandtest.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/early_warning_system_unittest.py:
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/queries_unittest.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/queuestest.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/comments.py:
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/credentials_unittest.py:
- Scripts/webkitpy/executive.py:
- Scripts/webkitpy/executive_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/multicommandtool.py:
- Scripts/webkitpy/multicommandtool_unittest.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/queueengine_unittest.py:
- Scripts/webkitpy/scm.py:
- Scripts/webkitpy/scm_unittest.py:
- Scripts/webkitpy/statusbot.py:
- Scripts/webkitpy/stepsequence.py:
- Scripts/webkitpy/webkit_logging_unittest.py:
- Scripts/webkitpy/webkitport_unittest.py:
- 10:58 PM Porting Macros plan edited by
- (diff)
- 10:54 PM Porting Macros plan edited by
- (diff)
- 10:50 PM Porting Macros plan created by
- 10:49 PM WikiStart edited by
- (diff)
- 10:31 PM Changeset in webkit [52702] by
-
- 3 edits1 move1 add in trunk/WebKitTools
2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Added script to test both Perl and Python, and renamed
run-webkit-unittests to test-webkit-python.
- Scripts/VCSUtils_unittest.pl:
- Tweaked so it can be run from outside Scripts directory.
- Scripts/run-webkit-unittests: Removed.
- Renamed to test-webkit-python.
- Scripts/test-webkit-perl:
- Tweaked so it can be run from outside Scripts directory.
- Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
- Scripts/test-webkit-scripts: Added.
- Runs both test-webkit-perl and test-webkit-python.
- 7:12 PM Changeset in webkit [52701] by
-
- 5 edits in trunk/WebKitTools
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue/bugzilla-tool should build both Debug and Release
https://bugs.webkit.org/show_bug.cgi?id=28450
Add a --build-style command that lets the master process tell the child
process to build both debug and release. Eventually we want to teach
the test step to understand this option too, but that's a patch for
another day.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 6:40 PM Changeset in webkit [52700] by
-
- 4 edits2 adds in trunk
2010-01-03 Kenneth Russell <kbr@google.com>
Reviewed by Maciej Stachowiak.
Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748
Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.
- fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
- fast/canvas/webgl/index-validation-copies-indices.html: Added.
2010-01-03 Kenneth Russell <kbr@google.com>
Reviewed by Maciej Stachowiak.
Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748
Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.
Test: fast/canvas/webgl/index-validation-copies-indices.html
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
- html/canvas/WebGLBuffer.h:
- 6:32 PM Changeset in webkit [52699] by
-
- 6 edits in trunk
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123
Call out to ChromiumBridge to find out if cookies are enabled.
- platform/chromium/ChromiumBridge.h:
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123
Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!
- public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
- 6:24 PM Changeset in webkit [52698] by
-
- 11 edits in trunk
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068
This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.
No new tests because this is all minus lines.
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertWindowToV8Object):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068
This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.
- public/WebFrame.h:
- src/FrameLoaderClientImpl.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
- 6:17 PM Changeset in webkit [52697] by
-
- 4 edits in trunk
2010-01-03 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064
Unskip 5 tests that are fixed now.
- platform/qt/Skipped:
2010-01-03 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064
Unskip 5 tests that are fixed now.
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
- 6:10 PM Changeset in webkit [52696] by
-
- 2 edits in trunk/WebKitTools
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add test for previous typo fix
https://bugs.webkit.org/show_bug.cgi?id=33083
A trivial test for a trivial fix, as requested by Eric.
- Scripts/modules/bugzilla_unittest.py:
- 6:03 PM Changeset in webkit [52695] by
-
- 6 edits in trunk/WebKitTools
2010-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement mac-ews
https://bugs.webkit.org/show_bug.cgi?id=33072
The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/early_warning_system_unittest.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queuestest.py:
- Scripts/modules/mock_bugzillatool.py:
- 5:55 PM Changeset in webkit [52694] by
-
- 1 edit12 moves3 adds in trunk/LayoutTests
2010-01-03 Mario Bensi <mbensi@pleyo.com>
Reviewed by Simon Fraser.
create 3d directory and move tests dependent of 3D Rendering in this
directory.
- animations/3d: Added.
- animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
- animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
- animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
- animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
- animations/change-transform-in-end-event.html: Removed.
- animations/state-at-end-event-transform.html: Removed.
- animations/transform-origin-vs-functions-expected.txt: Removed.
- animations/transform-origin-vs-functions.html: Removed.
- 1:48 PM Changeset in webkit [52693] by
-
- 2 edits in trunk/LayoutTests
Skip test that fails on and off on the release bot.
- 1:25 PM Changeset in webkit [52692] by
-
- 6 edits in trunk/WebKitTools
Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.
Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=33098
- Scripts/VCSUtils.pm:
- Added generateRunPatchCommand().
- Added runPatchCommand().
- Added exitStatus() from webkitdirs.pm to address FIXME.
- Scripts/VCSUtils_unittest.pl:
- Added 10 unit tests for generateRunPatchCommand().
- Added 4 unit tests for runPatchCommand().
- Added callSilently() method.
- Scripts/svn-apply:
- Refactored applyPatch().
- Removed $pathScriptWasRunFrom global variable.
- Addressed issue where "--force" option was getting added twice.
- Scripts/svn-unapply:
- Refactored applyPatch().
- Removed $pathScriptWasRunFrom global variable.
- Added support for --force option.
- Enhanced to return meaningful exit status.
- Scripts/webkitdirs.pm:
- Moved exitStatus() implementation to VCSUtils.pm.
- 11:39 AM Changeset in webkit [52691] by
-
- 4 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Remove out of date commented out attributes in IDLs. We have implemented onpopstate.
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.idl:
- page/DOMWindow.idl:
- 11:36 AM Changeset in webkit [52690] by
-
- 2 edits in trunk/WebKit/qt
2009-12-31 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable all HTML5 persistent features for QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=33086
- QGVLauncher/main.cpp: Call enablePersistentStorage() (main):
- 9:45 AM Changeset in webkit [52689] by
-
- 5 edits in trunk/WebCore
2010-01-03 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Mark more filter effect as alphaImage if possible
https://bugs.webkit.org/show_bug.cgi?id=33111
Mark more effects as alphaImage if the previous effect is a
alphaImage. This can reduce the calculation on the next effect
like feGaussianBlur.
Test: This changes don't affect any LayoutTests and can't be tested
somehow, since the changes are 'invisible'.
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
Jan 2, 2010:
- 11:57 AM Changeset in webkit [52688] by
-
- 5 edits3 deletes in trunk/LayoutTests
2010-01-02 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up the XSSAuditor test directory by removing unnecessary test scripts.
The patch for bug #33107 added notifyDone() functionality to the script
echo-intertag.pl. So, we can substitute this script for scripts echo-intertag-and-notify.php,
echo-intertag-post-and-notify.pl, and echo-intertag-post.pl.
- http/tests/security/xssAuditor/link-opens-new-window.html: Modified to call script echo-intertag.pl.
- http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Removed.
- http/tests/security/xssAuditor/script-tag-post-control-char.html: Modified to call script echo-intertag.pl.
- http/tests/security/xssAuditor/script-tag-post-null-char.html: Modified to call script echo-intertag.pl.
- http/tests/security/xssAuditor/script-tag-post.html: Modified to call script echo-intertag.pl.
- 11:54 AM Changeset in webkit [52687] by
-
- 4 edits in trunk/LayoutTests
2010-01-02 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Removes the use of window.setTimeout from the XSSAuditor tests:
get-from-iframe.html and post-from-iframe.html by having the
script echo-intertag.pl (called by these tests) call
layoutTestController.notifyDone().
- http/tests/security/xssAuditor/get-from-iframe.html: Removes call of window.setTimeout.
- http/tests/security/xssAuditor/post-from-iframe.html: Ditto.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: If the query argument notifyDone is found, then the script will generate a JavaScript script to call layoutTestController.notifyDone().
Jan 1, 2010:
- 11:40 AM Changeset in webkit [52686] by
-
- 5 edits4 adds in trunk
2010-01-01 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Scrollbar of overflow:scroll div in compositing layer fails to render
https://bugs.webkit.org/show_bug.cgi?id=32439
When deciding whether a RenderLayer needs backing store, check whether it has
overflow controls that need painting.
Test: compositing/overflow/scrollbar-painting.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasOverflowControls):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
Dec 31, 2009:
- 8:42 PM QtWebKitPerformanceToolBackLog: edited by
- Document the new netsim in the perf suite. (diff)
- 12:03 PM Changeset in webkit [52685] by
-
- 2 edits in trunk/WebCore
2009-12-31 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546
Only show font menu items in rich text areas in the GTK+ port.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- 11:58 AM Changeset in webkit [52684] by
-
- 2 edits in trunk/WebCore
2009-12-31 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546
Don't show spell checking menu items in text areas in the GTK+ port.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- 11:10 AM QtWebKitBackportingFixes edited by
- Added svn rev# for bug 33082 (diff)
- 11:07 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:41 AM Changeset in webkit [52683] by
-
- 4 edits4 adds in trunk
<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
https://bugs.webkit.org/show_bug.cgi?id=33067
Reviewed by Simon Fraser.
WebCore:
Test: fast/repaint/table-cell-overflow.html
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::hasVisibleOverflow): Added.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before r47440.
LayoutTests:
- fast/repaint/table-cell-overflow-expected.checksum: Added.
- fast/repaint/table-cell-overflow-expected.png: Added.
- fast/repaint/table-cell-overflow-expected.txt: Added.
- fast/repaint/table-cell-overflow.html: Added.
- 10:07 AM Changeset in webkit [52682] by
-
- 2 edits in trunk/WebCore
2009-12-31 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Do not include Frame.h under WebCore/html/canvas
https://bugs.webkit.org/show_bug.cgi?id=33082
No new tests, as there is no new functionality.
- html/canvas/CanvasRenderingContext2D.cpp:
- 8:45 AM ApplicationsGtk edited by
- (diff)
- 8:38 AM Changeset in webkit [52681] by
-
- 3 edits in trunk/WebKitTools
2009-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement build-and-test
https://bugs.webkit.org/show_bug.cgi?id=33073
Some of the early warning system bots want to use build-and-test so
they can cover LayoutTests in addition to just compilation.
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- 4:49 AM Changeset in webkit [52680] by
-
- 5 edits in trunk/WebKitTools
2009-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Show mac-ews status on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=33076
Also make error status purple.
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py:
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/statusbubble.html:
- 12:35 AM Changeset in webkit [52679] by
-
- 2 edits in trunk/WebKitTools
2009-12-31 Adam Barth <abarth@webkit.org>
Unreviewed.
[bzt] REGRESSION: Bugzila is a typo
https://bugs.webkit.org/show_bug.cgi?id=33074
Eric should test his code before landing! :)
- Scripts/modules/bugzilla.py:
- 12:25 AM Changeset in webkit [52678] by
-
- 2 edits in trunk/WebKitTools
2009-12-31 Adam Barth <abarth@webkit.org>
Unreviewed. Fix the unit tests!
- Scripts/run-webkit-unittests:
Dec 30, 2009:
- 8:58 PM Changeset in webkit [52677] by
-
- 4 edits in trunk
2009-12-30 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
2009-12-30 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847
- platform/network/chromium/ResourceRequest.h:
- 4:12 PM Changeset in webkit [52676] by
-
- 2 edits in trunk/WebKit/chromium
Not reviewed. Trivial Chromium build fix.
Add static_cast<unsigned>() to fix signed/unsigned comparison warning.
- src/AutocompletePopupMenuClient.cpp:
(WebKit::AutocompletePopupMenuClient::selectionChanged):
- 3:54 PM Changeset in webkit [52675] by
-
- 3 edits in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Remove unused code from V8DOMWrapper.
- bindings/v8/V8DOMWrapper.cpp: Removed code that I added but it's no longer used.
- bindings/v8/V8DOMWrapper.h: Ditto.
- 3:47 PM Changeset in webkit [52674] by
-
- 4 edits in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Generate configuring undetectable collection.
https://bugs.webkit.org/show_bug.cgi?id=33063
Refactoring, covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationMasqueradeAsUndefined.
- bindings/v8/DerivedSourcesAllInOne.cpp: Touched to keep IB-based builds happy.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed hand-configuring.
- 3:08 PM Changeset in webkit [52673] by
-
- 15 edits in trunk
2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Dimitri Glazkov.
Autocomplete in Chromium now offers suggestions within the input element as a user
a) types text that produces some autocomplete suggestions, and
b) scrolls through suggested values in the menu
The suggested value is rendered but not exposed through JS unti the
user makes the final selection.
No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue): (WebKit::AutocompletePopupMenuClient::selectionChanged): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
- src/AutocompletePopupMenuClient.h:
2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Dimitri Glazkov.
Added ability for PopupMenuClient to signal when
a) selection changed, and
b) weather suggested value should be accepted when popup menu closes
No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.
- platform/PopupMenuClient.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection): (WebCore::PopupListBox::hidePopup):
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::menuUnmapped):
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
- platform/qt/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::hidePopup):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::hide):
- platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::OnMenuItemSelected):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::popupDidHide):
- rendering/RenderMenuList.h: (WebCore::RenderMenuList::selectionChanged):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::popupDidHide):
- rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged):
- 1:59 PM Changeset in webkit [52672] by
-
- 25 edits1 delete in trunk/WebCore
2009-12-30 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Auto-generate V8 bindings header declarations for
property accessor getter/setters, and remove a couple of
unnecessarily custom bindings that weren't properly declared
custom anyway.
- Android.v8bindings.mk: Remove V8NavigatorCustom.cpp.
- WebCore.gypi: Remove V8NavigatorCustom.cpp.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/custom/V8AttrCustom.cpp:
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8ClipboardCustom.cpp:
- bindings/v8/custom/V8CoordinatesCustom.cpp:
- bindings/v8/custom/V8CustomBinding.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
- bindings/v8/custom/V8SVGLengthCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- 1:24 PM Changeset in webkit [52671] by
-
- 4 edits1 move in trunk/LayoutTests
2009-12-30 Dirk Schulze <krit@webkit.org>
Reviewed by Anders Carlsson.
svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393
Reenable the test. It isn't failing anymore.
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.checksum:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- svg/custom/use-on-symbol-inside-pattern.svg: Copied from LayoutTests/svg/custom/use-on-symbol-inside-pattern.svg-disabled.
- svg/custom/use-on-symbol-inside-pattern.svg-disabled: Removed.
- 12:05 PM Changeset in webkit [52670] by
-
- 2 edits in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Touch DerivedSourcesAllInOne to avoid clobbering IB-based builds.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added a line-break.
- 11:28 AM Changeset in webkit [52669] by
-
- 4 edits1 delete in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Generate configuring of call-as-function callbacks.
https://bugs.webkit.org/show_bug.cgi?id=33061
Refactoring, covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added GenerateHeaderCustomCall and
GenerateImplementationCustomCall.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed all hand-configuring of call-as-function
callbacks.
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::V8HTMLAppletElement::callAsFunctionCallback): Added. (WebCore::V8HTMLEmbedElement::callAsFunctionCallback): Added. (WebCore::V8HTMLObjectElement::callAsFunctionCallback): Added.
- bindings/v8/custom/V8HTMLPlugInElementCustom.h: Removed.
- 11:26 AM Changeset in webkit [52668] by
-
- 8 edits3 adds in trunk
Reviewed by Kevin Ollivier.
Introduce wxWebSettings API interface for editing wxWebView / page settings.
https://bugs.webkit.org/show_bug.cgi?id=32956
- 10:37 AM Changeset in webkit [52667] by
-
- 16 edits2 moves in trunk/WebKitTools
2009-12-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
logging.py should be renamed to webkit_logging.py and eventually die
https://bugs.webkit.org/show_bug.cgi?id=33058
Change all imports of "logging" to webkit_logging,
except the ones which came from Google's cpp_lint.py and diff_parser.py
which clearly are assuming python's logging.py.
- Scripts/modules/bugzilla.py:
- Scripts/modules/buildbot.py:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/credentials.py:
- Scripts/modules/executive.py:
- Scripts/modules/multicommandtool.py:
- Scripts/modules/queueengine.py:
- Scripts/modules/scm.py:
- Scripts/modules/statusbot.py:
- Scripts/modules/stepsequence.py:
- Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
- Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
- 10:22 AM Changeset in webkit [52666] by
-
- 7 edits2 adds in trunk/WebCore
2009-12-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[v8] Move world-specific state out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=33034
This is the first step towards unifying the V8 implementation of
isolated worlds with the JSC implementation. We need an object to
encapulate all the world-specific bindings state. Previoulsy, we used
V8Proxy for this purpose (along with a million other things), but
there's a one-to-one mapping between V8Proxy objects and Frame objects.
This patch takes the world-specific state and moves it to a new object,
affectionately called V8DOMWindowShell. This object is the moral
equivalent of JSDOMWindowShell but with more data members because life
is more complicated in V8-land.
This patch is almost entirely code motion. Future patches will clean
up this class as we use it to represent window shells in isolated
worlds as well as the main world.
- WebCore.gypi:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::updateDocument):
- bindings/v8/V8DOMWindowShell.cpp: Added. (WebCore::handleFatalErrorInV8): (WebCore::reportFatalErrorInV8): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::isContextInitialized): (WebCore::V8DOMWindowShell::disposeContextHandles): (WebCore::V8DOMWindowShell::destroyGlobal): (WebCore::V8DOMWindowShell::clearForClose): (WebCore::V8DOMWindowShell::clearForNavigation): (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::installDOMWindow): (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::clearDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::V8DOMWindowShell::clearDocumentWrapperCache): (WebCore::V8DOMWindowShell::setSecurityToken): (WebCore::V8DOMWindowShell::updateDocument): (WebCore::V8DOMWindowShell::updateSecurityOrigin): (WebCore::V8DOMWindowShell::getHiddenObjectPrototype): (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): (WebCore::V8DOMWindowShell::createWrapperFromCacheSlowCase):
- bindings/v8/V8DOMWindowShell.h: Added. (WebCore::V8DOMWindowShell::context): (WebCore::V8DOMWindowShell::createWrapperFromCache):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell): (WebCore::V8Proxy::extensions):
- 9:50 AM Changeset in webkit [52665] by
-
- 6 edits in trunk
2009-12-30 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054
Added invalidate() to SVGResourceClipper to reset clipData
and drawing area after attribute changes.
This fixes two LayoutTests.
- svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::invalidate):
- svg/graphics/SVGResourceClipper.h:
2009-12-30 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054
Drawing area should change after attribute changes in clipPath or
it's childs.
- platform/mac/svg/custom/clip-path-child-changes-expected.txt:
- platform/mac/svg/custom/clip-path-units-changes-expected.txt:
- 9:42 AM Changeset in webkit [52664] by
-
- 3 edits in trunk/WebCore
2009-12-30 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] RenderThemeQt::applyTheme is a misnomer and is suboptimally coded.
This patch:
- renames RenderThemeQt::applyTheme to initializeCommonQStyleOptions,
- extracts the palette initialization code to a separate function in order to provide for readable pointer checking and moves this code up in the function to allow for future changes to the palette brushes needed for bug 30173,
- optimizes some of the code in the function for readability, speed and size.
- fixes some minor style issues
No new tests because code behavior is not changed.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::initPaletteFromPageClientIfExists): (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
- platform/qt/RenderThemeQt.h:
- 8:49 AM Changeset in webkit [52663] by
-
- 6 edits in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Generate configuring of all indexers.
https://bugs.webkit.org/show_bug.cgi?id=33031
Refactorig, covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added generation of indexers for
special cases.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom tempalte configuration of
indexers.
- bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object
elements (these will be generated, too -- later.)
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectIndexedGetter): Moved common code to a separate method. (WebCore::npObjectIndexedSetter): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
- 8:43 AM Changeset in webkit [52662] by
-
- 8 edits in trunk
2009-12-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724
This change fixes the build break. Some QtWebKit interfaces
will not be fully functional (most notable QWebInspector) if
INSPECTOR is disabled.
- Api/qwebinspector.cpp: (QWebInspector::showEvent): (QWebInspector::closeEvent):
- Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPagePrivate::getOrCreateInspector): (QWebPagePrivate::inspectorController): (QWebPage::triggerAction): (QWebPage::updatePositionDependentActions):
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):
2009-12-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724
This makes the r48430 available for other ports as well.
No new tests, as there is no new functionality.
- inspector/InjectedScriptHost.idl: Guard the interface with INSPECTOR guard.
- inspector/InspectorBackend.idl: Ditto.
- inspector/InspectorFrontendHost.idl: Ditto.
- 8:13 AM Changeset in webkit [52661] by
-
- 6 edits in trunk/WebCore
2009-12-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Generate configuring of all named property getters/setters/enumerators.
https://bugs.webkit.org/show_bug.cgi?id=32996
Refactoring, covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added generation of named property handlers
for special cases (See bug for more info).
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom template configuration of named
property handlers.
- bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object
elements (these will be generated, too -- later.)
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectNamedGetter): Moved common code to a separate method. (WebCore::npObjectNamedSetter): Ditto. (WebCore::NAMED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
- 6:58 AM Changeset in webkit [52660] by
-
- 4 edits in trunk
2009-12-30 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052
The function should actually rewrite the given file to the buffer.
This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile):
2009-12-30 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052
The function should actually rewrite the given file to the buffer.
This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.
- platform/qt/Skipped:
- 6:30 AM Changeset in webkit [52659] by
-
- 2 edits in trunk/WebKitTools
2009-12-30 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
https://bugs.webkit.org/show_bug.cgi?id=33051
Moreover, its primary function is to normalize the path in regard of platform
specific directory separators. Therefore, it can simply make use of the
QDir::toNativeSeparators function.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pathToLocalResource):
- 6:16 AM Changeset in webkit [52658] by
-
- 3 edits in trunk/WebKitTools
Fix executable bits for r52646
- Scripts/VCSUtils_unittest.pl: Added property svn:executable.
- Scripts/test-webkit-perl: Ditto.
- 6:12 AM Changeset in webkit [52657] by
-
- 3 edits in trunk/WebCore
[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.
https://bugs.webkit.org/show_bug.cgi?id=32121
The implementation appears to either run into an ASSERT
or leak memory at runtime as the m_buffer, m_reader may
already exist. The bug was reopened and we do have a plan now.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
- platform/graphics/qt/ImageDecoderQt.h:
- 5:09 AM Changeset in webkit [52656] by
-
- 2 edits in trunk/LayoutTests
2009-12-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skipping isolatedWorld test - we still do not support that.
- platform/gtk/Skipped:
- 4:58 AM Changeset in webkit [52655] by
-
- 3 edits5 adds in trunk
WebCore: [Qt] Add support for Symbian def files
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.
- WebCore.pro:
WebKit/qt: Upstream Symbian def files from Qt 4.6.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.
These files define the ABI of QtWebKit on Symbian.
- symbian/bwins/QtWebKitu.def: Added.
- symbian/eabi/QtWebKitu.def: Added.
- 4:40 AM Changeset in webkit [52654] by
-
- 2 edits in trunk/WebCore
Unreviewed Qt/Symbian build fix.
Don't build network state notifier support when building inside of Qt.
Otherwise the Qt build depends on an external module that itself depends
on Qt again.
- WebCore.pro:
- 4:34 AM Changeset in webkit [52653] by
-
- 7 edits in trunk/WebCore
2009-12-30 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
[v8] Use current isolated world's context for ScriptCallStack.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::scriptState):
- bindings/v8/V8IsolatedWorld.h:
- 2:46 AM Changeset in webkit [52652] by
-
- 1 edit1 copy4 adds in trunk/LayoutTests
Rubber-stamped by Holger Hans Peter Freyther.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-30
[Qt] Add expected files for the following new passing tests.
- platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
- platform/qt/fast/block/float/in-margin-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/in-margin-expected.txt.
- platform/qt/fast/text/fake-italic-expected.txt: Added.
- platform/qt/svg/custom/empty-mask-expected.txt: Added.
- platform/qt/svg/filters/filter-source-position-expected.txt: Added.
- 2:20 AM Changeset in webkit [52651] by
-
- 12 edits in trunk/LayoutTests
[Qt] Expected files updated after r52647.
Reviewed by Dirk Schulze.
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 1:20 AM Changeset in webkit [52650] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] DataGrid support turned off by r52648. Expected files updated.
- platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
- platform/qt/fast/js/global-constructors-expected.txt: updated.
- 12:56 AM Changeset in webkit [52649] by
-
- 2 edits in trunk/LayoutTests
2009-12-30 Dirk Schulze <krit@webkit.org>
Unreviewed test result fix.
Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815
Forgot to update this test.
- platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
- 12:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:47 AM Changeset in webkit [52648] by
-
- 2 edits in trunk/WebCore
Turn off DataGrid support by default.
Patch by Laszlo Gombos <Laszlo Gombos> on 2009-12-30
Reviewed by Simon Hausmann.
No new tests, as there is no new functionality.
- WebCore.pro:
- 12:10 AM Changeset in webkit [52647] by
-
- 82 edits in trunk
2009-12-29 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815
Add new bounding boxes for strokes, filters, masker and clipper in SVG.
These new bounding boxes help to fix repaintRectInLocalCoordinates.
We calculate the smallest repaint rect considering the new bounding boxes
now, filters get the correct paint area, masker clip the mask image size
to the visible area of the target.
Tests: Many tests need an update. The changes in repaintRectInLocalCoordinates
affect the LayoutTests.
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::strokeBoundingBox):
- rendering/RenderObject.cpp: (WebCore::RenderObject::toSVGRenderBase):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath):
- rendering/RenderPath.h: (WebCore::RenderPath::markerBoundingBox):
- rendering/RenderSVGBlock.h: (WebCore::RenderSVGBlock::toSVGRenderBase):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::strokeBoundingBox):
- rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::objectBoundingBox): (WebCore::RenderSVGInline::repaintRectInLocalCoordinates):
- rendering/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::toSVGRenderBase):
- rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::strokeBoundingBox):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::toSVGRenderBase):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::~SVGRenderBase): (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
- rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::toSVGRenderBase): (WebCore::SVGRootInlineBox::objectBoundingBox): (WebCore::SVGRootInlineBox::repaintRectInLocalCoordinates):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
- svg/SVGFilterElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::clipperBoundingBox):
- svg/graphics/SVGResourceClipper.h:
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::prepareFilter):
- svg/graphics/SVGResourceFilter.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::maskerBoundingBox): (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
2009-12-30 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmmermann.
Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815
Mainly Filter and Masker tests need new test results.
repaintRectInLocalCoordinates changed to calculate the smallest
repaint area considering the bounding bo of masker, filter and
clipper as well as the stroke and marker boundaries.
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.txt:
- platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
- platform/mac/svg/custom/clip-path-href-changes-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
- platform/mac/svg/custom/clip-path-with-transform-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/focus-ring-expected.checksum:
- platform/mac/svg/custom/focus-ring-expected.png:
- platform/mac/svg/custom/focus-ring-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
- platform/mac/svg/custom/mask-excessive-malloc-expected.png:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/recursive-clippath-expected.txt:
- platform/mac/svg/custom/text-clip-expected.txt:
- platform/mac/svg/custom/visibility-override-clip-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- svg/custom/use-clipped-transform-expected.txt:
Dec 29, 2009:
- 11:19 PM Changeset in webkit [52646] by
-
- 2 edits2 adds in trunk/WebKitTools
2009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Kilzer.
Fixed a bug in fixChangeLogPatch, made it work correctly in
more circumstances, and added unit tests.
- Scripts/VCSUtils.pm: Rewrote fixChangeLogPatch.
- Scripts/VCSUtils_unittest.pl: Added. Added 7 unit tests for fixChangeLogPatch.
- Scripts/test-webkit-perl: Added. Added test harness for unit tests of Perl code.
- 10:46 PM Changeset in webkit [52645] by
-
- 8 edits in trunk/WebKitTools
2009-12-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out BugzillaQueries class from Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=33042
- Scripts/modules/bugzilla.py:
- Split out BugzillaQueries from Bugzilla.
- Try to isolate self.bugzilla usage into helper functions whenever possible.
- Add a bunch of FIXMEs.
- Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
- Scripts/modules/bugzilla_unittest.py:
- Create a new BugzillaQueriesTest testcase and move logic there.
- Scripts/modules/buildsteps_unittest.py:
- Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
- Scripts/modules/commands/queries.py:
- Update to use bugzilla.queries
- Scripts/modules/commands/queues.py:
- Ditto.
- Scripts/modules/commands/upload.py:
- Ditto.
- Scripts/modules/mock_bugzillatool.py:
- Add a MockBugzillaQueries.
- Make patches and bugs global privates.
- Let _id_to_object_dictionary take a variable argument list instead of an array.
- 10:29 PM Changeset in webkit [52644] by
-
- 2 edits in trunk/WebKitTools
2009-12-29 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Speed up the test method test_read_credentials_with_SVN by not actually
creating an SVN repository to test against (by default). Instead, it is
sufficient to create a temporary directory that does not contain a Git
repository.
Also, renamed method test_read_credentials_with_SVN to
test_read_credentials_without_git_repo, to better reflect what it is
testing.
- Scripts/modules/credentials_unittest.py:
- 10:04 PM Changeset in webkit [52643] by
-
- 3 edits in trunk/WebKitTools
2009-12-29 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
[bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
fails to find an entry for bugs.webkit.org.
Under Mac OS X, bugzilla-tool tries to query the keychain and Security
framework (via /usr/sbin/security) for an internet-password entry for
bugs.webkit.org so that it can use it to login to bugs.webkit.org.
However, if no such entry exists then bugzilla-tool dies with an error.
- Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
- Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
- 9:20 PM QtWebKitBackportingFixes edited by
- (diff)
- 9:03 PM Changeset in webkit [52642] by
-
- 2 edits in trunk/WebKitTools
2009-12-29 Eric Seidel <eric@webkit.org>
Rubber-stamped by Adam Barth.
Remove unused BugzillaException.
- Scripts/modules/bugzilla.py:
- 8:47 PM Changeset in webkit [52641] by
-
- 12 edits in trunk/WebKitTools
2009-12-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Need a script to assign bugs with r+ patches to committers for landing
https://bugs.webkit.org/show_bug.cgi?id=33009
This is just one more small tool to help in the fight against our
ever-growing list of to-be-committed patches.
- Scripts/modules/bugzilla.py:
- Rename assign_to_email to assigned_to_email (typo).
- Add assigned_to_email() method on Bug.
- Add reassign_bug method.
- Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
- Scripts/modules/bugzilla_unittest.py:
- Update test after assigned_to_email rename.
- Scripts/modules/commands/commandtest.py:
- Call bind_to_tool to that self.tool works in Command testing.
- Scripts/modules/commands/download.py:
- Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
- Scripts/modules/commands/queries_unittest.py:
- One of the test patches is now posted by "eric@webkit.org" which is a committer.
- Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
- Scripts/modules/commands/upload.py:
- Add new assign-to-committer command.
- Scripts/modules/commands/upload_unittest.py:
- Add basic assign-to-committer test.
- Scripts/modules/committers.py:
- Add bugzilla_email() accessor.
- Scripts/modules/committers_unittest.py:
- Test our assumption that bugzilla_email is the first email.
- Scripts/modules/mock_bugzillatool.py:
- Add _id_to_object_dictionary for generating bug_cache from list of bugs.
- Remove unused fetch_attachments_from_bug.
- Add fetch_bug support and a bug_cache.
- Scripts/modules/multicommandtool.py:
- Move AbstractDeclarativeCommmand here from download.py
- 8:19 PM Changeset in webkit [52640] by
-
- 3 edits in trunk/WebKitTools
2009-12-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Don't crash if user types a number during PromptForBugOrTitleStep
https://bugs.webkit.org/show_bug.cgi?id=33038
Simple fix with test.
- Scripts/modules/buildsteps.py:
- Scripts/modules/buildsteps_unittest.py:
- 8:12 PM Changeset in webkit [52639] by
-
- 2 edits in trunk/WebKitTools
2009-12-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] post-diff requires reading to the end
https://bugs.webkit.org/show_bug.cgi?id=33036
Catch the IOError caused by not reading to the end of the diff. We
don't have a good way to test this currently.
- Scripts/modules/user.py:
- 4:48 PM Changeset in webkit [52638] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-29 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a test for window.top and isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=33030
I wrote this test to investigate an issue that turns out is working
properly. No sense wasting a perfectly good test, so we should add it.
- http/tests/security/isolatedWorld/top-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/top-properties.html: Added.
- 3:19 PM Changeset in webkit [52637] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250
- wtf/Platform.h: Define WTF_PLATFORM_CAIRO for GTK port only For the WinCairo port WTF_PLATFORM_CAIRO is already defined in config.h
- 3:06 PM Changeset in webkit [52636] by
-
- 3 edits in trunk/WebKitTools
2009-12-29 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Adam Barth.
[Qt] Move logic that handles Qt headers before primary headers
so that Qt headers won't be treated as primary headers by mistake.
https://bugs.webkit.org/show_bug.cgi?id=32991
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 2:50 PM Changeset in webkit [52635] by
-
- 2 edits1 add in trunk/WebCore
2009-12-29 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
Add Android hook to NetworkStateNotifier class
so that the Java side can notify WebCore when the
network state changes.
https://bugs.webkit.org/show_bug.cgi?id=32871
No new tests required, this is platform code.
- platform/network/NetworkStateNotifier.h:
- platform/network/android/NetworkStateNotifierAndroid.cpp: Added. (WebCore::NetworkStateNotifier::networkStateChange):
- 2:32 PM Changeset in webkit [52634] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] Remove a bunch of now passing tests from skiplist.
- platform/qt/Skipped:
- 2:08 PM Changeset in webkit [52633] by
-
- 37 edits6 deletes in trunk
2009-12-29 Eric Seidel <eric@webkit.org>
No review, rolling out r52630.
https://bugs.webkit.org/show_bug.cgi?id=33012
http://trac.webkit.org/changeset/52630
This caused 2 layout test failures, and 2 layout test crashes on Leopard bots.
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-marker-creation-expected.txt:
- platform/mac/svg/custom/marker-changes-expected.checksum:
- platform/mac/svg/custom/marker-changes-expected.png:
- platform/mac/svg/custom/marker-changes-expected.txt:
- platform/mac/svg/custom/marker-child-changes-expected.checksum:
- platform/mac/svg/custom/marker-child-changes-expected.png:
- platform/mac/svg/custom/marker-child-changes-expected.txt:
- platform/mac/svg/custom/marker-default-width-height-expected.txt:
- platform/mac/svg/custom/marker-overflow-clip-expected.txt:
- platform/mac/svg/custom/marker-referencePoint-expected.checksum: Removed.
- platform/mac/svg/custom/marker-referencePoint-expected.png: Removed.
- platform/mac/svg/custom/marker-referencePoint-expected.txt: Removed.
- platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
- platform/mac/svg/custom/marker-viewBox-changes-expected.png:
- platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
- platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
- platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
- svg/custom/marker-referencePoint.svg: Removed.
2009-12-29 Eric Seidel <eric@webkit.org>
No review, rolling out r52630.
http://trac.webkit.org/changeset/52630
Change caused layout tests failures and crashes.
- Android.mk:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath): (WebCore::RenderPath::path): (WebCore::RenderPath::paint): (WebCore::): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::drawMarkerWithData): (WebCore::updateMarkerDataForElement): (WebCore::drawStartAndMidMarkers): (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGMarkerLayoutInfo.cpp: Removed.
- rendering/SVGMarkerLayoutInfo.h: Removed.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource): (WebCore::ResourceSet::ResourceSet): (WebCore::clientMap): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::cachedBounds): (WebCore::SVGResourceMarker::externalRepresentation):
- svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY):
- 1:05 PM Changeset in webkit [52632] by
-
- 30 edits in trunk/WebCore
Move the focus ring rect array, width and offset out of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=33028
Reviewed by Sam Weinig.
- platform/graphics/GraphicsContext.cpp: Removed initFocusRing(),
clearFocusRing(), focusRingBoundingRect(), addFocusRingRect(),
focusRingWidth(), focusRingOffset(), and focusRingRects().
- platform/graphics/GraphicsContext.h: Ditto. Added the focus ring rect
vector, width and offset as parameters to drawFocusRing().
- platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState): Cleaned up style.
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate): Removed
m_focusRingRects, m_focusRingWidth and m_focusRingOffset.
- platform/graphics/IntRect.cpp:
(WebCore::unionRect): Added this helper function.
- platform/graphics/IntRect.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects): Updated for new prototype.
Added empty rect checks that were previously done in
GraphicsContext::addFocusRingRect().
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects): Ditto.
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects): Ditto.
(WebCore::RenderInline::paintOutline): Collect focus ring rects into a
vector and pass it to drawFocusRing(). Use unionRect() instead of
focusRingBoundingRect().
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Changed to take a
Vector<IntRect> to which the rects are added.
- rendering/RenderPath.cpp:
(WebCore::RenderPath::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
- rendering/RenderSVGImage.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
- rendering/RenderTextControl.h:
- 12:51 PM Changeset in webkit [52631] by
-
- 2 edits in trunk/WebCore
- Changes the order in which some functions are called to match
the pre-r52536 order. Namely, when a new Database object is
created, DatabaseTracker::addOpenDatabase() is called in the
constructor, before doing anything else related to that database
(like trying to get a file handle to the database
file). Chromium's implementation depends on this ordering.
- Changes Database::performOpenAndVerify() to close the open
handle to the database file immediately if the database version
does not match the expected one. The current behavior is to add
the Database object to a DatabaseThread collection and let the
database thread close the handle when it's destroyed.
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=33005
All LayoutTests/storage tests pass in clean WebKit and Chromium
clients.
- storage/Database.cpp:
(WebCore::Database::openDatabase): Notify DatabaseTracker and
Document that a Database object is about to be destroyed (when a
database file cannot be opened, or its version doesn't match the
expected one).
(WebCore::Database::Database): Notify DatabaseTracker and Document
that a new Database object was created.
(WebCore::Database::performOpenAndVerify): If a database version
does not match the expected one, immediately close the open file
handle to the database file.
- 12:46 PM Changeset in webkit [52630] by
-
- 37 edits6 adds in trunk
2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012
Rewrite marker code, as it was buggy:
- Correct refX/refY handling (covered by new marker-referencePoint.svg test)
- Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
- Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
- Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)
Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg
- Android.mk:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath): (WebCore::RenderPath::paint): (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
- rendering/RenderPath.h: (WebCore::RenderPath::path):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::markerContentTransformation):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGMarkerLayoutInfo.cpp: Added. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::initialize): (WebCore::updateMarkerDataForElement): (WebCore::recordMarkerData): (WebCore::processStartAndMidMarkers): (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): (WebCore::SVGMarkerLayoutInfo::drawMarkers):
- rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerData::): (WebCore::MarkerData::MarkerData): (WebCore::MarkerLayout::MarkerLayout):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/graphics/SVGResource.cpp: (WebCore::resourceSet): (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerBoundaries): (WebCore::SVGResourceMarker::markerTransformation): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation):
- svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::setRenderer): (WebCore::SVGResourceMarker::setReferencePoint): (WebCore::SVGResourceMarker::referencePoint):
2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012
Update SVG test baseline, after rewriting marker support.
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-marker-creation-expected.txt:
- platform/mac/svg/custom/marker-changes-expected.checksum:
- platform/mac/svg/custom/marker-changes-expected.png:
- platform/mac/svg/custom/marker-changes-expected.txt:
- platform/mac/svg/custom/marker-child-changes-expected.checksum:
- platform/mac/svg/custom/marker-child-changes-expected.png:
- platform/mac/svg/custom/marker-child-changes-expected.txt:
- platform/mac/svg/custom/marker-default-width-height-expected.txt:
- platform/mac/svg/custom/marker-overflow-clip-expected.txt:
- platform/mac/svg/custom/marker-referencePoint-expected.checksum: Added.
- platform/mac/svg/custom/marker-referencePoint-expected.png: Added.
- platform/mac/svg/custom/marker-referencePoint-expected.txt: Added.
- platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
- platform/mac/svg/custom/marker-viewBox-changes-expected.png:
- platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
- platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
- platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
- svg/custom/marker-referencePoint.svg: Added.
- 11:55 AM Changeset in webkit [52629] by
-
- 4 edits in trunk/WebCore
2009-12-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix UI nits in the Audits panel.
https://bugs.webkit.org/show_bug.cgi?id=32932
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI.handleSelectAllClick): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditRuleResultPane):
- inspector/front-end/audits.css:
- 11:33 AM Changeset in webkit [52628] by
-
- 6 edits in trunk/WebKitTools
2009-12-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add the start of a Bug object for bugzilla.py
https://bugs.webkit.org/show_bug.cgi?id=32995
This allowed us to get rid of some duplicated "is_obsolete" checks.
- Scripts/modules/bugzilla.py:
- Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
- Add _fetch_bug_page for possible future mocking. (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
- Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
- Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
- Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
- Scripts/modules/bugzilla_unittest.py:
- Remove an unneeded unicode string marker.
- Scripts/modules/buildsteps.py:
- define all to include just the BuildSteps
- Scripts/modules/commands/download.py:
- import * now that we have an all defined.
- Scripts/modules/commands/upload.py:
- Use fetch_bug_dictionary instead of fetch_bug.
- 11:25 AM Changeset in webkit [52627] by
-
- 5 edits5 adds in trunk
2009-12-29 Johnny Ding <jnd@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=32863
Make NodeList support call-as-function
Test: fast/dom/NodeList/nodelist-item-call-as-function.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::callAsFunctionCallback):
2009-12-29 Johnny Ding <jnd@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=32863
Make NodeList support call-as-function.
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-call-as-function.html: Added.
- fast/dom/NodeList/script-tests: Added.
- fast/dom/NodeList/script-tests/TEMPLATE.html: Added.
- fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js: Added.
- 10:27 AM Changeset in webkit [52626] by
-
- 4 edits in trunk
2009-12-29 Daniel Bates <dbates@webkit.org>
Reviewed by Ariya Hidayat.
Adds an Open File dialog to make it convenient to open a file
to view in the browser.
- QGVLauncher/main.cpp: (MainWindow::load): Modified to call loadURL. (MainWindow::openFile): Added. (MainWindow::loadURL): Added. (MainWindow::buildUI): Added menu item Open File.
2009-12-29 Daniel Bates <dbates@webkit.org>
Reviewed by Ariya Hidayat.
Adds an Open File dialog to make it convenient to open a file
to view in the browser.
Currently a person must either specify the path to a file as a
command-line argument or type a file URL. Instead, we should
have a file dialog to allow a person to open a file without
memorizing its path.
- QtLauncher/main.cpp: (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded()) to urlEdit->setText(qurl.toString()). (MainWindow::openFile): Added. (MainWindow::changeLocation): Moved code to load URL into method MainWindow::loadURL. (MainWindow::loadURL): Added. (MainWindow::setupUI): Added menu item Open File.
- 9:44 AM Changeset in webkit [52625] by
-
- 4 edits in trunk
2009-12-29 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html
If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
2009-12-29 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html
If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.
- platform/qt/Skipped:
- 9:18 AM Changeset in webkit [52624] by
-
- 2 edits in trunk/WebCore
2009-12-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Typed text in table not correctly redrawn on page with compositing layers
https://bugs.webkit.org/show_bug.cgi?id=32874
Use the same test in RenderTableCell::computeRectForRepaint() that we use elsewhere
to decide when to use layoutState, which is to test for layoutStateEnabled()
and no repaint container.
Not possible to make a repaint test that exercises the problem, so no test.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
- 8:51 AM Changeset in webkit [52623] by
-
- 2 edits in trunk/WebCore
2009-12-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Discard port from cookie domain when matching cookies.
WebKit cookies do not hold the port information, so we should match only hostnames.
https://bugs.webkit.org/show_bug.cgi?id=31787
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 7:55 AM Changeset in webkit [52622] by
-
- 1 edit1 delete in trunk/WebKit/qt
2009-12-29 Laszlo Gombos <Laszlo Gombos>
Rubber-stamped by Simon Hausmann and Holger Freyther.
[Qt] Remove WebKit/qt/WebKitPart empty directory
The content of the directory has been removed by r34888.
- WebKitPart: Removed.
- 7:32 AM Changeset in webkit [52621] by
-
- 2 edits in trunk/WebCore
2009-12-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp
https://bugs.webkit.org/show_bug.cgi?id=33019
No new tests as there is no new functionality.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::totalTimeChanged):
- 6:28 AM Changeset in webkit [52620] by
-
- 7 edits3 adds in trunk
2009-12-29 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <aside> element.
https://bugs.webkit.org/show_bug.cgi?id=32943
<aside> should behave the same as <nav>, <section>, and <article>.
Test: fast/html/aside-element.html
- css/html.css: Add aside as a block element.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add asideTag.
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for asideTag. (WebCore::blockTagList): Add asideTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add asideTag.
- html/HTMLTagNames.in: Add aside.
2009-12-29 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <aside> element.
https://bugs.webkit.org/show_bug.cgi?id=32943
The new test file tests:
- <p> closing,
- Residual style, and
- FormatBlock.
- fast/html/aside-element-expected.txt: Added.
- fast/html/aside-element.html: Added.
- fast/html/script-tests/aside-element.js: Added.
- 5:52 AM Changeset in webkit [52619] by
-
- 7 edits in trunk/WebKit/mac
2009-12-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Alexey Proskuryakov.
plugins/get-url-with-iframe-target.html fails on SnowLeopard (64-bit)
https://bugs.webkit.org/show_bug.cgi?id=32982
This test has been failing on SnowLeopard since it was landed.
The problem is that we never delivered the notification for
NPN_GetURLNotify, in the frame-targeting case, for out-of-process
plugins on Mac.
I implemented support for this based on how in-process Mac plugins
do it.
- Plugins/Hosted/HostedNetscapePluginStream.h:
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::reasonForError):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::create): (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithError:]):
- 5:49 AM QtWebKit edited by
- (diff)
- 5:21 AM Changeset in webkit [52618] by
-
- 8 edits in trunk/WebCore
2009-12-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=33003
No new tests as there is no new functionality.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent):
- rendering/RenderSVGContainer.h: (WebCore::toRenderSVGContainer):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- 5:07 AM Changeset in webkit [52617] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
Minor style fix - reported by the style bot
- 5:05 AM Changeset in webkit [52616] by
-
- 2 edits in trunk/LayoutTests
2009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015
Skip test that fails on and off locally, but always on the release
bot, until we figure out what is wrong.
- platform/gtk/Skipped:
- 4:58 AM Changeset in webkit [52615] by
-
- 2 edits in trunk/LayoutTests
[GTK] Fails fast/dom/prototype-inheritance-2.html after r52559
https://bugs.webkit.org/show_bug.cgi?id=33014
Skipping test that is failing after r52559 until we figure out why
the constructors are not showing up for us.
- platform/gtk/Skipped:
- 4:56 AM Changeset in webkit [52614] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Holger Freyther.
[GTK] fails fast/harness/use-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=33013
Make sure settings are forwarded to child WebViews.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(createWebView):
- 4:47 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:27 AM QtWebKitReleases edited by
- (diff)
- 4:18 AM QtWebKitReleases edited by
- (diff)
- 4:00 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:42 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:30 AM Changeset in webkit [52613] by
-
- 2 edits in trunk/WebKitTools
2009-12-29 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Changes $diffPercentage to be a number to resolve Perl
warning about comparing a string to a number.
- Scripts/run-webkit-tests:
- 12:26 AM Changeset in webkit [52612] by
-
- 6 edits in trunk
2009-12-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989
Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.
Unskip some http/loading tests which succeed now.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
2009-12-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989
Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.
Unskip some http/loading tests which succeed now.
- platform/qt/Skipped:
2009-12-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989
Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.
Unskip some http/loading tests which succeed now.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
- 12:18 AM Changeset in webkit [52611] by
-
- 9 edits in trunk
2009-12-29 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] fix fast/dom/Window/window-onFocus.html
Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.
- Api/qwebpage.cpp: (QWebPagePrivate::focusOutEvent):
2009-12-29 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] fix fast/dom/Window/window-onFocus.html
Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.
- platform/qt/Skipped:
2009-12-29 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
[Qt] fix fast/dom/Window/window-onFocus.html
Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::switchFocus):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWindowIsKey): (LayoutTestController::setMainFrameIsFirstResponder):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
Dec 28, 2009:
- 10:49 PM Changeset in webkit [52610] by
-
- 3 edits in trunk/WebCore
2009-12-28 Andrei Popescu <andreip@google.com>
Reviewed by Dmitry Titov.
On Android, ResourceHandle instances make use of a pointer to a
ResourceLoaderAndroid pointer. This needs to be stored in order to later cancel
the load, if necessary. Since this pointer is an internal implementation
details of ResourceHandle on Android, it needs to be stored in the
ResourceHandleInternal class. This patch adds this pointer.
https://bugs.webkit.org/show_bug.cgi?id=32873
No new tests needed, this is platform-specific code.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- 10:41 PM Changeset in webkit [52609] by
-
- 3 edits4 adds in trunk
2009-12-28 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by Maciej Stachowiak.
Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
since with XHTMLMP enabled, it's not checking create Errors, and then contents inside
<noscript> are always parsed and rendered.
https://bugs.webkit.org/show_bug.cgi?id=32706
Tests: fast/parser/noscript-with-javascript-disabled.html
fast/parser/noscript-with-javascript-enabled.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
2009-12-28 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by Maciej Stachowiak.
Add test cases for <noscript> with both Javascript enabled and disabled
https://bugs.webkit.org/show_bug.cgi?id=32706
- fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
- fast/parser/noscript-with-javascript-disabled.html: Added.
- fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
- fast/parser/noscript-with-javascript-enabled.html: Added.
- 10:33 PM Changeset in webkit [52608] by
-
- 10 edits3 adds in trunk
2009-12-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Maciej Stachowiak.
Fixed isKeypadEvent behavior for chromium/Mac to correctly report
keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
https://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent):
2009-12-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Maciej Stachowiak.
Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
https://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- platform/mac/KeyEventMac.mm: (WebCore::isKeypadEvent):
2009-12-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Maciej Stachowiak.
Added a layout-test that tests if numeric pad arrow key
events are correctly reported with keyLocation as
DOM_KEY_LOCATION_NUMPAD. Currently this test only passes on Mac.
https://bugs.webkit.org/show_bug.cgi?id=28247
- fast/events/keydown-numpad-keys-expected.txt: Added.
- fast/events/keydown-numpad-keys.html: Added.
- fast/events/script-tests/keydown-numpad-keys.js: Added. (recordKeyEvent): (testKeyEventWithLocation):
- platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
- platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
- platform/win/Skipped: fast/events/keydown-numpad-keys.html added.
2009-12-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Maciej Stachowiak.
Extended EventSender.keyDown method to take another (3rd) argument
for indicating the keyLocation to make numeric pad key events testable.
Expected values for the argument is one of the KeyLocationCode
specified in DOM Level 3
(http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
https://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDown:withModifiers:withLocation:]):
- 10:25 PM Changeset in webkit [52607] by
-
- 3 edits2 adds in trunk
2009-12-28 Mike Moretti <webkit9@mordent.com>
Reviewed by Darin Adler.
Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string
Test: fast/dom/insert-span-into-long-text-bug-28245.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
2009-12-28 Mike Moretti <webkit9@mordent.com>
Reviewed by Darin Adler.
Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string
- fast/dom/insert-span-into-long-text-bug-28245-expected.txt: Added.
- fast/dom/insert-span-into-long-text-bug-28245.html: Added.
- 8:57 PM QtWebKitContrib edited by
- Added subsections "Dependencies" and "Installing dependencies on … (diff)
- 7:43 PM TinOS created by
- 7:33 PM WikiStart edited by
- (diff)
- 3:46 PM Changeset in webkit [52606] by
-
- 2 edits in trunk/LayoutTests
2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skip test that is failing since it was checked in, and some tests
that need results.
- platform/gtk/Skipped:
- 3:34 PM Changeset in webkit [52605] by
-
- 2 edits in trunk/WebCore
2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Follow Apple's decision to disable HTML DataGrid by default.
- GNUmakefile.am:
- 3:32 PM Changeset in webkit [52604] by
-
- 2 edits in trunk/WebKitTools
2009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com>
Unreviewed, update my email address.
- Scripts/modules/committers.py:
- 3:15 PM Changeset in webkit [52603] by
-
- 2 edits in trunk/WebCore
2009-12-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Ariya Hidayat.
Fix warnings when generating files using gperf. The warnings are
currently harmless, but some changes in the build system may make
them fatal.
[GTK] Build time must be reduced
https://bugs.webkit.org/show_bug.cgi?id=32921
- GNUmakefile.am:
- 12:28 PM Changeset in webkit [52602] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-28 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Delete ThreadPrivate instance after it is finished.
https://bugs.webkit.org/show_bug.cgi?id=32614
- wtf/qt/ThreadingQt.cpp: (WTF::ThreadMonitor::instance): (WTF::ThreadMonitor::threadFinished): (WTF::createThreadInternal): (WTF::detachThread):
- 12:05 PM QtWebKitBackportingFixes edited by
- (diff)
- 11:15 AM Changeset in webkit [52601] by
-
- 7 edits in trunk
2009-12-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Adam Barth.
[Qt] Fix build break for Qt 4.4
https://bugs.webkit.org/show_bug.cgi?id=30327
No new tests, as there is no new functionality.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Use intersected() instead of operator &, which was only introduced in Qt version 4.5.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner): Pass ColorSpace argument to fillColor() introduced in r50760
2009-12-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Adam Barth.
[Qt] Fix build break for Qt 4.4
https://bugs.webkit.org/show_bug.cgi?id=30327
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
- QtLauncher/main.cpp: (MainWindow::MainWindow): Qt::WA_TranslucentBackground was introduced in Qt version 4.5
- 9:35 AM Changeset in webkit [52600] by
-
- 3 edits in trunk/WebKitTools
2009-12-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add an edit-changelog command
https://bugs.webkit.org/show_bug.cgi?id=32986
This command makes it easier to edit ChangeLogs. It's similar to
prepare-ChangeLog -o, except it works with already existing ChangeLogs.
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 9:06 AM Changeset in webkit [52599] by
-
- 6 edits in trunk/WebKitTools
2009-12-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Create an ASAD command for uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=32979
The create-review command goes through the whole process of preparing a
code review, including creating a bug, editing the ChangeLogs, and
uploading the patch. It is indeed the All Sing, All Dance upload
command.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/user.py:
- 8:58 AM Changeset in webkit [52598] by
-
- 4 edits in trunk
2009-12-28 Patrick Gansterer <paroga@paroga.com>
Reviewed by Maciej Stachowiak.
Cleanup of #define JS_EXPORT.
- API/JSBase.h:
2009-12-28 Patrick Gansterer <paroga@paroga.com>
Reviewed by Maciej Stachowiak.
Use JS_NO_EXPORT for JSBase.h.
- wxwk-settings.bkl:
- 8:48 AM Changeset in webkit [52597] by
-
- 2 edits in trunk
2009-12-28 Estêvão Samuel Procópio <tevaum@gmail.com>
Reviewed by Gustavo Noronha Silva.
Bug 32940: [GTK] Changing the download throttle conditions.
https://bugs.webkit.org/show_bug.cgi?id=32716
The WebKitDownload progress notification was taking long to
update. This fix makes notification happens each 0.7 secs
or when the progress ups in 1%.
- WebKit/gtk/webkit/webkitdownload.cpp:
- 5:48 AM Changeset in webkit [52596] by
-
- 7 edits3 adds in trunk
2009-12-28 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <article> element.
https://bugs.webkit.org/show_bug.cgi?id=32942
The new test file tests:
- <p> closing,
- Residual style, and
- FormatBlock.
- fast/html/article-element-expected.txt: Added.
- fast/html/article-element.html: Added.
- fast/html/script-tests/article-element.js: Added.
2009-12-28 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Implement HTML5 <article> element.
https://bugs.webkit.org/show_bug.cgi?id=32936
<article> should behave the same as <nav> and <section>.
Test: fast/html/article-element.html
- css/html.css: Add article as a block element.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add articleTag.
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for articleTag. (WebCore::blockTagList): Add articleTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add articleTag.
- html/HTMLTagNames.in: Add article.
- 12:22 AM Changeset in webkit [52595] by
-
- 3 edits in trunk/WebKitTools
2009-12-28 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix (with test!).
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
Dec 27, 2009:
- 11:59 PM Changeset in webkit [52594] by
-
- 4 edits in trunk/WebKitTools
2009-12-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
https://bugs.webkit.org/show_bug.cgi?id=32980
- Scripts/modules/bugzilla.py:
- Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
- Replace fetch_title_from_bug with a new fetch_bug call instead.
- Use list comprehensions where possible to reduce code duplication.
- Scripts/modules/bugzilla_unittest.py:
- Add a minimal bug parsing test.
- Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
- Scripts/modules/commands/upload.py:
- Use fetch_bug(bug_id)title instead of fetch_title_from_bug
- 11:05 PM Changeset in webkit [52593] by
-
- 2 edits in trunk/WebKitTools
2009-12-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Status bubble shouldn't be transparent for bots that haven't run yet
https://bugs.webkit.org/show_bug.cgi?id=32977
- QueueStatusServer/templates/statusbubble.html:
- 10:58 PM Changeset in webkit [52592] by
-
- 2 edits in trunk/WebKitTools
2009-12-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[QueueStatusServer] Run gc cron job less often
https://bugs.webkit.org/show_bug.cgi?id=32958
Now that we've cleaned out the backlog of idle messages, we don't need
to run the gc job every half hour. We could also stop logging the idle
messages, but this seems easier for the time being.
- QueueStatusServer/cron.yaml:
- 8:58 PM Changeset in webkit [52591] by
-
- 3 edits in trunk/LayoutTests
Rubber stamped by Adam Barth.
Put media/audio-delete-while-step-button-clicked.html back in the mac skipped list because
I think it's making other media tests fail sporadically.
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- 7:39 PM Changeset in webkit [52590] by
-
- 5 edits in trunk
2009-12-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] Support upload progress events in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=32969
Make QNetworkReplyHandler report the upload progress to the client.
Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html
which have been unskipped.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::uploadProgress): (WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
2009-12-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] Support upload progress events in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=32969
Make QNetworkReplyHandler report the upload progress to the client.
Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html
which have been unskipped.
- platform/qt/Skipped:
- 7:17 PM Changeset in webkit [52589] by
-
- 2 edits in trunk/LayoutTests
Rubber stamped by Adam Barth.
Add media/audio-delete-while-step-button-clicked.html back to the Tiger skipped list.
- platform/mac-tiger/Skipped:
- 6:28 PM Changeset in webkit [52588] by
-
- 3 edits6 adds in trunk/LayoutTests
Rubber stamped by Adam Barth.
Removed some tests from the skipped list that are not failing on my system.
- platform/mac-snowleopard/Skipped:
- platform/mac/Skipped:
- platform/mac/fast/forms/menulist-style-color-expected.checksum: Added.
- platform/mac/fast/forms/menulist-style-color-expected.png: Added.
- platform/mac/fast/forms/menulist-style-color-expected.txt: Added.
- platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Added.
- platform/mac/plugins/qt-qwidget-plugin-expected.png: Added.
- platform/mac/plugins/qt-qwidget-plugin-expected.txt: Added.
- 6:01 PM Changeset in webkit [52587] by
-
- 5 edits1 add in trunk/WebKitTools
2009-12-27 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue where bugzilla-tool tries to read the username and password from
Git regardless of whether Git is installed. In particular, if Git is not
installed then bugzilla-tool dies (with a trace) when it attempts to query Git
for the authentication credentials to log into bugs.webkit.org.
Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
the specified error handler. For instance, the specified error handler will now
be called when the command does not exist (i.e. OSError errno 2).
- Scripts/modules/credentials.py: Added check for Git.
- Scripts/modules/credentials_unittest.py: Added test method test_read_credentials_with_SVN.
- Scripts/modules/executive.py: Modified method run_command to catch OSError exceptions (i.e [Errno 2] No such file or directory) and call the specified error handler.
- Scripts/modules/executive_unittest.py: Added.
- Scripts/run-webkit-unittests: Added import executive_unittest.py.
- 5:25 PM Changeset in webkit [52586] by
-
- 2 edits in trunk/LayoutTests
Rubber stamped by Cameron Zwarich.
Skip fast/images/size-failure.html on SnowLeopard because it
tickles a CG bug that makes it time out.
- platform/mac-snowleopard/Skipped:
- 3:48 PM Changeset in webkit [52585] by
-
- 4 edits3 copies in trunk/LayoutTests
2009-12-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
fast/forms/basic-selects.html is failing on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=32960
The recently added fast/forms/basic-selects.html is failing on SnowLeopard; the
result checked in is only valid for Leopard and earlier, because SnowLeopard
slightly changed the disabled text color.
Move the pre-SL result to platform/mac-leopard and generate new
SnowLeopard results in platform/mac.
- platform/mac-leopard/fast/forms/basic-selects-expected.checksum: Copied from platform/mac/fast/forms/basic-selects-expected.checksum.
- platform/mac-leopard/fast/forms/basic-selects-expected.png: Copied from platform/mac/fast/forms/basic-selects-expected.png.
- platform/mac-leopard/fast/forms/basic-selects-expected.txt: Copied from platform/mac/fast/forms/basic-selects-expected.txt.
- platform/mac/fast/forms/basic-selects-expected.checksum:
- platform/mac/fast/forms/basic-selects-expected.png:
- platform/mac/fast/forms/basic-selects-expected.txt:
- 2:22 PM Changeset in webkit [52584] by
-
- 19 edits4 adds in trunk
2009-12-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG: Stop rendering of objects with empty mask and filter content
https://bugs.webkit.org/show_bug.cgi?id=32968
It's not neccessary to continue rendering of an object and its' childs
if the mask clips the complete content away.
The same for filters, if the filter rendering is discontinued or either
width or height are zero.
We might also stop rendering if repaintRectInLocalCoordinates is empty.
But it needs to be fixed first.
Test: svg/custom/empty-mask.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/SVGResourceFilter.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
2009-12-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG: Stop rendering of objects with empty mask and filter content
https://bugs.webkit.org/show_bug.cgi?id=32968
Check if the content is not drawn, if the mask clips the complete
content away.
mask-excessive-malloc needed an update. This patch stops rendering
if there is no content in mask. But it's intention is to test
big masking images.
- platform/mac/svg/custom/empty-mask-expected.checksum: Added.
- platform/mac/svg/custom/empty-mask-expected.png: Added.
- platform/mac/svg/custom/empty-mask-expected.txt: Added.
- platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
- platform/mac/svg/custom/mask-excessive-malloc-expected.png:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- svg/custom/empty-mask.svg: Added.
- svg/custom/mask-excessive-malloc.svg:
- 11:25 AM Changeset in webkit [52583] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-27 Daniel Bates <dbates@webkit.org>
Unreviewed. Added missing file style_unittest.py that wasn't committed
in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
the patch for bug #32592.
- Scripts/modules/style_unittest.py: Added.
- 11:12 AM Changeset in webkit [52582] by
-
- 2 edits in trunk/WebKitTools
2009-12-27 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
[bzt] Updated the unit test based on the change made in bug #32951.
The change made in bug #32951 added the command-line argument:
--makeargs="-j8" to the build-webkit command. However, the associated
unit test was not updated.
- Scripts/modules/webkitport_unittest.py:
- 10:19 AM Changeset in webkit [52581] by
-
- 2 edits in trunk/WebCore
2009-12-27 Christian Dywan <christian@twotoasts.de>
Reviewed by Eric Seidel.
[GTK] Spell Check Suggestions (Do not work)
https://bugs.webkit.org/show_bug.cgi?id=30908
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): Implement the 'title' member and set the title from the native menu item.
- 9:08 AM Changeset in webkit [52580] by
-
- 34 edits4 adds in trunk
2009-12-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Mask result wrong, if two different objects call the same mask id
https://bugs.webkit.org/show_bug.cgi?id=32787
At the moment we create one resource per maskId. Some resources (like mask)
create ImageBuffers and depends on the properties of the RenderObject,
thus we can't use it for a second object.
This patch stores multiple mask resources for one maskId and different
RenderObject can use the same maskId.
Clipper, Filter and Patterns also need to store multiple resources later.
Test: svg/custom/mask-on-multiple-objects.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
- rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderResources):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
- svg/SVGClipPathElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::canvasResource):
- svg/SVGGradientElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::canvasResource):
- svg/SVGMaskElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::canvasResource):
- svg/SVGPatternElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
- svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
- svg/graphics/SVGPaintServer.cpp: (WebCore::getPaintServerById): (WebCore::SVGPaintServer::fillPaintServer): (WebCore::SVGPaintServer::strokePaintServer):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGResource.cpp: (WebCore::getResourceById):
- svg/graphics/SVGResource.h:
- svg/graphics/SVGResourceClipper.cpp: (WebCore::getClipperById):
- svg/graphics/SVGResourceClipper.h:
- svg/graphics/SVGResourceFilter.cpp: (WebCore::getFilterById):
- svg/graphics/SVGResourceFilter.h:
- svg/graphics/SVGResourceMarker.cpp: (WebCore::getMarkerById):
- svg/graphics/SVGResourceMarker.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::getMaskerById):
- svg/graphics/SVGResourceMasker.h:
2009-12-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Mask result wrong, if two different objects call the same mask id
https://bugs.webkit.org/show_bug.cgi?id=32787
Two rects with different sizes and positions call the same mask id. Both
rects should be masked to two circles, dependent on the properties of the
rects.
- platform/mac/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
- platform/mac/svg/custom/mask-on-multiple-objects-expected.png: Added.
- platform/mac/svg/custom/mask-on-multiple-objects-expected.txt: Added.
- svg/custom/mask-on-multiple-objects.svg: Added.
- 6:38 AM Changeset in webkit [52579] by
-
- 5 edits in trunk/WebCore
2009-12-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Cleanup RenderPath code, related to markers. Pass around
PaintInfo objects instead of GraphicsContext directly, to
avoid having to recreate a new PaintInfo object in
SVGResourceMarker::draw().
No layout test changes.
- 5:27 AM Changeset in webkit [52578] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] DRT sideeffect (authentication)
https://bugs.webkit.org/show_bug.cgi?id=32961
- platform/qt/Skipped: http/tests/xmlhttprequest/failed-auth.html added temorarily (until fix).
- 5:15 AM Changeset in webkit [52577] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove successful tests from qt skipped list
https://bugs.webkit.org/show_bug.cgi?id=32948
- platform/qt/Skipped:
- 2:48 AM QtBackLog edited by
- Add OProfile JIT agent to the list of things to do (diff)
- 1:42 AM Changeset in webkit [52576] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove duplicate entries from Qt skipped list
https://bugs.webkit.org/show_bug.cgi?id=32947
- platform/qt/Skipped:
- 1:11 AM Changeset in webkit [52575] by
-
- 2 edits in trunk/WebKitTools
2009-12-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
check-webkit-style should not mark moc files inclusion as errors
https://bugs.webkit.org/show_bug.cgi?id=32669
Add a new header type for moc files, and skip them when checking the order of header files.
- Scripts/modules/cpp_style.py:
- 12:55 AM Changeset in webkit [52574] by
-
- 2 edits in trunk/WebCore
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
WinCE buildfix (added missing header)
- platform/text/wince/TextBreakIteratorWince.cpp:
- 12:47 AM Changeset in webkit [52573] by
-
- 2 edits in trunk/WebCore
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix after r50760 and some style fixes.
- rendering/RenderThemeWince.cpp: (WebCore::RenderThemeWince::paintSearchFieldCancelButton): (WebCore::RenderThemeWince::paintSliderTrack): (WebCore::RenderThemeWince::paintSliderThumb): (WebCore::RenderThemeWince::paintMediaMuteButton): (WebCore::RenderThemeWince::paintMediaPlayButton):
- 12:39 AM Changeset in webkit [52572] by
-
- 4 edits in trunk/WebCore
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Barth.
WinCE buildfixes (missing headers and unsupported HWND_MESSAGE)
- platform/wince/MIMETypeRegistryWince.cpp:
- platform/wince/SearchPopupMenuWince.cpp:
- platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
- 12:32 AM Changeset in webkit [52571] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Barth.
WinCE buildfix (HWND_MESSAGE isn't supported there)
- wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
- 12:24 AM Changeset in webkit [52570] by
-
- 1 edit1 add in trunk/JavaScriptCore
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Barth.
Added a file with WinMain function to link agains in WinCE.
- os-win32/WinMain.cpp: Added. (convertToUtf8): (WinMain):
Dec 26, 2009:
- 11:36 PM Changeset in webkit [52569] by
-
- 2 edits in trunk/WebCore
2009-12-26 Eric Seidel <eric@webkit.org>
No review, rolling out r52554.
http://trac.webkit.org/changeset/52554
https://bugs.webkit.org/show_bug.cgi?id=32955
The original change was covered under
https://bugs.webkit.org/show_bug.cgi?id=32913
r52554 was itself a rollout of r52536.
However it caused two layout tests to fail on Leopard:
storage/open-database-while-transaction-in-progress.html
svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)
So I'm rolling out the rollout in an attempt to get the bots green.
r52554 did not explain why it was rolled out, so I do not know
what might fail for Chromium after this change. I warned the folks
in #chromium that it was coming.
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- 10:50 PM Changeset in webkit [52568] by
-
- 2 edits in trunk/WebKitTools
2009-12-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make the qt build go fast
https://bugs.webkit.org/show_bug.cgi?id=32951
Make use of multiple cores, if available.
- Scripts/modules/webkitport.py:
- 7:35 PM QtBackLog edited by
- (diff)
- 5:28 PM Changeset in webkit [52567] by
-
- 2 edits in trunk
Added Radar URLs
- 5:27 PM Changeset in webkit [52566] by
-
- 3 edits4 adds in trunk
REGRESSION (r47255): Extra Large Amount of Empty Space
https://bugs.webkit.org/show_bug.cgi?id=32690
Reviewed by Sam Weinig.
WebCore:
Test: fast/block/float/clear-to-fit.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.
LayoutTests:
- fast/block/float/clear-to-fit-expected.checksum: Added.
- fast/block/float/clear-to-fit-expected.png: Added.
- fast/block/float/clear-to-fit-expected.txt: Added.
- fast/block/float/clear-to-fit.html: Added.
- 1:40 AM Changeset in webkit [52565] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] Skipping some flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=32946
- platform/qt/Skipped:
- http/tests/cookies/simple-cookies-expired.html added.
- storage/database-lock-after-reload.html added.
- storage/empty-statement.html added.
- storage/execute-sql-args.html added.
- storage/hash-change-with-xhr.html added.
