Timeline
Nov 16, 2009:
- 11:16 PM Changeset in webkit [51067] by
-
- 4 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31050
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-16
Reviewed by Gavin Barraclough.
Minor fixes for JSVALUE32_64: branchConvertDoubleToInt32
failed on a CortexA8 CPU, but not on a simulator; and
JITCall.cpp modifications was somehow not committed to mainline.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::fmrs_r):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- 10:31 PM Changeset in webkit [51066] by
-
- 3 edits in trunk/WebCore
2009-11-16 Kent Tamura <tkent@chromium.org>
Unreviewd build fix.
- Fix typo in WebCore.vcproj.
- Intlude limits.h for INT_MAX.
- Enclose with parenthesis to suspress warning.
- WebCore.vcproj/WebCore.vcproj:
- html/ISODateTime.cpp: (WebCore::ISODateTime::addDay):
- 9:50 PM Changeset in webkit [51065] by
-
- 6 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Make sure wx scrollbar drawing code factors in transforms when switching backends,
fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
https://bugs.webkit.org/show_bug.cgi?id=31570
- 9:39 PM Changeset in webkit [51064] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Add myself to commiters.py
- 9:13 PM Changeset in webkit [51063] by
-
- 7 edits2 adds in trunk/WebCore
2009-11-16 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Introduce WebCore::ISODateTime class.
https://bugs.webkit.org/show_bug.cgi?id=31340
This class represents a value of date/time types of the HTML5 INPUT
element, and has some parsing methods for ISO 8601.
This change has no tests because the class is not used yet.
- GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
- WebCore.gypi: ditto.
- WebCore.pro: ditto.
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- WebCoreSources.bkl: ditto.
- html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class. (WebCore::isLeapYear): (WebCore::maxDayOfMonth): (WebCore::dayOfWeek): (WebCore::ISODateTime::maxWeekNumberInYear): (WebCore::countDigits): (WebCore::toInt): (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek(). (WebCore::ISODateTime::addDay): Private helper for parseTimeZone(). (WebCore::ISODateTime::addMinute): ditto. (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime(). (WebCore::ISODateTime::parseMonth): Parser for <input type=month>. (WebCore::ISODateTime::parseDate): Parser for <input type=date>. (WebCore::ISODateTime::parseWeek): Parser for <input type=week>. (WebCore::ISODateTime::parseTime): Parser for <input type=time>. (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>. (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
- html/ISODateTime.h: Added. Declare WebCore::ISODateTime class. (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::millisecond): (WebCore::ISODateTime::second): (WebCore::ISODateTime::minute): (WebCore::ISODateTime::hour): (WebCore::ISODateTime::monthDay): (WebCore::ISODateTime::month): (WebCore::ISODateTime::fullYear): (WebCore::ISODateTime::week):
- 7:05 PM BuildingQtOnLinux edited by
- Added missing "libsqlite3-dev" dependency for Ubuntu (diff)
- 4:09 PM Changeset in webkit [51062] by
-
- 2 edits in trunk/WebCore
Fix a typo in previous commit.
- platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
- 4:04 PM Changeset in webkit [51061] by
-
- 2 edits in trunk/WebCore
Fix a typo in previous commit.
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- 3:57 PM Changeset in webkit [51060] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named differently in Tiger CFNetwork.
- 3:32 PM Changeset in webkit [51059] by
-
- 3 edits in trunk/LayoutTests
Disabling WebSocket tests on Tiger and Windows again, as they still time out.
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 3:08 PM Changeset in webkit [51058] by
-
- 2 edits in trunk/WebCore
2009-11-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
- platform/KURLGoogle.cpp: (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
- 2:58 PM Changeset in webkit [51057] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Jon Honeycutt.
A better Windows build fix
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Use a macro that inserts declspec(dllimport) when appropriate for CFNetwork imports.
- 2:57 PM Changeset in webkit [51056] by
-
- 5 edits in trunk/WebCore
Rename protocolIsValid to isValidProtocol.
https://bugs.webkit.org/show_bug.cgi?id=31503
Reviewed by Darin Adler.
This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
No new tests since no new functionality was introduced.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setProtocol):
- platform/KURL.cpp:
(WebCore::isValidProtocol):
- platform/KURL.h:
- platform/KURLGoogle.cpp:
(WebCore::isValidProtocol):
- 2:41 PM Changeset in webkit [51055] by
-
- 8 edits2 adds in trunk
AX: aria-labelledby duplicates some of its WAI-ARIA label
https://bugs.webkit.org/show_bug.cgi?id=31565
Reviewed by Beth Dakin.
WebCore:
Test: accessibility/aria-labelledby-overrides-label.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(titleUIElementCallback):
(getIsValidCallback):
(AccessibilityUIElement::getJSClass):
LayoutTests:
- accessibility/aria-labelledby-overrides-label-expected.txt: Added.
- accessibility/aria-labelledby-overrides-label.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 2:40 PM Changeset in webkit [51054] by
-
- 2 edits in trunk/WebCore
2009-11-16 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Handle the case of a null NPObject* in NPN_SetException in
the V8 bindings. This allow out of process plugins calling
NPN_SetException to just send null instead of sending an
NPObject* that would be an address in a different
process's memory space.
- bindings/v8/NPV8Object.cpp: (_NPN_SetException): Allow null NPObject* and just throw a general error.
- 2:30 PM Changeset in webkit [51053] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
- 2:21 PM Changeset in webkit [51052] by
-
- 3 edits in trunk/WebCore
[Qt] ASSERT failure while running DRT
https://bugs.webkit.org/show_bug.cgi?id=30978
Reviewed by Kenneth Rohde Christiansen.
Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
- 1:51 PM Changeset in webkit [51051] by
-
- 1 edit1 add in trunk/WebCore
Attempt to fix the build. Land a file that was missing from r51049.
- bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
(WebCore::setWebGLArrayFromArray):
- 1:31 PM Changeset in webkit [51050] by
-
- 3 edits in trunk/WebKitTools
r50942 broke output from created windows. Make the
m_enableTextOutput a member of the DRT and not the
WebPage.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::javaScriptAlert):
(WebCore::WebPage::javaScriptConsoleMessage):
(WebCore::WebPage::javaScriptConfirm):
(WebCore::WebPage::javaScriptPrompt):
(WebCore::WebPage::acceptNavigationRequest):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::createWindow):
- DumpRenderTree/qt/DumpRenderTree.h:
(WebCore::DumpRenderTree::setTextOutputEnabled):
(WebCore::DumpRenderTree::isTextOutputEnabled):
(WebCore::WebPage::shouldInterruptJavaScript):
(WebCore::WebPage::isTextOutputEnabled):
(WebCore::WebPage::setViewGeometry):
- 1:30 PM Changeset in webkit [51049] by
-
- 53 edits in trunk
Update API of WebGLArray and friends
https://bugs.webkit.org/show_bug.cgi?id=31175
- 1:28 PM Changeset in webkit [51048] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
- 1:28 PM Changeset in webkit [51047] by
-
- 4 edits in trunk/WebKit/qt
API documentation fixes.
Reviewed by Kenneth Rohde Christiansen.
- Api/qgraphicswebview.cpp: Removed duplicate docs.
- Api/qwebelement.cpp: Added missing docs.
- Api/qwebsettings.cpp: Ditto.
- 1:01 PM Changeset in webkit [51046] by
-
- 2 edits in trunk/WebCore
Enable support for webkit-box-shadow in Cairo builds.
https://bugs.webkit.org/show_bug.cgi?id=26102.
Reviewed by Oliver Hunt.
Covered by existing fast/box-shadow tests.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Add support for fillRect shadows.
- 12:36 PM Changeset in webkit [51045] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not in WebKitSupportLibrary.
- 12:05 PM Changeset in webkit [51044] by
-
- 3 edits4 moves4 adds in trunk/WebKitTools
Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
as the implementation is being used by at least Qt and Gtk+.
Reviewed by Gustavo Noronha Silva.
Update buildsystems as well.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
- DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
- DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
- GNUmakefile.am:
- 11:08 AM Changeset in webkit [51043] by
-
- 2 edits in trunk/WebKitSite
Update Security Group Members list.
Reviewed by Anders Carlsson.
- security/security-group-members.html:
- 10:58 AM Changeset in webkit [51042] by
-
- 2 edits in trunk/WebKitSite
Update Security Group Members list.
Reviewed by Adele Peterson.
- security/security-group-members.html:
- 10:40 AM Changeset in webkit [51041] by
-
- 5 edits in trunk
WebKitTools:
2009-11-16 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Disable wss until all platforms support pyOpenSSL
- Scripts/run-webkit-tests:
LayoutTests:
Re-enabling WebSocket tests on Tiger and Windows, now that SSL is disabled.
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 9:59 AM Changeset in webkit [51040] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31494
Add unauthenticated proxy support to SocketStreamHandleCFNet
Cannot be tested in DRT.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS. (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
- 8:54 AM WebKit Team edited by
- (diff)
- 8:51 AM Changeset in webkit [51039] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Adding myself to committers.py.
- 7:38 AM Changeset in webkit [51038] by
-
- 8 edits2 adds in trunk
[Qt] Broken back/forward after using ErrorPageExtension to set error page
https://bugs.webkit.org/show_bug.cgi?id=30573
Reviewed by Antti Koivisto.
WebCore:
Make FrameLoader::checkLoadCompleteForThisFrame method
to check for any working DocumentLoader instance (through
activeDocumentLoader()) instead of only checking for
'm_provisionalDocumentLoader' in order to decide to if
it is going to reset of not the back and forward history.
after an error page has been loaded.
Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
WebKit/qt:
Implemented autotests for covering the back/forward
reset problem involving error pages.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::errorPageExtension):
LayoutTests:
Skipped fast/history/back-forward-reset-after-error-handling.html
in mac, gtk and win DRT, because their DRT do not support yet
error pages handling.
- fast/history/back-forward-reset-after-error-handling.html:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 7:37 AM Changeset in webkit [51037] by
-
- 5 edits in trunk/WebKitTools
[Qt] Implement load error pages support for Qt's DRT.
https://bugs.webkit.org/show_bug.cgi?id=31509
Reviewed by Kenneth Christiansen.
For now, it will not be a default feature, and layout tests
that want to make use of this have to explicitily call
'handleErrorPages();' for the test source.
Any of the other DumpRenderTree's (mac, win and gtk)
support handling error pages. Qt's will be the first.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::supportsExtension):
(WebCore::WebPage::extension):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::shouldHandleErrorPages):
(LayoutTestController::handleErrorPages):
- 7:05 AM QtWebKitContrib edited by
- (diff)
- 6:59 AM QtWebKitJournal edited by
- (diff)
- 6:58 AM QtWebKitJournal edited by
- (diff)
- 6:30 AM QtWebKitJournal edited by
- (diff)
- 6:26 AM QtWebKitJournal edited by
- (diff)
- 6:24 AM QtWebKitJournal edited by
- (diff)
- 6:18 AM QtWebKitJournal edited by
- (diff)
- 6:12 AM QtWebKit edited by
- (diff)
- 6:06 AM QtWebKitJournal edited by
- (diff)
- 6:05 AM QtWebKit edited by
- (diff)
- 6:04 AM QtWebKit edited by
- (diff)
- 5:59 AM QtWebKitJournal edited by
- (diff)
- 5:47 AM Changeset in webkit [51036] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
https://bugs.webkit.org/show_bug.cgi?id=31549
Renamed --commit-queue to --non-interactive in most places
and remove the code in land-patches which is no longer needed.
- Scripts/bugzilla-tool:
- 5:43 AM Changeset in webkit [51035] by
-
- 1 edit4 adds in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Added new Qt expected results for animation tests.
- platform/qt/animations/change-transform-in-end-event-expected.txt: Added.
- platform/qt/animations/state-at-end-event-expected.txt: Added.
- platform/qt/animations/state-at-end-event-transform-expected.txt: Added.
- 5:34 AM Changeset in webkit [51034] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
The commit-queue should use land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31548
- Scripts/bugzilla-tool:
- 5:25 AM Changeset in webkit [51033] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547
Also fixes a bug in workqueue and adds a test!
- Scripts/bugzilla-tool:
- Scripts/modules/workqueue.py:
- Scripts/modules/workqueue_unittest.py:
- 5:20 AM Changeset in webkit [51032] by
-
- 3 edits in trunk/JavaScriptCore
Fix Qt build on Windows CE 6.
Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-11-16
Reviewed by Simon Hausmann.
- JavaScriptCore.pri: Add missing include path.
- wtf/Platform.h: Include ce_time.h for Windows CE 6.
- 5:05 AM Changeset in webkit [51031] by
-
- 4 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547
Also fixes a bug in workqueue and adds a test!
- Scripts/bugzilla-tool:
- Scripts/modules/workqueue.py:
- Scripts/modules/workqueue_unittest.py:
- 4:29 AM Changeset in webkit [51030] by
-
- 4 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move StyleQueue over to using PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31544
That's what the class it's for.
- Scripts/bugzilla-tool:
- Scripts/modules/patchcollection.py:
- Scripts/modules/patchcollection_unittest.py:
- 4:11 AM Changeset in webkit [51029] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31543
Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
- Scripts/bugzilla-tool:
- 4:04 AM Changeset in webkit [51028] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Disable the style queue from posting to the commit queue status page.
- Scripts/bugzilla-tool:
- 3:54 AM Changeset in webkit [51027] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541
This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.
- Scripts/modules/patchcollection.py: Added.
- Scripts/modules/patchcollection_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 3:47 AM Changeset in webkit [51026] by
-
- 2 edits1 copy1 add in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541
This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.
- Scripts/modules/patchcollection.py: Added.
- Scripts/modules/patchcollection_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 3:31 AM Changeset in webkit [51025] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool check-style should work with attachment ids instead of bug ids
https://bugs.webkit.org/show_bug.cgi?id=31540
- Scripts/bugzilla-tool:
- 3:04 AM Changeset in webkit [51024] by
-
- 4 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WorkQueue is the only place that should know about special exit codes
https://bugs.webkit.org/show_bug.cgi?id=31534
Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
and add tests for handling exit codes.
I also cleaned up workqueue_unittest.py more.
- Scripts/bugzilla-tool:
- Scripts/modules/workqueue.py:
- Scripts/modules/workqueue_unittest.py:
- 3:02 AM Changeset in webkit [51023] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-factor workqueue_unittest to allow for more than one test.
https://bugs.webkit.org/show_bug.cgi?id=31535
- Scripts/modules/workqueue_unittest.py:
- 3:00 AM Changeset in webkit [51022] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532
- Scripts/bugzilla-tool: fix a couple obvious typos.
- 2:50 AM Changeset in webkit [51021] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532
The next patch will move these methods into WebKitLandingScripts.
- Scripts/bugzilla-tool:
- Split out _land_patch and _close_bug_if_no_active_patches.
- 2:45 AM Changeset in webkit [51020] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix silly copy-and-paste code. I am a terrible coder.
- Scripts/modules/bugzilla.py:
- 2:34 AM Changeset in webkit [51019] by
-
- 3 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement a StyleQueue
https://bugs.webkit.org/show_bug.cgi?id=31537
The first iteration of the style queue only produces output locally.
There is also a limit of 10 patches because it's not that useful to
iterate through the entire review queue at this point. We can remove
the limit later.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- 1:25 AM Changeset in webkit [51018] by
-
- 5 edits1 add in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unit test WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=31531
Adds basic unit testing for WorkQueue. Just runs through one cycle.
- Scripts/bugzilla-tool:
- Scripts/modules/statusbot.py:
- Scripts/modules/workqueue.py:
- Scripts/modules/workqueue_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 12:49 AM Changeset in webkit [51017] by
-
- 2 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31530
- Scripts/bugzilla-tool:
- 12:39 AM Changeset in webkit [51016] by
-
- 4 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs apply-attachment
https://bugs.webkit.org/show_bug.cgi?id=31528
- Scripts/bugzilla-tool:
- Add ApplyAttachment command.
- Abstract applying code into WebKitApplyingScripts.
- Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
- Scripts/modules/bugzilla.py:
- Add fetch_attachment and bug_id_for_attachment_id.
- Scripts/modules/bugzilla_unittest.py:
- Add test for new parsing.
- Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
- 12:38 AM Changeset in webkit [51015] by
-
- 3 edits in trunk/WebKitTools
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Document check-style's use of force_clean.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 12:28 AM Changeset in webkit [51014] by
-
- 3 edits1 add in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move WorkQueue to its own file
https://bugs.webkit.org/show_bug.cgi?id=31529
WorkQueue and WorkQueueDelegate are separate concerns from
bugzilla-tool. Also added a missing include to logging.py.
- Scripts/bugzilla-tool:
- Scripts/modules/logging.py:
- Scripts/modules/workqueue.py:
- 12:11 AM Changeset in webkit [51013] by
-
- 3 edits in trunk/WebKitTools
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Siedel.
Move OutputTee to logging.py.
- Scripts/bugzilla-tool:
- Scripts/modules/logging.py:
- 12:07 AM Changeset in webkit [51012] by
-
- 2 edits in trunk/WebKitTools
2009-11-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Refactor bugzilla-tool to allow for multiple queues
https://bugs.webkit.org/show_bug.cgi?id=31513
Divide the commit queue class into three class to make creating
additional queues easier.
- Scripts/bugzilla-tool:
Nov 15, 2009:
- 10:19 PM Changeset in webkit [51011] by
-
- 3 edits in trunk/LayoutTests
Fixing broken layout test.
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 10:02 PM Changeset in webkit [51010] by
-
- 3 edits in trunk/WebKitTools
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
svn-apply may not handle git patches created by bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31457
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 8:44 PM Changeset in webkit [51009] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Correct an error in the previous commit
- public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory, not WebAccessibilityDirectoryRole.
- 7:48 PM Changeset in webkit [51008] by
-
- 3 edits in trunk/WebKit/chromium
2009-11-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Bring WebAccessibilityRole up to sync after
http://trac.webkit.org/changeset/51007.
- public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
- src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and WebAccessibilityRoleDirectory.
- 6:05 PM Changeset in webkit [51007] by
-
- 10 edits2 adds in trunk
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-directory.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isOrderedList):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::createARIARoleMap):
WebKit/mac:
Fix a spelling error in the comment of a localized (accessibility) string.
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
LayoutTests:
- platform/mac/accessibility/aria-directory-expected.txt: Added.
- platform/mac/accessibility/aria-directory.html: Added.
- 3:34 PM Changeset in webkit [51006] by
-
- 2 edits in trunk/WebCore
2009-11-15 Dave Tapuska <dtapuska@rim.com>
Reviewed by George Staikos.
Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp
- platform/text/StringHash.h: (WebCore::StringHash::equal):
- 3:32 PM Changeset in webkit [51005] by
-
- 3 edits in trunk/WebKitTools
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
bugzilla-tool should post git binary diff
https://bugs.webkit.org/show_bug.cgi?id=31458
Add --binary option to Git.create_patch.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 3:29 PM Changeset in webkit [51004] by
-
- 2 edits in trunk/WebCore
2009-11-15 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
- bindings/v8/V8DOMWrapper.cpp:
- 3:28 PM Changeset in webkit [51003] by
-
- 2 edits in trunk/WebCore
2009-11-15 Maxime Simon <Maxime Simon>
Reviewed by Adam Barth.
[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
- platform/haiku/FileChooserHaiku.cpp:
- 3:26 PM Changeset in webkit [51002] by
-
- 2 edits in trunk/WebCore
2009-11-15 Maxime Simon <Maxime Simon>
Reviewed by Adam Barth.
[Haiku] Build fix. ColorSpace name had a wrong CamelCase.
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
- 3:24 PM Changeset in webkit [51001] by
-
- 4 edits in trunk/WebKitTools
2009-11-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add bugzilla-tool check-style
https://bugs.webkit.org/show_bug.cgi?id=31515
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- 3:15 PM Changeset in webkit [51000] by
-
- 8 edits in trunk/WebCore
2009-11-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r50999.
http://trac.webkit.org/changeset/50999
Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setUserEdited): (WebCore::RenderTextControl::subtreeHasChanged):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited): (WebCore::RenderTextControl::isUserEdited):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 2:55 PM Changeset in webkit [50999] by
-
- 8 edits in trunk/WebCore
2009-11-15 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.
No functionality was changed. So, no tests were included.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
Nov 14, 2009:
- 12:55 PM Changeset in webkit [50998] by
-
- 11 edits5 adds in trunk
WebCore: Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
Test: fast/overflow/line-clamp.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.
- WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
- rendering/style/LineClampValue.h: Added.
(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):
- rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
- rendering/style/RenderStyle.h: Use LineClampValue.
(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests: Test for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
- fast/overflow/line-clamp.html: Added.
- platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
- platform/mac/fast/overflow/line-clamp-expected.png: Added.
- platform/mac/fast/overflow/line-clamp-expected.txt: Added.
- 12:24 PM QtBackLog edited by
- Mention individual commits (diff)
- 9:53 AM Changeset in webkit [50997] by
-
- 8 edits in trunk
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme
- WebCore.base.exp: Export wkMediaControllerThemeAvailable
- platform/mac/WebCoreSystemInterface.h: Ditto.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.
- 7:21 AM Changeset in webkit [50996] by
-
- 4 edits3 adds in trunk
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for reading/writing .type property of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004
- fast/forms/input-type-change3-expected.txt: Added.
- fast/forms/input-type-change3.html: Added.
- fast/forms/script-tests/input-type-change3.js: Added.
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
- Recognizes date/datetime/datetime-local/month/time/week types of INPUT element. They have no dedicated UI and no type validation for now.
- Clean up setInputType() and formControlType() of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=29004
Test: fast/forms/input-type-change3.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::tooLong): (WebCore::createTypeMap): Initializer for a static local variable. (WebCore::HTMLInputElement::setInputType): (WebCore::createFormControlTypes): Initializer for a static local variable. (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::isTextField): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
- html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.
- 6:08 AM Changeset in webkit [50995] by
-
- 2 edits in trunk/LayoutTests
Skip new test that needs new DRT infrastructure, with bug filled.
Nov 13, 2009:
- 10:24 PM Changeset in webkit [50994] by
-
- 5 edits2 adds in trunk
WAI-ARIA: checkbox does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=31456
Reviewed by Darin Adler.
WebCore:
Test: accessibility/aria-checkbox-text.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
LayoutTests:
- accessibility/aria-checkbox-text.html: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/aria-checkbox-text-expected.txt: Added.
- platform/win/Skipped:
- 8:54 PM Changeset in webkit [50993] by
-
- 7 edits in trunk
WebCore:
2009-11-13 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
This is just enough changes to unbreak the port.
- bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):
- loader/FrameLoaderClient.h:
WebKit/chromium:
2009-11-13 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Rename windowObjectCleared to dispatchDidClearWindowObjectInWorld
to catch up http://trac.webkit.org/changeset/50973.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
- src/FrameLoaderClientImpl.h:
- 7:34 PM Changeset in webkit [50992] by
-
- 2 edits in trunk/WebCore
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld): Provide an empty implementation of this method because I don't know what it is supposed to do on Chromium.
- 7:11 PM Changeset in webkit [50991] by
-
- 2 edits in trunk/WebCore
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
- loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds() public, as Chromium's V8Proxy calls it.
- 6:58 PM Changeset in webkit [50990] by
-
- 2 edits in trunk/WebCore
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix to Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):
- 6:45 PM Changeset in webkit [50989] by
-
- 2 edits in trunk/WebCore
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
- platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
- 6:29 PM Changeset in webkit [50988] by
-
- 4 edits in trunk/WebCore
2009-11-13 Adam Barth <abarth@webkit.org>
Unreviewed partial build fix for Chromium. Should fix failure #4.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):
- bindings/v8/ScriptController.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):
- 6:18 PM Changeset in webkit [50987] by
-
- 2 edits in trunk/WebCore
2009-11-13 Adam Barth <abarth@webkit.org>
Unreviewed partial build fix for Chromium.
- bindings/v8/ScriptController.h: (WebCore::ScriptController::getAllWorlds):
- 5:47 PM Changeset in webkit [50986] by
-
- 2 edits in trunk/LayoutTests
Disable websocket tests on Tiger, as they time out.
Filed <https://bugs.webkit.org/show_bug.cgi?id=31501> to investigate this issue.
- platform/mac-tiger/Skipped:
- 5:40 PM Changeset in webkit [50985] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-13 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium WebKit Port to compile as dynamic lib
- WebKit.gyp:
- 5:33 PM Changeset in webkit [50984] by
-
- 2 edits in trunk/WebKit/wx
wx build fix after r50923 change to externalRepresentation.
- 5:22 PM Changeset in webkit [50983] by
-
- 4 edits in trunk/WebKit/chromium
woo
- 5:07 PM Changeset in webkit [50982] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31050
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-13
Reviewed by Gavin Barraclough.
Adding optimization support for mode JSVALUE32_64
on ARM systems.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
- 4:44 PM Changeset in webkit [50981] by
-
- 8 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31050
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-14
Reviewed by Gavin Barraclough.
Adding JSVALUE32_64 support for ARM (but not turning it
on by default). All optimizations must be disabled, since
this patch is only the first of a series of patches.
During the work, a lot of x86 specific code revealed and
made platform independent.
See revisions: 50531 50541 50593 50594 50595
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fdivd_r):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::set8):
(JSC::MacroAssemblerARM::setTest8):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::zeroDouble):
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
- wtf/StdLibExtras.h:
- 4:39 PM Changeset in webkit [50980] by
-
- 3 edits in trunk/WebCore
2009-11-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
- WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
- WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
- 4:27 PM Changeset in webkit [50979] by
-
- 5 edits in trunk
2009-11-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitry Titov.
LocalStorage quota should include key sizes in its count
https://bugs.webkit.org/show_bug.cgi?id=31451
- storage/StorageMap.cpp: (WebCore::StorageMap::setItem):
Count keys in the quota when adding a new item.
(WebCore::StorageMap::removeItem):
Remove the key's length from the quota if we're removing the item.
(WebCore::StorageMap::importItem):
Assume that we're adding things for the first time.
Count keys in the quota.
2009-11-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitry Titov.
Now that we're tracking key size in the quota, we can't fit as much in.
https://bugs.webkit.org/show_bug.cgi?id=31451
- storage/domstorage/quota-expected.txt:
- storage/domstorage/script-tests/quota.js: (testQuota):
- 4:25 PM Changeset in webkit [50978] by
-
- 2 edits in trunk/WebKitSite
2009-11-13 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added to the WebKit Coding Style Guidelines not to use
"using namespace" statements in header files.
- coding/coding-style.html:
- 4:09 PM Changeset in webkit [50977] by
-
- 8 edits1 move in trunk
2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
Adding isAlphanumeric abstraction, required
by TextBoundaries.cpp.
- wtf/unicode/glib/UnicodeGLib.h: (WTF::Unicode::isAlphanumeric):
- wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isAlphanumeric):
2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
Moving TextBoundariesICU.cpp to TextBoundaries.cpp
by removing the direct ICU dependency and replacing it
with WTF functions and WebCore's own TextBreakIterator
abstractions.
- GNUmakefile.am:
- platform/graphics/gtk/SimpleFontDataGtk.cpp:
- platform/text/TextBoundaries.cpp: Added. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
- platform/text/TextBoundariesICU.cpp: Removed.
- platform/text/TextBreakIterator.h:
- platform/text/TextBreakIteratorICU.cpp: (WebCore::textBreakLast): (WebCore::textBreakPrevious):
- 4:07 PM Changeset in webkit [50976] by
-
- 4 edits in trunk
2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459
Before this change, the render tree output for this test was wrong.
Note that #FF0000 (red) becomes #008000 (green) now.
- platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459
- rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
- 4:06 PM Changeset in webkit [50975] by
-
- 5 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Reviewed by Dan Bernstein.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:56 PM Changeset in webkit [50974] by
-
- 2 edits in trunk/WebKit/win
Build fix
- Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
- 3:49 PM Changeset in webkit [50973] by
-
- 45 edits2 adds in trunk
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Fixes <http://webkit.org/b/31124>.
Reviewed by Dave Hyatt.
WebCore:
Tell FrameLoaderClient when window objects in isolated worlds are
cleared
Test: http/tests/security/isolatedWorld/didClearWindowObject.html
- bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
worlds in m_worldSet to the passed-in Vector.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds): Added. Calls through to
WebCoreJSClientData.
(WebCore::ScriptController::initScript): Changed to call
FrameLoader::dispatchDidClearWindowObjectInWorld.
- bindings/js/ScriptController.h: Added getAllWorlds.
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Updated for FrameLoaderClient change.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::begin):
Changed to call dispatchDidClearWindowObjectsInAllWorlds.
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
Added. Retrieves all the worlds, then calls through to
dispatchDidClearWindowObjectInWorld for each one.
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
dispatchWindowObjectAvailable. Calls up to the client, then, if the
world is the mainThreadNormalWorld(), tells the Inspector about it,
too.
- loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
dispatchDidClearWindowObjectInWorld. Added
dispatchDidClearWindowObjectsInAllWorlds.
- loader/FrameLoaderClient.h: Replaced windowObjectCleared with
dispatchDidClearWindowObjectForWorld.
WebKit:
Add WebFrameLoadDelegatePrivat.h to WebKit.xcodeproj
- WebKit.xcodeproj/project.pbxproj: Added
WebFrameLoadDelegatePrivate.h, which already existed.
WebKit/gtk:
Update for changes to FrameLoaderClient
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientGtk.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/haiku:
Update for changes to FrameLoaderClient
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientHaiku.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Replaced windowObjectCleared with this function. If the delegate
implements it, call
-webView:didClearWindowObjectForFrame:inScriptWorld:. Otherwise, if
the passed-in world is the mainThreadNormalWorld(), call
-webView:didClearWindowObject:forFrame:.
- WebView/WebDelegateImplementationCaching.h: Added a new entry in the
frame load delegate implementation cache for the new delegate method.
- WebView/WebFrameLoadDelegatePrivate.h:
- WebView/WebScriptWorld.mm:
(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(-[WebScriptWorld initWithWorld:]): Add ourselves to allWorlds().
(-[WebScriptWorld dealloc]): Remove ourselves from allWorlds().
(+[WebScriptWorld findOrCreateWorld:]): Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.
- WebView/WebScriptWorldInternal.h: Declared +findOrCreateWorld:.
- WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]): Cache the
implementation of the new frame load delegate method.
WebKit/qt:
Update for changes to FrameLoaderClient
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientQt.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/win:
- Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
didClearWindowObjectForFrameInScriptWorld.
- WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
- WebFrame.h:
Replaced windowObjectCleared with this function. If the delegate
implements IWebFrameLoadDelegatePrivate2, call
didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
world is the mainThreadNormalWorld(), call
didClearWindowObjectForFrame.
- WebScriptWorld.cpp:
(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
(WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
(WebScriptWorld::standardWorld): Added this non-COM getter for the
standard world, which the COM getter now calls through to.
(WebScriptWorld::findOrCreateWorld): Added. Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.
- WebScriptWorld.h: Added new standardWorld overload, made one
overload of createInstance private, and added findOrCreateWorld.
WebKit/wx:
Update for changes to FrameLoaderClient
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchDidClearWindowObjectInWorld):
- WebKitSupport/FrameLoaderClientWx.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKitTools:
Add support for
http/tests/security/isolatedWorld/didClearWindowObject.html
- DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
Added. Moved code here from -webView:didClearWindowObject:forFrame:.
(-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
Added. Sets a worldID property on the global object whose value is
the ID of this world.
(-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
Respond to this new delegate callback by calling through to one of the
above new methods.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID for this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.
- DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didClearWindowObject): Moved code from hear to
didClearWindowObjectForFrameInStandardWorld.
(FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
Respond to this new delegate callback by calling through to one of the
below new methods.
(FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
Added. Sets a worldID property on the gobal object whose value is
the ID of this world.
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
Added. Moved code here from didClearWindowObject.
- DumpRenderTree/win/FrameLoadDelegate.h: Added the
didClearWindowObjectForFrame* functions.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID of this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.
LayoutTests:
Test that delegates can modify global objects in isolated worlds
- http/tests/security/isolatedWorld/didClearWindowObject-expected.txt: Added.
- http/tests/security/isolatedWorld/didClearWindowObject.html: Added.
Tests that the global object in the normal world does not have a
worldID property, and that the global object in isolated worlds has
a worldID property whose value is equal to the world's ID.
- 3:46 PM Changeset in webkit [50972] by
-
- 2 edits in trunk/WebCore
2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix SVG context assignment for pod types.
https://bugs.webkit.org/show_bug.cgi?id=31497
I broke this in r50958.
Tested by svg/custom/viewport-update2.svg.
- bindings/scripts/CodeGeneratorV8.pm:
- 3:38 PM Changeset in webkit [50971] by
-
- 12 edits in trunk/WebCore
Bring the platform/android files inline with Android 2.0
https://bugs.webkit.org/show_bug.cgi?id=31423
Patch by Andrei Popescu <andreip@google.com> on 2009-11-13
Reviewed by Dmitry Titov.
No new tests required: these are all Android-specific files.
- platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::files):
- platform/android/ClipboardAndroid.h:
- platform/android/FileChooserAndroid.cpp:
(WebCore::FileChooser::basenameForWidth):
(WebCore::fileButtonChooseFileLabel):
- platform/android/KeyEventAndroid.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/android/LocalizedStringsAndroid.cpp:
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::searchableIndexIntroduction):
(WebCore::resetButtonDefaultLabel):
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
- platform/android/RenderThemeAndroid.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeAndroid::baselinePosition):
(WebCore::RenderThemeAndroid::paintButton):
(WebCore::adjustMenuListStyleCommon):
(WebCore::RenderThemeAndroid::paintCombo):
- platform/android/ScreenAndroid.cpp:
- platform/android/ScrollViewAndroid.cpp:
(WebCore::ScrollView::platformOffscreenContentRectangle):
- platform/android/TemporaryLinkStubs.cpp:
(JSC::Bindings::dispatchJNICall):
- platform/android/WidgetAndroid.cpp:
(WebCore::Widget::setFrameRect):
- 3:33 PM UsingGitWithWebKit edited by
- (diff)
- 3:21 PM Changeset in webkit [50970] by
-
- 4 edits in trunk
2009-11-13 Norbert Leser <norbert.leser&nokia.com>
Reviewed by Eric Seidel.
Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).
- JavaScriptCore.pri:
2009-11-13 Norbert Leser <norbert.leser&nokia.com>
Reviewed by Eric Seidel.
Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).
- WebCore.pro:
- 3:20 PM Changeset in webkit [50969] by
-
- 2 edits in trunk/LayoutTests
Remove the unnecessary call to dumpDatabaseCallbacks().
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31495
- storage/hash-change-with-xhr.html:
- 1:51 PM Changeset in webkit [50968] by
-
- 23 edits5 adds in trunk
Implement composition events introduced in DOM Level 3.
This change adds a new IDL which defines the composition events, adds a class which
implements the composition events, and sends the composition events according to
the specification.
https://bugs.webkit.org/show_bug.cgi?id=26310
Patch by Hironori Bono <hbono@chromium.org> on 2009-11-13
Reviewed by Oliver Hunt.
WebCore:
Test: fast/events/ime-composition-events-001.html
- DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
- GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
- WebCore.gypi: ditto.
- WebCore.pro: ditto
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
- WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
- bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
- bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
- bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
(WebCore::V8DOMWrapper::convertEventToV8Object):
- bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
- bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
- dom/CompositionEvent.cpp: Implements the CompositionEvent class.
(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
(WebCore::CompositionEvent::isCompositionEvent):
- dom/CompositionEvent.h: Declares the CompositionEvent class.
(WebCore::CompositionEvent::create):
(WebCore::CompositionEvent::data):
- dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
- dom/Event.cpp:
(WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
- dom/Event.h:
- dom/EventNames.h: Added composition{start,update,end} to eventNames.
- editing/Editor.cpp:
(WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
(WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
LayoutTests:
- fast/events/ime-composition-events-001-expected.txt: Added.
- fast/events/ime-composition-events-001.html: Added.
- platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
- platform/qt/Skipped: ditto.
- platform/win/Skipped: ditto.
- 1:26 PM Changeset in webkit [50967] by
-
- 2 edits in trunk/WebCore
Fix a link error in unofficial GCC 4.4 builds on Linux.
https://bugs.webkit.org/show_bug.cgi?id=31477
Reviewed by Dimitri Glazkov.
- bindings/v8/V8Binding.cpp: Add explicit instantiations of v8StringToWebCoreString template.
- 12:55 PM Changeset in webkit [50966] by
-
- 3 edits in trunk/WebCore
2009-11-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix Debug build after http://trac.webkit.org/changeset/50960.
The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
https://bugs.webkit.org/show_bug.cgi?id=31213
- rendering/CounterNode.cpp: (WebCore::showTreeAndMark):
- rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
- 12:50 PM Changeset in webkit [50965] by
-
- 3 edits1 add in trunk
WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
defined in the SuppressedValgrindErrors file.
Reviewed by Simon Hausmann.
- Scripts/run-webkit-tests:
LayoutTests: Add a file for suppressing invalid valgrind errors (Qt / Linux only)
Reviewed by Simon Hausmann.
- platform/qt/SuppressedValgrindErrors: Added.
- 12:42 PM Changeset in webkit [50964] by
-
- 4 edits in trunk/JavaScriptCore
JSValueProtect and JSValueUnprotect don't protect API wrapper values
https://bugs.webkit.org/show_bug.cgi?id=31485
Reviewed by Geoff Garen.
Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.
- 12:35 PM Changeset in webkit [50963] by
-
- 2 edits in trunk/WebCore
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960
We currently fill a path with solid color instead of filling
a clipping path. This causes problems on some composite operators,
since Cairo modifies the area outside the path.
This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
Thanks to Benjamin Otte for tracking the bug down.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill):
- 12:29 PM Changeset in webkit [50962] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-13 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Antti Koivisto.
Fix typo, ce_time.cpp should be ce_time.c
- JavaScriptCore.pri:
- 12:25 PM Changeset in webkit [50961] by
-
- 11 edits1 add in trunk
Adding Chromium's DatabaseTracker implementation.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31440
WebCore:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- storage/DatabaseTracker.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
- storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::updateDatabaseSize):
- storage/chromium/QuotaTracker.h:
WebKit/chromium:
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::exceededDatabaseQuota):
- src/DatabaseObserver.cpp: Added.
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
- src/WebDatabase.cpp:
(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
- src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::toString):
(WebKit::WebSecurityOrigin::databaseIdentifier):
- 12:21 PM Changeset in webkit [50960] by
-
- 7 edits in trunk/WebCore
2009-11-13 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
https://bugs.webkit.org/show_bug.cgi?id=31213
Added tree navigation methods that permit full implementation of CSS2.1
counter feature without using recursion proportional to the counter
tree depth.
No new tests because I did not find any bug that is fixed by this
commit yet, this just reduces the size of the patch for 11031 and
helps respond to some concerns regarding that patch.
- rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::nextInPreOrderAfterChildren):
(WebCore::CounterNode::nextInPreOrder):
Added to support non-recursive tree traversal necessary for
efficient full implementation of CSS2.1 counters.
(WebCore::CounterNode::lastDescendant):
(WebCore::CounterNode::previousInPreOrder):
Moved this methods such that they occupy a place similar to that of
identically named methods on the render tree. This allows for their
broader use needed in full implementation of CSS2.1 counters.
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
Changed such that insertion/removal of a counter, triggers not only
recalculation of PrefixWidths, but also reassesment of values in
counter nodes. This is the basis full implementation of CSS2.1
counters. It does not change current behavior by much because of
changes needed to the recalculation algorithm, but those are comming
in the patch for 11031.
(WebCore::showTreeAndMark):
- rendering/CounterNode.h:
- rendering/RenderCounter.cpp: (WebCore::counter): Only changed argument type to prepare for implementation of Darin Adler's recommendation for the patch to 11031.
(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeChildren):
(WebCore::RenderCounter::destroyCounterNodes):
- rendering/RenderCounter.h:
- rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
- rendering/RenderObjectChildList.h: Added the ability to restrict invalidation to counters with a given identifier. Also invalidated counters that are on the child container itself which were missed by the previous algorithm, but were a valid case.
- 12:04 PM Changeset in webkit [50959] by
-
- 2 edits in trunk/WebKitTools
Set the locale to C and not to the current one in use on the system.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 11:56 AM Changeset in webkit [50958] by
-
- 3 edits in trunk/WebCore
2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Protect SVG animated properties from destruction in bindings.
https://bugs.webkit.org/show_bug.cgi?id=31474
Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
under Valgrind.
Made sure we keep a reference to SVG properties while setting a
context:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::withSVGContext):
- 11:30 AM Changeset in webkit [50957] by
-
- 2 edits in trunk/LayoutTests
Disable websocket tests on Windows, as the server cannot start on buildbot.
Filed <https://bugs.webkit.org/show_bug.cgi?id=31479> to investigate this issue.
- platform/win/Skipped:
- 11:21 AM Changeset in webkit [50956] by
-
- 2 edits in trunk/WebCore
[CAIRO] shadow support for Canvas and SVG.
https://bugs.webkit.org/show_bug.cgi?id=30960
Reviewed by Alexey Proskuryakov.
Incorporate Benjamin Otte's recommendations to avoid
a buffer overrun, and small performance improvement.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::copyContextProperties): Correctly size output
storage for cairo_get_dash to avoid buffer overrun.
(WebCore::drawPathShadow): Prefer cairo_fill_extents
to slower cairo_stroke_extents when not drawing shadows.
- 11:19 AM Changeset in webkit [50955] by
-
- 1 edit in trunk/WebCore/ChangeLog
Restoring parst of ChangeLog that were somehow deleted with my latest commit.
- 11:14 AM Changeset in webkit [50954] by
-
- 4 edits in trunk/WebCore
Do not register Chromium's HTML5 DB VFS as the default
VFS. Otherwise, other sqlite DB users in the same process will
stop working.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31462
- platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 10:51 AM Changeset in webkit [50953] by
-
- 2 edits in trunk/WebCore
Windows build fix
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags, avoiding a sign mismatch warning.
- 10:47 AM Changeset in webkit [50952] by
-
- 2 edits in trunk/WebCore
Release build fix.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): Use ASSERT_UNUSED for unused stream parameter.
- 10:14 AM Changeset in webkit [50951] by
-
- 7 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31441
Implement SocketStreamHandleCFNet
Existing WebSocket tests now pass on Mac. No proxy support yet.
- platform/network/SocketStreamHandleClient.h:
- platform/network/cf/SocketStreamHandle.h: (WebCore::SocketStreamHandle::shouldUseSSL): (WebCore::SocketStreamHandle::refAuthenticationClient): (WebCore::SocketStreamHandle::derefAuthenticationClient): (WebCore::SocketStreamHandle::):
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::chooseProxy): (WebCore::SocketStreamHandle::createStreams): (WebCore::SocketStreamHandle::copyCFStreamDescription): (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
- 10:07 AM Changeset in webkit [50950] by
-
- 2 edits in trunk/LayoutTests
Fix worker-timeout.html layout test that fails in Chromium harness.
https://bugs.webkit.org/show_bug.cgi?id=31452
Reviewed by Darin Adler.
- fast/workers/worker-timeout.html:
Stop logging timer messages at the same time as calling NotifyDone() because
in test harness Chromium uses for workers it does not capture the output immediately.
- 9:51 AM Changeset in webkit [50949] by
-
- 2 edits in trunk/WebKitLibraries
Build correction. No review.
The WinCairo build requires ENABLE_FILTERS to work properly.
- win/tools/vsprops/WinCairo.vsprops:
- 9:50 AM Changeset in webkit [50948] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-13 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling Chromium dependencies to match Chromium revision 31834.
- DEPS:
- 9:26 AM Changeset in webkit [50947] by
-
- 2 edits in trunk/WebCore
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: preload status bar button glyphs
in order to prevent them from flickering (take 2).
- inspector/front-end/inspector.js: (preloadImages):
- 9:10 AM Changeset in webkit [50946] by
-
- 3 edits2 deletes in trunk
2009-11-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Barth.
Chromium: [REGRESSION] Crash while stopping on a breakpoint.
Rolling back r50890.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):
- 9:10 AM Changeset in webkit [50945] by
-
- 2 edits in trunk/WebKit/win
Build fix
- Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
are order-dependent!
- 9:05 AM Changeset in webkit [50944] by
-
- 2 edits in trunk/WebKit/win
Touch WebKit.idl to fix the Windows build
- Interfaces/WebKit.idl: Sorted #includes.
- 8:58 AM Changeset in webkit [50943] by
-
- 10 edits in trunk
Finish replacing worldIDs with world objects
The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.
Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
Reviewed by Mark Rowe.
WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
- WebView/WebFramePrivate.h:
Renamed from
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGobalObject:FromString:.
Now takes a WebScriptWorld instead of a worldID, so we don't need to
maintain a map of worldID -> world anymore.
WebKit/win:
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
- WebFrame.h:
Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.
WebKitTools:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
Updated for changes to WebFrame. Now holds the map of worldID -> world
at this level instead of making WebKit do it.
- 8:43 AM Changeset in webkit [50942] by
-
- 3 edits in trunk/WebKitTools
[Qt] Ensure the DRT does not output anything until first test is run
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- DumpRenderTree/qt/DumpRenderTree.h:
- 8:11 AM Changeset in webkit [50941] by
-
- 2 edits in trunk/WebKitTools
Clear the undo stack in before each new test run.
Reviewed by Tor Arne Vestbø.
Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 7:06 AM Changeset in webkit [50940] by
-
- 6 edits in trunk/WebKit/qt
Update documentation for the Qt API
Reviewed by Simon Hausmann.
- Api/qgraphicswebview.cpp:
- Api/qwebelement.cpp:
- Api/qwebframe.cpp:
- Api/qwebsettings.cpp:
- Api/qwebview.cpp:
- 6:57 AM Changeset in webkit [50939] by
-
- 4 edits in trunk
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960
This is the fix of a regression, caused by the shadow patch
from the bug above. Reinserted the save and restore calls
that were accidently removed by the previous patch.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):
Skip fast/canvas/canvas-shadow.html we need to enable filters
on cairo to pass this test.
- platform/gtk/Skipped:
- 5:49 AM Changeset in webkit [50938] by
-
- 5 edits in trunk
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable Page Cache if setMaximumPagesInCache needs it.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31266.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setMaximumPagesInCache):
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
- 5:21 AM Changeset in webkit [50937] by
-
- 2 edits in trunk/WebKit/qt
2009-11-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix initial QWebView focus behavior.
focusController->setFocused(true) was not always called.
https://bugs.webkit.org/show_bug.cgi?id=31466
- Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent):
- 5:12 AM Changeset in webkit [50936] by
-
- 2 edits in trunk/WebKit/qt
Use correct install-path when running qdoc3
Reviewed by Simon Hausmann.
- docs/docs.pri:
- 2:45 AM Changeset in webkit [50935] by
-
- 2 edits in trunk/WebCore
2009-11-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Reverting r50908 since it makes inspector tests
time out.
- inspector/front-end/inspector.js:
- 2:21 AM Changeset in webkit [50934] by
-
- 2 edits in trunk/LayoutTests
Skip one new test.
- 1:51 AM Changeset in webkit [50933] by
-
- 5 edits1 add in trunk/WebCore
2009-11-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER.
- WebCore.gypi:
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
- bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CustomBinding.h:
- page/Console.idl:
- 1:34 AM Changeset in webkit [50932] by
-
- 2 edits in trunk/WebCore
Chromium build fix.
Reviewed by NOBODY.
- bindings/v8/ScriptController.h:
(WebCore::ScriptController::evaluateInWorld): Add a dummy
method which isn't called in chromium to make things compile.
- 12:11 AM Changeset in webkit [50931] by
-
- 2 edits in trunk/WebKitTools
2009-11-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update committers.py based on svn records
https://bugs.webkit.org/show_bug.cgi?id=31366
This list was generated using validate-committer-lists from
https://bugs.webkit.org/show_bug.cgi?id=30970
and makes committers.py current for committers who have
committed in the last 3 years.
- Scripts/modules/committers.py:
Nov 12, 2009:
- 11:52 PM Changeset in webkit [50930] by
-
- 4 edits in trunk/WebKit/mac
When exiting full-screen video, rather than resetting the system UI
mode, restore it to what it was when full-screen mode was entered.
Reviewed by Adele Peterson.
- WebView/WebVideoFullscreenController.h: Cleaned up style, removed
unnecessary imports, and added _savedUIMode and _savedUIOptions ivars.
- WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController delegate]): Cleaned up style.
(-[WebVideoFullscreenController setDelegate:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Restore the
system UI mode.
(-[WebVideoFullscreenController windowDidEnterFullscreen]): Save the
system UI mode.
- WebView/WebView.mm: Added now-necessary import.
- 10:42 PM Changeset in webkit [50929] by
-
- 7 edits in trunk
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-html and window-html tests don't use a setTimeout to notify that the
test is completed. The layout test plugin now issues the notifyDone call via
javascript.
- plugins/document-open.html:
- plugins/window-open.html:
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance, which causes a crash when the plugin stream
dereferences an invalid m_client pointer which points to the PluginView instance which
is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
and check for the same.
- plugins/PluginStream.cpp: (WebCore::PluginStream::stop): (WebCore::PluginStream::destroyStream):
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance. The pluginLog function in the layout test
plugin attempts to retrieve the window script object on a torn down plugin instance
which crashed consistently on windows in the debugger. The functions which issue
these logs already have a valid window script object. We now have variants of the pluginLog
function which take in a window script object with and without variable arguments.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLogWithWindowObject): (pluginLogWithWindowObjectVariableArgs): (pluginLog): (notifyTestCompletion): (testDocumentOpen): (testWindowOpen):
- 9:17 PM Changeset in webkit [50928] by
-
- 5 edits in trunk
Renaming some parameters passed to DB-related methods to better
indicate their purpose.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31449
WebCore:
- platform/chromium/ChromiumBridge.h:
WebKit/chromium:
- public/WebKitClient.h:
- src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):
- 9:08 PM Changeset in webkit [50927] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-12 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Adam Barth.
Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
https://bugs.webkit.org/show_bug.cgi?id=31416
- wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): (JSC::parseDateFromNullTerminatedCharacters):
- 8:59 PM Changeset in webkit [50926] by
-
- 3 edits in trunk/LayoutTests
2009-11-12 Kinuko Yasuda <kinuko@google.com>
Reviewed by Adam Barth.
Makes the output of fast/events/mouse-click-events.html independent
of the window size.
https://bugs.webkit.org/show_bug.cgi?id=31405
- fast/events/mouse-click-events-expected.txt:
- fast/events/script-tests/mouse-click-events.js:
- 8:36 PM Changeset in webkit [50925] by
-
- 3 edits4 adds in trunk
2009-11-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transformed reflected elements are clipped inside element with opacity
https://bugs.webkit.org/show_bug.cgi?id=30957
transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
each clip rect into painting space before taking the unions. This, however, did not work
correctly with combinations of reflections and transforms. Fixed by unioning the
clipRect and mapping through transforms along the way.
Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
where the transparency layers are.
Test: fast/reflections/opacity-reflection-transform.html
- rendering/RenderLayer.cpp: (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers):
- 7:17 PM QtWebKitPlugins edited by
- (diff)
- 7:05 PM Changeset in webkit [50924] by
-
- 2 edits in trunk/WebCore
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Improve SecurityOrigin::toString comment
https://bugs.webkit.org/show_bug.cgi?id=31041
- page/SecurityOrigin.h:
- 6:37 PM Changeset in webkit [50923] by
-
- 12 edits in trunk
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
- WebCore.base.exp:
- rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
- rendering/RenderTreeAsText.h:
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
- webkit/webkitwebframe.cpp: (webkit_web_frame_dump_render_tree):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
- Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
- Api/qwebframe.cpp: (QWebFrame::renderTreeDump):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
- WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation):
- 6:22 PM Changeset in webkit [50922] by
-
- 3 edits1 delete in trunk/WebCore
[Android] The Android specific files in page/Android are out of date.
https://bugs.webkit.org/show_bug.cgi?id=31437
Reviewed by Dimitri Glazkov.
No tests required.
- page/android/DragControllerAndroid.cpp:
(WebCore::DragController::dragOperation): Added.
(WebCore::DragController::cleanupAfterSystemDrag):
- page/android/EventHandlerAndroid.cpp:
(WebCore::EventHandler::accessKeyModifiers): Added.
- page/android/InspectorControllerAndroid.cpp: Removed.
- 5:59 PM Changeset in webkit [50921] by
-
- 9 edits2 adds in trunk
2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument
Added testing support for AtkDocument implementation.
- accessibility/document-attributes.html: Added.
- accessibility/document-attributes-expected.txt: Added.
- platform/mac/Skipped:
- platform/win/Skipped:
2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument
Added testing support.
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/AccessibilityUIElement.h: (getDocumentEncodingCallback): (getDocumentURICallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI):
- 5:47 PM Changeset in webkit [50920] by
-
- 10 edits5 adds in trunk
WebCore: [CAIRO] shadow support for Canvas and SVG.
https://bugs.webkit.org/show_bug.cgi?id=30960
Reviewed by Simon Fraser.
Implement Canvas/SVG shadow support for Cairo. This patch
uses the filter code from SVG Filters. That means that it is
necessary to activate filters to see the shadows.
Test: fast/canvas/canvas-shadow.html
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(GraphicsContext::calculateShadowBufferDimensions): New helper routine.
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::copyContextProperties):
(WebCore::drawPathShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::createPlatformShadow):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw): Add filter effect.
- platform/graphics/filters/Filter.h: Correct 'const' signatures.
- platform/graphics/filters/ImageBufferFilter.cpp: Added.
- platform/graphics/filters/ImageBufferFilter.h: Added.
- svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
- svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
LayoutTests: Some tests for canvas shadow.
Patch by Dirk Schulze <krit@webkit.org> on 2009-11-11
Reviewed by Simon Fraser.
- fast/canvas/canvas-shadow-expected.txt: Added.
- fast/canvas/canvas-shadow.html: Added.
- fast/canvas/script-tests/canvas-shadow.js: Added.
- 5:12 PM Changeset in webkit [50919] by
-
- 4 edits in trunk/WebCore
Add postTaskToMainThread to ScriptExecutionContext.
Move the code to post task to the main thread into a new method on ScriptExecutionContext,
to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
contexts that live on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=31427
Reviewed by Alexey Proskuryakov.
No new tests - simply moving the code.
- dom/Document.cpp:
(WebCore::Document::postTask):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskData::PerformTaskData):
(WebCore::PerformTaskData::performTask):
(WebCore::ScriptExecutionContext::postTaskToMainThread):
- dom/ScriptExecutionContext.h:
- 4:44 PM Changeset in webkit [50918] by
-
- 2 edits in trunk/WebCore
2009-11-12 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Fix crash when removing compositing layers when GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=31429
Workaround <rdar://problem/7390716> by special-casing the removal
of all sublayers when GC is enabled.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::safeSetSublayers): (WebCore::GraphicsLayerCA::updateSublayerList): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- 4:38 PM Changeset in webkit [50917] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Steve Falkenburg.
Add failing tests to Skipped list.
- platform/win/Skipped:
- 4:28 PM Changeset in webkit [50916] by
-
- 4 edits in trunk/JavaScriptCore
Rollout r50896 until i can work out why it causes failures.
- 4:23 PM Changeset in webkit [50915] by
-
- 2 edits in trunk/JavaScriptCore
Remove LIBRARY directive from def file to fix Debug_All target.
Reviewed by Stephanie Lewis.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:17 PM Changeset in webkit [50914] by
-
- 4 edits in trunk/WebCore
The last of the V8 binding optimizations.
- Replace string-valued element accessors with a shared getter/setter function.
- Change error handling flow of control to avoid extra branches and function calls.
https://bugs.webkit.org/show_bug.cgi?id=31443
Reviewed by Dimitri Glazkov.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr): Body of string-valued Element getter function.
(WebCore::setElementStringAttr): Body of string-valued Element setter function.
- bindings/v8/V8Binding.h:
- 3:48 PM Changeset in webkit [50913] by
-
- 2 edits in trunk/LayoutTests
Skipping tests that fail intermitently.
- 3:46 PM Changeset in webkit [50912] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Add ChangeLog entry to the last commit
- 3:39 PM Changeset in webkit [50911] by
-
- 1 edit in trunk/JavaScriptCore/wtf/FastMalloc.h
Revert "Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix"
This reverts commit d3f6ad156fc2ba883fdff85e7121bee9537cd021.
Conflicts:
JavaScriptCore/ChangeLog
- 3:21 PM Changeset in webkit [50910] by
-
- 3 edits3 adds in trunk
WebCore: Fix for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.
Reviewed by Oliver Hunt.
Test: fast/canvas/canvas-with-illegal-args.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
LayoutTests: Test for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.
Reviewed by Oliver Hunt.
- fast/canvas/canvas-with-illegal-args-expected.txt: Added.
- fast/canvas/canvas-with-illegal-args.html: Added.
- fast/canvas/script-tests/canvas-with-illegal-args.js: Added.
- 3:07 PM Changeset in webkit [50909] by
-
- 4 edits in trunk/WebCore
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: profile timeline panel, fix obvious problems.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.refresh):
- inspector/front-end/utilities.js: (Element.prototype.hasStyleClass):
- 3:04 PM Changeset in webkit [50908] by
-
- 2 edits in trunk/WebCore
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: preload status bar button glyphs
in order to prevent them from flickering.
- inspector/front-end/inspector.js: (preloadImages):
- 2:41 PM Changeset in webkit [50907] by
-
- 36 edits6 adds in trunk
Replace worldIDs with world objects
Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
user scripts/stylesheets and isolated worlds
Reviewed by Sam Weinig.
WebCore:
Covered by existing tests.
- WebCore.base.exp: Update exported symbols to match what now exists
and is needed by WebKit.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): Updated for function rename.
- bindings/js/ScriptController.cpp: Removed code that dealt with
worldIDs.
(WebCore::ScriptController::createWorld): Added. Returns a new world
suitable for use on the main thread.
(WebCore::ScriptController::executeScriptInWorld): Renamed from
executeScriptInIsolatedWorld, since this works just fine with a
"normal" world.
- bindings/js/ScriptController.h: Added createWorld, removed functions
that took worldIDs, renamed executeScriptInIsolatedWorld to
executeScriptInWorld.
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
Updated for changes to UserScriptMap and ScriptController.
- page/Frame.h: Changed injectUserScriptsForWorld to take a
DOMWrapperWorld* instead of a worldID.
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
Changed these functions to take a DOMWrapperWorld* instead of a
worldID. Also updated for changes to UserScript and UserStyleSheet.
- page/UserScript.h:
- page/UserStyleSheet.h: Changed not to hold a worldID, since it was
never used.
- page/UserScriptTypes.h:
- page/UserStyleSheetTypes.h: Changed UserScriptMap and
UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
worldID as their key type.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebScriptWorld to the project.
WebKit/mac:
WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in -[WebFrame
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:],
but that will change soon.
- WebKit.exp: Export WebScriptWorld.
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:]):
Moved the bizarre world caching/creation logic that DRT depends on
here from the findWorld function in ScriptController.cpp. Updated to
use ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
(-[WebFrame _contextForWorld:]): Renamed from contextForWorldID:. Now
takes a WebScriptWorld.
- WebView/WebFramePrivate.h: Replaced contextForWorldID: with
_contextForWorld:.
- WebView/WebScriptWorld.h: Added.
- WebView/WebScriptWorld.mm: Added.
(-[WebScriptWorld initWithWorld:]): Store the passed-in world in our
_private member.
(-[WebScriptWorld init]): Create a new DOMWrapperWorld and pass it to
-initWithWorld:.
(-[WebScriptWorld dealloc]): Release _private.
(+[WebScriptWorld standardWorld]): Returns a shared instance that
represents WebCore's mainThreadNormalWorld().
(+[WebScriptWorld world]): Returns a new instance.
(core): Returns the DOMWrapperWorld for this WebScriptWorld.
- WebView/WebScriptWorldInternal.h: Added.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
- WebView/WebViewPrivate.h:
Changed these functions to take a WebScriptWorld instead of a worldID.
WebKit/win:
WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in
IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
that will change soon.
- ForEachCoClass.h: Added WebScriptWorld.
- Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
contextForWorld.
- Interfaces/IWebScriptWorld.idl: Added.
- Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
functions to take an IWebScriptWorld instead of a worldID.
- Interfaces/WebKit.idl: Added WebScriptWorld.
- WebFrame.cpp:
(WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
an IWebScriptWorld.
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
bizarre world caching/creation logic that DRT depends on here from the
findWorld function in ScriptController.cpp. Updated to use
ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
- WebFrame.h: Replaced contextForWorldID with contextForWorld.
- WebScriptWorld.cpp: Added.
(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
(WebScriptWorld::createInstance):
(WebScriptWorld::AddRef):
(WebScriptWorld::Release):
(WebScriptWorld::QueryInterface):
Standard COM class implementations.
(WebScriptWorld::standardWorld): Returns a shared instance that represents
WebCore's mainThreadNormalWorld().
- WebScriptWorld.h: Added.
(WebScriptWorld::world): Simple getter.
- WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
- WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
- WebKitClassFactory.cpp: Added WebScriptWorld.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- WebView.h:
Changed these functions to take an IWebScriptWorld instead of a worldID.
WebKitTools:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Changed these functions to create a new WebJSWorld each time they're
called and to pass that world to WebKit.
- 2:40 PM Changeset in webkit [50906] by
-
- 2 edits in trunk/WebKit/win
Small clean-up in WebView's user content functions
Preparation for <http://webkit.org/b/31414> Implement new SPI for
dealing with user scripts/stylesheets and isolated worlds
Reviewed by Dave Hyatt.
- WebView.cpp:
(toString):
(toKURL):
Added these helper functions to convert BSTRs to WebCore types.
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
Use the new helper functions.
- 2:24 PM Changeset in webkit [50905] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/31260>.
Web Inspector: Main Resources Other than HTML are mis-detected.
Reviewed by Tim Hatcher.
Even if the resource is a main resource, look at its CachedResource type,
because it might be an image, stylesheet, or JavaScript file, and we
want to show them all correctly.
- inspector/InspectorResource.cpp:
(WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
(WebCore::InspectorResource::type):
- inspector/InspectorResource.h:
- 2:13 PM Changeset in webkit [50904] by
-
- 3 edits in trunk/LayoutTests
Skip an accessibility test that covers functionality not available on Tiger or Leopard.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 2:07 PM Changeset in webkit [50903] by
-
- 2 edits in trunk/LayoutTests
Skipping one more new test, and a number of other tests, with bugs
filled.
- 1:33 PM Changeset in webkit [50902] by
-
- 1 delete in trunk/LayoutTests/platform/mac-snowleopard/accessibility
Remove a now-empty directory that I missed.
- 1:32 PM Changeset in webkit [50901] by
-
- 2 edits in trunk/LayoutTests
Fix results for fast/dom/Window/window-properties.html after r50893.
- fast/dom/Window/window-properties-expected.txt:
- 1:32 PM Changeset in webkit [50900] by
-
- 1 edit2 moves in trunk/LayoutTests
Move a misplaced accessibility test from platform/mac-snowleopard/accessibility to accessibility,
and the results from platform/mac-snowleopard/accessibility to platform/mac/accessibility.
Rubber-stamped by Anders Carlsson.
- accessibility/aria-list-and-listitem.html: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem.html.
- platform/mac/accessibility/aria-list-and-listitem-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt.
- 1:32 PM Changeset in webkit [50899] by
-
- 3 edits2 copies4 adds in trunk/LayoutTests
Land updated results for file-url-mimetypes-2.html and file-url-mimetypes-3.html.
Rubber-stamped by Brady Eidson.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
- platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
- 1:28 PM Changeset in webkit [50898] by
-
- 2 edits in trunk/LayoutTests
2009-11-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skipped new tests, a test that keeps failing despite
not failing locally, and a new DnD test.
- platform/gtk/Skipped:
- 1:17 PM Changeset in webkit [50897] by
-
- 6 edits in trunk/WebCore
Table-driven setup for V8 binding template callback functions. 100k in code savings.
https://bugs.webkit.org/show_bug.cgi?id=31420
Reviewed by Dimitri Glazkov.
- bindings/scripts/CodeGeneratorV8.pm: Change generated ConfigureXXXTemplate fn
to call configureTemplate().
- bindings/v8/V8Binding.cpp:
(WebCore::configureTemplate): New function; does all the standard configuration work.
(WebCore::createCallback): De-inlined wrapper for FunctionTemplate creation.
- bindings/v8/V8Binding.h:
- bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes): Just wrapped the very long fn parameter list.
(WebCore::batchConfigureCallbacks): New function, used by configureTemplate.
(WebCore::batchConfigureConstants): Just wrapped the very long fn parameter list.
- bindings/v8/V8Proxy.h:
- 1:07 PM Changeset in webkit [50896] by
-
- 4 edits in trunk/JavaScriptCore
Start unifying entry logic for function and eval code.
Reviewed by Gavin Barraclough.
Eval now uses a ret instruction to end execution, and sets up
a callframe more in line with what we do for function entry.
- 1:03 PM Changeset in webkit [50895] by
-
- 2 edits in trunk/WebCore
Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
- 1:02 PM Changeset in webkit [50894] by
-
- 5 edits in trunk/LayoutTests
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Skipped tests need path relative to LayoutTests folder, not just
test name.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 12:23 PM Changeset in webkit [50893] by
-
- 13 edits5 adds in trunk
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7388969> Add DOM API for fullscreen video
DOM API for fullscreen <video>.
Tests: media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html
- dom/EventNames.h:
Add webkitbeginfullscreen and webkitendfullscreen.
- html/HTMLAttributeNames.in:
Add onwebkitbeginfullscreen and onwebkitendfullscreen.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute):
Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
(WebCore::HTMLMediaElement::enterFullscreen):
Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
actually do enter fullscreen.
(WebCore::HTMLMediaElement::exitFullscreen):
Schedule webkitendfullscreenEvent event.
(WebCore::HTMLMediaElement::webkitEnterFullScreen):
(WebCore::HTMLMediaElement::webkitExitFullScreen):
(WebCore::HTMLMediaElement::webkitSupportsFullscreen):
(WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
New, access to fullscreen properties and methods.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
Declare methods needed for fullscreen API.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen):
Return false if a movie does not have video.
- page/DOMWindow.h:
Add webkitbeginfullscreen and webkitendfullscreen.
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7388969> Add DOM API for fullscreen video
Tests for fullscreen <video> DOM API.
- media/media-fullscreen-inline-expected.txt: Added.
- media/media-fullscreen-inline.html: Added.
- media/media-fullscreen-not-in-document-expected.txt: Added.
- media/media-fullscreen-not-in-document.html: Added.
- media/media-fullscreen.js: Added.
- platform/gtk/Skipped:
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
Skipped on platforms that don't support fullscreen yet.
- 12:16 PM Changeset in webkit [50892] by
-
- 9 edits in trunk/LayoutTests
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=31426
Some WebSocket tests don't properly listen to close event
- websocket/tests/script-tests/handshake-error.js:
- websocket/tests/script-tests/simple.js: Made the tests clear second-chance timer on finish, avoiding confusing output when running them in Safari.
- websocket/tests/script-tests/frame-length-longer-than-buffer.js:
- websocket/tests/script-tests/frame-length-skip.js:
- websocket/tests/frame-length-longer-than-buffer-expected.txt:
- websocket/tests/frame-length-skip-expected.txt: These tests now finish properly.
- websocket/tests/handshake-error-expected.txt:
- websocket/tests/simple-expected.txt: I'm getting an extra empty line for these tests, which is surprising. But since I didn't change anything, I assume that it should be there.
- 12:03 PM Changeset in webkit [50891] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-12 Adam Barth <abarth>
Reviewed by Dimitri Glazkov.
[Chromium] reload-subframe-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=31398
More closely match FrameLoaderClient.mm. Turns out we don't want to
use MIMETypeRegistry::getMIMETypeForPath because we can't distinguish
between application/octet-stream and lack of knowledge of the MIME
type.
Covered by reload-subframe-object.html.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
- 11:56 AM Changeset in webkit [50890] by
-
- 3 edits2 adds in trunk
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test that we're using the calling security context in a simple case.
- http/tests/security/calling-versus-current-expected.txt: Added.
- http/tests/security/calling-versus-current.html: Added.
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test: http/tests/security/calling-versus-current.html
We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):
- 11:24 AM Changeset in webkit [50889] by
-
- 3 edits in trunk/WebKit/chromium
2009-11-12 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Add new accessibility enum values to Chromium enums from
http://trac.webkit.org/changeset/50865 and
http://trac.webkit.org/changeset/50883.
- public/WebAccessibilityRole.h: (WebKit::):
- src/AssertMatchingEnums.cpp:
- 11:21 AM Changeset in webkit [50888] by
-
- 5 edits in trunk
2009-11-12 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Fixes an issue where the returned drop effect is incorrect when
effectAllowed == "uninitialized".
According to section 7.9.2 of the HTML 5 spec.
<http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
when effectAllowed = "uninitialized" the resulting dropEffect should be the
user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
other case.
No test cases are included because we have an existing test case from
bug #24731.
- dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
2009-11-12 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Rebased results for existing test case fast/events/drag-and-drop.html
from bug #24731.
Now, we can run the part of the test when effectAllowed == "uninitialized".
- fast/events/drag-and-drop-expected.txt: Rebased results.
- fast/events/drag-and-drop.html: Removed notice about this bug (#30291).
- 10:46 AM Changeset in webkit [50887] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-12 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Send |keypress()| events for keys with cmd down, like safari.
Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
keypress() event.
- src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent):
- 10:35 AM Changeset in webkit [50886] by
-
- 2 edits in trunk/WebCore
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not highlight node on refresh.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
- 10:23 AM Changeset in webkit [50885] by
-
- 2 edits in trunk/WebCore
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Minor timeline fixes.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype._updateDetails): (WebInspector.TimelineRecordTreeElement.prototype.refresh):
- 9:44 AM Changeset in webkit [50884] by
-
- 2 edits in trunk/WebCore
SnowLeopard build fix.
Renamed initWithClient to initWithAuthenticationClient.
- platform/network/mac/AuthenticationMac.mm: (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]): (WebCore::AuthenticationChallenge::setAuthenticationClient):
- 9:37 AM Changeset in webkit [50883] by
-
- 10 edits2 adds in trunk
2009-11-12 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
- platform/mac/accessibility/aria-alerts-expected.txt: Added.
- platform/mac/accessibility/aria-alerts.html: Added.
2009-11-12 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
Test: platform/mac/accessibility/aria-alerts.html
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/mac/AccessibilityObjectWrapper.mm:
2009-11-12 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
- English.lproj/Localizable.strings:
- StringsNotToBeLocalized.txt:
2009-11-12 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):
- 9:18 AM Changeset in webkit [50882] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31386
Make Mac AuthenticationChallenge usable from cross-platform code
No change in behavior, so no tests.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge is identical.
- platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to be already set.
- platform/network/mac/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the best of my understanding. (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent confusion with "mac" and "web" challenges in ResourceHandleInternal.
- platform/network/mac/AuthenticationMac.mm: (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient, making it possible to use the latter with NSURLAuthenticationChallenge. (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge -> m_nsChallenge renaming. (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and set it as sender (or unset, if client is null).
- platform/network/mac/ResourceHandleMac.mm: (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as authentication challenge sender. (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an authentication sheet. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge using the new setAuthenticationClient() method. (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion. Since didCancelAuthenticationChallenge is called by connection, the passed challenge is the original Mac one, not the one we created for use with authentication sheet. I don't know when a connection would cancel authentication in practice, so I haven't tested this.
- 9:08 AM Changeset in webkit [50881] by
-
- 2 edits in trunk/WebCore
2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: breakpoint sidebar entries should allow click over entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411
No new tests; no new functionality, small usability change.
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
- 9:00 AM Changeset in webkit [50880] by
-
- 2 edits1 add in trunk/WebCore
2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: breakpoints in named evals are not restored after a reload
https://bugs.webkit.org/show_bug.cgi?id=31375
Manual test added
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
- manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
- 7:14 AM BuildingGtk edited by
- (diff)
- 6:37 AM Changeset in webkit [50879] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358
Reviewed by Jan Alonzo.
QWebPage's constructor docs are mentioning "QWebView":
"Constructs an empty QWebView with parent".
- Api/qwebpage.cpp:
- 6:13 AM Changeset in webkit [50878] by
-
- 416 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-12
[Qt] Update outdated metrics in layout tests after change to Qt 4.6 on the buildbot.
- platform/qt/css1/basic/class_as_selector-expected.txt:
- platform/qt/css1/basic/comments-expected.txt:
- platform/qt/css1/basic/containment-expected.txt:
- platform/qt/css1/basic/contextual_selectors-expected.txt:
- platform/qt/css1/basic/grouping-expected.txt:
- platform/qt/css1/basic/id_as_selector-expected.txt:
- platform/qt/css1/basic/inheritance-expected.txt:
- platform/qt/css1/box_properties/acid_test-expected.txt:
- platform/qt/css1/box_properties/border-expected.txt:
- platform/qt/css1/box_properties/border_bottom-expected.txt:
- platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/border_bottom_width-expected.txt:
- platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_color-expected.txt:
- platform/qt/css1/box_properties/border_color_inline-expected.txt:
- platform/qt/css1/box_properties/border_inline-expected.txt:
- platform/qt/css1/box_properties/border_left-expected.txt:
- platform/qt/css1/box_properties/border_left_inline-expected.txt:
- platform/qt/css1/box_properties/border_left_width-expected.txt:
- platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_right-expected.txt:
- platform/qt/css1/box_properties/border_right_inline-expected.txt:
- platform/qt/css1/box_properties/border_right_width-expected.txt:
- platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_style-expected.txt:
- platform/qt/css1/box_properties/border_style_inline-expected.txt:
- platform/qt/css1/box_properties/border_top-expected.txt:
- platform/qt/css1/box_properties/border_top_inline-expected.txt:
- platform/qt/css1/box_properties/border_top_width-expected.txt:
- platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
- platform/qt/css1/box_properties/border_width-expected.txt:
- platform/qt/css1/box_properties/border_width_inline-expected.txt:
- platform/qt/css1/box_properties/clear-expected.txt:
- platform/qt/css1/box_properties/clear_float-expected.txt:
- platform/qt/css1/box_properties/float-expected.txt:
- platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
- platform/qt/css1/box_properties/float_margin-expected.txt:
- platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
- platform/qt/css1/box_properties/height-expected.txt:
- platform/qt/css1/box_properties/margin-expected.txt:
- platform/qt/css1/box_properties/margin_bottom-expected.txt:
- platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/margin_inline-expected.txt:
- platform/qt/css1/box_properties/margin_left-expected.txt:
- platform/qt/css1/box_properties/margin_left_inline-expected.txt:
- platform/qt/css1/box_properties/margin_right-expected.txt:
- platform/qt/css1/box_properties/margin_right_inline-expected.txt:
- platform/qt/css1/box_properties/margin_top-expected.txt:
- platform/qt/css1/box_properties/margin_top_inline-expected.txt:
- platform/qt/css1/box_properties/padding-expected.txt:
- platform/qt/css1/box_properties/padding_bottom-expected.txt:
- platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/qt/css1/box_properties/padding_inline-expected.txt:
- platform/qt/css1/box_properties/padding_left-expected.txt:
- platform/qt/css1/box_properties/padding_left_inline-expected.txt:
- platform/qt/css1/box_properties/padding_right-expected.txt:
- platform/qt/css1/box_properties/padding_right_inline-expected.txt:
- platform/qt/css1/box_properties/padding_top-expected.txt:
- platform/qt/css1/box_properties/padding_top_inline-expected.txt:
- platform/qt/css1/box_properties/width-expected.txt:
- platform/qt/css1/cascade/cascade_order-expected.txt:
- platform/qt/css1/cascade/important-expected.txt:
- platform/qt/css1/classification/display-expected.txt:
- platform/qt/css1/classification/list_style-expected.txt:
- platform/qt/css1/classification/list_style_image-expected.txt:
- platform/qt/css1/classification/list_style_position-expected.txt:
- platform/qt/css1/classification/list_style_type-expected.txt:
- platform/qt/css1/classification/white_space-expected.txt:
- platform/qt/css1/color_and_background/background-expected.txt:
- platform/qt/css1/color_and_background/background_attachment-expected.txt:
- platform/qt/css1/color_and_background/background_color-expected.txt:
- platform/qt/css1/color_and_background/background_image-expected.txt:
- platform/qt/css1/color_and_background/background_position-expected.txt:
- platform/qt/css1/color_and_background/background_repeat-expected.txt:
- platform/qt/css1/color_and_background/color-expected.txt:
- platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/css1/font_properties/font_family-expected.txt:
- platform/qt/css1/font_properties/font_size-expected.txt:
- platform/qt/css1/font_properties/font_style-expected.txt:
- platform/qt/css1/font_properties/font_variant-expected.txt:
- platform/qt/css1/font_properties/font_weight-expected.txt:
- platform/qt/css1/formatting_model/canvas-expected.txt:
- platform/qt/css1/formatting_model/floating_elements-expected.txt:
- platform/qt/css1/formatting_model/height_of_lines-expected.txt:
- platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/qt/css1/formatting_model/inline_elements-expected.txt:
- platform/qt/css1/formatting_model/replaced_elements-expected.txt:
- platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
- platform/qt/css1/pseudo/anchor-expected.txt:
- platform/qt/css1/pseudo/firstletter-expected.txt:
- platform/qt/css1/pseudo/firstline-expected.txt:
- platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/qt/css1/text_properties/letter_spacing-expected.txt:
- platform/qt/css1/text_properties/line_height-expected.txt:
- platform/qt/css1/text_properties/text_align-expected.txt:
- platform/qt/css1/text_properties/text_decoration-expected.txt:
- platform/qt/css1/text_properties/text_indent-expected.txt:
- platform/qt/css1/text_properties/text_transform-expected.txt:
- platform/qt/css1/text_properties/vertical_align-expected.txt:
- platform/qt/css1/text_properties/word_spacing-expected.txt:
- platform/qt/css1/units/color_units-expected.txt:
- platform/qt/css1/units/length_units-expected.txt:
- platform/qt/css1/units/percentage_units-expected.txt:
- platform/qt/css1/units/urls-expected.txt:
- platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
- platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
- platform/qt/css2.1/t040103-case-00-b-expected.txt:
- platform/qt/css2.1/t040103-case-01-c-expected.txt:
- platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
- platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
- platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
- platform/qt/css2.1/t040103-ident-00-c-expected.txt:
- platform/qt/css2.1/t040103-ident-01-c-expected.txt:
- platform/qt/css2.1/t040103-ident-02-c-expected.txt:
- platform/qt/css2.1/t040103-ident-03-c-expected.txt:
- platform/qt/css2.1/t040103-ident-04-c-expected.txt:
- platform/qt/css2.1/t040103-ident-05-c-expected.txt:
- platform/qt/css2.1/t040103-ident-06-c-expected.txt:
- platform/qt/css2.1/t040103-ident-07-c-expected.txt:
- platform/qt/css2.1/t040103-ident-08-c-expected.txt:
- platform/qt/css2.1/t040103-ident-09-c-expected.txt:
- platform/qt/css2.1/t040103-ident-10-c-expected.txt:
- platform/qt/css2.1/t040103-ident-11-c-expected.txt:
- platform/qt/css2.1/t040103-ident-12-c-expected.txt:
- platform/qt/css2.1/t040103-ident-13-c-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
- platform/qt/css2.1/t040105-import-00-b-expected.txt:
- platform/qt/css2.1/t040105-import-01-b-expected.txt:
- platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
- platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
- platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
- platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
- platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
- platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
- platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
- platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
- platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
- platform/qt/css2.1/t1202-counter-00-b-expected.txt:
- platform/qt/css2.1/t1202-counter-01-b-expected.txt:
- platform/qt/css2.1/t1202-counter-02-b-expected.txt:
- platform/qt/css2.1/t1202-counter-03-b-expected.txt:
- platform/qt/css2.1/t1202-counter-04-b-expected.txt:
- platform/qt/css2.1/t1202-counter-05-b-expected.txt:
- platform/qt/css2.1/t1202-counter-06-b-expected.txt:
- platform/qt/css2.1/t1202-counter-07-b-expected.txt:
- platform/qt/css2.1/t1202-counter-08-b-expected.txt:
- platform/qt/css2.1/t1202-counter-09-b-expected.txt:
- platform/qt/css2.1/t1202-counter-11-b-expected.txt:
- platform/qt/css2.1/t1202-counter-12-b-expected.txt:
- platform/qt/css2.1/t1202-counter-13-b-expected.txt:
- platform/qt/css2.1/t1202-counter-14-b-expected.txt:
- platform/qt/css2.1/t1202-counter-15-b-expected.txt:
- platform/qt/css2.1/t1202-counter-16-f-expected.txt:
- platform/qt/css2.1/t1202-counters-00-b-expected.txt:
- platform/qt/css2.1/t1202-counters-01-b-expected.txt:
- platform/qt/css2.1/t1202-counters-02-b-expected.txt:
- platform/qt/css2.1/t1202-counters-03-b-expected.txt:
- platform/qt/css2.1/t1202-counters-05-b-expected.txt:
- platform/qt/css2.1/t1202-counters-06-b-expected.txt:
- platform/qt/css2.1/t1202-counters-07-b-expected.txt:
- platform/qt/css2.1/t1202-counters-08-b-expected.txt:
- platform/qt/css2.1/t1202-counters-09-b-expected.txt:
- platform/qt/css2.1/t1202-counters-11-b-expected.txt:
- platform/qt/css2.1/t1202-counters-12-b-expected.txt:
- platform/qt/css2.1/t1202-counters-13-b-expected.txt:
- platform/qt/css2.1/t1202-counters-14-b-expected.txt:
- platform/qt/css2.1/t1202-counters-15-b-expected.txt:
- platform/qt/css2.1/t1202-counters-16-c-expected.txt:
- platform/qt/css2.1/t1202-counters-17-d-expected.txt:
- platform/qt/css2.1/t1202-counters-18-f-expected.txt:
- platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
- platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
- platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
- platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
- platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
- platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
- platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
- platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
- platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
- platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
- platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
- platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
- platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
- platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
- platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
- platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
- platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/qt/fast/backgrounds/001-expected.txt:
- platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt:
- platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
- platform/qt/fast/backgrounds/background-origin-root-element-expected.txt:
- platform/qt/fast/backgrounds/background-position-1-expected.txt:
- platform/qt/fast/backgrounds/background-position-rounding-expected.txt:
- platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
- platform/qt/fast/backgrounds/mask-composite-expected.txt:
- platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
- platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
- platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
- platform/qt/fast/backgrounds/size/zero-expected.txt:
- platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-1-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-2-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-3-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-4-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-5-expected.txt:
- platform/qt/fast/backgrounds/svg-as-background-6-expected.txt:
- platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
- platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/qt/fast/borders/border-radius-constraints-expected.txt:
- platform/qt/fast/borders/border-radius-split-inline-expected.txt:
- platform/qt/fast/box-shadow/basic-shadows-expected.txt:
- platform/qt/fast/box-shadow/inset-expected.txt:
- platform/qt/fast/box-shadow/transform-fringing-expected.txt:
- platform/qt/fast/canvas/canvas-before-css-expected.txt:
- platform/qt/fast/canvas/canvas-composite-expected.txt:
- platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt:
- platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
- platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
- platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
- platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
- platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
- platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
- platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
- platform/qt/fast/canvas/canvas-zoom-expected.txt:
- platform/qt/fast/canvas/drawImage-expected.txt:
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt:
- platform/qt/fast/canvas/image-pattern-rotate-expected.txt:
- platform/qt/fast/canvas/shadow-offset-1-expected.txt:
- platform/qt/fast/canvas/shadow-offset-2-expected.txt:
- platform/qt/fast/canvas/shadow-offset-3-expected.txt:
- platform/qt/fast/canvas/shadow-offset-4-expected.txt:
- platform/qt/fast/canvas/shadow-offset-5-expected.txt:
- platform/qt/fast/canvas/shadow-offset-6-expected.txt:
- platform/qt/fast/canvas/shadow-offset-7-expected.txt:
- platform/qt/fast/css/attribute-selector-dynamic-expected.txt:
- platform/qt/fast/css/font-smoothing-expected.txt:
- platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
- platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
- platform/qt/fast/css/nth-child-dynamic-expected.txt:
- platform/qt/fast/css/pseudo-cache-stale-expected.txt:
- platform/qt/fast/css/rem-dynamic-scaling-expected.txt:
- platform/qt/fast/css/rem-units-on-root-expected.txt:
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/qt/fast/css/text-rendering-expected.txt:
- platform/qt/fast/doctypes/001-expected.txt:
- platform/qt/fast/doctypes/002-expected.txt:
- platform/qt/fast/doctypes/004-expected.txt:
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/qt/fast/dynamic/anchor-lock-expected.txt:
- platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
- platform/qt/fast/dynamic/window-scrollbars-test-expected.txt:
- platform/qt/fast/forms/basic-buttons-expected.txt:
- platform/qt/fast/forms/basic-inputs-expected.txt:
- platform/qt/fast/forms/button-style-color-expected.txt:
- platform/qt/fast/forms/isindex-placeholder-expected.txt:
- platform/qt/fast/forms/menulist-style-color-expected.txt:
- platform/qt/fast/forms/search-vertical-alignment-expected.txt:
- platform/qt/fast/forms/text-style-color-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
- platform/qt/fast/frames/frame-navigation-expected.txt:
- platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
- platform/qt/fast/frames/frameset-style-recalc-expected.txt:
- platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
- platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
- platform/qt/fast/gradients/crash-on-zero-radius-expected.txt:
- platform/qt/fast/history/clicked-link-is-visited-expected.txt:
- platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
- platform/qt/fast/images/image-in-map-expected.txt:
- platform/qt/fast/images/svg-as-background-expected.txt:
- platform/qt/fast/images/svg-width-100p-as-background-expected.txt:
- platform/qt/fast/lists/ol-start-parsing-expected.txt:
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
- platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
- platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
- platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
- platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
- platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
- platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
- platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
- platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
- platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
- platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
- platform/qt/fast/text/international/hindi-whitespace-expected.txt:
- platform/qt/fast/text/international/khmer-selection-expected.txt:
- platform/qt/fast/text/shadow-translucent-fill-expected.txt:
- platform/qt/fast/text/text-letter-spacing-expected.txt:
- platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/qt/fast/xsl/document-function-expected.txt:
- platform/qt/plugins/netscape-dom-access-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/qt/tables/mozilla/other/slashlogo-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 6:05 AM Changeset in webkit [50877] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-12 Richard Moe Gustavsen <richard.gustavsen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable pthread_setname_np.
This allows Qt builds on Mac from 10.6 to run on earlier version
where this symbol is not present.
https://bugs.webkit.org/show_bug.cgi?id=31403
- wtf/Platform.h:
- 5:52 AM Changeset in webkit [50876] by
-
- 7 edits in trunk
2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042
This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.
- page/PrintContext.cpp: (WebCore::PrintContext::begin):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042
This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- 5:28 AM Changeset in webkit [50875] by
-
- 3 edits in trunk/WebCore
2009-11-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Resource errors/warnings not shown in the Resource tree.
Error/Warning bubbles are not displayed next to the resource in the
Resources panel if those occur before the resource is attached to the tree.
https://bugs.webkit.org/show_bug.cgi?id=31404
Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.removeItem):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
- 4:44 AM Changeset in webkit [50874] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-12 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix linking on Linux 32-bit.
It was missing the ".text" directive at the top of the file,
indicating that code would follow. Without it, the assembler created
"NOTYPE" symbols, which would result in linker errors.
https://bugs.webkit.org/show_bug.cgi?id=30863
- jit/JITStubs.cpp:
- 2:39 AM Changeset in webkit [50873] by
-
- 2 edits in trunk/WebCore
2009-11-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html
Follow-up of r50726, don't block the UI thread when calling
gst_element_get_state(). Also fixed a compilation warning and some
static casts.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::playbackPosition): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setRate):
- 2:32 AM Changeset in webkit [50872] by
-
- 2 edits in trunk/WebCore
2009-11-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html
don't pause pipeline if already paused, same for play()
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause):
- 1:03 AM Changeset in webkit [50871] by
-
- 3 edits in trunk/WebCore
2009-11-12 Kinuko Yasuda <kinuko@google.com>
Reviewed by David Levin.
Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
Chromium too.
https://bugs.webkit.org/show_bug.cgi?id=31292
No new tests. (Corresponding test for Gtk+ is
platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
- page/EventHandler.cpp:
- page/chromium/EventHandlerChromium.cpp:
- 12:37 AM Changeset in webkit [50870] by
-
- 4 edits in trunk/LayoutTests
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed test fix by skipping a new test introduced in
https://bugs.webkit.org/show_bug.cgi?id=22249
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:15 AM Changeset in webkit [50869] by
-
- 6 edits4 adds in trunk
2009-11-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Prevent text inside a multi-column block from being split into columns.
If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.
CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249
- fast/multicol/single-line.html: Added.
- fast/multicol/single-line-expected.checksum: Added.
- fast/multicol/single-line-expected.png: Added.
- fast/multicol/single-line-expected.txt: Added.
2009-11-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Prevent text inside a multi-column block from being split into columns.
If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.
CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249
Test: fast/multicol/single-line.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns):
- rendering/RenderBlock.h:
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
- rendering/RenderView.h: (WebCore::RenderView::setTruncatedAt): (WebCore::RenderView::setMinimumColumnHeight): (WebCore::RenderView::minimumColumnHeight):
