⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 28, 2010:

11:23 PM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
11:19 PM Changeset in webkit [58478] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-28 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Added to VCSUtils's parseDiffHeader() support for binary patches.

​https://bugs.webkit.org/show_bug.cgi?id=38094

The parseDiffHeader() function is part of new patch-parsing code
for svn-apply and svn-unapply that will go live in a subsequent
revision.

  • Scripts/VCSUtils.pm:
    • Added logic to parseDiffHeader() to recognize the ending of the header portion of a binary diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Added unit test cases for SVN and Git binary diffs.
11:15 PM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
11:10 PM Changeset in webkit [58477] by eric@webkit.org
  • 8 edits in trunk

2010-04-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Allow editing script resources when resource tracking is enabled.

​https://bugs.webkit.org/show_bug.cgi?id=38269

  • inspector/front-end/ScriptView.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.canEditScripts): (WebInspector.ScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get textModel):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._addBreakpoint): (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete): (WebInspector.SourceView.prototype._sourceIDForLine):

2010-04-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Allow editing script resources when resource tracking is enabled.

​http://bugs.webkit.org/show_bug.cgi?id=38269

  • src/js/DebuggerAgent.js:
  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint): (.devtools.InspectorBackendImpl.prototype.editScriptSource):
9:45 PM Changeset in webkit [58476] by tonikitoo@webkit.org
  • 5 edits
    5 adds in trunk

2010-04-25 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Darin Adler.

Clicking a scrollbar blurs the currently focused element
​https://bugs.webkit.org/show_bug.cgi?id=16809

WebKit ports that do not use native (platform) widgets for rendering the scrollbars
are currently mismatching a common behaviour of other browser vendors (including
Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
instance, can observe the opposite behaviour.

Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
If that is the case, it bails out and do not change focus behavior at all.

It is important to note that the given way this is implemented by this patch, non-frame
scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
in the same way as it works currently.

Tests: scrollbars/scrollbar-click-does-not-blur-content.html

scrollbars/scrollbar-iframe-click-does-not-blur-content.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEve
9:34 PM Changeset in webkit [58475] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Do an unordered compare so that we don't treat NaN incorrectly.

RS=Gavin Barraclough

  • jit/ThunkGenerators.cpp:

(JSC::powThunkGenerator):

9:23 PM Changeset in webkit [58474] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix test failures seen on the Leopard build bot after r58467

Rubber-stamped by Maciej Stachowiak.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
calling widthForGlyph(), as the latter uses the former.

9:20 PM Changeset in webkit [58473] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Document that subprocess.poll/wait are not threadsafe
​https://bugs.webkit.org/show_bug.cgi?id=38289

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
9:16 PM Changeset in webkit [58472] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

9:13 PM Changeset in webkit [58471] by mrowe@apple.com
  • 1 copy in tags/Safari-533.7

New tag.

9:13 PM Changeset in webkit [58470] by Martin Robinson
  • 9 edits in trunk

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.

  • platform/gtk/Skipped: Uncomment tests that are now passing.

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method. (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data. (WebCore::dataObjectTypeFromHTMLClipboardType): Added. (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard. (WebCore::ClipboardGtk::clearAllData): Ditto. (WebCore::joinURIList): Added. (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible. (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard. (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types. (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files. (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard. (WebCore::ClipboardGtk::writeRange): Ditto. (WebCore::ClipboardGtk::writePlainText): Ditto. (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
  • platform/gtk/DataObjectGtk.cpp: (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text. (WebCore::DataObjectGtk::markup): Actually return the range if it's set. (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text. (WebCore::DataObjectGtk::clearText): Added. (WebCore::DataObjectGtk::clearMarkup): Added.
  • platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::clearURIList): Added. (WebCore::DataObjectGtk::clearImage): Added.
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets. (WebCore::urisToKURLVector): Added. (WebCore::PasteboardHelper::getClipboardContents): Added. (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs. (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
  • platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
8:57 PM Changeset in webkit [58469] by oliver@apple.com
  • 19 edits in trunk/JavaScriptCore

2010-04-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Add fast paths for Math.pow and Math.sqrt
​https://bugs.webkit.org/show_bug.cgi?id=38294

Add specialized thunks for Math.pow and Math.sqrt.
This requires adding a sqrtDouble function to the MacroAssembler
and sqrtsd to the x86 assembler.

Math.pow is slightly more complicated, in that we have
to implement exponentiation ourselves rather than relying
on hardware support. The inline exponentiation is restricted
to positive integer exponents on a numeric base. Exponentiation
is finally performed through the "Exponentiation by Squaring"
algorithm.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::sqrtDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadDouble): (JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::sqrtDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadDouble): (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::movsd_mr): (JSC::X86Assembler::sqrtsd_rr): (JSC::X86Assembler::X86InstructionFormatter::twoByteOp): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • create_hash_table:
  • jit/JIT.h:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.h: (JSC::JITThunks::ctiNativeCallThunk):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble): (JSC::JSInterfaceJIT::emitJumpIfImmediateNumber): (JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber): (JSC::JSInterfaceJIT::emitLoadInt32):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::loadDoubleArgument): (JSC::SpecializedThunkJIT::loadInt32Argument): (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • jit/ThunkGenerators.h:
  • runtime/Executable.h: (JSC::NativeExecutable::NativeExecutable):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
8:46 PM Changeset in webkit [58468] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.

No new tests, because pasteboard DataTransfer tests will be enabled
with the completion of the GTK+ DataTransfer object.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.
8:11 PM Changeset in webkit [58467] by mitz@apple.com
  • 3 edits in trunk/WebCore

More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
​https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Adele Peterson.

Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
this space by not storing the zero width and empty bounds in the metrics maps.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
(WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
without consulting the bounds map.
(WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
consulting the width map.

8:05 PM Changeset in webkit [58466] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load

Reviewed by Adele Peterson.

The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
that was added to address <​https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
access that occurs on the Safari welcome page.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):

8:00 PM Changeset in webkit [58465] by mthole@apple.com
  • 3 edits in trunk/WebKit2

Build fix, not reviewed.

Fix WebKit2 build by stubbing out WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace().

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
7:30 PM Changeset in webkit [58464] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

Removed the dividing line (i.e. "====...") logic from the code
called by svn-apply and svn-unapply.

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38093

The dividing line logic is unnecessary. Removing it simplifies the
code and makes some subsequent changes easier.

  • Scripts/VCSUtils.pm:
    • Removed the logic in gitdiff2svndiff() to convert the git "index" line to an SVN dividing line.
    • Adjusted the logic similarly in parseDiffHeader().
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
    • Corrected an error in the unit tests whereby all elements of an array were referencing the same element rather than distinct elements -- causing unit test failures to be masked.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
    • Made the same unit test correction as above for parseDiff.pl.
7:22 PM Changeset in webkit [58463] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-04-28 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Qt build fix.

[Qt] Guard the body of the function instead of the function for
exported functions.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled):
6:50 PM Changeset in webkit [58462] by estade@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py: adding myself as a committer
5:54 PM Changeset in webkit [58461] by mthole@apple.com
  • 5 edits
    1 add in trunk

JavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
exports file for it has been added.

Reviewed by Mark Rowe.

  • wtf/Platform.h:

WebCore: Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.

Reviewed by Mark Rowe.

  • DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
  • WebCore.ProtectionSpaceAuthCallback.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
5:51 PM Changeset in webkit [58460] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

Changes to WebCore.xcodeproj to build in audio code

5:51 PM Changeset in webkit [58459] by crogers@google.com
  • 5 edits in branches/audio/WebCore/audio

More compile fixes

5:51 PM Changeset in webkit [58458] by crogers@google.com
  • 38 edits in branches/audio/WebCore/audio

Lots of compile error fixes mostly revolving around 64bit double to 32bit float conversions

5:51 PM Changeset in webkit [58457] by crogers@google.com
  • 1 edit in branches/audio/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Make Complex.h be in PrivateHeaders

5:51 PM Changeset in webkit [58456] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

Although deprecated, need BiquadFilter class to get build going

5:51 PM Changeset in webkit [58455] by crogers@google.com
  • 1 edit
    1 add in branches/audio

Add Complex.h to ForwardingHeaders and JavaScriptCore project

5:50 PM Changeset in webkit [58454] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/DynamicsCompressor.h

fix compile warning with virtual methods

5:50 PM Changeset in webkit [58453] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioFloatArray.h

For now implement zero() method directly in AudioFloatArray

5:50 PM Changeset in webkit [58452] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/DynamicsCompressor.cpp

include config.h

5:50 PM Changeset in webkit [58451] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Accelerate.h

include config.h instead of wtf/Platform.h

5:50 PM Changeset in webkit [58450] by crogers@google.com
  • 1 edit
    1 add in branches/audio

Add wtf/Vector3.h to ForwardingHeaders and JavaScriptCore project

5:50 PM Changeset in webkit [58449] by crogers@google.com
  • 3 adds in branches/audio/WebCore/audio

temporarily add old AudioEffect class (although deprecated still needed in places)

5:50 PM Changeset in webkit [58448] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

Add audio directory to search path

5:38 PM Changeset in webkit [58447] by evan@chromium.org
  • 5 edits in trunk

2010-04-28 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] revert getFontDataForCharacters change in r58341
​https://bugs.webkit.org/show_bug.cgi?id=38288

  • platform/chromium/test_expectations.txt: add the test to the now-failing list.

2010-04-28 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] revert getFontDataForCharacters change in r58341
​https://bugs.webkit.org/show_bug.cgi?id=38288

It caused a performance regression.

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
5:34 PM Changeset in webkit [58446] by eric@webkit.org
  • 4 edits
    3 deletes in trunk

2010-04-28 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58441.
​http://trac.webkit.org/changeset/58441
​https://bugs.webkit.org/show_bug.cgi?id=37618

Broke 3 test on Qt.

  • editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Removed.
  • editing/pasteboard/drag-drop-iframe-refresh-crash.html: Removed.
  • editing/resources/drag-drop.html: Removed.

2010-04-28 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58441.
​http://trac.webkit.org/changeset/58441
​https://bugs.webkit.org/show_bug.cgi?id=37618

Broke 3 test on Qt.

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag):
  • page/DragController.h: (WebCore::DragController::setDragInitiator): (WebCore::DragController::dragInitiator): (WebCore::DragController::documentUnderMouse):
5:22 PM Changeset in webkit [58445] by Darin Adler
  • 8 edits in trunk/WebCore

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Remove some obsolete scrolling code
​https://bugs.webkit.org/show_bug.cgi?id=38293

  • page/Chrome.cpp: (WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
  • page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.
  • page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
  • page/FrameView.h: Removed scrollRectIntoViewRecursively and made setScrollPosition non-virtual, since there is no class derived from this class, and ScrollView's setScrollPosition is non-virtual.
  • platform/HostWindow.h: Removed scrollRectIntoView.
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment since I was able to do most of the tasks listed here.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for ScrollView* argument to Chrome::scrollRectIntoView.
5:14 PM Changeset in webkit [58444] by mthole@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix, not reviewed.

  • wtf/Platform.h:

Disable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK until an exports file is created.

4:58 PM Changeset in webkit [58443] by weinig@apple.com
  • 7 edits in trunk

.: Add WebKit2 to the lists of modules to build.

Reviewed by Mark Rowe.

  • Makefile:

WebKit2: Only build on SnowLeopard and later when using the Makefile.

Reviewed by Mark Rowe.

  • Makefile:

WebKitTools: Add MiniBrowser to the lists of modules to build and only build it on
SnowLeopard and later.

Reviewed by Mark Rowe.

  • Makefile:
  • MiniBrowser/Makefile:
4:16 PM Changeset in webkit [58442] by mthole@apple.com
  • 21 edits in trunk

Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
​https://bugs.webkit.org/show_bug.cgi?id=38271

Reviewed by David Kilzer.

JavaScriptCore:

  • wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.

WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.

  • platform/network/ProtectionSpace.h:

(WebCore::):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested. Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Added. If the resource load delegate implements the callback, use its answer. If it does
not, then only send authentication challenges for pre-10.6 protection spaces, which matches
CFNetwork's default behavior.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.

  • WebView/WebResourceLoadDelegatePrivate.h:

Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:

  • WebView/WebView.mm:

(-[WebView _cacheResourceLoadDelegateImplementations]):

3:48 PM Changeset in webkit [58441] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-04-28 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
​https://bugs.webkit.org/show_bug.cgi?id=37618

  • editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
  • editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
  • editing/resources/drag-drop.html: Added.

2010-04-28 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
​https://bugs.webkit.org/show_bug.cgi?id=37618

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag):
  • page/DragController.h: (WebCore::DragController::draggingImageURL): (WebCore::DragController::documentUnderMouse):
3:33 PM Changeset in webkit [58440] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fixing a build problem introduced by the previous patch.

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):

3:28 PM Changeset in webkit [58439] by agl@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-04-28 Adam Langley <​agl@chromium.org>

Unreviewed, expectations update.

These results are no longer specific to chromium-win. I believe that
they should have been deleted in r58182, but I didn't notice the
deletions, only the modified files.

  • platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
3:17 PM Changeset in webkit [58438] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.

Reviewed by Mark Rowe.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/make-launchable.sh: Added.
3:17 PM Changeset in webkit [58437] by dumi@chromium.org
  • 7 edits
    5 adds in trunk/WebCore

Adding some required classes for the sync WebSQLDatabases API.
​https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Jeremy Orlow.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DatabaseSync.cpp: Added.

(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):

  • storage/DatabaseSync.h: Added.

(WebCore::DatabaseSync::databaseDebugName):

  • storage/SQLTransactionSync.cpp: Added.

(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):

  • storage/SQLTransactionSync.h: Added.

(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):

  • storage/SQLTransactionSyncCallback.h: Added.

(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):

3:05 PM Changeset in webkit [58436] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 İsmail Dönmez <​ismail@namtrac.org>

Reviewed by Simon Hausmann.

Fix compilation with QT_NO_CURSOR defined.

  • platform/qt/QWebPageClient.h: (QWebPageClient::resetCursor): (QWebPageClient::setCursor):
2:53 PM Changeset in webkit [58435] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-04-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

fix linux expected result for fast/text/line-breaks.html
​https://bugs.webkit.org/show_bug.cgi?id=38283

This is needed after r58426. See ​http://trac.webkit.org/changeset/57242
for more details.

  • platform/chromium-linux/fast/text/line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/line-breaks-expected.png:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt:
2:51 PM Changeset in webkit [58434] by eric@webkit.org
  • 14 edits
    1 copy in trunk/WebKitTools

2010-04-28 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Audit all uses of subprocess in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=38284

After further discussions with Jeffrey Yasskin
about ​http://bugs.python.org/issue2320
and related issues of using subprocess from
multiple threads, I have learned that subprocess
is known to be non-threadsafe through recent
Python 2.7 builds.

I'm attempting to lessen our exposure to these
subprocess bugs by auditing each use of subprocess
in webkitpy. I did not find any unsafe calls
in my audit, but I did remove numerous unneeded
import subprocess lines.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
2:42 PM Changeset in webkit [58433] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Alexey Proskuryakov.

Added a check to make sure that resources from a different https origin are not cached.
​https://bugs.webkit.org/show_bug.cgi?id=33456

Test: http/tests/appcache/different-https-origin-resource-main.html

  • loader/appcache/ManifestParser.cpp: (WebCore::parseManifest):
2:23 PM Changeset in webkit [58432] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-04-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()

Ensure that the WebView +initialize method initializes threading, so that things are correctly
initialized when the first call into the WebKit framework is via a WebView class method.

  • WebView/WebView.mm: (+[WebView initialize]):
2:19 PM Changeset in webkit [58431] by weinig@apple.com
  • 2 edits in trunk/WebCore

Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.

Reviewed by Mark Rowe.

  • Configurations/WebCore.xcconfig:
2:04 PM Changeset in webkit [58430] by evan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-28 Evan Martin <​evan@chromium.org>

Reviewed by Adam Roben.

rebaseline for fast/text/international/bold-bengali
​https://bugs.webkit.org/show_bug.cgi?id=38281

  • platform/win/fast/text/international/bold-bengali-actual.txt: Added.
2:02 PM Changeset in webkit [58429] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.

Reviewed by Sam Weinig.

  • wtf/CurrentTime.cpp:

(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.

1:57 PM Changeset in webkit [58428] by Darin Adler
  • 7 edits in trunk

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

REGRESSION: Autoscroll does not work in Mail messages
​https://bugs.webkit.org/show_bug.cgi?id=38267
rdar://problem/7559799

The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
view had gotten broken in multiple ways. For some reason, a combination of bugs made it
partly work until around r48064. This brings it back.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view rather than the WebView itself. This logic may not be correct for the case where usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

REGRESSION: Autoscroll does not work in Mail messages
​https://bugs.webkit.org/show_bug.cgi?id=38267
rdar://problem/7559799

Still haven't figured out a good way to test this with DumpRenderTree
or with Safari. Testing has to be done with Mail for now.

The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
view had gotten broken in multiple ways. For some reason, a combination of bugs made it
partly work until around r48064. This brings it back.

There were three problems:

1) Code in EventHandler decided there was nothing to scroll, so didn't start

the autoscroll timer.

2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect

coordinate conversion.

I verified that none of these have any effect on regression tests, or behavior in
web browsers, or behavior on platforms other than Mac.

  • page/EventHandler.cpp: (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly and for the top level box of the top frame. (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll. (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Fixed comment.
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this now-unused function along with some comments about removing some obsolete code.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively since from the WebKit point of view this is the topmost scroll view anyway. Instead call setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs to use a different rectangle anyway.
1:50 PM Changeset in webkit [58427] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] tst_QWebHistoryInterface::visitedLinks() fails
​https://bugs.webkit.org/show_bug.cgi?id=37323

Patch by Antonio Gomes <​tonikitoo@webkit.org>, Yi Shen <​yi.4.shen@nokia.com> on 2010-04-28
Reviewed by NOBODY Simon Hausmann.

Patch fixes styleProperty method of QWebElement to make use of
CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter
and the corresponding failing QWebHistoryInterface::visitedLinks method.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

  • tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:

(tst_QWebHistoryInterface::visitedLinks):

1:50 PM Changeset in webkit [58426] by ojan@chromium.org
  • 5 edits in trunk

2010-04-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adele Peterson.

​http://trac.webkit.org/changeset/57215 caused perf/memory regressions
​https://bugs.webkit.org/show_bug.cgi?id=37292

#if out the canUseGlyphCache Changes from r57215 as they caused a
8% perf regression on Chromium's international page load tests so that
the perf regression can be fixed properly without being left in the tree.

  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:

2010-04-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adele Peterson.

​http://trac.webkit.org/changeset/57215 caused perf/memory regressions
​https://bugs.webkit.org/show_bug.cgi?id=37292

#if out the canUseGlyphCache Changes from r57215 as they caused a
8% perf regression on Chromium's international page load tests so that
the perf regression can be fixed properly without being left in the tree.

  • platform/graphics/FontFastPath.cpp: (WebCore::Font::canUseGlyphCache):
1:35 PM Changeset in webkit [58425] by darin@chromium.org
  • 8 edits in trunk

2010-04-28 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[Chromium] callOnMainThread should equate to MessageLoop::PostTask
​https://bugs.webkit.org/show_bug.cgi?id=38276

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • wtf/MainThread.cpp:
  • wtf/chromium/ChromiumThreading.h:
  • wtf/chromium/MainThreadChromium.cpp: (WTF::initializeMainThread): (WTF::callOnMainThread): (WTF::callOnMainThreadAndWait): (WTF::setMainThreadCallbacksPaused): (WTF::isMainThread):
1:30 PM Changeset in webkit [58424] by ap@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=38278
​https://localhost:8443 doesn't work in WebKit tests

We only had a VirtualHost for 127.0.0.1:8443. Changed that to *:8443.

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:
12:48 PM Changeset in webkit [58423] by Beth Dakin
  • 8 edits in trunk

Fix for <rdar://problem/7474349>

Reviewed by Darin Adler.

Add a synchronous display mechanism for WKCACFLayerRenderer.

WebCore:

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
just like setRootContents(), but it calls paint() instead of
renderSoon().

  • platform/graphics/win/WKCACFLayerRenderer.h:

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp:

(WebView::WebView):
(WebView::updateRootLayerContents):
(WebView::nextDisplayIsSynchronous):

  • WebView.h:
12:42 PM Changeset in webkit [58422] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

Make WebThemeEngine::paint take a const ref of ExtraParams
​https://bugs.webkit.org/show_bug.cgi?id=38242

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paint):
12:39 PM Changeset in webkit [58421] by dimich@chromium.org
  • 9 edits in trunk/WebCore

REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
​https://bugs.webkit.org/show_bug.cgi?id=37554

Reviewed by Geoffrey Garen.

The flaky fast/workers/wrapper-map-gc.html will stop being flaky.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.

  • bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
(WebCore::WorkerScriptController::isExecutionForbidden):

  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::isExecutionForbidden):

Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
and 'true' for WorkerContext when script is terminated.

  • dom/ScriptExecutionContext.h:
  • dom/Document.h:

(WebCore::Document::isJSExecutionTerminated):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::isJSExecutionTerminated):

  • workers/WorkerContext.h:
12:24 PM Changeset in webkit [58420] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
​https://bugs.webkit.org/show_bug.cgi?id=38270

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
12:15 PM Changeset in webkit [58419] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
​https://bugs.webkit.org/show_bug.cgi?id=38264

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
11:36 AM Changeset in webkit [58418] by crogers@google.com
  • 4 adds in branches/audio/WebCore/audio

Add biquad filter files

11:35 AM Changeset in webkit [58417] by alex
  • 2 edits in trunk/LayoutTests

2010-04-28 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing test http/tests/misc/isindex-with-no-form.html
​https://bugs.webkit.org/show_bug.cgi?id=30815

The test currently works, removing from Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/Skipped:
11:25 AM Changeset in webkit [58416] by evan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-04-28 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

fast/text/international/bold-bengali needs baselines
​https://bugs.webkit.org/show_bug.cgi?id=38273

  • platform/chromium-win/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/bold-bengali-expected.png: Added.
  • platform/mac/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/mac/fast/text/international/bold-bengali-expected.png: Added.
10:54 AM Changeset in webkit [58415] by xji@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-28 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dimitri Glazkov

Rebaseline Webkit Mac pixel results and chromium pixel results
caused by ​http://trac.webkit.org/changeset/58191
Webkit Mac pixel results failed with --tolerance=0
​https://bugs.webkit.org/show_bug.cgi?id=38104

  • platform/chromium-linux/editing/deleting/4845371-expected.checksum:
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5126166-expected.checksum:
  • platform/chromium-linux/editing/deleting/5126166-expected.png:
  • platform/chromium-linux/editing/deleting/5483370-expected.checksum:
  • platform/chromium-linux/editing/deleting/5483370-expected.png:
  • platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4875189-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-win/editing/deleting/4845371-expected.checksum:
  • platform/chromium-win/editing/deleting/4845371-expected.png:
  • platform/chromium-win/editing/deleting/5126166-expected.checksum:
  • platform/chromium-win/editing/deleting/5126166-expected.png:
  • platform/chromium-win/editing/deleting/5483370-expected.checksum:
  • platform/chromium-win/editing/deleting/5483370-expected.png:
  • platform/chromium-win/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4875189-2-expected.png:
  • platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5387578-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/4845371-expected.png:
  • platform/mac/editing/deleting/5126166-expected.png:
  • platform/mac/editing/deleting/5483370-expected.png:
  • platform/mac/editing/deleting/table-cells-expected.png:
  • platform/mac/editing/inserting/4875189-2-expected.png:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png:
  • platform/mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/mac/fast/repaint/caret-outside-block-expected.png:
10:53 AM Changeset in webkit [58414] by xji@chromium.org
  • 55 edits
    13 adds
    7 deletes in trunk/LayoutTests

2010-04-28 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dimitri Glazkov

Rebaseline Webkit Mac pixel results and chromium pixel results
caused by ​http://trac.webkit.org/changeset/58191
Webkit Mac pixel results failed with --tolerance=0

  • platform/chromium-linux/editing/deleting/4845371-expected.checksum:
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5126166-expected.checksum:
  • platform/chromium-linux/editing/deleting/5126166-expected.png:
  • platform/chromium-linux/editing/deleting/5483370-expected.checksum:
  • platform/chromium-linux/editing/deleting/5483370-expected.png:
  • platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4875189-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-win/editing/deleting/4845371-expected.checksum:
  • platform/chromium-win/editing/deleting/4845371-expected.png:
  • platform/chromium-win/editing/deleting/5126166-expected.checksum:
  • platform/chromium-win/editing/deleting/5126166-expected.png:
  • platform/chromium-win/editing/deleting/5483370-expected.checksum:
  • platform/chromium-win/editing/deleting/5483370-expected.png:
  • platform/chromium-win/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4875189-2-expected.png:
  • platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5387578-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/4845371-expected.png:
  • platform/mac/editing/deleting/5126166-expected.png:
  • platform/mac/editing/deleting/5483370-expected.png:
  • platform/mac/editing/deleting/table-cells-expected.png:
  • platform/mac/editing/inserting/4875189-2-expected.png:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png:
  • platform/mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/mac/fast/repaint/caret-outside-block-expected.png:
10:14 AM Changeset in webkit [58413] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-28 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Fixed passing breakpoints to V8.
​https://bugs.webkit.org/show_bug.cgi?id=38266

  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
10:10 AM Changeset in webkit [58412] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2010-04-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Linkify node and function in the event listeners panel.

​https://bugs.webkit.org/show_bug.cgi?id=38251

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation):
  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation):
  • bindings/v8/ScriptEventListener.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference): (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): ():
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
  • inspector/front-end/inspector.css: (.node-link):
9:56 AM Changeset in webkit [58411] by Darin Adler
  • 2 edits in trunk/WebKitTools

Ignore a directory the Python tools creates.

  • Scripts/webkitpy/style: Modified property svn:ignore.
9:44 AM Changeset in webkit [58410] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/extract-localizable-strings: Fix minor mistake in

argument checking.

9:29 AM Changeset in webkit [58409] by jchaffraix@webkit.org
  • 5 edits
    5 adds in trunk

[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
​https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

Rolling the patch in as I could not reproduce Qt results locally.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:

Added those 2 tests to the Skipped lists.

8:47 AM WebInspector edited by pmuellr@yahoo.com
add info about the weinre experiment (diff)
7:23 AM Changeset in webkit [58408] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: preserves-3d and backface visibility
​https://bugs.webkit.org/show_bug.cgi?id=35312

Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.

WebKitSite/blog-files/3d-transforms test now work with Qt.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::opaqueArea): (WebCore::GraphicsLayerQtImpl::boundingRect): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
6:58 AM Changeset in webkit [58407] by eric@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

2010-04-28 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Rebaseline svg-background-partial-redraw, node-iterator-prototype, and upstream test expectations for fast/text/international/bold-bengali.html
​https://bugs.webkit.org/show_bug.cgi?id=38259

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac/fast/images: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac/traversal: Added.
  • platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/chromium-win/traversal: Added.
  • platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:49 AM Changeset in webkit [58406] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
​https://bugs.webkit.org/show_bug.cgi?id=38251

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelinePanel.WindowSelector): (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement): (WebInspector.TimelinePanel.WindowSelector.prototype._close): (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
  • inspector/front-end/inspector.css: (#timeline-overview-grid): (.timeline-window-selector): (#timeline-overview-window): (.timeline-overview-dividers-background): (.timeline-overview-window-rulers): (.timeline-window-resizer):
5:58 AM Changeset in webkit [58405] by eric@webkit.org
  • 6 edits in trunk

2010-04-28 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Replacing method qt_wrt_setViewMode by wrt_viewMode property.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::event):
  • Api/qwebpage_p.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::wrt_viewModes):

2010-04-28 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Replacing method qt_wrt_setViewMode by wrt_viewMode property.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
5:53 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
4:58 AM Changeset in webkit [58404] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-04-28 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Reverts 58340 (​https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
​https://bugs.webkit.org/show_bug.cgi?id=38254

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
4:49 AM Changeset in webkit [58403] by eric@webkit.org
  • 13 edits
    5 adds
    1 delete in trunk

2010-04-28 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Moved console-tests.js to http tests. Added support for sorting
console messages, in case order may vary.
​https://bugs.webkit.org/show_bug.cgi?id=37215

  • http/tests/inspector/console-resource-errors-expected.txt: Added.
  • http/tests/inspector/console-resource-errors.html: Added.
  • http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Removed.
  • platform/mac-tiger/http/tests/inspector: Added.
  • platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added.

2010-04-28 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

Test: http/tests/inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
4:39 AM Changeset in webkit [58402] by eric@webkit.org
  • 5 edits in trunk

2010-04-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Support pause on exceptions in v8 implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=38205

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/ScriptDebugServer.h:

2010-04-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Support pause on exceptions in v8 implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=38205

  • src/js/DebuggerScript.js: (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber): (debuggerScriptConstructor):
4:19 AM Changeset in webkit [58401] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-28 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Adjusted check-webkit-style so that files with file type NONE
are automatically skipped without warning.

​https://bugs.webkit.org/show_bug.cgi?id=38197

This change simplifies configuring which files to skip. It also
addresses an issue whereby check-webkit-style was unintentionally
checking .vcproj files for carriage returns.

  • Scripts/webkitpy/style/checker.py:
    • Moved the C++, Python, and text file extensions to new module-level configuration variables.
    • Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration variable.
    • Changed the numeric values of the FileType enum so that FileType.NONE evaluates to False.
    • For ProcessorDispatcher.should_skip_without_warning():
      • Changed the method to return True for FileType.NONE files.
      • Made ChangeLog files an exception to getting skipped.
    • Changed the StyleProcessor.process() method to raise an exception if given a file path that should not be processed.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit tests and added more test cases as necessary.
3:57 AM Changeset in webkit [58400] by jorlow@chromium.org
  • 6 edits
    4 deletes in trunk

2010-04-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58313.
​http://trac.webkit.org/changeset/58313
​https://bugs.webkit.org/show_bug.cgi?id=38253

Regression evident in pixel tests: the search icon is always
clipped at the bottom. (Requested by jorlow on #webkit).

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::controlClipRect):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:

2010-04-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58313.
​http://trac.webkit.org/changeset/58313
​https://bugs.webkit.org/show_bug.cgi?id=38253

Regression evident in pixel tests: the search icon is always
clipped at the bottom. (Requested by jorlow on #webkit).

  • fast/css/input-search-padding.html: Removed.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Removed.
  • platform/mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/mac/fast/css/input-search-padding-expected.txt: Removed.
3:54 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
3:32 AM Changeset in webkit [58399] by Simon Hausmann
  • 1 edit in trunk/WebCore/inspector/InspectorFrontend.cpp

Removed execute permissions from WebCore/inspector/InspectorFrontend.cpp

3:29 AM Changeset in webkit [58398] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-28 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Disable printing/media-queries-print for now.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

  • platform/mac/Skipped:
3:09 AM Changeset in webkit [58397] by ukai@chromium.org
  • 10 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <​eric@webkit.org>

Reviewed by Jeremy Orlow.

webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
​https://bugs.webkit.org/show_bug.cgi?id=38248

The previous code did not check the return code of taskkill.
When I moved that callsite from using subprocess.call to
Executive.run_command having a non-zero return code became an error.

In this change I've centralized our killall handling in executive,
and added tests for it to make sure it works.

Currently kill_process and kill_all swallow exceptions in the cases
where the process(es) to be killed do(es) not exist.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
2:58 AM Changeset in webkit [58396] by hamaji@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-28 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Added missing expectation files missed in r58386.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

  • platform/mac/printing/media-queries-print-expected.checksum: Added.
  • platform/mac/printing/media-queries-print-expected.png: Added.
  • platform/mac/printing/media-queries-print-expected.txt: Added.
2:44 AM Changeset in webkit [58395] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <​eric@webkit.org>

Reviewed by Shinichiro Hamaji.

wdiff_text throws ScriptError because wdiff returns non-zero when files differ
​https://bugs.webkit.org/show_bug.cgi?id=38246

wdiff returns 0 when files are the same, 1 when they differ.
run_command by default raises ScriptError if the return code is non-zero.
Fixed this by adding a custom error handler which only raises if the
return code is not 1.

I broke up the huge wdiff_text() method into little pieces
for easier unit testing. There is only one functional change here
and that is the addition of the custom error handler.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
2:21 AM Changeset in webkit [58394] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

Unreviewed build fix.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest): too few arguments for format.

2:06 AM Changeset in webkit [58393] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

JSC's currentThreadStackBase is not reentrant on some platforms
​https://bugs.webkit.org/show_bug.cgi?id=37195

Patch by Simon Hausmann <​simon.hausmann@nokia.com>, Kent Hansen <​kent.hansen@nokia.com> on 2010-04-28
Reviewed by Darin Adler.

This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.

This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.

  • runtime/Collector.cpp:

(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):

1:55 AM Changeset in webkit [58392] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix compilation with gcc 3.4.

Patch by Thiago Macieira <​thiago.macieira@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor

  • wtf/text/AtomicStringImpl.h:

(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.

  • wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.
1:31 AM Changeset in webkit [58391] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] WINS DEF file freeze

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-04-28
Reviewed by Simon Hausmann <​simon.hausmann@nokia.com>

Updated WINSCW def file with added and removed symbols.

  • symbian/bwins/QtWebKitu.def:
1:29 AM Changeset in webkit [58390] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix detection of Qt 4.7's multimedia libraries

Patch by Justin McPherson <​justin.mcpherson@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.

  • WebCore.pro:
12:49 AM Changeset in webkit [58389] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-04-28 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed attempt to fix the chromium build.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

  • rendering/RenderTreeAsText.cpp:
12:47 AM Changeset in webkit [58388] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-28 Daniel Bates <​dbates@rim.com>

Unreviewed, rebase expected result of failing test.

Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
Following the landing of bug #37686, this test started failing despite
being unrelated to this bug. From looking at the diff of the result,
which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
comment, we have decided to rebase this result.

  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
12:33 AM Changeset in webkit [58387] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

WebView drawing code may access null backing store dirty region
​https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)

Reviewed by Maciej Stachowiak.

  • WebView.cpp:

(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.

12:30 AM Changeset in webkit [58386] by hamaji@chromium.org
  • 14 edits in trunk

2010-04-27 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

Now we can test media queries with the new function because the
render tree has the color information of the box.

Note that the pixel test is currently failing. We'll need another
patch to enable printing mode for pixel tests.

  • platform/mac/Skipped:
  • platform/mac/printing/media-queries-print-expected.checksum: Added.
  • platform/mac/printing/media-queries-print-expected.png: Added.
  • platform/mac/printing/media-queries-print-expected.txt: Added.
  • printing/media-queries-print.html:

2010-04-27 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

Added RenderAsTextPrintingMode as a behavior of externalRepresentation.

Now ~PrintContext() calls end() automatically.

  • page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext):
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
  • rendering/RenderTreeAsText.h: (WebCore::):

2010-04-27 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):

2010-04-27 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=37203

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setPrintingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::isPrinting): (LayoutTestController::setIsPrinting):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
12:09 AM Changeset in webkit [58385] by yuzo@google.com
  • 6 edits in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 4)
Implement page property parsing as specified at ​http://dev.w3.org/csswg/css3-page/#using-named-pages.
​https://bugs.webkit.org/show_bug.cgi?id=35853

  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 4)
Implement page property parsing as specified at ​http://dev.w3.org/csswg/css3-page/#using-named-pages.
​https://bugs.webkit.org/show_bug.cgi?id=35853

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parsePage):
  • css/CSSParser.h:

Apr 27, 2010:

11:45 PM Changeset in webkit [58384] by yuzo@google.com
  • 7 edits in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35851

  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35851

I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
(2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseSize): (WebCore::CSSParser::parseSizeParameter):
  • css/CSSParser.h: (WebCore::CSSParser::):
  • css/CSSValueKeywords.in:
11:19 PM Changeset in webkit [58383] by yuzo@google.com
  • 11 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.

​https://bugs.webkit.org/show_bug.cgi?id=35782

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • printing/page-rule-css-text-expected.txt: Added.
  • printing/page-rule-css-text.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

​https://bugs.webkit.org/show_bug.cgi?id=35782

Test: printing/page-rule-css-text.html

  • css/CSSGrammar.y:
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::create): (WebCore::CSSPageRule::isPageRule):
  • css/CSSParser.cpp: (WebCore::CSSParser::createPageRule):
  • css/CSSStyleRule.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPageRules): (WebCore::CSSRuleSet::CSSRuleSet): (WebCore::CSSRuleSet::~CSSRuleSet): (WebCore::CSSRuleSet::addPageRule): (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/CSSStyleSelector.h:
  • css/StyleBase.h: (WebCore::StyleBase::isPageRule):
11:00 PM Changeset in webkit [58382] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix bug that prevents autosave of forms without action attribute
​https://bugs.webkit.org/show_bug.cgi?id=38014
Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
It needs a native unit test, which would go in the Chromium repo, not WebKit.

  • src/WebPasswordFormData.cpp: (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
10:42 PM Changeset in webkit [58381] by dbates@webkit.org
  • 7 edits
    6 adds in trunk

2010-04-27 Daniel Bates <​dbates@rim.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=37686

Fixes an issue where the canvas method strokeRect will stroke a
rectangle whose dimensions are 0 when lineWidth > 1.

As per the definition of strokeRect in the HTML Canvas 2D Context
spec. <​http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
this method should have no effect when both the height and width
are zero.

Tests: fast/canvas/canvas-clearRect.html

fast/canvas/canvas-fillRect.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::validateRectForCanvas): Return false if height, width == 0.

2010-04-27 Daniel Bates <​dbates@rim.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=37686

Tests that strokeRect does not paint any artifacts when the
specified rectangle has height, width = 0 and lineWidth > 1.

Also tests that clearRect, fillRect, and rect are ignored when
height, width = 0.

  • fast/canvas/canvas-clearRect-expected.txt: Added.
  • fast/canvas/canvas-clearRect.html: Added.
  • fast/canvas/canvas-fillRect-expected.txt: Added.
  • fast/canvas/canvas-fillRect.html: Added.
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/canvas-strokeRect-expected.txt: Updated results.
  • fast/canvas/script-tests/canvas-clearRect.js: Added.
  • fast/canvas/script-tests/canvas-fillRect.js: Added.
  • fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
  • fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added debug statements so as to distinguish the results for each test.
10:40 PM Changeset in webkit [58380] by eric@webkit.org
  • 8 edits in trunk

2010-04-27 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

​https://bugs.webkit.org/show_bug.cgi?id=38147

  • public/WebCommonWorkerClient.h: add the factory method
  • public/WebURLRequest.h: add the TargetTypes
  • src/WebWorkerBase.cpp: call the embedder's factory when needed (WebKit::WebWorkerBase::didCreateDataSource) (WebKit::WebWorkerBase::createApplicationCacheHost)
  • src/WebWorkerBase.h: ditto
  • src/WebWorkerClientImpl.h: add a stub impl of the factory method (WebKit::WebWorkerClientImpl::createApplicationCacheHost):

2010-04-27 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

​https://bugs.webkit.org/show_bug.cgi?id=38147

  • DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method (TestWebWorker::createApplicationCacheHost):
10:31 PM Changeset in webkit [58379] by eric@webkit.org
  • 8 edits
    3 deletes in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove obsolete custom bindings file
​https://bugs.webkit.org/show_bug.cgi?id=38223

We don't need these files anymore because they are empty.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDocumentFragmentCustom.cpp: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Removed.
10:21 PM Changeset in webkit [58378] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
​https://bugs.webkit.org/show_bug.cgi?id=38227

Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
For now, we hack around the problem in the Chromium platform, but the proper long term
solution is to change DragController::performDrag to check dragData::asFilenames().

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
9:53 PM Changeset in webkit [58377] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
​https://bugs.webkit.org/show_bug.cgi?id=38103

  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • gyp_webkit:
9:49 PM Changeset in webkit [58376] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

run-bindings-tests doesn't work in an SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=38225

Previously detect_scm_system needed an absolute path for SVN. Now we
accept a relative path.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
9:20 PM Changeset in webkit [58375] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-04-27 Simon Fraser <Simon Fraser>

Reviewed by the inimitable Dan Bernstein.

SVG as background image renders incorrectly after zooming
​https://bugs.webkit.org/show_bug.cgi?id=38215

When doing a partial redraw of an SVGImage used as a CSS background
image, we're limited to drawing the entire Frame, clipped to the dirty rect.
Because of this, we need to fix up the CTM so that the origin is at the
top left of the unclipped image, rather than the top left of the
portion being redrawn.

Test: fast/images/svg-background-partial-redraw.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
8:42 PM Changeset in webkit [58374] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
8:37 PM Changeset in webkit [58373] by jchaffraix@webkit.org
  • 4 edits
    5 deletes in trunk

Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.

WebCore:

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):

LayoutTests:

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
  • platform/qt/Skipped:
8:08 PM Changeset in webkit [58372] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Add the 2 newly added test cases to the list

as they involve preflight requests.

7:44 PM Changeset in webkit [58371] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
​https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
7:29 PM Changeset in webkit [58370] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Makes clicking a select element close its associated popup if
it is open.
​https://bugs.webkit.org/show_bug.cgi?id=38105

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
7:08 PM Changeset in webkit [58369] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Merged the WebView public method to close suggestion popups
into a single method to close all popups (select and suggestions).
That ensures select popups are closed when the browser window is moved
or resized.
​https://bugs.webkit.org/show_bug.cgi?id=37837

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::hideSuggestionsPopup):
  • src/WebViewImpl.h:
6:45 PM Changeset in webkit [58368] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Always build WebKit2 when building on SnowLeopard and later.

Reviewed by Stephanie Lewis.

  • Scripts/build-webkit:
6:28 PM Changeset in webkit [58367] by weinig@apple.com
  • 6 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework

Reviewed by Maciej Stachowiak.

WebCore:

  • Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add

WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.

WebKit2:

  • Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't

need to set WebCore as a sub_umbrella of WebKit2, since we are not
reexporting any of its symbols.

WebKitTools:

  • Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building

WebCore for WebKit2, it is no longer necessary.

6:24 PM Changeset in webkit [58366] by dumi@chromium.org
  • 11 edits in trunk

WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
​https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
​https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

The expectations changed because of AUTO_VACUUM's overhead.

  • platform/chromium/test_expectations.txt:
  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
6:19 PM Changeset in webkit [58365] by jam@chromium.org
  • 1 edit
    1 delete in trunk/WebKit/chromium

2010-04-27 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary header now that Chrome is updated
​https://bugs.webkit.org/show_bug.cgi?id=38211

  • public/win/WebThemeEngine.h: Removed.
6:15 PM Changeset in webkit [58364] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by David Levin.

Fix a typo in chromium.py that causes NRWT to fail in --verbose
mode in a Chromium checkout.
​https://bugs.webkit.org/show_bug.cgi?id=38234

  • Scripts/webkitpy/layout_tests/port/chromium.py:
6:09 PM Changeset in webkit [58363] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-27 Garret Kelly <​gdk@chromium.org>

Reviewed by Darin Fisher.

Turn all of the touch event handlers into RuntimeEnabledFeatures, and
modify the createEvent methond on Document so that it won't create a
TouchEvent if the feature is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=37485

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::touchEnabled): (WebCore::RuntimeEnabledFeatures::setTouchEnabled): (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled): (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled): (WebCore::RuntimeEnabledFeatures::ontouchendEnabled): (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
  • dom/Document.cpp: (WebCore::Document::createEvent):
  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
5:55 PM Changeset in webkit [58362] by eric@webkit.org
  • 10 edits in trunk

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=37625

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox): New method.
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=37625

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didFirstLayout): (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
  • public/WebNode.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout): (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
  • src/WebElement.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::hasNonEmptyBoundingBox):
5:41 PM Changeset in webkit [58361] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] update test expectations for ancient linux bug
​https://bugs.webkit.org/show_bug.cgi?id=38229

According to
​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
this hasn't crashed in a long time, so the CRASH annotation is superfluous.

  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [58360] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix gyp build on Mac OS X with enable_svg=0.
​https://bugs.webkit.org/show_bug.cgi?id=38192

  • WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
5:33 PM EFLWebKit edited by barbieri@profusion.mobi
update to reflect current situation (diff)
5:29 PM Changeset in webkit [58359] by crogers@google.com
  • 5 edits in branches/audio/WebCore
  • added <xaudio> tag (this is temporary to support the old API)
  • some build changes for new audio javascript types
5:28 PM Changeset in webkit [58358] by eric@webkit.org
  • 6 edits in trunk

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

Switch over to implementing didNavigateWithinPage.

  • DumpRenderTree/chromium/WebViewHost.cpp: (TestWebViewDelegate::didNavigateWithinPage): (WebViewHost::didChangeLocationWithinPage):
  • DumpRenderTree/chromium/WebViewHost.h:
5:13 PM Changeset in webkit [58357] by crogers@google.com
  • 3 edits
    1 add in branches/audio/WebCore

hacks for CachedAudio including changes to EventTarget
(this supports a temporary and hackish loading mechanism for audio assets later to be replaced by XHR)

5:13 PM Changeset in webkit [58356] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/HRIR

add HRIR symlink

4:56 PM Changeset in webkit [58355] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::Carve):

4:42 PM Changeset in webkit [58354] by evan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Evan Martin <​evan@chromium.org>

Unreviewed.

Adding myself to commmitters list.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [58353] by Stephanie Lewis
  • 3 deletes in trunk/WebKitLibraries

Remove more files I didn't intend to commit

4:24 PM Changeset in webkit [58352] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

[V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
​https://bugs.webkit.org/show_bug.cgi?id=38207

No new tests.

  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:
4:23 PM Changeset in webkit [58351] by crogers@google.com
  • 2 deletes in branches/audio/WebCore/audio

remove initial test files

4:19 PM Changeset in webkit [58350] by Stephanie Lewis
  • 8 edits in trunk

Revert Files I didn't intend to commit

4:13 PM Changeset in webkit [58349] by eric@webkit.org
  • 5 edits
    8 adds in trunk

2010-04-27 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Additional MathML mroot & msqrt tests.
​https://bugs.webkit.org/show_bug.cgi?id=37044

  • mathml/presentation/roots.xhtml: Added.
  • platform/mac/mathml/presentation/roots-expected.checksum: Added.
  • platform/mac/mathml/presentation/roots-expected.png: Added.
  • platform/mac/mathml/presentation/roots-expected.txt: Added.

2010-04-27 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implementation of the MathML mroot & msqrt elements.
​https://bugs.webkit.org/show_bug.cgi?id=37044

Test: mathml/presentation/roots.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css: (mroot): (mroot > * + *): (mroot > * + mrow, mroot > * + mfenced):
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLRoot.cpp: Added. (WebCore::RenderMathMLRoot::RenderMathMLRoot): (WebCore::RenderMathMLRoot::addChild): (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout):
  • mathml/RenderMathMLRoot.h: Added.
  • mathml/RenderMathMLSquareRoot.cpp: Added. (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot): (WebCore::RenderMathMLSquareRoot::paint): (WebCore::RenderMathMLSquareRoot::layout):
  • mathml/RenderMathMLSquareRoot.h: Added.
4:02 PM Changeset in webkit [58348] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Create new baseline for caret-rtl-2
​https://bugs.webkit.org/show_bug.cgi?id=38126

​http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
test to start failing under Chromium. Since we're the only ones who
run pixel tests, it's possible that the actual baseline needs to be updated
and not just the chromium baseline...but I'm not sure.

I'm tracking the overall progress of figuring this out here:
​https://bugs.webkit.org/show_bug.cgi?id=38109

  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.
3:56 PM Changeset in webkit [58347] by Darin Adler
  • 1 edit
    1 delete in trunk/WebCore

I noticed an unused forwarding header.

Reviewed by Maciej Stachowiak.

  • ForwardingHeaders/runtime/PropertyMap.h: Removed.
3:55 PM Changeset in webkit [58346] by Stephanie Lewis
  • 8 edits
    9 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):

3:51 PM Changeset in webkit [58345] by jamesr@google.com
  • 12 edits in trunk/WebCore

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
​https://bugs.webkit.org/show_bug.cgi?id=38153

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
3:48 PM Changeset in webkit [58344] by evan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-27 Evan Martin <​evan@chromium.org>

Unreviewed, making the bots happy.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

Check in a baseline for Mac pulled from the bots.

  • platform/mac/fast/text/international/bold-bengali-expected.txt: Added.
3:47 PM Changeset in webkit [58343] by crogers@google.com
  • 2446 adds in branches/audio/WebCore/audio/AudioSpatialization

add HRIR spatialization files

3:04 PM Changeset in webkit [58342] by eric@webkit.org
  • 13 edits
    1 move
    2 deletes in trunk

2010-04-27 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58318.
​http://trac.webkit.org/changeset/58318
​https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • http/tests/inspector/console-resource-errors-expected.txt: Removed.
  • http/tests/inspector/console-resource-errors.html: Removed.
  • http/tests/inspector/console-tests.js: Removed.
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):

2010-04-27 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58318.
​http://trac.webkit.org/changeset/58318
​https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2:53 PM Changeset in webkit [58341] by evan@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

Add a layout test containing some bold Bengali text.

  • fast/text/international/bold-bengali.html: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

We must let Skia do font fallback, rather than picking a font name
then handing that to Skia. For example, if we have Bengali text and
choose FreeSans + fake bold, and then later reuse the name, Skia will
helpfully use FreeSansBold (which doesn't cover Bengali).

Test: fast/text/international/bold-bengali.html

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
Roll forward Chrome DEPS so we get new Skia API.

  • DEPS: update Chrome to r45696.
2:52 PM Changeset in webkit [58340] by jamesr@google.com
  • 6 edits in trunk/WebCore

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
​https://bugs.webkit.org/show_bug.cgi?id=38158

Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
and functions mixed in.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
2:51 PM Changeset in webkit [58339] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add test for NodeIterator prototype change behavior
​https://bugs.webkit.org/show_bug.cgi?id=38219

In the process of remove the custom code from NodeIterator, we thought
we fixed a subtle bug where iterating over nodes from another frame
would get the wrong prototype chain. This test documents that we
didn't actually change the behavior and we still have the bug.

  • traversal/node-iterator-prototype-expected.txt: Added.
  • traversal/node-iterator-prototype.html: Added.
  • traversal/resources/node-iterator-prototype-frame.html: Added.
2:44 PM Changeset in webkit [58338] by crogers@google.com
  • 130 adds in branches/audio/WebCore/audio

add initial set of audio engine source files

2:35 PM Changeset in webkit [58337] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/7911140> Hitting the "delete" key goes back twice

Reviewed by Maciej Stachowiak.

  • WebView.cpp:

(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.

2:31 PM Changeset in webkit [58336] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Sending a package file using FormData crashes WebKit on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=37882

Reviewed by Darin Adler.

Can't add a layout test because DRT does not support generating the file name.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::navigateToDifferentDocument):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

2:06 PM Changeset in webkit [58335] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Ojan Vafai <​ojan@chromium.org>

Unreviewed. Minor fix after goofup in ​http://trac.webkit.org/changeset/58331

layoutTestController should have dumpAsMarkup
​https://bugs.webkit.org/show_bug.cgi?id=26501

Forgot to reset the test results after doing the code review feedback
of adding a newline.

  • editing/selection/dump-as-markup-expected.txt:
1:59 PM Changeset in webkit [58334] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/test-commit2

test commit 2

1:55 PM Changeset in webkit [58333] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom NodeIterator bindings
​https://bugs.webkit.org/show_bug.cgi?id=38188

Another example of CallWith=ScriptState. This case shows us the right
way to handle the interaction with exception codes.

In my previous patch, I put the exception code handling after the
ScriptState exception handling. It turns out this was a mistake
(although a harmless one at the time because no IDL caused us to
generate that code). Now that we're generating both kinds of exception
handling, we need to generate them in the right order.

  • WebCore.gypi:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback): (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback): (WebCore::TestObjInternal::withScriptStateObjExceptionCallback): (WebCore::):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
  • dom/NodeIterator.idl:
1:35 PM Changeset in webkit [58332] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add comment about not using StringImpl::createCFString in WKStringCopyCFString.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

1:29 PM Changeset in webkit [58331] by ojan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-04-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

layoutTestController should have dumpAsMarkup
​https://bugs.webkit.org/show_bug.cgi?id=26501

  • editing/selection/dump-as-markup-expected.txt: Added.
  • editing/selection/dump-as-markup.html: Added.
  • resources/dump-as-markup.js: Added. (Markup.dump.get var): (Markup.dump.get catch): (Markup.dump): (Markup.waitUntilDone): (Markup.notifyDone): (Markup._spaces): (Markup._getAttributes): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
1:26 PM Changeset in webkit [58330] by abarth@webkit.org
  • 32 edits in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove copy/paste addEventListener "custom" bindings via code generation
​https://bugs.webkit.org/show_bug.cgi?id=38210

It's somewhat lame to special case addEventListener and
removeEventListener in the code generator, but it saves a large amount
of boilerplate "custom" bindings code.

Idea shamelessly stolen from the V8 code generator.

This patch points to some good refactoring opportunities in
CodeGeneratorJS.pm, but I'm going to hold off on those for a future
patch. By generating test coverage for the code generator, we make
these future refactorings easier.

  • bindings/js/JSAbstractWorkerCustom.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDesktopNotificationsCustom.cpp:
  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::addEventListenerCallback): (WebCore::TestObjInternal::removeEventListenerCallback): (WebCore::):
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/EventSource.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
1:25 PM Changeset in webkit [58329] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

run-bindings-tests should use --reset-results instead of --overwrite
​https://bugs.webkit.org/show_bug.cgi?id=38200

As requested by Ojan.

  • Scripts/run-bindings-tests:
1:22 PM Changeset in webkit [58328] by abarth@webkit.org
  • 22 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r58261): webkit-patch edit-changelogs is broken
​https://bugs.webkit.org/show_bug.cgi?id=38204

In 58261, we added code to abstract step that interrogates the squash
and git_commit options, but it doesn't declare that it uses those
options. That means any command that doesn't happen to declare those
options might be broken if it uses the cached_lookup mechanism.

  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
1:16 PM Changeset in webkit [58327] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
​https://bugs.webkit.org/show_bug.cgi?id=38212

  • Scripts/prepare-ChangeLog:
    • Pass --insecure to curl to work around CYGWIN missing certs.
1:15 PM Changeset in webkit [58326] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/test-commit

testing git svn dcommit

1:05 PM Changeset in webkit [58325] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters
directly. StringImpl::createCFString only an optimization when called
from the thread that WebCore is running on, which is never the case for
WKStringCopyCFString. We should revisit this later, perhaps adding a
threadspecific allocator. We also now honor the passed in allocator.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

12:51 PM Changeset in webkit [58324] by weinig@apple.com
  • 8 edits in trunk

WebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.

Rubber-stamped by Beth Dakin.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):

  • page/EventHandler.h:
  • page/mac/DragControllerMac.mm:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/PopupMenuMac.mm:

WebKitTools: It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
or WTF_USE_WEB_THREAD. Remove them.

Rubber-stamped by Beth Dakin.

  • Scripts/build-webkit:
12:50 PM WebKit Team edited by Chris Jerdonek
Changed myself from committer to reviewer. (diff)
12:45 PM Changeset in webkit [58323] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

No new tests required, only updating documentation.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling

the TouchStationary state as a result of discussions in bug 37609.

12:44 PM Changeset in webkit [58322] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Changed Chris Jerdonek from committer to reviewer.

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
12:33 PM Changeset in webkit [58321] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
​https://bugs.webkit.org/show_bug.cgi?id=35834

The scene should always have the size of the web view otherwhise it is
possible to scroll the graphics view.

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::resizeEvent):
12:26 PM Changeset in webkit [58320] by Simon Fraser
  • 5 edits
    5 adds in trunk/WebCore

2010-04-27 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler, Maciej Stachowiak.

REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
​https://bugs.webkit.org/show_bug.cgi?id=38183

Rather than sprinkle PLATFORM #ifdefs around, add a new method,
RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
an iframe with composited content should trigger compositing mode in the enclosing document
(a behavior that differs between platforms).

Use this new method to determine whether to trigger a style recalc in the parent document
when an iframe becomes composited.

Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().

  • manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
  • manual-tests/compositing/resources/flash-frame.html: Added.
  • manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent): (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
12:11 PM Changeset in webkit [58319] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself to committers.py

  • Scripts/webkitpy/common/config/committers.py:
11:47 AM Changeset in webkit [58318] by eric@webkit.org
  • 13 edits
    1 move
    2 adds in trunk

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Moved console-tests.js to http tests. Added support for sorting
console messages, in case order may vary.
​https://bugs.webkit.org/show_bug.cgi?id=37215

  • http/tests/inspector/console-resource-errors-expected.txt: Added.
  • http/tests/inspector/console-resource-errors.html: Added.
  • http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Removed.

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

Test: http/tests/inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:17 AM Changeset in webkit [58317] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add specialized thunks for a char code related string functions
​https://bugs.webkit.org/show_bug.cgi?id=38177

This is a simple extension to my prior patch. Basically hoist the
existing character loading logic from the charCodeAt thunk and into
a helper function, then add a helper to load strings from the small
string cache. This allows trivial implementations of fromCharCode
and charAt.

  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSCell): (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
  • jit/ThunkGenerators.cpp: (JSC::stringCharLoad): (JSC::charToString): (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator):
  • jit/ThunkGenerators.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
10:58 AM Changeset in webkit [58316] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Fix XHR memory leak in GC controller.
​https://bugs.webkit.org/show_bug.cgi?id=38202

​http://trac.webkit.org/changeset/55798 simplified processing of
active DOM objects but introduced a subtle bug in garbage
collection of XHRs. ActiveDOMObject is not a direct base class of
XHR and so upcasting changes pointer identity and breaks DOM
maps. This leads to forever live persistent handles to XHR that
had pending activity while V8 GC happened.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
10:54 AM Changeset in webkit [58315] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Unreviewed. Regenerate reference bindings code generator output.

  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback):
10:50 AM Changeset in webkit [58314] by eric@webkit.org
  • 14 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=37987

After further research, I believe the hang is caused by:
​http://bugs.python.org/issue2320
Basically Popen() is not reentrant.
The workaround is to pass close_fds=True to Popen() on Mac/Linux.

I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
when appropriate.

I audited all places we call Popen() and either moved them to run_command
or left a FIXME that they are not thread safe. A few places I added the
close_fds workaround there and left an explanitory note.

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/common/system/executive.py:
    • Fixed our Executive.run_* to workaround python bug 2320.
  • Scripts/webkitpy/common/system/user.py: _ Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Change wdiff back to using run_command now that we believe it to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • Fix to use Executive in places.
    • Pass self._executive down to the Driver for easier unit testing.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Re-factor to use a _kill_all method.
    • Made the _kill_all method use run_command to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/http_server.py:
    • Add FIXME about using Executive.
  • Scripts/webkitpy/layout_tests/port/server_process.py:
    • Use Executive to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Pass self._executive down to the Driver.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Add note about Popen not being threadsafe.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Move one caller to run_command add notes about moving others.
10:19 AM Changeset in webkit [58313] by Joseph Pecoraro
  • 6 edits
    4 adds in trunk

2010-04-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
​https://bugs.webkit.org/show_bug.cgi?id=38160

  • fast/css/input-search-padding.html: Added.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/mac/fast/css/input-search-padding-expected.png: Added.
  • platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
​https://bugs.webkit.org/show_bug.cgi?id=38160

Test: fast/css/input-search-padding.html

An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.

  • rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
  • rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
  • rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
9:39 AM Changeset in webkit [58312] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Restore breakpoints associated with script's URL once
script is parsed.
​https://bugs.webkit.org/show_bug.cgi?id=38132

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.restoreBreakpoints_): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.enabled): (devtools.BreakpointInfo.prototype.condition):
7:48 AM Changeset in webkit [58311] by pfeldman@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome Dev Tools: Further beautify themes.

​https://bugs.webkit.org/show_bug.cgi?id=38187

  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/devTools.css: (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
7:27 AM Changeset in webkit [58310] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

Disable thumb mode due to library size limitations, just like it's done
for the sbs/sbsv2 based build system.

  • WebCore.pro:
7:24 AM Changeset in webkit [58309] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

  • JavaScriptCore.pri: It is necessary to specify the library search path

when linking against JavaScriptCore.

6:56 AM Changeset in webkit [58308] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/JavaScriptCore

Compile fix for Visual Studio 2010
​https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Simon Hausmann.

Patch by Prasanth Ullattil <​prasanth.ullattil@nokia.com>

  • runtime/Structure.cpp:

(JSC::Structure::transitionTableAdd):

  • wtf/MathExtras.h:
  • wtf/Platform.h:
6:56 AM Changeset in webkit [58307] by jocelyn.turcotte@nokia.com
  • 9 edits in trunk/JavaScriptCore

Rename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)

Reviewed by Simon Hausmann.

  • config.h:

(JSC::Structure::transitionTableAdd):

  • wtf/Assertions.h:
  • wtf/Atomics.h:
  • wtf/CurrentTime.h:

(WTF::getLocalTime):

  • wtf/Platform.h:
  • wtf/StaticConstructors.h:
  • wtf/StringExtras.h:
  • wtf/Vector.h:

(WTF::::append):

6:55 AM Changeset in webkit [58306] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/JavaScriptCore

[Qt] Fix Mac build break.

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=37867

  • Make sure JavaScriptCore's debug_and_release config follows that of WebCore.
  • Use different name for JavaScriptCore target in debug and release since they might be written in the same path at the same time on parallel builds
  • Consolidate the DESTDIR determination logic in JavaScriptCore.pri
6:55 AM Changeset in webkit [58305] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] Make sure WebKit is not compiled using C++0x.
​https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Kenneth Rohde Christiansen.

As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.

Patch by Thiago Macieira <​thiago.macieira@nokia.com>

JavaScriptCore:

WebCore:

  • WebCore.pro:
5:56 AM Changeset in webkit [58304] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed. Previous disabling only did so via
TIMEOUT failures. Needs to ignore TEXT failures
on quota-tracking.html as well.

  • platform/chromium/test_expectations.txt:
5:05 AM Changeset in webkit [58303] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed. Disable quota-tracking in Chromium
until Dumi can take a look.

  • platform/chromium/test_expectations.txt:
4:18 AM Changeset in webkit [58302] by jorlow@chromium.org
  • 10 edits in trunk

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
​https://bugs.webkit.org/show_bug.cgi?id=38191

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
​https://bugs.webkit.org/show_bug.cgi?id=38191

Chromium bots are hitting ASSERTS when running layout tests.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::maximumSize): (WebCore::SQLiteDatabase::freeSpaceSize):
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
  • storage/Database.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit):
3:54 AM Changeset in webkit [58301] by yuzo@google.com
  • 8 edits
    2 deletes in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Removed.
  • fast/css/parsing-page-rule.html: Removed.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
2:53 AM Changeset in webkit [58300] by yuzo@google.com
  • 2 edits in trunk/WebCore

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
This results in incorrect parsing.
For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.

​https://bugs.webkit.org/show_bug.cgi?id=37787

No new tests are added because the original behavior is accidentally OK.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
2:38 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:35 AM Changeset in webkit [58299] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::lex): (WebCore::CSSParser::text): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
2:32 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:29 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:27 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:26 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:12 AM Changeset in webkit [58298] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for TreeWalker
​https://bugs.webkit.org/show_bug.cgi?id=38182

This custom code is just CallWith=ScriptState.

  • WebCore.gypi:
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::markChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
  • dom/TreeWalker.idl:
2:10 AM Changeset in webkit [58297] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
​https://bugs.webkit.org/show_bug.cgi?id=38186

Unfortunately, we don't have a good way of testing this change because
our test coverage of the scm.py API is poor...

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
1:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:02 AM Changeset in webkit [58296] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move code out of GenerateImplementation to make it more smaller
​https://bugs.webkit.org/show_bug.cgi?id=38176

  • bindings/scripts/CodeGeneratorJS.pm:
    • Move some code into a new GenerateAttributesHashTable method.
12:15 AM Changeset in webkit [58295] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add CallWith=DynamicFrame to CodeGenerator
​https://bugs.webkit.org/show_bug.cgi?id=38174

I've only used this in one instance, but this is infrastructure that I
think will help remove a bunch of custom bindings code. Also, added a
few tests of tricky argument cases.

  • bindings/js/JSHTMLFormElementCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withDynamicFrameCallback): (WebCore::TestObjInternal::withDynamicFrameAndArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): (WebCore::):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • html/HTMLFormElement.idl:

Apr 26, 2010:

11:28 PM Changeset in webkit [58294] by jam@chromium.org
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-04-26 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Prepare to making WebThemeEngine cross-platform
​https://bugs.webkit.org/show_bug.cgi?id=38077

  • WebKit.gyp:
  • public/WebThemeEngine.h: Added.
  • public/win/WebThemeEngine.h:
11:19 PM Changeset in webkit [58293] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove unused code from text_diff.py
​https://bugs.webkit.org/show_bug.cgi?id=38170

  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Remove is_render_tree_dump which appears unused.
11:10 PM Changeset in webkit [58292] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash after calling window.print() on a window object that has been closed.
​https://bugs.webkit.org/show_bug.cgi?id=38148

It is unfortunately not possible to write a layout test for this as the
crash occurs in an API that is only called by Chrome while showing a
print dialog.

  • src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
10:56 PM Changeset in webkit [58291] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch pretty-diff is broken
​https://bugs.webkit.org/show_bug.cgi?id=38172

We need to register for these options because they're used when we look
up the diff.

  • Scripts/webkitpy/tool/steps/confirmdiff.py:
10:30 PM Changeset in webkit [58290] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed. Update comment to better reflect reality.

  • bindings/scripts/test/TestObj.idl:
10:01 PM Changeset in webkit [58289] by abarth@webkit.org
  • 3 edits
    8 adds in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
​https://bugs.webkit.org/show_bug.cgi?id=38168

Added expected results.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added. (WebKit::kit): (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (WebKit::wrapTestObj): (WebKit::core): (webkit_dom_test_obj_finalize): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init): (webkit_dom_test_obj_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Added. (-[DOMTestObj dealloc]): (-[DOMTestObj finalize]): (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
​https://bugs.webkit.org/show_bug.cgi?id=38168

  • Scripts/run-bindings-tests:
9:49 PM Changeset in webkit [58288] by abarth@webkit.org
  • 4 edits
    2 moves
    4 adds in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38167

This required moving the test files around a bit more.

  • bindings/scripts/test/JS/JSTestObj.cpp: Added. (WebCore::): (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObjConstructor::classInfo): (WebCore::JSTestObjConstructor::createStructure): (WebCore::JSTestObjConstructor::getOwnPropertySlot): (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): (WebCore::JSTestObjPrototype::self): (WebCore::JSTestObjPrototype::getOwnPropertySlot): (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor): (WebCore::JSTestObj::JSTestObj): (WebCore::JSTestObj::~JSTestObj): (WebCore::JSTestObj::createPrototype): (WebCore::JSTestObj::getOwnPropertySlot): (WebCore::JSTestObj::getOwnPropertyDescriptor): (WebCore::jsTestObjReadOnlyIntAttr): (WebCore::jsTestObjReadOnlyStringAttr): (WebCore::jsTestObjReadOnlyTestObjAttr): (WebCore::jsTestObjIntAttr): (WebCore::jsTestObjStringAttr): (WebCore::jsTestObjTestObjAttr): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::jsTestObjCustomAttr): (WebCore::jsTestObjConstructor): (WebCore::JSTestObj::put): (WebCore::setJSTestObjIntAttr): (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjTestObjAttr): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::setJSTestObjCustomAttr): (WebCore::JSTestObj::getConstructor): (WebCore::jsTestObjPrototypeFunctionVoidMethod): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethod): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethod): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithException): (WebCore::jsTestObjPrototypeFunctionCustomMethod): (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::toJS): (WebCore::toTestObj):
  • bindings/scripts/test/JS/JSTestObj.h: Added. (WebCore::JSTestObj::classInfo): (WebCore::JSTestObj::createStructure): (WebCore::JSTestObj::impl): (WebCore::JSTestObjPrototype::classInfo): (WebCore::JSTestObjPrototype::createStructure): (WebCore::JSTestObjPrototype::JSTestObjPrototype):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38167

Add support for testing more than one bindings. Also, converted the
script to PEP8 style.

  • Scripts/run-bindings-tests:
9:39 PM Changeset in webkit [58287] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows

9:22 PM Changeset in webkit [58286] by oliver@apple.com
  • 21 edits
    3 adds in trunk

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
​https://bugs.webkit.org/show_bug.cgi?id=38155

The problem with calling lightweight builtins is that marshalling
the call from the nitro calling convention to the system calling
convention is very expensive relative to the cost of the actually
evaluating the function. To work around this problem this patch
adds the ability to define a custom thunk for a builtin.

This allows us to use high performance custom implementations of
the common and sensible versions of simple builtins. This patch
includes a simple (use of which is currently hardcoded) thunk for
charCodeAt.

This adds a JSInterfaceJIT subclass called SpecializedThunkJIT
that has helper functions to remove (or at least reduce) the need
to have separate thunk implementations for each JSValue encoding.

  • create_hash_table: Add thunk generation callbacks to the hash tables, currently we hardcode the script to only support charCodeAt
  • jit/JITStubCall.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::~JITThunks): (JSC::JITThunks::specializedThunk):
  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h: Added. (JSC::SpecializedThunkJIT::SpecializedThunkJIT): (JSC::SpecializedThunkJIT::loadCellArgument): (JSC::SpecializedThunkJIT::loadJSStringArgument): (JSC::SpecializedThunkJIT::loadInt32Argument): (JSC::SpecializedThunkJIT::appendFailure): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::argumentToVirtualRegister): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
  • jit/ThunkGenerators.cpp: Added. (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): (JSC::charCodeAtThunkGenerator):
  • jit/ThunkGenerators.h: Added.
  • runtime/Executable.h: (JSC::NativeExecutable::NativeExecutable):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::getThunk):
  • runtime/JSString.h: (JSC::):
  • runtime/JSValue.h: Protect some of the JSVALUE32 and JSVALUE32_64 only constants and function behind appropriate USE() guards to make it harder to use the wrong flags for the target build.
  • runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::generator): (JSC::HashEntry::): Make the lookup tables use a specialized thunkGenerator if present
  • wtf/text/StringImpl.h:

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
​https://bugs.webkit.org/show_bug.cgi?id=38155

Update bindings generation to include new thunk generator field
in the property map hash tables.

  • bindings/scripts/CodeGeneratorJS.pm:
9:21 PM Changeset in webkit [58285] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Refactor results.html generation out into a new method and test it
​https://bugs.webkit.org/show_bug.cgi?id=38164

Hopefully this results in no change in functionality.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:12 PM Changeset in webkit [58284] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix

8:45 PM Changeset in webkit [58283] by oliver@apple.com
  • 4 edits
    1 add in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Factor some basic JS interface logic out of JIT and into a superclass
​https://bugs.webkit.org/show_bug.cgi?id=38163

Create JSInterfaceJIT to hold some common low level functions for
interacting with the JS RegisterFile. Doing this separately from
​https://bugs.webkit.org/show_bug.cgi?id=38155 to ease reviewing.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
  • jit/JSInterfaceJIT.h: Added. (JSC::JSInterfaceJIT::emitLoadJSCell): (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::tagFor): (JSC::JSInterfaceJIT::payloadFor): (JSC::JSInterfaceJIT::addressFor):
8:36 PM Changeset in webkit [58282] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58265.
​http://trac.webkit.org/changeset/58265
​https://bugs.webkit.org/show_bug.cgi?id=38021

This change prevents me from uploading patches. It also breaks sheriff-bot.

  • Scripts/webkitpy/tool/steps/options.py:
8:35 PM Changeset in webkit [58281] by abarth@webkit.org
  • 3 edits
    3 moves
    1 add in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
​https://bugs.webkit.org/show_bug.cgi?id=38161

This test is really of the bindings scripts not of the bindings
themselves. By moving the files into the scripts directory, we'll be
able to test JSC as well.

  • bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
  • bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
​https://bugs.webkit.org/show_bug.cgi?id=38161

Change script to point to the new location of these data files.

  • Scripts/run-bindings-tests:
8:07 PM Changeset in webkit [58280] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
​https://bugs.webkit.org/show_bug.cgi?id=38159

No new tests.

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::setURL):
7:33 PM Changeset in webkit [58279] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=37987

Rolled out:
​http://trac.webkit.org/changeset/58062
​http://trac.webkit.org/changeset/58060
​http://trac.webkit.org/changeset/58059
​http://trac.webkit.org/changeset/58055
​http://trac.webkit.org/changeset/58054
and parts of:
​http://trac.webkit.org/changeset/58050

I also wrote some new comments and a tiny amount of new
code to help make ChromiumDriver.run_test easier to read.

In order to unit-test my new code, I had to change ChromiumDriver
to not automatically start itself when created. That ended up
being a lot of plumbing, but is hopefully easier to understand now.

There are no tests for the (restored) wdiff code. wdiff does not
exist on all systems, so for now we will assume it worked since
it is just old code being reverted.

  • Scripts/webkitpy/layout_tests/driver_test.py:
    • Use create_driver instead of start_driver, and be sure to call .stop()
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Use create_driver instead of start_driver
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Added a comment to explain that diffs are binary files.
    • Various patch reverts relating to wdiff
    • Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
    • Made _command_wrapper use shlex.split to get rid of the FIXME.
  • Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
    • test the new _command_wrapper
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Use _command_wrapper to get rid of a bunch of ugly code.
  • Make init stop auto-starting.
  • Rename create_driver to start_driver.
  • Added _write_command_and_read_line to make it possible to put a FIXME next to read_line() w/o having to put it in two places.
  • Moved test_shell command building into _test_shell_command and tested it.
  • Fix comments to say test_shell since ChromiumDriver is test_shell only.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
    • Test the new test_shell_command method.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/test.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Rename create_driver to start_driver.
    • Treat output as binary arrays.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Treat diff files as binary.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Treat diff files as binary.
7:22 PM Changeset in webkit [58278] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed. Mark run-bindings-tests executable so we can execute it.

  • Scripts/run-bindings-tests:
7:12 PM Changeset in webkit [58277] by yuzo@google.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

To keep up with the change that turned on HTML5 DB AUTO_VACUUM.
​https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/chromium-mac/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium-win/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium/storage/quota-tracking-expected.txt: Added.
6:32 PM Changeset in webkit [58276] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Don't make file paths available in text/uri-list when dragging files.
​https://bugs.webkit.org/show_bug.cgi?id=25882

Test will be checked in with WebCore/platform/mac fix.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
6:26 PM Changeset in webkit [58275] by tony@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-26 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] build-webkit --chromium should build release by default
​https://bugs.webkit.org/show_bug.cgi?id=38028

  • Scripts/build-dumprendertree: Also should build release by default
  • Scripts/build-webkit: Make sure to pass command line args through
  • Scripts/webkitdirs.pm: Build the right configuration
5:37 PM Changeset in webkit [58274] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing the build breakage introduced by r58269.

Turning on AUTO_VACUUM has increased the amount of space used by databases.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
5:09 PM Changeset in webkit [58273] by mjs@apple.com
  • 9 edits in trunk/WebCore

2010-04-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
​https://bugs.webkit.org/show_bug.cgi?id=38131

I did a number of separate optimizations which speed up style
resolution enough to more than make up for the regression. This
measures as a total PLT speedup of somewhere between 1.5% and
3.7%.


Optimizations done:

  • Cache determineLinkState results, to avoid the need to repeatedly compute the visited link hash for the same element. This directly addresses much of the slowdown, since all elements get their style computed twice now.
  • Added a fast way to get the length of a CSSMutableStyleDeclaration, and use in CSSStyleSelector::matchRulesForList, since it was hot there.
  • Hoist some loop invariant code that's not detected by the compiler out of the main loop in matchRulesForList
  • inline CSSStyleSelector::initElement and locateSharedStyle, since there is only one call site in each case
  • Inline the common non-line fast case of determineLinkState, and split the rest into out-of-line determineLinkStateSlowCase.
  • Added inline versions of the functions called by visitedLinkHash (the version called by determineLinkState).
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new inline nonvirtual mutableLength().
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual inline way to get the length if you know you have a mutable style decl.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::init): Clear cached link state. (WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main loop and get style decl length more efficiently. (WebCore::CSSStyleSelector::initElement): inline (only one call site) (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast case, call slow case. (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split most of the above function into this slow case helper. (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled way to get the current link state. (WebCore::CSSStyleSelector::locateSharedStyle): inline (WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way to get the current link state.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::currentElementLinkState): inline way to get link state for the current element; manages the cache
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline): inline version of below function (WebCore::visitedLinkHash): call the inline version (WebCore::visitedURLInline): inline version of below function (WebCore::visitedURL): call the inline version (WebCore::visitedURL): call inline versions of above two functions
4:30 PM Changeset in webkit [58272] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove last use of WEB_THREAD.

Reviewed by Alexey Proskuryakov.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread): This can always use
isMainThread().

4:10 PM Changeset in webkit [58271] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

initial commit test

3:58 PM Changeset in webkit [58270] by dumi@chromium.org
  • 7 edits in trunk/WebCore

Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, adding a guard against a bug
that was fixed in SQLite only starting with version 3.6.16.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

3:45 PM Changeset in webkit [58269] by crogers@google.com
  • 1 copy in branches/audio

creating private audio branch to implement new audio features with javascript API

3:45 PM Changeset in webkit [58268] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/mac/MainThreadMac.mm:

(WTF::isMainThread):

3:44 PM Changeset in webkit [58267] by ggaren@apple.com
  • 9 edits in trunk

<rdar://problem/7766413>

Reviewed by Sam Weinig.

Fixed a crash seen when using the JavaScriptCore API with WebKit.

No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.

JavaScriptCore:

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::setGlobalObject):
(JSC::RegisterFile::clearGlobalObject):
(JSC::RegisterFile::globalObject):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile): Use WeakGCPtr for managing m_globalObject,
since it's a weak pointer. (We never noticed this error before because,
in WebKit, global objects always have a self-reference in a global variable,
so marking the register file's global variables would keep m_globalObject
alive. In the JavaScriptCore API, you can allocate a global object with
no self-reference.)

  • runtime/JSActivation.h: Removed unneeded #include.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject): Don't use ==, since a weak
pointer is 0 when the object it points to runs its destructor.

  • runtime/WeakGCPtr.h:

(JSC::WeakGCPtr::clear): Changed to return a bool indicating whether the
clear actually happened.
(JSC::WeakGCPtr::assign): Changed to forbid assignment of 0 as a shorthand
for calling clear(). A client should never clear by assigning 0, since
clear() should be conditional on whether the object doing the clearing
is still pointed to by the weak pointer. (Otherwise, a zombie object might
clear a pointer to a new, valid object.)

WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.

3:38 PM Changeset in webkit [58266] by weinig@apple.com
  • 56 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading

Reviewed by Maciej Stachowiak.

JavaScriptCore:

This is the first step in getting rid of the WEB_THREAD #define and
paving the way to allowing mac both WebKit and WebKit2 to use the same
WebCore.

  • JavaScriptCore.exp: Export initializeMainThread and initializeMainThreadToProcessMainThread.
  • JavaScriptCore.xcodeproj/project.pbxproj: Sort files.
  • wtf/MainThread.cpp:

(WTF::mainThreadInitializationMutex):
(WTF::mainThreadFunctionQueueMutex):
(WTF::initializeMainThread):
(WTF::deprecatedInitializeMainThread):

  • wtf/MainThread.h:

Added Mac only initializeMainThreadToProcessMainThread which sets up callOnMainThread
and isMainThead calls to assume that WebCore's main thread is also the
process's main thread. Since it is possible that both initializeMainThread
and initializeMainThreadToProcessMainThread could be called, the first one called
wins (either will work).

  • wtf/Threading.h: Moved to top of file.
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::isMainThread):
Add runtime switch between the old behavior of using the system's main
thread and a stored pointer to the main thread. Tiger always uses the
system's main thread.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform): Add call to initializeCurrentThreadInternal
removed from initializeThreading.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Sort files.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary

+initialize method. The AccessibilityObjectWrapper has no data members
that need to be derefed, so it does not need to be finalized on the main
thread.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.

WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::initialize): Add call to initializeMainThread.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Ditto.

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(webkit_init): Add call to initializeMainThread.

WebKit/mac:

Calls initializeMainThreadToProcessMainThread since there is no way to ensure
that the initialize method will be called on the main thread.

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]): Ditto.

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]): Ditto.

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]): Ditto.

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]): Ditto.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]): Ditto.

  • Plugins/WebBaseNetscapePluginView.mm:

(+[WebBaseNetscapePluginView initialize]): Ditto.

  • Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]): Ditto.

  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]): Ditto.

  • WebCoreSupport/WebEditorClient.mm:

(+[WebEditCommand initialize]): Ditto.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]): Ditto.

  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSourcePrivate initialize]): Ditto.

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]): Ditto.
(+[WebHTMLView initialize]): Ditto.

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]): Ditto.

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]): Ditto.

  • WebView/WebView.mm:
  • WebView/WebViewData.mm: Ditto.

(+[WebViewPrivate initialize]): Ditto.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Add call to initializeMainThread.

WebKit/win:

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.

  • WebView.cpp:

(WebView::WebView): Ditto.

WebKit/wx:

  • WebView.cpp:

(wxWebView::Create): Add call to initializeMainThread.

WebKit2:

  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::webThreadBody): Add call to initializeMainThread.

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody): Ditto.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(main): Ditto.

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain): Ditto.

2:52 PM Changeset in webkit [58265] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

complete rietveld bugzilla integration
​https://bugs.webkit.org/show_bug.cgi?id=38021

Makes --fancy-review the default. All this means is that the patch will
be uploaded to rietveld in addition to bugs.webkit.org.

  • Scripts/webkitpy/tool/steps/options.py:
2:43 PM Changeset in webkit [58264] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=38128
Don't add empty credential to CredentialStorage.

An empty credential is currently regarded as a invalid login because it means a missing value in
protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
by ignoring empty credentials.

No new tests added since this only affects credential entered by user from credential dialog,
which is not testable in DRT.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedCredential):
2:01 PM Changeset in webkit [58263] by Chris Jerdonek
  • 3 edits
    1 move in trunk/WebKitTools

For check-webkit-style, renamed the style/processors/ directory
to style/checkers/.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=38122

  • Scripts/webkitpy/style/checker.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
  • Scripts/webkitpy/style/processors: Removed.
  • Scripts/webkitpy/style/processors/init.py: Removed.
  • Scripts/webkitpy/style/processors/common.py: Removed.
  • Scripts/webkitpy/style/processors/common_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/cpp.py: Removed.
  • Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
  • Scripts/webkitpy/style/processors/text.py: Removed.
  • Scripts/webkitpy/style/processors/text_unittest.py: Removed.
12:26 PM Changeset in webkit [58262] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
​https://bugs.webkit.org/show_bug.cgi?id=38123

HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
for QtWebKit as JavaScriptCore is built separately. These defines are only
used by JavaScriptCore and for JavaScriptCore these are already
properly defined in JavaScriptCore/config.h.

No new tests, no new functionality.

  • WebCore.pro:
10:48 AM Changeset in webkit [58261] by ojan@chromium.org
  • 26 edits in trunk/WebKitTools

2010-04-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

Include git commits in the diff for webkit-patch upload/land.
​https://bugs.webkit.org/show_bug.cgi?id=36394

Adds --squash, --no-squash and --git-commit.

--git-commit will use a specific local commit for land/upload.
If a commit-range is specified, then that range is treated as
a single squashed commit.

--squash will squash all local changes including working copy changes
into a single patch.

--no-squash is the legacy behavior (upload only considers the working copy,
land commits the working copy and then each local commit separately to SVN)

If neither is specified, then an informative error is raised if there is
more than one local commit or when there are local commit(s) and working
copy changes.

If the webkit-patch.squash git config parameter is set, then
that will be respected instead of raising an error.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/style/optparser.py: --git-since is removed and --git-commit no longer implies commit_id.. Instead, it treats that individual commit, but also supports commit ranges (e.g. commit_id..) as arguments.
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:03 AM Changeset in webkit [58260] by evan@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-26 Roman Gershman <​romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
The following manual test checks for desired behavior.

​https://bugs.webkit.org/show_bug.cgi?id=37977

  • manual-tests/chromium/suggestions-popup-font-change.html: Added.
9:56 AM Changeset in webkit [58259] by evan@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Roman Gershman <​romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

​https://bugs.webkit.org/show_bug.cgi?id=37977

  • src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::initialize):
9:21 AM Changeset in webkit [58258] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

View modes names in CSSValueKeywords.in
​https://bugs.webkit.org/show_bug.cgi?id=38125

View mode names has changed in previous patch but CSSValueKeywords.in file was
not updated.

  • css/CSSValueKeywords.in:
8:16 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:10 AM Changeset in webkit [58257] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix compilation with RVCT 4
​https://bugs.webkit.org/show_bug.cgi?id=37727

Reviewed by Kenneth Rohde Christiansen.

Swap extern and declspec to fix visibility of symbol imported from QtGui.

  • page/qt/EventHandlerQt.cpp:
7:58 AM Changeset in webkit [58256] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-04-26 Ruben Van Boxem <​vanboxem.ruben@gmail.com>

Reviewed by Adam Roben.

Fixes for Win64 compilation under gcc (mingw-w64)

  • WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
  • WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
  • WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
  • WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
  • WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
  • WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
  • WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64
7:54 AM Changeset in webkit [58255] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix the include header <qstring.h> -> <QtCore/qstring.h>

Patch by Thiago Macieira <​thiago.macieira@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

The module/header.h style inclusion removes the need to have -I$QTDIR/include/depending-module
in the include search path for the application.

  • Api/qwebkitversion.h:
7:37 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:33 AM Changeset in webkit [58254] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] HTTP pipelining efficiency increase
​https://bugs.webkit.org/show_bug.cgi?id=38062

Patch by Markus Goetz <​Markus.Goetz@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

Increase number of network requests that are fed into
QNetworkAccessManager.

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost):

6:56 AM Changeset in webkit [58253] by pfeldman@chromium.org
  • 9 edits
    5 deletes in trunk/WebKit/chromium

2010-04-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: brush up images.

​https://bugs.webkit.org/show_bug.cgi?id=38124

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentChromium2.png: Removed.
  • src/js/Images/segmentHoverChromium2.png: Removed.
  • src/js/Images/segmentSelectedChromium2.png: Removed.
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBackgroundChromium2.png: Removed.
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarButtonsChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonChromium2.png: Removed.
  • src/js/devTools.css: (.section > .header): (.console-group-messages .section > .header): (#resources-filter): (.crumbs .crumb): (.crumbs .crumb.end): (.crumbs .crumb.selected): (.crumbs .crumb.selected:hover): (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover): (.crumbs .crumb:hover): (.crumbs .crumb.dimmed:hover): (.crumbs .crumb.end:hover): (body.drawer-visible #main-status-bar): (.status-bar): (button.status-bar-item): (select.status-bar-item:active): (#drawer): (select.status-bar-item):
6:37 AM Changeset in webkit [58252] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: undefined shows up on inspector.
​https://bugs.webkit.org/show_bug.cgi?id=38120

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
6:31 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
6:01 AM Changeset in webkit [58251] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Deleted the StyleChecker-related classes that are no longer
being used.

​https://bugs.webkit.org/show_bug.cgi?id=38118

  • Scripts/webkitpy/style/checker.py:
    • Deleted the DeprecatedStyleChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Deleted the StyleCheckerTest, StyleCheckerCheckFileBase, StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
5:47 AM Changeset in webkit [58250] by eric@webkit.org
  • 4 edits in trunk

2010-04-26 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): change to root.get()

2010-04-26 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): new property variantMapProperty (MyQObject::variantMapProperty): read variantMapProperty (MyQObject::setVariantMapProperty): write variantMapProperty
5:28 AM Changeset in webkit [58249] by Chris Jerdonek
  • 6 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Changed the StyleChecker class to use the new TextFileReader class.

​https://bugs.webkit.org/show_bug.cgi?id=37066

This revision separates the code responsible for reading and iterating
over text files from the rest of check-webkit-style.

  • Scripts/check-webkit-style:
    • Changed the script to use the new StyleProcessor and TextFileReader classes instead of the StyleChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Added a FIXME to rename many of uses of the word "processor" to "checker". We did this to clarify the difference between ProcessorBase instances passed to the TextFileReader and classes that process and check lines for style.
    • Added a FIXME to remove FileType.NONE as a possible return value of ProcessorDispatcher._file_type(). This will better consolidate the logic of which files should be skipped.
    • Added a FIXME to delete the StyleChecker class.
    • Added the StyleProcessor class which implements ProcessorBase. This class is responsible for processing lines to check style (but not for reading files). For each file, this class creates creates both a carriage-return checker and a format-specific style checker (e.g. one of C++, Python, etc).
    • Updated the PatchChecker class to use a TextFileReader instance instead of a StyleChecker.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added the StyleProcessor_EndToEndTest class to do "end-to-end" tests of the StyleProcessor class.
    • Added the StyleProcessor_CodeCoverageTest to test the StyleProcessor class with more complete code coverage. Unlike the StyleProcessor_EndToEndTest class, this class makes heavy use of mock parameters.
    • Added FIXME's to delete the unit test classes that are no longer needed.
    • Updated the PatchCheckerTest class to use a MockTextFileReader instead of a MockStyleChecker.
  • Scripts/webkitpy/style/filereader.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
    • In the TextFileReaderTest class:
      • Moved the test_process_fileshould_not_process() method.
      • Added a test_process_filefile_stdin() method to test the file path "-".
5:28 AM Changeset in webkit [58248] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-26 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in the QScriptString.

QScriptStringPrivate's constructor shouldn't call JSStringRetain as
QScriptConverter implicitly pass a JSStringRef ownership.

[Qt] QScriptStringPrivate c'tor problem
​https://bugs.webkit.org/show_bug.cgi?id=38110

  • qt/api/qscriptstring_p.h: (QScriptStringPrivate::QScriptStringPrivate):
4:36 AM Changeset in webkit [58247] by pfeldman@chromium.org
  • 3 edits in trunk

2010-04-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".

​https://bugs.webkit.org/show_bug.cgi?id=38107

  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._drawSummaryGraph):
4:32 AM Changeset in webkit [58246] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix compilation against Qt 4.7

Some QtMultimedia things have been moved into QtMediaServices
​https://bugs.webkit.org/show_bug.cgi?id=38111

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::totalBytes):
4:23 AM Changeset in webkit [58245] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add expected results after r58228
​https://bugs.webkit.org/show_bug.cgi?id=38098

  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
4:01 AM Changeset in webkit [58244] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

c

3:25 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
3:23 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Triaging should now use the Triaged keyword instead of the assignee (diff)
3:07 AM QtWebKitJournal edited by Simon Hausmann
(diff)
3:05 AM Changeset in webkit [58243] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Dirk Schulze.

Call setStrokeStyle in applyStrokeStyleToContext
​https://bugs.webkit.org/show_bug.cgi?id=37849

Not all platforms set the stroke style to solid if they
get an empty line dash array. Some just ignore the operation.

  • rendering/SVGRenderSupport.cpp: (WebCore::applyStrokeStyleToContext):
2:35 AM Changeset in webkit [58242] by loislo@chromium.org
  • 5 edits in trunk/WebCore

2010-04-23 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Aggregated stats of time spent in children records should be visible
in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
​https://bugs.webkit.org/show_bug.cgi?id=37820

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._showPopover): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
  • inspector/front-end/inspector.css: (.timeline-graph-bar.with-children): (.timeline-graph-bar.cpu): (.timeline-aggregated-category): (.timeline-loading): (.timeline-scripting): (.timeline-rendering): (.popover .timeline-aggregated-category.timeline-loading): (.timeline-details-title):
1:23 AM Changeset in webkit [58241] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-26 Tony Chang <​tony@chromium.org>

Not reviewed, removing duplicate expectations.

[chromium] Check and rebaseline SVG test expectations for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [58240] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

Unreviewed. Roll out r58237 and r58238 because of Chromium/Linux build break.

1:21 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:21 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:19 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:11 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:02 AM Changeset in webkit [58239] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

Change SVG test expectations for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
1:01 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:56 AM Changeset in webkit [58238] by tkent@chromium.org
  • 1 edit in trunk/WebKit/chromium/DEPS

Unreviewd. Chromium build fix for r58237.

  • DEPS: Add third_party/mesa
12:33 AM Changeset in webkit [58237] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-26 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
​https://bugs.webkit.org/show_bug.cgi?id=38103

  • Bump the Chromium revision to r45515 to have GYP r818, which fixes a Windows project generation bug.
  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • DEPS:
  • gyp_webkit:
12:07 AM Changeset in webkit [58236] by tkent@chromium.org
  • 10 edits
    4 adds in trunk

2010-04-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs.
​https://bugs.webkit.org/show_bug.cgi?id=18282

Add a test for deeply nested <span> elements like block-nesting-cap.html.

  • fast/parser/element-nesting-cap-expected.txt: Added.
  • fast/parser/element-nesting-cap.html: Added.
  • fast/parser/script-tests/element-nesting-cap.js: Added.

2010-04-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs
​https://bugs.webkit.org/show_bug.cgi?id=18282

The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
TreeDepthLimit.h. This is performance-efficient, but does not work for
DOM operations such as Node.appendChild().

Test: fast/parser/element-nesting-cap.html

  • dom/Node.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TreeDepthLimit.h: Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
  • dom/XMLTokenizer.cpp: Use maxDOMTreeDepth. (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp: Introduce m_treeDepth, which counts the depth of the tree. Unlike m_blocksInStack, it contains the number of non-block nodes. (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::reset): (WebCore::HTMLParser::limitDepth): Renamed from limitBlockDepth. Add check for m_nodeDepth. (WebCore::HTMLParser::insertNodeAfterLimitDepth): Renamed from insertNodeAfterLimitBlockDepth. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::freeBlock):
  • html/HTMLParser.h:

Apr 25, 2010:

11:49 PM Changeset in webkit [58235] by yuzo@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

Rebaseline test expectation for Chromium.
The following tests pass for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=38083

  • platform/chromium/fast/js/ToNumber-expected.txt: Added.
  • platform/chromium/fast/js/parseFloat-expected.txt: Added.
11:45 PM Changeset in webkit [58234] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-25 Tony Chang <​tony@chromium.org>

Not reviewed, trying to get the chromium bots green.
Adding image diffs to pixel tests.

REGRESSION(r58191): Caret moved a pixel, pixel tests failing
​https://bugs.webkit.org/show_bug.cgi?id=38104

  • platform/chromium/test_expectations.txt:
11:12 PM Changeset in webkit [58233] by tony@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-04-25 Tony Chang <​tony@chromium.org>

Not reviewed, trying to get the chromium bots
green.

​https://bugs.webkit.org/show_bug.cgi?id=38099
Rebaseline a new test and add another new test to the
expected fail list on windows and linux.

  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:56 PM Changeset in webkit [58232] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

editing/inserting/caret-position.html is expected to fail for Chromium.
This is because TextInputController::firstRectForCharacterRange is unimplemented for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=38100

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [58231] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Update focus handling code to match current approaches used by other platforms,
and fix focus handling for corner cases such as when a mouse down pops up a dialog.

​https://bugs.webkit.org/show_bug.cgi?id=38086

9:16 AM Changeset in webkit [58230] by hamaji@chromium.org
  • 2 edits in trunk/WebKit/qt

2010-04-25 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
​https://bugs.webkit.org/show_bug.cgi?id=34573

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::counterValueForElementById):
8:46 AM Changeset in webkit [58229] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Adam Barth.

Added tests for pages event handlers being called with
page context when an event is dispatched from an isolated
world.
​https://bugs.webkit.org/show_bug.cgi?id=37947

  • http/tests/security/isolatedWorld/dispatchEvent-expected.txt: Added.
  • http/tests/security/isolatedWorld/dispatchEvent.html: Added.

2010-04-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Adam Barth.

Get context properly when event handler was created on
the main world.
​https://bugs.webkit.org/show_bug.cgi?id=37947

Test: http/tests/security/isolatedWorld/dispatchEvent.html

  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
6:52 AM Changeset in webkit [58228] by eric@webkit.org
  • 15 edits
    5 adds in trunk

2010-04-25 yael aharon <​yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
​https://bugs.webkit.org/show_bug.cgi?id=37901

Added a test for changing the -webkit-appearance statically and dynamically.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLProgressElement: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-04-25 yael aharon <​yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
​https://bugs.webkit.org/show_bug.cgi?id=37901

Added a new pseudo element to represent the value portion of the progress element.
Web developers can style this pseudo element separate from the rest of the progress element.

Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:
  • rendering/RenderProgress.cpp: (WebCore::ProgressValueElement::isShadowNode): (WebCore::ProgressValueElement::shadowParentNode): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::layout): (WebCore::RenderProgress::styleDidChange): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::updateValuePartState): (WebCore::RenderProgress::createStyleForValuePart): (WebCore::RenderProgress::updateAnimationState):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
4:37 AM Changeset in webkit [58227] by eric@webkit.org
  • 3 edits in trunk/WebKit/win

2010-04-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector client shouldn't check if it can be opened
docked if it is already in that state.

​https://bugs.webkit.org/show_bug.cgi?id=37946

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:

Apr 24, 2010:

11:44 PM Changeset in webkit [58226] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Sam Weinig.

Typo in Geolocation code causes crashes when updates are stopped
​https://bugs.webkit.org/show_bug.cgi?id=38089
<rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
10:06 PM Changeset in webkit [58225] by Darin Adler
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix log message.

10:00 PM Changeset in webkit [58224] by Darin Adler
  • 4 edits
    6 adds in trunk

2010-04-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
​https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

Tests: fast/js/ToNumber.html

fast/js/parseFloat.html

  • runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt): Added a FIXME comment about a problem I noticed. (JSC::parseFloat): Added a FIXME comment about a problem I noticed; covered by test cases in the test I added.
  • runtime/UString.cpp: (JSC::UString::toDouble): Added FIXME comments about two problem I noticed; covered by test cases in the tests I added. Added a return statement so we don't crash when illegal UTF-16 sequences are present.

2010-04-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
​https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

  • fast/js/parseFloat-expected.txt: Added.
  • fast/js/parseFloat.html: Added.
  • fast/js/script-tests/parseFloat.js: Added.
  • fast/js/ToNumber-expected.txt: Added.
  • fast/js/ToNumber.html: Added.
  • fast/js/script-tests/ToNumber.js: Added.
5:47 PM Changeset in webkit [58223] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add platform-specific results for Mac after r58222.

  • platform/mac/compositing/iframes: Added.
  • platform/mac/compositing/iframes/composited-iframe-expected.txt: Added.
4:59 PM Changeset in webkit [58222] by mitz@apple.com
  • 2 edits in trunk/WebCore

Don't propagate compositing out of iframes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=38072

Patch by Simon Fraser <Simon Fraser> on 2010-04-24
Reviewed by Dan Bernstein.

Propagating compositing out of iframes caused too many regressions on Mac,
so only do it for other platforms that may need to hook compositing layers
together across iframe boundaries.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):

2:54 PM Changeset in webkit [58221] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
​https://bugs.webkit.org/show_bug.cgi?id=38085

Reviewed by Darin Adler.

WebView was calling -_webView in a few places where it should have just used itself. It never
makes sense for WebView to call -_webView on itself, and these calls look like they were copied
from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
useful meaning.

  • WebView/WebView.mm:

(-[WebView drawSingleRect:]): Replaced [self _webView] with self.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
with _private->preferences.
(-[WebView _canShowMIMEType:]): Ditto.

10:53 AM Changeset in webkit [58220] by eric@webkit.org
  • 5 edits in trunk

2010-04-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

  • wtf/RefPtr.h: expose hash table deleted value

2010-04-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value (WTF::):
9:40 AM Changeset in webkit [58219] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

protocolHostAndPortEquals host check makes a wrong assumption
​https://bugs.webkit.org/show_bug.cgi?id=37777

Reviewed by Alexey Proskuryakov.

WebCore:

The host check assumed that both host started at the same position. This is true
if both URL are the same but sometimes one has credential and the other does not.
In this case, the method would compare invalid positions.

Test: http/tests/appcache/credential-url.html

  • platform/KURL.cpp:

(WebCore::protocolHostAndPortAreEqual):

  • platform/KURLGoogle.cpp:

(WebCore::protocolHostAndPortAreEqual):
Fix the host check to take both URL's credential into account.

LayoutTests:

Add a check that the URL with credential matches the current URL.

  • http/tests/appcache/credential-url-expected.txt: Added.
  • http/tests/appcache/credential-url.html: Added.
7:43 AM Changeset in webkit [58218] by robert@webkit.org
  • 10 edits
    3 adds in trunk

[Qt] Add more support for textInputController

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • platform/qt/Skipped:

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText): (TextInputController::insertText): (TextInputController::selectedRange): (TextInputController::firstRectForCharacterRange):
  • DumpRenderTree/qt/TextInputControllerQt.h:

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::selectedRange): (DumpRenderTreeSupportQt::firstRectForCharacterRange):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
6:48 AM Changeset in webkit [58217] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.


Attempt to turn the last core builder green again (not related anymore to my previous SVG checkins :-)
Skip http/tests/media/video-play-stall-seek.html on Windows as well (just like it has been done for Mac in r58107).
Bug ​https://bugs.webkit.org/show_bug.cgi?id=38000 describes the problem, and says it's ok to skip the test.

  • platform/win/Skipped:
6:37 AM Changeset in webkit [58216] by Nikolas Zimmermann
  • 1 edit
    10 adds in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add new results for all SVG tests that were missing on Gtk/Qt (since a while, just took the opportunity to add them now)

  • platform/gtk/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/qt/svg/filters/filter-clip-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
6:01 AM Changeset in webkit [58215] by Nikolas Zimmermann
  • 13 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update Qt SVG results, and a weird fast/xpath change (newline added).

  • fast/xpath/namespace-vs-predicate-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
5:47 AM Changeset in webkit [58214] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)

  • rendering/SVGRenderSupport.cpp:
5:35 AM Changeset in webkit [58213] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
4:42 AM Changeset in webkit [58212] by Nikolas Zimmermann
  • 192 edits
    1 add
    3 deletes in trunk

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
​https://bugs.webkit.org/show_bug.cgi?id=37986

Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
the finish of the SVGResource -> RenderSVGResource transition.

Outline of same key changes:

  • RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name. The reason for that is consistency with all other painting resources.
  • RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
  • RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading to much faster speed.
  • SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.
  • Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference. (WebCore::Gradient::addColorStop):
  • platform/graphics/Gradient.h: Ditto.
  • platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource (WebCore::TextRun::TextRun): (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer. (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
  • platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGGradientStop): Added. (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
  • rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer. (WebCore::RenderPath::fillContains): Adapt to new concept. (WebCore::RenderPath::strokeContains): Ditto. (WebCore::fillAndStrokePath): Ditto. (WebCore::RenderPath::paint): Ditto.
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
  • rendering/RenderSVGGradientStop.h: Fixed indention.
  • rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability. (WebCore::registerPendingResource): (WebCore::adjustColorForPseudoRules): (WebCore::RenderSVGResource::fillPaintingResource): (WebCore::RenderSVGResource::strokePaintingResource): (WebCore::RenderSVGResource::sharedSolidPaintingResource): (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
  • rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource. (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::isSVGResourceContainer): (WebCore::RenderSVGResourceContainer::drawsContents): (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer): (WebCore::getRenderSVGResourceContainerById): (WebCore::getRenderSVGResourceById):
  • rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored. (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::invalidateClients): (WebCore::RenderSVGResourceGradient::invalidateClient): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored. (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::renderName): (WebCore::RenderSVGResourceLinearGradient::resourceType):
  • rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::invalidateClient):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClient): (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h: (WebCore::MaskerData::MaskerData):
  • rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored. (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::invalidateClients): (WebCore::RenderSVGResourcePattern::invalidateClient): (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::RenderSVGResourcePattern::postApplyResource): (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow): (WebCore::RenderSVGResourcePattern::createTileImage): (WebCore::RenderSVGResourcePattern::buildPattern):
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::renderName): (WebCore::RenderSVGResourcePattern::resourceBoundingBox): (WebCore::RenderSVGResourcePattern::resourceType):
  • rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored. (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::renderName): (WebCore::RenderSVGResourceRadialGradient::resourceType):
  • rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored. (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::applyResource): (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::invalidateClients): (WebCore::RenderSVGResourceSolidColor::invalidateClient): (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox): (WebCore::RenderSVGResourceSolidColor::resourceType): (WebCore::RenderSVGResourceSolidColor::color): (WebCore::RenderSVGResourceSolidColor::setColor):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
  • rendering/RenderTreeAsText.cpp: (WebCore::write): Add RenderSVGGradientStop dumping. (WebCore::externalRepresentation): Remove SVGResource dumping.
  • rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
  • rendering/SVGInlineTextBox.h: Ditto. (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
  • rendering/SVGRenderSupport.cpp: Ditto. (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::invalidatePaintingResource): (WebCore::deregisterFromResources): (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer. (WebCore::applyStrokeStyleToContext): Ditto.
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well! (WebCore::operator<<): (WebCore::writeSVGPaintingResource): (WebCore::writeStyle): (WebCore::boundingBoxModeString): (WebCore::writeCommonGradientProperties): (WebCore::writeSVGResourceContainer): (WebCore::writeSVGGradientStop):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer): (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer): (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): (WebCore::SVGRootInlineBoxPaintWalker::setupFill): (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource): (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
  • svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup. (WebCore::GradientAttributes::stops): (WebCore::GradientAttributes::setStops):
  • svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/PatternAttributes.h: Add missing includes and class forwards.
  • svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGClipPathElement.h:
  • svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer. (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById): (WebCore::SVGDocumentExtensions::addPendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now. (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
  • svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
  • svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::Font::drawTextUsingSVGFont):
  • svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.) (WebCore::SVGGElement::createRenderer):
  • svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary. (WebCore::SVGGElement::rendererIsNeeded): Always return true.
  • svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code. (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGGradientElement::buildStops):
  • svg/SVGGradientElement.h:
  • svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code. (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::createRenderer): (WebCore::SVGLinearGradientElement::collectGradientProperties): (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle):
  • svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGPatternElement::createRenderer):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
  • svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code. (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::createRenderer): (WebCore::SVGRadialGradientElement::collectGradientProperties): (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs. (WebCore::SVGStopElement::parseMappedAttribute): (WebCore::SVGStopElement::stopColorIncludingOpacity):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing. (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting. (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources() (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
  • svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
  • svg/SVGTextPathElement.h:
  • svg/graphics/SVGPaintServer.h: Removed.
  • svg/graphics/SVGResource.cpp: Removed.
  • svg/graphics/SVGResource.h: Removed.

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
​https://bugs.webkit.org/show_bug.cgi?id=37986

Rebaseline SVG tests, after the RenderSVGResource transition.

NOTE: This WILL affect _any_ platform with custom svg results for tests using gradients/patterns.

That means I have to wait for the bot results, and update them ASAP. Therefore landing out
of california business hours and on the weekend - please stay tuned I'll fix any breakages soon.
(Except for chromium whose test results are not available on build.webkit.org, sorry.)

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/fill-fallback-expected.txt:
  • platform/mac/svg/custom/gradient-add-stops-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/group-opacity-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/mac/svg/custom/js-update-gradient-expected.checksum:
  • platform/mac/svg/custom/js-update-gradient-expected.png:
  • platform/mac/svg/custom/js-update-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-child-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-expected.txt:
  • platform/mac/svg/custom/js-update-stop-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/pattern-in-defs-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/mac/svg/custom/pattern-with-transformation-expected.txt:
  • platform/mac/svg/custom/pattern-y-offset-expected.txt:
  • platform/mac/svg/custom/resource-client-removal-expected.txt:
  • platform/mac/svg/custom/stroke-fallback-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/hixie/error/003-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/text/selection-background-color-expected.txt:
  • platform/mac/svg/text/selection-styles-expected.txt:
  • platform/mac/svg/text/text-gradient-positioning-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
3:29 AM Changeset in webkit [58211] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add win specific result for svg/custom/broken-internal-references.svg
It's a bad idea that textPath dumps FLT_MAX when it's not shown - that should be fixed, but it's not related to Moritas testcase.

  • platform/win/svg/custom/broken-internal-references-expected.txt: Added.
12:03 AM Changeset in webkit [58210] by eric@webkit.org
  • 9 edits
    1 copy in trunk/WebKitTools

2010-04-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

check-webkit-style complains about non-utf8 data in layout test result
​https://bugs.webkit.org/show_bug.cgi?id=38027

The problem was we were assuming patch files/diff output as utf-8.
Turns out they're not. We have to treat them as binary data because
a single patch may have multiple text files in it with conflicting encodings!

  • Scripts/webkitpy/common/checkout/api.py:
    • contents_at_revision returns a byte array, so decode it to unicode before passing it to parse_latest_entry_from_file
  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Update our mock mock_contents_at_revision to match the encoding semantics of the real one.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Be careful not to decode output which may contain file contents (like diff, cat or show) as the encoding for that content is unknown.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Update our tests to use both latin1 and utf-8 encoded data.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • _fill_attachment_form should not assume unicode data. Callers may wish to attach other types of files to bugs.
  • Scripts/webkitpy/common/prettypatch.py:
    • Diffs are byte arrays, deal with them as such.
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test to make sure we handle diffs with multiple conflicting encodings.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Make sure that our unicode support does not break our byte array input support for run_command.

Apr 23, 2010:

10:17 PM Changeset in webkit [58209] by eric@webkit.org
  • 5 edits in trunk

2010-04-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D: make the method const.
​https://bugs.webkit.org/show_bug.cgi?id=37872

  • platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):

2010-04-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D: make the method const.
​https://bugs.webkit.org/show_bug.cgi?id=37872

  • src/GraphicsContext3D.cpp: Make isGLES2Compliant() const. (WebCore::GraphicsContext3DInternal::isGLES2Compliant): (WebCore::GraphicsContext3D::isGLES2Compliant):
8:36 PM Changeset in webkit [58208] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-23 Ben Murdoch <​benm@google.com>

Reviewed by Jeremy Orlow.

[Android] The touchmove delta used in basic-single-touch-events.html is too small for Android
​https://bugs.webkit.org/show_bug.cgi?id=38056

  • fast/events/touch/basic-single-touch-events-expected.txt:
    • update the test expected output
  • fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouch): update test expectation with new coordinates. (singleTouchSequence): increase the touch move delta. (touchTargets): Start the touch at a different point to

singleTouchSequence to make examining behavior easier.

8:27 PM Changeset in webkit [58207] by eric@webkit.org
  • 3 edits
    1 delete in trunk

2010-04-23 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
​https://bugs.webkit.org/show_bug.cgi?id=37276

pointInPath.html passed because the expected.txt expect it fail, it is wrong.

  • platform/qt/fast/canvas/pointInPath-expected.txt: Removed.

2010-04-23 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
​https://bugs.webkit.org/show_bug.cgi?id=37276

QPainterPath::contains doesn't count the point on the bound.

  • platform/graphics/qt/PathQt.cpp: (WebCore::isPointOnPathBorder): (WebCore::Path::contains):
6:07 PM Changeset in webkit [58206] by weinig@apple.com
  • 9 edits
    3 copies
    9 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h

Reviewed by David Levin.

JavaScriptCore:

Move bits for of Threading.h into 3 new files.

  • Atomics.h for atomic operations.
  • ThreadSafeShared.h for the ThreadSafeShared class.
  • ThreadingPrimitives.h for the primitives and platform types.

Basic threading operations (creation, etc.) remain in Threading.h.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Atomics.h: Copied from wtf/Threading.h.
  • wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
  • wtf/Threading.h:
  • wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.

JavaScriptGlue:

Add necessary forwarding headers.

  • ForwardingHeaders/wtf/Atomics.h: Added.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebCore:

Add necessary forwarding headers.

  • ForwardingHeaders/wtf/Atomics.h: Added.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebKitTools:

Add necessary forwarding headers.

  • DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
6:05 PM Changeset in webkit [58205] by eric@webkit.org
  • 4 edits
    1 add in trunk

2010-04-23 Rafael Weinstein <​rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a vector of additionalFeatures to WindowFeatures
and populates it with any feature strings that evaluate to "yes"
and aren't directly observed in WindowFeatures. This allows
clients to capture experimental window features.

​https://bugs.webkit.org/show_bug.cgi?id=38013

  • page/WindowFeatures.cpp: (WebCore::WindowFeatures::setWindowFeature):
  • page/WindowFeatures.h:

2010-04-23 Rafael Weinstein <​rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a WebWindowFeatures binding struct for the
chromium client in anticipation of a follow-on patch which will
pass it to WebViewClient::createWindow.

​https://bugs.webkit.org/show_bug.cgi?id=38013

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h: Added. (WebKit::WebWindowFeatures::WebWindowFeatures):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
5:54 PM Changeset in webkit [58204] by xji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-23 Xiaomei Ji <​xji@chromium.org>

No need to review.

Add xji as committer.

  • Scripts/webkitpy/common/config/committers.py:
5:48 PM Changeset in webkit [58203] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-04-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
​https://bugs.webkit.org/show_bug.cgi?id=38066

When a layer goes into compositing mode because it has a negative z-index child that is going
into compositing mode, then set willBeComposited to true. Also add another assertion to catch
any other cases where the state of willBeComposited is mismanaged.

Test: compositing/composited-negative-zindex-child.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
5:48 PM Changeset in webkit [58202] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-04-23 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

<rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint

When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
NPPrint with a GWorldPtr, since Flash prefers the CGContext path.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
5:16 PM Changeset in webkit [58201] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7898436> :after content is duplicated

Reviewed by Simon Fraser.

WebCore:

Test: fast/css-generated-content/after-duplicated-after-split.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.

LayoutTests:

  • fast/css-generated-content/after-duplicated-after-split.html: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
5:12 PM Changeset in webkit [58200] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix, add platform stub for new LayoutTestController method.

5:02 PM Changeset in webkit [58199] by weinig@apple.com
  • 5 edits
    1 copy
    5 moves
    1 delete in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=38065
Merge mac and win DrawingAreaProxyUpdateChunk implementations.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):

  • UIProcess/DrawingAreaProxy.cpp: Copied from UIProcess/mac/DrawingAreaProxy.mm.
  • UIProcess/DrawingAreaProxy.h: Copied from UIProcess/mac/DrawingAreaProxy.h.
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.

(WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk):
(WebKit::DrawingAreaProxyUpdateChunk::paint):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::update):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):

  • UIProcess/DrawingAreaProxyUpdateChunk.h: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.h.
  • UIProcess/mac/DrawingAreaProxy.h: Removed.
  • UIProcess/mac/DrawingAreaProxy.mm: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.

(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • UIProcess/win/DrawingAreaProxy.cpp: Removed.
  • UIProcess/win/DrawingAreaProxy.h: Removed.
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: Copied from UIProcess/win/DrawingAreaProxy.cpp.

(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::onPaintEvent):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
4:50 PM Changeset in webkit [58198] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by Eric Seidel

QT does not support textInputController.firstRectForCharacterRange(),
so, skip editing/inserting/caret-position.html for QT.
​https://bugs.webkit.org/show_bug.cgi?id=25319

  • platform/qt/Skipped:
4:21 PM Changeset in webkit [58197] by adele@apple.com
  • 2 edits in trunk/WebCore

Fixing the Tiger build for real.

  • platform/graphics/mac/SimpleFontDataMac.mm:
4:08 PM Changeset in webkit [58196] by adele@apple.com
  • 2 edits in trunk/WebCore

Fixing the Tiger build.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

3:31 PM Changeset in webkit [58195] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-23 MORITA Hajime <​morrita@google.com>

Not reviewed. Added missing expectation files for
​https://bugs.webkit.org/show_bug.cgi?id=37187

  • platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.png: Added.
3:20 PM Changeset in webkit [58194] by jianli@chromium.org
  • 13 edits
    2 adds in trunk/WebCore

Add FileError for File API.
​https://bugs.webkit.org/show_bug.cgi?id=37840

Reviewed by Dmitry Titov.

The test will be added when implementing FileReader and FilerWriter.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionCode.h:

(WebCore::):

  • html/FileError.h: Added.
  • html/FileError.idl: Added.
  • page/DOMWindow.idl:
3:20 PM Changeset in webkit [58193] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Improve code generator scripts to handle OR ('|') condition in the
extended attributes.
​https://bugs.webkit.org/show_bug.cgi?id=37998

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLStructure.pm:
3:16 PM Changeset in webkit [58192] by adele@apple.com
  • 21 edits
    1 delete in trunk/WebCore

Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
​https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Dan Bernstein.

This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
a FloatRect for the glyph bounds unless we need to.

Covered by existing tests. This should not cause any change in functionality.

Updated for removal of GlyphMetricsMap.cpp

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.

  • platform/graphics/GlyphMetricsMap.cpp: Removed.
  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::::unknownMetrics):
(WebCore::::locatePageSlowCase):

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Call boundsForGlyph instead of metricsForGlyph.

  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):

ditto.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):

Call setMetricsForGlyph for both glyph maps.

Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.

  • platform/graphics/SimpleFontData.h:

(WebCore::):
(WebCore::SimpleFontData::boundsForGlyph):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/cairo/SimpleFontDataCairo.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/gtk/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):

  • platform/graphics/wince/SimpleFontDataWince.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

3:07 PM Changeset in webkit [58191] by xji@chromium.org
  • 4 edits
    2 adds in trunk

2010-04-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein and Darin Adler

Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
​https://bugs.webkit.org/show_bug.cgi?id=25319

Test: editing/inserting/caret-position.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

2010-04-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein and Darin Adler

Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
​https://bugs.webkit.org/show_bug.cgi?id=25319

  • editing/inserting/caret-position-expected.txt: Added.
  • editing/inserting/caret-position.html: Added.
  • platform/mac/editing/input/caret-primary-bidi-expected.txt:
3:02 PM Changeset in webkit [58190] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Performance] GraphicsLayer: constructing the layers takes too long
​https://bugs.webkit.org/show_bug.cgi?id=36365

The issue came from using QGraphicsView's cache as is. The problem is that
several code-paths require re-rendering of the item, but not re-rendering
of the web content into the cache.

The way to solve it is by having GraphicsLayerQt manage the cache directly
via QPixmapCache, instead of using QGraphicsItem cache modes.

FPS measurement shows significant improvement (20FPS before, 40FPS after)
on several use-cases, including blog-files/leaves on a desktop environment.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
2:58 PM Changeset in webkit [58189] by weinig@apple.com
  • 5 edits
    1 copy
    3 moves
    1 delete in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38059
Merge mac and win DrawingAreaUpdateChunk implementation.

Reviewed by Anders Carlsson.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.

(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/DrawingAreaUpdateChunk.h: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Removed.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Removed.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunkMac.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Removed.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Removed.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp: Copied from WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp.

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • win/WebKit2.vcproj:
2:13 PM Changeset in webkit [58188] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-04-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid marking symbols as dllexport in chromium win builds
​https://bugs.webkit.org/show_bug.cgi?id=38058

No new tests.

  • config.h:
1:39 PM Changeset in webkit [58187] by morrita@google.com
  • 6 edits
    2 adds in trunk

2010-04-23 MORITA Hajime <​morrita@google.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">

getTarget() did return url parameter as is if doesn't have
fragment identifier. So fixed to return empty string in such case
because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".


Test: svg/custom/broken-internal-references.svg

  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):

2010-04-23 MORITA Hajime <​morrita@google.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">

  • platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.png: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.txt: Added.
  • svg/custom/broken-internal-references.svg: Added.
  • svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt:
  • svg/dynamic-updates/script-tests/SVGTRefElement-dom-href-attr.js: (executeTest): Updated to follow this fix. href value should be an URL, not an id.
1:22 PM Changeset in webkit [58186] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-04-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
​https://bugs.webkit.org/show_bug.cgi?id=37955

After r37484, animation and transition end events were fired on a timer, after the animation/transition
ended. This opened up one event loop cycle in which the non-animating state of the element was visible
before the event fired, resulting in flashes in content that reset style from the event handler.

Fix by firing these events in the same event cycle as the animation end, once all animations
have been updated. This also required moving the place that start animations are fixed until
a later state in the state machine, so that animations have their start time set at the point
the event is fired (to avoid an assertion when using the freeze API in DRT).

Not testable, since the flash is very transitory and cannot be captured in a pixel test.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state where the start time is known.
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle() method. (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in updateStyleIfNeededDispatcherFired(). (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've processed all animations.
1:22 PM Changeset in webkit [58185] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-04-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
​https://bugs.webkit.org/show_bug.cgi?id=38017

Check to see if the animation name is "none", and don't fire off a keyframe animation in
that case.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
1:10 PM Changeset in webkit [58184] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::didUpdate):

12:43 PM Changeset in webkit [58183] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: add a "--retry-failures" flag and a
"--no-retry-failures" flag (the former is the default). Also, rename
"--print-unexpected-results" and "--retry-unexpected-results" to
"--print-last-failures" and "--retry-last-failures" because the
retry flag was confusing. The new flag names aren't great, but
hopefully they're less confusing.

​https://bugs.webkit.org/show_bug.cgi?id=37838

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:35 PM Changeset in webkit [58182] by agl@chromium.org
  • 45 edits in trunk/LayoutTests

2010-04-23 Adam Langley <​agl@chromium.org>

Unreviewed, expectations update.

Merging Skia r526 lead to a number of pixels changing color by 1 in
layout tests. This is the rebaseline for Windows and Linux. (Mac isn't
using Skia for this.)

  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.checksum:
  • platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.png:
  • platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.checksum:
  • platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.png:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.checksum:
  • platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.png:
  • platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.checksum:
  • platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4803-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4803-expected.png:
12:11 PM Changeset in webkit [58181] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Qt build.

  • wtf/qt/MainThreadQt.cpp: #include <QThread>
12:01 PM Changeset in webkit [58180] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix build.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

11:59 AM Changeset in webkit [58179] by weinig@apple.com
  • 13 edits
    2 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38022
Move isMainThread predicate function to MainThread.h

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF::isMainThread):

  • wtf/MainThread.h:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):

  • wtf/qt/MainThreadQt.cpp:

(WTF::isMainThread):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

  • wtf/text/AtomicString.cpp:

JavaScriptGlue:

Added forwarding header for MainThread.h

  • ForwardingHeaders/wtf/MainThread.h: Added.

WebKitTools:

Added forwarding header for MainThread.h

  • DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
11:31 AM Changeset in webkit [58178] by eric@webkit.org
  • 4 edits in trunk

2010-04-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Netscape plugin support for minimal configuration
​https://bugs.webkit.org/show_bug.cgi?id=38026

No new tests, as there is no new functionality.

  • WebCore.pri:

2010-04-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Netscape plugin support for minimal configuration
​https://bugs.webkit.org/show_bug.cgi?id=38026

Pass the minimal configuration option to Qt build system
as part of the CONFIG variable.

  • Scripts/build-webkit:
10:33 AM Changeset in webkit [58177] by hamaji@chromium.org
  • 21 edits in trunk/WebCore

2010-04-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Need borderAndPadding(Width|Height)
​https://bugs.webkit.org/show_bug.cgi?id=38046

Refactoring only, so no new tests.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::borderAndPaddingHeight): (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::calcPrefWidths):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcPrefWidths): (WebCore::RenderListBox::calcHeight):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths): (WebCore::RenderSlider::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
10:18 AM Changeset in webkit [58176] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Size mismatch between format string and argument in dumpTextEncodingNameMap()

Reviewed by Darin Adler.

See Bug 38030 and r58157.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::dumpTextEncodingNameMap): Assigned
textEncodingNameMap->size() to an unsigned variable before using
it in the fprintf() statement.

10:00 AM Changeset in webkit [58175] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168

  • DerivedSources.cpp: Changed include of JSMedia.cpp to

JSStyleMedia.cpp.

9:47 AM Changeset in webkit [58174] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX: Fix Mac build after Bug 36187 landed in r58168

  • WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,

DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
DOMStyleMedia.mm, DOMStyleMediaInternal.h.

9:33 AM Changeset in webkit [58173] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix.

Change Media to StyleMedia

  • DerivedSources.make:
9:28 AM Changeset in webkit [58172] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
9:24 AM Changeset in webkit [58171] by kenneth@webkit.org
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

9:15 AM Changeset in webkit [58170] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

  • fast/dom/Window/window-properties-expected.txt:
9:08 AM Changeset in webkit [58169] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Xan Lopez <​xlopez@igalia.com>

Try to fix the GTK+ bots.

  • GNUmakefile.am:
8:42 AM Changeset in webkit [58168] by kenneth@webkit.org
  • 15 edits
    3 moves in trunk

WebCore: Rename window.media to window.styleMedia
​https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Laszlo Gombos.

Rename the interface Media to StyleMedia as required by the
new CSSOM View spec.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/Media.cpp: Removed.
  • css/Media.h: Removed.
  • css/Media.idl: Removed.
  • css/StyleMedia.cpp: Added.

(WebCore::StyleMedia::StyleMedia):
(WebCore::StyleMedia::type):
(WebCore::StyleMedia::matchMedium):

  • css/StyleMedia.h: Added.

(WebCore::StyleMedia::create):
(WebCore::StyleMedia::disconnectFrame):

  • css/StyleMedia.idl: Added.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::styleMedia):

  • page/DOMWindow.h:

(WebCore::DOMWindow::optionalMedia):

  • page/DOMWindow.idl:

LayoutTests: Updated test results as the interface Media was renamed
to StyleMedia.

Reviewed by NOBODY (OOPS!).

  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
8:38 AM Changeset in webkit [58167] by eric@webkit.org
  • 7 edits in trunk/JavaScriptCore

2010-04-23 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Laszlo Gombos.

Add RVCT support for Linux

Developed in cooperation with Gabor Loki.

  • API/JSStringRef.h:
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JITStubs.cpp:
  • wtf/MathExtras.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
8:02 AM Changeset in webkit [58166] by yurys@chromium.org
  • 6 edits in trunk/WebCore

2010-04-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide JSC implementation for scopeType method on
call frame and use same jsvascript code for JSC and v8 when collecting
scope chain data.

​https://bugs.webkit.org/show_bug.cgi?id=37663

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
7:59 AM Changeset in webkit [58165] by eric@webkit.org
  • 3 edits
    1 move in trunk/JavaScriptCore

2010-04-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

[WIN] Move OwnPtrWin.cpp into platform specific folder.
​https://bugs.webkit.org/show_bug.cgi?id=38042

7:45 AM Changeset in webkit [58164] by eric@webkit.org
  • 1 edit
    1 move in trunk/JavaScriptCore

2010-04-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

[BREWMP] Move OwnPtrBrew.cpp into platform specific folder.
​https://bugs.webkit.org/show_bug.cgi?id=38042

  • wtf/OwnPtrBrew.cpp: Removed.
  • wtf/brew/OwnPtrBrew.cpp: Copied from JavaScriptCore/wtf/OwnPtrBrew.cpp.
6:05 AM Changeset in webkit [58163] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
​https://bugs.webkit.org/show_bug.cgi?id=37988

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2:51 AM Changeset in webkit [58162] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Flaky Inspector tests.
​https://bugs.webkit.org/show_bug.cgi?id=36217

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
2:42 AM Changeset in webkit [58161] by eric@webkit.org
  • 9 edits in trunk

2010-04-23 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate WebGLRenderingContext overloads in V8
​https://bugs.webkit.org/show_bug.cgi?id=37818

  • fast/canvas/webgl/script-tests/texImageTest.js: Test was wrong: Passing 0 value for a WebGLArray argument in texImage2D should throw the same exception as when passed to textSubImage2D.
  • platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt:
  • fast/canvas/webgl/texImageTest-expected.txt: Changes to reflect test.

2010-04-23 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate WebGLRenderingContext overloads in V8
​https://bugs.webkit.org/show_bug.cgi?id=37818

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:. (WebCore::WebGLRenderingContext::texImage2D) (WebCore::WebGLRenderingContext::texSubImage2D)
  • html/canvas/WebGLRenderingContext.h: Added missing overloads.
  • html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
2:31 AM Changeset in webkit [58160] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-04-23 Jeff Schiller <​codedread@gmail.com>

Reviewed by Nikolas Zimmermann.

Display tooltips when hovering over SVG elements, Bug 16854
​https://bugs.webkit.org/show_bug.cgi?id=16854

Manual test added for verifying tooltips.

  • manual-tests/svg-tooltip.svg: Added.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
  • svg/SVGStyledElement.h: add title() method declaration
1:43 AM Changeset in webkit [58159] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

Change expectation of fast/url/file-http-base.html for Chromium to TEXT.
​https://bugs.webkit.org/show_bug.cgi?id=38038

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [58158] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/38032> No need to content sniff 304 responses
<rdar://problem/7891726>

Reviewed by Brady Eidson.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
No need to adjust the MIME type on 304 responses since they're
only used to determine if the resource needs to be refetched.

1:05 AM Changeset in webkit [58157] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

<​http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds

Reviewed by Alexey Proskuryakov.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::dumpTextEncodingNameMap): Added.

  • platform/text/TextEncodingRegistry.h:

(WebCore::dumpTextEncodingNameMap): Added declaration.

12:36 AM Changeset in webkit [58156] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<​http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()

Reviewed by Timothy Hatcher.

Every other Objective-C class that calls
WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
JSC::initializeThreading(). The WebTextIteratorPrivate class
was the only one missing this call.

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]): Added call to
JSC::initializeThreading().

12:18 AM Changeset in webkit [58155] by aestes@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

12:14 AM Changeset in webkit [58154] by aestes@apple.com
  • 3 edits in trunk/WebKit/win

Roll out ​http://trac.webkit.org/changeset/55385.

Rubber stamped by Steve Falkenburg.

<rdar://problem/7884444>

  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):

12:04 AM Changeset in webkit [58153] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-04-22 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
​https://bugs.webkit.org/show_bug.cgi?id=37950

  • editing/text-iterator/rtl-selection-crash-expected.txt: Added.
  • editing/text-iterator/rtl-selection-crash.html: Added.

2010-04-22 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
​https://bugs.webkit.org/show_bug.cgi?id=37950

Test: editing/text-iterator/rtl-selection-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):
12:00 AM Changeset in webkit [58152] by mjs@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Add a test for file URL canonicalization with an http base
​https://bugs.webkit.org/show_bug.cgi?id=38035

  • fast/url/file-http-base-expected.txt: Added.
  • fast/url/file-http-base.html: Added.
  • fast/url/script-tests/file-http-base.js: Added.

Apr 22, 2010:

10:59 PM Changeset in webkit [58151] by mjs@apple.com
  • 2 edits in trunk

Fix up my immediately previous ChangeLogs.

10:47 PM Changeset in webkit [58150] by mjs@apple.com
  • 6 edits
    6 adds in trunk

2010-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Links around blocks (e.g. divs) results in too many VoiceOver call outs
​https://bugs.webkit.org/show_bug.cgi?id=37079

The basic change is to modify the AccessibilityRenderObject tree
traversal methods to account for inline continuations in the
render tree and make the accessibility tree look as if
continuations didn't exist - the same as if CSS blocks could just
sit in CSS inlines. This is slightly tricky code but creates a
much saner accessibility tree.


Tests: accessibility/image-link-inline-cont.html

accessibility/image-link.html
accessibility/inline-continuations.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations. (WebCore::firstChildInContinuation): ditto (WebCore::firstChildConsideringContinuation): ditto (WebCore::lastChildConsideringContinuation): ditto (WebCore::startOfContinuations): ditto (WebCore::endOfContinuations): ditto (WebCore::childBeforeConsideringContinuations): ditto (WebCore::firstChildIsInlineContinuation): ditto (WebCore::lastChildHasContinuation): ditto (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations. (WebCore::AccessibilityRenderObject::lastChild): ditto (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations and their anonymous block parents. (WebCore::AccessibilityRenderObject::nextSibling): ditto (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations. (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
  • rendering/RenderInline.h: Make RenderInline::inlineContinuation public.

2010-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Links around blocks (e.g. divs) results in too many VoiceOver call outs
​https://bugs.webkit.org/show_bug.cgi?id=37079


The new test cases verify the accessibility tree created by an image inside a link, and verify
that adding a div with role=presentation now has no effect on the accessibility tree (as expected).

  • accessibility/image-link-inline-cont-expected.txt: Added.
  • accessibility/image-link-inline-cont.html: Added.
  • accessibility/image-link.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/image-link-expected.txt: Added.
  • platform/win/Skipped:


Test to check that accessibility tree doesn't get duplicate content in the presence
of inline continuations (this was a bug in an earlier version of this patch).

  • accessibility/inline-continuations-expected.txt: Added.
  • accessibility/inline-continuations.html: Added.
9:51 PM Changeset in webkit [58149] by hamaji@chromium.org
  • 5 edits in trunk

2010-04-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: TextIterator may use freed memory
​https://bugs.webkit.org/show_bug.cgi?id=37973

  • platform/chromium/test_expectations.txt:

2010-04-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: TextIterator may use freed memory
​https://bugs.webkit.org/show_bug.cgi?id=37973

Added TextIterator::m_text to hold the returned String.

No new tests because there are no behavior change, but
copy-backslash-with-euc.html on chromium-win should test this.

  • editing/TextIterator.cpp: (WebCore::TextIterator::emitText):
  • editing/TextIterator.h:
9:48 PM Changeset in webkit [58148] by eric@webkit.org
  • 2 edits in trunk/BugsSite

2010-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

The new review tools shouldn't clear the comment box automatically
​https://bugs.webkit.org/show_bug.cgi?id=38004

Instead, we now have a button for doing that explicitly. If people
like this tool, we can look at fancier solutions.

Also, tried to make the tool work on the edit page as well as the review page.

  • PrettyPatch/PrettyPatch.rb:
9:32 PM Changeset in webkit [58147] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
9:29 PM Changeset in webkit [58146] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-22 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Revert 58077 and follow-ups. It's broken.
​https://bugs.webkit.org/show_bug.cgi?id=37664

  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
9:20 PM Changeset in webkit [58145] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Michael Forney <​mforney@mforney.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37761

Only include JSDatabase.h and JSDatabaseCallback.h when database is
enabled. This partially fixes building with --disable-database.

  • bindings/js/JSDOMWindowCustom.cpp: Add a check for database around database-related headers.
8:39 PM Changeset in webkit [58144] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Ray Rischpater <​Raymond.Rischpater@Nokia.com>

Reviewed by Darin Adler.

In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
this by changing shouldUseInputMethod to use internal methods to
check that the field is a text field that isn't a password field.

No new tests.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=37719>

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
8:30 PM Changeset in webkit [58143] by eric@webkit.org
  • 2 edits
    1 add
    1 delete in trunk

2010-04-22 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Integrate v8 testing utility with webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=37731

  • bindings/v8/test/run_tests.py: Removed.

2010-04-22 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Integrate v8 testing utility with webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=37731

  • Scripts/run-bindings-tests: Added.
8:10 PM Changeset in webkit [58142] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-22 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Update Android to use isfinite, isinf, isnan and signbit from namespace std.
​https://bugs.webkit.org/show_bug.cgi?id=37948

  • wtf/MathExtras.h:
7:52 PM Changeset in webkit [58141] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-04-22 John Pavan <​john.pavan@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates.
​https://bugs.webkit.org/show_bug.cgi?id=37163

QWebPage::inputMethodQuery is modified so that it
returns coordinates in the widget's coordinate system.
Tests are added for QGraphicsWebView and QWebView
to verify that this behavior is correct after the webpage
has been scrolled.

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
7:07 PM Changeset in webkit [58140] by eric@webkit.org
  • 10 edits in trunk

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=37872

  • html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant(). (WebCore::WebGLRenderingContext::isGLES2Compliant):
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=37872

  • public/WebGraphicsContext3D.h: Add isGLES2Compliant().
  • src/GraphicsContext3D.cpp: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto.
6:55 PM Changeset in webkit [58139] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

new-run-webkit-tests --verbose shows ever-increasing #EOF lines
​https://bugs.webkit.org/show_bug.cgi?id=37794

  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Remove the assert() since our ServerProcess code does not always seem to be reading the full stderr output (or we're not waiting for it to).
6:32 PM Changeset in webkit [58138] by ukai@chromium.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed build fix.

  • wtf/MD5.cpp: fix include path of CString.h
6:31 PM Changeset in webkit [58137] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-22 Yuzo Fujishima <​yuzo@google.com>

Unreviewed. Chromium test expectation change.

Mark fast/events/touch/send-oncancel-event.html as failing (TEXT).
​https://bugs.webkit.org/show_bug.cgi?id=38020

  • platform/chromium/test_expectations.txt:
6:13 PM Changeset in webkit [58136] by ukai@chromium.org
  • 9 edits
    3 adds in trunk

2010-04-22 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

MD5 is required for WebSocket new protocol implementation
​https://bugs.webkit.org/show_bug.cgi?id=37913

2010-04-22 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

MD5 is required for WebSocket new protocol implementation
​https://bugs.webkit.org/show_bug.cgi?id=37913

  • ForwardingHeaders/wtf/MD5.h: Added.
5:44 PM Changeset in webkit [58135] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::didUpdate):

5:16 PM Changeset in webkit [58134] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Errk, accidentally committed commenting out two ASSERTs! reverting.

Reviewed by NOBODY (build fix).

  • runtime/Collector.cpp:

(JSC::Heap::protect):
(JSC::Heap::unprotect):

5:11 PM Changeset in webkit [58133] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable

Reviewed by Geoff Garen.

Presently JSC's IdentifierTables are owned by the JSGlobalData. For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData. This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.

  • API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):

  • API/JSContextRef.cpp:

(JSContextGroupCreate):

  • runtime/Collector.cpp:

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):

  • runtime/JSLock.cpp:

(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

5:08 PM Changeset in webkit [58132] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38012
REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard

  • platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified characters, to avoid falling through to virtual key code lookup for Roman characters.
5:07 PM Changeset in webkit [58131] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptGlue

Do not get the globaldata for the APIShim via the
global object; global object construction creates identifiers
which results in the ASSERTs checking the thread data's
identifierTable has been set failing.

Rubber stamped by Sam Weinig

  • JSUtils.cpp:

(unprotectGlobalObject):
(getThreadGlobalData):
(getThreadGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPICallback::~JSGlueAPICallback):

5:02 PM Changeset in webkit [58130] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:00 PM Changeset in webkit [58129] by mrowe@apple.com
  • 1 copy in tags/Safari-533.6

New tag.

4:46 PM Changeset in webkit [58128] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add code to help debug new-run-webkit-test hangs on the Chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=38011

I can see no reasonable way to test this change.
Stubbing out sys._current_frames() and traceback.extract_stack
seems folly. Dumping real data would have line number
(and possibly other call stack) variance between runs.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add _dump_thread_states and _dump_thread_states_if_necessary to have our main thread dump the states of all threads every 60 seconds when running in verbose mode.
    • Better document what is going on in our main loop.
4:40 PM Changeset in webkit [58127] by jamesr@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-22 James Robinson <​jamesr@chromium.org>

Unreviewed, expectations only change.
Land chromium platform-specific results for fast/text/format-control.html

  • platform/chromium-linux/fast/text/format-control-expected.checksum: Added.
  • platform/chromium-linux/fast/text/format-control-expected.png: Added.
  • platform/chromium-mac/fast/text/format-control-expected.checksum: Added.
  • platform/chromium-win/fast/text/format-control-expected.checksum: Added.
  • platform/chromium-win/fast/text/format-control-expected.png: Added.
  • platform/chromium-win/fast/text/format-control-expected.txt: Added.
4:37 PM Changeset in webkit [58126] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Darin Adler.

Fix the MSVC 64bit build.
​https://bugs.webkit.org/show_bug.cgi?id=37980

  • platform/text/TextStream.cpp:
  • platform/text/TextStream.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::platformStart):
4:35 PM Changeset in webkit [58125] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebKit2

Merge the prefix headers.

Reviewed by Anders Carlsson.

  • Configurations/BaseTarget.xcconfig:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2Prefix.h:
  • WebKit2_Prefix.pch: Removed.
4:00 PM Changeset in webkit [58124] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-04-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Implement findThemePath to locate the correct theme file instead of
relying on a hardcoded location.
​http://webkit.org/b/37996

  • efl/EWebLauncher/main.c: (findThemePath): Fix to locate the correct theme files. (main): Use findThemePath() instead of a hardcoded one.
3:58 PM Changeset in webkit [58123] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Don't pass the new size when calling didSetSize, it's possible to get
the size from the update chunk.

Reviewed by Sam Weinig.

  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:

(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::setSize):

3:51 PM Changeset in webkit [58122] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-04-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Update efl/ewebkit.pc.in to match the variable substitution syntax
of CMake.
​http://webkit.org/b/37999

  • efl/ewebkit.pc.in: Updated.
3:41 PM Changeset in webkit [58121] by eric@webkit.org
  • 3 edits in trunk/WebKit

2010-04-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Update EWebKit (EFL port) to match recent API changes.
​http://webkit.org/b/37997

  • efl/ewk/ewk_frame.cpp: (ewk_frame_zoom_set): Change to use WebCore::ZoomMode. (ewk_frame_zoom_text_only_set): Change to use WebCore::ZoomMode. (_ewk_frame_handle_key_scrolling): s/WebCore::VK_/VK_/g (ewk_frame_plugin_create): Disable temporarily PluginView-related code until a proper plugin implementation is made.
  • efl/ewk/ewk_view.cpp: Fix typo in _parent_sc declaration. (ewk_view_selection_get): Fix a reference to WebCore::CString to WTF::CString.
3:33 PM Changeset in webkit [58120] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

<rdar://problem/7805969> REGRESSION: iTunes unable to play trailers

Undo the changes made for ​https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
for now. Clients rely on the old behavior, so a fix that changes it will need to account for
those.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL instead of baseURL again.
3:09 PM Changeset in webkit [58119] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Rename SetFrame and DidSetFrame to SetSize and DidSetSize.

Reviewed by Sam Weinig.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:

(DrawingAreaMessage::):

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:

(DrawingAreaProxyMessage::):

  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:

(WebKit::DrawingAreaProxyUpdateChunk::drawRectIntoContext):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

2:44 PM Changeset in webkit [58118] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58110.
​http://trac.webkit.org/changeset/58110
​https://bugs.webkit.org/show_bug.cgi?id=38007

Caused an internal compiler error on Qt (Requested by abarth
on #webkit).

  • wtf/MathExtras.h:
1:56 PM Changeset in webkit [58117] by weinig@apple.com
  • 21 edits
    1 copy
    3 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38002
Add rudimentary statistics gathering for WebKit2

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):

  • UIProcess/API/C/WKContextPrivate.h: Copied from WebKit2/UIProcess/API/C/WKContext.h.
  • UIProcess/API/C/WKPageNamespace.cpp:

(WKPageNamespaceGetContext):

  • UIProcess/API/C/WKPageNamespace.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::getStatistics):

  • UIProcess/WebPageNamespace.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getStatistics):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::numberOfPages):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate showStatisticsWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):

  • MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
  • MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
  • MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.

(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
(-[BrowserStatisticsWindowController windowDidLoad]):
(-[BrowserStatisticsWindowController refreshStatistics:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/English.lproj/MainMenu.xib:
  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
1:50 PM Changeset in webkit [58116] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • API/JSWeakObjectMapRefPrivate.cpp:

Reviewed by NOBODY (windows build fix).

1:42 PM Changeset in webkit [58115] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore
  • API/JSBase.cpp:
  • API/JSCallbackObject.cpp:

Reviewed by NOBODY (windows build fix).

1:31 PM Changeset in webkit [58114] by barraclough@apple.com
  • 15 edits
    1 add in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=37978
Unify JSC::IdentifierTable and WebCore::AtomicStringTable implementations.

Reviewed by Geoff Garen.

These two classes both implement a HashSet of uniqued StringImpls, with
translator classes to avoid unnecessary object creation. The only difference
between the classes is which flag (isIdentifier or inTable) is set.
Combine the two classes using a template predicated on which flag to use.

New class AtomicStringTable created, containing all the goodness from
IdentifierTable & AtomicStringTable, expect for Identifier's literalTable,
which has been moved onto JSGlobalData. Removed duplicate string translator
classes. Renamed StringImpl's inTable flag to more explicit 'isAtomic',
and set this on the empty string (which matches Identifier behaviour, and
removes a redundant check for zero-length).

(JSC::createLiteralTable):
(JSC::deleteLiteralTable):
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(WTF::WTFThreadData::atomicStringTable):

  • wtf/text/AtomicString.cpp:

(WebCore::table):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):

  • wtf/text/AtomicStringTable.h: Added.

(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::IdentifierOrAtomicStringTable::remove):
(WTF::::~IdentifierOrAtomicStringTable):
(WTF::::add):
(WTF::::find):

  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
(WebCore::equal):

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase):

1:17 PM Changeset in webkit [58113] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-04-22 MORITA Hajime <​morrita@google.com>

Not reviewed.

Picked a review feedback left on:
​https://bugs.webkit.org/show_bug.cgi?id=37056
LayoutTests/editing/selection/move-left-right.html is slow


  • editing/selection/move-left-right.html:
1:12 PM Changeset in webkit [58112] by robert@webkit.org
  • 4 edits in trunk/WebKit/qt

[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins

when PluginsEnabled is false.

2010-04-22 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins

when PluginsEnabled is false.

tst_qwebpage should have been updated as part of r56662.
(See ​https://bugs.webkit.org/show_bug.cgi?id=32196)

Updated documentation of QWebPage::createPlugin and QWebSetting::pluginsEnabled

to match the new behaviour.

  • Api/qwebpage.cpp: Update docs.
  • Api/qwebsettings.cpp: Update docs.
  • tests/qwebpage/tst_qwebpage.cpp: (createPlugin): (tst_QWebPage::createPluginWithPluginsEnabled): (tst_QWebPage::createPluginWithPluginsDisabled):
1:03 PM Changeset in webkit [58111] by Dimitri Glazkov
  • 39 edits
    2 adds in trunk

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Add test for icon change notifications.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • fast/dom/icon-url-property-expected.txt: Added.
  • fast/dom/icon-url-property.html: Added.
  • Skipped on all platforms but Win

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

​https://bugs.webkit.org/show_bug.cgi?id=33812

Test: fast/dom/icon-url-property.html

  • dom/Document.cpp: (WebCore::Document::setIconURL):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setIconURL):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::iconURL):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/FrameLoaderClientImpl.h:

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::didChangeTitle):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::didChangeIcons):
  • WebFrame.h:

2010-04-22 Dave Moore <​davemoore@chromium.org>

Reviewed by Dimitri Glazkov.

Add test support for icon changes.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpIconChangesCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpIconChanges): (LayoutTestController::setDumpIconChanges):
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didChangeIcons):
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • WinLauncher/WinLauncher.h: (WinLauncherWebHost::didChangeIcons):
12:55 PM Changeset in webkit [58110] by steveblock@google.com
  • 2 edits in trunk/JavaScriptCore

2010-04-22 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Update Android to use isfinite, isinf, isnan and signbit from namespace std.
​https://bugs.webkit.org/show_bug.cgi?id=37948

  • wtf/MathExtras.h:
12:46 PM Changeset in webkit [58109] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-04-22 Eric Carlson <​eric.carlson@apple.com>

Test fix, no review.

​https://bugs.webkit.org/show_bug.cgi?id=38000
r58107 causes video-play-stall and video-play-stall-seek to fail

Skip http/tests/media/video-play-stall.html and http/tests/media/video-play-stall-seek.html
until we can figure out how to work around QuickTime bug.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:39 PM Changeset in webkit [58108] by xan@webkit.org
  • 10 edits
    2 adds in trunk

WebCore:

2010-04-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Extend the bindings to cover most of Document.idl

  • GNUmakefile.am:
  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
  • bindings/gobject/WebKitDOMBinding.h:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added. (WebKit::createAnchorWrapper): (WebKit::createAppletWrapper): (WebKit::createAreaWrapper): (WebKit::createBaseWrapper): (WebKit::createBaseFontWrapper): (WebKit::createBlockquoteWrapper): (WebKit::createBodyWrapper): (WebKit::createBRWrapper): (WebKit::createButtonWrapper): (WebKit::createCanvasWrapper): (WebKit::createTableCaptionWrapper): (WebKit::createTableColWrapper): (WebKit::createModWrapper): (WebKit::createDirectoryWrapper): (WebKit::createDivWrapper): (WebKit::createDListWrapper): (WebKit::createEmbedWrapper): (WebKit::createFieldSetWrapper): (WebKit::createFontWrapper): (WebKit::createFormWrapper): (WebKit::createFrameWrapper): (WebKit::createFrameSetWrapper): (WebKit::createHeadingWrapper): (WebKit::createHeadWrapper): (WebKit::createHRWrapper): (WebKit::createHtmlWrapper): (WebKit::createIFrameWrapper): (WebKit::createImageWrapper): (WebKit::createInputWrapper): (WebKit::createIsIndexWrapper): (WebKit::createLabelWrapper): (WebKit::createLegendWrapper): (WebKit::createLIWrapper): (WebKit::createLinkWrapper): (WebKit::createMapWrapper): (WebKit::createMarqueeWrapper): (WebKit::createMenuWrapper): (WebKit::createMetaWrapper): (WebKit::createObjectWrapper): (WebKit::createOListWrapper): (WebKit::createOptGroupWrapper): (WebKit::createOptionWrapper): (WebKit::createParagraphWrapper): (WebKit::createParamWrapper): (WebKit::createPreWrapper): (WebKit::createQuoteWrapper): (WebKit::createScriptWrapper): (WebKit::createSelectWrapper): (WebKit::createStyleWrapper): (WebKit::createTableWrapper): (WebKit::createTableSectionWrapper): (WebKit::createTableCellWrapper): (WebKit::createTextAreaWrapper): (WebKit::createTitleWrapper): (WebKit::createTableRowWrapper): (WebKit::createUListWrapper): (WebKit::createHTMLElementWrapper):
  • bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
  • bindings/scripts/CodeGeneratorGObject.pm:
  • dom/Node.idl:

WebKit/gtk:

2010-04-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Add webkit_web_view_get_document to retrieve the WebKitDOMDocument
from a WebKitWebView, and a very simple test for it.

  • tests/testwebview.c:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_document):
  • webkit/webkitwebview.h:
11:06 AM Changeset in webkit [58107] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2010-04-22 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Do not pause movie when readyState drops below HAVE_FUTURE_DATA
​https://bugs.webkit.org/show_bug.cgi?id=37991
<rdar://problem/7893937>

No new tests, we don't have infrastructure in DRT to test with streamed
movies.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum. (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum. (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum. (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was previously >= HAVE_FUTURE_DATA.
  • html/HTMLMediaElement.h:
10:57 AM Changeset in webkit [58106] by eric@webkit.org
  • 4 edits in trunk/WebKit

2010-04-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Update EFL port files to match recent API changes.
​http://webkit.org/b/37876

  • efl/WebCoreSupport/ChromeClientEfl.cpp: (kit): Added. (WebCore::ChromeClientEfl::ChromeClientEfl): Coding style fix. (WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel): Coding style fix. (WebCore::ChromeClientEfl::mouseDidMoveOverElement): Coding style fix. (WebCore::ChromeClientEfl::runOpenPanel): Implemented. (WebCore::ChromeClientEfl::cancelGeolocationPermissionRequestForFrame): Stubbed. (WebCore::ChromeClientEfl::cancelGeolocationPermissionForFrame): Stubbed. (WebCore::ChromeClientEfl::invalidateContents): Stubbed. (WebCore::ChromeClientEfl::invalidateWindow): Stubbed. (WebCore::ChromeClientEfl::invalidateContentsAndWindow): Implemented. (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll): Implemented. (WebCore::ChromeClientEfl::scroll): Updated. (WebCore::ChromeClientEfl::iconForFiles): Stubbed. (WebCore::ChromeClientEfl::chooseIconForFiles): Stubbed.
  • efl/WebCoreSupport/ChromeClientEfl.h: Add new method prototypes.
  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::committedLoad): Call setEncoding() from FrameLoader::writer. (WebCore::FrameLoaderClientEfl::finishedLoading): Ditto. (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): Ditto. (WebCore::FrameLoaderClientEfl::setMainDocumentError): Ditto.
10:32 AM Changeset in webkit [58105] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove translatable strings from the hybridPixmap test.
​https://bugs.webkit.org/show_bug.cgi?id=37867

  • tests/hybridPixmap/widget.ui:
10:13 AM Changeset in webkit [58104] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove dependency of JSC to QtGui
​https://bugs.webkit.org/show_bug.cgi?id=37867

The patch also make sure that hal.h is in the include path on Symbian.
The dependency to QtGui took care of that before.

Patch by Thiago Macieira <​thiago.macieira@nokia.com>

and Rohan McGovern <​rohan.mcgovern@nokia.com>

10:04 AM Changeset in webkit [58103] by eric@webkit.org
  • 5 edits in trunk

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression: framebufferRenderbuffer crashes with null renderBuffer
​https://bugs.webkit.org/show_bug.cgi?id=37963

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Adding test cases for null renderbuffer input.
  • fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression: framebufferRenderbuffer crashes with null renderBuffer
​https://bugs.webkit.org/show_bug.cgi?id=37963

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
9:54 AM Changeset in webkit [58102] by eric@webkit.org
  • 8 edits in trunk

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
​https://bugs.webkit.org/show_bug.cgi?id=37281

  • fast/canvas/webgl/read-pixels-expected.txt: Add test case for the other supported format/type in readPixels (besides RGBA/UNSIGNED_BYTE); also, changed to a simpler test framework.
  • fast/canvas/webgl/read-pixels.html: Ditto.

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
​https://bugs.webkit.org/show_bug.cgi?id=37281

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now. (WebCore::WebGLRenderingContext::getParameter): Add two enums. (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
​https://bugs.webkit.org/show_bug.cgi?id=37281

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two enums.
9:50 AM Changeset in webkit [58101] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed. Turns out we need to do more escaping because Ruby was
explanding our newlines, creating a syntax error.

  • PrettyPatch/PrettyPatch.rb:
9:38 AM Changeset in webkit [58100] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Corrects symbols visibility for JavaScriptCore.

​https://bugs.webkit.org/show_bug.cgi?id=37867

9:28 AM Changeset in webkit [58099] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-22 Marcus Bulach <​bulach@chromium.org>

Reviewed by Dimitri Glazkov.

Enable LayoutTests for EventSource on chromium
​https://bugs.webkit.org/show_bug.cgi?id=37863

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
8:46 AM Changeset in webkit [58098] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-22 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK_ROLE_COMBO_BOX.

  • tests/testatkroles.c: (test_webkit_atk_get_role_combobox): (main):
8:36 AM Changeset in webkit [58097] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[GTK] Mute/unmute button on <video> elements are backwards
​https://bugs.webkit.org/show_bug.cgi?id=33967

Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling):
7:56 AM Changeset in webkit [58096] by eric@webkit.org
  • 13 edits in trunk/WebKit/qt

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix autotests .qrc file paths when built in Qt.

Compiling auto-tests from qt/tests/auto/qweb* produced
failing tests since these .pro files include the
ones in WebKit/qt/tests and the .qrc file was
not added to RESOURCES

  • tests/benchmarks/loading/loading.pro:
  • tests/benchmarks/painting/painting.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebinspector/qwebinspector.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
  • tests/tests.pri:
7:46 AM Changeset in webkit [58095] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Eric Seidel.

Fix build if NPAPI support is disabled
​https://bugs.webkit.org/show_bug.cgi?id=36621

No new tests, this is a build fix.
Re-submit r58043 with fix for EFL.

  • plugins/PluginViewNone.cpp:
7:36 AM Changeset in webkit [58094] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-22 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Implement ATK_ROLE_COMBO_BOX.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
6:50 AM Changeset in webkit [58093] by Nikolas Zimmermann
  • 15 edits
    11 moves
    1 delete in trunk/WebCore

2010-04-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
​https://bugs.webkit.org/show_bug.cgi?id=37986

No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
This is a preparation for the real patch which follows soon.

  • Android.mk: Rename files and move to the right location.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
  • rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
  • rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
  • rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
  • rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
  • rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
  • rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
  • rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
  • rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
  • rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
  • rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
  • rendering/SVGRenderTreeAsText.cpp: Change include file names.
  • svg/SVGFont.cpp: Ditto.
  • svg/SVGGradientElement.cpp: Ditto.
  • svg/SVGGradientElement.h: Ditto.
  • svg/SVGLinearGradientElement.cpp: Ditto.
  • svg/SVGPatternElement.cpp: Ditto.
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGRadialGradientElement.cpp: Ditto.
  • svg/graphics/SVGPaintServer.cpp: Removed.
  • svg/graphics/SVGPaintServerGradient.cpp: Removed.
  • svg/graphics/SVGPaintServerGradient.h: Removed.
  • svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
  • svg/graphics/SVGPaintServerLinearGradient.h: Removed.
  • svg/graphics/SVGPaintServerPattern.cpp: Removed.
  • svg/graphics/SVGPaintServerPattern.h: Removed.
  • svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
  • svg/graphics/SVGPaintServerRadialGradient.h: Removed.
  • svg/graphics/SVGPaintServerSolid.cpp: Removed.
  • svg/graphics/SVGPaintServerSolid.h: Removed.
  • svg/graphics/SVGResourceListener.h: Removed.
6:34 AM Changeset in webkit [58092] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.

This prevents the dependent headers from being included by
qt/include/QtWebKit/QtWebKit

  • WebCore.pro:
6:24 AM Changeset in webkit [58091] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-04-22 Gabor Loki <​loki@webkit.org>

Reviewed by Gavin Barraclough.

Use BLX and BX to keep happy the return stack predictor above ARMv4
​https://bugs.webkit.org/show_bug.cgi?id=37862

Inspired by Jacob Bramley's patch from JaegerMonkey

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h: (JSC::ARMAssembler::): (JSC::ARMAssembler::bx): (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::getLdrImmAddress):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
5:28 AM Changeset in webkit [58090] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-22 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Turn on antialias and stencil as default canvas attributes.
​https://bugs.webkit.org/show_bug.cgi?id=36972

  • fast/canvas/webgl/resources/webgl-test.js: (create3DContext): Turn on antialias and stencil as default canvas attributes.
5:09 AM Changeset in webkit [58089] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Adam Roben.

EFL does not support PluginDatabase yet.
​http://webkit.org/b/37854

No behavior changes, so no new tests were added.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
5:08 AM Changeset in webkit [58088] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Script fix. Will ask dpranke to look tomorrow.

new-run-webkit-tests --verbose shows ever-increasing #EOF lines
​https://bugs.webkit.org/show_bug.cgi?id=37794

The bots are seeing cases where .error is sometimes empty.
Lets make the code not crash in that case for now.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
4:21 AM Changeset in webkit [58087] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
​https://bugs.webkit.org/show_bug.cgi?id=37924

  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDividers):
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateEventDividers): (WebInspector.TimelinePanel.prototype._refresh):
4:15 AM Changeset in webkit [58086] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
4:11 AM Changeset in webkit [58085] by eric@webkit.org
  • 24 edits in trunk

2010-04-22 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Unreviewed expected results update.

Rename window.media to window.styleMedia
​https://bugs.webkit.org/show_bug.cgi?id=36187

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/media/print-restores-previous-mediatype-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:

2010-04-22 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Fraser.

Rename window.media to window.styleMedia
​https://bugs.webkit.org/show_bug.cgi?id=36187

It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.

  • page/AbstractView.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::styleMedia):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:41 AM Changeset in webkit [58084] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Do not pass empty handle into SetHiddenValue which would crash.
​https://bugs.webkit.org/show_bug.cgi?id=37801

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
3:31 AM Changeset in webkit [58083] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-22 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK_ROLE_SEPARATOR.

  • tests/testatkroles.c: (test_webkit_atk_get_role_separator): (main):
3:19 AM Changeset in webkit [58082] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

  • Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
3:00 AM Changeset in webkit [58081] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

  • Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
2:59 AM Changeset in webkit [58080] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Restore the Leopard bots to using
old-run-webkit-tests for now.

  • Scripts/run-webkit-tests:
2:48 AM Changeset in webkit [58079] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
2:38 AM Changeset in webkit [58078] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-22 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Implement ImageBuffer support
​https://bugs.webkit.org/show_bug.cgi?id=35288

Covered by existing tests.

Complete implementation of ImageBuffer for Haiku. Uses StillImage
class to export a WebCore::Image and associated GraphicsContext
to perform arbitrary drawing in the offscreen BBitmap buffer.

  • platform/graphics/haiku/ImageBufferData.h:
  • platform/graphics/haiku/ImageBufferHaiku.cpp, (WebCore::ImageBufferData::ImageBufferData), (WebCore::ImageBufferData::~ImageBufferData), (WebCore::ImageBuffer::ImageBuffer), (WebCore::ImageBuffer::~ImageBuffer), (WebCore::ImageBuffer::context), (WebCore::ImageBuffer::image):

Implementation uses offscreen BBitmap and BView, wraps StillImage
around those to provide WebCore::Image interface.

(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::convertFromData):

Method just performs BGRA <-> RGBA conversion.

(WebCore::convertFromInternalData):

Method just performs BGRA <-> RGBA conversion and handles
pre-multiplying the color values if requested.

(WebCore::convertToInternalData):

Method just performs BGRA <-> RGBA conversion and handles
de.multiplying the color values if requested.

(WebCore::getImageData):

Common code for the next two methods.

(WebCore::ImageBuffer::getUnmultipliedImageData),
(WebCore::ImageBuffer::getPremultipliedImageData):

Implemented.

(WebCore::putImageData):

Common code for the next two methods.

(WebCore::ImageBuffer::putUnmultipliedImageData),
(WebCore::ImageBuffer::putPremultipliedImageData):

Implemented.

(WebCore::ImageBuffer::toDataURL):

Uses Haiku "Translation Kit" to convert image data to data
of the requested mime type.

2:34 AM Changeset in webkit [58077] by ukai@chromium.org
  • 6 edits in trunk/WebKitTools

2010-04-22 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

Chromium: Add --chromium option to new-run-webkit-websocketserver
​https://bugs.webkit.org/show_bug.cgi?id=37664

Move cygwin setup logic in chromium_win.py.

  • Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
  • Scripts/new-run-webkit-websocketserver: add --chromium flag
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
  • Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
2:20 AM Changeset in webkit [58076] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests --verbose shows ever-increasing #EOF lines
​https://bugs.webkit.org/show_bug.cgi?id=37794

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Fix the log message to explain that this is stderr output, not test output.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Be sure to reset the server_process.error after reading (seems like the wrong place to do this, but at least this fixes the bug and dpranke and I can talk about better designs later).
    • Also remove the #EOF from the stderr output before returning it.
2:12 AM Changeset in webkit [58075] by abarth@webkit.org
  • 2 edits
    1 add in trunk/BugsSite

2010-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Hack up PrettyDiff to allow line-by-line comments
​https://bugs.webkit.org/show_bug.cgi?id=37886

Admittedly a bit of a hack, this is a basic line-by-line editor we can
play with thanks to Andrew Scherkus. It's meant to integrate with the
"review" page at bugs.webkit.org.

I changed a few things from Andrew's original version:
1) Trigger text boxes on single click to make iPhone/iPad reviewing
easier.
2) Clear the main text box on load.
3) Reference a version of prototype.js on bugs.webkit.org.

  • PrettyPatch/PrettyPatch.rb:
  • prototype.js: Added.
1:29 AM Changeset in webkit [58074] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Fixing new-run-webkit-tests on the bots.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Fixing _compat_shim_option to take variable keyword args.
    • Turns out that nargs + callback is ignored unless type is specified. So I added the type so that the option was properly consumed. This was why new-run-webkit-tests couldn't find any tests, it was looking for them under "20" because that was the argument which should have been consumed by --exit-after-n-failures.
1:03 AM Changeset in webkit [58073] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-22 Tony Chang <​tony@chromium.org>

Not reviewed, build fix for chromium Windows.

[chromium] fix ImageDiff compile on windows
​https://bugs.webkit.org/show_bug.cgi?id=37979

  • DumpRenderTree/chromium/ImageDiff.cpp:
12:50 AM Changeset in webkit [58072] by abarth@webkit.org
  • 42 edits
    3 deletes in trunk

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • editing/execCommand/clipboard-access-expected.txt: Removed.
  • editing/execCommand/clipboard-access.html: Removed.
  • editing/execCommand/script-tests/clipboard-access.js: Removed.

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-04-22 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58069.
​http://trac.webkit.org/changeset/58069
​https://bugs.webkit.org/show_bug.cgi?id=27751

Broke compile on Windows.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12:40 AM Changeset in webkit [58071] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Just adding logging.

Adding logging to help debug why the Leopard Bot
can't find any tests to run.

  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Make it a fatal error to have no tests to run.
12:40 AM Changeset in webkit [58070] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-22 Tony Chang <​tony@chromium.org>

Reviewed by Shinichiro Hamaji.

[chromium] roll chromium deps to pick up some windows build fixes
​https://bugs.webkit.org/show_bug.cgi?id=37972

  • DEPS:
12:37 AM Changeset in webkit [58069] by abarth@webkit.org
  • 42 edits
    3 adds in trunk

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Manual test to verify that javascript cannot access clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • editing/execCommand/clipboard-access-expected.txt: Added.
  • editing/execCommand/clipboard-access.html: Added.
  • editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled): (runTest):

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

Test: editing/execCommand/clipboard-access.html

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
  • page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
  • src/WebSettingsImpl.h:

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-04-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
12:29 AM Changeset in webkit [58068] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-22 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Improve SimpleFontDataHaiku
​https://bugs.webkit.org/show_bug.cgi?id=37411

Covered by existing tests.

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:
    • Cleaned up includes
    • Removed prototype "charUnicodeToUTF8HACK"

(WebCore::SimpleFontData::platformInit):

  • Use const BFont pointer

(WebCore::SimpleFontData::smallCapsFontData):

  • "fontPlatformData" was leaked. It is only used as the key for the font cache lookup.

(WebCore::SimpleFontData::platformMetricsForGlyph):

  • Use existing WebCore encoding infrastructure instead of adding a hack for Haiku.
12:11 AM Changeset in webkit [58067] by aestes@apple.com
  • 3 edits in trunk/WebKit/win

Reference count WebView's backing store bitmap to prevent
deleteBackingStore() from freeing the bitmap while it is still being
referenced by Core Animation.

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=37954

  • WebView.cpp:

(WebView::ensureBackingStore):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::updateBackingStore):
(WebView::paint):
(WebView::backingStore):
(releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
Animation has dropeed its reference to the memory.
(WebView::updateRootLayerContents): ref m_backingStoreBitmap before
passing the memory to Core Animation to prevent deleteBackingStore()
from freeing it while it is still referenced by CA.

  • WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,

and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.

Apr 21, 2010:

11:59 PM Changeset in webkit [58066] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch can't fetch attachments on security bugs
​https://bugs.webkit.org/show_bug.cgi?id=37975

Instead of calling CURL, we just need to use our Mechanize object,
which understand bugs.webkit.org authentication.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
11:50 PM Changeset in webkit [58065] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-21 Tony Chang <​tony@chromium.org>

Reviewed by Shinichiro Hamaji.

[chromium] gyp_webkit should be executable
​https://bugs.webkit.org/show_bug.cgi?id=37971

  • gyp_webkit: Added property svn:executable.
11:49 PM Changeset in webkit [58064] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

URL LayoutTests don't run on Firefox
​https://bugs.webkit.org/show_bug.cgi?id=37974

It turns out Firefox doesn't handle base URLs properly if we go through
the DOM to create the <base> and <a> elements. If we switch to
document.write, we can run the tests in Firefox (even though
document.write is lame).

  • fast/url/resources/utilities.js: (canonicalize): (setBaseURL):
11:48 PM Changeset in webkit [58063] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Temporary commit, will roll-out before morning.

Turning on new-run-webkit-tests for the Leopard build bot
for testing of the harness.
Users should not noctice (except for the results.html difference).

  • Scripts/run-webkit-tests:
11:38 PM Changeset in webkit [58062] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix typo in my previous fix attempt.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

More on-the-bot debugging, sigh. I wish I had a local build.

  • Scripts/webkitpy/layout_tests/port/base.py:
11:32 PM Changeset in webkit [58061] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-21 Steve Block <​steveblock@google.com>

Reviewed by Kenneth Rohde Christiansen.

Replace Geolocation::suspend()/resume() which are required by Android.
​https://bugs.webkit.org/show_bug.cgi?id=37942

These methods were removed in Bug 36255.

Build fix only, no new tests.

  • page/Geolocation.cpp: (WebCore::Geolocation::suspend): (WebCore::Geolocation::resume):
  • page/Geolocation.h:
11:29 PM Changeset in webkit [58060] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix typo in my previous fix attempt.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add self. to class variable access.
11:18 PM Changeset in webkit [58059] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Another attempt to fix NRWT for chromium.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/port/base.py:
    • wdiff_text was returning a byte array instead of a unicode string. The simple fix was to just decode the result. However, seeing so much duplicated code with Executive made me cry, so I re-wrote the function to be more like pretty_patch_text and use run_command (which already knows how to handle unicode).
11:02 PM Changeset in webkit [58058] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-21 Ben Murdoch <​benm@google.com>

Reviewed by Jeremy Orlow.

send-oncancel-event touch test should use js-test-post-function.js
​https://bugs.webkit.org/show_bug.cgi?id=37830

Restore reference to js-test-post-function removed erroneously in copy
when this test was move in ​http://trac.webkit.org/changeset/54253
and the corresponding call to the isSuccessfullyParsed function.

  • fast/events/touch/script-tests/send-oncancel-event.js: (touchcancelHandler): Call isSuccessfullyParsed.
  • fast/events/touch/send-oncancel-event.html: Add js-test-post-function.js back.
10:49 PM Changeset in webkit [58057] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Ray Rischpater <​Raymond.Rischpater@Nokia.com>

In HTMLInputElement.cpp there are numerous style
violations.

This patch includes style changes to fix existing style
deviations in this file.

Rubber stamped by Darin Adler.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=37881>

  • html/HTMLInputElement.cpp:
10:49 PM Changeset in webkit [58056] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Windows tests buildbots are too slow to be core builders
​https://bugs.webkit.org/show_bug.cgi?id=37970

It's 10:45. The Windows test bots are still hours behind. They're too
slow to be core builders. When they get fast, we can add them back.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
10:49 PM Changeset in webkit [58055] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt one more time to fix NRWT for chromium.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

I'm debugging in the blind because I don't have a chromium
build on this laptop.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • Apply the previous fix to a second caller.
10:40 PM Changeset in webkit [58054] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt one more time to fix NRWT for chromium.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • Fix handling of test_shell output so that we always decode it as utf-8. Unlike DumpRenderTree test_shell does not ever return pixel data. It spits out the pixel dumps in a separate file, thus all output over stdout is utf-8 text.
10:39 PM Changeset in webkit [58053] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Adam Roben.

Add missing EFL WebCore file.
​http://webkit.org/b/37854

No behavior changes, so no new tests were added.

  • bindings/js/ScriptControllerEfl.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
9:45 PM Changeset in webkit [58052] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=37964
Fix a typo in comments - Korean encoding name is windows-949, not windows-939

  • WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
9:38 PM Changeset in webkit [58051] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-04-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Printing Core Animation-based plug-ins is broken
​https://bugs.webkit.org/show_bug.cgi?id=37967

When we do a "flattening" paint because of printing, we need to stash
the flattening flag in the FrameView's m_paintBehavior, because
WebBaseNetscapePluginView needs to find it there to decide whether
to grab a bitmap for printing, for CA plug-ins.

  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
9:30 PM Changeset in webkit [58050] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt one more time to fix NRWT for chromium.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • Pass encoding to _save_baseline_data and write_output_files
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Make _save_baseline_data and write_output_files take an encoding.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Pass encoding to _save_baseline_data and write_output_files
8:47 PM Changeset in webkit [58049] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Fix to take into account a change made in "StringImpl".
​https://bugs.webkit.org/show_bug.cgi?id=37763

  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
8:40 PM Changeset in webkit [58048] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-04-21 MORITA Hajime <​morrita@google.com>

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=37056
LayoutTests/editing/selection/move-left-right.html is slow


Reduced style change that would trigger relayout. Note that You
might find that expectation looks storange. It is due to Bug
37016.

  • editing/selection/move-left-right.html:
  • platform/mac/editing/selection/move-left-right-expected.txt:
8:31 PM Changeset in webkit [58047] by eric@webkit.org
  • 4 edits
    2 adds in trunk/WebKitTools

2010-04-21 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher: make FPS measurement accurate
​https://bugs.webkit.org/show_bug.cgi?id=37934

Instead of counting paints, which are not interchangeable with frames that
the user sees, we now set an arbitrary timer for FPS measurements. The idea is
that if the main thread is delayed for any reason, that timer would be delayed
as well.

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/fpstimer.cpp: Added. (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::start): (FpsTimer::stop): (FpsTimer::timerEvent):
  • QtLauncher/fpstimer.h: Added.
  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled): (WebViewGraphicsBased::updateFrameRate): (WebViewGraphicsBased::paintEvent):
  • QtLauncher/webview.h:
8:22 PM Changeset in webkit [58046] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-21 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Don't notify the WebView that a popup was
opened when the popup is handled externally, as the popup
is in that case transparent to the WebView.
The notification was causing an ASSERT on Mac (where
the popup is handled externally) as there would be no
notification that the popup was closed.
​https://bugs.webkit.org/show_bug.cgi?id=37825

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
8:18 PM Changeset in webkit [58045] by aestes@apple.com
  • 8 edits
    1 move in trunk

JavaScriptCore: Export WTF::deleteOwnedPtr(HFONT).

Rubber stamped by Mark Rowe.

WebCore: Create a template for creating reference-counted Windows GDI handles.
Refactor RefCountedHFONT to use this template.

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37952

No change in behavior.

  • WebCore.vcproj/WebCore.vcproj: Add RefCountedHFONT.h
  • platform/graphics/cairo/FontPlatformData.h:

(WebCore::FontPlatformData::hfont): Refactor to return m_hfont->handle() instead of m_hfont->hfont().

  • platform/graphics/cg/FontPlatformData.h:

(WebCore::FontPlatformData::hfont): Same.

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Instantiate m_hfont with a RefCountedGDIHandle<HFONT>.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Same.

  • platform/graphics/win/RefCountedGDIHandle.h: Added. Interface is identical to RefCountedHFONT with exception of renaming hfont() to handle().

(WebCore::RefCountedGDIHandle::create):
(WebCore::RefCountedGDIHandle::createDeleted):
(WebCore::RefCountedGDIHandle::~RefCountedGDIHandle):
(WebCore::RefCountedGDIHandle::handle): Return the GDI handle.
(WebCore::RefCountedGDIHandle::hash):
(WebCore::RefCountedGDIHandle::RefCountedGDIHandle):

  • platform/graphics/win/RefCountedHFONT.h: Removed.
8:16 PM Changeset in webkit [58044] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding missing ":" in python file.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

new-run-webkit-tests --chromium was borked.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
7:51 PM Changeset in webkit [58043] by Laszlo Gombos
  • 4 edits in trunk/WebCore

2010-04-21 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Fix build if NPAPI support is disabled
​https://bugs.webkit.org/show_bug.cgi?id=36621

No new tests, this is a build fix.
Re-submit r56585 with fix for Chromium.

  • plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
  • plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
  • plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC) or PLATFORM(CHROMIUM)
7:48 PM Changeset in webkit [58042] by Joseph Pecoraro
  • 6 edits
    4 adds in trunk

2010-04-21 David Yonge-Mallo <​davinci@chromium.org>

Reviewed by Dan Bernstein.

ZWNJ - Display non-printing, invisible character
​https://bugs.webkit.org/show_bug.cgi?id=16131

Fix the (non)display of glyphs for ZWJ and ZWNJ in simple font code path.

Tests: fast/text/format-control.html

fast/text/zero-width-characters.html

  • platform/graphics/Font.h: (WebCore::Font::operator!=): (WebCore::Font::treatAsZeroWidthSpace): treat ZWNJ and ZWJ as ZWSP.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): added ZWNJ and ZWJ.
  • platform/text/CharacterNames.h: added ZWNJ and ZWJ.

2010-04-21 David Yonge-Mallo <​davinci@chromium.org>

Reviewed by Dan Bernstein.

ZWNJ - Display non-printing, invisible character
​https://bugs.webkit.org/show_bug.cgi?id=16131

Added tests for the handling of ZWJ and ZWNJ characters in simple font
path. These characters have zero width but may change the widths of text
around them. Furthermore, their glyphs should not be displayed in
simple static text.

  • fast/text/format-control.html: Added.
  • fast/text/zero-width-characters.html: modified to test ZWSP, ZWJ, and ZWNJ.
  • platform/mac/fast/text/format-control-expected.checksum: Added.
  • platform/mac/fast/text/format-control-expected.png: Added.
  • platform/mac/fast/text/format-control-expected.txt: Added.
7:41 PM Changeset in webkit [58041] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix webkit build problem when xhtmlmp enabled, which is introduced by revision 57927, for
bug fix of 37175 , which seperates DocumentWriter from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37915

No new tests since this only fixes the build problem.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
7:17 PM Changeset in webkit [58040] by hamaji@chromium.org
  • 6 edits in trunk/WebCore

2010-04-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Call sites of TextIterator constructor are difficult to read
​https://bugs.webkit.org/show_bug.cgi?id=37909

Now we use enum parameters instead of boolean parameters and
boolean version of constructors are eliminated.

This change also changes the names of boolean members so they are
now third person singular.

No new tests because this is just a refactoring.

  • WebCore.base.exp:
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleReplacedElement): (WebCore::TextIterator::shouldRepresentNodeOffsetZero): (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::TextIterator::emitCharacter): (WebCore::TextIterator::emitText): (WebCore::CharacterIterator::CharacterIterator): (WebCore::TextIterator::rangeLength): (WebCore::TextIterator::rangeFromLocationAndLength): (WebCore::findPlainText):
  • editing/TextIterator.h: (WebCore::):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
  • editing/visible_units.cpp: (WebCore::nextBoundary):
6:58 PM Changeset in webkit [58039] by Laszlo Gombos
  • 2 edits in trunk/LayoutTests

2010-04-21 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Enable notifications layout tests that are passing.

Qt port has a partial implementation of Notifications,
see r57408.

  • platform/qt/Skipped:
6:56 PM Changeset in webkit [58038] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-04-21 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Add PageClientQt files.

[Qt] PageClientQt specific implementation for QWidget
​https://bugs.webkit.org/show_bug.cgi?id=37858

  • WebCore.pro:

2010-04-21 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Add PageClientQWidget implementation based on the old
QWebPageWidgetClient to PageClientQt files. Also fix
QWebPage::setView() to use PageClientQWidget.

[Qt] PageClientQt specific implementation for QWidget
​https://bugs.webkit.org/show_bug.cgi?id=37858

  • Api/qwebpage.cpp: (QWebPage::setView):
  • WebCoreSupport/PageClientQt.cpp: Added. (WebCore::PageClientQWidget::scroll): (WebCore::PageClientQWidget::update): (WebCore::PageClientQWidget::setInputMethodEnabled): (WebCore::PageClientQWidget::inputMethodEnabled): (WebCore::PageClientQWidget::setInputMethodHint): (WebCore::PageClientQWidget::cursor): (WebCore::PageClientQWidget::updateCursor): (WebCore::PageClientQWidget::palette): (WebCore::PageClientQWidget::screenNumber): (WebCore::PageClientQWidget::ownerWidget): (WebCore::PageClientQWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQWidget::pluginParent): (WebCore::PageClientQWidget::style):
  • WebCoreSupport/PageClientQt.h: Added. (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQWidget::isQWidgetClient):
6:46 PM Changeset in webkit [58037] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-21 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Implement ATK_ROLE_SEPARATOR.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
6:34 PM Changeset in webkit [58036] by eric@webkit.org
  • 48 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

Third time is the charm. I've fixed all the
new-run-webkit-tests regressions from previous attempts.

I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.

This fixes our Executive.run_command code to work around a Popen
bug ​http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.

Following the advice of:
​http://farmdev.com/talks/unicode/
I have changed all of webkitpy to use unicode() objects as strings
instead of str objects (which in Python 3 are renamed "bytes").

String literals were left as "foo" instead of converting to u"foo"
as u"foo" is only required if the string has a non-ascii code point.
Python is smart about comparing str() and unicode() values and will
log an error to the console if the comparison is ever invalid.

Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.

I removed several uses of StringIO. StringIO should generally always be
passed a unicode() value.

Likewise I replaced most calls to open() with codecs.open().
codecs.open() matches Python 3 open semantics in requiring an encoding
parameter. Files opened with codecs.open() with a unicode-compatible
encoding will vend unicode() objects from their read() calls, like how
StringIO created with a unicode() object will do.

I also deployed "with" statements wider (now that the project has
settled on Python 2.5) to close a bunch of file descriptor leaks.

  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Read/write utf-8 files instead of ascii.
    • Update the tests to use test for proper unicode() handling.
  • Scripts/webkitpy/common/checkout/changelog.py:
    • Document that parse_latest_entry_from_file expects file-like objects which return unicode strings.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
    • Use unicode() strings instead of str() byte arrays.
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/common/checkout/commitinfo.py:
    • Remove unneeded import.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Remove use of str().
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Read/write utf-8 files and use unicode() strings in testing.
  • Scripts/webkitpy/common/config/committers.py:
    • Use \u instead of \x to make slightly clearer what we're doing.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Add a new _string_contents() method and explain why

we have to call unicode() on the result of soup.string
and why it's safe to do so w/o needing to pass a codec name.

  • Remove the (unused) support for passing a file object to add_patch_to_bug().
  • Scripts/webkitpy/common/net/buildbot.py:
    • Use unicode() instead of str() when needing to coax a

NavigableString object into a unicode() object.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
    • Add a test which contains a unicode builder name.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Remove use of str()
  • Scripts/webkitpy/common/prettypatch.py:
    • Write out the patch file as utf-8.
  • Scripts/webkitpy/common/system/autoinstall.py:
    • Write out files with a explicit encodings.
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/common/system/deprecated_logging.py:
    • Write out log files as utf-8.
  • Scripts/webkitpy/common/system/executive.py:
    • Make run* properly take and return unicode() objects.
    • Cleaned up input handling in run_command a little by adding a _compute_input() method which can return early instead of having such a long/cluttered if-block.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Added a unit test to make sure we don't break Tor again!
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Write out the test list as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
    • Write out json files as utf-8.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
  • Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
  • Scripts/webkitpy/layout_tests/port/mac.py: ditto.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
    • Make the skipped file parsing test unicode.
  • Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
  • Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Make explicit the encodings of log files and pid files.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Make encodings explicit and deploy "with".
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
  • Scripts/webkitpy/style/filereader_unittest.py: ditto.
  • Scripts/webkitpy/thirdparty/init.py: ditto.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
    • Removed extra import.
  • Scripts/webkitpy/tool/commands/queues.py:
    • No need to map args to strings now that run_command does.
    • Update test results to match args changes.
    • Document our global argument hacks.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/mocktool.py:
    • Rename add_patch_to_bug argument to match bugzilla.py
  • Scripts/webkitpy/tool/steps/abstractstep.py:
    • Executive.run_* now require lists instead of strings. The lack of this change was what broke webkit-patch for svn users the first time this was landed.
  • Scripts/webkitpy/tool/steps/postdiff.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Fixed spurious logging seen when running test-webkitpy
6:30 PM Changeset in webkit [58035] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 David Leong <​david.leong@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Symbian apps crash on exit due to a bad qObject_cast.

​https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash. Reworked to fix memory leak

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformDestroy):
6:03 PM Changeset in webkit [58034] by eric@webkit.org
  • 1 edit
    11 adds in trunk/WebKit

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Nikolas Zimmermann.

Add missing EFL WebKit/efl theme files.
​http://webkit.org/b/37854

  • efl/DefaultTheme/default.edc: Added.
  • efl/DefaultTheme/widget/button/button.edc: Added.
  • efl/DefaultTheme/widget/check/check.edc: Added.
  • efl/DefaultTheme/widget/combo/combo.edc: Added.
  • efl/DefaultTheme/widget/entry/entry.edc: Added.
  • efl/DefaultTheme/widget/file/file.edc: Added.
  • efl/DefaultTheme/widget/radio/radio.edc: Added.
  • efl/DefaultTheme/widget/scrollbar/scrollbar.edc: Added.
  • efl/DefaultTheme/widget/search/cancel/search_cancel.edc: Added.
  • efl/DefaultTheme/widget/search/decoration/search_decoration.edc: Added.
  • efl/DefaultTheme/widget/search/field/search_field.edc: Added.
5:55 PM Changeset in webkit [58033] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-21 James Robinson <​jamesr@chromium.org>

Unreviewed. Updating chromium test expecations.

  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [58032] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58028.
​http://trac.webkit.org/changeset/58028
​https://bugs.webkit.org/show_bug.cgi?id=37962

broke the chromium build (Requested by tonywork on #webkit).

  • DEPS:
5:25 PM Changeset in webkit [58031] by Chris Fleizach
  • 15 edits
    8 adds in trunk

aria-liveregion-notifications.html fails on leopard release bot
​https://bugs.webkit.org/show_bug.cgi?id=37112

Reviewed by Alexey Proskuryakov.

WebCore:

Change the method that DRT uses to monitor AX notifications so that its robust
by just sending out NSNotification that can be listened to by anyone, instead
of keeping a static function pointer around.

This change is aimed to avoid flakiness seen in DRT when the notification handlers
are not being called at the appropriate time.

Tests: platform/mac/accessibility/aria-liveregions-addedelement.html

platform/mac/accessibility/aria-liveregions-changedalt.html
platform/mac/accessibility/aria-liveregions-changedtext.html
platform/mac/accessibility/aria-liveregions-removedelement.html

  • accessibility/mac/AccessibilityObjectWrapper.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

Change the way that notifications are listened for by forcing clients
to call a remove listener as well to match the add listener. DRT will
assert if those are not done in the correct order.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(removeNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::removeNotificationListener):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::removeNotificationListener):

LayoutTests:

Add four more tests that test specific live region functionality. Having these
four tests run in order seems to stress the notification mechanism and will expose issues
more frequently.
Modify tests that use notification listeners to also "removeNotificationListener".

  • platform/mac-leopard/Skipped:
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
  • platform/mac/accessibility/aria-liveregion-on-image.html:
  • platform/mac/accessibility/aria-liveregions-addedelement-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-addedelement.html: Added.
  • platform/mac/accessibility/aria-liveregions-changedalt-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-changedalt.html: Added.
  • platform/mac/accessibility/aria-liveregions-changedtext-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-changedtext.html: Added.
  • platform/mac/accessibility/aria-liveregions-notifications.html:
  • platform/mac/accessibility/aria-liveregions-removedelement-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-removedelement.html: Added.
  • platform/mac/accessibility/change-notification-on-scroll.html:
5:18 PM Changeset in webkit [58030] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-04-21 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

Fix up notifications request permission test.
​https://bugs.webkit.org/show_bug.cgi?id=37959

  • fast/notifications/notifications-request-permission-expected.txt:
  • fast/notifications/notifications-request-permission.html:
5:16 PM Changeset in webkit [58029] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Remove old exports.

Reviewed by NOBODY (Leopard build fix).

  • WebCore.base.exp:
5:15 PM Changeset in webkit [58028] by evan@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-21 Evan Martin <​evan@chromium.org>

Unreviewed, just a dependency change.

[chromium] roll skia forward to r538
​https://bugs.webkit.org/show_bug.cgi?id=37960

This will cause a bunch of pixel tests to fail due to bulleted
lists rendering slightly differently. I will grab new baselines
from the bots and check them in in a followup.

  • DEPS:
4:59 PM Changeset in webkit [58027] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Bug 37949 - Do no copy strings into a shared buffer when converting UStrings to Strings
UString and String now have the same internal representation; Just re-wrap the internal impl.

Reviewed by Darin Adler.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsStringSlowCase):

  • bindings/js/JSDOMBinding.h:

(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):

4:59 PM Changeset in webkit [58026] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Rubber Stamped by Oliver Hunt.

Make SmallStrings store an array of RefPtr<StringImpl>,
instead of a direct array of StringImpls. This allows
us to remove a friend (and a layering violation) from
WTF::StringImpl, and makes it so that all StringImpls
are individually heap allocated.

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::rep):
(JSC::SmallStringsStorage::SmallStringsStorage):

  • wtf/text/StringImpl.h:
4:54 PM Changeset in webkit [58025] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

​https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

Tweaked the test to pass on Tiger.

  • http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html: Tiger synchronous loader wrongfully terats 401 response as a failure. While this causes incorrect behavior for XMLHttpRequest, it's acceptable for the purposes of this test.
4:39 PM Changeset in webkit [58024] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-04-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add debug menu items to show/hide the Web View.
​https://bugs.webkit.org/show_bug.cgi?id=37958

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController showHideWebView:]): (-[BrowserWindowController removeReinsertWebView:]): (-[BrowserWindowController validateMenuItem:]):
  • MiniBrowser/mac/English.lproj/MainMenu.xib:
4:22 PM Changeset in webkit [58023] by eric@webkit.org
  • 47 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Rolling out unicode() changes as they broke NRWT for chromium.
Rolling out:
​http://trac.webkit.org/changeset/58014
​http://trac.webkit.org/changeset/58016
​http://trac.webkit.org/changeset/58020

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/prettypatch.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/deprecated_logging.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/thirdparty/init.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
4:20 PM Changeset in webkit [58022] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Tiger build fix.

  • Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
4:16 PM Changeset in webkit [58021] by johnnyg@google.com
  • 5 edits
    7 moves in trunk/LayoutTests

2010-04-15 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

Enable the notifications layout tests, but skip them on the ports that don't
implement notifications.
​https://bugs.webkit.org/show_bug.cgi?id=37667

  • fast/notifications/notifications-check-permission.html: Added.
  • fast/notifications/notifications-check-permission.html-disabled: Removed.
  • fast/notifications/notifications-display-close-events.html: Added.
  • fast/notifications/notifications-display-close-events.html-disabled: Removed.
  • fast/notifications/notifications-double-show.html: Added.
  • fast/notifications/notifications-double-show.html-disabled: Removed.
  • fast/notifications/notifications-no-icon.html: Added.
  • fast/notifications/notifications-no-icon.html-disabled: Removed.
  • fast/notifications/notifications-request-permission.html: Added.
  • fast/notifications/notifications-request-permission.html-disabled: Removed.
  • fast/notifications/notifications-with-permission.html: Added.
  • fast/notifications/notifications-with-permission.html-disabled: Removed.
  • fast/notifications/notifications-without-permission.html: Added.
  • fast/notifications/notifications-without-permission.html-disabled: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:12 PM Changeset in webkit [58020] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing NRWT for real this time.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Add a hack to fix new-run-webkit-tests my understanding of codecs.open(encoding=None) must have been wrong.
4:11 PM Changeset in webkit [58019] by jamesr@google.com
  • 3 edits in trunk/WebKit/chromium

2010-04-21 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

[chromium] Web page serializer saves tag names in upper case
​https://bugs.webkit.org/show_bug.cgi?id=37940

Simply convert all tags to lower case.

This is tested by chrome tests:

  • save page browser tests
  • encoding ui tests
  • web page serializer test shell tests
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString):
4:07 PM Changeset in webkit [58018] by mrowe@apple.com
  • 3 edits
    1 add in trunk

<rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]

Reviewed by Eric Carlson.

WebCore:

A manual test case is required here as the Flip4Mac plug-in displays an alert, and some manual tweaking of the plug-in's
preference file on disk is often required to reproduce the bug.

  • manual-tests/plugins/flip4mac-update-alert-over-navigation.html: Added.

WebKit/mac:

Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).

The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
no other references to keep the object alive.

We work around this bug by patching the following two messages:

1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]

Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.

Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).

These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.

  • Plugins/WebPluginController.mm:

(-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
install our workaround if it is.
(isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
(WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
(WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
delegate if this NSAlert belongs to the Flip4Mac plug-in.
(installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
the method we're interested in. In that case we want to bail out before patching any methods.

4:07 PM Changeset in webkit [58017] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog

Reviewed by Maciej Stachowiak.

WebCore:

This is a manual test case as I was not able to construct an automated test that reproduced the same issue without displaying
a modal dialog on-screen.

  • manual-tests/plugins/timeout-dialog-displayed-over-navigation.html: Added.
  • manual-tests/plugins/timeout-dialog-displayed-over-navigation.swf: Added.

WebKit/mac:

An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCInvalidateRect):
(WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
is already processing requests. This ensures that there will be no plug-in code on the stack when
the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
a modal dialog is displayed.

3:51 PM Changeset in webkit [58016] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing exception seen on builders.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Pass and encoding to _write_into_file_at_path
3:06 PM Changeset in webkit [58015] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-04-21 Simon Fraser <Simon Fraser>

Unreviewed; fix assertion in LayoutTests.

​https://bugs.webkit.org/show_bug.cgi?id=37932
Assertion in transitions/transition-end-event-destroy-iframe.html

Now that composited iframes cause their parent document to enter compositing mode,
iframe painting via NSView does't send the required -viewWillDraw, which causes
this assertion. Disable the test until we figure out a solution.

  • platform/mac-snowleopard/Skipped:
3:04 PM Changeset in webkit [58014] by eric@webkit.org
  • 47 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.

This fixes our Executive.run_command code to work around a Popen
bug ​http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.

Following the advice of:
​http://farmdev.com/talks/unicode/
I have changed all of webkitpy to use unicode() objects as strings
instead of str objects (which in Python 3 are renamed "bytes").

String literals were left as "foo" instead of converting to u"foo"
as u"foo" is only required if the string has a non-ascii code point.
Python is smart about comparing str() and unicode() values and will
log an error to the console if the comparison is ever invalid.

Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.

I removed several uses of StringIO. StringIO should generally always be
passed a unicode() value.

Likewise I replaced most calls to open() with codecs.open().
codecs.open() matches Python 3 open semantics in requiring an encoding
parameter. Files opened with codecs.open() with a unicode-compatible
encoding will vend unicode() objects from their read() calls, like how
StringIO created with a unicode() object will do.

I also deployed "with" statements wider (now that the project has
settled on Python 2.5) to close a bunch of file descriptor leaks.

  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Read/write utf-8 files instead of ascii.
    • Update the tests to use test for proper unicode() handling.
  • Scripts/webkitpy/common/checkout/changelog.py:
    • Document that parse_latest_entry_from_file expects file-like objects which return unicode strings.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
    • Use unicode() strings instead of str() byte arrays.
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/common/checkout/commitinfo.py:
    • Remove unneeded import.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Remove use of str().
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Read/write utf-8 files and use unicode() strings in testing.
  • Scripts/webkitpy/common/config/committers.py:
    • Use \u instead of \x to make slightly clearer what we're doing.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Add a new _string_contents() method and explain why

we have to call unicode() on the result of soup.string
and why it's safe to do so w/o needing to pass a codec name.

  • Remove the (unused) support for passing a file object to add_patch_to_bug().
  • Scripts/webkitpy/common/net/buildbot.py:
    • Use unicode() instead of str() when needing to coax a

NavigableString object into a unicode() object.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
    • Add a test which contains a unicode builder name.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Remove use of str()
  • Scripts/webkitpy/common/prettypatch.py:
    • Write out the patch file as utf-8.
  • Scripts/webkitpy/common/system/autoinstall.py:
    • Write out files with a explicit encodings.
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/common/system/deprecated_logging.py:
    • Write out log files as utf-8.
  • Scripts/webkitpy/common/system/executive.py:
    • Make run* properly take and return unicode() objects.
    • Cleaned up input handling in run_command a little by adding a _compute_input() method which can return early instead of having such a long/cluttered if-block.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Added a unit test to make sure we don't break Tor again!
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Write out the test list as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
    • Write out json files as utf-8.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
  • Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
  • Scripts/webkitpy/layout_tests/port/mac.py: ditto.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
    • Make the skipped file parsing test unicode.
  • Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
  • Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Deploy "with" to close file descriptor leaks.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Make explicit the encodings of log files and pid files.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Make encodings explicit and deploy "with".
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
  • Scripts/webkitpy/style/filereader_unittest.py: ditto.
  • Scripts/webkitpy/thirdparty/init.py: ditto.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
    • Removed extra import.
  • Scripts/webkitpy/tool/commands/queues.py:
    • No need to map args to strings now that run_command does.
    • Update test results to match args changes.
    • Document our global argument hacks.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/mocktool.py:
    • Rename add_patch_to_bug argument to match bugzilla.py
  • Scripts/webkitpy/tool/steps/abstractstep.py:
    • Executive.run_* now require lists instead of strings. The lack of this change was what broke webkit-patch for svn users the first time this was landed.
  • Scripts/webkitpy/tool/steps/postdiff.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Fixed spurious logging seen when running test-webkitpy
2:17 PM Changeset in webkit [58013] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-21 James Robinson <​jamesr@chromium.org>

Unreviewed. Updating chromium test expecations.

  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [58012] by weinig@apple.com
  • 14 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37937
Wean JavaScriptCore off calls to isMainThread()

Reviewed by Geoffrey Garen.

JavaScriptCore:

  • Replace use of isMainThread() for interpreter reentry checks with a stored value on the JSGlobalData.
  • Replace use of isMainThread() for useMainThread only check in the collector with a stored exclusive thread.
  • API/JSContextRef.cpp:

(JSContextGroupCreate):
Always default to a small stack type for uses of the JSC API. It is
unlikely that the interpreter reentry required on the web will be as
important for other uses of JavaScriptCore.

Update exports.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().

  • interpreter/Interpreter.h:

Rename MaxMainThreadReentryDepth to MaxLargeThreadReentryDepth and
MaxSecondaryThreadReentryDepth to MaxSmallThreadReentryDepth.

  • jsc.cpp:

(main): Use the a large stack for jsc since it is always using the
main thread.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().

  • runtime/Collector.cpp:

(JSC::Heap::registerThread):
Use the concept of making JSC run on an exclusiveThread instead of
forcing a mainThreadOnly assertion.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

Add ThreadStackType argument to JSGlobalData constructors and set
maxReentryDepth based on it.

WebCore:

No change in behavior.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):
Explicitly set a large stack type for the common JSGlobalData and
set the currently running thread as the exclusive thread for its
execution.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
Explicitly set a small stack type for the workers JSGlobalData.

1:28 PM Changeset in webkit [58011] by kinuko@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed.

Add myself in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
1:08 PM Changeset in webkit [58010] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt. 3).

1:05 PM Changeset in webkit [58009] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptGlue

<rdar://problem/7879485> Leopard: Crash after opening Software Update dialog

Reviewed by Sam Weinig.

  • JSUtils.cpp:

(unprotectGlobalObject): Use the version of JSGlueAPIEntry that doesn't
call pthread_getspecific, since it's not safe to call pthread_getspecific
from a thread-specific data destructor. (<rdar://problem/7889842>
pthread_getspecific returns 0 when called from thread-specific data
destructor function)

(getThreadGlobalObject): Make sure to set the currentIdentifierTable
when first constructing our JSGlobalObject, since JSGlueAPIEntry has not
yet had an opportunity to do so.

(JSGlueAPIEntry::JSGlueAPIEntry):

  • JSUtils.h: New version of JSGlueAPIEntry that doesn't call

pthread_getspecific.

12:56 PM Changeset in webkit [58008] by barraclough@apple.com
  • 1 edit
    1 add in trunk/JavaScriptGlue

Errk! tree on fire, add fwd!

Reviewed by NOBODY (build fix).

  • ForwardingHeaders/wtf/text/StringHash.h: Added.
12:52 PM Changeset in webkit [58007] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt. 2).

12:49 PM Changeset in webkit [58006] by barraclough@apple.com
  • 6 edits
    1 move in trunk

JavaScriptCore: * JavaScriptCore.gypi:

  • JavaScriptCore.pro:
  • wtf/qt/StringQt.cpp: Copied from WebCore/platform/text/qt/StringQt.cpp.

Reviewed by NOBODY (Qt build fix).

WebCore: * WebCore.gypi:

  • WebCore.pro:
  • platform/text/qt/StringQt.cpp: Removed.

Reviewed by NOBODY (Qt build fix).

12:49 PM Changeset in webkit [58005] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

new-run-webkit-tests: fix a bug in the Chromium port where we would
try to talk to a crashed test_shell and raise exceptions that weren't
being caught.

​https://bugs.webkit.org/show_bug.cgi?id=37941

  • Scripts/webkitpy/layout_tests/port/chromium.py:
12:41 PM Changeset in webkit [58004] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-21 James Robinson <​jamesr@chromium.org>

Updating chromium expectations for tests that need new layoutTestController
functionality.

  • platform/chromium/test_expectations.txt:
12:40 PM Changeset in webkit [58003] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore
  • API/JSValueRef.cpp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):

  • runtime/Identifier.h:
  • wtf/WTFThreadData.h:

(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):

  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

Reviewed by NOBODY (windows build fix).

12:19 PM Changeset in webkit [58002] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Sheriffing cleanup.

[chromium] Add bug numbers for expectations created during sheriffing.

  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [58001] by barraclough@apple.com
  • 21 edits
    2 adds
    1 delete in trunk

JavaScriptCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.

Reviewed by Oliver Hunt, Darin Adler.

JSC::UStringImpl and WebCore::StringImpl (soon to be renamed to
WTF::StringImpl) are almost identical. Remove duplication of code by unifying
the two, move missing features from UStringImpl into StringImpl & delete the
class UStringImpl.

  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pro:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/EvalCodeCache.h:
  • bytecode/JumpTable.cpp:
  • profiler/ProfileNode.cpp:
  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/Identifier.h:

(JSC::Identifier::equal):

  • runtime/UString.cpp:
  • runtime/UString.h:

(WTF::):

  • runtime/UStringImpl.cpp: Removed.
  • runtime/UStringImpl.h:
  • wtf/text/StringHash.h:

(WebCore::StringHash::equal):
(WebCore::CaseFoldingHash::equal):

  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::empty):
(WebCore::StringImpl::sharedBuffer):
(WebCore::equal):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
(WebCore::StringImpl::cost):
(WebCore::StringImpl::isIdentifier):
(WebCore::StringImpl::setIsIdentifier):
(WebCore::StringImpl::computeHash):
(WebCore::StringImpl::copyChars):
(WebCore::StringImpl::):

JavaScriptGlue: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add forwarding header.

Reviewed by Oliver Hunt, Darin Adler.

  • ForwardingHeaders/wtf/ASCIICType.h: Added.
  • ForwardingHeaders/wtf/text/StringImpl.h: Added.

WebCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add include for StringHash.h.

Reviewed by Oliver Hunt, Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/c/c_class.cpp:
12:08 PM Changeset in webkit [58000] by Laszlo Gombos
  • 2 edits in trunk/WebKitTools

2010-04-21 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] [Symbian] Build fix.

Work around a Qt quirk. Some versions of Symbian port Qt
QFontDatabase::removeAllApplicationFonts symbol is not available.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
11:32 AM Changeset in webkit [57999] by ap@apple.com
  • 3 edits in trunk/WebKitTools

Unreviewed.

​https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
a real implementation may or may not be necessary for the one test that currently uses it
to pass.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::authenticateSession):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:29 AM Changeset in webkit [57998] by mitz@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bug URL

11:14 AM Changeset in webkit [57997] by ap@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

  • platform/qt/Skipped: Skip the new test on Qt. There is nothing special about it, existing related tests are skipped already.
11:11 AM Changeset in webkit [57996] by ap@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::createNSURLConnection): Fixed a typo, named an argument. (WebCore::ResourceHandle::start): Moved shouldUseCredentialStorage out of #if, since it's now passed to createNSURLConneciton() on all platforms (and then ignored on Tiger).
11:07 AM Changeset in webkit [57995] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Windows build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp: Declare CFURLConnectionCreateWithProperties for now, as it's mistakenly missing from WebKitSupportLibrary headers.
10:34 AM Changeset in webkit [57994] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test.
​https://bugs.webkit.org/show_bug.cgi?id=37902

The issue is due to MSVC creating enums as signed. The fix is to store the value
as unsigned.

Test: ​http://acid3.acidtests.org/

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags): Changed type of _insideLink to unsigned.
10:33 AM Changeset in webkit [57993] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

Test: http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html

This improves integration between ResourceHandle and Apple networking libraries.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createConnectionProperties): A new helper for creating connection properties dictionary. (WebCore::ResourceHandle::start): Pass connection properties. (WebCore::WebCoreSynchronousLoader::load): Ditto.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::createNSURLConnection): Factor out OS version dependent code for creating NSURLConnection. Tell NSURLConnection about credential policy upfront. (WebCore::ResourceHandle::start): Use the new function. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
10:30 AM Changeset in webkit [57992] by xji@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-21 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dimitri Glazkov

This patch fixes [chromium] RTL <select> dropdown box expands to right
instead of left.
​https://bugs.webkit.org/show_bug.cgi?id=37232

No automatic test is possible.

  • manual-tests/select_dropdown_box_alignment.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layout): Adjust the x-axis of dropdown box for RTL.
10:21 AM Changeset in webkit [57991] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-21 anton muhin <​antonm@google.com>

Reviewed by Adam Barth.

[v8] Bail out if fetching of Object.prototype fails.
​https://bugs.webkit.org/show_bug.cgi?id=37661

If for any reason we failed to fetch Object.prototype, context cannot
be properly initialized and we bail out.

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): bail out if installHiddenObjectPrototype failed (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): bail out if failed to fetch Object.prototype
  • bindings/v8/V8DOMWindowShell.h: return false if installHiddenObjectPrototype failed
9:40 AM Changeset in webkit [57990] by timothy@apple.com
  • 2 edits in trunk/WebCore

Make UserContentURLPattern correctly check for subdomains and the URL
has the same suffix as the pattern. Also improve the parsing of the host.

​https://bugs.webkit.org/show_bug.cgi?id=37357

Reviewed by Darin Adler.

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
simply check for "*" only or a "*." prefix and then do a substring.
(WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
position before the suffix to ensure it a subdomain and not just a suffix match.

9:02 AM Changeset in webkit [57989] by jwieczorek@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-21 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

Skip the new fast/lists tests on Mac and Windows until these ports
implement LayoutTestController::markerTextForListItem().

  • platform/mac/Skipped:
  • platform/win/Skipped:
8:57 AM Changeset in webkit [57988] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Make DRT compilable in Chromium tree
​https://bugs.webkit.org/show_bug.cgi?id=37923

We need to use different GYPs in a case of WebKit-only checkout
and a case of whole Chromium checkout because the relative paths
from webkit/ to WebKit/chromium/features.gypi are different in
these cases and we can't use 'conditions' for 'includes' in GYPs.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
8:43 AM Changeset in webkit [57987] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Xan Lopez <​xlopez@igalia.com>

Try to fix compilation on GTK+ debug bots.

  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper):
8:41 AM Changeset in webkit [57986] by jwieczorek@webkit.org
  • 23 edits
    13 adds in trunk

List item markers are not always updated after changes in the DOM.
​https://bugs.webkit.org/show_bug.cgi?id=37060

Reviewed by Darin Adler.

WebCore:

In particular, they would not be updated when adding/removing an item
that is not a direct child of the list element.

Tests: fast/lists/ol-nested-items-dynamic-insert.html

fast/lists/ol-nested-items-dynamic-remove.html
fast/lists/ol-nested-items.html
fast/lists/ol-nested-list-dynamic-insert.html
fast/lists/ol-nested-list-dynamic-remove.html
fast/lists/ol-nested-list.html

  • rendering/RenderListItem.cpp:

(WebCore::updateListMarkerNumbers): Change it to traverse the whole subtree of a list, not only siblings of an item.

  • rendering/RenderListItem.h:
  • rendering/RenderObject.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.

(WebCore::RenderObject::addChild): Move the code updating list markers to RenderObjectChildList for consistency.

  • rendering/RenderObjectChildList.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.

(WebCore::RenderObjectChildList::removeChildNode): Pass the actual node being removed, not the next sibling.
(WebCore::RenderObjectChildList::appendChildNode): Pass the actual node being added, not the next sibling.
(WebCore::RenderObjectChildList::insertChildNode): Pass the actual node being added, not the next sibling.

  • rendering/RenderTreeAsText.cpp:

(WebCore::markerTextForListItem):

WebKit/gtk:

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

(webkit_web_frame_marker_text_for_list_item): Add a private API to get the marker text for a list item.

WebKit/qt:

  • Api/qwebelement.h: Make DumpRenderTreeSupportQt a friend class.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::markerTextForListItem): Add a private API to get the marker text for a list item.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(markerTextForListItemCallback): A function that returns the marker text for a given list item.
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::markerTextForListItem): Implement it in the GTK port.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::markerTextForListItem): Add a stub.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::markerTextForListItem): Implement it in the Qt port.

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::markerTextForListItem): Add a stub.

LayoutTests:

  • fast/lists/dump-list.js:

(indent):
(dumpListHelper): A recursive function to dump nested lists.
(dumpList): A function that dumps a readable plain text representation of a list.

  • fast/lists/ol-nested-items-dynamic-insert-expected.txt: Added.
  • fast/lists/ol-nested-items-dynamic-insert.html: Added.
  • fast/lists/ol-nested-items-dynamic-remove-expected.txt: Added.
  • fast/lists/ol-nested-items-dynamic-remove.html: Added.
  • fast/lists/ol-nested-items-expected.txt: Added.
  • fast/lists/ol-nested-items.html: Added.
  • fast/lists/ol-nested-list-dynamic-insert-expected.txt: Added.
  • fast/lists/ol-nested-list-dynamic-insert.html: Added.
  • fast/lists/ol-nested-list-dynamic-remove-expected.txt: Added.
  • fast/lists/ol-nested-list-dynamic-remove.html: Added.
  • fast/lists/ol-nested-list-expected.txt: Added.
  • fast/lists/ol-nested-list.html: Added.
  • platform/mac/Skipped: Skip the tests until this port implements the new LayoutTestController function.
  • platform/win/Skipped: Skip the tests until this port implements the new LayoutTestController function.
8:24 AM Changeset in webkit [57985] by xan@webkit.org
  • 6 edits
    9 adds in trunk

2010-04-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Adam Barth.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Add build bits for the GObject DOM bindings.

  • GNUmakefile.am:

2010-04-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Adam Barth.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Initial version of the GObject DOM bindings.

Only bindings for Node.idl and a few of its dependencies are
provided, without public API to access them at the
moment. References to the Document interfaces and to
EventListeners in Node.idl are ignored for GObject to make the
initial patch as small as possible, but will be enabled in a
follow-up patch.

  • GNUmakefile.am:
  • bindings/gobject/ConvertToUTF8String.cpp: Added. (convertToUTF8String):
  • bindings/gobject/ConvertToUTF8String.h: Added.
  • bindings/gobject/WebKitDOMBinding.cpp: Added. (WebKit::domObjects): (WebKit::DOMObjectCache::get): (WebKit::DOMObjectCache::put): (WebKit::DOMObjectCache::forget): (WebKit::createWrapper): (WebKit::kit):
  • bindings/gobject/WebKitDOMBinding.h: Added.
  • bindings/gobject/WebKitDOMObject.cpp: Added. (webkit_dom_object_init): (webkit_dom_object_class_init):
  • bindings/gobject/WebKitDOMObject.h: Added.
  • bindings/scripts/CodeGeneratorGObject.pm: Added.
  • bindings/scripts/gobject-generate-headers.pl: Added.
  • dom/Node.idl:
8:18 AM Changeset in webkit [57984] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Xan Lopez.

Wrong header being included in FontPlatformDataCairo.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37829

No behavior changes, so no new tests were added.

  • platform/graphics/cairo/FontPlatformDataCairo.cpp:
8:08 AM Changeset in webkit [57983] by Adam Roben
  • 2 edits in trunk/WebKitTools

Exclude leaks in CGGradientCreateWithColorComponents from run-webkit-tests leaks output

The leak in CG is covered by <rdar://problem/7888492>.

Fixes <​http://webkit.org/b/37927>.

Reviewed by Eric Carlson.

  • Scripts/old-run-webkit-tests:

(sub countAndPrintLeaks): Exclude leaks in
CGGradientCreateWithColorComponents on certain OSs.

8:08 AM Changeset in webkit [57982] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-21 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Check the request empty or not in ChromeClientQt::createWindow()
​https://bugs.webkit.org/show_bug.cgi?id=37821

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
7:43 AM Changeset in webkit [57981] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-04-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Import MockSpellCheck from Chromium
​https://bugs.webkit.org/show_bug.cgi?id=37910

Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add ICU explicitly because WTFString.h includes ICU headers. Add MockSpellCheck.{cpp,h}.
  • DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
  • DumpRenderTree/chromium/MockSpellCheck.h: Added.
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
7:42 AM Changeset in webkit [57980] by Adam Roben
  • 2 edits in trunk/WebCore

Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter

Fixes <​http://webkit.org/b/37922>.

Reviewed by Dave Hyatt.

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
hold the heap-allocated FilterData object, so that we won't leak it
when we bail out of this function on error.

7:34 AM Changeset in webkit [57979] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] startAnimation() is not needed to preceede nativeImageForCurrentFrame()
​https://bugs.webkit.org/show_bug.cgi?id=37844

nativeImageForCurrentFrame() resets the m_decoder parameter under Qt,
which is required by startAnimation() to detect frame and repetition counts.
Hence, Image::drawTiled cannot start animations under Qt:
<html><body background="animated.gif"></body></html> does not work

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
7:09 AM Changeset in webkit [57978] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-04-21 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Added missing #include "Lookup.h" in LUT source files.
​https://bugs.webkit.org/show_bug.cgi?id=XXXXX

  • runtime/ArrayPrototype.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/JSONObject.cpp:
  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/StringPrototype.cpp:
6:52 AM Changeset in webkit [57977] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add webkit-patch pretty-diff
​https://bugs.webkit.org/show_bug.cgi?id=37892

This is slightly lame because it asks you whether the diff is correct,
but it's a starting point.

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/prettydiff.py: Added.
  • Scripts/webkitpy/tool/main.py:
6:42 AM Changeset in webkit [57976] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] media/video-source-add-src.html was removed from tree
by r57820, so it's time to remove it from Qt Skipped list.

  • platform/qt/Skipped: media/video-source-add-src.html removed.
6:42 AM Changeset in webkit [57975] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove mention of non-existant --no-build option
​https://bugs.webkit.org/show_bug.cgi?id=37893

The option doesn't exist!

  • Scripts/webkitpy/tool/commands/stepsequence.py:
6:32 AM Changeset in webkit [57974] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-21 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
​https://bugs.webkit.org/show_bug.cgi?id=37198

  • QtLauncher/main.cpp: (LauncherWindow::toggleInterruptingJavaScriptEnabled): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
  • QtLauncher/webpage.cpp: (WebPage::WebPage): (WebPage::shouldInterruptJavaScript):
  • QtLauncher/webpage.h: (WebPage::setInterruptingJavaScriptEnabled):
6:17 AM Changeset in webkit [57973] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-21 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK_ROLE_FORM.

  • tests/testatkroles.c: (test_webkit_atk_get_role_form): (main):
6:08 AM Changeset in webkit [57972] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-21 Shu Chang <​chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix Symbian build where QT_NO_SYSTEMTRAYICON is defined.
​https://bugs.webkit.org/show_bug.cgi?id=37442

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show):
  • WebCoreSupport/NotificationPresenterClientQt.h:
5:57 AM Changeset in webkit [57971] by eric@webkit.org
  • 5 edits
    16 adds in trunk

2010-04-21 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Simon Fraser.

Update of fixed elements is not made correctly when the page has been scrolled
​https://bugs.webkit.org/show_bug.cgi?id=36783

  • fast/repaint/fixed-child-move-after-scroll.html: Added.
  • fast/repaint/fixed-child-of-fixed-move-after-scroll.html: Added.
  • fast/repaint/fixed-child-of-transformed-move-after-scroll.html: Added.
  • fast/repaint/fixed-move-after-scroll.html: Added.
  • platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/mac/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-move-after-scroll-expected.txt: Added.

2010-04-21 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Simon Fraser.

Update of fixed elements is not made correctly when the page has been scrolled
​https://bugs.webkit.org/show_bug.cgi?id=36783

When a fixed element was updated, the old geometry was not repainted correctly
because the repaint rect was cached during the layout and not updated when
scrolling.

The rect is now updated while scrolling so the region updated correspond to the
region of the element on the screen.

The method RenderLayer::updateRepaintRectsAfterScroll() updates
the repaint rect of all fixed tree after scroll.

Tests: fast/repaint/fixed-child-move-after-scroll.html

fast/repaint/fixed-child-of-fixed-move-after-scroll.html
fast/repaint/fixed-child-of-transformed-move-after-scroll.html
fast/repaint/fixed-move-after-scroll.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateRepaintRectsAfterScroll):
  • rendering/RenderLayer.h:
5:32 AM Changeset in webkit [57970] by eric@webkit.org
  • 9 edits in trunk

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Adam Roben.

Update EFL port to match recent API changes.
​http://webkit.org/b/37853

No behavior changes, so no new tests were added.

  • platform/efl/FileSystemEfl.cpp:
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::missingPluginText): (WebCore::crashedPluginText):
  • platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/graphics/efl/ImageEfl.cpp:

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Adam Roben.

Update EFL port to match recent API changes.
​http://webkit.org/b/37853

  • efl/WebCoreSupport/EditorClientEfl.cpp:
  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument): (WebCore::FrameLoaderClientEfl::objectContentType): (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons): (WebCore::FrameLoaderClientEfl::canShowMIMEType):
  • efl/WebCoreSupport/FrameLoaderClientEfl.h:
5:22 AM Changeset in webkit [57969] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Avi Drissman <​avi@chromium.org>

Reviewed by Simon Fraser.

JPG images fail to print in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=37796

Image sources of JPG data with final=false fail to draw into PDF contexts even if later updated (<rdar://problem/7874035>). Therefore, destroy and re-create the image source when the final data arrives.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
5:11 AM Changeset in webkit [57968] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Nikolas Zimmermann.

Add missing EFL JavaScriptCore file.
​http://webkit.org/b/37854

  • wtf/efl: Added.
  • wtf/efl/MainThreadEfl.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::timeoutFired): (WTF::scheduleDispatchFunctionsOnMainThread):
5:00 AM Changeset in webkit [57967] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-21 Marcus Bulach <​bulach@chromium.org>

Reviewed by Nate Chapin.

EventSource needs to be marked as an ActiveDomType.
​https://bugs.webkit.org/show_bug.cgi?id=37857
Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
4:14 AM Changeset in webkit [57966] by eric@webkit.org
  • 8 edits in trunk

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r57963.
​http://trac.webkit.org/changeset/57963
​https://bugs.webkit.org/show_bug.cgi?id=37759

Three tests started crashing on the Qt bot.

  • platform/qt/Skipped:

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r57963.
​http://trac.webkit.org/changeset/57963
​https://bugs.webkit.org/show_bug.cgi?id=37759

Three tests started crashing on the Qt bot.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r57963.
​http://trac.webkit.org/changeset/57963
​https://bugs.webkit.org/show_bug.cgi?id=37759

Three tests started crashing on the Qt bot.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
4:02 AM Changeset in webkit [57965] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Make new-run-webkit-tests work for the Qt port
​https://bugs.webkit.org/show_bug.cgi?id=37588

  • Scripts/webkitpy/layout_tests/port/qt.py:
3:57 AM Changeset in webkit [57964] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

new-run-webkit-tests: try to detect alternate apache path
​https://bugs.webkit.org/show_bug.cgi?id=37587

_check_port_build() also needs to return true in the
base implementation to not fail the check_build step.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:54 AM Changeset in webkit [57963] by eric@webkit.org
  • 8 edits in trunk

2010-04-21 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Unskip a bunch of now passing tests, which was skipped because of
missing LayoutTestController::computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

  • platform/qt/Skipped:

2010-04-21 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-21 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:44 AM Changeset in webkit [57962] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-21 Gustavo Sverzut Barbieri <​barbieri@profusion.mobi>

Reviewed by Nikolas Zimmermann.

Add missing includes to platform/posix/FileSystemPOSIX.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37861

No behavior changes, so no new tests were added.

  • platform/posix/FileSystemPOSIX.cpp:
3:09 AM Changeset in webkit [57961] by eric@webkit.org
  • 9 edits in trunk

2010-04-21 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

[Qt] Fix or remove the runtime flag for accelerated compositing.

This adds a way for a chrome client to disallow layers from becoming composited,
even if the settings enable accelerated compositing. This is necessary for platforms
where different views can be applied with the same settings to the same page.

We enable an API through ChromeClient to ask the chrome-client whether or not
it can render composited layers, which is taken into account when the compositor
decides whether or not to start compositing.

​https://bugs.webkit.org/show_bug.cgi?id=37313

Pages under LayoutTests/compositing now work under QWebView, even when
QWebSettings::AcceleratedCompositingEnabled is on.

  • page/ChromeClient.h: (WebCore::ChromeClient::allowsAcceleratedCompositing):
  • platform/qt/QWebPageClient.h: (QWebPageClient::allowsAcceleratedCompositing):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::canBeComposited):

2010-04-21 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

[Qt] Fix or remove the runtime flag for accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=37313

This lets the QWebPageClient "veto" the settings value for accelerated compositing.
In this case we allow accelerated compositing only on QGraphicsWebView.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::allowsAcceleratedCompositing):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
  • WebCoreSupport/ChromeClientQt.h:
2:48 AM Changeset in webkit [57960] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed, test fix only.

new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
​https://bugs.webkit.org/show_bug.cgi?id=37726

This change seems to have broken a test.
Attempting to handle the case where we don't have any
timing information. Dirk may have to correct this change.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:24 AM Changeset in webkit [57959] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

No review. Spurious whitespace was removed from project file.

  • WebCore.xcodeproj/project.pbxproj:
12:57 AM Changeset in webkit [57958] by alex
  • 2 edits in trunk/LayoutTests

2010-04-21 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping fast/frames/frame-crash-with-page-cache.html
​https://bugs.webkit.org/show_bug.cgi?id=37914

  • platform/gtk/Skipped:
12:46 AM Changeset in webkit [57957] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37912

Reviewed by Eric Seidel.

Replaced the ternary operator by an if statement because GCC was confused by the use of
ternary operator and producing warnings on Qt builds.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs):

Apr 20, 2010:

11:55 PM Changeset in webkit [57956] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests has much higher startup latency than run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=37643

I got rid of the -expected.checksum reads during startup.
This makes startup noticably better on my laptop.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Use image_hash() instead of .image_hash now that expected.checksum file reads are done lazily.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
    • Add debug logging for this sleep call. In my testing I never saw this sleep() hit.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Sleep a shorter interval to make websocket server startup more responsive. On my machine startup was taking around 1 second.
    • Remove the unconditional .5s delay on startup.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Make image_hash file reads done lazily in a new image_hash() function.
    • Add a "Starting testing ..." meter update after DRT threads have been started, but before we get updates from the first one.
    • Rename variable "t" to a full english name to match WebKit style.
11:41 PM Changeset in webkit [57955] by oliver@apple.com
  • 14 edits
    3 adds in trunk

2010-04-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

[ES5] RegExp literals are constants that should be persistent across multiple function calls.
​https://bugs.webkit.org/show_bug.cgi?id=37908

Dump the separate RegExp constant pool, and just use the standard JS constant pool
in codeblock. This allows us to drop op_new_regexp and all associated code as well.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::):

2010-04-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

[ES5] RegExp literals are constants that should be persistent across multiple function calls.
​https://bugs.webkit.org/show_bug.cgi?id=37908

Add tests to ensure correct persistence of RegExp literals, and correctly avoid
sharing "identical" regexps used in different places.

  • fast/js/regexp-literals-are-constants-expected.txt: Added.
  • fast/js/regexp-literals-are-constants.html: Added.
  • fast/js/script-tests/regexp-literals-are-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
10:54 PM Changeset in webkit [57954] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
​https://bugs.webkit.org/show_bug.cgi?id=19539

Reviewed by Justin Garcia.

WebCore:

Fixes a bug where two consecutive lists are not merged if they have been converted
from ordered/unordered lists inside another list.

The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
list element and its neighbors. This patch adds code to doApply so that after inserting
the list element, it updates previousList and nextList to the outermost list elements around
insertionPos under the same enclosing list. Because the next and the previous list elements
are not necessarily visually next to the newly inserted element before moveParagraph moves
the paragraph into the new list element, doApply merges lists after moveParagraph is called.

Test: editing/execCommand/insert-lists-inside-another-list.html

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply): Modified as described above

  • editing/htmlediting.cpp:

(WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,

which is a descendent of rootNode.

  • editing/htmlediting.h:

LayoutTests:

Test to make sure InsertListCommand merges consecutive lists when converting
ordered/unordered lists to the opposite type of lists inside another list.

  • editing/execCommand/insert-lists-inside-another-list-expected.txt: Added.
  • editing/execCommand/insert-lists-inside-another-list.html: Added.
  • editing/execCommand/script-tests/insert-lists-inside-another-list.js: Added.

(testList):

  • platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt:
10:48 PM Changeset in webkit [57953] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-04-20 Simon Fraser <Simon Fraser>

Fix test result after r57913.

  • compositing/iframes/composited-iframe-expected.txt:
10:25 PM Changeset in webkit [57952] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-20 Yuzo Fujishima <​yuzo@google.com>

Unreviewed test skipping for Chromium Win.

Skip editing/pasteboard/copy-backslash-with-euc.html for Chromium Win.
​https://bugs.webkit.org/show_bug.cgi?id=36419

  • platform/chromium/test_expectations.txt:
9:55 PM Changeset in webkit [57951] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37776
<rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes

  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping for Roman letters and punctuation.
  • platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak) also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes to their keycodes.
9:11 PM Changeset in webkit [57950] by hamaji@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix a ChangeLog entry.

9:09 PM Changeset in webkit [57949] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-20 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

A backslash in EUC-JP becomes to a yen sign when it is copied
​https://bugs.webkit.org/show_bug.cgi?id=36419

Add editing/pasteboard/copy-backslash-with-euc into Gtk's skipped list.

  • platform/gtk/Skipped:
8:54 PM Changeset in webkit [57948] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-20 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:31 PM Changeset in webkit [57947] by tkent@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Import Chromium image_diff as ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=37790

ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
6:13 PM Changeset in webkit [57946] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-20 Xan Lopez <​xlopez@igalia.com>

Another attempt to fix the build.

  • GNUmakefile.am:
6:13 PM Changeset in webkit [57945] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Don't paint the web page before we've blit the last update chunk to the backing store.

Reviewed by Sam Weinig.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didUpdate):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:
5:54 PM Changeset in webkit [57944] by xan@webkit.org
  • 2 edits in trunk

2010-04-20 Xan Lopez <​xlopez@igalia.com>

Build fix?

  • autotools/webkit.m4:
5:50 PM Changeset in webkit [57943] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix license on create_regex_tables

5:47 PM Changeset in webkit [57942] by oliver@apple.com
  • 2 edits in trunk

Fix gtk

5:09 PM Changeset in webkit [57941] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::receivedData):

4:51 PM Changeset in webkit [57940] by hamaji@chromium.org
  • 12 edits
    5 adds in trunk

2010-04-20 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Alexey Proskuryakov.

A backslash in EUC-JP becomes to a yen sign when it is copied
​https://bugs.webkit.org/show_bug.cgi?id=36419

  • editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
  • editing/execCommand/transpose-backslash-with-euc.html: Added.
  • editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
  • editing/pasteboard/copy-backslash-with-euc.html: Added.
  • editing/pasteboard/resources/copy-backslash-euc.html: Added.

2010-04-20 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler and Alexey Proskuryakov.

A backslash in EUC-JP becomes to a yen sign when it is copied
​https://bugs.webkit.org/show_bug.cgi?id=36419

Tests: editing/execCommand/transpose-backslash-with-euc.html

editing/pasteboard/copy-backslash-with-euc.html

  • editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls. (WebCore::Editor::addToKillRing):
  • editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::init): (WebCore::TextIterator::emitText): (WebCore::plainTextToMallocAllocatedBuffer):
  • editing/TextIterator.h: (WebCore::):
  • platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::Pasteboard::writeSelection):
  • platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
  • rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding (WebCore::RenderText::RenderText): (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::styleDidChange): (WebCore::isInlineFlowOrEmptyText): (WebCore::RenderText::previousCharacter): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::textWithoutTranscoding): (WebCore::RenderText::transformText):
  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter):
  • rendering/RenderTextFragment.h:
4:42 PM Changeset in webkit [57939] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-20 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, updating Chromium test_expectations for media/video-zoom.html.

  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [57938] by jamesr@google.com
  • 2 edits
    1 move
    2 deletes in trunk/LayoutTests

2010-04-20 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium expectations. Also consolidate identical
platform expectations for fast/dom/prototype-inheritance.html.

  • platform/chromium-linux/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt.
  • platform/chromium/test_expectations.txt:
4:22 PM Changeset in webkit [57937] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix gtk

4:18 PM Changeset in webkit [57936] by Nate Chapin
  • 4 edits in trunk/WebCore

2010-04-20 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=37367

Fix style violations in code generated by CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/test/V8TestObj.cpp:
  • bindings/v8/test/V8TestObj.h:
3:57 PM Changeset in webkit [57935] by Csaba Osztrogonác
  • 10 edits in trunk

Unreviewed, rolling out r57924.
​http://trac.webkit.org/changeset/57924
​https://bugs.webkit.org/show_bug.cgi?id=37898

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2010-04-20
It broke 3-4 test on all bot (Requested by Ossy on #webkit).

WebCore:

  • page/AbstractView.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::media):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/print-restores-previous-mediatype-expected.txt:
  • fast/media/print-restores-previous-mediatype.html:
3:43 PM Changeset in webkit [57934] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-20 Dirk Pranke <​dpranke@chromium.org>

This patch to new-run-webkit-tests adds a --log 'trace' option
that prints out detailed info about a given test as it executes
(where the baselines are, what the expectation is, what we got,
how long it took).

​https://bugs.webkit.org/show_bug.cgi?id=37726

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • use the newly exposed TestResult class and implement --log trace
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
    • rename TestStats to TestResult and make it more public, resulting in cleaner code
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
    • add expectation_to_string() as a separate callable function
3:38 PM Changeset in webkit [57933] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-04-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't paint the web page before we've blit the last update chunk to the backing store
​https://bugs.webkit.org/show_bug.cgi?id=37896

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::):
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): (WebKit::DrawingAreaProxyUpdateChunk::update): (WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::scheduleDisplay): (WebKit::DrawingAreaUpdateChunk::setSize): (WebKit::DrawingAreaUpdateChunk::didUpdate): (WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
3:34 PM Changeset in webkit [57932] by barraclough@apple.com
  • 7 edits
    1 copy
    2 adds in trunk

JavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl

Reviewed by Oliver Hunt.

The implementation of StringImpl & UStringImpl is very similar. Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.

(JSC::RopeImpl::RopeImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):

  • wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.

(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):

JavaScriptGlue: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/text/StringImplBase.h: Added.

WebCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/text/StringImplBase.h: Added.
3:26 PM Changeset in webkit [57931] by abarth@webkit.org
  • 4 edits in trunk

2010-04-20 Adam Barth <​abarth@webkit.org>

Unreviewed build fix fro Chromium.

  • loader/DocumentWriter.cpp:

2010-04-20 Adam Barth <​abarth@webkit.org>

Unreviewed build fix.

  • Api/qwebframe.cpp: (QWebFrame::setUrl):
3:24 PM Changeset in webkit [57930] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-04-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.

​https://bugs.webkit.org/show_bug.cgi?id=37820

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptLine):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._cancelEditingLine):
3:24 PM Changeset in webkit [57929] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-04-20 Simon Fraser <Simon Fraser>

Test fix, no review.

Disable compositing/iframes/composited-iframe.html because compositing is
turned off at runtime on Leopard (based on QuickTime version), so we can't
rely on the result.

  • platform/mac-leopard/Skipped:
3:19 PM Changeset in webkit [57928] by jamesr@google.com
  • 35 edits
    2 adds
    43 deletes in trunk/LayoutTests

2010-04-20 James Robinson <​jamesr@chromium.org>

Reviewed by dglazkov.

Update chromium SVG baselines for r57886
​https://bugs.webkit.org/show_bug.cgi?id=37891

  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/non-opaque-filters-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/visibility-override-filter-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feMerge-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feOffset-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/custom/empty-merge-expected.txt: Removed.
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/visibility-override-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/chromium-win/svg/filters/big-sized-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/feComposite-expected.txt:
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feMerge-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feMerge-wrong-input-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feOffset-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feTile-expected.txt: Removed.
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:12 PM Changeset in webkit [57927] by abarth@webkit.org
  • 41 edits
    2 adds in trunk

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Added.
  • loader/DocumentWriter.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):
3:09 PM Changeset in webkit [57926] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::chooseIconForFiles):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
3:05 PM Changeset in webkit [57925] by oliver@apple.com
  • 13 edits
    1 add in trunk/JavaScriptCore

2010-04-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Autogenerate yarr character tables
​https://bugs.webkit.org/show_bug.cgi?id=37877

Use a python script to automatically generate character tables
for the builtin YARR character classes. This allows us to generate
actual tables as well, by using these tables we can both increase
performance of the check (for complex builtins) and reduce the actual
code size.

4-8% win on string-unpack-code, but lots of noise on other tests so
i'm only confident saying its a 1% win overall.

  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::branchTest8):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchTest8):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::branchTest8):
  • assembler/X86Assembler.h: (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump):
  • create_regex_tables: Added.
  • yarr/RegexCompiler.cpp: (JSC::Yarr::CharacterClassConstructor::charClass):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::matchCharacterClass): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
  • yarr/RegexPattern.h: (JSC::Yarr::CharacterClassTable::create): (JSC::Yarr::CharacterClassTable::CharacterClassTable): (JSC::Yarr::CharacterClass::CharacterClass):
3:04 PM Changeset in webkit [57924] by kenneth@webkit.org
  • 10 edits in trunk

Rename window.media to window.styleMedia
​https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Simon Fraser.

WebCore:

It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.

  • page/AbstractView.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::styleMedia):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Update layout tests.

  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/print-restores-previous-mediatype.html:
2:50 PM Changeset in webkit [57923] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix matching of "​file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.

Also fix comparisons to be case insensitive.

​https://bugs.webkit.org/show_bug.cgi?id=37889

Reviewed by Dave Hyatt.

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.

2:42 PM Changeset in webkit [57922] by Nate Chapin
  • 6 edits
    4 adds in trunk

2010-04-20 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
​https://bugs.webkit.org/show_bug.cgi?id=37331

Added a setting to enable/disable media per-page and have the SVGImage
disable media for its dummy page. Also found and fixed a related bad
cast in the V8 bindings (JSC had a custom wrapper for this already).

Tests: media/svg-as-image-with-media-blocked.html

2:32 PM Changeset in webkit [57921] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
​https://bugs.webkit.org/show_bug.cgi?id=37802

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.

No behavior change, it is just a safe assignment shortcut.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

2:29 PM Changeset in webkit [57920] by eric@webkit.org
  • 32 edits in trunk/WebKitTools

2010-04-20 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r57907.
​http://trac.webkit.org/changeset/57907
​https://bugs.webkit.org/show_bug.cgi?id=37765

Appears to have broken MacEWS and possibly webkit-patch upload
for svn users. Needs further investigation.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/prettypatch.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/deprecated_logging.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
2:24 PM Changeset in webkit [57919] by Simon Fraser
  • 9 edits
    5 adds in trunk

2010-04-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Hook compositing layers together across iframes
​https://bugs.webkit.org/show_bug.cgi?id=37878

First step: if an iframe's document goes into compositing mode, also throw the parent
document into compositing mode (all the way up to the root). This is required both
to preserve layering (since parent document content can obscure iframe content),
and so that we can eventually hook the layer trees together.

Test: compositing/iframes/composited-iframe.html

  • rendering/RenderIFrame.h:
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have a RenderLayer, so must return |true| from requiresLayer(). (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document is in compositing mode. (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check if a renderer is an iframe. (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when the compositing mode changes, so that the parent document can update its compositing status. (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame(). (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe wants to be composited.
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderIFrame): Base class returns false.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify its parent document that a recalcStyle is required, to update compositing state.
2:17 PM Changeset in webkit [57918] by Nate Chapin
  • 2 edits in trunk/WebKitTools

2010-04-20 Nate Chapin <Nate Chapin>

Unreviewed.

Update my irc handle in committers.py (natechapin -> japhet).

  • Scripts/webkitpy/common/config/committers.py:
2:13 PM Changeset in webkit [57917] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix - missed a bit!).

2:12 PM Changeset in webkit [57916] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

worker-close.html is flaky on slow machines.
​https://bugs.webkit.org/show_bug.cgi?id=37887

Reviewed by Adam Barth.

  • fast/workers/worker-close.html: Move the start of the timer to terminate the test after an expected message is received.
2:03 PM Changeset in webkit [57915] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-20 James Robinson <​jamesr@chromium.org>

Unreviewed. Another round of chromium test expectation SVG updates.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [57914] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix).

1:41 PM Changeset in webkit [57913] by Simon Fraser
  • 4 edits in trunk

2010-04-20 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

backgroundColor is oddly indented in layer tree dump
​https://bugs.webkit.org/show_bug.cgi?id=37885

The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
to be written twice.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
1:33 PM Changeset in webkit [57912] by barraclough@apple.com
  • 10 edits
    2 copies
    1 add in trunk

JavaScriptCore: Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

WebCore: Speculative tiger build fix.

Reviewed by NOBODY (build fix).

  • WebCore.NPAPI.exp:
  • WebCore.PluginHostProcess.exp:
  • WebCore.base.exp:
1:23 PM Changeset in webkit [57911] by barraclough@apple.com
  • 4 edits in trunk/WebCore

Speculative tiger build fix.

Reviewed by NOBODY (build fix).

  • WebCore.NPAPI.exp:
  • WebCore.PluginHostProcess.exp:
  • WebCore.base.exp:
1:22 PM Changeset in webkit [57910] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-20 James Robinson <​jamesr@chromium.org>

Unreviewed. Fix typo in chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:18 PM Changeset in webkit [57909] by pfeldman@chromium.org
  • 13 edits in trunk

2010-04-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add basic script editing capabilities to the front-end.

​https://bugs.webkit.org/show_bug.cgi?id=37875

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._editLine): (WebInspector.ScriptView.prototype._editLineComplete):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.canEditScripts): (WebInspector.ScriptsPanel.prototype.editScriptLine):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.updateContent): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.reset):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.copyRange):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set editCallback): (WebInspector.TextViewer.prototype._buildChunks): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._commitEditingLine): (WebInspector.TextViewer.prototype._cancelEditingLine):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.isEditingAnyField): (WebInspector.startEditing.cleanUpAfterEditing):

2010-04-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add basic script editing capabilities to the front-end.

​https://bugs.webkit.org/show_bug.cgi?id=37875

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.editScriptLine): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
  • src/js/DevTools.js:
  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.editScriptLine):
1:06 PM Changeset in webkit [57908] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

12:54 PM Changeset in webkit [57907] by eric@webkit.org
  • 32 edits in trunk/WebKitTools

2010-04-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.

This fixes our Executive.run_command code to work around a Popen
bug ​http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.

Following the advice of:
​http://farmdev.com/talks/unicode/
I'm attempting to take the python unicode plunge and use unicode()
objects as strings instead of str() objects everywhere in webkitpy.

We do not have to use u"" instead of "" because u"a" == "a" as expected
in Python. Python will generate a warning to the console in cases where
a unicode() == str() operation cannot be performed.

I also cleaned up the input handling in run_command a little by adding
a new _compute_input() method which can return early instead of having
such a long/cluttered if-block.

Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.

All places which use StringIO need to be sure to pass StringIO a
pre-encoded byte-array (str object) instead of unicode so that
clients which read from the StringIO don't have encoding exceptions.
To make this easier, I removed the patch_file_object support from
add_patch_to_bug, and changed the 4 places which previously used
StringIO to create a fake patch file.

I attempted to document any places where we are not correctly converting
to/from bytes (str() objects) to strings (unicode() objects).

  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Read/write utf-8 files instead of ascii.
    • Update the tests to use test for proper unicode() handling.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
    • Use unicode() strings instead of str() byte arrays.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Remove use of str().
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Read/write utf-8 files and use unicode() strings in testing.
  • Scripts/webkitpy/common/config/committers.py:
    • Use \u instead of \x to make slightly clearer what we're doing.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Add a new _string_contents() method and explain why we have to call unicode() on the result of soup.string and why it's safe to do so w/o needing to pass a codec name.
    • Remove the (unused) support for passing a file object to add_patch_to_bug().
  • Scripts/webkitpy/common/net/buildbot.py:
    • Use unicode() instead of str() when needing to coax a NavigableString object into a unicode() object.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Remove use of str()
  • Scripts/webkitpy/common/prettypatch.py:
    • Write out the patch file as utf-8.
  • Scripts/webkitpy/common/system/autoinstall.py:
    • Add a FIXME about encoding.
  • Scripts/webkitpy/common/system/deprecated_logging.py:
    • Document that tee() works on bytes, not strings.
  • Scripts/webkitpy/common/system/executive.py:
    • Make run* properly take and return unicode() objects.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Added a unit test to make sure we don't break Tor again!
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Write out the test list as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
    • Write out json files as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • Add FIXME about encoding handling.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/mocktool.py:
    • Rename add_patch_to_bug argument to match bugzilla.py
  • Scripts/webkitpy/tool/steps/postdiff.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Fixed spurious logging seen when running test-webkitpy
12:52 PM Changeset in webkit [57906] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-20 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium test expectations to reflect changes
in SVG tests from r57886.

  • platform/chromium/test_expectations.txt:
12:42 PM PythonGuidelines edited by Chris Jerdonek
Stubbed out section on strings and unicode. (diff)
12:34 PM Changeset in webkit [57905] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-20 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

For check-webkit-style, implemented eq() and ne() (the
built-in equality and inequality methods) for the
DefaultStyleErrorHandler class.

​https://bugs.webkit.org/show_bug.cgi?id=37850

This will facilitate unit-testing for a subsequent patch,
namely for ​https://bugs.webkit.org/show_bug.cgi?id=37850

  • Scripts/webkitpy/style/error_handlers.py:
    • Added eq() and ne() to the DefaultStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added unit tests for eq() and ne().
    • Also included a minor clean-up refactoring of combining the StyleErrorHandlerTestBase class (which has not needed to be separate due to previous changes) into the DefaultStyleErrorHandlerTest class.
12:28 PM Changeset in webkit [57904] by barraclough@apple.com
  • 26 edits
    7 copies
    3 moves
    7 adds in trunk

Bug 37828 - Move WebCore's String classes to WTF

Reviewed by Geoff Garen.

Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).

As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").

JavaScriptCore:

Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
  • wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
  • wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
  • wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
  • wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
  • wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
  • wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
  • wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
  • wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.

(WebCore::charactersToFloat):

  • wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.

WebCore:

Moving the files, but leaving the classes logically in the WebCore namespace –
which is technically a layering violation – I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • ForwardingHeaders/wtf/StaticConstructors.h: Added.
  • ForwardingHeaders/wtf/text/AtomicString.h: Added.
  • ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
  • ForwardingHeaders/wtf/text/StringBuffer.h: Added.
  • ForwardingHeaders/wtf/text/StringHash.h: Added.
  • ForwardingHeaders/wtf/text/StringImpl.h: Added.
  • ForwardingHeaders/wtf/text/WTFString.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/MediaFeatureNames.cpp:
  • dom/QualifiedName.cpp:
  • dom/make_names.pl:
  • platform/StaticConstructors.h: Removed.
  • platform/text/AtomicString.cpp: Removed.
  • platform/text/AtomicString.h:
  • platform/text/AtomicStringImpl.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringHash.h:
  • platform/text/StringImpl.cpp: Removed.
  • platform/text/StringImpl.h:
12:20 PM Changeset in webkit [57903] by eric@webkit.org
  • 26 edits in trunk

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
to FileChooser*. Though an implementation of chooseIconForFiles()
might have ownership of the FileChooser instance, we don't need to
use PassRefPtr<> in this case.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::chooseIconForFiles):
  • page/Chrome.cpp: (WebCore::Chrome::chooseIconForFiles):
  • page/Chrome.h:
  • page/ChromeClient.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/ChromeClientImpl.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::chooseIconForFiles):
  • WebCoreSupport/ChromeClientGtk.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
  • WebCoreSupport/ChromeClientHaiku.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
  • WebCoreSupport/ChromeClientQt.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
  • WebCoreSupport/WebChromeClient.h:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
​https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
  • WebKitSupport/ChromeClientWx.h:
12:08 PM Changeset in webkit [57902] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-20 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Implement ATK_ROLE_FORM.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
11:52 AM Changeset in webkit [57901] by Martin Robinson
  • 9 edits
    1 add in trunk

2010-04-20 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::collapseSelection): Converted this logic to a GClosure callback. (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now.
  • WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore. (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list. (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list. (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids. (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard.
  • WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality.

2010-04-20 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.

No new tests as functionality has not changed.

  • GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
  • platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
  • platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming. (WebCore::clipboard_get_contents_cb): Ditto. (WebCore::Pasteboard::helper): Added, member is now private. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::documentFragment): Update to reflect method renaming. (WebCore::Pasteboard::plainText): Ditto.
  • platform/gtk/PasteboardHelper.cpp: Added. (WebCore::PasteboardHelper::PasteboardHelper): Added. (WebCore::PasteboardHelper::~PasteboardHelper): Added. (WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit. (WebCore::widgetFromFrame): Added helper function. (WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit. (WebCore::PasteboardHelper::getClipboard): Ditto. (WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto. (WebCore::PasteboardHelper::targetList): Ditto. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::targetListForDataObject): Ditto. (WebCore::getClipboardContentsCallback): Ditto. (WebCore::clearClipboardContentsCallback): Ditto. (WebCore::PasteboardHelper::writeClipboardContents): Ditto.
  • platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
11:22 AM Changeset in webkit [57900] by Simon Fraser
  • 12 edits
    2 deletes in trunk/WebCore

2010-04-20 Simon Fraser <Simon Fraser>

Reviewed by Dimitri Glazkov.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

RenderPartObject is a useless intermediate class between RenderPart and
RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
applies to objects and embeds when the content is a FrameView, so can move
to RenderEmbeddedObject.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): (WebCore::RenderEmbeddedObject::requiresLayer): (WebCore::RenderEmbeddedObject::paint): (WebCore::RenderEmbeddedObject::viewCleared):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameBase.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp: Removed.
  • rendering/RenderPartObject.h: Removed.
11:15 AM Changeset in webkit [57899] by scherkus@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

2010-04-20 Sergey Ulanov <​sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum:
  • platform/chromium-mac/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-zoom-expected.checksum: Added.
  • platform/chromium-win/media/video-zoom-expected.png: Added.
  • platform/chromium-win/media/video-zoom-expected.txt: Added.
11:00 AM Changeset in webkit [57898] by jwieczorek@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-20 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

Add my IRC nick to the committers.py list.

  • Scripts/webkitpy/common/config/committers.py:
10:41 AM Changeset in webkit [57897] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

[Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
​https://bugs.webkit.org/show_bug.cgi?id=37816

Patch by Kim Grönholm <​kim.gronholm@nomovok.com> on 2010-04-20
Reviewed by Simon Hausmann.

Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Test: ​https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955

  • QtLauncher/main.cpp:

(LauncherWindow::eventFilter):
(LauncherWindow::initializeView):

10:31 AM Changeset in webkit [57896] by krit@webkit.org
  • 7 edits in trunk

2010-04-20 Robin Cao <​robin.webkit@gmail.com>

Reviewed by Dirk Schulze.

SVG no AnimateColor for stroke or fill if they are set to none on target.
​https://bugs.webkit.org/show_bug.cgi?id=36718

SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case
the property type determined by base value may be different from the one determined by 'fromTo' values.

No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue):

2010-04-20 Robin Cao <​robin.webkit@gmail.com>

Reviewed by Dirk Schulze.

Update expected results after bug fix: ​https://bugs.webkit.org/show_bug.cgi?id=36718
now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Updated.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Updated.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Updated.
  • svg/custom/animation-currentColor.svg: Updated.
9:09 AM Changeset in webkit [57895] by Simon Fraser
  • 11 edits in trunk

2010-04-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57892.
​http://trac.webkit.org/changeset/57892
​https://bugs.webkit.org/show_bug.cgi?id=37864

Caused an assertion in Mac builds (Requested by smfr on
#webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
  • rendering/RenderFrameBase.h:
  • rendering/RenderObject.h:

2010-04-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57892.
​http://trac.webkit.org/changeset/57892
​https://bugs.webkit.org/show_bug.cgi?id=37864

Caused an assertion in Mac builds (Requested by smfr on
#webkit).

  • WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]):
  • WebView/WebFrameView.mm: (-[WebFrameView _install]):
8:54 AM Changeset in webkit [57894] by morrita@google.com
  • 2 edits in trunk/WebKitTools

2010-04-20 MORITA Hajime <​morrita@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:12 AM Changeset in webkit [57893] by jwieczorek@webkit.org
  • 2 edits in trunk/WebCore

2010-04-20 Jakub Wieczorek <​jwieczorek@webkit.org>

Reviewed by Darin Adler.

RenderListItem: change enclosingList() to only traverse the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=37319

This makes the function safe to use for items with nodes that are detached from
the DOM tree and simplifies the code quite a bit.

Covered by existing tests.

  • rendering/RenderListItem.cpp: (WebCore::enclosingList): (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
8:06 AM Changeset in webkit [57892] by Simon Fraser
  • 11 edits in trunk

2010-04-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
  • rendering/RenderFrameBase.h: (WebCore::RenderFrameBase::isRenderFrameBase): (WebCore::toRenderFrameBase):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderFrameBase):
7:58 AM Changeset in webkit [57891] by eric@webkit.org
  • 4 edits in trunk

2010-04-20 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Pressing tab now closes the select popup as it should.
​https://bugs.webkit.org/show_bug.cgi?id=37721

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent):

2010-04-20 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Tests that pressing tab now closes the select popup.
​https://bugs.webkit.org/show_bug.cgi?id=37721

  • tests/PopupMenuTest.cpp: (WebKit::TEST_F):
7:50 AM Changeset in webkit [57890] by Adam Roben
  • 2 edits in trunk/LayoutTests

Unskip xss-DENIED-mime-type-execute-as-html.html on Windows

This is essentially a rollout of r57729. I was hoping that skipping
this test would fix the spurious timeouts described in
<​http://webkit.org/b/37714>, but that hasn't happened.

  • platform/win/Skipped:
7:16 AM Changeset in webkit [57889] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-20 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Nate Chapin.

Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
​https://bugs.webkit.org/show_bug.cgi?id=37810

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
  • bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
  • bindings/v8/test/V8TestObj.cpp: (WebCore::TestObjInternal::overloadedMethodCallback):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added null checks. (WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
  • html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
  • html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".
6:44 AM Changeset in webkit [57888] by eric@webkit.org
  • 4 edits
    1 add in trunk

2010-04-20 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

[chromium] crash when dragging images
​https://bugs.webkit.org/show_bug.cgi?id=37715

NULL check the return value of nativeImageForCurrentFrame(),
and NULL check Image just for good measure.

Tested by new DragImageTest unit test.

  • platform/chromium/DragImageChromiumSkia.cpp: (WebCore::createDragImageFromImage):

2010-04-20 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

[chromium] crash when dragging images
​https://bugs.webkit.org/show_bug.cgi?id=37715

Added unit tests for DragImageChromiumSkia.

  • WebKit.gyp:
  • tests/DragImageTest.cpp: Added. (WebCore::TestImage::TestImage): (WebCore::TestImage::~TestImage): (WebCore::TestImage::size): (WebCore::TestImage::nativeImageForCurrentFrame): (WebCore::TestImage::destroyDecodedData): (WebCore::TestImage::decodedSize): (WebCore::TestImage::draw): (WebCore::TEST):
6:23 AM Changeset in webkit [57887] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-20 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by David Levin.

Remove a workaround in plugin cursor setting that was obsoleted by
the change in ​https://bugs.webkit.org/show_bug.cgi?id=35132
​https://bugs.webkit.org/show_bug.cgi?id=37811

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin):
  • src/ChromeClientImpl.h:
6:14 AM PythonGuidelines edited by Chris Jerdonek
Added single quote/double quote example. (diff)
5:57 AM PythonGuidelines edited by Chris Jerdonek
Added unittest naming convention. (diff)
5:52 AM Changeset in webkit [57886] by krit@webkit.org
  • 133 edits
    3 adds
    2 deletes in trunk

2010-04-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
​https://bugs.webkit.org/show_bug.cgi?id=35320

This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.

No behavior changes, so no new tests were added.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::): (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
  • svg/graphics/SVGResourceFilter.cpp: Removed.
  • svg/graphics/SVGResourceFilter.h: Removed.
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):

2010-04-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
​https://bugs.webkit.org/show_bug.cgi?id=35320

All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.

  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-source-position-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
5:46 AM Changeset in webkit [57885] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

[Qt] Unreviewed speculative buildfix for WinCE after r57882
​https://bugs.webkit.org/show_bug.cgi?id=37701

4:33 AM Changeset in webkit [57884] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative Chromium/Win build fix, attempt #2.

Reviewed by NOBODY (build fix).

  • config.h:
4:19 AM Changeset in webkit [57883] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative Chromium/Win build fix.

Reviewed by NOBODY (build fix).

  • config.h: JS_EXPORTDATA should do nothing on !JSC builds.
4:16 AM Changeset in webkit [57882] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=37701

Reviewed by Simon Hausmann.

3:37 AM Changeset in webkit [57881] by eric@webkit.org
  • 116 edits
    2 adds
    2 deletes in trunk

2010-04-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57880.
​http://trac.webkit.org/changeset/57880
​https://bugs.webkit.org/show_bug.cgi?id=37846

Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).

  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:

2010-04-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57880.
​http://trac.webkit.org/changeset/57880
​https://bugs.webkit.org/show_bug.cgi?id=37846

Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Removed.
  • rendering/RenderSVGResourceFilter.h: Removed.
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterElement.h: (WebCore::SVGFilterElement::rendererIsNeeded):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
  • svg/graphics/SVGResourceFilter.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::fitsInMaximumImageSize): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation): (WebCore::getFilterById):
  • svg/graphics/SVGResourceFilter.h: Added. (WebCore::SVGResourceFilter::create): (WebCore::SVGResourceFilter::resourceType): (WebCore::SVGResourceFilter::setFilterResolution): (WebCore::SVGResourceFilter::setHasFilterResolution): (WebCore::SVGResourceFilter::filterBoundingBoxMode): (WebCore::SVGResourceFilter::setFilterBoundingBoxMode): (WebCore::SVGResourceFilter::effectBoundingBoxMode): (WebCore::SVGResourceFilter::setEffectBoundingBoxMode): (WebCore::SVGResourceFilter::filterRect): (WebCore::SVGResourceFilter::setFilterRect): (WebCore::SVGResourceFilter::scaleX): (WebCore::SVGResourceFilter::scaleY): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::builder):
  • svg/graphics/filters/SVGFilterBuilder.h:
2:45 AM Changeset in webkit [57880] by krit@webkit.org
  • 116 edits
    2 adds
    2 deletes in trunk

2010-04-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
​https://bugs.webkit.org/show_bug.cgi?id=35320

This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.

No behavior changes, so no new tests were added.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
  • svg/graphics/SVGResourceFilter.cpp: Removed.
  • svg/graphics/SVGResourceFilter.h: Removed.
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):

2010-04-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
​https://bugs.webkit.org/show_bug.cgi?id=35320

All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.

  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
1:30 AM Changeset in webkit [57879] by barraclough@apple.com
  • 23 edits
    4 copies in trunk

Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA

JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):

  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Copied from JavaScriptCore/wtf/WTFThreadData.cpp.
  • wtf/WTFThreadData.h: Copied from JavaScriptCore/wtf/WTFThreadData.h.

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h.
  • JSUtils.cpp:

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):

1:28 AM Changeset in webkit [57878] by eric@webkit.org
  • 4 edits in trunk

2010-04-20 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-20 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
12:30 AM Changeset in webkit [57877] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/fast/forms/interactive-validation-lost-focusable.html

Unreviewed.
Attempt to fix fast/forms/interactive-validation-lost-focusable.html failures on non-Mac.

12:15 AM Changeset in webkit [57876] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix some unexpected results of editing
​https://bugs.webkit.org/show_bug.cgi?id=37843

This change fixes about 70 unexpected results.
The original test_webview_delegate.cc doesn't have this bug.
The bug was introduced when I ported it to WebKit tree.

  • DumpRenderTree/chromium/WebViewHost.cpp: (printRangeDescription): Replace the latter startContainer() with endContainer().
12:03 AM Changeset in webkit [57875] by tkent@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

More tests for interactive validation
​https://bugs.webkit.org/show_bug.cgi?id=37345

Add tests for cases that event handlers modify DOM structures.
These improve test coverage for r57346.

  • fast/forms/checkValidity-handler-updates-dom-expected.txt: Added.
  • fast/forms/checkValidity-handler-updates-dom.html: Added.
  • fast/forms/interactive-validation-lost-focusable-expected.txt: Added.
  • fast/forms/interactive-validation-lost-focusable.html: Added.
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js: Added.

Apr 19, 2010:

11:39 PM Changeset in webkit [57874] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK form roles.

  • tests/testatkroles.c: (test_webkit_atk_get_role_check_box): (test_webkit_atk_get_role_entry): (test_webkit_atk_get_role_label): (test_webkit_atk_get_role_listbox): (test_webkit_atk_get_role_password_text): (test_webkit_atk_get_role_push_button): (test_webkit_atk_get_role_radio_button): (main):
11:30 PM Changeset in webkit [57873] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-19 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by David Hyatt.

Add missing dummy implementations in PluginPackageNone and PluginViewNone.
​http://webkit.org/b/37478

  • plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::NPVersion): Add dummy implementation.
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::handleFocusInEvent): Add dummy implementation. (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
11:18 PM Changeset in webkit [57872] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Turn off some unit tests for now - the new-run-webkit-tests dryrun
tests for chromium won't work if you don't have a chromium checkout.

​https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:00 PM Changeset in webkit [57871] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

(Re-)add dryrun.py; this was renamed from passing.py in the previous
CL but apparently somehow didn't get checked in.

​https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
10:41 PM Changeset in webkit [57870] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

check-webkit-style: exits when encountering a deleted file
​https://bugs.webkit.org/show_bug.cgi?id=37122

This reverts the quick fix done by r57119 and makes check_patch
not call check_file for deleted files.

Also this change fixes the behavior for "-", which should mean
stdin. Before this change, the style checker just ignored "-"
with a warning message.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
10:10 PM Changeset in webkit [57869] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-19 Daniel Bates <​dbates@rim.com>

No review, rolling out 57868.
​http://trac.webkit.org/changeset/57868
​https://bugs.webkit.org/show_bug.cgi?id=37748

Sheriffbot wasn't very inspirational after this patch.
Instead, he was silent when you said hi :-(. Rolling
out this patch so that I can debug/test this some more.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
9:34 PM Changeset in webkit [57868] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-19 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
9:22 PM Changeset in webkit [57867] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-04-19 Simon Fraser <Simon Fraser>

Reviewed by Geoff Garen.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
since it's only used for <object> fallback.

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
  • rendering/RenderEmbeddedObject.h: (WebCore::RenderEmbeddedObject::hasFallbackContent):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h:
9:02 PM Changeset in webkit [57866] by Simon Fraser
  • 15 edits
    4 copies in trunk/WebCore

2010-04-19 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
and move code from RenderPart and RenderPartObject into these new classes.


There should be no functionality difference with this change, so no new tests.


Fixing up renderer names in the layout tests will be done in a later pass.


Fix build systems to include the new files.


  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::createRenderer):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame):
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.cpp: Added. (WebCore::RenderFrameBase::RenderFrameBase): (WebCore::RenderFrameBase::layoutWithFlattening):
  • rendering/RenderFrameBase.h: Added.
  • rendering/RenderIFrame.cpp: Added. (WebCore::RenderIFrame::RenderIFrame): (WebCore::RenderIFrame::calcHeight): (WebCore::RenderIFrame::calcWidth): (WebCore::RenderIFrame::flattenFrame): (WebCore::RenderIFrame::layout):
  • rendering/RenderIFrame.h: Added. (WebCore::RenderIFrame::renderName):
  • rendering/RenderPart.cpp:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderPartObject.h:
8:59 PM Changeset in webkit [57865] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Bindings clean-up.
​https://bugs.webkit.org/show_bug.cgi?id=37833

Reviewed by Geoffrey Garen.

Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

7:59 PM Changeset in webkit [57864] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Mac builders for now by restoring the keepAlive function.

7:10 PM Changeset in webkit [57863] by kevino@webkit.org
  • 7 edits in trunk

Build fixes for wx with latest trunk.

6:43 PM Changeset in webkit [57862] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [57861] by jberlin@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

Remove an extra space in the getComputedStyle-with-psuedo-element test that was causing it to fail on the Chromium bots, and remove the platform-specific results that were landed in the meantime.

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
5:53 PM Changeset in webkit [57860] by dpranke@chromium.org
  • 5 edits
    1 delete in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
that can be used to test platforms other than the one you are running
on. This can be useful for checking baselines and testing code
coverage.

Note that running the code on the "wrong" port requires each
port-specific implementation to actually not require any
platform-specific python code (e.g., the chromium-win port must
test for the existence of windows functions before calling them).

​https://bugs.webkit.org/show_bug.cgi?id=37782

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:34 PM Changeset in webkit [57859] by mrowe@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force generated interfaces to be rebuilt. Boo.

5:33 PM Changeset in webkit [57858] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add --build (default) and --no-build
options to make that step optional. This flag modifies what happens
in port.check_build().

​https://bugs.webkit.org/show_bug.cgi?id=37786

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:24 PM Changeset in webkit [57857] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:16 PM Changeset in webkit [57856] by mrowe@apple.com
  • 38 edits
    2 deletes in trunk

Roll out r57823.

It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
by shipping clients of WebKit on Windows. Adding methods to a delegate interface in this
manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
methods are used.

4:35 PM Changeset in webkit [57855] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests - fix a typo in r57480 that caused us to stop
logging the actual list of unexpected results.

​https://bugs.webkit.org/show_bug.cgi?id=37831

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:30 PM Changeset in webkit [57854] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
4:26 PM Changeset in webkit [57853] by barraclough@apple.com
  • 23 edits
    4 deletes in trunk

This broke windows.

Reviewed by NOBODY (rolling out r57829).

JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):

  • runtime/Identifier.h:

(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Removed.
  • wtf/WTFThreadData.h: Removed.

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • JSUtils.cpp:

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::atomicStringTable):

  • platform/text/AtomicString.cpp:

(WebCore::stringTable):

4:24 PM Changeset in webkit [57852] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • platform/graphics/mac/GraphicsContext3DMac.cpp:
4:10 PM Changeset in webkit [57851] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed and landed by Anders Carlsson.

Patch by Douglas Gregor <​dgregor@apple.com> on 2010-04-19

  • runtime/UStringImpl.h:

Fix class/struct declaration mismatches.

4:05 PM Changeset in webkit [57850] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

From a patch by Tor Arne Vestbo <​tor.arne.vestbo@nokia.com>

new-run-webkit-tests: make the retry step more explicit
​https://bugs.webkit.org/show_bug.cgi?id=37606

It might be confusing to see the test and percent counters
reset without any notice of what's going on, so we make the
message that a retry-run is started explicit.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:59 PM Changeset in webkit [57849] by weinig@apple.com
  • 8 edits in trunk/WebKitTools

Add support for opening a new window (File->New Window) to
Windows MiniBrowser. Accelerator doesn't work.

Reviewed by Anders Carlsson.

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Use BrowserView::create.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
by creating a new window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::create): Added. Don't allow creating
BrowserWindows on the stack by making constructor
private and exposing the create function.

  • MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::createNewWindow): Move new window creation
logic here.

  • MiniBrowser/win/MiniBrowser.h:
  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/main.cpp:

(_tWinMain): Use the new MiniBrowser::createNewWindow().

3:54 PM QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
3:27 PM Changeset in webkit [57848] by Chris Fleizach
  • 8 edits
    2 adds in trunk

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

Test: platform/mac/accessibility/element-haspopup.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaHasPopup):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaHasPopup): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • platform/mac/accessibility/element-haspopup-expected.txt: Added.
  • platform/mac/accessibility/element-haspopup.html: Added.

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::hasPopup):
3:09 PM Changeset in webkit [57847] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Submit a better workaround for r57806 than the one in r57831 - log
an error and exit if you try to run new-run-webkit-tests with --use-drt
on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=37822

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:03 PM Changeset in webkit [57846] by jesus@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Just adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
2:59 PM Changeset in webkit [57845] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add slightly better logging to the websocket python wrapper script,
including a --verbose flag for debug output.

​https://bugs.webkit.org/show_bug.cgi?id=37233

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/new-run-webkit-websocketserver:
2:57 PM Changeset in webkit [57844] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix a crash when rendering <select> elements with WebKit2.

Reviewed by Sam Weinig.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.

2:56 PM Changeset in webkit [57843] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a way (--print-unexpected-results) to
(re-)print out the tests that produced unexpected results in the
last run. Also add a way (--retry-unexpected-results) to
automatically re-test them.

​https://bugs.webkit.org/show_bug.cgi?id=37783

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:48 PM Changeset in webkit [57842] by jamesr@google.com
  • 1 edit
    6 adds
    3 deletes in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed, move chromium baselines for fast/url around.

The desired behavior is that chromium-win use one set of baselines and
chromium-mac/chromium-linux use another, however to do we have to
duplicate the mac+linux results into chromium-mac and chromium-linux.

  • platform/chromium-linux/fast/url/file-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-win-expected.txt: Added.
  • platform/chromium-mac/fast/url/file-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/fast/url/file-expected.txt: Removed.
  • platform/chromium/fast/url/relative-unix-expected.txt: Removed.
  • platform/chromium/fast/url/relative-win-expected.txt: Removed.
2:41 PM Changeset in webkit [57841] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Restructure the logging in new-run-webkit-tests so that many of log
messages that were logged to the MeteredStream also get logged in
--verbose mode.

​https://bugs.webkit.org/show_bug.cgi?id=37780

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:39 PM Changeset in webkit [57840] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add 'summary' and 'unexpected-results' options
to the --log flag. Also add a 'progress' flag to enable the regular
progress bar (as opposed to 'detailed-progress', which enables the
dots). Also add a 'nothing' flag to allow you to be explicit that
you don't want any logging on the command line.

The default is
'--log detailed-progress,summary,unexpected,unexpected-results'

(The default logging is unchanged by this patch, this just makes things
properly configurable).

Note that 'nothing' doesn't work properly yet; I need a couple other
patches to land to avoid rewriting things several different ways.

​https://bugs.webkit.org/show_bug.cgi?id=37785

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:15 PM Changeset in webkit [57839] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
​https://bugs.webkit.org/show_bug.cgi?id=36031

Reviewed by Darin Adler.

WebCore:

Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.

Test: fast/dom/Node/fragment-mutation.html

  • dom/ContainerNode.cpp:

(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in

inserting/appending operation.

(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.

  • dom/Node.cpp:

(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.

LayoutTests:

These tests study various side-effects of DOM mutation events fired during appending/inserting
document fragments.

  • fast/dom/Node/fragment-mutation-expected.txt: Added.
  • fast/dom/Node/fragment-mutation.html: Added.
2:10 PM Changeset in webkit [57838] by jamesr@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed - yet more rebaselines and expectation updates.

  • platform/chromium-win/fast/url/file-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [57837] by ggaren@apple.com
  • 1 edit
    3 adds in trunk/JavaScriptCore

Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.

Reviewed by Beth Dakin.

  • tests/perf: Added.
  • tests/perf/bench-allocate-nonretained.js: Added.
  • tests/perf/bench-allocate-retained.js: Added.
1:56 PM Changeset in webkit [57836] by kenneth@webkit.org
  • 4 edits in trunk/WebKitTools

Make the URL change on committed load.

Reviewed by Simon Hausmann.

  • QtLauncher/mainwindow.cpp:

(MainWindow::buildUI):
(MainWindow::setAddressUrl):

  • QtLauncher/mainwindow.h:
1:51 PM Changeset in webkit [57835] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:50 PM Changeset in webkit [57834] by jamesr@google.com
  • 4 edits
    3 adds
    2 deletes in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. More chromium rebaselines+expectation updates.

  • platform/chromium-linux/fast/css/getComputedStyle: Added.
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-mac/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:35 PM Changeset in webkit [57833] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix a typo in the rebaselining tool that causes us to use "debug"
instead of "Debug" in a directory path, which fails on platforms with
case-sensitive filesystems.

​https://bugs.webkit.org/show_bug.cgi?id=37819

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1:20 PM Changeset in webkit [57832] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed build fix.

Update chromium expectations

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [57831] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix breakage of chromium-win canary bots caused by r57806. That patch
introduced the option of using Chrome's new port of DumpRenderTree,
but unfortunately that port relies on the webkit.py class
implementation which uses non-blocking I/O that isn't available on
Windows. This patch turns off that option and doesn't import the
class if we're running on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=37817

  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:12 PM Changeset in webkit [57830] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix regression introduced in r57820.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of just setting a URL on the one used for the previous <source> element. This restores the behavior prior to the changes for ​https://bugs.webkit.org/show_bug.cgi?id=37728.
1:05 PM Changeset in webkit [57829] by barraclough@apple.com
  • 22 edits
    2 copies
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.

Reviewed by Sam Weinig.

Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.

JavaScriptCore:

WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.

This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):

  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.

(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • JSUtils.cpp: Update

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h: Remove m_atomicStringTable.

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().

1:00 PM CommitterTips edited by jesus@webkit.org
There is no more "--no-build" option anymore. (diff)
12:36 PM Changeset in webkit [57828] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-04-19 James Robinson <​jamesr@chromium.org>

Reviewed by abarth.

Fix a typo

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
12:29 PM Changeset in webkit [57827] by jamesr@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed build fix for Chromium

Add baselines for new platform-specific tests.

  • platform/chromium/fast/url: Added.
  • platform/chromium/fast/url/file-expected.txt: Added.
  • platform/chromium/fast/url/relative-expected.txt: Added.
  • platform/chromium/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [57826] by adachan@apple.com
  • 3 edits in trunk/WebCore

Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
12:13 PM Changeset in webkit [57825] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests when there are spaces in the path

Fixes <​http://webkit.org/b/37809>

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Use an "indirect object" to specify the

path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.

12:01 PM Changeset in webkit [57824] by Dimitri Glazkov
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild of Interfaces.vcproj

11:49 AM Changeset in webkit [57823] by Dimitri Glazkov
  • 38 edits
    2 adds in trunk

WebCore: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

Test: fast/dom/icon-url-property.html

  • dom/Document.cpp:

(WebCore::Document::setIconURL):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setIconURL):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::iconURL):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didChangeIcons):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

  • src/FrameLoaderClientImpl.h:

WebKit/gtk: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidChangeIcons):

WebKit/qt: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::didChangeTitle):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:

(WebFrame::didChangeIcons):

  • WebFrame.h:

WebKitTools: Add test support for icon changes.

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpIconChangesCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpIconChanges):
(LayoutTestController::setDumpIconChanges):

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didChangeIcons):

  • DumpRenderTree/win/FrameLoadDelegate.h:
  • WinLauncher/WinLauncher.h:

(WinLauncherWebHost::didChangeIcons):

LayoutTests: Add test for icon change notifications.

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • fast/dom/icon-url-property-expected.txt: Added.
  • fast/dom/icon-url-property.html: Added.
  • Skipped on all platforms but Win
11:37 AM Changeset in webkit [57822] by adachan@apple.com
  • 12 edits in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.

Reviewed by Jeremy Orlow.

  • WebCore.base.exp: Export Settings::setSessionStorageQuota().
  • page/Page.cpp:

(WebCore::Page::sessionStorage):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

  • page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::sessionStorageNamespace):

  • storage/StorageNamespaceImpl.h:

WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=37717
Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
StorageNamespace::sessionStorageNamespace() take in a quota parameter.

Reviewed by Jeremy Orlow.

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • src/WebStorageNamespaceImpl.cpp:

(WebKit::WebStorageNamespace::createSessionStorageNamespace):

11:34 AM Changeset in webkit [57821] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for WinCE.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

Moved the include of the non-existing errno.h header file inside
platform guard macros.

  • jit/ExecutableAllocatorFixedVMPool.cpp:
11:28 AM Changeset in webkit [57820] by eric.carlson@apple.com
  • 9 edits
    2 deletes in trunk

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
​https://bugs.webkit.org/show_bug.cgi?id=37728

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute changes unless it is missing. (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal. (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad. (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad so the previously loading file, if any, is cancelled there.

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
​https://bugs.webkit.org/show_bug.cgi?id=37728

  • media/event-attributes-expected.txt: Updated results.
  • media/event-attributes.html: Do not need to call load().
  • media/video-source-add-src-expected.txt: Removed.
  • media/video-source-add-src.html: Removed.
  • media/video-src-change-expected.txt: Updated results.
  • media/video-src-change.html: Update test to match current behavior.
  • media/video-src-invalid-remove-expected.txt: Updated results.
  • media/video-src-invalid-remove.html: Update test to match current behavior.
11:07 AM Changeset in webkit [57819] by Simon Hausmann
  • 8 edits in trunk

[Qt] Fix compilation against namespaced Qt.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

WebCore:

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/Tile.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.h:
11:00 AM Changeset in webkit [57818] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-19 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Destroy SharedTimerQt before destruction of QCoreApplication.

To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
into the SharedTimerQt instance.

​https://bugs.webkit.org/show_bug.cgi?id=36832

No functional change so no new tests.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::destroy): (WebCore::SharedTimerQt::inst):
10:48 AM Changeset in webkit [57817] by mitz@apple.com
  • 2 edits in trunk/WebCore

Make the fix for <rdar://problem/7873647> from r57759 more robust.

Reviewed by Darin Adler.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.

10:43 AM Changeset in webkit [57816] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-04-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

WinLauncher.h should use LF line-endings and use native line-endings style.
​https://bugs.webkit.org/show_bug.cgi?id=37807

  • WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
10:38 AM Changeset in webkit [57815] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Add and enable the build of testatkroles to test ATK non form roles.

  • GNUmakefile.am:

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Add testatkroles to test ATK non form roles.

  • tests/testatkroles.c: Added. (finish_loading): (atk_roles_fixture_setup): (atk_roles_fixture_teardown): (get_child_and_test_role): (test_webkit_atk_get_role_document_frame): (test_webkit_atk_get_role_heading): (test_webkit_atk_get_role_image): (test_webkit_atk_get_role_link): (test_webkit_atk_get_role_list_and_item): (test_webkit_atk_get_role_paragraph): (test_webkit_atk_get_role_section): (test_webkit_atk_get_role_table): (main):
10:21 AM Changeset in webkit [57814] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by Sam Weinig.

  • WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
10:11 AM Changeset in webkit [57813] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-04-19 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix.

  • bindings/v8/JavaScriptCallFrame.h:
10:01 AM Changeset in webkit [57812] by yurys@chromium.org
  • 10 edits
    3 adds in trunk

2010-04-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement JavaScriptCallFrame that works for v8.
Implementing this binding for v8 allows to make evaluations on
call frames and protects access to the debugger context from
inspected context.

​https://bugs.webkit.org/show_bug.cgi?id=37755

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/v8/JavaScriptCallFrame.cpp: Added. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::scopeType): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/v8/JavaScriptCallFrame.h: Added. (WebCore::JavaScriptCallFrame::create):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added. (WebCore::V8JavaScriptCallFrame::evaluateCallback): (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter): (WebCore::V8JavaScriptCallFrame::scopeTypeCallback): (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter): (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
  • inspector/JavaScriptCallFrame.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
9:41 AM Changeset in webkit [57811] by Csaba Osztrogonác
  • 5 edits
    39 adds in trunk/LayoutTests

[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.

Rubber-stamped by Simon Hausmann.

Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped:
  • platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
  • platform/qt/fast/frames/frame-navigation-expected.png: Added.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
  • platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
  • platform/qt/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt/fast/overflow/line-clamp-expected.txt: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
  • platform/qt/http/tests/misc/error404-expected.checksum: Added.
  • platform/qt/http/tests/misc/error404-expected.png: Added.
  • platform/qt/http/tests/misc/error404-expected.txt: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
  • platform/qt/http/tests/misc/iframe404-expected.png: Added.
  • platform/qt/http/tests/misc/iframe404-expected.txt: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/qt/http/tests/uri/css-href-expected.checksum: Added.
  • platform/qt/http/tests/uri/css-href-expected.png: Added.
  • platform/qt/http/tests/uri/css-href-expected.txt: Updated.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
8:05 AM Changeset in webkit [57810] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Rubber Stamped by Adam Roben

Chromium Release Build Fix.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.

6:28 AM Changeset in webkit [57809] by jberlin@webkit.org
  • 13 edits
    2 adds in trunk

First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
​https://bugs.webkit.org/show_bug.cgi?id=24021

Reviewed by Dave Hyatt.

WebCore:

Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.

Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html

  • WebCore.base.exp:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Take into consideration the pseudo-element.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.

  • dom/Element.cpp:

(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.

  • dom/Element.h:

(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.

  • dom/Node.h:

(WebCore::Node::computedStyle):
Ditto.

  • dom/Node.cpp:

(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):
Ditto.

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.
4:54 AM Changeset in webkit [57808] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] lacks clipToImageBuffer()
​https://bugs.webkit.org/show_bug.cgi?id=24289

Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.

  • platform/qt/Skipped:
2:05 AM Changeset in webkit [57807] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a test initialization problem
​https://bugs.webkit.org/show_bug.cgi?id=37791

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Call resetTestController() before runFileTest(). Some controllers initialize their fields in reset() and not in their constructors.
1:52 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:40 AM Changeset in webkit [57806] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
​https://bugs.webkit.org/show_bug.cgi?id=37793

We need to use WebKitDriver instead of ChromiumDriver for Chromium
DRT because its interface is different from test_shell.

Chromium DRT has no UI. So we can't use it to show test results.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

Apr 18, 2010:

11:36 PM Changeset in webkit [57805] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Make failure-reason more forgiving
​https://bugs.webkit.org/show_bug.cgi?id=37525

Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:13 PM Changeset in webkit [57804] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-18 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Laszlo Gombos.

[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
​https://bugs.webkit.org/show_bug.cgi?id=37434

Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.

  • wtf/Platform.h:
9:26 PM Changeset in webkit [57803] by Chris Jerdonek
  • 3 edits
    2 adds in trunk/WebKitTools

Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
  • Scripts/webkitpy/style/checker.py:
    • Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
    • Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
  • Scripts/webkitpy/style/filereader.py: Added.
    • Created a TextFileReader class that encapsulates reading and iterating over text files.
  • Scripts/webkitpy/style/filereader_unittest.py: Added.
    • Added a TextFileReaderTest class to unit-test the new TextFileReader class.
9:22 PM Changeset in webkit [57802] by eric@webkit.org
  • 4 edits in trunk

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

  • WebCore.pro:
9:08 PM Changeset in webkit [57801] by eric@webkit.org
  • 2 edits in trunk

2010-04-18 Michael Forney <​michael@mforney.org>

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=37762

Fixes the sandbox option in configure.

  • configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
8:26 PM Changeset in webkit [57800] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests should be able to use chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=37645

Make sure that the lack of a chromium checkout doesn't cause the script to
fail.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths

to be relative to an upstream output dir.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2:25 PM Changeset in webkit [57799] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Exit non-zero of launching the harness fails.
1:58 PM Changeset in webkit [57798] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
1:56 PM Changeset in webkit [57797] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-18 Adam Barth <​abarth@webkit.org>

Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.

  • blog-files/loader-diagram.svg:
1:34 PM Changeset in webkit [57796] by eric@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
​https://bugs.webkit.org/show_bug.cgi?id=37632

This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.

Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.

I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.

  • Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
  • Scripts/run-webkit-tests:
    • A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
10:43 AM Changeset in webkit [57795] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33295

The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
4:01 AM Changeset in webkit [57794] by robert@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Add support for LayoutTestController commands

2010-04-18 Robert Hogan <​robert@webkit.org>

Unreviewed fix to pixel differences in unskipped layout tests.

[Qt] Add support for LayoutTestController commands

Fix up minor pixel differences on unskipped tests from r57793.

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt:
3:36 AM Changeset in webkit [57793] by robert@webkit.org
  • 17 edits in trunk

[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:25 AM Changeset in webkit [57792] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-18 Antonio Gomes <​tonikitoo@webkit.org>

[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

It was removed by r57511.

  • platform/qt/Skipped:

Apr 17, 2010:

11:27 PM Changeset in webkit [57791] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

  • blog-files/loader-diagram.svg: Added.
11:03 PM Changeset in webkit [57790] by ap@apple.com
  • 8 edits in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
  • bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.
  • html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.
  • html/HTMLFrameSetElement.idl: Ditto.
10:00 PM Changeset in webkit [57789] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-04-17 Juan C. Montemayor <​jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
​https://bugs.webkit.org/show_bug.cgi?id=20219

  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
5:42 PM Changeset in webkit [57788] by eric@webkit.org
  • 13 edits
    2 deletes in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
​https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
1:43 PM Changeset in webkit [57787] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
​https://bugs.webkit.org/show_bug.cgi?id=37453

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
  • bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
1:10 PM Changeset in webkit [57786] by eric@webkit.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
​https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land ​http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

  • fast/url/file-expected.txt: Added.
  • fast/url/file.html: Added.
  • fast/url/mailto.html:
  • fast/url/script-tests/file.js: Added.
1:00 PM Changeset in webkit [57785] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
​https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

  • fast/url/relative-expected.txt: Added.
  • fast/url/relative-unix-expected.txt: Added.
  • fast/url/relative-unix.html: Added.
  • fast/url/relative-win-expected.txt: Added.
  • fast/url/relative-win.html: Added.
  • fast/url/relative.html: Added.
  • fast/url/script-tests/relative-unix.js: Added.
  • fast/url/script-tests/relative-win.js: Added.
  • fast/url/script-tests/relative.js: Added.
11:42 AM Changeset in webkit [57784] by eric@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-04-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

​https://bugs.webkit.org/show_bug.cgi?id=37740

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorController.h:
9:00 AM Changeset in webkit [57783] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
​https://bugs.webkit.org/show_bug.cgi?id=37753

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [57782] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
​https://bugs.webkit.org/show_bug.cgi?id=37752

  • platform/gtk/Skipped:
8:16 AM Changeset in webkit [57781] by alex
  • 2 edits in trunk/WebKit/gtk

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

  • webkit/webkitdownload.cpp: (webkit_download_finalize):
7:55 AM Changeset in webkit [57780] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
​https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

  • WebCore.gypi: Added GLES2Context.h
  • platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
​https://bugs.webkit.org/show_bug.cgi?id=37541

  • WebKit.gyp:
  • public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
  • src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):
6:37 AM Changeset in webkit [57779] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Crash while handling SVG font in the wrong namespace imported with @font-face
​https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

  • fast/invalid/invalidSVGFont-expected.txt: Added.
  • fast/invalid/invalidSVGFont.html: Added.
  • fast/invalid/resources/svgFontWrongNamespace.svg: Added.
1:13 AM Changeset in webkit [57778] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
​https://bugs.webkit.org/show_bug.cgi?id=37742

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1:02 AM Changeset in webkit [57777] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Fix expected results for unit test broken by
​http://trac.webkit.org/changeset/57772

  • Scripts/webkitpy/common/net/buildbot_unittest.py:

Apr 16, 2010:

11:14 PM Changeset in webkit [57776] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r57770.
​http://trac.webkit.org/changeset/57770
​https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

  • platform/qt/Skipped:
9:40 PM Changeset in webkit [57775] by dbates@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-04-16 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=36312

Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <​http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

  • Android.mk: Added file ViewportArguments.cpp.
  • GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::isSeparator): Added. (WebCore::Document::processArguments): Added. (WebCore::Document::processViewport): Added.
  • dom/Document.h:
  • dom/ViewportArguments.cpp: Added. (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
  • dom/ViewportArguments.h: Added. (WebCore::): (WebCore::ViewportArguments::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
  • page/ChromeClient.h: (WebCore::ChromeClient::didReceiveViewportArguments): Added.
8:23 PM Changeset in webkit [57774] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebKit2

Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

  • UIProcess/API/C/WKBase.h:
  • WebProcess/win/WebProcessMain.h:
  • win/WebKit2.def: Removed.
  • win/WebKit2.vcproj:
8:06 PM Changeset in webkit [57773] by weinig@apple.com
  • 8 edits in trunk

Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

  • win/WebKit2.def:

WebKitTools:

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.

  • MiniBrowser/win/BrowserView.h:

(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

  • MiniBrowser/win/main.cpp:

(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

7:53 PM Changeset in webkit [57772] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

  • Scripts/webkitpy/common/net/buildbot.py:

(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

7:30 PM Changeset in webkit [57771] by dumi@chromium.org
  • 2 edits in trunk/WebKit/chromium

Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

7:04 PM Changeset in webkit [57770] by eric@webkit.org
  • 4 edits in trunk

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
5:24 PM Changeset in webkit [57769] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

5:20 PM Changeset in webkit [57768] by dumi@chromium.org
  • 4 edits in trunk/WebKit/chromium

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
​https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

  • public/WebSecurityOrigin.h:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

5:14 PM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:12 PM Changeset in webkit [57767] by dimich@chromium.org
  • 7 edits
    1 move
    1 add in trunk

WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.

  • bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

  • platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
  • platform/chromium/fast/workers/worker-close-expected.txt: Added.
5:10 PM Changeset in webkit [57766] by barraclough@apple.com
  • 28 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSMimeTypeArrayCustom.cpp:

(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginArrayCustom.cpp:

(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):

  • bindings/js/JSPluginCustom.cpp:

(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::initPopStateEvent):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

  • platform/text/AtomicString.h:

(WebCore::AtomicString::AtomicString):

4:58 PM Changeset in webkit [57765] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix typo from r55729

  • platform/win/Skipped:
4:51 PM Changeset in webkit [57764] by weinig@apple.com
  • 5 edits in trunk

Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(_createNewPage): Use the correct initializer to and load the window.

4:45 PM Changeset in webkit [57763] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

  • platform/chromium/test_expectations.txt:
4:31 PM Changeset in webkit [57762] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [57761] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Don't optimize debug builds.

Reviewed by Mark Rowe.

  • WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.
4:13 PM Changeset in webkit [57760] by ukai@chromium.org
  • 3 edits
    4 adds in trunk

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
​https://bugs.webkit.org/show_bug.cgi?id=37682

  • websocket/tests/bad-handshake-crash-expected.txt: Added.
  • websocket/tests/bad-handshake-crash.html: Added.
  • websocket/tests/bad-handshake-crash_wsh.py: Added.
  • websocket/tests/script-tests/bad-handshake-crash.js: Added.

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
​https://bugs.webkit.org/show_bug.cgi?id=37682

If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.

Test: websocket/tests/bad-handshake-crash.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.
4:10 PM Changeset in webkit [57759] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

  • fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
  • fast/dynamic/hover-style-recalc-crash.html: Added.
4:07 PM Changeset in webkit [57758] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3DInternal::beginPaint):

3:42 PM Changeset in webkit [57757] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

3:31 PM Changeset in webkit [57756] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
3:29 PM Changeset in webkit [57755] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [57754] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Make Safari correctly allocate 5MB of DB storage to all new
origins.
​https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::detailsForNameAndOrigin):

3:06 PM Changeset in webkit [57753] by scherkus@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-04-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

  • platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:05 PM Changeset in webkit [57752] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
2:57 PM Changeset in webkit [57751] by mrowe@apple.com
  • 4 edits in tags/Safari-533.5.2/WebKit/win

Merge r57615.

2:56 PM Changeset in webkit [57750] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.2

Versioning.

2:55 PM Changeset in webkit [57749] by kinuko@chromium.org
  • 9 edits
    3 adds in trunk/WebCore

2010-04-16 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
​https://bugs.webkit.org/show_bug.cgi?id=37218

No new tests; tests will be added when we add upper layer implementations.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: (WebCore::FileStream::stop):
  • html/FileStream.h:
  • html/FileStreamClient.h: (WebCore::FileStreamClient::didStop):
  • html/FileStreamProxy.cpp: Added
  • html/FileStreamProxy.h: Added
  • html/FileThreadTask.h: Added
2:50 PM Changeset in webkit [57748] by barraclough@apple.com
  • 11 edits in trunk

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

  • WebCore.base.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsString):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::create):

  • platform/text/StringImpl.h:
2:39 PM Changeset in webkit [57747] by eric@webkit.org
  • 7 edits in trunk

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
​https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getOwnerGLWidget): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
​https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
2:39 PM Changeset in webkit [57746] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.2

New tag.

2:27 PM Changeset in webkit [57745] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebKit compilation fails with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=37699

API for readPixels() has been changed.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::readPixels):
2:16 PM Changeset in webkit [57744] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt]QtLauncher crash on page with CSS 3D transform
​https://bugs.webkit.org/show_bug.cgi?id=36859

Added a neccessary null-pointer check, lack of which created the crash circumstances.

Tested by ​http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
2:14 PM Changeset in webkit [57743] by scherkus@chromium.org
  • 59 edits in trunk/LayoutTests

2010-04-16 Sergey Ulanov <​sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
2:08 PM Changeset in webkit [57742] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

1:52 PM Changeset in webkit [57741] by andersca@apple.com
  • 2 edits in trunk/WebCore

Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

  • platform/mac/ThemeMac.mm:

(WebCore::paintCheckbox):
(WebCore::paintRadio):

1:34 PM Changeset in webkit [57740] by barraclough@apple.com
  • 3 edits in trunk/WebKit/win
  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

1:26 PM Changeset in webkit [57739] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix windows build.

Reviewed by Sam Weinig.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::run):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody):
(WebKit::launchWebProcess):

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain):

1:21 PM Changeset in webkit [57738] by barraclough@apple.com
  • 73 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:

WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString

  • to JSDOMBindings.h, and updates code to call these methods.
  • WebCore.base.exp:
  • WebCore.order:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::getEventListenerHandlerBody):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptObject::set):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:

(WebCore::ScriptValue::toString):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):

  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::sourceString):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • platform/KURL.h:

(WebCore::KURL::operator const String&):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptDebugger.mm:

(toNSURL):

  • WebView/WebView.mm:

(aeDescFromJSValue):

1:15 PM Changeset in webkit [57737] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

  • Use the same waitFor logic as do for the Mac resizing DrawingAreaUpdateChunk code.
  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):

  • Shared/win/UpdateChunk.h: Add a constructor that only takes an IntRect and allocates the shared memory mapping for you.
  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:

Perform wait in paint as we do on the mac.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

Specialize setSize() drawing and factor out painting
into a helper function.

1:13 PM Changeset in webkit [57736] by ajwong@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

  • platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-win/fast/url/standard-url-expected.txt:
1:05 PM Changeset in webkit [57735] by ajwong@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

  • platform/chromium-linux/fast/url/host-expected.txt: Added.
  • platform/chromium-linux/fast/url/path-expected.txt: Added.
  • platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
12:58 PM Changeset in webkit [57734] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Always pass a view to the AppKit drawing functions.
​https://bugs.webkit.org/show_bug.cgi?id=37724

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
12:45 PM Changeset in webkit [57733] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

Test: fast/events/recorded-keydown-event.html

  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is frameless.
12:36 PM Changeset in webkit [57732] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2010-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Make run loops be allocated as thread specific data.
​https://bugs.webkit.org/show_bug.cgi?id=37723

  • Platform/RunLoop.cpp: (RunLoop::initializeMainRunLoop): (RunLoop::current): (RunLoop::main):
  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm: (RunLoop::run): (RunLoop::stop):
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: (WebKit::webThreadBody): (WebKit::launchWebProcess):
  • UIProcess/ResponsivenessTimer.cpp: (WebKit::ResponsivenessTimer::ResponsivenessTimer):
  • WebProcess/Launching/mac/WebProcessMain.mm: (main):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::isSeparateProcess):
11:52 AM Changeset in webkit [57731] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <​http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
11:40 AM Changeset in webkit [57730] by Adam Roben
  • 3 edits in trunk/WebKit/win

Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

  • ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which

lists all our instantiatable classes.

  • WebKitClassFactory.cpp: Added a now-required #include.
11:19 AM Changeset in webkit [57729] by Adam Roben
  • 2 edits in trunk/LayoutTests

SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<​http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped:
11:19 AM Changeset in webkit [57728] by ukai@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=37687

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
11:07 AM Changeset in webkit [57727] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-04-16 Jian Li <​jianli@chromium.org>

Reviewed by Dmitry Titov.

Update FormDataList to fix style violations in old code.
​https://bugs.webkit.org/show_bug.cgi?id=37689

  • html/FormDataList.h: (WebCore::FormDataList::appendData): (WebCore::FormDataList::appendBlob):
11:00 AM Changeset in webkit [57726] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Update FormDataList to fix style violations in old code.
​https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

10:59 AM Changeset in webkit [57725] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix WebKit2 build.

  • WebCore.base.exp:
10:18 AM Changeset in webkit [57724] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-16 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-16 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
10:09 AM Changeset in webkit [57723] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor.

9:18 AM Changeset in webkit [57722] by eric@webkit.org
  • 9 edits
    3 deletes in trunk/LayoutTests

2010-04-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57719.
​http://trac.webkit.org/changeset/57719
​https://bugs.webkit.org/show_bug.cgi?id=37708

Broke 8 URL tests on Windows due to use of ​file:///tmp/ URLs,
which don't work on Windows. (Requested by aroben on #webkit).

  • fast/url/anchor.html:
  • fast/url/file-expected.txt: Removed.
  • fast/url/file.html: Removed.
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/script-tests/TEMPLATE.html:
  • fast/url/script-tests/file.js: Removed.
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
7:11 AM Changeset in webkit [57721] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Antonio Gomes <​tonikitoo@webkit.org>

Unreviewed QtWebKit (with Qt 4.7) build fix.

Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:36 AM Changeset in webkit [57720] by eric@webkit.org
  • 5 edits in trunk

2010-04-16 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37690

  • DEPS: Need to roll deps to remove a dependency on src/chrome
  • gyp_webkit: generate makefiles for DRT.gyp on Linux

2010-04-16 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37690

  • Scripts/build-dumprendertree: Add support for win and linux
12:27 AM Changeset in webkit [57719] by mjs@apple.com
  • 9 edits
    3 adds in trunk/LayoutTests

2010-04-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Test file: URL canonicalization
​https://bugs.webkit.org/show_bug.cgi?id=37700

  • fast/url/script-tests/file.js: Added new test.
  • fast/url/file-expected.txt: Added (expected results).
  • fast/url/file.html: Added (wrapper).
  • fast/url/script-tests/TEMPLATE.html: Add an explicit dependable <base> URL to the template, to avoid making test expectations system dependent.


Other test wrappers regenerated for the above change:

  • fast/url/anchor.html:
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
12:25 AM Changeset in webkit [57718] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.

[Qt] GraphicsLayer: performance optimizations
​https://bugs.webkit.org/show_bug.cgi?id=35393

No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::updateState):
12:20 AM QtWebKitRelease20 edited by Henry Haverinen
(diff)
12:19 AM QtWebKit edited by Henry Haverinen
(diff)
12:14 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:14 AM Changeset in webkit [57717] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-16 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebCore::Font::font() causes a QFont detach
​https://bugs.webkit.org/show_bug.cgi?id=37683

Moved the setStyleStrategy call to FontPlatformData
to avoid the detach.

Thanks to Holger for spotting this.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
12:13 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:03 AM Changeset in webkit [57716] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
​http://webkit.org/b/35915

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
  • efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.

Apr 15, 2010:

11:20 PM Changeset in webkit [57715] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Adam Barth.

Remove the check for the main frame's scheme when deciding which
v8 extensions to add to a script context. Instead, Chromium will
handle that check elsewhere to allow finer-grained control over
what APIs we expose to web pages.
​https://bugs.webkit.org/show_bug.cgi?id=37681

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
10:59 PM Changeset in webkit [57714] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-15 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

No default selection for <select multiple> menu lists.
​https://bugs.webkit.org/show_bug.cgi?id=37530

Manual test: manual-tests/no-listbox-rendering.html

For menu lists, if the selection is not indicated by the html file, the first <option> will be
selected after loading the page or reseting the form. On the other hand listboxes may have no
element selected after loading the page or reseting the form.

When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple>
that did not have selected elements, now being menu lists, will have the first <option>
selected. That is the behavior difference that this patch corrects.

When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot
be used to decide about initial selection of the elements. This patch replaces (usesMenuLists())
by (!multiple && size <= 1) where initial selection is considered.

  • dom/SelectElement.cpp: (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::reset):
  • manual-tests/no-listbox-rendering.html: Added.
10:36 PM Changeset in webkit [57713] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Tony Chang <​tony@chromium.org>

Not reviewed, trying to make the tree green.

[qt] fast/url/hosts.html is failing, skip until someone can
investigate.
​https://bugs.webkit.org/show_bug.cgi?id=37697

  • platform/qt/Skipped:
7:50 PM Changeset in webkit [57712] by eric@webkit.org
  • 9 edits in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Clean up unicode URL tests cases
​https://bugs.webkit.org/show_bug.cgi?id=37678

When we started writing these URL tests, I didn't understand how to
handle the unicodes test cases properly. With a bunch of help (and a
pointer to ​http://rishida.net/tools/conversion/), I've fixed these to
be more or less faithful to the original unit tests.

  • fast/url/anchor-expected.txt:
  • fast/url/query-expected.txt:
  • fast/url/script-tests/anchor.js:
  • fast/url/script-tests/query.js:
  • fast/url/script-tests/standard-url.js:
  • fast/url/script-tests/trivial.js:
    • Updated this test to use the shared implementations
    • Also, removed assumptions about the base URL.
  • fast/url/standard-url-expected.txt:
  • fast/url/trivial-expected.txt:
7:38 PM Changeset in webkit [57711] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for host names
​https://bugs.webkit.org/show_bug.cgi?id=37666

  • fast/url/host-expected.txt: Added.
  • fast/url/host.html: Added.
  • fast/url/script-tests/host.js: Added.
7:27 PM Changeset in webkit [57710] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for paths
​https://bugs.webkit.org/show_bug.cgi?id=37672

  • fast/url/path-expected.txt: Added.
  • fast/url/path.html: Added.
  • fast/url/script-tests/path.js: Added.
7:01 PM Changeset in webkit [57709] by eric@webkit.org
  • 7 edits in trunk

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
​https://bugs.webkit.org/show_bug.cgi?id=31892

  • fast/canvas/webgl/index-validation-expected.txt: Add new test cases for index validations.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
​https://bugs.webkit.org/show_bug.cgi?id=31892

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations): Cache active attribute locations for a program at linkProgram time. (WebCore::WebGLProgram::getActiveAttribLocation): Get the cached attribute location. (WebCore::WebGLProgram::numActiveAttribLocations): Get the number of cached attribute locations.
  • html/canvas/WebGLProgram.h: Add attribute locations member.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Add logic not to validate those attributes that do not belong to the current program. (WebCore::WebGLRenderingContext::linkProgram): Call cacheActiveAttribLocations().
6:38 PM Changeset in webkit [57708] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Mark send-form-data-with-sliced-file.html as failed on Chromium Linux.

  • platform/chromium/test_expectations.txt:
6:34 PM Changeset in webkit [57707] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Use GDI text rendering on Windows by default.

Reviewed by Adam Roben.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Use the AlternateRenderingMode
setting.

6:24 PM Changeset in webkit [57706] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Use the threaded process model for MiniBrowser if holding down
the shift key on startup.

Reviewed by Adam Roben.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

6:20 PM Changeset in webkit [57705] by weinig@apple.com
  • 2 edits in trunk/WebCore

Don't assert when soft-linked libraries can't be found

Patch by Adam Roben <Adam Roben> on 2010-04-16
In some situations (e.g., when using SOFT_LINK_OPTIONAL), we expect soft-link libraries not
to be able to be found in all cases. So we shouldn't assert that they're always found.

Reviewed by Sam Weinig.

  • platform/win/SoftLinking.h:

(SOFT_LINK): Don't assert when LoadLibrary fails.

6:17 PM Changeset in webkit [57704] by dimich@chromium.org
  • 15 edits
    8 deletes in trunk

2010-04-15 Dmitry Titov <​dimich@chromium.org>

Unreviewed, rolling out r57688.
​http://trac.webkit.org/changeset/57688
​https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • fast/workers/change-version-handle-reuse-worker-expected.txt: Removed.
  • fast/workers/change-version-handle-reuse-worker.html: Removed.
  • fast/workers/execute-sql-args-worker-expected.txt: Removed.
  • fast/workers/execute-sql-args-worker.html: Removed.
  • fast/workers/resources/database-worker-controller.js: Removed.
  • fast/workers/resources/database-worker.js: Removed.
  • storage/change-version-handle-reuse-expected.txt:
  • storage/change-version-handle-reuse.html:
  • storage/change-version-handle-reuse.js: Removed.
  • storage/execute-sql-args.html:
  • storage/execute-sql-args.js: Removed.

2010-04-15 Dmitry Titov <​dimich@chromium.org>

Unreviewed, rolling out r57688.
​http://trac.webkit.org/changeset/57688
​https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
  • workers/WorkerContext.h: (WebCore::WorkerContext::databaseExceededQuota):
  • workers/WorkerContext.idl:
6:16 PM Changeset in webkit [57703] by tony@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add TestShellGtk.cpp so we can link on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37561

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and

add platform file exceptions.

  • DumpRenderTree/chromium/TestShellGtk.cpp: Added. (AlarmHandler): (TestShell::waitTestFinished):
6:13 PM Changeset in webkit [57702] by tony@chromium.org
  • 5 edits in trunk

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=37639

  • gyp_webkit: generate build files for DRT on mac

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=37639

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/build-dumprendertree: enable build-dumprendertree --chromium
6:08 PM Changeset in webkit [57701] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
6:00 PM Changeset in webkit [57700] by mrowe@apple.com
  • 2 edits in tags/Safari-533.5.1/WebKit/mac

Merge r57692.

6:00 PM Changeset in webkit [57699] by eric@webkit.org
  • 7 edits in trunk/WebKit/chromium

2010-04-15 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Dimitri Glazkov.

Implement layoutTestController's addUserStyleSheet and
setAuthorAndUserStylesEnabled on Chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=37595

  • public/WebSettings.h:
  • public/WebView.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserStyleSheet):
  • src/WebViewImpl.h:
5:58 PM Changeset in webkit [57698] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.1

Versioning.

5:58 PM Changeset in webkit [57697] by jianli@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed.

Updated Skipped list to use the right directory due to directory
shuffling at r57695.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:54 PM Changeset in webkit [57696] by ajwong@chromium.org
  • 5 edits in trunk/LayoutTests

Not reviewed. Sheriffing.

[Chromium] Build fix. Rebaseline these again since the fonts changed again.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
5:50 PM Changeset in webkit [57695] by jianli@chromium.org
  • 12 edits
    2 moves
    9 adds
    1 delete in trunk

Support using FormData to send a sliced file via XHR.
​https://bugs.webkit.org/show_bug.cgi?id=36678

Reviewed by Dmitry Titov.

WebCore:

Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html

  • html/Blob.h:

(WebCore::Blob::isFile):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

  • html/File.h:

(WebCore::File::isFile):

  • html/FormDataList.h:

(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::blob):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::appendFormData):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::closeCurrentStream):

LayoutTests:

Move common functionality to test sending FormData into a helper file
so that it can be shared by FormData layout tests.
Also move the form data testing files to a new subdirectory formdata/.

  • http/tests/local/formdata/resources/send-form-data-common.js: Added.
  • http/tests/local/formdata/script-tests/TEMPLATE.html: Added.
  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js: Added.
  • http/tests/local/formdata/script-tests/send-form-data.js: Added.
  • http/tests/local/formdata/send-form-data-expected.txt: Renamed from LayoutTests/http/tests/local/send-form-data-expected.txt.
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-with-sliced-file.html: Added.
  • http/tests/local/formdata/send-form-data.html: Added.
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:43 PM Changeset in webkit [57694] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

  • fast/canvas/webgl/point-size-expected.txt: Added.
  • fast/canvas/webgl/point-size.html: Added.

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

Test: fast/canvas/webgl/point-size.html

  • platform/graphics/mac/GraphicsContext3DMac.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

  • src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
5:42 PM Changeset in webkit [57693] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.1

New tag.

5:40 PM Changeset in webkit [57692] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.

Reviewed by Sam Weinig.

  • WebView/WebDynamicScrollBarsView.h:
5:36 PM Changeset in webkit [57691] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix crash when trying to load an invalid URL.

Reviewed by Adam Roben.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL): Use constructor for ResourceRequest
that takes a KURL instead of the one that takes a String. The one
that takes a string expects a valid URL.

5:31 PM Changeset in webkit [57690] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add LayoutTestHelper for Mac
​https://bugs.webkit.org/show_bug.cgi?id=37668

LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
5:22 PM Changeset in webkit [57689] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Make tooltips work. Thanks Adam!

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::toolTipChanged): Pass the WebView's HWND, not the tooltip's.

5:10 PM Changeset in webkit [57688] by eric@webkit.org
  • 15 edits
    3 copies
    5 adds in trunk

2010-04-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/execute-sql-args-worker.html: Added.
  • fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/resources/database-worker.js: Added.

2010-04-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
4:58 PM Changeset in webkit [57687] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Nicolas Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Fix drag image thumbnails for indexed images.
​https://bugs.webkit.org/show_bug.cgi?id=37621

  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::scaleDragImage): Always use RGB color space. (WebCore::dissolveDragImageToFraction): Always use RGB color space.
4:56 PM Changeset in webkit [57686] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build dependencies.

Reviewed by Adam Roben.

  • WebKit2.sln:
4:52 PM Changeset in webkit [57685] by ap@apple.com
  • 5 edits
    1 delete in trunk

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=37494
<rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
fails on Windows

  • DumpRenderTree/win/EventSender.cpp: (makeEventSender):
  • DumpRenderTree/win/EventSender.h: Tell EventSender if it's being created for a top frame.


  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset EventSender machinery when a new test is loaded, not when an iframe (or just its global object) is created.
4:51 PM Changeset in webkit [57684] by weinig@apple.com
  • 5 edits in trunk

Fix Windows WebKit2 build.

WebKit2:

Patch by Adam Roben <Adam Roben> on 2010-04-15

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit):

  • win/WebKit2Generated.make:

WebKitTools:

Patch by Adam Roben <Adam Roben> on 2010-04-15

  • MiniBrowser/win/MiniBrowser.cpp:
4:37 PM WebKit Team edited by Joseph Pecoraro
Italics look like quotes in WikiFormatting. But its Magic Quotes. (diff)
4:34 PM WebKit Team edited by Joseph Pecoraro
Moving up in the world ;) (diff)
3:53 PM Changeset in webkit [57683] by Adam Roben
  • 2 edits in trunk/WebKit/mac

Export WebUserContentURLPattern from WebKit

Rubber-stamped by Mark Rowe.

  • WebKit.exp:
3:33 PM Changeset in webkit [57682] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
without intermediate calls -[WebHTMLView _endPrintMode].

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):

3:30 PM Changeset in webkit [57681] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed.

Layout test fix for new test that works differently on leopard v. snow leopard.

AXHelp is being appended from ancestors incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=37659

  • platform/mac/accessibility/unexpected-help-text-expected.txt:
  • platform/mac/accessibility/unexpected-help-text.html:
3:19 PM Changeset in webkit [57680] by Adam Roben
  • 11 edits
    5 adds in trunk

Expose UserContentURLPattern as WebKit SPI

Fixes <​http://webkit.org/b/37354>.

Reviewed by Tim Hatcher.

WebCore:

  • WebCore.base.exp: Export UserContentURLPattern::parse, and sorted

the file.

  • WebCore.xcodeproj/project.pbxproj: Marked UserContentURLPattern.h as

"Private".

  • page/UserContentURLPattern.h:

(WebCore::UserContentURLPattern::UserContentURLPattern): Added a
default constructor.
(WebCore::UserContentURLPattern::isValid): Added this getter.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add WebUserContentURLPattern.

WebKit/mac:

  • Misc/WebUserContentURLPattern.h: Added.
  • Misc/WebUserContentURLPattern.mm: Added.

(-[WebUserContentURLPattern initWithPatternString:]): Initialize
_private and then parse the passed-in string into a
UserContentURLPattern.
(-[WebUserContentURLPattern dealloc]): Release _private.

(-[WebUserContentURLPattern isValid]):
(-[WebUserContentURLPattern scheme]):
(-[WebUserContentURLPattern host]):
(-[WebUserContentURLPattern matchesSubdomains]):
Call through to UserContentURLPattern.

WebKit/win:

  • Interfaces/IWebUserContentURLPattern.idl: Added.
  • Interfaces/WebKit.idl: Added WebUserContentURLPattern.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
  • WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
  • WebUserContentURLPattern.cpp: Added.

(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
(WebUserContentURLPattern::createInstance):
(WebUserContentURLPattern::AddRef):
(WebUserContentURLPattern::Release):
(WebUserContentURLPattern::QueryInterface):
Standard COM implementations.

(WebUserContentURLPattern::parse): Parse the string into a
UserContentURLPattern and store it.

(WebUserContentURLPattern::isValid):
(WebUserContentURLPattern::scheme):
(WebUserContentURLPattern::host):
(WebUserContentURLPattern::matchesSubdomains):
Call through to UserContentURLPattern.

  • WebUserContentURLPattern.h: Added.
3:18 PM Changeset in webkit [57679] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

Include codereview issue number in patch description
​https://bugs.webkit.org/show_bug.cgi?id=37677

This lets us know which rietveld issue this patch is tied to.

Also, make it so that --fancy-review overrides --no-review.

  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
3:11 PM Changeset in webkit [57678] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make --exit-after-n-failures work when all tests are timing out or crashing

Fixes <​http://webkit.org/b/37679>.

Reviewed by Jon Honeycutt.

  • Scripts/run-webkit-tests:

(top level): When a test crashes or times out, break out of the main loop if
stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
from here...
(stopRunningTestsEarlyIfNeeded): ...to here.

2:50 PM Changeset in webkit [57677] by ajwong@chromium.org
  • 6 edits in trunk/LayoutTests

Not reviewed, sheriffing.

[Chromium] Update chromium layout tests expecataions with new baselines. Remove expectations for some tests that seem to be passing now.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/chromium/test_expectations.txt:
2:23 PM Changeset in webkit [57676] by weinig@apple.com
  • 14 edits
    2 copies
    5 adds in trunk

Add WebHistoryClient support.
​https://bugs.webkit.org/show_bug.cgi?id=37671

Reviewed by Anders Carlsson.

WebKit2:

Adds the following callbacks:

didNavigateWithNavigationData
didPerformClientRedirect
didPerformServerRedirect
didUpdateHistoryTitle

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • Shared/WebNavigationDataStore.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNavigationData.cpp: Added.
  • UIProcess/API/C/WKNavigationData.h: Added.
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebHistoryClient.cpp: Copied from UIProcess/WebUIClient.cpp.
  • UIProcess/WebHistoryClient.h: Copied from UIProcess/WebUIClient.h.
  • UIProcess/WebNavigationData.cpp: Added.
  • UIProcess/WebNavigationData.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • win/WebKit2.vcproj:

WebKitTools:

Add HistoryClient logging.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didNavigateWithNavigationData):
(_didPerformClientRedirect):
(_didPerformServerRedirect):
(_didUpdateHistoryTitle):
(-[BrowserWindowController awakeFromNib]):

2:15 PM Changeset in webkit [57675] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2010-04-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Start the mini browser in threaded mode if shift is pressed during startup.
​https://bugs.webkit.org/show_bug.cgi?id=37670

  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]):
2:05 PM Changeset in webkit [57674] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AXHelp is being appended from ancestors incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=37659

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/unexpected-help-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getHelpTextCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::helpText):

LayoutTests:

  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:

Update tests because they were wrong. AXCells should not have their AXHelp come from the AXTable.

  • platform/mac/accessibility/unexpected-help-text-expected.txt: Added.
  • platform/mac/accessibility/unexpected-help-text.html: Added.
2:01 PM Changeset in webkit [57673] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
(broken by r57463 and r57381, at least). I've also filed bug 37477
to fix check-webkit-style to catch these things.

​https://bugs.webkit.org/show_bug.cgi?id=38586

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:01 PM Changeset in webkit [57672] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Add a way to override the user-visible name for the test binary since
some ports don't call it DumpRenderTree (e.g., Chromium Win uses
test_shell, Chromium Mac uses TestShell) by adding a driver_name()
method to the Port interface.

​https://bugs.webkit.org/show_bug.cgi?id=37631

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:55 PM Changeset in webkit [57671] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles don't work right when only the visited path specifies
a pseudoelement.

Reviewed by Anders Carlsson.

Rework the pseudo cache on RenderStyles to support nesting, i.e., a pseudo hanging off a pseudo. The existing model gets
confused by this concept, since it relies on a singly linked list of chained pseudo styles (instead of a Vector owned by a primary
style). I changed the style cache to be a Vector instead.

Reworked both styleForElement and pseudoStyleForElement to resolve visited styles first, since in the pseudoStyleForElement case
you need to do this in order to know to allocate an unvisited pseudo style even if one shouldn't normally exist.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::cachedPseudoStyles):

1:45 PM Changeset in webkit [57670] by ajwong@chromium.org
  • 18 edits
    1 delete in trunk

2010-04-15 Albert J. Wong <​ajwong@chromium.org>

Unreviewed, rolling out r57660.
​http://trac.webkit.org/changeset/57660
​https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::ScriptDebugServer):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Albert J. Wong <​ajwong@chromium.org>

Unreviewed, rolling out r57660.
​http://trac.webkit.org/changeset/57660
​https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Removed.
  • src/js/DevTools.js: (WebInspector.loaded): (WebInspector.UnresolvedPropertyValue): ():
  • src/js/DevToolsHostStub.js:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
1:44 PM Changeset in webkit [57669] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-15 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Mark QWebFrame::overloadedSlots autotest as expected failure

​https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp:
1:40 PM Changeset in webkit [57668] by dumi@chromium.org
  • 4 edits in trunk/WebCore

DatabaseTracker refactoring: remove the dependency on
OriginQuotaManager from DatabaseTracker.h
​https://bugs.webkit.org/show_bug.cgi?id=31482

Reviewed by Dimitri Glazkov.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::~DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

1:36 PM Changeset in webkit [57667] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove empty file configurations.

Reviewed by Adam Roben.

  • win/WebKit2.vcproj:
1:28 PM Changeset in webkit [57666] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

[v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=37655

  • platform/chromium/test_expectations.txt:
1:18 PM Changeset in webkit [57665] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
​http://webkit.org/b/35918

  • efl/WebCoreSupport/EditorClientEfl.cpp: Added.
  • efl/WebCoreSupport/EditorClientEfl.h: Added.
1:07 PM Changeset in webkit [57664] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
​https://bugs.webkit.org/show_bug.cgi?id=36908

  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0. (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
12:33 PM Changeset in webkit [57663] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
​https://bugs.webkit.org/show_bug.cgi?id=37635

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.

  • page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):

12:26 PM Changeset in webkit [57662] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method ​https://bugs.webkit.org/show_bug.cgi?id=37634

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This assignment line is not longer needed after r57061, bug that refactored all
assignment logic to happen lines below in the method.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

11:47 AM Changeset in webkit [57661] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix WebKit2s build. Don't return temporaries.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCreateWithCFString):

  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

11:40 AM Changeset in webkit [57660] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
11:32 AM Changeset in webkit [57659] by Nikolas Zimmermann
  • 6 edits
    4 adds in trunk

2010-04-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
​https://bugs.webkit.org/show_bug.cgi?id=37575

Test: svg/custom/clip-path-id-changes.svg

  • rendering/RenderSVGResource.h: (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::idChanged): (WebCore::getRenderSVGResourceById):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):

2010-04-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
​https://bugs.webkit.org/show_bug.cgi?id=37575

  • platform/mac/svg/custom/clip-path-id-changes-expected.checksum: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.png: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.txt: Added.
  • svg/custom/clip-path-id-changes.svg: Added.
11:24 AM Changeset in webkit [57658] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

2010-04-15 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

LayoutTest breakage in V8 bindings after r57627
​https://bugs.webkit.org/show_bug.cgi?id=37660

Fixes breakage of the following tests due to an error in V8 bindings for
NamedNodeMap:
hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback):
11:22 AM Changeset in webkit [57657] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color. Make sure
that the pseudo style caching allows visited link styles to hang off other pseudo styles.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):

11:21 AM Changeset in webkit [57656] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

REGRESSION(r56552): Broken scrollbars size ​https://bugs.webkit.org/show_bug.cgi?id=36853

Reviewed by Kenneth Christiansen and Tor Arne Vestbø.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

The regression was caused by r56552, which introduced a fix to bug
webkit.org/b/21300. The bug solved an issue with the resize handle on mac,
but did it in a way that affected all Qt platforms and thus broke the behavior
on non-mac platforms.

This patch makes the mac specific change ifdef'ed and only applied for the mac
platform.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

11:13 AM Changeset in webkit [57655] by benm@google.com
  • 5 edits in trunk

2010-04-15 Ben Murdoch <​benm@google.com>

Unreviewed, rolling out r57652.
​http://trac.webkit.org/changeset/57652
​https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState):

2010-04-15 Ben Murdoch <​benm@google.com>

Unreviewed, rolling out r57652.
​http://trac.webkit.org/changeset/57652
​https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::):
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
10:51 AM Changeset in webkit [57654] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add "Force Repaint" to debug menu.
​https://bugs.webkit.org/show_bug.cgi?id=37627

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController forceRepaint:]):
  • MiniBrowser/mac/English.lproj/MainMenu.xib:
10:33 AM Changeset in webkit [57653] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-15 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Nate Chapin.

Overloads auto-generation in V8
​https://bugs.webkit.org/show_bug.cgi?id=37373

This will be used by XHR.send/open, Canvas.*, WebGL.* methods that are currently custom. When more than a single overload exists for a method, the correct overload is chosen based on the total number of arguments passed as well as the values passed to non-primitive arguments.

Overload dispatch order depends on the order the functions are defined in the IDL. Overloads must be specified from the most precise (overloads with wrapper type arguments) to the least precise (overloads with only primitive type arguments).

  • bindings/scripts/CodeGeneratorV8.pm: Identify and output overloads callbacks and dispatch code.
  • bindings/v8/test/TestObj.idl: Overloads sample.
  • bindings/v8/test/V8TestObj.cpp: Output change.
10:18 AM Changeset in webkit [57652] by benm@google.com
  • 5 edits in trunk

2010-04-14 Ben Murdoch <​benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint is not
handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided that
this is a currently unused state without a good future use case in the
Touch API and thus decided to remove it. This patch actions that decision.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState): Remove TouchStationary.

2010-04-15 Ben Murdoch <​benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint
is not handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided
that this is a currently unused state without a good future use
case in the Touch API and thus decided to remove it. This patch
actions that decision.

As the TouchStationary state is not handled in the EventHandler,
there is no change in functionality so no new tests are required.

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::): Remove TouchStationary.
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Remove TouchStationary.
10:03 AM Changeset in webkit [57651] by weinig@apple.com
  • 2 edits
    1 copy in trunk/WebKitTools

Add debug-minibrowser script.

Reviewed by Adam Roben.

  • Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
  • Scripts/webkitdirs.pm:
9:57 AM Changeset in webkit [57650] by sfalken@apple.com
  • 3 edits in trunk/WebCore

2010-04-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Use a lower-overhead mechanism for plug-in message throttling
​https://bugs.webkit.org/show_bug.cgi?id=37642
<rdar://problem/7418285> Very high CPU usage idling in gmail under Windows 7 (plug-in related)


GMail has an instance of Flash that loads on the main mail page.
This Flash content sends us a constant stream of WM_USER+1 messsages.


There was already code in PluginMessageThrottlerWin to queue and process these
excess WM_USER+1 messages from Flash. Unfortunately, there were a couple of
problems with this code:


  • The timer used to process the excess messages had a very low timeout (1ms). Chrome uses a value of 5ms for this delay, and doesn't use excess CPU here, while still maintaining good Flash frame rate.


  • The overhead involved in generating a constant stream of 5ms timers still swamped the CPU, resulting in continued high CPU utilization.


To fix this, I changed the throttling code to:


  • Process a queued WM_USER+1 message directly if none has been processed in 5ms. This allows us to avoid the overhead of a timer.


  • Process remaining delayed WM_USER+1 messages on a 16ms timer.


This reduces our CPU utilization idling in GMail from ~20% to ~2-3% on my system.
I also verified the frame rate for Flash content wasn't reduced with this change.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Initialize m_lastMessageTime. (WebCore::PluginMessageThrottlerWin::appendMessage): Process a queued message directly if >5ms have passed. (WebCore::PluginMessageThrottlerWin::processQueuedMessage): Split out from messageThrottleTimerFired. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Call through to processQueuedMessage.
  • plugins/win/PluginMessageThrottlerWin.h: Add processQueuedMessage, m_lastMessageTime.
8:59 AM Changeset in webkit [57649] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-04-15 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
​https://bugs.webkit.org/show_bug.cgi?id=37636

Second patch: add Windows-specific implementation parts
of TestShell.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestShell.h: (TestShell::finishedEvent):
  • DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): (TestShell::waitTestFinished):
8:50 AM Changeset in webkit [57648] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-15 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
​https://bugs.webkit.org/show_bug.cgi?id=37636

First patch: fix compiler errors.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): (EventSender::dispatchMessage):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TestWebWorker.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
8:20 AM Changeset in webkit [57647] by antonm@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline URL related tests: update expectations for Win and Mac.

​https://bugs.webkit.org/show_bug.cgi?id=37654

  • platform/chromium-mac/fast/url/mailto-expected.txt: Added.
  • platform/chromium-mac/fast/url/scheme-expected.txt: Added.
  • platform/chromium-win/fast/url/mailto-expected.txt: Added.
  • platform/chromium-win/fast/url/scheme-expected.txt: Added.
7:52 AM Changeset in webkit [57646] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-04-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

LEAK: in ThreadableWebSocketChannel::create()
​https://bugs.webkit.org/show_bug.cgi?id=37584

No new tests because this change just fixes a leak.

  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
7:41 AM Changeset in webkit [57645] by ggaren@apple.com
  • 17 edits
    1 delete in trunk/WebKit2

Fixed complexity and performance FIXME created by using KURL in the UI
process -- it turned out that everywhere we were using KURL, we could
have just used String instead. (That's how Windows WebKit works, too.)

Reviewed by Anders Carlsson.

I kept WKURLRef and WKStringRef distinct opaque types in the API for now,
though, since there may be profit in changing their backing stores in the
future, and it's nice for the API to encode a difference between generic
strings and strings that are valid, canonical URLs.

  • Shared/KURLWrapper.h: Removed. Yay!
  • Shared/WebCoreTypeArgumentMarshalling.h: Nixed KURL marshalling functions.

Old callers marshal Strings now, instead. (This is what KURL was doing
under the covers, anyway.)

  • UIProcess/API/C/WKAPICast.h:

(toWK): Backed by StringImpl* now.
(toURLRef): Added a disambiguating function for specifying that you want
a WKURLRef, since StringImpl* converts to WKStringRef by default.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetProvisionalURL):
(WKFrameGetURL):

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadURL):

  • UIProcess/API/C/WKURL.cpp:
  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h: Replaced KURL / KURLWrapper with String.
7:40 AM Changeset in webkit [57644] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline svg/custom/path-bad-data.svg after ​http://trac.webkit.org/changeset/57591/

​http://trac.webkit.org/changeset/57591://bugs.webkit.org/show_bug.cgi?id=37657

  • platform/chromium-linux/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-linux/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
7:18 AM Changeset in webkit [57643] by antonm@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline fast/repaint/fixed-tranformed.html after
​http://trac.webkit.org/changeset/57633/

​https://bugs.webkit.org/show_bug.cgi?id=37656

  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint: Added.
  • platform/chromium-win-xp/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.png: Added.
6:41 AM Changeset in webkit [57642] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2010-04-15 William Siegrist <​wsiegrist@apple.com>

Give a name to new KillOldProcesss step so it does not collide with the other compile step.

6:39 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:19 AM Changeset in webkit [57641] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-04-15 William Siegrist <​wsiegrist@apple.com>

Add core/noncore categories to builders.

6:15 AM Changeset in webkit [57640] by antonm@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

Rebaseline some recently added LayoutTests under fast/url.

  • platform/chromium-linux/fast/url: Added.
  • platform/chromium-linux/fast/url/mailto-expected.txt: Added.
  • platform/chromium-linux/fast/url/scheme-expected.txt: Added.
  • platform/chromium-mac/fast/url: Added.
  • platform/chromium-mac/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-mac/fast/url/path-url-expected.txt: Added.
  • platform/chromium-mac/fast/url/port-expected.txt: Added.
  • platform/chromium-mac/fast/url/standard-url-expected.txt: Added.
  • platform/chromium-win/fast/url: Added.
  • platform/chromium-win/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-win/fast/url/path-url-expected.txt: Added.
  • platform/chromium-win/fast/url/port-expected.txt: Added.
  • platform/chromium-win/fast/url/standard-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:03 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:54 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:32 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
4:51 AM Changeset in webkit [57639] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-15 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

Duplicated patches related to wml were pushed to trunk. So, one of
the patches should be reverted.
​https://bugs.webkit.org/show_bug.cgi?id=37542

  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.h:
4:01 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
3:32 AM BuildingQtOnLinux edited by jocelyn.turcotte@nokia.com
(diff)
3:03 AM Changeset in webkit [57638] by eric@webkit.org
  • 5 edits in trunk

2010-04-15 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.
So now the code below properly checks for null pointers:

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getClass): may return NULL (JSC::Bindings::QtInstance::getMethod): may return jsNull() (JSC::Bindings::QtInstance::stringValue): may return jsNull() (JSC::Bindings::QtInstance::booleanValue): may return false
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): May return jsNull on QObjectStar

2010-04-15 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.

Follow the tests for the corrections done over WebCore.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): init the field m_objectStar (MyQObject::objectStarProperty): read the Object* prop (MyQObject::setObjectStarProperty): write the Object* prop (tst_QWebFrame::getSetStaticProperty): new tests for the new prop
2:53 AM Changeset in webkit [57637] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-15 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak in QScriptEngine::evaluate().

QScriptEnginePrivate::evaluate should release temporary variables.

[Qt] QScriptEngine::evaluate has memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37596

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h:
1:14 AM Changeset in webkit [57636] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Jonathan Dixon <​joth@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37492

Add mailto: canonicalization tests to the URL regressions tests

  • fast/url/mailto-expected.txt: Added.
  • fast/url/mailto.html: Added.
  • fast/url/script-tests/mailto.js: Added.
1:07 AM Changeset in webkit [57635] by abarth@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add URL scheme parsing tests
​https://bugs.webkit.org/show_bug.cgi?id=37496

I'm not super happy with how these test turned out. It's difficult to
test these cases with this methodology because most of the cases get
treated as relative URLs. I tired using the "protocol" property of the
HTMLAnchorElement, but that often caused the test case to be ignored
for reasons I don't fully understand.

  • fast/url/resources/utilities.js: (setBaseURL):
    • In the course of trying various variations of this test, I wrote this function. It seemed useful, so I left it here for the benefit of future test writing.
  • fast/url/scheme-expected.txt: Added.
  • fast/url/scheme.html: Added.
  • fast/url/script-tests/scheme.js: Added.
12:55 AM Changeset in webkit [57634] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add comments back to IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37620

I removed these comments when importing this test. The comments are
likley to be helpful to us in the future, so I've restored them.

  • fast/url/script-tests/ipv4.js:

Apr 14, 2010:

11:49 PM April 2010 Meeting edited by vestbo@webkit.org
(diff)
9:48 PM Changeset in webkit [57633] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-04-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Repaint of fixed, transformed element is broken
​https://bugs.webkit.org/show_bug.cgi?id=37637

RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.

Also cache style()->position() in a local variable for performance.

Test: fast/repaint/fixed-tranformed.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
9:47 PM Changeset in webkit [57632] by Simon Fraser
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

​https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

9:04 PM Changeset in webkit [57631] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
  • WebCoreSupport/ChromeClientQt.h:
8:37 PM Changeset in webkit [57630] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Adam Barth <​abarth@webkit.org>

Unreviewed attempt to fix Qt build.

  • bindings/js/JSNodeCustom.cpp:
8:34 PM Changeset in webkit [57629] by eric@webkit.org
  • 6 edits in trunk

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • Api/qwebpage.cpp: (qt_wrt_setViewMode):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
8:17 PM Changeset in webkit [57628] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in QScriptValue::inherits.

[Qt] QScriptValue::inherits has a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37617

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::inherits):
8:11 PM Changeset in webkit [57627] by abarth@webkit.org
  • 16 edits in trunk

2010-04-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Javascript URL can be set as iframe.src via multiple DOM aliases
​https://bugs.webkit.org/show_bug.cgi?id=37031

Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::setNamedItem): (WebCore::JSNamedNodeMap::setNamedItemNS):
  • bindings/js/JSNodeCustom.cpp: (WebCore::isAttrFrameSrc): (WebCore::JSNode::setNodeValue): (WebCore::JSNode::setTextContent): (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback): (WebCore::toV8):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::isFrameSrc): (WebCore::V8Node::textContentAccessorSetter): (WebCore::V8Node::nodeValueAccessorSetter): (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
  • dom/Attr.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:

2010-04-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Fix frame/iframe src setting for JavaScript URLs
​https://bugs.webkit.org/show_bug.cgi?id=37031

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
8:07 PM Changeset in webkit [57626] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a few memory leaks in QScriptEngine.

Syntax checking caused memory leak, not all temporary variables were released.

[Qt] Syntax checking in the QtScript cause a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37610

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
  • qt/api/qscriptsyntaxcheckresult.cpp: (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
7:58 PM Changeset in webkit [57625] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak inside QScriptEnginePrivate::makeJSValue.

QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.

[Qt] tst_QScriptValue::toString has a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37598

  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):
6:39 PM Changeset in webkit [57624] by alex
  • 2 edits in trunk/WebCore

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to check if the resource handler is cancelled before
checking the client, other case it could crash.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
6:06 PM Changeset in webkit [57623] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Rendering artifacts on Qt plugins when scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=37152

Because we no longer repaint the entire viewport on scroll,
we must trigger a repaint of QtPluginWidgets when their geometry changes.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
5:59 PM Changeset in webkit [57622] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Add some very minimal unit tests for new-run-webkit-tests. This should
be enough to catch egregious brokenness like syntax errors and import
declaration issues.

​https://bugs.webkit.org/show_bug.cgi?id=37432

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
5:46 PM Changeset in webkit [57621] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix horizontal scrollbar repainting
​https://bugs.webkit.org/show_bug.cgi?id=37626

Make sure that the update chunk is flipped because that's what WebCore expects.


  • Shared/mac/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
  • Shared/mac/UpdateChunk.h: Add new createImage member function that creates a CGImageRef from the update chunk.


  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): Pass the right rectangle here; CoreGraphics wants it in non-flipped coordinates.


(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
Create a flipped backing store.

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): Flip the update chunk.
5:13 PM Changeset in webkit [57620] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS: Pull sub deps from chromium's DEPS file
4:33 PM Changeset in webkit [57619] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:31 PM Changeset in webkit [57618] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5

New tag.

4:25 PM Changeset in webkit [57617] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Xan Lopez <​xlopez@igalia.com>

[GTK] scrollbars/scrollbar-crash-on-refresh.html is flakey on debug bots
​https://bugs.webkit.org/show_bug.cgi?id=37623

We are on a mission here, people.

  • platform/gtk/Skipped:
4:11 PM Changeset in webkit [57616] by eric@webkit.org
  • 5 edits
    2 deletes in trunk

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
​http://trac.webkit.org/changeset/57609
​https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/console-resource-errors-expected.txt: Removed.
  • inspector/console-resource-errors.html: Removed.

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
​http://trac.webkit.org/changeset/57609
​https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
4:01 PM Changeset in webkit [57615] by Adam Roben
  • 5 edits in trunk/WebKit/win

Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows

Fixes <​http://webkit.org/b/37619>.

Reviewed by Steve Falkenburg.

  • Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
  • Interfaces/WebKit.idl: Touched to force a build.
  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

  • WebScriptWorld.h:

Added. Just calls through to DOMWrapperWorld::unregisterWorld.

3:32 PM Changeset in webkit [57614] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping fast/workers/shared-worker-frame-lifecycle.html
​https://bugs.webkit.org/show_bug.cgi?id=37616

  • platform/gtk/Skipped:
3:15 PM Changeset in webkit [57613] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't cache SimpleFontData* in getLastResortFallbackFont. The cached entry may be invalidated.
​https://bugs.webkit.org/show_bug.cgi?id=37599

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
3:06 PM Changeset in webkit [57612] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing, I've duplicated the other printing bugs and
left this one.
​https://bugs.webkit.org/show_bug.cgi?id=37613

  • platform/gtk/Skipped:
2:53 PM Changeset in webkit [57611] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

2:51 PM Changeset in webkit [57610] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-layout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=37611

  • platform/gtk/Skipped:
2:49 PM Changeset in webkit [57609] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-14 Andrey Kosyakov <​caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

  • inspector/console-resource-errors-expected.txt: Added.
  • inspector/console-resource-errors.html: Added.

2010-04-14 Andrey Kosyakov <​caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

Test: inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2:38 PM Changeset in webkit [57608] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-04-14 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.

​https://bugs.webkit.org/show_bug.cgi?id=37571

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::jitCompileRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!):
  • yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
2:24 PM Changeset in webkit [57607] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always.html
​https://bugs.webkit.org/show_bug.cgi?id=37607

  • platform/gtk/Skipped:
2:10 PM Changeset in webkit [57606] by eric@webkit.org
  • 6 edits
    1 delete in trunk

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
​http://trac.webkit.org/changeset/57599
​https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
​http://trac.webkit.org/changeset/57599
​https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • WebKit.gyp:
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: Removed.
2:08 PM Changeset in webkit [57605] by weinig@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add WKRetainPtr helper class as private header
​https://bugs.webkit.org/show_bug.cgi?id=37603

Reviewed by Anders Carlsson.

WKRetainPtr is just like RetainPtr, but works for WK types instead of
CF/NS types.

  • UIProcess/API/cpp: Added.
  • UIProcess/API/cpp/WKRetainPtr.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add new file.
  • win/WebKit2.vcproj: Ditto.
1:51 PM Changeset in webkit [57604] by aa@chromium.org
  • 10 edits in trunk

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • notifications/Notification.cpp: (WebCore::Notification::Notification): Accept resolved KURL instead of relative string.
  • notifications/Notification.h: (WebCore::Notification::create): Ditto. (WebCore::Notification::iconURL): Return resolved KURL instead of relative string.
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): Immediately resolve URL instead of passing off relative string. (WebCore::NotificationCenter::createNotification): Ditto.
  • notifications/NotificationContents.h: (WebCore::NotificationContents::NotificationContents): Accept resolved KURL instead of relative string. (WebCore::NotificationContents::icon): Return resolved URL.

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • public/WebNotification.h: Remove deprecated icon() method.
  • src/WebNotification.cpp: Ditto.

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed.
1:39 PM Changeset in webkit [57603] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton.
​https://bugs.webkit.org/show_bug.cgi?id=37601

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm: (-[WebCoreFlippedView isFlipped]): (WebCore::paintButton): (WebCore::ThemeMac::ensuredView):
1:32 PM Changeset in webkit [57602] by bweinstein@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Add a way for the buildbot to kill any old processes that are running. This
is useful because the Windows bots can get in states where a process remains
running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
state, and the processes must be killed manually.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill

the old processes that might be running.

  • BuildSlaveSupport/win/kill-old-processes: Added.
1:26 PM Changeset in webkit [57601] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Make the WebProcess a LSUIElement to suppress its icon from the Dock.

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Info.plist:
1:23 PM Changeset in webkit [57600] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Tear down WebKit more completely on window closing and application
termination. We still don't block application termination for pending
close, but this is a step in the right direction.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate applicationWillTerminate:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dealloc]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):

1:21 PM Changeset in webkit [57599] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-14 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
1:18 PM Changeset in webkit [57598] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

I thought that skipping this test was causing other http tests to time
out, but Brian Weinstein pointed out that the timing-out tests come
before this one so shouldn't be affected by it.

<​http://webkit.org/b/37096> tracks making this test not time out.

Rubber-stamped by Brian Weinstein.

  • platform/win/Skipped:
1:01 PM Changeset in webkit [57597] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

Add tests for ipv6 address canonicalization.
​https://bugs.webkit.org/show_bug.cgi?id=37583

  • fast/url/ipv6-expected.txt: Added.
  • fast/url/ipv6.html: Added.
  • fast/url/script-tests/ipv6.js: Added.
12:44 PM PythonGuidelines edited by Chris Jerdonek
Clarified suggested import ordering style guideline. (diff)
12:42 PM Changeset in webkit [57596] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Factor code to paint into an update chunk out into a separate function.
​https://bugs.webkit.org/show_bug.cgi?id=37594

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::setSize):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
12:24 PM Changeset in webkit [57595] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Remove an incorrect ASSERT in UniscribeHelper::draw().
​https://bugs.webkit.org/show_bug.cgi?id=37533

Reviewed by Jian Li.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

11:56 AM Changeset in webkit [57594] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: readline shortcuts don't work in Chromium.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype._moveCaretToStartOfPrompt):
11:45 AM Changeset in webkit [57593] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always-for-overflow.html
​https://bugs.webkit.org/show_bug.cgi?id=37592

  • platform/gtk/Skipped:
11:42 AM Changeset in webkit [57592] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
​https://bugs.webkit.org/show_bug.cgi?id=37582

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype._tabKeyPressed):
11:30 AM Changeset in webkit [57591] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Update path parser test for Bug 37413: ​https://bugs.webkit.org/show_bug.cgi?id=37413
now that all path segments render up until the first error

  • platform/mac/svg/custom/path-bad-data-expected.txt: updated path segments that render
  • svg/custom/path-bad-data.svg: updated test to ensure reference image is the same
  • svg/dom/fuzz-path-parser-expected.txt: updated path segments that render
  • svg/dom/path-parser-expected.txt: updated path segments that render
  • svg/dom/script-tests/path-parser.js: changed expected results for path segments that render ():

2010-04-14 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Render SVG Paths up to first error, bug 37413: ​https://bugs.webkit.org/show_bug.cgi?id=37413

  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathSegListBuilder::build):
11:18 AM Changeset in webkit [57590] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Ctrl-L (Clear History) does nothing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37579

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
10:51 AM Changeset in webkit [57589] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/numberOfPages.html
​https://bugs.webkit.org/show_bug.cgi?id=37585

  • platform/gtk/Skipped:
10:42 AM Changeset in webkit [57588] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add port URL tests
​https://bugs.webkit.org/show_bug.cgi?id=37524

This went pretty well.

  • fast/url/port-expected.txt: Added.
  • fast/url/port.html: Added.
  • fast/url/script-tests/port.js: Added.
10:27 AM Changeset in webkit [57587] by eric@webkit.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Use pretty patch for confirming webkit-patch diffs
​https://bugs.webkit.org/show_bug.cgi?id=37489

  • Scripts/webkitpy/common/prettypatch.py: Added.
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
10:16 AM Changeset in webkit [57586] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing "path" URLs
​https://bugs.webkit.org/show_bug.cgi?id=37581

  • fast/url/path-url-expected.txt: Added.
  • fast/url/path-url.html: Added.
  • fast/url/script-tests/path-url.js: Added.
10:06 AM Changeset in webkit [57585] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing standard URLs
​https://bugs.webkit.org/show_bug.cgi?id=37580

  • fast/url/script-tests/standard-url.js: Added.
  • fast/url/standard-url-expected.txt: Added.
  • fast/url/standard-url.html: Added.
9:39 AM Changeset in webkit [57584] by Adam Roben
  • 2 edits in trunk/LayoutTests

Roll out r57566

It seems to have caused other http tests to hang on Windows.

  • platform/win/Skipped:
9:26 AM Changeset in webkit [57583] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Maciej Stachowiak.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
​https://bugs.webkit.org/show_bug.cgi?id=34888

When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.

Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.

Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.

  • wtf/VMTags.h:
9:17 AM WebInspector edited by apavlov@chromium.org
Fix column title, add Chrome/Chromium-specific shortcuts (diff)
9:08 AM Changeset in webkit [57582] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

Skip some and add test expectations for other layout tests which started to fail
against Chromium after ​http://trac.webkit.org/changeset/57535/

  • platform/chromium/test_expectations.txt:
8:48 AM WebInspector edited by apavlov@chromium.org
Add Win/Linux shortcuts (diff)
8:19 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:07 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:02 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:56 AM Changeset in webkit [57581] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skipping another crash on the 64bit Gtk slave.

  • platform/gtk/Skipped:
7:52 AM Changeset in webkit [57580] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/open-and-close-window-with-plugin.html
​https://bugs.webkit.org/show_bug.cgi?id=37572

Skipping media/video-played-ranges-1.html
​https://bugs.webkit.org/show_bug.cgi?id=37573

  • platform/gtk/Skipped:
7:45 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:25 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:12 AM Changeset in webkit [57579] by antonm@chromium.org
  • 26 edits
    147 adds
    1 delete in trunk/LayoutTests/platform

Not reviewed.

BUG=​http://code.google.com/p/chromium/issues/detail?id=41450

6:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:12 AM Changeset in webkit [57578] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-04-14 Anton Muhin <​antonm@chromium.org>

Not review, build fix.

Add <limits.h> include to bring UINT_MAX.

  • html/canvas/WebGLArray.h:
4:11 AM Changeset in webkit [57577] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57573.
​http://trac.webkit.org/changeset/57573
​https://bugs.webkit.org/show_bug.cgi?id=37569

Revert r57573 which unskipped http/tests/media/video-
cookie.html on SnowLeopard Intel Release (Tests). Let's get a
core builder back to green again. (Requested by WildFox on
#webkit).

  • platform/mac/Skipped:
4:00 AM Changeset in webkit [57576] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to unbreak build - NodeRenderStyle.h is an _interessting_ concept...

  • rendering/style/SVGRenderStyle.cpp: Include 'NodeRenderStyle.h'
3:44 AM Changeset in webkit [57575] by Nikolas Zimmermann
  • 14 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
​https://bugs.webkit.org/show_bug.cgi?id=37568

Cleanup SVGRenderStyle / SVGRenderStyleDefs:

  • use copy constructors in initialization list to initialize members, instead of assignment operators in the body
  • fix style issues (misplaced references, abbrevations)
  • merge StyleClipData/StyleMaskData to save memory, rename it StyleResourceData
  • move filter property in StyleResourceData
  • rename StyleMarkerData to StyleInheritedResourceData to highlight the difference to StyleResourceData
  • unify naming schemes for all resources (filter/clipper/masker/markers)
    • clipPath() -> clipperResource()
    • maskElement() -> maskerResource()
    • startMarker() -> markerStartResource()
    • midMarker() -> markerMidResource()
    • endMarker() -> markerEndResource()
    • filter() -> filterResource()

Adapt all callsites to the renames above.
No new tests, as this doesn't affect anything except memory overhead.

  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle): (WebCore::SVGRenderStyle::operator==): (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==): (WebCore::StyleStopData::StyleStopData): (WebCore::StyleStopData::operator==): (WebCore::StyleTextData::StyleTextData): (WebCore::StyleMiscData::StyleMiscData): (WebCore::StyleMiscData::operator==): (WebCore::StyleShadowSVGData::StyleShadowSVGData): (WebCore::StyleShadowSVGData::operator==): (WebCore::StyleResourceData::StyleResourceData): (WebCore::StyleResourceData::operator==): (WebCore::StyleInheritedResourceData::StyleInheritedResourceData): (WebCore::StyleInheritedResourceData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: (WebCore::StyleFillData::operator!=): (WebCore::StyleStopData::operator!=): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy): (WebCore::StyleMiscData::operator!=): (WebCore::StyleShadowSVGData::create): (WebCore::StyleShadowSVGData::copy): (WebCore::StyleShadowSVGData::operator!=): (WebCore::StyleResourceData::create): (WebCore::StyleResourceData::copy): (WebCore::StyleResourceData::operator!=): (WebCore::StyleInheritedResourceData::create): (WebCore::StyleInheritedResourceData::copy): (WebCore::StyleInheritedResourceData::operator!=):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
3:23 AM Changeset in webkit [57574] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

  • fast/canvas/webgl/read-pixels-expected.txt: Verify pixelStorei and readPixels.
  • fast/canvas/webgl/read-pixels.html: Ditto.

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

Test: fast/canvas/webgl/read-pixels.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init members to support pack_alignment. (WebCore::WebGLRenderingContext::pixelStorei): Save pack/unpack_alignment. (WebCore::WebGLRenderingContext::readPixels): Validate enum and deal with pack_alignment.
  • html/canvas/WebGLRenderingContext.h: Add members to support pack_alignment.
  • platform/graphics/GraphicsContext3D.h: Refactor readPixels.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

  • src/GraphicsContext3D.cpp: Refactor readPixels.
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
3:11 AM Changeset in webkit [57573] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Nicolas Weber <​thakis@chromium.org>

Reviewed by Gustavo Noronha Silva.

Remove passing test from Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=34287

  • platform/mac/Skipped: video-cookie.html seems to be passing, so remove it from Skipped list.
2:00 AM Changeset in webkit [57572] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to handle revisions missing ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=37519

Make commit_info_for_revision return None when revision
is missing a ChangeLog. Previously we would throw an array index
exception.
Teach callers how to handle None.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
1:51 AM Changeset in webkit [57571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Re-write testProfilerTab to match the new implementation.

​https://bugs.webkit.org/show_bug.cgi?id=37516

  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab):
12:34 AM Changeset in webkit [57570] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-data-url.html
​https://bugs.webkit.org/show_bug.cgi?id=37564

  • platform/gtk/Skipped:
12:15 AM Changeset in webkit [57569] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/update-widgets-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=37562

  • platform/gtk/Skipped:
12:03 AM Changeset in webkit [57568] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/video-seeking.html
​https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
​https://bugs.webkit.org/show_bug.cgi?id=37552

Skipping media/video-played-reset.html
​https://bugs.webkit.org/show_bug.cgi?id=37556

Skipping http/tests/misc/image-blocked-src-change.html
​https://bugs.webkit.org/show_bug.cgi?id=37557

Skipping inspector/console-clear.html
​https://bugs.webkit.org/show_bug.cgi?id=37558

Skipping inspector/console-format-collections.html
​https://bugs.webkit.org/show_bug.cgi?id=37559

Skipping svg/dom/SVGScriptElement/script-set-href.svg
​https://bugs.webkit.org/show_bug.cgi?id=37560

  • platform/gtk/Skipped:

Apr 13, 2010:

11:36 PM Changeset in webkit [57567] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping svg/custom/use-instanceRoot-as-event-target.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=37544

Skipping plugins/setProperty.html
​https://bugs.webkit.org/show_bug.cgi?id=37545

Skipping media/audio-delete-while-slider-thumb-clicked.html
​https://bugs.webkit.org/show_bug.cgi?id=37546

Skipping media/video-currentTime-set2.html
​https://bugs.webkit.org/show_bug.cgi?id=37547

Skipping media/video-seekable.html
​https://bugs.webkit.org/show_bug.cgi?id=37548

Skipping media/video-currentTime-set.html
​https://bugs.webkit.org/show_bug.cgi?id=37549

Skipping fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
​https://bugs.webkit.org/show_bug.cgi?id=37550

Skipping media/video-seeking.html
​https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
​https://bugs.webkit.org/show_bug.cgi?id=37552

  • platform/gtk/Skipped:
11:22 PM Changeset in webkit [57566] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

<​http://webkit.org/b/37096> tracks making this test not time out.

Reviewed by Eric Seidel.

  • platform/win/Skipped:
11:13 PM Changeset in webkit [57565] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results for text-control-intrinsic-widths.html

<​http://webkit.org/b/37091> tracks deciding whether these results are
better than the previous ones or not.

Reviewed by Eric Seidel.

  • platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
11:12 PM Changeset in webkit [57564] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r57511): many new graphics / svg related leaks
​https://bugs.webkit.org/show_bug.cgi?id=37527

The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient):
11:12 PM Changeset in webkit [57563] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows failing results for mouse-drag-from-frame-to-other-frame.html

<​http://webkit.org/b/37494> tracks fixing this test.

Reviewed by Eric Seidel.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Added.
11:11 PM Changeset in webkit [57562] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows failing results for font-face-opentype.html

<​http://webkit.org/b/37089> tracks fixing this test.

Reviewed by Eric Seidel.

  • platform/win/fast/css/font-face-opentype-expected.txt: Added.
11:09 PM Changeset in webkit [57561] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
​https://bugs.webkit.org/show_bug.cgi?id=33297

This is an experiment. The bots have been green for
a while. We'll see if adding them under sheriff-bot protection
will keep them green.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
10:56 PM Changeset in webkit [57560] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2010-04-13 Darin Fisher <​darin@chromium.org>

Update skipped lists for failing tests:
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
10:29 PM Changeset in webkit [57559] by eric@webkit.org
  • 12 edits in trunk

2010-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
​https://bugs.webkit.org/show_bug.cgi?id=37466

  • fast/canvas/webgl/array-unit-tests-expected.txt: Add tests that would cause overflow without this fix, but work fine with this fix.
  • fast/canvas/webgl/array-unit-tests.html: Ditto.

2010-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
​https://bugs.webkit.org/show_bug.cgi?id=37466

  • html/canvas/WebGLArray.h: (WebCore::WebGLArray::clampOffsetAndNumElements): Input parameter "offset"'s semantic changed from in bytes from buffer to in elements from array view; calculate offset in bytes from buffer inside the function, avoiding overflow.
  • html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::slice): Changed according to new semantic of WebCore::WebGLArray::clampOffsetAndNumElements.
  • html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::slice): Ditto.
  • html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::slice): Ditto.
  • html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::slice): Ditto.
  • html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::slice): Ditto.
  • html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::slice): Ditto.
  • html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::slice): Ditto.
9:52 PM Changeset in webkit [57558] by darin@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-13 Darin Fisher <​darin@chromium.org>

Reviewed by Brady Eidson.

If the browsing context's session history contains only one Document,
and that was the about:blank Document created when the browsing context
was created, then the navigation must be done with replacement enabled.

​https://bugs.webkit.org/show_bug.cgi?id=37126

Tests: fast/loader/frame-location-change-not-added-to-history.html

fast/loader/frame-src-change-not-added-to-history.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::findFrameForNavigation):
  • loader/HistoryController.cpp: (WebCore::HistoryController::currentItemShouldBeReplaced):
  • loader/HistoryController.h:
9:29 PM Changeset in webkit [57557] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing a constant in the Rietveld unit test.

  • Scripts/webkitpy/common/net/rietveld_unittest.py
9:12 PM Changeset in webkit [57556] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding missing Mock to fix python tests.

  • Scripts/webkitpy/tool/mocktool.py:
5:29 PM Changeset in webkit [57555] by ggaren@apple.com
  • 8 edits in trunk

Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
its own lifetime, so a DOMWrapperWorld's controller can throw away
its wrappers even before its refcount reaches 0.

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.base.exp:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::registerWorld):
(WebCore::DOMWrapperWorld::unregisterWorld):

  • bindings/js/DOMWrapperWorld.h: Factored out DOMWrapperWorld registration

and unregistration into helper functions, so unregistering could be done manually.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::destroyWindowShell): Added an ASSERT to match
similar code.

WebKit/mac:

  • WebView/WebScriptWorld.h:
  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.

5:28 PM Changeset in webkit [57554] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update the test results after r57544.

  • http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt:
5:25 PM Changeset in webkit [57553] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/js/kde/string-1-n.html,
See ​https://bugs.webkit.org/show_bug.cgi?id=37532

Skipping fast/js/kde/string-2-n.html.
​https://bugs.webkit.org/show_bug.cgi?id=37534

Skipping inspector/console-format.html
​https://bugs.webkit.org/show_bug.cgi?id=37535

Skipping media/video-reverse-play-duration.html
​https://bugs.webkit.org/show_bug.cgi?id=37536

Skipping plugins/round-trip-npobject.html
​https://bugs.webkit.org/show_bug.cgi?id=37537

Skipping svg/custom/use-on-clip-path-with-transformation.svg
​https://bugs.webkit.org/show_bug.cgi?id=37539

Skipping http/tests/security/xss-DENIED-mime-type-execute-as-html.html
​https://bugs.webkit.org/show_bug.cgi?id=37540

  • platform/gtk/Skipped:
5:23 PM Changeset in webkit [57552] by ojan@chromium.org
  • 11 edits
    1 copy
    2 adds in trunk/WebKitTools

2010-04-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

Add experimental prototype Rietveld integration to webkit-patch upload
​https://bugs.webkit.org/show_bug.cgi?id=37418

This patch adds bare-bones integrtion with Rietveld for code reviews.
The behavior is hidden behind the --fancy-review command line flag.
Currently, there's no support for uploading more than one patch per
issue (which is a nice feature of Rietveld). The plan is to play with
this for a bit and see if it's useful.

Modified from Adam's original patch to autoinstall the rietveld upload script.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/rietveld.py: Added.
  • Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py: Added.
  • Scripts/webkitpy/tool/steps/postdiff.py:
5:22 PM Changeset in webkit [57551] by weinig@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add Makefile to MiniBrowser.

Rubber-stamped by Mark Rowe.

  • MiniBrowser/Makefile: Added.
4:54 PM Changeset in webkit [57550] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding a sanity check.

Add check to make sure commit-queue can never commit too short a message
​https://bugs.webkit.org/show_bug.cgi?id=37528

The commit-queue made bogus messages here:
​http://trac.webkit.org/changeset/57532
​http://trac.webkit.org/changeset/57534

This was a regression caused by adding unicode parsing for
our ChangeLog files. Popen does not seem to play nice with
unicode strings.

I'm also adding an "assert" to make sure short ChangeLogs never happen again.

  • Scripts/webkitpy/common/system/executive.py:
    • Cast input to strings before passing to POpen
  • Scripts/webkitpy/tool/steps/commit.py:
    • Validate that commit messages are not to short.
4:51 PM Changeset in webkit [57549] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Fix reported leaks when quitting MiniBrowser with open pages.

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.h: Make close() public.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::didClose): If the UIProcess disappears, close
the live pages in an effort to not leak.

  • WebProcess/WebProcess.h:
4:30 PM Changeset in webkit [57548] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Do a JS collection and clear the memory cache to improve leaks output
when exiting. Only do this in debug builds as it is slow.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shutdown):
(WebKit::WebProcess::didClose):

4:29 PM April 2010 Meeting edited by yuzo@google.com
(diff)
4:22 PM Changeset in webkit [57547] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Post a null event after calling [NSApp stop] to flush the run loop
and finish teardown.

Reviewed by Adele Peterson.

  • Platform/mac/RunLoopMac.mm:

(RunLoop::stop):

4:20 PM CommitterTips edited by yuzo@google.com
(diff)
4:19 PM Changeset in webkit [57546] by Adam Roben
  • 2 edits in trunk/WebKitTools

Robustify new-run-webkit-tests against paths with spaces in them

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:

(LayoutTestApacheHttpd.init): Quote all paths that we pass to
Apache to ensure that paths with spaces in them are interpreted
correctly.

4:04 PM Changeset in webkit [57545] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix, update platform specific expected file after r57534.

  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
3:58 PM Changeset in webkit [57544] by chang.shu@nokia.com
  • 5 edits
    2 adds in trunk

2010-04-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=34653

Based on W3C spec and Firefox behavior, while invoking XHR Send with parameter
as String, the charset in Content-Type should be forced to set to UTF-8.

Test: http/tests/xmlhttprequest/request-encoding2.html

  • platform/network/HTTPParsers.cpp: (WebCore::extractCharsetFromMediaType): (WebCore::findCharsetInMediaType):
  • platform/network/HTTPParsers.h:
  • xml/XMLHttpRequest.cpp: (WebCore::setCharsetInMediaType): (WebCore::XMLHttpRequest::send):

2010-04-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Fisher.

Added test for forcing UTF-8 charset.
​https://bugs.webkit.org/show_bug.cgi?id=34653

  • http/tests/xmlhttprequest/request-encoding2-expected.txt: Added.
  • http/tests/xmlhttprequest/request-encoding2.html: Added.
3:55 PM Changeset in webkit [57543] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping more new tests, we still do not have results. Remove test
that does not exist anymore:
svg/custom/clip-path-display-none-child.svg

  • platform/gtk/Skipped:
3:50 PM Changeset in webkit [57542] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed buildfix after r57537.

  • DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3:44 PM Changeset in webkit [57541] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/history/multiple-classes-visited.html test,
See ​https://bugs.webkit.org/show_bug.cgi?id=37526

  • platform/gtk/Skipped:
3:43 PM Changeset in webkit [57540] by weinig@apple.com
  • 3 edits
    1 copy in trunk/WebKitTools

Make building new webkit API and MiniBrowser a little easier.

Reviewed by Maciej Stachowiak.

  • Scripts/build-webkit: Make building with --webkit2 build the

MiniBrowser as well and tell you how to use it.

  • Scripts/run-minibrowser: Copied from Scripts/run-safari.
  • Scripts/webkitdirs.pm: Add runMiniBrowser function.
3:34 PM Changeset in webkit [57539] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57530, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()

  • platform/qt/Skipped:
    • storage/statement-error-callback-isolated-world.html skipped.
    • storage/statement-success-callback-isolated-world.html skipped.
    • storage/transaction-callback-isolated-world.html skipped.
    • storage/transaction-error-callback-isolated-world.html skipped.
3:31 PM Changeset in webkit [57538] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping new tests, we still do not have results.

  • platform/gtk/Skipped:
3:23 PM Changeset in webkit [57537] by timothy@apple.com
  • 24 edits
    2 adds in trunk

SecurityOrigin needs a way to remove individual OriginAccessEntries
​https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

Test: http/tests/xmlhttprequest/origin-whitelisting-removal.html

  • WebCore.base.exp: Added SecurityOrigin::removeOriginAccessWhitelistEntry.
  • page/OriginAccessEntry.h:

(WebCore::OriginAccessEntry::protocol): Added. Returns m_protocol.
(WebCore::OriginAccessEntry::host): Added. Returns m_host.
(WebCore::OriginAccessEntry::subdomainSettings): Added. Returns m_subdomainSettings.
(WebCore::operator==): Added. Compares OriginAccessEntry.
(WebCore::operator!=): Ditto.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): Use the add method to prevent a
second hash lookup.
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry): Added. Find a matching
OriginAccessEntry and remove it.

  • page/SecurityOrigin.h: Added removeOriginAccessWhitelistEntry.

WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
Call SecurityOrigin::removeOriginAccessWhitelistEntry.

  • WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.

  • WebView.h: Added removeOriginAccessWhitelistEntry.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
(LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

LayoutTests:

  • http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Added.
  • http/tests/xmlhttprequest/origin-whitelisting-removal.html: Added.
  • platform/gtk/Skipped: Added origin-whitelisting-removal.html.
  • platform/qt/Skipped: Ditto.
3:23 PM Changeset in webkit [57536] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Make Joseph Pecoraro a reviewer.

3:15 PM Changeset in webkit [57535] by timothy@apple.com
  • 40 edits in trunk

Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.

SecurityOrigin needs a way to remove individual OriginAccessEntries
​https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

  • WebCore.base.exp:
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::resetOriginAccessWhitelists):

  • page/SecurityOrigin.h:

WebKit/chromium:

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
(WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(webkit_white_list_access_from_origin):
(webkit_reset_origin_access_white_lists):

WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):

  • WebView/WebViewPrivate.h:

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::addOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):

  • WebView.h:

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(addOriginAccessWhitelistEntryCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

LayoutTests:

  • http/tests/security/local-image-from-remote-whitelisted-expected.txt:
  • http/tests/security/local-image-from-remote-whitelisted.html:
  • http/tests/xmlhttprequest/origin-whitelisting-all.html:
  • http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
  • http/tests/xmlhttprequest/origin-whitelisting-https.html:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
  • http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:
3:01 PM Changeset in webkit [57534] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2

2:59 PM Changeset in webkit [57533] by ggaren@apple.com
  • 6 edits in trunk/WebCore

Tidied up some more DOMWrapperWorld lifetime issues.

Reviewed by Mark Rowe.

Made DOMWrapperWorld aware of its JSDOMWindowShells, so it can clear them.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::didCreateWindowShell):
(WebCore::DOMWrapperWorld::didDestroyWindowShell): Functionality for
tracking window shells that reference a given DOMWrapperWorld.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):

  • bindings/js/ScriptController.h: Refactored to update a DOMWrapperWorld

when adding or removing a JSDOMWindowShell.

  • dom/Document.cpp:

(WebCore::Document::destroyAllWrapperCaches): Changed to use isEmpty(),
which is slightly faster and simpler than iterator comparison.

2:51 PM Changeset in webkit [57532] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2

2:28 PM Changeset in webkit [57531] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

the commit-queue hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37511

We were failing to read reviewers out of ChangeLogs
when the reviewer has unicode characters in his/her name.
I fixed this by explicitly decoding from utf8 every time we
read in a ChangeLog file (they are always UTF8).

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
2:19 PM Changeset in webkit [57530] by dumi@chromium.org
  • 26 edits
    8 adds in trunk

WebCore: Make all HTML5 DB callbacks run in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=27698

Reviewed by Adam Barth.

Tests: storage/statement-error-callback-isolated-world.html

storage/statement-success-callback-isolated-world.html
storage/transaction-callback-isolated-world.html
storage/transaction-error-callback-isolated-world.html

  • bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:

(WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
(WebCore::V8CustomSQLStatementCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementCallback.h:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:

(WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
(WebCore::V8CustomSQLTransactionCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLTransactionCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:

(WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:

(WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):

LayoutTests: Test that the HTML5 DB callbacks run in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=27698

Reviewed by Adam Barth.

  • storage/statement-error-callback-isolated-world-expected.txt: Added.
  • storage/statement-error-callback-isolated-world.html: Added.
  • storage/statement-success-callback-isolated-world-expected.txt: Added.
  • storage/statement-success-callback-isolated-world.html: Added.
  • storage/transaction-callback-isolated-world-expected.txt: Added.
  • storage/transaction-callback-isolated-world.html: Added.
  • storage/transaction-error-callback-isolated-world-expected.txt: Added.
  • storage/transaction-error-callback-isolated-world.html: Added.
1:14 PM BuildingQtOnLinux edited by robert@roberthogan.net
(diff)
1:13 PM BuildingQtOnLinux edited by robert@roberthogan.net
(diff)
12:14 PM Changeset in webkit [57529] by eric@webkit.org
  • 4 edits in trunk

2010-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix search behavior in Profiles tab.

​https://bugs.webkit.org/show_bug.cgi?id=37498

2010-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix search behavior in Heap profiles.

​https://bugs.webkit.org/show_bug.cgi?id=37498

  • src/js/HeapProfilerPanel.js:
11:58 AM Changeset in webkit [57528] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37513, clean up StyleBoxData and the RenderStyle variable that uses it.

Reviewed by Oliver Hunt.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::width):
(WebCore::InheritedFlags::height):
(WebCore::InheritedFlags::minWidth):
(WebCore::InheritedFlags::maxWidth):
(WebCore::InheritedFlags::minHeight):
(WebCore::InheritedFlags::maxHeight):
(WebCore::InheritedFlags::verticalAlignLength):
(WebCore::InheritedFlags::boxSizing):
(WebCore::InheritedFlags::setWidth):
(WebCore::InheritedFlags::setHeight):
(WebCore::InheritedFlags::setMinWidth):
(WebCore::InheritedFlags::setMaxWidth):
(WebCore::InheritedFlags::setMinHeight):
(WebCore::InheritedFlags::setMaxHeight):
(WebCore::InheritedFlags::setVerticalAlignLength):
(WebCore::InheritedFlags::hasAutoZIndex):
(WebCore::InheritedFlags::setHasAutoZIndex):
(WebCore::InheritedFlags::zIndex):
(WebCore::InheritedFlags::setZIndex):
(WebCore::InheritedFlags::setBoxSizing):

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
(WebCore::StyleBoxData::zIndex):
(WebCore::StyleBoxData::hasAutoZIndex):
(WebCore::StyleBoxData::boxSizing):

11:28 AM WikiStart edited by ddkilzer@webkit.org
(diff)
11:17 AM Changeset in webkit [57527] by yael.aharon@nokia.com
  • 4 edits in trunk/WebCore

Minor fix to pass RenderProgress instead of RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=37481

Reviewed by Tor Arne Vestbo.

  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityProgressIndicator.cpp:
  • accessibility/AccessibilityProgressIndicator.h:
11:10 AM Changeset in webkit [57526] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37510, clean up StyleBackgroundData

Reviewed by Oliver Hunt.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::hasBackground):
(WebCore::InheritedFlags::hasBackgroundImage):
(WebCore::InheritedFlags::hasFixedBackgroundImage):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyle):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::accessBackgroundLayers):
(WebCore::InheritedFlags::backgroundLayers):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::resetOutline):
(WebCore::InheritedFlags::setBackgroundColor):
(WebCore::InheritedFlags::setBackgroundXPosition):
(WebCore::InheritedFlags::setBackgroundYPosition):
(WebCore::InheritedFlags::setBackgroundSize):
(WebCore::InheritedFlags::setBackgroundSizeLength):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::clearBackgroundLayers):
(WebCore::InheritedFlags::inheritBackgroundLayers):
(WebCore::InheritedFlags::setOutlineOffset):

  • rendering/style/StyleBackgroundData.h:

(WebCore::StyleBackgroundData::background):
(WebCore::StyleBackgroundData::color):
(WebCore::StyleBackgroundData::outline):

11:04 AM Changeset in webkit [57525] by Adam Roben
  • 2 edits in trunk/WebKitTools

Revert r57523

11:00 AM Changeset in webkit [57524] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests on Windows with spaces in the path

Fixes <​http://webkit.org/b/37509>.

Reviewed by Steve Falkenburg.

  • Scripts/run-webkit-tests:

(convertPathUsingCygpath): Remove spaces from the path before passing
them to cygpath, then add them back in after conversion, as some
versions of cygpath seem to convert spaces into newlines.

10:59 AM Changeset in webkit [57523] by Adam Roben
  • 2 edits in trunk/WebKitTools

Revert "run-webkit-tests should respect argument order"

This reverts commit adc7db320e18d5a866dbf63a2ed7192471c86c85.

10:46 AM Changeset in webkit [57522] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use the system clipboard instead of a private clipboard.

Fix various problems in the previous implementation.

​https://bugs.webkit.org/show_bug.cgi?id=37421

No new tests needed.

  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::generalPasteboard):
    • Don't leak the pasteboard at program exit.

(WebCore::AutoClipboardLocker::AutoClipboardLocker):
(WebCore::AutoClipboardLocker::~AutoClipboardLocker):
(WebCore::AutoClipboardLocker::isLocked):

  • helper class for locking a BClipboard.

(WebCore::Pasteboard::writeSelection):

  • Use AddData(B_MIME_TYPE) as required by clipboard protocol.
  • Make sure we don't end up with unwanted UTF-8 characters for regular line breaks.

(WebCore::Pasteboard::writePlainText):

  • Use AddData(B_MIME_TYPE) as required by clipboard protocol.

(WebCore::Pasteboard::plainText):

  • Use FindData(B_MIME_TYPE) as required by clipboard protocol.

(WebCore::Pasteboard::documentFragment):

  • Implemented.

(WebCore::Pasteboard::writeURL):

  • Needs to use AddData(B_MIME_TYPE) instead of AddString().

(WebCore::Pasteboard::clear):

10:20 AM Changeset in webkit [57521] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Fix bridging Widget to native top-level BView.
​https://bugs.webkit.org/show_bug.cgi?id=37419

In the Haiku port, there is no mapping between native widgets
and WebCore Widget instances. There is only a top-level BView
which renders a web page into a bitmap. For certain WebCore widget
functionality, we need to access this BView, like for setting the
current cursor or forcing focus. On the other hand, setting a
platform widget pointer on Widget results into completely different
behavior, like ScrollView tries to forward everything instead of
handling stuff itself. To make this work, the pointer to a "top-level"
BView is stored in every Widget for the Haiku port.

No new tests needed.

  • platform/Widget.h:
    • Added the m_topLevelPlatformWidget member for the Haiku platform.

(WebCore::Widget::setPlatformWidget):
(WebCore::Widget::topLevelPlatformWidget):
(WebCore::Widget::setTopLevelPlatformWidget):

  • platform/haiku/WidgetHaiku.cpp: (WebCore::AutoPlatformWidgetLocker::AutoPlatformWidgetLocker): (WebCore::AutoPlatformWidgetLocker::~AutoPlatformWidgetLocker): (WebCore::AutoPlatformWidgetLocker::isLocked):
    • helper class for locking the BView looper thread with a timeout

(WebCore::Widget::Widget):
(WebCore::Widget::setFocus):

  • Make sure the top-level view receives keyboard input.

(WebCore::Widget::setCursor):

  • Set the cursor on the top-level view.

(WebCore::Widget::show):
(WebCore::Widget::hide):

  • Don't show/hide the top-level view, but make the code correct for whenever we would map an individual BView per Widget.
  • Use setSelfVisible() and isParentVisible() like in other ports.
10:08 AM Changeset in webkit [57520] by eric@webkit.org
  • 4 edits in trunk

2010-04-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Levin.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

No new tests as there is no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.

2010-04-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Levin.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

  • src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
9:49 AM Changeset in webkit [57519] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add a null ptr check for m_popupClient.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::abandon): Add a null ptr check
9:42 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:56 AM Changeset in webkit [57518] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-04-13 William Siegrist <​wsiegrist@apple.com>

Add a temporary bot to test new-run-webkit-tests

8:52 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:51 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:45 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:44 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:41 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:41 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:38 AM Mobile Features Talk created by treat@kde.org
8:36 AM April 2010 Meeting edited by treat@kde.org
(diff)
8:31 AM Changeset in webkit [57517] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use the system's default font family as last fall back font.
​https://bugs.webkit.org/show_bug.cgi?id=37501

No new tests needed.

  • platform/graphics/haiku/FontCacheHaiku.cpp: (WebCore::FontCache::getLastResortFallbackFont):
    • Use the system's default font family (from be_plain_font global).
8:21 AM Changeset in webkit [57516] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Eskil Blomfeldt <​eblomfel@trolltech.com>, Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Use integer pixel metric QFont API to fix rounding errors in text rendering on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=36532

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::floatWidthForComplexText): (WebCore::Font::font):
8:11 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:54 AM Changeset in webkit [57515] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix, platform specific expected file updated after r57511.

  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: updated.
7:50 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:36 AM Changeset in webkit [57514] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cannot effectively delete properties in the Styles sidebar pane
​https://bugs.webkit.org/show_bug.cgi?id=37499

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):
7:17 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:45 AM Changeset in webkit [57513] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

Use the Haiku MIME type data base as a fall back for unknown file extensions.
​https://bugs.webkit.org/show_bug.cgi?id=34686

Covered by existing tests.

  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::):
    • fixed coding style issues

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):

  • fall back to the system MIME database for unknown types.
  • return empty String as last resort, this is used elsewhere as indicator for unknown types.
6:36 AM Changeset in webkit [57512] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use all the new system cursors available in recent Haiku revisions.
<​https://bugs.webkit.org/show_bug.cgi?id=37385>

Covered by existing tests.

  • platform/haiku/CursorHaiku.cpp: (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=):
    • Adapted to maintain an owned BCursor instance.

(WebCore::createCursorByID):

  • helper function to create a Cursor instance by BCursorID constant.

(WebCore::pointerCursor):

  • NULL BCursor triggers using the system cursor.

(WebCore::moveCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):

  • Use the new system cursors.
5:45 AM Changeset in webkit [57511] by krit@webkit.org
  • 28 edits
    130 adds
    1 delete in trunk

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

<clipPath> doesn't correctly handle <text> elements
​https://bugs.webkit.org/show_bug.cgi?id=12571

Adds support for text elements as clipPath, heterogenous clip rules, as well
as clipping of clipPath.
A fast code path let platforms clip simple shapes directly. All other variants
are drawn to a seperate ImageBuffer, which is used as a mask. This happens the same
way we like we do it on SVG Masking. This needs temporary changes to the RenderStyle
of clipPath childs. Values like stroke, resources, opacity have to be ignored.

Tests: svg/clip-path/clip-path-child-clipped.svg

svg/clip-path/clip-path-childs-clipped.svg
svg/clip-path/clip-path-clipped-evenodd-twice.svg
svg/clip-path/clip-path-clipped-no-content.svg
svg/clip-path/clip-path-clipped-nonzero.svg
svg/clip-path/clip-path-clipped.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-evenodd.svg
svg/clip-path/clip-path-nonzero-evenodd.svg
svg/clip-path/clip-path-nonzero.svg
svg/clip-path/clip-path-objectBoundingBox.svg
svg/clip-path/clip-path-on-clipped-use.svg
svg/clip-path/clip-path-on-g-and-child.svg
svg/clip-path/clip-path-on-g.svg
svg/clip-path/clip-path-on-svg-and-child.svg
svg/clip-path/clip-path-on-svg.svg
svg/clip-path/clip-path-recursive-call-by-child.svg
svg/clip-path/clip-path-recursive-call.svg
svg/clip-path/clip-path-text-and-shape.svg
svg/clip-path/clip-path-text-and-stroke.svg
svg/clip-path/clip-path-text.svg
svg/clip-path/clip-path-use-as-child.svg
svg/clip-path/clip-path-use-as-child2.svg
svg/clip-path/clip-path-use-as-child3.svg
svg/clip-path/clip-path-use-as-child4.svg
svg/clip-path/clip-path-use-as-child5.svg
svg/clip-path/clip-path-userSpaceOnUse.svg
svg/clip-path/clip-path-with-container.svg
svg/clip-path/clip-path-with-different-unittypes.svg
svg/clip-path/clip-path-with-different-unittypes2.svg
svg/clip-path/clip-path-with-invisibile-child.svg
svg/clip-path/clip-path-with-text-clipped.svg

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGShadowTreeRootContainer): identify use-element renderer
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::pathOnlyClipping): direct clipping for simple shapes (WebCore::RenderSVGResourceClipper::applyClippingToContext): direct clipping or maskImage? (WebCore::RenderSVGResourceClipper::createClipData): creates maskImage for clipping (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGShadowTreeRootContainer.h: identify use-Element by renderer (WebCore::RenderSVGShadowTreeRootContainer::isSVGShadowTreeRootContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): hack to get texts working on clipping (masks and pattern)
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::rendererClipChild): get renderer of referenced object
  • svg/SVGUseElement.h:

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

<clipPath> doesn't correctly handle <text> elements
​https://bugs.webkit.org/show_bug.cgi?id=12571

33 new Tests for SVG's clip-path. Test behavior of different clip objects
like text as well as different clip rules.
Other older tests are rendered correctly now.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.checksum:
  • platform/mac/svg/batik/text/textEffect2-expected.png:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.checksum:
  • platform/mac/svg/batik/text/textProperties-expected.png:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/clip-path: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.checksum:
  • svg/clip-path: Added.
  • svg/clip-path/clip-path-child-clipped.svg: Added.
  • svg/clip-path/clip-path-childs-clipped.svg: Added.
  • svg/clip-path/clip-path-clipped-evenodd-twice.svg: Added.
  • svg/clip-path/clip-path-clipped-no-content.svg: Added.
  • svg/clip-path/clip-path-clipped-nonzero.svg: Added.
  • svg/clip-path/clip-path-clipped.svg: Added.
  • svg/clip-path/clip-path-evenodd-nonzero.svg: Added.
  • svg/clip-path/clip-path-evenodd.svg: Added.
  • svg/clip-path/clip-path-nonzero-evenodd.svg: Added.
  • svg/clip-path/clip-path-nonzero.svg: Added.
  • svg/clip-path/clip-path-objectBoundingBox.svg: Added.
  • svg/clip-path/clip-path-on-clipped-use.svg: Added.
  • svg/clip-path/clip-path-on-g-and-child.svg: Added.
  • svg/clip-path/clip-path-on-g.svg: Added.
  • svg/clip-path/clip-path-on-svg-and-child.svg: Added.
  • svg/clip-path/clip-path-on-svg.svg: Added.
  • svg/clip-path/clip-path-recursive-call-by-child.svg: Added.
  • svg/clip-path/clip-path-recursive-call.svg: Added.
  • svg/clip-path/clip-path-text-and-shape.svg: Added.
  • svg/clip-path/clip-path-text-and-stroke.svg: Added.
  • svg/clip-path/clip-path-text.svg: Added.
  • svg/clip-path/clip-path-use-as-child.svg: Added.
  • svg/clip-path/clip-path-use-as-child2.svg: Added.
  • svg/clip-path/clip-path-use-as-child3.svg: Added.
  • svg/clip-path/clip-path-use-as-child4.svg: Added.
  • svg/clip-path/clip-path-use-as-child5.svg: Added.
  • svg/clip-path/clip-path-userSpaceOnUse.svg: Added.
  • svg/clip-path/clip-path-with-container.svg: Added.
  • svg/clip-path/clip-path-with-different-unittypes.svg: Added.
  • svg/clip-path/clip-path-with-different-unittypes2.svg: Added.
  • svg/clip-path/clip-path-with-invisibile-child.svg: Added.
  • svg/clip-path/clip-path-with-text-clipped.svg: Added.
  • svg/custom/clip-path-display-none-child.svg: Removed.
5:25 AM QtWebKitFeaturePlanning edited by Henry Haverinen
(diff)
4:39 AM Changeset in webkit [57510] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Checksum of svg/filters/filterRes.svg was not updated properly after rebasing.
It's only visible when using "run-webkit-tests --tolerance 0 -p svg"

  • platform/mac/svg/filters/filterRes-expected.checksum:
3:48 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
3:35 AM Changeset in webkit [57509] by Nikolas Zimmermann
  • 28 edits in trunk/WebCore

2010-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG renderers should track transform/path changes, instead of pulling every time from SVG DOM
​https://bugs.webkit.org/show_bug.cgi?id=15389

RenderPath caches repaint rectangles (fill/stroke bbox etc.) though this caching
was effectively useless because every layout() call caused them to be reset to empty rects.
Furthermore RenderPath::layout() queried the SVG DOM upon every invocation to retrieve
the Path object, instead of only doing it when necessary. Even the TransformationMatrix
was polled everytime from the SVG DOM.

Move the knownledge wheter we need to update path/transform into the render tree and
only update when necessary. This should result in a huge performance increase, with
the drawback of adding slightly more memory, because we need to add booleans indicating
the status of path/transform (is dirty?).

Doesn't affect any tests, only performance.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::layout):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::setNeedsTransformUpdate):
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsTransformUpdate): (WebCore::RenderObject::setNeedsBoundariesUpdate):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::layout): (WebCore::RenderPath::invalidateCachedBoundaries): (WebCore::RenderPath::styleWillChange):
  • rendering/RenderPath.h: (WebCore::RenderPath::setNeedsBoundariesUpdate): (WebCore::RenderPath::setNeedsPathUpdate): (WebCore::RenderPath::setNeedsTransformUpdate): (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::setNeedsTransformUpdate):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients):
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::invalidateClients):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::setNeedsTransformUpdate):
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::setNeedsTransformUpdate): (WebCore::RenderSVGTransformableContainer::localTransform):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::svgAttributeChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
2:34 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:49 AM Changeset in webkit [57508] by mnaganov@chromium.org
  • 4 edits in trunk

Unreviewed build fixes for Qt and Chromium ports.

Unreviewed Qt build fix: add new .idl files to WebCore.pri

  • WebCore.pri:

Unreviewed Chromium build fix: pin to a newer V8 revision (4386).

  • DEPS:
12:48 AM Changeset in webkit [57507] by abarth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-13 Adam Barth <​abarth@webkit.org>

Unreviewed, but approved by Dumitru Daniliuc. (This patch is intended
to fix the downstream Chromium build bots. Hopefully it will work!)

Add a driver script for the new websocket server
​https://bugs.webkit.org/show_bug.cgi?id=37495

websocket_server.py can't be run directly because its a module and not
a standalone script. This used to work by accident because it didn't
depend on any other modules.

  • Scripts/new-run-webkit-websocketserver: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
12:38 AM Changeset in webkit [57506] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, adding another fast/url/ test to Chromium's
test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:22 AM Changeset in webkit [57505] by mnaganov@chromium.org
  • 23 edits
    7 copies
    2 moves
    1 add
    2 deletes in trunk

2010-04-12 Mikhail Naganov <​mnaganov@chromium.org>

Replace hand-written JavaScriptProfile* bindings with idl-based, and
in Chromium port, bind them to the new V8's profiler API that is
aligned with JSC.

​https://bugs.webkit.org/show_bug.cgi?id=37448

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSScriptProfileNodeCustom.cpp: Added. (WebCore::JSScriptProfileNode::callUID): (WebCore::JSScriptProfileNode::children):
  • bindings/js/JavaScriptProfile.cpp: Removed.
  • bindings/js/JavaScriptProfile.h: Removed.
  • bindings/js/JavaScriptProfileNode.cpp: Removed.
  • bindings/js/JavaScriptProfileNode.h: Removed.
  • bindings/js/ScriptProfileNode.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.cpp: Added. (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::head):
  • bindings/v8/ScriptProfile.h: (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfileNode.cpp: Added. (WebCore::ScriptProfileNode::functionName): (WebCore::ScriptProfileNode::url): (WebCore::ScriptProfileNode::lineNumber): (WebCore::ScriptProfileNode::totalTime): (WebCore::ScriptProfileNode::selfTime): (WebCore::ScriptProfileNode::numberOfCalls): (WebCore::ScriptProfileNode::children): (WebCore::ScriptProfileNode::visible): (WebCore::ScriptProfileNode::callUID):
  • bindings/v8/ScriptProfileNode.h: Added. (WebCore::ScriptProfileNode::create): (WebCore::ScriptProfileNode::~ScriptProfileNode): (WebCore::ScriptProfileNode::ScriptProfileNode):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::V8Console::profilesAccessorGetter):
  • bindings/v8/custom/V8ScriptProfileCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Added. (WebCore::V8ScriptProfileNode::childrenAccessorGetter): (WebCore::V8ScriptProfileNode::callUIDAccessorGetter): (WebCore::toV8):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
  • inspector/ScriptProfile.idl: Added.
  • inspector/ScriptProfileNode.idl: Added.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
  • page/Console.idl:
  • platform/android/TemporaryLinkStubs.cpp:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):
  • src/js/Tests.js:
12:01 AM Changeset in webkit [57504] by dbates@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-13 Daniel Bates <​dbates@rim.com>

Unreviewed, fix bug url mentioned in the change log
for change set 57502 <​http://trac.webkit.org/changeset/57502>.

Inadvertently listed the bug url to be <​https://bugs.webkit.org/show_bug.cgi?id=37480>.
Instead, it should be <​https://bugs.webkit.org/show_bug.cgi?id=37490>.

Apr 12, 2010:

11:42 PM Changeset in webkit [57503] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Finish IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37493

I rushed the first version of this test because I wanted to get the
framework in the tree for other folks to work on the other tests. The
expected.txt file matches KURL but the PASS/FAIL indiciations match
GURL.

  • fast/url/ipv4-expected.txt:
  • fast/url/script-tests/ipv4.js:
11:09 PM Changeset in webkit [57502] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements the anchor tests from <​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.

  • fast/url/anchor-expected.txt: Added.
  • fast/url/anchor.html: Added.
  • fast/url/script-tests/anchor.js: Added.
9:52 PM Changeset in webkit [57501] by eric@webkit.org
  • 4 edits
    1 copy
    4 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements all of the non-encoding specific query string tests from
<​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.

Also, moved JavaScript function canonicalize to external JavaScript
script /resources/utilities.js since this function is being called
by tests ipv4.html, query.html, and trivial.html.

  • fast/url/ipv4.html:
  • fast/url/query-expected.txt: Added.
  • fast/url/query.html: Added.
  • fast/url/resources: Added.
  • fast/url/resources/utilities.js: Added. (canonicalize):
  • fast/url/script-tests/TEMPLATE.html: Include external JavaScript script resources/utilities.js.
  • fast/url/script-tests/query.js: Added.
  • fast/url/trivial.html:
9:38 PM Changeset in webkit [57500] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make new-run-webkit-test PrettyPatch failure reporting more awesome
​https://bugs.webkit.org/show_bug.cgi?id=37487

I also fixed an Executive/executive typo.

  • Scripts/webkitpy/layout_tests/port/base.py:
9:00 PM Changeset in webkit [57499] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should only build java support files on Mac
​https://bugs.webkit.org/show_bug.cgi?id=37482

Only the mac needs java support files, so I pushed _build_java
down into the Mac port using a new hook "_check_port_build".
In the process I noticed a bunch of code which could be shared
between all ports and thus got rid of _tests_for_disabled_features
and version() copy/paste between all webkit ports.
I also made check_build only bother to check for ImageDiff if we're
using pixel tests.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
8:00 PM Changeset in webkit [57498] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping two tests on Chromium because they fail.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [57497] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, trying to make scripts work on machines without
Ruby...

  • Scripts/webkitpy/layout_tests/port/base.py:
7:29 PM Changeset in webkit [57496] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
​https://bugs.webkit.org/show_bug.cgi?id=37461

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
the node is currently offscreen in an scroll overflowed content.

Test: fast/events/spatial-navigation/snav-simple-content-overflow.html

  • page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):

LayoutTests:

  • fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
  • fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.
7:28 PM Changeset in webkit [57495] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed style fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

7:13 PM Changeset in webkit [57494] by yael.aharon@nokia.com
  • 10 edits
    4 adds in trunk

Accessibility support for progress element
​https://bugs.webkit.org/show_bug.cgi?id=37275

Reviewed by Darin Adler.

WebCore:

Implement AccessibilityProgressIndicator to hook up progress element to accessibility framework.

Test: platform/mac/accessibility/progressbar.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityProgressIndicator.cpp: Added.
  • accessibility/AccessibilityProgressIndicator.h: Added.
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:

LayoutTests:

  • platform/mac/accessibility/progressbar-expected.txt: Added.
  • platform/mac/accessibility/progressbar.html: Added.
7:07 PM Changeset in webkit [57493] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test that started failing with r57492.

  • storage/open-database-over-quota.html:
6:04 PM Changeset in webkit [57492] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
​https://bugs.webkit.org/show_bug.cgi?id=33916

Reviewed by Dimitri Glazkov.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

5:59 PM Changeset in webkit [57491] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • platform/qt/test_expectations.txt: Added.

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/qt.py: Added.
5:47 PM Changeset in webkit [57490] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

WebKit should have more robust last-chance font fallback on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37473
<rdar://problem/7789438> Crash in FontFallbackList::determinePitch
<rdar://problem/7233762> Crash in FontFallbackList::fontDataAt


Look harder for a suitable last-resort font. Previously, we checked for
"Times New Roman" followed by DEFAULT_GUI_FONT.


We now look for:

  • Typically installed Unicode-capable fonts, in order of coverage
  • DEFAULT_GUI_FONT
  • SPI_GETNONCLIENTMETRICS fonts


  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
5:11 PM Changeset in webkit [57489] by abarth@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add some ip4v tests (will revise in a minute)
​https://bugs.webkit.org/show_bug.cgi?id=37476

  • fast/url/ipv4-expected.txt: Added.
  • fast/url/ipv4.html: Added.
  • fast/url/script-tests/ipv4.js: Added.
  • fast/url/script-tests/trivial.js: (canonicalize):
  • fast/url/trivial-expected.txt:
4:42 PM Changeset in webkit [57488] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add a trivial test for URL parsing
​https://bugs.webkit.org/show_bug.cgi?id=37475

Hopefully this will be the starting point for many URL tests.

  • fast/url/script-tests/TEMPLATE.html: Added.
  • fast/url/script-tests/trivial.js: Added. (canonicalize):
  • fast/url/trivial-expected.txt: Added.
  • fast/url/trivial.html: Added.
4:20 PM Changeset in webkit [57487] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add #ifdef so that WKView is not included on the mac if not
compiling objective-c.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WebKit2.h:
4:15 PM Changeset in webkit [57486] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Modify run_webkit_tests.py to not call sys.exit() at the end of test
run; doing so makes it more difficult to embed the routine for,
among other things, unit tests. We push the exit calling up into
new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=37464

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:10 PM Changeset in webkit [57485] by andersca@apple.com
  • 1 edit
    1 add in trunk/WebKit2

Add WebKit2 solution file.

Reviewed by Adam Roben.

  • WebKit2.sln: Added.
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
3:14 PM Changeset in webkit [57484] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/style/RenderStyle.cpp

Fix debug build bustage.

3:10 PM ReviewTool edited by maruel@chromium.org
(diff)
2:55 PM Changeset in webkit [57483] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • platform/gtk/test_expectations.txt: Copied from LayoutTests/animations/resources/dynamic-stylesheet-insertion-inserted.css.

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py: Added.
2:53 PM Changeset in webkit [57482] by hyatt@apple.com
  • 18 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37469, clean up ShadowData to be encapsulated properly.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForShadow):

  • page/animation/AnimationBase.cpp:

(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperShadow::blend):

  • page/mac/FrameMac.mm:

(WebCore::Frame::fontAttributesForSelectionStart):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustRectForOutlineAndShadow):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintCharacters):

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
(WebCore::RenderStyle::getBoxShadowExtent):
(WebCore::RenderStyle::getBoxShadowHorizontalExtent):
(WebCore::RenderStyle::getBoxShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::boxShadow):

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::~ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::blur):
(WebCore::ShadowData::spread):
(WebCore::ShadowData::style):
(WebCore::ShadowData::color):
(WebCore::ShadowData::next):
(WebCore::ShadowData::setNext):

2:53 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
2:50 PM ReviewTool edited by maruel@chromium.org
(diff)
2:48 PM ReviewTool created by maruel@chromium.org
1:51 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:49 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:48 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:47 PM Changeset in webkit [57481] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] LayoutTests/platform/gtk/Skipped clean up
​https://bugs.webkit.org/show_bug.cgi?id=37465

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • platform/gtk/Skipped: Clean up needed after r57289 and r57292.
1:47 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:45 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:42 PM Changeset in webkit [57480] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-04-12 William Siegrist <​wsiegrist@apple.com>

Add new Qt bots for Windows release, Windows debug, Linux release minimal, Linux armv5 release, and Linux armv7 release.

1:41 PM Accelerated Compositing created by Simon Fraser
1:40 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:39 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:37 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:29 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:28 PM Transforms-Transitions-Animations created by Simon Fraser
1:26 PM Changeset in webkit [57479] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37463, clean up NinePieceImage.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::slices):
(WebCore::NinePieceImage::setSlices):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):

12:28 PM Changeset in webkit [57478] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping a new test on Chromium, because the test is
using an API that is not yet implemented in Chromium.

  • platform/chromium/test_expectations.txt:
12:23 PM Changeset in webkit [57477] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57476, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped: fast/history/multiple-classes-visited.html skipped.
11:42 AM Changeset in webkit [57476] by hyatt@apple.com
  • 4 edits
    2 adds
    1 delete in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.

Reviewed by Sam Weinig.

WebCore:

Added fast/history/multiple-classes-visited.html.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):

LayoutTests:

  • fast/history/multiple-classes-visited-expected.txt: Added.
  • fast/history/multiple-classes-visited.html: Added.
11:31 AM April 2010 Meeting edited by evan@chromium.org
add my name, alphabetize (diff)
11:03 AM Changeset in webkit [57475] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails with exception on systems missing ruby
​https://bugs.webkit.org/show_bug.cgi?id=37441

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Catch failures similar to how wdiff code path does.
    • After one failure, stop trying.
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:20 AM April 2010 Meeting edited by Simon Fraser
(diff)
10:02 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:59 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:58 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:56 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:46 AM Changeset in webkit [57474] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-04-12 Dirk Schulze <​krit@webkit.org>

Unreviewed build fix.

Make comma/whitespace around arc flags optional in SVG path syntax
​https://bugs.webkit.org/show_bug.cgi?id=37431

Fix the SL build.

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag):
9:42 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:41 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:39 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:28 AM April 2010 Meeting edited by ddkilzer@webkit.org
(diff)
8:49 AM Changeset in webkit [57473] by eric@webkit.org
  • 6 edits in trunk

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Add tests to handle that comma/whitespace around arc flags are optional
and that arc flags can only be 0 or 1 in SVG path syntax:
​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/dom/fuzz-path-parser-expected.txt: One test now fails due to flags not 0 or 1
  • svg/dom/path-parser-expected.txt: Add test results for missing whitespace and flags not 0 or 1
  • svg/dom/script-tests/path-parser.js: Add 6 tests to check that whitespace is optional after flags and flags must be 0 or 1

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Make comma/whitespace around arc flags optional in SVG path syntax and ensure flags are
either 0 or 1: ​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): function to read in a 0 or 1 for largeArcFlag and sweepFlag (WebCore::SVGPathParser::parseSVG): modify/simplify arc parsing by using parseArcFlag()
8:24 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:23 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:12 AM April 2010 Meeting edited by Simon Hausmann
(diff)
8:09 AM April 2010 Meeting edited by adam.bergkvist@ericsson.com
(diff)
8:07 AM April 2010 Meeting edited by pmuellr@yahoo.com
(diff)
7:58 AM April 2010 Meeting edited by darin@chromium.org
(diff)
7:57 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:47 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:37 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:35 AM April 2010 Meeting edited by Simon Hausmann
(diff)
6:47 AM QtWebKitBackportingFixes edited by joseph.ligman@nokia.com
(diff)
3:59 AM Changeset in webkit [57472] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for Mac when building with build-webkit --qt

Reviewed by nobody, build fix.

Specifying no configuration on Mac builds WebCore both in debug
and release. JavaScriptCore has to follow this rule as well.

3:52 AM BuildingQtOnLinux edited by nicholas@nicholaswilson.me.uk
added dependency on fontconfig (diff)
2:20 AM Changeset in webkit [57471] by aestes@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Inserting my name in the correct location.

1:03 AM Changeset in webkit [57470] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Fix how we import simplejson based on how it's used in this file.
This fixes exceptions raised when trying to write the simplejson output.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Apr 11, 2010:

11:53 PM April 2010 Meeting edited by xan@webkit.org
(diff)
11:19 PM April 2010 Meeting edited by levin@chromium.org
(diff)
11:11 PM April 2010 Meeting edited by levin@chromium.org
(diff)
10:47 PM April 2010 Meeting edited by levin@chromium.org
(diff)
10:41 PM April 2010 Meeting edited by mjs@apple.com
(diff)
9:54 PM Changeset in webkit [57469] by abarth@webkit.org
  • 41 edits
    2 deletes in trunk

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Removed.
  • loader/DocumentWriter.h: Removed.
  • loader/FrameLoader.cpp: (WebCore::canReferToParentFrameEncoding): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::replaceDocument): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
9:34 PM April 2010 Meeting edited by morrita@google.com
(diff)
9:20 PM Changeset in webkit [57468] by abarth@webkit.org
  • 41 edits
    2 adds in trunk

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Added.
  • loader/DocumentWriter.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
9:05 PM April 2010 Meeting edited by ben@webkit.org
(diff)
8:52 PM Changeset in webkit [57467] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style so that the StyleChecker class
has no dependencies on patch-related concepts.

​https://bugs.webkit.org/show_bug.cgi?id=37065

This patch is an intermediate step towards making the StyleChecker
class a generalized file processor that can do arbitary operations
on the files corresponding to a list of paths. This patch
also simplifies the unit-testing of patch-checking code.

  • Scripts/check-webkit-style:
    • Updated to use the new PatchChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Refactored the StyleChecker.check_patch() method into the check() method of a new PatchChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the unit tests as necessary, changing the StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
8:50 PM April 2010 Meeting edited by ben@webkit.org
(diff)
8:02 PM April 2010 Meeting edited by dimich@chromium.org
(diff)
7:56 PM April 2010 Meeting edited by morrita@google.com
(diff)
7:54 PM Changeset in webkit [57466] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Unreviewed.

Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
​https://bugs.webkit.org/show_bug.cgi?id=37430

We need some basic unit testing of this script, or we're going to keep
breaking it like this. Added missing namespace qualifiers and
propagated renaming of an option.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:47 PM Changeset in webkit [57465] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-04-11 Tony Chang <​tony@chromium.org>

Not reviewed, layout test fix for QT bots.

Update paste expected results on QT and skip a new d&d test.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Added.
7:21 PM Changeset in webkit [57464] by tony@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
​https://bugs.webkit.org/show_bug.cgi?id=37193

  • editing/pasteboard/onpaste-text-html-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html.html: Added.
  • fast/events/ondrop-text-html-expected.txt: Added.
  • fast/events/ondrop-text-html.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-04-07 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
​https://bugs.webkit.org/show_bug.cgi?id=37193

Tests: editing/pasteboard/onpaste-text-html.html

fast/events/ondrop-text-html.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): add html type (WebCore::ClipboardChromium::clearData): implement clear text/html (WebCore::ClipboardChromium::getData): implement get text/html (similar to text/plain) (WebCore::ClipboardChromium::setData): implement set text/html
7:16 PM Changeset in webkit [57463] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Break new-run-webkit-tests options into groups for easier re-use and possible relocation
​https://bugs.webkit.org/show_bug.cgi?id=37408

new-run-webkit-tests currently has one huge function for
dealing with all options-parsing.
This patch is a first attempt at trying to split that large
function down into smaller (hopefully more readable?) chunks
dealing with the different areas of options.
For example, it would make sense to move configuration
options off into some module which deals with the vagries of
WebKit's configuration system. It would also make sense to move
Chromium options off onto the Chromium port object (where they are used).
It may make sense to move results.json options over to the results.json code.
This change is a first iteration, and we will certainly need more
refinement to this code over time. Hopefully I didn't make things
harder to read here.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:07 PM April 2010 Meeting edited by ariya@webkit.org
add myself (diff)
6:58 PM Changeset in webkit [57462] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout copy needs to be updated to reflect removal of --no-build
​https://bugs.webkit.org/show_bug.cgi?id=37425

Removed --no-build and --no-test from the instructions because these
don't exist anymore.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
    • Updated the expected results to reflect the new copy.
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
6:04 PM Changeset in webkit [57461] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
​http://trac.webkit.org/changeset/57460
​https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DEPS:
  • gyp_webkit:

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
​http://trac.webkit.org/changeset/57460
​https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5:49 PM Changeset in webkit [57460] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS:
  • gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between WebKit.gyp and webkit.gyp.
4:57 PM April 2010 Meeting edited by tkent@chromium.org
(diff)
4:44 PM April 2010 Meeting edited by yutak@chromium.org
(diff)
4:22 PM April 2010 Meeting edited by tkent@chromium.org
Add tkent to attendees list (diff)
4:08 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
4:05 PM April 2010 Meeting edited by abarth@webkit.org
(diff)
3:55 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
3:47 PM April 2010 Meeting edited by eric@webkit.org
(diff)
3:25 PM ApplicationsGtk edited by khorben@defora.org
Added DeforaOS Surfer (diff)
3:23 PM ApplicationsGtk edited by khorben@defora.org
Typos (diff)
3:18 PM April 2010 Meeting edited by jamesr@google.com
(diff)
3:09 PM April 2010 Meeting edited by kbr@google.com
(diff)
2:42 PM April 2010 Meeting edited by staikos@kde.org
(diff)
2:22 PM Changeset in webkit [57459] by mrowe@apple.com
  • 2 edits in tags/Safari-533.4.1/JavaScriptCore

Merge r57457.

2:15 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:14 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:14 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:12 PM Changeset in webkit [57458] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37417
Move duplicated internal CoreIPC message kinds to a
header.

Reviewed by Darin Adler.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/CoreIPCMessageKinds.h: Added.

(CoreIPC::CoreIPCMessage::):
(CoreIPC::):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
2:05 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:04 PM Changeset in webkit [57457] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/7851332> Fix the build.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.

2:04 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:55 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:54 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:46 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:43 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:43 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:42 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:41 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:41 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:37 PM April 2010 Meeting edited by weinig@apple.com
(diff)
1:35 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:34 PM Changeset in webkit [57456] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Disable not-implemented warnings by default for now.

Rubber-stamped by Anders Carlsson.

  • Shared/NotImplemented.h:
1:33 PM April 2010 Meeting edited by weinig@apple.com
(diff)
1:32 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:31 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:31 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:30 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:30 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:28 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:25 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:24 PM April 2010 Meeting edited by Chris Jerdonek
Typo fix (diff)
1:22 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:20 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:19 PM Changeset in webkit [57455] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

svn-apply errors out when removing directories in git
​https://bugs.webkit.org/show_bug.cgi?id=34871

  • Scripts/svn-apply: (isDirectoryEmptyForRemoval): early break if the directory doesn't exist (scmRemove): have git ignore unmatched files
1:18 PM Changeset in webkit [57454] by weinig@apple.com
  • 12 edits in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37399
Remove use of STL data structures from CoreIPC code

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeBytes):
(CoreIPC::ArgumentDecoder::removeAttachment):

  • Platform/CoreIPC/ArgumentDecoder.h:

Use WTF::Deque instead of std::queue and WTF::Vector
instead of std::vector. Replace use of malloc/free with
fastMalloc/fastFree.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::addAttachment):
(CoreIPC::ArgumentEncoder::releaseAttachments):

  • Platform/CoreIPC/ArgumentEncoder.h:

Use WTF::Vector instead of std::list. Replace use of malloc/free
with fastMalloc/fastFree.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchMessages):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):
Use WTF::Vector instead of std::queue.

  • Platform/RunLoop.cpp:

(RunLoop::performWork):
(RunLoop::scheduleWork):

  • Platform/RunLoop.h:

Ditto.

  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWork):
(WorkQueue::performWork):
Ditto.

1:17 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:16 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:15 PM April 2010 Meeting edited by eric@webkit.org
(diff)
12:09 PM Changeset in webkit [57453] by dbates@webkit.org
  • 4 edits
    3 deletes in trunk/WebKitTools

2010-04-11 Daniel Bates <​dbates@rim.com>

No review, rolling out 57440.
​http://trac.webkit.org/changeset/57440
​https://bugs.webkit.org/show_bug.cgi?id=27204

Did not handle Git patches that included both file and property
changes to the same file. Rolling this change out while I look
into this.

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
11:51 AM Changeset in webkit [57452] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

Minor Updates and Cleanup to the Contributing Page
​https://bugs.webkit.org/show_bug.cgi?id=37415

  • coding/contributing.html:
11:43 AM Changeset in webkit [57451] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix typo in log path for AbstractQueue
​https://bugs.webkit.org/show_bug.cgi?id=37414

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
10:34 AM Changeset in webkit [57450] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Unreviewed. Add missing import statement.

  • Scripts/webkitpy/common/system/executive.py:
8:37 AM Changeset in webkit [57449] by eric@webkit.org
  • 7 edits in trunk

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

Unskip:

http/tests/security/no-referrer.html
fast/loader/onload-willSendRequest-null-for-frame.html
fast/loader/onload-willSendRequest-null-for-script.html

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • platform/qt/Skipped:

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
2:05 AM Changeset in webkit [57448] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Unreviewed buildfix for --debug build after r57433.

Refactor Qt DRT support in QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35844

  • QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();

(launcherMain):

12:46 AM Changeset in webkit [57447] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Mark Rowe.

Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
​https://bugs.webkit.org/show_bug.cgi?id=37407

  • Scripts/commit-log-editor:
12:41 AM Changeset in webkit [57446] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add PrettyPatch links to new-run-webkit-tests output
​https://bugs.webkit.org/show_bug.cgi?id=37406

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • We're leaking a file handle here, add a FIXME.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
    • Add pretty diff links.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add support for generating pretty diffs using PrettyPatch.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • We're leaking another file handle here, another FIXME.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • Update write_output_files signature.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Remove unused arguments from write_output_files.
    • Add support for dumping pretty diffs to write_output_files.
    • Fix a bunch of file descriptor leaks in this file.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Update write_output_files signature.

Apr 10, 2010:

11:57 PM Changeset in webkit [57445] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-04-10 Adam Barth <​abarth@webkit.org>

Unreviewed. Rename m_forceSandboxFlags to m_forcedSandoxFlags, as
requested by Darin Adler.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::updateSandboxFlags):
  • loader/FrameLoader.h: (WebCore::FrameLoader::setForcedSandboxFlags):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
11:52 PM Changeset in webkit [57444] by abarth@webkit.org
  • 9 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

kill_process is copy/pasted in five places
​https://bugs.webkit.org/show_bug.cgi?id=37405

We shouldn't replicate the kill_process logic in every port. Instead,
we should move the process interaction to Executive.

Dirk mentioned that he wanted this abstraction to make it easier to
mock things out for testing. It turns out this function is only used
in one place where it can't be used as a mock point for testing because
the corresponding create process actually creates a real process. In
the long term, we should indirect both these calls through a non-static
Executive as a mock point. However, we should wait on that until we
actually want to write the test.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
11:13 PM Changeset in webkit [57443] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests shouldn't alter its path to import packages
​https://bugs.webkit.org/show_bug.cgi?id=37404

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
11:05 PM Changeset in webkit [57442] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should store results to a directory under the build tree
​https://bugs.webkit.org/show_bug.cgi?id=37380

  • Scripts/webkitpy/layout_tests/port/webkit.py:
10:57 PM Changeset in webkit [57441] by mrowe@apple.com
  • 8 edits
    1 move in trunk

<rdar://problem/7845305> Further adoption of formal protocols for delegates.

Reviewed by Dan Bernstein.

Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/EmptyProtocolDefinitions.h: Renamed from WebKit/mac/Misc/EmptyProtocolDefinitions.h.
  • platform/network/mac/ResourceHandleMac.mm:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • Misc/EmptyProtocolDefinitions.h: Removed.
  • Misc/WebDownload.mm:
  • WebKitPrefix.h:
10:46 PM Changeset in webkit [57440] by eric@webkit.org
  • 4 edits
    3 adds in trunk/WebKitTools

2010-04-10 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27204

Implement support for changing the executable bit of a file.
The executable bit is among the most changed file properties.
Future support can include other property changes.

Currently, if a patch changes the executable bit of a file
it is not respected by svn-apply or svn-unapply. Since the
commit-queue bot uses these tools as part of its workflow,
such patches cannot be committed by it. That is, such patches
need to be committed by hand. Instead, we should add support
for the executable bit so that such patches can be committed
by the commit-queue bot.

  • Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. in copyright to Apple, Inc.
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.
10:27 PM Changeset in webkit [57439] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
​https://bugs.webkit.org/show_bug.cgi?id=37401

The Git-based bots don't have this trouble because
Git.clean_working_directory fully removes files that were
marked as "add". SVN.clean_working_directory previously just
called "svn revert" which would leave added files in the
working directory untracked. This patch makes
SVN.clean_working_directory function more like
Git.clean_working_directory by removing added files after revert.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Add SCM.absolute_path for easy conversion between repository-relative paths and absolute paths.
    • Add SCM.add and SCM.added_files
    • Make SVN.clean_working_directory remove any added_files after svn revert.
    • The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add tests for added code.
10:17 PM Changeset in webkit [57438] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-10 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Defense in depth: make sure an SVG document in the <img> context has
a unique origin.

​https://bugs.webkit.org/show_bug.cgi?id=37392

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Force the temporary rendering context into a unique origin.
  • loader/FrameLoader.h: (WebCore::FrameLoader::setForceSandboxFlags): Support for setting sandbox flags that will always be applied.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags): Always apply any forced flags.
10:10 PM Changeset in webkit [57437] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests can't find ImageDiff on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37403

It turns out the build directory on Windows is structured differently
than it is on other platforms. Instead of assuming the normal
structure, we should just ask perl to figure it out for us.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
10:03 PM Changeset in webkit [57436] by eric@webkit.org
  • 4 edits
    6 moves in trunk

2010-04-10 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Moving files associated with the GPU compositor from platform/graphics/skia to platform/graphics/chromium. Class
rename was done in a previous CL, this CL does the file move and rename.
​https://bugs.webkit.org/show_bug.cgi?id=37231

No new functionality, no new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp.
  • platform/graphics/chromium/GraphicsLayerChromium.h: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.h.
  • platform/graphics/chromium/LayerChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerSkia.cpp.
  • platform/graphics/chromium/LayerChromium.h: Copied from WebCore/platform/graphics/skia/LayerSkia.h.
  • platform/graphics/chromium/LayerRendererChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.cpp.
  • platform/graphics/chromium/LayerRendererChromium.h: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.h.
  • platform/graphics/skia/GraphicsLayerSkia.cpp: Removed.
  • platform/graphics/skia/GraphicsLayerSkia.h: Removed.
  • platform/graphics/skia/LayerRendererSkia.cpp: Removed.
  • platform/graphics/skia/LayerRendererSkia.h: Removed.
  • platform/graphics/skia/LayerSkia.cpp: Removed.
  • platform/graphics/skia/LayerSkia.h: Removed.

2010-04-10 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
​https://bugs.webkit.org/show_bug.cgi?id=37231

  • src/WebViewImpl.h:
9:03 PM Changeset in webkit [57435] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Change "Gathering files" status line to "Collecting tests". Gathering
the files sounds silly to me.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:51 PM Changeset in webkit [57434] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
​https://bugs.webkit.org/show_bug.cgi?id=37400

Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.

  • platform/win/test_expectations.txt: Added.

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
​https://bugs.webkit.org/show_bug.cgi?id=37400

Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
6:35 PM Changeset in webkit [57433] by eric@webkit.org
  • 17 edits
    2 adds in trunk

2010-04-10 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • WebCore.pro: Add DumpRenderTreeSupportQt.cpp

2010-04-10 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Move all QT DRT support functions to a static class.

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebframe.cpp: Remove static functions.
  • Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
  • Api/qwebpage.cpp: Remove static functions.
  • Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
  • Api/qwebsecurityorigin.cpp: Remove static functions.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode):
  • WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
  • WebCoreSupport/EditorClientQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

2010-04-10 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Update Qt DRT to use new DumpRenderTreeSupportQt static class.

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpFramesAsText):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/GCControllerQt.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/qt/GCControllerQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setMediaType): (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::setCaretBrowsingEnabled): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::workerThreadCount): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:25 PM Changeset in webkit [57432] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move global queue log to the logs directory so it survives git clean -f
​https://bugs.webkit.org/show_bug.cgi?id=37395

  • Scripts/webkitpy/tool/commands/queues.py:
6:16 PM Changeset in webkit [57431] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-10 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup after chromium breakage. All interface methods are
returned to being abstract.

  • public/WebNotificationPresenter.h:
6:06 PM Changeset in webkit [57430] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should spam when it encounters errors
​https://bugs.webkit.org/show_bug.cgi?id=37329

We need to always update the status server so we don't get stuck in a
spam loop. I tried writing a test for this change, but it kind of
got out of control. We need a better way to do failure injection.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
5:51 PM Changeset in webkit [57429] by Joseph Pecoraro
  • 4 edits in trunk/WebCore

2010-04-10 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Missing CONTEXT_MENUS Guards
​https://bugs.webkit.org/show_bug.cgi?id=37398

Added missing ENABLE(CONTEXT_MENUS) guards.

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient):
  • inspector/InspectorFrontendHost.h:
5:49 PM Changeset in webkit [57428] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Add slow expectations based on webkit-dev discussion.

  • platform/mac/test_expectations.txt:
5:44 PM Changeset in webkit [57427] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Unreviewed attempt to fix the Chromium Mac canary.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
5:28 PM Changeset in webkit [57426] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Unreviewed.

Add the Apache bits to win.py for new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=37397

I still have run this yet, but I looked around to figure out what the
various paths appear to be. I'll figure out a way to remove the
copy/paste code in a future patch.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
4:39 PM Changeset in webkit [57425] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the win port for new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=37393

I haven't tried running this yet, but we've got to start somewhere.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py: Added.
3:44 PM Changeset in webkit [57424] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch land should not build and test by default
​https://bugs.webkit.org/show_bug.cgi?id=33631

Reverse the sense of --no-build and --no-test to be --build and --test.
Also, decoupled the build and test options so you can test without
building.

(Patch manngled by Adam Barth. All bugs are his fault.)

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
3:18 PM Changeset in webkit [57423] by abarth@webkit.org
  • 4 edits
    1 copy in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor WebKitPort out of MacPort to allow for WinPort
​https://bugs.webkit.org/show_bug.cgi?id=37388

The split is a bit of a guess. We might have to adjust things once we
actually have a second port to work with.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
3:17 PM Changeset in webkit [57422] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

run_webkit_tests.py shouldn't have platform-specific logic
​https://bugs.webkit.org/show_bug.cgi?id=37387

Dirk Pranke pointed out that my last patch was wrong because I
introduced platform-specific logic into run_webkit_tests.py, limiting
the parallelism in Chromium to work around a bug in the main Mac port.

  • Scripts/webkitpy/common/system/executive.py:
    • Fix a typo pointed out by Chris Jerdonek.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:09 PM Changeset in webkit [57421] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Fix an obviously incorrect part of the Xcode configuration cleanup that resulted in debug builds
asserting shortly after launch.

  • WebKit2.xcodeproj/project.pbxproj: Fix the setting of DEBUG_DEFINES for the Debug configuration.
2:39 PM Changeset in webkit [57420] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix crash in Gradient::fill()
​https://bugs.webkit.org/show_bug.cgi?id=37386

Covered by existing tests.

  • platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::fill):
    • Make sure the platform gradient is already cached before dereferencing its pointer.
2:30 PM Changeset in webkit [57419] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix build of ImageHaiku.cpp
<​https://bugs.webkit.org/show_bug.cgi?id=37384>

No new tests needed.

  • platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
    • include SharedBuffer.h
    • changed parameter name to be in line with other ports, the code I landed in an earlier commit was already using this name.
5:28 AM Changeset in webkit [57418] by robert@webkit.org
  • 4 edits in trunk

[Qt] Fix regressions in http/tests/navigation from r57416

2010-04-10 Robert Hogan <​robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Unskip tests skipped after regression in r57416.

​https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:

2010-04-10 Robert Hogan <​robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Reset willSendRequestReturnsNullOnRedirect after each test to
prevent it leaking to subsequent tests.

Error pointed out by Jakub Wieczorek.

​https://bugs.webkit.org/show_bug.cgi?id=37237

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
3:41 AM Changeset in webkit [57417] by robert@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-04-10 Robert Hogan <​robert@webkit.org>

Unreviewed fix to regressions from r57416.

Add expected results missing from r57416

Skip 2 tests that now fail.

http/tests/navigation/postredirect-reload.html
http/tests/navigation/redirect302-basic.html

These regressions will be worked under:
​https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:
  • platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
3:12 AM Changeset in webkit [57416] by robert@webkit.org
  • 8 edits in trunk

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5 rather than -999, so add platform-specific results accordingly.

Add platform-specific results for the the following, though leave them skipped for now. They've started failing again
since review was granted (see ​https://bugs.webkit.org/show_bug.cgi?id=37382):

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

​https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:
  • platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=37237

  • WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
Prevent dumping resource load callbacks once layout test has dumped.

​https://bugs.webkit.org/show_bug.cgi?id=37237

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
2:09 AM Changeset in webkit [57415] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, fixing description and expectation for media/video-replaces-poster.html.

  • platform/chromium/test_expectations.txt:
2:06 AM Changeset in webkit [57414] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, marking media/video-replaces-poster.html as flaky.

  • platform/chromium/test_expectations.txt:
1:35 AM Changeset in webkit [57413] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in corrected baselines for media/video-replaces-poster.html
on Chromium Win.

  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
1:18 AM Changeset in webkit [57412] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed, platform specific expected files updated after r57408.

[Qt] Implement Desktop Notifications API for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35503

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
1:11 AM Changeset in webkit [57411] by scherkus@chromium.org
  • 120 edits
    41 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, enable the rest of the fast/media tests for Chromium Mac and Linux
by checking in new baselines.

  • platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.png:
  • platform/chromium-linux/fast/media/media-type-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/media-type-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/media-type-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/media-type-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/mq-animation-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-animation-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-aspect-ratio-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-aspect-ratio-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-compound-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-grid-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-grid-01-expected.png:
  • platform/chromium-linux/fast/media/mq-grid-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-grid-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.png:
  • platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.checksum:
  • platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.png:
  • platform/chromium-linux/fast/media/mq-min-constraint-expected.checksum:
  • platform/chromium-linux/fast/media/mq-min-constraint-expected.png:
  • platform/chromium-linux/fast/media/mq-orientation-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-orientation-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-pixel-ratio-expected.checksum:
  • platform/chromium-linux/fast/media/mq-pixel-ratio-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-01-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-01-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-04-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-04-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transition-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transition-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-valueless-expected.checksum:
  • platform/chromium-linux/fast/media/mq-valueless-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
  • platform/chromium-linux/fast/media/viewport-media-query-expected.checksum:
  • platform/chromium-linux/fast/media/viewport-media-query-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:47 AM Changeset in webkit [57410] by scherkus@chromium.org
  • 4 edits
    8 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in updated baselines and expectations for Chromium media layout tests.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-linux/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-mac/media/controls-drag-timebar-expected.txt: Added.
  • platform/chromium-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-mac/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-win/media/controls-drag-timebar-expected.txt: Added.
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-win/media/video-replaces-poster-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:46 AM Changeset in webkit [57409] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=37381

  • platform/qt/Skipped: animations/dynamic-stylesheet-loading.html skipped until fix.
12:35 AM Changeset in webkit [57408] by Laszlo Gombos
  • 13 edits
    2 adds in trunk

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35503

Map WebKit notifications to Qt's SystemTray API and
implement DRT tracing.

This patch does not implement the security part of
WebKit notifications.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission):
  • WebCoreSupport/NotificationPresenterClientQt.h: Added.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35503

No new tests enabled as notification DRT tests are
disabled at the moment.

  • WebCore.pri: Add files to the build system and turn on the feature by default.
  • WebCore.pro: Add files to the build system
  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission): (WebCore::JSNotification::addEventListener): (WebCore::JSNotification::removeEventListener): Fix build regresssion.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35503

DRT stubs for notification. Enables to run and pass
3 (currently disabled) tests.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

Apr 9, 2010:

11:35 PM Changeset in webkit [57407] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, another change to executive.py to make it run with
python 2.4.

  • Scripts/webkitpy/common/system/executive.py:
11:20 PM Changeset in webkit [57406] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, attempting to make executive.py run with python 2.4
(which is still used on Chromium's Windows canary bot).

  • Scripts/webkitpy/common/system/executive.py:
10:02 PM Changeset in webkit [57405] by pfeldman@chromium.org
  • 6 edits in trunk

2010-04-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Console with two recursive arrays causes infinite loop trying to display.
​https://bugs.webkit.org/show_bug.cgi?id=37133

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
8:18 PM WebKit2 edited by dbates@webkit.org
Spelling corrections. (diff)
8:09 PM Changeset in webkit [57404] by eric@webkit.org
  • 11 edits in trunk

2010-04-09 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

  • css/CSSFontFaceSource.cpp:
  • platform/graphics/wx/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeContains): (WebCore::Path::debugString): (WebCore::Path::operator=): (WebCore::Path::isEmpty):
  • rendering/RenderSVGResourceMasker.cpp:
  • wscript:

2010-04-09 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

  • wx/build/settings.py:
7:59 PM Changeset in webkit [57403] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
​https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
7:50 PM Changeset in webkit [57402] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-09 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Linux: respect the scale factor during printing
​https://bugs.webkit.org/show_bug.cgi?id=37168

Chromium doesn't support testing .pdfs from printing at the moment, so
this change is not covered by any tests.

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):
7:34 PM Changeset in webkit [57401] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-09 Aaron Boodman <​aa@chromium.org>

Reviewed by Eric Seidel.

Remove applicationID() from WebDocument as it is Chromium-specific.
​https://bugs.webkit.org/show_bug.cgi?id=37350

  • public/WebDocument.h:
  • src/WebDocument.cpp:
7:24 PM Changeset in webkit [57400] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-09 Adam Barth <​abarth@webkit.org>

Unreviewed.

Test a theory about why this is failing downstream.

  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
7:17 PM Changeset in webkit [57399] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-04-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't reinvent Executive.cpu_count for every port
​https://bugs.webkit.org/show_bug.cgi?id=37377

mac.py and chromium_mac.py had some copy/paste code. This code doesn't
actually have anything to do with WebKit ports. It's really just
something in the multiprocessing package. The lame bit is that package
isn't available in older versions of Python, so we need to implement a
fallback. However, we already have the fallback in common. We don't
need to reinvent it specificly for layout_tests.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:17 PM Changeset in webkit [57398] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
​https://bugs.webkit.org/show_bug.cgi?id=37376

We need to explicitly pass the --release flag. I bet there are more
instances of this bug.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
7:16 PM Changeset in webkit [57397] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_IM
​https://bugs.webkit.org/show_bug.cgi?id=36533

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup):
7:13 PM Changeset in webkit [57396] by scherkus@chromium.org
  • 59 edits in trunk/LayoutTests

2010-04-09 Sergey Ulanov <​sergeyu@chromium.org>

Unreviewed, checking in baselines due to Chromium's new video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
7:06 PM Changeset in webkit [57395] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-09 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] DRT compile fix on win/linux
​https://bugs.webkit.org/show_bug.cgi?id=37314

Looks like this was missed when upstreaming.

  • DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier):
6:56 PM Changeset in webkit [57394] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-09 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

StorageEvent destructor should be in StorageEvent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37356

Because Storage is forward-declared in StorageEvent.h, we need to define
the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
destructor has a complete type for Storage.

  • storage/StorageEvent.cpp: (WebCore::StorageEvent::~StorageEvent):
  • storage/StorageEvent.h:
6:45 PM Changeset in webkit [57393] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-04-09 Young Han Lee <​joybro@company100.net>

Reviewed by Eric Seidel.

[WINCE] Add forwarding header for UnicodeWince.h
​https://bugs.webkit.org/show_bug.cgi?id=37224

  • ForwardingHeaders/wtf/unicode/wince/UnicodeWince.h: Added.
6:15 PM Changeset in webkit [57392] by mrowe@apple.com
  • 5 edits in trunk/WebKit2

Bring the WebKit2 Xcode configuration in to sync with recent changes to the WebKit Xcode configuration files.

Reviewed by Sam Weinig.

In particular, this updates the FEATURE_DEFINES to match those used in the other projects, and brings in
the changes to support building WebKit for older Mac OS X versions from the current Mac OS X version.

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
6:09 PM Changeset in webkit [57391] by ggaren@apple.com
  • 7 edits in trunk/WebCore

Tidied up some more DOMWrapperWorld lifetime issues.

Reviewed by Sam "R the K!" Weinig.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Notify the document that
we're going away instead of deleting its data, since deleting other
objects' data is error-prone and, more importantly, rude.

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::didCreateWrapperCache):
(WebCore::DOMWrapperWorld::didDestroyWrapperCache): A few renames for
clarity.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h: Converted forgetAllDOMNodesForDocument

to a Document member function, for the same reason.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createWrapperCache):
(WebCore::Document::destroyWrapperCache):
(WebCore::Document::destroyAllWrapperCaches):

  • dom/Document.h: Added a destroyWrapperCache function to balance

createWrapperCache, so it's clear who allocates and deletes these wrapper
caches.

6:00 PM Changeset in webkit [57390] by cmarrin@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Simon Fraser.

Fixed bug where animation time was not updated when dynamically loading a style sheet
​https://bugs.webkit.org/show_bug.cgi?id=37352

A dynamically loaded style sheet kicks off its own styleRecalc cycle. This was not
bracketed with a beginAnimationUpdate/endAnimationUpdate which wasn't resetting the
animation time. In some time-dependent cases this was causing a negative elapsedTime
to be sent to the keyframe animator. This is an invalid case which destroys the
animation prematurely. I not only added the brackets, but I also added an assert
and protection for when the elapsedTime comes up negative.

Test: animations/dynamic-stylesheet-loading.html

  • dom/Document.cpp: Added brackets (WebCore::Document::updateStyleSelector):
  • page/animation/KeyframeAnimation.cpp: Added assert and protection (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
5:52 PM Changeset in webkit [57389] by mrowe@apple.com
  • 5 edits
    1 copy
    1 move
    1 add in trunk/WebKit2

Clean up the Xcode project configuration.

Reviewed by Sam Weinig.

Common target settings are pulled out in to BaseTarget.xcconfig. The majority of setting overrides are
removed from the Xcode project itself. Info.plist files are updated to match those used in other frameworks.

  • Configurations/BaseTarget.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
  • Configurations/WebKit2.xcconfig:
  • Configurations/WebProcess.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
  • Info.plist:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess-Info.plist: Removed.
  • WebProcess/Info.plist: Moved from WebProcess-Info.plist.
5:51 PM Changeset in webkit [57388] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::popupFocus() fails
​https://bugs.webkit.org/show_bug.cgi?id=37320

The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.

  • tests/qwebframe/tst_qwebframe.cpp:
5:41 PM Changeset in webkit [57387] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-09 Jaime Yap <​jaimeyap@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixes "wrong parent" for GCEvents that come at the end of a
timeline record node.
​https://bugs.webkit.org/show_bug.cgi?id=37340

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
5:26 PM Changeset in webkit [57386] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2010-04-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Prevent HTTP responses served with JSON content type from being rendered as HTML.

Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types.

2010-04-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Test non-image and javascript mime types are not rendered as HTML.

  • http/tests/security/resources/send-mime-types.php: Added.
  • http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt: Added.
  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Added.
4:45 PM Changeset in webkit [57385] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m:

(InitWebCoreSystemInterface): Update for recent WKSI changes.

4:40 PM Changeset in webkit [57384] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-04-09 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Prevent wrong use of PrintContext
​https://bugs.webkit.org/show_bug.cgi?id=37194

No new tests because this doesn't change the behavior.

  • page/PrintContext.cpp: (WebCore::PrintContext::PrintContext): (WebCore::PrintContext::~PrintContext): (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
  • page/PrintContext.h:
4:28 PM Changeset in webkit [57383] by abarth@webkit.org
  • 1 edit
    1 move in trunk/WebKitTools

2010-04-09 Adam Barth <​abarth@webkit.org>

Unreviewed, but approved by Dirk Pranke.

rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run
​https://bugs.webkit.org/show_bug.cgi?id=37372

We need to end unit tests with _unittest.py for them to be autodetected
by the test harness. +6 tests.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py.
4:28 PM Changeset in webkit [57382] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-09 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Darin Fisher.

[V8] SerializedScriptValue value doesn't follow the spec for DOM objects and files
​https://bugs.webkit.org/show_bug.cgi?id=37094

This patch adds support for file-related types.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::writeString): (WebCore::Writer::writeWebCoreString): (WebCore::Writer::writeBlob): (WebCore::Writer::writeFile): (WebCore::Writer::writeFileList): (WebCore::Writer::doWriteString): (WebCore::Writer::doWriteWebCoreString): (WebCore::Serializer::writeBlob): (WebCore::Serializer::writeFile): (WebCore::Serializer::writeFileList): (WebCore::Serializer::doSerialize): (WebCore::Reader::read): (WebCore::Reader::readWebCoreString): (WebCore::Reader::readBlob): (WebCore::Reader::readFile): (WebCore::Reader::readFileList): (WebCore::SerializedScriptValue::SerializedScriptValue):
4:19 PM Changeset in webkit [57381] by abarth@webkit.org
  • 6 edits
    1 move in trunk/WebKitTools

2010-04-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should talk about DumpRenderTree not test_shell
​https://bugs.webkit.org/show_bug.cgi?id=37371

test_shell is some strange Chromium thing.
DumpRenderTree (tm) is the real deal.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:18 PM Changeset in webkit [57380] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-09 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff()
​https://bugs.webkit.org/show_bug.cgi?id=32582

Add missing return variable. Initialize $patch variable and remove unnecessary condition.

  • Scripts/svn-create-patch:
4:16 PM Changeset in webkit [57379] by ggaren@apple.com
  • 7 edits in trunk/WebCore

Tidied up some DOMWrapperWorld lifetime issues.

Reviewed by Cameron Zwarich.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld): Made DOMWrapperWorld wholly
responsible for managing its presence in WebCoreJSClientData's world set.
This is simpler and more encapsulated than making its clients sometimes
responsible for managing that set and sometimes not.

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create): Made isNormal default to false,
removing one of the reasons for the IsolatedWorld class to exist, so I
could remove that class.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData): Used the work-around below.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWorld): Nixed IsolatedWorld, which is
now superfluous.

  • bindings/js/WebCoreJSClientData.h:

(WebCore::initNormalWorldClientData): Added a work-around for the fact
that WebCoreJSClientData must be set as globalData->clientData before
the DOMWrapperWorld constructor runs. This removed the other reason
for the IsolatedWorld class to exist, so I could remove that class.

4:12 PM Changeset in webkit [57378] by yaar@chromium.org
  • 1 edit
    5 adds in trunk/WebCore

2010-04-09 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Nate Chapin.

Testing utility for CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=37286

  • bindings/v8/test: Added.
  • bindings/v8/test/TestObj.idl: Contains basic IDL definitions for testing purposes.
  • bindings/v8/test/V8TestObj.cpp: Expected output.
  • bindings/v8/test/V8TestObj.h: Expected output.
  • bindings/v8/test/run_tests.py: Tool for generating the above h/cpp files from the idl file.
3:58 PM Changeset in webkit [57377] by Darin Adler
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37370
Division by 0 in RenderBoxModelObject::calculateFillTileSize

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/backgrounds/background-fill-zero-area-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Added checks for
zero before doing division. These come up when the area to fill is zero.

LayoutTests:

  • fast/backgrounds/background-fill-zero-area-crash-expected.txt: Added.
  • fast/backgrounds/background-fill-zero-area-crash.html: Added.
3:53 PM Changeset in webkit [57376] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after addition of LayoutTestController method.

3:50 PM Changeset in webkit [57375] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37351
Cannot build with build-webkit --webkit2

Reviewed by Darin Adler.

Add some headers that it seems others are not getting
already.

  • Platform/mac/WorkQueueMac.cpp: #inlude <mach/mach_port.h>
  • Shared/mac/UpdateChunk.cpp: #inlude <mach/vm_map.h>
3:46 PM Changeset in webkit [57374] by weinig@apple.com
  • 1 edit
    29 adds in trunk/WebKitTools

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37368
Add MiniBrowser.

Reviewed by Anders Carlsson.

  • MiniBrowser: Added.
  • MiniBrowser/MiniBrowser.vcproj: Added.
  • MiniBrowser/MiniBrowser.xcodeproj: Added.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
  • MiniBrowser/mac: Added.
  • MiniBrowser/mac/AppDelegate.h: Added.
  • MiniBrowser/mac/AppDelegate.m: Added.
  • MiniBrowser/mac/BrowserWindowController.h: Added.
  • MiniBrowser/mac/BrowserWindowController.m: Added.
  • MiniBrowser/mac/English.lproj: Added.
  • MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
  • MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
  • MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
  • MiniBrowser/mac/MiniBrowser-Info.plist: Added.
  • MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
  • MiniBrowser/mac/main.m: Added.
  • MiniBrowser/win: Added.
  • MiniBrowser/win/BrowserView.cpp: Added.
  • MiniBrowser/win/BrowserView.h: Added.
  • MiniBrowser/win/BrowserWindow.cpp: Added.
  • MiniBrowser/win/BrowserWindow.h: Added.
  • MiniBrowser/win/MiniBrowser.cpp: Added.
  • MiniBrowser/win/MiniBrowser.h: Added.
  • MiniBrowser/win/MiniBrowser.rc: Added.
  • MiniBrowser/win/Resources: Added.
  • MiniBrowser/win/main.cpp: Added.
  • MiniBrowser/win/resource.h: Added.
  • MiniBrowser/win/stdafx.cpp: Added.
  • MiniBrowser/win/stdafx.h: Added.
3:33 PM Changeset in webkit [57373] by ap@apple.com
  • 16 edits
    3 copies
    2 adds
    2 deletes in trunk

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=24572
XMLHttpRequest.statusText returns always "OK" on Mac

Covered by existing tests, which now pass.

  • WebCore.base.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Added a WebKitSystemInterface method to fetch status line.
  • platform/network/HTTPParsers.cpp: (WebCore::extractReasonPhraseFromHTTPStatusLine):
  • platform/network/HTTPParsers.h:
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): Moved code for parsing status line to HTTPHeaders, as it's used for both Mac and CF now.
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Use the actual reason phrase when available, and "OK" otherwise. Synthesizing a reson when there isn't one is misleading, so we'll stick to our old broken behavior on Tiger, rather than introduce a new broken one.
3:19 PM Changeset in webkit [57372] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling back the last two changes. The failing tests
are a Chromium problem, not a WebKit one.

  • platform/chromium/test_expectations.txt:
3:14 PM Changeset in webkit [57371] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.

Reviewed by Oliver Hunt.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::sizeType):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskImage):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):
(WebCore::InheritedFlags::maskComposite):
(WebCore::InheritedFlags::maskAttachment):
(WebCore::InheritedFlags::maskClip):
(WebCore::InheritedFlags::maskOrigin):
(WebCore::InheritedFlags::maskXPosition):
(WebCore::InheritedFlags::maskYPosition):
(WebCore::InheritedFlags::maskSizeType):
(WebCore::InheritedFlags::maskSizeLength):

3:05 PM Changeset in webkit [57370] by mrowe@apple.com
  • 2 edits in tags/Safari-533.4.1/WebKit/win

Merge r57336.

2:59 PM Changeset in webkit [57369] by mrowe@apple.com
  • 4 edits in tags/Safari-533.4.1

Versioning.

2:40 PM Changeset in webkit [57368] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, adding a TIMEOUT expectations for worker-simple.html
on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [57367] by andersca@apple.com
  • 4 edits in trunk/WebKit2

More build fixes.

  • WebProcess/win/WebProcessMain.h:

Include windows.h here.

  • win/WebKit2.def:

Add new exports.

  • win/WebKit2.vcproj:

Add new files.

2:36 PM Changeset in webkit [57366] by mrowe@apple.com
  • 1 copy in tags/Safari-533.4.1

New tag.

2:20 PM Changeset in webkit [57365] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add another missing export to fix the build.

  • WebCore.base.exp:
2:19 PM Changeset in webkit [57364] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add new WKString.h and WKURL.h headers to top
level include.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WebKit2.h:
2:10 PM Changeset in webkit [57363] by andersca@apple.com
  • 4 edits in trunk/WebKit2

More Windows build fixes.

  • Shared/NotImplemented.h:
  • UIProcess/API/C/cf/WKURLCF.cpp:

Fix typo.

(WKURLCreateWithCFURL):

  • UIProcess/API/C/cf/WKURLCF.h:

Ditto.

  • win/WebKit2Generated.make:

Copy the new CF headers.

2:06 PM Changeset in webkit [57362] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping a test on Linux in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=37359

  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [57361] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch attached my patch to the wrong bug
​https://bugs.webkit.org/show_bug.cgi?id=37015

The problem here is that SVN was violating SCM's implicit
contract of always returning paths relative to the repository root.
That can easily be fixed by telling SVN that the CWD is the repository root.

When fixing this I realized there are a large number of places in SCM.py where
we want to consider explicitly passing self.checkout_root as the CWD.
That would allow scm methods to be executed even when the CWD is not inside
the scm tree at all, and would also make sure (in the case of SVN) that paths
returned are relative to the root. Git (almost always) returns paths relative
to the repository root.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
    • Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root and which do not. We'll probably add a helper function to scm (likely SCM._run) which always passes cwd=self.checkout_root to Executive.run_command
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add a test for this change.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Removed the explicit os.chdir to the repository root, since scm.py methods should be robust against the cwd not being equal to the root.
1:51 PM Changeset in webkit [57360] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Two more #include sorting issues.

Reviewed by Anders Carlsson.

  • Shared/NotImplemented.h:
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
1:49 PM Changeset in webkit [57359] by weinig@apple.com
  • 37 edits in trunk/WebKit2

Fix minor style nits found by the style-script.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • Platform/CoreIPC/win/ConnectionWin.cpp:
  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:
  • Platform/win/RunLoopWin.cpp:
  • Shared/KURLWrapper.h:
  • Shared/WebCoreTypeArgumentMarshalling.h:
  • Shared/mac/UpdateChunk.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKURL.cpp:
  • UIProcess/Launcher/win/WebProcessLauncher.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/win/DrawingAreaProxy.cpp:
  • UIProcess/win/WebView.cpp:
  • WebProcess/Launching/win/WebProcessWinMain.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp:
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/win/WebLocalizableStrings.cpp:
  • WebProcess/win/WebLocalizableStrings.h:
  • WebProcess/win/WebProcessMain.cpp:
1:44 PM Changeset in webkit [57358] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.

Reviewed by Adam Roben.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • rendering/style/CursorData.h:

(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::image):
(WebCore::CursorData::hotSpot):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCursor):

1:40 PM Changeset in webkit [57357] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Holger Freyther.

Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete
since Qt 4.5. window() method is being used instead now.

See ​http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::windowResizerRect):
1:35 PM Changeset in webkit [57356] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • Shared/NotImplemented.h:

Include stdio.h.

1:21 PM Changeset in webkit [57355] by hyatt@apple.com
  • 11 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup. Working from the outside in to
bring some style consistency to RenderStyle and its associated classes. This patch cleans up the
border and outline classes.

Reviewed by Adam Roben.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcOuterBorderTop):
(WebCore::RenderTableSection::calcOuterBorderBottom):
(WebCore::RenderTableSection::calcOuterBorderLeft):
(WebCore::RenderTableSection::calcOuterBorderRight):

  • rendering/style/BorderData.h:

(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator==):
(WebCore::BorderData::left):
(WebCore::BorderData::right):
(WebCore::BorderData::top):
(WebCore::BorderData::bottom):
(WebCore::BorderData::image):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
(WebCore::BorderValue::width):
(WebCore::BorderValue::style):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::operator==):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::operator==):
(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::isAuto):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getBorderRadiiForRect):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::borderLeft):
(WebCore::InheritedFlags::borderRight):
(WebCore::InheritedFlags::borderTop):
(WebCore::InheritedFlags::borderBottom):
(WebCore::InheritedFlags::borderImage):
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderLeftIsTransparent):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderRightIsTransparent):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderTopIsTransparent):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::borderBottomIsTransparent):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::resetBorderTop):
(WebCore::InheritedFlags::resetBorderRight):
(WebCore::InheritedFlags::resetBorderBottom):
(WebCore::InheritedFlags::resetBorderLeft):
(WebCore::InheritedFlags::resetBorderImage):
(WebCore::InheritedFlags::resetBorderTopLeftRadius):
(WebCore::InheritedFlags::resetBorderTopRightRadius):
(WebCore::InheritedFlags::resetBorderBottomLeftRadius):
(WebCore::InheritedFlags::resetBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderImage):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderLeftWidth):
(WebCore::InheritedFlags::setBorderLeftStyle):
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightWidth):
(WebCore::InheritedFlags::setBorderRightStyle):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopWidth):
(WebCore::InheritedFlags::setBorderTopStyle):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomWidth):
(WebCore::InheritedFlags::setBorderBottomStyle):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setOutlineOffset):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::setColumnRuleWidth):

  • rendering/style/StyleMultiColData.h:

(WebCore::StyleMultiColData::ruleWidth):

1:20 PM Changeset in webkit [57354] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-09 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Make CallIdentifier constructor to handle null urls.

​https://bugs.webkit.org/show_bug.cgi?id=37341

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::CallIdentifier):
1:10 PM Changeset in webkit [57353] by weinig@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Add some missing URLs to ChangeLogs.

1:08 PM Changeset in webkit [57352] by weinig@apple.com
  • 21 edits
    10 adds in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37347
Don't use CF types in the new C API

Reviewed by Anders Carlsson.

Replace all uses of CF types in the C API.

  • Replace CFStringRef with WKStringRef.
  • Replace CFURLRef with WKURLRef.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • Shared/KURLWrapper.h: Added. RefCounted wrapper around KURL.
  • UIProcess/API/C/WKAPICast.h: Add new conversions.
  • UIProcess/API/C/WKBase.h: Add new types.
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:

Replace uses of CF types with WK equivalents.

  • UIProcess/API/C/WKString.cpp: Added.
  • UIProcess/API/C/WKString.h: Added.

Represents a WebCore::StringImpl*.

  • UIProcess/API/C/WKURL.cpp: Added.
  • UIProcess/API/C/WKURL.h: Added.

Represents a WebKit::KURLWrapper*.

  • UIProcess/API/C/cf: Added.
  • UIProcess/API/C/cf/WKStringCF.cpp: Added.
  • UIProcess/API/C/cf/WKStringCF.h: Added.
  • UIProcess/API/C/cf/WKURLCF.cpp: Added.
  • UIProcess/API/C/cf/WKURLCF.h: Added.

CoreFoundation conversion files. Allows converting

WKStringRef <-> CFStringRef
WKURLRef <-> CFURLRef

  • UIProcess/ScriptReturnValueCallback.cpp:

(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):

  • UIProcess/ScriptReturnValueCallback.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptAlert):

  • UIProcess/WebUIClient.h:

Don't use CF types internally at all.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Fix typo.

1:01 PM Changeset in webkit [57351] by eric@webkit.org
  • 6 edits in trunk

2010-04-09 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Darin Adler.

Changed expectation for text status for HTTP status of 4xx following
a fix for localized status messages.
​https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt:
  • platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:

2010-04-09 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Darin Adler.

Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText()
to return meaningful values.
​https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
12:50 PM Changeset in webkit [57350] by eric@webkit.org
  • 13 edits in trunk

2010-04-09 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
​https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

No functional change.

  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:

2010-04-09 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
​https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
12:29 PM Changeset in webkit [57349] by dimich@chromium.org
  • 12 edits
    2 adds in trunk

WebCore: WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker.
​https://bugs.webkit.org/show_bug.cgi?id=37053

Reviewed by Darin Adler.

WebCore:

Test: fast/workers/worker-close-more.html

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):

  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::):
Added option parameter to forbidExecution (both JCS and V8 versions) that specifies whether currently running
script should be immediately terminated or left executed until the end.

  • bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContextWrapper):
This method now can return 0 instead of context if the further execution of JS is forbidden. Since any JS execution requires
fetching JS global object first, returning 0 here is a good way to prevent re-entry into JS once worker started termination.
V8 version does similar thing already in WorkerScriptController::proxy().

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::postMessage):
Removed check that immediately disables postMessage from WorkerContext after close().

  • workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::create):
(WebCore::CloseWorkerContextTask::performTask):
(WebCore::CloseWorkerContextTask::isCleanupTask):
(WebCore::WorkerContext::close):
Use new forbidExecution(LetRunningScriptFinish) to avoid termination of script until it executes and exits.
Post a task to actually terminate the worker once the currently executing JS fragment exits.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
Use new forbidExecution(TerminateRunningScript) to immediately terminate the JS.

LayoutTests:

  • fast/workers/resources/worker-close.js:
  • fast/workers/worker-close-expected.txt:

Updated tests to expect the script fragment that includes close() to run to completion.

  • fast/workers/worker-close-more-expected.txt: Added.
  • fast/workers/worker-close-more.html: Added.
  • fast/workers/worker-close.html:

Added test to check terminate() after close() and close() in the case of multiple MessagePort messages dispatching.

12:10 PM Changeset in webkit [57348] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r57343.
​http://trac.webkit.org/changeset/57343
​https://bugs.webkit.org/show_bug.cgi?id=37311

Broke Tiger compile.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
11:56 AM Changeset in webkit [57347] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.

11:03 AM Changeset in webkit [57346] by tkent@chromium.org
  • 6 edits
    13 adds in trunk

Implement interactive validation for forms.
​https://bugs.webkit.org/show_bug.cgi?id=34930

Reviewed by Darin Adler.

WebCore:

  • HTMLFormControlElement::checkValidity() supports unhandled invalid control list
  • HTMLFormElement::validateInteractively() called from prepareSubmit() prevents the submission if neither noValidate nor formNoValidate is specified, and focuses on the first invalid control of which "invalid" event is not canceled.

Tests: fast/forms/checkValidity-cancel.html

fast/forms/interactive-validation-cancel.html
fast/forms/interactive-validation-formnovalidate.html
fast/forms/interactive-validation-novalidate.html
fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-remove-node-in-handler.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity):

If the control is invalid and the "invalid" is not canceled,
push the control to the specified vector.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

The main part of the interactive validation.

(WebCore::HTMLFormElement::prepareSubmit):

Calls validateInteractively().

(WebCore::HTMLFormElement::checkValidity):

Uses collectUnhandledInvalidControls().

(WebCore::HTMLFormElement::collectUnhandledInvalidControls):

  • html/HTMLFormElement.h:

LayoutTests:

Add tests for "invalid" event and interactive validation.

  • fast/forms/checkValidity-cancel-expected.txt: Added.
  • fast/forms/checkValidity-cancel.html: Added.
  • fast/forms/interactive-validation-cancel-expected.txt: Added.
  • fast/forms/interactive-validation-cancel.html: Added.
  • fast/forms/interactive-validation-formnovalidate-expected.txt: Added.
  • fast/forms/interactive-validation-formnovalidate.html: Added.
  • fast/forms/interactive-validation-novalidate-expected.txt: Added.
  • fast/forms/interactive-validation-novalidate.html: Added.
  • fast/forms/interactive-validation-prevented-expected.txt: Added.
  • fast/forms/interactive-validation-prevented.html: Added.
  • fast/forms/interactive-validation-remove-node-in-handler-expected.txt: Added.
  • fast/forms/interactive-validation-remove-node-in-handler.html: Added.
  • fast/forms/script-tests/checkValidity-cancel.js: Added.
10:45 AM Changeset in webkit [57345] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-09 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK+] media/video-src-invalid-remove.html
​https://bugs.webkit.org/show_bug.cgi?id=37344

Skip test that is failing constantly but apparently without reason
on the 64 bits release bot.

  • platform/gtk/Skipped:
10:04 AM Changeset in webkit [57344] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the mac WebKit2 build.

  • WebCore.base.exp:
9:53 AM Changeset in webkit [57343] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
​https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
9:49 AM Changeset in webkit [57342] by abecsi@webkit.org
  • 1 edit
    107 adds in trunk/LayoutTests

[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expected files these
platform dependent results only differ from Mac resulst in font metrics and svg implementation.

Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <​abecsi@inf.u-szeged.hu>

  • platform/qt/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/qt/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/qt/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.checksum: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.png: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.txt: Added.
  • platform/qt/fast/forms/basic-selects-expected.checksum: Added.
  • platform/qt/fast/forms/basic-selects-expected.png: Added.
  • platform/qt/fast/forms/basic-selects-expected.txt: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.txt: Added.
  • platform/qt/fast/ruby: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.txt: Added.
  • platform/qt/fast/runin/generated2-expected.checksum: Added.
  • platform/qt/fast/runin/generated2-expected.png: Added.
  • platform/qt/fast/runin/generated2-expected.txt: Added.
  • platform/qt/fast/runin/generated3-expected.checksum: Added.
  • platform/qt/fast/runin/generated3-expected.png: Added.
  • platform/qt/fast/runin/generated3-expected.txt: Added.
  • platform/qt/fast/runin/generated4-expected.checksum: Added.
  • platform/qt/fast/runin/generated4-expected.png: Added.
  • platform/qt/fast/runin/generated4-expected.txt: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.txt: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.checksum: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.png: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.checksum: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.png: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.checksum: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.txt: Added.
  • platform/qt/svg/overflow: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.png: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/qt/svg/text/selection-styles-expected.checksum: Added.
  • platform/qt/svg/text/selection-styles-expected.png: Added.
  • platform/qt/svg/text/selection-styles-expected.txt: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.png: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.txt: Added.
9:38 AM Changeset in webkit [57341] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
​https://bugs.webkit.org/show_bug.cgi?id=37330

  • public/WebApplicationCacheHost.h:
  • public/WebKitClient.h:
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
9:35 AM Changeset in webkit [57340] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37181
<rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data

Test: fast/events/gc-freeze-with-attribute-listeners.html

The problem was that we were creating JS wrappers for nodes with attribute event listeners,
and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
have a wrapper.

  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction() will create one.
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem we are stepping around now.
8:56 AM Changeset in webkit [57339] by Adam Roben
  • 4 edits
    8 adds in trunk

Make :visited tests added in r57292 not assert on Windows and GTK builds

Fixes <​http://webkit.org/b/37333>.

Reviewed by Anders Carlsson.

WebKitTools:

Don't return 0 as a JSValueRef

That is an illegal use of the JSC API.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.

LayoutTests:

Add Windows- and GTK-specific results for new :visited tests

These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<​http://webkit.org/b/37336> and <​http://webkit.org/b/37337>.

  • platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Added.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
  • platform/win/fast/history/nested-visited-test-expected.txt: Added.
  • platform/win/fast/history/self-is-visited-expected.txt: Added.
  • platform/win/fast/history/sibling-visited-test-expected.txt: Added.
7:25 AM QtWebKitBackportingFixes edited by joseph.ligman@nokia.com
(diff)
7:01 AM Changeset in webkit [57338] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-09 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

WebGtk GLib-CRITICAL Segmentation fault
​https://bugs.webkit.org/show_bug.cgi?id=34937

Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
6:44 AM Changeset in webkit [57337] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-04-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Cannot select elements within iframes with the magnifying glass.

​https://bugs.webkit.org/show_bug.cgi?id=31732

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::handleMousePress):
  • inspector/InspectorController.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
6:40 AM Changeset in webkit [57336] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows Debug/Release build fix after r57244

  • WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or

QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.

6:14 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:13 AM Changeset in webkit [57335] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
Should not try to access WebViewClient if the frame has already been disconnected.
​https://bugs.webkit.org/show_bug.cgi?id=37318

  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
6:03 AM Changeset in webkit [57334] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-09 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_PROPERTIES
​https://bugs.webkit.org/show_bug.cgi?id=36526

Disable dynamic properties when QT_NO_PROPERTIES is defined.

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed):
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
  • bridge/qt/qt_runtime.h: (JSC::Bindings::QtField::):
5:47 AM QtWebKitJournal edited by Simon Hausmann
(diff)
5:15 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:14 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:12 AM Changeset in webkit [57333] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Symbian apps crash on exit due to a bad qObject_cast.

Patch by David Leong <​david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash.

  • plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformDestroy):

5:03 AM Changeset in webkit [57332] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

[ Re-landing of r57329 with the requisite memset added in -initWithFrame: so that the tests keep working. ]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

4:55 AM Changeset in webkit [57331] by Simon Hausmann
  • 2 edits in trunk

Unreviewed crash fix.

Revert part of 57320 that would remove NDEBUG in release builds for
DRT, etc.

  • WebKit.pri:
4:55 AM Changeset in webkit [57330] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Roll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.

4:51 AM WebKit2 edited by mrowe@apple.com
(diff)
4:47 AM WebKit2 edited by mjs@apple.com
(diff)
4:44 AM Changeset in webkit [57329] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

4:42 AM WebKit2 edited by mjs@apple.com
(diff)
4:30 AM Changeset in webkit [57328] by Csaba Osztrogonác
  • 4 edits in trunk/WebKitTools

Make DumpRenderTree parallelizable
​https://bugs.webkit.org/show_bug.cgi?id=36899

Reviewed by Eric Seidel.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

  • Scripts/run-webkit-tests:
    • Create a unique temporary directory and pass its path to DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.
4:26 AM chromium-webkit-stack.png attached to WebKit2 by mjs@apple.com
4:26 AM WebKit2 edited by mjs@apple.com
(diff)
4:14 AM WebKit2 edited by mjs@apple.com
(diff)
4:13 AM WebKit2 edited by mjs@apple.com
(diff)
4:12 AM webkit2-stack.png attached to WebKit2 by mjs@apple.com
webkit2-stack
4:12 AM mac-webkit-stack.png attached to WebKit2 by mjs@apple.com
mac-webkit-stack
3:55 AM Changeset in webkit [57327] by eric@webkit.org
  • 6 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compile error with QT_NO_ACTION
​https://bugs.webkit.org/show_bug.cgi?id=36529

Make sure QT_NO_ACTION is not defined to use QAction

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::pageAction):
  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::updatePositionDependentActions):
  • Api/qwebpage.h:
  • Api/qwebview.cpp:
  • Api/qwebview.h:
3:53 AM Changeset in webkit [57326] by mrowe@apple.com
  • 3 edits
    1 add in trunk

<​http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Wire up the script. Remove the three inappropriate

files from the Copy Bundle Resources build phase.

WebKitTools:

Add a script to detect the presence of inappropriate files in the frameworks. At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently. It can be extended to check the
other frameworks or for other inappropriate files in the future.

  • Scripts/check-for-inappropriate-files-in-framework: Added.
3:46 AM Changeset in webkit [57325] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Expose SecurityOrigin::canRequest in WebSecurityOrigin.
​https://bugs.webkit.org/show_bug.cgi?id=37271

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canRequest):
3:37 AM Changeset in webkit [57324] by eric@webkit.org
  • 8 edits in trunk

2010-04-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
​https://bugs.webkit.org/show_bug.cgi?id=37047

  • fast/canvas/webgl/error-reporting-expected.txt: Change a few errors from INVALID_OPERATION to INVALID_VALUE.
  • fast/canvas/webgl/getActiveTest-expected.txt: Ditto.
  • fast/canvas/webgl/null-object-behaviour-expected.txt: Ditto.
  • fast/canvas/webgl/script-tests/error-reporting.js: Ditto.

2010-04-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
​https://bugs.webkit.org/show_bug.cgi?id=37047

  • html/canvas/WebGLRenderingContext.cpp: Synthesize INVALID_VALUE error when input object is 0. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource):
  • html/canvas/WebGLRenderingContext.h: Add helper function to validate webgl object input parameters.
3:10 AM Changeset in webkit [57323] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] tests/qgraphicswebview fails
​https://bugs.webkit.org/show_bug.cgi?id=37317

Reviewed by Lars Knoll.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null.

3:06 AM Changeset in webkit [57322] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-04-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=37174

  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt: Added.
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Added.
  • fast/canvas/webgl/resources/utils3d.js: Add ContextAttributes parameter to initWebGL function.

2010-04-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

  • platform/graphics/mac/GraphicsContext3DMac.cpp: resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D):

2010-04-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

  • src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
3:00 AM ApplicationsGtk edited by scaroo@gmail.com
(diff)
2:48 AM Changeset in webkit [57321] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-09 Evan Stade <​estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] <select> dropdowns don't die when an item is selected
​https://bugs.webkit.org/show_bug.cgi?id=37243

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::notifyPopupHidden): (WebCore::PopupListBox::hidePopup): inform container that popup is closing
  • platform/chromium/PopupMenuChromium.h:
2:03 AM Changeset in webkit [57320] by Simon Hausmann
  • 6 edits in trunk

[Qt] Fix crashes with package builds in release

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

.:

  • WebKit.pri: Don't randomly add NDEBUG to the defines.

JavaScriptCore:

Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.

WebCore:

  • WebCore.pro: Don't add NDEBUG to the defines here, add it from JavaScriptCore.pri
1:59 AM Changeset in webkit [57319] by eric@webkit.org
  • 5 edits in trunk

2010-04-09 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Fraser.

Update test as the 'all' value has been removed

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-09 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Fraser.

Remove "all" value from the view-mode media feature (as agreed on
1-Apr-2010) in the Widgets voice conf.

  • css/CSSValueKeywords.in:
  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
1:36 AM Changeset in webkit [57318] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-04-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Implement NO_RETURN for COMPILER(MSVC).
​https://bugs.webkit.org/show_bug.cgi?id=33056

Added NO_RETURN_WITH_VALUE for functions with non-void return type.

  • jsc.cpp:
  • wtf/AlwaysInline.h:
  • wtf/FastMalloc.cpp:
1:21 AM WebKit2 edited by mjs@apple.com
(diff)
1:20 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:15 AM Changeset in webkit [57317] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57286.
​http://trac.webkit.org/changeset/57286
​https://bugs.webkit.org/show_bug.cgi?id=37312

"Caused intermittent test failures on all Mac bots."
(Requested by eseidel on #webkit).

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::getMaxSizeForDatabase): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp: (WebCore::SQLTransactionClient::didExecuteStatement):
1:06 AM WebKit2 edited by mjs@apple.com
(diff)
12:59 AM Changeset in webkit [57316] by abecsi@webkit.org
  • 7 edits in trunk

[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
​https://bugs.webkit.org/show_bug.cgi?id=37296

Reviewed by Simon Hausmann.
Patch by Andras Becsi <​abecsi@inf.u-szeged.hu>

WebCore:

Do not use moc to preprocess user agent style sheets because it removes at-symbols
and hexadecimal colours from declarations.
Remove unneeded preprocessor usage from make-css-file-arrays.pl since the script
processes default css files using regular expressions therefore preprocessing is redundant.

  • WebCore.pri: remove --preprocessor usage
  • css/make-css-file-arrays.pl: remove gcc dependency

LayoutTests:

Update expected files after removal of moc preprocessing of default css sheets.
These test results now only differ in metrics from Mac ones.

  • platform/qt/editing/execCommand/insert-list-xml-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
12:58 AM WebKit2 edited by mjs@apple.com
(diff)
12:35 AM Changeset in webkit [57315] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

12:33 AM Changeset in webkit [57314] by mrowe@apple.com
  • 1 copy in tags/Safari-533.4

New tag.

Apr 8, 2010:

11:43 PM Changeset in webkit [57313] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

2010-04-08 Chris Evans <​cevans@chromium.org>

Reviewed by Sam Weinig.

Add test for POST & _blank popup blocker bypass.
​https://bugs.webkit.org/show_bug.cgi?id=34541

  • fast/events/popup-blocked-to-post-blank.html: added
  • fast/events/popup-blocked-to-post-blank-expected.txt: added

2010-04-08 Chris Evans <​cevans@chromium.org>

Reviewed by Sam Weinig.

Use the new UserGestureIndictor for _blank POST requests.

​https://bugs.webkit.org/show_bug.cgi?id=34541

Test: fast/events/popup-blocked-to-post-blank.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Use UserGestureIndicator in more cases.
  • page/EventHandler.cpp: (WebCore::EventHandler): Impact from UserGestureIndicator API change. (WebCore::FrameLoader::submitForm): Block the load immediately if popups are not allowed and it would open a new window.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Note the UserGestureIndicator status at the time of submission. (WebCore::ScheduledFormSubmission::fire): Use the stored UserGestureIndicator status in the asynchronous callback.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): Add ability to store a negative indication.
6:14 PM Changeset in webkit [57312] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Add option to build WebKit2 to build-webkit.

Reviewed by Darin Adler.

  • Scripts/build-webkit:
5:52 PM Changeset in webkit [57311] by weinig@apple.com
  • 1 edit
    23 adds in trunk/WebKit2

Add build support for WebKit2.

Reviewed by Anders Carlsson.

  • Configurations: Added.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/FeatureDefines.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebKit2.xcconfig: Added.
  • English.lproj: Added.
  • English.lproj/InfoPlist.strings: Added.
  • Info.plist: Added.
  • Makefile: Added.
  • WebKit2.xcodeproj: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added.
  • WebKit2Prefix.cpp: Added.
  • WebKit2Prefix.h: Added.
  • WebKit2_Prefix.pch: Added.
  • WebProcess-Info.plist: Added.
  • version.plist: Added.
  • win: Added.
  • win/WebKit2.def: Added.
  • win/WebKit2.vcproj: Added.
  • win/WebKit2Generated.make: Added.
  • win/WebKit2Generated.vcproj: Added.
  • win/WebKit2WebProcess.vcproj: Added.
5:50 PM Changeset in webkit [57310] by weinig@apple.com
  • 1 edit
    73 adds in trunk/WebKit2

Add WebKit2/UIProcess directory.

Patch by Anders Carlsson <​andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.

  • UIProcess: Added.
  • UIProcess/API: Added.
  • UIProcess/API/C: Added.
  • UIProcess/API/C/WKAPICast.h: Added.
  • UIProcess/API/C/WKBase.h: Added.
  • UIProcess/API/C/WKContext.cpp: Added.
  • UIProcess/API/C/WKContext.h: Added.
  • UIProcess/API/C/WKFrame.cpp: Added.
  • UIProcess/API/C/WKFrame.h: Added.
  • UIProcess/API/C/WKFramePolicyListener.cpp: Added.
  • UIProcess/API/C/WKFramePolicyListener.h: Added.
  • UIProcess/API/C/WKPage.cpp: Added.
  • UIProcess/API/C/WKPage.h: Added.
  • UIProcess/API/C/WKPageNamespace.cpp: Added.
  • UIProcess/API/C/WKPageNamespace.h: Added.
  • UIProcess/API/C/WKPreferences.cpp: Added.
  • UIProcess/API/C/WKPreferences.h: Added.
  • UIProcess/API/C/WebKit2.h: Added.
  • UIProcess/API/mac: Added.
  • UIProcess/API/mac/PageClientImpl.h: Added.
  • UIProcess/API/mac/PageClientImpl.mm: Added.
  • UIProcess/API/mac/WKView.h: Added.
  • UIProcess/API/mac/WKView.mm: Added.
  • UIProcess/API/mac/WKViewInternal.h: Added.
  • UIProcess/API/win: Added.
  • UIProcess/API/win/WKAPICastWin.h: Added.
  • UIProcess/API/win/WKBaseWin.h: Added.
  • UIProcess/API/win/WKView.cpp: Added.
  • UIProcess/API/win/WKView.h: Added.
  • UIProcess/Launcher: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Added.
  • UIProcess/Launcher/mac: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
  • UIProcess/Launcher/win: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
  • UIProcess/PageClient.h: Added.
  • UIProcess/ProcessModel.h: Added.
  • UIProcess/ResponsivenessTimer.cpp: Added.
  • UIProcess/ResponsivenessTimer.h: Added.
  • UIProcess/ScriptReturnValueCallback.cpp: Added.
  • UIProcess/ScriptReturnValueCallback.h: Added.
  • UIProcess/WebContext.cpp: Added.
  • UIProcess/WebContext.h: Added.
  • UIProcess/WebFramePolicyListenerProxy.cpp: Added.
  • UIProcess/WebFramePolicyListenerProxy.h: Added.
  • UIProcess/WebFrameProxy.cpp: Added.
  • UIProcess/WebFrameProxy.h: Added.
  • UIProcess/WebLoaderClient.cpp: Added.
  • UIProcess/WebLoaderClient.h: Added.
  • UIProcess/WebPageNamespace.cpp: Added.
  • UIProcess/WebPageNamespace.h: Added.
  • UIProcess/WebPageProxy.cpp: Added.
  • UIProcess/WebPageProxy.h: Added.
  • UIProcess/WebPolicyClient.cpp: Added.
  • UIProcess/WebPolicyClient.h: Added.
  • UIProcess/WebPreferences.cpp: Added.
  • UIProcess/WebPreferences.h: Added.
  • UIProcess/WebProcessManager.cpp: Added.
  • UIProcess/WebProcessManager.h: Added.
  • UIProcess/WebProcessProxy.cpp: Added.
  • UIProcess/WebProcessProxy.h: Added.
  • UIProcess/WebUIClient.cpp: Added.
  • UIProcess/WebUIClient.h: Added.
  • UIProcess/mac: Added.
  • UIProcess/mac/DrawingAreaProxy.h: Added.
  • UIProcess/mac/DrawingAreaProxy.mm: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
  • UIProcess/win: Added.
  • UIProcess/win/DrawingAreaProxy.cpp: Added.
  • UIProcess/win/DrawingAreaProxy.h: Added.
  • UIProcess/win/WebView.cpp: Added.
  • UIProcess/win/WebView.h: Added.
5:49 PM Changeset in webkit [57309] by weinig@apple.com
  • 1 edit
    50 adds in trunk/WebKit2

Add WebKit2/WebProcess directory.

Patch by Anders Carlsson <​andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.

  • WebProcess: Added.
  • WebProcess/Launching: Added.
  • WebProcess/Launching/mac: Added.
  • WebProcess/Launching/mac/WebProcessMain.mm: Added.
  • WebProcess/Launching/win: Added.
  • WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
  • WebProcess/WebCoreSupport: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
  • WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebDragClient.h: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.h: Added.
  • WebProcess/WebCoreSupport/WebErrors.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
  • WebProcess/WebCoreSupport/mac: Added.
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
  • WebProcess/WebCoreSupport/win: Added.
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
  • WebProcess/WebPage: Added.
  • WebProcess/WebPage/DrawingArea.cpp: Added.
  • WebProcess/WebPage/DrawingArea.h: Added.
  • WebProcess/WebPage/WebFrame.cpp: Added.
  • WebProcess/WebPage/WebFrame.h: Added.
  • WebProcess/WebPage/WebPage.cpp: Added.
  • WebProcess/WebPage/WebPage.h: Added.
  • WebProcess/WebPage/mac: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/mac/WebPageMac.mm: Added.
  • WebProcess/WebPage/win: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/win/WebPageWin.cpp: Added.
  • WebProcess/WebProcess.cpp: Added.
  • WebProcess/WebProcess.h: Added.
  • WebProcess/win: Added.
  • WebProcess/win/DllMain.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.h: Added.
  • WebProcess/win/WebProcessMain.cpp: Added.
  • WebProcess/win/WebProcessMain.h: Added.
5:47 PM Changeset in webkit [57308] by weinig@apple.com
  • 1 edit
    24 adds in trunk/WebKit2

Add WebKit2/Shared directory.

Reviewed by Anders Carlsson.

  • Shared: Added.
  • Shared/CoreIPCSupport: Added.
  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
  • Shared/NotImplemented.h: Added.
  • Shared/WebCoreTypeArgumentMarshalling.h: Added.
  • Shared/WebEvent.h: Added.
  • Shared/WebEventConversion.cpp: Added.
  • Shared/WebEventConversion.h: Added.
  • Shared/WebPreferencesStore.cpp: Added.
  • Shared/WebPreferencesStore.h: Added.
  • Shared/mac: Added.
  • Shared/mac/UpdateChunk.cpp: Added.
  • Shared/mac/UpdateChunk.h: Added.
  • Shared/mac/WebEventFactory.h: Added.
  • Shared/mac/WebEventFactory.mm: Added.
  • Shared/win: Added.
  • Shared/win/UpdateChunk.cpp: Added.
  • Shared/win/UpdateChunk.h: Added.
  • Shared/win/WebEventFactory.cpp: Added.
  • Shared/win/WebEventFactory.h: Added.
5:46 PM Changeset in webkit [57307] by weinig@apple.com
  • 1 edit
    29 adds in trunk/WebKit2

Add WebKit2/Platform directory.

Reviewed by Anders Carlsson.

  • Platform: Added.
  • Platform/CoreIPC: Added.
  • Platform/CoreIPC/ArgumentDecoder.cpp: Added.
  • Platform/CoreIPC/ArgumentDecoder.h: Added.
  • Platform/CoreIPC/ArgumentEncoder.cpp: Added.
  • Platform/CoreIPC/ArgumentEncoder.h: Added.
  • Platform/CoreIPC/Arguments.h: Added.
  • Platform/CoreIPC/Attachment.cpp: Added.
  • Platform/CoreIPC/Attachment.h: Added.
  • Platform/CoreIPC/Connection.cpp: Added.
  • Platform/CoreIPC/Connection.h: Added.
  • Platform/CoreIPC/MessageID.h: Added.
  • Platform/CoreIPC/mac: Added.
  • Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
  • Platform/CoreIPC/mac/MachPort.h: Added.
  • Platform/CoreIPC/win: Added.
  • Platform/CoreIPC/win/ConnectionWin.cpp: Added.
  • Platform/PlatformProcessIdentifier.h: Added.
  • Platform/RunLoop.cpp: Added.
  • Platform/RunLoop.h: Added.
  • Platform/WorkItem.h: Added.
  • Platform/WorkQueue.cpp: Added.
  • Platform/WorkQueue.h: Added.
  • Platform/mac: Added.
  • Platform/mac/RunLoopMac.mm: Added.
  • Platform/mac/WorkQueueMac.cpp: Added.
  • Platform/win: Added.
  • Platform/win/RunLoopWin.cpp: Added.
5:37 PM Changeset in webkit [57306] by Darin Adler
  • 2 edits in trunk/WebKitTools

run-webkit-tests should respect argument order
​https://bugs.webkit.org/show_bug.cgi?id=37257

Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests: Changed so that sorting is done only

on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.

4:31 PM Changeset in webkit [57305] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[Chromium] Mark failing tests after r57292
​https://bugs.webkit.org/show_bug.cgi?id=37298

  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [57304] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Spatial Navigation: proper handle negative x or y coordinates ​https://bugs.webkit.org/show_bug.cgi?id=36773

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.

However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.

Test: fast/events/spatial-navigation/snav-offscreen-content.html

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

  • fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-offscreen-content.html: Added.
4:07 PM Changeset in webkit [57303] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.

  • platform/qt/Skipped: fast/forms/willvalidate-000.html removed.
3:59 PM Changeset in webkit [57302] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

WebView::isLoading should null check m_mainFrame
​https://bugs.webkit.org/show_bug.cgi?id=37294

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::isLoading):

3:55 PM Changeset in webkit [57301] by dumi@chromium.org
  • 5 edits in trunk

WebCore: Create the creation callback is the current world.
​https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • bindings/js/JSDatabaseCallback.cpp:

(WebCore::JSDatabaseCallback::JSDatabaseCallback):

LayoutTests: Test that the creation callback is executed in the world where it
was created.
​https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • storage/open-database-creation-callback-isolated-world-expected.txt:
  • storage/open-database-creation-callback-isolated-world.html:
3:39 PM Changeset in webkit [57300] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped:
    • fast/history/nested-visited-test.html skipped.
    • fast/history/self-is-visited.html skipped.
    • fast/history/sibling-visited-test.html skipped.
3:37 PM Changeset in webkit [57299] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Followup optimization to bug 24300, don't leak history info via CSS :visited. If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.

Reviewed by Oliver Hunt.

There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that. It just restores the optimization
that existed prior to the patch in 24300 landing.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):

3:36 PM WebKit2 edited by weinig@apple.com
(diff)
3:18 PM Changeset in webkit [57298] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Another trial

Tests that should have been landed as part of the earlier patch for Bug 36276.
​https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
3:18 PM WebKit2 created by weinig@apple.com
Initial chech-in.
3:17 PM Changeset in webkit [57297] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Caught by pixel tests. I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.

Reviewed by Oliver Hunt.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

3:16 PM WikiStart edited by weinig@apple.com
Add link to WebKit2 design doc (diff)
3:09 PM Changeset in webkit [57296] by weinig@apple.com
  • 2 adds in trunk/WebKit2

Rubber-stamped by Mark Rowe.

Add WebKit2 directory.

3:05 PM Changeset in webkit [57295] by yuzo@google.com
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Tests that should have been landed as part of the earlier patch for Bug 36276.
​https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
3:02 PM Changeset in webkit [57294] by hyatt@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

Fix Qt build.

2:48 PM Changeset in webkit [57293] by ojan@chromium.org
  • 22 edits
    1 delete in trunk/LayoutTests

2010-04-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Many new test results are needed due to recent check-ins.
​https://bugs.webkit.org/show_bug.cgi?id=36799

I missed the linux-only results in ​http://trac.webkit.org/changeset/57291

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
2:29 PM Changeset in webkit [57292] by hyatt@apple.com
  • 44 edits
    7 adds
    3 deletes in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.

Reviewed by Oliver Hunt.

This patch implements the policy described by David Baron here:

​http://dbaron.org/mozilla/visited-privacy

Added new tests in fast/history.

  • WebCore.base.exp:

Expose functions needed for the WebKit SPI used by layout tests.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.

  • platform/LinkHash.cpp:

(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintFocusRings):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp:

(WebCore::RenderPath::paint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):

  • rendering/style/RenderStyleConstants.h:

Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).

(WebCore::):

  • svg/graphics/SVGPaintServer.cpp:

(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.

WebKit/mac: ​https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

Add SPI so that layout tests can access computed style including :visited information.

  • WebView/WebRenderNode.mm:

(copyRenderNode):

  • WebView/WebView.mm:

(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

WebKitTools: ​https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for
obtaining computed style with :visited info included. This allows layout tests to actually tell that
:visited is in effect.

Reviewed by Oliver Hunt.

  • DumpRenderTree/LayoutTestController.cpp:

(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

  • fast/history/clicked-link-is-visited.html: Removed.
  • fast/history/nested-visited-test-expected.txt: Added.
  • fast/history/nested-visited-test.html: Added.
  • fast/history/resources/dummy.html: Added.
  • fast/history/self-is-visited-expected.txt: Added.
  • fast/history/self-is-visited.html: Added.
  • fast/history/sibling-visited-test-expected.txt: Added.
  • fast/history/sibling-visited-test.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Removed.
  • fast/history/subframe-is-visited.html: Removed.
2:09 PM Changeset in webkit [57291] by ojan@chromium.org
  • 33 edits
    4 deletes in trunk/LayoutTests

2010-04-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Daniel Bates.

[chromium] Many new test results are needed due to recent check-ins.
​https://bugs.webkit.org/show_bug.cgi?id=36799

Adds new results for all the tests that started failing after ​http://trac.webkit.org/changeset/57287.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
1:47 PM Changeset in webkit [57290] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-07 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
12:46 PM Changeset in webkit [57289] by dbates@webkit.org
  • 1 edit
    51 deletes in trunk/LayoutTests

2010-04-08 Daniel Bates <​dbates@rim.com>

No review, rolling out 56717.
​http://trac.webkit.org/changeset/56717
​https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56717
since we rolled out the change committed in change set 56655,
<​http://trac.webkit.org/changeset/56655> (in change set 57287,
<​http://trac.webkit.org/changeset/57287>). The change committed
in change set 56655 caused a layout test regression of the some
of the mozilla- and mozilla expected failure- tests. See bug #9268
for more details.

  • platform/qt/fast/table/table-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-background-expected.png: Removed.
  • platform/qt/fast/table/table-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.
12:42 PM Changeset in webkit [57288] by otte@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Fix build with MathML enabled.

  • GNUmakefile.am:
12:21 PM Changeset in webkit [57287] by dbates@webkit.org
  • 7 edits
    68 deletes in trunk

2010-04-08 Daniel Bates <​dbates@rim.com>

No review, rolling out 56655.
​http://trac.webkit.org/changeset/56655
​https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

2010-04-08 Daniel Bates <​dbates@rim.com>

No review, rolling out 56655.
​http://trac.webkit.org/changeset/56655
​https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • fast/table/table-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
  • fast/table/table-cell-overrides-row-background.html: Removed.
  • fast/table/table-col-background.html: Removed.
  • fast/table/table-col-group-background.html: Removed.
  • fast/table/table-col-group-col-span-background.html: Removed.
  • fast/table/table-col-group-span-background.html: Removed.
  • fast/table/table-col-span-background.html: Removed.
  • fast/table/table-row-background-left-50px.html: Removed.
  • fast/table/table-row-background-right-100percent.html: Removed.
  • fast/table/table-row-background-right-50px.html: Removed.
  • fast/table/table-row-background.html: Removed.
  • fast/table/table-row-group-background-positioned.html: Removed.
  • fast/table/table-row-group-background.html: Removed.
  • platform/mac/fast/table/table-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-background-expected.png: Removed.
  • platform/mac/fast/table/table-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.
11:40 AM Changeset in webkit [57286] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31482

  • storage/DatabaseTracker.cpp:

(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

11:11 AM Changeset in webkit [57285] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dimitri Glazkov.

A couple test expectations cleanups
​https://bugs.webkit.org/show_bug.cgi?id=37285

  • platform/chromium/test_expectations.txt:
9:57 AM BuildBot edited by wsiegrist@apple.com
webkit-dev is a better choice for bot discussions (diff)
9:35 AM Changeset in webkit [57284] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

Fix http.conf for GTK-Debug and Chromium-Linux bots
​https://bugs.webkit.org/show_bug.cgi?id=37279

  • http/conf/apache2-debian-httpd.conf:
9:23 AM Changeset in webkit [57283] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Replace max with std::max
​https://bugs.webkit.org/show_bug.cgi?id=37201

std::max is preferred.

  • platform/wince/FileSystemWince.cpp: (WebCore::makeAllDirectories): (WebCore::pathGetFileName):
9:08 AM Changeset in webkit [57282] by tonikitoo@webkit.org
  • 1 edit
    1 move
    1 add in trunk/WebCore

[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
​https://bugs.webkit.org/show_bug.cgi?id=36405

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

8:57 AM Changeset in webkit [57281] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-08 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Warnings when compiling InspectorClientQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37266

Add a default: for the switch()-case to avoid
warnings.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting):
8:27 AM Changeset in webkit [57280] by pfeldman@chromium.org
  • 14 edits in trunk

2010-04-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.

​https://bugs.webkit.org/show_bug.cgi?id=37267

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.removeEventDividers):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._updateMarks): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow.prototype.update):
  • inspector/front-end/inspector.css: (.resources-event-divider): (.resources-red-divider): (.resources-blue-divider): (.resources-orange-divider):
8:00 AM Changeset in webkit [57279] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fix a test for the behavior change by r57274.

  • fast/css/pseudo-invalid-novalidate-001.html:
7:43 AM Changeset in webkit [57278] by tonikitoo@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-05 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
​https://bugs.webkit.org/show_bug.cgi?id=29431

Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.

  • DumpRenderTree/LayoutTestController.cpp: (setScrollbarPolicyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setScrollbarPolicy):
7:38 AM Changeset in webkit [57277] by tonikitoo@webkit.org
  • 19 edits
    2 adds in trunk

2010-04-01 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by David Hyatt.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
​https://bugs.webkit.org/show_bug.cgi?id=29431

Test: fast/overflow/scrollbar-restored-and-then-locked.html

WebCore:

Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
as such, unless unset.

For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
are all optional, any previous code calling them do not need modification.

Two optional parameters were also added to Frame's createView method, for horizontal and vertical
lock state persistence cross page loads.

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::Frame::createView):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode):
  • platform/ScrollView.h: (WebCore::ScrollView::setHorizontalScrollbarLock): (WebCore::ScrollView::isHorizontalScrollbarLocked): (WebCore::ScrollView::setVerticalScrollbarLock): (WebCore::ScrollView::isVerticalScrollbarLocked): (WebCore::ScrollView::setScrollingModesLocked):

WebKit/qt:

Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.

Always added a qt auto test for set scrollbar policy feature.

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
  • tests/qwebframe/tst_qwebframe.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage):

WebKitTools:

Make possible to DRT to set scrollbar policies (on, off or auto).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • QtLauncher/main.cpp: (LauncherWindow::toggleScrollbars): (LauncherWindow::createChrome):

LayoutTests:

  • fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
  • fast/overflow/scrollbar-restored-and-then-locked.html: Added.
7:29 AM QtWebKitJournal edited by Henry Haverinen
(diff)
7:28 AM Changeset in webkit [57276] by yurys@chromium.org
  • 5 edits in trunk

2010-04-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Correctly save number of properties when object being serialized
have properties in its prorotype.

​https://bugs.webkit.org/show_bug.cgi?id=37263

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::ZigZag::Serializer::AbstractObjectState::advance):

2010-04-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that object with ptototype can be sent as message.

​https://bugs.webkit.org/show_bug.cgi?id=37263

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:
7:14 AM Changeset in webkit [57275] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2010-04-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Yury Semikhatsky.

IDB callbacks should fire asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=37265

Fix the firing behavior of the callbacks to not be synchronous.

There's still a major bug that I'm trying to track down that is keeping
us from testing this stuff. Promise lots of tests ASAP.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccessAsync): (WebCore::V8CustomIDBCallbacks::onErrorAsync):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks): (WebCore::IDBCallbacks::onSuccess): (WebCore::IDBCallbacks::onError): (WebCore::IDBCallbacks::timerFired):
  • storage/IndexedDatabaseRequest.cpp:
7:10 AM Changeset in webkit [57274] by tkent@chromium.org
  • 9 edits
    3 adds
    20 deletes in trunk

willValidate doesn't need to check existence of a form element and a name attribute.
​https://bugs.webkit.org/show_bug.cgi?id=34733

Reviewed by Darin Adler.

WebCore:

Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.

Test: fast/forms/willvalidate.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::formDestroyed):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInputType):

setNeedsWillValidateCheck() should be called before
setAttribute(valueAttr, ...) is called.

LayoutTests:

  • Merge willvalidate-00x tests into one file.
  • Update tests affected by the willValidate behavior change.
  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/willvalidate.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:
  • fast/forms/willvalidate-000-expected.txt: Removed.
  • fast/forms/willvalidate-000.html: Removed.
  • fast/forms/willvalidate-001-expected.txt: Removed.
  • fast/forms/willvalidate-001.html: Removed.
  • fast/forms/willvalidate-002-expected.txt: Removed.
  • fast/forms/willvalidate-002.html: Removed.
  • fast/forms/willvalidate-003-expected.txt: Removed.
  • fast/forms/willvalidate-003.html: Removed.
  • fast/forms/willvalidate-004-expected.txt: Removed.
  • fast/forms/willvalidate-004.html: Removed.
  • fast/forms/willvalidate-005-expected.txt: Removed.
  • fast/forms/willvalidate-005.html: Removed.
  • fast/forms/willvalidate-006-expected.txt: Removed.
  • fast/forms/willvalidate-006.html: Removed.
  • fast/forms/willvalidate-007-expected.txt: Removed.
  • fast/forms/willvalidate-007.html: Removed.
  • fast/forms/willvalidate-008-expected.txt: Removed.
  • fast/forms/willvalidate-008.html: Removed.
  • fast/forms/willvalidate-009-expected.txt: Removed.
  • fast/forms/willvalidate-009.html: Removed.
  • fast/forms/willvalidate-expected.txt: Added.
  • fast/forms/willvalidate.html: Added.
7:05 AM Changeset in webkit [57273] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-08 Young Han Lee <​joybro@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Add missing headers
​https://bugs.webkit.org/show_bug.cgi?id=37199

Include missing headers.

  • platform/graphics/wince/FontCustomPlatformData.cpp:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wince/ImageBufferWince.cpp:
  • platform/graphics/wince/PlatformPathWince.h:
  • platform/wince/FileSystemWince.cpp:
6:54 AM Changeset in webkit [57272] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-08 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Use WebCore::instanceHandle()
​https://bugs.webkit.org/show_bug.cgi?id=37202

Page::instanceHandle() is moved to WebCore::instanceHandle().

  • platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::Pasteboard):
  • platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
6:44 AM Changeset in webkit [57271] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-08 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Check if ARM or _ARM_ is defined
​https://bugs.webkit.org/show_bug.cgi?id=37200

MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.

  • wtf/Platform.h:
6:24 AM Changeset in webkit [57270] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-08 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] WebKit crashes while input text through input method.
The formatted text underline painting crashes when painting with invalid indexes.
​https://bugs.webkit.org/show_bug.cgi?id=36870

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat):
5:38 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:15 AM Changeset in webkit [57269] by vitalyr@chromium.org
  • 9 edits
    2 adds in trunk

2010-04-08 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
​https://bugs.webkit.org/show_bug.cgi?id=37234

Test: fast/dom/node-filter-detached-iframe-crash.html

  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Switched to using callFunctionWithoutFrame.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunctionWithoutFrame): Added a function to call V8 with no current frame.
  • bindings/v8/V8Proxy.h:

2010-04-08 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
​https://bugs.webkit.org/show_bug.cgi?id=37234

  • fast/dom/node-filter-detached-iframe-crash-expected.txt: Added.
  • fast/dom/node-filter-detached-iframe-crash.html: Added.
2:50 AM Changeset in webkit [57268] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Eric Seidel <​eric@webkit.org>

Unreviewed. Update test_expectations to account for tests which fail
when run out of order.

fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order.
​https://bugs.webkit.org/show_bug.cgi?id=37259

  • platform/mac/test_expectations.txt:
2:23 AM Changeset in webkit [57267] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Jarkko Sakkinen <​jarkko.sakkinen@tieto.com>

Reviewed by Simon Hausmann.

[Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37226

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::shaderSource):
2:13 AM Changeset in webkit [57266] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-08 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
​https://bugs.webkit.org/show_bug.cgi?id=36674

The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.

I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively):
1:59 AM Changeset in webkit [57265] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should give a percent complete indication
​https://bugs.webkit.org/show_bug.cgi?id=37258

Because it's awesome.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:26 AM Changeset in webkit [57264] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Adam Barth <​abarth@webkit.org>

Unreviewed. Update test_expectations to account for some tests that
fail when run out of order.

  • platform/mac/test_expectations.txt:
1:19 AM Changeset in webkit [57263] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-08 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG image with excessive nesting.
​https://bugs.webkit.org/show_bug.cgi?id=37247

  • fast/images/svg-nested.html: added
  • fast/images/svg-nested-expected.txt: added

2010-04-08 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Sanity: apply a max node depth to XML parsing.

​https://bugs.webkit.org/show_bug.cgi?id=37247

Test: fast/images/svg-nested.html

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Error out the parse upon a really large node depth.
1:16 AM Changeset in webkit [57262] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

Reviewed Oliver Hunt.

[Qt]r57240 broke Qt build (might be a gcc bug)
​https://bugs.webkit.org/show_bug.cgi?id=37253

Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.

  • wtf/PassRefPtr.h: Qt guards added.
1:04 AM Changeset in webkit [57261] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

cross-frame-access-put depends on test ordering
​https://bugs.webkit.org/show_bug.cgi?id=37254

If you run the tests in a different order, the value of this property
can change. We just need to avoid printing the actual value.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
12:54 AM Changeset in webkit [57260] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
​https://bugs.webkit.org/show_bug.cgi?id=37104

Turns out the CYGWIN also uses Apache 1.3, so can't bind to ::1 either.

  • http/conf/cygwin-httpd.conf:
12:51 AM Changeset in webkit [57259] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, cleaning up Chromium Mac test expecatations for fast/media.

  • platform/chromium/test_expectations.txt:
12:49 AM Changeset in webkit [57258] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-08 Adam Barth <​abarth@webkit.org>

Unreviewed.

Add back the --target option because it's needed by the downstream
Chromium bots.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:45 AM Changeset in webkit [57257] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should understand set-webkit-configuration
​https://bugs.webkit.org/show_bug.cgi?id=37252

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:27 AM Changeset in webkit [57256] by abarth@webkit.org
  • 15 edits in trunk/WebKitTools

2010-04-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
​https://bugs.webkit.org/show_bug.cgi?id=37251

The rest of our tools call --debug or --release the configuration.
It's confusing to call it target in this script.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
12:19 AM Changeset in webkit [57255] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, cleaning up test expectations for fast/media and media/video-played-reset.html.

Previously all of fast/media was marked as PASS FAIL, but now has finer-grained
expectations for all tests.

Due to Chromium-side changes, media/video-played-reset.html is now passing again.

  • platform/chromium/test_expectations.txt:

Apr 7, 2010:

11:56 PM Changeset in webkit [57254] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove depricated op.popen2 call in new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=37249

Python complains that this API is depricated. We already solved this
problem in executive.py.

  • Scripts/webkitpy/layout_tests/port/mac.py:
11:55 PM Changeset in webkit [57253] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests crashes when run on a 64-bit machine
​https://bugs.webkit.org/show_bug.cgi?id=37248

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.
11:51 PM Changeset in webkit [57252] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
​https://bugs.webkit.org/show_bug.cgi?id=37145

I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.

  • transitions/transition-end-event-set-none.html:
11:40 PM QtWebKit edited by Henry Haverinen
(diff)
11:13 PM Changeset in webkit [57251] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

(Not reviewed.)

Random demo to look cool on twitter.

  • misc/gradient-input.html: Added.
11:03 PM Changeset in webkit [57250] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
​https://bugs.webkit.org/show_bug.cgi?id=37104

Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
and add a warning about how that may cause flakiness on systems which
use Apache 1.3, but support IPv6.

  • http/conf/httpd.conf:
10:00 PM Changeset in webkit [57249] by abarth@webkit.org
  • 9 edits in trunk

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
​https://bugs.webkit.org/show_bug.cgi?id=37104

WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
addreses when IPv6 is enabled. Since DNS lookup returns addresses in random
order, we would occasionally fail to make connections to "localhost" addresses
if the various network re-tries all happen to resolve to the IPv6 loopback.

To make matters worse, the kernel has a connection reset throttle which we
could trigger if we would repeatedly attempt to connect to ::1 and fail.
The trottle would cause a 1 or 2 second delay on the connection, sometimes
causing slow tests to time out.

I also discovered during this investigation that we have some partial support
for specifying our apache port numbers at runtime. The support is already incomplete
by not accounting for WebSockets or SSL ports. This fix will make our partial
support for dynamic apache port numbers even more broken.

I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
platforms (except cygwin which does not have the 8443 directive to begin with).

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
​https://bugs.webkit.org/show_bug.cgi?id=37104

Add warnings that the partial support for specifying what port numbers
apache should bind to is even more broken after this fix.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
9:35 PM Changeset in webkit [57248] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Vector<UString> makes many needless calls to UString::UString and UString::~UString

Reviewed by Anders Carlsson.

Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.

  • runtime/UString.h:

(WTF::):

9:12 PM Changeset in webkit [57247] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
​https://bugs.webkit.org/show_bug.cgi?id=37190

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
9:11 PM Changeset in webkit [57246] by mitz@apple.com
  • 5 edits in trunk/WebKit/mac

Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
​https://bugs.webkit.org/show_bug.cgi?id=37246

Reviewed by Adele Peterson.

  • Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
  • Misc/WebNSPrintOperationExtras.m:

(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,

-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.

6:18 PM Changeset in webkit [57245] by dumi@chromium.org
  • 9 edits in trunk/WebCore

Fix Chromium's HTML5 DB support in --single-process mode.
​https://bugs.webkit.org/show_bug.cgi?id=37186.

Reviewed by Jeremy Orlow.

Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.

Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/SQLiteFileSystem.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):

5:38 PM Changeset in webkit [57244] by cmarrin@apple.com
  • 7 edits
    3 deletes in trunk

Remove QuartzCoreInterface from the build


No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).

5:32 PM Changeset in webkit [57243] by ojan@chromium.org
  • 2 edits
    2 deletes in trunk

2010-04-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57178.
​http://trac.webkit.org/changeset/57178
​https://bugs.webkit.org/show_bug.cgi?id=37240

Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
4:52 PM Changeset in webkit [57242] by ojan@chromium.org
  • 5 edits
    4 adds in trunk/LayoutTests

2010-04-07 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

New chromium expected results after r57215
​https://bugs.webkit.org/show_bug.cgi?id=37239

  • platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-linux/fast/text/line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/line-breaks-expected.png:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt: Our new behavior is no more broken than the old behavior. Evan says he'll fix the underlying problem some day.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added. This is a new test. These are just the usual windows vs. mac font rendering differences.
  • platform/chromium/test_expectations.txt:
4:49 PM Changeset in webkit [57241] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
​https://bugs.webkit.org/show_bug.cgi?id=37235

Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.

  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
4:06 PM Changeset in webkit [57240] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull

Reviewed by Geoff Garen.

  • wtf/PassRefPtr.h:
4:04 PM Changeset in webkit [57239] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Add the comment and assert that we're generating version 4 random number
based UUIDs.
​https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Adam Barth and Dmitry Titov.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

  • platform/UUID.h:
3:59 PM Changeset in webkit [57238] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-07 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
​https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

  • http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
  • http/tests/security/local-image-from-remote-whitelisted.html: Added.

2010-04-07 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
​https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

Test: http/tests/security/local-image-from-remote-whitelisted.html

  • page/OriginAccessEntry.cpp: (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching. (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
  • page/SecurityOrigin.h: Add private function isAccessWhiteListed
3:43 PM Changeset in webkit [57237] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
​https://bugs.webkit.org/show_bug.cgi?id=37235

Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
that these tests use, and call it to clear the cookies before leaving the test.

I could not resist the temptation of cleaning up the ridiculously awful copy/paste
in these tests, so the changes are larger than strictly necessary.

  • http/tests/xmlhttprequest/cookies.html:
  • http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
2:53 PM Changeset in webkit [57236] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-07 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Adding static method zero() to classes IntPoint and FloatPoint.
​https://bugs.webkit.org/show_bug.cgi?id=37220

Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::zero):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::zero): (WebCore::IntPoint::clampNegativeToZero):
2:32 PM Changeset in webkit [57235] by ap@apple.com
  • 2 edits in trunk/WebCore
  • platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
2:30 PM Changeset in webkit [57234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-07 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default. (create3DContext):
  • fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.
2:25 PM Changeset in webkit [57233] by ap@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo.

2:25 PM Changeset in webkit [57232] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darinn Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37230
<rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
authenticating to Windows IIS Server

  • platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added a constant for ProtectionSpaceAuthenticationSchemeUnknown.
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
  • platform/network/mac/AuthenticationMac.mm: (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from NSURLConnection, even though there was no public constant. (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
2:20 PM Changeset in webkit [57231] by eric@webkit.org
  • 17 edits in trunk

2010-04-07 Jaime Yap <​jaimeyap@google.com>

Reviewed by Pavel Feldman.
Tests expectations changed due to the addition of the function symbol name for
the call location for records sent by the InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • inspector/timeline-test.js:
  • platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
  • platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
  • platform/chromium-win/inspector/timeline-network-resource-expected.txt:
  • platform/chromium-win/inspector/timeline-paint-expected.txt:
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:

2010-04-07 Jaime Yap <​jaimeyap@google.com>

Reviewed by Pavel Feldman.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::topStackFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
2:10 PM Changeset in webkit [57230] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Add test for a popup related crasher.
​https://bugs.webkit.org/show_bug.cgi?id=37141

  • platform/chromium/fast/forms: Added.
  • platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
  • platform/chromium/fast/forms/search-popup-crasher.html: Added.

2010-04-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Fixing a NULL pointer being dereferenced in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=37141

Test: platform/chromium/fast/forms/search-popup-crasher.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::~PopupMenu):
1:47 PM Changeset in webkit [57229] by jianli@chromium.org
  • 8 edits
    3 copies in trunk/WebCore

Add skeleton FileStream module for providing sync file operations for FileAPI
​https://bugs.webkit.org/show_bug.cgi?id=37217

Patch by Kinuko Yasuda <​kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.

For now the module just defines an interface and is almost empty.
Implementation will be added.

No new tests; will be added when we have complete implementation.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: Added.
  • html/FileStream.h: Added.
  • html/FileStreamClient.h: Added.
  • html/FileThread.cpp:

(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):

  • html/FileThread.h:

(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):

1:44 PM Changeset in webkit [57228] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Poor rendering on lala.com with frame flattening
​https://bugs.webkit.org/show_bug.cgi?id=37164

Platform specific expected files added for test introduced in r57225.

  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
1:37 PM Changeset in webkit [57227] by oliver@apple.com
  • 5 edits in trunk/WebCore

2010-04-07 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Remove some unnecessary uses of commonJSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=37229

Pass the ExecState down to identifierFromNPIdentifier and update call sites

  • bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
  • bridge/c/c_utility.cpp: (JSC::Bindings::identifierFromNPIdentifier):
  • bridge/c/c_utility.h:
1:32 PM Changeset in webkit [57226] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-07 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Replace isprint with isASCIIPrintable
​https://bugs.webkit.org/show_bug.cgi?id=37223

WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.

  • pcre/pcre_exec.cpp: (pchars):
1:22 PM Changeset in webkit [57225] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-04-07 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Darin Adler.

Poor rendering on lala.com with frame flattening
​https://bugs.webkit.org/show_bug.cgi?id=37164

Do not flatten offscreen iframes.

Test: fast/frames/flattening/iframe-flattening-offscreen.html

  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::flattenFrame):
  • rendering/RenderPartObject.h:
12:57 PM BuildBot edited by wsiegrist@apple.com
update contact and port (diff)
12:49 PM Changeset in webkit [57224] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-07 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Make sure that calling bindings constructors as function does not result in crash.

  • fast/constructors: Added.
  • fast/constructors/constructor-as-function-crash-expected.txt: Added.
  • fast/constructors/constructor-as-function-crash.html: Added.

2010-04-07 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

[V8] Add a missing check for constructor call in WebKitPointConstructor.
​https://bugs.webkit.org/show_bug.cgi?id=37210

Test: fast/constructors/constructor-as-function-crash.html

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.
12:17 PM Changeset in webkit [57223] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

2010-04-07 Ojan Vafai <​ojan@chromium.org>

Reviewed by Simon Fraser.

Make tests pass with tolerance=0 after r57215
​https://bugs.webkit.org/show_bug.cgi?id=37225

  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:
11:54 AM Changeset in webkit [57222] by scherkus@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2010-04-07 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.

Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
to pass this layout test.

  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.
11:44 AM Changeset in webkit [57221] by enrica@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm

Fixing TIGER build (take 2)

11:16 AM Changeset in webkit [57220] by pfeldman@chromium.org
  • 3 edits
    5 adds in trunk/WebKit/chromium

2010-04-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: support themes in devtools window.

​https://bugs.webkit.org/attachment.cgi?bugid=37216

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors):
  • src/js/Images/segmentChromium2.png: Added.
  • src/js/Images/segmentHoverChromium2.png: Added.
  • src/js/Images/segmentSelectedChromium2.png: Added.
  • src/js/Images/statusbarBackgroundChromium2.png: Added.
  • src/js/Images/statusbarMenuButtonChromium2.png: Added.
11:12 AM Changeset in webkit [57219] by scherkus@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2010-04-07 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in missing image baselines for fast/layers/video-layer.html

  • platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
  • platform/chromium-win/fast/layers/video-layer-expected.png: Updated.
10:59 AM Changeset in webkit [57218] by enrica@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37219

Reviewed by Darin Adler.

JavaScriptCore:

This change disables text caret for the iPhone platflorm.

  • wtf/Platform.h: Disabled text caret for iPhone.

WebCore:

This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):

  • page/Frame.cpp:

(WebCore::Frame::paintDragCaret):

10:57 AM Changeset in webkit [57217] by enrica@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm

Fixing TIGER build

10:06 AM Changeset in webkit [57216] by enrica@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<​https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
10:01 AM Changeset in webkit [57215] by enrica@apple.com
  • 42 edits
    2 moves
    4 adds in trunk

WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<​https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.

The original version of this patch has been written by Dan Bernstein.

Test: fast/repaint/stacked-diacritics.html

  • Android.mk: File name change.
  • GNUmakefile.am: File name change.
  • WebCore.base.exp: Added parameter in exported function.
  • WebCore.gypi: File name change.
  • WebCore.vcproj/WebCore.vcproj: File name change.
  • WebCore.xcodeproj/project.pbxproj: File name change.
  • platform/graphics/Font.cpp:

(WebCore::Font::floatWidth): Added glyphOverflow parameter.

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.

  • platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.

(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.

  • platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.

(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):

  • platform/graphics/GlyphWidthMap.cpp: Removed.
  • platform/graphics/GlyphWidthMap.h: Removed.
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):

  • platform/graphics/cairo/SimpleFontDataCairo.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange

  • platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::floatWidthForComplexText): Name and signature change.

  • platform/graphics/gtk/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::metricsForGDIGlyph):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):

  • platform/graphics/wince/FontWince.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/FontWx.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):

  • rendering/RenderText.h:

LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<​https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
9:53 AM Changeset in webkit [57214] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Fix incorrect white-space in WebGLRenderingContext.idl
​https://bugs.webkit.org/show_bug.cgi?id=31339

  • html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.
9:43 AM Changeset in webkit [57213] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-07 Rodrigo Belem <​rodrigo.belem@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
​https://bugs.webkit.org/show_bug.cgi?id=37173

This patch sets the correct path to the classheaders.pri and then
fixes the installation of the generated headers.

  • WebCore.pro:
9:33 AM Changeset in webkit [57212] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-07 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add ewk_view (the high level object to acces the WebKit-EFL browser
component) to efl/ewk.
​http://webkit.org/b/35932

  • efl/ewk/ewk_view.cpp: Added.
  • efl/ewk/ewk_view.h: Added.
9:32 AM Changeset in webkit [57211] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable ​https://bugs.webkit.org/show_bug.cgi?id=37135

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusableNodeInDirection):

9:18 AM Changeset in webkit [57210] by eric@webkit.org
  • 44 edits in trunk

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:
  • loader/ResourceLoadNotifier.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): (WebCore::WorkerContext::addMessage):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
  • src/WebWorkerClientImpl.h:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-04-07 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
​https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:
8:52 AM Changeset in webkit [57209] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-07 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] WebIDBDatabaseError::assign doesn't work correctly
​https://bugs.webkit.org/show_bug.cgi?id=37209

  • src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):
7:14 AM Changeset in webkit [57208] by Simon Hausmann
  • 7 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=36827

Patch by Dawit Alemayehu <​adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.

WebCore:

Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.

See comments 39-42 in ​https://bugs.webkit.org/show_bug.cgi?id=36395

  • platform/network/HTTPParsers.cpp:

(WebCore::contentDispositionType):

  • platform/network/HTTPParsers.h:

(WebCore::):

WebKit/chromium:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in ​https://bugs.webkit.org/show_bug.cgi?id=36395

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

WebKit/qt:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in ​https://bugs.webkit.org/show_bug.cgi?id=36395

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

7:04 AM Changeset in webkit [57207] by vitalyr@chromium.org
  • 10 edits in trunk/WebCore

2010-04-07 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Throw exception in SerializedScriptValue on input errors
​https://bugs.webkit.org/show_bug.cgi?id=37160

When cycles are detected SerializedScriptValue should throw
NOT_SUPPORTED_ERR. See
​http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone

  • bindings/scripts/CodeGeneratorV8.pm: Custom processing for function arguments of type SerializedScriptValue.
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): Added a constructor function with an extra paratemer to check whether an exception was thrown.

SerializedScriptValue::create callers updated to check for
exceptions:

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
  • bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
6:10 AM Changeset in webkit [57206] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-04-07 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Provide a placeholder for resources with no content available
​https://bugs.webkit.org/show_bug.cgi?id=37142

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView): (WebInspector.ImageView.prototype.contentTabSelected):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype.contentTabSelected):
  • inspector/front-end/inspector.css: (.resource-content-unavailable):
5:48 AM Changeset in webkit [57205] by Simon Hausmann
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
5:03 AM Changeset in webkit [57204] by Simon Hausmann
  • 4 edits in trunk/WebCore

Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.

Reviewed by Holger Freyther.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
4:39 AM Changeset in webkit [57203] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2010-04-06 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

V8CustomIDBCallbacks<> should not hold a reference to the frame
​https://bugs.webkit.org/show_bug.cgi?id=37154

Don't hold on to a Frame reference.
Instead, be an ActiveDOMObject and use scriptExecutionContext()
to get the v8 context.
Factor the guts of onSuccess and onError out.

Doesn't work enough to test yet.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onEvent):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks):
4:14 AM Changeset in webkit [57202] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-07 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] When providing a widget for the PDF mime type it will cause a crash

m_pluginView may actually be a Widget (for embedded Qt widgets),
so always check isPluginView() before calling PluginView specific methods.

​https://bugs.webkit.org/show_bug.cgi?id=29450

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad):
3:19 AM Changeset in webkit [57201] by eric@webkit.org
  • 12 edits in trunk

2010-04-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
​http://trac.webkit.org/changeset/57196
​https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • inspector/timeline-test.js:

2010-04-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
​http://trac.webkit.org/changeset/57196
​https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext): (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::utilityContext):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
3:07 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
(diff)
2:19 AM Changeset in webkit [57200] by Simon Hausmann
  • 4 edits in trunk/WebCore

Unreviewed, rolling out r57199.
​http://trac.webkit.org/changeset/57199
​https://bugs.webkit.org/show_bug.cgi?id=36750

Breaks non-touch enabled build

  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
2:08 AM Changeset in webkit [57199] by Simon Hausmann
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
1:15 AM Changeset in webkit [57198] by eric@webkit.org
  • 2 edits in trunk

2010-04-07 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
12:39 AM Changeset in webkit [57197] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-07 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

Add createApplicationCacheHost to WebFrameClient so
the ApplicationCacheHost has access to its frame.

​https://bugs.webkit.org/show_bug.cgi?id=36882

  • public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
12:20 AM Changeset in webkit [57196] by eric@webkit.org
  • 12 edits in trunk

2010-04-07 Jaime Yap <​jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds callerFuncName to the list of nondeterministic fields in the timeline
layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=36839

  • inspector/timeline-test.js:

2010-04-07 Jaime Yap <​jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::lastCallFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):

Apr 6, 2010:

11:40 PM Changeset in webkit [57195] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch command to crawl buildbot history and find when tests
started to fail.
​https://bugs.webkit.org/show_bug.cgi?id=36911

This is a very bare-bones implementation, which works, but isn't pretty.
We will need further re-factoring and improvement to this code, but
after long discussions with Adam, I think it's best that we land this
and iterate from there.

  • Scripts/webkitpy/common/net/buildbot.py:
    • Add revision_build_pairs_with_results for cleaner code and possible optimization of this command.
    • Return None if a build number can't be found for a revision in build_for_revision
    • Separate out suspect_revisions_for_transition for re-use by FailureReason
    • Add LayoutTestResults.failing_tests() and make our parsing code explict about what tables it accepts.
  • Scripts/webkitpy/tool/commands/queries.py:
    • Move _print_blame_information_for_commit out of WhatBroke for re-use by FailureReason.
    • Add FailureReason command which can crawl a given builder and explain why it is currently red on a per-test basis.
10:14 PM Changeset in webkit [57194] by bolsinga@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.

Reviewed by Darin Adler.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.

  • page/Geolocation.h:

(WebCore::Geolocation::): Ditto.

9:58 PM Changeset in webkit [57193] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Remove obsolete MOBILE flag
​https://bugs.webkit.org/show_bug.cgi?id=37125

The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.

No new tests as there is no new functionality.

  • config.h:
  • html/HTMLTokenizer.cpp:
9:38 PM Changeset in webkit [57192] by eric@webkit.org
  • 19 edits
    1 copy
    3 adds in trunk

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
​https://bugs.webkit.org/show_bug.cgi?id=36646

Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.

  • GNUmakefile.am:
    • Added new Terminator.h file.
  • JavaScriptCore.gypi:
    • Added new Terminator.h file.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Added new Terminator.h file.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new Terminator.h file.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException):
    • Fully unwind the stack for TerminatedExecutionException.

(JSC::Interpreter::privateExecute):

  • Check if we've been terminated at the same time we check if we've timed out.
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
    • Check if we've been terminated at the same time we check if we've timed out.
  • runtime/Completion.cpp:
    • Some exceptions define special completion types so that calls can see why we terminated evaluation.

(JSC::evaluate):

  • runtime/Completion.h:
    • Define a new completion type for termination.

(JSC::):

  • runtime/ExceptionHelpers.cpp:
    • Define TerminatedExecutionException and refactor pseudo-RTTI virtual function to be more semantic.

(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):

  • runtime/ExceptionHelpers.h:
    • Entry point for generating a TerminatedExecutionException.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
    • Add a Terminator object that can be used to asynchronously terminate a JavaScript execution stack.
  • runtime/JSGlobalData.h:
  • runtime/JSObject.h: (JSC::JSObject::exceptionType):
    • Define that, by default, thrown objects have a normal exception type.
  • runtime/Terminator.h: Added.
    • Added a new controller object that can be used to terminate execution asynchronously. This object is more or less a glorified bool.

(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
​https://bugs.webkit.org/show_bug.cgi?id=36646

  • fast/workers/resources/worker-run-forever.js: Added.
  • fast/workers/worker-terminate-forever-expected.txt: Added.
  • fast/workers/worker-terminate-forever.html: Added.
    • Test what happens when we terminate an infinitely running worker. The essential point is that we don't spam the console with nonsense about a timeout.
  • platform/mac/Skipped:
    • Rescue worker-terminate.html from the Skipped list now that we've fixed the underlying bug that was causing the flakiness.

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
​https://bugs.webkit.org/show_bug.cgi?id=36646

Cause the worker code to swallow termination exceptions because these
need not be reported to the user because they are an implementation
detail of how we terminate worker execution.

Test: fast/workers/worker-terminate-forever.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
    • Refuse to report termination exceptions to the user because they are an implementation detail.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::forbidExecution):
    • Instead of using timeouts to stop run away workers, use our fancy new Terminator object.
9:17 PM Changeset in webkit [57191] by eric@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

2010-04-06 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Seidel.

Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
​https://bugs.webkit.org/show_bug.cgi?id=37180

  • platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
  • platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
  • platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
  • platform/chromium/test_expectations.txt: Removed expectations for the above two tests.
8:10 PM Changeset in webkit [57190] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
7:54 PM Changeset in webkit [57189] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
7:39 PM Changeset in webkit [57188] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-04-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
​https://bugs.webkit.org/show_bug.cgi?id=37137

  • Add DumpRenderTree.gyp
  • Remove some dependencies to base/string_util.h, base/compiler_specific.h, base/file_path.h, base/file_util.h, base/message_loop.h, base/sys_string_conversions.h,
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
  • DumpRenderTree/chromium/CppVariant.cpp: (CppVariant::toStringVector):
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::keyDown): (EventSender::scheduleAsynchronousClick): (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): (TextInputController::selectedRange):
7:33 PM Changeset in webkit [57187] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Write stack traces into the results directory for new-run-webkit-tests,
instead of writing them alongside the test file.

​https://bugs.webkit.org/show_bug.cgi?id=36504

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
7:29 PM Changeset in webkit [57186] by abarth@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-06 Adam Barth <​abarth@webkit.org>

Unreviewed.

Speculative build fix for Tiger.

  • WebView/WebHTMLViewPrivate.h:
7:27 PM Changeset in webkit [57185] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-06 Dirk Pranke <​dpranke@chromium.org>

Unreviewed build fix.

Enable pixel tests by default in new-run-webkit-tests unless
explicitly set by the port or by the command line. This was broken in
the fix for bug 36801 (rev. 57173).

​https://bugs.webkit.org/show_bug.cgi?id=37184

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6:53 PM Changeset in webkit [57184] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Expose WebHTMLView’s page breaking logic as SPI.

Reviewed by Sam Weinig and Anders Carlsson.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:

  • WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
6:40 PM Changeset in webkit [57183] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Add an #if in order to make Tiger happy.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

6:29 PM Changeset in webkit [57182] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
​https://bugs.webkit.org/show_bug.cgi?id=36938

No new tests; will be added when we implement upper layers.

  • platform/FileSystem.h: (WebCore::):
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::writeToFile): (WebCore::readFromFile):
6:15 PM Changeset in webkit [57181] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.

6:02 PM Changeset in webkit [57180] by eric@webkit.org
  • 6 edits in trunk

2010-04-06 Nicolas Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Implement DragImage functionality for chromium/mac.
​https://bugs.webkit.org/show_bug.cgi?id=37069

  • page/chromium/DragControllerChromium.cpp: (WebCore::DragController::maxDragImageSize): Use a max size of 400x400 on OS X.
  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::dragImageSize): Implement. (WebCore::deleteDragImage): Implement. (WebCore::scaleDragImage): Implement. (WebCore::dissolveDragImageToFraction): Implement. (WebCore::createDragImageFromImage): Implement.
  • platform/chromium/DragImageRef.h: Use CGImageRefs as DragImageRef on OS X.

2010-04-06 Nicolas Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Use drag images on OS X as well.
​https://bugs.webkit.org/show_bug.cgi?id=37069

  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
4:37 PM Changeset in webkit [57179] by mrowe@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<​http://webkit.org/b/37156> / <rdar://problem/7832408>

Rubber-stamped by Oliver Hunt.

Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html. <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.

  • platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.
4:36 PM Changeset in webkit [57178] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-06 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add test for javascript:window.open() popup blocker bypass.
​https://bugs.webkit.org/show_bug.cgi?id=37138

  • fast/events/popup-blocked-from-window-open.html: added
  • fast/events/popup-blocked-from-window-open-expected.txt: added

2010-04-06 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Use the new UserGestureIndictor to process javascript:window.open()

​https://bugs.webkit.org/show_bug.cgi?id=37138

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()
4:27 PM Changeset in webkit [57177] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
​https://bugs.webkit.org/show_bug.cgi?id=37145

The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.

The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.

I'll file a separate bug about DRT leaking state from one test to
another.

  • transitions/transition-end-event-helpers.js:
  • transitions/transition-end-event-set-none.html:
4:17 PM Changeset in webkit [57176] by eric@webkit.org
  • 11 edits in trunk

2010-04-06 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
in a subsequent CL.
​https://bugs.webkit.org/show_bug.cgi?id=37116

No new functionality so no new tests.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/skia/GraphicsLayerSkia.cpp: (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::nativeLayer): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setPosition): (WebCore::GraphicsLayerChromium::setAnchorPoint): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::setChildrenTransform): (WebCore::GraphicsLayerChromium::setPreserves3D): (WebCore::GraphicsLayerChromium::setMasksToBounds): (WebCore::GraphicsLayerChromium::setDrawsContent): (WebCore::GraphicsLayerChromium::setBackgroundColor): (WebCore::GraphicsLayerChromium::clearBackgroundColor): (WebCore::GraphicsLayerChromium::setContentsOpaque): (WebCore::GraphicsLayerChromium::setBackfaceVisibility): (WebCore::GraphicsLayerChromium::setOpacity): (WebCore::GraphicsLayerChromium::setNeedsDisplay): (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): (WebCore::GraphicsLayerChromium::setContentsRect): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToVideo): (WebCore::GraphicsLayerChromium::setGeometryOrientation): (WebCore::GraphicsLayerChromium::hostLayerForSublayers): (WebCore::GraphicsLayerChromium::layerForSuperlayer): (WebCore::GraphicsLayerChromium::platformLayer): (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): (WebCore::GraphicsLayerChromium::setDebugBorder): (WebCore::GraphicsLayerChromium::updateSublayerList): (WebCore::GraphicsLayerChromium::updateLayerPosition): (WebCore::GraphicsLayerChromium::updateLayerSize): (WebCore::GraphicsLayerChromium::updateAnchorPoint): (WebCore::GraphicsLayerChromium::updateTransform): (WebCore::GraphicsLayerChromium::updateChildrenTransform): (WebCore::GraphicsLayerChromium::updateMasksToBounds): (WebCore::GraphicsLayerChromium::updateContentsOpaque): (WebCore::GraphicsLayerChromium::updateBackfaceVisibility): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): (WebCore::GraphicsLayerChromium::updateContentsImage): (WebCore::GraphicsLayerChromium::updateContentsVideo): (WebCore::GraphicsLayerChromium::updateContentsRect): (WebCore::GraphicsLayerChromium::updateGeometryOrientation): (WebCore::GraphicsLayerChromium::setupContentsLayer): (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
  • platform/graphics/skia/GraphicsLayerSkia.h: (WebCore::GraphicsLayerChromium::primaryLayer): (WebCore::GraphicsLayerChromium::contentsLayer):
  • platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::updateLayerContents): (WebCore::LayerRendererChromium::drawLayersInCanvas): (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive): (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
  • platform/graphics/skia/LayerRendererSkia.h: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::rootLayer):
  • platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::addSublayer): (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::indexOfSublayer): (WebCore::LayerChromium::setBackingStoreRect): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers): (WebCore::LayerChromium::setSuperlayer): (WebCore::LayerChromium::superlayer): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/skia/LayerSkia.h: (WebCore::LayerChromium::setAnchorPoint): (WebCore::LayerChromium::anchorPoint): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::frame): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::position): (WebCore::LayerChromium::zPosition): (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setSublayerTransform): (WebCore::LayerChromium::sublayerTransform): (WebCore::LayerChromium::setTransform): (WebCore::LayerChromium::transform):

2010-04-06 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Changing references to Graphics Layer related classes from *Skia to *Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=37116

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
4:04 PM Changeset in webkit [57175] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] These tests can be removed from the skipped list since these
work after the redirection loop detection implemented in qt network.
​https://bugs.webkit.org/show_bug.cgii?id=36690

  • platform/qt/Skipped:
3:55 PM Changeset in webkit [57174] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-06 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] WebKit does not build on Windows with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=37026

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform):
3:47 PM Changeset in webkit [57173] by dpranke@chromium.org
  • 6 edits in trunk/WebKitTools

2010-04-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Disable pixel tests on the mac port by default.

Also, revamp the way we check for pixel tests being enabled or
disabled. We now look for options.pixel_tests instead of
options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
and "--no-pixel-tests" (force disable) flags.

​https://bugs.webkit.org/show_bug.cgi?id=36801

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:42 PM Changeset in webkit [57172] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-06 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Laszlo Gombos.

[Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
​https://bugs.webkit.org/show_bug.cgi?id=37159

  • QtLauncher/useragentlist.txt:
3:39 PM Changeset in webkit [57171] by jhawkins@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-06 James Hawkins <​jhawkins@chromium.org>

Reviewed by Adam Barth.

[Chromium] Implement WebInputElement::maxLength.
​https://bugs.webkit.org/show_bug.cgi?id=37172

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength):
3:32 PM Changeset in webkit [57170] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-06 Abhinav Mithal <​abhinav.mithal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] npapi header leaves XP_WIN flag defined even when SYMBIAN32 flag is found
​https://bugs.webkit.org/show_bug.cgi?id=34614

Do not define XP_WIN if WebKit is compiled for Symbian.

No new tests as there is no new functionality.

  • bridge/npapi.h:
3:02 PM Changeset in webkit [57169] by aestes@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Added myself to the committers list.

2:58 PM Changeset in webkit [57168] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, media test expectations tweak.

We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [57167] by Chris Fleizach
  • 3 edits
    2 adds in trunk

aria-label doesn't work on image map area
​https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

  • platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/area-with-aria-label.html: Added.
2:21 PM Changeset in webkit [57166] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, cleaning up media layout test expectations.

Mostly correcting bug numbers, updating comments, and fixing expectations.

  • platform/chromium/test_expectations.txt:
1:44 PM Changeset in webkit [57165] by jamesr@google.com
  • 6 edits in trunk/WebCore

2010-04-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Reverts the incorrect fixed position fastpath scrolling logic
​https://bugs.webkit.org/show_bug.cgi?id=33150

This code does not properly handle overflow or transforms on fixed
position elements, causing repaint bugs on scroll.

No new tests.

  • page/FrameView.cpp: (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
12:58 PM Changeset in webkit [57164] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix for wxMac / Cocoa on wx trunk.

12:50 PM Changeset in webkit [57163] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-06 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Darin Adler.

JS code generator does not support feature conditional attributes that are writable
​https://bugs.webkit.org/show_bug.cgi?id=37149

Write out the feature #ifdef not only for the getter, but also for the setter
function.

  • bindings/scripts/CodeGeneratorJS.pm:
12:17 PM Changeset in webkit [57162] by eric@webkit.org
  • 9 edits
    1 copy
    1 move in trunk

2010-04-06 Evan Stade <​estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

This was previously committed but rolled back for breaking layout
tests. The fix is on the WebKit/chromium side.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Removed.
  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageRef.h:

2010-04-06 Evan Stade <​estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

This was previously committed but rolled back for breaking layout
tests.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
11:56 AM Changeset in webkit [57161] by yuzo@google.com
  • 5 edits in trunk

2010-04-01 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
​https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.

2010-04-01 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per ​http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
​https://bugs.webkit.org/show_bug.cgi?id=36276

Test: fast/css/invalid-not-with-simple-selector-sequence.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
11:18 AM Changeset in webkit [57160] by Darin Adler
  • 1 edit
    1 copy in trunk/LayoutTests

REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37157

  • platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.

11:17 AM Changeset in webkit [57159] by mitz@apple.com
  • 3 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Patch by Andy Estes <​aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.

​https://bugs.webkit.org/show_bug.cgi?id=37008

  • dom/UserGestureIndicator.cpp:
  • dom/UserGestureIndicator.h:
10:59 AM Changeset in webkit [57158] by jhawkins@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-04-06 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Move the getElementsByTagName from WebDocument to WebNode.
​https://bugs.webkit.org/show_bug.cgi?id=37161

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName):
10:49 AM Changeset in webkit [57157] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-06 Andrei Popescu <​andreip@google.com>

Reviewed by Dimitri Glazkov.

[V8][Android] PageCache crashes when JavaScript is disabled
​https://bugs.webkit.org/show_bug.cgi?id=37150

This patch ensures that saving and restoration of the script
state only happens when JS is enabled and each frame has a
non-null context.

No new tests: existing tests show the feature is working
when JS is enabled. When JS is disabled, manual testing
is required.

  • bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
10:39 AM Changeset in webkit [57156] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Bryan Yeung <​bryeung@chromium.org>

Reviewed by Dimitri Glazkov.

Update chromium expectations for passing Linux tests.

  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [57155] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-06 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
​https://bugs.webkit.org/show_bug.cgi?id=36538

  • Api/qwebkitglobal.h:
10:11 AM Changeset in webkit [57154] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

2010-04-06 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.

  • platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
9:15 AM Changeset in webkit [57153] by loislo@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Chromium DEPS.

  • DEPS:
8:56 AM Changeset in webkit [57152] by loislo@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed: build fixi for WebKit Chromium bots.

  • DEPS:
8:11 AM Changeset in webkit [57151] by loislo@chromium.org
  • 2 edits
    4 adds in trunk/WebCore

2010-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Web Inspector: missed files were added.

  • GNUmakefile.am:
  • bindings/js/ScriptGCEvent.h: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/v8/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize): (WebCore::ScriptGCEvent::getUsedHeapSize): (WebCore::ScriptGCEvent::gcPrologueCallback): (WebCore::ScriptGCEvent::gcEpilogueCallback):
  • bindings/v8/ScriptGCEvent.h: Added.
  • inspector/ScriptGCEventListener.h: Added. (WebCore::ScriptGCEventListener::~ScriptGCEventListener):
7:50 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:46 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:44 AM Changeset in webkit [57150] by loislo@chromium.org
  • 28 edits in trunk

2010-04-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The JS code can be not optimal from memory usage point of view.
As example it can generate a lot of temp objects and GC will spend significant time to collect these objects.
GC event will show us these moments. Also each event can show us how much memory is in use.
​https://bugs.webkit.org/show_bug.cgi?id=37025

  • WebCore.gypi:
  • WebCore.pro:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount): (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGCEventData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseHover):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
7:33 AM Changeset in webkit [57149] by tonikitoo@webkit.org
  • 1 edit in trunk/WebCore/rendering/RenderBox.cpp

Unreviewed identation fix.

7:32 AM Changeset in webkit [57148] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Remove unused DIRECTIONAL_PAD_NAVIGATION
​https://bugs.webkit.org/show_bug.cgi?id=37134

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
​https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.

However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

7:00 AM Changeset in webkit [57147] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
6:45 AM Changeset in webkit [57146] by pfeldman@chromium.org
  • 13 edits in trunk

2010-04-06 Mattias Nissler <​mnissler@chromium.org>

Reviewed by Pavel Feldman.

Rework inspector docking to issue a request call from the frontend
whenever the user triggers to (un)dock the inspector window. Doing so
enables InspectorFrontendHost implementations to asynchronously decide
whether the window is docked or not. The old canAttachWindow() is not
required anymore, remove it.
​https://bugs.webkit.org/show_bug.cgi?id=36944

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::requestAttachWindow):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::requestAttachWindow):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/inspector.js: (WebInspector.toggleAttach):

2010-04-06 Mattias Nissler <​mnissler@chromium.org>

Reviewed by Pavel Feldman.

Handle docking requests from the developer tools and forward them to
WebDevToolsFrontendClient.
​https://bugs.webkit.org/show_bug.cgi?id=36944

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
  • src/WebDevToolsFrontendImpl.h:
6:33 AM Changeset in webkit [57145] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-06 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
6:29 AM QtWebKitTriageRoster edited by koshuin@gmail.com
(diff)
6:19 AM Changeset in webkit [57144] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add current user-agent string for Symbian for QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=37131

  • QtLauncher/useragentlist.txt:
5:53 AM QtWebKitTriageRoster edited by benjamin.poulain@nokia.com
(diff)
5:50 AM QtWebKitTriageRoster edited by antti.j.koivisto@nokia.com
(diff)
5:46 AM QtWebKitTriageRoster edited by kenneth@webkit.org
(diff)
5:35 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
5:31 AM QtWebKitTriageRoster created by Simon Hausmann
5:26 AM Changeset in webkit [57143] by pfeldman@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-04-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaselining Chromium layout test expectations.

  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:26 AM QtWebKitBugs edited by Simon Hausmann
(diff)
5:25 AM QtWebKitBugs edited by Simon Hausmann
(diff)
5:25 AM QtWebKitBugs edited by Simon Hausmann
(diff)
4:54 AM Changeset in webkit [57142] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-06 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

[Qt] LayoutTests/fast/canvas/canvas-text-alignment.html skipped on Qt
​https://bugs.webkit.org/show_bug.cgi?id=36058

fast/canvas/canvas-text-alignment.html passes, so it can be unskipped.
Compared to png file and Mac expected file.

  • platform/qt/Skipped: fast/canvas/canvas-text-alignment.html unskipped.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Added.
3:47 AM Changeset in webkit [57141] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed buildfix for --minimal build.
Buildfix after r57134. Add ENABLE(WORKERS) guard.

original bug: ​https://bugs.webkit.org/show_bug.cgi?id=36375

  • bindings/js/JSWorkerContextErrorHandler.cpp:
3:37 AM Changeset in webkit [57140] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
​https://bugs.webkit.org/show_bug.cgi?id=37071

Test: svg/animations/animate-keySplines.html

The String in 'keySplines' can have multiple spaces between numbers
and delimiters. The parsing code is inspired by SVGParserUtilities
and respects this.

  • svg/SVGAnimationElement.cpp: (WebCore::parseKeySplines):

2010-04-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
​https://bugs.webkit.org/show_bug.cgi?id=37071

Test correct parsing of keySplines.

  • svg/animations/animate-keySplines-expected.txt: Added.
  • svg/animations/animate-keySplines.html: Added.
  • svg/animations/script-tests/animate-keySplines.js: Added. (sample1): (sample2): (sample3): (executeTest):
3:34 AM Changeset in webkit [57139] by pfeldman@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2010-04-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
3:14 AM Changeset in webkit [57138] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-06 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Fixed logging of unhndled worker exceptions.
​https://bugs.webkit.org/show_bug.cgi?id=37143

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
2:59 AM Changeset in webkit [57137] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Explain how to handle rollout patches
​https://bugs.webkit.org/show_bug.cgi?id=37139

We need to set expectations for how long landing rollout patches with
the commit-queue takes. The commit-queue is optimized for safety, not
performance. Also, give folks an alternative way to land patches
quickly.

In addition, improve our testing of add_patch_to_bug by having
MockBugzilla log. This caused me to tighten a bunch of tests and
notice that one of our tests wasn't being run.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2:58 AM Changeset in webkit [57136] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
2:07 AM Changeset in webkit [57135] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: updated test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
1:46 AM Changeset in webkit [57134] by yurys@chromium.org
  • 20 edits
    3 copies
    1 add in trunk

2010-04-06 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:

2010-04-06 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
1:12 AM Changeset in webkit [57133] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-04-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: reverting v8 change at r57079 for crashing Chromium layout tests.

12:27 AM Changeset in webkit [57132] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Turns out commit_info.committer() can be None
​https://bugs.webkit.org/show_bug.cgi?id=37106

When the committer isn't in committers.py, the committer() property on
commit_info can be None. We need to handle that case gracefully.

  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
12:09 AM Changeset in webkit [57131] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
​https://bugs.webkit.org/show_bug.cgi?id=37082

Use the QT_NO_PRINTER guard to flag QPrinter dependent code.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dryRunPrint):

Apr 5, 2010:

11:59 PM Changeset in webkit [57130] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

RenderProgress.cpp is missing CurrentTime.h
​https://bugs.webkit.org/show_bug.cgi?id=37080

No new tests. just fixed compilation error.

  • rendering/RenderProgress.cpp:
11:48 PM Changeset in webkit [57129] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

2010-04-05 Peter Nelson <​charn.opcode@gmail.com>

Reviewed by Eric Seidel.

Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for ​https://bugs.webkit.org/show_bug.cgi?id=34979.

  • DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
11:33 PM Changeset in webkit [57128] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
​https://bugs.webkit.org/show_bug.cgi?id=36671

The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.

No new tests.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
11:32 PM WebInspector edited by Joseph Pecoraro
(diff)
11:11 PM Changeset in webkit [57127] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Anthony Ricaud <​rik@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits launcher view is unusable with a small height window
​https://bugs.webkit.org/show_bug.cgi?id=37109

Use flex box instead of absolute positioning to avoid overlapping elements.

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
11:08 PM WikiStart edited by Joseph Pecoraro
(diff)
11:01 PM Changeset in webkit [57126] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - wrong spelling
​https://bugs.webkit.org/show_bug.cgi?id=37110

Correcting wrong spelling in RenderThemeQt.cpp.

  • platform/qt/RenderThemeQt.cpp:
10:52 PM Changeset in webkit [57125] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should force_build builders that are idle and have failed exactly once
​https://bugs.webkit.org/show_bug.cgi?id=37059

We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
10:51 PM Changeset in webkit [57124] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/Platform*Event.h.
​http://webkit.org/b/36309

  • platform/PlatformWheelEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformKeyboardEvent.h:
10:23 PM Changeset in webkit [57123] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Another build fix

10:07 PM Changeset in webkit [57122] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

And another build fix.

10:00 PM Changeset in webkit [57121] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

9:18 PM Changeset in webkit [57120] by oliver@apple.com
  • 4 edits
    3 adds in trunk/JavaScriptCore

2010-04-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Support weak maps in JSC
​https://bugs.webkit.org/show_bug.cgi?id=37132

Expose an API to allow creation of a map for storing
weak JS references.

  • API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
  • API/JSWeakObjectMapRefPrivate.cpp: Added.
  • API/JSWeakObjectMapRefPrivate.h: Added.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
8:59 PM Changeset in webkit [57119] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-05 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.

​https://bugs.webkit.org/show_bug.cgi?id=37122

  • Scripts/webkitpy/style/checker.py:
    • Changed non-existent file message from ERROR to WARN.
    • StyleChecker.check_file() no longer raises an exception when a file is not found.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
8:50 PM Changeset in webkit [57118] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/graphics/*.h.
​http://webkit.org/b/36308

  • platform/graphics/Icon.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/IntPoint.h:
8:33 PM Changeset in webkit [57117] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.

Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
8:08 PM Changeset in webkit [57116] by jamesr@google.com
  • 6 edits
    6 adds in trunk

2010-04-05 Dimitri Glazkov <Dimitri Glazkov> and James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler and Dimitri Glazkov.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()

call to ensure that object loads start before firing window load.

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.
8:02 PM Changeset in webkit [57115] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should include blamelist when posting to bugs
​https://bugs.webkit.org/show_bug.cgi?id=37113

When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:32 PM Changeset in webkit [57114] by Chris Jerdonek
  • 2 edits
    1 delete in trunk/WebKitTools

Unreviewed after discussion with Adam, Darin, and Eric.

Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).

Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.

  • Scripts/webkitpy/thirdparty/autoinstalled: Removed.
7:24 PM Changeset in webkit [57113] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update a test result.

  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
7:03 PM Changeset in webkit [57112] by tonikitoo@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-05 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Laszlo Gombos.

Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.

  • manual-tests/spatial-navigation/frameset.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
6:45 PM Changeset in webkit [57111] by mrowe@apple.com
  • 12 edits
    2 adds in trunk

Test case for <​http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI

Reviewed by Adele Peterson.

WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.

WebKitTools:

Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.

  • DumpRenderTree/LayoutTestController.cpp:

(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):

LayoutTests:

  • platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
  • platform/mac/editing/deleting/resources/deletionUI-helpers.js:

(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):

6:45 PM Changeset in webkit [57110] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Roll out r56989 as it introduced crashes in Mail.
<​http://webkit.org/b/37115> / <rdar://problem/7829331>

Reviewed by Adele Peterson.

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

6:38 PM Changeset in webkit [57109] by Darin Adler
  • 18 edits
    3 adds in trunk

Images must re-load when an image-holding element moves into a new document
​https://bugs.webkit.org/show_bug.cgi?id=37127

Reviewed by Sam Weinig.

WebCore:

Test: fast/images/move-image-to-new-document.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.

  • html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.h: Ditto.
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLVideoElement.h: Ditto.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.

  • svg/SVGImageElement.h: Ditto.
  • html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected

so it can be called by HTMLVideoElement.cpp.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.

  • loader/ImageLoader.h: Added it.

LayoutTests:

  • fast/images/move-image-to-new-document-expected.txt: Added.
  • fast/images/move-image-to-new-document.html: Added.
  • fast/images/script-tests/move-image-to-new-document.js: Added.
  • fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting

tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.

5:55 PM Changeset in webkit [57108] by eric@webkit.org
  • 4 edits in trunk

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
​https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.

  • wtf/Platform.h:

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
​https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

No new tests as there is no new functionality.

  • config.h:
5:34 PM Changeset in webkit [57107] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add missing ClipboardEfl.h to platform/efl.
​http://webkit.org/b/36242

  • platform/efl/ClipboardEfl.h: Added.
5:18 PM Changeset in webkit [57106] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-04-05 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Adler.

A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
​https://bugs.webkit.org/show_bug.cgi?id=37077
​https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
  • fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
5:08 PM Changeset in webkit [57105] by eric@webkit.org
  • 7 edits
    3 adds in trunk

2010-04-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
​https://bugs.webkit.org/show_bug.cgi?id=28938

  • fast/css/script-tests/string-quote-binary.js: Added.
  • fast/css/string-quote-binary-expected.txt: Added.
  • fast/css/string-quote-binary.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.

2010-04-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
​https://bugs.webkit.org/show_bug.cgi?id=28938

Test: fast/css/string-quote-binary.html

  • css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
5:06 PM Changeset in webkit [57104] by Darin Adler
  • 2 edits in trunk/SunSpider

Updated the ignore property for changes to the contents here.

  • .: Modified property svn:ignore.
4:54 PM Changeset in webkit [57103] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

  • fast/notifications/notifications-no-icon-expected.txt: Added.
  • fast/notifications/notifications-no-icon.html-disabled: Added.

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
4:40 PM Changeset in webkit [57102] by Darin Adler
  • 10 edits in trunk/WebKitTools

Ignore more files the Python tools strew about the working directory.

  • Scripts/webkitpy: Added property svn:ignore.
  • Scripts/webkitpy/common: Added property svn:ignore.
  • Scripts/webkitpy/common/checkout: Added property svn:ignore.
  • Scripts/webkitpy/common/config: Added property svn:ignore.
  • Scripts/webkitpy/common/net: Added property svn:ignore.
  • Scripts/webkitpy/common/thread: Added property svn:ignore.
  • Scripts/webkitpy/python24: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
  • Scripts/webkitpy/tool/bot: Added property svn:ignore.
4:19 PM Changeset in webkit [57101] by Darin Adler
  • 5 edits in trunk/WebCore

Removed some unneeded type casts.

Reviewed by Mark Rowe.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.

  • page/Location.cpp:

(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort): Ditto.

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.

4:07 PM Changeset in webkit [57100] by abarth@webkit.org
  • 5 edits
    6 deletes in trunk

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
  • fast/forms/textarea-and-mutation-events-expected.txt: Removed.
  • fast/forms/textarea-and-mutation-events.html: Removed.

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
3:57 PM Changeset in webkit [57099] by beidson@apple.com
  • 2 edits in trunk/WebCore

ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and ​https://bugs.webkit.org/show_bug.cgi?id=37120

Reviewed by Oliver Hunt.

No new tests. (No behavior change)

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.

3:39 PM Changeset in webkit [57098] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected pixel results for missing plug-in, now using text placeholder.

  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
  • platform/mac/plugins/qt-qwidget-plugin-expected.png:
3:03 PM Changeset in webkit [57097] by yael.aharon@nokia.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/win/fast/js: Added.
  • platform/win/fast/js/global-constructors-expected.txt: Added.
2:52 PM Changeset in webkit [57096] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57030.
​http://trac.webkit.org/changeset/57030
​https://bugs.webkit.org/show_bug.cgi?id=37114

Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:49 PM Changeset in webkit [57095] by ap@apple.com
  • 22 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes

2:16 PM Changeset in webkit [57094] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed.

Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
​https://bugs.webkit.org/show_bug.cgi?id=37112

Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.

  • platform/mac-leopard/Skipped:
1:41 PM Changeset in webkit [57093] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
​https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

When aria-selected is changed in the DOM, it will trigger a selected children change notification.

Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlType):

Remove extra whitespace before comment (webkit-style).

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::observableObject):

Allowed a listBox to be an observable object.

(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):

Updated and streamlined existing code.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
​https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
1:38 PM Changeset in webkit [57092] by yael.aharon@nokia.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
12:55 PM Changeset in webkit [57091] by ojan@chromium.org
  • 6 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:33 PM Changeset in webkit [57090] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:27 PM Changeset in webkit [57089] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix regression in pixel test for animated svg background images.

Patch by Adam Treat <​atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37027

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:30 AM Changeset in webkit [57088] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Update kenne's IRC nick to his registered nick.

  • Scripts/webkitpy/common/config/committers.py:
11:27 AM Changeset in webkit [57087] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
11:24 AM Changeset in webkit [57086] by kenneth@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed layout test fix.

Update mac results for iframe flattening.

  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
11:16 AM WebKit Team edited by abarth@webkit.org
(diff)
10:57 AM Changeset in webkit [57085] by robert@webkit.org
  • 4 edits in trunk

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Qt enters an infinite loop if a redirect response redirects to itself.

Fixes http/tests/xmlhttprequest/connection-error-sync.html

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Unskip http/tests/xmlhttprequest/connection-error-sync.html

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/qt/Skipped:
10:55 AM Changeset in webkit [57084] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog should take a merge-base for which git branch to diff against.
​https://bugs.webkit.org/show_bug.cgi?id=36394

  • Scripts/prepare-ChangeLog:
10:36 AM Changeset in webkit [57083] by kenneth@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed layout test fix.

Update Qt results for iframe flattening.

  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
10:35 AM Changeset in webkit [57082] by yurys@chromium.org
  • 19 edits
    4 deletes in trunk

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, revert r57078.

10:27 AM Changeset in webkit [57081] by Dimitri Glazkov
  • 5 edits
    6 adds in trunk

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

10:18 AM Changeset in webkit [57080] by kenneth@webkit.org
  • 4 edits in trunk/WebCore

iframe flattening doesn't flatten
​https://bugs.webkit.org/show_bug.cgi?id=36798

Reviewed by Dave Hyatt.

Fixed to the iframe flattening code so that the iframes on
​http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.

Covered by current tests.

  • page/FrameView.cpp: Propagate contents changes of iframes

and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):

  • rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from

HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth

return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

10:06 AM Changeset in webkit [57079] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-05 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
10:00 AM Changeset in webkit [57078] by yurys@chromium.org
  • 19 edits
    3 copies
    1 add in trunk

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
  • workers/WorkerContext.h:
8:53 AM Changeset in webkit [57077] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

Fix some "explicit braces to avoid ambiguous 'else'" warnings
​https://bugs.webkit.org/show_bug.cgi?id=37088

Reviewed by Darin Adler.
Patch by Antonio Gomes (​tonikitoo@webkit.org)

  • dom/Node.cpp:

(WebCore::Node::dispatchGenericEvent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

7:28 AM Changeset in webkit [57076] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

No new tests as there is no new functionality.

  • config.h:
7:12 AM Changeset in webkit [57075] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-05 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Kenneth-Rohde Christiansen.

re-login.html and re-login-async.html are now tracked in bugzilla.

​https://bugs.webkit.org/show_bug.cgi?id=37084

  • platform/qt/Skipped:
6:47 AM Changeset in webkit [57074] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Remove obsolete build flags for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=37083

Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.

Symbian now has inttypes.h as part of OpenC.

stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.

No new tests as there is no new functionality.

  • config.h:
5:48 AM Changeset in webkit [57073] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
5:48 AM Changeset in webkit [57072] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-04-05 Lucas Lommer <​llommer@svn.gnome.org>

Reviewed by Gustavo Noronha.

Czech translation for WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=36879

  • cs.po: Added.
5:44 AM Changeset in webkit [57071] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-04-05 Christian Kirbach <​Christian.Kirbach@googlemail.com>

Reviewed by Gustavo Noronha.

Updated German translation
​https://bugs.webkit.org/show_bug.cgi?id=36453

  • de.po:
5:38 AM Changeset in webkit [57070] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-04-05 Luca Ferretti <​elle.uca@libero.it>

Reviewed by Gustavo Noronha.

Italian translation for 1.1.90
​https://bugs.webkit.org/show_bug.cgi?id=36323

  • it.po:
5:37 AM Changeset in webkit [57069] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.

​https://bugs.webkit.org/show_bug.cgi?id=37081

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
4:59 AM Changeset in webkit [57068] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-04-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Remove logging of successful XHR and worker's importScript()
to inspector console
​https://bugs.webkit.org/show_bug.cgi?id=37078

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
  • workers/DedicatedWorkerContext.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
2:27 AM Changeset in webkit [57067] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium test expectations update for the roll.

  • platform/chromium/test_expectations.txt:
12:41 AM Changeset in webkit [57066] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-05 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.

​https://bugs.webkit.org/show_bug.cgi?id=37067

  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a line_number parameter to the check_file() method.
      • Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
      • Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
      • Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
    • Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
    • Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
    • Removed the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
    • Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
12:24 AM Changeset in webkit [57065] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Tighten SheriffBot's flaky test detector
​https://bugs.webkit.org/show_bug.cgi?id=37063

Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.

I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:

Apr 4, 2010:

11:30 PM Changeset in webkit [57064] by pfeldman@chromium.org
  • 9 edits
    1 move
    1 delete in trunk

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out chromium changes r57028 and r57032
for breaking chromium layout tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumMac.cpp: Removed.
  • platform/chromium/DragImageChromiumSkia.cpp: Removed.
  • platform/chromium/DragImageRef.h:


WebKit/chromium:

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
7:28 PM Changeset in webkit [57063] by johnnyg@google.com
  • 2 edits in trunk/WebKitTools

2010-04-04 John Gregg <​johnnyg@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
7:11 PM Changeset in webkit [57062] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed expected results fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

The implementation was fixed, and results were no longer valid.

  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
7:10 PM Changeset in webkit [57061] by tonikitoo@webkit.org
  • 6 edits in trunk/WebCore

2010-03-29 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

WebCore::distanceInDirection method was handling much of the logic not
strictly only related to the distance between nodes acquisition. This
method was simplified and renamed to 'WebCore::distanceDataForNode'.
The latter is now responsible for only getting the distance and alignment
data, while all assignement logic previously in distanceInDirection method
was moved place to updateFocusCandidateIfCloser.

Parent document distance and alignment acquisitions, in turn, have also
changed location: they are both got from deepFindFocusableNodeInDirection,
and passed in a recursive call to findFocusableNodeInDirection via the
candidateParent variable (optional parameter). In addition, the need for
the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
was removed, making the code much cleaner.

No behaviour change at this point. Mostly moving code around to the place
where it should live in.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::updateFocusCandidateIfCloser): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): (WebCore::renderRectRelativeToRootDocument):
  • page/SpatialNavigation.
3:18 PM Changeset in webkit [57060] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

​https://bugs.webkit.org/show_bug.cgi?id=37072

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
3:00 PM Changeset in webkit [57059] by pfeldman@chromium.org
  • 1 edit
    21 adds in trunk/WebKitSite

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

(Not reviewed).

Adding images for inspector blog post. Previewed by Timothy Hatcher.

  • blog-files/inspector/audits_launcher.png: Added.
  • blog-files/inspector/audits_panel.png: Added.
  • blog-files/inspector/console_panel.png: Added.
  • blog-files/inspector/context_menu.png: Added.
  • blog-files/inspector/css_highlighted_line.png: Added.
  • blog-files/inspector/css_line_number_snippet.png: Added.
  • blog-files/inspector/css_line_numbers.png: Added.
  • blog-files/inspector/deactivate_breakpoints.png: Added.
  • blog-files/inspector/evaluate_on_hover.png: Added.
  • blog-files/inspector/evaluate_on_hover_2.png: Added.
  • blog-files/inspector/inherited_styles.png: Added.
  • blog-files/inspector/large_dom.png: Added.
  • blog-files/inspector/large_resources.png: Added.
  • blog-files/inspector/pseudo_elements.png: Added.
  • blog-files/inspector/redirect_headers.png: Added.
  • blog-files/inspector/redirect_headers_full.png: Added.
  • blog-files/inspector/redirects.png: Added.
  • blog-files/inspector/redirects_full.png: Added.
  • blog-files/inspector/timeline_overview.png: Added.
  • blog-files/inspector/timeline_panel.png: Added.
  • blog-files/inspector/timeline_record_details.png: Added.
4:52 AM Changeset in webkit [57058] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-04 Robert Hogan <​robert@webkit.org>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
1:53 AM Changeset in webkit [57057] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, adding my IRC nickname to committers.py

  • Scripts/webkitpy/common/config/committers.py:
1:26 AM Changeset in webkit [57056] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

2010-04-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's option-parsing code.

​https://bugs.webkit.org/show_bug.cgi?id=37064

  • Scripts/check-webkit-style:
    • Moved the "WebKit checkout not found" check from ArgumentParser.parse() to the calling code.
    • Moved the --git-commit argument validation from the calling code to ArgumentParser.parse().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a unit test as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Renamed ArgumentParser._exit_with_help() to _parse_error() and made its error_message parameter required.
    • Removed the found_checkout parameter from ArgumentParser.parse().
    • Removed the "WebKit checkout not found" check and moved it to the calling code.
    • Added --git-commit argument checking.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Adjusted the import statements to be fully qualified.
    • Changed the ArgumentParserTest class to inherit from LoggingTestCase, and updated the class as necessary.
    • Added a unit-test for the --git-commit validation.
    • Added unit tests for the --git-diff and --git-since variants of --git-commit.

Apr 3, 2010:

11:53 PM Changeset in webkit [57055] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.

Reviewed by Oliver Hunt.

No performance impact.

(JSC::InternalFunction::InternalFunction):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::initializeUString):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):

6:53 PM PythonGuidelines edited by Chris Jerdonek
Added another reason for the from/import ordering suggestion. (diff)
6:17 PM Changeset in webkit [57054] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-03 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Fix uninitalised members in CallLinkInfo and BytecodeGenerator.

​https://bugs.webkit.org/show_bug.cgi?id=36816

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
1:28 PM PythonGuidelines edited by Chris Jerdonek
Moved the PEP8 remark to the style section. (diff)
1:20 PM PythonGuidelines edited by Chris Jerdonek
Fixed typo. (diff)
1:19 PM PythonGuidelines edited by Chris Jerdonek
Added a style section. (diff)
1:01 PM WikiStart edited by Chris Jerdonek
Retitled link to Python page (diff)
11:59 AM Changeset in webkit [57053] by jwieczorek@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

[Qt] Skip five XMLHttpRequest tests that are timing out.

  • platform/qt/Skipped: Add a comment on why they are failing.
10:40 AM Changeset in webkit [57052] by jwieczorek@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Rubber-stamped by Daniel Bates.

Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
failure on the Qt and GTK+ ports.

Refactor it to not hardcode any metrics (in order to dispatch mouse events)
but instead calculate them from the offset* properties.

  • fast/events/popup-allowed-from-gesture-initiated-event.html:
10:40 AM WikiStart edited by abarth@webkit.org
(diff)
10:38 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:35 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 AM Keeping the Tree Green created by abarth@webkit.org
10:27 AM Changeset in webkit [57051] by eric@webkit.org
  • 11 edits in trunk

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeMac::animationDurationForProgressBar): (WebCore::RenderThemeMac::adjustProgressBarStyle): (WebCore::RenderThemeMac::paintProgressBar):

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
7:34 AM Changeset in webkit [57050] by jwieczorek@webkit.org
  • 2 edits in trunk/WebCore

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

Fix debug build with GCC >= 4.3.

  • platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
12:49 AM Changeset in webkit [57049] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

Test: fast/canvas/webgl/null-uniform-location.html

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
12:46 AM Changeset in webkit [57048] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist. Previously, it failed
silently on such paths.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=36957

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a FIXME to rename the LoggingTestCase class to LoggingTestCaseBase.
  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker.check_file() method:
      • Added a mock_os_path_exists parameter.
      • Renamed the process_file parameter to mock_process_file.
      • Added logic to log an error and exist if the given path does not exist.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the StyleCheckerCheckFileTest class slightly to inherit from LoggingTestCase.
    • Added a test method to unit-test the case of a file that does not exist.
    • Adjusted the other test methods as necessary.
12:34 AM Changeset in webkit [57047] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
​https://bugs.webkit.org/show_bug.cgi?id=33289

Add Tiger and SnowLeopard Tests to the core builders. This is a bit of
an experiment now that the bots are green. Hopefully we can keep them
on the list and have the tree stay greener.

  • Scripts/webkitpy/common/net/buildbot.py:
12:12 AM Changeset in webkit [57046] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-03 Darin Fisher <​darin@chromium.org>

Add default implementations of WebNotificationPresenter methods to
repair the downstream Chromium build.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission):
12:05 AM Changeset in webkit [57045] by abarth@webkit.org
  • 13 edits
    8 adds in trunk

2010-04-02 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=37008.

  • fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
  • fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
  • fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-button-click.html: Added.
  • fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-focus.html: Added.

2010-04-02 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

The previous mechanism for testing whether an event was due to a user
gesture only checked the event type, not the source of the event. This
allowed scripts to defeat popup blocking by programatically emitting
certain types of events.

Change the user gesture detection to check for a flag that is only set
when the event in question was generated through the platform and not
through the DOM.

​https://bugs.webkit.org/show_bug.cgi?id=37008

Tests: fast/events/popup-allowed-from-gesture-initiated-event.html

fast/events/popup-blocked-from-fake-button-click.html
fast/events/popup-blocked-from-fake-focus.html

  • Android.mk: Add UserGestureIndicator.{cpp, h}.
  • GNUmakefile.am: Same.
  • WebCore.gypi: Same.
  • WebCore.pro: Same.
  • WebCore.vcproj/WebCore.vcproj: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Check the value of UserGesureIndicator::processingUserGesture().
  • dom/Document.cpp: (WebCore::Document::createEvent): Remove call to Event::setCreatedByDOM().
  • dom/Event.cpp: (WebCore::Event::Event): Remove initializers for m_createdByDOM. (WebCore::Event::fromUserGesture): Check the value of UserGestureIndicator::processingUserGesture().
  • dom/Event.h: Remove m_createdByDOM.
  • dom/UserGestureIndicator.cpp: Added. (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous value of s_processingUserGesture before setting it to true. (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore s_processingUserGesture to its previous value.
  • dom/UserGestureIndicator.h: Added. (WebCore::UserGestureIndicator::processingUserGesture): Return the value of s_processingUserGesture.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Instantiate a UserGestureIndicator object on the stack to indicate a user gesture is being processed. (WebCore::EventHandler::handleMouseDoubleClickEvent): Same. (WebCore::EventHandler::handleMouseReleaseEvent): Same. (WebCore::EventHandler::keyEvent): Same. (WebCore::EventHandler::handleTouchEvent): Same.

Apr 2, 2010:

11:15 PM Changeset in webkit [57044] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed.

REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=36934

Attempt Alexey's solution of using a non-sniffable MIME type.

  • http/tests/xmlhttprequest/resources/download-with-delay.php:
10:49 PM Changeset in webkit [57043] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed. Disabled fast/workers/worker-terminate.html because it
randomly fails about 25% of the time.

​https://bugs.webkit.org/show_bug.cgi?id=36646

  • platform/mac/Skipped:
9:48 PM Changeset in webkit [57042] by darin@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-04-02 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36647
Make replacestate-in-frame.html less insane and hopefully no longer flaky.

  • fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
  • fast/loader/stateobjects/replacestate-in-iframe.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
9:20 PM Changeset in webkit [57041] by abarth@webkit.org
  • 3 edits
    9 adds in trunk

2010-04-02 Justin Schuh <​jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
​https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.

2010-04-02 Justin Schuh <​jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
​https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html

http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightFailure):
9:09 PM Changeset in webkit [57040] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed.

Have Eric and Adam watch the SheriffBot
​https://bugs.webkit.org/show_bug.cgi?id=37054

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
6:05 PM Changeset in webkit [57039] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Very bad scrolling-performance with the Trackpad at ​http://www.apple.com/ipad/app-store/
​https://bugs.webkit.org/show_bug.cgi?id=36978

When we update compositing layers (which can happen on scrolling, when there are fixed position elements
on the page), we can end up redundantly setting images as layer contents if we have to color-correct
the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
every time.

Avoid this by storing a reference to the original uncorrected image, which is used to then
avoid work if the image does not change.

  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
6:03 PM Changeset in webkit [57038] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-04-02 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix for WML enabled build failure.

​https://bugs.webkit.org/show_bug.cgi?id=36648

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::disabled):
  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
  • wml/WMLSelectElement.h:
5:38 PM Changeset in webkit [57037] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=37011
Position::primaryDirection() should not use its own accessor.

No new tests. This is small clenaup with no behaviour change.

  • dom/Position.cpp: (WebCore::Position::primaryDirection):
5:16 PM Changeset in webkit [57036] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5. This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
​https://bugs.webkit.org/show_bug.cgi?id=36671

No new tests. Requires testing on Safari on Windows.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.
5:14 PM Changeset in webkit [57035] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

commit-queue should ignore builders when landing rollouts
​https://bugs.webkit.org/show_bug.cgi?id=37051

When we moved the "builders are red" check into the master process, we
forgot about rollouts. I thought we had a test covering this case, but
looking at the test, it was a bit too loose. I added a new test and
introduced some new logging technology into MockTool to make the test
tighter.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
5:06 PM Changeset in webkit [57034] by eric@webkit.org
  • 6 edits in trunk

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask in a constructor argument
instead of hard coding it.
​https://bugs.webkit.org/show_bug.cgi?id=37037

No new tests, new new functionality.

  • storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior. (WebCore::Database::markAsDeletedAndClose):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask):
  • storage/DatabaseTask.h: (WebCore::DatabaseCloseTask::create):

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask at this callsite to
RemoveDatabaseFromContext. This restores its behavior to what it was prior to
r56293.
​https://bugs.webkit.org/show_bug.cgi?id=37037

  • src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):
4:52 PM Changeset in webkit [57033] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-04-02 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Remove an ASSERT that sometimes flakes due to time dependent animations
​https://bugs.webkit.org/show_bug.cgi?id=37048

The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.

No change in behavior, no new tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
4:45 PM Changeset in webkit [57032] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Adam Barth.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Add two files that failed to get added in my previous patch.

  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
4:30 PM Changeset in webkit [57031] by eric.carlson@apple.com
  • 12 edits in trunk

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Configure multi-language movies: when QuickTime has sufficiently loaded
the movie, call into wkQTMovieSelectPreferredAlternates to select the
movie's alternate tracks according to the user's language preferences.

​https://bugs.webkit.org/show_bug.cgi?id=36624

  • WebCore.base.exp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded, call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
  • platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
  • platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.


​https://bugs.webkit.org/show_bug.cgi?id=36624

Update WebKitSystemInterface

  • WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

​https://bugs.webkit.org/show_bug.cgi?id=36624
Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
4:21 PM Changeset in webkit [57030] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-04-02 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Splits RenderBlock::layoutInline into smaller functions
​https://bugs.webkit.org/show_bug.cgi?id=36921

RenderBlock::layoutInlineChildren is 351 lines long and very difficult
to comprehend or edit safely. This patch splits it up into a few
slightly smaller functions. Most of the code is now in the 241 line
layoutRunsAndFloats() which is a slight improvement.

Perf neutral on the page cyclers. This doesn't introduce any function
calls into the hottest layout paths inside layoutRunsAndFloats and
findNextLineBreak.

No change in behavior, no new tests.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutReplacedElements): (WebCore::RenderBlock::createLineBoxesForResolver): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
3:57 PM Changeset in webkit [57029] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Rebaseline Symbian def file
​https://bugs.webkit.org/show_bug.cgi?id=37038

Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
and QWebInspector::closeEvent to match QtWebkit 4.6 branch

Fix the signature for qt_drt_setFrameFlatteningEnabled
after r56718.

Add new QtWebKit API symbols introduced not listed in the file yet.

  • symbian/eabi/QtWebKitu.def:
3:48 PM Changeset in webkit [57028] by eric@webkit.org
  • 9 edits
    1 delete in trunk

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp:
  • platform/chromium/DragImageRef.h:

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
3:23 PM Changeset in webkit [57027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] font fallback for generic fonts picks wrong font
​https://bugs.webkit.org/show_bug.cgi?id=37033

When a page specifies the generic "monospace" font and the user's
browser-configured monospace font doesn't exist, we previously relied
on getLastResortFallbackFont to eventually pick a monospace font for us.

But that doesn't quite work: WebKit first falls back to the user's
"preferred standard font" before hitting the last resort code path.
So if the above conditions hold but this font exists, we'll end up
never hitting the last resort codepath.

The fix is to allow OS-level font fallback when first attempting to
resolve monospace. The existing code tried to do this, but the logic
was wrong. We would eventually fall back to the correct font anyway
so we didn't notice the logic was wrong.

This code is all handling cases where particular fonts aren't installed,
so I can't think of a way to test it; existing tests should still pass.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
3:13 PM Changeset in webkit [57026] by eric@webkit.org
  • 6 edits in trunk/WebKit

2010-04-02 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):

2010-04-02 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
2:53 PM Changeset in webkit [57025] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-02 Ruben Van Boxem <​vanboxem.ruben@gmail.com>

Reviewed by Eric Seidel.

Mingw-w64 fixes for JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=35607

  • runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32) (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::currentThreadStackBase):
  • wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
2:21 PM Changeset in webkit [57024] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37043
Java regression tests spam stderr about being unable to set status message

With this change, there is still spam about "Attempt to access JavaScript from destroyed
applet, type 9." I haven't investigated if that indicates a problem or not.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): Removed check for _documentView. We don't seem to care.
2:18 PM Changeset in webkit [57023] by scherkus@chromium.org
  • 6 edits
    2 adds in trunk

2010-04-02 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
​https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Test: http/tests/media/video-play-suspend.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
​https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Currently Chromium is the only platform that fires the suspend event
hence most platforms skipping this test.

  • http/tests/media/video-play-suspend-expected.txt: Added.
  • http/tests/media/video-play-suspend.html: Added.
  • platform/gtk/Skipped: Doesn't fire a suspend event.
  • platform/mac/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
2:01 PM Changeset in webkit [57022] by Darin Adler
  • 3 edits in trunk/WebCore

Fix mispelling that broke the build.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:

Dashbard -> Dashboard.

1:40 PM Changeset in webkit [57021] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: updated the .def file.

1:31 PM Changeset in webkit [57020] by levin@chromium.org
  • 10 edits in trunk

(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
​https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

  • dom/CanvasSurface.cpp: Added methods for items that depended on

CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.

  • dom/CanvasSurface.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.

  • html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about

removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.

(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox

as it may become slightly more expensive in the future.

(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

  • fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test

to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

1:15 PM Changeset in webkit [57019] by ggaren@apple.com
  • 11 edits in trunk/JavaScriptCore

Inlined toThisString and toThisJSString to avoid virtual function call overhead
​https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSString.cpp:
  • runtime/JSString.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

  • runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

1:03 PM Changeset in webkit [57018] by eric@webkit.org
  • 14 edits
    2 adds in trunk

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
  • fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
  • platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setIsAttached):
  • html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached):
  • html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalformat): (WebCore::WebGLRenderbuffer::getInternalformat):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat. (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
  • html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
  • platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums. (WebCore::GraphicsContext3D::):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format. (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
12:55 PM Changeset in webkit [57017] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Stored focused frame and document in a vars, instead of querying for them many times.

Reviewed by Adam Treat.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):

12:51 PM Changeset in webkit [57016] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-02 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Beef up documentation for ASSERT* and CRASH macros a bit.

​https://bugs.webkit.org/show_bug.cgi?id=36527

  • wtf/Assertions.h:
12:21 PM Changeset in webkit [57015] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=36908

  • fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.
12:11 PM Changeset in webkit [57014] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKit/chromium

2010-04-02 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

The popup type (select or suggestion) is now passed to the
WebClient::createPopupMenu() method. This is required for
Chromium on Linux to make the select popups work correctly.
​https://bugs.webkit.org/show_bug.cgi?id=37013

  • WebKit.gyp:
  • public/WebPopupType.h: Added. (WebKit::):
  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened):
12:09 PM Changeset in webkit [57013] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
​https://bugs.webkit.org/show_bug.cgi?id=26241

  • fast/forms/button-state-restore.html: Updated for the behavior change.
  • fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
  • fast/forms/state-restore-to-non-edited-controls.html: Added.

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
​https://bugs.webkit.org/show_bug.cgi?id=26241

To fix this issue, we don't save values if it is not changed from
the default value.

Updating the value IDL attribute of some controls such as
type=hidden also updates the value content attribute, and it's
impossible to distinguish the initial value and the current
value. The values of such controls are not saved. It won't be a
problem because we want to save and restore user-edited values.

Test: fast/forms/state-restore-to-non-edited-controls.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): Do not save the value if it is same as the default value.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
11:31 AM Changeset in webkit [57012] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
​https://bugs.webkit.org/show_bug.cgi?id=36762

  • fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
  • fast/forms/state-restore-to-non-autocomplete-form.html: Added.

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
​https://bugs.webkit.org/show_bug.cgi?id=36762

Introduce Element::shouldSaveAndRestoreFormControlState() to check
if we should save and restore control state.

Test: fast/forms/state-restore-to-non-autocomplete-form.html

  • dom/Document.cpp: (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
  • dom/Element.h: (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::autoComplete): Added. It return autocomplete state of the form. (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Added. It returns the result of autoComplete(). (WebCore::HTMLFormControlElementWithState::finishParsingChildren): Do not restore state if shouldSaveAndRestoreFormControlState() is false.
  • html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::autoComplete): Reduce code by using autoComplete() of the parent class. (WebCore::HTMLInputElement::saveFormControlState): Remove the autoComplete() check. Document::formElementsState() does equivalent check.
11:03 AM Changeset in webkit [57011] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
​https://bugs.webkit.org/show_bug.cgi?id=37030

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't start with -.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout reason which starts with -.
  • Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
10:41 AM Changeset in webkit [57010] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Unreviewed.

Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.

  • Scripts/check-webkit-style:
    • Tweaked one line.
10:40 AM Changeset in webkit [57009] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
​https://bugs.webkit.org/show_bug.cgi?id=36994

r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
use this to avoid updating widget positions, and compositing layer positions when possible.

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • page/FrameView.h: (WebCore::FrameView::hasFixedObjects):
10:33 AM Changeset in webkit [57008] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-04-02 Nate Chapin <Nate Chapin>

Rubber-stamped by Dimitri Glazkov.

​http://trac.webkit.org/changeset/57004 caused
fast/dom/console-log-stack-overflow.html to fail for Chromium.
Add check for empty wrappers before using them to create a hidden reference.

  • bindings/scripts/CodeGeneratorV8.pm:
10:24 AM Changeset in webkit [57007] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Dirk Schulze <​krit@webkit.org>

Unreviewed.

[Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
​https://bugs.webkit.org/show_bug.cgi?id=37029

Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
the bug report from above.

  • platform/gtk/Skipped:
10:01 AM Changeset in webkit [57006] by eric@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-02 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
​https://bugs.webkit.org/show_bug.cgi?id=36858

Add failing results for Tiger to make the Tiger bot green.
We may wish to actually fix Tiger at some point.

  • platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.
9:45 AM Changeset in webkit [57005] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix for DumpRenderTree after addition of layerTreeAsText.

9:40 AM Changeset in webkit [57004] by Nate Chapin
  • 14 edits
    4 deletes in trunk/WebCore

2010-04-01 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generalize (and generate!) the creation of hidden references
between JS wrappers.


​https://bugs.webkit.org/show_bug.cgi?id=36777

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in attribute getters.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a hidden reference on a global object. (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs. (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/WrapperTypeInfo.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8ScreenCustom.cpp: Removed.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::frame): Add frame() accessor.
8:43 AM Changeset in webkit [57003] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-04-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: start editing DOM and styles on click-and-pause (part 1).

​https://bugs.webkit.org/show_bug.cgi?id=36965

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onattach): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._handleClickAndPause): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause): (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick): (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent): (WebInspector.StylePropertyTreeElement.prototype.onattach): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:
  • inspector/front-end/treeoutline.js: (TreeElement.prototype._attach): (TreeElement.treeElementMouseDown): (TreeElement.prototype.selectOnMouseDown):
8:07 AM Changeset in webkit [57002] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Darin Fisher <​darin@chromium.org>

Add chromium suppression for http/tests/xhtmlmp since we do not support
this feature.

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [57001] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed, minor build fix.

Change the order of the member initialisation list
in constructor to match declaration order

  • runtime/Collector.cpp: (JSC::Heap::Heap):
6:41 AM WebKit Team edited by chang.shu@nokia.com
(diff)
6:05 AM Changeset in webkit [57000] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix when building --no-svg.

Build fix after r56941. Add ENABLE(SVG) guard.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
5:55 AM Changeset in webkit [56999] by yurys@chromium.org
  • 14 edits
    1 copy
    1 add in trunk

2010-04-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendHost::showContextMenu for Chromium.


Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.


​https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebCore.Inspector.exp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient): (WebCore::InspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):

2010-04-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl.

​https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebKit.gyp:
  • src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/InspectorFrontendClientImpl.h: Added.
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
  • src/js/DevTools.js: ():
5:18 AM Changeset in webkit [56998] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955,
but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."

  • platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.
5:17 AM Changeset in webkit [56997] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-04-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline Overview pane should support short records filtering.
​https://bugs.webkit.org/show_bug.cgi?id=37020

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):
4:25 AM Changeset in webkit [56996] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Platform specific expected file added for test introduced in r56775,
because it passes. Compared to png file and Mac expected file.

  • platform/qt/svg/custom/animation-currentColor-expected.txt: Added.
3:10 AM Changeset in webkit [56995] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Update the expectation for fast/dom/HTMLProgressElement/set-progress-properties.html

2:31 AM Changeset in webkit [56994] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Add a simple test that fails if XHTML-MP mime
type is not accepted.

  • http/conf/mime.types: Register XHTML-MP mime type with the test server
  • http/tests/xhtmlmp: Added.
  • http/tests/xhtmlmp/xhtml-expected.txt: Added.
  • http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase with the newly registered file extension.

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Enable processing XHTML-MP mime type as an XHTML document
even if XHTML-MP support is not enabled.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Register xhtmlmp file extension as the new type
for XHTML-MP test content.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2:20 AM Changeset in webkit [56993] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout doesn't fill out ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=37010

The contract between apply_reverse_diff and PrepareChangeLogForRevert
was unclear. I broke filling out the ChangeLog during rollout earlier
when I changed apply_reverse_diff to revert the ChangeLogs because
PrepareChangeLogForRevert thought that it was supposed to do that.
I've now taught PrepareChangeLogsForRevert the new contract.

It's unclear to me how to test this change because it's essentially an
integration issue that requires the file system. At some point we
should think about a testing strategy for integration. As the system
becomes larger, we're running into more of these issues.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2:10 AM Changeset in webkit [56992] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews to QueueStatusServer
​https://bugs.webkit.org/show_bug.cgi?id=37004

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
2:00 AM Changeset in webkit [56991] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Make XSSAuditor go fast with large POST data
​https://bugs.webkit.org/show_bug.cgi?id=36694

There were two things slowing down this bechmark:

1) Searching the large POST data for each inline event handler. To

make this faster, we now use a suffix tree to fast-reject strings
that don't appear as substrings of the POST data.

2) The next largest cost was flattening the form data into a string.

To make this fater, we now use the form data object itself as a key
and only flatten once.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::CachingURLCanonicalizer::clear): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
  • platform/text/SuffixTree.h: Added. (WebCore::UnicodeCodebook::codeWord): (WebCore::UnicodeCodebook::): (WebCore::ASCIICodebook::codeWord): (WebCore::ASCIICodebook::): (WebCore::SuffixTree::SuffixTree): (WebCore::SuffixTree::mightContain): (WebCore::SuffixTree::Node::Node): (WebCore::SuffixTree::Node::~Node): (WebCore::SuffixTree::Node::at): (WebCore::SuffixTree::build):
1:33 AM Changeset in webkit [56990] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Kent Tamura <​tkent@chromium.org>

Unreviewed test fix. Follow the behavior change by r56962.

  • editing/selection/4960137.html:
1:31 AM Changeset in webkit [56989] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-02 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 36741 - Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
​https://bugs.webkit.org/show_bug.cgi?id=36741

Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
Update PositionIterator::isCandidate() to mirror Position::isCandidate().

Rationale: PositionIterator::isCandidate() is called in a tight loop within
next/previousCandidate(). Also, creation of a PositionIterator from a Position
is cheaper than vice-versa.

Tests: ran all tests in 'editing'.

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
1:31 AM Changeset in webkit [56988] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Unit-test networktransaction.py's log messages, and add a base
class to make unit-testing log messages even easier.

​https://bugs.webkit.org/show_bug.cgi?id=36958

The purpose of this patch is also to provide a mini-tutorial on
how to unit-test Python logging.py messages.

  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
    • Unit-tested the log messages in test_retry().
  • Scripts/webkitpy/common/system/logtesting.py:
    • Adjusted the LogTesting class by moving the code that clears the array of log messages into a finally block. This prevents redundant AssertionErrors from getting rendered to the screen while running unit tests.
    • Added a LoggingTestCase class so the setUp() and tearDown() methods do not need to be implemented in order to test logging. Rather, TestCase classes can simply inherit from this class.
1:27 AM Changeset in webkit [56987] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Re-wrote check-webkit-style's argument parsing code to use
Python's optparser module and more uniform error-handling logic.

​https://bugs.webkit.org/show_bug.cgi?id=34676

  • Scripts/webkitpy/style/optparser.py:
    • Removed "option help" from check-webkit-style's usage string since that is provided separately by the OptionParser class.
    • Also changed the usage string from a function to a constant string _USAGE.
    • Added an _EPILOG string which renders after OptionParser's usage string and option help.
    • In the ArgumentParser class:
      • Changed the constructor's stderr_write parameter to a mock_stderr since the OptionParser accepts a sys.stderr substitute rather than a sys.stderr.write substitute.
      • Changed the constructor to set a _parser data attribute with an OptionParser instance.
      • Added a _create_option_parser() method which instantiates the OptionParser.
      • Updated _exit_with_help() to interact with the OptionParser's help method.
      • Updated the parse() method as necessary. Also changed the raising of ValueErrors to calls to _exit_with_help().
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Removed the CreateUsageTest class since the create_usage method was replaced by a constant string.
    • Added a _MockStdErr class to the ArgumentParserTest class.
    • Updated the unit tests as necessary.
1:18 AM Changeset in webkit [56986] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The master commit-queue process should take responsibility for checking that the builders are green
​https://bugs.webkit.org/show_bug.cgi?id=37009

We had a failure where the child process noticed that the builders were
red. We've always had this race condition, but the new optimistic
design made it easier to trigger.

  • Scripts/webkitpy/tool/commands/queues.py:
1:18 AM Changeset in webkit [56985] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak rollout changelog to pass ValidateReviewer check
​https://bugs.webkit.org/show_bug.cgi?id=37019

We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
1:16 AM Changeset in webkit [56984] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_SETTINGS
​https://bugs.webkit.org/show_bug.cgi?id=36533

If QT_NO_SETTINGS is defined, QSettings is not available.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting):
1:13 AM Changeset in webkit [56983] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Removed duplicate ChangeLog entry.

1:04 AM Changeset in webkit [56982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Eric Seidel <​eric@webkit.org>

Unreviewed, just updating expected results for passing tests.

suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=36620

Remove several tests marked MISSING which no longer seem to be missing.

  • platform/mac/test_expectations.txt:
1:03 AM Changeset in webkit [56981] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

To the Python 2.4 error message, added a link to the wiki page
that contains instructions on how to upgrade.

  • Scripts/test-webkitpy:
    • Eliminated a use of the ternary operator in configure_logging() to let the version warning display in case of Python 2.4.
  • Scripts/webkitpy/python24/versioning_unittest.py:
    • Updated unit test text.
12:39 AM Changeset in webkit [56980] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-02 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - customized popup for <select multiple> elements
​https://bugs.webkit.org/show_bug.cgi?id=36368

Using QtMaemoWebPopup instead of QtFallbackWebPopup for Maemo.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
12:30 AM Changeset in webkit [56979] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=36933

Change the test design in an attempt to get this passing on Tiger. In
this variation, we use a POST request to work around possible caching
issues in Tiger's CFNetwork.

  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html:
12:25 AM Changeset in webkit [56978] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Database code falsely returns errors due to errant pointer check
​https://bugs.webkit.org/show_bug.cgi?id=37014

Reviewed by Dan Bernstein.

r56943 introduced a check to see if there were any unprocessed
SQL commands after calling sqlite3_prepare16_v2.

Accessing the remaining data via pointer wasn't possible since
the query string is deallocated immediately after the
query runs. The String returned from strippedWhiteSpace
goes out of scope at that point.

Fix is to store the strippedWhiteSpace in a temporary String
so we can access it via character ptr later in the function.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

12:14 AM Changeset in webkit [56977] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Record the IRC nick of folks who request rollouts
​https://bugs.webkit.org/show_bug.cgi?id=36999

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
12:04 AM Changeset in webkit [56976] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews
​https://bugs.webkit.org/show_bug.cgi?id=36974

Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Apr 1, 2010:

11:44 PM Changeset in webkit [56975] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Using a failure exit code when failing to load a required import
​https://bugs.webkit.org/show_bug.cgi?id=37000

Well spotted by Mark Rowe.

  • Scripts/webkitpy/common/system/user.py:
11:34 PM Changeset in webkit [56974] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

setting document.title doesn't change document.title value
​https://bugs.webkit.org/show_bug.cgi?id=36802

  • fast/dom/Document/script-tests/title-with-multiple-children.js: Added.
  • fast/dom/Document/title-with-multiple-children-expected.txt: Added.
  • fast/dom/Document/title-with-multiple-children.html: Added.

2010-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

setting document.title doesn't change document.title value
​https://bugs.webkit.org/show_bug.cgi?id=36802

An entity of "value" argument on HTMLTitleElement::setTitle() could be
Document::m_title and be changed during HTMLTitleElement::setText().
Fix copying the argument to keep the original value.

Test: fast/dom/Document/title-with-multiple-children.html

  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::setText):
11:15 PM Changeset in webkit [56973] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

Rewrote the revision (r56942) to disable the 79 character line
length limit Python/PEP8 style check.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33639#c39

This rewrite puts the disabling not in the PythonProcessor but
in the calling code's default filter rule configuration. This
allows the user to check line-length style from the command-line
if desired.

  • Scripts/webkitpy/style/checker.py:
    • Added "-pep8/E501" to the _BASE_FILTER_RULES configuration variable to disable the line-length check.
    • Added "-pep8/E501" to the list of recognized style categories to permit the category to be checked from the command line.
11:09 PM Changeset in webkit [56972] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-01 Jay Civelli <​jcivelli@google.com>

Reviewed by David Levin.

Adds a method to WebFrame to execute JavaScript and get the value
it evaluates to.
​https://bugs.webkit.org/show_bug.cgi?id=36907

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptAndReturnValue):
  • src/WebFrameImpl.h:
10:35 PM Changeset in webkit [56971] by krit@webkit.org
  • 1 edit
    3 moves
    1 add in trunk/LayoutTests

2010-04-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move some SVG mac results to the SVG base directory, to give other platforms like Gtk
access to them.
Gtk needs a platform specific result for feColorMatrix-values.

  • platform/gtk/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/mac/svg/custom/animation-currentColor-expected.txt: Removed.
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Removed.
  • svg/custom/animation-currentColor-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/animation-currentColor-expected.txt.
  • svg/custom/glyph-transformation-with-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt.
  • svg/custom/gradient-with-1d-boundingbox-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt.
10:33 PM Changeset in webkit [56970] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-01 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - <select multiple> custom rendering
​https://bugs.webkit.org/show_bug.cgi?id=36369

Customizing rendering of <select multiple> elements in Maemo5.

  • platform/qt/Maemo5Webstyle.cpp: (Maemo5WebStyle::drawMultipleComboButton): (Maemo5WebStyle::drawSimpleComboButton): (Maemo5WebStyle::getButtonImageSize): (Maemo5WebStyle::findComboButton): (Maemo5WebStyle::drawComplexControl):
  • platform/qt/Maemo5Webstyle.h:
10:24 PM Changeset in webkit [56969] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is a follow up to commit r56906. The fourth filter example,
feMorphology, shouldn't be displayed. filterRes causes a scaling of the filter
parameters, so that one value of 'radius' is lower than one.
The spec want us to round filter values down and a value of zero
for 'radius' stops the rendering process of feMorphology.

  • platform/mac/svg/filters/filterRes-expected.png:
10:22 PM Changeset in webkit [56968] by eric@webkit.org
  • 24 edits
    2 adds in trunk

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add EANBEL_FILE_READER and ENABLE_FILE_WRITER flags.

  • configure.ac:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.

  • Configurations/FeatureDefines.xcconfig:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add FileThread for async file operation support for FileReader and
FileWriter. The patch also adds ENABLE_FILE_READER or
ENABLE_FILE_WRITER build flags/defines. Both flags are disabled
by default.

No new tests, will add ones when after adding modules which use the thread.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::fileThread):
  • dom/ScriptExecutionContext.h:
  • html/FileThread.cpp: Added. (WebCore::FileThread::FileThread): (WebCore::FileThread::~FileThread): (WebCore::FileThread::start): (WebCore::FileThread::stop): (WebCore::FileThread::postTask): (WebCore::SameFilePredicate::SameFilePredicate): (WebCore::SameFilePredicate::operator()): (WebCore::FileThread::removeTask): (WebCore::FileThread::fileThreadStart): (WebCore::FileThread::runLoop):
  • html/FileThread.h: Added. (WebCore::FileThread::create): (WebCore::FileThread::Task::Task): (WebCore::FileThread::Task::~Task): (WebCore::FileThread::Task::fileHandle):
  • platform/Logging.cpp: (WebCore::): (WebCore::getChannelFromName):
  • platform/Logging.h:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.

  • features.gypi:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add FILE_READER or FILE_WRITER feature defines.

  • Configurations/FeatureDefines.xcconfig:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Adds ENABLE_FILE_READER and ENABLE_FILE_WRITER feature flags
for FileReader and FileWriter support.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-04-01 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36896

Add options to enable FILE_READER and FILE_WRITER support.

  • Scripts/build-webkit:
10:22 PM Changeset in webkit [56967] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding flaky tests to test_expectations.

Mark fast/dom/global-constructors.html and
fast/tokenizer/doctype-search-reset.html as flaky when run
under new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=35006
​https://bugs.webkit.org/show_bug.cgi?id=37007

  • platform/mac/test_expectations.txt:
9:46 PM Changeset in webkit [56966] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Kent Tamura <​tkent@chromium.org>

Unreviewed. Add missing license header.

  • DumpRenderTree/chromium/TestShellMac.mm:
9:38 PM Changeset in webkit [56965] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk

2010-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed. Rollout of ​http://trac.webkit.org/changeset/56930
​https://bugs.webkit.org/show_bug.cgi?id=36977

We suspect that this change broke aria-liveregions-notifications

  • platform/mac/accessibility/area-with-aria-label-expected.txt: Removed.
  • platform/mac/accessibility/area-with-aria-label.html: Removed.

2010-04-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed. Rollout of ​http://trac.webkit.org/changeset/56930
​https://bugs.webkit.org/show_bug.cgi?id=36977

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::accessibilityDescription):
9:31 PM Changeset in webkit [56964] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Improve the error handling in rollout a bit
​https://bugs.webkit.org/show_bug.cgi?id=36995

This patch does a few things to make the error handling in rollout a
bit more robust.

  • Scripts/webkitpy/common/checkout/api.py:

The old logic here was wrong. We don't want to resolve the
ChangeLogs (that would remove the old ChangeLog entry). Instead,
we want to revert the ChangeLogs so we can fill them with the new
message.

  • Scripts/webkitpy/tool/commands/download_unittest.py:

Update test expectations because we're using a different mock object.

  • Scripts/webkitpy/tool/commands/download.py:
    • Added an update command to make updating from the SheriffBot more robust.
    • Now that we have CommitInfo, we can automatically CC the responsible parties on the bug we create.
    • Re-ordered the steps in create-rollout. Our original thinking was that we always wanted to create the bug, but that's not really true given how things appear to be playing out. If we fail to apply the reverse diff, we don't want to create the bug.
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Use the new, more robust update command.
  • Scripts/webkitpy/tool/steps/createbug.py:

Allow commands to pre-load who they want to be CCed on a new bug.

8:37 PM Changeset in webkit [56963] by tkent@chromium.org
  • 1 edit
    7 adds in trunk/WebKitTools

2010-04-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
​https://bugs.webkit.org/show_bug.cgi?id=36814

This change introduces:

  • WebViewHost class It's an implementation of some delegates required by Chromium WebKit API, and manages painting of a WebView. It's base on src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of Chromium rev.40492.
  • TestShell class The TestShell instance holds global states of DumpRenderTree process. Unlike TestShell class of Chromium test_shell, TestShell instance is created just once.
  • DumpRenderTree.cpp The program entry.
  • DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
  • DumpRenderTree/chromium/TestShell.cpp: Added.
  • DumpRenderTree/chromium/TestShell.h: Added.
  • DumpRenderTree/chromium/TestShellMac.mm: Added.
  • DumpRenderTree/chromium/WebViewHost.cpp: Added.
  • DumpRenderTree/chromium/WebViewHost.h: Added.
  • DumpRenderTree/chromium/config.h: Added.
8:14 PM Changeset in webkit [56962] by tkent@chromium.org
  • 6 edits
    6 adds in trunk

2010-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
​https://bugs.webkit.org/show_bug.cgi?id=36800

  • editing/selection/DOMSelection-DocumentType-expected.txt: Added.
  • editing/selection/DOMSelection-DocumentType.html: Added.
  • editing/selection/DOMSelection-crossing-document-expected.txt: Added.
  • editing/selection/DOMSelection-crossing-document.html: Added.
  • editing/selection/drag-in-iframe.html: Updated to follow follow behaviour change.
  • editing/selection/script-tests/DOMSelection-DocumentType.js: Added.
  • editing/selection/script-tests/DOMSelection-crossing-document.js: Added. (makeEditableDocument): (clear):

2010-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
​https://bugs.webkit.org/show_bug.cgi?id=36800

Added guards nodes from foreign documents to DOMSelection APIs.

Tests: editing/selection/DOMSelection-DocumentType.html

editing/selection/DOMSelection-crossing-document.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::isValidForPosition):
  • page/DOMSelection.h:
7:54 PM Changeset in webkit [56961] by tkent@chromium.org
  • 5 edits in trunk

Unreviewed. Roll out r56959 because of some test failures

6:45 PM Changeset in webkit [56960] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

sheriffbot rollout should verify that the svn revision is a number.
​https://bugs.webkit.org/show_bug.cgi?id=37001

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
  • Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision is a number. Fixed the imports (since the files uses ScriptError and log) and a typo.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify the behavior.
6:37 PM Changeset in webkit [56959] by yuzo@google.com
  • 5 edits in trunk

2010-04-01 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
​https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.

2010-04-01 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per ​http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
​https://bugs.webkit.org/show_bug.cgi?id=36276

Test: fast/css/invalid-not-with-simple-selector-sequence.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
6:25 PM Changeset in webkit [56958] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-01 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Eric Seidel.

[chromium] FindInPage on multi-frame pages wasn't always updating
tickmarks on scrollbars for the subframes. It was calling invalidateRect
on the View and specifying a rect that's in window coordinates, whereas
the invalidateRect expects frame coordinates.

​https://bugs.webkit.org/show_bug.cgi?id=36982

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::invalidateArea):
6:14 PM Changeset in webkit [56957] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Print an error message for readline bogosity in MacPorts
​https://bugs.webkit.org/show_bug.cgi?id=36979

  • Scripts/webkitpy/common/system/user.py:
5:44 PM Changeset in webkit [56956] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-04-01 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add test for XSLT NULL crash:
​https://bugs.webkit.org/show_bug.cgi?id=36804

  • LayoutTests/fast/xsl/xslt-bad-import-uri.html: added
  • LayoutTests/fast/xsl/xslt-bad-import-uri-expected.txt: added
  • LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xml: added
  • LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xsl: added

2010-04-01 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Fix a NULL pointer crash if @import fails to load a stylesheet.

​https://bugs.webkit.org/show_bug.cgi?id=36804

Test: fast/xsl/xslt-bad-import-uri.html

  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString): Handle an empty string gracefully. An empty string has a NULL buffer, which we pass in to xmlCreateMemoryParserCtxt(). It returns NULL if it is passed a NULL buffer. In the top-level XSL case, the current code does not crash "by luck" because the other APIs used can handle a NULL argument. In the @import case, additional code runs which will deference the NULL.
5:26 PM Changeset in webkit [56955] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36854
<rdar://problem/7811668> REGRESSION (r47291): Body from cross origin preflight response
is prepended to the actual response body

Tests: http/tests/xmlhttprequest/access-control-response-with-body-sync.html

http/tests/xmlhttprequest/access-control-response-with-body.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData): Don't send data to the client when handling a preflight request.
5:13 PM Changeset in webkit [56954] by adachan@apple.com
  • 6 edits in trunk

WebCore: Change DatabaseTracker::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for DatabaseTracker::deleteDatabase().

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36988

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):

  • storage/DatabaseTracker.h:

WebKit/mac: Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for WebDatabaseManager::deleteDatabase().

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36988

  • Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager deleteOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):

  • Storage/WebDatabaseManagerPrivate.h:
4:58 PM Changeset in webkit [56953] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-04-01 Simon Fraser <Simon Fraser>

No review.

Remove some casts that I indended to remove before committing r56948.

  • rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
4:54 PM Changeset in webkit [56952] by cmarrin@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

Attempt to fix GTK LayoutTestController build

4:52 PM Changeset in webkit [56951] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't pass --non-interactive to create-rollout
​https://bugs.webkit.org/show_bug.cgi?id=36989

It turns out you can't pass --non-interactive to create-rollout. Also,
improve our error reporting slighly to catch the case where we error
out after creating the rollout bug.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
4:49 PM Changeset in webkit [56950] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch can incorrectly think the working directory is modified
​https://bugs.webkit.org/show_bug.cgi?id=36985

If a file's modification time is modified, but the contents are not,
then diff-index will think the file has been modified unless you do
some crazy update-index call. Instead, call diff --name-only, which
has the index update builtin.

Tried to write a test, but could not reproduce this in a unittest.
To test manually:

touch file-in-repo
git diff-index HEAD
git diff HEAD --name-only

The diff-index call incorrectly shows file-in-repo as modified.

  • Scripts/webkitpy/common/checkout/scm.py:
4:42 PM Changeset in webkit [56949] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Assertion failure (willBeComposited == needsToBeComposited(layer)) in
RenderLayerCompositor::computeCompositingRequirements() on hulu.com
​https://bugs.webkit.org/show_bug.cgi?id=36516

Fix assertions added in r56017. That changed replaced calls to needsToBeComposited()
with use of the local 'willBeComposited' variable, but that fails to take into
account the fact that needsToBeComposited() also tests layer->isSelfPaintingLayer().

Fix by adding a canBeComposited() method that we call before testing
whether the layer should go into compositing mode.

Test: compositing/self-painting-layers2.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): Repace use of isSelfPaintingLayer() with a call to canBeComposited(). (WebCore::RenderLayerCompositor::computeCompositingRequirements): Call canBeComposited() to ensure that we only toggle 'willBeComposited' for layers that can. (WebCore::RenderLayerCompositor::needsToBeComposited): Call canBeComposited(). (WebCore::RenderLayerCompositor::canBeComposited): Test if compositing is enabled, and whether the layer is self-painting.
  • rendering/RenderLayerCompositor.h: Add canBeComposited().
4:38 PM Changeset in webkit [56948] by Simon Fraser
  • 6 edits in trunk/WebCore

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36980
Add object addresses to debug showLayerTree() output.

Add the ability to print RenderLayer and RenderObject addresses in the showLayerTree()
output.

  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<):
  • platform/text/TextStream.h:
  • rendering/RenderLayer.cpp: (showLayerTree):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
  • rendering/RenderTreeAsText.h:
4:34 PM Changeset in webkit [56947] by abarth@webkit.org
  • 8 edits
    1 copy
    1 add in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add rollout command to sheriffbot
​https://bugs.webkit.org/show_bug.cgi?id=36986

This IRC command creates a new bug an attaches a rollout patch. To
actually commit the rollout, a committer needs to mark the patch
commit-queue+ in bugs.webkit.org.

Also, factored out some of the logic from the queue into a separate
object for easier testing.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py: Added.
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3:57 PM Changeset in webkit [56946] by cmarrin@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Backed out change to run-webkit-tests accidentally checked in

3:54 PM Changeset in webkit [56945] by cmarrin@apple.com
  • 2 edits in trunk

Skipping compositing/geometry/preserve-3d-switching.html test on Leopard until we can fix ​https://bugs.webkit.org/show_bug.cgi?id=36984

3:53 PM Changeset in webkit [56944] by ojan@chromium.org
  • 2 edits in trunk

2010-04-01 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

autoinstalled should be git ignored
​https://bugs.webkit.org/show_bug.cgi?id=36970

  • .gitignore:
3:45 PM Changeset in webkit [56943] by dumi@chromium.org
  • 3 edits
    2 adds in trunk

WebCore: Changing SQLiteStatement::prepare() to return an error when it's
given a string that has more than one statement in it. Currently,
everything past the first statement is silently ignored.

Reviewed by Dimitri Glazkov.

Test: storage/executesql-accepts-only-one-statement.html

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

LayoutTests: Testing that executeSql() accepts only one-statement strings.

Reviewed by Dimitri Glazkov.

  • storage/executesql-accepts-only-one-statement-expected.txt: Added.
  • storage/executesql-accepts-only-one-statement.html: Added.
3:39 PM Changeset in webkit [56942] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Eric Seidel <​eric@webkit.org>

Unreviewed, only ignoring chatty style errors.

check-webkit-style: WebKit needs a python style checker
​https://bugs.webkit.org/show_bug.cgi?id=33639

Remove the 79 char line limit by ignoring
pep8/E501. Because we have our own report_error
implementation we have to ignore E501 by hand
instead of passing --ignore=E501.

Right now over 1400 lines of our existing python
fail E501 so this rule just generates needless noise.
The rest of WebKit has no wrapping rule so it makes
little sense for our Python to differ here.

  • Scripts/webkitpy/style/processors/python.py:
3:21 PM Changeset in webkit [56941] by jamesr@google.com
  • 10 edits
    8 adds in trunk

2010-04-01 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Keeps a transient optimistic offset to the root in RenderLayer::updateLayerPositions
​https://bugs.webkit.org/show_bug.cgi?id=33520

RenderLayer::updateLayerPositions() makes a recursive walk through all RenderLayers and updates the repaint rectangles on each.
These rectangles have to be calculated in the repaint container's coordinates using RenderObject::mapLocalToContainer to walk
up to the repaint container. This patch keeps track of the offset to the root and uses that offset instead of walking back up to
the root every time.

Tests: fast/layers/nested-layers-1.html

fast/layers/nested-layers-2.html
fast/layers/nested-layers-3.html
fast/layers/nested-layers-4.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::outlineBoundsForRepaint):
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
  • rendering/RenderSVGModelObject.h:

2010-04-01 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Mapping from local to container coord space in updateLayerPositions is quadratic
​https://bugs.webkit.org/show_bug.cgi?id=33520

These tests move layers around in various ways to test that the offset caching in
updateLayerPositions() is correct.

  • fast/layers/nested-layers-1-expected.txt: Added.
  • fast/layers/nested-layers-1.html: Added.
  • fast/layers/nested-layers-2-expected.txt: Added.
  • fast/layers/nested-layers-2.html: Added.
  • fast/layers/nested-layers-3-expected.txt: Added.
  • fast/layers/nested-layers-3.html: Added.
  • fast/layers/nested-layers-4-expected.txt: Added.
  • fast/layers/nested-layers-4.html: Added.
3:06 PM Changeset in webkit [56940] by dbates@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2010-04-01 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36901

Removed functions Range::operator == and Range::operator != as they
were using C++ code that was not sound and hence may have undefined
behavior.

Test case: manual-tests/crash-on-find-with-no-selection.html

  • dom/Range.cpp: (WebCore::areRangesEqual): Added.
  • dom/Range.h:
  • editing/markup.cpp: (WebCore::createMarkup): Modified to call WebCore::areRangesEqual.
  • manual-tests/crash-on-find-with-no-selection.html: Added.
  • page/Frame.cpp: (WebCore::Frame::findString): Modified to call WebCore::areRangesEqual.
2:57 PM Changeset in webkit [56939] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild of Interfaces

2:43 PM Changeset in webkit [56938] by cmarrin@apple.com
  • 3 edits in trunk

Fixed Windows (and hopefully Tiger) build

2:15 PM Changeset in webkit [56937] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Unreviewed. Add cmarrin's IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
2:10 PM Changeset in webkit [56936] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Unreviewed.

EWS spins hot when unable to build
​https://bugs.webkit.org/show_bug.cgi?id=36981

The problem is that the queue engine things we have more work to do,
but the bot isn't actually able to do anything. After this change, we
back off the usual amount.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
1:59 PM Changeset in webkit [56935] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't there to catch potential future attempts to store empty/deleted values before these happen - it's actually wrong to try to look up these values. Added an early return. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
1:15 PM Changeset in webkit [56934] by cmarrin@apple.com
  • 18 edits
    2 adds in trunk

Added layerTreeAsText function to DRT (for Mac)
​https://bugs.webkit.org/show_bug.cgi?id=36782

1:11 PM Changeset in webkit [56933] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Synchronous rendering when setting form control values slows down JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=36967

Reviewed by Sam Weinig.

This patch basically reverts ​http://trac.webkit.org/changeset/19006.

Dan asked me to investigate why 19006 is no longer needed. I have two answers:

(1) I was also able to remove the synchronous call to updateFromElement().
That call was the proximate cause of the crash that 19006 fixed.

(2) updateFromElement() no longer calls HTMLElement::setInnerText()
in the way that it used to. (However, it doesn't seem prudent to
rely on this happy coincidence.)

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Simplified some logic here. Moved
setNeedsValidityCheck() outside of individual 'if' clauses, since they all
called it.

Removed call to updateStyleIfNeeded(), which does rendering synchronously,
since that was the performance problem. (setNeedsStyleRecalc() ensures
that rendering will happen asynchronously.) Also removed comment about
ordering dangers introduced by updateStyleIfNeeded().

Removed call to updateFromElement(), since it's dangerous and also a minor
performance problem. (setNeedsStyleRecalc() ensures that updateFromElement()
will happen asynchronously, too.)

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setNonDirtyValue): Ditto. Here, I had to
add a call to setNeedsStyleRecalc(), since there wasn't one before.

12:59 PM Changeset in webkit [56932] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), because the latter fails with an assertion when looking up 0 or -1. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected object IDs coming from plug-in host.
12:58 PM Changeset in webkit [56931] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Sometimes js code can detach page from it's frame and in that case
Dispatch Events will stay in the TimelineAgent's events stack. Only immediate events will
appear at frontend.
​https://bugs.webkit.org/show_bug.cgi?id=36890

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
12:46 PM Changeset in webkit [56930] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 36977 - aria-label doesn't work on image map area
​https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

  • platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/area-with-aria-label.html: Added.
12:36 PM Changeset in webkit [56929] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-01 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add Single and Multiple Selection Popup for Maemo 5.

[Qt] Maemo5 theme - popup dialogs
​https://bugs.webkit.org/show_bug.cgi?id=36789

  • WebCoreSupport/QtMaemoWebPopup.cpp: (WebCore::Maemo5Popup::populateList): (WebCore::Maemo5Popup::onItemSelected): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup): (WebCore::MultipleItemListDelegate::MultipleItemListDelegate): (WebCore::MultipleItemListDelegate::paint): (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
  • WebCoreSupport/QtMaemoWebPopup.h:
12:23 PM Changeset in webkit [56928] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Part of:
REGRESSION(56394):
http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
fails on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=36934

  • http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Add more explicit failing messages to help find out what is failing.
11:54 AM Changeset in webkit [56927] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after addition of JavaScriptCore/wtf/text directory.

11:46 AM Changeset in webkit [56926] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

REGRESSION(56489): security/block-test.html fails on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=36932

It appears that r56489 just forgot to update the Tiger results
to include the new parts of the test. Tiger has had custom
results for this test since r54193.

I just pulled these off the bot. I do not have the domain knowledge
to know if these are right or not. They look fine to me.

  • platform/mac-tiger/security/block-test-expected.txt:
11:37 AM Changeset in webkit [56925] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=36908

  • fast/canvas/webgl/script-tests/index-validation.js: Disable antialias for this test.
11:19 AM Changeset in webkit [56924] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Assertion failure: !repaintContainer
repaintContainer == this

​https://bugs.webkit.org/show_bug.cgi?id=36672

RenderText's implementation of clippedOverflowRectForRepaint() uses containingBlock()
to get the renderer to use for computing the repaint rect. However, the renderer returned
by containingBlock() may be an ancestor of the repaintContainer, and containingBlock()
doesn't have the 'repaintContainerSkipped' logic that container() has.

So in this case, check to see whether repaintContainer is actually a descendant of the
containing block, and in that case just repaint the entire repaintContainer.

Test: compositing/repaint/inline-repaint-container.html

  • rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint):
11:05 AM Changeset in webkit [56923] by eric@webkit.org
  • 2 edits in trunk

2010-04-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Add -Wextra warning level to the QtWebKit build
​https://bugs.webkit.org/show_bug.cgi?id=36971

  • WebKit.pri:
10:49 AM WebKit Team edited by jianli@chromium.org
(diff)
10:49 AM Changeset in webkit [56922] by Csaba Osztrogonác
  • 3 edits in trunk/WebCore

[Qt] REGRESSION(r56869): Windows build is broken
​https://bugs.webkit.org/show_bug.cgi?id=36929

Reviewed by Jian Li.

  • WebCore.pro: LIBS += -lOle32 added.
  • platform/UUID.cpp: Define ARRAYSIZE macro if it isn't defined before.
10:31 AM Changeset in webkit [56921] by jianli@chromium.org
  • 2 edits in trunk/WebKitTools

Rubber-stamped by David Levin.

Add myself to the reviewers list.

  • Scripts/webkitpy/common/config/committers.py:
10:17 AM Changeset in webkit [56920] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 36968 - 1 crash in Safari at com.apple.WebCore: WebCore::Element::getAttribute const
​https://bugs.webkit.org/show_bug.cgi?id=36968

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/crash-with-noelement-selectbox.html

When a <select> element had no options, the selectedIndex == -1 and that was being
used to index into an empty array.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):

LayoutTests:

  • accessibility/crash-with-noelement-selectbox-expected.txt: Added.
  • accessibility/crash-with-noelement-selectbox.html: Added.
10:10 AM Changeset in webkit [56919] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Unreviewed.

Turns out the Chromium Windows bots don't have pdevenv installed.

  • Scripts/webkitdirs.pm:
9:54 AM Changeset in webkit [56918] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Let Chromium Windows build with Visual Studio Express
​https://bugs.webkit.org/show_bug.cgi?id=36919

This is horrible, horrible copy/paste code, but that seems to be the
way of webkitdirs.pm. :(

Someone needs to go through an cleanup this code, but I don't have the
heart to do it in this patch.

  • Scripts/webkitdirs.pm:
9:45 AM Changeset in webkit [56917] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-01 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

[chromium] FindInPage should clear the focused node when a match has
been found. This is because WebFrameImpl::setFocus will try to refocus
editable elements if it thinks they have focus, causing the page to
scroll.

​https://bugs.webkit.org/show_bug.cgi?id=36923

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find):
9:07 AM Changeset in webkit [56916] by kov@webkit.org
  • 4 edits
    1 add in trunk

2010-04-01 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] webkit_get_default_session() should make sure webkit_init() is called
​https://bugs.webkit.org/show_bug.cgi?id=36754

Make sure global functions that do not require a WebKitWebView to
be created call webkit_init() before doing their job. Also add an
API test to check for that.

  • tests/testglobals.c: Added. (test_globals_default_session): (main):
  • webkit/webkitwebview.cpp: (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model):
8:14 AM Changeset in webkit [56915] by hamaji@chromium.org
  • 4 edits in trunk/WebCore

2010-04-01 MORITA Hajime <​morrita@google.com>

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=36948
Refactoring: Position::primaryDirection() should be extracted.

No new tests. No functinal change.

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): (WebCore::Position::primaryDirection): Added
  • dom/Position.h:
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
8:03 AM Changeset in webkit [56914] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKit

2010-04-01 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL's pkg-config metadata file file to efl/.
​http://webkit.org/b/36766

  • efl/ewebkit.pc.in: Added.
7:46 AM Changeset in webkit [56913] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Add myself to the committers list.
​https://bugs.webkit.org/show_bug.cgi?id=36953

  • Scripts/webkitpy/common/config/committers.py:
7:12 AM Changeset in webkit [56912] by eric@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-04-01 yael aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

set-progress-properties.html expected result should not be platform specific
​https://bugs.webkit.org/show_bug.cgi?id=36918

  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Removed.
6:48 AM Changeset in webkit [56911] by chang.shu@nokia.com
  • 3 edits
    2 adds in trunk/LayoutTests

2010-04-01 Shu Chang <​chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] As Qt does not support dashboard compatibility mode, the red squares on
the second row are expected. Rebaseline and unskip test case.
​https://bugs.webkit.org/show_bug.cgi?id=36869

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt:
6:10 AM Changeset in webkit [56910] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-01 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Mark console-log-before-frame-navigation as pssing on Chromium Win.

​https://bugs.webkit.org/show_bug.cgi?id=36807

  • platform/chromium/test_expectations.txt:
6:00 AM Changeset in webkit [56909] by eric@webkit.org
  • 5 edits in trunk

2010-04-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
​https://bugs.webkit.org/show_bug.cgi?id=36952

  • inspector/audits-panel-functional-expected.txt:
  • inspector/audits-panel-functional.html:

2010-04-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
​https://bugs.webkit.org/show_bug.cgi?id=36952

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
5:02 AM Changeset in webkit [56908] by eric@webkit.org
  • 4 edits
    1 delete in trunk/WebKit/chromium

2010-04-01 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

As a follow up on ​https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
GeolocationServiceBridgeChromium.h
dettachBridge()
getGeolocationService()
​https://bugs.webkit.org/show_bug.cgi?id=36895

  • WebKit.gyp:
  • public/GeolocationServiceBridgeChromium.h: Removed.
  • public/WebGeolocationService.h: (WebKit::WebGeolocationService::detachBridge):
  • public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):
3:19 AM Changeset in webkit [56907] by jorlow@chromium.org
  • 13 edits in trunk

2010-03-31 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Misc IndexedDatabase cleanup
​https://bugs.webkit.org/show_bug.cgi?id=36889

No functional changes.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):

Get rid of 2 largely redundant bools

  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:

Plumb the Frame* and style cleanups.

2010-03-31 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Misc IndexedDatabase cleanup
​https://bugs.webkit.org/show_bug.cgi?id=36889

Plumb the Frame* so Chromium knows where the request originated from.

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
2:16 AM WebKit Team edited by jwieczorek@webkit.org
(diff)
1:54 AM Changeset in webkit [56906] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix filter references in svg/filters/filterRes.svg, to make two filters show up in Opera.
Clearly shows we have a regression with filterRes + feMorphology.

  • svg/filters/filterRes.svg:
1:30 AM Changeset in webkit [56905] by Nikolas Zimmermann
  • 18 edits
    9 adds in trunk

2010-03-31 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
​https://bugs.webkit.org/show_bug.cgi?id=27183

Rewrite getCTM() / getScreenCTM() handling in an iterative way, fixing all known problems/limitations.
The bug mentioned above is actually not a regression, getScreenCTM() only worked before, because we
did not handle non-SVG CSS box parents properly. When support was added to handle those cases, the
getScreenCTM() handling was completly off, causing a lot of trouble in real-life SVG applications (carto.net for instance)

Tests: svg/custom/svgsvgelement-ctm.xhtml (fixed typo, missing unit identifier in CSS 'height' property, leading to incorrect results)

svg/custom/svgsvgelement-ctm2.xhtml
svg/custom/svgsvgelement-ctm3.xhtml
svg/custom/svgsvgelement-ctm4.xhtml
svg/custom/svgsvgelement-ctm5.xhtml

  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::computeCTM):
  • svg/SVGLocatable.h: (WebCore::SVGLocatable::localCoordinateSpaceTransform):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::createRenderer):
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::localCoordinateSpaceTransform):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
  • svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::localCoordinateSpaceTransform):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::getScreenCTM):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::localCoordinateSpaceTransform):
  • svg/SVGTransformable.cpp: (WebCore::SVGTransformable::SVGTransformable):
  • svg/SVGTransformable.h: (WebCore::SVGTransformable::localCoordinateSpaceTransform):

2010-03-31 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
​https://bugs.webkit.org/show_bug.cgi?id=27183

Share code between the different svgsvgelement-ctm*.xhtm tests, placed in svg/custom/resources.
Add several new tests covering getCTM()/getScreenCTM() on text, inner and outer svg elements and containers.

  • svg/custom/resources/svgsvgelement-ctm.js: Added. (log): (stringForMatrix): (printCTMs):
  • svg/custom/svgsvgelement-ctm-expected.txt:
  • svg/custom/svgsvgelement-ctm.xhtml:
  • svg/custom/svgsvgelement-ctm2-expected.txt: Added.
  • svg/custom/svgsvgelement-ctm2.xhtml: Added.
  • svg/custom/svgsvgelement-ctm3-expected.txt: Added.
  • svg/custom/svgsvgelement-ctm3.xhtml: Added.
  • svg/custom/svgsvgelement-ctm4-expected.txt: Added.
  • svg/custom/svgsvgelement-ctm4.xhtml: Added.
  • svg/custom/svgsvgelement-ctm5-expected.txt: Added.
  • svg/custom/svgsvgelement-ctm5.xhtml: Added.
1:22 AM Changeset in webkit [56904] by hclam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Not reviewed. Build fix.

Adding test expectations missing in r56873.

  • platform/chromium-mac/media/audio-constructor-src-expected.txt: Added.
  • platform/chromium-mac/media/video-source-add-src-expected.txt: Added.
1:16 AM Changeset in webkit [56903] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-04-01 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Darin Fisher.

[V8] Quick fix for failure in SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=36943

This allows the web worker layout tests to pass again.

  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
1:02 AM Changeset in webkit [56902] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-01 Eric Seidel <​eric@webkit.org>

Rubber-stamped by Adam Barth.

Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33292

Just adding the "Build" builder for now.
We'll add the "Test" builders when the tests
are less flaky.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
12:38 AM Changeset in webkit [56901] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-01 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by David Levin.

Add myself to the reviewers list.

​https://bugs.webkit.org/show_bug.cgi?id=36935

  • Scripts/webkitpy/common/config/committers.py:
12:10 AM WebKit Team edited by yurys@chromium.org
(diff)
12:04 AM Changeset in webkit [56900] by rolandsteiner@chromium.org
  • 2 edits
    6 moves in trunk/LayoutTests

2010-04-01 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed - more layout test result build fixes:
.) Fix expected layout test filenames for Chromium.
.) Add new layout test to gtk Skipped list.

Original patch review by Darin Adler (no functional change):

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
​https://bugs.webkit.org/show_bug.cgi?id=36803

  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.checksum.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.png.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.txt.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.checksum.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.png.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.txt.
  • platform/gtk/Skipped:

Mar 31, 2010:

11:35 PM Changeset in webkit [56899] by Chris Jerdonek
  • 4 edits
    3 adds in trunk/WebKitTools

Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by Dave Levin.

​https://bugs.webkit.org/show_bug.cgi?id=33639

  • Scripts/webkitpy/style/checker.py:
    • Added PYTHON to FileType.
    • Updated ProcessorDispatcher to return a PythonProcessor for *.py files.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the ProcessorDispatcher unit tests for *.py files.
  • Scripts/webkitpy/style/processors/python.py: Added.
    • Added PythonProcessor class.
  • Scripts/webkitpy/style/processors/python_unittest.py: Added.
    • Added PythonProcessor unit tests.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
    • Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).
  • Scripts/webkitpy/style/unittests.py:
    • Updated the style unit test file to import python_unittest.py.
  • Scripts/webkitpy/style_references.py:
    • Adjusted style references to import pep8.
11:23 PM Changeset in webkit [56898] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

fast/replaced/border-radius-clip.html failed on Snow Leopard Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=36642

This test is flaky (seemingly due to <video> load times)
and is thus useless until fixed. Skipping for now.

  • platform/mac/Skipped:
11:09 PM Changeset in webkit [56897] by Chris Jerdonek
  • 9 edits
    1 add
    2 deletes in trunk/WebKitTools

Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a given destination directory.

Reviewed by Dave Levin.

​https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will let us autoinstall pep8.py from the web and put
our third-party autoinstalled code in an explicit directory like
webkitpy/thirdparty/autoinstalled. These changes should also speed
up the execution of autoinstalled *.zip packages slightly since
*.pyc files cannot be generated when importing from zipped
packages using the current autoinstall.

  • Scripts/test-webkitpy:
    • Addressed the FIXME to enable auto-install logging once autoinstall was rewritten not to log as verbosely.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/buildbot.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/irc/ircbot.py:
    • Updated ircbot and irclib import statements.
  • Scripts/webkitpy/common/net/networktransaction.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/system/autoinstall.py: Added.
    • Added AutoInstaller class.
    • Added sample/testing usage to the main block.
  • Scripts/webkitpy/thirdparty/init.py:
    • Updated the autoinstall lines to use the new autoinstall methods.
    • Added pep8.py to the list of auto-installed packages.
    • Added a README file to the target autoinstallation directory so users know that the directory is safe to delete.
  • Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
    • This is replaced by the rewritten autoinstall webkitpy/common/system/autoinstall.py.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py: Removed.
    • The target autoinstallation directory is now auto-generated.
10:22 PM Changeset in webkit [56896] by rolandsteiner@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-01 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed - add missing Chromium layout test results for:

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
​https://bugs.webkit.org/show_bug.cgi?id=36803

(original patch review by Darin Adler).

  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Added.
10:02 PM Changeset in webkit [56895] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-31 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
​https://bugs.webkit.org/show_bug.cgi?id=25567

  • fast/dom/title-content-write-set-expected.txt: Added.
  • fast/dom/title-content-write-set.html: Added.

2010-03-31 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
​https://bugs.webkit.org/show_bug.cgi?id=25567

Document::setTitle() invoked HTMLTitleElement::setText(), which
contains DOM tree modification, even when setTitle() is called
from HTMLTitleElement::childrenChanged(). Fix to skip setText()
when setTitle() is called childrenChanged() to avoid cascading
DOM mutations between Document and HTMLTitleElement.

Test: fast/dom/title-content-write-set.html

  • dom/Document.cpp: (WebCore::Document::setTitle):
9:50 PM Changeset in webkit [56894] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Tweak webkitpy's logtesting.LogTesting class to get more mileage out
of our unit tests that test log messages.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=36886

This patch adds to the LogTesting class's tearDown() method a line
asserting that the array of remaining log messages is empty. This
ensures that no extra log messages are getting logged that the caller
might not be aware of or may have forgotten to check for.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Modified the tearDown() method as described above.
    • Also modified the assertMessages() method to clear the array of log messages after asserting.
9:22 PM Changeset in webkit [56893] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

Added support for a --verbose-logging flag to test-webkitpy.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36429

Verbose logging is useful for debugging test-webkitpy code that
runs before the actual unit tests -- things like autoinstalling and
unit-test auto-detection logic. This is different from verbose
logging of the unit tests themselves (which corresponds to the
unittest module's --verbose flag).

  • Scripts/test-webkitpy:
    • In the configure_logging() method--
      • Added an is_verbose_logging parameter that sets the logging level to logging.DEBUG instead of logging.INFO.
      • Changed the method to throttle the logging level on the root logger's handler instead of directly on the root logger itself.
      • Enabled logging of the autoinstall module when the flag is set.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py:
    • Added a work-around for a bug in Python 2.6's logging module that was discovered while working on this patch.
8:56 PM Changeset in webkit [56892] by Chris Jerdonek
  • 7 edits in trunk/WebKitTools

Enabled Python's logging module for webkit-patch, and replaced
deprecated_logging with Python logging in networktransaction.py.
This eliminates some spurious output when running test-webkitpy.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36725

  • Scripts/webkit-patch:
    • Replaced the configure_logging() function with a call to the new logutils.configure_logging() function.
  • Scripts/webkitpy/common/net/networktransaction.py:
    • Replaced the use of deprecated_logging with Python logging.
  • Scripts/webkitpy/common/system/logutils.py:
    • Added _default_handlers() which creates the default logging handler for webkitpy.
    • Added configure_logging() which configures default logging for webkitpy.
  • Scripts/webkitpy/common/system/logutils_unittest.py:
    • Added unit tests for logutils.configure_logging().
  • Scripts/webkitpy/style/checker.py:
    • Refactored check-webkit-style's configure_logging() method to call the new logutils.configure_logging().
  • Scripts/webkitpy/style_references.py:
    • Updated references as necessary.
8:49 PM Changeset in webkit [56891] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch land fails if not run from the root directory
​https://bugs.webkit.org/show_bug.cgi?id=35822

The root of the problem was that ChangeLog.init expects a path
relative to the current working directory, and SCM expects to
return paths relative to the SCM root. Fix it by converting from
SCM-relative to absolute paths in Checkout.modified_changelogs

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
8:28 PM Changeset in webkit [56890] by rolandsteiner@chromium.org
  • 3 edits
    4 adds in trunk

2010-03-29 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Darin Adler.

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
​https://bugs.webkit.org/show_bug.cgi?id=36803

Don't use ruby rendering if the underlying 'display' property has been
changed into a value other than 'inline' or 'block' (such as 'inline-table').

Test: fast/ruby/ruby-inline-table.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):

Add layout test to confirm that 'inline-table' rendering is not affected
by ruby implementation.

  • fast/ruby/ruby-inline-table.html: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.txt: Added.
8:27 PM Changeset in webkit [56889] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add more tests for webkitpy.common.checkout
​https://bugs.webkit.org/show_bug.cgi?id=36926

We don't have a great way of testing checkout, sadly.

  • Scripts/webkitpy/common/checkout/api_unittest.py:
7:55 PM Changeset in webkit [56888] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: EWS crashes on failure
​https://bugs.webkit.org/show_bug.cgi?id=36924

Turns out we need to pass one more argument. My test is kind of lame,
but at least it's there.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
7:33 PM Changeset in webkit [56887] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.

7:08 PM Changeset in webkit [56886] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Fix 3 failed tests on Snow Leopard bot from 33416
​https://bugs.webkit.org/show_bug.cgi?id=36910

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Considering the case where EXT_packed_depth_stencil is unsupported.
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Ditto.
  • fast/canvas/webgl/context-attributes-expected.txt: Ditto.
  • fast/canvas/webgl/context-attributes.html: Ditto.
  • fast/canvas/webgl/gl-get-calls-expected.txt: Ditto.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
6:54 PM Changeset in webkit [56885] by ggaren@apple.com
  • 4 edits
    2 adds in trunk

Crash submitting display:none textarea in a form
​https://bugs.webkit.org/show_bug.cgi?id=36905

Reviewed by Darin Adler.

WebCore:

Test: fast/forms/textarea-submit-crash.html

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData): Do update layout before
asking our renderer for its text, since we can't rely on our renderer's
text if layout is needed.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textWithHardLineBreaks): Don't update layout
while being asked for our text, since doing so may delete us, causing a crash.

LayoutTests:

  • fast/forms/textarea-submit-crash-expected.txt: Added.
  • fast/forms/textarea-submit-crash.html: Added.
6:43 PM Changeset in webkit [56884] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS go faster by being optimistic
​https://bugs.webkit.org/show_bug.cgi?id=36916

Have the EWS be optimistic that a patch will correctly build. This
should speed up the common case by not requiring two builds for every
patch.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
6:13 PM Changeset in webkit [56883] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the ability to restart sheriffbot from IRC
​https://bugs.webkit.org/show_bug.cgi?id=36909

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
5:58 PM Changeset in webkit [56882] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebCore: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

Test: platform/mac/accessibility/html-with-aria-label.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.h:

WebKit/mac: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

  • WebView/WebFrame.mm:

(-[WebFrame setAccessibleName:]):

  • WebView/WebFramePrivate.h:

LayoutTests: Test for
Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

  • platform/mac/accessibility/html-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/html-with-aria-label.html: Added.
5:47 PM Changeset in webkit [56881] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add win-ews to QueueStatusServer
​https://bugs.webkit.org/show_bug.cgi?id=36876

The win-ews is still experimental, but it seems to be more or less
running. We should show its results to the people.

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
5:23 PM Changeset in webkit [56880] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

Fixing a build break caused by 56872. One of the Chromium bots doesn't
like std::strstr(). Includes string.h and use strstr() instead.

  • src/WebGraphicsContext3DDefaultImpl.cpp:

(WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
Includes string.h and use strstr().

5:13 PM Changeset in webkit [56879] by mrowe@apple.com
  • 5 edits in trunk

<​http://webkit.org/b/36878> REGRESSION: Trailing colon on hostnames (with no port specified) causes "Not allowed to use restricted network port"

Reviewed by Darin Adler.

WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::port): Explicitly handle the case of a colon being present in the URL after the host name but with
no port number before the path. This is handled in the same manner as the colon and port being omitted completely.

LayoutTests:

Add explicit tests for handling of allowed ports. We currently only test the ports that map to port 80: 0, 80, and "".

  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:
5:12 PM Changeset in webkit [56878] by barraclough@apple.com
  • 9 edits in trunk/WebCore

Remove dependency on TextBreakIterator from StringImpl.cpp,
and from member methods of String.

Reviewed by Oliver Hunt.

Make 'numGraphemeClusters' & 'numCharactersInGraphemeClusters'
global function defined in PlatformString.h, rather than
member methods on String (these can be implemented purely
using the characters() and length() public interface),
and make 'makeCapitalized' a static function in RenderText.cpp.

  • dom/InputElement.cpp:

(WebCore::InputElement::sanitizeUserInputValue):
(WebCore::InputElement::handleBeforeTextInsertedEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::tooLong):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::sanitizeUserInputValue):
(WebCore::HTMLTextAreaElement::tooLong):

  • platform/text/PlatformString.h:

(WebCore::String::makeSecure):

  • platform/text/String.cpp:

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/StringImpl.cpp:
  • platform/text/StringImpl.h:
  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::setTextInternal):

5:09 PM Changeset in webkit [56877] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-31 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by David Levin.

[V8] SerializedScriptValue must be deserialized only once and in the right context
​https://bugs.webkit.org/show_bug.cgi?id=36892

See also ​https://bugs.webkit.org/show_bug.cgi?id=34227 for the
corresponding JSC change.

General idea: SerializedScriptValue must be deserialized only once
and in the context of the intended MessageEvent recepient. The
approach we take for now is to eagerly deserialize when a
JavaScript wrapper for MessageEvent is created.

A better fix would be to keep a reference to the context in
MessageEvent and use it when lazily deserializing. It's harder to
do since the API doesn't have a clean method to have such a reference.

Tested by fast/dom/Window/window-postmessage-clone-frames.html. This
test still fails but only for the types which we can't serialize yet.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
4:45 PM Changeset in webkit [56876] by victorw@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-30 Victor Wang <​victorw@chromium.org>

Reviewed by Eric Seidel.

Update rebaseline tool to check the release image diff binary and
fallback to debug if the release version does not exist.

​https://bugs.webkit.org/show_bug.cgi?id=36245

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4:22 PM Changeset in webkit [56875] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Cleanup RedirectScheduler
​https://bugs.webkit.org/show_bug.cgi?id=36874

Removed the nutty ScheduledRedirection struct in favor of a hierarchy
of classes to represent the various kinds of scheduled redirects.
Doing this lets us get rid of the pseudo RTTI switch statements on
"type" in favour of calling virtual functions.

No new tests because this change should be API identical with the
existing RedirectScheduler.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::~ScheduledNavigation): (WebCore::ScheduledNavigation::isLocationChange): (WebCore::ScheduledNavigation::shouldStartTimer): (WebCore::ScheduledNavigation::didStartTimer): (WebCore::ScheduledNavigation::didStopTimer): (WebCore::ScheduledNavigation::delay): (WebCore::ScheduledNavigation::lockHistory): (WebCore::ScheduledNavigation::lockBackForwardList): (WebCore::ScheduledNavigation::wasDuringLoad): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledURLNavigation::url): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledURLNavigation::wasUserGesture): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledRedirect::isLocationChange): (WebCore::ScheduledRedirect::shouldStartTimer): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h:
3:55 PM Changeset in webkit [56874] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach buildbot.py how to parse builder activity from /one_box_per_builder
​https://bugs.webkit.org/show_bug.cgi?id=36898

I also removed some obsolete FIXMEs and
refactored one_box_per_builder parsing into multiple
methods for easier reading.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
3:53 PM Changeset in webkit [56873] by scherkus@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2010-03-31 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Dmitry Titov.

Checking in Chromium media baselines for layout tests fixed in r56481.

​https://bugs.webkit.org/show_bug.cgi?id=36860

  • platform/chromium-linux/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-linux/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-mac/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac/media/video-no-audio-expected.txt: Added.
  • platform/chromium-win/media/audio-constructor-src-expected.txt: Added.
  • platform/chromium-win/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-win/media/video-no-audio-expected.png: Added.
  • platform/chromium-win/media/video-no-audio-expected.txt: Added.
  • platform/chromium-win/media/video-source-add-src-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Tests are now passing.
3:15 PM Changeset in webkit [56872] by eric@webkit.org
  • 15 edits
    2 adds in trunk

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
​https://bugs.webkit.org/show_bug.cgi?id=33416

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
  • fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
  • fast/canvas/webgl/context-attributes.html: Ditto.
  • fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
​https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug. (WebCore::V8HTMLCanvasElement::getContextCallback):
  • platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
  • platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
  • platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support. (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac. (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
  • platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call. (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
​https://bugs.webkit.org/show_bug.cgi?id=33416

  • src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
  • src/WebGraphicsContext3DDefaultImpl.h: Add a function.
2:51 PM Changeset in webkit [56871] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix logging in new-run-webkit-tests so that we don't report IMAGE
expected failures as unexpected passes when we run with pixel tests
disabled.

This change splits some of the logic embedded into the TestExpectations
classes out into separate pure functions (result_was_expected,
remove_image_failures) to make them easier to test. This also adds
a parameter to matches_an_expected_result() to indicate whether or
not pixel test results should be included in the expectations.

​https://bugs.webkit.org/show_bug.cgi?id=36771

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:44 PM Changeset in webkit [56870] by Chris Jerdonek
  • 4 edits
    2 adds in trunk/WebKitTools

In webkitpy, refactored two calls to os.path.relpath() replacements
to use a common method.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=36891

  • Scripts/webkitpy/common/net/bugzilla.py:
    • Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().
  • Scripts/webkitpy/common/system/ospath.py: Added.
    • Moved the relpath() implementation from style/main.py.
  • Scripts/webkitpy/common/system/ospath_unittest.py: Added.
    • Moved the relpath() unit tests from style/main_unittest.py.
  • Scripts/webkitpy/style/main.py:
    • Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().
  • Scripts/webkitpy/style/main_unittest.py:
    • Moved the relpath unit tests to opsys_unittest.py.
2:23 PM Changeset in webkit [56869] by jianli@chromium.org
  • 6 edits
    2 adds in trunk/WebCore

Add support to create UUID string.
​https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Dmitry Titov.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/UUID.cpp: Added.

(WebCore::createCanonicalUUIDString):

  • platform/UUID.h: Added.
2:15 PM Changeset in webkit [56868] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt II).

1:59 PM Changeset in webkit [56867] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:57 PM Changeset in webkit [56866] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a Builder.force_build method
​https://bugs.webkit.org/show_bug.cgi?id=36875

We plan to eventually use this in SheriffBot to break deadlocks created
by flaky tests.

  • Scripts/webkitpy/common/net/buildbot.py:
1:38 PM Changeset in webkit [56865] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable LayoutTests/fast/canvas/zero-size-fill-rect.html
​https://bugs.webkit.org/show_bug.cgi?id=36837

Remove zero-size-fill-rect.html from skipped and create expected files.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.txt:
1:36 PM Changeset in webkit [56864] by barraclough@apple.com
  • 6 edits
    2 adds in trunk

Bug 36871 - Remove JSC::CString
Use WTF::CString instead (which until recently was WebCore::CString).

Reviewed by Geoff Garen.

JavaScriptCore:

JavaScriptGlue:

  • ForwardingHeaders/wtf/text: Added.
  • ForwardingHeaders/wtf/text/CString.h: Added.
1:28 PM Changeset in webkit [56863] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch reads wrong bug url from unified diff context
​https://bugs.webkit.org/show_bug.cgi?id=36477

Instead of trying to figure out the bug_id from the diff, we should
just get the information from the Checkout object, which understands
these concepts.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
1:28 PM Changeset in webkit [56862] by Darin Adler
  • 2 edits in trunk/WebCore
  • rendering/RenderThemeChromiumWin.h: Fix inconsistent line endings.
1:21 PM Changeset in webkit [56861] by hclam@chromium.org
  • 4 edits in trunk/LayoutTests

2010-03-31 Alpha Lam <​hclam@chromium.org>

Reviewed by Darin Fisher.

Update test results due to changes in r56824.
​https://bugs.webkit.org/show_bug.cgi?id=36900

  • platform/chromium-win/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium/test_expectations.txt: fast/forms/input-file-re-render.html generates incorrect results on Linux, mark it so.
1:18 PM Changeset in webkit [56860] by eric@webkit.org
  • 5 edits
    3 adds in trunk/WebCore

2010-03-31 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - form controls style
​https://bugs.webkit.org/show_bug.cgi?id=36370

Adjusting Mameo5 form elements rendering.

  • WebCore.pri:
  • WebCore.pro:
  • css/themeQtMaemo5.css: Added. (select): (select:disabled): (select:active): (select:active:disabled): (textarea): (textarea:disabled): (textarea:active):
  • platform/qt/Maemo5Webstyle.cpp: Added. (Maemo5WebStyle::Maemo5WebStyle): (drawRectangularControlBackgorund): (Maemo5WebStyle::drawChecker): (Maemo5WebStyle::findChecker): (Maemo5WebStyle::drawRadio): (Maemo5WebStyle::findRadio): (Maemo5WebStyle::drawControl): (Maemo5WebStyle::drawComplexControl):
  • platform/qt/Maemo5Webstyle.h: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::popupInternalPaddingBottom): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
  • platform/qt/RenderThemeQt.h:
12:51 PM Changeset in webkit [56859] by ap@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

Addressing additional review comments.

  • rendering/RenderWidget.cpp: Removed an unneeded include.
  • rendering/RenderWidget.h: Reworded the new comment.
12:48 PM Changeset in webkit [56858] by ap@apple.com
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

  • manual-tests/plugin-in-iframe-scroll.html: Added.
  • manual-tests/resources/plugin-in-iframe-scroll-iframe.html: Added.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): This method isn't called when an iframe containing the widget moves, so we should store a value that is not dependent on current scroll offset. (WebCore::RenderWidget::windowClipRect): Apply scroll offset and window clip now.
  • rendering/RenderWidget.h: Renamed m_windowClipRect to m_clipRect, because it is no longer in window coordinates.
  • WebCore.base.exp: Export RenderWidget::windowClipRect(), since it's no longer inline.
12:32 PM Changeset in webkit [56857] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch commit-queue should land patches optimistically
​https://bugs.webkit.org/show_bug.cgi?id=34187

This patch adds an optimistic path to commit-queue and a "fail twice"
requirement for rejecting patches. That means we'll land good patches
faster (via the optmistic first run) and we'll reject many fewer
patches due to flaky tests.

  • Scripts/webkitpy/tool/commands/queues.py:
12:17 PM Changeset in webkit [56856] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed crash fix.

Crash with frame flattening on after r56854
​https://bugs.webkit.org/show_bug.cgi?id=36894

Solution tested by Greg Bolsinga, thanks.

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

12:12 PM PythonGuidelines edited by Chris Jerdonek
Retitled, and clarified the minimum Python version requirement. (diff)
11:46 AM Changeset in webkit [56855] by Csaba Osztrogonác
  • 4 edits
    8 adds in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

iframe flattening doesn't flatten
​https://bugs.webkit.org/show_bug.cgi?id=36798

Platform specific expected files added, and updated after r56852.

  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
11:03 AM Changeset in webkit [56854] by kenneth@webkit.org
  • 6 edits in trunk/WebCore

Do not draw scrollbars for subframes when frame flattening is
enabled. Implemented using a virtual method in ScrollView as
suggested by Dave Hyatt.

Reviewed by Antti Koivisto.

Do not suppress scrollbars as that is wrong according to
Dave Hyatt.

Covered by current tests.

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/ScrollView.h:

(WebCore::ScrollView::avoidScrollbarCreation):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

11:00 AM Changeset in webkit [56853] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-31 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[chromium] including WebKit.gyp:webkit should automatically add Skia
and NPAPI include paths

​https://bugs.webkit.org/show_bug.cgi?id=36887

  • WebKit.gyp:
10:55 AM Changeset in webkit [56852] by kenneth@webkit.org
  • 3 edits
    4 adds in trunk

iframe flattening doesn't flatten
​https://bugs.webkit.org/show_bug.cgi?id=36798

WebCore: Fix wrongly reversing logic in frame flattening check.

Reviewed by Antti Koivisto.

Tests:
fast/frames/flattening/iframe-flattening-fixed-height.html
fast/frames/flattening/iframe-flattening-fixed-width.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):

LayoutTests: Add more tests for iframe flattening

Reviewed by Antti Koivisto.

  • fast/frames/flattening/iframe-flattening-fixed-height.html
  • fast/frames/flattening/iframe-flattening-fixed-width.html
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html
10:54 AM PythonGuidelines edited by Chris Jerdonek
Eliminated the Tips section (diff)
10:47 AM Changeset in webkit [56851] by eric@webkit.org
  • 23 edits in trunk

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
Similar to requestGeolocationPermissionForFrame(), passes Geolocation* to cancelGeolocationPermissionRequestForFrame(),
so that the embedder can identify which Geolocation object is cancelling the pending permission request.
Calls cancelGeolocationPermissionRequestForFrame() before stopUpdating() so it better matches the startUpdating() / requestPermission() flow.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::cancelGeolocationPermissionRequestForFrame):
  • page/Chrome.cpp: (WebCore::Chrome::cancelGeolocationPermissionRequestForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • public/WebGeolocationService.h: (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/ChromeClientImpl.h:

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
  • WebCoreSupport/ChromeClientGtk.h:

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::cancelGeolocationPermissionRequestForFrame):
10:06 AM Changeset in webkit [56850] by yael.aharon@nokia.com
  • 8 edits
    2 adds in trunk/WebCore

Add animation to progress element
​https://bugs.webkit.org/show_bug.cgi?id=36664

Reviewed by Antti Koivisto.

Add a timer to control the animation. The timer is started after painting
or a state change in the progress bar, to prevent animation from running
when the progress bar is not visible.

  • html/HTMLProgressElement.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h:
10:01 AM Changeset in webkit [56849] by pfeldman@chromium.org
  • 9 edits in trunk

2010-03-31 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r56829 since it broke chromium layout tests.

[REGRESSION] Inspector tests started crashing since r56829
​https://bugs.webkit.org/show_bug.cgi?id=36888

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • loader/FrameLoaderClient.h: WebKit/chromium:
  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
9:53 AM Changeset in webkit [56848] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <​sswigart@google.com>

Reviewed by David Levin.

[Chromium] Enable fast/events/onbeforeunload-focused-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=36781

  • platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView is implemented in test_shell.
9:44 AM PythonGuidelines edited by Chris Jerdonek
Added section on consequences of not using Python 2.6 (diff)
9:29 AM Changeset in webkit [56847] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

more tweaks to WebGL+CSS

9:23 AM Changeset in webkit [56846] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-03-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: creating new style bugfixing.

​https://bugs.webkit.org/show_bug.cgi?id=36884

  • InspectorDOMAgent should clear internal state upon reset (we are re-using single dom agent instance throughout entire inspector controller lifetime)
  • Brought back blank style 'refresh' processing logic - remove it by mistake earlier
  • Blocked couple of click handlers so that double-click to edit was not expanding / collapsing the pane
  • There is no need to reach out for matched rules upon 'refresh' update - getting computed style is sufficient.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.getStylesCallback): (WebInspector.StylesSidebarPane.prototype.update.getComputedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._refreshUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): (WebInspector.StylePropertiesSection.prototype._clickSelector):
9:22 AM PythonGuidelines edited by Chris Jerdonek
Wording improvements to upgrade section. (diff)
9:16 AM PythonGuidelines edited by Chris Jerdonek
Added outline (diff)
9:10 AM Changeset in webkit [56845] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, fix after r56842.

Add UNUSED_PARAM a to silence warning.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
9:09 AM Changeset in webkit [56844] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-03-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix: create missing v8::HandleScope.

​https://bugs.webkit.org/show_bug.cgi?id=36828

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
9:01 AM Changeset in webkit [56843] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix crash

Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
​https://bugs.webkit.org/show_bug.cgi?id=36885

  • inspector/audits-panel-functional.html:
  • platform/chromium/test_expectations.txt:
8:59 AM Changeset in webkit [56842] by Laszlo Gombos
  • 3 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

Refactor JITStubs.cpp so that the list of STUB_FUNCTIONs
are not dependent on the JSVALUE32_64 guard.

  • jit/JITStubs.cpp: Place the JSVALUE32_64 guard inside the body of cti_op_eq_strings.
  • jit/JITStubs.h: Remove JSVALUE32_64 guard from cti_op_eq_strings stub.
8:24 AM Changeset in webkit [56841] by yurys@chromium.org
  • 10 edits in trunk

2010-03-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Check that injected script can still access inspected window object when wrapping console object. When the window cannot be access serialize objects as strings. Also don't call InjectedScript.dispatch if the window cannot be accessed (due to frame navigation).

​https://bugs.webkit.org/show_bug.cgi?id=36828

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapForConsole):
  • inspector/InjectedScriptHost.h:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-03-30 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspecting frames whose content has changed.

​https://bugs.webkit.org/show_bug.cgi?id=36828

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:
7:45 AM Changeset in webkit [56840] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-31 Mattias Nissler <​mnissler@google.com>

Reviewed by Pavel Feldman.

Allow generic resource URLs for cookie handling in the inspector. This
enables display of all cookies, not only those that are associated
with resources accessed through http, https or file.
​https://bugs.webkit.org/show_bug.cgi?id=36877

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
7:42 AM Changeset in webkit [56839] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-31 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing pixel test results for svg/filters/feColorMatrix-values.svg

  • platform/mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/mac/svg/filters/feColorMatrix-values-expected.png: Added.
7:26 AM Changeset in webkit [56838] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Custom user agent for user agent switcher
​https://bugs.webkit.org/show_bug.cgi?id=36757

  • QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
6:27 AM Changeset in webkit [56837] by antti.j.koivisto@nokia.com
  • 3 edits in trunk/WebKit/qt

​https://bugs.webkit.org/show_bug.cgi?id=36446
[Qt] QWebSettings::TiledBackingStoreEnabled attribute lacks documentation and default value

Reviewed by Kenneth Rohde Christiansen.

  • Api/qgraphicswebview.cpp:
  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

4:04 AM Changeset in webkit [56836] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stubs for moveWindowBy and setAttachedWindowHeight.

​https://bugs.webkit.org/show_bug.cgi?id=36842

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight): (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
  • src/WebDevToolsFrontendImpl.h:
3:45 AM Changeset in webkit [56835] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

path to committers.py in commit-queue rejection message is wrong
​https://bugs.webkit.org/show_bug.cgi?id=36865

This fix would have only been 3 lines long if we had

  1. Had access to an SCM object or tool to give us the checkout root
  2. Been able to depend on Python 2.6 Instead I've added a bunch of hack code, but at least now we should never have to update this string again as the location of committers.py is fully dynamically discovered. :p
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
3:35 AM Changeset in webkit [56834] by jorlow@chromium.org
  • 6 edits
    1 copy
    1 move in trunk/WebCore

2010-03-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest
​https://bugs.webkit.org/show_bug.cgi?id=36830

Still not enough hooked up to test. Soon!

  • WebCore.gypi:
  • bindings/v8/custom/V8CustomIDBCallback.h: Removed.
  • bindings/v8/custom/V8CustomIDBCallbacks.h: Added. (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::~V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IDBDatabaseRequest.cpp: Added. (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::~IDBDatabaseRequest):
  • storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::create):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
3:26 AM Changeset in webkit [56833] by eric@webkit.org
  • 5 edits in trunk

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
​https://bugs.webkit.org/show_bug.cgi?id=35619

  • fast/canvas/webgl/array-setters-expected.txt: Testing shared overlapping buffer set() behaviors.
  • fast/canvas/webgl/array-setters.html: Ditto.

2010-03-31 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
​https://bugs.webkit.org/show_bug.cgi?id=35619

New test cases are added to fast/canvas/webgl/array-setters.html.

  • html/canvas/WebGLArray.cpp: Use memmove instead of memcpy; with memmove, copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap. (WebCore::WebGLArray::setImpl):
3:08 AM Changeset in webkit [56832] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <​sswigart@google.com>

Reviewed by David Levin.

[chromium] test_expectations.txt swept for MAC test cases becoming PASS
​https://bugs.webkit.org/show_bug.cgi?id=36863

  • platform/chromium/test_expectations.txt: Cleaned up test_expectations.txt for MAC which are now PASS.
2:50 AM Changeset in webkit [56831] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-31 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
​https://bugs.webkit.org/show_bug.cgi?id=36810

Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox

  • rendering/RenderBox.h: (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  • rendering/RenderObject.h:
2:48 AM QtWebKitJournal edited by fboudra@gmail.com
(diff)
1:56 AM Changeset in webkit [56830] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

[Qt] Remove LayoutTests/fast/canvas/image-object-in-canvas.html from Skipped
​https://bugs.webkit.org/show_bug.cgi?id=36836

Enable LayoutTests/fast/canvas/image-object-in-canvas.html at LayoutTests

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/qt/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt/fast/canvas/image-object-in-canvas-expected.txt:
1:37 AM Changeset in webkit [56829] by eric@webkit.org
  • 9 edits in trunk

2010-03-31 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
​https://bugs.webkit.org/show_bug.cgi?id=35773

No new tests as no new functionality.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Utilities.cpp: (WebCore::logPropertyAccess):
  • bindings/v8/V8Utilities.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::logCrossFramePropertyAccess):

2010-03-31 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
​https://bugs.webkit.org/show_bug.cgi?id=35773

  • public/WebFrameClient.h: (WebKit::WebFrameClient::logCrossFramePropertyAccess):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
  • src/FrameLoaderClientImpl.h:
12:16 AM April 2010 Meeting edited by kim.gronholm@nomovok.com
(diff)
12:14 AM Changeset in webkit [56828] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed test fix for r56809.

webkit-patch what-broke throws exception
​https://bugs.webkit.org/show_bug.cgi?id=36852

  • Scripts/webkitpy/common/checkout/api_unittest.py:
12:04 AM Changeset in webkit [56827] by hamaji@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-03-30 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] fast/repaint/overflow-scroll-body-appear need to be rebaselined
​https://bugs.webkit.org/show_bug.cgi?id=36825

  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Mar 30, 2010:

11:09 PM Changeset in webkit [56826] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixing b0rked version of JavaScriptCore.vcproj - added lines were truncated.

Reviewed by NOBODY (windows build fix).

10:44 PM Changeset in webkit [56825] by barraclough@apple.com
  • 259 edits
    2 moves
    3 adds in trunk

Rubber stamped by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=36866
Move CString to WTF

JavaScriptCore:

(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(WTF::CStringBuffer::create):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::CString):
(WTF::CString::isNull):
(WTF::CString::buffer):
(WTF::operator!=):

WebCore:

  • Android.mk:
  • ForwardingHeaders/wtf/text: Added.
  • ForwardingHeaders/wtf/text/CString.h: Added.
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/v8/JavaStringV8.h:

(JSC::Bindings::JavaStringImpl::init):

  • css/CSSParser.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/Node.cpp:
  • dom/Position.cpp:
  • dom/Range.cpp:
  • dom/Text.cpp:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerQt.cpp:
  • editing/SelectionController.cpp:
  • editing/VisiblePosition.cpp:
  • editing/VisibleSelection.cpp:
  • history/CachedFrame.cpp:
  • history/HistoryItem.cpp:
  • history/qt/HistoryItemQt.cpp:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):

  • html/HTMLDocument.cpp:
  • html/PreloadScanner.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • loader/DocLoader.cpp:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FrameLoader.cpp:
  • loader/HistoryController.cpp:
  • loader/ProgressTracker.cpp:
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/icon/wince/IconDatabaseWince.cpp:
  • loader/loader.cpp:
  • page/Console.cpp:
  • page/DOMWindow.cpp:
  • page/SecurityOrigin.cpp:
  • page/XSSAuditor.cpp:
  • page/animation/AnimationBase.cpp:
  • platform/ContextMenu.cpp:
  • platform/FileSystem.h:
  • platform/KURL.cpp:
  • platform/KURLGoogle.cpp:
  • platform/KURLGooglePrivate.h:
  • platform/Pasteboard.h:
  • platform/android/FileSystemAndroid.cpp:
  • platform/android/TemporaryLinkStubs.cpp:
  • platform/brew/KURLBrew.cpp:
  • platform/cf/FileSystemCF.cpp:
  • platform/chromium/MIMETypeRegistryChromium.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/efl/PasteboardEfl.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/efl/RenderThemeEfl.cpp:
  • platform/efl/ScrollbarEfl.cpp:
  • platform/efl/SharedBufferEfl.cpp:
  • platform/efl/WidgetEfl.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/cairo/FontPlatformDataCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/chromium/FontCacheLinux.cpp:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/FontPlatformDataPango.cpp:
  • platform/graphics/gtk/IconGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/mac/GraphicsContext3DMac.cpp:
  • platform/graphics/mac/GraphicsLayerCA.mm:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/skia/GraphicsLayerSkia.cpp:
  • platform/graphics/win/GraphicsLayerCACF.cpp:
  • platform/graphics/win/WKCACFLayer.cpp:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/gtk/ClipboardGtk.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/FileChooserGtk.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GeolocationServiceGtk.cpp:
  • platform/gtk/KURLGtk.cpp:
  • platform/gtk/Language.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PopupMenuGtk.cpp:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/SharedBufferGtk.cpp:
  • platform/haiku/FileSystemHaiku.cpp:
  • platform/haiku/PlatformKeyboardEventHaiku.cpp:
  • platform/network/CredentialStorage.cpp:
  • platform/network/FormData.cpp:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.cpp:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.cpp:
  • platform/network/android/ResourceHandleAndroid.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/chromium/ResourceResponse.h:
  • platform/network/curl/FormDataStreamCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
  • platform/network/curl/ResourceHandleManager.h:
  • platform/network/mac/FormDataStreamMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/qt/KURLQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:
  • platform/text/CString.cpp: Removed.
  • platform/text/CString.h: Removed.
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/TextCodec.h:
  • platform/text/TextCodecICU.cpp:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/TextEncoding.h:
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/haiku/StringHaiku.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/qt/TextCodecQt.cpp:
  • platform/text/wx/StringWx.cpp:
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardWin.cpp:
  • platform/win/ContextMenuItemWin.cpp:
  • platform/win/ContextMenuWin.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/win/GDIObjectCounter.cpp:
  • platform/win/Language.cpp:
  • platform/win/PasteboardWin.cpp:
  • platform/wince/FileSystemWince.cpp:
  • platform/wince/KeygenWince.cpp:
  • platform/wince/PasteboardWince.cpp:
  • platform/wx/FileSystemWx.cpp:
  • platform/wx/LoggingWx.cpp:
  • plugins/PluginDebug.h:
  • plugins/PluginPackage.cpp:
  • plugins/PluginStream.cpp:
  • plugins/PluginStream.h:
  • plugins/PluginView.h:
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/mac/PluginPackageMac.cpp:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/symbian/PluginPackageSymbian.cpp:
  • plugins/win/PluginPackageWin.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderTreeAsText.cpp:
  • storage/Database.cpp:
  • storage/SQLTransactionCoordinator.cpp:
  • storage/SQLTransactionCoordinator.h:
  • storage/StorageAreaSync.cpp:
  • storage/StorageSyncManager.cpp:
  • storage/chromium/DatabaseTrackerChromium.cpp:
  • storage/chromium/QuotaTracker.cpp:
  • storage/chromium/QuotaTracker.h:
  • svg/SVGFontFaceElement.cpp:
  • svg/SVGStyledElement.cpp:
  • svg/SVGUseElement.cpp:
  • websockets/WebSocket.cpp:
  • websockets/WebSocketChannel.cpp:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLErrorHandling.cpp:
  • wml/WMLGoElement.cpp:
  • wml/WMLPageState.cpp:
  • wml/WMLPostfieldElement.cpp:
  • wml/WMLSelectElement.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XSLStyleSheetLibxslt.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

WebKit:

  • efl/WebCoreSupport/ChromeClientEfl.cpp:
  • efl/ewk/ewk_frame.cpp:

(ewk_frame_name_get):
(ewk_frame_selection_get):
(ewk_frame_uri_changed):

  • efl/ewk/ewk_history.cpp:
  • efl/ewk/ewk_settings.cpp:

WebKit/chromium:

  • public/WebCString.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/GraphicsContext3D.cpp:
  • src/WebCString.cpp:

(WebKit::WebCString::assign):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::operator WTF::CString):

  • src/WebMediaPlayerClientImpl.cpp:
  • src/WebString.cpp:
  • src/WebURLError.cpp:

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
  • gdom/ConvertToGCharPrivate.h:
  • webkit/webkitdownload.cpp:
  • webkit/webkithittestresult.cpp:
  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebdatabase.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_finalize):
(webkit_web_history_item_get_target):

  • webkit/webkitwebresource.cpp:
  • webkit/webkitwebsettings.cpp:
  • webkit/webkitwebview.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::getProxy):
(WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
(WebKit::NetscapePluginInstanceProxy::resolveURL):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView resolveURL:forTarget:]):

WebKit/qt:

  • Api/qwebelement.cpp:

WebKit/win:

  • WebDownload.cpp:
  • WebDownloadCFNet.cpp:
  • WebDownloadCurl.cpp:
  • WebHistoryItem.cpp:
  • WebLocalizableStrings.cpp:
  • WebMutableURLRequest.cpp:
  • WebPreferences.cpp:

(WebPreferences::migrateWebKitPreferencesToCFPreferences):

  • WebView.cpp:

WebKit/wx:

  • WebFrame.cpp:
  • WebView.cpp:
9:35 PM Changeset in webkit [56824] by tkent@chromium.org
  • 7 edits in trunk

2010-03-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
​https://bugs.webkit.org/show_bug.cgi?id=36723

  • fast/forms/input-file-re-render.html: Force to do re-layout to check the regression.

2010-03-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
​https://bugs.webkit.org/show_bug.cgi?id=36723

RenderFileUploadControl::chooseIconForFiles was called before
m_fileChooser was initialized.

  • platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Introduce m_isInitializing flag to avoid FileChooserClient::repaint() call. (WebCore::FileChooser::loadIcon): (WebCore::FileChooser::iconLoaded):
  • platform/FileChooser.h: Add a FielChooser parameter to FileChooserClient::chooseIconForFiles().
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::chooseIconForFiles): (WebCore::RenderFileUploadControl::paintObject): Add an assertion.
  • rendering/RenderFileUploadControl.h:
9:32 PM Changeset in webkit [56823] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Rubber stamped by Dave Levin.

Made check-webkit-style less chatty.

Examples include:

  • Scripts/webkitpy/style/checker.py:
    • Changed unrecognized file type log message from info to debug.
8:36 PM Changeset in webkit [56822] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-03-30 Stanislav Paltis <​Stanislav.Paltis@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] qmake/symbian build failure
​https://bugs.webkit.org/show_bug.cgi?id=36745

Fix build break in Symbian build introduced in r56714,
by modifying comment escape character from ";" to "#".

  • WebCore.pro:
8:09 PM April 2010 Meeting edited by staikos@kde.org
(diff)
7:00 PM Changeset in webkit [56821] by yuzo@google.com
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-03-30 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Fix LayoutTests/fast/dom/Window/window-resize.html
The test failed on Mac if Dock is placed on the left or the right because the window's width
and horizontal position can be adjusted by the OS.
This patch fixes it by using window.availWidth instead of window.width as the expected
values and by avoid using constant expected values.
As a side effect, the expected values become platform independent.

​https://bugs.webkit.org/show_bug.cgi?id=36813

  • fast/dom/Window/window-resize-expected.txt:
  • fast/dom/Window/window-resize.html:
  • platform/mac/fast/dom/Window/window-resize-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-resize-expected.txt: Removed.
6:25 PM Changeset in webkit [56820] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <​hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Fix test expectations for a new test added in r56779
​https://bugs.webkit.org/show_bug.cgi?id=36868

inspector/audits-panel-functional.html is crashing on Windows. Mark it so.

  • platform/chromium/test_expectations.txt: Add expectation for inspector/audits-panel-functional.html to mark it as crashing.
6:19 PM Changeset in webkit [56819] by kevino@webkit.org
  • 6 edits in trunk

wx build fixes after new method additions and a method rename.

5:35 PM Changeset in webkit [56818] by hclam@chromium.org
  • 7 edits
    6 adds in trunk/LayoutTests

2010-03-30 Alpha Lam <​hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] New test results due to 56776
​https://bugs.webkit.org/show_bug.cgi?id=36857

Adding new layout test results for chromium for tests added in r56776.

  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium/test_expectations.txt: Removed the failing expectation for platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html because the difference in only in the scroll bar, there is not difference in the image content. Also fixed a grammar problem in last commit.
5:34 PM Changeset in webkit [56817] by hclam@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

fixed rebaseline

5:27 PM Changeset in webkit [56816] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, expectations tweak.

Updating expectations to stop skipping tests that were fixed in r56481.

  • platform/chromium/test_expectations.txt: Don't skip fixed tests.
4:58 PM Changeset in webkit [56815] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add missing export.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
4:44 PM Changeset in webkit [56814] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

[chromium] Fix test_expectations for new test added in r56795
​https://bugs.webkit.org/show_bug.cgi?id=36861

  • platform/chromium/test_expectations.txt: Expects svg/animations/animate-points.html to fail because a API is missing in Chromium. See ​http://crbug.com/39904.
4:12 PM Changeset in webkit [56813] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Incorrect insertion position after typing THAI CHARACTER SARA AM = 0E33.
<rdar://problem/7810749>
​https://bugs.webkit.org/show_bug.cgi?id=36858

Reviewed by Darin Adler.

WebCore:

Test: fast/text/multiglyph-characters.html

Characters with multiple glyph were not supported correctly.
Computing the advance width was producing a division by zero.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

  • fast/text/multiglyph-characters-expected.txt: Added.
  • fast/text/multiglyph-characters.html: Added.
3:35 PM Changeset in webkit [56812] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:33 PM Changeset in webkit [56811] by mrowe@apple.com
  • 1 copy in tags/Safari-533.3

New tag.

2:51 PM Changeset in webkit [56810] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-03-30 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG pattern canvas tainting.

​https://bugs.webkit.org/show_bug.cgi?id=36838

  • fast/canvas/svg-taint.html: Added
  • fast/canvas/svg-taint-expected.txt: Added
  • fast/canvas/resources/empty.svg: Added

2010-03-30 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Taint the canvas if an SVG-derived pattern is rendered into it.

​https://bugs.webkit.org/show_bug.cgi?id=36838

Test: fast/canvas/svg-taint.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): Take into account the image's hasSingleSecurityOrigin() property.
2:44 PM Changeset in webkit [56809] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch what-broke throws exception
​https://bugs.webkit.org/show_bug.cgi?id=36852

  • Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
  • Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
2:27 PM Changeset in webkit [56808] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

​https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode for keys used in tests (we used to always pass 0 for 'A').
1:58 PM April 2010 Meeting edited by jasonr@bsquare.com
(diff)
1:48 PM Changeset in webkit [56807] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Darin Adler.

Updating expectations for video-no-audio.html to reflect changes made in r56481.

​https://bugs.webkit.org/show_bug.cgi?id=36846

  • platform/mac-tiger/media/video-no-audio-expected.txt: Updating due to different source video dimensions.
  • platform/win/media/video-no-audio-expected.txt: Ditto.
1:37 PM Changeset in webkit [56806] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

​https://bugs.webkit.org/show_bug.cgi?id=36848
<rdar://problem/7362913>
Menu items appropriate only for rich-content editing can appear in plain-text contexts

Reviewed by Dan Bernstein.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView validRequestorForSendType:returnType:]):
Don't return self for non-string content if _canEditRichly is false.

1:10 PM Changeset in webkit [56805] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-30 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsScene mousePressEvent does not set the clickCausedFocus flag
​https://bugs.webkit.org/show_bug.cgi?id=35259

The clickCausedFocus flag is not being set in method
mousePressEvent(QGraphicsSceneMouseEvent* ev). This flag is used
in conjunction with QStyle::RSIP_OnMouseClickAndAlreadyFocused when
deciding to launch the software input panel.

  • Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent):
1:00 PM Changeset in webkit [56804] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

​https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): This is now the primary function for determining Windows key code - there is no reason to round trip a virtual key code via character code to get Windows virtual key code, and this can't work for non-Roman alphabets. (WebCore::windowsKeyCodeForCharCode): Removed keys that are now handled in windowsKeyCodeForKeyCode(), only keeping those for which we don't have known key codes (yet?).
  • platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Added comments.
12:51 PM Changeset in webkit [56803] by eric@webkit.org
  • 9 edits
    2 copies
    1 move
    1 add in trunk

2010-03-30 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge
Uses Geoposition instead of individual params for setLastPosition.
​https://bugs.webkit.org/show_bug.cgi?id=36535

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): (WebCore::GeolocationServiceChromium::setIsAllowed): (WebCore::GeolocationServiceChromium::setLastPosition):
  • platform/chromium/GeolocationServiceChromium.h:

2010-03-30 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge:
Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp
Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.

​https://bugs.webkit.org/show_bug.cgi?id=36535

  • WebKit.gyp:
  • public/GeolocationServiceBridgeChromium.h:
  • public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. (WebKit::WebGeolocationService::detachBridge):
  • public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
  • public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
  • src/ChromiumBridge.cpp:
  • src/GeolocationServiceBridgeChromium.cpp: Removed.
  • src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp. (WebKit::createGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
  • src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
12:31 PM Changeset in webkit [56802] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement win-ews
​https://bugs.webkit.org/show_bug.cgi?id=36809

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:21 PM Changeset in webkit [56801] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Fixed some size issues caused by how we now compute the WebGL canvas size

11:16 AM Changeset in webkit [56800] by agl@chromium.org
  • 7 edits in trunk

2010-03-30 Adam Langley <​agl@chromium.org>

Reviewed by David Levin.

[chromium] linux: prefer the "hinting" fontconfig preference.

fontconfig can give contradictory hinting information, setting
"hinting" to zero and "hintstyle" to non-zero. In this case we
should take the "hinting" preference.

​https://bugs.webkit.org/show_bug.cgi?id=36602

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
10:42 AM Changeset in webkit [56799] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Copying from the Content tab in Resources includes line numbers.

​https://bugs.webkit.org/show_bug.cgi?id=35104

10:32 AM Changeset in webkit [56798] by pfeldman@chromium.org
  • 5 edits in trunk

2010-03-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not send empty matching rules for pseudo elements to frontend.

​https://bugs.webkit.org/show_bug.cgi?id=36834

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update):
10:09 AM Changeset in webkit [56797] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=36791
Add assertions for instance proxy validity

Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
pointer to one across complicated function calls, relying on the caller to protect the
reference.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::renderContextID): (WebKit::NetscapePluginInstanceProxy::pluginView): (WebKit::NetscapePluginInstanceProxy::hostProxy):
9:57 AM Changeset in webkit [56796] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test_expectations.txt to enable send-dragged-sliced-file.html
​https://bugs.webkit.org/show_bug.cgi?id=36764

Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:
9:40 AM Changeset in webkit [56795] by krit@webkit.org
  • 8 edits
    3 adds in trunk

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
​https://bugs.webkit.org/show_bug.cgi?id=21371

Add animation support for 'points' on polygons in SVG.

Test: svg/animations/animate-points.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::): added PropertyType PointsProperty
  • svg/SVGPointList.cpp: (WebCore::blendFunc): (WebCore::SVGPointList::createAnimated): calculates animated PointList
  • svg/SVGPointList.h:

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
​https://bugs.webkit.org/show_bug.cgi?id=21371

Tests if points of a polygon are animateable.

  • svg/animations/animate-points-expected.txt: Added.
  • svg/animations/animate-points.html: Added.
  • svg/animations/script-tests/animate-points.js: Added. (sample1): (sample2): (sample3): (executeTest):
9:18 AM Changeset in webkit [56794] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Adjusted test-webkitpy to delete all orphaned *.pyc files
from webkitpy/ prior to importing any modules from webkitpy.
This ensures that no import statements in webkitpy falsely
succeed because of leftover *.pyc files.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=36599

  • Scripts/test-webkitpy:
    • Added _clean_pyc_files() to delete orphaned *.pyc files from a directory.
    • Added _clean_webkitpy_with_test() to call and test _clean_pyc_files().
    • Moved the "import webkitpy.python24.versioning" statement from the top of the module to the init() method -- immediately after the call to _clean_webkitpy_with_test().
8:43 AM Changeset in webkit [56793] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: bring test expectation back - it still fails for some
reason.

  • platform/chromium/test_expectations.txt:
8:40 AM Changeset in webkit [56792] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: bad CSS selector results in exception inside evaluated code
​https://bugs.webkit.org/show_bug.cgi?id=36821

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
8:23 AM Changeset in webkit [56791] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix build break on Qt Mac.

Reviewed by nobody, build break.

DESTDIR path on Mac do not include the configuration path by default
like on Windows. Have to force it.

7:51 AM Changeset in webkit [56790] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Package build fixes for Symbian

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-03-29
Reviewed by Simon Hausmann.

  • enable building standalone QtWebkit for Symbian using qtlibinfix configuration option

qtlibinfix adds possibility having multiple versions of Qt in Symbian devices.
Fix also allows unfrozen DLL exports during development.

  • Removed heap size configuration. DLLs don't have a heap.
  • Removed enforcement to def files for package builds. Instead inherit the setting from

Qt's qconfig.pri whether to use def files or not. It's still possible to override this
also at qmake time by passing CONFIG+=def_files.

  • WebCore.pro:
7:50 AM Changeset in webkit [56789] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Title for show/hide short records button was adjusted.
Some unused code was removed.
​https://bugs.webkit.org/show_bug.cgi?id=36823

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
7:49 AM Changeset in webkit [56788] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:45 AM Changeset in webkit [56787] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: removed failure expectation from Chromium.

  • platform/chromium/test_expectations.txt:
7:16 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:13 AM Changeset in webkit [56786] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • Interfaces/WebKit.idl: Touched this to force a build.
7:13 AM Changeset in webkit [56785] by Adam Roben
  • 2 edits in trunk/WebCore

Enable extra Direct3D debugging information in Debug builds

This makes it easier to track down memory leaks and misuses of the D3D
APIs in Debug builds.

Fixes <​http://webkit.org/b/36820>

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp: Define D3D_DEBUG_INFO

in Debug builds before #including d3d9.h so that extra D3D debugging
information will be enabled.

7:10 AM April 2010 Meeting edited by ukai@chromium.org
Add Fumitoshi Ukai (diff)
7:10 AM Changeset in webkit [56784] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-03-30 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
​https://bugs.webkit.org/show_bug.cgi?id=36790

Moving maemo5 theme related code from WebCore.pri to WebCore.pro and adding
new maemo menu lists popup class source and header to the project.

The code was in .pri file because of a theme css that was conditionally included.
As the css file is been included unconditionally there is no need to this
code to be kept in webcore.pri.

  • WebCore.pri:
  • WebCore.pro:

2010-03-30 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
​https://bugs.webkit.org/show_bug.cgi?id=36790

A new QtAbstractWebPopup descendant class to be used for maemo menu lists.
This is the first step. The next step will be the dialogs implementation that
will come in bug 36789 and finally to use QtMaemoWebPopup instead of QtFallbackWebPopup
that will come in bug 36368.

  • WebCoreSupport/QtMaemoWebPopup.cpp: Added. (WebCore::QtMaemoWebPopup::QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::~QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::QtMaemoWebPopup::createPopup): (WebCore::QtMaemoWebPopup::show): (WebCore::QtMaemoWebPopup::hide): (WebCore::QtMaemoWebPopup::popupClosed): (WebCore::QtMaemoWebPopup::itemClicked):
  • WebCoreSupport/QtMaemoWebPopup.h: Added. (WebCore::Maemo5Popup::Maemo5Popup):
7:01 AM FAQ edited by tony@gonk.net
Fixed incorrect use of “it’s”. Changed hyphen to m-dash. (diff)
7:01 AM Changeset in webkit [56783] by jchaffraix@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

fast/parser/comments.html needs some clean-up
​https://bugs.webkit.org/show_bug.cgi?id=36537

Reviewed by Darin Adler.

  • The test is converted to dumpAsText now.
  • The output is also made more explicit as to what is expected (adding some PASSED and FAILED).
  • Finally some part of the test were actually commented so added some comment endings to make sure we run all the part of the test.
  • fast/parser/comments-expected.txt: Added.
  • fast/parser/comments.html:
  • platform/chromium-linux/fast/parser/comments-expected.checksum: Removed.
  • platform/chromium-linux/fast/parser/comments-expected.png: Removed.
  • platform/chromium-win/fast/parser/comments-expected.checksum: Removed.
  • platform/chromium-win/fast/parser/comments-expected.png: Removed.
  • platform/chromium-win/fast/parser/comments-expected.txt: Removed.
  • platform/mac/fast/parser/comments-expected.checksum: Removed.
  • platform/mac/fast/parser/comments-expected.png: Removed.
  • platform/mac/fast/parser/comments-expected.txt: Removed.
  • platform/qt/fast/parser/comments-expected.txt: Removed.
6:45 AM Changeset in webkit [56782] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-30 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove dysfunctional implementation of canEstablishDatabase for
Workers. I postpone this implementation until Workers can actually
access Web Databases.

​https://bugs.webkit.org/show_bug.cgi?id=36795

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.h:
6:27 AM Changeset in webkit [56781] by eric@webkit.org
  • 16 edits
    1 add in trunk

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Guard Geolocation files with ENABLE_GEOLOCATION
​https://bugs.webkit.org/show_bug.cgi?id=25756

The intent is to guard the Geolocation implementation files
and minimize the impact on on clients/call sites.

  • DerivedSources.make:
  • WebCore.Geolocation.exp: Added. Exported interfaces if GEOLOCATION is enabled.
  • WebCore.base.exp:
  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): Stub implementation if GEOLOCATION is turned off. (WebCore::Geolocation::Geolocation): Ditto. (WebCore::Geolocation::~Geolocation): Ditto. (WebCore::Geolocation::setIsAllowed): Ditto.
  • page/Geolocation.h:
  • page/Geolocation.idl:
  • page/GeolocationPositionCache.cpp:
  • page/Geoposition.idl:
  • page/PositionError.idl:
  • platform/GeolocationService.cpp:
  • platform/mock/GeolocationServiceMock.cpp:

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Explicit guards for ENABLE_GEOLOCATION
​https://bugs.webkit.org/show_bug.cgi?id=25756

  • WebCoreSupport/WebGeolocationMock.mm: (-[WebGeolocationMock setError:code:]): Make the body conditional on ENABLE(GEOLOCATION) (-[WebGeolocationMock setPosition:]): Ditto.
6:08 AM Changeset in webkit [56780] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-30 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Support EventTarget interface in fake workers (both for Worker object
and WorkerContext). Use MessagePort to implement message passing to
support passing ports in PostMessage.
​https://bugs.webkit.org/show_bug.cgi?id=36763

  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.Worker.onmessageGetter): (InjectedFakeWorker.Worker.onmessageSetter): (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageGetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageSetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._addEventListener): (InjectedFakeWorker.FakeWorker.prototype._removeEventListener): (InjectedFakeWorker.FakeWorker.prototype._callbackWrapper): (InjectedFakeWorker.FakeWorker.prototype._handleException):
5:44 AM Changeset in webkit [56779] by apavlov@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-03-30 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, test missing in r56732.

  • inspector/audits-panel-functional-expected.txt: Added.
  • inspector/audits-panel-functional.html: Added.
  • inspector/resources/audits-script1.js: Added. (foo1):
  • inspector/resources/audits-script2.js: Added. (foo2):
  • inspector/resources/audits-script3.js: Added. (foo3):
  • inspector/resources/audits-style1.css: Added.
5:44 AM Changeset in webkit [56778] by benm@google.com
  • 2 edits in trunk/WebCore

[v8] Add if ENABLE guard for Worker specific code.
​https://bugs.webkit.org/show_bug.cgi?id=36597

Patch by Kristian Monsen <​kristianm@google.com> on 2010-03-30
Reviewed by David Levin.

Build fix only, no new tests.

  • bindings/v8/V8DOMWrapper.h:
4:58 AM Changeset in webkit [56777] by jorlow@chromium.org
  • 20 edits
    1 copy
    1 move
    3 deletes in trunk

2010-03-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
​https://bugs.webkit.org/show_bug.cgi?id=36770

Add the "singleton" IndexedDatabase object to PageGroup
IndexedDatabase now has a create() method since PageGroup can own the instance (at least for now)
Rip out the IDBRequest stuff (now obsolete).
DOMWindow now can instantiate indexedDatabase objects on demand.

New layout tests starting with the next patch (which should make indexedDB.open() "work").

  • WebCore.gypi:
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
  • page/DOMWindow.h:
  • page/PageGroup.cpp: (WebCore::PageGroup::indexedDatabase):
  • page/PageGroup.h:
  • storage/IDBDatabase.cpp:
  • storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
  • storage/IDBDatabaseRequest.idl:
  • storage/IDBRequest.cpp: Removed.
  • storage/IDBRequest.h: Removed.
  • storage/IDBRequest.idl: Removed.
  • storage/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::create): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
  • storage/IndexedDatabaseRequest.h: (WebCore::IndexedDatabaseRequest::create):
  • storage/IndexedDatabaseRequest.idl:
  • storage/chromium/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):

2010-03-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
​https://bugs.webkit.org/show_bug.cgi?id=36770

Start the implementation of WebIndexedDatabase (for entrance back into WebKit).

  • WebKit.gyp:
  • public/WebIndexedDatabase.h:
  • src/WebIndexedDatabaseImpl.cpp: Added. (WebKit::WebIndexedDatabase::create): (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl): (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h: Added.
4:30 AM Changeset in webkit [56776] by krit@webkit.org
  • 8 edits
    5 adds in trunk

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
​https://bugs.webkit.org/show_bug.cgi?id=36731

Kerning on SVGFonts should be applied to the userSpace of the current Char
and not to the userSpace of the viewport. This means scaling the kerning
to match the current userSpace.

Test: svg/custom/glyph-transformation-with-hkern.svg

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
​https://bugs.webkit.org/show_bug.cgi?id=36731

Test of correct scaled kerning, if userSpace on SVGFont doesn't
match the scaling of the viewport userSpace.

  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • svg/custom/glyph-transformation-with-hkern.svg: Added.
  • svg/custom/resources/SVGFreeSans.svg: Added.
4:28 AM Changeset in webkit [56775] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
​https://bugs.webkit.org/show_bug.cgi?id=36695

Test: svg/custom/animation-currentColor.svg

SVG Animation can't handle currentColor at the moment. This patch catches the
color value of the target element and replaces 'currentColor' with it's color string.

  • svg/SVGAnimationElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimationElement::startedActiveInterval):

2010-03-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
​https://bugs.webkit.org/show_bug.cgi?id=36695

Check if SVG animation takes the color value of the target element as 'currentColor'.

  • platform/mac/svg/custom/animation-currentColor-expected.checksum: Added.
  • platform/mac/svg/custom/animation-currentColor-expected.png: Added.
  • platform/mac/svg/custom/animation-currentColor-expected.txt: Added.
  • svg/custom/animation-currentColor.svg: Added.
2:27 AM Changeset in webkit [56774] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-30 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
​https://bugs.webkit.org/show_bug.cgi?id=36811

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.
Same as ​https://bugs.webkit.org/show_bug.cgi?id=36586

  • Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
2:11 AM Changeset in webkit [56773] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Skip http/tests/inspector-enabled on Linux and Mac where LayoutTestContoller doesn't support inspector methods yet.

​https://bugs.webkit.org/show_bug.cgi?id=36807

  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [56772] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Visible/captured records counter should be implemented in Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=36708

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._updateRecordsCounter): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._filterRecords):
  • inspector/front-end/inspector.css: (.timeline-records-counter):
12:53 AM April 2010 Meeting edited by Philippe Normand
Igalia people (diff)
12:24 AM Changeset in webkit [56771] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
​https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Adam Barth.

  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Ditto.
12:09 AM Changeset in webkit [56770] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-30 Philippe Normand <​pnormand@igalia.com>

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
​https://bugs.webkit.org/show_bug.cgi?id=36653

Unreviewed, don't define the bool variable with
DEFINE_STATIC_LOCAL, it makes sense only for objects which have a
destructor. Thanks to Dan Bernstein for spotting this.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
12:08 AM Changeset in webkit [56769] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-29 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

There is a build break due to the disabled() when wml feature is
enabled. This break comes from the Bug 35056 - Disabled menu options
are still submitted.(​https://bugs.webkit.org/show_bug.cgi?id=35056)
The WMLOptionElement.h needs to define the disabled() as well.
And, there is an additional break due to Bug 36177 - Multiselect Popup

​https://bugs.webkit.org/show_bug.cgi?id=36698

  • wml/WMLOptionElement.h: (WebCore::WMLOptionElement::disabled):
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::listBoxSelectItem):
12:02 AM Changeset in webkit [56768] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Barth.

Needed to fix test_expectations.txt for recent addition in r56764.

  • platform/chromium/test_expectations.txt: Added IMAGE (due to the results on OSX).

Mar 29, 2010:

11:52 PM Changeset in webkit [56767] by alice.liu@apple.com
  • 2 edits in trunk/JavaScriptCore

add JSObjectRefPrivate.h

Reviewed by NOBODY (build fix).

11:46 PM BuildingQtOnLinux edited by fboudra@gmail.com
Fix typo (diff)
11:44 PM Changeset in webkit [56766] by levin@chromium.org
  • 11 edits
    9 adds in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
​https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Shinichiro Hamaji.

Various rebaselines due to changes in layout or new tests. The revision that caused
each change is by the change.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.
11:42 PM BuildingQtOnLinux edited by fboudra@gmail.com
Add missing build dependencies (diff)
11:16 PM Changeset in webkit [56765] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <​eric@webkit.org>

Unreviewed, build fix only.

  • Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
11:15 PM Changeset in webkit [56764] by hamaji@chromium.org
  • 7 edits
    4 adds in trunk

2010-03-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
​https://bugs.webkit.org/show_bug.cgi?id=36461

  • fast/repaint/overflow-scroll-body-appear.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-03-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
​https://bugs.webkit.org/show_bug.cgi?id=36461

Don't suppress scrollbar change for non-first layouts.
In the first layout, the scrollbar change will happen in later
adjustViewSize() call, but in other layouts, adjustViewSize() may
not be called when the size of contents doesn't change.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
11:08 PM Changeset in webkit [56763] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Remove '_flymake' suffix from base part of file name so that
check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.

​https://bugs.webkit.org/show_bug.cgi?id=36573

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
10:41 PM Changeset in webkit [56762] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Get the following test-webkitpy unit test working again:
scm_unittest.SVNTest.test_svn_apply().

​https://bugs.webkit.org/show_bug.cgi?id=36696

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add leading spaces to the empty lines of the ChangeLog strings.
    • Manually set the _reviewer attribute on the Attachment object to get the tests to pass.
10:09 PM Changeset in webkit [56761] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-03-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adele Peterson.

Default value of accelerated compositing should be false for Windows
​https://bugs.webkit.org/show_bug.cgi?id=36805

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
9:04 PM Changeset in webkit [56760] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-03-29 Martin Robinson <Martin Robinson>

Reviewed by Holger Freyther.

[GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
​https://bugs.webkit.org/show_bug.cgi?id=36390

Suppress debugging messages sent to the GLib logger during DRT runs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (logHandler): Added. (main): Use logHandler as the default GLib log message handler.
7:59 PM Changeset in webkit [56759] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-03-29 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

MIPS JIT Supports
​https://bugs.webkit.org/show_bug.cgi?id=30144

The following changes enable MIPS JIT.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::lbu): (JSC::MIPSAssembler::linkWithOffset):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load8): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::setTest8): (JSC::MacroAssemblerMIPS::setTest32):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
7:44 PM Changeset in webkit [56758] by levin@chromium.org
  • 49 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
​https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Dimitri Glazkov.

r56655 changed how tables layout which causes a lot of pixels tests for
tables to need rebaselines.

r56693 did some svg changes.

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by ​http://crbug.com/35387).
7:32 PM Changeset in webkit [56757] by eric@webkit.org
  • 6 edits in trunk

2010-03-29 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

  • fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Check that an isolated ​file:// origin can access about:blank iframes that it created itself.

2010-03-29 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Don't use unique domains for ​file:// separation: it breaks local
databases, and access to your own same-origin iframes. Instead, use
path-based access checks.

​https://bugs.webkit.org/show_bug.cgi?id=36692

Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

  • dom/Document.cpp: (WebCore::Document::initSecurityContext): renamed API.
  • page/SecurityOrigin.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Initialize new flag. Take note of ​file:// path. Copy new fields in copy constructor. (WebCore::SecurityOrigin::canAccess): Take into account path-based origin separation for ​file:// (WebCore::SecurityOrigin::enforceFilePathSeparation): New method to enable ​file:// path origin separation. (WebCore::SecurityOrigin::toString): Return a null domain for an isolated file origin. (WebCore::SecurityOrigin::isSameSchemeHostPort): Take into account path-based origin separation for ​file:// (WebCore::SecurityOrigin::passesFileCheck): Abstraction of common logic for ​file:// access checks.
6:38 PM Changeset in webkit [56756] by eric@webkit.org
  • 11 edits in trunk

2010-03-29 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-29 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::checkPermission):
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:

2010-03-29 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
6:15 PM Changeset in webkit [56755] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot should comment on bugs when builders break
​https://bugs.webkit.org/show_bug.cgi?id=36786

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Add a new _post_blame_comment_to_bug and all it from process_work_item
    • Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test the new _post_blame_comment_to_bug call
6:07 PM Changeset in webkit [56754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot fails to get information about certain builds
​https://bugs.webkit.org/show_bug.cgi?id=36768

This seems to be caused by:
​http://buildbot.net/trac/ticket/753
I have no work-around, but for now at least we're logging
the error better. I also added allow_none to our ServerProxy
creation in case that fixes things for other versions of python.

  • Scripts/webkitpy/common/net/buildbot.py:
5:34 PM Changeset in webkit [56753] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Victor Wang <​victorw@chromium.org>

Reviewed by Adam Barth.

Add sign in/out link to TestResults appengine

Add a link to main menu for sign in/out to this appengine.
People signed in with admin privilege could perform
actions that are only allowed to admins like deleting files.

​https://bugs.webkit.org/show_bug.cgi?id=36767

  • TestResultServer/handlers/menu.py:
  • TestResultServer/stylesheets/menu.css: (.sign):
  • TestResultServer/templates/menu.html:
5:16 PM Changeset in webkit [56752] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-29 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
​https://bugs.webkit.org/show_bug.cgi?id=36769

Adding method itemIsSelected() to QtAbstractWebPopup.

  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::itemIsSelected):
4:58 PM Changeset in webkit [56751] by levin@chromium.org
  • 8 edits
    6 moves
    53 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

[Chromium] pixel layout test fixes.

r56655 caused runin test which needed separate results for each platform.
r56673 caused computed-style-expected.
r56655 cause the fast/table changes (and we need linux specific results).
r56644 caused clip-path-referencing-use2-expected.
r56693 caused painting-marker-01-f-expected.

  • platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
  • platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
  • platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
  • platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
  • platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
  • platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated2-expected.png: Added.
  • platform/chromium-win/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated3-expected.png: Added.
  • platform/chromium-win/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated4-expected.png: Added.
  • platform/chromium-win/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
4:58 PM Changeset in webkit [56750] by eric@webkit.org
  • 8 edits in trunk

2010-03-29 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Simon Hausmann.

Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*

​https://bugs.webkit.org/show_bug.cgi?id=36395

This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
is used to check whether or not a request is supposed to be rendered or
simply downloaded based on the "Content-Disposition" header sent by the
web server. The intent of code refactoring is to avoid code duplication
so that this piece of code can be used by other implementations such as
QtWebKit.

  • platform/network/HTTPParsers.cpp: (WebCore::shouldTreatAsAttachment):
  • platform/network/HTTPParsers.h:

2010-03-29 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Simon Hausmann.

Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
and replacted local version with the factored out version.

The code was factored out to make possible its use in other implementations
such as QtWebKit.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

2010-03-29 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Simon Hausmann.

[Qt] Added support for handling the HTTP "Content-Disposition" header.

​https://bugs.webkit.org/show_bug.cgi?id=36395

Whenever a server response contains a "Content-Disposition: attachment..." header,
treat the request as a download and emit the unsupportedContent signal.

  • Api/qwebpage.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
4:38 PM Changeset in webkit [56749] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
​https://bugs.webkit.org/show_bug.cgi?id=36735

  • platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-on-image.html: Added.

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
​https://bugs.webkit.org/show_bug.cgi?id=36735

Test: platform/mac/accessibility/aria-liveregion-on-image.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::contentChanged):
4:33 PM Changeset in webkit [56748] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

ValidateReviewer step is draconian and un-tested
​https://bugs.webkit.org/show_bug.cgi?id=36792

ValidateReviewer logic was commented out in
​http://trac.webkit.org/changeset/56744
That was a symptom of the fact that validatereviewer.py
is too inflexible to be used when real humans are driving webkit-patch.
For now we just disable ValidateReviewer when humans are at the keyboard.

  • Scripts/webkitpy/tool/steps/validatereviewer.py:
    • Only run when in non-interactive mode.
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
    • Test our validation logic to make sure it's sane.
4:18 PM Changeset in webkit [56747] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Eliminate explicit slash characters from check-webkit-style's
_rel_path() method to make its implementation more platform
independent.

​https://bugs.webkit.org/show_bug.cgi?id=36759

  • Scripts/webkitpy/style/main.py:
    • Changed to use os.sep instead of slash_chars "/
      ". This can be done since os.path.abspath() converts slashes to os.sep.
3:35 PM Changeset in webkit [56746] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change new-run-webkit-tests to not use more than four threads by
default on the mac port until
​https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

​https://bugs.webkit.org/show_bug.cgi?id=36687

  • Scripts/webkitpy/layout_tests/port/mac.py:
3:34 PM Changeset in webkit [56745] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

​https://bugs.webkit.org/show_bug.cgi?id=36691

  • Scripts/webkitpy/layout_tests/port/mac.py:
3:28 PM Changeset in webkit [56744] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

2010-03-29 Stephen White <​senorblanco@chromium.org>

Reviewed by Dave Hyatt.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

​https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/cssText-cache.html, and more.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:

2010-03-29 Stephen White <​senorblanco@chromium.org>

Reviewed by Dave Hyatt.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

​https://bugs.webkit.org/show_bug.cgi?id=36556

  • fast/css/cssText-cache-expected.txt: Added.
  • fast/css/cssText-cache.html: Added.
3:26 PM April 2010 Meeting edited by Laszlo Gombos
(diff)
3:20 PM Changeset in webkit [56743] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails java/lc3 on a clean checkout
​https://bugs.webkit.org/show_bug.cgi?id=36078

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Build the java support files in check_build
    • Unwrap a line which would still fit under 80col
3:19 PM Changeset in webkit [56742] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build Fix: Touch WebKit.idl to force Interfaces to rebuild

3:15 PM Changeset in webkit [56741] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build fix. Touch WebKit.idl to force rebuild.

2:44 PM Changeset in webkit [56740] by kenneth@webkit.org
  • 19 edits
    2 adds in trunk

JavaScriptCore: Add an enable flag for the Widgets (​http://www.w3.org/TR/widgets-reqs/)
and turn it on for Qt only.

Reviewed by Simon Fraser.

  • wtf/Platform.h:

WebCore: When enabling Web Widgets, add support for the view-mode media
feature (​http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Test: fast/media/media-feature-wgt-view-mode.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::view_modeMediaFeatureEval):

  • page/ChromeClient.h:

(WebCore::ChromeClient::isDocked):
(WebCore::ChromeClient::isFloating):
(WebCore::ChromeClient::isApplication):
(WebCore::ChromeClient::isFullscreen):

WebKit/qt: Add an internal Qt API for changing the view mode media feature
(​http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

  • Api/qwebpage.cpp:

(qt_wrt_setViewMode):
(QWebPagePrivate::priv):

  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::isDocked):
(WebCore::ChromeClientQt::isFloating):
(WebCore::ChromeClientQt::isApplication):
(WebCore::ChromeClientQt::isFullscreen):

  • WebCoreSupport/ChromeClientQt.h:

WebKitTools: Add hooks to the Qt DRT for testing the view mode media feature.

Reviewed by Simon Fraser.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setViewModeMediaFeature):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add a test and an expected result for the Widgets 1.0: View Mode
Media Feature (​http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Skip on all other platforms than Qt, that has Skipped files.

  • fast/media/media-feature-wgt-view-mode.html: Added.
  • fast/media/media-feature-wgt-view-mode-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
1:51 PM Changeset in webkit [56739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Adam Barth <​abarth@webkit.org>

Unreviewed. Update expected results for unit tests.

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1:49 PM Changeset in webkit [56738] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Adam Barth <​abarth@webkit.org>

Unreviewed. I think Eric meant svn_revision.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
1:40 PM Changeset in webkit [56737] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
​https://bugs.webkit.org/show_bug.cgi?id=29311

Now that we have sheriff-bot watching the tree, it can post
rollout patches on behalf of the commit queue.

  • Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Break IRC logic out into _post_irc_warning for easier testing.
    • Add _post_rollout_patch for posting rollout patches to bugzilla.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test _rollout_reason
  • Scripts/webkitpy/tool/grammar.py:
    • Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
  • Scripts/webkitpy/tool/grammar_unittest.py:
    • Test join_with_separators
1:31 PM Changeset in webkit [56736] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sheriffbot should actually run commands
​https://bugs.webkit.org/show_bug.cgi?id=36776

Some minor changes to Sheriffbot:

1) We should actually run commands (by giving control back to the
command processing object.

2) Use URLs instead of just numbers to represent SVN revisions (making
it easier to folks in IRC ot followup).

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
12:51 PM QtWebKitRelease20 edited by fboudra@gmail.com
(diff)
12:50 PM QtWebKitRelease20 edited by fboudra@gmail.com
nicer (diff)
12:48 PM QtWebKitRelease20 edited by fboudra@gmail.com
Link to the top of the page (diff)
12:45 PM BuildingQtOnLinux edited by fboudra@gmail.com
Update build dependencies for Debian and Ubuntu (diff)
11:54 AM April 2010 Meeting edited by geoffrey.levand@am.sony.com
Add Geoff Levand. (diff)
11:28 AM Changeset in webkit [56735] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-03-29 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
​https://bugs.webkit.org/show_bug.cgi?id=36737

No new tests; ran WebGL demos in Chromium on Windows to verify fix.

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
11:20 AM Changeset in webkit [56734] by levin@chromium.org
  • 1 edit
    109 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

Add chromium specific baselines for table tests added in r56641
and for runin tests added in r56655.

  • platform/chromium-mac/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-overrides-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-left-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-100percent-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-positioned-expected.txt.
  • platform/chromium-win/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.txt: Added.
  • platform/chromium/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium/fast/runin/generated2-expected.png: Added.
  • platform/chromium/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium/fast/runin/generated3-expected.png: Added.
  • platform/chromium/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium/fast/runin/generated4-expected.png: Added.
11:10 AM Changeset in webkit [56733] by Joseph Pecoraro
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Test for Ensuring Pseudo Class's are Respected on Dynamic Changes
​https://bugs.webkit.org/show_bug.cgi?id=36765

This tests elements affected by a CSS pseudo class selector is updated
after a dynamic DOM change.

  • fast/css/dynamic-pseudo-class-expected.txt: Added.
  • fast/css/dynamic-pseudo-class.html: Added.
10:59 AM Changeset in webkit [56732] by apavlov@chromium.org
  • 7 edits in trunk

2010-03-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cover the Audits panel with tests
​https://bugs.webkit.org/show_bug.cgi?id=36613

LayoutTests:

  • inspector/audits-panel-functional-expected.txt: Added.
  • inspector/audits-panel-functional.html: Added.
  • inspector/resources/audits-script1.js: Added. (foo1):
  • inspector/resources/audits-script2.js: Added. (foo2):
  • inspector/resources/audits-script3.js: Added. (foo3):

WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane.ruleSorter): (WebInspector.AuditCategoryResultPane):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditRuleResult.linkifyDisplayName): (WebInspector.AuditRuleResult.resourceDomain): (WebInspector.AuditRuleResult.prototype.addURL):
  • inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
10:54 AM April 2010 Meeting edited by ericu@chromium.org
(diff)
10:50 AM Changeset in webkit [56731] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-29 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Antti Koivisto.

Use 'Mobile Safari' instead of 'Safari' on mobile Qt platforms.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
10:39 AM Changeset in webkit [56730] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Fix build break introduced in r56724.

Reviewed by nobody, build fix.

  • WebCore.pro:
10:31 AM Changeset in webkit [56729] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-29 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Corrected name of (u)int64_t compile time assert.
​https://bugs.webkit.org/show_bug.cgi?id=36739

int64_t_is_four_bytes -> int64_t_is_eight_bytes

  • os-win32/stdint.h:
10:13 AM Changeset in webkit [56728] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-29 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=36743

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
10:11 AM Changeset in webkit [56727] by apavlov@chromium.org
  • 4 edits in trunk

2010-03-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector should highlight when clicking a node's closing tag
​https://bugs.webkit.org/show_bug.cgi?id=16258

LayoutTests:

  • inspector/elements-panel-limited-children.html:

WebCore:

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set suppressRevealAndSelect): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.onselect): (WebInspector.ElementsTreeElement.prototype.ondblclick): ():
10:03 AM April 2010 Meeting edited by chang.shu@nokia.com
(diff)
10:00 AM April 2010 Meeting edited by Chris Jerdonek
Alphabetize list of attendees (diff)
9:56 AM April 2010 Meeting edited by darin@chromium.org
(diff)
9:56 AM Changeset in webkit [56726] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-29 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

​https://bugs.webkit.org/show_bug.cgi?id=36315

Remove obsolete Geolocation::m_currentPosition
(follow up on ​https://bugs.webkit.org/show_bug.cgi?id=30676)

  • page/Geolocation.cpp: (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::makeSuccessCallbacks):
  • page/Geolocation.h:
  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):
9:52 AM April 2010 Meeting edited by treat@kde.org
(diff)
9:51 AM April 2010 Meeting edited by dbates@webkit.org
Added myself to the list of attendees (diff)
9:31 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:24 AM Changeset in webkit [56725] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.

Reviewed by Simon Hausmann.

9:24 AM Changeset in webkit [56724] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Do not generate INSTALLS for webkit when building inside Qt.
Qt will do this for us.

Reviewed by Simon Hausmann.

  • WebCore.pro:
9:21 AM April 2010 Meeting edited by rik@webkit.org
(diff)
9:19 AM April 2010 Meeting edited by ben@webkit.org
(diff)
9:10 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:05 AM Changeset in webkit [56723] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in ​http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

  • loader/loader.cpp:

(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

9:04 AM April 2010 Meeting edited by vestbo@webkit.org
(diff)
8:29 AM April 2010 Meeting edited by kenneth@webkit.org
(diff)
8:28 AM April 2010 Meeting edited by kenneth@webkit.org
(diff)
8:16 AM April 2010 Meeting created by Chris Jerdonek
Started page for WebKit meeting
8:15 AM Changeset in webkit [56722] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
​https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
8:12 AM WikiStart edited by Chris Jerdonek
Fix typo (diff)
8:11 AM WikiStart edited by Chris Jerdonek
Created link to a page for the April 2010 WebKit meeting (diff)
7:48 AM Changeset in webkit [56721] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] unit tests don't compile inside of Qt

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=36756

  • tests/tests.pri: Don't do the target substitution inside Qt and find the sources

through VPATH instead of relying on the location of the .pro file exclusively.

7:40 AM Changeset in webkit [56720] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
​https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: updated after r56718.
7:03 AM Changeset in webkit [56719] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=36749

Doing a 'make sis' expects the dll in the libdir, so place it
there. This fixes out-of-source building to always put the dll
in the expected dir.

  • WebCore.pro: Fix for shadow builds inside Qt.
7:03 AM Changeset in webkit [56718] by kenneth@webkit.org
  • 47 edits
    2 adds in trunk

WebCore: Implement flattening for iframes.

Reviewed by Antti Koivisto.

Refactoring of frameset flattening code to reuse it for
iframe flattening.

Tests: fast/frames/flattening/iframe-flattening-simple.html

  • WebCore.base.exp:
  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameFlatteningEnabled):

  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

  • rendering/RenderFrameSet.h:
  • rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

  • rendering/RenderPartObject.h:

WebKit/mac: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isFrameFlatteningEnabled]):
(-[WebPreferences setFrameFlatteningEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt: Change due to renaming of frame flattening setting.

Reviewed by Antti Koivisto.

  • Api/qwebpage.cpp:

(qt_drt_setFrameFlatteningEnabled):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • symbian/eabi/QtWebKitu.def:

WebKit/win: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Renaming of frame flattening LayoutTestController method
to setFrameFlatteningEnabled(bool)

Reviewed by Antti Koivisto.

  • DumpRenderTree/LayoutTestController.cpp:

(setFrameFlatteningEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests: Add new iframe flattening test and change existing frameset
flattening tests to use the new LayoutTestController method.

Reviewed by Antti Koivisto.

  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-simple.html: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
6:53 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:53 AM QtWebKitBackportingFixes edited by yael.aharon@nokia.com
(diff)
5:23 AM Changeset in webkit [56717] by Csaba Osztrogonác
  • 1 edit
    51 adds in trunk/LayoutTests

[Qt] Platform specific expected file added for tests introduced in r56655,
because they pass. Compared to png file and Mac expected file.

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/table/table-background-expected.checksum: Added.
  • platform/qt/fast/table/table-background-expected.png: Added.
  • platform/qt/fast/table/table-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-background-expected.png: Added.
  • platform/qt/fast/table/table-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-expected.png: Added.
  • platform/qt/fast/table/table-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Added.
4:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:49 AM Changeset in webkit [56716] by benm@google.com
  • 4 edits
    1 add in trunk/WebCore

Page Cache does not work on Android with V8
​https://bugs.webkit.org/show_bug.cgi?id=36665

Patch by Andrei Popescu <​andreip@google.com> on 2010-03-29
Reviewed by Adam Barth.

No new tests, existing tests should suffice, this is platform code.

This implementation simply saves the context and the global object
just before the frame is navigated to a new url. At restore time,
the global object is reattached to the context and the context
is attached to the window shell of the frame.

Note that isolated worlds are not taken into account in any way,
as Android does not use them.

  • bindings/v8/ScriptCachedFrameData.cpp: Added.

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setContext):

  • bindings/v8/V8DOMWindowShell.h:
4:14 AM Changeset in webkit [56715] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Make it possible to build using both Windows and Linux for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=36748

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

  • WebCore.pro: don't assume Windows buildsystem is the only one

and exclude the windows-only setters from the linux builds.

4:07 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:55 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:49 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:44 AM Changeset in webkit [56714] by Simon Hausmann
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36745

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

[Qt] Fix def file builds with Qt 4.7.

Switched to using DEF_FILE, which is the official variable.

  • WebCore.pro: Use DEF_FILE
2:35 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:26 AM Changeset in webkit [56713] by jorlow@chromium.org
  • 13 edits
    8 copies
    2 adds in trunk

2010-03-24 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

A few more steps towards IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=36546

Add a callback interface to be used by all async methods.
Add the first fragments of IDBDatabase.
Clean up on IDBDatabaseError.
Flesh out IndexedDatabase further.

Not enough hooked up yet to test. Soon though...

  • WebCore.gypi:
  • storage/IDBCallbacks.h: Added. (WebCore::IDBCallbacks::~IDBCallbacks):
  • storage/IDBDatabase.cpp: Added.
  • storage/IDBDatabase.h: Added. (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::IDBDatabaseError):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):

2010-03-24 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB plumbing
​https://bugs.webkit.org/show_bug.cgi?id=36546

Plumbing work towards the goal of making IndexedDatabase::open work.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: Added. (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
  • public/WebIDBDatabase.h: Added. (WebKit::WebIDBDatabase::~WebIDBDatabase):
  • public/WebIDBDatabaseError.h: Added. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebIndexedDatabase.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::indexedDatabase):
  • public/WebSerializedScriptValue.h:
  • src/IDBCallbacksProxy.h: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onSuccess): (WebCore::IDBCallbacksProxy::onError):
  • src/IDBDatabaseProxy.cpp: Added. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
  • src/IDBDatabaseProxy.h: Added.
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIDBDatabaseError.cpp: Added. (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::assign): (WebKit::WebIDBDatabaseError::code): (WebKit::WebIDBDatabaseError::message): (WebKit::WebIDBDatabaseError::operator=): (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
2:10 AM Changeset in webkit [56712] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=36742

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

gcc for Symbian doesn't support gcc extensions like atomicity.h - disable

  • wtf/Threading.h: also detect os symbian
1:52 AM Changeset in webkit [56711] by mnaganov@chromium.org
  • 7 edits in trunk

2010-03-29 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Remove a possibility of confusion from Profiles panel Welcome screen
by turning buttons into non-clickable glyphs. Also, span instructions
alongside panel width.

​https://bugs.webkit.org/show_bug.cgi?id=34319

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
  • inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item):
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
1:17 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:41 AM Changeset in webkit [56710] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
​https://bugs.webkit.org/show_bug.cgi?id=36653

Defined the static variables using DEFINE_STATIC_GLOBAL.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
12:37 AM Changeset in webkit [56709] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] player header cleanups
​https://bugs.webkit.org/show_bug.cgi?id=36656

Destructor made private and added missing
mediaPlayerPrivateMuteChangedCallback declaration.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:34 AM Changeset in webkit [56708] by yurys@chromium.org
  • 7 edits
    7 adds in trunk

2010-03-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Protect global object from being GC'ed if there are messages written to console from the iframe with that global object.

Whent serializing objects in the injected script check that global object properties are still defined before using them as arguments. The may become undefined if owning frame navigated to a different domain.

​https://bugs.webkit.org/show_bug.cgi?id=36612

Test: http/tests/inspector-enabled/console-log-before-frame-navigation.html

  • bindings/js/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):

2010-03-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: don't crash when there are messages in console from previous iframe content.

​https://bugs.webkit.org/show_bug.cgi?id=36612

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt: Added.
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added. (doit.callback): (doit): (receiveMessage): (frontend_dumpConsoleMessages):
  • http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html: Added.
12:29 AM Changeset in webkit [56707] by Philippe Normand
  • 5 edits in trunk/WebCore

2010-03-26 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

It should be possible to use GStreamer in addition to another media engine
​https://bugs.webkit.org/show_bug.cgi?id=36654

Renamed gstreamer player and added a WTF_USE_GSTREAMER
define. Made the MediaPlayer register the GStreamer backend only
if it's enabled (true by default on WebKitGTK+).

  • GNUmakefile.am:
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivateGStreamer::create): (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): (WebCore::MediaPlayerPrivateGStreamer::isAvailable): (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::load): (WebCore::MediaPlayerPrivateGStreamer::commitLoad): (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): (WebCore::MediaPlayerPrivateGStreamer::play): (WebCore::MediaPlayerPrivateGStreamer::pause): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivateGStreamer::cancelSeek): (WebCore::MediaPlayerPrivateGStreamer::endPointTimerFired): (WebCore::MediaPlayerPrivateGStreamer::paused): (WebCore::MediaPlayerPrivateGStreamer::seeking): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::hasVideo): (WebCore::MediaPlayerPrivateGStreamer::hasAudio): (WebCore::MediaPlayerPrivateGStreamer::setVolume): (WebCore::MediaPlayerPrivateGStreamer::volumeChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::volumeChanged): (WebCore::MediaPlayerPrivateGStreamer::setRate): (WebCore::MediaPlayerPrivateGStreamer::networkState): (WebCore::MediaPlayerPrivateGStreamer::readyState): (WebCore::MediaPlayerPrivateGStreamer::buffered): (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): (WebCore::MediaPlayerPrivateGStreamer::bytesLoaded): (WebCore::MediaPlayerPrivateGStreamer::totalBytes): (WebCore::MediaPlayerPrivateGStreamer::cancelLoad): (WebCore::MediaPlayerPrivateGStreamer::updateStates): (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged): (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation): (WebCore::MediaPlayerPrivateGStreamer::loadStateChanged): (WebCore::MediaPlayerPrivateGStreamer::sizeChanged): (WebCore::MediaPlayerPrivateGStreamer::timeChanged): (WebCore::MediaPlayerPrivateGStreamer::didEnd): (WebCore::MediaPlayerPrivateGStreamer::durationChanged): (WebCore::MediaPlayerPrivateGStreamer::supportsMuting): (WebCore::MediaPlayerPrivateGStreamer::setMuted): (WebCore::MediaPlayerPrivateGStreamer::muteChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::muteChanged): (WebCore::MediaPlayerPrivateGStreamer::loadingFailed): (WebCore::MediaPlayerPrivateGStreamer::setSize): (WebCore::MediaPlayerPrivateGStreamer::setVisible): (WebCore::MediaPlayerPrivateGStreamer::repaint): (WebCore::MediaPlayerPrivateGStreamer::paint): (WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): (WebCore::MediaPlayerPrivateGStreamer::supportsType): (WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen): (WebCore::MediaPlayerPrivateGStreamer::setPreload): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Note: See TracTimeline for information about the timeline view.