Timeline
Oct 1, 2011:
- 11:49 PM Changeset in webkit [96469] by
-
- 2 edits1 delete in trunk/LayoutTests
Tweak expectations for leopard some more.
- platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 9:34 PM Changeset in webkit [96468] by
-
- 2 edits in trunk/Tools
Correct post-build step for WinCairo test runs.
https://bugs.webkit.org/show_bug.cgi?id=69191
Reviewed by Brian Weinstein.
- DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
shell case to handle the CFLite build.
- 7:21 PM Changeset in webkit [96467] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
http://trac.webkit.org/changeset/96454
https://bugs.webkit.org/show_bug.cgi?id=69217
Reviewed by James Robinson.
Tests: compositor test now pass
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- 6:13 PM Changeset in webkit [96466] by
-
- 3 edits in trunk/Source/WebKit/mac
Leopard build fix: Updated for Strong<T> changes.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
- WebView/WebScriptDebugger.mm:
- 5:54 PM Changeset in webkit [96465] by
-
- 33 edits2 adds in trunk/Source
Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218
Reviewed by Sam Weinig.
- heap/Heap.h:
(JSC::Heap::handleHeap):
- runtime/JSGlobalData.h: Removed these helper functions, since they
just created indirection.
- heap/StrongInlines.h: Added. Broke out a header for inline functions
to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Go forth and build.
- API/JSCallbackObjectFunctions.h:
(JSC::::init):
- runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::setSingleTransition):
- heap/Local.h:
(JSC::::Local):
- heap/Strong.h:
(JSC::::Strong):
(JSC::::set):
- heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.
- bytecompiler/BytecodeGenerator.cpp:
- runtime/JSGlobalData.cpp:
- runtime/LiteralParser.cpp:
- runtime/RegExpCache.cpp: Updated for header changes.
../JavaScriptGlue:
- JSRun.cpp:
- JSValueWrapper.cpp:
../WebCore:
- ForwardingHeaders/heap/StrongInlines.h: Added.
- bindings/js/JSCallbackData.h:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCachedFrameData.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptValue.h:
- bindings/js/WorkerScriptController.cpp:
- bridge/runtime_root.cpp:
../WebKit2:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- 3:08 PM Changeset in webkit [96464] by
-
- 2 edits in trunk/Tools
Added myself to reviewers, because I'm now a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 3:03 PM Changeset in webkit [96463] by
-
- 11 edits2 adds in trunk/Source/JavaScriptCore
All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201
Reviewed by Oliver Hunt.
This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.
It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
- runtime/Heuristics.cpp: Added.
(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):
- runtime/Heuristics.h: Added.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- 3:01 PM WebKit Team edited by
- (diff)
- 2:58 PM Changeset in webkit [96462] by
-
- 2 edits in trunk/Tools
Bencher script makes it difficult to do automated performance testing
https://bugs.webkit.org/show_bug.cgi?id=69207
Reviewed by Sam Weinig.
This adds two new features:
The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.
The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.
- Scripts/bencher:
- 2:46 PM Changeset in webkit [96461] by
-
- 8 edits in trunk/Source/JavaScriptCore
Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215
Reviewed by Geoff Garen.
Adds a GetStringLength node to the DFG so that we can support
string.length inline.
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSString.h:
(JSC::JSString::offsetOfLength):
- 1:48 PM Changeset in webkit [96460] by
-
- 2 edits in trunk/Tools
WTR is not successfully changing the NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=69204
Reviewed by Dan Bernstein.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.
- 12:56 PM Changeset in webkit [96459] by
-
- 1 edit1 delete in trunk/LayoutTests
Delete bogus text expectation.
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
- 12:21 PM Changeset in webkit [96458] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.
If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
- 10:32 AM Changeset in webkit [96457] by
-
- 2 edits in trunk/LayoutTests
Note test as timing out.
- platform/chromium/test_expectations.txt:
- 10:29 AM Changeset in webkit [96456] by
-
- 3 edits5 adds2 deletes in trunk/LayoutTests
Update Mac baselines.
- platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/svg/as-object: Added.
- platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
- platform/chromium-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
- 12:22 AM Changeset in webkit [96455] by
-
- 8 edits1 delete in trunk/Source
Unreviewed, rolling out r96421.
http://trac.webkit.org/changeset/96421
https://bugs.webkit.org/show_bug.cgi?id=69206
It broke Qt-WK2 build (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-01
Source/JavaScriptCore:
- JavaScriptCore.pri:
- wtf/qt/UtilsQt.h: Removed.
- wtf/wtf.pri:
Source/WebCore:
- WebCore.pro:
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
- 12:04 AM QtWebKitBuildBots edited by
- Update Qt5 on the WK2 bot (diff)
Sep 30, 2011:
- 8:15 PM Changeset in webkit [96454] by
-
- 28 edits1 add in trunk/Source
[chromium] Track separate scroll deltas on the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69034
Reviewed by James Robinson.
Source/WebCore:
Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest
Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
The CCLayerImpl tree is now able to adjust these scroll deltas
independent of the main thread. To push them back to the main thread,
CCLayerTreeHostImpl collects them all and then bakes them into the
scroll position during a begin frame and commit call. This allows new
deltas to be collected while the scroll position containing the old
delta and the old scroll position will be overwritten during the next
commit.
Only the main frame is supported right now for pushing this scroll
delta back into the authoritative WebKit source to keep both sides in
sync.
Move tilingTransform() to the impl tree because drawTransform() is now
updated using scroll deltas and so the results from calculating draw
transforms needs to be dynamic so that children are updated properly.
Also, exposed DebugScopedSetImplThread public because it's used in a
few places.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore::LayerChromium::scrollDelta):
(WebCore::LayerChromium::scrollable):
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setViewport):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::scrollBy):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::maxScrollPosition):
(WebCore::CCLayerImpl::setMaxScrollPosition):
(WebCore::CCLayerImpl::scrollDelta):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::scrollable):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
(WebCore::CCTiledLayerImpl::draw):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
Add testing support for scroll deltas on layers.
- WebKit.gypi:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyScrollDelta):
- src/WebViewImpl.h:
- tests/CCLayerTreeHostImplTest.cpp: Added.
(WebCore::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebCore::CCLayerTreeHostImplTest::expectClearedScrollDeltasRecursive):
(WebCore::CCLayerTreeHostImplTest::expectContains):
(WebCore::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::applyScrollDelta):
(WTF::MockLayerTreeHostClient::applyScrollDelta):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::CCLayerTreeHostTestScrollSimple::CCLayerTreeHostTestScrollSimple):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollSimple::afterTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::CCLayerTreeHostTestScrollMultipleRedraw):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::afterTest):
- tests/TreeSynchronizerTest.cpp:
(WebCore::TEST):
- 8:12 PM Changeset in webkit [96453] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-09-30 Daniel Bates <dbates@webkit.org>
Attempt to fix the Apple Windows and WinCairo Debug builds after
<http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol ?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the corresponding function, JSValue::toStrictThisObject(), was removed.
- 8:07 PM Changeset in webkit [96452] by
-
- 8 edits21 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=69202
[CSS3 Regions] Make positioned objects use the first region as the ICB when it
is their containing block. Make sure static distance computations take into
account the current region as well.
Reviewed by Sam Weinig.
Source/WebCore:
Added new tests in fast/regions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForContent):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::computeLogicalTopPositionedOffset):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
- rendering/RenderFlowThread.h:
LayoutTests:
- fast/regions/positioned-objects-block-static-in-regions.html: Added.
- fast/regions/positioned-objects-block-static-in-rtl-regions.html: Added.
- fast/regions/positioned-objects-in-regions.html: Added.
- fast/regions/positioned-objects-in-rtl-regions.html: Added.
- fast/regions/positioned-objects-inline-static-in-regions.html: Added.
- fast/regions/positioned-objects-inline-static-in-rtl-regions.html: Added.
- fast/regions/positioned-objects-perpendicular-flows-in-regions.html: Added.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Added.
- platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Added.
- platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Added.
- 7:14 PM Changeset in webkit [96451] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG operation results are not set correctly in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69126
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.
The setupResults routine has the bug of reversing the source and destination.
Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::setupTwoStubArgs):
(JSC::DFG::setupResults):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
- 7:12 PM Changeset in webkit [96450] by
-
- 2 edits1 add in trunk/Source/WebKit/chromium
Adding unit tests for LayerChromium. Emphasis on verifying
behavior of notifySyncRequired callback and tree manipulations.
https://bugs.webkit.org/show_bug.cgi?id=68572
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-30
Reviewed by James Robinson.
- WebKit.gypi:
- tests/LayerChromiumTest.cpp: Added.
- 6:43 PM Changeset in webkit [96449] by
-
- 6 edits3 adds in trunk
Implement currentColor support for CSS gradients
https://bugs.webkit.org/show_bug.cgi?id=58730
Patch by David Barr <davidbarr@chromium.org> on 2011-09-30
Reviewed by Adam Barth.
Source/WebCore:
Allow currentColor as a CSS3 gradient color-stop.
Test: fast/css/linear-gradient-currentcolor.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::isCacheable): Make currentColor uncacheable since the
background image may be invalidated if currentColor is used as a gradient stop and
the value of the 'color' property changes.
- css/CSSParser.cpp:
(WebCore::parseGradientColorOrKeyword): Accept the currentColor keyword.
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image): Initialize document styleSelector so that
currentColor may be computed for a StyleGeneratedImage.
LayoutTests:
- fast/css/linear-gradient-currentcolor-expected.txt: Added.
- fast/css/linear-gradient-currentcolor.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
- 6:40 PM Changeset in webkit [96448] by
-
- 3 edits in trunk/Tools
Cleanup: Extract code to launch a Mac WebKit application into a common function
https://bugs.webkit.org/show_bug.cgi?id=68662
Reviewed by Adam Roben.
Extracts common code to launch a WebKit application on Mac OS X into a function
so that we can remove duplicate code.
- Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
- Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
(runMacWebKitApp): Added.
(runSafari): Modified to use webkitdirs::runMacWebKitApp().
(runMiniBrowser): Ditto.
(runWebKitTestRunner): Ditto.
(runTestWebKitAPI): Ditto.
- 6:37 PM Changeset in webkit [96447] by
-
- 1 edit1 add in trunk/LayoutTests
Update baseline for this test on Leopard.
- platform/chromium-cg-mac-leopard/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- 6:29 PM Changeset in webkit [96446] by
-
- 14 edits in trunk/Source
Remove toStrictThisObject, toThisString, toThisJSString
https://bugs.webkit.org/show_bug.cgi?id=69203
Rubber stamped by Sam Weinig
These are no longer used.
- JavaScriptCore.exp:
- runtime/JSActivation.cpp:
- runtime/JSActivation.h:
- runtime/JSObject.cpp:
- runtime/JSObject.h:
- runtime/JSStaticScopeObject.cpp:
- runtime/JSStaticScopeObject.h:
- runtime/JSValue.h:
- runtime/StrictEvalActivation.cpp:
- runtime/StrictEvalActivation.h:
../WebCore:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- 6:17 PM Changeset in webkit [96445] by
-
- 2 edits in trunk/Source/WebCore
Remove ASSERT introduced in http://trac.webkit.org/changeset/96427
which is triggering all over the place.
Sorting this out is covered in this bug:
https://bugs.webkit.org/show_bug.cgi?id=69200
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- 6:08 PM Changeset in webkit [96444] by
-
- 9 edits4 adds in trunk/Tools
watchlist: Add webkit-patch command to run watchlist.
https://bugs.webkit.org/show_bug.cgi?id=68973
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/host.py: Exposed the watch_list.
- Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
the cc and messages as sorted lists. To allow for deterministic ordering.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
- Scripts/webkitpy/tool/commands/init.py: Add ApplyWatchListLocal so
that it will be exposed as a command by webkit-patch.
- Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
- Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
- Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
- Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
- Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
- Scripts/webkitpy/tool/steps/init.py: Added ApplyWatchList.
- Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
- Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
- 5:58 PM Changeset in webkit [96443] by
-
- 9 edits in trunk/Source/JavaScriptCore
DFG does not speculate aggressively enough on put_by_id
https://bugs.webkit.org/show_bug.cgi?id=69114
Reviewed by Oliver Hunt.
This adds new nodes along with optimizations for those nodes:
GetPropertyStorage: CheckStructure used to do both the structure
check and retrieve the storage pointer. Now CheckStructure just
checks the structure, and GetPropertyStorage retrieves the
storage pointer.
PutStructure: Changes the structure, and has the expected store
to load optimization with CheckStructure.
PutByOffset: Directly sets the value. Has store to load
optimization with GetByOffset.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasStorageAccessData):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::impureCSE):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:46 PM Changeset in webkit [96442] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r96426.
http://trac.webkit.org/changeset/96426
https://bugs.webkit.org/show_bug.cgi?id=69199
Broke a zillion image results on Chromium Skia Mac (Requested
by abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
- 5:39 PM Changeset in webkit [96441] by
-
- 4 edits2 adds in trunk/Tools
watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
https://bugs.webkit.org/show_bug.cgi?id=69031
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
a comment to explain something important about the email addresses, and
a comment to let emacs know to treat the file as a python file.
- Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
Detects increases or decreases in a pattern.
- Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
Added unit tests for watchlist which has "more" or "less".
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
Added support for "more" or "less".
- 5:25 PM Changeset in webkit [96440] by
-
- 3 edits2 adds in trunk
Fix assertion failure in XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=69050
https://code.google.com/p/chromium/issues/detail?id=97346
Reviewed by Daniel Bates.
Source/WebCore:
Test: fast/forms/xss-auditor-doesnt-crash.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init): Don't try to decode the HTML body if it is empty.
LayoutTests:
- fast/forms/xss-auditor-doesnt-crash-expected.txt: Added.
- fast/forms/xss-auditor-doesnt-crash.html: Added.
- 5:16 PM Changeset in webkit [96439] by
-
- 15 edits in trunk
Add support for eventSender.mouseScrollBy in WTR
https://bugs.webkit.org/show_bug.cgi?id=69189
Source/WebKit2:
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::wheelEventSyncForTesting):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Add sync version of wheel event handling for use in testing.
Tools:
Add implementation of eventSender.mouseScrollBy for the mac.
Reviewed by Simon Fraser.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
LayoutTests:
Reviewed by Simon Fraser.
- platform/mac-wk2/Skipped:
Removes tests that used eventSender.mouseScrollBy.
- 4:54 PM Changeset in webkit [96438] by
-
- 6 edits in trunk/Source/JavaScriptCore
StringRecursionChecker should not work in terms of EncodedJSValue
https://bugs.webkit.org/show_bug.cgi?id=69188
Reviewed by Oliver Hunt.
0 is not the empty value on 32_64.
Code that casts literals to EncodedJSValues may be unsafe if we change our internal representation.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
- runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
(JSC::StringRecursionChecker::emptyString):
- runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::earlyReturnValue):
- 4:30 PM Changeset in webkit [96437] by
-
- 2 edits in trunk/Source/WebCore
Loading page on potterybankids causes reproducible assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69185
<rdar://problem/10218241>
Reviewed by Simon Fraser.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeRepaintRects): Remove assert condition that isn't guaranteed
to be true.
- 4:05 PM Changeset in webkit [96436] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT, Branch on integer can always be a 32-bit compare.
https://bugs.webkit.org/show_bug.cgi?id=69174
Reviewed by Sam Weinig.
if (shouldSpeculateInteger(node.child1()) && !isStrictInt32(node.child1())),
the JSVALUE64 JIT will currently compare all 64bits in the register, but in
these cases the DataFormat is always a JS boxed integer. In these cases we
can just compare the low 32bits anyway - no need to check the tag.
This allows the code to be unified with the JSVALUE32_64 JIT.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:01 PM Changeset in webkit [96435] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Add missing include for QMimeData
https://bugs.webkit.org/show_bug.cgi?id=69178
Reviewed by Tor Arne Vestbø.
This was implicitly included by other headers, but due to changes in
Qt5 we need to include explicitly.
- UIProcess/qt/QtWebPageProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 3:53 PM Changeset in webkit [96434] by
-
- 3 edits in trunk/Tools
fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=35273
Reviewed by Dan Bernstein.
There are two types of font issue that can cause layout test failure.
First, the user may have non-standard fonts installed that affect the layout
of some tests. For example, some tests use the MS Gothic font if installed.
Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
which override the system fonts (e.g. a copy of Arial from MS Office). For
some tests, this can affect font metrics or fallback behavior.
This change addresses the first problem only. It limits the set of fonts
available through NSFontManager, by swizzling some methods to return
a list of fonts or font families which only include fonts from a hardcoded
whitelist.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(drt_NSFontManager_availableFontFamilies):
(drt_NSFontManager_availableFonts):
(swizzleNSFontManagerMethods):
(activateTestingFonts):
(adjustFonts):
(createWebViewAndOffscreenWindow):
(prepareConsistentTestingEnvironment):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::InjectedBundle::platformInitialize):
- 3:31 PM Changeset in webkit [96433] by
-
- 15 edits3 adds in trunk
Source/WebCore: Support -webkit-tap-highlight-color when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544
Reviewed by Kenneth Rohde Christiansen.
Original code from the iOS WebCore code dump, extracted and modified by tijiang@rim and jnd@chromium.
Supports the new CSS property -webkit-tap-highlight-color on platforms which support touch events.
Platform can override WebCore::RenderTheme::platformTapHighlightColor to use its own platform
specific default tap highlight color. Otherwise RenderTheme::defaultTapHighlightColor will be
used as default tap highlight color.
Test: fast/events/touch/tap-highlight-color.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::tapHighlightColor):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::platformTapHighlightColor):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::initialTapHighlightColor):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::tapHighlightColor):
(WebCore::InheritedFlags::setTapHighlightColor):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
LayoutTests: Support -webkit-tap-highlight-color in WebCore when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544.
Reviewed by Kenneth Rohde Christiansen.
Add a layout test to get customized tap highlight color set by page author.
- fast/css/getComputedStyle/computed-style-without-renderer.html:
- fast/css/getComputedStyle/computed-style.html:
- fast/events/touch/script-tests/tap-highlight-color.js: Added.
(onTouchStart):
(touchTargets):
- fast/events/touch/tap-highlight-color-expected.txt: Added.
- fast/events/touch/tap-highlight-color.html: Added.
- svg/css/getComputedStyle-basic.xhtml:
- 3:23 PM Changeset in webkit [96432] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-09-30 Oliver Hunt <oliver@apple.com>
Need a sensible GGC policy
Reviewed by Geoff Garen.
This replaces the existing random collection policy
with a deterministic policy based on nursery size.
- heap/AllocationSpace.cpp: (JSC::AllocationSpace::allocateSlowCase):
- heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots): (JSC::Heap::collect):
- heap/Heap.h:
- heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::resetAllocator):
- heap/MarkedSpace.h: (JSC::MarkedSpace::nurseryWaterMark): (JSC::MarkedSpace::allocate):
- 3:12 PM Changeset in webkit [96431] by
-
- 3 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=69173
RTL/LTR mixtures still not correct in regions. Simplify the loop once I realized it's only
your directionality that matters and not your containing block's.
Reviewed by Dan Bernstein.
Source/WebCore:
Added new test in fast/regions.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
LayoutTests:
- fast/regions/multiple-directionality-changes-in-variable-width-regions.html: Added.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- 3:00 PM Changeset in webkit [96430] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
https://bugs.webkit.org/show_bug.cgi?id=69169
Patch by James Robinson <jamesr@chromium.org> on 2011-09-30
Reviewed by Darin Fisher.
If the compositor does not process the input event the embedder might want to do something with it - for
example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
open a new tab. This passes that state through the didHandleInputEvent callback.
- public/WebCompositorClient.h:
- src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
- 2:44 PM Changeset in webkit [96429] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG 32-bit support for op_call and op_construct causes
run-javascriptcore-tests to fail
https://bugs.webkit.org/show_bug.cgi?id=69171
Reviewed by Gavin Barraclough.
This fixes one obvious bug that was causing test failures (no
support for dummy slow case for op_add in 32_64), and disables
op_call and op_construct by default.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
- 2:38 PM Changeset in webkit [96428] by
-
- 2 edits in trunk/Tools
Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
https://bugs.webkit.org/show_bug.cgi?id=69039
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
Actually skip only one specific test that is failing on Windows.
- 2:36 PM Changeset in webkit [96427] by
-
- 4 edits3 adds in trunk
<rdar://problem/10208291> first-letter in generated before content with display: table is not updated
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/css-generated-content/first-letter-in-nested-before.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent): Preserve the style type of anonymous
containers around the generated content when updating their style. This preserves the first-letter-ness
of the inline wrapping the first letter, which allows updateFirstLetter() to identify it later.
LayoutTests:
- fast/css-generated-content/first-letter-in-nested-before-expected.png: Added.
- fast/css-generated-content/first-letter-in-nested-before-expected.txt: Added.
- fast/css-generated-content/first-letter-in-nested-before.html: Added.
- 2:26 PM Changeset in webkit [96426] by
-
- 2 edits in trunk/Source/WebCore
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956
This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.
Reviewed by Stephen White.
No new tests. This platform is not enabled.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
- 2:23 PM Changeset in webkit [96425] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r96422.
http://trac.webkit.org/changeset/96422
https://bugs.webkit.org/show_bug.cgi?id=69170
Broke Windows build and kling wanted to roll it out as well
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30
- rendering/InlineBox.cpp:
(WebCore::InlineBox::prevOnLineExists):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
- 2:15 PM Changeset in webkit [96424] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crash due to out of bounds read/write in MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=69148
This was a case of being surprised by a poorly aritulcated cell size limit,
plus an incorrect ASSERT guarding the cell size limit.
Reviewed by Oliver Hunt.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::sizeClassFor): Changed heap size ranges to be inclusive,
since it makes the ranges easier to understand.
Bumped up the max cell size to support the use case in this bug. Since the
atomSize is much bigger than it used to be, there isn't much accounting
cost to handling more size classes.
Switched to FixedArray, to help catch SizeClass indexing bugs in the future.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeCellLivenessData): Updated for size ranges
being inclusive.
- 2:04 PM Changeset in webkit [96423] by
-
- 6 edits15 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=69167
[CSS3 Regions] Fix some bugs in the computation of the logical left and width offsets
for blocks in variable width regions. Specifically, this patch addresses a minor bug
with overflow:hidden/scroll/auto block placement and with RTL directionality.
Reviewed by Sam Weinig.
Source/WebCore:
Added five new tests in fast/regions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalRightOffsetForContent):
Avoid a double fetch of the border box in a given region by not calling
logicalLeftOffsetForContent. No correctness change here. It's just cleaner.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
Change the shifted optimization to be cached for "self" rather than for "containing block".
Rework the adjustment loop to handle changes in directionality and to fix correctness
issues with RTL.
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Don't double adjust if an object uses line width as the containing block width. In that
case we already computed the line width in the region, so we don't need to apply any
additional fixup.
(WebCore::RenderBox::renderBoxRegionInfo):
- rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::RenderBoxRegionInfo):
(WebCore::RenderBoxRegionInfo::isShifted):
Changed the shifted code to be on self rather than on containing block.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
Refactor the layout code for RenderFlowThread to properly set up region rects assuming
right alignment in RTL code. This change forces us to compute our maximum logical width
first before looping through the regions again to set their content rects.
LayoutTests:
- fast/regions/overflow-in-variable-width-regions.html: Added.
- fast/regions/overflow-rtl-in-variable-width-regions.html: Added.
- fast/regions/percentage-margins-mixed-ltr-dominant-regions.html: Added.
- fast/regions/percentage-margins-mixed-rtl-dominant-regions.html: Added.
- fast/regions/percentage-margins-rtl-variable-width-regions.html: Added.
- platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
- platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
- platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
- platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
- platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
- platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
- platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
- 1:49 PM Changeset in webkit [96422] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
https://bugs.webkit.org/show_bug.cgi?id=64914
Patch by Andreas Kling <kling@webkit.org> on 2011-09-30
Reviewed by Antti Koivisto.
Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.
Also added a compile-time assertion to guard against future bloating of
the InlineBox class.
- rendering/InlineBox.cpp:
(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
- 1:47 PM Changeset in webkit [96421] by
-
- 8 edits1 add in trunk/Source
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162
Use QString::toHtmlEscaped in the Qt5 case.
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-09-30
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- JavaScriptCore.pri:
- wtf/qt/UtilsQt.h: Added.
(escapeHtml):
- wtf/wtf.pri:
Source/WebCore:
No new tests needed.
- WebCore.pro: adjust the include path accordingly
in the v8 case.
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
- 1:36 PM Changeset in webkit [96420] by
-
- 2 edits6 adds in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/96404.
- platform/chromium-cg-mac/fast/text/atsui-multiple-renderers-expected.png: Added.
- platform/chromium-cg-mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/chromium-linux/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/chromium-mac/fast/text/atsui-multiple-renderers-expected.png:
- platform/chromium-mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/chromium-win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/chromium-win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
- 1:36 PM Changeset in webkit [96419] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix bug in getHostCallReturnValue of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69133
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.
We need to insert the additional argument in the stack slot before
return address instead of simply pushing it afterwards.
Also getHostCallReturnValue* should be attributed as stdcall
to make the stack cleaned up by the callee.
- dfg/DFGOperations.cpp:
- 1:22 PM Changeset in webkit [96418] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] wtf header files are unknown to Qt Creator
https://bugs.webkit.org/show_bug.cgi?id=69158
Adding the HEADERS variable in wtf.pri so that
the header files can be accessed easily.
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-09-30
Reviewed by Andreas Kling.
- wtf/wtf.pri:
- 1:05 PM Changeset in webkit [96417] by
-
- 5 edits in trunk
[Qt] Prevent qDebug() output from DRT and WTR unless --verbose
For DRT we didn't install the message handler early enough to
catch output while constructing the QApplication. For WTR we
didn't even install a message handler.
Since the UI process will forward any output from the web process
we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
in WTR before the web process is started. This is picked up by the
web process which installs its own message handler.
The environment variable can be overriden on the command line if you
want to see output from the web process, or you can pass --verbose to
WTR to see output from both processes.
https://bugs.webkit.org/show_bug.cgi?id=69132
Reviewed by Andreas Kling.
- 1:04 PM Changeset in webkit [96416] by
-
- 3 edits in trunk/Tools
[Qt] Make sure WTR sizes the window and item correctly
Revision 96345 changed the logic for how the view and
window was created, but missed a vital part, setting
the size.
We now use a QSGView for the window, that has a simple
item as its root object that is always resized to fit
within the window. The webview is then parented to the
root object and set to anchors.fill: parent. That way
any window geometry changes will propagate to the web
view.
https://bugs.webkit.org/show_bug.cgi?id=69134
Reviewed by Andreas Kling.
- 1:01 PM Changeset in webkit [96415] by
-
- 8 edits in trunk/Source/JavaScriptCore
Merge some more of DFGSpeculativeJIT 32_64/64
https://bugs.webkit.org/show_bug.cgi?id=69164
Reviewed by Oliver Hunt.
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGJITCodeGenerator32_64.cpp:
- dfg/DFGJITCodeGenerator64.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- 12:34 PM Changeset in webkit [96414] by
-
- 2 edits in trunk/Tools
[EFL] Only save the current viewport in PixelDumpSupportEfl.
https://bugs.webkit.org/show_bug.cgi?id=68450
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-30
Reviewed by Antonio Gomes.
The previous implementation saved the whole page contents in the final
PNG, however the baselines and expectations in the tree only want the
current viewport (with a scrollbar, if needed), so we now only save the
currently visible contents.
- DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView): Use
ewk_frame_visible_content_geometry_get instead of
ewk_frame_contents_size_get.
- 12:11 PM Changeset in webkit [96413] by
-
- 8 edits in trunk/Source/WebKit2
Remove didCompleteRubberBandForMainFrame UIClient callback
https://bugs.webkit.org/show_bug.cgi?id=69161
Reviewed by Adam Roben.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didCompleteRubberBandForFrame):
- 12:05 PM Changeset in webkit [96412] by
-
- 2 edits in trunk/Source/WebKit/chromium
webkit->chromium DEPS roll 102910->103471
https://bugs.webkit.org/show_bug.cgi?id=69160
Patch by Elliot Poger <epoger@google.com> on 2011-09-30
Reviewed by Adam Barth.
- DEPS:
- 11:44 AM Changeset in webkit [96411] by
-
- 2 edits in trunk/Tools
[EFL] Support and keep track of extra windows (views).
https://bugs.webkit.org/show_bug.cgi?id=68454
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-30
Reviewed by Antonio Gomes.
So far, window.open and related JavaScript code would not work, as
DRTView did not implementation
Ewk_View_Smart_Class::window_{open,close}. The default implementation
in ewk just returns the current window/view, which broke any
layouttest which relied on window.open.
We now properly create and remove these new views. Unfortunately, the
current way ewk works (and due to the fact that we cannot pass class
methods as function pointers to the EFL functions), DRTView needs to
know that DRTChrome exists and call `browser' directly in some points.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onWindowCreate):
(onWindowCloseDelayed):
(onWindowClose):
(drtViewTiledAdd):
- 11:28 AM Changeset in webkit [96410] by
-
- 3 edits in trunk/Source/WebCore
Remove unused ReplaceSelectionCommand::copyStyleToChildren
https://bugs.webkit.org/show_bug.cgi?id=69153
Reviewed by Antonio Gomes.
Removed the function because it's no called anywhere.
- editing/ReplaceSelectionCommand.cpp:
- editing/ReplaceSelectionCommand.h:
- 11:20 AM Changeset in webkit [96409] by
-
- 2 edits in trunk/Source/WebCore
Fix EnabledAtRuntime support for constants.
https://bugs.webkit.org/show_bug.cgi?id=67311
Patch by Aaron Colwell <acolwell@chromium.org> on 2011-09-30
Reviewed by Adam Barth.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- 11:18 AM QtWebKitReleases edited by
- (diff)
- 11:18 AM Changeset in webkit [96408] by
-
- 32 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=69043
[CSS3 Regions] Blocks split across regions with variable width need to size
differently in each region.
This patch adds the capability for blocks to have variable width and positioning
when split across regions. It is very rudimentary and so far only operates on basic
normal flow RenderBlocks. Future patches will expand the support to cover other layout
constructs like flexible boxes and tables.
Reviewed by Sam Weinig.
Added new tests in fast/regions and updated existing results.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
- rendering/HitTestResult.h:
(WebCore::HitTestResult::region):
(WebCore::HitTestResult::setRegion):
The hit test result now holds the active RenderRegion so that hit testing can adjust
block widths and positions when hit testing their border boxes.
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
The paint info struct now holds the active RenderRegion so that painting can adjust
block widths and positions when painting borders and backgrounds and shadows.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
If our width ever changes, we invalidate all of our cached RenderBoxRegionInfo in all
regions that we span.
(WebCore::RenderBlock::clearRenderBoxRegionInfo):
Called to clear out our cached region-specific information in all regions that we span.
(WebCore::RenderBlock::borderBoxRectInRegionAtPosition):
Returns the borderBoxRect for the region at the specified vertical offset. This rect
can be both shifted horizontally and have a different width from our original border rect.
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Modified to call borderBoxRectInRegionAtPosition so that lines will fit inside
the content rect of the border box rect for the specific region.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForContent):
Modified to call logicalLeftOffsetForContent since it's cleaner.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
Called to compute the border box rect in a specific region. The result is cached in a HashMap
in the region itself so that subsequent lookups are fast.
(WebCore::RenderBox::nodeAtPoint):
Modified to use the border box rect in the active region when hit testing the backgrounds of boxes.
(WebCore::RenderBox::paintBoxDecorations):
Modified to use the border box rect in the active region when painting the backgrounds of boxes.
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Helpers for computing logical widths and margins in a specific region. The result is then cached
in a HashMap in the region.
(WebCore::RenderBox::renderBoxRegionInfo):
The function for obtaining the region-specific information for a given box.
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRectInRegion):
New function for returning the border box rect in a given region.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Make sure mask painting honors the active region.
- rendering/RenderBoxRegionInfo.h: Added.
(WebCore::RenderBoxRegionInfo::RenderBoxRegionInfo):
(WebCore::RenderBoxRegionInfo::logicalLeft):
(WebCore::RenderBoxRegionInfo::logicalWidth):
(WebCore::RenderBoxRegionInfo::containingBlockChainIsShifted):
New class held by RenderRegions that caches box-specific info for a given region. This will eventually
expand to include custom styles as well, but for now it is limited to a new logical left and a new
logical width, along with a bit for optimizing accumulated shifting when painting/hit testing to avoid
too much groveling up the containing block chain.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
Removed the region fitting optimization, since eventually everyone is going to care, and there's no reason
to limit it with the results now being cached.
(WebCore::RenderFlowThread::layout):
All box-specific region information is always cleared whenever the regions are invalidated.
(WebCore::RenderFlowThread::computeLogicalWidth):
Modified to set up RenderBoxRegionInfo for the flow thread in all regions.
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
Modified to take the region instead of the region's rectangle so that painting and hit testing of the flow
thread layer tree can properly receive the active region.
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Helper for removing a box's information from all regions. For now it grovels through every region, so eventually
we may want to have a cache of the start/end regions for a given box somewhere.
- rendering/RenderFlowThread.h:
Removal of the region fitting stuff.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Modified to pass the current region down through painting functions so that it is known at paint time.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
Added a new bit to RenderObjects, inRenderFlowThread(), so that it is quick to determine whether or not an
object needs flow thread special casing.
(WebCore::RenderObject::enclosingRenderFlowThread):
Modified enclosingRenderFlowThread to be able to quickly return 0 if the object is not in a flow thread.
(WebCore::RenderObject::containerForRepaint):
Same.
- rendering/RenderObject.h:
(WebCore::RenderObject::setParent):
setParent now updates inRenderFlowThread() state.
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::setInRenderFlowThread):
Adding the new bit.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Make sure when an object is removed from a RenderFlowThread that it deletes its box-specific information
in all regions.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):
(WebCore::RenderRegion::matchesRenderFlowThreadLogicalWidth):
- rendering/RenderRegion.h:
Added the new HashMap for holding box-specific region information. Also added an additional optimization to
check if a specific region matches the overall width of the RenderFlowThread. If it does, we don't need to
cache box-specific information for that region.
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
Modified the PaintInfo construction to include the region argument. It's not optional so that callers will
have to consider it (since masks illustrated this is necessary).
LayoutTests:
- fast/regions/percentage-margins-variable-width-regions.html: Added.
- platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png:
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
- platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png:
- platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png:
- 11:14 AM QtWebKitReleases edited by
- (diff)
- 11:09 AM Changeset in webkit [96407] by
-
- 2 edits in trunk/Source/WebCore
feBlend uses a table of function pointers which reduces inlineability inside the main loop
https://bugs.webkit.org/show_bug.cgi?id=69154
<rdar://problem/10215221>
Reviewed by Darin Adler.
Don't use a table of function pointers inside the feBlend inner loop, instead
use switch and inline functions, bringing a 20% performance gain across the
board to feBlend.
No new tests, minor performance improvement.
- platform/graphics/filters/FEBlend.cpp:
(WebCore::normal):
(WebCore::multiply):
(WebCore::screen):
(WebCore::darken):
(WebCore::lighten):
(WebCore::FEBlend::apply):
- 10:59 AM Changeset in webkit [96406] by
-
- 7 edits in trunk/Source
Add getCallData to MethodTable in ClassInfo
https://bugs.webkit.org/show_bug.cgi?id=69024
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added the getCallData to the MethodTable in the ClassInfo struct.
- runtime/ClassInfo.h:
Source/WebCore:
No new tests.
- WebCore.exp.in:
Changed getCallData from private to protected to allow subclasses who
don't override getCallData themselves to reference it in their own
method tables when calling the CREATE_METHOD_TABLE macro.
- bridge/runtime_method.h:
- 10:26 AM Changeset in webkit [96405] by
-
- 14 edits1 delete in trunk
WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
https://bugs.webkit.org/show_bug.cgi?id=42698
Reviewed by Andreas Kling.
Source/WebKit2:
Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
and call clearApplicationCache when layoutTest start up.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleClearApplicationCache):
(WKBundleSetAppCacheMaximumSize):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearApplicationCache):
(WebKit::InjectedBundle::setAppCacheMaximumSize):
- WebProcess/InjectedBundle/InjectedBundle.h:
Tools:
Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
and call clearApplicationCache when layoutTest start up.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::clearAllApplicationCaches):
(WTR::LayoutTestController::setAppCacheMaximumSize):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
LayoutTests:
Removed http/tests/appcache/max-size.html from skipped list, and also the "failed" expected file for http/tests/appcache/interrupted-update-expected.html
- platform/mac-wk2/http/tests/appcache: Removed.
- platform/mac-wk2/http/tests/appcache/interrupted-update-expected.txt: Removed.
- platform/wk2/Skipped:
- 10:05 AM Changeset in webkit [96404] by
-
- 6 edits3 adds in trunk
Complex spaces with synthetic bold are too wide
https://bugs.webkit.org/show_bug.cgi?id=69033
Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-30
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/text/complex-synthetic-bold-space-width.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Subtract synthetic bold offset from spaceWidth.
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem): Ditto.
LayoutTests:
- fast/text/complex-synthetic-bold-space-width.html: Added.
- platform/mac/fast/text/atsui-multiple-renderers-expected.png:
- platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
- platform/mac/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/mac/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
- 10:00 AM Changeset in webkit [96403] by
-
- 3 edits in trunk/LayoutTests
LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=69130
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-30
Reviewed by Alexey Proskuryakov.
- fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
- fast/dom/HTMLInputElement/input-size-attribute.html:
- 7:54 AM Changeset in webkit [96402] by
-
- 3 edits in trunk/Tools
[Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=69145
This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
and is perfectly suitable for SceneGraph as well. GraphicsScene events
will not be available in QtGui anymore in future. Therefore we also have to change
QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-30
Reviewed by Chang Shu.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::createMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
- 7:44 AM Changeset in webkit [96401] by
-
- 2 edits in trunk/LayoutTests
Replace textInputController.doCommand with eventSender.keyDown in password-echo tests
https://bugs.webkit.org/show_bug.cgi?id=69143
textInputController.doCommand is not supported very well across the platforms. Replace it
with eventSender.keyDown would make the tests pass on more platforms and potentially WK2.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-30
Reviewed by Antonio Gomes.
- editing/input/resources/password-echo.js:
(init):
- 7:23 AM Changeset in webkit [96400] by
-
- 3 edits in trunk/Source/WebKit2
[UNIX] Add a method to get information for an already loaded plugin module
https://bugs.webkit.org/show_bug.cgi?id=69139
Reviewed by Martin Robinson.
- Shared/Plugins/Netscape/NetscapePluginModule.h: Add pluginInfo().
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::pluginInfo): Private method to get
the plugin information from the module, it must be called when the
module has been already initialized.
(WebKit::NetscapePluginModule::getPluginInfo): Use pluginInfo() to
get information of the plugin module for the given path.
- 4:58 AM Changeset in webkit [96399] by
-
- 11 edits in trunk/Source/WebKit2
[Qt][WK2] Event delivery in QDesktopWebView is broken after merge of Qt5 refactor
https://bugs.webkit.org/show_bug.cgi?id=69105
This changes QDesktopWebView and QDesktopWebPageProxy to use QMouseEvent instead
of QGraphicsSceneMouseEvent.
Further it removes an endless loop introduced by the QSGItem::event() function
delivering inputMethodEvents but no other events.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-30
Reviewed by Andreas Kling.
- Shared/NativeWebMouseEvent.h:
(WebKit::NativeWebMouseEvent::nativeEvent):
- Shared/NativeWebWheelEvent.h:
(WebKit::NativeWebWheelEvent::nativeEvent):
- Shared/qt/NativeWebMouseEventQt.cpp:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- Shared/qt/NativeWebWheelEventQt.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::mouseButtonForEvent):
(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
- Shared/qt/WebEventFactoryQt.h:
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::event):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleMouseMoveEvent):
(QDesktopWebPageProxy::handleMousePressEvent):
(QDesktopWebPageProxy::handleMouseReleaseEvent):
(QDesktopWebPageProxy::handleMouseDoubleClickEvent):
(QDesktopWebPageProxy::handleWheelEvent):
(QDesktopWebPageProxy::handleHoverMoveEvent):
- UIProcess/qt/qdesktopwebpageproxy.h:
- 3:44 AM Changeset in webkit [96398] by
-
- 12 edits2 moves in trunk/Source
Web Inspector: [chromium] expose inspector protocol version to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=69092
Source/WebCore:
This change also introduces major/minor inspector version components.
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- inspector/Inspector-0.1.json: Renamed from Source/WebCore/inspector/Inspector.draft-01.json.
- inspector/Inspector.json:
- inspector/generate-inspector-protocol-version: Renamed from Source/WebCore/inspector/validate-protocol-compatibility.
Source/WebKit/chromium:
Reviewed by Yury Semikhatsky.
- public/WebDevToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::inspectorProtocolVersion):
(WebKit::WebDevToolsAgent::supportsInspectorProtocolVersion):
- 1:07 AM Changeset in webkit [96397] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout test failures under Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=54322
Unreviewed test_expectations.txt update. acid3 seems to be IMAGE+TEXT, not IMAGE
- platform/chromium/test_expectations.txt:
- 1:00 AM Changeset in webkit [96396] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast/frames/frame-set-rotation-hit.html and fast/frames/frame-set-scaling-hit.html are failing
https://bugs.webkit.org/show_bug.cgi?id=69136
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 12:14 AM Changeset in webkit [96395] by
-
- 5 edits in trunk/Source
Versioning.
- 12:12 AM Changeset in webkit [96394] by
-
- 1 copy in tags/Safari-535.5
New tag.
- 12:07 AM Changeset in webkit [96393] by
-
- 7 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=69106
Universal attribute selectors disable style sharing
Reviewed by Dave Hyatt.
Selectors of type [foo="bar"] ended up marking every element style with the affectedByAttributeSelectors bit
rendering style sharing inoperative. This happens on http://www.whatwg.org/specs/web-apps/current-work/ for example.
Instead we now mark style with affectedByUncommonAttributeSelectors bit only if an attribute selector actually
matches the element. Before sharing, we also check the current element against collected attribute rules.
We can share the style if neither element was affected.
This speeds up style matching and applying ~15% on full HTML5 spec (=~0.7s). Sharing percentage goes from 0% to ~30%.
Increased sharing should also save a substantial amount of memory.
- css/CSSSelector.h:
(WebCore::CSSSelector::isAttributeSelector):
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::collectSpecialRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::selectorListContainsUncommonAttributeSelector):
(WebCore::isCommonAttributeSelectorAttribute):
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
- css/CSSStyleSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::affectedByUncommonAttributeSelectors):
(WebCore::InheritedFlags::setAffectedByUncommonAttributeSelectors):
- 12:05 AM Changeset in webkit [96392] by
-
- 17 edits3 copies1 add in trunk
[chromium] Add WebKit API for sending input events to the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69117
Reviewed by Darin Fisher.
Source/WebCore:
Convert to using an externally-provided thread instead of one managed by CCThreadProxy internally. Most changes
in these files are mechanically changing references from ccThread to s_ccThread to reflect the class-static
nature of this pointer, the rest are removing the old thread creation codepath.
These changes are covered by the CC* unit tests and by the gpu layout tests when run with the
use_threaded_compositing=1 gyp define.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setThread):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Adds a new WebKit interface to allow the embedder to pass input events directly to the compositor thread.
Exposes the new WebCompositor interface and associated client. These interfaces are slightly different in that
they can only be interacted with from the compositor thread.
Changes the initialization path for the compositor thread to using an externally allocated and managed thread
instead of one internal to WebCore so that the embedder can interact with the thread more easily. This also
simplifies the startup and shutdown paths. The contract is that WebCompositor::setThread() must be called
before any compositor can be initialized and the passed-in thread must outlive all compositor instances.
Each WebCompositor instance is associated with a WebWidget. There isn't any way to get a WebCompositor for a
given WebWidget in this patch, that will be done in a follow-up.
- WebKit.gyp:
- public/WebCompositor.h:
(WebKit::WebCompositor::~WebCompositor):
- public/WebCompositorClient.h:
(WebKit::WebCompositorClient::~WebCompositorClient):
- src/CCThreadImpl.cpp:
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::CCThreadImpl):
- src/CCThreadImpl.h:
- src/WebCompositorImpl.cpp: Added.
(WebKit::WebCompositor::setThread):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
- src/WebCompositorImpl.h:
(WebKit::WebCompositorImpl::create):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
- tests/CCThreadTest.cpp:
(WebKit::TEST):
Tools:
Adds support for creating and setting a compositor thread in DRT.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::WebViewHost):
- DumpRenderTree/chromium/WebViewHost.h:
Sep 29, 2011:
- 11:17 PM Changeset in webkit [96391] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add op_call/op_constructor support to JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69120
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
Improve the coverage of JSVALUE32_64 DFG JIT.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::tagOfCallData):
(JSC::DFG::payloadOfCallData):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- 10:22 PM Changeset in webkit [96390] by
-
- 6 edits in trunk/Tools
watchlist: Add cross-checks for WatchList once it is filled.
https://bugs.webkit.org/show_bug.cgi?id=68975
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
instead of having trivial getter and setters.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
pass the validation checks.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
and fix a few style nits.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
validation checks.
- Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
- 10:15 PM Changeset in webkit [96389] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG JIT - register not unlocked after usage in ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=69122
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Geoffrey Garen.
Some allocated register is not unlocked after the usage in ArithDiv.
Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".
- dfg/DFGNode.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 10:05 PM Changeset in webkit [96388] by
-
- 2 edits in trunk/Tools
run-api-tests fails on chromium-win bot
https://bugs.webkit.org/show_bug.cgi?id=69121
On Windows running a perl script needs the interpreter.
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-29
Reviewed by Adam Barth.
- Scripts/run-api-tests:
(buildTestTool):
- 10:04 PM Changeset in webkit [96387] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test platform/chromium/compositing/3d-corners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69124
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 9:58 PM Changeset in webkit [96386] by
-
- 2 edits in trunk/LayoutTests
fast/text/line-initial-and-final-swashes.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=69103
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 9:44 PM Changeset in webkit [96385] by
-
- 3 edits6 adds in trunk
Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/frames/frame-set-rotation-hit.html
fast/frames/frame-set-scaling-hit.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
LayoutTests:
- fast/frames/frame-set-rotation-hit-expected.png: Added.
- fast/frames/frame-set-rotation-hit-expected.txt: Added.
- fast/frames/frame-set-rotation-hit.html: Added.
- fast/frames/frame-set-scaling-hit-expected.png: Added.
- fast/frames/frame-set-scaling-hit-expected.txt: Added.
- fast/frames/frame-set-scaling-hit.html: Added.
- 9:11 PM Changeset in webkit [96384] by
-
- 2 edits in trunk/Source/WebCore
fix gyp warnings in chromium for renamed files
https://bugs.webkit.org/show_bug.cgi?id=69116
Reviewed by Adam Barth.
- WebCore.gypi:
- 7:30 PM Changeset in webkit [96383] by
-
- 4 edits in trunk/Source/WebKit2
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize the native window handles of GTK.
- UIProcess/WebInspectorProxy.h: Add native window handle for inspector window.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::inspectorFilesBasePath): Base folder for inspector resources.
(WebKit::inspectorWindowDestroyed): Invoked when inspector window is closed by user.
(WebKit::WebInspectorProxy::windowDestroyed): Resets the native handles to 0 when user closes the window.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the WebView for inspector.
(WebKit::WebInspectorProxy::platformOpen): Create the window for inspector.
(WebKit::WebInspectorProxy::platformDidClose): Close both WebView & window of inspector.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Update the title of inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the absolute URL of inspector.html.
(WebKit::WebInspectorProxy::inspectorBaseURL): Return the location where inspector resources are present.
WebProcess is given read access to this folder only for loading file URLs by sandboxed extension.
- 7:18 PM Changeset in webkit [96382] by
-
- 8 edits in trunk/Source/WebKit/efl
[EFL] Use C++ type cast instead of C style type cast
https://bugs.webkit.org/show_bug.cgi?id=68321
Reviewed by Martin Robinson.
This is a second step in order to be more compliant with WebKit coding style.
The second step is to change C-type casting with C++-type casting in .cpp files.
In addition, remained efl style '*' pointer placements are moved to the right place as well.
- ewk/ewk_auth_soup.cpp:
- ewk/ewk_contextmenu.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_history.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_single.cpp:
- ewk/ewk_view_tiled.cpp:
- 7:09 PM Changeset in webkit [96381] by
-
- 10 edits in trunk/Source/JavaScriptCore
De-virtualize JSCell::toObject
https://bugs.webkit.org/show_bug.cgi?id=68937
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.
- runtime/JSCell.cpp:
(JSC::JSCell::toObject):
- runtime/JSCell.h:
Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
- runtime/JSObject.cpp:
- runtime/JSObject.h:
De-virtualized JSObject::toObject and JSString::toObject.
- runtime/JSString.h:
- 5:13 PM Changeset in webkit [96380] by
-
- 2 edits in trunk/LayoutTests
These tests can also time out.
- platform/chromium/test_expectations.txt:
- 5:09 PM Changeset in webkit [96379] by
-
- 5 edits1 copy in trunk/Source/JavaScriptCore
Start refactoring DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=69112
Reviewed by Oliver Hunt.
Again, move JSVALUE64 code into a DFJSpeculativeJIT64.cpp
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT64.cpp: Copied from Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp.
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- 4:47 PM Changeset in webkit [96378] by
-
- 5 edits3 adds in trunk
[Freetype] Some text in Planet GNOME renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=69099
Reviewed by Dirk Schulze.
Source/WebCore:
Test: platform/gtk/fonts/synthetic-oblique-positioning.html
Fold the oblique transform into the font matrix itself rather than transforming
the CTM of the context at render time. Not only does this fix the issue, it
prevents unnecessary work on every paint.
- platform/graphics/cairo/FontCairo.cpp:
No longer set the synthetic oblique transformation matrix on the context
when rendering the text. Instead it is now folded into the TM of the font
itself.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::initializeWithFontFace): Fold the oblique transform into the scaled font.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
LayoutTests:
Add a test which exercises this issue. It seems the problem grows worse
as the y component of the text position increases, so position the text
about halfway down the page.
- platform/gtk/fonts/synthetic-oblique-positioning-expected.png: Added.
- platform/gtk/fonts/synthetic-oblique-positioning-expected.txt: Added.
- platform/gtk/fonts/synthetic-oblique-positioning.html: Added.
- 4:29 PM Changeset in webkit [96377] by
-
- 6 edits1 copy in trunk/Source/JavaScriptCore
Refactor out trivially duplicated code in DFGJITCodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=69109
Reviewed by Oliver Hunt.
Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp
Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code
in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.
For some function differences are trivial & make more sense to ifdef individually, and some
Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
- dfg/DFGJITCodeGenerator32_64.cpp:
- dfg/DFGJITCodeGenerator64.cpp: Copied from Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotCell):
- dfg/DFGJITCompilerInlineMethods.h:
- 4:21 PM Changeset in webkit [96376] by
-
- 6 edits in trunk/LayoutTests
Update image baselines after http://trac.webkit.org/changeset/96366. These are progressions.
- platform/chromium-mac/fast/css/font-smoothing-expected.png:
- platform/chromium-mac/fast/repaint/text-emphasis-v-expected.png:
- platform/chromium-mac/fast/text/emphasis-avoid-ruby-expected.png:
- platform/chromium-mac/fast/text/emphasis-overlap-expected.png:
- platform/chromium-mac/fast/text/soft-hyphen-4-expected.png:
- 4:17 PM Changeset in webkit [96375] by
-
- 19 edits3 adds in trunk/Source/JavaScriptCore
DFG JIT should infer which uses of a variable are not aliased
https://bugs.webkit.org/show_bug.cgi?id=68593
Reviewed by Oliver Hunt.
This separates how a variable is stored (i.e. its virtual register)
from how it's predicted. Each variable now takes a
VariableAccessData as its operand, instead of the virtual register.
The VariableAccessData stores the operand and the prediction. If
multiple uses of a variable are aliased, their VariableAccessDatas
are unified.
This also adds tracking of which argument values are used. It
correctly observes that an argument value is not used, if the
argument is assigned to inside the function before being used.
This also adds tracking of which variables are live at the head of
a basic block, and separates that from a variable being live at the
tail.
Finally, this communicates to both OSR entry and OSR exit code how
a variable is predicted at a particular point in the code, rather
than just communicating how it was predicted in the entire code
block (since with this patch there is no longer the notion of a
variable having just one prediction for a code block).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ActionablePrediction.h: Added.
(JSC::actionablePredictionFromPredictedType):
(JSC::valueObeysPrediction):
(JSC::actionablePredictionToString):
(JSC::ActionablePredictions::ActionablePredictions):
(JSC::ActionablePredictions::setArgument):
(JSC::ActionablePredictions::argument):
(JSC::ActionablePredictions::setVariable):
(JSC::ActionablePredictions::variable):
(JSC::ActionablePredictions::argumentUpperBound):
(JSC::ActionablePredictions::variableUpperBound):
(JSC::ActionablePredictions::pack):
(JSC::ActionablePredictions::packVector):
- bytecode/CodeBlock.h:
- bytecode/PredictionTracker.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGGraph.h:
(JSC::DFG::operandIsArgument):
(JSC::DFG::VariableRecord::setFirstTime):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::local):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- wtf/PackedIntVector.h: Added.
(WTF::PackedIntVector::PackedIntVector):
(WTF::PackedIntVector::operator=):
(WTF::PackedIntVector::size):
(WTF::PackedIntVector::ensureSize):
(WTF::PackedIntVector::resize):
(WTF::PackedIntVector::clearAll):
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):
(WTF::PackedIntVector::mask):
- wtf/Platform.h:
- wtf/UnionFind.h: Added.
(WTF::UnionFind::UnionFind):
(WTF::UnionFind::find):
(WTF::UnionFind::unify):
- 4:12 PM Changeset in webkit [96374] by
-
- 6 edits in trunk
Follow-up fix for <rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not
Reviewed by Simon Fraser.
Source/WebCore:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont): Check for Hoefler Text Black Italic as well.
LayoutTests:
Added Hoefler Text Black Italic to the test case.
- fast/text/line-initial-and-final-swashes.html:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
- 4:09 PM Changeset in webkit [96373] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 3:52 PM Changeset in webkit [96372] by
-
- 13 edits in trunk/Source/JavaScriptCore
Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100
Reviewed by Geoff Garen.
This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
- heap/AllocationSpace.cpp:
Tidy up the write barrier logic a bit
(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):
- heap/AllocationSpace.h:
- heap/CardSet.h:
(JSC::::isCardMarked):
(JSC::::clearCard):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- heap/Heap.h:
(JSC::Heap::writeBarrier):
- heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
- heap/SlotVisitor.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
Tidy the write barrier a bit
- 3:42 PM Changeset in webkit [96371] by
-
- 3 edits3 copies in branches/chromium/874
Merge 96151 - Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
BUG=98161
Review URL: http://codereview.chromium.org/8082012
- 3:39 PM Changeset in webkit [96370] by
-
- 1 edit2 copies in branches/chromium/874
Merge 96341 - We should ignore the return value of GetRealNamedProperty
BUG=96885
Review URL: http://codereview.chromium.org/8090001
- 3:35 PM Changeset in webkit [96369] by
-
- 1 edit3 copies in branches/chromium/874
Merge 96294 - <rdar://problem/10196497> first-letter after list marker not updated correctly
BUG=98064
Review URL: http://codereview.chromium.org/8085012
- 3:33 PM Changeset in webkit [96368] by
-
- 3 edits3 copies in branches/chromium/874
Merge 96260 - JavaScript generated documents don't inherit the cookie URL
BUG=98407
Review URL: http://codereview.chromium.org/8083016
- 3:25 PM Changeset in webkit [96367] by
-
- 2 edits in trunk/Tools
Attempt to make this tool work on Windows.
- Scripts/run-api-tests:
(buildTestTool):
- 3:21 PM Changeset in webkit [96366] by
-
- 2 edits in trunk/Source/WebCore
Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734
Reviewed by Stephen White.
No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.
Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.
- platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):
- 3:16 PM Changeset in webkit [96365] by
-
- 4 edits in trunk/Source
Implement flick gesture in Chromium Gesture Recognizer
https://bugs.webkit.org/show_bug.cgi?id=67930
Reviewed by Dimitri Glazkov.
Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp
- platform/chromium/GestureRecognizerChromium.cpp: (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed): (WebCore::GestureRecognizerChromium::appendScrollGestureEnd): (WebCore::GestureRecognizerChromium::updateValues): (WebCore::GestureRecognizerChromium::scrollEnd):
- platform/chromium/GestureRecognizerChromium.h:
Patch by Varun Jain <varunjain@google.com> on 2011-09-29
- 3:14 PM Changeset in webkit [96364] by
-
- 2 edits in trunk/Source/WebCore
[chromium] canvas.toDataURL("image/jpeg"): use libjpeg-turbo data swizzle
https://bugs.webkit.org/show_bug.cgi?id=67402
Reviewed by Kenneth Russell.
libjpeg-turbo can read directly from the input data for the premultiplied BRGX
(SkBitmap) encoding case.
No change in behavior, covered by existing canvas 2d/3d tests
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels): If JCS_EXTENSIONS is defined (libjpeg-turbo), swizzle
the input BRGX pixels directly within libjpeg-turbo.
- 3:13 PM Changeset in webkit [96363] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix.
- assembler/MacroAssemblerCodeRef.h:
- dfg/DFGOperations.h:
- 3:02 PM Changeset in webkit [96362] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-29
Reviewed by Ryosuke Niwa.
Add a function to return a frame's contents converted to plain text,
as already exposed by other ports and needed by DRT when dumping a
frame's contents.
- ewk/ewk_frame.cpp:
(ewk_frame_plain_text_get):
- ewk/ewk_frame.h:
- 2:58 PM Changeset in webkit [96361] by
-
- 2 edits in trunk/LayoutTests
This test can also time out.
- platform/chromium/test_expectations.txt:
- 2:29 PM Changeset in webkit [96360] by
-
- 3 edits in trunk/Tools
[Qt] Try to fix the minial build
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/webpage.cpp:
- 2:15 PM Changeset in webkit [96359] by
-
- 1 edit1 delete in trunk/LayoutTests
Delete bogus expectation.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.
- 2:12 PM Changeset in webkit [96358] by
-
- 4 edits3 adds1 delete in trunk/LayoutTests
Attempt to update these image results again.
- platform/chromium-cg-mac-leopard/http/tests/misc: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
- platform/chromium-mac/http/tests/misc/acid3-expected.png:
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
- 2:07 PM Changeset in webkit [96357] by
-
- 2 edits in trunk/Source/WebCore
Fixenate the build.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):
- 1:51 PM Changeset in webkit [96356] by
-
- 2 edits in trunk/LayoutTests
Mark test as expected to fail.
- platform/chromium/test_expectations.txt:
- 1:50 PM Changeset in webkit [96355] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.
Rubber-stamped by Tor Arne Vestbø.
- platform/qt-wk2/Skipped:
- 1:45 PM Changeset in webkit [96354] by
-
- 3 edits in trunk/Source/JavaScriptCore
Structure transitions involving many (> 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102
Reviewed by Darin Adler.
Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
- 1:31 PM Changeset in webkit [96353] by
-
- 5 edits in trunk/Source/WebCore
Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023
Reviewed by Enrica Casucci.
Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).
Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.
Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
completeHTMLReplacement by nullity checks of start and end positions.
- dom/Node.cpp:
(WebCore::Node::traversePreviousSibling): Added.
- dom/Node.h:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
willRemoveNode.
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
removeUnrenderedTextNodesAtEnds.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
accessing m_firstNodeInserted.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/ReplaceSelectionCommand.h:
- 1:30 PM Changeset in webkit [96352] by
-
- 2 edits in trunk/Source/WebCore
Shrink HTMLAnchorElement on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69094
Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.
- html/HTMLAnchorElement.h: Pack members into a bitfield.
- 1:21 PM Changeset in webkit [96351] by
-
- 3 edits3 adds in trunk
<rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/text/line-initial-and-final-swashes.html
Hoefler Text Italic enables line-initial and -final swashes by default, so disable them. This
change targets only this known-bad font rather than all fonts, because at least one font (Khmer MN)
incorrectly claims to have the line-initial feature enabled, but disabling it actually does
something different and bad (breaking some combining marks).
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::createFeatureSettingDictionary): Added this helper function.
(WebCore::cascadeToLastResortFontDescriptor): Deployed WTF_ARRAY_LENGTH().
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor): Added. Returns a font descriptor
that, in addition to having a cascade list consisting of the last resort font, also has feature
settings to disable line-initial and line-final swashes.
(WebCore::FontPlatformData::ctFont): For Hoefler Text Italic, use cascadeToLastResortAndDisableSwashesFontDescriptor().
LayoutTests:
- fast/text/line-initial-and-final-swashes.html: Added.
- platform/mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Added.
- 1:14 PM Changeset in webkit [96350] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed: resetting baseline for code generator bindings
Unreviewed build fix
No new tests.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- 12:46 PM Changeset in webkit [96349] by
-
- 2 edits in trunk/Source/WebCore
[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().
https://bugs.webkit.org/show_bug.cgi?id=68099
Reviewed by Adam Barth.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):
- 12:40 PM Changeset in webkit [96348] by
-
- 9 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=69040
ScrollbarThemeComposite requires a ScrollView to draw scroll corner
Reviewed by Simon Fraser.
No new tests. This will be needed later.
- platform/ScrollbarThemeComposite.cpp:
(WebCore::pageForScrollView):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
Use pageForScrollView() function which already existed in this file, used in another similar
location.
- platform/chromium/FramelessScrollView.cpp:
- platform/chromium/FramelessScrollView.h:
- platform/gtk/ScrollbarThemeGtk.cpp:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/wx/ScrollbarThemeWx.cpp:
- platform/wx/ScrollbarThemeWx.h:
All these overrides are no longer needed, ScrollbarThemeComposite will do the right thing.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
Removed a special case for updatingControlTints phase. The same case is present in cross-platform
code now, and Qt doesn't have any custom subclasses of ScrollableArea or ScrollView to need
special handling.
This was added in r37377 without a bug or much ChangeLog explanation.
- 12:37 PM Changeset in webkit [96347] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux
- assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- 12:37 PM Changeset in webkit [96346] by
-
- 78 edits in trunk/Source
De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- API/JSCallbackObject.h:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
- debugger/DebuggerActivation.h:
- runtime/Arguments.cpp:
- runtime/Arguments.h:
- runtime/Executable.cpp:
- runtime/Executable.h:
- runtime/GetterSetter.cpp:
- runtime/GetterSetter.h:
- runtime/JSActivation.cpp:
- runtime/JSActivation.h:
- runtime/JSArray.cpp:
- runtime/JSArray.h:
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSPropertyNameIterator.h:
- runtime/JSStaticScopeObject.cpp:
- runtime/JSStaticScopeObject.h:
- runtime/JSValue.h:
- runtime/NativeErrorConstructor.cpp:
- runtime/NativeErrorConstructor.h:
- runtime/RegExpObject.cpp:
- runtime/RegExpObject.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
- runtime/StructureChain.cpp:
- runtime/StructureChain.h:
Inlined the method table access and call to the visitChildren function (the only call sites
to visitChildren are here).
- heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
Changed the field name for the visitChildren function pointer to visitChildren (from
visitChildrenFunctionPtr) to make call sites less verbose.
- runtime/ClassInfo.h:
Discovered JSBoundFunction doesn't have its own ClassInfo (it used JSFunction's ClassInfo) but
overrides visitChildren, so it needs to have its own ClassInfo.
- runtime/JSBoundFunction.cpp:
- runtime/JSBoundFunction.h:
Had to move className up to make sure that the virtual destructor in JSObject wasn't
the first non-inline virtual method in JSObject (as per the comment in the file).
Also moved JSCell::visitChildrenVirtual into JSObject.h in order for it be inline-able
to mitigate the cost of an extra method call.
Also added a convenience accessor function methodTable() to JSCell to return the MethodTable to make
call sites more concise. Implementation is inline in JSObject.h.
- runtime/JSObject.h:
(JSC::JSCell::methodTable):
- runtime/JSCell.h:
Added an out of line virtual destructor to JSWrapperObject and ScopeChainNode to
appease the vtable gods. It refused to compile if there were no virtual methods in
both of these classes due to the presence of a weak vtable pointer.
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::~JSWrapperObject):
- runtime/JSWrapperObject.h:
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::~ScopeChainNode):
- runtime/ScopeChain.h:
Source/JavaScriptGlue:
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- UserObjectImp.cpp:
- UserObjectImp.h:
Source/WebCore:
No new tests.
Removed the remaining visitChildrenVirtual methods. This patch completes the process of
de-virtualizing visitChildren.
- WebCore.exp.in:
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSAudioContextCustom.cpp:
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSJavaScriptAudioNodeCustom.cpp:
- bindings/js/JSMessageChannelCustom.cpp:
- bindings/js/JSMessagePortCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/JSNodeFilterCustom.cpp:
- bindings/js/JSNodeIteratorCustom.cpp:
- bindings/js/JSSVGElementInstanceCustom.cpp:
- bindings/js/JSSharedWorkerCustom.cpp:
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSTreeWalkerCustom.cpp:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- bindings/js/JSWorkerContextCustom.cpp:
- bindings/js/JSXMLHttpRequestCustom.cpp:
- bindings/js/JSXPathResultCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/qt/qt_instance.cpp:
- bridge/qt/qt_runtime.cpp:
- bridge/qt/qt_runtime.h:
- 12:31 PM Changeset in webkit [96345] by
-
- 55 edits in trunk
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.
https://bugs.webkit.org/show_bug.cgi?id=68687
Reviewed by Andreas Kling.
- 12:07 PM Changeset in webkit [96344] by
-
- 2 edits in trunk/Source/JavaScriptCore
Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:03 PM Changeset in webkit [96343] by
-
- 12 edits2 deletes in trunk
Unreviewed, rolling out r96340.
http://trac.webkit.org/changeset/96340
https://bugs.webkit.org/show_bug.cgi?id=69098
Caused 10 tests to crash in Debug (Requested by
abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-29
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
- accessibility/AccessibilityRenderObject.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
LayoutTests:
- platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
- platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.
- 11:04 AM Changeset in webkit [96342] by
-
- 5 edits in trunk/Source/WebCore
Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093
Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.
Reduce the size of FontFallbackList by one CPU word, decreasing memory
consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.
- platform/graphics/FontCache.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::generation):
Store the FontCache generation as an ushort rather than uint.
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
- platform/graphics/FontFallbackList.h:
Pack enum and bool members in a bitfield.
- 10:50 AM Changeset in webkit [96341] by
-
- 3 edits2 adds in trunk
We should ignore the return value of GetRealNamedProperty
https://bugs.webkit.org/show_bug.cgi?id=68840
Reviewed by Nate Chapin.
Source/WebCore:
Instead of skipping the lookup process by using the result of real
named property, we should just indiciate that it wasn't handled by the
interceptor.
Test: http/tests/security/window-named-valueOf.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
LayoutTests:
- http/tests/security/window-named-valueOf-expected.txt: Added.
- http/tests/security/window-named-valueOf.html: Added.
- 10:46 AM Changeset in webkit [96340] by
-
- 12 edits2 adds in trunk
ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289
Source/WebCore:
If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.
Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.
Reviewed by Darin Adler.
Test: platform/mac/accessibility/aria-liveregion-without-element-access.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
- accessibility/AccessibilityRenderObject.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
LayoutTests:
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
- platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
- 10:35 AM Changeset in webkit [96339] by
-
- 7 edits5 deletes in trunk/Source/WebCore
[GTK] Dragging a selection does not produce a drag image
https://bugs.webkit.org/show_bug.cgi?id=69064
Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-29
Reviewed by Andreas Kling.
Moved Chromium's generic implementation of Frame::nodeImage and
Frame::dragImageForSeletion to Frame.cpp and simply excluded via
#ifdefs platforms that do not have their own implementation. Removed
all empty implementations of these functions and Qt's which was
functionally identical.
No new tests. Drag-and-drop drag image functionality changes
are incredibly difficult to test in a non-manual way.
- CMakeListsEfl.txt: Delist FrameEfl.cpp.
- GNUmakefile.list.am: Delist FrameGtk.cpp.
- WebCore.gypi: Delist removed Frame*.cpp.
- WebCore.pro: Delist FrameQt.cpp.
- page/Frame.cpp: Moved FrameChromium implementation here.
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/chromium/FrameChromium.cpp: Removed.
- page/efl/FrameEfl.cpp: Removed.
- page/gtk/FrameGtk.cpp: Removed.
- page/qt/FrameQt.cpp: Removed.
- page/wx/FrameWx.cpp: Removed.
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
the drag image for a node.
- 10:16 AM Changeset in webkit [96338] by
-
- 2 edits in trunk/Source/WebCore
[chromium skia] PNGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=68988
Reviewed by Kenneth Russell.
No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.png.*.html
fast/canvas/toDataURL-alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::encodePixels): Move constant out of the encoding loop.
(WebCore::PNGImageEncoder::encode): Consistency & style: call encodePixels()
just like we do in the JPEG encoder.
- 10:05 AM Changeset in webkit [96337] by
-
- 5 edits1 add in trunk/Source
Add unit test for CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=68622
Source/WebCore:
Minor refactoring for testability:
- Made pointInTriangle public.
- Added LayerShape to decouple LayerIntersector and GraphNode.
- Added a public wrapper function for LayerIntersector.
Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::pointInTriangle):
(WebCore::CCLayerSorter::calculateZDiff):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
- platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):
Source/WebKit/chromium:
Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.
- WebKit.gypi:
- tests/CCLayerSorterTest.cpp: Added.
(WebCore::TEST):
- 10:04 AM Changeset in webkit [96336] by
-
- 5 edits2 moves5 adds8 deletes in trunk/LayoutTests
Rebaseline for r95870
https://bugs.webkit.org/show_bug.cgi?id=69090
Patch by David Reveman <reveman@chromium.org> on 2011-09-29
Reviewed by James Robinson.
- platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.png: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.txt: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
- platform/chromium-gpu/compositing/flat-with-transformed-child-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/3d-corners-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/backface-visibility-transformed-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png.
- platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt.
- platform/chromium/test_expectations.txt:
- 9:42 AM Changeset in webkit [96335] by
-
- 1 edit2 adds in trunk/LayoutTests
Layout test demonstrating IDBCursor inconsistency bug.
https://bugs.webkit.org/show_bug.cgi?id=69012
Reviewed by Nate Chapin.
- storage/indexeddb/cursor-inconsistency-expected.txt: Added.
- storage/indexeddb/cursor-inconsistency.html: Added.
- 9:32 AM Changeset in webkit [96334] by
-
- 2 edits in trunk/Tools
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
- 9:25 AM Changeset in webkit [96333] by
-
- 2 edits in trunk/LayoutTests
Generalize expected result to all of MAC.
- platform/chromium/test_expectations.txt:
- 9:24 AM Changeset in webkit [96332] by
-
- 2 edits in trunk/LayoutTests
This test can also time out.
- platform/chromium/test_expectations.txt:
- 9:20 AM Changeset in webkit [96331] by
-
- 1 edit2 adds in trunk/LayoutTests
Update expected results on Leopard. As far as I can tell, these are
progressions.
- platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.
- 9:09 AM Changeset in webkit [96330] by
-
- 2 edits in trunk/LayoutTests
Add some expected failures on Leopard.
- platform/chromium/test_expectations.txt:
- 8:46 AM Changeset in webkit [96329] by
-
- 4 edits in trunk/Tools
Unbreak the "update expectatations" button by using the existing
machinery to create the failureInfo objects.
Unbreak the "close" button on the progress dialog by using |this|
instead of the old name of the object.
Teach the controllers unit test not to talk to the actual network.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 8:34 AM Changeset in webkit [96328] by
-
- 1 edit4 adds in trunk/LayoutTests
Update baselines. (Font rendering.)
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
- platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
- 8:32 AM Changeset in webkit [96327] by
-
- 1 edit6 adds2 deletes in trunk/LayoutTests
Update baselines.
- platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
- platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
- platform/chromium-mac-leopard/svg/text: Added.
- platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
- platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
- platform/mac/svg/text/selection-background-color-expected.txt: Removed.
- svg/text/selection-background-color-expected.txt: Added.
- 7:30 AM Changeset in webkit [96326] by
-
- 5 edits in trunk
Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
https://bugs.webkit.org/show_bug.cgi?id=69087
The fix has the changes for the test and minor perf framework improvements.
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._defaultRefreshDelay.500._scheduleRefresh):
LayoutTests:
- inspector/performance/resources/network-append-30-requests.html:
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):
- 7:22 AM WebKitGTK/Releasing edited by
- (diff)
- 7:22 AM WebKitGTKStableReleases edited by
- (diff)
- 7:21 AM WebKitGTKStableReleases edited by
- (diff)
- 7:20 AM WebKitGTKStableReleases edited by
- (diff)
- 7:20 AM WebKitGTKStableReleases edited by
- (diff)
- 6:59 AM Changeset in webkit [96325] by
-
- 2 edits in trunk
[GTK] Bump version to 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=69082
Reviewed by Martin Robinson.
Apart from bumping the library version to 1.7.0 this patch also
sets the libtool version to the same one we have for the stable
branch.
- configure.ac:
- 6:53 AM Changeset in webkit [96324] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Force single header include in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69084
Reviewed by Martin Robinson.
Only <webkit2/webkit2.h> will be allowed for API users.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebLoaderClient.h:
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewBase.h:
- UIProcess/API/gtk/webkit2.h:
- 6:44 AM QtWebKitRelease22 edited by
- (diff)
- 6:02 AM QtWebKitRelease22 edited by
- (diff)
- 5:59 AM Changeset in webkit [96323] by
-
- 8 edits in trunk
Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025
Source/WebCore:
Changed search-in-resource test.
Removed error parameter from content provider's searchInContent callback.
Reviewed by Pavel Feldman.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/search/search-in-resource-expected.txt:
- http/tests/inspector/search/search-in-resource.html:
- http/tests/inspector/search/search-in-resources.html:
- http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):
- 5:56 AM QtWebKitRelease22 edited by
- (diff)
- 5:29 AM Changeset in webkit [96322] by
-
- 11 edits in trunk
IndexedDB: Use LevelDB also for in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=68903
Reviewed by Steve Block.
Source/WebCore:
Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
to create in-memory LevelDB databases.
Use this in IDBLeveLDBBackingStore::open() when the caller passes in
an empty file path.
This happens in Chromium's incognito mode, and when running layout
tests.
Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
files when passed in an empty file path, but uses the in-memory mode
instead.
Existing layout tests will all be run in-memory.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::openDB):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):
- platform/leveldb/LevelDBDatabase.h:
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::backingStoreExists):
Source/WebKit/chromium:
Don't fall back to SQLite or use a temporary dir for in-memory
databases (Incognito and layout tests); LevelDB supports in-memory
databases now.
- public/WebIDBFactory.h:
- src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
Tools:
Remove the temporary dir that was necessary before LevelDB supported
in-memory databases.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
- 4:59 AM Changeset in webkit [96321] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
https://bugs.webkit.org/show_bug.cgi?id=69081
There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.
Reviewed by Pavel Feldman.
Test: inspector/performance/resources/network-append-30-requests.html
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):
- 4:49 AM Changeset in webkit [96320] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: make inspector protocol validation a part of the build process.
https://bugs.webkit.org/show_bug.cgi?id=68999
Since we'd like to commit to inspector protocol backwards compatibility, violating it
should be a build failure.
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- inspector/Inspector.draft-01.json:
- inspector/Inspector.json:
- inspector/generate-inspector-idl:
- inspector/generate-protocol-externs:
- inspector/validate-protocol-compatibility:
- 4:39 AM Changeset in webkit [96319] by
-
- 7 edits4 deletes in trunk
Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
LayoutTests:
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
- platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
- platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
- 4:06 AM Changeset in webkit [96318] by
-
- 2 edits in trunk/Source/WebCore
2011-09-28 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: network log view refresh optimizations
https://bugs.webkit.org/show_bug.cgi?id=69010
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView.prototype.refresh):
- 4:00 AM Changeset in webkit [96317] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079
Reviewed by Xan Lopez.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):
- 3:33 AM Changeset in webkit [96316] by
-
- 2 edits in trunk/LayoutTests
LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=69067
Patch by Arun Patole <bmf834@motorola.com> on 2011-09-29
Reviewed by Philippe Normand.
Update expected test result for video-does-not-loop.html
as the 'pause' event should be fired at the end of playback.
- media/video-does-not-loop-expected.txt:
- 3:30 AM Changeset in webkit [96315] by
-
- 2 edits in trunk/LayoutTests
[Chromium] some Layout Tests in editing/ is failing
https://bugs.webkit.org/show_bug.cgi?id=69078
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 3:07 AM Changeset in webkit [96314] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-javascript-doc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69077
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 1:46 AM WebKitGTK/Releasing edited by
- Confirmed that patch is required even for make-3.82 (diff)
- 1:44 AM Changeset in webkit [96313] by
-
- 5 edits1 move1 add1 delete in trunk
Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
https://bugs.webkit.org/show_bug.cgi?id=69068
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.
(WebInspector.RawSourceCode): Moved from SourceFile.js.
(WebInspector.UILocation): Moved from SourceFile.js.
- inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:36 AM Changeset in webkit [96312] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test svg/filters/animate-fill.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=69070
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 1:07 AM Changeset in webkit [96311] by
-
- 3 edits in trunk
[GStreamer] 2 flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=67407
Reviewed by Martin Robinson.
Workaround for GStreamer bug#639941. In GStreamer
0.10.35 basesink reports wrong duration in case of EOS and
negative playback rate. This workaround fixes two media tests,
media/video-timeupdate-reverse-play.html and
media/video-reverse-play-duration.html.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
- 1:03 AM Changeset in webkit [96310] by
-
- 6 edits in trunk/Source/WebCore
[GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936
Reviewed by Martin Robinson.
Don't use the identity element to avoid painting of the in-window
video. Instead simply make the sink aware of the fullscreen state
and ignore buffers if fullscreen and autovideosink are
active. Also fixed two deadlocks happening when a paused pipeline
is switched to fullscreen and when fullscreen is disabled for a
paused pipeline.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/GStreamerGWorld.h:
(WebCore::GStreamerGWorld::isFullscreen):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
(webkit_video_sink_new):
- platform/graphics/gstreamer/VideoSinkGStreamer.h:
- 12:52 AM Changeset in webkit [96309] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.
size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.
- dfg/DFGNode.h:
- 12:33 AM Changeset in webkit [96308] by
-
- 2 edits in trunk/LayoutTests
Hopefully the last Chromium test expectation update for r96294.
- platform/chromium/test_expectations.txt:
- 12:23 AM Changeset in webkit [96307] by
-
- 59 edits3 adds in trunk
REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred
https://bugs.webkit.org/show_bug.cgi?id=68679
<rdar://problem/10204649>
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Strip prefixes from SVG attributes before testing if they're supported.
Namespaced attributes will be matched using their namespace instead of
the (user-choosable) prefix.
Test: svg/custom/xlink-custom-namespace.svg
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
- svg/SVGElement.h:
(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
- svg/SVGExternalResourcesRequired.h:
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::addSupportedAttributes):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):
LayoutTests:
Add a test ensuring that using xlink:href with a different prefix (i.e. xl:href)
works correctly.
- svg/custom/xlink-custom-namespace-expected.png: Added.
- svg/custom/xlink-custom-namespace-expected.txt: Added.
- svg/custom/xlink-custom-namespace.svg: Added.
- 12:12 AM Changeset in webkit [96306] by
-
- 4 edits3 adds in trunk
DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
LayoutTests:
- fast/js/boolean-argument-prediction-expected.txt: Added.
- fast/js/boolean-argument-prediction.html: Added.
- fast/js/script-tests/boolean-argument-prediction.js: Added.
(predictBooleanArgument):
Sep 28, 2011:
- 11:32 PM Changeset in webkit [96305] by
-
- 2 edits in trunk/LayoutTests
Chromium test_expectations update for isindex-with-no-form.html
- platform/chromium/test_expectations.txt:
- 11:27 PM Changeset in webkit [96304] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062
Chromium test_expectations update
- platform/chromium/test_expectations.txt:
- 11:24 PM Changeset in webkit [96303] by
-
- 1 edit4 adds in trunk/LayoutTests
Chromium rebaseline after r96294.
- platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- 11:11 PM Changeset in webkit [96302] by
-
- 3 edits in trunk/LayoutTests
Yet another Chromium linux rebaseline after r96257.
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
- platform/chromium/test_expectations.txt:
- 11:07 PM Changeset in webkit [96301] by
-
- 3 edits in trunk/Source/WebCore
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
https://bugs.webkit.org/show_bug.cgi?id=68984
Reviewed by Darin Adler.
Just a follow-up fix for the bug 68345. For performance,
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".
Tests: fast/events/constructors/pop-state-event-constructor.html
fast/events/fire-popstate-event.html
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):
- dom/PopStateEvent.h:
- 11:03 PM Changeset in webkit [96300] by
-
- 7 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r96257.
- platform/qt-4.8/editing/inserting/4278698-expected.png:
- platform/qt-4.8/editing/inserting/4278698-expected.txt:
- platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
- platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
- platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
- platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:
- 11:02 PM Changeset in webkit [96299] by
-
- 6 edits2 adds in trunk/Source
[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=66890
Source/WebCore:
Added a GtkDragAndDropHelper class to hold all the logic that is common
between WebKit1 and WebKit2. This will allow greater code sharing between
the two ports.
Reviewed by Philippe Normand.
No new tests. This patch should not change behavior.
- GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
- platform/gtk/GtkDragAndDropHelper.cpp: Added.
- platform/gtk/GtkDragAndDropHelper.h: Added.
Source/WebKit/gtk:
Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.
Reviewed by Philippe Normand.
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.
- webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was
maintaining drag-and-drop state itself.
- webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance
of the glue class.
- 11:01 PM Changeset in webkit [96298] by
-
- 2 edits2 adds in trunk/LayoutTests
Update Chromium test expectation and also add back the expected result erroneously removed in r96284.
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.
- 10:43 PM Changeset in webkit [96297] by
-
- 27 edits29 adds39 deletes in trunk/LayoutTests
Chromium rebaselines for r96257 part 2.
- editing/deleting/delete-line-011-expected.txt: Added.
- editing/deleting/delete-tab-001-expected.txt: Added.
- editing/deleting/delete-tab-002-expected.txt: Added.
- editing/deleting/delete-tab-003-expected.txt: Added.
- editing/deleting/delete-tab-004-expected.txt: Added.
- editing/deleting/smart-delete-002-expected.txt: Added.
- editing/inserting/insert-text-with-newlines-expected.txt: Added.
- editing/style/smoosh-styles-003-expected.txt: Added.
- editing/style/style-3681552-fix-001-expected.txt: Added.
- editing/style/style-boundary-002-expected.txt: Added.
- editing/style/style-boundary-003-expected.txt: Added.
- editing/style/typing-style-001-expected.txt: Added.
- editing/style/typing-style-002-expected.txt: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-cg-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-linux-x86/editing: Added.
- platform/chromium-linux-x86/editing/pasteboard: Added.
- platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-linux-x86/editing/style: Added.
- platform/chromium-linux-x86/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
- platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/chromium-linux/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win-vista/editing/deleting: Removed.
- platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand: Removed.
- platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Removed.
- platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Removed.
- platform/chromium-win-vista/editing/inserting: Removed.
- platform/chromium-win-vista/editing/inserting/4278698-expected.png: Removed.
- platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Removed.
- platform/chromium-win-vista/editing/selection: Removed.
- platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Removed.
- platform/chromium-win-vista/editing/style: Added.
- platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-win-vista/editing/undo: Removed.
- platform/chromium-win-vista/editing/undo/4063751-expected.png: Removed.
- platform/chromium-win-vista/editing/unsupported-content: Removed.
- platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Removed.
- platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Removed.
- platform/chromium-win-xp/editing/pasteboard: Added.
- platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/chromium-win-xp/editing/style: Added.
- platform/chromium-win-xp/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/chromium-win-xp/fast/events: Removed.
- platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Added.
- platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/chromium-win/editing/spelling/spelling-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
- platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
- platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
- platform/chromium-win/editing/style/style-boundary-002-expected.txt:
- platform/chromium-win/editing/style/style-boundary-003-expected.txt:
- platform/chromium-win/editing/style/style-boundary-005-expected.txt:
- platform/chromium-win/editing/style/typing-style-001-expected.txt:
- platform/chromium-win/editing/style/typing-style-002-expected.txt:
- platform/chromium-win/fast/events/updateLayoutForHitTest-expected.png:
- platform/chromium-win/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-002-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-003-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
- platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
- platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
- platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
- platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
- platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
- platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
- platform/gtk/fast/repaint/selection-clear-expected.txt: Removed.
- platform/mac/editing/deleting/delete-line-011-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-001-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-002-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-003-expected.txt: Removed.
- platform/mac/editing/deleting/delete-tab-004-expected.txt: Removed.
- platform/mac/editing/deleting/smart-delete-002-expected.txt: Removed.
- platform/mac/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
- platform/mac/editing/style/smoosh-styles-003-expected.txt: Removed.
- platform/mac/editing/style/style-3681552-fix-001-expected.txt: Removed.
- platform/mac/editing/style/style-boundary-002-expected.txt: Removed.
- platform/mac/editing/style/style-boundary-003-expected.txt: Removed.
- platform/mac/editing/style/typing-style-001-expected.txt: Removed.
- platform/mac/editing/style/typing-style-002-expected.txt: Removed.
- 9:55 PM Changeset in webkit [96296] by
-
- 2 edits in trunk/LayoutTests
Remove some of Chromium test expectations temporarily added for r96257.
- platform/chromium/test_expectations.txt:
- 9:48 PM Changeset in webkit [96295] by
-
- 4 edits in trunk
.: Fix the WebKit2 WebGL build.
- configure.ac: Add -ldl to the OPENGL_LIBS.
Source/WebKit2: Fix the WebGL build on WebKit2 GTK+.
- GNUmakefile.am: Add OPENGL_LIBS to WebKit2 targets.
- 9:12 PM Changeset in webkit [96294] by
-
- 3 edits3 adds in trunk
<rdar://problem/10196497> first-letter after list marker not updated correctly
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/dynamic/first-letter-after-list-marker.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter): Improved the logic for continuing past list markers
when trying to locate a first letter to update.
LayoutTests:
- fast/dynamic/first-letter-after-list-marker-expected.png: Added.
- fast/dynamic/first-letter-after-list-marker-expected.txt: Added.
- fast/dynamic/first-letter-after-list-marker.html: Added.
- 9:00 PM Changeset in webkit [96293] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix pt 2 for r96286.
- assembler/MacroAssemblerCodeRef.h:
- 8:57 PM Changeset in webkit [96292] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for accesskey in regard to iframes.
https://bugs.webkit.org/show_bug.cgi?id=67642
Reviewed by Hajime Morita.
To catch any improvement of accesskey behavior in regard to
iframes, it'd be nice to add a test to verify the current behavior.
- fast/dom/access-key-iframe-expected.txt: Added.
- fast/dom/access-key-iframe.html: Added.
- 7:52 PM Changeset in webkit [96291] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
https://bugs.webkit.org/show_bug.cgi?id=68594
As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
isn't effective at all, this patch just removes it.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_zoom_set_internal):
- 7:49 PM Changeset in webkit [96290] by
-
- 5 edits in trunk
REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 231
https://bugs.webkit.org/show_bug.cgi?id=68981
Reviewed by Darin Adler.
Source/WebCore:
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().
LayoutTests:
- fast/forms/input-text-paste-maxlength-expected.txt:
- fast/forms/input-text-paste-maxlength.html:
- 7:37 PM Changeset in webkit [96289] by
-
- 2 edits in trunk/Tools
Run TestWebKitAPI on Chromium buildbots
https://bugs.webkit.org/show_bug.cgi?id=68678
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 7:32 PM Changeset in webkit [96288] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix attempt for r96286.
- assembler/MacroAssemblerCodeRef.h:
- 7:27 PM Changeset in webkit [96287] by
-
- 2 edits in trunk
[EFL] Bump minimum requirement for eina.
https://bugs.webkit.org/show_bug.cgi?id=68994
Reviewed by Ryosuke Niwa.
- Source/cmake/FindEFL.cmake:
- 6:36 PM Changeset in webkit [96286] by
-
- 6 edits in trunk/Source/JavaScriptCore
DFG JIT Operations on 32_64 should use stdcall calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69046
Reviewed by Sam Weinig.
All calls out are expecting stdcall conventions, but the default on OS X are cdecl.
Leave D_DFGOperation_DD calls as the one exception, since we want to be able to link
directly to std library functions like fmod - leave these calls obeying the default
platform calling convention.
- assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- Add implicit constructors for std calls.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- Make this work non-Mac platforms.
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
- Mark all operations as stdcalls.
- 6:34 PM Changeset in webkit [96285] by
-
- 2 edits in trunk/LayoutTests
One last GTK rebaseline for r96257.
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- 6:31 PM Changeset in webkit [96284] by
-
- 53 edits58 adds2 deletes in trunk/LayoutTests
Chromium rebaseline for r96257 part 2.
- platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
- platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/undo: Added.
- platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-cg-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-cg-mac/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-cg-mac/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-cg-mac/editing/inserting/4278698-expected.png: Added.
- platform/chromium-cg-mac/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-cg-mac/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-cg-mac/editing/undo: Added.
- platform/chromium-cg-mac/editing/undo/4063751-expected.png: Added.
- platform/chromium-cg-mac/editing/unsupported-content: Added.
- platform/chromium-cg-mac/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-cg-mac/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-linux/editing/execCommand/paste-1-expected.png:
- platform/chromium-linux/editing/execCommand/paste-2-expected.png:
- platform/chromium-linux/editing/inserting/4278698-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-linux/editing/pasteboard/3976872-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-expected.png:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
- platform/chromium-linux/editing/undo/4063751-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-mac/editing/execCommand/paste-1-expected.png:
- platform/chromium-mac/editing/execCommand/paste-2-expected.png:
- platform/chromium-mac/editing/inserting/4278698-expected.png:
- platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-mac/editing/pasteboard/3976872-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-expected.png:
- platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png:
- platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
- platform/chromium-mac/editing/undo/4063751-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win-vista/editing: Added.
- platform/chromium-win-vista/editing/deleting: Added.
- platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand: Added.
- platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Added.
- platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Added.
- platform/chromium-win-vista/editing/inserting: Added.
- platform/chromium-win-vista/editing/inserting/4278698-expected.png: Added.
- platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard: Added.
- platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/chromium-win-vista/editing/selection: Added.
- platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Added.
- platform/chromium-win-vista/editing/undo: Added.
- platform/chromium-win-vista/editing/undo/4063751-expected.png: Added.
- platform/chromium-win-vista/editing/unsupported-content: Added.
- platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Added.
- platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Added.
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-win/editing/execCommand/paste-1-expected.png:
- platform/chromium-win/editing/execCommand/paste-2-expected.png:
- platform/chromium-win/editing/inserting/4278698-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-win/editing/pasteboard/3976872-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-win/editing/selection/select-all-iframe-expected.png:
- platform/chromium-win/editing/undo/4063751-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.
- 6:28 PM Changeset in webkit [96283] by
-
- 5 edits in trunk/Source
Remove unused createRootLayerPainter from CCLayerTreeHostClient
https://bugs.webkit.org/show_bug.cgi?id=69042
Patch by Antoine Labour <piman@chromium.org> on 2011-09-28
Reviewed by James Robinson.
No new test needed: no semantic change.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- 6:03 PM clutter edited by
- (diff)
- 6:03 PM Changeset in webkit [96282] by
-
- 2 edits in trunk/Tools
garden-o-matic results should anticipate 0 unexpected failures.
https://bugs.webkit.org/show_bug.cgi?id=69036
Also fixes controllers: UnexpectedFailures test.
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
- 6:01 PM Changeset in webkit [96281] by
-
- 2 edits in trunk/Source/WebCore
Only resolve direction aware properties when properties are direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 5:47 PM Changeset in webkit [96280] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG JIT falls back on numerical comparisons when it does not
recognize a prediction
https://bugs.webkit.org/show_bug.cgi?id=68977
Reviewed by Geoffrey Garen.
This fixes both the way comparison implementations are selected. It
also fixes a bug where comparisons other than equality (like < or >)
on objects are compiled as if the comparison was equality.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
- 5:45 PM Changeset in webkit [96279] by
-
- 2 edits in trunk/Source/WebKit/mac
ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=69037
Reviewed by Alexey Proskuryakov.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runOpenPanel):
If no delegate is implemented, dismiss the listener
with a cancel. It expects some action.
- 5:45 PM Changeset in webkit [96278] by
-
- 6 edits in trunk
fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
https://bugs.webkit.org/show_bug.cgi?id=68815
Source/WebCore:
Reviewed by Dan Bernstein.
FrameView::scrollElementToRect() was incorrectly using Element::boundsInWindowSpace(),
which is window-relative (not web view-relative), and has flipped coordinates
in WebKit1.
Change to use Node::getRect() which is what the author intended.
- dom/Element.h:
- page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect):
LayoutTests:
Reviewed by Dan Bernstein.
Fix these tests to not throw errors when window.internals is not available.
- fast/dom/scroll-element-to-rect-centered.html:
- fast/dom/scroll-element-to-rect.html:
- 5:32 PM Changeset in webkit [96277] by
-
- 1 edit1 copy in trunk/LayoutTests
Qt rebsaeline after r96257. It seems like the difference is coming from the font used in select element.
- platform/qt/editing/pasteboard/select-element-1-expected.txt: Copied from
LayoutTests/editing/pasteboard/select-element-1-expected.txt.
- 5:29 PM Changeset in webkit [96276] by
-
- 5 edits10 adds in trunk
Don't clamp cubic-bezier timing functions between 0 and 1
https://bugs.webkit.org/show_bug.cgi?id=45761
Source/WebCore:
Remove the limitation of clamping the cubic-bezier timing function
values between 0 and 1, following the specification change made on
April 5 of this year.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.
Tests: transitions/cubic-bezier-overflow-color.html
transitions/cubic-bezier-overflow-length.html
transitions/cubic-bezier-overflow-shadow.html
transitions/cubic-bezier-overflow-svg-length.html
transitions/cubic-bezier-overflow-transform.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
LayoutTests:
Test overflow behavior of colors, lengths, svg lengths,
shadows and transforms (through rotations). Update the
timing function test to check for now valid values.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.
- fast/css/transition-timing-function-expected.txt:
- fast/css/transition-timing-function.html:
- transitions/cubic-bezier-overflow-color-expected.txt: Added.
- transitions/cubic-bezier-overflow-color.html: Added.
- transitions/cubic-bezier-overflow-length-expected.txt: Added.
- transitions/cubic-bezier-overflow-length.html: Added.
- transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
- transitions/cubic-bezier-overflow-shadow.html: Added.
- transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
- transitions/cubic-bezier-overflow-svg-length.html: Added.
- transitions/cubic-bezier-overflow-transform-expected.txt: Added.
- transitions/cubic-bezier-overflow-transform.html: Added.
- 5:24 PM Changeset in webkit [96275] by
-
- 10 edits in trunk/LayoutTests
More GTK rebaselines after r96257.
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/gtk/editing/deleting/delete-line-005-expected.txt:
- platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/gtk/editing/deleting/regional-indicators-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- 5:21 PM Changeset in webkit [96274] by
-
- 2 edits in trunk/LayoutTests
Remove Chromium failing expectations for tests that now pass.
- platform/chromium/test_expectations.txt:
- 5:20 PM Changeset in webkit [96273] by
-
- 283 edits1 add4 deletes in trunk/LayoutTests
Chromium rebaseline for r96257 part 1.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Removed.
- platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
- platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
- platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-linux/editing/execCommand/paste-1-expected.png:
- platform/chromium-linux/editing/execCommand/paste-2-expected.png:
- platform/chromium-linux/editing/inserting/4278698-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-linux/editing/pasteboard/3976872-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-linux/editing/pasteboard/4076267-expected.png:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-linux/editing/selection/node-removal-1-expected.png:
- platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
- platform/chromium-linux/editing/undo/4063751-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png:
- platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-mac/editing/execCommand/paste-1-expected.png:
- platform/chromium-mac/editing/execCommand/paste-2-expected.png:
- platform/chromium-mac/editing/inserting/4278698-expected.png:
- platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-mac/editing/pasteboard/3976872-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-mac/editing/pasteboard/4076267-expected.png:
- platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-mac/editing/selection/node-removal-1-expected.png:
- platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
- platform/chromium-mac/editing/undo/4063751-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win-xp/editing/pasteboard: Removed.
- platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3775172-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3857753-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3865854-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3928305-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt:
- platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
- platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-contents-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/chromium-win/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-first-list-item-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-image-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-003-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-006-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-007-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-008-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-009-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-010-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-013-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-014-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-015-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-016-expected.txt:
- platform/chromium-win/editing/deleting/delete-line-017-expected.txt:
- platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-listitem-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/chromium-win/editing/deleting/forward-delete-expected.txt:
- platform/chromium-win/editing/deleting/list-item-1-expected.txt:
- platform/chromium-win/editing/deleting/merge-different-styles-expected.txt:
- platform/chromium-win/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
- platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
- platform/chromium-win/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/editing/deleting/table-cells-expected.txt:
- platform/chromium-win/editing/execCommand/4641880-1-expected.txt:
- platform/chromium-win/editing/execCommand/4641880-2-expected.txt:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
- platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
- platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
- platform/chromium-win/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/chromium-win/editing/execCommand/indent-list-item-expected.txt:
- platform/chromium-win/editing/execCommand/indent-selection-expected.txt:
- platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/chromium-win/editing/execCommand/nsresponder-indent-expected.txt:
- platform/chromium-win/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/chromium-win/editing/execCommand/paste-1-expected.png:
- platform/chromium-win/editing/execCommand/paste-1-expected.txt:
- platform/chromium-win/editing/execCommand/paste-2-expected.png:
- platform/chromium-win/editing/execCommand/paste-2-expected.txt:
- platform/chromium-win/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/chromium-win/editing/execCommand/remove-list-item-1-expected.txt:
- platform/chromium-win/editing/inserting/4278698-expected.png:
- platform/chromium-win/editing/inserting/4278698-expected.txt:
- platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
- platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-3775316-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-3851164-fix-expected.txt:
- platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-at-end-01-expected.txt:
- platform/chromium-win/editing/inserting/insert-at-end-02-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-005-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-001-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-002-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-005-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-007-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-009-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-010-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-020-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-023-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-025-expected.txt:
- platform/chromium-win/editing/inserting/insert-div-026-expected.txt:
- platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
- platform/chromium-win/editing/inserting/paragraph-separator-03-expected.txt:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/chromium-win/editing/inserting/redo-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/chromium-win/editing/inserting/typing-001-expected.txt:
- platform/chromium-win/editing/inserting/typing-002-expected.txt:
- platform/chromium-win/editing/inserting/typing-003-expected.txt:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
- platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
- platform/chromium-win/editing/pasteboard/3976872-expected.png:
- platform/chromium-win/editing/pasteboard/3976872-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
- platform/chromium-win/editing/pasteboard/4076267-expected.png:
- platform/chromium-win/editing/pasteboard/4076267-expected.txt:
- platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
- platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
- platform/chromium-win/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
- platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/chromium-win/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/chromium-win/editing/selection/node-removal-1-expected.png:
- platform/chromium-win/editing/selection/node-removal-1-expected.txt:
- platform/chromium-win/editing/selection/node-removal-2-expected.txt:
- platform/chromium-win/editing/selection/replace-selection-1-expected.txt:
- platform/chromium-win/editing/selection/select-all-iframe-expected.png:
- platform/chromium-win/editing/selection/select-all-iframe-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-001-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-002-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-003-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-004-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-007-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-009-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-010-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-011-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-012-expected.txt:
- platform/chromium-win/editing/style/create-block-for-style-013-expected.txt:
- platform/chromium-win/editing/style/designmode-expected.txt:
- platform/chromium-win/editing/style/relative-font-size-change-001-expected.txt:
- platform/chromium-win/editing/style/relative-font-size-change-002-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-001-expected.txt:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
- platform/chromium-win/editing/style/smoosh-styles-003-expected.txt:
- platform/chromium-win/editing/style/style-3998892-fix-expected.txt:
- platform/chromium-win/editing/style/style-boundary-001-expected.txt:
- platform/chromium-win/editing/style/style-boundary-004-expected.txt:
- platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
- platform/chromium-win/editing/undo/4063751-expected.png:
- platform/chromium-win/editing/undo/4063751-expected.txt:
- platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
- platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
- platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
- platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-delete-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-delete-003-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
- platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-001-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-002-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-delete-003-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
- platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
- platform/chromium-win/fast/dynamic/move-node-with-selection-expected.txt:
- platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
- platform/gtk/editing/deleting/delete-br-010-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-div-010-expected.txt: Removed.
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Removed.
- platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
- 5:09 PM Changeset in webkit [96272] by
-
- 16 edits in trunk
Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
https://bugs.webkit.org/show_bug.cgi?id=67253
Reviewed by Eric Seidel.
Tools:
Nearly all of the work in this was done by Simon Fraser; I'm
just repackaging it and cleaning it up a bit. This change
modifies port.diff_image() to return a tuple of (pass/fail,
%age), adds the value to the FailureImageHashMismatch, and
writes the value into the full_results.json files to be
displayed in the results page.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/models/test_failures.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
LayoutTests:
- fast/harness/resources/results-test.js:
(mockExpectation):
(runDefaultSingleRowTest):
():
- fast/harness/results.html:
- 5:09 PM Changeset in webkit [96271] by
-
- 2 edits in trunk/Source/WebKit2
WinCairo build fix.
- WebProcess/WebPage/WebFrame.h: Add include of <wtc/RetainPtr.h>
- 5:06 PM Changeset in webkit [96270] by
-
- 4 edits3 adds in trunk
DelayNode must set the context on delayTime AudioParam to support automation
https://bugs.webkit.org/show_bug.cgi?id=68828
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/delaynode-scheduling.html
- webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
LayoutTests:
- webaudio/delaynode-scheduling-expected.txt: Added.
- webaudio/delaynode-scheduling.html: Added.
- webaudio/delaynode.html:
- webaudio/resources/delay-testing.js: Added.
(createToneBuffer):
(checkDelayedResult.return.var):
(checkDelayedResult):
- 5:02 PM Changeset in webkit [96269] by
-
- 3 edits in trunk/LayoutTests
More Mac rebaselines for r96257.
- platform/mac/editing/execCommand/insertHorizontalRule-expected.png:
- platform/mac/editing/selection/node-removal-1-expected.png:
- 5:00 PM Changeset in webkit [96268] by
-
- 2 edits in trunk/Tools
Add myself to committers.py
- 4:56 PM Changeset in webkit [96267] by
-
- 2 edits in trunk/LayoutTests
Add failing Chromium expectations after r96257.
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [96266] by
-
- 245 edits in trunk/LayoutTests
GTK rebaseline for r96257.
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/gtk/editing/deleting/delete-br-008-expected.txt:
- platform/gtk/editing/deleting/delete-br-010-expected.txt:
- platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-first-list-item-expected.txt:
- platform/gtk/editing/deleting/delete-image-001-expected.txt:
- platform/gtk/editing/deleting/delete-image-002-expected.txt:
- platform/gtk/editing/deleting/delete-image-003-expected.txt:
- platform/gtk/editing/deleting/delete-image-004-expected.txt:
- platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-002-expected.txt:
- platform/gtk/editing/deleting/delete-line-003-expected.txt:
- platform/gtk/editing/deleting/delete-line-004-expected.txt:
- platform/gtk/editing/deleting/delete-line-005-expected.txt:
- platform/gtk/editing/deleting/delete-line-006-expected.txt:
- platform/gtk/editing/deleting/delete-line-007-expected.txt:
- platform/gtk/editing/deleting/delete-line-008-expected.txt:
- platform/gtk/editing/deleting/delete-line-009-expected.txt:
- platform/gtk/editing/deleting/delete-line-010-expected.txt:
- platform/gtk/editing/deleting/delete-line-011-expected.txt:
- platform/gtk/editing/deleting/delete-line-012-expected.txt:
- platform/gtk/editing/deleting/delete-line-013-expected.txt:
- platform/gtk/editing/deleting/delete-line-014-expected.txt:
- platform/gtk/editing/deleting/delete-line-015-expected.txt:
- platform/gtk/editing/deleting/delete-line-016-expected.txt:
- platform/gtk/editing/deleting/delete-line-017-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
- platform/gtk/editing/deleting/delete-selection-001-expected.txt:
- platform/gtk/editing/deleting/delete-tab-001-expected.txt:
- platform/gtk/editing/deleting/delete-tab-002-expected.txt:
- platform/gtk/editing/deleting/delete-tab-003-expected.txt:
- platform/gtk/editing/deleting/delete-tab-004-expected.txt:
- platform/gtk/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/gtk/editing/deleting/forward-delete-expected.txt:
- platform/gtk/editing/deleting/list-item-1-expected.txt:
- platform/gtk/editing/deleting/merge-different-styles-expected.txt:
- platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/gtk/editing/deleting/merge-no-br-expected.txt:
- platform/gtk/editing/deleting/non-smart-delete-expected.txt:
- platform/gtk/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/gtk/editing/deleting/smart-delete-001-expected.txt:
- platform/gtk/editing/deleting/smart-delete-002-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt:
- platform/gtk/editing/execCommand/4641880-2-expected.txt:
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
- platform/gtk/editing/execCommand/find-after-replace-expected.txt:
- platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/gtk/editing/execCommand/indent-list-item-expected.txt:
- platform/gtk/editing/execCommand/indent-selection-expected.txt:
- platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/gtk/editing/execCommand/nsresponder-indent-expected.txt:
- platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/gtk/editing/execCommand/paste-1-expected.txt:
- platform/gtk/editing/execCommand/paste-2-expected.txt:
- platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/gtk/editing/execCommand/remove-list-item-1-expected.txt:
- platform/gtk/editing/inserting/4278698-expected.txt:
- platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- platform/gtk/editing/inserting/insert-br-001-expected.txt:
- platform/gtk/editing/inserting/insert-br-003-expected.txt:
- platform/gtk/editing/inserting/insert-br-005-expected.txt:
- platform/gtk/editing/inserting/insert-br-006-expected.txt:
- platform/gtk/editing/inserting/insert-br-007-expected.txt:
- platform/gtk/editing/inserting/insert-br-008-expected.txt:
- platform/gtk/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/gtk/editing/inserting/insert-div-001-expected.txt:
- platform/gtk/editing/inserting/insert-div-002-expected.txt:
- platform/gtk/editing/inserting/insert-div-003-expected.txt:
- platform/gtk/editing/inserting/insert-div-005-expected.txt:
- platform/gtk/editing/inserting/insert-div-006-expected.txt:
- platform/gtk/editing/inserting/insert-div-007-expected.txt:
- platform/gtk/editing/inserting/insert-div-008-expected.txt:
- platform/gtk/editing/inserting/insert-div-009-expected.txt:
- platform/gtk/editing/inserting/insert-div-010-expected.txt:
- platform/gtk/editing/inserting/insert-div-020-expected.txt:
- platform/gtk/editing/inserting/insert-div-023-expected.txt:
- platform/gtk/editing/inserting/insert-div-024-expected.txt:
- platform/gtk/editing/inserting/insert-div-025-expected.txt:
- platform/gtk/editing/inserting/insert-div-026-expected.txt:
- platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/gtk/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/gtk/editing/inserting/multiple-lines-selected-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-03-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/gtk/editing/inserting/redo-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/gtk/editing/inserting/typing-001-expected.txt:
- platform/gtk/editing/inserting/typing-002-expected.txt:
- platform/gtk/editing/inserting/typing-003-expected.txt:
- platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
- platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
- platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt:
- platform/gtk/editing/pasteboard/3976872-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/pasteboard/bad-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
- platform/gtk/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
- platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-cells-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-016-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-019-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/pasting-object-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
- platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/gtk/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/gtk/editing/selection/node-removal-1-expected.txt:
- platform/gtk/editing/selection/node-removal-2-expected.txt:
- platform/gtk/editing/selection/replace-selection-1-expected.txt:
- platform/gtk/editing/selection/select-all-iframe-expected.txt:
- platform/gtk/editing/spelling/spelling-expected.txt:
- platform/gtk/editing/style/create-block-for-style-001-expected.txt:
- platform/gtk/editing/style/create-block-for-style-002-expected.txt:
- platform/gtk/editing/style/create-block-for-style-003-expected.txt:
- platform/gtk/editing/style/create-block-for-style-004-expected.txt:
- platform/gtk/editing/style/create-block-for-style-007-expected.txt:
- platform/gtk/editing/style/create-block-for-style-009-expected.txt:
- platform/gtk/editing/style/create-block-for-style-010-expected.txt:
- platform/gtk/editing/style/create-block-for-style-011-expected.txt:
- platform/gtk/editing/style/create-block-for-style-012-expected.txt:
- platform/gtk/editing/style/create-block-for-style-013-expected.txt:
- platform/gtk/editing/style/designmode-expected.txt:
- platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
- platform/gtk/editing/style/relative-font-size-change-002-expected.txt:
- platform/gtk/editing/style/smoosh-styles-001-expected.txt:
- platform/gtk/editing/style/smoosh-styles-003-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
- platform/gtk/editing/style/style-3998892-fix-expected.txt:
- platform/gtk/editing/style/style-boundary-001-expected.txt:
- platform/gtk/editing/style/style-boundary-002-expected.txt:
- platform/gtk/editing/style/style-boundary-003-expected.txt:
- platform/gtk/editing/style/style-boundary-004-expected.txt:
- platform/gtk/editing/style/style-boundary-005-expected.txt:
- platform/gtk/editing/style/typing-style-001-expected.txt:
- platform/gtk/editing/style/typing-style-002-expected.txt:
- platform/gtk/editing/style/unbold-in-bold-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/undo/undo-misspellings-expected.txt:
- platform/gtk/editing/undo/undo-typing-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/table-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/table-type-before-expected.txt:
- platform/gtk/fast/dynamic/move-node-with-selection-expected.txt:
- platform/gtk/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/fast/repaint/selection-clear-expected.txt:
- platform/gtk/svg/custom/use-clipped-hit-expected.txt:
- 3:25 PM Changeset in webkit [96265] by
-
- 4 edits in trunk/Tools
garden-o-matic shouldn't depend on test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=69019
Reviewed by Dimitri Glazkov.
This patch moves garden-o-matic from getting full_results.json from
test-results.appspot.com to getting that information directly from the
buildbot. This patch improve the load time and accuracy of
garden-o-matic because test-results.appspot.com is slow and is dropping
a significant number of writes (see
https://bugs.webkit.org/show_bug.cgi?id=68748).
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- 3:05 PM Changeset in webkit [96264] by
-
- 263 edits in trunk/LayoutTests
Mac rebaseline for r96257.
Also fixed editing/deleting/regional-indicators.html as done in the original patch.
(The fix was included in the original patch but webkit-patch could not apply because of some exotic characters in the test.)
- editing/deleting/delete-ligature-001-expected.txt:
- editing/deleting/regional-indicators.html:
- editing/pasteboard/interchange-newline-2-expected.txt:
- editing/pasteboard/paste-4039777-fix-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- fast/events/5056619-expected.txt:
- platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
- platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
- platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
- platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
- platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
- platform/mac/editing/deleting/delete-3865854-fix-expected.txt:
- platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
- platform/mac/editing/deleting/delete-3959464-fix-expected.txt:
- platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- platform/mac/editing/deleting/delete-and-undo-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-002-expected.txt:
- platform/mac/editing/deleting/delete-block-contents-003-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/mac/editing/deleting/delete-br-008-expected.txt:
- platform/mac/editing/deleting/delete-br-010-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-first-list-item-expected.txt:
- platform/mac/editing/deleting/delete-image-001-expected.txt:
- platform/mac/editing/deleting/delete-image-002-expected.txt:
- platform/mac/editing/deleting/delete-image-003-expected.txt:
- platform/mac/editing/deleting/delete-image-004-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-001-expected.txt:
- platform/mac/editing/deleting/delete-line-002-expected.txt:
- platform/mac/editing/deleting/delete-line-003-expected.txt:
- platform/mac/editing/deleting/delete-line-004-expected.txt:
- platform/mac/editing/deleting/delete-line-005-expected.txt:
- platform/mac/editing/deleting/delete-line-006-expected.txt:
- platform/mac/editing/deleting/delete-line-007-expected.txt:
- platform/mac/editing/deleting/delete-line-008-expected.txt:
- platform/mac/editing/deleting/delete-line-009-expected.txt:
- platform/mac/editing/deleting/delete-line-010-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/deleting/delete-line-012-expected.txt:
- platform/mac/editing/deleting/delete-line-013-expected.txt:
- platform/mac/editing/deleting/delete-line-014-expected.txt:
- platform/mac/editing/deleting/delete-line-015-expected.txt:
- platform/mac/editing/deleting/delete-line-016-expected.txt:
- platform/mac/editing/deleting/delete-line-017-expected.txt:
- platform/mac/editing/deleting/delete-listitem-001-expected.txt:
- platform/mac/editing/deleting/delete-listitem-002-expected.txt:
- platform/mac/editing/deleting/delete-selection-001-expected.txt:
- platform/mac/editing/deleting/delete-tab-001-expected.txt:
- platform/mac/editing/deleting/delete-tab-002-expected.txt:
- platform/mac/editing/deleting/delete-tab-003-expected.txt:
- platform/mac/editing/deleting/delete-tab-004-expected.txt:
- platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/mac/editing/deleting/forward-delete-expected.txt:
- platform/mac/editing/deleting/list-item-1-expected.txt:
- platform/mac/editing/deleting/merge-different-styles-expected.txt:
- platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/mac/editing/deleting/merge-no-br-expected.txt:
- platform/mac/editing/deleting/non-smart-delete-expected.txt:
- platform/mac/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/mac/editing/deleting/smart-delete-001-expected.txt:
- platform/mac/editing/deleting/smart-delete-002-expected.txt:
- platform/mac/editing/deleting/smart-delete-003-expected.txt:
- platform/mac/editing/deleting/smart-delete-004-expected.txt:
- platform/mac/editing/deleting/table-cells-expected.txt:
- platform/mac/editing/execCommand/4641880-1-expected.txt:
- platform/mac/editing/execCommand/4641880-2-expected.txt:
- platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
- platform/mac/editing/execCommand/find-after-replace-expected.txt:
- platform/mac/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/mac/editing/execCommand/indent-list-item-expected.txt:
- platform/mac/editing/execCommand/indent-selection-expected.txt:
- platform/mac/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/mac/editing/execCommand/nsresponder-indent-expected.txt:
- platform/mac/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/mac/editing/execCommand/remove-list-item-1-expected.txt:
- platform/mac/editing/input/5576619-expected.txt:
- platform/mac/editing/input/emacs-ctrl-o-expected.txt:
- platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
- platform/mac/editing/input/text-input-controller-expected.txt:
- platform/mac/editing/inserting/4278698-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
- platform/mac/editing/inserting/insert-3775316-fix-expected.txt:
- platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
- platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
- platform/mac/editing/inserting/insert-at-end-01-expected.txt:
- platform/mac/editing/inserting/insert-at-end-02-expected.txt:
- platform/mac/editing/inserting/insert-br-001-expected.txt:
- platform/mac/editing/inserting/insert-br-003-expected.txt:
- platform/mac/editing/inserting/insert-br-005-expected.txt:
- platform/mac/editing/inserting/insert-br-006-expected.txt:
- platform/mac/editing/inserting/insert-br-007-expected.txt:
- platform/mac/editing/inserting/insert-br-008-expected.txt:
- platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/mac/editing/inserting/insert-div-001-expected.txt:
- platform/mac/editing/inserting/insert-div-002-expected.txt:
- platform/mac/editing/inserting/insert-div-003-expected.txt:
- platform/mac/editing/inserting/insert-div-005-expected.txt:
- platform/mac/editing/inserting/insert-div-006-expected.txt:
- platform/mac/editing/inserting/insert-div-007-expected.txt:
- platform/mac/editing/inserting/insert-div-008-expected.txt:
- platform/mac/editing/inserting/insert-div-009-expected.txt:
- platform/mac/editing/inserting/insert-div-010-expected.txt:
- platform/mac/editing/inserting/insert-div-020-expected.txt:
- platform/mac/editing/inserting/insert-div-023-expected.txt:
- platform/mac/editing/inserting/insert-div-024-expected.txt:
- platform/mac/editing/inserting/insert-div-025-expected.txt:
- platform/mac/editing/inserting/insert-div-026-expected.txt:
- platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/mac/editing/inserting/redo-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/mac/editing/inserting/typing-001-expected.txt:
- platform/mac/editing/inserting/typing-002-expected.txt:
- platform/mac/editing/inserting/typing-003-expected.txt:
- platform/mac/editing/inserting/typing-around-br-001-expected.txt:
- platform/mac/editing/inserting/typing-around-image-001-expected.txt:
- platform/mac/editing/inserting/typing-at-end-of-line-expected.txt:
- platform/mac/editing/pasteboard/3976872-expected.txt:
- platform/mac/editing/pasteboard/4076267-2-expected.txt:
- platform/mac/editing/pasteboard/4076267-3-expected.txt:
- platform/mac/editing/pasteboard/4076267-expected.txt:
- platform/mac/editing/pasteboard/8145-3-expected.txt:
- platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
- platform/mac/editing/pasteboard/cut-text-001-expected.txt:
- platform/mac/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/mac/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/mac/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/mac/editing/pasteboard/paste-table-003-expected.txt:
- platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
- platform/mac/editing/pasteboard/paste-text-004-expected.txt:
- platform/mac/editing/pasteboard/paste-text-005-expected.txt:
- platform/mac/editing/pasteboard/paste-text-006-expected.txt:
- platform/mac/editing/pasteboard/paste-text-007-expected.txt:
- platform/mac/editing/pasteboard/paste-text-008-expected.txt:
- platform/mac/editing/pasteboard/paste-text-016-expected.txt:
- platform/mac/editing/pasteboard/paste-text-019-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/pasteboard/pasting-object-expected.txt:
- platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
- platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/mac/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/mac/editing/selection/node-removal-1-expected.txt:
- platform/mac/editing/selection/node-removal-2-expected.txt:
- platform/mac/editing/selection/replace-selection-1-expected.txt:
- platform/mac/editing/selection/select-all-iframe-expected.txt:
- platform/mac/editing/spelling/spelling-expected.txt:
- platform/mac/editing/style/create-block-for-style-001-expected.txt:
- platform/mac/editing/style/create-block-for-style-002-expected.txt:
- platform/mac/editing/style/create-block-for-style-003-expected.txt:
- platform/mac/editing/style/create-block-for-style-004-expected.txt:
- platform/mac/editing/style/create-block-for-style-007-expected.txt:
- platform/mac/editing/style/create-block-for-style-009-expected.txt:
- platform/mac/editing/style/create-block-for-style-010-expected.txt:
- platform/mac/editing/style/create-block-for-style-011-expected.txt:
- platform/mac/editing/style/create-block-for-style-012-expected.txt:
- platform/mac/editing/style/create-block-for-style-013-expected.txt:
- platform/mac/editing/style/designmode-expected.txt:
- platform/mac/editing/style/relative-font-size-change-001-expected.txt:
- platform/mac/editing/style/relative-font-size-change-002-expected.txt:
- platform/mac/editing/style/smoosh-styles-001-expected.txt:
- platform/mac/editing/style/smoosh-styles-003-expected.txt:
- platform/mac/editing/style/style-3681552-fix-001-expected.txt:
- platform/mac/editing/style/style-3681552-fix-002-expected.txt:
- platform/mac/editing/style/style-3998892-fix-expected.txt:
- platform/mac/editing/style/style-boundary-001-expected.txt:
- platform/mac/editing/style/style-boundary-002-expected.txt:
- platform/mac/editing/style/style-boundary-003-expected.txt:
- platform/mac/editing/style/style-boundary-004-expected.txt:
- platform/mac/editing/style/style-boundary-005-expected.txt:
- platform/mac/editing/style/typing-style-001-expected.txt:
- platform/mac/editing/style/typing-style-002-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- platform/mac/editing/undo/4063751-expected.txt:
- platform/mac/editing/undo/redo-typing-001-expected.txt:
- platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-combined-delete-expected.txt:
- platform/mac/editing/undo/undo-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-delete-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-expected.txt:
- platform/mac/editing/undo/undo-misspellings-expected.txt:
- platform/mac/editing/undo/undo-typing-001-expected.txt:
- platform/mac/editing/unsupported-content/list-delete-001-expected.txt:
- platform/mac/editing/unsupported-content/list-delete-003-expected.txt:
- platform/mac/editing/unsupported-content/list-type-after-expected.txt:
- platform/mac/editing/unsupported-content/list-type-before-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-002-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
- platform/mac/editing/unsupported-content/table-type-after-expected.txt:
- platform/mac/editing/unsupported-content/table-type-before-expected.txt:
- platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
- platform/mac/fast/repaint/selection-clear-expected.txt:
- platform/mac/svg/custom/use-clipped-hit-expected.txt:
- 2:58 PM Changeset in webkit [96263] by
-
- 2 edits4 adds in trunk/Tools
watchlist: Add a way to load the watchlist from config.
https://bugs.webkit.org/show_bug.cgi?id=68991
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/watchlist: Added.
- Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
Support for loading the watch list.
- Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
Tests for the loading.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
Adjusted to use the common base class.
- Scripts/webkitpy/common/webkitunittest.py: Added.
Made a common base class for functionality used in more than one.
- 2:30 PM Changeset in webkit [96262] by
-
- 2 edits in trunk/Tools
Attempt fix for Leopard python unit test run.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 2:02 PM Changeset in webkit [96261] by
-
- 2 edits in branches/chromium/874/Source/WebKit/chromium
Merge 95861 - occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.
Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/8072009
- 2:01 PM Changeset in webkit [96260] by
-
- 5 edits3 adds in trunk
JavaScript generated documents don't inherit the cookie URL
https://bugs.webkit.org/show_bug.cgi?id=69003
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/cookies/cookie-theft-with-javascript-doc.html
- dom/Document.h:
(WebCore::Document::setCookieURL):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h:
LayoutTests:
- http/tests/security/cookies/cookie-theft-with-javascript-doc-expected.txt: Added.
- http/tests/security/cookies/cookie-theft-with-javascript-doc.html: Added.
- http/tests/security/cookies/resources/innocent-victim-with-cookies.html: Added.
- 1:59 PM Changeset in webkit [96259] by
-
- 3 edits in trunk/Source/JavaScriptCore
Implement callOperation(D_DFGOperation_DD) for DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=69026
Reviewed by Sam Weinig.
- assembler/X86Assembler.h:
(JSC::X86Assembler::fstpl):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- 1:55 PM Changeset in webkit [96258] by
-
- 6 edits2 adds in trunk
REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=68938
Source/WebCore:
Reviewed by David Hyatt.
Test: all svg tests in LayoutTests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths): Added a null-check for containingBlock.
Tools:
Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
Reviewed by David Hyatt.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didUpdateLayout): Added width/height queries.
- DumpRenderTree/chromium/WebViewHost.h: Updated defs.
LayoutTests:
Reviewed by David Hyatt.
- fast/frames/flattening/crash-svg-document-expected.txt: Added.
- fast/frames/flattening/crash-svg-document.html: Added.
- 1:51 PM QtWebKitRelease22 edited by
- (diff)
- 1:51 PM Changeset in webkit [96257] by
-
- 330 edits4 adds in trunk
Setting innerText to an empty string on editable div loses focus
https://bugs.webkit.org/show_bug.cgi?id=62092
Patch by Una Sabovic <una.sabovic@palm.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Source/WebCore:
When selection start or end node is being deleted do not clear the selection.
Instead update the start/end position to an equivalent parent-anchored positions.
When text is inserted/deleted update selection per range modification spec:
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation
Tests: editing/selection/document-mutation.html
editing/selection/editable-div-clear-on-keydown.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):
- editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval):
LayoutTests:
Added test to make sure that caret is still present in a focused editable div after its text is deleted.
Updated editing tests to not expect that deleting selection start or end node will clear the selection.
Added test to exercise range modification examples from
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Mutation
- editing/deleting/5546763-expected.txt:
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-br-011-expected.txt:
- editing/deleting/delete-by-word-001-expected.txt:
- editing/deleting/delete-by-word-002-expected.txt:
- editing/deleting/delete-cell-contents-expected.txt:
- editing/deleting/delete-ligature-002-expected.txt:
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-select-all-002-expected.txt:
- editing/deleting/delete-select-all-003-expected.txt:
- editing/deleting/delete-to-end-of-paragraph-expected.txt:
- editing/deleting/merge-paragraph-into-blockquote-expected.txt:
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/pruning-after-merge-1-expected.txt:
- editing/deleting/skip-virama-001-expected.txt:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/execCommand/4920488-expected.txt:
- editing/execCommand/crash-indenting-list-item-expected.txt:
- editing/execCommand/createLink-expected.txt:
- editing/execCommand/format-block-expected.txt:
- editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt:
- editing/execCommand/format-block-with-braces-expected.txt:
- editing/execCommand/hilitecolor-expected.txt:
- editing/execCommand/indent-nested-lists-1-expected.txt:
- editing/execCommand/indent-nested-lists-2-expected.txt:
- editing/execCommand/indent-nested-lists-3-expected.txt:
- editing/execCommand/indent-nested-lists-4-expected.txt:
- editing/execCommand/indent-nested-lists-5-expected.txt:
- editing/execCommand/indent-nested-lists-6-expected.txt:
- editing/execCommand/indent-nested-lists-7-expected.txt:
- editing/execCommand/indent-paragraphs-expected.txt:
- editing/execCommand/indent-with-style-expected.txt:
- editing/execCommand/insertHTML-expected.txt:
- editing/execCommand/outdent-nested-lists-1-expected.txt:
- editing/execCommand/outdent-nested-lists-2-expected.txt:
- editing/execCommand/outdent-nested-lists-3-expected.txt:
- editing/execCommand/outdent-nested-lists-4-expected.txt:
- editing/execCommand/queryCommandState-01-expected.txt:
- editing/execCommand/remove-formatting-2-expected.txt:
- editing/execCommand/remove-formatting-expected.txt:
- editing/execCommand/remove-list-1-expected.txt:
- editing/execCommand/remove-list-items-expected.txt:
- editing/execCommand/switch-list-type-expected.txt:
- editing/execCommand/unlink-expected.txt:
- editing/inserting/insert-3786362-fix-expected.txt:
- editing/inserting/insert-div-021-expected.txt:
- editing/inserting/insert-paragraph-at-end-of-line-expected.txt:
- editing/inserting/insert-thai-characters-001-expected.txt:
- editing/pasteboard/4242293-1-expected.txt:
- editing/pasteboard/5065605-expected.txt:
- editing/pasteboard/block-wrappers-necessary-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
- editing/pasteboard/insert-div-text-into-text-expected.txt:
- editing/pasteboard/interchange-newline-1-expected.txt:
- editing/pasteboard/interchange-newline-3-expected.txt:
- editing/pasteboard/interchange-newline-4-expected.txt:
- editing/pasteboard/merge-end-2-expected.txt:
- editing/pasteboard/merge-end-3-expected.txt:
- editing/pasteboard/merge-end-4-expected.txt:
- editing/pasteboard/merge-end-5-expected.txt:
- editing/pasteboard/merge-end-list-2-expected.txt:
- editing/pasteboard/merge-end-list-expected.txt:
- editing/pasteboard/merge-end-table-2-expected.txt:
- editing/pasteboard/merge-end-table-expected.txt:
- editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- editing/pasteboard/paste-into-anchor-text-expected.txt:
- editing/pasteboard/paste-list-001-expected.txt:
- editing/pasteboard/paste-table-001-expected.txt:
- editing/pasteboard/paste-table-002-expected.txt:
- editing/pasteboard/paste-text-001-expected.txt:
- editing/pasteboard/paste-text-002-expected.txt:
- editing/pasteboard/paste-text-003-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- editing/pasteboard/paste-text-017-expected.txt:
- editing/pasteboard/paste-text-018-expected.txt:
- editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
- editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
- editing/pasteboard/paste-text-with-style-expected.txt:
- editing/pasteboard/prevent-block-nesting-01-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- editing/pasteboard/smart-paste-003-expected.txt:
- editing/pasteboard/smart-paste-004-expected.txt:
- editing/pasteboard/smart-paste-005-expected.txt:
- editing/pasteboard/smart-paste-006-expected.txt:
- editing/selection/5497643-expected.txt:
- editing/selection/5497643.html:
- editing/selection/character-data-mutation-expected.txt:
- editing/selection/character-data-mutation.html:
- editing/selection/document-mutation-expected.txt: Added.
- editing/selection/document-mutation.html: Added.
- editing/selection/editable-div-clear-on-keydown-expected.txt: Added.
- editing/selection/editable-div-clear-on-keydown.html: Added.
- editing/selection/regional-indicators.html:
- editing/style/remove-underline-from-stylesheet-expected.txt:
- editing/style/typing-style-003-expected.txt:
- editing/undo/redo-style-expected.txt:
- editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:
- editing/undo/undo-indent-expected.txt:
- platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html:
- platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608462-fix-expected.txt:
- platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
- platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
- platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
- platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
- platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
- platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/qt/editing/deleting/delete-and-undo-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/qt/editing/deleting/delete-br-008-expected.txt:
- platform/qt/editing/deleting/delete-br-010-expected.txt:
- platform/qt/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-first-list-item-expected.txt:
- platform/qt/editing/deleting/delete-image-001-expected.txt:
- platform/qt/editing/deleting/delete-image-002-expected.txt:
- platform/qt/editing/deleting/delete-image-003-expected.txt:
- platform/qt/editing/deleting/delete-image-004-expected.txt:
- platform/qt/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-line-001-expected.txt:
- platform/qt/editing/deleting/delete-line-002-expected.txt:
- platform/qt/editing/deleting/delete-line-003-expected.txt:
- platform/qt/editing/deleting/delete-line-004-expected.txt:
- platform/qt/editing/deleting/delete-line-005-expected.txt:
- platform/qt/editing/deleting/delete-line-006-expected.txt:
- platform/qt/editing/deleting/delete-line-007-expected.txt:
- platform/qt/editing/deleting/delete-line-008-expected.txt:
- platform/qt/editing/deleting/delete-line-009-expected.txt:
- platform/qt/editing/deleting/delete-line-010-expected.txt:
- platform/qt/editing/deleting/delete-line-012-expected.txt:
- platform/qt/editing/deleting/delete-line-013-expected.txt:
- platform/qt/editing/deleting/delete-line-014-expected.txt:
- platform/qt/editing/deleting/delete-line-015-expected.txt:
- platform/qt/editing/deleting/delete-line-016-expected.txt:
- platform/qt/editing/deleting/delete-line-017-expected.txt:
- platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-listitem-001-expected.txt:
- platform/qt/editing/deleting/delete-listitem-002-expected.txt:
- platform/qt/editing/deleting/delete-selection-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/qt/editing/deleting/forward-delete-expected.txt:
- platform/qt/editing/deleting/list-item-1-expected.txt:
- platform/qt/editing/deleting/merge-different-styles-expected.txt:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/qt/editing/deleting/merge-no-br-expected.txt:
- platform/qt/editing/deleting/non-smart-delete-expected.txt:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/qt/editing/deleting/smart-delete-001-expected.txt:
- platform/qt/editing/deleting/smart-delete-003-expected.txt:
- platform/qt/editing/deleting/smart-delete-004-expected.txt:
- platform/qt/editing/deleting/table-cells-expected.txt:
- platform/qt/editing/execCommand/4641880-1-expected.txt:
- platform/qt/editing/execCommand/4641880-2-expected.txt:
- platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
- platform/qt/editing/execCommand/find-after-replace-expected.txt:
- platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/qt/editing/execCommand/indent-list-item-expected.txt:
- platform/qt/editing/execCommand/indent-selection-expected.txt:
- platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/qt/editing/execCommand/nsresponder-indent-expected.txt:
- platform/qt/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/qt/editing/execCommand/paste-1-expected.txt:
- platform/qt/editing/execCommand/paste-2-expected.txt:
- platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
- platform/qt/editing/input/emacs-ctrl-o-expected.txt:
- platform/qt/editing/inserting/4278698-expected.txt:
- platform/qt/editing/inserting/editing-empty-divs-expected.txt:
- platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
- platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
- platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
- platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
- platform/qt/editing/inserting/insert-at-end-01-expected.txt:
- platform/qt/editing/inserting/insert-at-end-02-expected.txt:
- platform/qt/editing/inserting/insert-br-001-expected.txt:
- platform/qt/editing/inserting/insert-br-003-expected.txt:
- platform/qt/editing/inserting/insert-br-005-expected.txt:
- platform/qt/editing/inserting/insert-br-006-expected.txt:
- platform/qt/editing/inserting/insert-br-007-expected.txt:
- platform/qt/editing/inserting/insert-br-008-expected.txt:
- platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/qt/editing/inserting/insert-div-001-expected.txt:
- platform/qt/editing/inserting/insert-div-002-expected.txt:
- platform/qt/editing/inserting/insert-div-003-expected.txt:
- platform/qt/editing/inserting/insert-div-005-expected.txt:
- platform/qt/editing/inserting/insert-div-006-expected.txt:
- platform/qt/editing/inserting/insert-div-007-expected.txt:
- platform/qt/editing/inserting/insert-div-008-expected.txt:
- platform/qt/editing/inserting/insert-div-009-expected.txt:
- platform/qt/editing/inserting/insert-div-010-expected.txt:
- platform/qt/editing/inserting/insert-div-020-expected.txt:
- platform/qt/editing/inserting/insert-div-023-expected.txt:
- platform/qt/editing/inserting/insert-div-024-expected.txt:
- platform/qt/editing/inserting/insert-div-025-expected.txt:
- platform/qt/editing/inserting/insert-div-026-expected.txt:
- platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/qt/editing/inserting/redo-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/qt/editing/inserting/typing-001-expected.txt:
- platform/qt/editing/inserting/typing-002-expected.txt:
- platform/qt/editing/inserting/typing-003-expected.txt:
- platform/qt/editing/inserting/typing-around-br-001-expected.txt:
- platform/qt/editing/inserting/typing-around-image-001-expected.txt:
- platform/qt/editing/pasteboard/3976872-expected.txt:
- platform/qt/editing/pasteboard/4076267-2-expected.txt:
- platform/qt/editing/pasteboard/4076267-3-expected.txt:
- platform/qt/editing/pasteboard/4076267-expected.txt:
- platform/qt/editing/pasteboard/8145-3-expected.txt:
- platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
- platform/qt/editing/pasteboard/cut-text-001-expected.txt:
- platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
- platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/qt/editing/pasteboard/paste-table-003-expected.txt:
- platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
- platform/qt/editing/pasteboard/paste-text-004-expected.txt:
- platform/qt/editing/pasteboard/paste-text-005-expected.txt:
- platform/qt/editing/pasteboard/paste-text-006-expected.txt:
- platform/qt/editing/pasteboard/paste-text-007-expected.txt:
- platform/qt/editing/pasteboard/paste-text-008-expected.txt:
- platform/qt/editing/pasteboard/paste-text-016-expected.txt:
- platform/qt/editing/pasteboard/paste-text-019-expected.txt:
- platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/qt/editing/pasteboard/pasting-object-expected.txt:
- platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
- platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
- platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/qt/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/qt/editing/selection/node-removal-1-expected.txt:
- platform/qt/editing/selection/node-removal-2-expected.txt:
- platform/qt/editing/selection/replace-selection-1-expected.txt:
- platform/qt/editing/selection/select-all-iframe-expected.txt:
- platform/qt/editing/style/create-block-for-style-001-expected.txt:
- platform/qt/editing/style/create-block-for-style-002-expected.txt:
- platform/qt/editing/style/create-block-for-style-003-expected.txt:
- platform/qt/editing/style/create-block-for-style-004-expected.txt:
- platform/qt/editing/style/create-block-for-style-007-expected.txt:
- platform/qt/editing/style/create-block-for-style-009-expected.txt:
- platform/qt/editing/style/create-block-for-style-010-expected.txt:
- platform/qt/editing/style/create-block-for-style-011-expected.txt:
- platform/qt/editing/style/create-block-for-style-012-expected.txt:
- platform/qt/editing/style/create-block-for-style-013-expected.txt:
- platform/qt/editing/style/designmode-expected.txt:
- platform/qt/editing/style/relative-font-size-change-001-expected.txt:
- platform/qt/editing/style/relative-font-size-change-002-expected.txt:
- platform/qt/editing/style/smoosh-styles-001-expected.txt:
- platform/qt/editing/style/smoosh-styles-003-expected.txt:
- platform/qt/editing/style/style-3998892-fix-expected.txt:
- platform/qt/editing/style/style-boundary-001-expected.txt:
- platform/qt/editing/style/style-boundary-004-expected.txt:
- platform/qt/editing/style/unbold-in-bold-expected.txt:
- platform/qt/editing/undo/4063751-expected.txt:
- platform/qt/editing/undo/redo-typing-001-expected.txt:
- platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-combined-delete-expected.txt:
- platform/qt/editing/undo/undo-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-delete-expected.txt:
- platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/qt/editing/undo/undo-forward-delete-expected.txt:
- platform/qt/editing/undo/undo-misspellings-expected.txt:
- platform/qt/editing/undo/undo-typing-001-expected.txt:
- platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
- platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
- platform/qt/editing/unsupported-content/list-type-after-expected.txt:
- platform/qt/editing/unsupported-content/list-type-before-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
- platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
- platform/qt/editing/unsupported-content/table-type-after-expected.txt:
- platform/qt/editing/unsupported-content/table-type-before-expected.txt:
- platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
- platform/qt/svg/custom/use-clipped-hit-expected.txt:
- 1:50 PM QtWebKitRelease22 edited by
- (diff)
- 1:48 PM Changeset in webkit [96256] by
-
- 2 edits in trunk/LayoutTests
[chromium / skia] temporarily add files test expectations pending rebaseline due to skia change
https://bugs.webkit.org/show_bug.cgi?id=69013
Patch by Brian Salomon <bsalomon@google.com> on 2011-09-28
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 1:48 PM QtWebKitRelease22 edited by
- (diff)
- 1:46 PM Changeset in webkit [96255] by
-
- 3 edits in trunk/Source/WebKit/mac
Expose +[WebStorageManager _storageDirectoryPath] as SPI
https://bugs.webkit.org/show_bug.cgi?id=68951
Reviewed by Brady Eidson.
This patch exposes +[WebStorageManager _storageDirectoryPath], which
pulls the path from NSUserDefaults if the preference is set. Otherwise,
it falls back on the default path.
- Storage/WebStorageManager.mm:
(+[WebStorageManager _storageDirectoryPath]): Adding static variable
so that we don't reread user defaults repeatedly.
(WebKitInitializeStorageIfNecessary):
- Storage/WebStorageManagerPrivate.h:
- 1:41 PM QtWebKitFeatures22 edited by
- (diff)
- 1:28 PM QtWebKitRelease22 edited by
- (diff)
- 1:21 PM Changeset in webkit [96254] by
-
- 1 edit in branches/chromium/874/Source/WebCore/inspector/front-end/TimelinePanel.js
Merge 95794 - Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 1:18 PM Changeset in webkit [96253] by
-
- 2 edits in trunk/Source/WebCore
FTPDirectoryDocument Shows Garbled String for Last Modified Date
https://bugs.webkit.org/show_bug.cgi?id=69011
Reviewed by Dan Bernstein.
Force WTF::String concatenation instead of an accidental char* pointer addition.
- html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
- 1:10 PM Changeset in webkit [96252] by
-
- 3 edits in trunk/Tools
Get rebaseline server running again
https://bugs.webkit.org/show_bug.cgi?id=69020
Reviewed by Adam Barth.
Make rebaseline server run again after r90337 (missing format_date_time
import, results_json wasn't outputting anything).
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
- Scripts/webkitpy/tool/servers/reflectionhandler.py:
- 1:07 PM Changeset in webkit [96251] by
-
- 2 edits in trunk/Tools
Move dgrogan from contributor to committer.
- 1:06 PM Changeset in webkit [96250] by
-
- 3 edits in trunk/Tools
Add Mac Skia GPU bots to builders.py
https://bugs.webkit.org/show_bug.cgi?id=69016
Reviewed by Eric Seidel.
This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
GPU tests.
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- 12:56 PM QtWebKitRelease22 edited by
- (diff)
- 12:55 PM Changeset in webkit [96249] by
-
- 3 edits in trunk/Source/WebCore
Fix a regression in r96060. ResourceLoader shouldn't get
initialized with a null DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=69004
Patch by Nate Chapin <Nate Chapin> on 2011-09-28
Reviewed by Csaba Osztrogonác.
This should fix a debug crash in some platforms in
plugins/js-from-destroy.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Move the activeDocumentLoader() null checks back
to SubresouceLoader::create().
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
- 12:55 PM QtWebKitFeatures22 edited by
- (diff)
- 12:54 PM Changeset in webkit [96248] by
-
- 2 edits in trunk/Source/WebKit2
One more shot at fixing GTK+, this seems to make the dependencies
work.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 12:53 PM Changeset in webkit [96247] by
-
- 5 edits in trunk/Source/JavaScriptCore
Merge bug#68580, bug#68932 for DFG JIT with JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=69017
Reviewed by Oliver Hunt.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
- 12:51 PM QtWebKitFeatures22 edited by
- (diff)
- 12:24 PM Changeset in webkit [96246] by
-
- 4 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
- fast/js/array-prototype-properties-expected.txt: Added.
- fast/js/array-prototype-properties.html: Added.
- fast/js/script-tests/array-prototype-properties.js: Added.
- Added layout test for array prototype functions with undefined as this value.
- ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
- These tests now pass.
- 12:15 PM Changeset in webkit [96245] by
-
- 2 edits in trunk/Source/WebKit2
GTK+ build fix 3 - the return of the marshal.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 12:14 PM Changeset in webkit [96244] by
-
- 3 edits in trunk/LayoutTests
Rebaseline fast/canvas/canvas-composite-transformclip.html and
fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:
- 12:02 PM Changeset in webkit [96243] by
-
- 2 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- These methods should throw if this value is undefined.
- 11:39 AM Changeset in webkit [96242] by
-
- 4 edits in trunk
Second try at fixing the GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
Source/WebKit2:
- GNUmakefile.am:
Tools:
- GNUmakefile.am:
- 11:14 AM Changeset in webkit [96241] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
- GNUmakefile.am:
- 11:09 AM Changeset in webkit [96240] by
-
- 2 edits in trunk/LayoutTests
[Chromium] remove a passing test from the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=69008
Reviewed by David Levin.
- platform/chromium/test_expectations.txt:
- 11:06 AM Changeset in webkit [96239] by
-
- 2 edits in trunk/Source/WebCore
CSP doesn't work for a wide variety of cases
https://bugs.webkit.org/show_bug.cgi?id=68921
Reviewed by Darin Adler.
Patch suggested by Sam Weinig. It's unclear to me how to test this
change because all our tests run on non-default ports, which is why we
have this bug in the first place. Mozilla uses a proxy while testing
so they can test with URLs like http://example.com, but we don't have
such a facility.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::portMatches):
- 11:05 AM Changeset in webkit [96238] by
-
- 7 edits in trunk/Source/JavaScriptCore
Value profiling in baseline JIT for JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=68750
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Geoff Garen.
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- 10:56 AM QtWebKitReleases edited by
- (diff)
- 10:56 AM Changeset in webkit [96237] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix webkit2 unit tests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69006
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-28
Reviewed by Martin Robinson.
We are currently using the WorQueue name as thread name which in
this moment can be com.apple.WebKit.ProcessLauncher or
com.apple.CoreIPC.ReceiveQueue. Both names are longer than 31
characters which is the limit of Visual Studio for thread
names. When log is enabled createThread() will assert instead of
truncate the name, so we need to make sure we don't use a name
longer than 31 characters.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
- 10:54 AM Changeset in webkit [96236] by
-
- 2 edits3 adds in trunk/LayoutTests
Rebaseline svg/filters/animate-fill.svg for Chromium.
- platform/chromium-cg-mac/svg/filters/animate-fill-expected.png: Added.
- platform/chromium-mac/svg/filters/animate-fill-expected.png: Added.
- platform/chromium-win/svg/filters/animate-fill-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:46 AM Changeset in webkit [96235] by
-
- 3 edits in trunk/Tools
Let TestWebKitAPI and webkit_unit_tests work for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=68680
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.
- Scripts/run-chromium-webkit-unit-tests:
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
- 10:44 AM QtWebKit edited by
- (diff)
- 10:40 AM Changeset in webkit [96234] by
-
- 7 edits in trunk
[Gtk] Implement textInputController.doCommand
https://bugs.webkit.org/show_bug.cgi?id=66496
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-09-28
Reviewed by Martin Robinson.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::doCommand): Function definition for doCommand
callback. Converted Incoming command to match with WebCore::Editor CommandMap.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
- DumpRenderTree/gtk/TextInputController.cpp:
(doCommandCallback): Callback function for textInputController.doCommand
LayoutTests:
Removed skipped tests under textInputController.doCommand for Gtk Port.
- platform/gtk/Skipped:
- 10:36 AM Changeset in webkit [96233] by
-
- 5 edits1 copy in trunk/Source
[Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
https://bugs.webkit.org/show_bug.cgi?id=68936
Reviewed by Tony Chang.
Source/WebCore:
Chromium need to be built without Gtk for future version of ChromiumOS.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- WebKit.gyp:
- public/gtk/WebFontInfo.h:
- public/linux/WebFontInfo.h: Copied from Source/WebKit/chromium/public/gtk/WebFontInfo.h.
- 10:35 AM QtWebKitReleases edited by
- (diff)
- 10:28 AM Changeset in webkit [96232] by
-
- 3 edits in trunk/Tools
watchlist: Suggest corrections for typos and improve error message consistency.
https://bugs.webkit.org/show_bug.cgi?id=68976
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
for typos and improve consistency of the error messages.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
and improve the regex that were already present.
- 10:19 AM Changeset in webkit [96231] by
-
- 8 edits in trunk
Revert change which broke displaying end script tags in view-source, instead
deal with any trailing </script> tag included by mistake in the XSSAuditor
itself. Correct tests to detect the missing close tags.
https://bugs.webkit.org/show_bug.cgi?id=68898
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::end):
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):
- html/parser/XSSAuditor.cpp:
(WebCore::startsHTMLEndTagAt):
(WebCore::XSSAuditor::snippetForJavaScript):
LayoutTests:
- fast/frames/resources/viewsource-frame-2.html:
- fast/frames/viewsource-plain-text-tags-expected.txt:
- fast/frames/viewsource-plain-text-tags.html:
- 10:15 AM Changeset in webkit [96230] by
-
- 3 edits in trunk/Source/JavaScriptCore
Wrong integer checks in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68985
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-28
Reviewed by Geoffrey Garen.
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
- 10:06 AM Changeset in webkit [96229] by
-
- 2 edits8 deletes in trunk/Source
Remove empty directories.
Source/JavaScriptCore:
- wtf/brew: Removed.
- wtf/unicode/brew: Removed.
Source/WebCore:
- editing/brew: Removed.
- page/brew: Removed.
- platform/brew: Removed.
- platform/graphics/brew: Removed.
- platform/network/brew: Removed.
- platform/text/brew: Removed.
- 10:05 AM Changeset in webkit [96228] by
-
- 4 edits2 adds in trunk/Tools
watchlist: Add support for matching added or deleted lines.
https://bugs.webkit.org/show_bug.cgi?id=68972
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
- Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
- Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
to the pattern match to only have the diff lines instead of the DiffFile.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
Add tests for the new patterns and combinations of the patterns.
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
Sort imports. Add changeline support.
- 9:57 AM Changeset in webkit [96227] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: optional arguments support for the frontend needs to be extended.
https://bugs.webkit.org/show_bug.cgi?id=69005
Generator supports optional arguments but they are transferred by value.
It is not suitable if the used type doesn't have operator bool.
I'll transfer such arguments by pointer.
Reviewed by Pavel Feldman.
Build is the test.
- inspector/CodeGeneratorInspector.pm:
(generateFrontendFunction):
(paramTypeTraits):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFailLoading):
- 9:24 AM Changeset in webkit [96226] by
-
- 4 edits4 adds in trunk/Source/WebKit2
[GTK] Loader client implementation for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68085
Reviewed by Martin Robinson.
Adds a new object, WebKitWebLoaderClient, that emits signals for
every page loader callback.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp: Added.
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(webkitWebLoaderClientConstructed):
(webkitWebLoaderClientSetProperty):
(webkitWebLoaderClientGetProperty):
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):
- UIProcess/API/gtk/WebKitWebLoaderClient.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the loader client for the view.
(webkit_web_view_init):
(webkit_web_view_get_loader_client): Get the current loader client.
(webkit_web_view_set_loader_client): Set a new loader client.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/tests/testloading.c: Added.
(serverCallback):
(webLoadingFixtureSetup):
(webLoadingFixtureTeardown):
(getURIForPath):
(loadStatusProvisionalLoadStarted):
(loadStatusProvisionalLoadReceivedServerRedirect):
(loadStatusProvisionalLoadFailed):
(loadStatusLoadCommitted):
(loadStatusLoadFinished):
(loadStatusLoadFailed):
(testLoadingStatus):
(loadErrorProvisionalLoadStarted):
(loadErrorProvisionalLoadFailed):
(loadErrorLoadFinished):
(testLoadingError):
(main):
- UIProcess/API/gtk/webkit2marshal.list: Added.
- 9:20 AM Changeset in webkit [96225] by
-
- 6 edits1 copy1 add in trunk
[GTK] Add WebKitError to GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=68508
Reviewed by Martin Robinson.
Source/WebKit2:
Add WebKitNetworkError enum to define network errors.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitError.cpp: Added.
(webkit_network_error_quark):
- UIProcess/API/gtk/WebKitError.h:
- UIProcess/API/gtk/WebKitPrivate.h: Add
COMPILE_ASSERT_MATCHING_ENUM macro.
- UIProcess/API/gtk/webkit2.h: Add WebKitError.h and
WebKitEnumTypes.h
Tools:
- GNUmakefile.am: Add path to webkitgtk derived sources to the
include path.
- 8:52 AM Changeset in webkit [96224] by
-
- 5 edits2 adds in trunk
Reflected attribute input.size wraps on negative values (Chrome), or
returns them (Safari).
https://bugs.webkit.org/show_bug.cgi?id=44886
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-28
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLInputElement/input-size-attribute.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
LayoutTests:
- fast/dom/HTMLInputElement/input-size-attribute-expected.txt: Added.
- fast/dom/HTMLInputElement/input-size-attribute.html: Added.
- fast/dom/HTMLInputElement/script-tests/size-attribute.js:
- fast/dom/HTMLInputElement/size-attribute-expected.txt:
- 8:01 AM Changeset in webkit [96223] by
-
- 12 edits2 adds in trunk
Web Inspector: Add support for search in single resource to page agent.
https://bugs.webkit.org/show_bug.cgi?id=68998
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/search-in-resource.html
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
- inspector/ContentSearchUtils.h:
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForSearchMatch):
(WebCore::InspectorPageAgent::searchInResource):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):
- inspector/front-end/SourceFile.js:
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
LayoutTests:
- http/tests/inspector/search/search-in-resource-expected.txt: Added.
- http/tests/inspector/search/search-in-resource.html: Added.
- http/tests/inspector/search/search-in-resources.html:
- http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest.InspectorTest.dumpSearchMatches):
(initialize_SearchTest):
- 7:30 AM Changeset in webkit [96222] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
https://bugs.webkit.org/show_bug.cgi?id=69002
Reviewed by Yury Semikhatsky.
- inspector/CodeGeneratorInspector.pm:
- 7:28 AM Changeset in webkit [96221] by
-
- 2 edits in trunk/LayoutTests
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-28
Reviewed by Csaba Osztrogonác.
- platform/wk2/Skipped: Skip svg/animations/animate-from-to-keyTimes.html.
- 7:02 AM Changeset in webkit [96220] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new tests.
- platform/gtk/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/gtk/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
- platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
- 6:53 AM Changeset in webkit [96219] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: live edit cursor always appears at the beginning of the file.
https://bugs.webkit.org/show_bug.cgi?id=68900
Reviewed by Pavel Feldman.
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):
- 6:41 AM Changeset in webkit [96218] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip 2 64-bits Debug crashers on GTK.
- platform/gtk/Skipped: Skip
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html and plugins/js-from-destroy.html
- 5:35 AM Changeset in webkit [96217] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Remove *void* parameter in internal functions
https://bugs.webkit.org/show_bug.cgi?id=68867
Reviewed by Andreas Kling.
As a step to let ewk be compliant with webkit coding style,
we need to remove *void* parameter in internal functions.
- ewk/ewk_private.h:
- ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
- ewk/ewk_util.cpp:
(ewk_util_dpi_get):
- 5:35 AM Changeset in webkit [96216] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected file after r95745.
- platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt:
- 4:56 AM Changeset in webkit [96215] by
-
- 10 edits10 adds in trunk
Web Inspector: Refactor searching in inspector, add test (fixed non regex search).
https://bugs.webkit.org/show_bug.cgi?id=68930
Reviewed by Yury Semikhatsky.
Source/WebCore:
Search moved out from page agent.
Fixed search for non regex case which is not yet used.
Test: http/tests/inspector/search/search-in-resources.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/ContentSearchUtils.cpp: Added.
(WebCore::ContentSearchUtils::createSearchRegexSource):
(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
- inspector/ContentSearchUtils.h: Added.
- inspector/InspectorPageAgent.cpp:
(WebCore::hasTextContent):
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::textContentForCachedResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
- inspector/front-end/utilities.js:
():
LayoutTests:
- http/tests/inspector/search/resources/search.css: Added.
(div.searchTestUniqueString):
(div.searchTestUniqueString:hover):
- http/tests/inspector/search/resources/search.html: Added.
- http/tests/inspector/search/resources/search.js: Added.
(searchTestUniqueString):
(doSomething):
- http/tests/inspector/search/search-in-resources-expected.txt: Added.
- http/tests/inspector/search/search-in-resources.html: Added.
- http/tests/inspector/search/search-test.js: Added.
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest):
- 4:25 AM Changeset in webkit [96214] by
-
- 2 edits in trunk/Tools
[GTK] missing WebKit2 support in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=68992
Rubber-stamped by Andreas Kling.
- Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
webkit2 directory.
- 3:56 AM Changeset in webkit [96213] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Fix Programs/unittests/webkit2/testwebview
https://bugs.webkit.org/show_bug.cgi?id=68993
Reviewed by Philippe Normand.
- GNUmakefile.am: Add -DWEBKIT_EXEC_PATH.
- UIProcess/API/gtk/tests/testwebview.c:
(main): Get WebProcess path from WEBKIT_EXEC_PATH environment
variable.
- 2:54 AM Changeset in webkit [96212] by
-
- 5 edits in trunk
Implement a PopStateEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68896
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/pop-state-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
- dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
- platform/chromium/test_expectations.txt:
- 2:45 AM Changeset in webkit [96211] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Allow TextureMapperGL to work without a GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=68980
Reviewed by Andreas Kling.
Perform a null-check for m_context and initialize that variable.
If a graphics-context doesn't exist, we don't need to reset it.
No new functionality so no new tests.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
- 2:42 AM Changeset in webkit [96210] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix for test.
- inspector/performance/resources/inspector-startup-time.html:
- 2:30 AM Changeset in webkit [96209] by
-
- 2 edits1 add in trunk/LayoutTests
Web Inspector: UI performance test for Inspector start-up time is required.
https://bugs.webkit.org/show_bug.cgi?id=68986
Reviewed by Yury Semikhatsky.
- inspector/performance/resources/inspector-startup-time.html: Added.
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
- 2:27 AM Changeset in webkit [96208] by
-
- 7 edits in trunk
Implement an ErrorEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68336
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/error-event-constructor.html
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Returns an unsigned value corresponding to a given key.
- bindings/v8/OptionsObject.h:
- bindings/v8/custom/V8EventConstructors.cpp: Added the ErrorEvent constructor.
- dom/ErrorEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled fast/events/constructors/error-event-constructor.html,
since V8 now has the constructor for ErrorEvent.
- platform/chromium/test_expectations.txt:
- 2:27 AM Changeset in webkit [96207] by
-
- 3 edits in trunk/Tools
[GTK] build-webkit --no-webkit2 still builds WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68892
Reviewed by Martin Robinson.
Take the --no-webkit2 option in account when building WebKitGTK+.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
(buildGtkProject):
- 1:47 AM Changeset in webkit [96206] by
-
- 3 edits in trunk/LayoutTests
[Qt][GTK] Skip http/tests/multipart/stop-crash.html because it fails after r96174.
https://bugs.webkit.org/show_bug.cgi?id=68979
Reviewed by Csaba Osztrogonác.
- platform/gtk/Skipped: Skip http/tests/multipart/stop-crash.html failing
- platform/qt/Skipped: Skip http/tests/multipart/stop-crash.html failing
- 1:28 AM Changeset in webkit [96205] by
-
- 8 edits1 delete in trunk/Source
WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
https://bugs.webkit.org/show_bug.cgi?id=68863
Reviewed by Darin Adler.
The SolarWalk binary does not link against WebKit.framework directly,
so calling NSVersionOfLinkTimeLibrary() will not return the version of
WebKit against which SolarWalk was linked. Since Solar Walk has
released an update that addresses the issue for which this app-specific
hack was originally added, we should just remove the hack.
Source/WebCore:
- WebCore.exp.in: Remove applicationIsSolarWalkMac().
- platform/RuntimeApplicationChecks.cpp: Ditto.
- platform/RuntimeApplicationChecks.h: Ditto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove SolarWalkQuirksUserScript.js.
Source/WebKit/mac:
- Misc/SolarWalkQuirksUserScript.js: Removed.
- WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
leakSolarWalkQuirksUserScriptContents(), and
-[WebView _injectSolarWalkQuirksScript].
(-[WebView _commonInitializationWithFrameName:groupName:]): Do not
inject the Solar Walk quirks script.
- 1:21 AM Changeset in webkit [96204] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/crash-set-font.html failing on all platform because
getCSSCanvasContext needs 4 parameters
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Csaba Osztrogonác.
- fast/canvas/crash-set-font.html: adding the fourth parameter
- 1:06 AM Changeset in webkit [96203] by
-
- 2 edits in trunk/Source/WebCore
Fix potential SVG performance regression (over-invalidation of caches) from 96052
https://bugs.webkit.org/show_bug.cgi?id=68941
<rdar://problem/10196224>
Reviewed by Zoltan Herczeg.
Only invalidate the cache of a filter when target style changes, as of the different types of cached
resources, only filters make use of the style of the target element and thus need to be invalidated
when the target style changes.
No new tests, performance improvement.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientUpdatedFromElement):
- 1:02 AM Changeset in webkit [96202] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get.
https://bugs.webkit.org/show_bug.cgi?id=65842
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get
as an optional parameter. Developer may pass NULL to skip returning the number of elements
of the requested array.
- ewk/ewk_view.cpp:
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
- 1:00 AM Changeset in webkit [96201] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed manual rebaseline for linux gpu.
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
- 12:54 AM Changeset in webkit [96200] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
https://bugs.webkit.org/show_bug.cgi?id=68982
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 12:46 AM Changeset in webkit [96199] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Unreviewed. Slight adjustment of the test content for better representation of the performance.
- inspector/performance/resources/show-panel.html:
- 12:44 AM Changeset in webkit [96198] by
-
- 3 edits4 adds1 delete in trunk/LayoutTests
Unreviewed rebaseline pservers-grad-14-b again.
- platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
- 12:39 AM Changeset in webkit [96197] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed fix for a lint error in test_expectations.txt
- platform/chromium/test_expectations.txt:
- 12:22 AM Changeset in webkit [96196] by
-
- 2 edits in trunk/Source/WebCore
Missing initialization of member in ImageFrameQt class
https://bugs.webkit.org/show_bug.cgi?id=68943
Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-09-28
Reviewed by Kenneth Rohde Christiansen.
No new tests, this fixes internal implementation detail.
- platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
- 12:12 AM Changeset in webkit [96195] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] URL of resources are not decoded.
https://bugs.webkit.org/show_bug.cgi?id=66540
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Fix ewk_frame_resources_location_get which was returning the encoded URL of resources.
As a result characters for instance, %20 occurred. For now returned strings are decoded.
- ewk/ewk_frame.cpp:
(ewk_frame_resources_location_get):
- 12:02 AM Changeset in webkit [96194] by
-
- 3 edits in trunk/Tools
Make Chromium Win Release (Tests) a core builder
https://bugs.webkit.org/show_bug.cgi?id=68906
Reviewed by Adam Barth.
Add Chromium Win Release (Tests) to the list of core builders.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
Sep 27, 2011:
- 11:46 PM Changeset in webkit [96193] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add platform specific expected result for new test introduced in r96149.
- platform/qt/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- 11:32 PM Changeset in webkit [96192] by
-
- 2 edits in trunk/Source/WebCore
Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=68964
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Doing value->isPrimitiveValue() is relatviely expensive, so moving it after the early returns but
before the result is used saves a significant number of cycles. (Tested with Shark profiler in Safari).
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 10:43 PM Changeset in webkit [96191] by
-
- 8 edits1 copy2 adds in trunk/LayoutTests
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed rebaseline for skia r2300 roll.
- platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
- platform/chromium/test_expectations.txt:
- 10:37 PM Changeset in webkit [96190] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed test_expectations.txt update
- platform/chromium/test_expectations.txt:
- 10:33 PM Changeset in webkit [96189] by
-
- 10 edits in trunk/Source/JavaScriptCore
DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=68580
Reviewed by Oliver Hunt.
This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.
With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownArray):
- 10:26 PM BuildingGtk edited by
- Changed the libgail dependency to libgail-3-dev (diff)
- 10:23 PM Changeset in webkit [96188] by
-
- 2 edits in trunk
Unreviewed. Fix a build error in WebKit EFL.
When web socket is disabled, there is a build break in WebKit EFL port.
Currently, web socket is enabled by default in build-webkit script.
Thus, the web socket is also enabled in EFL script of cmake build system for now.
Because, WebKit EFL developers can't work on latest WebKit trunk.
However, IMO, we should fix build errors when web socket is disabled.
- Source/cmake/OptionsEfl.cmake:
- 10:04 PM Changeset in webkit [96187] by
-
- 16 edits in trunk/Source/WebCore
Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
https://bugs.webkit.org/show_bug.cgi?id=68939
Reviewed by Darin Adler.
Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.
This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
text at ends are not removed when it has a render object. Fixed the bug by checking the length of
the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)
This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.
- dom/Position.cpp:
(WebCore::Position::rendersInDifferentPosition):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasVisibleRenderText): Added.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.
- editing/visible_units.cpp:
(WebCore::startOfParagraph): Calls renderedTextLength.
(WebCore::endOfParagraph): Ditto.
- rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
- rendering/InlineBox.h: Ditto.
- rendering/InlineTextBox.cpp: Ditto.
- rendering/InlineTextBox.h: Ditto.
- rendering/RenderBR.cpp: Ditto.
- rendering/RenderBR.h: Ditto.
- rendering/RenderObject.cpp: Ditto.
- rendering/RenderObject.h: Ditto.
- rendering/RenderReplaced.cpp: Ditto.
- rendering/RenderReplaced.h: Ditto.
- rendering/RenderText.cpp:
(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.
- rendering/RenderText.h:
- 9:56 PM Changeset in webkit [96186] by
-
- 29 edits1 copy1 add in trunk/Source/WebCore
[chromium] LayerRenderChromium asserts about leaking textures.
https://bugs.webkit.org/show_bug.cgi?id=68190
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(WebCore::TextureAllocator::~TextureAllocator):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
- platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 9:03 PM Changeset in webkit [96185] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
https://bugs.webkit.org/show_bug.cgi?id=68967
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).
Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
- 8:39 PM Changeset in webkit [96184] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG JIT should speculate more aggressively on reads of array.length
https://bugs.webkit.org/show_bug.cgi?id=68932
Reviewed by Oliver Hunt.
This is a 2% speed-up on Kraken, neutral elsewhere.
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 8:37 PM Changeset in webkit [96183] by
-
- 4 edits in trunk/Tools
garden-o-matic should load faster and inform the user what is happening
https://bugs.webkit.org/show_bug.cgi?id=68954
Reviewed by Dimitri Glazkov.
This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.
This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- 7:58 PM Changeset in webkit [96182] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=68925
Reviewed by Kenneth Russell.
- webaudio/waveshaper-expected.txt: Added.
- webaudio/waveshaper.html: Added.
- 7:48 PM Changeset in webkit [96181] by
-
- 2 edits in trunk/Tools
garden-o-matic should show the first result when examining results
https://bugs.webkit.org/show_bug.cgi?id=68960
Reviewed by Dimitri Glazkov.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- 7:30 PM Changeset in webkit [96180] by
-
- 5 edits in trunk
Implement a PageTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68067
Patch by Kentaro Hara <haraken@chromium.com> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/page-transition-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
- dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
- platform/chromium/test_expectations.txt:
- 7:02 PM Changeset in webkit [96179] by
-
- 11 edits2 adds in trunk
Implement a MessageEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68883
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
The spec for MessageEvent is here:
http://www.whatwg.org/specs/web-apps/current-work/#messageevent
Currently, some tests in fast/events/constructors/message-event-constructor.html
are failing or crashing in DRT, as we commented in the test file.
This is because MessageEvent.data is implemented as SerializedScriptValue,
and thus it cannot keep ScriptValue passed by JavaScript.
This is the same issue as the bug (https://bugs.webkit.org/show_bug.cgi?id=68345).
We will soon make a follow-up patch to fix these failures, after this
patch is landed.
Test: fast/events/constructors/message-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the MessageEvent constructor.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Generates MessagePortArray from the list of message ports in the format of JSValues.
- bindings/js/JSDictionary.h:
- bindings/js/JSEventConstructors.cpp: Added #includes for MessageEvent.
- dom/MessageEvent.cpp:
(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
- dom/MessageEvent.h: Added a definition for MessageEvent. Removed an extra leading spaces.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::origin):
(WebCore::MessageEvent::lastEventId):
(WebCore::MessageEvent::source):
(WebCore::MessageEvent::ports):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):
- dom/MessageEvent.idl: Makes MessageEvent constructible.
LayoutTests:
message-event-constructor.html checks the behavior of the MessageEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has MessageEvent.
- fast/events/constructors/message-event-constructor-expected.txt: Added.
- fast/events/constructors/message-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped message-event-constructor.html, since V8 does not yet have the MessageEvent constructor.
- 6:52 PM Changeset in webkit [96178] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT - merge changes between 95905 - 96175
https://bugs.webkit.org/show_bug.cgi?id=68963
Reviewed by Sam Weinig.
Merge missing changes from bug#68677, bug#68784, bug#68785.
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:46 PM Changeset in webkit [96177] by
-
- 5 edits1 copy8 adds in trunk
[Chromium/FileWriter] race condition in FileWriter completion can lead to assert
https://bugs.webkit.org/show_bug.cgi?id=67684
Reviewed by David Levin.
Source/WebCore:
Tests: fast/filesystem/file-writer-abort-continue.html
fast/filesystem/file-writer-abort.html
Track the state of the backend and be prepared for reentrant user
requests. Limit recursion depth to an arbitrary small constant.
- fileapi/FileWriter.cpp: Lots of event-handling changes.
- fileapi/FileWriter.h:
LayoutTests:
- fast/filesystem/file-writer-abort-continue-expected.txt: Added.
- fast/filesystem/file-writer-abort-continue.html: Added.
- fast/filesystem/file-writer-abort-expected.txt: Added.
- fast/filesystem/file-writer-abort.html: Added.
- fast/filesystem/resources/file-writer-abort-continue.js: Added.
- fast/filesystem/resources/file-writer-abort.js: Added.
- fast/filesystem/resources/file-writer-events.js: Fixed a copy-paste error.
- 6:12 PM Changeset in webkit [96176] by
-
- 7 edits in trunk/LayoutTests
svg/custom/oversized-pattern-scale.svg is useless because the interesting part of the test is off the screen
https://bugs.webkit.org/show_bug.cgi?id=68945
Reviewed by Darin Adler.
Change oversized-pattern-scale so that the interesting part of the pattern is on the screen,
and so that it doesn't draw a scrollbar (making it platform-independent).
Change transformed-pattern-clamp-svg-root so that it doesn't draw a gradient, making it platform-independent.
- svg/custom/oversized-pattern-scale-expected.png:
- svg/custom/oversized-pattern-scale-expected.txt:
- svg/custom/oversized-pattern-scale.svg:
- svg/custom/transformed-pattern-clamp-svg-root-expected.png:
- svg/custom/transformed-pattern-clamp-svg-root-expected.txt:
- svg/custom/transformed-pattern-clamp-svg-root.svg:
- 6:09 PM Changeset in webkit [96175] by
-
- 9 edits in trunk/Source/JavaScriptCore
Get JSVALUE32_64 DFG JIT building on OS X.
https://bugs.webkit.org/show_bug.cgi?id=68961
Reviewed by Geoff Garen.
- Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
- Forward-declare functions in DFGOperations.cpp
- UNUSED_PARAM for unused arguments
- NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
- Fix argument types handled by OpInfo constructor.
- Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
- Add files to Xcode project.
- 6:01 PM Changeset in webkit [96174] by
-
- 3 edits in trunk/LayoutTests
http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=34222
Reviewed by Ryosuke Niwa.
Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).
- http/tests/multipart/stop-crash-expected.txt:
- http/tests/multipart/stop-crash.html:
- 5:25 PM Changeset in webkit [96173] by
-
- 29 edits3 deletes in trunk/Source/WebCore
Unreviewed, rolling out r96141.
http://trac.webkit.org/changeset/96141
https://bugs.webkit.org/show_bug.cgi?id=68190
Breaks PrerenderBrowserTest.PrerenderHTML5Video in
browser_tests
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::createLayerTexture):
(WebCore::LayerRendererChromium::deleteLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Removed.
- platform/graphics/chromium/TrackingTextureAllocator.h: Removed.
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp.rej: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 4:51 PM Changeset in webkit [96172] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=68953
Reviewed by Kenneth Russell.
The accelerated drawing code is incompatible with threaded compositing. Rather than tying the two behaviors
together via USE(THREADED_COMPOSITING), this patch guards the accelerated drawing code with its own USE() guard
so the features can advance independently. Today, it's not safe to set both of these flags.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- 4:48 PM Changeset in webkit [96171] by
-
- 7 edits in trunk/Source/JavaScriptCore
Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68755
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Gavin Barraclough.
We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:42 PM Changeset in webkit [96170] by
-
- 4 edits2 copies in trunk/Tools
watchlist: Add support for cc and message rules.
https://bugs.webkit.org/show_bug.cgi?id=68950
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
the cc's and messages for a patch.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
for the rules.
- Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
A generic encapsulation of either a message list or a cc list.
- Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
- 4:32 PM Changeset in webkit [96169] by
-
- 8 edits in trunk/Source/JavaScriptCore
Macro assembler branch8 & 16 methods vary in treatment of upper bits
https://bugs.webkit.org/show_bug.cgi?id=68301
Reviewed by Sam Weinig.
Fix for branch16 - remove it!
No performance impact.
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
- assembler/MacroAssemblerSH4.h:
- assembler/MacroAssemblerX86Common.h:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
- 4:24 PM Changeset in webkit [96168] by
-
- 3 edits in trunk/Source/WebCore
Slightly improve performance of CSSStyleApplyProperty handler lookup.
https://bugs.webkit.org/show_bug.cgi?id=68868
Reviewed by Eric Seidel.
No new tests as no functionality changed.
- css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::propertyHandler):
Make propertyHandler() public and remove redirecting functions.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Perform property handler lookup once and reuse the result.
- 4:11 PM Changeset in webkit [96167] by
-
- 1 edit4 adds in trunk/LayoutTests
Chromium baselines for fast/multicol/float-paginate-empty-lines.html
after r96149 and 96162.
- platform/chromium-linux/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- 4:05 PM Changeset in webkit [96166] by
-
- 5 edits in trunk
[V8] element.dataset.nonExistingKey should return undefined.
https://bugs.webkit.org/show_bug.cgi?id=68877
Reviewed by Nate Chapin.
Source/WebCore:
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().
LayoutTests:
- fast/dom/dataset-expected.txt: Updated.
- fast/dom/script-tests/dataset.js: Add a test case.
- 3:53 PM Changeset in webkit [96165] by
-
- 2 edits6 adds2 deletes in trunk/LayoutTests
Chromium rebaseline after r96155.
- platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
- platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- 3:46 PM Changeset in webkit [96164] by
-
- 74 edits in trunk/Source
Source/JavaScriptCore: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
(JSC::JSCallbackFunction::getCallData):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
(JSC::::getCallData):
- API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
(JSC::ArrayConstructor::getCallData):
- runtime/ArrayConstructor.h:
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
(JSC::BooleanConstructor::getCallData):
- runtime/BooleanConstructor.h:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
(JSC::DateConstructor::getCallData):
- runtime/DateConstructor.h:
- runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
(JSC::ErrorConstructor::getCallData):
- runtime/ErrorConstructor.h:
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
(JSC::FunctionConstructor::getCallData):
- runtime/FunctionConstructor.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
(JSC::FunctionPrototype::getCallData):
- runtime/FunctionPrototype.h:
- runtime/InternalFunction.h:
- runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
(JSC::JSCell::getCallData):
- runtime/JSCell.h:
(JSC::getCallData):
- runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
(JSC::JSFunction::getCallData):
- runtime/JSFunction.h:
- runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
(JSC::NativeErrorConstructor::getCallData):
- runtime/NativeErrorConstructor.h:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
(JSC::NumberConstructor::getCallData):
- runtime/NumberConstructor.h:
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
(JSC::ObjectConstructor::getCallData):
- runtime/ObjectConstructor.h:
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
(JSC::RegExpConstructor::getCallData):
- runtime/RegExpConstructor.h:
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
(JSC::StringConstructor::getCallData):
- runtime/StringConstructor.h:
Source/JavaScriptGlue: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
- UserObjectImp.cpp:
(UserObjectImp::getCallDataVirtual):
(UserObjectImp::getCallData):
- UserObjectImp.h:
Source/WebCore: Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
No new tests.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
- WebCore.exp.in:
- bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):
- bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):
- bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):
- bindings/scripts/test/JS/JSTestObj.h:
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
- bridge/qt/qt_runtime.h:
- workers/WorkerContext.h:
Source/WebKit/mac: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::getCallDataVirtual):
(WebKit::JSNPMethod::getCallData):
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallDataVirtual):
(WebKit::JSNPObject::getCallData):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 3:43 PM Changeset in webkit [96163] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Remove duplicate FilterOperation{s}.h that were
accidentally added to the top level of the Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- 3:11 PM Changeset in webkit [96162] by
-
- 5 edits1 add in trunk
https://bugs.webkit.org/show_bug.cgi?id=68940
Narrow the float/lines pagination heuristic to only kick in if
the previous line broke cleanly and if the floats are occurring
at the start of the line.
Reviewed by Dan Bernstein.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):
LayoutTests:
- fast/regions/webkit-flow-float-pushed-to-last-region.html:
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
- 3:04 PM Changeset in webkit [96161] by
-
- 2 edits in trunk/Tools
webkit-patch doesn't like UTF-8 characters in reviewers names
https://bugs.webkit.org/show_bug.cgi?id=63452
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-27
Reviewed by Eric Seidel.
- Scripts/webkit-patch:
- 2:47 PM Changeset in webkit [96160] by
-
- 3 edits2 adds in trunk
Add a mechanism to test for the compositing tree mutated during painting
https://bugs.webkit.org/show_bug.cgi?id=68738
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.
Test: compositing/video/video-with-invalid-source.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
LayoutTests:
Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.
- compositing/video/video-with-invalid-source-expected.txt: Added.
- compositing/video/video-with-invalid-source.html: Added.
- 2:45 PM Changeset in webkit [96159] by
-
- 6 edits in trunk
take padding/border on flexbox into account with direction:rtl
https://bugs.webkit.org/show_bug.cgi?id=68846
Reviewed by David Hyatt.
Source/WebCore:
Use the logicalWidth of the flexbox instead of it's availableLogicalWidth
so that we include the flexbox's border and padding.
Also, change all uses of availableLogicalWidth to contentLogicalWidth.
The former takes multi-column into account. Multi-column flexboxes don't
make any sense, so there's no point in calling availableLogicalWidth.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/writing-modes-expected.txt:
- css3/flexbox/writing-modes.html:
- 2:43 PM QtWebKitSecurity edited by
- (diff)
- 2:41 PM QtWebKitSecurity edited by
- (diff)
- 2:31 PM QtWebKitSecurity edited by
- (diff)
- 2:30 PM QtWebKitReleases edited by
- (diff)
- 2:29 PM QtWebKitSecurity edited by
- (diff)
- 2:25 PM Changeset in webkit [96158] by
-
- 2 edits in trunk/LayoutTests
Chromium test expectations update.
Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.
- platform/chromium/test_expectations.txt:
- 2:23 PM QtWebKitSecurity edited by
- (diff)
- 2:20 PM QtWebKitReleases edited by
- (diff)
- 2:19 PM Changeset in webkit [96157] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r96139.
http://trac.webkit.org/changeset/96139
https://bugs.webkit.org/show_bug.cgi?id=68933
Broke table-percent-height.html on Mac bots (Requested by
mwenge2 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/RenderBox.h:
LayoutTests:
- fast/replaced/table-percent-width-expected.txt: Removed.
- fast/replaced/table-percent-width.html: Removed.
- 2:17 PM QtWebKitReleases edited by
- (diff)
- 2:13 PM QtWebKitSecurity edited by
- (diff)
- 2:12 PM Changeset in webkit [96156] by
-
- 2 edits in trunk/LayoutTests
need to rebseline these once new aa-gdi-text code lands in skia
https://bugs.webkit.org/show_bug.cgi?id=68920
Reviewed by Kenneth Russell.
- platform/chromium/test_expectations.txt:
- 2:08 PM QtWebKitSecurity edited by
- (diff)
- 2:06 PM QtWebKitSecurity edited by
- (diff)
- 2:06 PM Changeset in webkit [96155] by
-
- 14 edits6 adds in trunk
REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
https://bugs.webkit.org/show_bug.cgi?id=67700
<rdar://problem/10125102>
Reviewed by Darin Adler.
Clamp all resources to the same size, 4096x4096 (arbitrarily chosen), instead of to the size
of the <svg> element. This fixes the case where a transformed element displays part of a resource
outside of the size of the <svg> element.
When drawing an oversized pattern into its tile image, scale the content down to fit. When drawing
the tile image to the screen, scale it back up to fit the expected area. This will cause pixelation
when patterns are over the 4k limit.
Tests: svg/custom/transformed-pattern-clamp-svg-root.svg, svg/custom/oversized-pattern-scale.svg
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRect):
- rendering/svg/SVGImageBufferTools.h:
pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is
still very excessive but easier to draw with.
Add a test (transformed-pattern-clamp-svg-root.svg) that ensures that patterns on transformed
elements are displayed correctly, instead of being clamped to the size of the <svg> element.
Add a test (oversized-pattern-scale.svg) that ensures that oversized patterns are correctly drawn
into the pattern tile scaled down and then are scaled back up when drawn to the screen.
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
- svg/custom/pattern-excessive-malloc-expected.txt:
- svg/custom/pattern-excessive-malloc.svg:
- svg/custom/oversized-pattern-scale-expected.png: Added.
- svg/custom/oversized-pattern-scale-expected.txt: Added.
- svg/custom/oversized-pattern-scale.svg: Added.
- svg/custom/transformed-pattern-clamp-svg-root.svg: Added.
- svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
- svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added.
- 2:04 PM Changeset in webkit [96154] by
-
- 3 edits2 adds in trunk
<rdar://problem/10098679> Assertion failure in RenderLayer::paintPaginatedChildLayer()
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/dynamic/layer-no-longer-paginated.html
FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.
LayoutTests:
- fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
- fast/dynamic/layer-no-longer-paginated.html: Added.
- 2:02 PM Changeset in webkit [96153] by
-
- 5 edits1 add in trunk/Tools
garden-o-matic examine buttons shows both expected and unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=68918
Reviewed by Dimitri Glazkov.
This was a copy/paste error when I refactored this classes to share
more code.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- 1:55 PM Changeset in webkit [96152] by
-
- 8 edits2 adds in trunk
offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
https://bugs.webkit.org/show_bug.cgi?id=68304
Reviewed by David Hyatt.
Source/WebCore:
When grabbing the x/y values of the RenderBox, we need to take writing mode
flipping into account.
Test: fast/dom/offset-position-writing-modes.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::locationIncludingFlipping):
- rendering/RenderBox.h:
(WebCore::RenderBox::yFlippedForWritingMode):
(WebCore::RenderBox::xFlippedForWritingMode):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
LayoutTests:
- css3/flexbox/writing-modes-expected.txt:
- css3/flexbox/writing-modes.html:
- fast/dom/offset-position-writing-modes-expected.txt: Added.
- fast/dom/offset-position-writing-modes.html: Added.
- 1:54 PM Changeset in webkit [96151] by
-
- 6 edits3 adds in trunk
Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
https://bugs.webkit.org/show_bug.cgi?id=68816
<rdar://problem/10186468>
Reviewed by Simon Fraser.
If a filter returns without writing into its result buffer, make sure to return an cleared buffer.
Test: svg/filters/feMorphology-zero-radius.svg
- 1:51 PM Changeset in webkit [96150] by
-
- 2 edits in trunk/Source/WebCore
CompositeEditCommand::prune should remove subtree at once
https://bugs.webkit.org/show_bug.cgi?id=68866
Reviewed by Darin Adler.
Extracted the logic to find the highest ancestor to remove as highestNodeToRemoveInPruning from prune.
This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.
- editing/CompositeEditCommand.cpp:
(WebCore::hasARenderedDescendant): Takes excludedNode in addition to node. excludedNode is used to ignore
the child node from which we climbed up the tree in highestNodeToRemoveInPruning.
(WebCore::highestNodeToRemoveInPruning): Extracted from prune.
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- 1:39 PM Changeset in webkit [96149] by
-
- 4 edits5 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68922
Source/WebCore:
Paginated floats should not grow the height of a block when they don't end
up being tied to a line. Floats encountered in skipLeadingWhitespace that
paginate can't immediately grow the height of the block, since there may not
end up being any actual line content. We only want to push the height of the
block down if we have actual line content that we want to keep with the
float.
Make positionNewFloatOnLine check if the line is empty or not, and if it is,
it just puts the desired pagination strut into LineInfo. If and when actual
line content is encountered and setEmpty becomes false, we'll grow the block
height then.
Reviewed by Dan Bernstein.
Added fast/multicol/float-paginate-empty-lines.html and
fast/regions/webkit-flow-double-pagination-float-push.html.
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setFloatPaginationStrut):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::positionNewFloatOnLine):
LayoutTests:
Paginated floats should not grow the height of a block when they don't end
up being tied to a line.
Reviewed by Dan Bernstein.
- fast/multicol/float-paginate-empty-lines.html: Added.
- fast/regions/webkit-flow-double-pagination-float-push.html: Added.
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
- 1:35 PM QtWebKitSecurity edited by
- (diff)
- 1:34 PM QtWebKitSecurity edited by
- (diff)
- 1:29 PM Changeset in webkit [96148] by
-
- 2 edits in trunk/Tools
Add Kaustubh Atrawalkar to the list of contributors.
- Scripts/webkitpy/common/config/committers.py:
- 1:28 PM QtWebKitSecurity edited by
- (diff)
- 1:24 PM Changeset in webkit [96147] by
-
- 2 edits in trunk/Tools
[Chromium] Fixed layout mode tests break subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=68923
Reviewed by Adam Barth.
Reset fixed layout mode between tests, so that tests that run after
platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
regular 800x600 non-fixed layout.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
- 1:16 PM Changeset in webkit [96146] by
-
- 14 edits3 deletes in trunk
Unreviewed, rolling out r96131.
http://trac.webkit.org/changeset/96131
https://bugs.webkit.org/show_bug.cgi?id=68927
It made 18+ tests crash on all platform (Requested by
Ossy_night on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
- jsc.cpp:
(GlobalObject::finishCreation):
- parser/Parser.h:
(JSC::Parser::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Removed.
- fast/js/stack-trace-expected.txt: Removed.
- fast/js/stack-trace.html: Removed.
- platform/chromium/test_expectations.txt:
- 1:05 PM Changeset in webkit [96145] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt] QDesktopWebView load zero size view test missing
https://bugs.webkit.org/show_bug.cgi?id=68655
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-27
Reviewed by Chang Shu.
Added test case to check load behavior with zero size view.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 12:55 PM Changeset in webkit [96144] by
-
- 4 edits3 copies in trunk/Tools
watchlist: Add the filename pattern for definitions.
https://bugs.webkit.org/show_bug.cgi?id=68917
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
- Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
for definitions.
- Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
- 12:53 PM Changeset in webkit [96143] by
-
- 11 edits in trunk/Source/JavaScriptCore
De-virtualize JSCell::getPrimitiveNumber
https://bugs.webkit.org/show_bug.cgi?id=68851
Reviewed by Darin Adler.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Changed JSCell::getPrimitiveNumber to manually handle the dispatch for
JSCells (JSObject and JSString in this case).
- runtime/JSCell.cpp:
(JSC::JSCell::getPrimitiveNumber):
- runtime/JSCell.h:
Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't
matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
can cover the case for JSNotAnObject.
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber
and changed them to be const. Also made JSString::getPrimitiveNumber public
because it needs to be called from JSCell::getPrimitiveNumber and also since it's
no longer virtual, we want people who have a more specific pointer (JSString*
instead of JSCell*) to not have to pay the cost of a virtual method call.
- runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
- runtime/JSObject.h:
- runtime/JSString.cpp:
(JSC::JSString::getPrimitiveNumber):
- runtime/JSString.h:
- 12:49 PM Changeset in webkit [96142] by
-
- 12 edits3 copies2 adds in trunk/Source/WebCore
Add 'filter' value to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=68471
Reviewed by Simon Fraser.
Add a filter property to RenderStyle when ENABLE(CSS_FILTERS)
is turned on. Similar to -webkit-transform, -webkit-filter is a
list of FilterOperations, each identifying what type of operation
it is. This change simply adds the basic objects, it does not
parse the property to generate the list.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FilterOperation.h: Added.
(WebCore::FilterOperation::~FilterOperation):
(WebCore::FilterOperation::operator!=):
(WebCore::FilterOperation::getOperationType):
(WebCore::FilterOperation::isSameType):
(WebCore::FilterOperation::FilterOperation):
(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::reference):
(WebCore::ReferenceFilterOperation::operator==):
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::BasicColorMatrixFilterOperation::create):
(WebCore::BasicColorMatrixFilterOperation::amount):
(WebCore::BasicColorMatrixFilterOperation::operator==):
(WebCore::BasicColorMatrixFilterOperation::BasicColorMatrixFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::create):
(WebCore::BasicComponentTransferFilterOperation::amount):
(WebCore::BasicComponentTransferFilterOperation::operator==):
(WebCore::BasicComponentTransferFilterOperation::BasicComponentTransferFilterOperation):
(WebCore::GammaFilterOperation::create):
(WebCore::GammaFilterOperation::amplitude):
(WebCore::GammaFilterOperation::exponent):
(WebCore::GammaFilterOperation::offset):
(WebCore::GammaFilterOperation::operator==):
(WebCore::GammaFilterOperation::GammaFilterOperation):
(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::operator==):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::amount):
(WebCore::SharpenFilterOperation::operator==):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):
(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::shadow):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
- platform/graphics/filters/FilterOperations.cpp: Added.
(WebCore::FilterOperations::FilterOperations):
(WebCore::FilterOperations::operator==):
- platform/graphics/filters/FilterOperations.h: Added.
(WebCore::FilterOperations::operator!=):
(WebCore::FilterOperations::clear):
(WebCore::FilterOperations::operations):
(WebCore::FilterOperations::size):
(WebCore::FilterOperations::at):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::filter):
(WebCore::InheritedFlags::hasFilter):
(WebCore::InheritedFlags::setFilter):
(WebCore::InheritedFlags::initialFilter):
- rendering/style/StyleAllInOne.cpp: Added include of new StyleFilterData.
- rendering/style/StyleFilterData.cpp: Added.
(WebCore::StyleFilterData::StyleFilterData):
(WebCore::StyleFilterData::operator==):
- rendering/style/StyleFilterData.h: Added.
(WebCore::StyleFilterData::create):
(WebCore::StyleFilterData::copy):
(WebCore::StyleFilterData::operator!=):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h: New filter DataRef.
- 12:41 PM Changeset in webkit [96141] by
-
- 29 edits1 copy2 adds in trunk/Source/WebCore
[chromium] LayerRenderChromium asserts about leaking textures.
https://bugs.webkit.org/show_bug.cgi?id=68190
Reviewed by Kenneth Russell.
This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(WebCore::TextureAllocator::~TextureAllocator):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
- platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- 12:34 PM Changeset in webkit [96140] by
-
- 5 edits in trunk/Source/WebKit/efl
[EFL] Make ewk_view emit the "load,document,finished" signal.
https://bugs.webkit.org/show_bug.cgi?id=66782
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-27
Reviewed by Antonio Gomes.
Currently, only ewk_frame emits the "load,document,finished" signal
when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
ewk_frame_load_document_finished().
However, in some cases it is not even possible to connect to the
"frame,created" signal to properly monitor the
"load,document,finished" signal, as the former is not emitted.
fast/frames/frame-unload-crash.html, for example, has a page with an
iframe inside an iframe, and this innermost iframe does not seem to be
loaded via FrameLoaderClientEfl::createFrame (which calls all the
machinery which then emits the "frame,created" signal).
We now make ewk_frame_load_document_finished() call the newly-created
ewk_view_load_document_finished() function, whose job is to emit the
"load,document,signal" with the frame as its parameter. This way, one
can just connect to the view and make sure all the signals will get
delivered.
- ewk/ewk_frame.cpp:
(ewk_frame_load_document_finished):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(ewk_view_load_document_finished):
- ewk/ewk_view.h:
- 12:31 PM Changeset in webkit [96139] by
-
- 4 edits2 adds in trunk
Reviewed by David Hyatt.
Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447
Source/WebCore:
If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.
Test: fast/replaced/table-percent-width.html
- rendering/RenderBox.cpp:
(WebCore::avoidSqueezingWidth):
(WebCore::avoidSqueezingHeight):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/RenderBox.h:
LayoutTests:
- fast/replaced/table-percent-width.html: Added.
- fast/replaced/table-percent-width-expected.txt: Added.
- 12:00 PM Changeset in webkit [96138] by
-
- 9 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=67858
Roll r96070 back in now that the crash has been fixed in r96130.
Source/WebCore:
Reviewed by Darin Adler.
When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.
Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
- platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
- rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.
LayoutTests:
- compositing/iframes/repaint-after-losing-scrollbars-expected.png:
- 11:44 AM Changeset in webkit [96137] by
-
- 2 edits in trunk/Source/WebCore
Fix Chromium Mac build after r96130.
- page/FrameView.cpp:
(WebCore::FrameView::layerForOverhangAreas):
- 11:32 AM Changeset in webkit [96136] by
-
- 5 edits3 adds in trunk/Source/WebKit2
[GTK] Use WebKitWebContext in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=67990
Reviewed by Martin Robinson.
Use webkit_web_context_get_default() instead of
WKContextGetSharedProcessContext() and add API to create a view
with a given web context and to return the current context
associated to the view.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetWKContext): Private API to get the WKContext
wrapped by the WebKitWebContext.
- UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the webpage using the web
context of the view.
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_init):
(webkit_web_view_class_init):
(webkit_web_view_new): Create a new view with the default context.
(webkit_web_view_new_with_context): Create a new view with the
given context.
(webkit_web_view_get_context): Return the context.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/tests/testwebview.c: Added.
(testWebViewDefaultContext):
(main):
- 11:19 AM Changeset in webkit [96135] by
-
- 2 edits in trunk
[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.
Install the flag, which indicates whether or not the optimization
script was executed, on the global object.
https://bugs.webkit.org/show_bug.cgi?id=68890
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
- Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
- 11:17 AM Changeset in webkit [96134] by
-
- 3 edits2 adds in trunk
Autofocus on readonly inputs does not focus the element.
https://bugs.webkit.org/show_bug.cgi?id=24092
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-09-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
Readonly input elements should be autofocusable. Removed the check.
Tests: fast/forms/autofocus-readonly-attribute.html
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
LayoutTests:
- fast/forms/autofocus-readonly-attribute-expected.txt: Added.
- fast/forms/autofocus-readonly-attribute.html: Added.
- 11:06 AM Changeset in webkit [96133] by
-
- 3 edits1 copy3 adds in trunk/Source/WebKit2
[GTK] Add WebKitWebContext to GTK API
https://bugs.webkit.org/show_bug.cgi?id=67931
Reviewed by Philippe Normand.
Initial implementation of WebKitWebContext for WebKit2 GTK API.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebContext.cpp: Added.
(webkitWebContextFinalize):
(webkit_web_context_init):
(webkit_web_context_class_init):
(createDefaultWebContext):
(webkit_web_context_get_default):
- UIProcess/API/gtk/WebKitWebContext.h: Added.
- UIProcess/API/gtk/tests/testwebcontext.c:
(testWebContextDefault):
(main):
- UIProcess/API/gtk/webkit2.h: Add <webkit2/WebKitWebContext.h>.
- 11:04 AM Changeset in webkit [96132] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
https://bugs.webkit.org/show_bug.cgi?id=68915
Reviewed by Ryosuke Niwa.
r92496 and r92881 were only trying to move the baselines to
platform/mac-snowleopard/platform/mac/fast, but they also inadvertedly
copied the test itself.
- platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
- 10:58 AM Changeset in webkit [96131] by
-
- 14 edits3 adds in trunk
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Patch by Juan Carlos Montemayor Elosua <j.mont@me.com> on 2011-09-27
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(JSC::StackFrame::toString):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
- parser/Parser.h:
(JSC::Parser::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
LayoutTests:
Unit tests that contain both normal and special cases for stack trace
generation.
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
- fast/js/stack-trace-expected.txt: Added.
- fast/js/stack-trace.html: Added.
- platform/chromium/test_expectations.txt:
- 10:55 AM Changeset in webkit [96130] by
-
- 2 edits in trunk/Source/WebCore
Clean up how FrameView accesses the RenderView
https://bugs.webkit.org/show_bug.cgi?id=68914
Reviewed by Sam Weinig.
Clean up how FrameView accesses the content renderer of its
frame. Previously, this was done in several different ways,
only some of which did null-checking.
Use an inline method to avoid having to expose Frame
in the header.
Standardize the terminology to use 'root' for this RenderView.
- page/FrameView.cpp:
(WebCore::rootRenderer):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):
- 10:53 AM Changeset in webkit [96129] by
-
- 2 edits in trunk/Tools
garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488
Reviewed by Andy Estes.
Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time. That confused one user study
participant. This patch sorts the lists so that they occur in a
predictable order.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 10:38 AM Changeset in webkit [96128] by
-
- 2 edits1 add in trunk/LayoutTests
[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed rebaseline.
- platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:29 AM Changeset in webkit [96127] by
-
- 3 edits2 adds in trunk
AXObjectCache cleared unnecessarily when non-top Document is detached.
https://bugs.webkit.org/show_bug.cgi?id=68636
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-27
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/deleting-iframe-destroys-axcache.html
- dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::detach):
LayoutTests:
- accessibility/deleting-iframe-destroys-axcache.html: Added.
- platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
- 10:27 AM Changeset in webkit [96126] by
-
- 55 edits in trunk
Unreviewed, rolling out r96108, r96111, r96113, and r96116.
http://trac.webkit.org/changeset/96108
http://trac.webkit.org/changeset/96111
http://trac.webkit.org/changeset/96113
http://trac.webkit.org/changeset/96116
https://bugs.webkit.org/show_bug.cgi?id=68913
Wait for working Qt5 (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
.:
- Source/WebKit.pro:
Source/WebCore:
- WebCore.pri:
- platform/graphics/qt/GraphicsLayerQt.cpp:
Source/WebKit/qt:
- Api/qgraphicswebview.cpp:
- Api/qgraphicswebview.h:
- Api/qwebframe.h:
- Api/qwebhistory.h:
- Api/qwebpage.h:
- Api/qwebsettings.h:
- Api/qwebview.h:
- QtWebKit.pro:
- WebCoreSupport/PageClientQt.h:
- WebCoreSupport/QtWebComboBox.cpp:
- WebCoreSupport/QtWebComboBox.h:
- declarative/declarative.pro:
- declarative/qdeclarativewebview.cpp:
- declarative/qdeclarativewebview_p.h:
- docs/webkitsnippets/webpage/main.cpp:
- examples/platformplugin/WebNotificationPresenter.h:
- tests/tests.pri:
Source/WebKit2:
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::chooseFiles):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/tests/tests.pri:
- UIProcess/API/qt/tests/tests.pro:
- UIProcess/qt/ViewInterface.h:
- UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView):
- MiniBrowser/qt/BrowserView.h:
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.h:
- MiniBrowser/qt/main.cpp:
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/locationedit.h:
- QtTestBrowser/main.cpp:
- QtTestBrowser/mainwindow.cpp:
- QtTestBrowser/mainwindow.h:
- QtTestBrowser/webinspector.h:
- QtTestBrowser/webpage.cpp:
- QtTestBrowser/webview.cpp:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::wkView):
(WTR::WebView::pageRef):
(WTR::WebView::~WebView):
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 10:26 AM Changeset in webkit [96125] by
-
- 3 edits6 adds26 deletes in trunk/LayoutTests
dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html
https://bugs.webkit.org/show_bug.cgi?id=68857
Reviewed by Kent Tamura.
Converted the tests into dump-as-markup tests. Also split each test into two tests.
- editing/pasteboard/merge-end-list-2-expected.txt: Added.
- editing/pasteboard/merge-end-list-2.html: Added.
- editing/pasteboard/merge-end-list-expected.txt: Added.
- editing/pasteboard/merge-end-list.html:
- editing/pasteboard/merge-end-table-2-expected.txt: Added.
- editing/pasteboard/merge-end-table-2.html: Added.
- editing/pasteboard/merge-end-table-expected.txt: Added.
- editing/pasteboard/merge-end-table.html:
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/gtk/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/gtk/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/gtk/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/gtk/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/mac/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/mac/editing/pasteboard/merge-end-table-expected.txt: Removed.
- platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
- platform/qt/editing/pasteboard/merge-end-list-expected.txt: Removed.
- platform/qt/editing/pasteboard/merge-end-table-expected.png: Removed.
- platform/qt/editing/pasteboard/merge-end-table-expected.txt: Removed.
- 10:18 AM Changeset in webkit [96124] by
-
- 1 edit2 adds in trunk/LayoutTests
Crash in WebCore::HTMLParser::createHead
https://bugs.webkit.org/show_bug.cgi?id=32426
Reviewed by Darin Adler.
The crash was fixed some time ago but the test was not landed which kept the bug open.
- fast/parser/crash-HTMLParser-createHead.html: Added.
Tweaked the test case as we now throw an exception (DOM Exception 12).
- 10:06 AM Changeset in webkit [96123] by
-
- 7 edits in trunk/Source/WebCore
Fix ENABLE(SQL_DATABASE)=0 build after r95919
https://bugs.webkit.org/show_bug.cgi?id=68902
r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.
Reviewed by Adam Barth.
- platform/sql/SQLiteAuthorizer.cpp:
- platform/sql/SQLiteDatabase.cpp:
- platform/sql/SQLiteFileSystem.cpp:
- platform/sql/SQLiteStatement.cpp:
- platform/sql/SQLiteTransaction.cpp:
- storage/DatabaseAuthorizer.cpp:
- 9:55 AM Changeset in webkit [96122] by
-
- 3 edits2 adds in trunk
Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/crash-set-font.html
This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
list as Font::update was never called.
The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
Until this happens, it is better not to crash.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
mutated by the previous property change. Also added a comment explaining why it is safe to do it
this way.
LayoutTests:
- fast/canvas/crash-set-font-expected.txt: Added.
- fast/canvas/crash-set-font.html: Added.
- 9:40 AM Changeset in webkit [96121] by
-
- 7 edits1 move in trunk
[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
https://bugs.webkit.org/show_bug.cgi?id=65178
Reviewed by Martin Robinson.
Source/WebKit2:
- GNUmakefile.am: Add webkit2.h.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
- webkit2gtk.pc.in: Use webkitgtk-<api-version> as include dir.
Tools:
- GNUmakefile.am:
- GtkLauncher/main.c: Include <webkit2/webkit2.h>.
- 9:38 AM Changeset in webkit [96120] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
https://bugs.webkit.org/show_bug.cgi?id=68897
Reviewed by Andreas Kling.
No new functionality so no new tests.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::syncCompositingState):
- platform/graphics/texmap/TextureMapperNode.h:
- 9:28 AM Changeset in webkit [96119] by
-
- 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: http://codereview.chromium.org/8055019
- 9:28 AM Changeset in webkit [96118] by
-
- 6 edits in trunk/Source/WebCore
[Texmap][Qt] Refactor texture-upload to allow direct chunk update
https://bugs.webkit.org/show_bug.cgi?id=68808
Add a function to BitmapTexture for direct pixel updates.
Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
to RGBA swizzling is done inside that function, there's no need for the
RGBA32PremultipliedBuffer class to contain such function. Also,
RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
an old mistake.
Reviewed by Andreas Kling.
No new tests. Existing tests in LayoutTests/compositing test this.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/opengl/TextureMapperGL.h:
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
- platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
- platform/graphics/qt/TextureMapperQt.h:
- platform/graphics/texmap/TextureMapper.h:
- 9:21 AM Changeset in webkit [96117] by
-
- 1 edit2 copies in branches/chromium/874
Merge 95926 - <rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
BUG=97952
Review URL: http://codereview.chromium.org/8052011
- 9:12 AM Changeset in webkit [96116] by
-
- 6 edits in trunk
[Qt][WK2] Buildfix after r96108.
Rubber-stamped by Andreas Kling.
Source/WebKit/qt:
- tests/tests.pri:
Tools:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 8:52 AM Changeset in webkit [96115] by
-
- 3 edits in trunk/Tools
watchlist: Change watchlistparser.py to be class based.
https://bugs.webkit.org/show_bug.cgi?id=68869
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 8:50 AM Changeset in webkit [96114] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followupfix for r96110.
This is a small adjustment of the heap size delta calculation.
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
- 8:37 AM WebKitGTK/Releasing edited by
- Added link to make patch (diff)
- 8:36 AM Changeset in webkit [96113] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix build of declarative plugin against Qt5
Reviewed by Andreas Kling.
- declarative/declarative.pro:
- 8:35 AM Changeset in webkit [96112] by
-
- 2 edits1 add in trunk/Tools
watchlist: Break out the diff boilerplate to allow for re-use.
https://bugs.webkit.org/show_bug.cgi?id=68871
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
Break out the diff into a new file.
- Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
- 8:29 AM Changeset in webkit [96111] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix build of WebKit2 unit-tests after r96108
Reviewed by Andreas Kling.
- UIProcess/API/qt/tests/tests.pri:
- 8:26 AM Changeset in webkit [96110] by
-
- 5 edits in trunk
Web Inspector: UI performance: introduce heap size tracking stats.
https://bugs.webkit.org/show_bug.cgi?id=68901
It is interesting how much the heap memory is used by Inspector in order of running the test.
Reviewed by Yury Semikhatsky.
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::showDevTools):
(TestShell::closeDevTools):
LayoutTests:
- inspector/performance/resources/network-append-30-requests.html:
- inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
- 8:17 AM Changeset in webkit [96109] by
-
- 5 edits in trunk/LayoutTests
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=68852
Rebaseline GPU tests for Mac, Win.
Reviewed by Shinichiro Hamaji.
- platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
- platform/chromium/test_expectations.txt:
- 8:11 AM Changeset in webkit [96108] by
-
- 49 edits in trunk
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.
https://bugs.webkit.org/show_bug.cgi?id=68687
Reviewed by Andreas Kling.
- 7:49 AM Changeset in webkit [96107] by
-
- 8 edits in trunk/LayoutTests
Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68577
Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
- platform/chromium-linux-x86/fast/box-shadow: Removed.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium/test_expectations.txt:
- 7:13 AM Changeset in webkit [96106] by
-
- 16 edits in trunk
Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
- dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
- inspector/Inspector.draft-01.json:
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype._setAttribute):
(WebInspector.DOMNode.prototype._removeAttribute):
(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._attributeRemoved):
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMDispatcher.prototype.attributeModified):
(WebInspector.DOMDispatcher.prototype.attributeRemoved):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype):
- inspector/validate-protocol-compatibility:
LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
- inspector/elements/mutate-unknown-node.html-disabled:
- inspector/elements/set-attribute.html:
- 7:09 AM Changeset in webkit [96105] by
-
- 14 edits1 add in trunk
[Qt][WK2] Add support for hover API in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68369
Reviewed by Andreas Kling.
Source/WebKit2:
Based on the patch from Igor Oliveira in the same bug.
Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
QString corresponding to the link title. I left textContent out because was
unsure of its use case.
In QDesktopWebView we store the last URL and title emitted to make sure we send
the signal only if either value changes. Tests were added to the QML element to
check: if values are correctly emitted and if we don't emit more signals than
necessary.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didMouseMoveOverElement):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/test2.html:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/qt/ClientImpl.cpp:
(qt_wk_mouseDidMoveOverElement):
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
- UIProcess/qt/TouchViewInterface.h:
(WebKit::TouchViewInterface::didMouseMoveOverElement):
- UIProcess/qt/ViewInterface.h:
Tools:
Change the statusbar to show the link URL when hovering links in
MiniBrowser using QDesktopWebView.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLinkHovered):
- MiniBrowser/qt/BrowserWindow.h:
- 6:23 AM Changeset in webkit [96104] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
- DEPS:
- 6:12 AM Changeset in webkit [96103] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 6:00 AM Changeset in webkit [96102] by
-
- 10 edits in trunk
Unreviewed, rolling out r96070 and r96075.
http://trac.webkit.org/changeset/96070
http://trac.webkit.org/changeset/96075
https://bugs.webkit.org/show_bug.cgi?id=68893
WK2 tests started crashing after r96070 for SL and Qt
(Requested by torarne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner):
- platform/ScrollableArea.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::imageChanged):
LayoutTests:
- compositing/iframes/repaint-after-losing-scrollbars-expected.png:
- platform/qt/Skipped:
- 5:58 AM Changeset in webkit [96101] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
https://bugs.webkit.org/show_bug.cgi?id=68889
Reviewed by Andreas Kling.
Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.h:
- 5:39 AM Changeset in webkit [96100] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
https://bugs.webkit.org/show_bug.cgi?id=67732
Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.
Reviewed by Pavel Feldman.
- src/js/Tests.js:
(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):
- 5:34 AM Changeset in webkit [96099] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed typo fix.
- platform/chromium/test_expectations.txt:
- 5:21 AM Changeset in webkit [96098] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: JS exception upon clicking on "Word Wrap" checkbox in Settings screen
https://bugs.webkit.org/show_bug.cgi?id=68888
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
- 5:06 AM Changeset in webkit [96097] by
-
- 7 edits in trunk
Web Inspector: migrate RawSourceCode clients to SourceMapping class.
https://bugs.webkit.org/show_bug.cgi?id=68524
Source/WebCore:
Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.
Reviewed by Yury Semikhatsky.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get sourceMapping):
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/raw-source-code.html:
- 4:20 AM Changeset in webkit [96096] by
-
- 3 edits2 adds in trunk
wrap attribute of textarea element cannot be accessed by JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=68592
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Added JS interface for wrap attribute to HTMLTextAreaElement.idl.
Test: fast/forms/textarea-wrap-attribute.html
- html/HTMLTextAreaElement.idl:
LayoutTests:
Added test cases to check accessibility to wrap attribute by JS.
- fast/forms/textarea-wrap-attribute-expected.txt: Added.
- fast/forms/textarea-wrap-attribute.html: Added.
- 3:43 AM Changeset in webkit [96095] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6
Bump the release number to 1.6.1 and add the NEWS information
- 3:33 AM Changeset in webkit [96094] by
-
- 3 edits in releases/WebKitGTK/webkit-1.6/Source/WebCore
- 3:28 AM Changeset in webkit [96093] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Add compatibility methods for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68884
Reviewed by Philippe Normand.
Add compatibility methods for our DOM bindings.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_blob_slice): alias to the new method name.
(webkit_dom_html_form_element_dispatch_form_change): this was
removed from WebCore, so just print a warning about it.
(webkit_dom_html_form_element_dispatch_form_input): ditto.
- bindings/gobject/WebKitDOMCustom.h:
- 3:22 AM Changeset in webkit [96092] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
- DEPS:
- 3:15 AM Changeset in webkit [96091] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast compositing/geometry/limit-layer-bounds-transformed-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68886
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 3:06 AM Changeset in webkit [96090] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 2:56 AM Changeset in webkit [96089] by
-
- 2 edits in trunk/LayoutTests
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68852
Unreviewed test_expectations.txt update. We may need GPU-CG, too.
- platform/chromium/test_expectations.txt:
- 2:51 AM Changeset in webkit [96088] by
-
- 2 edits in trunk/LayoutTests
[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 2:35 AM Changeset in webkit [96087] by
-
- 8 edits in trunk
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Initialize $libwebkitgtkincludedir to
$(prefix)/include/webkitgtk-<api-version>
Source/JavaScriptCore:
Install header files under $libwebkitgtkincludedir/JavaScriptCore.
- GNUmakefile.am: Use $libwebkitgtkincludedir.
- javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.
Source/WebKit/gtk:
Install header files under $libwebkitgtkincludedir/webkit.
- GNUmakefile.am: Use $libwebkitgtkincludedir.
- webkit.pc.in: Use webkitgtk-<api-version> as include dir.
- 2:31 AM Changeset in webkit [96086] by
-
- 2 edits in trunk/LayoutTests
[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=68881
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 2:24 AM Changeset in webkit [96085] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK gardening
- platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
in 32-Bits Release.
- platform/gtk/test_expectations.txt: Mark
media/video-timeupdate-reverse-play.html as flaky because of bug 67407.
- 2:00 AM Changeset in webkit [96084] by
-
- 6 edits in trunk/Source/WebCore
Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
https://bugs.webkit.org/show_bug.cgi?id=68875
Reviewed by Kent Tamura.
Added InsertedNode class inside ReplaceSelection to encapsulate m_firstNodeInserted and m_lastLeafInserted.
Deployed it in removeRedundantStylesAndKeepStyleSpanInline, doApply, and insertAsListItems of ReplaceSelectionCommand.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::respondToNodeInsertion):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::InsertedNodes::firstNodeInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::lastLeafInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
- editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval): Moved from DeleteSelectionCommand.cpp.
- editing/htmlediting.h:
- 1:56 AM Changeset in webkit [96083] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 1:33 AM Changeset in webkit [96082] by
-
- 6 edits2 adds in trunk
Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.
https://bugs.webkit.org/show_bug.cgi?id=60972
Patch by Arun Patole <bmf834@motorola.com> on 2011-09-27
Reviewed by Philippe Normand.
Source/WebCore:
The paused attribute should be set to true and the media element should emit a 'paused' at the end of playback.
WHATWG revision r6562: http://html5.org/tools/web-apps-tracker?from=6561&to=6562
Test: media/media-element-play-after-eos.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): set m_paused to true and schedule 'pause' event when playback ended.
LayoutTests:
Update media tests as the 'pause' event should be fired
and 'paused' should be set to true at the end of playback.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- media/media-element-play-after-eos-expected.txt: Added.
- media/media-element-play-after-eos.html: Added.
- media/video-loop-expected.txt:
- 1:21 AM Changeset in webkit [96081] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/Skipped:
Skip outdated canvas/philip/tests/2d.drawImage.outsidesource.html.
- platform/gtk/test_expectations.txt:
media/video-playing-and-pause.html is flaky.
- 1:08 AM Changeset in webkit [96080] by
-
- 5 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline after r95845, r95897 and r95857.
- platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/gtk/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
- platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
- 12:55 AM Changeset in webkit [96079] by
-
- 5 edits in trunk/Source/WebKit2
[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
https://bugs.webkit.org/show_bug.cgi?id=68848
Reviewed by Andreas Kling.
The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qwebnavigationcontroller.h:
- 12:34 AM Changeset in webkit [96078] by
-
- 4 edits2 adds in trunk
<input> with autofocus doesn't lose focus when it has a certain onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/autofocus-focus-only-once.html
These changes make sure that an element is focused only once when autofocus attribute is used.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::attach):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::hasAutofocused):
(WebCore::HTMLFormControlElement::setAutofocused):
LayoutTests:
These changes make sure that an element is focused only once when autofocus attribute is used.
- fast/forms/autofocus-focus-only-once-expected.txt: Added.
- fast/forms/autofocus-focus-only-once.html: Added.
- 12:05 AM Changeset in webkit [96077] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Add missing test expecteds after r95924.
Unreviewed gardening.
- platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
- platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
