Timeline
Apr 16, 2012:
- 11:51 PM April 2012 Meeting edited by
- (diff)
- 11:45 PM Changeset in webkit [114352] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files.
Source/WebCore:
- GNUmakefile.list.am: Add missing files.
- 11:40 PM Changeset in webkit [114351] by
-
- 106 edits1 add in trunk/Source/WebCore
insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701
Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.
This change makes following change to merge these functions.
- pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
- letting new Node::insertInto() do the job for its own, but not for its children and
- Pass the parent of each insertion root as a parameter of insertedInto(). This root node can tell inserted node where it is inserted, specifically whetehr the insertion is to the document or not.
Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.
Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.
Caveat:
There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that. It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.
No new tests. Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):
- dom/ContainerNode.h:
(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):
- dom/ContainerNodeAlgorithms.cpp: Added.
(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
- dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):
- dom/DOMAllInOne.cpp:
- dom/DocumentType.cpp:
(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):
- dom/DocumentType.h:
(DocumentType):
- dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- dom/Element.h:
(Element):
- dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):
- dom/Node.h:
(Node):
(WebCore::Node::didNotifyDescendantInseretions):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
- dom/ProcessingInstruction.h:
(ProcessingInstruction):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::insertedInto):
- dom/ScriptElement.h:
(WebCore):
(ScriptElement):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
- dom/ShadowTree.h:
(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
- html/FormAssociatedElement.h:
(FormAssociatedElement):
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):
- html/HTMLBaseElement.h:
(HTMLBaseElement):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):
- html/HTMLFormElement.h:
(HTMLFormElement):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):
- html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):
- html/HTMLInputElement.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
- html/HTMLLinkElement.h:
(HTMLLinkElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
- html/HTMLMapElement.h:
(HTMLMapElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::insertedInto):
- html/HTMLMetaElement.h:
(HTMLMetaElement):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):
- html/HTMLObjectElement.h:
(HTMLObjectElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto):
- html/HTMLOptionElement.h:
(HTMLOptionElement):
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
- html/HTMLQuoteElement.h:
(HTMLQuoteElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
- html/HTMLScriptElement.h:
(HTMLScriptElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto):
- html/HTMLSelectElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
- html/HTMLSourceElement.h:
(HTMLSourceElement):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
- html/HTMLStyleElement.h:
(HTMLStyleElement):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
- html/HTMLTextFormControlElement.h:
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):
- html/HTMLTitleElement.h:
(HTMLTitleElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto):
- html/HTMLTrackElement.h:
(HTMLTrackElement):
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
- mathml/MathMLMathElement.h:
(MathMLMathElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):
- svg/SVGFEImageElement.h:
(SVGFEImageElement):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):
- svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::insertedInto):
- svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):
- svg/SVGGlyphElement.h:
(SVGGlyphElement):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGHKernElement.h:
(SVGHKernElement):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::insertedInto):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
- svg/SVGSVGElement.h:
(SVGSVGElement):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
- svg/SVGScriptElement.h:
(SVGScriptElement):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):
- svg/SVGStyleElement.h:
(SVGStyleElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
- svg/SVGStyledElement.h:
(SVGStyledElement):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):
- svg/SVGTRefElement.h:
(SVGTRefElement):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
- svg/SVGTitleElement.h:
(SVGTitleElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
- svg/SVGUseElement.h:
(SVGUseElement):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- svg/SVGVKernElement.h:
(SVGVKernElement):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
- 11:26 PM Changeset in webkit [114350] by
-
- 3 edits3 adds in trunk
Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
- http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
- http/tests/css/css-imports-redirect-cycle.css: Added.
- http/tests/css/css-imports-redirect-cycle.html: Added.
- 11:22 PM Changeset in webkit [114349] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 11:11 PM Changeset in webkit [114348] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054
- chromium/public/WebFilterOperations.h:
(WebKit): WebFilterOperation is a struct, not a class.
- 10:57 PM Changeset in webkit [114347] by
-
- 5 edits1 move in trunk/Source
Rename LocalizedNumberICU.h to ICULocale.h
https://bugs.webkit.org/show_bug.cgi?id=84119
Reviewed by Kentaro Hara.
Source/WebCore:
LocalizedNumberICU.h contains only ICULocale class. It should be
named as ICULocale.h. We're going to move some functions in
LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale,
and add unit tests for them.
- WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h
- platform/text/ICULocale.h:
Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h.
- platform/text/LocalizedNumberICU.cpp:
Rename LocalizedNumberICU.h to ICULocale.h
Source/WebKit/chromium:
- tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h
- 10:49 PM Changeset in webkit [114346] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip one more worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125
- platform/chromium/test_expectations.txt:
- 10:46 PM Changeset in webkit [114345] by
-
- 1 edit2 adds in trunk/Source/WebKit2
[EFL][WK2] Add missing files to build webkit2/Efl.
https://bugs.webkit.org/show_bug.cgi?id=76139
Reviewed by Ryosuke Niwa.
Add missing files needed to build webkit2/Efl.
- Shared/efl/PlatformCertificateInfo.h: Added.
(WebKit):
(PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
- UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Added.
(WebKit):
(WebKit::ThreadLauncher::createWebThread):
- 10:36 PM Changeset in webkit [114344] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066
Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.
WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
- platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
- 10:28 PM Changeset in webkit [114343] by
-
- 8 edits4 adds in trunk/Source
[chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebFilterOperation.h: Added.
(WebKit):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBlurFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebDropShadowFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):
- chromium/public/WebFilterOperations.h: Added.
(WebKit):
(WebFilterOperations):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
Source/WebCore:
Adds WebFilterOperation that wraps WebCore::FilterOperation and
WebFilterOperations that wraps WebCore::FilterOperations.
We add support for most of the FilterOperation subclasses, and
allow the user to set the WebFilterOperations for both layer
content filters and background filters.
- WebCore.gypi:
- platform/chromium/support/WebFilterOperation.cpp: Added.
(WebKit):
(WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation):
(WebKit::WebBlurFilterOperation::toFilterOperation):
(WebKit::WebDropShadowFilterOperation::toFilterOperation):
- platform/chromium/support/WebFilterOperations.cpp: Added.
(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::toFilterOperations):
Source/WebKit/chromium:
- WebKit.gyp:
- src/WebLayer.cpp:
(WebKit::WebLayer::setFilters):
(WebKit):
(WebKit::WebLayer::setBackgroundFilters):
- 10:08 PM Changeset in webkit [114342] by
-
- 2 edits in trunk/Source/WebCore
Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.
No new tests. The repro steps require using Chrome notifications on Win.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 10:08 PM Changeset in webkit [114341] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove invalid text expectation for Snow Leopard.
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
- 10:07 PM Changeset in webkit [114340] by
-
- 1 copy in tags/Safari-534.57.1
New tag.
- 9:32 PM Changeset in webkit [114339] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove useless text expectation for WinXP
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
- 9:09 PM Changeset in webkit [114338] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125
- platform/chromium/test_expectations.txt:
- 8:58 PM Changeset in webkit [114337] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
- DEPS:
- 8:42 PM Changeset in webkit [114336] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116
Reviewed by Kentaro Hara.
This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().
- src/WebPagePopupImpl.h:
(WebPagePopupImpl): Rename an argument name.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().
- 8:38 PM April 2012 Meeting edited by
- (diff)
- 8:04 PM Changeset in webkit [114335] by
-
- 16 edits2 copies1 move in trunk/Source
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
https://bugs.webkit.org/show_bug.cgi?id=83963
Reviewed by Adrienne Walker.
Source/Platform:
Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface.
- Platform.gypi:
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebLayer.h:
(WebLayer):
(WebKit::WebLayer::unwrap):
- chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h.
(WebKit):
(WebVideoFrameProvider):
(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider):
(Client):
- chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::~WebVideoLayer):
Source/WebCore:
Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a
WebCore VideoFrameProvider.
- WebCore.gypi:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
- platform/graphics/chromium/VideoLayerChromium.h:
(WebKit):
(WebCore):
(VideoLayerChromium):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):
(CCVideoLayerImpl):
Source/WebKit/chromium:
Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it.
WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer()
interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer.
- WebKit.gyp:
- src/WebContentLayer.cpp:
- src/WebLayer.cpp:
(WebKit::WebLayer::invalidate):
(WebKit):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
- 7:55 PM Changeset in webkit [114334] by
-
- 6 edits in trunk
[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010
Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-16
Reviewed by Hajime Morita.
This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point
Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.
- html/shadow/InsertionPoint.h:
(InsertionPoint):
Added isActive public method.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.
- 7:33 PM April 2012 Meeting edited by
- (diff)
- 7:15 PM Changeset in webkit [114333] by
-
- 3 edits in trunk/Source/WebCore
Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299
Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.
Reviewed by Antti Koivisto.
No new tests. No bahavior change.
- dom/Node.cpp:
(WebCore):
- dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):
- 7:02 PM Changeset in webkit [114332] by
-
- 2 edits in trunk/Tools
[GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball
- 6:06 PM Changeset in webkit [114331] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110150
- 5:55 PM Changeset in webkit [114330] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107
broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
- fast/media/media-query-list-08-expected.txt: Removed.
- fast/media/media-query-list-08.html: Removed.
- platform/qt/Skipped:
- 5:48 PM Changeset in webkit [114329] by
-
- 5 edits1 add in trunk/Source/WebKit/chromium
Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebMediaPlayer.h:
(WebKit):
- public/WebMediaPlayerClient.h:
- public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.
(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):
- src/AssertMatchingEnums.cpp:
- 5:47 PM WebKitGTK/1.8.x edited by
- (diff)
- 5:47 PM Changeset in webkit [114328] by
-
- 3 edits in trunk/Source/WebCore
Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100
Reviewed by Alexey Proskuryakov.
No new tests, removing dead code.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):
- 5:35 PM Changeset in webkit [114327] by
-
- 2 edits in trunk/Source/WebKit2
Followup to http://trac.webkit.org/changeset/114323
For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.
Reviewed by Mark Rowe.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- 5:35 PM Changeset in webkit [114326] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r114322.
http://trac.webkit.org/changeset/114322
https://bugs.webkit.org/show_bug.cgi?id=84096
Didn't make the debug bot happy, so back out
- gtk/jhbuild.modules:
- 5:28 PM Changeset in webkit [114325] by
-
- 6 edits in trunk/Source/WebCore
Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
<http://webkit.org/b/83988>
Reviewed by Antti Koivisto.
Remove the 'context style sheet' argument to <font face> value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.
- css/CSSParser.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
- css/CSSValuePool.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
- 5:21 PM Changeset in webkit [114324] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543
Reviewed by Adrienne Walker.
It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.
One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.
Covered by existing tests.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- 5:21 PM Changeset in webkit [114323] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit
Reviewed by Jessie Berlin.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one.
- 5:18 PM Changeset in webkit [114322] by
-
- 2 edits in trunk/Tools
[GTK] Try to fix debug bot by adding gobject-introspection to the build
https://bugs.webkit.org/show_bug.cgi?id=84096
Unreviewed speculative build fix.
- gtk/jhbuild.modules: Added gobject-introspection, since modules need
an up-to-date introspection m4 for running autogen.
- 5:17 PM Changeset in webkit [114321] by
-
- 2 edits in trunk/LayoutTests
Add two flaky tests in fast/profiler.
- platform/mac/Skipped:
- 4:53 PM Changeset in webkit [114320] by
-
- 3 edits2 adds in trunk
[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831
Reviewed by Nate Chapin.
Source/WebCore:
Test: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
LayoutTests:
- http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
- http/tests/security/isolatedWorld/context-destroy.html: Added.
- 4:50 PM Changeset in webkit [114319] by
-
- 12 edits in trunk/Source/WebCore
Add V8 code generation support for MessagePortArray attributes.
https://bugs.webkit.org/show_bug.cgi?id=83943
Patch by Greg Billock <gbillock@google.com> on 2012-04-16
Reviewed by Kentaro Hara.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::ports):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_get_ports):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface ports]):
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
- 4:45 PM Changeset in webkit [114318] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:37 PM Changeset in webkit [114317] by
-
- 17 edits in trunk
Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097
it broke everything (Requested by olliej on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- bytecode/CodeBlock.h:
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1):
- fast/js/stack-trace-expected.txt:
- 4:32 PM Changeset in webkit [114316] by
-
- 2 edits in trunk/Source/WebCore
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521
Reviewed by David Levin.
No functionality change, so no new tests.
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
- 4:24 PM Changeset in webkit [114315] by
-
- 9 edits in trunk/Source/WebCore
Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063
Reviewed by Eric Seidel.
In an effort to prevent misuse, we previously decided to have borderBoxRect return a
pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned
at (0,0), and therefore won't snap to the same size as the element it's covering.
There are a couple uses of borderBoxRect that don't pixel snap the values and require
sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping
explicit, and moves uses that would otherwise pixel snap the rect to this version to
avoid producing a rect of the incorrect size. For details about pixel snapping with
LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit
No new tests. No change in behavior.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addVisualOverflowFromTheme):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
(WebCore::RenderBox::pixelSnappedBorderBoxRect):
(WebCore::RenderBox::borderBoundingBox):
(WebCore::RenderBox::hasVisualOverflow):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromChildren):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
- 4:19 PM Changeset in webkit [114314] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaseline continued from xji's rebase after r114267.
Unreviewed.
- platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added.
- 4:10 PM Changeset in webkit [114313] by
-
- 6 edits11 adds11 deletes in trunk/LayoutTests
Unreviewed gardening for ietestcenter/grid. Adding reference tests
and removing gtk expected.txt
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-16
- ietestcenter/css3/grid/display-grid-001-expected.htm: Added.
- ietestcenter/css3/grid/display-grid-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-column-003-expected.htm: Added.
- ietestcenter/css3/grid/grid-columns-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-001-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-002-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-003-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-004-expected.htm: Added.
- ietestcenter/css3/grid/grid-items-005-expected.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Removed.
- platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Removed.
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 3:54 PM Changeset in webkit [114312] by
-
- 2 edits in trunk/Tools
[GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086
Unreviewed build fix.
- gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.
- 3:50 PM Changeset in webkit [114311] by
-
- 2 edits in trunk/Source/WebCore
Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091
Reviewed by Andreas Kling.
Null check triggeringEvent.
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
- 3:27 PM Changeset in webkit [114310] by
-
- 15 edits in branches/subpixellayout
Reverting unnecessary changes to RenderRubyRun, and applying the patch from webkit.org/b/84063.
- 3:26 PM Changeset in webkit [114309] by
-
- 17 edits in trunk
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOriginIndexForReturn):
(CodeBlock):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
Update tests to include new exception property ordering, and new functions
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1): Modified slightly so that we produce consistent traces
- fast/js/stack-trace-expected.txt:
- 3:25 PM Changeset in webkit [114308] by
-
- 2 edits in trunk/Tools
[GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
includes a phony clean target that should make warnings and errors go
away.
- 3:19 PM Changeset in webkit [114307] by
-
- 5 edits in trunk/Source/WebKit/mac
Use a MIG call when creating a plug-in property list file
https://bugs.webkit.org/show_bug.cgi?id=84084
<rdar://problem/11197341>
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::createPropertyListFile):
Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.
- Plugins/Hosted/WebKitPluginHost.defs:
Add PHCreatePluginMIMETypesPreferences.
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage createPropertyListFile]):
NetscapePluginHostManager::createPropertyListFile is no longer a static member function.
- 3:14 PM Changeset in webkit [114306] by
-
- 2 edits in trunk/LayoutTests
Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=83965
Patch by David Alcala <dalcala@adobe.com> on 2012-04-16
Reviewed by Dirk Schulze.
- platform/chromium/test_expectations.txt:
- 3:09 PM Changeset in webkit [114305] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.
Unreviewed.
- platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
- platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
- 3:05 PM Changeset in webkit [114304] by
-
- 2 edits in trunk
Re-add GPU DEPS builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=84056
Patch by Dave Tu <dtu@chromium.org> on 2012-04-16
Reviewed by Ojan Vafai.
- Tools/TestResultServer/static-dashboards/builders.js:
- 3:05 PM Changeset in webkit [114303] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Supressing test errors introduced by http://trac.webkit.org/changeset/114283.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:02 PM Changeset in webkit [114302] by
-
- 3 edits in trunk/Source/WebCore
Rename to updateZOrderListsSlowCase to rebuildZOrderLists
https://bugs.webkit.org/show_bug.cgi?id=84071
Reviewed by Antti Koivisto.
Use a better name for updateZOrderListsSlowCase().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::rebuildZOrderLists):
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::updateZOrderLists):
- 2:50 PM Changeset in webkit [114301] by
-
- 6 edits in trunk/Source
[chromium] Allow WebGestureEvent to store four floating point values
https://bugs.webkit.org/show_bug.cgi?id=84053
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
See bug description for an explanation of the changes made.
Source/WebCore:
- platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
(WebCore::PlatformGestureEvent::gammaX):
(WebCore::PlatformGestureEvent::gammaY):
Source/WebKit/chromium:
- public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 2:44 PM Changeset in webkit [114300] by
-
- 4 edits1 add1 delete in trunk/LayoutTests
[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
https://bugs.webkit.org/show_bug.cgi?id=84082
Unreviewed Chromium test expectations update.
Results look right but the test maybe flaky.
- platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
- platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png:
- platform/chromium-mac/svg/hixie/error/012-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 2:33 PM Changeset in webkit [114299] by
-
- 12 edits3 deletes in trunk/LayoutTests
[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
https://bugs.webkit.org/show_bug.cgi?id=84075
Unreviewed Chromium expectations update.
- platform/chromium-linux-x86/svg/as-image: Removed.
- platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
- platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium/test_expectations.txt:
- svg/hixie/perf/001-expected.txt: Removed.
- svg/hixie/perf/002-expected.txt: Removed.
- 2:19 PM Changeset in webkit [114298] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring][V8] Remove $indent from NativeToJSValue()
https://bugs.webkit.org/show_bug.cgi?id=84077
Reviewed by Nate Chapin.
$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used.
This patch removes it.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- 2:19 PM Changeset in webkit [114297] by
-
- 4 edits1 delete in trunk
[GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060
Rubber-stamped by Martin Robinson.
.:
- configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we
already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.
Tools:
- gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
to their GNOME 3.4 versions.
- gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
is applied upstream.
- 2:02 PM Changeset in webkit [114296] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking failing test platform/chromium/compositing/filters/background-filter-blur-outsets.html.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 2:02 PM Changeset in webkit [114295] by
-
- 8 edits in trunk/Source/WebKit2
Nightly Back/Forward no longer calls plug-in's NPP_NewStream
https://bugs.webkit.org/show_bug.cgi?id=83805
<rdar://problem/11238748>
Reviewed by Simon Fraser.
When a page with a full-frame plug-in is restored from the page cache, it needs to re-fetch the plug-in stream.
Fix this by breaking the assumption that a plug-in will always get its data from WebCore if it's a full-frame plug-in;
instead it only get its data from WebCore if it's a full-frame plug-in that's not being restored from the page cache.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Rename m_loadManually to m_shouldUseManualLoader.
(WebKit::NetscapePlugin::initialize):
Get the mode from parameters.isFullFramePlugin instead.
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
Rename m_loadManually to m_shouldUseManualLoader.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Rename m_loadManually to m_shouldUseManualLoader.
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h:
(Parameters):
Add an extra isFullFramePlugin parameter, and rename loadManually to shouldUseManualLoader.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameCameFromPageCache.
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Set m_frameCameFromPageCache to true.
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Set m_frameCameFromPageCache to false.
(WebKit::WebFrameLoaderClient::createPlugin):
Initialize isFullFramePlugin and shouldUseManualLoader.
- 1:57 PM Changeset in webkit [114294] by
-
- 3 edits2 adds in trunk/LayoutTests
[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=84069
Unreviewed Chromium test expectations update.
Finally closing out an expectations update from 2009.
- platform/chromium-mac-leopard/svg/filters/sourceAlpha-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png:
- platform/chromium-mac/svg/filters/sourceAlpha-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:32 PM Changeset in webkit [114293] by
-
- 3 edits10 adds10 deletes in trunk/LayoutTests
[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
https://bugs.webkit.org/show_bug.cgi?id=84064
Unreviewed Chromium expectations update.
One of these results, for svg/filters/filter-source-position.svg, is
incorrect, but it should be updated regardless.
- platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/filter-clip-expected.png: Added.
- platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/chromium-win/svg/filters/filter-clip-expected.png: Added.
- platform/chromium-win/svg/filters/filter-source-position-expected.png: Added.
- platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/svg/filters/filter-source-position-expected.png: Removed.
- platform/efl/svg/filters/filter-source-position-expected.txt: Removed.
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/gtk/svg/filters/filter-source-position-expected.png: Removed.
- platform/gtk/svg/filters/filter-source-position-expected.txt: Removed.
- platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/mac/svg/filters/filter-source-position-expected.txt: Removed.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/qt/svg/filters/filter-source-position-expected.txt: Removed.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- svg/filters/filter-source-position-expected.png: Added.
- svg/filters/filter-source-position-expected.txt: Added.
- svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- 1:26 PM Changeset in webkit [114292] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position-composited-page-scale-down.
Unreviewed.
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- 1:14 PM Changeset in webkit [114291] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove BlobRegistryProxy::createResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=84047
Reviewed by Nate Chapin.
- src/BlobRegistryProxy.h: (BlobRegistryProxy::createResourceHandle): This function
is no longer used.
- 1:08 PM Changeset in webkit [114290] by
-
- 1 edit3 adds in trunk/LayoutTests
RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431
Add a test case for Bug 80431. It renders a 1x1 svg as an image with percent
width/height specified.
Patch by Yong Li <yoli@rim.com> on 2012-04-16
Reviewed by Nikolas Zimmermann.
- svg/as-image/resources/rect-1x1.svg: Added.
- svg/as-image/svg-as-image-with-relative-size-expected.html: Added.
- svg/as-image/svg-as-image-with-relative-size.html: Added.
- 1:05 PM Changeset in webkit [114289] by
-
- 3 edits in trunk/LayoutTests
Reverting shader-precision-format.html reftest fix - it only fixed some DBG builders. Marking test failing for those.
Unreviewed.
- fast/canvas/webgl/shader-precision-format-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:00 PM Changeset in webkit [114288] by
-
- 2 edits in trunk/Source/WebKit/blackberry
2012-04-16 Antonio Gomes <agomes@rim.com>
Screen shift down when VKB shows by clicking in a input box MKS_3601371
PR #149846
Reviewed by Rob Buis.
After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
we had a less restricted code path allowing/disallowing overscrolling. That caused
some webpages like google.com to get on overscroll when adjusting the scroll
position to ensure the focused input field is visible.
Patch restricts the way we allow overscrolling to the bottom, where the virtual
keyboard pops up from, clamping it to 0, 0 if it tries to
overscroll upwards, and to maximum scroll position if it overscrolls
downwards.
Internally reviewed by Mike Fenton.
PR #149846
- WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 12:34 PM Changeset in webkit [114287] by
-
- 3 edits7 adds in trunk/LayoutTests
Rebaseline after r114267.
- platform/chromium-linux/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-mac/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png:
- platform/chromium/test_expectations.txt:
- 11:52 AM Changeset in webkit [114286] by
-
- 2 edits in trunk/Source/WebKit2
EndPrinting message should be sent synchronously when printing was initiated from DOM.
https://bugs.webkit.org/show_bug.cgi?id=84049
<rdar://problem/11096575>
Reviewed by Oliver Hunt.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): When printing is initiated by WebProcess, all messages from UI process are sent synchronously to avoid being queued, and so should EndPrinting.
- 11:45 AM Changeset in webkit [114285] by
-
- 6 edits2 adds in trunk
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903
Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-16
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/media-query-list-08.html
Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.
The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.
- dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
Testing MediaQueryLists listeners related to viewport changes.
- fast/media/media-query-list-08-expected.txt: Added.
- fast/media/media-query-list-08.html: Added.
Skipping the new test in Qt due to an issue in its DumpRenderTree.
- platform/qt/Skipped:
- 11:41 AM Changeset in webkit [114284] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Delete uncalled unreserveContentsTextures function
https://bugs.webkit.org/show_bug.cgi?id=84005
Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.
This is vestigal dead code.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- 11:32 AM Changeset in webkit [114283] by
-
- 14 edits7 adds in trunk
Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547
Source/WebCore:
Reviewed by Dean Jackson.
If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.
This saves backing store memory on some pages.
Tests: compositing/backing/no-backing-for-clip-overlap.html
compositing/backing/no-backing-for-clip.html
compositing/backing/no-backing-for-perspective.html
- rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):
- rendering/RenderLayerCompositor.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
LayoutTests:
Reviewed by Dean Jackson.
New tests for backing store elimination with clip or perspective.
New results for some tests that no longer have backing store on some
layers.
- compositing/backing/no-backing-for-clip-expected.txt: Added.
- compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- compositing/backing/no-backing-for-clip-overlap.html: Added.
- compositing/backing/no-backing-for-clip.html: Added.
- compositing/backing/no-backing-for-perspective-expected.txt: Added.
- compositing/backing/no-backing-for-perspective.html: Added.
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/visibility/layer-visible-content-expected.png:
- compositing/visibility/layer-visible-content-expected.txt:
- 11:28 AM April 2012 Meeting edited by
- (diff)
- 11:27 AM Changeset in webkit [114282] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903
Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.
PR 125888
Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.
Reviewed internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 11:27 AM Changeset in webkit [114281] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 11:12 AM Changeset in webkit [114280] by
-
- 2 edits in trunk/Tools
Adding Contributors Brian Salomon and Tom Hudson to committers.py.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 11:06 AM Changeset in webkit [114279] by
-
- 3 edits in trunk/LayoutTests
Try to fix a flaky JS test.
Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).
- fast/js/custom-constructors-expected.txt:
- fast/js/script-tests/custom-constructors.js:
- 11:01 AM Changeset in webkit [114278] by
-
- 5 edits in trunk/Source
<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed
Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.
Source/WebCore:
- WebCore.exp.in: Export PageCache::remove()
Source/WebKit2:
Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.
- WebProcess/WebPage/WebBackForwardListProxy.h:
- 10:55 AM Changeset in webkit [114277] by
-
- 925 edits198 copies37 deletes in branches/subpixellayout
Merge trunk changes up until 114126 into subpixel branch.
- 10:55 AM April 2012 Meeting edited by
- Added proposed IDB discussion (diff)
- 10:51 AM Changeset in webkit [114276] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, GTK build fix after r114269.
- GNUmakefile.list.am:
- 10:43 AM Changeset in webkit [114275] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606
Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
- 10:41 AM Changeset in webkit [114274] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix COMMANDLINE_TYPEDARRAYS build
https://bugs.webkit.org/show_bug.cgi?id=84051
Reviewed by Gavin Barraclough.
Update for new putByIndex API and wtf changes.
- JSCTypedArrayStubs.h:
(JSC):
- 10:30 AM Changeset in webkit [114273] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Turns out those frame
flattening tests are still flaky.
- 10:25 AM Changeset in webkit [114272] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870
Reviewed by Pavel Feldman.
- only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
- 10:23 AM Changeset in webkit [114271] by
-
- 13 edits63 moves1 delete in trunk
Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
https://bugs.webkit.org/show_bug.cgi?id=84038
A bunch of renames "detailed heapshot" -> "heap snapshot".
Reviewed by Pavel Feldman.
PerformanceTests:
- inspector/detailed-heapshots-smoke-test.html:
Source/WebCore:
Tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-show-all.html
inspector/profiler/heap-snapshot-comparison-show-next.html
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-sorting.html
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-show-all.html
inspector/profiler/heap-snapshot-containment-show-next.html
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-sorting.html
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-show-all.html
inspector/profiler/heap-snapshot-dominators-show-next.html
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-sorting.html
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-show-all.html
inspector/profiler/heap-snapshot-summary-show-next.html
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-sorting.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/HeapSnapshotGridNodes.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js.
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotGridNode.prototype.createCell):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._emptyData):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffNode.prototype._signForDelta):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
(MixInSnapshotNodeFunctions):
- inspector/front-end/HeapSnapshotView.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotView.js.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback2):
(WebInspector.HeapSnapshotView.prototype.wasShown):
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype.onResize):
(WebInspector.HeapSnapshotView.prototype.searchCanceled):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesById):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesQuery):
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToLastSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToNextSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToPreviousSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingLastSearchResult):
(WebInspector.HeapSnapshotView.prototype._jumpToSearchResult):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapSnapshotView.prototype._changeFilter):
(WebInspector.HeapSnapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.HeapSnapshotView.prototype._changeNameFilter):
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype._loadProfile):
(WebInspector.HeapSnapshotView.prototype._loadProfileByIndex):
(WebInspector.HeapSnapshotView.prototype.isDetailedSnapshot):
(WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
(WebInspector.HeapSnapshotView.prototype._selectionChanged):
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.HeapSnapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.HeapSnapshotView.prototype.changeView.sortingComplete):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
(WebInspector.HeapSnapshotView.prototype._resolveObjectForPopover):
(WebInspector.HeapSnapshotView.prototype._helpClicked.appendHelp):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._retainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
(WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.HeapSnapshotProfileType.prototype.get description):
(WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/heapProfiler.css:
(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .view):
(.heap-snapshot-view .view.visible):
(.heap-snapshot-view .data-grid tr:empty):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid td.addedCount-column):
(.heap-snapshot-view .data-grid td.removedCount-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid td.addedSize-column):
(.heap-snapshot-view .data-grid td.removedSize-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(.heap-snapshot-view .data-grid td.shallowSize-column):
(.heap-snapshot-view .data-grid td.retainedSize-column):
(.heap-snapshot-view .data-grid td.distanceToWindow-column):
(.heap-snapshot-view .data-grid span.percent-column):
(.heap-snapshot-view .console-formatted-object, .console-formatted-node):
(.heap-snapshot-view .console-formatted-string):
(.heap-snapshot-view .console-formatted-id):
(.heap-snapshot-view .data-grid tr.selected *):
(.heap-snapshot-view .data-grid:focus tr.selected *):
(.heap-snapshot-view .delimiter):
(.heap-snapshot-view .views-container):
(.heap-snapshot-view .views-container .view):
(.heap-snapshot-view .retaining-paths-view):
(.heap-snapshot-view .class-view-grid):
(.heap-snapshot-view .class-view-toolbar):
(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):
(.heap-snapshot-view .retainers-view-header .title > span):
(.heap-snapshot-view tr:not(.selected) td.object-column span.highlight):
(.heap-snapshot-view td.object-column span.grayed):
(.heap-snapshot-help-status-bar-item .glyph):
(table.heap-snapshot-help):
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/profiler/detailed-heapshots-test.js: Removed.
- inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
- inspector/profiler/heap-snapshot-comparison-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html.
- inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
- inspector/profiler/heap-snapshot-comparison-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next.html.
- inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
- inspector/profiler/heap-snapshot-comparison-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting.html.
- inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
- inspector/profiler/heap-snapshot-containment-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all.html.
- inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
- inspector/profiler/heap-snapshot-containment-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next.html.
- inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
- inspector/profiler/heap-snapshot-containment-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting.html.
- inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
- inspector/profiler/heap-snapshot-dominators-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all.html.
- inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt.
- inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
- inspector/profiler/heap-snapshot-dominators-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next.html.
- inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
- inspector/profiler/heap-snapshot-dominators-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting.html.
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
- inspector/profiler/heap-snapshot-summary-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all.html.
- inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
- inspector/profiler/heap-snapshot-summary-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next.html.
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html.
- inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
- inspector/profiler/heap-snapshot-summary-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting.html.
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
(initialize_HeapSnapshotTest.InspectorTest.completeProfilerTest):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite.runner):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
- platform/chromium/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
- platform/chromium/inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
- 10:18 AM Changeset in webkit [114270] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
https://bugs.webkit.org/show_bug.cgi?id=83946
Reviewed by Pavel Feldman.
Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
support for moving overview window with horizontal swype over lower timeline pane, thus removing
an irritating situation when we try to both change overview window and scroll lower timeline pane
upon a single touchpad gesture. Those willing to move timeline window now would need to position
mouse over overview.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
- 10:14 AM Changeset in webkit [114269] by
-
- 10 edits2 adds in trunk/Source/WebCore
[GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095
Reviewed by Martin Robinson.
Moved the GStreamer initialization logic to a new
GStreamerUtilities module, used by the MediaPlayer and the
AudioContext. I also removed the static variables as
gst_init_check already handles cases where it's called multiple
times.
- GNUmakefile.list.am:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstElementFactory):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF):
- platform/graphics/gstreamer/GStreamerUtilities.cpp: Added.
(WebCore):
(WebCore::initializeGStreamer):
- platform/graphics/gstreamer/GStreamerUtilities.h: Added.
(WebCore):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::doGstInit):
- 10:06 AM Changeset in webkit [114268] by
-
- 5 edits in trunk/Source/WebCore
Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
https://bugs.webkit.org/show_bug.cgi?id=83982
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-16
Reviewed by Martin Robinson.
GL_BGRA is not defined in GLESv2, so it causes build-break at readRenderingResults.
To resolve this, a helper function readPixelsAndConvertToBGRAIfNecessary is added
in GC3DOpenGL.cpp & GC3DOpenGLES.cpp and it's used in GC3DOpenGLCommon.cpp.
And some other issues to build with GLES are gone with this patch.
No new tests, since no new feature.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::readRenderingResults):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
- 10:03 AM Changeset in webkit [114267] by
-
- 4 edits8 adds in trunk
[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
Disable kashida justification if using Skia to draw.
Test: fast/text/international/arabic-justify.html
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
- fast/text/international/arabic-justify.html: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
- 9:59 AM Changeset in webkit [114266] by
-
- 4 edits in trunk/Source/WebCore
Build fix.
Change set 114220 broke OS X internal build. Change set 114231 attempted to fix it, but isn't entirely
correct. This patch amends change set 114231.
- WebCore.exp.in:
- editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h:
(DictationAlternative):
- 9:37 AM Changeset in webkit [114265] by
-
- 6 edits2 adds in trunk
REGRESSION (r104445): Style is not recomputed on serenaandlily.com
https://bugs.webkit.org/show_bug.cgi?id=83663
Source/WebCore:
Reviewed by Andreas Kling.
CSS class and id selectors are case insensitive in non-strict modes. The code
that invalidated the scope elements used getElementByID() which is case
sensitive in all modes. As a result we would fail to invalidate elements
that would match a style rule but used different case in id.
The new code invalidates by crawling the DOM tree. This often (when there are classes)
actually faster than the existing code as we can now handle everything in a single pass.
Each class scope required a crawl with the old code.
The code uses the same functions as the selector matching code to get the same behavior.
The maximum class limit is lifted as number of classes does not affect complexity anymore.
Test: fast/css/id-or-class-before-stylesheet-strict.html
- css/SelectorChecker.h:
(WebCore::SelectorChecker::elementMatchesSelectorScopes):
(WebCore):
- dom/Document.cpp:
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore):
LayoutTests:
Reviewed by Andreas Kling.
Update the existing test with case insensitive comparisons and add a strict mode test.
- fast/css/id-or-class-before-stylesheet-expected.txt:
- fast/css/id-or-class-before-stylesheet-strict-expected.txt: Added.
- fast/css/id-or-class-before-stylesheet-strict.html: Added.
- fast/css/id-or-class-before-stylesheet.html:
- 9:28 AM April 2012 Meeting edited by
- (diff)
- 8:56 AM Changeset in webkit [114264] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Unflag frame flattening
tests fixed in r114262.
- 8:53 AM Changeset in webkit [114263] by
-
- 6 edits in trunk
[BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
https://bugs.webkit.org/show_bug.cgi?id=84031
Patch by Jonathan Dong <Jonathan Dong> on 2012-04-16
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.
Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
- Api/DumpRenderTreeClient.h:
(WebCore):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
Tools:
Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
(DumpRenderTree):
- 8:51 AM Changeset in webkit [114262] by
-
- 16 edits in trunk/LayoutTests
[Qt] LayoutTest: Replace setTimeout with synchronous layout for frame flattening where possible.
https://bugs.webkit.org/show_bug.cgi?id=84028
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
It's safer (and faster) to force synchronous layout, than expecting a layout before setTimout(0) hits.
- fast/frames/flattening/crash-svg-document.html: Remove extra line so that non-svg builds don't report failure.
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- 8:36 AM Changeset in webkit [114261] by
-
- 3 edits2 adds in trunk
CSS3 Selectors failures on css3test.com
https://bugs.webkit.org/show_bug.cgi?id=83885
Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16
Reviewed by Zoltan Herczeg.
Source/WebCore:
Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type()
with values -n-b and n-b as they are of valid form an+b where a and b are integers.
http://www.w3.org/TR/selectors/#structural-pseudos
Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers.
However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor.
The original code only checked this if the string was n- or -n- but this is not enough.
We need to check everything which starts with an n- or -n- prefix.
Test: css3/parsing-css3-nthchild.html
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
LayoutTests:
- css3/parsing-css3-nthchild-expected.txt: Added.
- css3/parsing-css3-nthchild.html: Added.
- 8:35 AM Changeset in webkit [114260] by
-
- 2 edits in trunk
[GTK] GStreamer 1.0 support in configure.ac
https://bugs.webkit.org/show_bug.cgi?id=84029
Reviewed by Martin Robinson.
The GStreamer version was recently changed to 1.0 in the git
repositories of the project so we need to reflect this change in
configure.ac.
- configure.ac:
- 8:33 AM Changeset in webkit [114259] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt:
- 8:18 AM Changeset in webkit [114258] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in notifyChildInserted when HTMLMediaElement is removed from tree
https://bugs.webkit.org/show_bug.cgi?id=83949
Reviewed by Antti Koivisto.
No new tests. I was not able to create a reproducible test case, but I have been unable
to reproduce the ASSERT that occassionally fired in existing tests since I have been
living on these changes.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedIntoDocument): Call configureMediaControls.
(WebCore::HTMLMediaElement::removedFromDocument): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Don't show controls when the
media element is not in a Document.
- 8:15 AM Changeset in webkit [114257] by
-
- 2 edits in trunk/Tools
build-webkit --gtk --no-webkit2 builds WK2
https://bugs.webkit.org/show_bug.cgi?id=83977
Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-16
Reviewed by Martin Robinson.
- Scripts/build-webkit: Fixup ./configure option to disable
WebKit2 build.
- 8:13 AM Changeset in webkit [114256] by
-
- 5 edits in trunk
Layout Test media/track/track-delete-during-setup.html is hitting an ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=82269
Reviewed by Antti Koivisto.
Source/WebCore:
No new tests, already tested by media/track/track-delete-during-setup.html.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoDocument): Don't notify the media element until/unless
the track element is inserted into the document.
- html/HTMLTrackElement.h:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 8:10 AM Changeset in webkit [114255] by
-
- 7 edits in trunk/Source/JavaScriptCore
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by Geoffrey Garen.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
- runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
- runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):
- 7:49 AM Changeset in webkit [114254] by
-
- 2 edits16 adds in trunk/LayoutTests
[EFL][DRT] Create baselines for CSS cases related to Ahem font
https://bugs.webkit.org/show_bug.cgi?id=83265
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/fast/css/caption-width-absolute-position-expected.png: Added.
- platform/efl/fast/css/caption-width-absolute-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/caption-width-fixed-position-expected.png: Added.
- platform/efl/fast/css/caption-width-fixed-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/caption-width-relative-position-expected.png: Added.
- platform/efl/fast/css/caption-width-relative-position-expected.txt: Added.
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-expected.png: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-expected.txt: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
- platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
- platform/efl/test_expectations.txt:
- 7:43 AM Changeset in webkit [114253] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build break in PageClientImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?=id=84034
Reviewed by Kenneth Rohde Christiansen.
Fixes typo in didChangeViewportProperites definition.
- UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::didChangeViewportProperties):
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-16
- 7:33 AM Changeset in webkit [114252] by
-
- 53 edits56 adds in trunk/LayoutTests
[EFL][DRT] SVG rebaseline for tests affected by SVGEllipse and SVG shadow root changes
https://bugs.webkit.org/show_bug.cgi?id=84027
Unreviewed, EFL gardening.
Updating txt baselines for tests affected by r109097 and r112806,
creating pixel test results.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
- platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/efl/svg/batik/paints/patternRegionA-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegionA-expected.txt:
- platform/efl/svg/batik/paints/patternRegions-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegions-expected.txt:
- platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/efl/svg/carto.net/button-expected.png: Added.
- platform/efl/svg/carto.net/button-expected.txt:
- platform/efl/svg/carto.net/colourpicker-expected.png: Added.
- platform/efl/svg/carto.net/colourpicker-expected.txt:
- platform/efl/svg/carto.net/slider-expected.png: Added.
- platform/efl/svg/carto.net/slider-expected.txt:
- platform/efl/svg/carto.net/window-expected.png: Added.
- platform/efl/svg/carto.net/window-expected.txt:
- platform/efl/svg/clip-path/clip-in-mask-expected.png: Added.
- platform/efl/svg/clip-path/clip-in-mask-expected.txt:
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt:
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt:
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt:
- platform/efl/svg/clip-path/clip-path-evenodd-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-expected.txt:
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/efl/svg/clip-path/clip-path-nonzero-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-expected.txt:
- platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
- platform/efl/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt:
- platform/efl/svg/clip-path/clip-path-transform-1-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-transform-1-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt:
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-container-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-container-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
- platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt:
- platform/efl/svg/clip-path/clipper-placement-issue-expected.png: Added.
- platform/efl/svg/clip-path/clipper-placement-issue-expected.txt:
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
- platform/efl/svg/css/clippath-with-shadow-expected.png: Added.
- platform/efl/svg/css/clippath-with-shadow-expected.txt:
- platform/efl/svg/css/mask-with-shadow-expected.png: Added.
- platform/efl/svg/css/mask-with-shadow-expected.txt:
- platform/efl/svg/css/shadow-changes-expected.png: Added.
- platform/efl/svg/css/shadow-changes-expected.txt:
- platform/efl/svg/hixie/cascade/001-broken-expected.png: Added.
- platform/efl/svg/hixie/cascade/001-broken-expected.txt:
- platform/efl/svg/hixie/cascade/002-expected.png: Added.
- platform/efl/svg/hixie/cascade/002-expected.txt:
- platform/efl/svg/hixie/error/001-expected.png: Added.
- platform/efl/svg/hixie/error/001-expected.txt:
- platform/efl/svg/hixie/error/003-expected.png: Added.
- platform/efl/svg/hixie/error/003-expected.txt:
- platform/efl/svg/hixie/error/017-expected.png: Added.
- platform/efl/svg/hixie/error/017-expected.txt:
- platform/efl/svg/hixie/perf/001-expected.png: Added.
- platform/efl/svg/hixie/perf/001-expected.txt: Added.
- platform/efl/svg/hixie/perf/002-expected.png: Added.
- platform/efl/svg/hixie/perf/002-expected.txt: Added.
- platform/efl/svg/hixie/rendering-model/001-expected.png: Added.
- platform/efl/svg/hixie/rendering-model/001-expected.txt:
- platform/efl/svg/hixie/rendering-model/002-expected.png: Added.
- platform/efl/svg/hixie/rendering-model/002-expected.txt:
- platform/efl/svg/hixie/transform/001-expected.png: Added.
- platform/efl/svg/hixie/transform/001-expected.txt:
- platform/efl/svg/hixie/use/001-expected.png: Added.
- platform/efl/svg/hixie/use/001-expected.txt:
- platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
- platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
- platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- 7:30 AM WebKit Team edited by
- Adding myself to the committers list. (diff)
- 7:20 AM Changeset in webkit [114251] by
-
- 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore
Merged r112966.
- 7:17 AM Changeset in webkit [114250] by
-
- 4 edits in trunk
[EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797
Tools:
Keep the keyName valid within scope of KeyEventInfo to avoid
feeding key events with invalid keyName.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
- DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
LayoutTests:
Unskip fast/frames/iframe-window-focus.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
- platform/efl/Skipped:
- 7:05 AM Changeset in webkit [114249] by
-
- 8 edits1 add in trunk
[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981
Reviewed by Kenneth Rohde Christiansen.
.:
- ManualTests/remove-add-fixed-position.html: Added.
Source/WebCore:
When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.
- page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
- rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):
- rendering/RenderView.h:
(RenderView):
Source/WebKit2:
Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
- 6:59 AM Changeset in webkit [114248] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip crash test in chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=84024
- platform/chromium/test_expectations.txt:
- 6:38 AM Changeset in webkit [114247] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Clean up how the interaction engine is making use of ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=83895
Reviewed by Simon Hausmann.
Refactor how the interaction engine is using the ViewportAttributes
and get rid of the Contraints subclass.
Push the ViewportAttributes through to the QQuickWebViewPrivate class
and add some default values in the case the Legacy view is used.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::setCSSScaleBounds):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::hadUserInteraction):
(WebKit::QtViewportInteractionEngine::setAllowsUserScaling):
(WebKit::QtViewportInteractionEngine::setContentToDevicePixelRatio):
- 6:19 AM Changeset in webkit [114246] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after QRawFont change.
Missed this one earlier. We now use primaryFontHasGlyphForCharacter from
FontFastPath.cpp, resulting in a different DRT output.
- platform/qt-5.0/Skipped: unskip
- platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- 6:16 AM SelectiveTestEWS edited by
- (diff)
- 6:09 AM SelectiveTestBuildBot edited by
- (diff)
- 5:58 AM Changeset in webkit [114245] by
-
- 2 edits in trunk/LayoutTests
[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820
Unreviewed gardening. Skip new failing tests after r114240 until fix.
- platform/qt-5.0/Skipped:
- 5:53 AM Changeset in webkit [114244] by
-
- 3 edits in trunk/LayoutTests
[EFL][DRT] Gardening CSS Regions & Exclusions
https://bugs.webkit.org/show_bug.cgi?id=84011
Skipping CSS regions and exclusions tests for now,
waiting for feature to complete.
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 5:41 AM Changeset in webkit [114243] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Flag two failing media tests.
- 4:58 AM Top100Invariant edited by
- (diff)
- 4:57 AM RegressionTestResearch edited by
- (diff)
- 4:51 AM SelectiveTestBuildBot edited by
- (diff)
- 4:50 AM Changeset in webkit [114242] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
https://bugs.webkit.org/show_bug.cgi?id=83933
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-16
Reviewed by Adam Treat.
RIM PR: 149609
This was because I accidentally dropped an exclamation mark when
upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
the exclamation mark.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- 4:49 AM Improving Regression Tests edited by
- (diff)
- 4:46 AM Changeset in webkit [114241] by
-
- 26 edits1 add in trunk
Web Inspector: extract ContentProvider into its own file, make NetworkRequest, Resoruce and others implement it.
https://bugs.webkit.org/show_bug.cgi?id=83922
Reviewed by Yury Semikhatsky.
Source/WebCore:
We have two different types of requestContent methods: one on the source mapping level and one on the resource level.
There are also adapters between the two. I'm aligning it all to a single requestContent method declared in ContentProvider.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
- inspector/front-end/ContentProvider.js: Added.
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.contentURL):
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
(WebInspector.ContentProvider.SearchMatch):
- inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.contentURL):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentURL):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.requestContent):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._getResourceContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
- inspector/front-end/NetworkItemView.js:
(WebInspector.RequestContentView.prototype._ensureInnerViewShown.callback):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.contentURL):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.searchInContent):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.contentURL):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.contentURL):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):
- inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
- inspector/front-end/ScriptFormatter.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/content-providers-expected.txt:
- inspector/debugger/content-providers.html:
- inspector/debugger/raw-source-code.html:
- inspector/debugger/ui-source-code.html:
- 4:44 AM Changeset in webkit [114240] by
-
- 3 edits6 adds in trunk/Tools
[Qt] Replace QtXmlPatterns usage with libxslt dependency
<https://bugs.webkit.org/show_bug.cgi?id=76820>
Patch by Andras Piroska <pandras@inf.u-szeged.hu> on 2012-04-16
Reviewed by Simon Hausmann.
The features.prf file was modified, in order to use libxml and libxslt by default.
This modification only work at Qt5.
- qmake/config.tests/libxml2/libxml2.cpp: Added.
(main):
- qmake/config.tests/libxml2/libxml2.pro: Added.
- qmake/config.tests/libxslt/libxslt.cpp: Added.
(main):
- qmake/config.tests/libxslt/libxslt.pro: Added.
- qmake/mkspecs/features/features.prf:
- qmake/sync.profile:
- 4:32 AM Changeset in webkit [114239] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix a wrong expected.txt
https://bugs.webkit.org/show_bug.cgi?id=84014
- fast/canvas/webgl/shader-precision-format-expected.txt:
- 4:20 AM Changeset in webkit [114238] by
-
- 2 edits in trunk/Tools
[EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
https://bugs.webkit.org/show_bug.cgi?id=83862
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
It doesn't work properly because of wrong parameter order in function call.
- EWebLauncher/main.c:
- 3:13 AM Changeset in webkit [114237] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip failing tests, because less tests means less problems.
- platform/qt-5.0/Skipped:
- platform/qt/Skipped:
- 2:24 AM Changeset in webkit [114236] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r114200.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 2:04 AM Changeset in webkit [114235] by
-
- 3 edits2 adds in trunk
[BlackBerry] Missing readyState 2 when a XMLHttpRequest calls xmlhttp.open("HEAD","notExist.html",true).
https://bugs.webkit.org/show_bug.cgi?id=83866
Source/WebCore:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
We receive 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case shouldn't be treated as a failure.
Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyClose):
LayoutTests:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
- http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html: Added.
- 1:56 AM Changeset in webkit [114234] by
-
- 7 edits2 deletes in trunk/LayoutTests
[Chromium] Rebaseline for date-appearance.html.
- platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Removed.
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
- platform/chromium-win/fast/forms/date/date-appearance-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
- 1:42 AM Changeset in webkit [114233] by
-
- 2 edits in trunk/LayoutTests
[Qt]REGRESSION(r114217): It broke fast/repaint/line-flow-with-floats-in-regions.html
https://bugs.webkit.org/show_bug.cgi?id=84013
Unreviewed gardening, skip a failing test to paint the bot green. (Less tests, less problem.)
- platform/qt/Skipped:
- 1:32 AM Changeset in webkit [114232] by
-
- 1 edit12 adds in trunk/LayoutTests
Unreviewed, GTK baselines for tests added in r114162.
- platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
- platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
- 1:16 AM Changeset in webkit [114231] by
-
- 4 edits in trunk/Source/WebCore
Build fix.
- WebCore.exp.in:
- editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h:
(DictationAlternative):
- 1:11 AM Changeset in webkit [114230] by
-
- 2 edits in trunk/Source/WebCore
Fix signed/unsigned mismatch warning for BlackBerry debug builds.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::removeCookieAtIndex):
- 12:42 AM Changeset in webkit [114229] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Skip svg failures, unskip
ietestcenter for rebaseline and unflag a flaky media/track test.
- 12:26 AM Changeset in webkit [114228] by
-
- 2 edits in trunk/Tools
Unreviewed, GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skip /webkit/atk/textChangedNotifications.
- 12:14 AM Changeset in webkit [114227] by
-
- 2 edits in trunk/Source/WTF
Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999
Reviewed by Sam Weinig.
Before this patch, NullPtr.h assumed that a working |nullptr| implied
a working |std::nullptr_t| as well. With clang and libstdc++4.2, this
is not true.
I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03)
with clang.
- wtf/NullPtr.h:
(std):
Apr 15, 2012:
- 11:37 PM Changeset in webkit [114226] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- 11:23 PM Changeset in webkit [114225] by
-
- 8 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
- platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
- platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
- platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.
- 11:12 PM Changeset in webkit [114224] by
-
- 2 edits in trunk/Source/WebCore
WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991
Reviewed by Hajime Morita.
We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.
No new tests because this behavior depends on locale setting.
- platform/text/LocalizedCalendarICU.cpp:
(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().
- 10:32 PM PrefixedAPIs edited by
- (diff)
- 10:21 PM Changeset in webkit [114223] by
-
- 7 edits in trunk/Source/WebKit/chromium
Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777
Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.
Reviewed by Kent Tamura.
- public/WebAutofillClient.h:
(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
- public/WebView.h:
(WebView):
- src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
- src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.
Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions):
- src/WebViewImpl.h:
(WebViewImpl):
- 9:13 PM Changeset in webkit [114222] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to chromium-win build fix.
- editing/DictationAlternative.h:
- 8:54 PM Changeset in webkit [114221] by
-
- 2 edits in trunk/Source/WebCore
Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003
Reviewed by Eric Seidel.
Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.
No new tests. Covered by existing cnavas toDataURL tests.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::toDataURL):
- 8:05 PM Changeset in webkit [114220] by
-
- 31 edits3 copies3 adds in trunk/Source/WebCore
Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549
Reviewed by Hajime Morita.
No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.
On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:
- Added DictationMarkDetails to store non-string type maker detail.
- Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with attached markers.
- Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
- Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.
Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.
This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used
by AlternativeTextController.
(WebCore):
- dom/Document.h:
(WebCore):
- dom/DocumentMarker.cpp:
(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):
- dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore):
- dom/DocumentMarkerController.h:
(DocumentMarkerController):
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: Added member variable for dictation alternatives.
(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):
- dom/TextEventInputType.h:
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):
- editing/AlternativeTextController.h:
(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):
- editing/CompositeEditCommand.h:
(WebCore::CompositeEditCommand::isDictationCommand):
- editing/DictationAlternative.cpp: Added.
(WebCore):
(WebCore::DictationAlternative::DictationAlternative):
- editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.
(DictationAlternative):
(WebCore):
- editing/DictationCommand.cpp: Added.
(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):
- editing/DictationCommand.h: Added.
(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):
- editing/EditingAllInOne.cpp:
- editing/Editor.cpp:
(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
- editing/Editor.h:
(Editor):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):
- editing/InsertTextCommand.h:
(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):
- editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.
(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
- editing/TextInsertionBaseCommand.h: Added.
(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):
- editing/TypingCommand.cpp:
(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):
- editing/TypingCommand.h:
- page/EventHandler.cpp:
- rendering/InlineTextBox.cpp:
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/InlineTextBox.h:
(InlineTextBox):
- testing/Internals.cpp:
(WebCore::markerTypesFrom):
- 7:49 PM Changeset in webkit [114219] by
-
- 33 edits2 copies4 adds6 deletes in trunk/LayoutTests
[chromium] Unreviewed rebaselines for various compositing tests.
- platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
- platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
- platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
- platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
- platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
- platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
- 7:44 PM Changeset in webkit [114218] by
-
- 16 edits in trunk/Source
[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415
Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.
Source/WebCore:
This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):
- platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):
- 7:40 PM Changeset in webkit [114217] by
-
- 27 edits in trunk
Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998
Source/WebCore:
Reviewed by Andreas Kling.
Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.
The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.
If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.
- css/CSSGrammar.y:
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
- css/CSSParser.cpp:
(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):
- css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):
- css/CSSParserMode.h:
(WebCore):
(CSSParserContext):
- css/CSSRule.h:
(WebCore::CSSRule::parserContext):
(CSSRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):
- css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):
- css/CSSValuePool.cpp:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::parseDeclaration):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
- dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
- dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector):
- dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
LayoutTests:
Reviewed by Andreas Kling.
Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.
- css3/filters/script-tests/custom-filter-property-parsing.js:
- fast/regions/script-tests/css-regions-disabled.js:
- 7:14 PM Changeset in webkit [114216] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975
Reviewed by Martin Robinson.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests. Covered by existing canvas toDataURL tests.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().
- 6:43 PM Changeset in webkit [114215] by
-
- 7 edits in trunk/Source
Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749
Reviewed by David Levin.
Source/WebCore:
Second attempt to remove leaks around WorkerThreadableWebSocketChannel.
No new tests, as this patch does not impose any functional change.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).
Source/WebKit/chromium:
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().
- 4:15 PM Changeset in webkit [114214] by
-
- 2 edits in trunk/Tools
Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641
Reviewed by Eric Seidel.
Don't build on perf bots to improve the cycle time.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 8:23 AM Changeset in webkit [114213] by
-
- 1 delete in trunk/LayoutTests/platform/efl/fast/regions
Remove empty directory.
- 8:21 AM Changeset in webkit [114212] by
-
- 2 edits50 deletes in trunk/LayoutTests
[EFL] Gardening. Skip fast/regions tests.
SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.
- platform/efl/Skipped:
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
- platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
- platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
- platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
Apr 14, 2012:
- 8:51 PM Changeset in webkit [114211] by
-
- 4 edits in trunk/Source/WebCore
Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
https://bugs.webkit.org/show_bug.cgi?id=83929
Reviewed by Eric Seidel.
Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.
No new tests, no change in functionality.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup):
- html/shadow/MediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::layout):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
- 8:31 PM Changeset in webkit [114210] by
-
- 2 edits in trunk/Source/WebCore
Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990
Reviewed by Kentaro Hara.
We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:
weekStartDay: "1",
and the JavaScript code used it in the following code:
dayLabels[(weekStartDay + i) % 7]
If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...
We need to pass the "weekStartDay" property as a number.
No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.
- 5:43 PM Changeset in webkit [114209] by
-
- 2 edits in trunk/Source/WTF
Harden WTF::ByteArray::create()
https://bugs.webkit.org/show_bug.cgi?id=83318
Reviewed by Maciej Stachowiak.
- wtf/ByteArray.cpp:
(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.
- 2:29 PM Changeset in webkit [114208] by
-
- 4 edits4 adds in trunk
Viewport-percentage Length units does not work for Replaced elements size
https://bugs.webkit.org/show_bug.cgi?id=83425
Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.
Added the support for viewport-percentage length units while calculating the width/height of replaced elements.
Source/WebCore:
Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html
- platform/Length.h:
(WebCore::Length::isSpecified):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
LayoutTests:
- css3/viewport-percentage-lengths/resources: Added.
- css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
- css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
- css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.
- 2:05 PM Changeset in webkit [114207] by
-
- 3 edits2 adds in trunk
CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736
Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.
Added support for fetching the value of 'border-radius' CSS property which was missing.
Source/WebCore:
Test: fast/css/border-radius-property-value.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
- fast/css/border-radius-property-value-expected.txt: Added.
- fast/css/border-radius-property-value.html: Added.
- 11:29 AM Changeset in webkit [114206] by
-
- 4 edits in trunk
[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.
Tools:
WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.
- platform/mac-wk2/Skipped:
- 11:15 AM Changeset in webkit [114205] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=83826
Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.
Reviewed by Dan Bernstein.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
- 3:30 AM WebKitGTK edited by
- Use internal link (diff)
- 2:34 AM Changeset in webkit [114204] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569
Reviewed by Eric Seidel.
No new tests. Covered by exiting fast/canvas/*toDataURL* tests.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.
Apr 13, 2012:
- 11:02 PM Changeset in webkit [114203] by
-
- 7 edits in trunk/Source
[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
https://bugs.webkit.org/show_bug.cgi?id=83804
Patch by David Reveman <reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.
Source/WebCore:
Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.
Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
TiledLayerChromiumTest.partialUpdates
- platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 8:32 PM Changeset in webkit [114202] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
https://bugs.webkit.org/show_bug.cgi?id=83899
Reviewed by Adrienne Walker.
When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.
Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- 8:07 PM Changeset in webkit [114201] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
https://bugs.webkit.org/show_bug.cgi?id=83920
Reviewed by James Robinson.
Found by clang:
third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));
- tests/LayerChromiumTest.cpp:
- 8:06 PM Changeset in webkit [114200] by
-
- 39 edits6 deletes in trunk
Unreviewed, rolling out r114036.
http://trac.webkit.org/changeset/114036
https://bugs.webkit.org/show_bug.cgi?id=83969
Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebCore:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
- bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- dom/NodeList.idl:
LayoutTests:
- fast/dom/HTMLSelectElement/named-options-expected.txt:
- fast/dom/HTMLSelectElement/script-tests/named-options.js:
- fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
- fast/dom/NodeList/node-list-array-class.html: Removed.
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
- fast/dom/everything-to-string-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/js/recursion-limit-equal-expected.txt:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-dir-expected.txt:
- inspector/console/console-format-collections-expected.txt:
- jquery/traversing-expected.txt:
- platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
- platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
- platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
- platform/chromium/inspector/console/console-dir-expected.txt:
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- platform/chromium/jquery/traversing-expected.txt: Removed.
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 8:02 PM Changeset in webkit [114199] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Add null pointer check to animatePageScale
https://bugs.webkit.org/show_bug.cgi?id=83940
Patch by Alexandre Elias <aelias@google.com> on 2012-04-13
Reviewed by James Robinson.
Add null pointer check to startPageScaleAnimation.
If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.
No new tests.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animatePageScale):
- 7:33 PM Changeset in webkit [114198] by
-
- 5 edits in trunk/LayoutTests
Two lineboxcontain tests are failing
https://bugs.webkit.org/show_bug.cgi?id=82742
Reviewed by Ojan Vafai.
- platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
- platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
Rebaselined.
- platform/mac/Skipped:
- platform/mac/test_expectations.txt:
Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.
- 6:58 PM Changeset in webkit [114197] by
-
- 6 edits in trunk/Source
[chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262
Reviewed by Adrienne Walker.
Source/WebCore:
When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.
Unit test: CCOcclusionTrackerTestReplicaDoesOcclude
CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
- 6:30 PM Changeset in webkit [114196] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test case for JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=83747
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
- webaudio/javascriptaudionode-expected.txt: Added.
- webaudio/javascriptaudionode.html: Added.
- 6:29 PM Changeset in webkit [114195] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r114185.
http://trac.webkit.org/changeset/114185
https://bugs.webkit.org/show_bug.cgi?id=83967
Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
- runtime/CommonIdentifiers.h:
- tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases):
- 6:27 PM Changeset in webkit [114194] by
-
- 2 edits in trunk/LayoutTests
convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793
Patch by Raymond Toy <Raymond Toy> on 2012-04-13
Reviewed by Eric Seidel.
- platform/chromium/test_expectations.txt: Delete entry.
- 6:25 PM Changeset in webkit [114193] by
-
- 7 edits2 adds in trunk
AudioContext createChannelMerger() method should have optional argument for number of inputs.
https://bugs.webkit.org/show_bug.cgi?id=83759
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.
Source/WebCore:
Test: webaudio/audiochannelmerger-basic.html
- Modules/webaudio/AudioChannelMerger.cpp:
(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):
- Modules/webaudio/AudioChannelMerger.h:
(AudioChannelMerger):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelMerger):
(WebCore):
- Modules/webaudio/AudioContext.h:
(AudioContext):
- Modules/webaudio/AudioContext.idl:
LayoutTests:
- webaudio/audiochannelmerger-basic-expected.txt: Added.
- webaudio/audiochannelmerger-basic.html: Added.
- 6:20 PM Changeset in webkit [114192] by
-
- 4 edits in trunk/Source/JavaScriptCore
Don't rely on fixed offsets to patch calls
https://bugs.webkit.org/show_bug.cgi?id=83966
Rubber stamped by Oliver Hunt.
These aren't being used anywhere!
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- 5:42 PM Changeset in webkit [114191] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316
Reviewed by Adrienne Walker.
We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.
We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.
Covered by existing tests.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
- platform/graphics/chromium/TextureManager.h:
(TextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):
- 5:38 PM Changeset in webkit [114190] by
-
- 2 edits in trunk/Source/WebCore
Optimize tracking of intruding floats being removed from RenderBlock during layout
https://bugs.webkit.org/show_bug.cgi?id=82928
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.
Performance tweaks in RenderBlock layout as a follow up to r112935.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
- 5:36 PM Changeset in webkit [114189] by
-
- 14 edits2 adds in trunk
[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134
Reviewed by David Hyatt.
Source/WebCore:
The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.
The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).
Test: fast/regions/webkit-named-flow-content-nodes.html
- dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::detach):
- dom/Node.h:
(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
- rendering/FlowThreadController.h:
(FlowThreadController):
- rendering/RenderNamedFlowThread.cpp:
(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
- rendering/RenderNamedFlowThread.h:
(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):
LayoutTests:
- fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
- fast/regions/webkit-named-flow-content-nodes.html: Added.
- 5:34 PM Changeset in webkit [114188] by
-
- 2 edits in trunk/Source/WebCore
Remove the calls to CRASH() from ResourceLoader.cpp.
https://bugs.webkit.org/show_bug.cgi?id=83962
Reviewed by Alexey Proskuryakov.
They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):
- 5:33 PM Changeset in webkit [114187] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
https://bugs.webkit.org/show_bug.cgi?id=83523
Reviewed by Kent Tamura.
Revert r102190.
Convert characters being treatAsSpace to white space.
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):
- 5:27 PM Changeset in webkit [114186] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove fallback code for "Missing plug-in" string.
https://bugs.webkit.org/show_bug.cgi?id=81907
Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.
- src/LocalizedStrings.cpp:
(WebCore::missingPluginText):
- 5:26 PM Changeset in webkit [114185] by
-
- 4 edits in trunk/Source/JavaScriptCore
Array.prototype.toString and Array.prototype.toLocaleString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588
Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
- runtime/CommonIdentifiers.h:
- tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases.array.item.new.TestCase):
(getTestCases):
- 5:11 PM Changeset in webkit [114184] by
-
- 2 edits in trunk/Source/WebCore
Change how the Web Insector is installed on Mac builds.
<rdar://problem/10857918>
Reviewed by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources
and Streamline Inspector Source build phases.
- 4:44 PM Changeset in webkit [114183] by
-
- 6 edits in trunk/Source/JavaScriptCore
Don't rely on fixed offsets to patch method checks
https://bugs.webkit.org/show_bug.cgi?id=83958
Reviewed by Oliver Hunt.
- bytecode/StructureStubInfo.h:
- Add fields for the method check info.
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- Store the offsets on the stub info, instead of asserting.
- jit/JIT.h:
- Delete all the method check related offsets.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- Use the offset from the stubInfo.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Pass the stubInfo to patchMethodCallProto.
- 4:44 PM Changeset in webkit [114182] by
-
- 7 edits in trunk/LayoutTests
Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.
- compositing/images/direct-pdf-image-expected.png:
- compositing/repaint/newly-composited-repaint-rect-expected.png:
- compositing/visibility/visibility-image-layers-expected.png:
- compositing/visibility/visibility-simple-video-layer-expected.png:
- platform/mac/compositing/reflections/reflection-in-composited-expected.png:
- platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
- 4:43 PM Changeset in webkit [114181] by
-
- 1 edit11 deletes in trunk/LayoutTests
fast/dom/Window/window-property-descriptors.html is too much work to maintain
https://bugs.webkit.org/show_bug.cgi?id=83915
Reviewed by Alexey Proskuryakov.
The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.
Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)
- fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
- fast/dom/Window/window-property-descriptors.html: Removed.
- platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- 4:31 PM Changeset in webkit [114180] by
-
- 5 edits in trunk/Source
Video at apple.com gets standard controls in addition to custom controls after returning from full screen
https://bugs.webkit.org/show_bug.cgi?id=83939
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.
Instead of asking the media element whether it is in full screen or not, rely on when the media root element
was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
media element due to animations.
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):
- html/shadow/MediaControlRootElement.h:
(MediaControlRootElement): Added m_isFullscreen;
Source/WebKit2:
So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
immediately.
Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
controls don't momentarily appear at the end of an animation.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 4:27 PM Changeset in webkit [114179] by
-
- 5 edits1 delete in trunk
fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Fixes fullscreen/video-controls-drag.html.
Regressed in r110409. When the -webkit-media-controls-panel were changed
from position:absolute to position:relative, this broke dragging of the
controls in fullscreen, which relies on the panel being absolutely positioned
to do its drag positioning. Change the way drag positioning is calculated to
accommodate position:relative.
- css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,
use margin-bottom:50px to push panel up from the bottom of the screen.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
(WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations
only to calculate the new panel position.
- html/shadow/MediaControlElements.h:
LayoutTests:
Removed expected failing results from platform/mac.
- platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.
- 4:25 PM Changeset in webkit [114178] by
-
- 5 edits in trunk/LayoutTests
Fix two compositing animation tests to not have flakey pixel results
https://bugs.webkit.org/show_bug.cgi?id=83957
Reviewed by Dean Jackson.
Fix these tests to use the pause animation API by providing an animation
name in the expected data. There's no need to start the animations by hand.
- compositing/reflections/animation-inside-reflection.html:
- compositing/reflections/nested-reflection-animated.html:
- platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
- 4:16 PM Changeset in webkit [114177] by
-
- 2 edits in trunk/LayoutTests
Rebaseline this since svg/custom/resources/green-checker.png changed.
- svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
- 3:51 PM Changeset in webkit [114176] by
-
- 13 edits in trunk/LayoutTests
Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1
https://bugs.webkit.org/show_bug.cgi?id=83950
Reviewed by James Robinson.
Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
affect WebKit1 scrollbars.
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- 3:26 PM Changeset in webkit [114175] by
-
- 5 edits1 delete in trunk
Compositing layers not updated after scroll in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=83945
Source/WebCore:
Reviewed by James Robinson.
Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().
Covered by existing tests.
- page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
LayoutTests:
Reviewed by James Robinson.
Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.
Remove a passing test from test-expectations.
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
- platform/mac/test_expectations.txt:
- 3:09 PM Changeset in webkit [114174] by
-
- 2 edits in trunk/LayoutTests
Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:05 PM Changeset in webkit [114173] by
-
- 2 edits in trunk/PerformanceTests
Fix skipped list.
- Skipped:
- 3:02 PM Changeset in webkit [114172] by
-
- 6 edits4 adds in trunk
Don't process filters if the input region is exceptionally large.
https://bugs.webkit.org/show_bug.cgi?id=83317
Reviewed by Simon Fraser.
Source/WebCore:
An extremely large element causes problems with filters, either by
taking too long to compute the output or using too much memory. The
filter engine already has some constants for maximum expected size.
Make sure the render tree checks them before deciding to apply
effects.
Tests: css3/filters/huge-region-composited.html
css3/filters/huge-region.html
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
- rendering/FilterEffectRenderer.cpp:
(WebCore):
(WebCore::isFilterSizeValid):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::updateBackingStore):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
LayoutTests:
- css3/filters/huge-region-composited-expected.txt: Added.
- css3/filters/huge-region-composited.html: Added.
- css3/filters/huge-region-expected.txt: Added.
- css3/filters/huge-region.html: Added.
- 2:45 PM Changeset in webkit [114171] by
-
- 11 edits in trunk
Queue the cuechange event on HTMLTrackElement for proper sorting.
https://bugs.webkit.org/show_bug.cgi?id=83858
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Updates to media/track/track-cues-cuechange.html and
media/track/track-mode.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
Add HTMLTrackElement's cuechange event to the event queue rather than
firing it synchronously.
- html/track/LoadableTextTrack.cpp:
Remove fireCueChangeEvent() as it is no longer used.
- html/track/LoadableTextTrack.h:
Ditto.
- html/track/TextTrack.h:
(TextTrack):
Ditto.
LayoutTests:
- media/track/captions-webvtt/captions-fast.vtt:
Captions were a wee bit too fast: they need to be at least 250ms apart
for accurate testing as timeupdate events are only fired every 250ms.
- media/track/track-cues-cuechange-expected.txt:
Changes the order that cuechange events are fired.
- media/track/track-cues-cuechange.html:
Ditto.
- media/track/track-mode-expected.txt:
cuechange events are now fired at the proper times.
Test now checks for all cuechange events (both enter and exit of cues).
- media/track/track-mode.html:
Ditto.
- 2:32 PM Changeset in webkit [114170] by
-
- 9 edits48 adds in trunk
Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611
Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>
Source/WebCore:
As of today, any FrameView attached to the Widget-tree or any
RenderLayer whose corresponding RenderBox's style has a 'overflow'
property set to 'auto' is cached in its containing scrollable areas set.
We could be more restrictive about what we in fact want to
cache as scrollable areas, by checking if the element as an overflow
(i.e. more content than its viewport).
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Whenever the viewport changes, check if we have an scrollable/overflowed
content, and update the cache accordingly.
(WebCore::FrameView::setContentsSize):
Whenever the contents size changes, check if we have a scrollable/overflowed
content, and update the cache accordingly.
(WebCore::FrameView::calculateScrollbarModesForLayout):
Introduces a way to query for the scrollbars by only
taking into account the "rules" set by the web author.
For that, a new enum was added called SrollbarModesCalculationStrategy,
which allows callers to discard for example client-side scrollbar policies
in order to verify if a given frameview is scrollable or not.
(WebCore::FrameView::updateScrollableAreaSet):
Take into account various factors before considering a FrameView as
scrollable. If in the end it is, it gets added to its parent FrameView
scrollable areas map, otherwise removed.
(WebCore):
(WebCore::FrameView::addScrollableArea):
Became unneeded, thus removed.
(WebCore::FrameView::removeScrollableArea):
Whenever a FrameView is removed from the Widget-tree,
remove it from the cache.
- page/FrameView.h:
(FrameView):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Update scrollable area set after layout.
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Update scrollable area set after style changes.
(WebCore::RenderLayer::styleChanged):
Removed the scrollable areas logic detection from it.
(WebCore::RenderLayer::updateScrollableAreaSet):
Updates the containing FrameView scrollable areas cache
only when needed (i.e. an overflow exists).
(WebCore):
- rendering/RenderLayer.h:
(RenderLayer):
- testing/Internals.cpp:
(WebCore::Internals::numberOfScrollableAreas):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-overflow-hidden.html
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-scrolling-no.html
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
fast/scrolling/scrollable-area-frame-scrolling-yes.html
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-zero-size-and-border.html
fast/scrolling/scrollable-area-frame.html
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-display-none.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
fast/scrolling/scrollable-area-overflow-auto.html
fast/scrolling/scrollable-area-overflow-not-set.html
fast/scrolling/scrollable-area-overflow-visible.html
LayoutTests:
Reviewed by NOBODY (OOPS!).
Added scrollable area set count tests to many situations observed
in real world sites.
- fast/scrolling/resources/generic-scrollable-content.html: Added.
- fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
- fast/scrolling/resources/scrollable-area.js: Added.
(runTest):
(end):
- fast/scrolling/resources/scrollable-style.css: Added.
(.inner):
(.offscreen):
- fast/scrolling/scrollable-area-frame-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
- fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
- fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
- fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
- fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
- fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
- fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
- fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
- fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
- fast/scrolling/scrollable-area-frame.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
- fast/scrolling/scrollable-area-overflow-auto.html: Added.
- fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-not-set.html: Added.
- fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
- fast/scrolling/scrollable-area-overflow-visible.html: Added.
- 2:32 PM April 2012 Meeting edited by
- (diff)
- 2:29 PM Changeset in webkit [114169] by
-
- 2 edits in trunk/Source/WebKit2
Make sure that we're using the right compiler for generating derived sources.
Rubber-stamped by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [114168] by
-
- 6 edits in trunk/Source/WebCore
Track rem unit usage in StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=83923
Reviewed by Andreas Kling.
Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to
the stylesheet instead so parser does not need to know about the document. This also
avoids setting the flag unnecessarily when the stylesheet is not used.
- css/CSSGrammar.y:
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
- css/CSSStyleSheet.h:
(WebCore::StyleSheetInternal::parserSetUsesRemUnits):
(WebCore::StyleSheetInternal::usesRemUnits):
(StyleSheetInternal):
- dom/Document.cpp:
(WebCore):
(WebCore::checkUsesRemUnits):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(WebCore::Document::usesRemUnits):
- 2:19 PM Changeset in webkit [114167] by
-
- 2 edits in trunk/LayoutTests
Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html
Unreviewed.
- platform/chromium/test_expectations.txt:
- 2:01 PM Changeset in webkit [114166] by
-
- 18 edits in trunk
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
https://bugs.webkit.org/show_bug.cgi?id=83733
Reviewed by Adrienne Walker.
Source/Platform:
Remove compositeOffscreen setting. This was an experiment that is no longer needed.
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
Source/WebKit/chromium:
Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
- public/WebSettings.h:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- 1:57 PM Changeset in webkit [114165] by
-
- 5 edits in trunk
REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached
https://bugs.webkit.org/show_bug.cgi?id=83925
<rdar://problem/11231790>
Reviewed by Antti Koivisto.
Added subtests to http/tests/cache/subresource-expiration-2.html.
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age instead of the last. New behavior matches both Firefox and IE.
- 1:43 PM Changeset in webkit [114164] by
-
- 18 edits2 moves2 deletes in trunk/Source
[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851
Reviewed by Adam Barth.
Source/Platform:
Move WebVideoFrame API into Platform.
- Platform.gypi:
- chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
- chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
(WebKit):
Source/WebCore:
Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).
Covered by existing media/ and compositing/ layout tests.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebKit):
Source/WebKit/chromium:
Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.
- WebKit.gyp:
- public/WebVideoFrame.h:
- src/AssertMatchingEnums.cpp:
- src/VideoFrameChromiumImpl.cpp: Removed.
- src/VideoFrameChromiumImpl.h: Removed.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 12:43 PM Changeset in webkit [114163] by
-
- 6 edits1 add in trunk
Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859
Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/image-set-parsing.html
- WebCore.gypi:
Source/WebKit/chromium:
- features.gypi:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 12:39 PM Changeset in webkit [114162] by
-
- 6 edits12 adds in trunk/LayoutTests
Integrate IETC CSS : grid layout tests
https://bugs.webkit.org/show_bug.cgi?id=83830
Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth
- ietestcenter/css3/grid/display-grid-001.htm: Added.
- ietestcenter/css3/grid/display-grid-002.htm: Added.
- ietestcenter/css3/grid/grid-column-001.htm: Added.
- ietestcenter/css3/grid/grid-column-002.htm: Added.
- ietestcenter/css3/grid/grid-column-003.htm: Added.
- ietestcenter/css3/grid/grid-columns-001.htm: Added.
- ietestcenter/css3/grid/grid-items-001.htm: Added.
- ietestcenter/css3/grid/grid-items-002.htm: Added.
- ietestcenter/css3/grid/grid-items-003.htm: Added.
- ietestcenter/css3/grid/grid-items-004.htm: Added.
- ietestcenter/css3/grid/grid-items-005.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 12:34 PM Changeset in webkit [114161] by
-
- 3 edits3 copies in tags/Safari-536.6.2
Merged r113941.
- 12:33 PM Changeset in webkit [114160] by
-
- 12 edits5 deletes in trunk/Source
[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
https://bugs.webkit.org/show_bug.cgi?id=83807
Reviewed by Adam Barth.
Source/WebCore:
No new tests, existing tests apply.
- WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
- storage/StorageEventDispatcher.h: Delete a stale comment.
Source/WebKit/chromium:
- WebKit.gyp: Delete a few files.
- public/WebStorageNamespace.h: Remove some unused data members and methods, and annotate close() as deprecated.
- public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
- src/StorageAreaProxy.cpp: Remove the include of a deleted file.
- src/StorageEventDispatcherChromium.cpp: Removed.
- src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
- src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
- src/StorageNamespaceProxy.h: Moved some blank lines around.
- src/WebStorageAreaImpl.cpp: Removed.
- src/WebStorageAreaImpl.h: Removed.
- src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
- src/WebStorageNamespaceImpl.cpp: Removed.
- src/WebStorageNamespaceImpl.h: Removed.
- 12:32 PM Changeset in webkit [114159] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaselining after r114150.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- 12:26 PM Changeset in webkit [114158] by
-
- 3 edits in trunk/Tools
webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.
- Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPageLoadingPerfTest.test_run):
- 12:24 PM Changeset in webkit [114157] by
-
- 7 edits in trunk/Source/JavaScriptCore
Don't rely on fixed offsets to patch get_by_id/put_by_id
https://bugs.webkit.org/show_bug.cgi?id=83924
Reviewed by Oliver Hunt.
Store offsets in the structure stub info, as we do for the DFG JIT.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::differenceBetween):
- this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
- bytecode/StructureStubInfo.h:
- added new fields for baseline JIT offsets.
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- moved out from JIT::privateCompile.
(JSC::JIT::privateCompile):
- moved out code to PropertyStubCompilationInfo::copyToStubInfo.
- jit/JIT.h:
(PropertyStubCompilationInfo):
- added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
- removed many offsets.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- changed code generation to use new interface to store info on PropertyStubCompilationInfo.
- changed repatch functions to read offsets from the structure stub info.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- changed code generation to use new interface to store info on PropertyStubCompilationInfo.
- changed repatch functions to read offsets from the structure stub info.
- 12:21 PM Changeset in webkit [114156] by
-
- 4 edits in tags/Safari-536.6.2/Source
Versioning.
- 12:20 PM Changeset in webkit [114155] by
-
- 1 copy in tags/Safari-536.6.2
New Tag.
- 12:19 PM Changeset in webkit [114154] by
-
- 2 edits in trunk/LayoutTests
More rebaselining.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- 12:02 PM Changeset in webkit [114153] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Antonio Gomes.
Fix signed/unsigned comparison warning.
- parser/Lexer.cpp:
(JSC::::record16):
- 11:49 AM Changeset in webkit [114152] by
-
- 2 edits in trunk/Source/WebKit2
Include the error if we fail to initialize the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=83927
Reviewed by Alexey Proskuryakov.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
- 11:26 AM Changeset in webkit [114151] by
-
- 6 edits1 delete in trunk
Unreviewed, rolling out r114140.
http://trac.webkit.org/changeset/114140
https://bugs.webkit.org/show_bug.cgi?id=83921
Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebCore:
- WebCore.gypi:
Source/WebKit/chromium:
- features.gypi:
LayoutTests:
- platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 11:25 AM PrefixedAPIs edited by
- Added CanvasRenderingContext2D extensions for high-resolution backing … (diff)
- 11:20 AM Changeset in webkit [114150] by
-
- 13 edits4 adds in trunk
<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83836
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/2d.imageDataHD.html
Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and
webkitGetImageDataHD().
- platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values
LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
LayoutTests:
- fast/canvas/2d.imageDataHD-expected.txt: Added.
- fast/canvas/2d.imageDataHD.html: Added.
- 11:16 AM Changeset in webkit [114149] by
-
- 6 edits1 add in trunk
Enable SVG page loading performance tests
https://bugs.webkit.org/show_bug.cgi?id=83861
Reviewed by Adam Barth.
PerformanceTests:
Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).
- Skipped:
Tools:
Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.
Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
- Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
(MockPrinter):
(MockPrinter.init):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):
- 11:15 AM Changeset in webkit [114148] by
-
- 2 edits in trunk/LayoutTests
Rebaseline a test.
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- 11:06 AM Changeset in webkit [114147] by
-
- 12 edits2 adds in trunk/Source/WebCore
[chromium] Support CCHeadsUpDisplay in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=67499
Reviewed by James Robinson.
No new tests because this code is debugging code itself.
The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.
(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):
- platform/graphics/chromium/cc/CCFontAtlas.h: Added.
(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
- 11:06 AM Changeset in webkit [114146] by
-
- 2 edits in trunk/LayoutTests
Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.
- platform/gtk/test_expectations.txt:
- 11:03 AM Changeset in webkit [114145] by
-
- 11 edits8 copies in branches/chromium/1084
Merge 112582 - REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html
This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.
LayoutTests:
- fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
- fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
- fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
- fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
- fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
- fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
- fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
- fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.
Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
- platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
- platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
- platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
Rebaselined those tests on Chromium linux (new layers).
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
Skipped the previous tests on the other platforms.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10090001
- 10:47 AM Changeset in webkit [114144] by
-
- 2 edits in trunk/LayoutTests
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303
Unreviewed Chromium test_expectations clean up.
Previous clean up in r114137 dropped a WIN IMAGE failure suppression.
- platform/chromium/test_expectations.txt:
- 10:46 AM Changeset in webkit [114143] by
-
- 18 edits2 adds in trunk
<rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache
Source/WebKit2:
- Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified of back/forward navigations (and deny them if it chooses)
- Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.
Reviewed by Darin Adler.
Add the new WKBundleBackForwardListItem API:
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
(WKBundleBackForwardListItemIsInPageCache):
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
(WebKit::InjectedBundleBackForwardListItem::isInPageCache):
Update the UI page loader client to allow for a user data object to be passed from the bundle:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willGoToBackForwardListItem):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Add the new callback to the bundle loader client:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
Call the bundle client before doing anything else, possibly canceling the navigation:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.
Tools:
Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
Reviewed by Darin Adler.
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
- 10:43 AM Changeset in webkit [114142] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
<rdar://problem/10552398> Meringue: 11A390: CrashTracer: 56,187 crashes in WebProcess at com.apple.WebCore: WebCore::DocumentWriter::deprecatedFrameEncoding const + 12 (71828)
Reviewed by Darin Adler.
No new tests because this change is going only on the Safari Nectarine branch, not TOT.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
Nil check the activeDocumentLoader().
- 10:40 AM Changeset in webkit [114141] by
-
- 2 edits1 add in trunk/LayoutTests
Update baselines to make this test run again.
- platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
- platform/chromium/test_expectations.txt:
- 10:20 AM Changeset in webkit [114140] by
-
- 6 edits1 add in trunk
Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859
Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/image-set-parsing.html
- WebCore.gypi:
Source/WebKit/chromium:
- features.gypi:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 9:16 AM Changeset in webkit [114139] by
-
- 2 edits in trunk/LayoutTests
Mark test as even flakier: it can timeout.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 9:05 AM Changeset in webkit [114138] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Flag fast/regions
again. Only parts of it were passing, sigh.
- 8:49 AM Changeset in webkit [114137] by
-
- 2 edits in trunk/LayoutTests
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303
Unreviewed Chromium test_expectations clean up.
Consolidating common-cause flaky tests.
- platform/chromium/test_expectations.txt:
- 8:42 AM Changeset in webkit [114136] by
-
- 1794 edits1801 copies80 deletes in branches/subpixellayout
Merge trunk changes up until 114126 into subpixel branch.
- 8:41 AM Changeset in webkit [114135] by
-
- 5 edits in trunk
Web Inspector: do not attempt to load content from resource until request finished loading.
https://bugs.webkit.org/show_bug.cgi?id=83896
Reviewed by Yury Semikhatsky.
Source/WebCore:
When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
LayoutTests:
- inspector/debugger/raw-source-code.html:
- 8:40 AM Changeset in webkit [114134] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Unskip fast/regions and
svg/hixie/perf that seem to pass fine on GTK bots.
- 7:33 AM Changeset in webkit [114133] by
-
- 4 edits in trunk
Web Inspector: follow up to r114116 - fixing QT test
https://bugs.webkit.org/show_bug.cgi?id=83892
Reviewed by Yury Semikhatsky.
Source/WebCore:
Requesting content for the scripts exclusively via the page agent now.
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):
LayoutTests:
- inspector/debugger/raw-source-code.html:
- 7:30 AM Changeset in webkit [114132] by
-
- 3 edits in trunk/Tools
Group EFL bots into a category on the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=82712
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.
Creating a new category definition on the buildbot frontend.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig): Determine category for EFL bots
- BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
- 7:28 AM Changeset in webkit [114131] by
-
- 5 edits in trunk
InsertHTML fails to insert h6 if the insertion point is before some text.
https://bugs.webkit.org/show_bug.cgi?id=82689
Reviewed by Ryosuke Niwa.
Added the missing h6 tag for the isHeaderElement.
Source/WebCore:
No new tests: updated existing test (editing/execCommand/4128080-1.html)
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isHeaderElement):
LayoutTests:
- editing/execCommand/4128080-1-expected.txt:
- editing/execCommand/4128080-1.html:
- 7:25 AM Changeset in webkit [114130] by
-
- 2 edits in trunk/Source/WebKit/chromium
2012-04-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix after r114126.
- WebKit.gyp:
- 7:23 AM Changeset in webkit [114129] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.
This fixes API tests broken by r113715.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
- 7:18 AM Changeset in webkit [114128] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.
- 7:16 AM Changeset in webkit [114127] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:50 AM Changeset in webkit [114126] by
-
- 19 edits1 add2 deletes in trunk
Web Inspector: exception in heap profiler when expanding a class in summary view
https://bugs.webkit.org/show_bug.cgi?id=83883
Moved all DOM-specific inspector utilities into DOMExtension.js
Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.
Reviewed by Pavel Feldman.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/BinarySearch.js: Removed.
- inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.
(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):
- inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings
by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
- inspector/front-end/HeapSnapshotWorker.js:
- inspector/front-end/PartialQuickSort.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js:
(.):
- 6:45 AM Changeset in webkit [114125] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:26 AM Changeset in webkit [114124] by
-
- 4 edits in trunk
Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887
It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebKit2:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 6:16 AM Changeset in webkit [114123] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r114103.
http://trac.webkit.org/changeset/114103
https://bugs.webkit.org/show_bug.cgi?id=83884
New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
- inspector/front-end/Images/breakpointConditionalCounterBorder.png:
- inspector/front-end/Images/breakpointCounterBorder.png:
- inspector/front-end/Images/programCounterBorder.png:
- inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
- 6:14 AM Changeset in webkit [114122] by
-
- 3 edits2 adds in trunk
[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
https://bugs.webkit.org/show_bug.cgi?id=83760
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.
.:
- ManualTests/blackberry/http-cookie-database-set.php: Added.
- ManualTests/blackberry/http-cookie-database-update.php: Added.
Source/WebCore:
When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).
We must restart the browser to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-cookie-database-set.php
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::invokeOpen):
- 6:06 AM Changeset in webkit [114121] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:01 AM Changeset in webkit [114120] by
-
- 2 edits in trunk/Tools
webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
https://bugs.webkit.org/show_bug.cgi?id=83690
Reviewed by Tor Arne Vestbø.
Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py
- Scripts/webkit-tools-completion.sh:
- 5:57 AM Changeset in webkit [114119] by
-
- 6 edits in trunk/LayoutTests
[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- 5:56 AM Changeset in webkit [114118] by
-
- 4 edits in trunk/Source
[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
https://bugs.webkit.org/show_bug.cgi?id=83770
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
Source/WebKit2:
- Do the alignment on the highest level as possible: the QQuickFlickable content item position. It already supports this with setPixelAligned which rounds the content item's position.
- Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
- Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):
- 5:25 AM Changeset in webkit [114117] by
-
- 15 edits in trunk
Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=83871
Reviewed by Yury Semikhatsky.
Source/WebCore:
There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.
This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
- inspector/front-end/Database.js:
(WebInspector.Database.prototype.get displayDomain):
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
- inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/debugger/raw-source-code.html:
- 5:15 AM Changeset in webkit [114116] by
-
- 11 edits in trunk
Web Inspector: extracting NetworkRequest from Resource (step 3)
https://bugs.webkit.org/show_bug.cgi?id=83802
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.
- inspector/front-end/NetworkManager.js:
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
LayoutTests:
- http/tests/inspector/network/network-request-revision-content.html:
- inspector/debugger/raw-source-code.html:
- inspector/debugger/set-breakpoint.html:
- inspector/debugger/source-frame.html:
- 5:12 AM Changeset in webkit [114115] by
-
- 2 edits in trunk/Source/WebCore
use getClipDeviceBounds, rather than (deprecated) getTotalClip
https://bugs.webkit.org/show_bug.cgi?id=83808
Reviewed by Stephen White.
Equivalent functionality, existing tests apply.
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):
- 5:02 AM Changeset in webkit [114114] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:44 AM Changeset in webkit [114113] by
-
- 14 edits2 adds in trunk
[EFL] Add API for color chooser
https://bugs.webkit.org/show_bug.cgi?id=83692
.:
Enables INPUT_TYPE_COLOR by default on the EFL port.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
- PlatformEfl.cmake:
- platform/efl/ColorChooserEfl.cpp: Added.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
- platform/efl/ColorChooserEfl.h: Added.
(WebCore):
(ColorChooserEfl):
Source/WebKit/efl:
Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
- ewk/ewk_private.h:
(WebCore):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
- ewk/ewk_view.h:
Tools:
Enables INPUT_TYPE_COLOR by default on the EFL port.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
- Scripts/build-webkit:
- 4:25 AM Changeset in webkit [114112] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt:
- 4:19 AM Changeset in webkit [114111] by
-
- 1 edit3 adds in trunk/LayoutTests
Linux rebaselines.
Unreviewed.
- platform/chromium-linux/platform/chromium/compositing/filters: Added.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
- 4:16 AM Changeset in webkit [114110] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Build fix with QT_NO_BEARERMANAGEMENT
Reviewed by Jocelyn Turcotte.
- 4:11 AM Changeset in webkit [114109] by
-
- 3 edits2 adds in trunk
Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.
Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html
- page/FrameView.cpp:
(WebCore::FrameView::delegatesScrollingDidChange):
LayoutTests:
- fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
- fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.
- 4:09 AM Changeset in webkit [114108] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762
Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.
Reviewed by Kent Tamura.
- public/WebInputElement.h:
(WebKit):
(WebInputElement):
- src/WebInputElement.cpp:
(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.
- 4:00 AM April 2012 Meeting edited by
- (diff)
- 3:39 AM Changeset in webkit [114107] by
-
- 2 edits64 adds in trunk/LayoutTests
Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.
- platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
- platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
- platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/gtk/fast/dom/gc-10-expected.txt: Added.
- platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
- platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
- platform/gtk/fast/images/exif-orientation-expected.txt: Added.
- platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
- platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
- platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
- platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
- platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
- platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
- platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
- platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
- platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
- platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
- platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
- platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
- platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
- platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
- platform/gtk/fast/text/hyphens-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
- platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
- platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
- platform/gtk/test_expectations.txt: Mark a media/track test flaky.
- 3:37 AM Changeset in webkit [114106] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fix build on OS X
We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.
Reviewed by Simon Hausmann.
- 3:29 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 3:23 AM Changeset in webkit [114105] by
-
- 2 edits in trunk/LayoutTests
New suppression.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:11 AM Changeset in webkit [114104] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.
- 3:10 AM Changeset in webkit [114103] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.
Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view
No additional test cases required for the above fix.
- inspector/front-end/Images/breakpointConditionalCounterBorder.png:
- inspector/front-end/Images/breakpointCounterBorder.png:
- inspector/front-end/Images/programCounterBorder.png:
- inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
- 2:37 AM Changeset in webkit [114102] by
-
- 2 edits in trunk/LayoutTests
Now test sometimes crashes in Debug on XP too.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 2:15 AM Changeset in webkit [114101] by
-
- 7 edits in trunk/Source
Add a runtime flag for <input type=date>
https://bugs.webkit.org/show_bug.cgi?id=83853
Reviewed by Adam Barth.
Source/WebCore:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()
Source/WebKit/chromium:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.
- 2:12 AM Changeset in webkit [114100] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Skip failing new
encrypted-media test.
- 1:58 AM Changeset in webkit [114099] by
-
- 1 edit3 adds in trunk/LayoutTests
Rebaselines.
Unreviewed.
- platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
- platform/chromium-mac/fast/text/international/002-expected.png: Added.
- platform/chromium-mac/fast/text/international/002-expected.txt: Added.
- 1:57 AM Changeset in webkit [114098] by
-
- 2 edits in trunk/Source/WebCore
JSDocument::setLocation does too much bare-handed lifting
https://bugs.webkit.org/show_bug.cgi?id=83850
Reviewed by Sam Weinig.
As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way. There shouldn't
be any behavior change.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
- 1:55 AM Changeset in webkit [114097] by
-
- 1 edit4 adds in trunk/LayoutTests
Rebaselines.
Unreviewed.
- platform/chromium-win/platform/chromium/compositing/filters: Added.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
- 1:44 AM Changeset in webkit [114096] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 1:39 AM Changeset in webkit [114095] by
-
- 5 edits4 adds in trunk
Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350
Reviewed by Nikolas Zimmermann.
Source/WebCore:
calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.
Since CachedImage has already similar code, we moved it to IntSize and shared it.
Tests: fast/css/zoom-background-repeat-x-expected.html
fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- platform/graphics/IntSize.h:
(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
LayoutTests:
- fast/css/zoom-background-repeat-x-expected.html: Added.
- fast/css/zoom-background-repeat-x.html: Added.
- fast/css/zoom-background-repeat-y-expected.html: Added.
- fast/css/zoom-background-repeat-y.html: Added.
- 12:56 AM Changeset in webkit [114094] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
- DEPS:
- 12:53 AM Changeset in webkit [114093] by
-
- 2 edits in trunk/Source/WebCore
Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838
Reviewed by Ryosuke Niwa.
Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.
This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
For context, see:
https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
- 12:35 AM Changeset in webkit [114092] by
-
- 3 edits2 adds in trunk
Should clear an invalid string in a date field on blur
https://bugs.webkit.org/show_bug.cgi?id=83863
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/forms/date/input-date-commit-valid-only.html
- html/DateInputType.cpp:
(WebCore::DateInputType::handleBlurEvent):
Reset the visible value. The code is same as NumberInputType::handleBlurEvent().
LayoutTests:
- fast/forms/date/input-date-commit-valid-only-expected.txt: Added.
- fast/forms/date/input-date-commit-valid-only.html: Added.
- 12:30 AM Changeset in webkit [114091] by
-
- 2 edits in trunk/LayoutTests
[Chromium] <input type=date> tests should pass.
- platform/chromium/test_expectations.txt:
Apr 12, 2012:
- 11:33 PM Changeset in webkit [114090] by
-
- 2 edits in trunk/Source/WebCore
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
https://bugs.webkit.org/show_bug.cgi?id=83685
Reviewed by Kentaro Hara.
Remove the followings from input files:
- multi line comments /*...*/ (.js and .css)
- single line comment ... (.js)
- repeating whitespace (.js and .css)
- leading and trailing whitespace (.js and .css)
- empty lines (.js and .css)
This doesn't work for arbitrary JavaScript or CSS inputs, but
works well for expected input files like
css/make-css-file-arrays.pl
- make-file-arrays.py:
(strip_whitespace_and_comments):
(main):
- 11:19 PM Changeset in webkit [114089] by
-
- 2 edits in trunk/LayoutTests
Mark test as also crashing.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 11:14 PM Changeset in webkit [114088] by
-
- 3 edits in trunk/Source/WebCore
Chromium: Fix scrollbar tickmark drawing on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=83844
Patch by Sailesh Agrawal <sail@chromium.org> on 2012-04-12
Reviewed by James Robinson.
On Mountain Lion overlay scrollbars have a new expanded mode. In expanded mode the scrolllbar is slightly wider which causes the tickmarks to look incorrect. Fix was to explicitly enter expanded mode to get the correct look.
Screenshots:
broken: http://i.imgur.com/PDKYH.png
fixed: http://i.imgur.com/utp0Y.png
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint): Called setExpanded if API is available.
- platform/mac/NSScrollerImpDetails.h: Exposed the isExpanded: API.
- 11:11 PM Changeset in webkit [114087] by
-
- 2 edits in trunk/LayoutTests
Rebaselines.
Unreviewed.
- platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- 11:08 PM Changeset in webkit [114086] by
-
- 2 edits in trunk/LayoutTests
Rebaselines.
Unreviewed.
- platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
- 11:07 PM Changeset in webkit [114085] by
-
- 2 edits in trunk/Source/WebCore
LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859
Reviewed by Hajime Morita.
udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().
No new tests. This behavior depends on the timezone setting of the local machine.
- platform/text/LocalizedDateICU.cpp:
(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.
- 11:00 PM Changeset in webkit [114084] by
-
- 2 edits in trunk
[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753
Reviewed by Martin Robinson.
- configure.ac:
- 10:37 PM Changeset in webkit [114083] by
-
- 139 edits17 adds25 deletes in trunk/LayoutTests
Rebaselines.
Unreviewed.
- fast/media/mq-min-pixel-ratio-expected.txt: Added.
- fast/reflections/reflection-masks-expected.txt: Added.
- fast/reflections/reflection-masks-opacity-expected.txt: Added.
- fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
- platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
- platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
- platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
- platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
- platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
- platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
- platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
- platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
- platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-mac/css3/filters/effect-blur-expected.png:
- platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/css3/filters/effect-contrast-expected.png:
- platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
- platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/css3/filters/effect-invert-expected.png:
- platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-opacity-expected.png:
- platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/css3/filters/effect-saturate-expected.png:
- platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-sepia-expected.png:
- platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
- platform/chromium-mac/css3/filters/regions-expanding-expected.png:
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
- platform/chromium-mac/platform/chromium/virtual/threaded: Added.
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing: Added.
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility: Added.
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
- platform/chromium-mac/svg/custom/createImageElement-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/createImageElement2-expected.png:
- platform/chromium-mac/svg/custom/focus-ring-expected.png:
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/js-update-image-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/efl/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
- platform/efl/fast/reflections/reflection-masks-expected.txt: Removed.
- platform/efl/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
- platform/efl/fast/reflections/reflection-masks-outset-expected.png: Removed.
- platform/efl/fast/reflections/reflection-masks-outset-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt: Removed.
- platform/gtk/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
- platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
- platform/mac/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
- platform/qt/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
- platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
- 10:31 PM Changeset in webkit [114082] by
-
- 5 edits in trunk/Source/WebCore
Prepare window.location for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83843
Reviewed by Eric Seidel.
This patch refactors window.location to flow through
FrameLoader::findFrameForNavigation, which is where we're going to
implement the seamless navigation redirect. This patch shouldn't cause
any observable changes in behavior today, but it will make all the
seamless-window-location* tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
pass once we merge the seamlesss branch. See
https://github.com/eseidel/webkit/commit/a6e708fa6c643b156397e9a287b40a0868c7959c
for context.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
- page/Location.cpp:
(WebCore::Location::setHref):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::assign):
(WebCore::Location::replace):
(WebCore::Location::setLocation):
(WebCore):
- page/Location.h:
(Location):
- 10:28 PM Changeset in webkit [114081] by
-
- 17 edits10 adds in trunk
[chromium] Background filters for composited layers
https://bugs.webkit.org/show_bug.cgi?id=80046
Reviewed by Adrienne Walker.
Source/WebCore:
Adds background filters to LayerChromium/CCLayerImpl. These filters are
applied to any pixels in the contents behind the layer and seen through
it.
This is done by adding a backgroundTexture() to the render surface, which
holds the read-back contents of the target framebuffer, background filter
applied, in the surface's own coordinate space. Then this is drawn back
into the frame buffer before the contents of the surface itself is drawn.
Tests: platform/chromium/compositing/filters/background-filter-blur-off-axis.html
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/filters/background-filter-blur.html
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBackgroundFilters):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::backgroundFilters):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderSurface):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundFilters):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundFilters):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::computeDeviceTransform):
(WebCore::CCRenderSurface::computeDeviceBoundingBox):
(WebCore::CCRenderSurface::computeReadbackDeviceBoundingBox):
(WebCore::CCRenderSurface::readbackDeviceContentRect):
(WebCore::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::copyDeviceToBackgroundTexture):
(WebCore::getSkBitmapTextureId):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::applyFilters):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):
(WebCore::CCRenderSurface::backgroundTexture):
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::setBackgroundBlurOnNode):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/chromium:
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
LayoutTests:
- platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
- platform/chromium/compositing/filters/background-filter-blur-expected.txt: Added.
- platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
- platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Added.
- platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Added.
- platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
- platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
- platform/chromium/compositing/filters/background-filter-blur-outsets.html: Added.
- platform/chromium/compositing/filters/background-filter-blur.html: Added.
- 9:39 PM Changeset in webkit [114080] by
-
- 4 edits in trunk/Source/WebCore
Remove V8DOMWindowShell::setLocation
https://bugs.webkit.org/show_bug.cgi?id=83833
Reviewed by Eric Seidel.
V8DOMWindowShell::setLocation is only used by document.location. It's
more direct for document.location to call Location::setHref directly.
This integrates correctly with the navigation rules for
<iframe seamless>.
(See https://github.com/eseidel/webkit/compare/master...seamless for
more context about the connection with seamless.)
Reviewed on GitHub:
https://github.com/abarth/webkit/commit/48601729d53a6ac39df5a43b22218c91330c3f61
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorSetter):
- 9:19 PM Changeset in webkit [114079] by
-
- 7 edits in trunk/Source/WebCore
Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726
Reviewed by Eric Seidel.
Preparing the functions that live in LengthFunctions for sub-pixel layout, which entails
using and returning LayoutUnits instead of integers. There are a number of rendering
classes that are laid out using integers -- see https://trac.webkit.org/wiki/LayoutUnit
for details -- so this also adds integer-specific versions of the length functions for
explicit use in those classes.
No new tests. No change in behavior.
- css/LengthFunctions.h:
(WebCore): Using LayoutUnits for sub-pixel precision and adding integer-specific versions
of minimumValueForLength and valueForLength that truncate.
- css/LengthFunctions.cpp:
(WebCore):
- dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Document sizes are integral.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis): The frame tree continues to be integral.
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired): RenderMarquee scrolling uses integral values.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Table layout is integral.
- 8:51 PM Changeset in webkit [114078] by
-
- 17 edits1 copy2 moves1 add in trunk/Source
Unreviewed, rolling out r114075.
http://trac.webkit.org/changeset/114075
https://bugs.webkit.org/show_bug.cgi?id=83857
Breaks compile (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
Source/Platform:
- Platform.gypi:
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/VideoFrameChromium.cpp: Renamed from Source/Platform/chromium/src/WebVideoFrame.cpp.
(WebCore):
(WebCore::VideoFrameChromium::~VideoFrameChromium):
- platform/graphics/chromium/VideoFrameChromium.h: Copied from Source/Platform/chromium/public/WebVideoFrame.h.
(WebCore):
(VideoFrameChromium):
- platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebVideoFrame.h:
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
- src/AssertMatchingEnums.cpp:
- src/VideoFrameChromiumImpl.cpp: Added.
(WebKit):
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
(WebKit::VideoFrameChromiumImpl::requiredTextureSize):
(WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
(WebKit::VideoFrameChromiumImpl::textureId):
(WebKit::VideoFrameChromiumImpl::textureTarget):
- src/VideoFrameChromiumImpl.h: Renamed from Source/Platform/chromium/public/WebVideoFrame.h.
(WebKit):
(VideoFrameChromiumImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 8:47 PM Changeset in webkit [114077] by
-
- 2 edits in trunk/Source/WebCore
Use _self to represnet self-navigation, like in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=83834
Reviewed by Eric Seidel.
This patch aligns the internal state representation of the FrameLoader
more closely with the HTML5 spec. Both the null string and "_self"
represent self-navigation, but the HTML5 spec distinguishes them when
navigating seamless iframes. In that case, "_self" is explicit
self-navigation, whereas a null string will get redirected to the
"master" frame (the closest enclosing non-seamless frame).
This patch shouldn't have any observable behavior changes, but it will
be useful when we merge in the seamless branch from GitHub.
(See https://github.com/eseidel/webkit/commit/df0e71fcacdb0e7e45fe669afe1314cec5b76523
which contains this change.)
Once the seamless branch lands, this change will be tested by a number
of tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
including seamless-hyperlink.html.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
- 8:11 PM Changeset in webkit [114076] by
-
- 3 edits1 add in trunk/Tools
Extract PerfTest class from PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83847
Reviewed by Hajime Morita.
Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
that was previously represented by a tuple.
Also moved the logic to determine whether a given test is chromium style or not from run() to
_collect_tests(). And moved the output parsing algorithms for parser style and chromium style
tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
add new types of tests more easily.
- Scripts/webkitpy/performance_tests/perftest.py: Added.
(PerfTest):
(PerfTest.init):
(PerfTest.test_name):
(PerfTest.dirname):
(PerfTest.path_or_url):
(PerfTest._should_ignore_line_in_parser_test_result):
(PerfTest.parse_output):
(ChromiumStylePerfTest):
(ChromiumStylePerfTest.init):
(ChromiumStylePerfTest.parse_output):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(_tests_for_runner):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(_collect_tests_and_sort_test_name):
(test_collect_tests):
(test_collect_tests_with_skipped_list):
- 7:52 PM Changeset in webkit [114075] by
-
- 17 edits2 moves2 deletes in trunk/Source
[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851
Reviewed by Adam Barth.
Source/Platform:
Move WebVideoFrame API into Platform.
- Platform.gypi:
- chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
- chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
(WebKit):
Source/WebCore:
Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).
Covered by existing media/ and compositing/ layout tests.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebKit):
Source/WebKit/chromium:
Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.
- WebKit.gyp:
- public/WebVideoFrame.h:
- src/AssertMatchingEnums.cpp:
- src/VideoFrameChromiumImpl.cpp: Removed.
- src/VideoFrameChromiumImpl.h: Removed.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 7:51 PM Changeset in webkit [114074] by
-
- 8 edits in trunk
REGRESSION (r113900): Text tests started failing
https://bugs.webkit.org/show_bug.cgi?id=83724
Reviewed by Dan Bernstein.
Source/WebCore:
- Resources/DefaultFonts.plist.in: Use serif fonts for standard family again,
and updated the list with better fonts for Japanese.
LayoutTests:
- platform/mac/Skipped: unskip the tests.
- platform/mac/fast/ruby/nested-ruby-expected.png:
- platform/mac/fast/ruby/nested-ruby-expected.txt:
- platform/mac/fast/text/international/002-expected.png:
- platform/mac/fast/text/international/002-expected.txt:
Updated for minor rendering differences.
- 7:49 PM Changeset in webkit [114073] by
-
- 4 edits in branches/chromium/1025/Source/WebCore
Merge 113132 - [Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002
Reviewed by Kent Tamura.
Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.
No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.
- platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.
TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10072004
- 7:30 PM Changeset in webkit [114072] by
-
- 2 edits in trunk/Source/JavaScriptCore
Improve replaceUsingStringSearch() for case of a single character searchValue
https://bugs.webkit.org/show_bug.cgi?id=83738
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.
This patch improves replaceUsingStringSearch() with the following:
-Add a special case for single character search, taking advantage of the faster WTF::find().
-Inline replaceUsingStringSearch().
-Use StringImpl::create() instead of UString::substringSharingImpl() since we know we are in the bounds
by definition.
This gives less than 1% improvement for the multicharacter replace.
The single character search show about 9% improvement.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingStringSearch):
- 7:25 PM Changeset in webkit [114071] by
-
- 4 edits in trunk/Source/WTF
Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.
The implementation of StringImpl::find() is a simple branch before invoking one of
two inline functions. The overhead of having a function for StringImpl::find() is significant.
It is better to let the compiler decide if that should be inlined or not.
- wtf/text/StringImpl.cpp:
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::find):
(WTF):
(WTF::reverseFind):
(WTF::StringImpl::find):
- wtf/text/WTFString.h:
- 7:12 PM Changeset in webkit [114070] by
-
- 4 edits in trunk/Source
Versioning.
- 6:54 PM Changeset in webkit [114069] by
-
- 4 edits in trunk/Source
Preprocessing text files with modern clang treats double slashes in comments
https://bugs.webkit.org/show_bug.cgi?id=83827
Reviewed by Mark Rowe.
Source/WebCore:
- DerivedSources.make: Pass appropriate flags to both llvm and gcc.
Source/WebKit2:
- DerivedSources.make: Pass appropriate flags to both llvm and gcc.
- 6:36 PM Changeset in webkit [114068] by
-
- 4 edits in branches/safari-534.57-branch/Source/WebCore
Merged r113415.
- 6:32 PM Changeset in webkit [114067] by
-
- 23 edits4 copies7 adds in trunk
Add Encrypted Media Extensions events and errors to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-12
Reviewed by Adam Barth.
The new events and errors are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#events.
Source/WebCore:
Tests: fast/events/constructors/media-key-event-constructor.html
media/encrypted-media/encrypted-media-constants.html
media/encrypted-media/encrypted-media-events.html
- WebCore.gypi:
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
- bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- html/HTMLAttributeNames.in:
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMediaElement.idl:
- html/MediaError.h:
- html/MediaError.idl:
- html/MediaKeyError.h: Added.
(WebCore):
(MediaKeyError):
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::code):
(WebCore::MediaKeyError::MediaKeyError):
- html/MediaKeyError.idl: Added.
- html/MediaKeyEvent.cpp: Added.
(WebCore):
(WebCore::MediaKeyEventInit::MediaKeyEventInit):
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEvent::~MediaKeyEvent):
(WebCore::MediaKeyEvent::interfaceName):
- html/MediaKeyEvent.h: Added.
(WebCore):
(MediaKeyEventInit):
(MediaKeyEvent):
(WebCore::MediaKeyEvent::create):
(WebCore::MediaKeyEvent::keySystem):
(WebCore::MediaKeyEvent::sessionId):
(WebCore::MediaKeyEvent::initData):
(WebCore::MediaKeyEvent::message):
(WebCore::MediaKeyEvent::defaultURL):
(WebCore::MediaKeyEvent::errorCode):
(WebCore::MediaKeyEvent::systemCode):
- html/MediaKeyEvent.idl: Added.
- page/DOMWindow.idl:
- platform/graphics/MediaPlayer.cpp:
(WebCore):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):
- platform/graphics/MediaPlayer.h:
(MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):
Source/WebKit/chromium:
- public/WebMediaPlayerClient.h:
- src/AssertMatchingEnums.cpp:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::keyAdded):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::keyError):
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit::WebMediaPlayerClientImpl::keyNeeded):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
- fast/events/constructors/media-key-event-constructor-expected.txt: Added.
- fast/events/constructors/media-key-event-constructor.html: Added.
- fast/js/resources/js-test-pre.js:
(shouldBeZero):
(shouldBeEmptyString):
- media/encrypted-media/encrypted-media-constants-expected.txt: Added.
- media/encrypted-media/encrypted-media-constants.html: Added.
- media/encrypted-media/encrypted-media-events-expected.txt: Added.
- media/encrypted-media/encrypted-media-events.html: Added.
- media/video-test.js:
(testExpected):
(testArraysEqual):
- 6:29 PM Changeset in webkit [114066] by
-
- 3 edits in branches/subpixellayout/Source/WebCore
Add size_t versions of multiplication and division operators to FractionalLayoutUnit and remove unneeded casts.
- 6:26 PM Changeset in webkit [114065] by
-
- 2 edits in trunk/Source/WebCore
Reset the user preferred language overrides in Internals::reset
https://bugs.webkit.org/show_bug.cgi?id=83845
Reviewed by Ryosuke Niwa.
We don't want setting the language override in one test to affect subsequent tests,
so make sure to reset it in Internals::reset.
- testing/Internals.cpp:
(WebCore::Internals::reset):
- 6:11 PM Changeset in webkit [114064] by
-
- 9 edits in trunk/LayoutTests
Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197
Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-12
Reviewed by Ryosuke Niwa.
It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.
- fast/dom/onerror-img.html:
- fast/js/custom-constructors-expected.txt:
- fast/js/script-tests/custom-constructors.js:
- fast/notifications/notifications-double-show.html:
- fast/notifications/notifications-with-permission.html:
- fast/notifications/notifications-without-permission.html:
- 6:08 PM Changeset in webkit [114063] by
-
- 3 edits in trunk/Source/WebCore
[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
https://bugs.webkit.org/show_bug.cgi?id=83837
Reviewed by James Robinson.
- merge CCSingleThreadProxy::commitIfNeeded() and CCSingleThreadProxy::doComposite() into commitAndComposite()
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback): call site updated.
(WebCore::CCSingleThreadProxy::compositeImmediately): ditto.
(WebCore::CCSingleThreadProxy::commitAndComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- 6:07 PM Changeset in webkit [114062] by
-
- 5 edits in trunk/Source/WebCore
Remove FrameLoader:m_isLoadingMainResource, since it is always
false at the only point it is checked.
https://bugs.webkit.org/show_bug.cgi?id=83819
Reviewed by Adam Barth.
No new tests, no functionality change intended.
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end): Merge with endIfNotLoadingMainResource(), always end, assert that we're still attached.
- loader/DocumentWriter.h:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h: Remove isLoadingMainResource(), didEndDocument(), and m_isLoadingMainResource.
- 6:03 PM Changeset in webkit [114061] by
-
- 4 edits in branches/safari-534.57-branch/WebKitLibraries
Merged r113649.
- 6:01 PM Changeset in webkit [114060] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r113528.
- 5:58 PM Changeset in webkit [114059] by
-
- 15 edits2 adds in trunk
XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432
Reviewed by Ryosuke Niwa.
Source/WebCore:
Serialize the xml declaration exactly as parsed, if present in the document.
Test: fast/dom/dom-parse-serialize-xmldecl.html
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setXMLStandalone): update xmlStandalone to either yes or no.
- dom/Document.h:
(WebCore::Document::xmlStandalone):
(WebCore::Document::xmlStandaloneStatus): xmlStandalone can be unspecified, yes or no.
(WebCore::Document::hasXMLDeclaration): test if xml declaration is present.
(WebCore::Document::setHasXMLDeclaration):
(Document):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration): write xml declaration if present.
(WebCore):
(WebCore::MarkupAccumulator::appendStartMarkup):
- editing/MarkupAccumulator.h:
(MarkupAccumulator):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.
LayoutTests:
Verify that xml declaration gets serialized if present. The updated test results are improvements.
- fast/dom/dom-parse-serialize-display-expected.txt:
- fast/dom/dom-parse-serialize-expected.txt:
- fast/dom/dom-parse-serialize-xmldecl-expected.txt: Added.
- fast/dom/dom-parse-serialize-xmldecl.html: Added.
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- fast/xsl/xslt-processor-expected.txt:
- http/tests/xmlhttprequest/xml-encoding-expected.txt:
- platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- 5:52 PM Changeset in webkit [114058] by
-
- 7 edits in branches/safari-534.57-branch
Merged r112023.
- 5:42 PM Changeset in webkit [114057] by
-
- 4 edits in trunk/Source/WebCore
window.open should prepare for seamless navigation by using findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835
Reviewed by Ryosuke Niwa.
Before this patch, window.open called FrameTree::find and
Document::canNavigate separately. This patch refactors the code to
call FrameLoader::findFrameForNavigation, which does both. This
refactoring prepares window.open to understand seamless navigation,
which will happen in findFrameForNavigation.
This patch should have no behavior change today, but once we merge the
seamless branch, this change will be tested by
https://github.com/eseidel/webkit/blob/seamless/LayoutTests/fast/frames/seamless/seamless-window-open.html
See https://github.com/eseidel/webkit/commit/a0d8b7defbb63047912aefbc8e22bca4f0638c37 for context.
- WebCore.exp.in:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
(WebCore::createWindow):
- loader/FrameLoader.h:
(FrameLoader):
- 5:26 PM Changeset in webkit [114056] by
-
- 9 edits in trunk/LayoutTests
Convert layout test resource PNGs to sRGB. Some tests, such as
compositing/color-matching/image-color-matching.html, expect that
images with an RGB profile will not be altered when displayed. However,
some of the resources have RGB profiles that are different from sRGB
and actually should change when displayed with color profile support.
https://bugs.webkit.org/show_bug.cgi?id=83799
Patch by Tony Payne <tpayne@chromium.org> on 2012-04-12
Reviewed by Adam Barth.
- compositing/resources/thiswayup.png:
- css3/filters/resources/reference.png:
- fast/media/resources/apple_logo_half_size.png:
- fast/reflections/resources/kate.png:
- svg/as-border-image/resources/large-tiles.png:
- svg/custom/resources/green-checker.png:
- svg/custom/resources/red-checker.png:
- svg/wicd/resources/test-svg-child-object-rightsizing.png:
- 5:24 PM Changeset in webkit [114055] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r111977.
- 5:20 PM Changeset in webkit [114054] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r111108.
- 5:15 PM Changeset in webkit [114053] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r110150.
- 5:09 PM Changeset in webkit [114052] by
-
- 2 edits in trunk/Source/JavaScriptCore
StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823
Reviewed by Gavin Barraclough.
Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::reset):
- 5:08 PM Changeset in webkit [114051] by
-
- 1 copy in tags/Safari-536.7
New Tag.
- 5:05 PM Changeset in webkit [114050] by
-
- 2 edits in branches/safari-534.57-branch/Source/WebCore
Merged r110139.
- 5:03 PM Changeset in webkit [114049] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.
- platform/chromium/test_expectations.txt:
- 4:58 PM Changeset in webkit [114048] by
-
- 8 edits in trunk/Source
REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
https://bugs.webkit.org/show_bug.cgi?id=83832
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Shipping versions of iAd Producer rely on the pre-r102262 behavior of
respecting '!important' when specified in a CSSStyleDeclaration
property setter. Restore this quirky behavior for versions of the app
that expect it.
- WebCore.exp.in: Export
Settings::setShouldRespectPriorityInCSSAttributeSetters().
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate): If
setShouldRespectPriorityInCSSAttributeSetters() is true, restore the
pre-r102262 behavior wherein we attempt to parse '!important' out of
the property value.
- page/Settings.cpp:
(WebCore::Settings::setShouldRespectPriorityInCSSAttributeSetters):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
- page/Settings.h:
Source/WebKit/mac:
- Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first
version of WebKit.framework to ignore '!important' in
CSSStyleDeclaration property setters.
- WebView/WebView.mm:
(shouldRespectPriorityInCSSAttributeSetters):
(-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
quirk to restore pre-r102262 behavior if the application is iAd Producer
and was linked against a version of WebKit.framework that had the old behavior.
- 4:58 PM Changeset in webkit [114047] by
-
- 5 edits4 copies in branches/safari-534.57-branch
Merged r109480.
- 4:55 PM Changeset in webkit [114046] by
-
- 4 edits2 adds in trunk
REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
https://bugs.webkit.org/show_bug.cgi?id=83815
Reviewed by Simon Fraser.
Source/WebCore:
The filtered area used to be the dirty rect intersected by the bounding box of the
layer. During a previous change that behavior was lost, so adding it back now.
Also, removing the memory buffers used to compute filters after the filter is computed.
They are deleted next time the filter is applied anyway, so there's no need to keep the
memory for them.
Test: css3/filters/offscreen-filters-memory-usage.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
(WebCore):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
LayoutTests:
Adding a test that creates a lot of layers outside the viewport. The memory should not grow
and the browser should not crash.
- css3/filters/offscreen-filters-memory-usage-expected.txt: Added.
- css3/filters/offscreen-filters-memory-usage.html: Added.
- 4:10 PM Changeset in webkit [114045] by
-
- 2 edits in trunk/Source/WebKit2
[WinCairo] Build fix after Windows export definition file change.
- win/WebKit2CFLite.def: This file needs to be kept in sync with
WebKit2.def (aside from the WebKitInterface exports.)
- 4:08 PM Changeset in webkit [114044] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Build fix after addition of openTypeTable.
- platform/graphics/FontPlatformData.h:
(FontPlatformData): The openTypeTable declaration is needed
for WinCairo as well.
- platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore):
(WebCore::FontPlatformData::openTypeTable): The implementation
of openTypeTable is needed for non-CG builds.
- 4:00 PM Changeset in webkit [114043] by
-
- 2 edits in trunk/LayoutTests
Image failures due to text rendering change.
Bug filed and test flagged failing.
https://bugs.webkit.org/show_bug.cgi?id=83826
Unreviewed.
- platform/chromium/test_expectations.txt:
- 3:28 PM Changeset in webkit [114042] by
-
- 31 edits in trunk
[Qt] Fix WebKit1 build with V8
https://bugs.webkit.org/show_bug.cgi?id=83322
Reviewed by Adam Barth.
Source/JavaScriptCore:
- yarr/yarr.pri:
Source/WebCore:
Make it possible to build WebKit1 with v8.
WebKit2 is not covered yet so it need to be disabled.
To build webkit with --v8 one need a qtjsbackend with
an up-to-date copy of v8. Thanks to Peter Varga such
a public repository is available on gitorious:
https://qt.gitorious.org/~stampho/qt/stamphos-qtjsbackend.
This patch contains some build fix with !ENABLE(INSPECTOR)
from it's previous version. These are not necessary now
but I kept them because they makes sense.
No change in behaviour so no new tests.
- DerivedSources.pri:
- Target.pri:
- WebCore.pri:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptControllerQt.cpp:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):
- bindings/v8/ScriptState.cpp:
(WebCore::evalEnabled):
(WebCore::setEvalEnabled):
- bindings/v8/V8Binding.cpp:
(WebCore):
- bindings/v8/V8Binding.h:
(V8BindingPerIsolateData):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8GCForContextDispose.cpp:
(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
- config.h:
- editing/TextIterator.cpp:
- html/MediaFragmentURIParser.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/qt/PlatformSupportQt.cpp:
(WebCore::PlatformSupport::popupsAllowed):
Source/WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
- WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):
- WebCoreSupport/InitWebCoreQt.cpp:
Source/WTF:
- wtf/StdLibExtras.h:
(WTF):
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/features.prf:
- 3:19 PM Changeset in webkit [114041] by
-
- 3 edits in trunk/Source/WebCore
IndexedDB: Refactor cursor iteration to remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=83302
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.
No new tests, no behavior changes.
- Modules/indexeddb/IDBBackingStore.h:
(Cursor):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
- 2:54 PM Changeset in webkit [114040] by
-
- 2 edits in trunk/LayoutTests
More rebaselining.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- 2:39 PM Changeset in webkit [114039] by
-
- 4 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=83821
Move dfg repatching properties of structure stub info into a union
Reviewed by Oliver Hunt.
We want to be able to have similar properties for the baseline JIT, some restructuring to prepare for this.
- bytecode/StructureStubInfo.h:
(StructureStubInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- 2:38 PM Changeset in webkit [114038] by
-
- 2 edits in trunk/Source/JavaScriptCore
Delete a bunch of unused, copy & pasted values in JIT.h
https://bugs.webkit.org/show_bug.cgi?id=83822
Reviewed by Oliver Hunt.
The only architecture we support the JSVALUE64 JIT on is x86-64, all the patch offsets for other architectures are just nonsense.
- jit/JIT.h:
(JIT):
- 2:19 PM Changeset in webkit [114037] by
-
- 7 edits3 adds in trunk/LayoutTests
[Chromium] Flaky svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=83820
Unreviewed Chromium test expectations.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:15 PM Changeset in webkit [114036] by
-
- 39 edits4 copies3 adds in trunk
Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=
Reviewed by Adam Barth.
Attempt to reland r113931. Now with more updated test expectations.
With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist
For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.
For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.
Source/WebCore:
Test: fast/dom/NodeList/node-list-array-class.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.
- bindings/scripts/IDLAttributes.txt:: Adds new attribute: ArrayClass.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the[[Prototype]].
- bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- dom/NodeList.idl:
LayoutTests:
- fast/dom/HTMLSelectElement/named-options-expected.txt:
- fast/dom/HTMLSelectElement/script-tests/named-options.js:
- fast/dom/NodeList/node-list-array-class-expected.txt: Added.
- fast/dom/NodeList/node-list-array-class.html: Added.
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
- fast/dom/everything-to-string-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/js/recursion-limit-equal-expected.txt:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-dir-expected.txt:
- inspector/console/console-format-collections-expected.txt:
- jquery/traversing-expected.txt:
- platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
- platform/chromium/fast/dom/everything-to-string-expected.txt: Copied from LayoutTests/fast/dom/everything-to-string-expected.txt.
- platform/chromium/inspector/console/command-line-api-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-expected.txt.
- platform/chromium/inspector/console/console-dir-expected.txt:
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- platform/chromium/jquery/traversing-expected.txt: Copied from LayoutTests/jquery/traversing-expected.txt.
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 2:14 PM Changeset in webkit [114035] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Web Inspector cookie expiry is showing the wrong date.
https://bugs.webkit.org/show_bug.cgi?id=83814
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.
The internal representation for expiry is seconds, we need to convert it
to milliseconds by multiplying by 1000.
The value from this method doesn't get used anywhere except Web Inspector.
Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.
- platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::appendWebCoreCookie):
- 2:11 PM Changeset in webkit [114034] by
-
- 13 edits in trunk/Source/WebCore
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256
Reviewed by Kentaro Hara.
This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.
I've landed the refactoring bits of r112318 as separate changes,
so that this patch contains only the change in which map setter is called.
Binding tests have been updated with new output.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
to set up wrapper mapping and remove call to leakRef() which is handled
in V8DOMWrapper.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 2:09 PM Changeset in webkit [114033] by
-
- 3 edits5 adds1 delete in trunk/LayoutTests
chromium windows + linux svg tests failing after r65665
https://bugs.webkit.org/show_bug.cgi?id=44278
Unreviewed Chromium test expectations update.
Looks like a result of the Skia switch plus some font adjustments.
- platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
- platform/chromium-mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:06 PM Changeset in webkit [114032] by
-
- 8 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=83817
This patch modifies RenderText so that it scans all of its characters up front to
determine whether or not the simple code path can be used for measurement/rendering
of the text for the whole run.
TextRun now has an additional field that indicates that the character scan is not
required, since the entire RenderText is known to be simple. This boolean is set
when constructing the TextRun from the places that make TextRuns from RenderTexts.
The character scan has been refactored into a static Font method so that it can be
called by RenderText. The scan of individual TextRuns is also done using the same method
so that the code is shared.
Reviewed by Dan Bernstein.
- platform/graphics/Font.cpp:
(WebCore::Font::codePath):
(WebCore::Font::characterRangeCodePath):
- platform/graphics/Font.h:
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::characterScanForCodePath):
(WebCore::TextRun::setCharacterScanForCodePath):
(TextRun):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::textWidth):
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::width):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
(WebCore):
- rendering/RenderText.h:
(RenderText):
(WebCore::RenderText::canUseSimpleFontCodePath):
- 1:56 PM Changeset in webkit [114031] by
-
- 15 edits in trunk/Source/WebCore
Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83803
Reviewed by Eric Seidel.
AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
implementing it in AccessibilityObject.
Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
accessibility code.
No new tests. No change in behavior.
- accessibility/AccessibilityMenuListOption.h:
(WebCore::AccessibilityMenuListOption::canHaveChildren):
- accessibility/AccessibilityMenuListPopup.h:
(WebCore::AccessibilityMenuListPopup::elementRect):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::pixelSnappedSize):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilitySlider.cpp:
(WebCore):
- accessibility/AccessibilitySlider.h:
(AccessibilitySliderThumb):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore):
- accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore):
- accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
- accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentGetExtents):
- accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageSize):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 1:55 PM Changeset in webkit [114030] by
-
- 4 edits4 adds1 delete in trunk/LayoutTests
some clip paths broken on chromium win/linux after r65729
https://bugs.webkit.org/show_bug.cgi?id=44341
Unreviewed Chromium expectations update.
These tests are now matching the mac results, and the new results on
the bots look correct. Some changes are just font metric changes.
- platform/chromium-linux/svg/clip-path/clip-path-childs-clipped-expected.png:
- platform/chromium-linux/svg/clip-path/clip-path-pixelation-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
- platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
- platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.png:
- platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.png: Added.
- platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:42 PM Changeset in webkit [114029] by
-
- 13 edits in branches/subpixellayout/Source/WebCore/accessibility
Remove unnecessary virtual designation for AccessibilityObject::size, add pixelSnappedSize, and use it in platform code.
- 1:35 PM Changeset in webkit [114028] by
-
- 2 edits in trunk/Source/WTF
ThreadingWin: Mutex::unlock() can be "over-unlocked".
https://bugs.webkit.org/show_bug.cgi?id=83725
Reviewed by David Levin.
In order to support the behavior of pthread_mutex_trylock(), the Windows Mutex class includes
a recursion counter which is incremented in Mutex::lock(), decremented in Mutex::unlock(),
and checked in Mutex::tryLock(). If the mutex is "over-unlocked", the counter wraps around to
MAX_INT, and subsequent calls to Mutex::trylock() will fail. Raise an ASSERT in this situation
so the "over-unlock" will be caught.
- wtf/ThreadingWin.cpp:
(WTF::Mutex::unlock): ASSERT if unlocking a non-locked mutex.
- 1:31 PM Changeset in webkit [114027] by
-
- 3 edits4 adds in trunk/LayoutTests
[Chromium] filters/feDisplacementMap.svg crossHatch pattern improperly drawn
https://bugs.webkit.org/show_bug.cgi?id=83810
Unreviewed Chromium expectations update.
These test results match Firefox, and I see no reason to believe they
are incorrect.
- platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Added.
- platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Added.
- platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Added.
- platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Added.
- platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
- platform/chromium/test_expectations.txt:
- 1:29 PM Changeset in webkit [114026] by
-
- 7 edits1 add in trunk
Update HTMLMediaElement's index of cues when TextTrack.mode changes to
and from TextTrack::DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=83377
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Instead updated media/track/track-mode.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):
Add the track's cues to the index when the mode changes to HIDDEN or SHOWING.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::textTrackRemoveCues):
Fix a copy pasta error.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode):
Remove the track's cues from the index when the mode changes to DISABLED.
LayoutTests:
- media/track/track-mode-expected.txt:
- media/track/track-mode.html:
- 1:26 PM Changeset in webkit [114025] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rolling out r114005.
http://trac.webkit.org/changeset/114005
https://bugs.webkit.org/show_bug.cgi?id=83809
This patch may have unveiled other bugs, need to investigate
(Requested by vrk on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- platform/chromium/test_expectations.txt:
- 1:23 PM Changeset in webkit [114024] by
-
- 2 edits in trunk/Source/WebCore
Allow certain Char events in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=83330
Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-04-12
Reviewed by Alexey Proskuryakov.
- page/EventHandler.cpp:
(WebCore::EventHandler::isKeyEventAllowedInFullScreen):
- 1:04 PM Changeset in webkit [114023] by
-
- 2 edits1 add in trunk/LayoutTests
Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509
Unreviewed Chromium expectations update (after all this time).
- platform/chromium-win/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:01 PM Changeset in webkit [114022] by
-
- 8 edits3 adds in trunk
IndexedDB: Attributes for a cursor "run past the end" should be undefined.
https://bugs.webkit.org/show_bug.cgi?id=83492
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.
Source/WebCore:
This brings us up to spec with respect to when it's ok to call
cursor.continue() and the various behaviors around it:
If you call it more than once, continue() throws an exception.
The values of key/primaryKey/value are consistent, whether or not
continue has been called, meaning that if continue() results in
data being loaded from the backing store, that data does not
affect the cursor until the success callback has completed.
Calls to update() and delete() can happen before continue(), but
not afterwards.
Test: storage/indexeddb/cursor-continue-validity.html
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGotValue):
(WebCore):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
LayoutTests:
- storage/indexeddb/cursor-continue-validity-expected.txt: Added.
- storage/indexeddb/cursor-continue-validity.html: Added.
- storage/indexeddb/resources/cursor-continue-validity.js: Added.
- storage/indexeddb/resources/mozilla/cursors-expected.txt:
- storage/indexeddb/resources/shared.js:
- 12:58 PM Changeset in webkit [114021] by
-
- 11 edits2 adds in trunk
Media engine should not be told to prepare for playback if media loading is not allowed
https://bugs.webkit.org/show_bug.cgi?id=83620
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/video-load-require-user-gesture.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load): Early return if user gesture requirement is not met.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture): Moved the method here from
Internals to be with the rest of the Internals methods that expose preferences.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp: Moved setMediaPlaybackRequiresUserGesture to InternalSettings.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/video-load-require-user-gesture-expected.txt: Added.
- media/video-load-require-user-gesture.html: Added.
- media/video-play-require-user-gesture.html: Update for move of setMediaPlaybackRequiresUserGesture
from window.internals to window.internals.settings.
- 12:54 PM Changeset in webkit [114020] by
-
- 21 edits2 adds in trunk
[CSS Exclusions] Add flag to enable / disable exclusions at runtime
https://bugs.webkit.org/show_bug.cgi?id=83313
Patch by Bear Travis <betravis@adobe.com> on 2012-04-12
Reviewed by Ryosuke Niwa.
.:
Adding the GTK symbols
- Source/autotools/symbols.filter:
Source/WebCore:
Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
The CSS parser will not accept values for the exclusions properties when
cssExclusionsEnabled is false. However, you will still get the default value
in the computed style.
Test: fast/exclusions/css-exclusions-disabled.html
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(RuntimeEnabledFeatures):
- css/CSSParser.cpp:
(WebCore::isSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit2:
Adding windows symbols
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Adding a test to cover CSS parsing, which is the only piece of exclusions
work in place. Updating other exclusions test to explicitly enable the
feature.
- fast/exclusions/css-exclusions-disabled-expected.txt: Added.
- fast/exclusions/css-exclusions-disabled.html: Added.
- fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
- fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
- fast/exclusions/script-tests/wrap-flow-parsing.js:
- fast/exclusions/script-tests/wrap-margin-parsing.js:
- fast/exclusions/script-tests/wrap-padding-parsing.js:
- fast/exclusions/script-tests/wrap-parsing.js:
- fast/exclusions/script-tests/wrap-through-parsing.js:
- 12:50 PM Changeset in webkit [114019] by
-
- 3 edits2 adds2 deletes in trunk/LayoutTests
[Chromium] Layout test svg/text/font-size-below-point-five.svg needs rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83806
Unreviewed Chromium test expectations update.
- platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
- platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.png: Added.
- platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/text/font-size-below-point-five-expected.png: Removed.
- platform/chromium-mac/svg/text/font-size-below-point-five-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:35 PM Changeset in webkit [114018] by
-
- 2 edits in trunk/LayoutTests
Add fast/frames/flattening/frameset-flattening-simple.html to the Skipped list.
- platform/mac/Skipped:
- 12:27 PM Changeset in webkit [114017] by
-
- 2 edits1 add in trunk/LayoutTests
[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717
Unreviewed Chromium test expectations update.
Second attempt, now leaving some tests as flakey.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:27 PM Changeset in webkit [114016] by
-
- 5 edits in trunk/Source/WebCore
Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055
Reviewed by Adam Barth.
No new tests, no functionality change intended.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from
FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.
(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url
should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since
DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.
(WebCore::FrameLoader::loadArchive):
- loader/FrameLoader.h:
- 12:23 PM Changeset in webkit [114015] by
-
- 3 edits in trunk/LayoutTests
Update test results after r113945.
- fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 12:19 PM Changeset in webkit [114014] by
-
- 2 edits in trunk/Tools
test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
https://bugs.webkit.org/show_bug.cgi?id=83583
Reviewed by Philippe Normand
Updated the unit test to ignore the hours and minutes of the
localtime for time(0), since we can't easily guarantee which
timezone we're in or what timezone rules were in effect on
1/1/1970; this should be mostly fine since we can trust that
time.localtime() will work, although there is the possibility
that we'll screw up the time formatting of which field is the
hours and which is the minutes.
- Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
- 12:16 PM Changeset in webkit [114013] by
-
- 4 edits in trunk
Source/WebCore: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
checking for duplicates in ObjectPool when serializing.
Reviewed by Dean Jackson.
Covered by existing tests.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::checkForDuplicate):
LayoutTests: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Bug fixed, unskipping tests.
Reviewed by Dean Jackson.
- platform/mac/Skipped:
- 12:07 PM Changeset in webkit [114012] by
-
- 8 edits in trunk
Don't modify shared style objects in RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=83736
Patch by David Barton <Dave Barton> on 2012-04-12
Reviewed by Julien Chaffraix.
Source/WebCore:
To leave room for the radical sign and absolutely positioned "index", we switch to using
intrinsic padding. RenderMathMLRoot.cpp is also cleaned up and prepared for merging with
RenderMathMLSquareRoot.cpp. The base and index are no longer wrapped in extra renderers,
and the child renderers are now in the same order as in the DOM. Some padding/placement
terms are unified and debugged.
Tested by existing tests in roots.xhtml.
- css/mathml.css:
(mroot):
(mroot > * + *):
(mroot > * + mrow, mroot > * + mfenced):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore):
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):
- rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
- rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore):
(WebCore::RenderMathMLSquareRoot::paint):
LayoutTests:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- 12:03 PM Changeset in webkit [114011] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web Inspector messages incorrectly converted
https://bugs.webkit.org/show_bug.cgi?id=83796
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.
The JSON sent over from the remote Web Inspector front-end was being
mis interpreted as ISO-8859-1. This caused all non ascii characters to
become garbled when using the String constructor, so we use fromtUTF8 instead.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
- 11:57 AM Changeset in webkit [114010] by
-
- 4 edits in trunk/LayoutTests
Typos in LayoutTests/http/tests/security/xssAuditor/script-tag-inside-svg-tag*.html
https://bugs.webkit.org/show_bug.cgi?id=83794
Reviewed by Adam Barth.
Several changes needed to make the XSS in these test cases fire against actual
vulnerable browsers. The tests were still valid, but it is more helpful to see
the XSS pop up.
- http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
- 11:54 AM Changeset in webkit [114009] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove unused WebKit1 SPI for suppressing incremental rendering.
https://bugs.webkit.org/show_bug.cgi?id=83801
Reviewed by Simon Fraser.
This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).
- WebView/WebPreferences.mm:
- WebView/WebPreferencesPrivate.h:
- 11:51 AM Changeset in webkit [114008] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations.
- platform/gtk/test_expectations.txt: Flaky tests list update.
- 11:32 AM Changeset in webkit [114007] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- page/mac/SettingsMac.mm:
(WebCore::defaultFontFamilyDictionary):
- 11:28 AM Changeset in webkit [114006] by
-
- 5 edits in trunk/Source/WebCore
Remove style sheet argument from StyleRuleImport constructor
https://bugs.webkit.org/show_bug.cgi?id=83740
Reviewed by Andreas Kling.
The style sheet is set when the rule is added to one. The parser does not need to know about it.
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::StyleRuleImport):
- css/CSSImportRule.h:
(StyleRuleImport):
(WebCore::StyleRuleImport::setParentStyleSheet):
- css/CSSParser.cpp:
(WebCore::CSSParser::createImportRule):
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
- 11:24 AM Changeset in webkit [114005] by
-
- 4 edits in trunk/LayoutTests
Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues
https://bugs.webkit.org/show_bug.cgi?id=83505
The test had an arbitrary performance expectation to start playing in 200 ms,
which caused the layout test to fail for Chromium when the Chromium's
audio buffer size increased.
This CL removes that expectation and fixes some HTML and grammar mistakes.
Reviewed by Eric Carlson.
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- platform/chromium/test_expectations.txt:
- 11:11 AM Changeset in webkit [114004] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r113900): In nightly builds, Safari Webpage Preview Fetcher crashes in Settings::initializeDefaultFontFamilies() due to uncaught exception (sandbox preventing access to fonts plist)
https://bugs.webkit.org/show_bug.cgi?id=83792
<rdar://problem/11234002>
Reviewed by Dan Bernstein.
- page/mac/SettingsMac.mm: (WebCore::defaultFontFamilyDictionary): Bail out without setting font preferences if the process doesn't have read access to WebCore.framework.
- 11:10 AM Changeset in webkit [114003] by
-
- 2 edits in trunk/Tools
Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711
Forgot to add EFL Linux Debug to scheduler.
Patch by Dominik Rottsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:49 AM PrefixedAPIs edited by
- Pointer Lock spec link (diff)
- 10:47 AM Changeset in webkit [114002] by
-
- 3 edits1 add in trunk/Source/WebCore
[BlackBerry] Set up default fonts for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=83775
Reviewed by Antonio Gomes.
- PlatformBlackBerry.cmake:
- page/Settings.cpp:
(WebCore):
- page/blackberry/SettingsBlackBerry.cpp: Added.
(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):
- 10:23 AM Changeset in webkit [114001] by
-
- 9 edits1 add in trunk/Source/WebCore
Implement Dictionary.h on mac (83472)
https://bugs.webkit.org/show_bug.cgi?id=83472
<rdar://problem/11209766>
Reviewed by Kentaro Hara.
A difference between Dictionary and JSDictionary makes it difficult to merge the two together and avoid
creating a confusing API. The boolean returned by Dictionary::get() represents whether the
property was found. The boolean returned by JSDictionary::tryGetProperty() represents whether an
exception was thrown.
- WebCore.xcodeproj/project.pbxproj: Add Dictionary.h and Dictionary.cpp.
- bindings/js/Dictionary.cpp: Added.
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::get):
- bindings/js/Dictionary.h: Leverage JSDictionary's functionality to obtain the data.
(WebCore::Dictionary::isObject): Mark an unimplemented.
(WebCore::Dictionary::isUndefinedOrNull): Mark an unimplemented.
(WebCore::Dictionary::getWithUndefinedOrNullCheck): Mark an unimplemented.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::isValid):
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
(WebCore::JSDictionary::get): Similar to tryGetProperty(), but returns true if the
property was found, converting the value succeeded and the out parameter "result" was set.
(WebCore::JSDictionary::tryGetPropertyAndResult): Refactor tryGetProperty() to return the enum directly.
Change bindings scripts to use Dictionary constructor.
- bindings/js/IDBBindingUtilities.cpp: Remove createDictionaryFromValue().
- bindings/js/IDBBindingUtilities.h: Remove createDictionaryFromValue().
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative): Update to remove IDBBindingUtilities.h dependency, and use Dictionary constructor.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Update expected generated output.
- 10:16 AM Changeset in webkit [114000] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix threaded compositor HUD crash
https://bugs.webkit.org/show_bug.cgi?id=83778
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-12
Reviewed by James Robinson.
Don't try to read font metrics in threaded compositing mode, since we
currently can't render HUD text with the threaded compositor.
HUD is not testable in WebKit.
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::drawHudContents):
- 10:09 AM Changeset in webkit [113999] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations.
- platform/gtk/test_expectations.txt: Marking 2 media tests flaky.
- 10:02 AM Changeset in webkit [113998] by
-
- 1 edit1 add7 deletes in trunk/LayoutTests
[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83713
Patch by David Alcala <dalcala@adobe.com> on 2012-04-12
Reviewed by Dirk Schulze.
- fast/regions/region-overflow-break-expected.html: Added.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-break-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-break-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
- platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
- 10:02 AM Changeset in webkit [113997] by
-
- 2 edits in trunk/Tools
Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.
Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
- BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
- 9:40 AM Changeset in webkit [113996] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: zoom timeline frame on dblclick on the frame bar
https://bugs.webkit.org/show_bug.cgi?id=83741
Reviewed by Pavel Feldman.
- put timeline frame bars into a container, so we can have one listener;
- upon dblclick, find the frame, get its window coordinates and set overview selection window accordingly.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame): Get frame coordinates, set overview window.
(WebInspector.TimelineVerticalOverview.prototype.update): Maintain framesPerBar as a member for reuse in getFramePosition()
(WebInspector.TimelineVerticalOverview.prototype.framePosition): Map frame to screen positions.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): Factored out barNumberToScreenPosition()
(WebInspector.TimelineVerticalOverview.prototype._barNumberToScreenPosition):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes): Drive-by style fix.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateFrames): Put frames into a containing div.
(WebInspector.TimelinePanel.prototype._onFrameDoubleClicked): Zoom to frame upon double click.
- inspector/front-end/timelinePanel.css:
(.timeline-frame-container):
- 9:31 AM Changeset in webkit [113995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations post-Skipped-migration update #2.
- platform/gtk/test_expectations.txt:
- 9:29 AM Changeset in webkit [113994] by
-
- 9 edits in trunk
Web Inspector: show wall time frame duration on the vertical overview
https://bugs.webkit.org/show_bug.cgi?id=83718
Reviewed by Pavel Feldman.
Source/WebCore:
- show frame duration as a contour of the frame bar in vertical overview;
- when scaling, normalize bar to a max of 3 * median frame duration, so too long frames do not dwarf the majority;
- add Array.prototype.qselect() for the above;
- factor our partition algorithm onto Array.prototype for better reuse;
- inspector/front-end/PartialQuickSort.js: factor out partition()
(Object.defineProperty.):
(Object.defineProperty):
- inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._flushFrame): add frame.duration.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset): this._longestFrameTime is gone.
(WebInspector.TimelineVerticalOverview.prototype.update): ditto.
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames): return frames to display, not just their timeByCatogory.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): use entire frames, not timeByCategory.
(WebInspector.TimelineVerticalOverview.prototype._renderBar): ditto.
- inspector/front-end/externs.js: Added annotations for partition() and qselect()
(Array.prototype.partition):
(Array.prototype.qselect):
- inspector/front-end/utilities.js:
(.):
LayoutTests:
- inspector/utilities-expected.txt:
- inspector/utilities.html: added results for Array.prototype.qselect()
- 9:20 AM Changeset in webkit [113993] by
-
- 29 edits in trunk/LayoutTests
[Qt] More unreviewed gardening after r113968.
Set the right expected results this time.
- platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt:
- platform/qt-5.0/editing/inserting/5549929-2-expected.txt:
- platform/qt-5.0/editing/inserting/5549929-3-expected.txt:
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt:
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt:
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt:
- platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt:
- platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt:
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt:
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt:
- platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
- platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/qt-5.0/fast/css/word-space-extra-expected.txt:
- platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
- platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
- platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
- platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
- platform/qt-5.0/svg/batik/text/textPosition-expected.txt:
- platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- 9:05 AM Changeset in webkit [113992] by
-
- 4 edits in trunk
Enable the fullscreen API for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83757
Reviewed by Antonio Gomes.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Tools:
- Scripts/build-webkit:
- 9:04 AM Changeset in webkit [113991] by
-
- 2 edits in trunk/Source/WebCore
Optimize non-rounded double border rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=83745
Patch by David Barr <davidbarr@chromium.org> on 2012-04-12
Reviewed by Simon Fraser.
No functional change, painting optimization only.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
- 9:02 AM Changeset in webkit [113990] by
-
- 24 edits2 adds in trunk
Reduce the use of RenderLayer outside of the rendering code
https://bugs.webkit.org/show_bug.cgi?id=83728
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/layers/scrollByLines-overflow-no-layer.html
This is mostly a layering violation change. This changes reduces the number of
RenderLayer use outside rendering/ by a third but there are still numerous uses.
While auditing the different uses of RenderLayer, I found a potential crasher
and fixed it which is why we have a test case.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
(WebCore::Document::handleZeroPadding):
(WebCore::nodeFromPoint):
(WebCore::Document::prepareMouseEvent):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains):
- page/DragController.cpp:
(WebCore::elementUnderMouse):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::handleDrag):
Updated these call sites to use RenderView::hitTest.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- page/FrameView.cpp:
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
Updated these call sites to use RenderObject::isComposited().
- dom/Element.cpp:
(WebCore::Element::scrollByUnits):
Call directly RenderBox::scroll instead of calling the layer.
This actually fixes a crasher that slipped through the cracks.
- editing/visible_units.cpp:
- html/shadow/TextControlInnerElements.cpp:
- page/ContextMenuController.cpp:
- page/FocusController.cpp:
- page/Frame.cpp:
- page/GestureTapHighlighter.cpp:
- page/PrintContext.cpp:
- plugins/mac/PluginViewMac.mm:
Removed unneeded #include.
- plugins/gtk/PluginViewGtk.cpp:
- plugins/qt/PluginViewQt.cpp:
Replaced RenderLayer.h #include with RenderObject.h as
we use RenderObject::absoluteToLocal.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isComposited):
- rendering/RenderObject.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
- rendering/RenderView.h:
Added 2 new functions that pipe through the RenderLayer.
LayoutTests:
The test checks that calling scrollByUnit without a RenderLayer doesn't crash.
- fast/layers/scrollByLines-overflow-no-layer.html: Added.
- fast/layers/scrollByLines-overflow-no-layer-expected.txt: Added.
- 9:00 AM Changeset in webkit [113989] by
-
- 2 edits in trunk/Source/WebCore
font-size:0 text runs has non zero width in case of Windows Safari.
https://bugs.webkit.org/show_bug.cgi?id=83559
Patch by Pravinin D <pravind.2k4@gmail.com> on 2012-04-12
Reviewed by Dan Bernstein.
Test case already exits.
LayoutTest/fast/text/font-size-zero.html
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- 8:57 AM Changeset in webkit [113988] by
-
- 4 edits in trunk
Web Inspector: Move meta node out of nodes in snapshot serialization.
https://bugs.webkit.org/show_bug.cgi?id=83701
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-12
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
LayoutTests:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):
- 8:53 AM Changeset in webkit [113987] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766
Reviewed by Rob Buis.
PR 136593.
Re-speed up text selection. The previous patch had a merge
error causing text selection not to function. The fix
implemented removed the optimization. This fixes the error
in the original patch and removes the temporary fix.
Make style updated as suggested by Antonio Gomes.
Reviewed Internally by Gen Mak.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::regionRectListContainsPoint):
- 8:48 AM Changeset in webkit [113986] by
-
- 13 edits1 copy3 adds in trunk/LayoutTests
Unreviewed, GTK test_expectations post-Skipped-migration update.
- platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
- platform/gtk/http/tests/misc/acid2-expected.txt:
- platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
- platform/gtk/svg/hixie/perf/001-expected.txt: Added.
- platform/gtk/svg/hixie/perf/002-expected.txt: Added.
- platform/gtk/svg/hixie/perf/003-expected.txt:
- platform/gtk/svg/hixie/perf/004-expected.txt:
- platform/gtk/svg/hixie/perf/005-expected.txt:
- platform/gtk/svg/hixie/perf/006-expected.txt:
- platform/gtk/svg/hixie/perf/007-expected.txt:
- platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
- platform/gtk/svg/text/text-deco-01-b-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/gtk/test_expectations.txt:
- svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
- 8:43 AM Changeset in webkit [113985] by
-
- 6 edits7 adds in trunk/LayoutTests
[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717
Unreviewed Chromium test expectations update.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png: Modified property svn:mime-type.
- platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Modified property svn:mime-type.
- platform/chromium/test_expectations.txt:
- 8:38 AM Changeset in webkit [113984] by
-
- 2 edits in trunk/LayoutTests
More Mac rebaselines.
Unreviewed.
- platform/chromium-mac-leopard/css2.1/20110323/replaced-elements-001-expected.png:
- 8:35 AM Changeset in webkit [113983] by
-
- 8 edits1 add in trunk
[Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720
Reviewed by Noam Rosenthal.
.:
- ManualTests/nested-fixed-position.html: Added.
Source/WebCore:
Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
If it does, do not set scrollPositionDelta.
Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed position layer.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::fixedToViewport):
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::isAncestorFixedToViewport):
(WebCore):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFixedToViewport):
Source/WebKit2:
Set the fixedToViewport flag on the fixed position layers and adjust to
the new function name for setting scrollPositionDelta.
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::setLayerState):
- 8:32 AM Changeset in webkit [113982] by
-
- 2 edits37 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r113968
Since we now use QRawFont, some tests need a Qt5 specific baseline.
- platform/qt-5.0/Skipped: skipped two tests with suspicious results.
- platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt: Added.
- platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Added.
- platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
- platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Added.
- platform/qt-5.0/editing/selection/editable-html-element-expected.txt: Added.
- platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Added.
- platform/qt-5.0/fast/css/word-space-extra-expected.txt: Added.
- platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
- platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
- platform/qt-5.0/fast/table/border-collapsing/004-expected.txt: Added.
- platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt: Added.
- platform/qt-5.0/fast/text/text-letter-spacing-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Added.
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- 8:12 AM Changeset in webkit [113981] by
-
- 2 edits1 delete in trunk/LayoutTests
[GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768
Reviewed by Martin Robinson.
This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.
- platform/gtk/Skipped: Removed.
- platform/gtk/test_expectations.txt:
- 8:09 AM Changeset in webkit [113980] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Pattern matching for hexadecimal should include * as an allowable count.
https://bugs.webkit.org/show_bug.cgi?id=83779
Reviewed by Rob Buis.
Update pattern matching check to allow wildcard for number
of characters allowed.
PR 148907.
Reviewed Internally by Gen Mak.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
- 8:07 AM Changeset in webkit [113979] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaky on all platforms and add new failure mode.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 8:01 AM Changeset in webkit [113978] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline Mac expectations.
Unreviewed.
- platform/chromium-mac-leopard/fast/block/float/avoiding-float-centered-expected.png: Added.
- 7:55 AM Changeset in webkit [113977] by
-
- 2 edits in trunk/LayoutTests
Mark test as flaking on all platforms.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:55 AM Changeset in webkit [113976] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Revert the patch for 82764
https://bugs.webkit.org/show_bug.cgi?id=83767
Reviewed by Rob Buis.
Revert the patch for 82764, which is causing misfunction.
The internal commit is: 800213f5
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):
- plugins/blackberry/PluginViewPrivateBlackBerry.h:
(PluginViewPrivate):
- 7:52 AM Changeset in webkit [113975] by
-
- 2 edits in trunk/LayoutTests
[Qt]{Mac] Unreviewed, skip new failing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 7:43 AM Changeset in webkit [113974] by
-
- 23 edits in trunk/Source/WebKit2
Move viewport meta handling to the web process side
https://bugs.webkit.org/show_bug.cgi?id=83771
Reviewed by Simon Hausmann.
Instead of computing the viewport attributes on both sides,
we now do everything on the web process side, and just send
over the computed result.
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
(WebCore):
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
- UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
- UIProcess/API/gtk/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/mac/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didChangeViewportProperties):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- UIProcess/PageClient.h:
(WebCore):
(PageClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeViewportProperties):
- UIProcess/WebPageProxy.h:
(WebCore):
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::didChangeViewportProperties):
- UIProcess/qt/QtPageClient.h:
(QtPageClient):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
- UIProcess/win/WebView.h:
(WebView):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
(WebKit):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit):
(WebKit::WebPage::setViewportSize):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- 7:23 AM Changeset in webkit [113973] by
-
- 2 edits in trunk/LayoutTests
[Qt] One more unreviewed gardening after r113945 and r113961.
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- 7:21 AM Changeset in webkit [113972] by
-
- 6 edits in trunk/Source
[Chromium] Enable INPUT_TYPE_DATE
https://bugs.webkit.org/show_bug.cgi?id=83761
Reviewed by Kentaro Hara.
Source/WebCore:
- html/DateInputType.cpp:
Touch it to avoid build issues. No code changes.
- html/DateInputType.h: ditto.
- html/InputType.cpp: ditto.
Source/WebKit/chromium:
- features.gypi: Turn ENABLE_INPUT_TYPE_DATE on.
- 7:13 AM Changeset in webkit [113971] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: annotate the rest of profiler front-end for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=83781
All remaining Profiler front-end files are annotated for closure compiler.
Reviewed by Pavel Feldman.
- inspector/compile-front-end.py:
- inspector/front-end/CSSSelectorProfileView.js:
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorkerWrapper):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
- inspector/front-end/HeapSnapshotWorkerDispatcher.js:
- inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
- inspector/front-end/externs.js:
(addEventListener):
- 6:39 AM Changeset in webkit [113970] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Node Value should not get corrupt while jump over different matches in search.
https://bugs.webkit.org/show_bug.cgi?id=83758
The order in which updateEntryHide is called for cached
highlightResults is changed in "last changed first corrected" order to preserve the semantic of node.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-12
Reviewed by Pavel Feldman.
No new tests required.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
- 6:33 AM Changeset in webkit [113969] by
-
- 2 edits in trunk/Tools
[GTK] Test runner crashes without recent versions of pulseaudio-utils
https://bugs.webkit.org/show_bug.cgi?id=83774
Patch by Simon Pena <Simon Pena> on 2012-04-12
Reviewed by Philippe Normand.
Besides checking that pactl is available, check also that its output
is the expected one, and handle gracefully when it isn't, when
trying to unload pulseaudio modules.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module):
(GtkPort._restore_pulseaudio_module):
- 6:28 AM Changeset in webkit [113968] by
-
- 20 edits1 copy in trunk
[Qt] Use QRawFont when building with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78001
Source/WebCore:
Up until now, fonts in the Qt port have been handled via
the QFont API. QRawFont offers a lower-level API enabling
us to be more in line with what other WebKit ports do.
This patch proceeds to switching over to QRawFont, and
effectively use an earlier change by Andreas Kling
that remained guarded up until now.
Reviewed by Simon Hausmann.
No new tests since this is refactoring of existing
functionality.
- Target.pri:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
- platform/graphics/Font.h:
(Font):
(WebCore):
(WebCore::Font::syntheticFont): Added.
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::getQtRawFont):
(WebCore):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::rawFontForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontCustomPlatformData.h:
(FontCustomPlatformData):
- platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::operator==):
- platform/graphics/qt/FontQt.cpp:
(WebCore::fillPenForContext):
(WebCore::pathForGlyphs):
(WebCore::drawQtGlyphRun):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):
(WebCore):
(WebCore::Font::drawGlyphs):
(WebCore::Font::syntheticFont):
(WebCore::Font::rawFont):
- platform/graphics/qt/FontQt4.cpp: Copied from Source/WebCore/platform/graphics/qt/FontQt.cpp.
(WebCore):
(WebCore::fromRawDataWithoutRef):
(WebCore::setupLayout):
(WebCore::fillPenForContext):
(WebCore::strokePenForContext):
(WebCore::drawTextCommon):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::primaryFontHasGlyphForCharacter):
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::font):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
Source/WebKit/qt:
Since QFont is not used internally, we now need
to query for a QFont that should be a good
enough match.
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
(QWebPage::inputMethodQuery):
- WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
- WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
Tools:
Flip the QRawFont switch for Qt 5.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 6:22 AM Changeset in webkit [113967] by
-
- 2 edits in trunk/Source/WebCore
Calculate the cover rect of tiled backing store with the trajectory vector.
https://bugs.webkit.org/show_bug.cgi?id=83462
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.
When trajectory vector is not zero, it is able to calculate the proper cover area.
No new tests - no new functionality.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
- 6:12 AM Changeset in webkit [113966] by
-
- 18 edits1 copy7 moves in trunk
Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773
Reviewed by Yury Semikhatsky.
This step moves request-related views from being resource-based to request-based.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
- inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
(WebInspector.RequestContentView):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._showPopover):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.resource):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createContentProvider):
- inspector/front-end/RequestCookiesView.js: Renamed from Source/WebCore/inspector/front-end/ResourceCookiesView.js.
(WebInspector.RequestCookiesView):
- inspector/front-end/RequestHTMLView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHTMLView.js.
(WebInspector.RequestHTMLView):
(WebInspector.RequestHTMLView.prototype._createIFrame):
- inspector/front-end/RequestHeadersView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHeadersView.js.
(WebInspector.RequestHeadersView):
- inspector/front-end/RequestJSONView.js: Renamed from Source/WebCore/inspector/front-end/ResourceJSONView.js.
(WebInspector.RequestJSONView):
(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.parseJSONP):
- inspector/front-end/RequestPreviewView.js: Renamed from Source/WebCore/inspector/front-end/ResourcePreviewView.js.
(WebInspector.RequestPreviewView):
(WebInspector.RequestPreviewView.prototype.contentLoaded):
(WebInspector.RequestPreviewView.prototype._createPreviewView):
- inspector/front-end/RequestResponseView.js: Renamed from Source/WebCore/inspector/front-end/ResourceResponseView.js.
(WebInspector.RequestResponseView):
(WebInspector.RequestResponseView.prototype.get sourceView):
(WebInspector.RequestResponseView.prototype.contentLoaded):
- inspector/front-end/RequestTimingView.js: Renamed from Source/WebCore/inspector/front-end/ResourceTimingView.js.
(WebInspector.RequestTimingView):
(WebInspector.RequestTimingView.prototype._refresh):
- inspector/front-end/RequestView.js: Copied from Source/WebCore/inspector/front-end/NetworkRequest.js.
(WebInspector.RequestView):
(WebInspector.RequestView.prototype.hasContent):
(WebInspector.RequestView.hasTextContent):
(WebInspector.RequestView.nonSourceViewForRequest):
- inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame._canonicalMIMEType):
(WebInspector.ResourceSourceFrame._mimeTypeForResource):
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773
Reviewed by Yury Semikhatsky.
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/network/request-parameters-decoding.html:
- 5:42 AM Changeset in webkit [113965] by
-
- 4 edits1 copy in trunk/LayoutTests
[Qt] Unreviewed gardening after r113945, update platform specific expected files.
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt-5.0/Skipped: Unskip dom/prototype-inheritance-2.html and update its results.
- platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- 5:19 AM Changeset in webkit [113964] by
-
- 2 edits in trunk/Source/WebCore
2012-04-12 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix a couple of compiler annotations after r113963.
- inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
- 5:03 AM Changeset in webkit [113963] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: add closure compiler annotations for profiler code
https://bugs.webkit.org/show_bug.cgi?id=83700
Basic type annotations are added to most of the profiler front-end. Some
dead code removed.
Reviewed by Pavel Feldman.
- inspector/compile-front-end.py:
- inspector/front-end/BinarySearch.js:
(Object.defineProperty):
- inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode.prototype._restore):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
(WebInspector.BottomUpProfileDataGridTree):
- inspector/front-end/DataGrid.js:
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.DetailedHeapshotView.prototype._helpClicked.appendHelp):
(WebInspector.DetailedHeapshotView.prototype._helpClicked):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(HeapSnapshotMetainfo):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
(WebInspector.ProfileDataGridNode.prototype._populate):
(WebInspector.ProfileDataGridTree.propertyComparator):
- inspector/front-end/ProfileView.js:
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
- inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
- inspector/front-end/externs.js:
(Array.prototype.binaryIndexOf):
(Array.prototype.sortRange):
(WebInspector.CSSSelectorProfileType):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createObject):
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
- inspector/front-end/heapProfiler.css:
- 4:27 AM Component Model edited by
- (diff)
- 4:12 AM Changeset in webkit [113962] by
-
- 16 edits3 adds in trunk
[Qt][WK2] Zoom gesture with double tap crashes on iframe when main frame has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=83428
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.
Test: touchadjustment/iframe-with-mainframe-scroll-offset.html
- page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
- page/EventHandler.h:
(EventHandler):
- page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
- page/GestureTapHighlighter.cpp:
- testing/Internals.cpp:
(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
LayoutTests:
- touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset-expected.txt: Added.
- touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: Added.
- touchadjustment/zoom-basic.html:
- 4:01 AM Changeset in webkit [113961] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r113945, update platform specific expected files.
- platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
- 3:52 AM Changeset in webkit [113960] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Two canvas tests fail with QT_IMAGE_DECODER=0 setup
https://bugs.webkit.org/show_bug.cgi?id=83764
The following tests were failed after r108792:
- canvas-toDataURL-case-insensitive-mimetype.html
- toDataURL-supportedTypes.html
because supportedImageMIMETypesForEncoding wasn't filled
with MIME types in case of QT_IMAGE_DECODER=0 build setup.
Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-04-12
Reviewed by Csaba Osztrogonác.
Fixes existing tests.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- 3:32 AM Changeset in webkit [113959] by
-
- 31 edits4 deletes in trunk
Unreviewed, rolling out r113931.
http://trac.webkit.org/changeset/113931
https://bugs.webkit.org/show_bug.cgi?id=83766
broke 4 tests on JSC platforms (Requested by philn-tp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
Source/WebCore:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
- bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- dom/NodeList.idl:
LayoutTests:
- fast/dom/HTMLSelectElement/named-options-expected.txt:
- fast/dom/HTMLSelectElement/script-tests/named-options.js:
- fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
- fast/dom/NodeList/node-list-array-class.html: Removed.
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
- platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
- platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
- platform/chromium/inspector/console/console-dir-expected.txt:
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 3:26 AM Changeset in webkit [113958] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix !ENABLE(PAGE_POPUP) build
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Wrap m_pagePopup with ENABLE(PAGE_POPUP).
- 3:19 AM Changeset in webkit [113957] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, remove test expectations for worker-reload.html, as
the source of flakiness was removed in r113292.
- platform/chromium/test_expectations.txt:
- platform/mac/test_expectations.txt:
- 2:59 AM Changeset in webkit [113956] by
-
- 6 edits1 add in trunk/Source/WebKit/chromium
[Chromium] Add PagePopup implementation
https://bugs.webkit.org/show_bug.cgi?id=81081
Reviewed by Adam Barth.
Add WebPagePopupImpl class, which is an implementation of
WebCore::PagePopup interface and WebKit::WebPagePopup interface. It's a
WebWidget which has a Page object.
No new tests because this makes no behavior change yet.
- WebKit.gyp: Add WebPagePopupImpl.h.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::hasOpenedPopup): Supports the PagePopup.
(WebKit::ChromeClientImpl::openPagePopup):
just delegate to WebViewImpl::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup): ditto.
- src/WebPagePopupImpl.cpp:
(PagePopupChromeClient):
This is a light implementation of ChromeClient for the page in
WebPagePopupImpl. This is a friend of WebPagePopupImpl becase of ease of
access to its members.
(WebKit::PagePopupChromeClient::PagePopupChromeClient):
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
(WebKit::WebPagePopupImpl::~WebPagePopupImpl):
(WebKit::WebPagePopupImpl::init):
(WebKit::WebPagePopupImpl::initPage):
(WebKit::WebPagePopupImpl::size):
(WebKit::WebPagePopupImpl::animate): Calls PageWidgetDelegate::animate().
(WebKit::WebPagePopupImpl::composite):
(WebKit::WebPagePopupImpl::layout): Calls PageWidgetDelegate::layout().
(WebKit::WebPagePopupImpl::paint): Calls PageWidgetDelegate::paint().
(WebKit::WebPagePopupImpl::resize):
(WebKit::WebPagePopupImpl::handleKeyEvent):
(WebKit::WebPagePopupImpl::handleCharEvent):
(WebKit::WebPagePopupImpl::handleGestureEvent):
(WebKit::WebPagePopupImpl::handleInputEvent):
(WebKit::WebPagePopupImpl::setFocus):
(WebKit::WebPagePopupImpl::close): Delete the page, and kill itself.
(WebKit::WebPagePopupImpl::closePopup):
(WebKit::WebPagePopup::create):
- src/WebPagePopupImpl.h: Added.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Initialize m_pagePopup.
(WebKit::WebViewImpl::handleKeyEvent):
Renamed from keyEvent(). Forward key events to a PagePopup if it is open.
(WebKit::WebViewImpl::handleCharEvent):
Renamed from charEvent(). Forward char events to a PagePopup if it is open.
(WebKit::WebViewImpl::openPagePopup):
Added. Instantiate a WebPagePopupImpl, calculates a good bounding
rectangle of the page popup from the specified element rectangle,
initialize the WebPagePopupImpl, and stop caret blink.
(WebKit::WebViewImpl::closePagePopup):
Close the popup, clear m_pagePopup, and resume caret blink.
(WebKit::WebViewImpl::setFocus): Hide all the popups.
(WebKit::WebViewImpl::hidePopups): Hide the page popup too.
- src/WebViewImpl.h:
(WebKit::WebViewImpl::hasOpenedPopup): Checks the page popup too.
- 2:51 AM Changeset in webkit [113955] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt][ARM] Buildfix after r113934.
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):
- 2:01 AM Changeset in webkit [113954] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r113885.
- platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
- 1:51 AM Changeset in webkit [113953] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstreaming BlackBerry-specific changes to PluginView -- remove unused functions
https://bugs.webkit.org/show_bug.cgi?id=83756
Reviewed by George Staikos.
PluginView::halt(), PluginView::restart() have been removed from
upstreaming code, should remove them from BlackBerry porting also.
- plugins/blackberry/PluginViewBlackBerry.cpp:
- 1:50 AM Changeset in webkit [113952] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreveiwed gardening. Skip the failing reftest.
- platform/qt/Skipped: skip fast/workers/worker-multi-startup.html
- 1:49 AM Changeset in webkit [113951] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] The size of glyphStorage should be passed to substituteWithVerticalGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=83751
Reviewed by Kent Tamura.
The last argument of substituteWithVerticalGlyphs() should be
the size of |glyphStorage|.
No new tests because we can't test the fix by layout tests.
I confirmed the fix with ASAN.
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
- 1:37 AM Changeset in webkit [113950] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] We shouldn't set empty Content-Length & Content-Type to a request's headers.
https://bugs.webkit.org/show_bug.cgi?id=83349
When there is a redirection for a POST request, we change POST to GET and set
Content-Length/Content-Type to empty strings.
We should remove these headers instead of adding empty strings.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-12
Reviewed by George Staikos.
No new tests. Refactor.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleRedirect):
- platform/network/blackberry/ResourceRequest.h:
(ResourceRequest):
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore):
(WebCore::ResourceRequest::clearHTTPContentType):
- 1:31 AM Changeset in webkit [113949] by
-
- 2 edits in trunk/Source/WebCore
[Qt] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83746
Reviewed by Simon Hausmann.
Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
since that is a given.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::toDataURL):
- 1:22 AM Changeset in webkit [113948] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
[Chromium] Move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate
https://bugs.webkit.org/show_bug.cgi?id=83750
Reviewed by Adam Barth.
In order to share code in WebViewImpl and the incoming WebPagePopupImpl,
we move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate.
PageWidgetDelegate is a set of static functions because we can't use
virtual inheritance in this case and we don't want to move WebView's
data members to another class.
No new tests. Just refactoring.
- WebKit.gyp: Add PageWidgetDelegate.{cpp,h} and WebPagePopupImpl.h.
- src/PageWidgetDelegate.cpp: Added.
(WebKit::mainFrameView):
(WebKit::PageWidgetDelegate::animate):
Moved from a part of WebViewImpl::animatie()
(WebKit::PageWidgetDelegate::layout):
Moved from WebViewImpl::layout() and WebFrameImpl::layout().
(WebKit::PageWidgetDelegate::paint):
Moved from WebFrameImpl::paint() and paintWithContext().
(WebKit::PageWidgetDelegate::handleInputEvent):
Moved from a part of WebViewImpl::handleInputEvent().
(WebKit::PageWidgetEventHandler::handleMouseMove):
Common implementation of an event handling.
(WebKit::PageWidgetEventHandler::handleMouseLeave): ditto.
(WebKit::PageWidgetEventHandler::handleMouseDown): ditto.
(WebKit::PageWidgetEventHandler::handleMouseUp): ditto.
(WebKit::PageWidgetEventHandler::handleMouseWheel): ditto.
(WebKit::PageWidgetEventHandler::handleTouchEvent): ditto.
- src/PageWidgetDelegate.h: Added.
- src/WebFrameImpl.cpp:
Remove layout(), paintWithContext(), and paint(). They are moved to
PageWidgetDelegate.
- src/WebFrameImpl.h:
(WebFrameImpl): Remove layout(), paintWithContext(), and paint().
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseLeave):
Renamed from mouseLeave(), use PageWidgetDelegate::handleMouseLeave().
(WebKit::WebViewImpl::handleMouseDown):
Renamed from mouseDown(), use PageWidgetDelegate::handleMouseDown().
(WebKit::WebViewImpl::handleMouseUp):
Renamed from mouseUp(), use PageWidgetDelegate::handleMouseUp().
(WebKit::WebViewImpl::scrollBy): Calls renamed handleMouseWheel().
(WebKit::WebViewImpl::handleGestureEvent): Renamed from gestureEvent().
(WebKit::WebViewImpl::handleKeyEvent): Renamed from keyEvent().
(WebKit::WebViewImpl::handleCharEvent): Renamed from charEvent().
(WebKit::WebViewImpl::updateAnimations): Uses PageWidgetDelegate::animate().
(WebKit::WebViewImpl::layout): Uses PageWidgetDelegate::layout().
(WebKit::WebViewImpl::paint): Uses PageWidgetDelegate::paint().
(WebKit::WebViewImpl::handleInputEvent): Uses PageWidgetDelegate::handleInputEvent().
- src/WebViewImpl.h:
- 1:09 AM Changeset in webkit [113947] by
-
- 10 edits in trunk/Source/WebKit/chromium
[chromium] Fix Windows compiler warnings in webkit_unit_test target
https://bugs.webkit.org/show_bug.cgi?id=83732
Reviewed by Kent Tamura.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
- tests/CCQuadCullerTest.cpp:
(WebCore::TEST):
- tests/FloatQuadTest.cpp:
(WebCore::TEST):
- tests/ScrollAnimatorNoneTest.cpp:
(TEST_F):
- tests/TreeSynchronizerTest.cpp:
(WebKitTests::TEST):
- tests/WebLayerTest.cpp:
- 12:08 AM Changeset in webkit [113946] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r113945.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
